@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 3 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Class Likes |
@@ -108,8 +109,9 @@ discard block |
||
108 | 109 | $this->_extra = isset($_GET['extra']) ? $_GET['extra'] : false; |
109 | 110 | |
110 | 111 | // We do not want to output debug information here. |
111 | - if ($this->_js) |
|
112 | - $db_show_debug = false; |
|
112 | + if ($this->_js) { |
|
113 | + $db_show_debug = false; |
|
114 | + } |
|
113 | 115 | } |
114 | 116 | |
115 | 117 | /** |
@@ -143,8 +145,9 @@ discard block |
||
143 | 145 | $call = $this->_sa; |
144 | 146 | |
145 | 147 | // Guest can only view likes. |
146 | - if ($call != 'view') |
|
147 | - is_not_guest(); |
|
148 | + if ($call != 'view') { |
|
149 | + is_not_guest(); |
|
150 | + } |
|
148 | 151 | |
149 | 152 | checkSession('get'); |
150 | 153 | |
@@ -182,15 +185,17 @@ discard block |
||
182 | 185 | global $smcFunc, $modSettings; |
183 | 186 | |
184 | 187 | // This feature is currently disable. |
185 | - if (empty($modSettings['enable_likes'])) |
|
186 | - return $this->_error = 'like_disable'; |
|
188 | + if (empty($modSettings['enable_likes'])) { |
|
189 | + return $this->_error = 'like_disable'; |
|
190 | + } |
|
187 | 191 | |
188 | 192 | // Zerothly, they did indicate some kind of content to like, right? |
189 | 193 | preg_match('~^([a-z0-9\-\_]{1,6})~i', $this->_type, $matches); |
190 | 194 | $this->_type = isset($matches[1]) ? $matches[1] : ''; |
191 | 195 | |
192 | - if ($this->_type == '' || $this->_content <= 0) |
|
193 | - return $this->_error = 'cannot_'; |
|
196 | + if ($this->_type == '' || $this->_content <= 0) { |
|
197 | + return $this->_error = 'cannot_'; |
|
198 | + } |
|
194 | 199 | |
195 | 200 | // First we need to verify if the user can see the type of content or not. This is set up to be extensible, |
196 | 201 | // so we'll check for the one type we do know about, and if it's not that, we'll defer to any hooks. |
@@ -209,12 +214,14 @@ discard block |
||
209 | 214 | 'msg' => $this->_content, |
210 | 215 | ) |
211 | 216 | ); |
212 | - if ($smcFunc['db_num_rows']($request) == 1) |
|
213 | - list ($this->_idTopic, $topicOwner) = $smcFunc['db_fetch_row']($request); |
|
217 | + if ($smcFunc['db_num_rows']($request) == 1) { |
|
218 | + list ($this->_idTopic, $topicOwner) = $smcFunc['db_fetch_row']($request); |
|
219 | + } |
|
214 | 220 | |
215 | 221 | $smcFunc['db_free_result']($request); |
216 | - if (empty($this->_idTopic)) |
|
217 | - return $this->_error = 'cannot_'; |
|
222 | + if (empty($this->_idTopic)) { |
|
223 | + return $this->_error = 'cannot_'; |
|
224 | + } |
|
218 | 225 | |
219 | 226 | // So we know what topic it's in and more importantly we know the user can see it. |
220 | 227 | // If we're not viewing, we need some info set up. |
@@ -224,9 +231,7 @@ discard block |
||
224 | 231 | $this->_validLikes['can_see'] = allowedTo('likes_view') ? true : 'cannot_view_likes'; |
225 | 232 | |
226 | 233 | $this->_validLikes['can_like'] = ($this->_user['id'] == $topicOwner ? 'cannot_like_content' : (allowedTo('likes_like') ? true : 'cannot_like_content')); |
227 | - } |
|
228 | - |
|
229 | - else |
|
234 | + } else |
|
230 | 235 | { |
231 | 236 | // Modders: This will give you whatever the user offers up in terms of liking, e.g. $this->_type=msg, $this->_content=1 |
232 | 237 | // When you hook this, check $this->_type first. If it is not something your mod worries about, return false. |
@@ -244,8 +249,9 @@ discard block |
||
244 | 249 | if ($result !== false) |
245 | 250 | { |
246 | 251 | // Match the type with what we already have. |
247 | - if (!isset($result['type']) || $result['type'] != $this->_type) |
|
248 | - return $this->_error = 'not_valid_like_type'; |
|
252 | + if (!isset($result['type']) || $result['type'] != $this->_type) { |
|
253 | + return $this->_error = 'not_valid_like_type'; |
|
254 | + } |
|
249 | 255 | |
250 | 256 | // Fill out the rest. |
251 | 257 | $this->_type = $result['type']; |
@@ -256,17 +262,20 @@ discard block |
||
256 | 262 | } |
257 | 263 | } |
258 | 264 | |
259 | - if (!$found) |
|
260 | - return $this->_error = 'cannot_'; |
|
265 | + if (!$found) { |
|
266 | + return $this->_error = 'cannot_'; |
|
267 | + } |
|
261 | 268 | } |
262 | 269 | |
263 | 270 | // Does the user can see this? |
264 | - if (isset($this->_validLikes['can_see']) && is_string($this->_validLikes['can_see'])) |
|
265 | - return $this->_error = $this->_validLikes['can_see']; |
|
271 | + if (isset($this->_validLikes['can_see']) && is_string($this->_validLikes['can_see'])) { |
|
272 | + return $this->_error = $this->_validLikes['can_see']; |
|
273 | + } |
|
266 | 274 | |
267 | 275 | // Does the user can like this? Viewing a list of likes doesn't require this permission. |
268 | - if ($this->_sa != 'view' && isset($this->_validLikes['can_like']) && is_string($this->_validLikes['can_like'])) |
|
269 | - return $this->_error = $this->_validLikes['can_like']; |
|
276 | + if ($this->_sa != 'view' && isset($this->_validLikes['can_like']) && is_string($this->_validLikes['can_like'])) { |
|
277 | + return $this->_error = $this->_validLikes['can_like']; |
|
278 | + } |
|
270 | 279 | } |
271 | 280 | |
272 | 281 | /** |
@@ -291,8 +300,9 @@ discard block |
||
291 | 300 | ); |
292 | 301 | |
293 | 302 | // Are we calling this directly? if so, set a proper data for the response. Do note that __METHOD__ returns both the class name and the function name. |
294 | - if ($this->_sa == __FUNCTION__) |
|
295 | - $this->_data = __FUNCTION__; |
|
303 | + if ($this->_sa == __FUNCTION__) { |
|
304 | + $this->_data = __FUNCTION__; |
|
305 | + } |
|
296 | 306 | } |
297 | 307 | |
298 | 308 | /** |
@@ -322,8 +332,8 @@ discard block |
||
322 | 332 | |
323 | 333 | // Add a background task to process sending alerts. |
324 | 334 | // Mod author, you can add your own background task for your own custom like event using the "integrate_issue_like" hook or your callback, both are immediately called after this. |
325 | - if ($this->_type == 'msg') |
|
326 | - $smcFunc['db_insert']('insert', |
|
335 | + if ($this->_type == 'msg') { |
|
336 | + $smcFunc['db_insert']('insert', |
|
327 | 337 | '{db_prefix}background_tasks', |
328 | 338 | array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'), |
329 | 339 | array('$sourcedir/tasks/Likes-Notify.php', 'Likes_Notify_Background', json_encode(array( |
@@ -335,10 +345,12 @@ discard block |
||
335 | 345 | )), 0), |
336 | 346 | array('id_task') |
337 | 347 | ); |
348 | + } |
|
338 | 349 | |
339 | 350 | // Are we calling this directly? if so, set a proper data for the response. Do note that __METHOD__ returns both the class name and the function name. |
340 | - if ($this->_sa == __FUNCTION__) |
|
341 | - $this->_data = __FUNCTION__; |
|
351 | + if ($this->_sa == __FUNCTION__) { |
|
352 | + $this->_data = __FUNCTION__; |
|
353 | + } |
|
342 | 354 | } |
343 | 355 | |
344 | 356 | /** |
@@ -364,8 +376,9 @@ discard block |
||
364 | 376 | $smcFunc['db_free_result']($request); |
365 | 377 | |
366 | 378 | // If you want to call this directly, fill out _data property too. |
367 | - if ($this->_sa == __FUNCTION__) |
|
368 | - $this->_data = $this->_numLikes; |
|
379 | + if ($this->_sa == __FUNCTION__) { |
|
380 | + $this->_data = $this->_numLikes; |
|
381 | + } |
|
369 | 382 | } |
370 | 383 | |
371 | 384 | /** |
@@ -378,8 +391,9 @@ discard block |
||
378 | 391 | global $smcFunc; |
379 | 392 | |
380 | 393 | // Safety first! |
381 | - if (empty($this->_type) || empty($this->_content)) |
|
382 | - return $this->_error = 'cannot_'; |
|
394 | + if (empty($this->_type) || empty($this->_content)) { |
|
395 | + return $this->_error = 'cannot_'; |
|
396 | + } |
|
383 | 397 | |
384 | 398 | // Do we already like this? |
385 | 399 | $request = $smcFunc['db_query']('', ' |
@@ -397,26 +411,28 @@ discard block |
||
397 | 411 | $this->_alreadyLiked = (bool) $smcFunc['db_num_rows']($request) != 0; |
398 | 412 | $smcFunc['db_free_result']($request); |
399 | 413 | |
400 | - if ($this->_alreadyLiked) |
|
401 | - $this->delete(); |
|
402 | - |
|
403 | - else |
|
404 | - $this->insert(); |
|
414 | + if ($this->_alreadyLiked) { |
|
415 | + $this->delete(); |
|
416 | + } else { |
|
417 | + $this->insert(); |
|
418 | + } |
|
405 | 419 | |
406 | 420 | // Now, how many people like this content now? We *could* just +1 / -1 the relevant container but that has proven to become unstable. |
407 | 421 | $this->_count(); |
408 | 422 | |
409 | 423 | // Update the likes count for messages. |
410 | - if ($this->_type == 'msg') |
|
411 | - $this->msgIssueLike(); |
|
424 | + if ($this->_type == 'msg') { |
|
425 | + $this->msgIssueLike(); |
|
426 | + } |
|
412 | 427 | |
413 | 428 | // Any callbacks? |
414 | 429 | elseif (!empty($this->_validLikes['callback'])) |
415 | 430 | { |
416 | 431 | $call = call_helper($this->_validLikes['callback'], true); |
417 | 432 | |
418 | - if (!empty($call)) |
|
419 | - call_user_func_array($call, array($this)); |
|
433 | + if (!empty($call)) { |
|
434 | + call_user_func_array($call, array($this)); |
|
435 | + } |
|
420 | 436 | } |
421 | 437 | |
422 | 438 | // Sometimes there might be other things that need updating after we do this like. |
@@ -425,8 +441,9 @@ discard block |
||
425 | 441 | // Now some clean up. This is provided here for any like handlers that want to do any cache flushing. |
426 | 442 | // This way a like handler doesn't need to explicitly declare anything in integrate_issue_like, but do so |
427 | 443 | // in integrate_valid_likes where it absolutely has to exist. |
428 | - if (!empty($this->_validLikes['flush_cache'])) |
|
429 | - cache_put_data($this->_validLikes['flush_cache'], null); |
|
444 | + if (!empty($this->_validLikes['flush_cache'])) { |
|
445 | + cache_put_data($this->_validLikes['flush_cache'], null); |
|
446 | + } |
|
430 | 447 | |
431 | 448 | // All done, start building the data to pass as response. |
432 | 449 | $this->_data = array( |
@@ -450,8 +467,9 @@ discard block |
||
450 | 467 | { |
451 | 468 | global $smcFunc; |
452 | 469 | |
453 | - if ($this->_type !== 'msg') |
|
454 | - return; |
|
470 | + if ($this->_type !== 'msg') { |
|
471 | + return; |
|
472 | + } |
|
455 | 473 | |
456 | 474 | $smcFunc['db_query']('', ' |
457 | 475 | UPDATE {db_prefix}messages |
@@ -492,8 +510,9 @@ discard block |
||
492 | 510 | 'like_type' => $this->_type, |
493 | 511 | ) |
494 | 512 | ); |
495 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
496 | - $context['likers'][$row['id_member']] = array('timestamp' => $row['like_time']); |
|
513 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
514 | + $context['likers'][$row['id_member']] = array('timestamp' => $row['like_time']); |
|
515 | + } |
|
497 | 516 | |
498 | 517 | // Now to get member data, including avatars and so on. |
499 | 518 | $members = array_keys($context['likers']); |
@@ -501,8 +520,9 @@ discard block |
||
501 | 520 | if (count($loaded) != count($members)) |
502 | 521 | { |
503 | 522 | $members = array_diff($members, $loaded); |
504 | - foreach ($members as $not_loaded) |
|
505 | - unset ($context['likers'][$not_loaded]); |
|
523 | + foreach ($members as $not_loaded) { |
|
524 | + unset ($context['likers'][$not_loaded]); |
|
525 | + } |
|
506 | 526 | } |
507 | 527 | |
508 | 528 | foreach ($context['likers'] as $liker => $dummy) |
@@ -544,12 +564,14 @@ discard block |
||
544 | 564 | global $context, $txt; |
545 | 565 | |
546 | 566 | // Don't do anything if someone else has already take care of the response. |
547 | - if (!$this->_setResponse) |
|
548 | - return; |
|
567 | + if (!$this->_setResponse) { |
|
568 | + return; |
|
569 | + } |
|
549 | 570 | |
550 | 571 | // Want a json response huh? |
551 | - if ($this->_validLikes['json']) |
|
552 | - return $this->jsonResponse(); |
|
572 | + if ($this->_validLikes['json']) { |
|
573 | + return $this->jsonResponse(); |
|
574 | + } |
|
553 | 575 | |
554 | 576 | // Set everything up for display. |
555 | 577 | loadTemplate('Likes'); |
@@ -559,8 +581,9 @@ discard block |
||
559 | 581 | if ($this->_error) |
560 | 582 | { |
561 | 583 | // If this is a generic error, set it up good. |
562 | - if ($this->_error == 'cannot_') |
|
563 | - $this->_error = $this->_sa == 'view' ? 'cannot_view_likes' : 'cannot_like_content'; |
|
584 | + if ($this->_error == 'cannot_') { |
|
585 | + $this->_error = $this->_sa == 'view' ? 'cannot_view_likes' : 'cannot_like_content'; |
|
586 | + } |
|
564 | 587 | |
565 | 588 | // Is this request coming from an ajax call? |
566 | 589 | if ($this->_js) |
@@ -570,8 +593,9 @@ discard block |
||
570 | 593 | } |
571 | 594 | |
572 | 595 | // Nope? then just do a redirect to whatever URL was provided. |
573 | - else |
|
574 | - redirectexit(!empty($this->_validLikes['redirect']) ? $this->_validLikes['redirect'] . ';error=' . $this->_error : ''); |
|
596 | + else { |
|
597 | + redirectexit(!empty($this->_validLikes['redirect']) ? $this->_validLikes['redirect'] . ';error=' . $this->_error : ''); |
|
598 | + } |
|
575 | 599 | |
576 | 600 | return; |
577 | 601 | } |
@@ -580,8 +604,9 @@ discard block |
||
580 | 604 | else |
581 | 605 | { |
582 | 606 | // Not an ajax request so send the user back to the previous location or the main page. |
583 | - if (!$this->_js) |
|
584 | - redirectexit(!empty($this->_validLikes['redirect']) ? $this->_validLikes['redirect'] : ''); |
|
607 | + if (!$this->_js) { |
|
608 | + redirectexit(!empty($this->_validLikes['redirect']) ? $this->_validLikes['redirect'] : ''); |
|
609 | + } |
|
585 | 610 | |
586 | 611 | // These fine gentlemen all share the same template. |
587 | 612 | $generic = array('delete', 'insert', '_count'); |
@@ -612,8 +637,9 @@ discard block |
||
612 | 637 | // If there is an error, send it. |
613 | 638 | if ($this->_error) |
614 | 639 | { |
615 | - if ($this->_error == 'cannot_') |
|
616 | - $this->_error = $this->_sa == 'view' ? 'cannot_view_likes' : 'cannot_like_content'; |
|
640 | + if ($this->_error == 'cannot_') { |
|
641 | + $this->_error = $this->_sa == 'view' ? 'cannot_view_likes' : 'cannot_like_content'; |
|
642 | + } |
|
617 | 643 | |
618 | 644 | $print['error'] = $this->_error; |
619 | 645 | } |
@@ -649,33 +675,36 @@ discard block |
||
649 | 675 | <body style="background-color: #444455; color: white; font-style: italic; font-family: serif;"> |
650 | 676 | <div style="margin-top: 12%; font-size: 1.1em; line-height: 1.4; text-align: center;">'; |
651 | 677 | |
652 | - if (!isset($_GET['verse']) || ($_GET['verse'] != '2:18' && $_GET['verse'] != '22:1-2')) |
|
653 | - $_GET['verse'] = '4:16'; |
|
678 | + if (!isset($_GET['verse']) || ($_GET['verse'] != '2:18' && $_GET['verse'] != '22:1-2')) { |
|
679 | + $_GET['verse'] = '4:16'; |
|
680 | + } |
|
654 | 681 | |
655 | - if ($_GET['verse'] == '2:18') |
|
656 | - echo ' |
|
682 | + if ($_GET['verse'] == '2:18') { |
|
683 | + echo ' |
|
657 | 684 | Woe, it was that his name wasn\'t <em>known</em>, that he came in mystery, and was recognized by none. And it became to be in those days <em>something</em>. Something not yet <em id="unknown" name="[Unknown]">unknown</em> to mankind. And thus what was to be known the <em>secret project</em> began into its existence. Henceforth the opposition was only <em>weary</em> and <em>fearful</em>, for now their match was at arms against them.'; |
658 | - elseif ($_GET['verse'] == '4:16') |
|
659 | - echo ' |
|
685 | + } elseif ($_GET['verse'] == '4:16') { |
|
686 | + echo ' |
|
660 | 687 | And it came to pass that the <em>unbelievers</em> dwindled in number and saw rise of many <em>proselytizers</em>, and the opposition found fear in the face of the <em>x</em> and the <em>j</em> while those who stood with the <em>something</em> grew stronger and came together. Still, this was only the <em>beginning</em>, and what lay in the future was <em id="unknown" name="[Unknown]">unknown</em> to all, even those on the right side.'; |
661 | - elseif ($_GET['verse'] == '22:1-2') |
|
662 | - echo ' |
|
688 | + } elseif ($_GET['verse'] == '22:1-2') { |
|
689 | + echo ' |
|
663 | 690 | <p>Now <em>behold</em>, that which was once the secret project was <em id="unknown" name="[Unknown]">unknown</em> no longer. Alas, it needed more than <em>only one</em>, but yet even thought otherwise. It became that the opposition <em>rumored</em> and lied, but still to no avail. Their match, though not <em>perfect</em>, had them outdone.</p> |
664 | 691 | <p style="margin: 2ex 1ex 0 1ex; font-size: 1.05em; line-height: 1.5; text-align: center;">Let it continue. <em>The end</em>.</p>'; |
692 | + } |
|
665 | 693 | |
666 | 694 | echo ' |
667 | 695 | </div> |
668 | 696 | <div style="margin-top: 2ex; font-size: 2em; text-align: right;">'; |
669 | 697 | |
670 | - if ($_GET['verse'] == '2:18') |
|
671 | - echo ' |
|
698 | + if ($_GET['verse'] == '2:18') { |
|
699 | + echo ' |
|
672 | 700 | from <span style="font-family: Georgia, serif;"><strong><a href="', $scripturl, '?action=about:unknown;verse=4:16" style="color: white; text-decoration: none; cursor: text;">The Book of Unknown</a></strong>, 2:18</span>'; |
673 | - elseif ($_GET['verse'] == '4:16') |
|
674 | - echo ' |
|
701 | + } elseif ($_GET['verse'] == '4:16') { |
|
702 | + echo ' |
|
675 | 703 | from <span style="font-family: Georgia, serif;"><strong><a href="', $scripturl, '?action=about:unknown;verse=22:1-2" style="color: white; text-decoration: none; cursor: text;">The Book of Unknown</a></strong>, 4:16</span>'; |
676 | - elseif ($_GET['verse'] == '22:1-2') |
|
677 | - echo ' |
|
704 | + } elseif ($_GET['verse'] == '22:1-2') { |
|
705 | + echo ' |
|
678 | 706 | from <span style="font-family: Georgia, serif;"><strong>The Book of Unknown</strong>, 22:1-2</span>'; |
707 | + } |
|
679 | 708 | |
680 | 709 | echo ' |
681 | 710 | </div> |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 3 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Show the list of topics in this board, along with any child boards. |
@@ -56,8 +57,9 @@ discard block |
||
56 | 57 | |
57 | 58 | $context['name'] = $board_info['name']; |
58 | 59 | $context['description'] = $board_info['description']; |
59 | - if (!empty($board_info['description'])) |
|
60 | - $context['meta_description'] = strip_tags($board_info['description']); |
|
60 | + if (!empty($board_info['description'])) { |
|
61 | + $context['meta_description'] = strip_tags($board_info['description']); |
|
62 | + } |
|
61 | 63 | |
62 | 64 | // How many topics do we have in total? |
63 | 65 | $board_info['total_topics'] = allowedTo('approve_posts') ? $board_info['num_topics'] + $board_info['unapproved_topics'] : $board_info['num_topics'] + $board_info['unapproved_user_topics']; |
@@ -73,12 +75,14 @@ discard block |
||
73 | 75 | $session_name = session_name(); |
74 | 76 | foreach ($_GET as $k => $v) |
75 | 77 | { |
76 | - if (!in_array($k, array('board', 'start', $session_name))) |
|
77 | - $context['robot_no_index'] = true; |
|
78 | + if (!in_array($k, array('board', 'start', $session_name))) { |
|
79 | + $context['robot_no_index'] = true; |
|
80 | + } |
|
78 | 81 | } |
79 | 82 | } |
80 | - if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) |
|
81 | - $context['robot_no_index'] = true; |
|
83 | + if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) { |
|
84 | + $context['robot_no_index'] = true; |
|
85 | + } |
|
82 | 86 | |
83 | 87 | // If we can view unapproved messages and there are some build up a list. |
84 | 88 | if (allowedTo('approve_posts') && ($board_info['unapproved_topics'] || $board_info['unapproved_posts'])) |
@@ -89,14 +93,16 @@ discard block |
||
89 | 93 | } |
90 | 94 | |
91 | 95 | // We only know these. |
92 | - if (isset($_REQUEST['sort']) && !in_array($_REQUEST['sort'], array('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post'))) |
|
93 | - $_REQUEST['sort'] = 'last_post'; |
|
96 | + if (isset($_REQUEST['sort']) && !in_array($_REQUEST['sort'], array('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post'))) { |
|
97 | + $_REQUEST['sort'] = 'last_post'; |
|
98 | + } |
|
94 | 99 | |
95 | 100 | // Make sure the starting place makes sense and construct the page index. |
96 | - if (isset($_REQUEST['sort'])) |
|
97 | - $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d;sort=' . $_REQUEST['sort'] . (isset($_REQUEST['desc']) ? ';desc' : ''), $_REQUEST['start'], $board_info['total_topics'], $maxindex, true); |
|
98 | - else |
|
99 | - $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d', $_REQUEST['start'], $board_info['total_topics'], $maxindex, true); |
|
101 | + if (isset($_REQUEST['sort'])) { |
|
102 | + $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d;sort=' . $_REQUEST['sort'] . (isset($_REQUEST['desc']) ? ';desc' : ''), $_REQUEST['start'], $board_info['total_topics'], $maxindex, true); |
|
103 | + } else { |
|
104 | + $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d', $_REQUEST['start'], $board_info['total_topics'], $maxindex, true); |
|
105 | + } |
|
100 | 106 | $context['start'] = &$_REQUEST['start']; |
101 | 107 | |
102 | 108 | // Set a canonical URL for this page. |
@@ -132,14 +138,16 @@ discard block |
||
132 | 138 | $context['link_moderators'] = array(); |
133 | 139 | if (!empty($board_info['moderators'])) |
134 | 140 | { |
135 | - foreach ($board_info['moderators'] as $mod) |
|
136 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
141 | + foreach ($board_info['moderators'] as $mod) { |
|
142 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
143 | + } |
|
137 | 144 | } |
138 | 145 | if (!empty($board_info['moderator_groups'])) |
139 | 146 | { |
140 | 147 | // By default just tack the moderator groups onto the end of the members |
141 | - foreach ($board_info['moderator_groups'] as $mod_group) |
|
142 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
148 | + foreach ($board_info['moderator_groups'] as $mod_group) { |
|
149 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
150 | + } |
|
143 | 151 | } |
144 | 152 | |
145 | 153 | // Now we tack the info onto the end of the linktree |
@@ -191,20 +199,24 @@ discard block |
||
191 | 199 | ); |
192 | 200 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
193 | 201 | { |
194 | - if (empty($row['id_member'])) |
|
195 | - continue; |
|
202 | + if (empty($row['id_member'])) { |
|
203 | + continue; |
|
204 | + } |
|
196 | 205 | |
197 | - if (!empty($row['online_color'])) |
|
198 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
199 | - else |
|
200 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
206 | + if (!empty($row['online_color'])) { |
|
207 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
208 | + } else { |
|
209 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
210 | + } |
|
201 | 211 | |
202 | 212 | $is_buddy = in_array($row['id_member'], $user_info['buddies']); |
203 | - if ($is_buddy) |
|
204 | - $link = '<strong>' . $link . '</strong>'; |
|
213 | + if ($is_buddy) { |
|
214 | + $link = '<strong>' . $link . '</strong>'; |
|
215 | + } |
|
205 | 216 | |
206 | - if (!empty($row['show_online']) || allowedTo('moderate_forum')) |
|
207 | - $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
217 | + if (!empty($row['show_online']) || allowedTo('moderate_forum')) { |
|
218 | + $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
219 | + } |
|
208 | 220 | // @todo why are we filling this array of data that are just counted (twice) and discarded? ??? |
209 | 221 | $context['view_members'][$row['log_time'] . $row['member_name']] = array( |
210 | 222 | 'id' => $row['id_member'], |
@@ -217,8 +229,9 @@ discard block |
||
217 | 229 | 'hidden' => empty($row['show_online']), |
218 | 230 | ); |
219 | 231 | |
220 | - if (empty($row['show_online'])) |
|
221 | - $context['view_num_hidden']++; |
|
232 | + if (empty($row['show_online'])) { |
|
233 | + $context['view_num_hidden']++; |
|
234 | + } |
|
222 | 235 | } |
223 | 236 | $context['view_num_guests'] = $smcFunc['db_num_rows']($request) - count($context['view_members']); |
224 | 237 | $smcFunc['db_free_result']($request); |
@@ -257,8 +270,9 @@ discard block |
||
257 | 270 | $context['sort_direction'] = $ascending ? 'up' : 'down'; |
258 | 271 | $txt['starter'] = $txt['started_by']; |
259 | 272 | |
260 | - foreach ($sort_methods as $key => $val) |
|
261 | - $context['topics_headers'][$key] = '<a href="' . $scripturl . '?board=' . $context['current_board'] . '.' . $context['start'] . ';sort=' . $key . ($context['sort_by'] == $key && $context['sort_direction'] == 'up' ? ';desc' : '') . '">' . $txt[$key] . ($context['sort_by'] == $key ? '<span class="sort sort_' . $context['sort_direction'] . '"></span>' : '') . '</a>'; |
|
273 | + foreach ($sort_methods as $key => $val) { |
|
274 | + $context['topics_headers'][$key] = '<a href="' . $scripturl . '?board=' . $context['current_board'] . '.' . $context['start'] . ';sort=' . $key . ($context['sort_by'] == $key && $context['sort_direction'] == 'up' ? ';desc' : '') . '">' . $txt[$key] . ($context['sort_by'] == $key ? '<span class="sort sort_' . $context['sort_direction'] . '"></span>' : '') . '</a>'; |
|
275 | + } |
|
262 | 276 | |
263 | 277 | // Calculate the fastest way to get the topics. |
264 | 278 | $start = (int) $_REQUEST['start']; |
@@ -268,14 +282,15 @@ discard block |
||
268 | 282 | $fake_ascending = true; |
269 | 283 | $maxindex = $board_info['total_topics'] < $start + $maxindex + 1 ? $board_info['total_topics'] - $start : $maxindex; |
270 | 284 | $start = $board_info['total_topics'] < $start + $maxindex + 1 ? 0 : $board_info['total_topics'] - $start - $maxindex; |
285 | + } else { |
|
286 | + $fake_ascending = false; |
|
271 | 287 | } |
272 | - else |
|
273 | - $fake_ascending = false; |
|
274 | 288 | |
275 | 289 | // Setup the default topic icons... |
276 | 290 | $context['icon_sources'] = array(); |
277 | - foreach ($context['stable_icons'] as $icon) |
|
278 | - $context['icon_sources'][$icon] = 'images_url'; |
|
291 | + foreach ($context['stable_icons'] as $icon) { |
|
292 | + $context['icon_sources'][$icon] = 'images_url'; |
|
293 | + } |
|
279 | 294 | |
280 | 295 | $topic_ids = array(); |
281 | 296 | $context['topics'] = array(); |
@@ -306,8 +321,9 @@ discard block |
||
306 | 321 | ) |
307 | 322 | ); |
308 | 323 | $topic_ids = array(); |
309 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
310 | - $topic_ids[] = $row['id_topic']; |
|
324 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
325 | + $topic_ids[] = $row['id_topic']; |
|
326 | + } |
|
311 | 327 | } |
312 | 328 | |
313 | 329 | // Grab the appropriate topic information... |
@@ -363,11 +379,13 @@ discard block |
||
363 | 379 | // Begin 'printing' the message index for current board. |
364 | 380 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
365 | 381 | { |
366 | - if ($row['id_poll'] > 0 && $modSettings['pollMode'] == '0') |
|
367 | - continue; |
|
382 | + if ($row['id_poll'] > 0 && $modSettings['pollMode'] == '0') { |
|
383 | + continue; |
|
384 | + } |
|
368 | 385 | |
369 | - if (!$pre_query) |
|
370 | - $topic_ids[] = $row['id_topic']; |
|
386 | + if (!$pre_query) { |
|
387 | + $topic_ids[] = $row['id_topic']; |
|
388 | + } |
|
371 | 389 | |
372 | 390 | // Reference the main color class. |
373 | 391 | $colorClass = 'windowbg'; |
@@ -377,8 +395,9 @@ discard block |
||
377 | 395 | { |
378 | 396 | // Limit them to $modSettings['preview_characters'] characters |
379 | 397 | $row['first_body'] = strip_tags(strtr(parse_bbc($row['first_body'], $row['first_smileys'], $row['id_first_msg']), array('<br>' => ' '))); |
380 | - if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters']) |
|
381 | - $row['first_body'] = $smcFunc['substr']($row['first_body'], 0, $modSettings['preview_characters']) . '...'; |
|
398 | + if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters']) { |
|
399 | + $row['first_body'] = $smcFunc['substr']($row['first_body'], 0, $modSettings['preview_characters']) . '...'; |
|
400 | + } |
|
382 | 401 | |
383 | 402 | // Censor the subject and message preview. |
384 | 403 | censorText($row['first_subject']); |
@@ -389,27 +408,27 @@ discard block |
||
389 | 408 | { |
390 | 409 | $row['last_subject'] = $row['first_subject']; |
391 | 410 | $row['last_body'] = $row['first_body']; |
392 | - } |
|
393 | - else |
|
411 | + } else |
|
394 | 412 | { |
395 | 413 | $row['last_body'] = strip_tags(strtr(parse_bbc($row['last_body'], $row['last_smileys'], $row['id_last_msg']), array('<br>' => ' '))); |
396 | - if ($smcFunc['strlen']($row['last_body']) > $modSettings['preview_characters']) |
|
397 | - $row['last_body'] = $smcFunc['substr']($row['last_body'], 0, $modSettings['preview_characters']) . '...'; |
|
414 | + if ($smcFunc['strlen']($row['last_body']) > $modSettings['preview_characters']) { |
|
415 | + $row['last_body'] = $smcFunc['substr']($row['last_body'], 0, $modSettings['preview_characters']) . '...'; |
|
416 | + } |
|
398 | 417 | |
399 | 418 | censorText($row['last_subject']); |
400 | 419 | censorText($row['last_body']); |
401 | 420 | } |
402 | - } |
|
403 | - else |
|
421 | + } else |
|
404 | 422 | { |
405 | 423 | $row['first_body'] = ''; |
406 | 424 | $row['last_body'] = ''; |
407 | 425 | censorText($row['first_subject']); |
408 | 426 | |
409 | - if ($row['id_first_msg'] == $row['id_last_msg']) |
|
410 | - $row['last_subject'] = $row['first_subject']; |
|
411 | - else |
|
412 | - censorText($row['last_subject']); |
|
427 | + if ($row['id_first_msg'] == $row['id_last_msg']) { |
|
428 | + $row['last_subject'] = $row['first_subject']; |
|
429 | + } else { |
|
430 | + censorText($row['last_subject']); |
|
431 | + } |
|
413 | 432 | } |
414 | 433 | |
415 | 434 | // Decide how many pages the topic should have. |
@@ -420,42 +439,50 @@ discard block |
||
420 | 439 | $pages = constructPageIndex($scripturl . '?topic=' . $row['id_topic'] . '.%1$d', $start, $row['num_replies'] + 1, $context['messages_per_page'], true, false); |
421 | 440 | |
422 | 441 | // If we can use all, show all. |
423 | - if (!empty($modSettings['enableAllMessages']) && $row['num_replies'] + 1 < $modSettings['enableAllMessages']) |
|
424 | - $pages .= ' <a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0;all">' . $txt['all'] . '</a>'; |
|
442 | + if (!empty($modSettings['enableAllMessages']) && $row['num_replies'] + 1 < $modSettings['enableAllMessages']) { |
|
443 | + $pages .= ' <a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0;all">' . $txt['all'] . '</a>'; |
|
444 | + } |
|
445 | + } else { |
|
446 | + $pages = ''; |
|
425 | 447 | } |
426 | - else |
|
427 | - $pages = ''; |
|
428 | 448 | |
429 | 449 | // We need to check the topic icons exist... |
430 | 450 | if (!empty($modSettings['messageIconChecks_enable'])) |
431 | 451 | { |
432 | - if (!isset($context['icon_sources'][$row['first_icon']])) |
|
433 | - $context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
434 | - if (!isset($context['icon_sources'][$row['last_icon']])) |
|
435 | - $context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
436 | - } |
|
437 | - else |
|
452 | + if (!isset($context['icon_sources'][$row['first_icon']])) { |
|
453 | + $context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
454 | + } |
|
455 | + if (!isset($context['icon_sources'][$row['last_icon']])) { |
|
456 | + $context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
457 | + } |
|
458 | + } else |
|
438 | 459 | { |
439 | - if (!isset($context['icon_sources'][$row['first_icon']])) |
|
440 | - $context['icon_sources'][$row['first_icon']] = 'images_url'; |
|
441 | - if (!isset($context['icon_sources'][$row['last_icon']])) |
|
442 | - $context['icon_sources'][$row['last_icon']] = 'images_url'; |
|
460 | + if (!isset($context['icon_sources'][$row['first_icon']])) { |
|
461 | + $context['icon_sources'][$row['first_icon']] = 'images_url'; |
|
462 | + } |
|
463 | + if (!isset($context['icon_sources'][$row['last_icon']])) { |
|
464 | + $context['icon_sources'][$row['last_icon']] = 'images_url'; |
|
465 | + } |
|
443 | 466 | } |
444 | 467 | |
445 | - if (!empty($board_info['recycle'])) |
|
446 | - $row['first_icon'] = 'recycled'; |
|
468 | + if (!empty($board_info['recycle'])) { |
|
469 | + $row['first_icon'] = 'recycled'; |
|
470 | + } |
|
447 | 471 | |
448 | 472 | // Is this topic pending approval, or does it have any posts pending approval? |
449 | - if ($context['can_approve_posts'] && $row['unapproved_posts']) |
|
450 | - $colorClass .= (!$row['approved'] ? ' approvetopic' : ' approvepost'); |
|
473 | + if ($context['can_approve_posts'] && $row['unapproved_posts']) { |
|
474 | + $colorClass .= (!$row['approved'] ? ' approvetopic' : ' approvepost'); |
|
475 | + } |
|
451 | 476 | |
452 | 477 | // Sticky topics should get a different color, too. |
453 | - if ($row['is_sticky']) |
|
454 | - $colorClass .= ' sticky'; |
|
478 | + if ($row['is_sticky']) { |
|
479 | + $colorClass .= ' sticky'; |
|
480 | + } |
|
455 | 481 | |
456 | 482 | // Locked topics get special treatment as well. |
457 | - if ($row['locked']) |
|
458 | - $colorClass .= ' locked'; |
|
483 | + if ($row['locked']) { |
|
484 | + $colorClass .= ' locked'; |
|
485 | + } |
|
459 | 486 | |
460 | 487 | // 'Print' the topic info. |
461 | 488 | $context['topics'][$row['id_topic']] = array_merge($row, array( |
@@ -536,8 +563,9 @@ discard block |
||
536 | 563 | $smcFunc['db_free_result']($result); |
537 | 564 | |
538 | 565 | // Fix the sequence of topics if they were retrieved in the wrong order. (for speed reasons...) |
539 | - if ($fake_ascending) |
|
540 | - $context['topics'] = array_reverse($context['topics'], true); |
|
566 | + if ($fake_ascending) { |
|
567 | + $context['topics'] = array_reverse($context['topics'], true); |
|
568 | + } |
|
541 | 569 | |
542 | 570 | if (!empty($modSettings['enableParticipation']) && !$user_info['is_guest'] && !empty($topic_ids)) |
543 | 571 | { |
@@ -554,8 +582,9 @@ discard block |
||
554 | 582 | 'limit' => count($topic_ids), |
555 | 583 | ) |
556 | 584 | ); |
557 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
558 | - $context['topics'][$row['id_topic']]['is_posted_in'] = true; |
|
585 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
586 | + $context['topics'][$row['id_topic']]['is_posted_in'] = true; |
|
587 | + } |
|
559 | 588 | $smcFunc['db_free_result']($result); |
560 | 589 | } |
561 | 590 | } |
@@ -580,9 +609,9 @@ discard block |
||
580 | 609 | // Can we restore topics? |
581 | 610 | $context['can_restore'] = allowedTo('move_any') && !empty($board_info['recycle']); |
582 | 611 | |
583 | - if ($user_info['is_admin'] || $modSettings['topic_move_any']) |
|
584 | - $context['can_move_any'] = true; |
|
585 | - else |
|
612 | + if ($user_info['is_admin'] || $modSettings['topic_move_any']) { |
|
613 | + $context['can_move_any'] = true; |
|
614 | + } else |
|
586 | 615 | { |
587 | 616 | // We'll use this in a minute |
588 | 617 | $boards_allowed = boardsAllowedTo('post_new'); |
@@ -609,11 +638,13 @@ discard block |
||
609 | 638 | } |
610 | 639 | |
611 | 640 | // Can we use quick moderation checkboxes? |
612 | - if ($options['display_quick_mod'] == 1) |
|
613 | - $context['can_quick_mod'] = $context['user']['is_logged'] || $context['can_approve'] || $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'] || $context['can_merge'] || $context['can_restore']; |
|
641 | + if ($options['display_quick_mod'] == 1) { |
|
642 | + $context['can_quick_mod'] = $context['user']['is_logged'] || $context['can_approve'] || $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'] || $context['can_merge'] || $context['can_restore']; |
|
643 | + } |
|
614 | 644 | // Or the icons? |
615 | - else |
|
616 | - $context['can_quick_mod'] = $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move']; |
|
645 | + else { |
|
646 | + $context['can_quick_mod'] = $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move']; |
|
647 | + } |
|
617 | 648 | } |
618 | 649 | |
619 | 650 | if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1) |
@@ -647,13 +678,15 @@ discard block |
||
647 | 678 | ); |
648 | 679 | |
649 | 680 | // We've seen all these boards now! |
650 | - foreach ($board_info['parent_boards'] as $k => $dummy) |
|
651 | - if (isset($_SESSION['topicseen_cache'][$k])) |
|
681 | + foreach ($board_info['parent_boards'] as $k => $dummy) { |
|
682 | + if (isset($_SESSION['topicseen_cache'][$k])) |
|
652 | 683 | unset($_SESSION['topicseen_cache'][$k]); |
684 | + } |
|
653 | 685 | } |
654 | 686 | |
655 | - if (isset($_SESSION['topicseen_cache'][$board])) |
|
656 | - unset($_SESSION['topicseen_cache'][$board]); |
|
687 | + if (isset($_SESSION['topicseen_cache'][$board])) { |
|
688 | + unset($_SESSION['topicseen_cache'][$board]); |
|
689 | + } |
|
657 | 690 | |
658 | 691 | $request = $smcFunc['db_query']('', ' |
659 | 692 | SELECT id_topic, id_board, sent |
@@ -675,8 +708,9 @@ discard block |
||
675 | 708 | $context['is_marked_notify'] = true; |
676 | 709 | $board_sent = $row['sent']; |
677 | 710 | } |
678 | - if (!empty($row['id_topic'])) |
|
679 | - $context['topics'][$row['id_topic']]['is_watched'] = true; |
|
711 | + if (!empty($row['id_topic'])) { |
|
712 | + $context['topics'][$row['id_topic']]['is_watched'] = true; |
|
713 | + } |
|
680 | 714 | } |
681 | 715 | $smcFunc['db_free_result']($request); |
682 | 716 | |
@@ -700,8 +734,7 @@ discard block |
||
700 | 734 | $pref = !empty($pref[$user_info['id']]) ? $pref[$user_info['id']] : array(); |
701 | 735 | $pref = isset($pref['board_notify_' . $board]) ? $pref['board_notify_' . $board] : (!empty($pref['board_notify']) ? $pref['board_notify'] : 0); |
702 | 736 | $context['board_notification_mode'] = !$context['is_marked_notify'] ? 1 : ($pref & 0x02 ? 3 : ($pref & 0x01 ? 2 : 1)); |
703 | - } |
|
704 | - else |
|
737 | + } else |
|
705 | 738 | { |
706 | 739 | $context['is_marked_notify'] = false; |
707 | 740 | $context['board_notification_mode'] = 1; |
@@ -714,23 +747,27 @@ discard block |
||
714 | 747 | $context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false; |
715 | 748 | |
716 | 749 | // Don't want to show this forever... |
717 | - if ($context['becomesUnapproved']) |
|
718 | - unset($_SESSION['becomesUnapproved']); |
|
750 | + if ($context['becomesUnapproved']) { |
|
751 | + unset($_SESSION['becomesUnapproved']); |
|
752 | + } |
|
719 | 753 | |
720 | 754 | // Build the message index button array. |
721 | 755 | $context['normal_buttons'] = array(); |
722 | 756 | |
723 | - if ($context['can_post_new']) |
|
724 | - $context['normal_buttons']['new_topic'] = array('text' => 'new_topic', 'image' => 'new_topic.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0', 'active' => true); |
|
757 | + if ($context['can_post_new']) { |
|
758 | + $context['normal_buttons']['new_topic'] = array('text' => 'new_topic', 'image' => 'new_topic.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0', 'active' => true); |
|
759 | + } |
|
725 | 760 | |
726 | - if ($context['can_post_poll']) |
|
727 | - $context['normal_buttons']['post_poll'] = array('text' => 'new_poll', 'image' => 'new_poll.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0;poll'); |
|
761 | + if ($context['can_post_poll']) { |
|
762 | + $context['normal_buttons']['post_poll'] = array('text' => 'new_poll', 'image' => 'new_poll.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0;poll'); |
|
763 | + } |
|
728 | 764 | |
729 | - if (!$context['user']['is_logged']) |
|
730 | - $context['normal_buttons']['markread'] = array('text' => 'mark_read_short', 'image' => 'markread.png', 'lang' => true, 'custom' => 'data-confirm="' . $txt['are_sure_mark_read'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=markasread;sa=board;board=' . $context['current_board'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
765 | + if (!$context['user']['is_logged']) { |
|
766 | + $context['normal_buttons']['markread'] = array('text' => 'mark_read_short', 'image' => 'markread.png', 'lang' => true, 'custom' => 'data-confirm="' . $txt['are_sure_mark_read'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=markasread;sa=board;board=' . $context['current_board'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
767 | + } |
|
731 | 768 | |
732 | - if ($context['can_mark_notify']) |
|
733 | - $context['normal_buttons']['notify'] = array( |
|
769 | + if ($context['can_mark_notify']) { |
|
770 | + $context['normal_buttons']['notify'] = array( |
|
734 | 771 | 'lang' => true, |
735 | 772 | 'text' => 'notify_board_' . $context['board_notification_mode'], |
736 | 773 | 'sub_buttons' => array( |
@@ -748,6 +785,7 @@ discard block |
||
748 | 785 | ), |
749 | 786 | ), |
750 | 787 | ); |
788 | + } |
|
751 | 789 | |
752 | 790 | // Javascript for inline editing. |
753 | 791 | loadJavaScriptFile('topic.js', array('defer' => false), 'smf_topic'); |
@@ -769,18 +807,21 @@ discard block |
||
769 | 807 | checkSession('request'); |
770 | 808 | |
771 | 809 | // Lets go straight to the restore area. |
772 | - if (isset($_REQUEST['qaction']) && $_REQUEST['qaction'] == 'restore' && !empty($_REQUEST['topics'])) |
|
773 | - redirectexit('action=restoretopic;topics=' . implode(',', $_REQUEST['topics']) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
810 | + if (isset($_REQUEST['qaction']) && $_REQUEST['qaction'] == 'restore' && !empty($_REQUEST['topics'])) { |
|
811 | + redirectexit('action=restoretopic;topics=' . implode(',', $_REQUEST['topics']) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
812 | + } |
|
774 | 813 | |
775 | - if (isset($_SESSION['topicseen_cache'])) |
|
776 | - $_SESSION['topicseen_cache'] = array(); |
|
814 | + if (isset($_SESSION['topicseen_cache'])) { |
|
815 | + $_SESSION['topicseen_cache'] = array(); |
|
816 | + } |
|
777 | 817 | |
778 | 818 | // This is going to be needed to send off the notifications and for updateLastMessages(). |
779 | 819 | require_once($sourcedir . '/Subs-Post.php'); |
780 | 820 | |
781 | 821 | // Remember the last board they moved things to. |
782 | - if (isset($_REQUEST['move_to'])) |
|
783 | - $_SESSION['move_to_topic'] = $_REQUEST['move_to']; |
|
822 | + if (isset($_REQUEST['move_to'])) { |
|
823 | + $_SESSION['move_to_topic'] = $_REQUEST['move_to']; |
|
824 | + } |
|
784 | 825 | |
785 | 826 | // Only a few possible actions. |
786 | 827 | $possibleActions = array(); |
@@ -800,8 +841,7 @@ discard block |
||
800 | 841 | ); |
801 | 842 | |
802 | 843 | $redirect_url = 'board=' . $board . '.' . $_REQUEST['start']; |
803 | - } |
|
804 | - else |
|
844 | + } else |
|
805 | 845 | { |
806 | 846 | /** |
807 | 847 | * @todo Ugly. There's no getting around this, is there? |
@@ -819,8 +859,7 @@ discard block |
||
819 | 859 | if (!empty($board)) |
820 | 860 | { |
821 | 861 | $boards_can['post_new'] = array_diff(boardsAllowedTo('post_new'), array($board)); |
822 | - } |
|
823 | - else |
|
862 | + } else |
|
824 | 863 | { |
825 | 864 | $boards_can['post_new'] = boardsAllowedTo('post_new'); |
826 | 865 | } |
@@ -831,55 +870,67 @@ discard block |
||
831 | 870 | } |
832 | 871 | } |
833 | 872 | |
834 | - if (!$user_info['is_guest']) |
|
835 | - $possibleActions[] = 'markread'; |
|
836 | - if (!empty($boards_can['make_sticky'])) |
|
837 | - $possibleActions[] = 'sticky'; |
|
838 | - if (!empty($boards_can['move_any']) || !empty($boards_can['move_own'])) |
|
839 | - $possibleActions[] = 'move'; |
|
840 | - if (!empty($boards_can['remove_any']) || !empty($boards_can['remove_own'])) |
|
841 | - $possibleActions[] = 'remove'; |
|
842 | - if (!empty($boards_can['lock_any']) || !empty($boards_can['lock_own'])) |
|
843 | - $possibleActions[] = 'lock'; |
|
844 | - if (!empty($boards_can['merge_any'])) |
|
845 | - $possibleActions[] = 'merge'; |
|
846 | - if (!empty($boards_can['approve_posts'])) |
|
847 | - $possibleActions[] = 'approve'; |
|
873 | + if (!$user_info['is_guest']) { |
|
874 | + $possibleActions[] = 'markread'; |
|
875 | + } |
|
876 | + if (!empty($boards_can['make_sticky'])) { |
|
877 | + $possibleActions[] = 'sticky'; |
|
878 | + } |
|
879 | + if (!empty($boards_can['move_any']) || !empty($boards_can['move_own'])) { |
|
880 | + $possibleActions[] = 'move'; |
|
881 | + } |
|
882 | + if (!empty($boards_can['remove_any']) || !empty($boards_can['remove_own'])) { |
|
883 | + $possibleActions[] = 'remove'; |
|
884 | + } |
|
885 | + if (!empty($boards_can['lock_any']) || !empty($boards_can['lock_own'])) { |
|
886 | + $possibleActions[] = 'lock'; |
|
887 | + } |
|
888 | + if (!empty($boards_can['merge_any'])) { |
|
889 | + $possibleActions[] = 'merge'; |
|
890 | + } |
|
891 | + if (!empty($boards_can['approve_posts'])) { |
|
892 | + $possibleActions[] = 'approve'; |
|
893 | + } |
|
848 | 894 | |
849 | 895 | // Two methods: $_REQUEST['actions'] (id_topic => action), and $_REQUEST['topics'] and $_REQUEST['qaction']. |
850 | 896 | // (if action is 'move', $_REQUEST['move_to'] or $_REQUEST['move_tos'][$topic] is used.) |
851 | 897 | if (!empty($_REQUEST['topics'])) |
852 | 898 | { |
853 | 899 | // If the action isn't valid, just quit now. |
854 | - if (empty($_REQUEST['qaction']) || !in_array($_REQUEST['qaction'], $possibleActions)) |
|
855 | - redirectexit($redirect_url); |
|
900 | + if (empty($_REQUEST['qaction']) || !in_array($_REQUEST['qaction'], $possibleActions)) { |
|
901 | + redirectexit($redirect_url); |
|
902 | + } |
|
856 | 903 | |
857 | 904 | // Merge requires all topics as one parameter and can be done at once. |
858 | 905 | if ($_REQUEST['qaction'] == 'merge') |
859 | 906 | { |
860 | 907 | // Merge requires at least two topics. |
861 | - if (empty($_REQUEST['topics']) || count($_REQUEST['topics']) < 2) |
|
862 | - redirectexit($redirect_url); |
|
908 | + if (empty($_REQUEST['topics']) || count($_REQUEST['topics']) < 2) { |
|
909 | + redirectexit($redirect_url); |
|
910 | + } |
|
863 | 911 | |
864 | 912 | require_once($sourcedir . '/SplitTopics.php'); |
865 | 913 | return MergeExecute($_REQUEST['topics']); |
866 | 914 | } |
867 | 915 | |
868 | 916 | // Just convert to the other method, to make it easier. |
869 | - foreach ($_REQUEST['topics'] as $topic) |
|
870 | - $_REQUEST['actions'][(int) $topic] = $_REQUEST['qaction']; |
|
917 | + foreach ($_REQUEST['topics'] as $topic) { |
|
918 | + $_REQUEST['actions'][(int) $topic] = $_REQUEST['qaction']; |
|
919 | + } |
|
871 | 920 | } |
872 | 921 | |
873 | 922 | // Weird... how'd you get here? |
874 | - if (empty($_REQUEST['actions'])) |
|
875 | - redirectexit($redirect_url); |
|
923 | + if (empty($_REQUEST['actions'])) { |
|
924 | + redirectexit($redirect_url); |
|
925 | + } |
|
876 | 926 | |
877 | 927 | // Validate each action. |
878 | 928 | $temp = array(); |
879 | 929 | foreach ($_REQUEST['actions'] as $topic => $action) |
880 | 930 | { |
881 | - if (in_array($action, $possibleActions)) |
|
882 | - $temp[(int) $topic] = $action; |
|
931 | + if (in_array($action, $possibleActions)) { |
|
932 | + $temp[(int) $topic] = $action; |
|
933 | + } |
|
883 | 934 | } |
884 | 935 | $_REQUEST['actions'] = $temp; |
885 | 936 | |
@@ -900,27 +951,31 @@ discard block |
||
900 | 951 | { |
901 | 952 | if (!empty($board)) |
902 | 953 | { |
903 | - if ($row['id_board'] != $board || ($modSettings['postmod_active'] && !$row['approved'] && !allowedTo('approve_posts'))) |
|
904 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
905 | - } |
|
906 | - else |
|
954 | + if ($row['id_board'] != $board || ($modSettings['postmod_active'] && !$row['approved'] && !allowedTo('approve_posts'))) { |
|
955 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
956 | + } |
|
957 | + } else |
|
907 | 958 | { |
908 | 959 | // Don't allow them to act on unapproved posts they can't see... |
909 | - if ($modSettings['postmod_active'] && !$row['approved'] && !in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])) |
|
910 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
960 | + if ($modSettings['postmod_active'] && !$row['approved'] && !in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])) { |
|
961 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
962 | + } |
|
911 | 963 | // Goodness, this is fun. We need to validate the action. |
912 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'sticky' && !in_array(0, $boards_can['make_sticky']) && !in_array($row['id_board'], $boards_can['make_sticky'])) |
|
913 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
914 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'move' && !in_array(0, $boards_can['move_any']) && !in_array($row['id_board'], $boards_can['move_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['move_own']) && !in_array($row['id_board'], $boards_can['move_own'])))) |
|
915 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
916 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'remove' && !in_array(0, $boards_can['remove_any']) && !in_array($row['id_board'], $boards_can['remove_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['remove_own']) && !in_array($row['id_board'], $boards_can['remove_own'])))) |
|
917 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
964 | + elseif ($_REQUEST['actions'][$row['id_topic']] == 'sticky' && !in_array(0, $boards_can['make_sticky']) && !in_array($row['id_board'], $boards_can['make_sticky'])) { |
|
965 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
966 | + } elseif ($_REQUEST['actions'][$row['id_topic']] == 'move' && !in_array(0, $boards_can['move_any']) && !in_array($row['id_board'], $boards_can['move_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['move_own']) && !in_array($row['id_board'], $boards_can['move_own'])))) { |
|
967 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
968 | + } elseif ($_REQUEST['actions'][$row['id_topic']] == 'remove' && !in_array(0, $boards_can['remove_any']) && !in_array($row['id_board'], $boards_can['remove_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['remove_own']) && !in_array($row['id_board'], $boards_can['remove_own'])))) { |
|
969 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
970 | + } |
|
918 | 971 | // @todo $locked is not set, what are you trying to do? (taking the change it is supposed to be $row['locked']) |
919 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'lock' && !in_array(0, $boards_can['lock_any']) && !in_array($row['id_board'], $boards_can['lock_any']) && ($row['id_member_started'] != $user_info['id'] || $row['locked'] == 1 || (!in_array(0, $boards_can['lock_own']) && !in_array($row['id_board'], $boards_can['lock_own'])))) |
|
920 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
972 | + elseif ($_REQUEST['actions'][$row['id_topic']] == 'lock' && !in_array(0, $boards_can['lock_any']) && !in_array($row['id_board'], $boards_can['lock_any']) && ($row['id_member_started'] != $user_info['id'] || $row['locked'] == 1 || (!in_array(0, $boards_can['lock_own']) && !in_array($row['id_board'], $boards_can['lock_own'])))) { |
|
973 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
974 | + } |
|
921 | 975 | // If the topic is approved then you need permission to approve the posts within. |
922 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'approve' && (!$row['unapproved_posts'] || (!in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])))) |
|
923 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
976 | + elseif ($_REQUEST['actions'][$row['id_topic']] == 'approve' && (!$row['unapproved_posts'] || (!in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])))) { |
|
977 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
978 | + } |
|
924 | 979 | } |
925 | 980 | } |
926 | 981 | $smcFunc['db_free_result']($request); |
@@ -938,11 +993,11 @@ discard block |
||
938 | 993 | { |
939 | 994 | $topic = (int) $topic; |
940 | 995 | |
941 | - if ($action == 'markread') |
|
942 | - $markCache[] = $topic; |
|
943 | - elseif ($action == 'sticky') |
|
944 | - $stickyCache[] = $topic; |
|
945 | - elseif ($action == 'move') |
|
996 | + if ($action == 'markread') { |
|
997 | + $markCache[] = $topic; |
|
998 | + } elseif ($action == 'sticky') { |
|
999 | + $stickyCache[] = $topic; |
|
1000 | + } elseif ($action == 'move') |
|
946 | 1001 | { |
947 | 1002 | require_once($sourcedir . '/MoveTopic.php'); |
948 | 1003 | moveTopicConcurrence(); |
@@ -950,23 +1005,25 @@ discard block |
||
950 | 1005 | // $moveCache[0] is the topic, $moveCache[1] is the board to move to. |
951 | 1006 | $moveCache[1][$topic] = (int) (isset($_REQUEST['move_tos'][$topic]) ? $_REQUEST['move_tos'][$topic] : $_REQUEST['move_to']); |
952 | 1007 | |
953 | - if (empty($moveCache[1][$topic])) |
|
954 | - continue; |
|
1008 | + if (empty($moveCache[1][$topic])) { |
|
1009 | + continue; |
|
1010 | + } |
|
955 | 1011 | |
956 | 1012 | $moveCache[0][] = $topic; |
1013 | + } elseif ($action == 'remove') { |
|
1014 | + $removeCache[] = $topic; |
|
1015 | + } elseif ($action == 'lock') { |
|
1016 | + $lockCache[] = $topic; |
|
1017 | + } elseif ($action == 'approve') { |
|
1018 | + $approveCache[] = $topic; |
|
957 | 1019 | } |
958 | - elseif ($action == 'remove') |
|
959 | - $removeCache[] = $topic; |
|
960 | - elseif ($action == 'lock') |
|
961 | - $lockCache[] = $topic; |
|
962 | - elseif ($action == 'approve') |
|
963 | - $approveCache[] = $topic; |
|
964 | 1020 | } |
965 | 1021 | |
966 | - if (empty($board)) |
|
967 | - $affectedBoards = array(); |
|
968 | - else |
|
969 | - $affectedBoards = array($board => array(0, 0)); |
|
1022 | + if (empty($board)) { |
|
1023 | + $affectedBoards = array(); |
|
1024 | + } else { |
|
1025 | + $affectedBoards = array($board => array(0, 0)); |
|
1026 | + } |
|
970 | 1027 | |
971 | 1028 | // Do all the stickies... |
972 | 1029 | if (!empty($stickyCache)) |
@@ -1026,14 +1083,16 @@ discard block |
||
1026 | 1083 | { |
1027 | 1084 | $to = $moveCache[1][$row['id_topic']]; |
1028 | 1085 | |
1029 | - if (empty($to)) |
|
1030 | - continue; |
|
1086 | + if (empty($to)) { |
|
1087 | + continue; |
|
1088 | + } |
|
1031 | 1089 | |
1032 | 1090 | // Does this topic's board count the posts or not? |
1033 | 1091 | $countPosts[$row['id_topic']] = empty($row['count_posts']); |
1034 | 1092 | |
1035 | - if (!isset($moveTos[$to])) |
|
1036 | - $moveTos[$to] = array(); |
|
1093 | + if (!isset($moveTos[$to])) { |
|
1094 | + $moveTos[$to] = array(); |
|
1095 | + } |
|
1037 | 1096 | |
1038 | 1097 | $moveTos[$to][] = $row['id_topic']; |
1039 | 1098 | |
@@ -1047,8 +1106,9 @@ discard block |
||
1047 | 1106 | require_once($sourcedir . '/MoveTopic.php'); |
1048 | 1107 | |
1049 | 1108 | // Do the actual moves... |
1050 | - foreach ($moveTos as $to => $topics) |
|
1051 | - moveTopics($topics, $to); |
|
1109 | + foreach ($moveTos as $to => $topics) { |
|
1110 | + moveTopics($topics, $to); |
|
1111 | + } |
|
1052 | 1112 | |
1053 | 1113 | // Does the post counts need to be updated? |
1054 | 1114 | if (!empty($moveTos)) |
@@ -1097,20 +1157,23 @@ discard block |
||
1097 | 1157 | |
1098 | 1158 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1099 | 1159 | { |
1100 | - if (!isset($members[$row['id_member']])) |
|
1101 | - $members[$row['id_member']] = 0; |
|
1160 | + if (!isset($members[$row['id_member']])) { |
|
1161 | + $members[$row['id_member']] = 0; |
|
1162 | + } |
|
1102 | 1163 | |
1103 | - if ($topicRecounts[$row['id_topic']] === '+') |
|
1104 | - $members[$row['id_member']] += 1; |
|
1105 | - else |
|
1106 | - $members[$row['id_member']] -= 1; |
|
1164 | + if ($topicRecounts[$row['id_topic']] === '+') { |
|
1165 | + $members[$row['id_member']] += 1; |
|
1166 | + } else { |
|
1167 | + $members[$row['id_member']] -= 1; |
|
1168 | + } |
|
1107 | 1169 | } |
1108 | 1170 | |
1109 | 1171 | $smcFunc['db_free_result']($request); |
1110 | 1172 | |
1111 | 1173 | // And now update them member's post counts |
1112 | - foreach ($members as $id_member => $post_adj) |
|
1113 | - updateMemberData($id_member, array('posts' => 'posts + ' . $post_adj)); |
|
1174 | + foreach ($members as $id_member => $post_adj) { |
|
1175 | + updateMemberData($id_member, array('posts' => 'posts + ' . $post_adj)); |
|
1176 | + } |
|
1114 | 1177 | |
1115 | 1178 | } |
1116 | 1179 | } |
@@ -1190,8 +1253,9 @@ discard block |
||
1190 | 1253 | approveTopics($approveCache); |
1191 | 1254 | |
1192 | 1255 | // Time for some logging! |
1193 | - foreach ($approveCache as $topic) |
|
1194 | - logAction('approve_topic', array('topic' => $topic, 'member' => $approveCacheMembers[$topic])); |
|
1256 | + foreach ($approveCache as $topic) { |
|
1257 | + logAction('approve_topic', array('topic' => $topic, 'member' => $approveCacheMembers[$topic])); |
|
1258 | + } |
|
1195 | 1259 | } |
1196 | 1260 | } |
1197 | 1261 | |
@@ -1226,8 +1290,7 @@ discard block |
||
1226 | 1290 | $lockStatus[$row['id_topic']] = empty($row['locked']); |
1227 | 1291 | } |
1228 | 1292 | $smcFunc['db_free_result']($result); |
1229 | - } |
|
1230 | - else |
|
1293 | + } else |
|
1231 | 1294 | { |
1232 | 1295 | $result = $smcFunc['db_query']('', ' |
1233 | 1296 | SELECT id_topic, locked, id_board |
@@ -1277,13 +1340,15 @@ discard block |
||
1277 | 1340 | ) |
1278 | 1341 | ); |
1279 | 1342 | $logged_topics = array(); |
1280 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1281 | - $logged_topics[$row['id_topic']] = $row['unwatched']; |
|
1343 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1344 | + $logged_topics[$row['id_topic']] = $row['unwatched']; |
|
1345 | + } |
|
1282 | 1346 | $smcFunc['db_free_result']($request); |
1283 | 1347 | |
1284 | 1348 | $markArray = array(); |
1285 | - foreach ($markCache as $topic) |
|
1286 | - $markArray[] = array($modSettings['maxMsgID'], $user_info['id'], $topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0)); |
|
1349 | + foreach ($markCache as $topic) { |
|
1350 | + $markArray[] = array($modSettings['maxMsgID'], $user_info['id'], $topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0)); |
|
1351 | + } |
|
1287 | 1352 | |
1288 | 1353 | $smcFunc['db_insert']('replace', |
1289 | 1354 | '{db_prefix}log_topics', |
@@ -1296,8 +1361,9 @@ discard block |
||
1296 | 1361 | foreach ($moveCache as $topic) |
1297 | 1362 | { |
1298 | 1363 | // Didn't actually move anything! |
1299 | - if (!isset($topic[0])) |
|
1300 | - break; |
|
1364 | + if (!isset($topic[0])) { |
|
1365 | + break; |
|
1366 | + } |
|
1301 | 1367 | |
1302 | 1368 | logAction('move', array('topic' => $topic[0], 'board_from' => $topic[1], 'board_to' => $topic[2])); |
1303 | 1369 | sendNotifications($topic[0], 'move'); |
@@ -1319,8 +1385,9 @@ discard block |
||
1319 | 1385 | 'calendar_updated' => time(), |
1320 | 1386 | )); |
1321 | 1387 | |
1322 | - if (!empty($affectedBoards)) |
|
1323 | - updateLastMessages(array_keys($affectedBoards)); |
|
1388 | + if (!empty($affectedBoards)) { |
|
1389 | + updateLastMessages(array_keys($affectedBoards)); |
|
1390 | + } |
|
1324 | 1391 | |
1325 | 1392 | redirectexit($redirect_url); |
1326 | 1393 | } |
@@ -17,8 +17,9 @@ discard block |
||
17 | 17 | * @version 2.1 Beta 3 |
18 | 18 | */ |
19 | 19 | |
20 | -if (!defined('SMF')) |
|
20 | +if (!defined('SMF')) { |
|
21 | 21 | die('No direct access...'); |
22 | +} |
|
22 | 23 | |
23 | 24 | /** |
24 | 25 | * Attempt to start the session, unless it already has been. |
@@ -38,8 +39,9 @@ discard block |
||
38 | 39 | { |
39 | 40 | $parsed_url = parse_url($boardurl); |
40 | 41 | |
41 | - if (preg_match('~^\d{1,3}(\.\d{1,3}){3}$~', $parsed_url['host']) == 0 && preg_match('~(?:[^\.]+\.)?([^\.]{2,}\..+)\z~i', $parsed_url['host'], $parts) == 1) |
|
42 | - @ini_set('session.cookie_domain', '.' . $parts[1]); |
|
42 | + if (preg_match('~^\d{1,3}(\.\d{1,3}){3}$~', $parsed_url['host']) == 0 && preg_match('~(?:[^\.]+\.)?([^\.]{2,}\..+)\z~i', $parsed_url['host'], $parts) == 1) { |
|
43 | + @ini_set('session.cookie_domain', '.' . $parts[1]); |
|
44 | + } |
|
43 | 45 | } |
44 | 46 | // @todo Set the session cookie path? |
45 | 47 | |
@@ -47,8 +49,9 @@ discard block |
||
47 | 49 | if ((ini_get('session.auto_start') == 1 && !empty($modSettings['databaseSession_enable'])) || session_id() == '') |
48 | 50 | { |
49 | 51 | // Attempt to end the already-started session. |
50 | - if (ini_get('session.auto_start') == 1) |
|
51 | - session_write_close(); |
|
52 | + if (ini_get('session.auto_start') == 1) { |
|
53 | + session_write_close(); |
|
54 | + } |
|
52 | 55 | |
53 | 56 | // This is here to stop people from using bad junky PHPSESSIDs. |
54 | 57 | if (isset($_REQUEST[session_name()]) && preg_match('~^[A-Za-z0-9,-]{16,64}$~', $_REQUEST[session_name()]) == 0 && !isset($_COOKIE[session_name()])) |
@@ -65,19 +68,21 @@ discard block |
||
65 | 68 | @ini_set('session.serialize_handler', 'php'); |
66 | 69 | session_set_save_handler('sessionOpen', 'sessionClose', 'sessionRead', 'sessionWrite', 'sessionDestroy', 'sessionGC'); |
67 | 70 | @ini_set('session.gc_probability', '1'); |
71 | + } elseif (ini_get('session.gc_maxlifetime') <= 1440 && !empty($modSettings['databaseSession_lifetime'])) { |
|
72 | + @ini_set('session.gc_maxlifetime', max($modSettings['databaseSession_lifetime'], 60)); |
|
68 | 73 | } |
69 | - elseif (ini_get('session.gc_maxlifetime') <= 1440 && !empty($modSettings['databaseSession_lifetime'])) |
|
70 | - @ini_set('session.gc_maxlifetime', max($modSettings['databaseSession_lifetime'], 60)); |
|
71 | 74 | |
72 | 75 | // Use cache setting sessions? |
73 | - if (empty($modSettings['databaseSession_enable']) && !empty($modSettings['cache_enable']) && php_sapi_name() != 'cli') |
|
74 | - call_integration_hook('integrate_session_handlers'); |
|
76 | + if (empty($modSettings['databaseSession_enable']) && !empty($modSettings['cache_enable']) && php_sapi_name() != 'cli') { |
|
77 | + call_integration_hook('integrate_session_handlers'); |
|
78 | + } |
|
75 | 79 | |
76 | 80 | session_start(); |
77 | 81 | |
78 | 82 | // Change it so the cache settings are a little looser than default. |
79 | - if (!empty($modSettings['databaseSession_loose'])) |
|
80 | - header('Cache-Control: private'); |
|
83 | + if (!empty($modSettings['databaseSession_loose'])) { |
|
84 | + header('Cache-Control: private'); |
|
85 | + } |
|
81 | 86 | } |
82 | 87 | |
83 | 88 | // Set the randomly generated code. |
@@ -123,8 +128,9 @@ discard block |
||
123 | 128 | { |
124 | 129 | global $smcFunc; |
125 | 130 | |
126 | - if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) |
|
127 | - return ''; |
|
131 | + if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) { |
|
132 | + return ''; |
|
133 | + } |
|
128 | 134 | |
129 | 135 | // Look for it in the database. |
130 | 136 | $result = $smcFunc['db_query']('', ' |
@@ -153,8 +159,9 @@ discard block |
||
153 | 159 | { |
154 | 160 | global $smcFunc; |
155 | 161 | |
156 | - if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) |
|
157 | - return false; |
|
162 | + if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) { |
|
163 | + return false; |
|
164 | + } |
|
158 | 165 | |
159 | 166 | // First try to update an existing row... |
160 | 167 | $smcFunc['db_query']('', ' |
@@ -169,13 +176,14 @@ discard block |
||
169 | 176 | ); |
170 | 177 | |
171 | 178 | // If that didn't work, try inserting a new one. |
172 | - if ($smcFunc['db_affected_rows']() == 0) |
|
173 | - $smcFunc['db_insert']('ignore', |
|
179 | + if ($smcFunc['db_affected_rows']() == 0) { |
|
180 | + $smcFunc['db_insert']('ignore', |
|
174 | 181 | '{db_prefix}sessions', |
175 | 182 | array('session_id' => 'string', 'data' => 'string', 'last_update' => 'int'), |
176 | 183 | array($session_id, $data, time()), |
177 | 184 | array('session_id') |
178 | 185 | ); |
186 | + } |
|
179 | 187 | |
180 | 188 | return ($smcFunc['db_affected_rows']() == 0 ? false : true); |
181 | 189 | } |
@@ -190,8 +198,9 @@ discard block |
||
190 | 198 | { |
191 | 199 | global $smcFunc; |
192 | 200 | |
193 | - if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) |
|
194 | - return false; |
|
201 | + if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) { |
|
202 | + return false; |
|
203 | + } |
|
195 | 204 | |
196 | 205 | // Just delete the row... |
197 | 206 | $smcFunc['db_query']('', ' |
@@ -217,8 +226,9 @@ discard block |
||
217 | 226 | global $modSettings, $smcFunc; |
218 | 227 | |
219 | 228 | // Just set to the default or lower? Ignore it for a higher value. (hopefully) |
220 | - if (!empty($modSettings['databaseSession_lifetime']) && ($max_lifetime <= 1440 || $modSettings['databaseSession_lifetime'] > $max_lifetime)) |
|
221 | - $max_lifetime = max($modSettings['databaseSession_lifetime'], 60); |
|
229 | + if (!empty($modSettings['databaseSession_lifetime']) && ($max_lifetime <= 1440 || $modSettings['databaseSession_lifetime'] > $max_lifetime)) { |
|
230 | + $max_lifetime = max($modSettings['databaseSession_lifetime'], 60); |
|
231 | + } |
|
222 | 232 | |
223 | 233 | // Clean up after yerself ;). |
224 | 234 | $smcFunc['db_query']('', ' |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 3 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | |
20 | 21 | /** |
@@ -44,8 +45,9 @@ discard block |
||
44 | 45 | $_REQUEST['sa'] = isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']]) ? $_REQUEST['sa'] : (allowedTo('manage_membergroups') ? 'index' : 'settings'); |
45 | 46 | |
46 | 47 | // Is it elsewhere? |
47 | - if (isset($subActions[$_REQUEST['sa']][2])) |
|
48 | - require_once($sourcedir . '/' . $subActions[$_REQUEST['sa']][2]); |
|
48 | + if (isset($subActions[$_REQUEST['sa']][2])) { |
|
49 | + require_once($sourcedir . '/' . $subActions[$_REQUEST['sa']][2]); |
|
50 | + } |
|
49 | 51 | |
50 | 52 | // Do the permission check, you might not be allowed her. |
51 | 53 | isAllowedTo($subActions[$_REQUEST['sa']][1]); |
@@ -104,19 +106,20 @@ discard block |
||
104 | 106 | 'function' => function($rowData) use ($scripturl) |
105 | 107 | { |
106 | 108 | // Since the moderator group has no explicit members, no link is needed. |
107 | - if ($rowData['id_group'] == 3) |
|
108 | - $group_name = $rowData['group_name']; |
|
109 | - else |
|
109 | + if ($rowData['id_group'] == 3) { |
|
110 | + $group_name = $rowData['group_name']; |
|
111 | + } else |
|
110 | 112 | { |
111 | 113 | $color_style = empty($rowData['online_color']) ? '' : sprintf(' style="color: %1$s;"', $rowData['online_color']); |
112 | 114 | $group_name = sprintf('<a href="%1$s?action=admin;area=membergroups;sa=members;group=%2$d"%3$s>%4$s</a>', $scripturl, $rowData['id_group'], $color_style, $rowData['group_name']); |
113 | 115 | } |
114 | 116 | |
115 | 117 | // Add a help option for moderator and administrator. |
116 | - if ($rowData['id_group'] == 1) |
|
117 | - $group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl); |
|
118 | - elseif ($rowData['id_group'] == 3) |
|
119 | - $group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl); |
|
118 | + if ($rowData['id_group'] == 1) { |
|
119 | + $group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl); |
|
120 | + } elseif ($rowData['id_group'] == 3) { |
|
121 | + $group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl); |
|
122 | + } |
|
120 | 123 | |
121 | 124 | return $group_name; |
122 | 125 | }, |
@@ -330,12 +333,14 @@ discard block |
||
330 | 333 | call_integration_hook('integrate_add_membergroup', array($id_group, $postCountBasedGroup)); |
331 | 334 | |
332 | 335 | // Update the post groups now, if this is a post group! |
333 | - if (isset($_POST['min_posts'])) |
|
334 | - updateStats('postgroups'); |
|
336 | + if (isset($_POST['min_posts'])) { |
|
337 | + updateStats('postgroups'); |
|
338 | + } |
|
335 | 339 | |
336 | 340 | // You cannot set permissions for post groups if they are disabled. |
337 | - if ($postCountBasedGroup && empty($modSettings['permission_enable_postgroups'])) |
|
338 | - $_POST['perm_type'] = ''; |
|
341 | + if ($postCountBasedGroup && empty($modSettings['permission_enable_postgroups'])) { |
|
342 | + $_POST['perm_type'] = ''; |
|
343 | + } |
|
339 | 344 | |
340 | 345 | if ($_POST['perm_type'] == 'predefined') |
341 | 346 | { |
@@ -365,8 +370,9 @@ discard block |
||
365 | 370 | $smcFunc['db_free_result']($request); |
366 | 371 | |
367 | 372 | // Protected groups are... well, protected! |
368 | - if ($copy_type == 1) |
|
369 | - fatal_lang_error('membergroup_does_not_exist'); |
|
373 | + if ($copy_type == 1) { |
|
374 | + fatal_lang_error('membergroup_does_not_exist'); |
|
375 | + } |
|
370 | 376 | } |
371 | 377 | |
372 | 378 | // Don't allow copying of a real priviledged person! |
@@ -384,18 +390,20 @@ discard block |
||
384 | 390 | $inserts = array(); |
385 | 391 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
386 | 392 | { |
387 | - if (empty($context['illegal_permissions']) || !in_array($row['permission'], $context['illegal_permissions'])) |
|
388 | - $inserts[] = array($id_group, $row['permission'], $row['add_deny']); |
|
393 | + if (empty($context['illegal_permissions']) || !in_array($row['permission'], $context['illegal_permissions'])) { |
|
394 | + $inserts[] = array($id_group, $row['permission'], $row['add_deny']); |
|
395 | + } |
|
389 | 396 | } |
390 | 397 | $smcFunc['db_free_result']($request); |
391 | 398 | |
392 | - if (!empty($inserts)) |
|
393 | - $smcFunc['db_insert']('insert', |
|
399 | + if (!empty($inserts)) { |
|
400 | + $smcFunc['db_insert']('insert', |
|
394 | 401 | '{db_prefix}permissions', |
395 | 402 | array('id_group' => 'int', 'permission' => 'string', 'add_deny' => 'int'), |
396 | 403 | $inserts, |
397 | 404 | array('id_group', 'permission') |
398 | 405 | ); |
406 | + } |
|
399 | 407 | |
400 | 408 | $request = $smcFunc['db_query']('', ' |
401 | 409 | SELECT id_profile, permission, add_deny |
@@ -406,17 +414,19 @@ discard block |
||
406 | 414 | ) |
407 | 415 | ); |
408 | 416 | $inserts = array(); |
409 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
410 | - $inserts[] = array($id_group, $row['id_profile'], $row['permission'], $row['add_deny']); |
|
417 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
418 | + $inserts[] = array($id_group, $row['id_profile'], $row['permission'], $row['add_deny']); |
|
419 | + } |
|
411 | 420 | $smcFunc['db_free_result']($request); |
412 | 421 | |
413 | - if (!empty($inserts)) |
|
414 | - $smcFunc['db_insert']('insert', |
|
422 | + if (!empty($inserts)) { |
|
423 | + $smcFunc['db_insert']('insert', |
|
415 | 424 | '{db_prefix}board_permissions', |
416 | 425 | array('id_group' => 'int', 'id_profile' => 'int', 'permission' => 'string', 'add_deny' => 'int'), |
417 | 426 | $inserts, |
418 | 427 | array('id_group', 'id_profile', 'permission') |
419 | 428 | ); |
429 | + } |
|
420 | 430 | |
421 | 431 | // Also get some membergroup information if we're copying and not copying from guests... |
422 | 432 | if ($copy_id > 0 && $_POST['perm_type'] == 'copy') |
@@ -469,14 +479,15 @@ discard block |
||
469 | 479 | $changed_boards['allow'] = array(); |
470 | 480 | $changed_boards['deny'] = array(); |
471 | 481 | $changed_boards['ignore'] = array(); |
472 | - foreach ($accesses as $group_id => $action) |
|
473 | - $changed_boards[$action][] = (int) $group_id; |
|
482 | + foreach ($accesses as $group_id => $action) { |
|
483 | + $changed_boards[$action][] = (int) $group_id; |
|
484 | + } |
|
474 | 485 | |
475 | 486 | foreach (array('allow', 'deny') as $board_action) |
476 | 487 | { |
477 | 488 | // Only do this if they have special access requirements. |
478 | - if (!empty($changed_boards[$board_action])) |
|
479 | - $smcFunc['db_query']('', ' |
|
489 | + if (!empty($changed_boards[$board_action])) { |
|
490 | + $smcFunc['db_query']('', ' |
|
480 | 491 | UPDATE {db_prefix}boards |
481 | 492 | SET {raw:column} = CASE WHEN {raw:column} = {string:blank_string} THEN {string:group_id_string} ELSE CONCAT({raw:column}, {string:comma_group}) END |
482 | 493 | WHERE id_board IN ({array_int:board_list})', |
@@ -488,11 +499,13 @@ discard block |
||
488 | 499 | 'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups', |
489 | 500 | ) |
490 | 501 | ); |
502 | + } |
|
491 | 503 | } |
492 | 504 | |
493 | 505 | // If this is joinable then set it to show group membership in people's profiles. |
494 | - if (empty($modSettings['show_group_membership']) && $_POST['group_type'] > 1) |
|
495 | - updateSettings(array('show_group_membership' => 1)); |
|
506 | + if (empty($modSettings['show_group_membership']) && $_POST['group_type'] > 1) { |
|
507 | + updateSettings(array('show_group_membership' => 1)); |
|
508 | + } |
|
496 | 509 | |
497 | 510 | // Rebuild the group cache. |
498 | 511 | updateSettings(array( |
@@ -513,8 +526,9 @@ discard block |
||
513 | 526 | $context['undefined_group'] = !isset($_REQUEST['postgroup']) && !isset($_REQUEST['generalgroup']); |
514 | 527 | $context['allow_protected'] = allowedTo('admin_forum'); |
515 | 528 | |
516 | - if (!empty($modSettings['deny_boards_access'])) |
|
517 | - loadLanguage('ManagePermissions'); |
|
529 | + if (!empty($modSettings['deny_boards_access'])) { |
|
530 | + loadLanguage('ManagePermissions'); |
|
531 | + } |
|
518 | 532 | |
519 | 533 | $result = $smcFunc['db_query']('', ' |
520 | 534 | SELECT id_group, group_name |
@@ -531,11 +545,12 @@ discard block |
||
531 | 545 | ) |
532 | 546 | ); |
533 | 547 | $context['groups'] = array(); |
534 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
535 | - $context['groups'][] = array( |
|
548 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
549 | + $context['groups'][] = array( |
|
536 | 550 | 'id' => $row['id_group'], |
537 | 551 | 'name' => $row['group_name'] |
538 | 552 | ); |
553 | + } |
|
539 | 554 | $smcFunc['db_free_result']($result); |
540 | 555 | |
541 | 556 | $request = $smcFunc['db_query']('', ' |
@@ -552,12 +567,13 @@ discard block |
||
552 | 567 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
553 | 568 | { |
554 | 569 | // This category hasn't been set up yet.. |
555 | - if (!isset($context['categories'][$row['id_cat']])) |
|
556 | - $context['categories'][$row['id_cat']] = array( |
|
570 | + if (!isset($context['categories'][$row['id_cat']])) { |
|
571 | + $context['categories'][$row['id_cat']] = array( |
|
557 | 572 | 'id' => $row['id_cat'], |
558 | 573 | 'name' => $row['cat_name'], |
559 | 574 | 'boards' => array() |
560 | 575 | ); |
576 | + } |
|
561 | 577 | |
562 | 578 | // Set this board up, and let the template know when it's a child. (indent them..) |
563 | 579 | $context['categories'][$row['id_cat']]['boards'][$row['id_board']] = array( |
@@ -605,8 +621,9 @@ discard block |
||
605 | 621 | require_once($sourcedir . '/Subs-Membergroups.php'); |
606 | 622 | $result = deleteMembergroups((int) $_REQUEST['group']); |
607 | 623 | // Need to throw a warning if it went wrong, but this is the only one we have a message for... |
608 | - if ($result === 'group_cannot_delete_sub') |
|
609 | - fatal_lang_error('membergroups_cannot_delete_paid', false); |
|
624 | + if ($result === 'group_cannot_delete_sub') { |
|
625 | + fatal_lang_error('membergroups_cannot_delete_paid', false); |
|
626 | + } |
|
610 | 627 | |
611 | 628 | // Go back to the membergroup index. |
612 | 629 | redirectexit('action=admin;area=membergroups;'); |
@@ -628,8 +645,9 @@ discard block |
||
628 | 645 | |
629 | 646 | $_REQUEST['group'] = isset($_REQUEST['group']) && $_REQUEST['group'] > 0 ? (int) $_REQUEST['group'] : 0; |
630 | 647 | |
631 | - if (!empty($modSettings['deny_boards_access'])) |
|
632 | - loadLanguage('ManagePermissions'); |
|
648 | + if (!empty($modSettings['deny_boards_access'])) { |
|
649 | + loadLanguage('ManagePermissions'); |
|
650 | + } |
|
633 | 651 | |
634 | 652 | // Make sure this group is editable. |
635 | 653 | if (!empty($_REQUEST['group'])) |
@@ -651,8 +669,9 @@ discard block |
||
651 | 669 | } |
652 | 670 | |
653 | 671 | // Now, do we have a valid id? |
654 | - if (empty($_REQUEST['group'])) |
|
655 | - fatal_lang_error('membergroup_does_not_exist', false); |
|
672 | + if (empty($_REQUEST['group'])) { |
|
673 | + fatal_lang_error('membergroup_does_not_exist', false); |
|
674 | + } |
|
656 | 675 | |
657 | 676 | // People who can manage boards are a bit special. |
658 | 677 | require_once($sourcedir . '/Subs-Members.php'); |
@@ -683,8 +702,9 @@ discard block |
||
683 | 702 | require_once($sourcedir . '/Subs-Membergroups.php'); |
684 | 703 | $result = deleteMembergroups($_REQUEST['group']); |
685 | 704 | // Need to throw a warning if it went wrong, but this is the only one we have a message for... |
686 | - if ($result === 'group_cannot_delete_sub') |
|
687 | - fatal_lang_error('membergroups_cannot_delete_paid', false); |
|
705 | + if ($result === 'group_cannot_delete_sub') { |
|
706 | + fatal_lang_error('membergroups_cannot_delete_paid', false); |
|
707 | + } |
|
688 | 708 | |
689 | 709 | redirectexit('action=admin;area=membergroups;'); |
690 | 710 | } |
@@ -761,16 +781,18 @@ discard block |
||
761 | 781 | $request = $smcFunc['db_query']('', ' |
762 | 782 | SELECT id_board |
763 | 783 | FROM {db_prefix}boards'); |
764 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
765 | - $accesses[(int) $row['id_board']] = 'allow'; |
|
784 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
785 | + $accesses[(int) $row['id_board']] = 'allow'; |
|
786 | + } |
|
766 | 787 | $smcFunc['db_free_result']($request); |
767 | 788 | } |
768 | 789 | |
769 | 790 | $changed_boards['allow'] = array(); |
770 | 791 | $changed_boards['deny'] = array(); |
771 | 792 | $changed_boards['ignore'] = array(); |
772 | - foreach ($accesses as $group_id => $action) |
|
773 | - $changed_boards[$action][] = (int) $group_id; |
|
793 | + foreach ($accesses as $group_id => $action) { |
|
794 | + $changed_boards[$action][] = (int) $group_id; |
|
795 | + } |
|
774 | 796 | |
775 | 797 | foreach (array('allow', 'deny') as $board_action) |
776 | 798 | { |
@@ -786,8 +808,8 @@ discard block |
||
786 | 808 | 'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups', |
787 | 809 | ) |
788 | 810 | ); |
789 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
790 | - $smcFunc['db_query']('', ' |
|
811 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
812 | + $smcFunc['db_query']('', ' |
|
791 | 813 | UPDATE {db_prefix}boards |
792 | 814 | SET {raw:column} = {string:member_group_access} |
793 | 815 | WHERE id_board = {int:current_board}', |
@@ -797,11 +819,12 @@ discard block |
||
797 | 819 | 'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups', |
798 | 820 | ) |
799 | 821 | ); |
822 | + } |
|
800 | 823 | $smcFunc['db_free_result']($request); |
801 | 824 | |
802 | 825 | // Add the membergroup to all boards that hadn't been set yet. |
803 | - if (!empty($changed_boards[$board_action])) |
|
804 | - $smcFunc['db_query']('', ' |
|
826 | + if (!empty($changed_boards[$board_action])) { |
|
827 | + $smcFunc['db_query']('', ' |
|
805 | 828 | UPDATE {db_prefix}boards |
806 | 829 | SET {raw:column} = CASE WHEN {raw:column} = {string:blank_string} THEN {string:group_id_string} ELSE CONCAT({raw:column}, {string:comma_group}) END |
807 | 830 | WHERE id_board IN ({array_int:board_list}) |
@@ -815,6 +838,7 @@ discard block |
||
815 | 838 | 'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups', |
816 | 839 | ) |
817 | 840 | ); |
841 | + } |
|
818 | 842 | } |
819 | 843 | } |
820 | 844 | |
@@ -840,12 +864,14 @@ discard block |
||
840 | 864 | ) |
841 | 865 | ); |
842 | 866 | $updates = array(); |
843 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
844 | - $updates[$row['additional_groups']][] = $row['id_member']; |
|
867 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
868 | + $updates[$row['additional_groups']][] = $row['id_member']; |
|
869 | + } |
|
845 | 870 | $smcFunc['db_free_result']($request); |
846 | 871 | |
847 | - foreach ($updates as $additional_groups => $memberArray) |
|
848 | - updateMemberData($memberArray, array('additional_groups' => implode(',', array_diff(explode(',', $additional_groups), array((int) $_REQUEST['group']))))); |
|
872 | + foreach ($updates as $additional_groups => $memberArray) { |
|
873 | + updateMemberData($memberArray, array('additional_groups' => implode(',', array_diff(explode(',', $additional_groups), array((int) $_REQUEST['group']))))); |
|
874 | + } |
|
849 | 875 | |
850 | 876 | // Sorry, but post groups can't moderate boards |
851 | 877 | $smcFunc['db_query']('', ' |
@@ -855,8 +881,7 @@ discard block |
||
855 | 881 | 'current_group' => (int) $_REQUEST['group'], |
856 | 882 | ) |
857 | 883 | ); |
858 | - } |
|
859 | - elseif ($_REQUEST['group'] != 3) |
|
884 | + } elseif ($_REQUEST['group'] != 3) |
|
860 | 885 | { |
861 | 886 | // Making it a hidden group? If so remove everyone with it as primary group (Actually, just make them additional). |
862 | 887 | if ($_POST['group_hidden'] == 2) |
@@ -871,8 +896,9 @@ discard block |
||
871 | 896 | ) |
872 | 897 | ); |
873 | 898 | $updates = array(); |
874 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
875 | - $updates[$row['additional_groups']][] = $row['id_member']; |
|
899 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
900 | + $updates[$row['additional_groups']][] = $row['id_member']; |
|
901 | + } |
|
876 | 902 | $smcFunc['db_free_result']($request); |
877 | 903 | |
878 | 904 | foreach ($updates as $additional_groups => $memberArray) |
@@ -914,8 +940,9 @@ discard block |
||
914 | 940 | $smcFunc['db_free_result']($request); |
915 | 941 | |
916 | 942 | // Do we need to update the setting? |
917 | - if ((empty($modSettings['show_group_membership']) && $have_joinable) || (!empty($modSettings['show_group_membership']) && !$have_joinable)) |
|
918 | - updateSettings(array('show_group_membership' => $have_joinable ? 1 : 0)); |
|
943 | + if ((empty($modSettings['show_group_membership']) && $have_joinable) || (!empty($modSettings['show_group_membership']) && !$have_joinable)) { |
|
944 | + updateSettings(array('show_group_membership' => $have_joinable ? 1 : 0)); |
|
945 | + } |
|
919 | 946 | } |
920 | 947 | |
921 | 948 | // Do we need to set inherited permissions? |
@@ -948,8 +975,9 @@ discard block |
||
948 | 975 | { |
949 | 976 | $moderators[$k] = trim($moderators[$k]); |
950 | 977 | |
951 | - if (strlen($moderators[$k]) == 0) |
|
952 | - unset($moderators[$k]); |
|
978 | + if (strlen($moderators[$k]) == 0) { |
|
979 | + unset($moderators[$k]); |
|
980 | + } |
|
953 | 981 | } |
954 | 982 | |
955 | 983 | // Find all the id_member's for the member_name's in the list. |
@@ -965,8 +993,9 @@ discard block |
||
965 | 993 | 'count' => count($moderators), |
966 | 994 | ) |
967 | 995 | ); |
968 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
969 | - $group_moderators[] = $row['id_member']; |
|
996 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
997 | + $group_moderators[] = $row['id_member']; |
|
998 | + } |
|
970 | 999 | $smcFunc['db_free_result']($request); |
971 | 1000 | } |
972 | 1001 | } |
@@ -974,8 +1003,9 @@ discard block |
||
974 | 1003 | if (!empty($_POST['moderator_list'])) |
975 | 1004 | { |
976 | 1005 | $moderators = array(); |
977 | - foreach ($_POST['moderator_list'] as $moderator) |
|
978 | - $moderators[] = (int) $moderator; |
|
1006 | + foreach ($_POST['moderator_list'] as $moderator) { |
|
1007 | + $moderators[] = (int) $moderator; |
|
1008 | + } |
|
979 | 1009 | |
980 | 1010 | if (!empty($moderators)) |
981 | 1011 | { |
@@ -989,8 +1019,9 @@ discard block |
||
989 | 1019 | 'num_moderators' => count($moderators), |
990 | 1020 | ) |
991 | 1021 | ); |
992 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
993 | - $group_moderators[] = $row['id_member']; |
|
1022 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1023 | + $group_moderators[] = $row['id_member']; |
|
1024 | + } |
|
994 | 1025 | $smcFunc['db_free_result']($request); |
995 | 1026 | } |
996 | 1027 | } |
@@ -1002,8 +1033,9 @@ discard block |
||
1002 | 1033 | if (!empty($group_moderators)) |
1003 | 1034 | { |
1004 | 1035 | $mod_insert = array(); |
1005 | - foreach ($group_moderators as $moderator) |
|
1006 | - $mod_insert[] = array($_REQUEST['group'], $moderator); |
|
1036 | + foreach ($group_moderators as $moderator) { |
|
1037 | + $mod_insert[] = array($_REQUEST['group'], $moderator); |
|
1038 | + } |
|
1007 | 1039 | |
1008 | 1040 | $smcFunc['db_insert']('insert', |
1009 | 1041 | '{db_prefix}group_moderators', |
@@ -1037,8 +1069,9 @@ discard block |
||
1037 | 1069 | 'current_group' => (int) $_REQUEST['group'], |
1038 | 1070 | ) |
1039 | 1071 | ); |
1040 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1041 | - fatal_lang_error('membergroup_does_not_exist', false); |
|
1072 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1073 | + fatal_lang_error('membergroup_does_not_exist', false); |
|
1074 | + } |
|
1042 | 1075 | $row = $smcFunc['db_fetch_assoc']($request); |
1043 | 1076 | $smcFunc['db_free_result']($request); |
1044 | 1077 | |
@@ -1075,14 +1108,16 @@ discard block |
||
1075 | 1108 | ) |
1076 | 1109 | ); |
1077 | 1110 | $context['group']['moderators'] = array(); |
1078 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1079 | - $context['group']['moderators'][$row['id_member']] = $row['real_name']; |
|
1111 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1112 | + $context['group']['moderators'][$row['id_member']] = $row['real_name']; |
|
1113 | + } |
|
1080 | 1114 | $smcFunc['db_free_result']($request); |
1081 | 1115 | |
1082 | 1116 | $context['group']['moderator_list'] = empty($context['group']['moderators']) ? '' : '"' . implode('", "', $context['group']['moderators']) . '"'; |
1083 | 1117 | |
1084 | - if (!empty($context['group']['moderators'])) |
|
1085 | - list ($context['group']['last_moderator_id']) = array_slice(array_keys($context['group']['moderators']), -1); |
|
1118 | + if (!empty($context['group']['moderators'])) { |
|
1119 | + list ($context['group']['last_moderator_id']) = array_slice(array_keys($context['group']['moderators']), -1); |
|
1120 | + } |
|
1086 | 1121 | |
1087 | 1122 | // Get a list of boards this membergroup is allowed to see. |
1088 | 1123 | $context['boards'] = array(); |
@@ -1102,12 +1137,13 @@ discard block |
||
1102 | 1137 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1103 | 1138 | { |
1104 | 1139 | // This category hasn't been set up yet.. |
1105 | - if (!isset($context['categories'][$row['id_cat']])) |
|
1106 | - $context['categories'][$row['id_cat']] = array( |
|
1140 | + if (!isset($context['categories'][$row['id_cat']])) { |
|
1141 | + $context['categories'][$row['id_cat']] = array( |
|
1107 | 1142 | 'id' => $row['id_cat'], |
1108 | 1143 | 'name' => $row['cat_name'], |
1109 | 1144 | 'boards' => array() |
1110 | 1145 | ); |
1146 | + } |
|
1111 | 1147 | |
1112 | 1148 | // Set this board up, and let the template know when it's a child. (indent them..) |
1113 | 1149 | $context['categories'][$row['id_cat']]['boards'][$row['id_board']] = array( |
@@ -1155,19 +1191,22 @@ discard block |
||
1155 | 1191 | $image_info = getimagesize($settings['default_theme_dir'] . '/images/membericons/' . $value); |
1156 | 1192 | |
1157 | 1193 | // If this is bigger than 128 in width or 32 in height, skip this one. |
1158 | - if ($image_info == false || $image_info[0] > 128 || $image_info[1] > 32) |
|
1159 | - continue; |
|
1194 | + if ($image_info == false || $image_info[0] > 128 || $image_info[1] > 32) { |
|
1195 | + continue; |
|
1196 | + } |
|
1160 | 1197 | |
1161 | 1198 | // Else it's valid. Add it in. |
1162 | - else |
|
1163 | - $context['possible_icons'][] = $value; |
|
1199 | + else { |
|
1200 | + $context['possible_icons'][] = $value; |
|
1201 | + } |
|
1164 | 1202 | } |
1165 | 1203 | } |
1166 | 1204 | } |
1167 | 1205 | |
1168 | 1206 | // Insert our JS, if we have possible icons. |
1169 | - if (!empty($context['possible_icons'])) |
|
1170 | - loadJavaScriptFile('icondropdown.js', array('validate' => true), 'smf_icondropdown'); |
|
1207 | + if (!empty($context['possible_icons'])) { |
|
1208 | + loadJavaScriptFile('icondropdown.js', array('validate' => true), 'smf_icondropdown'); |
|
1209 | + } |
|
1171 | 1210 | |
1172 | 1211 | loadJavaScriptFile('suggest.js', array('defer' => false), 'smf_suggest'); |
1173 | 1212 | |
@@ -1189,8 +1228,9 @@ discard block |
||
1189 | 1228 | ) |
1190 | 1229 | ); |
1191 | 1230 | $context['inheritable_groups'] = array(); |
1192 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1193 | - $context['inheritable_groups'][$row['id_group']] = $row['group_name']; |
|
1231 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1232 | + $context['inheritable_groups'][$row['id_group']] = $row['group_name']; |
|
1233 | + } |
|
1194 | 1234 | $smcFunc['db_free_result']($request); |
1195 | 1235 | |
1196 | 1236 | call_integration_hook('integrate_view_membergroup'); |
@@ -141,7 +141,7 @@ discard block |
||
141 | 141 | /** |
142 | 142 | * Make files writable. First try to use regular chmod, but if that fails, try to use FTP. |
143 | 143 | * |
144 | - * @param $files |
|
144 | + * @param string[] $files |
|
145 | 145 | * @return bool |
146 | 146 | */ |
147 | 147 | function makeFilesWritable(&$files) |
@@ -381,7 +381,7 @@ discard block |
||
381 | 381 | /** |
382 | 382 | * Prints an error to stderr. |
383 | 383 | * |
384 | - * @param $message |
|
384 | + * @param string $message |
|
385 | 385 | * @param bool $fatal |
386 | 386 | */ |
387 | 387 | function print_error($message, $fatal = false) |
@@ -400,7 +400,7 @@ discard block |
||
400 | 400 | /** |
401 | 401 | * Throws a graphical error message. |
402 | 402 | * |
403 | - * @param $message |
|
403 | + * @param string $message |
|
404 | 404 | * @return bool |
405 | 405 | */ |
406 | 406 | function throw_error($message) |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * This file contains helper functions for upgrade.php |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF_VERSION')) |
|
16 | +if (!defined('SMF_VERSION')) { |
|
17 | 17 | die('No direct access!'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Clean the cache using the SMF 2.1 CacheAPI. |
@@ -45,8 +46,9 @@ discard block |
||
45 | 46 | global $smcFunc; |
46 | 47 | static $member_groups = array(); |
47 | 48 | |
48 | - if (!empty($member_groups)) |
|
49 | - return $member_groups; |
|
49 | + if (!empty($member_groups)) { |
|
50 | + return $member_groups; |
|
51 | + } |
|
50 | 52 | |
51 | 53 | $request = $smcFunc['db_query']('', ' |
52 | 54 | SELECT group_name, id_group |
@@ -71,8 +73,9 @@ discard block |
||
71 | 73 | ) |
72 | 74 | ); |
73 | 75 | } |
74 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
75 | - $member_groups[trim($row[0])] = $row[1]; |
|
76 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
77 | + $member_groups[trim($row[0])] = $row[1]; |
|
78 | + } |
|
76 | 79 | $smcFunc['db_free_result']($request); |
77 | 80 | |
78 | 81 | return $member_groups; |
@@ -88,8 +91,9 @@ discard block |
||
88 | 91 | { |
89 | 92 | global $upcontext, $boarddir, $sourcedir; |
90 | 93 | |
91 | - if (empty($files)) |
|
92 | - return true; |
|
94 | + if (empty($files)) { |
|
95 | + return true; |
|
96 | + } |
|
93 | 97 | |
94 | 98 | $failure = false; |
95 | 99 | // On linux, it's easy - just use is_writable! |
@@ -104,14 +108,16 @@ discard block |
||
104 | 108 | @chmod($file, 0755); |
105 | 109 | |
106 | 110 | // Well, 755 hopefully worked... if not, try 777. |
107 | - if (!is_writable($file) && !@chmod($file, 0777)) |
|
108 | - $failure = true; |
|
111 | + if (!is_writable($file) && !@chmod($file, 0777)) { |
|
112 | + $failure = true; |
|
113 | + } |
|
109 | 114 | // Otherwise remove it as it's good! |
110 | - else |
|
111 | - unset($files[$k]); |
|
115 | + else { |
|
116 | + unset($files[$k]); |
|
117 | + } |
|
118 | + } else { |
|
119 | + unset($files[$k]); |
|
112 | 120 | } |
113 | - else |
|
114 | - unset($files[$k]); |
|
115 | 121 | } |
116 | 122 | } |
117 | 123 | // Windows is trickier. Let's try opening for r+... |
@@ -122,30 +128,35 @@ discard block |
||
122 | 128 | foreach ($files as $k => $file) |
123 | 129 | { |
124 | 130 | // Folders can't be opened for write... but the index.php in them can ;). |
125 | - if (is_dir($file)) |
|
126 | - $file .= '/index.php'; |
|
131 | + if (is_dir($file)) { |
|
132 | + $file .= '/index.php'; |
|
133 | + } |
|
127 | 134 | |
128 | 135 | // Funny enough, chmod actually does do something on windows - it removes the read only attribute. |
129 | 136 | @chmod($file, 0777); |
130 | 137 | $fp = @fopen($file, 'r+'); |
131 | 138 | |
132 | 139 | // Hmm, okay, try just for write in that case... |
133 | - if (!$fp) |
|
134 | - $fp = @fopen($file, 'w'); |
|
140 | + if (!$fp) { |
|
141 | + $fp = @fopen($file, 'w'); |
|
142 | + } |
|
135 | 143 | |
136 | - if (!$fp) |
|
137 | - $failure = true; |
|
138 | - else |
|
139 | - unset($files[$k]); |
|
144 | + if (!$fp) { |
|
145 | + $failure = true; |
|
146 | + } else { |
|
147 | + unset($files[$k]); |
|
148 | + } |
|
140 | 149 | @fclose($fp); |
141 | 150 | } |
142 | 151 | } |
143 | 152 | |
144 | - if (empty($files)) |
|
145 | - return true; |
|
153 | + if (empty($files)) { |
|
154 | + return true; |
|
155 | + } |
|
146 | 156 | |
147 | - if (!isset($_SERVER)) |
|
148 | - return !$failure; |
|
157 | + if (!isset($_SERVER)) { |
|
158 | + return !$failure; |
|
159 | + } |
|
149 | 160 | |
150 | 161 | // What still needs to be done? |
151 | 162 | $upcontext['chmod']['files'] = $files; |
@@ -197,36 +208,40 @@ discard block |
||
197 | 208 | |
198 | 209 | if (!isset($ftp) || $ftp->error !== false) |
199 | 210 | { |
200 | - if (!isset($ftp)) |
|
201 | - $ftp = new ftp_connection(null); |
|
211 | + if (!isset($ftp)) { |
|
212 | + $ftp = new ftp_connection(null); |
|
213 | + } |
|
202 | 214 | // Save the error so we can mess with listing... |
203 | - elseif ($ftp->error !== false && !isset($upcontext['chmod']['ftp_error'])) |
|
204 | - $upcontext['chmod']['ftp_error'] = $ftp->last_message === null ? '' : $ftp->last_message; |
|
215 | + elseif ($ftp->error !== false && !isset($upcontext['chmod']['ftp_error'])) { |
|
216 | + $upcontext['chmod']['ftp_error'] = $ftp->last_message === null ? '' : $ftp->last_message; |
|
217 | + } |
|
205 | 218 | |
206 | 219 | list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__)); |
207 | 220 | |
208 | - if ($found_path || !isset($upcontext['chmod']['path'])) |
|
209 | - $upcontext['chmod']['path'] = $detect_path; |
|
221 | + if ($found_path || !isset($upcontext['chmod']['path'])) { |
|
222 | + $upcontext['chmod']['path'] = $detect_path; |
|
223 | + } |
|
210 | 224 | |
211 | - if (!isset($upcontext['chmod']['username'])) |
|
212 | - $upcontext['chmod']['username'] = $username; |
|
225 | + if (!isset($upcontext['chmod']['username'])) { |
|
226 | + $upcontext['chmod']['username'] = $username; |
|
227 | + } |
|
213 | 228 | |
214 | 229 | // Don't forget the login token. |
215 | 230 | $upcontext += createToken('login'); |
216 | 231 | |
217 | 232 | return false; |
218 | - } |
|
219 | - else |
|
233 | + } else |
|
220 | 234 | { |
221 | 235 | // We want to do a relative path for FTP. |
222 | 236 | if (!in_array($upcontext['chmod']['path'], array('', '/'))) |
223 | 237 | { |
224 | 238 | $ftp_root = strtr($boarddir, array($upcontext['chmod']['path'] => '')); |
225 | - if (substr($ftp_root, -1) == '/' && ($upcontext['chmod']['path'] == '' || $upcontext['chmod']['path'][0] === '/')) |
|
226 | - $ftp_root = substr($ftp_root, 0, -1); |
|
239 | + if (substr($ftp_root, -1) == '/' && ($upcontext['chmod']['path'] == '' || $upcontext['chmod']['path'][0] === '/')) { |
|
240 | + $ftp_root = substr($ftp_root, 0, -1); |
|
241 | + } |
|
242 | + } else { |
|
243 | + $ftp_root = $boarddir; |
|
227 | 244 | } |
228 | - else |
|
229 | - $ftp_root = $boarddir; |
|
230 | 245 | |
231 | 246 | // Save the info for next time! |
232 | 247 | $_SESSION['installer_temp_ftp'] = array( |
@@ -240,10 +255,12 @@ discard block |
||
240 | 255 | |
241 | 256 | foreach ($files as $k => $file) |
242 | 257 | { |
243 | - if (!is_writable($file)) |
|
244 | - $ftp->chmod($file, 0755); |
|
245 | - if (!is_writable($file)) |
|
246 | - $ftp->chmod($file, 0777); |
|
258 | + if (!is_writable($file)) { |
|
259 | + $ftp->chmod($file, 0755); |
|
260 | + } |
|
261 | + if (!is_writable($file)) { |
|
262 | + $ftp->chmod($file, 0777); |
|
263 | + } |
|
247 | 264 | |
248 | 265 | // Assuming that didn't work calculate the path without the boarddir. |
249 | 266 | if (!is_writable($file)) |
@@ -252,19 +269,23 @@ discard block |
||
252 | 269 | { |
253 | 270 | $ftp_file = strtr($file, array($_SESSION['installer_temp_ftp']['root'] => '')); |
254 | 271 | $ftp->chmod($ftp_file, 0755); |
255 | - if (!is_writable($file)) |
|
256 | - $ftp->chmod($ftp_file, 0777); |
|
272 | + if (!is_writable($file)) { |
|
273 | + $ftp->chmod($ftp_file, 0777); |
|
274 | + } |
|
257 | 275 | // Sometimes an extra slash can help... |
258 | 276 | $ftp_file = '/' . $ftp_file; |
259 | - if (!is_writable($file)) |
|
260 | - $ftp->chmod($ftp_file, 0755); |
|
261 | - if (!is_writable($file)) |
|
262 | - $ftp->chmod($ftp_file, 0777); |
|
277 | + if (!is_writable($file)) { |
|
278 | + $ftp->chmod($ftp_file, 0755); |
|
279 | + } |
|
280 | + if (!is_writable($file)) { |
|
281 | + $ftp->chmod($ftp_file, 0777); |
|
282 | + } |
|
263 | 283 | } |
264 | 284 | } |
265 | 285 | |
266 | - if (is_writable($file)) |
|
267 | - unset($files[$k]); |
|
286 | + if (is_writable($file)) { |
|
287 | + unset($files[$k]); |
|
288 | + } |
|
268 | 289 | } |
269 | 290 | |
270 | 291 | $ftp->close(); |
@@ -274,8 +295,9 @@ discard block |
||
274 | 295 | // What remains? |
275 | 296 | $upcontext['chmod']['files'] = $files; |
276 | 297 | |
277 | - if (empty($files)) |
|
278 | - return true; |
|
298 | + if (empty($files)) { |
|
299 | + return true; |
|
300 | + } |
|
279 | 301 | |
280 | 302 | return false; |
281 | 303 | } |
@@ -288,8 +310,9 @@ discard block |
||
288 | 310 | */ |
289 | 311 | function quickFileWritable($file) |
290 | 312 | { |
291 | - if (is_writable($file)) |
|
292 | - return true; |
|
313 | + if (is_writable($file)) { |
|
314 | + return true; |
|
315 | + } |
|
293 | 316 | |
294 | 317 | @chmod($file, 0755); |
295 | 318 | |
@@ -299,10 +322,11 @@ discard block |
||
299 | 322 | foreach ($chmod_values as $val) |
300 | 323 | { |
301 | 324 | // If it's writable, break out of the loop |
302 | - if (is_writable($file)) |
|
303 | - break; |
|
304 | - else |
|
305 | - @chmod($file, $val); |
|
325 | + if (is_writable($file)) { |
|
326 | + break; |
|
327 | + } else { |
|
328 | + @chmod($file, $val); |
|
329 | + } |
|
306 | 330 | } |
307 | 331 | |
308 | 332 | return is_writable($file); |
@@ -329,14 +353,16 @@ discard block |
||
329 | 353 | { |
330 | 354 | static $fp = null; |
331 | 355 | |
332 | - if ($fp === null) |
|
333 | - $fp = fopen('php://stderr', 'wb'); |
|
356 | + if ($fp === null) { |
|
357 | + $fp = fopen('php://stderr', 'wb'); |
|
358 | + } |
|
334 | 359 | |
335 | 360 | fwrite($fp, $message . "\n"); |
336 | 361 | |
337 | - if ($fatal) |
|
338 | - exit; |
|
339 | -} |
|
362 | + if ($fatal) { |
|
363 | + exit; |
|
364 | + } |
|
365 | + } |
|
340 | 366 | |
341 | 367 | /** |
342 | 368 | * Throws a graphical error message. |
@@ -104,7 +104,7 @@ |
||
104 | 104 | * |
105 | 105 | * @param string $class The fully-qualified class name. |
106 | 106 | */ |
107 | -spl_autoload_register(function ($class) use ($sourcedir) |
|
107 | +spl_autoload_register(function($class) use ($sourcedir) |
|
108 | 108 | { |
109 | 109 | $classMap = array( |
110 | 110 | 'ReCaptcha\\' => 'ReCaptcha/', |
@@ -32,16 +32,18 @@ discard block |
||
32 | 32 | ob_start(); |
33 | 33 | |
34 | 34 | // Do some cleaning, just in case. |
35 | -foreach (array('db_character_set', 'cachedir') as $variable) |
|
35 | +foreach (array('db_character_set', 'cachedir') as $variable) { |
|
36 | 36 | if (isset($GLOBALS[$variable])) |
37 | 37 | unset($GLOBALS[$variable], $GLOBALS[$variable]); |
38 | +} |
|
38 | 39 | |
39 | 40 | // Load the settings... |
40 | 41 | require_once(dirname(__FILE__) . '/Settings.php'); |
41 | 42 | |
42 | 43 | // Make absolutely sure the cache directory is defined. |
43 | -if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) |
|
44 | +if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) { |
|
44 | 45 | $cachedir = $boarddir . '/cache'; |
46 | +} |
|
45 | 47 | |
46 | 48 | // Without those we can't go anywhere |
47 | 49 | require_once($sourcedir . '/QueryString.php'); |
@@ -51,8 +53,9 @@ discard block |
||
51 | 53 | require_once($sourcedir . '/Load.php'); |
52 | 54 | |
53 | 55 | // If $maintenance is set specifically to 2, then we're upgrading or something. |
54 | -if (!empty($maintenance) && $maintenance == 2) |
|
56 | +if (!empty($maintenance) && $maintenance == 2) { |
|
55 | 57 | display_maintenance_message(); |
58 | +} |
|
56 | 59 | |
57 | 60 | // Create a variable to store some SMF specific functions in. |
58 | 61 | $smcFunc = array(); |
@@ -67,8 +70,9 @@ discard block |
||
67 | 70 | cleanRequest(); |
68 | 71 | |
69 | 72 | // Seed the random generator. |
70 | -if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) |
|
73 | +if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) { |
|
71 | 74 | smf_seed_generator(); |
75 | +} |
|
72 | 76 | |
73 | 77 | // Before we get carried away, are we doing a scheduled task? If so save CPU cycles by jumping out! |
74 | 78 | if (isset($_GET['scheduled'])) |
@@ -88,9 +92,9 @@ discard block |
||
88 | 92 | if (!empty($modSettings['enableCompressedOutput']) && !headers_sent()) |
89 | 93 | { |
90 | 94 | // If zlib is being used, turn off output compression. |
91 | - if (ini_get('zlib.output_compression') >= 1 || ini_get('output_handler') == 'ob_gzhandler') |
|
92 | - $modSettings['enableCompressedOutput'] = '0'; |
|
93 | - else |
|
95 | + if (ini_get('zlib.output_compression') >= 1 || ini_get('output_handler') == 'ob_gzhandler') { |
|
96 | + $modSettings['enableCompressedOutput'] = '0'; |
|
97 | + } else |
|
94 | 98 | { |
95 | 99 | ob_end_clean(); |
96 | 100 | ob_start('ob_gzhandler'); |
@@ -182,18 +186,21 @@ discard block |
||
182 | 186 | loadPermissions(); |
183 | 187 | |
184 | 188 | // Attachments don't require the entire theme to be loaded. |
185 | - if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach') |
|
186 | - detectBrowser(); |
|
189 | + if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach') { |
|
190 | + detectBrowser(); |
|
191 | + } |
|
187 | 192 | // Load the current theme. (note that ?theme=1 will also work, may be used for guest theming.) |
188 | - else |
|
189 | - loadTheme(); |
|
193 | + else { |
|
194 | + loadTheme(); |
|
195 | + } |
|
190 | 196 | |
191 | 197 | // Check if the user should be disallowed access. |
192 | 198 | is_not_banned(); |
193 | 199 | |
194 | 200 | // If we are in a topic and don't have permission to approve it then duck out now. |
195 | - if (!empty($topic) && empty($board_info['cur_topic_approved']) && !allowedTo('approve_posts') && ($user_info['id'] != $board_info['cur_topic_starter'] || $user_info['is_guest'])) |
|
196 | - fatal_lang_error('not_a_topic', false); |
|
201 | + if (!empty($topic) && empty($board_info['cur_topic_approved']) && !allowedTo('approve_posts') && ($user_info['id'] != $board_info['cur_topic_starter'] || $user_info['is_guest'])) { |
|
202 | + fatal_lang_error('not_a_topic', false); |
|
203 | + } |
|
197 | 204 | |
198 | 205 | $no_stat_actions = array('clock', 'dlattach', 'findmember', 'jsoption', 'likes', 'loadeditorlocale', 'modifycat', 'requestmembers', 'smstats', 'suggest', 'about:unknown', '.xml', 'xmlhttp', 'verificationcode', 'viewquery', 'viewsmfile'); |
199 | 206 | call_integration_hook('integrate_pre_log_stats', array(&$no_stat_actions)); |
@@ -204,8 +211,9 @@ discard block |
||
204 | 211 | writeLog(); |
205 | 212 | |
206 | 213 | // Track forum statistics and hits...? |
207 | - if (!empty($modSettings['hitStats'])) |
|
208 | - trackStats(array('hits' => '+')); |
|
214 | + if (!empty($modSettings['hitStats'])) { |
|
215 | + trackStats(array('hits' => '+')); |
|
216 | + } |
|
209 | 217 | } |
210 | 218 | unset($no_stat_actions); |
211 | 219 | |
@@ -219,13 +227,14 @@ discard block |
||
219 | 227 | return ($_REQUEST['action'] == 'login2' ? 'Login2' : ($_REQUEST['action'] == 'logintfa' ? 'LoginTFA' : 'Logout')); |
220 | 228 | } |
221 | 229 | // Don't even try it, sonny. |
222 | - else |
|
223 | - return 'InMaintenance'; |
|
230 | + else { |
|
231 | + return 'InMaintenance'; |
|
232 | + } |
|
224 | 233 | } |
225 | 234 | // If guest access is off, a guest can only do one of the very few following actions. |
226 | - elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'logintfa', 'reminder', 'activate', 'help', 'helpadmin', 'smstats', 'verificationcode', 'signup', 'signup2')))) |
|
227 | - return 'KickGuest'; |
|
228 | - elseif (empty($_REQUEST['action'])) |
|
235 | + elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'logintfa', 'reminder', 'activate', 'help', 'helpadmin', 'smstats', 'verificationcode', 'signup', 'signup2')))) { |
|
236 | + return 'KickGuest'; |
|
237 | + } elseif (empty($_REQUEST['action'])) |
|
229 | 238 | { |
230 | 239 | // Action and board are both empty... BoardIndex! Unless someone else wants to do something different. |
231 | 240 | if (empty($board) && empty($topic)) |
@@ -239,8 +248,9 @@ discard block |
||
239 | 248 | |
240 | 249 | $call = call_helper($defaultAction, true); |
241 | 250 | |
242 | - if (!empty($call)) |
|
243 | - return $call; |
|
251 | + if (!empty($call)) { |
|
252 | + return $call; |
|
253 | + } |
|
244 | 254 | } |
245 | 255 | |
246 | 256 | // No default action huh? then go to our good old BoardIndex. |
@@ -370,8 +380,9 @@ discard block |
||
370 | 380 | |
371 | 381 | $call = call_helper($fallbackAction, true); |
372 | 382 | |
373 | - if (!empty($call)) |
|
374 | - return $call; |
|
383 | + if (!empty($call)) { |
|
384 | + return $call; |
|
385 | + } |
|
375 | 386 | } |
376 | 387 | |
377 | 388 | // No fallback action, huh? |
@@ -18,178 +18,178 @@ |
||
18 | 18 | */ |
19 | 19 | class Converter |
20 | 20 | { |
21 | - /** |
|
22 | - * @var string |
|
23 | - */ |
|
24 | - protected $from; |
|
25 | - |
|
26 | - /** |
|
27 | - * @var string |
|
28 | - */ |
|
29 | - protected $to; |
|
30 | - |
|
31 | - /** |
|
32 | - * @param string $from The original base path (directory, not file!) |
|
33 | - * @param string $to The new base path (directory, not file!) |
|
34 | - */ |
|
35 | - public function __construct($from, $to) |
|
36 | - { |
|
37 | - $shared = $this->shared($from, $to); |
|
38 | - if ($shared === '') { |
|
39 | - // when both paths have nothing in common, one of them is probably |
|
40 | - // absolute while the other is relative |
|
41 | - $cwd = getcwd(); |
|
42 | - $from = strpos($from, $cwd) === 0 ? $from : $cwd.'/'.$from; |
|
43 | - $to = strpos($to, $cwd) === 0 ? $to : $cwd.'/'.$to; |
|
44 | - |
|
45 | - // or traveling the tree via `..` |
|
46 | - // attempt to resolve path, or assume it's fine if it doesn't exist |
|
47 | - $from = realpath($from) ?: $from; |
|
48 | - $to = realpath($to) ?: $to; |
|
49 | - } |
|
50 | - |
|
51 | - $from = $this->dirname($from); |
|
52 | - $to = $this->dirname($to); |
|
53 | - |
|
54 | - $from = $this->normalize($from); |
|
55 | - $to = $this->normalize($to); |
|
56 | - |
|
57 | - $this->from = $from; |
|
58 | - $this->to = $to; |
|
59 | - } |
|
60 | - |
|
61 | - /** |
|
62 | - * Normalize path. |
|
63 | - * |
|
64 | - * @param string $path |
|
65 | - * |
|
66 | - * @return string |
|
67 | - */ |
|
68 | - protected function normalize($path) |
|
69 | - { |
|
70 | - // deal with different operating systems' directory structure |
|
71 | - $path = rtrim(str_replace(DIRECTORY_SEPARATOR, '/', $path), '/'); |
|
72 | - |
|
73 | - /* |
|
21 | + /** |
|
22 | + * @var string |
|
23 | + */ |
|
24 | + protected $from; |
|
25 | + |
|
26 | + /** |
|
27 | + * @var string |
|
28 | + */ |
|
29 | + protected $to; |
|
30 | + |
|
31 | + /** |
|
32 | + * @param string $from The original base path (directory, not file!) |
|
33 | + * @param string $to The new base path (directory, not file!) |
|
34 | + */ |
|
35 | + public function __construct($from, $to) |
|
36 | + { |
|
37 | + $shared = $this->shared($from, $to); |
|
38 | + if ($shared === '') { |
|
39 | + // when both paths have nothing in common, one of them is probably |
|
40 | + // absolute while the other is relative |
|
41 | + $cwd = getcwd(); |
|
42 | + $from = strpos($from, $cwd) === 0 ? $from : $cwd.'/'.$from; |
|
43 | + $to = strpos($to, $cwd) === 0 ? $to : $cwd.'/'.$to; |
|
44 | + |
|
45 | + // or traveling the tree via `..` |
|
46 | + // attempt to resolve path, or assume it's fine if it doesn't exist |
|
47 | + $from = realpath($from) ?: $from; |
|
48 | + $to = realpath($to) ?: $to; |
|
49 | + } |
|
50 | + |
|
51 | + $from = $this->dirname($from); |
|
52 | + $to = $this->dirname($to); |
|
53 | + |
|
54 | + $from = $this->normalize($from); |
|
55 | + $to = $this->normalize($to); |
|
56 | + |
|
57 | + $this->from = $from; |
|
58 | + $this->to = $to; |
|
59 | + } |
|
60 | + |
|
61 | + /** |
|
62 | + * Normalize path. |
|
63 | + * |
|
64 | + * @param string $path |
|
65 | + * |
|
66 | + * @return string |
|
67 | + */ |
|
68 | + protected function normalize($path) |
|
69 | + { |
|
70 | + // deal with different operating systems' directory structure |
|
71 | + $path = rtrim(str_replace(DIRECTORY_SEPARATOR, '/', $path), '/'); |
|
72 | + |
|
73 | + /* |
|
74 | 74 | * Example: |
75 | 75 | * /home/forkcms/frontend/cache/compiled_templates/../../core/layout/css/../images/img.gif |
76 | 76 | * to |
77 | 77 | * /home/forkcms/frontend/core/layout/images/img.gif |
78 | 78 | */ |
79 | - do { |
|
80 | - $path = preg_replace('/[^\/]+(?<!\.\.)\/\.\.\//', '', $path, -1, $count); |
|
81 | - } while ($count); |
|
82 | - |
|
83 | - return $path; |
|
84 | - } |
|
85 | - |
|
86 | - /** |
|
87 | - * Figure out the shared path of 2 locations. |
|
88 | - * |
|
89 | - * Example: |
|
90 | - * /home/forkcms/frontend/core/layout/images/img.gif |
|
91 | - * and |
|
92 | - * /home/forkcms/frontend/cache/minified_css |
|
93 | - * share |
|
94 | - * /home/forkcms/frontend |
|
95 | - * |
|
96 | - * @param string $path1 |
|
97 | - * @param string $path2 |
|
98 | - * |
|
99 | - * @return string |
|
100 | - */ |
|
101 | - protected function shared($path1, $path2) |
|
102 | - { |
|
103 | - // $path could theoretically be empty (e.g. no path is given), in which |
|
104 | - // case it shouldn't expand to array(''), which would compare to one's |
|
105 | - // root / |
|
106 | - $path1 = $path1 ? explode('/', $path1) : array(); |
|
107 | - $path2 = $path2 ? explode('/', $path2) : array(); |
|
108 | - |
|
109 | - $shared = array(); |
|
110 | - |
|
111 | - // compare paths & strip identical ancestors |
|
112 | - foreach ($path1 as $i => $chunk) { |
|
113 | - if (isset($path2[$i]) && $path1[$i] == $path2[$i]) { |
|
114 | - $shared[] = $chunk; |
|
115 | - } else { |
|
116 | - break; |
|
117 | - } |
|
118 | - } |
|
119 | - |
|
120 | - return implode('/', $shared); |
|
121 | - } |
|
122 | - |
|
123 | - /** |
|
124 | - * Convert paths relative from 1 file to another. |
|
125 | - * |
|
126 | - * E.g. |
|
127 | - * ../images/img.gif relative to /home/forkcms/frontend/core/layout/css |
|
128 | - * should become: |
|
129 | - * ../../core/layout/images/img.gif relative to |
|
130 | - * /home/forkcms/frontend/cache/minified_css |
|
131 | - * |
|
132 | - * @param string $path The relative path that needs to be converted. |
|
133 | - * |
|
134 | - * @return string The new relative path. |
|
135 | - */ |
|
136 | - public function convert($path) |
|
137 | - { |
|
138 | - // quit early if conversion makes no sense |
|
139 | - if ($this->from === $this->to) { |
|
140 | - return $path; |
|
141 | - } |
|
142 | - |
|
143 | - $path = $this->normalize($path); |
|
144 | - // if we're not dealing with a relative path, just return absolute |
|
145 | - if (strpos($path, '/') === 0) { |
|
146 | - return $path; |
|
147 | - } |
|
148 | - |
|
149 | - // normalize paths |
|
150 | - $path = $this->normalize($this->from.'/'.$path); |
|
151 | - |
|
152 | - // strip shared ancestor paths |
|
153 | - $shared = $this->shared($path, $this->to); |
|
154 | - $path = mb_substr($path, mb_strlen($shared)); |
|
155 | - $to = mb_substr($this->to, mb_strlen($shared)); |
|
156 | - |
|
157 | - // add .. for every directory that needs to be traversed to new path |
|
158 | - $to = str_repeat('../', mb_substr_count($to, '/')); |
|
159 | - |
|
160 | - return $to.ltrim($path, '/'); |
|
161 | - } |
|
162 | - |
|
163 | - /** |
|
164 | - * Attempt to get the directory name from a path. |
|
165 | - * |
|
166 | - * @param string $path |
|
167 | - * |
|
168 | - * @return string |
|
169 | - */ |
|
170 | - public function dirname($path) |
|
171 | - { |
|
172 | - if (is_file($path)) { |
|
173 | - return dirname($path); |
|
174 | - } |
|
175 | - |
|
176 | - if (is_dir($path)) { |
|
177 | - return rtrim($path, '/'); |
|
178 | - } |
|
179 | - |
|
180 | - // no known file/dir, start making assumptions |
|
181 | - |
|
182 | - // ends in / = dir |
|
183 | - if (mb_substr($path, -1) === '/') { |
|
184 | - return rtrim($path, '/'); |
|
185 | - } |
|
186 | - |
|
187 | - // has a dot in the name, likely a file |
|
188 | - if (preg_match('/.*\..*$/', basename($path)) !== 0) { |
|
189 | - return dirname($path); |
|
190 | - } |
|
191 | - |
|
192 | - // you're on your own here! |
|
193 | - return $path; |
|
194 | - } |
|
79 | + do { |
|
80 | + $path = preg_replace('/[^\/]+(?<!\.\.)\/\.\.\//', '', $path, -1, $count); |
|
81 | + } while ($count); |
|
82 | + |
|
83 | + return $path; |
|
84 | + } |
|
85 | + |
|
86 | + /** |
|
87 | + * Figure out the shared path of 2 locations. |
|
88 | + * |
|
89 | + * Example: |
|
90 | + * /home/forkcms/frontend/core/layout/images/img.gif |
|
91 | + * and |
|
92 | + * /home/forkcms/frontend/cache/minified_css |
|
93 | + * share |
|
94 | + * /home/forkcms/frontend |
|
95 | + * |
|
96 | + * @param string $path1 |
|
97 | + * @param string $path2 |
|
98 | + * |
|
99 | + * @return string |
|
100 | + */ |
|
101 | + protected function shared($path1, $path2) |
|
102 | + { |
|
103 | + // $path could theoretically be empty (e.g. no path is given), in which |
|
104 | + // case it shouldn't expand to array(''), which would compare to one's |
|
105 | + // root / |
|
106 | + $path1 = $path1 ? explode('/', $path1) : array(); |
|
107 | + $path2 = $path2 ? explode('/', $path2) : array(); |
|
108 | + |
|
109 | + $shared = array(); |
|
110 | + |
|
111 | + // compare paths & strip identical ancestors |
|
112 | + foreach ($path1 as $i => $chunk) { |
|
113 | + if (isset($path2[$i]) && $path1[$i] == $path2[$i]) { |
|
114 | + $shared[] = $chunk; |
|
115 | + } else { |
|
116 | + break; |
|
117 | + } |
|
118 | + } |
|
119 | + |
|
120 | + return implode('/', $shared); |
|
121 | + } |
|
122 | + |
|
123 | + /** |
|
124 | + * Convert paths relative from 1 file to another. |
|
125 | + * |
|
126 | + * E.g. |
|
127 | + * ../images/img.gif relative to /home/forkcms/frontend/core/layout/css |
|
128 | + * should become: |
|
129 | + * ../../core/layout/images/img.gif relative to |
|
130 | + * /home/forkcms/frontend/cache/minified_css |
|
131 | + * |
|
132 | + * @param string $path The relative path that needs to be converted. |
|
133 | + * |
|
134 | + * @return string The new relative path. |
|
135 | + */ |
|
136 | + public function convert($path) |
|
137 | + { |
|
138 | + // quit early if conversion makes no sense |
|
139 | + if ($this->from === $this->to) { |
|
140 | + return $path; |
|
141 | + } |
|
142 | + |
|
143 | + $path = $this->normalize($path); |
|
144 | + // if we're not dealing with a relative path, just return absolute |
|
145 | + if (strpos($path, '/') === 0) { |
|
146 | + return $path; |
|
147 | + } |
|
148 | + |
|
149 | + // normalize paths |
|
150 | + $path = $this->normalize($this->from.'/'.$path); |
|
151 | + |
|
152 | + // strip shared ancestor paths |
|
153 | + $shared = $this->shared($path, $this->to); |
|
154 | + $path = mb_substr($path, mb_strlen($shared)); |
|
155 | + $to = mb_substr($this->to, mb_strlen($shared)); |
|
156 | + |
|
157 | + // add .. for every directory that needs to be traversed to new path |
|
158 | + $to = str_repeat('../', mb_substr_count($to, '/')); |
|
159 | + |
|
160 | + return $to.ltrim($path, '/'); |
|
161 | + } |
|
162 | + |
|
163 | + /** |
|
164 | + * Attempt to get the directory name from a path. |
|
165 | + * |
|
166 | + * @param string $path |
|
167 | + * |
|
168 | + * @return string |
|
169 | + */ |
|
170 | + public function dirname($path) |
|
171 | + { |
|
172 | + if (is_file($path)) { |
|
173 | + return dirname($path); |
|
174 | + } |
|
175 | + |
|
176 | + if (is_dir($path)) { |
|
177 | + return rtrim($path, '/'); |
|
178 | + } |
|
179 | + |
|
180 | + // no known file/dir, start making assumptions |
|
181 | + |
|
182 | + // ends in / = dir |
|
183 | + if (mb_substr($path, -1) === '/') { |
|
184 | + return rtrim($path, '/'); |
|
185 | + } |
|
186 | + |
|
187 | + // has a dot in the name, likely a file |
|
188 | + if (preg_match('/.*\..*$/', basename($path)) !== 0) { |
|
189 | + return dirname($path); |
|
190 | + } |
|
191 | + |
|
192 | + // you're on your own here! |
|
193 | + return $path; |
|
194 | + } |
|
195 | 195 | } |
@@ -39,8 +39,8 @@ discard block |
||
39 | 39 | // when both paths have nothing in common, one of them is probably |
40 | 40 | // absolute while the other is relative |
41 | 41 | $cwd = getcwd(); |
42 | - $from = strpos($from, $cwd) === 0 ? $from : $cwd.'/'.$from; |
|
43 | - $to = strpos($to, $cwd) === 0 ? $to : $cwd.'/'.$to; |
|
42 | + $from = strpos($from, $cwd) === 0 ? $from : $cwd . '/' . $from; |
|
43 | + $to = strpos($to, $cwd) === 0 ? $to : $cwd . '/' . $to; |
|
44 | 44 | |
45 | 45 | // or traveling the tree via `..` |
46 | 46 | // attempt to resolve path, or assume it's fine if it doesn't exist |
@@ -147,7 +147,7 @@ discard block |
||
147 | 147 | } |
148 | 148 | |
149 | 149 | // normalize paths |
150 | - $path = $this->normalize($this->from.'/'.$path); |
|
150 | + $path = $this->normalize($this->from . '/' . $path); |
|
151 | 151 | |
152 | 152 | // strip shared ancestor paths |
153 | 153 | $shared = $this->shared($path, $this->to); |
@@ -157,7 +157,7 @@ discard block |
||
157 | 157 | // add .. for every directory that needs to be traversed to new path |
158 | 158 | $to = str_repeat('../', mb_substr_count($to, '/')); |
159 | 159 | |
160 | - return $to.ltrim($path, '/'); |
|
160 | + return $to . ltrim($path, '/'); |
|
161 | 161 | } |
162 | 162 | |
163 | 163 | /** |
@@ -17,96 +17,96 @@ discard block |
||
17 | 17 | */ |
18 | 18 | class CSS extends Minify |
19 | 19 | { |
20 | - /** |
|
21 | - * @var int |
|
22 | - */ |
|
23 | - protected $maxImportSize = 5; |
|
24 | - |
|
25 | - /** |
|
26 | - * @var string[] |
|
27 | - */ |
|
28 | - protected $importExtensions = array( |
|
29 | - 'gif' => 'data:image/gif', |
|
30 | - 'png' => 'data:image/png', |
|
31 | - 'jpe' => 'data:image/jpeg', |
|
32 | - 'jpg' => 'data:image/jpeg', |
|
33 | - 'jpeg' => 'data:image/jpeg', |
|
34 | - 'svg' => 'data:image/svg+xml', |
|
35 | - 'woff' => 'data:application/x-font-woff', |
|
36 | - 'tif' => 'image/tiff', |
|
37 | - 'tiff' => 'image/tiff', |
|
38 | - 'xbm' => 'image/x-xbitmap', |
|
39 | - ); |
|
40 | - |
|
41 | - /** |
|
42 | - * Set the maximum size if files to be imported. |
|
43 | - * |
|
44 | - * Files larger than this size (in kB) will not be imported into the CSS. |
|
45 | - * Importing files into the CSS as data-uri will save you some connections, |
|
46 | - * but we should only import relatively small decorative images so that our |
|
47 | - * CSS file doesn't get too bulky. |
|
48 | - * |
|
49 | - * @param int $size Size in kB |
|
50 | - */ |
|
51 | - public function setMaxImportSize($size) |
|
52 | - { |
|
53 | - $this->maxImportSize = $size; |
|
54 | - } |
|
55 | - |
|
56 | - /** |
|
57 | - * Set the type of extensions to be imported into the CSS (to save network |
|
58 | - * connections). |
|
59 | - * Keys of the array should be the file extensions & respective values |
|
60 | - * should be the data type. |
|
61 | - * |
|
62 | - * @param string[] $extensions Array of file extensions |
|
63 | - */ |
|
64 | - public function setImportExtensions(array $extensions) |
|
65 | - { |
|
66 | - $this->importExtensions = $extensions; |
|
67 | - } |
|
68 | - |
|
69 | - /** |
|
70 | - * Move any import statements to the top. |
|
71 | - * |
|
72 | - * @param string $content Nearly finished CSS content |
|
73 | - * |
|
74 | - * @return string |
|
75 | - */ |
|
76 | - protected function moveImportsToTop($content) |
|
77 | - { |
|
78 | - if (preg_match_all('/@import[^;]+;/', $content, $matches)) { |
|
79 | - // remove from content |
|
80 | - foreach ($matches[0] as $import) { |
|
81 | - $content = str_replace($import, '', $content); |
|
82 | - } |
|
83 | - |
|
84 | - // add to top |
|
85 | - $content = implode('', $matches[0]).$content; |
|
86 | - } |
|
87 | - |
|
88 | - return $content; |
|
89 | - } |
|
90 | - |
|
91 | - /** |
|
92 | - * Combine CSS from import statements. |
|
93 | - * |
|
94 | - * @import's will be loaded and their content merged into the original file, |
|
95 | - * to save HTTP requests. |
|
96 | - * |
|
97 | - * @param string $source The file to combine imports for |
|
98 | - * @param string $content The CSS content to combine imports for |
|
99 | - * @param string[] $parents Parent paths, for circular reference checks |
|
100 | - * |
|
101 | - * @return string |
|
102 | - * |
|
103 | - * @throws FileImportException |
|
104 | - */ |
|
105 | - protected function combineImports($source, $content, $parents) |
|
106 | - { |
|
107 | - $importRegexes = array( |
|
108 | - // @import url(xxx) |
|
109 | - '/ |
|
20 | + /** |
|
21 | + * @var int |
|
22 | + */ |
|
23 | + protected $maxImportSize = 5; |
|
24 | + |
|
25 | + /** |
|
26 | + * @var string[] |
|
27 | + */ |
|
28 | + protected $importExtensions = array( |
|
29 | + 'gif' => 'data:image/gif', |
|
30 | + 'png' => 'data:image/png', |
|
31 | + 'jpe' => 'data:image/jpeg', |
|
32 | + 'jpg' => 'data:image/jpeg', |
|
33 | + 'jpeg' => 'data:image/jpeg', |
|
34 | + 'svg' => 'data:image/svg+xml', |
|
35 | + 'woff' => 'data:application/x-font-woff', |
|
36 | + 'tif' => 'image/tiff', |
|
37 | + 'tiff' => 'image/tiff', |
|
38 | + 'xbm' => 'image/x-xbitmap', |
|
39 | + ); |
|
40 | + |
|
41 | + /** |
|
42 | + * Set the maximum size if files to be imported. |
|
43 | + * |
|
44 | + * Files larger than this size (in kB) will not be imported into the CSS. |
|
45 | + * Importing files into the CSS as data-uri will save you some connections, |
|
46 | + * but we should only import relatively small decorative images so that our |
|
47 | + * CSS file doesn't get too bulky. |
|
48 | + * |
|
49 | + * @param int $size Size in kB |
|
50 | + */ |
|
51 | + public function setMaxImportSize($size) |
|
52 | + { |
|
53 | + $this->maxImportSize = $size; |
|
54 | + } |
|
55 | + |
|
56 | + /** |
|
57 | + * Set the type of extensions to be imported into the CSS (to save network |
|
58 | + * connections). |
|
59 | + * Keys of the array should be the file extensions & respective values |
|
60 | + * should be the data type. |
|
61 | + * |
|
62 | + * @param string[] $extensions Array of file extensions |
|
63 | + */ |
|
64 | + public function setImportExtensions(array $extensions) |
|
65 | + { |
|
66 | + $this->importExtensions = $extensions; |
|
67 | + } |
|
68 | + |
|
69 | + /** |
|
70 | + * Move any import statements to the top. |
|
71 | + * |
|
72 | + * @param string $content Nearly finished CSS content |
|
73 | + * |
|
74 | + * @return string |
|
75 | + */ |
|
76 | + protected function moveImportsToTop($content) |
|
77 | + { |
|
78 | + if (preg_match_all('/@import[^;]+;/', $content, $matches)) { |
|
79 | + // remove from content |
|
80 | + foreach ($matches[0] as $import) { |
|
81 | + $content = str_replace($import, '', $content); |
|
82 | + } |
|
83 | + |
|
84 | + // add to top |
|
85 | + $content = implode('', $matches[0]).$content; |
|
86 | + } |
|
87 | + |
|
88 | + return $content; |
|
89 | + } |
|
90 | + |
|
91 | + /** |
|
92 | + * Combine CSS from import statements. |
|
93 | + * |
|
94 | + * @import's will be loaded and their content merged into the original file, |
|
95 | + * to save HTTP requests. |
|
96 | + * |
|
97 | + * @param string $source The file to combine imports for |
|
98 | + * @param string $content The CSS content to combine imports for |
|
99 | + * @param string[] $parents Parent paths, for circular reference checks |
|
100 | + * |
|
101 | + * @return string |
|
102 | + * |
|
103 | + * @throws FileImportException |
|
104 | + */ |
|
105 | + protected function combineImports($source, $content, $parents) |
|
106 | + { |
|
107 | + $importRegexes = array( |
|
108 | + // @import url(xxx) |
|
109 | + '/ |
|
110 | 110 | # import statement |
111 | 111 | @import |
112 | 112 | |
@@ -151,8 +151,8 @@ discard block |
||
151 | 151 | |
152 | 152 | /ix', |
153 | 153 | |
154 | - // @import 'xxx' |
|
155 | - '/ |
|
154 | + // @import 'xxx' |
|
155 | + '/ |
|
156 | 156 | |
157 | 157 | # import statement |
158 | 158 | @import |
@@ -191,173 +191,173 @@ discard block |
||
191 | 191 | ;? |
192 | 192 | |
193 | 193 | /ix', |
194 | - ); |
|
195 | - |
|
196 | - // find all relative imports in css |
|
197 | - $matches = array(); |
|
198 | - foreach ($importRegexes as $importRegex) { |
|
199 | - if (preg_match_all($importRegex, $content, $regexMatches, PREG_SET_ORDER)) { |
|
200 | - $matches = array_merge($matches, $regexMatches); |
|
201 | - } |
|
202 | - } |
|
203 | - |
|
204 | - $search = array(); |
|
205 | - $replace = array(); |
|
206 | - |
|
207 | - // loop the matches |
|
208 | - foreach ($matches as $match) { |
|
209 | - // get the path for the file that will be imported |
|
210 | - $importPath = dirname($source).'/'.$match['path']; |
|
211 | - |
|
212 | - // only replace the import with the content if we can grab the |
|
213 | - // content of the file |
|
214 | - if ($this->canImportFile($importPath)) { |
|
215 | - // check if current file was not imported previously in the same |
|
216 | - // import chain. |
|
217 | - if (in_array($importPath, $parents)) { |
|
218 | - throw new FileImportException('Failed to import file "'.$importPath.'": circular reference detected.'); |
|
219 | - } |
|
220 | - |
|
221 | - // grab referenced file & minify it (which may include importing |
|
222 | - // yet other @import statements recursively) |
|
223 | - $minifier = new static($importPath); |
|
224 | - $importContent = $minifier->execute($source, $parents); |
|
225 | - |
|
226 | - // check if this is only valid for certain media |
|
227 | - if (!empty($match['media'])) { |
|
228 | - $importContent = '@media '.$match['media'].'{'.$importContent.'}'; |
|
229 | - } |
|
230 | - |
|
231 | - // add to replacement array |
|
232 | - $search[] = $match[0]; |
|
233 | - $replace[] = $importContent; |
|
234 | - } |
|
235 | - } |
|
236 | - |
|
237 | - // replace the import statements |
|
238 | - $content = str_replace($search, $replace, $content); |
|
239 | - |
|
240 | - return $content; |
|
241 | - } |
|
242 | - |
|
243 | - /** |
|
244 | - * Import files into the CSS, base64-ized. |
|
245 | - * |
|
246 | - * @url(image.jpg) images will be loaded and their content merged into the |
|
247 | - * original file, to save HTTP requests. |
|
248 | - * |
|
249 | - * @param string $source The file to import files for |
|
250 | - * @param string $content The CSS content to import files for |
|
251 | - * |
|
252 | - * @return string |
|
253 | - */ |
|
254 | - protected function importFiles($source, $content) |
|
255 | - { |
|
256 | - $extensions = array_keys($this->importExtensions); |
|
257 | - $regex = '/url\((["\']?)((?!["\']?data:).*?\.('.implode('|', $extensions).'))\\1\)/i'; |
|
258 | - if ($extensions && preg_match_all($regex, $content, $matches, PREG_SET_ORDER)) { |
|
259 | - $search = array(); |
|
260 | - $replace = array(); |
|
261 | - |
|
262 | - // loop the matches |
|
263 | - foreach ($matches as $match) { |
|
264 | - // get the path for the file that will be imported |
|
265 | - $path = $match[2]; |
|
266 | - $path = dirname($source).'/'.$path; |
|
267 | - $extension = $match[3]; |
|
268 | - |
|
269 | - // only replace the import with the content if we're able to get |
|
270 | - // the content of the file, and it's relatively small |
|
271 | - if ($this->canImportFile($path) && $this->canImportBySize($path)) { |
|
272 | - // grab content && base64-ize |
|
273 | - $importContent = $this->load($path); |
|
274 | - $importContent = base64_encode($importContent); |
|
275 | - |
|
276 | - // build replacement |
|
277 | - $search[] = $match[0]; |
|
278 | - $replace[] = 'url('.$this->importExtensions[$extension].';base64,'.$importContent.')'; |
|
279 | - } |
|
280 | - } |
|
281 | - |
|
282 | - // replace the import statements |
|
283 | - $content = str_replace($search, $replace, $content); |
|
284 | - } |
|
285 | - |
|
286 | - return $content; |
|
287 | - } |
|
288 | - |
|
289 | - /** |
|
290 | - * Minify the data. |
|
291 | - * Perform CSS optimizations. |
|
292 | - * |
|
293 | - * @param string[optional] $path Path to write the data to |
|
294 | - * @param string[] $parents Parent paths, for circular reference checks |
|
295 | - * |
|
296 | - * @return string The minified data |
|
297 | - */ |
|
298 | - public function execute($path = null, $parents = array()) |
|
299 | - { |
|
300 | - $content = ''; |
|
301 | - |
|
302 | - // loop css data (raw data and files) |
|
303 | - foreach ($this->data as $source => $css) { |
|
304 | - /* |
|
194 | + ); |
|
195 | + |
|
196 | + // find all relative imports in css |
|
197 | + $matches = array(); |
|
198 | + foreach ($importRegexes as $importRegex) { |
|
199 | + if (preg_match_all($importRegex, $content, $regexMatches, PREG_SET_ORDER)) { |
|
200 | + $matches = array_merge($matches, $regexMatches); |
|
201 | + } |
|
202 | + } |
|
203 | + |
|
204 | + $search = array(); |
|
205 | + $replace = array(); |
|
206 | + |
|
207 | + // loop the matches |
|
208 | + foreach ($matches as $match) { |
|
209 | + // get the path for the file that will be imported |
|
210 | + $importPath = dirname($source).'/'.$match['path']; |
|
211 | + |
|
212 | + // only replace the import with the content if we can grab the |
|
213 | + // content of the file |
|
214 | + if ($this->canImportFile($importPath)) { |
|
215 | + // check if current file was not imported previously in the same |
|
216 | + // import chain. |
|
217 | + if (in_array($importPath, $parents)) { |
|
218 | + throw new FileImportException('Failed to import file "'.$importPath.'": circular reference detected.'); |
|
219 | + } |
|
220 | + |
|
221 | + // grab referenced file & minify it (which may include importing |
|
222 | + // yet other @import statements recursively) |
|
223 | + $minifier = new static($importPath); |
|
224 | + $importContent = $minifier->execute($source, $parents); |
|
225 | + |
|
226 | + // check if this is only valid for certain media |
|
227 | + if (!empty($match['media'])) { |
|
228 | + $importContent = '@media '.$match['media'].'{'.$importContent.'}'; |
|
229 | + } |
|
230 | + |
|
231 | + // add to replacement array |
|
232 | + $search[] = $match[0]; |
|
233 | + $replace[] = $importContent; |
|
234 | + } |
|
235 | + } |
|
236 | + |
|
237 | + // replace the import statements |
|
238 | + $content = str_replace($search, $replace, $content); |
|
239 | + |
|
240 | + return $content; |
|
241 | + } |
|
242 | + |
|
243 | + /** |
|
244 | + * Import files into the CSS, base64-ized. |
|
245 | + * |
|
246 | + * @url(image.jpg) images will be loaded and their content merged into the |
|
247 | + * original file, to save HTTP requests. |
|
248 | + * |
|
249 | + * @param string $source The file to import files for |
|
250 | + * @param string $content The CSS content to import files for |
|
251 | + * |
|
252 | + * @return string |
|
253 | + */ |
|
254 | + protected function importFiles($source, $content) |
|
255 | + { |
|
256 | + $extensions = array_keys($this->importExtensions); |
|
257 | + $regex = '/url\((["\']?)((?!["\']?data:).*?\.('.implode('|', $extensions).'))\\1\)/i'; |
|
258 | + if ($extensions && preg_match_all($regex, $content, $matches, PREG_SET_ORDER)) { |
|
259 | + $search = array(); |
|
260 | + $replace = array(); |
|
261 | + |
|
262 | + // loop the matches |
|
263 | + foreach ($matches as $match) { |
|
264 | + // get the path for the file that will be imported |
|
265 | + $path = $match[2]; |
|
266 | + $path = dirname($source).'/'.$path; |
|
267 | + $extension = $match[3]; |
|
268 | + |
|
269 | + // only replace the import with the content if we're able to get |
|
270 | + // the content of the file, and it's relatively small |
|
271 | + if ($this->canImportFile($path) && $this->canImportBySize($path)) { |
|
272 | + // grab content && base64-ize |
|
273 | + $importContent = $this->load($path); |
|
274 | + $importContent = base64_encode($importContent); |
|
275 | + |
|
276 | + // build replacement |
|
277 | + $search[] = $match[0]; |
|
278 | + $replace[] = 'url('.$this->importExtensions[$extension].';base64,'.$importContent.')'; |
|
279 | + } |
|
280 | + } |
|
281 | + |
|
282 | + // replace the import statements |
|
283 | + $content = str_replace($search, $replace, $content); |
|
284 | + } |
|
285 | + |
|
286 | + return $content; |
|
287 | + } |
|
288 | + |
|
289 | + /** |
|
290 | + * Minify the data. |
|
291 | + * Perform CSS optimizations. |
|
292 | + * |
|
293 | + * @param string[optional] $path Path to write the data to |
|
294 | + * @param string[] $parents Parent paths, for circular reference checks |
|
295 | + * |
|
296 | + * @return string The minified data |
|
297 | + */ |
|
298 | + public function execute($path = null, $parents = array()) |
|
299 | + { |
|
300 | + $content = ''; |
|
301 | + |
|
302 | + // loop css data (raw data and files) |
|
303 | + foreach ($this->data as $source => $css) { |
|
304 | + /* |
|
305 | 305 | * Let's first take out strings & comments, since we can't just remove |
306 | 306 | * whitespace anywhere. If whitespace occurs inside a string, we should |
307 | 307 | * leave it alone. E.g.: |
308 | 308 | * p { content: "a test" } |
309 | 309 | */ |
310 | - $this->extractStrings(); |
|
311 | - $this->stripComments(); |
|
312 | - $css = $this->replace($css); |
|
310 | + $this->extractStrings(); |
|
311 | + $this->stripComments(); |
|
312 | + $css = $this->replace($css); |
|
313 | 313 | |
314 | - $css = $this->stripWhitespace($css); |
|
315 | - $css = $this->shortenHex($css); |
|
316 | - $css = $this->shortenZeroes($css); |
|
317 | - $css = $this->shortenFontWeights($css); |
|
318 | - $css = $this->stripEmptyTags($css); |
|
314 | + $css = $this->stripWhitespace($css); |
|
315 | + $css = $this->shortenHex($css); |
|
316 | + $css = $this->shortenZeroes($css); |
|
317 | + $css = $this->shortenFontWeights($css); |
|
318 | + $css = $this->stripEmptyTags($css); |
|
319 | 319 | |
320 | - // restore the string we've extracted earlier |
|
321 | - $css = $this->restoreExtractedData($css); |
|
320 | + // restore the string we've extracted earlier |
|
321 | + $css = $this->restoreExtractedData($css); |
|
322 | 322 | |
323 | - $source = is_int($source) ? '' : $source; |
|
324 | - $parents = $source ? array_merge($parents, array($source)) : $parents; |
|
325 | - $css = $this->combineImports($source, $css, $parents); |
|
326 | - $css = $this->importFiles($source, $css); |
|
323 | + $source = is_int($source) ? '' : $source; |
|
324 | + $parents = $source ? array_merge($parents, array($source)) : $parents; |
|
325 | + $css = $this->combineImports($source, $css, $parents); |
|
326 | + $css = $this->importFiles($source, $css); |
|
327 | 327 | |
328 | - /* |
|
328 | + /* |
|
329 | 329 | * If we'll save to a new path, we'll have to fix the relative paths |
330 | 330 | * to be relative no longer to the source file, but to the new path. |
331 | 331 | * If we don't write to a file, fall back to same path so no |
332 | 332 | * conversion happens (because we still want it to go through most |
333 | 333 | * of the move code...) |
334 | 334 | */ |
335 | - $converter = new Converter($source, $path ?: $source); |
|
336 | - $css = $this->move($converter, $css); |
|
337 | - |
|
338 | - // combine css |
|
339 | - $content .= $css; |
|
340 | - } |
|
341 | - |
|
342 | - $content = $this->moveImportsToTop($content); |
|
343 | - |
|
344 | - return $content; |
|
345 | - } |
|
346 | - |
|
347 | - /** |
|
348 | - * Moving a css file should update all relative urls. |
|
349 | - * Relative references (e.g. ../images/image.gif) in a certain css file, |
|
350 | - * will have to be updated when a file is being saved at another location |
|
351 | - * (e.g. ../../images/image.gif, if the new CSS file is 1 folder deeper). |
|
352 | - * |
|
353 | - * @param Converter $converter Relative path converter |
|
354 | - * @param string $content The CSS content to update relative urls for |
|
355 | - * |
|
356 | - * @return string |
|
357 | - */ |
|
358 | - protected function move(Converter $converter, $content) |
|
359 | - { |
|
360 | - /* |
|
335 | + $converter = new Converter($source, $path ?: $source); |
|
336 | + $css = $this->move($converter, $css); |
|
337 | + |
|
338 | + // combine css |
|
339 | + $content .= $css; |
|
340 | + } |
|
341 | + |
|
342 | + $content = $this->moveImportsToTop($content); |
|
343 | + |
|
344 | + return $content; |
|
345 | + } |
|
346 | + |
|
347 | + /** |
|
348 | + * Moving a css file should update all relative urls. |
|
349 | + * Relative references (e.g. ../images/image.gif) in a certain css file, |
|
350 | + * will have to be updated when a file is being saved at another location |
|
351 | + * (e.g. ../../images/image.gif, if the new CSS file is 1 folder deeper). |
|
352 | + * |
|
353 | + * @param Converter $converter Relative path converter |
|
354 | + * @param string $content The CSS content to update relative urls for |
|
355 | + * |
|
356 | + * @return string |
|
357 | + */ |
|
358 | + protected function move(Converter $converter, $content) |
|
359 | + { |
|
360 | + /* |
|
361 | 361 | * Relative path references will usually be enclosed by url(). @import |
362 | 362 | * is an exception, where url() is not necessary around the path (but is |
363 | 363 | * allowed). |
@@ -368,9 +368,9 @@ discard block |
||
368 | 368 | * recent PCRE version. That's why I'm doing 2 separate regular |
369 | 369 | * expressions & combining the matches after executing of both. |
370 | 370 | */ |
371 | - $relativeRegexes = array( |
|
372 | - // url(xxx) |
|
373 | - '/ |
|
371 | + $relativeRegexes = array( |
|
372 | + // url(xxx) |
|
373 | + '/ |
|
374 | 374 | # open url() |
375 | 375 | url\( |
376 | 376 | |
@@ -402,8 +402,8 @@ discard block |
||
402 | 402 | |
403 | 403 | /ix', |
404 | 404 | |
405 | - // @import "xxx" |
|
406 | - '/ |
|
405 | + // @import "xxx" |
|
406 | + '/ |
|
407 | 407 | # import statement |
408 | 408 | @import |
409 | 409 | |
@@ -432,243 +432,243 @@ discard block |
||
432 | 432 | (?P=quotes) |
433 | 433 | |
434 | 434 | /ix', |
435 | - ); |
|
436 | - |
|
437 | - // find all relative urls in css |
|
438 | - $matches = array(); |
|
439 | - foreach ($relativeRegexes as $relativeRegex) { |
|
440 | - if (preg_match_all($relativeRegex, $content, $regexMatches, PREG_SET_ORDER)) { |
|
441 | - $matches = array_merge($matches, $regexMatches); |
|
442 | - } |
|
443 | - } |
|
444 | - |
|
445 | - $search = array(); |
|
446 | - $replace = array(); |
|
447 | - |
|
448 | - // loop all urls |
|
449 | - foreach ($matches as $match) { |
|
450 | - // determine if it's a url() or an @import match |
|
451 | - $type = (strpos($match[0], '@import') === 0 ? 'import' : 'url'); |
|
452 | - |
|
453 | - // attempting to interpret GET-params makes no sense, so let's discard them for awhile |
|
454 | - $params = strrchr($match['path'], '?'); |
|
455 | - $url = $params ? substr($match['path'], 0, -strlen($params)) : $match['path']; |
|
456 | - |
|
457 | - // fix relative url |
|
458 | - $url = $converter->convert($url); |
|
459 | - |
|
460 | - // now that the path has been converted, re-apply GET-params |
|
461 | - $url .= $params; |
|
462 | - |
|
463 | - // build replacement |
|
464 | - $search[] = $match[0]; |
|
465 | - if ($type == 'url') { |
|
466 | - $replace[] = 'url('.$url.')'; |
|
467 | - } elseif ($type == 'import') { |
|
468 | - $replace[] = '@import "'.$url.'"'; |
|
469 | - } |
|
470 | - } |
|
471 | - |
|
472 | - // replace urls |
|
473 | - $content = str_replace($search, $replace, $content); |
|
474 | - |
|
475 | - return $content; |
|
476 | - } |
|
477 | - |
|
478 | - /** |
|
479 | - * Shorthand hex color codes. |
|
480 | - * #FF0000 -> #F00. |
|
481 | - * |
|
482 | - * @param string $content The CSS content to shorten the hex color codes for |
|
483 | - * |
|
484 | - * @return string |
|
485 | - */ |
|
486 | - protected function shortenHex($content) |
|
487 | - { |
|
488 | - $content = preg_replace('/(?<=[: ])#([0-9a-z])\\1([0-9a-z])\\2([0-9a-z])\\3(?=[; }])/i', '#$1$2$3', $content); |
|
489 | - |
|
490 | - // we can shorten some even more by replacing them with their color name |
|
491 | - $colors = array( |
|
492 | - '#F0FFFF' => 'azure', |
|
493 | - '#F5F5DC' => 'beige', |
|
494 | - '#A52A2A' => 'brown', |
|
495 | - '#FF7F50' => 'coral', |
|
496 | - '#FFD700' => 'gold', |
|
497 | - '#808080' => 'gray', |
|
498 | - '#008000' => 'green', |
|
499 | - '#4B0082' => 'indigo', |
|
500 | - '#FFFFF0' => 'ivory', |
|
501 | - '#F0E68C' => 'khaki', |
|
502 | - '#FAF0E6' => 'linen', |
|
503 | - '#800000' => 'maroon', |
|
504 | - '#000080' => 'navy', |
|
505 | - '#808000' => 'olive', |
|
506 | - '#CD853F' => 'peru', |
|
507 | - '#FFC0CB' => 'pink', |
|
508 | - '#DDA0DD' => 'plum', |
|
509 | - '#800080' => 'purple', |
|
510 | - '#F00' => 'red', |
|
511 | - '#FA8072' => 'salmon', |
|
512 | - '#A0522D' => 'sienna', |
|
513 | - '#C0C0C0' => 'silver', |
|
514 | - '#FFFAFA' => 'snow', |
|
515 | - '#D2B48C' => 'tan', |
|
516 | - '#FF6347' => 'tomato', |
|
517 | - '#EE82EE' => 'violet', |
|
518 | - '#F5DEB3' => 'wheat', |
|
519 | - ); |
|
520 | - |
|
521 | - return preg_replace_callback( |
|
522 | - '/(?<=[: ])('.implode(array_keys($colors), '|').')(?=[; }])/i', |
|
523 | - function ($match) use ($colors) { |
|
524 | - return $colors[strtoupper($match[0])]; |
|
525 | - }, |
|
526 | - $content |
|
527 | - ); |
|
528 | - } |
|
529 | - |
|
530 | - /** |
|
531 | - * Shorten CSS font weights. |
|
532 | - * |
|
533 | - * @param string $content The CSS content to shorten the font weights for |
|
534 | - * |
|
535 | - * @return string |
|
536 | - */ |
|
537 | - protected function shortenFontWeights($content) |
|
538 | - { |
|
539 | - $weights = array( |
|
540 | - 'normal' => 400, |
|
541 | - 'bold' => 700, |
|
542 | - ); |
|
543 | - |
|
544 | - $callback = function ($match) use ($weights) { |
|
545 | - return $match[1].$weights[$match[2]]; |
|
546 | - }; |
|
547 | - |
|
548 | - return preg_replace_callback('/(font-weight\s*:\s*)('.implode('|', array_keys($weights)).')(?=[;}])/', $callback, $content); |
|
549 | - } |
|
550 | - |
|
551 | - /** |
|
552 | - * Shorthand 0 values to plain 0, instead of e.g. -0em. |
|
553 | - * |
|
554 | - * @param string $content The CSS content to shorten the zero values for |
|
555 | - * |
|
556 | - * @return string |
|
557 | - */ |
|
558 | - protected function shortenZeroes($content) |
|
559 | - { |
|
560 | - // reusable bits of code throughout these regexes: |
|
561 | - // before & after are used to make sure we don't match lose unintended |
|
562 | - // 0-like values (e.g. in #000, or in http://url/1.0) |
|
563 | - // units can be stripped from 0 values, or used to recognize non 0 |
|
564 | - // values (where wa may be able to strip a .0 suffix) |
|
565 | - $before = '(?<=[:(, ])'; |
|
566 | - $after = '(?=[ ,);}])'; |
|
567 | - $units = '(em|ex|%|px|cm|mm|in|pt|pc|ch|rem|vh|vw|vmin|vmax|vm)'; |
|
568 | - |
|
569 | - // strip units after zeroes (0px -> 0) |
|
570 | - // NOTE: it should be safe to remove all units for a 0 value, but in |
|
571 | - // practice, Webkit (especially Safari) seems to stumble over at least |
|
572 | - // 0%, potentially other units as well. Only stripping 'px' for now. |
|
573 | - // @see https://github.com/matthiasmullie/minify/issues/60 |
|
574 | - $content = preg_replace('/'.$before.'(-?0*(\.0+)?)(?<=0)px'.$after.'/', '\\1', $content); |
|
575 | - |
|
576 | - // strip 0-digits (.0 -> 0) |
|
577 | - $content = preg_replace('/'.$before.'\.0+'.$units.'?'.$after.'/', '0\\1', $content); |
|
578 | - // strip trailing 0: 50.10 -> 50.1, 50.10px -> 50.1px |
|
579 | - $content = preg_replace('/'.$before.'(-?[0-9]+\.[0-9]+)0+'.$units.'?'.$after.'/', '\\1\\2', $content); |
|
580 | - // strip trailing 0: 50.00 -> 50, 50.00px -> 50px |
|
581 | - $content = preg_replace('/'.$before.'(-?[0-9]+)\.0+'.$units.'?'.$after.'/', '\\1\\2', $content); |
|
582 | - // strip leading 0: 0.1 -> .1, 01.1 -> 1.1 |
|
583 | - $content = preg_replace('/'.$before.'(-?)0+([0-9]*\.[0-9]+)'.$units.'?'.$after.'/', '\\1\\2\\3', $content); |
|
584 | - |
|
585 | - // strip negative zeroes (-0 -> 0) & truncate zeroes (00 -> 0) |
|
586 | - $content = preg_replace('/'.$before.'-?0+'.$units.'?'.$after.'/', '0\\1', $content); |
|
587 | - |
|
588 | - // remove zeroes where they make no sense in calc: e.g. calc(100px - 0) |
|
589 | - // the 0 doesn't have any effect, and this isn't even valid without unit |
|
590 | - // strip all `+ 0` or `- 0` occurrences: calc(10% + 0) -> calc(10%) |
|
591 | - // looped because there may be multiple 0s inside 1 group of parentheses |
|
592 | - do { |
|
593 | - $previous = $content; |
|
594 | - $content = preg_replace('/\(([^\(\)]+)\s+[\+\-]\s+0(\s+[^\(\)]+)?\)/', '(\\1\\2)', $content); |
|
595 | - } while ($content !== $previous); |
|
596 | - // strip all `0 +` occurrences: calc(0 + 10%) -> calc(10%) |
|
597 | - $content = preg_replace('/\(\s*0\s+\+\s+([^\(\)]+)\)/', '(\\1)', $content); |
|
598 | - // strip all `0 -` occurrences: calc(0 - 10%) -> calc(-10%) |
|
599 | - $content = preg_replace('/\(\s*0\s+\-\s+([^\(\)]+)\)/', '(-\\1)', $content); |
|
600 | - // I'm not going to attempt to optimize away `x * 0` instances: |
|
601 | - // it's dumb enough code already that it likely won't occur, and it's |
|
602 | - // too complex to do right (order of operations would have to be |
|
603 | - // respected etc) |
|
604 | - // what I cared about most here was fixing incorrectly truncated units |
|
605 | - |
|
606 | - return $content; |
|
607 | - } |
|
608 | - |
|
609 | - /** |
|
610 | - * Strip comments from source code. |
|
611 | - * |
|
612 | - * @param string $content |
|
613 | - * |
|
614 | - * @return string |
|
615 | - */ |
|
616 | - protected function stripEmptyTags($content) |
|
617 | - { |
|
618 | - return preg_replace('/(^|\}|;)[^\{\};]+\{\s*\}/', '\\1', $content); |
|
619 | - } |
|
620 | - |
|
621 | - /** |
|
622 | - * Strip comments from source code. |
|
623 | - */ |
|
624 | - protected function stripComments() |
|
625 | - { |
|
626 | - $this->registerPattern('/\/\*.*?\*\//s', ''); |
|
627 | - } |
|
628 | - |
|
629 | - /** |
|
630 | - * Strip whitespace. |
|
631 | - * |
|
632 | - * @param string $content The CSS content to strip the whitespace for |
|
633 | - * |
|
634 | - * @return string |
|
635 | - */ |
|
636 | - protected function stripWhitespace($content) |
|
637 | - { |
|
638 | - // remove leading & trailing whitespace |
|
639 | - $content = preg_replace('/^\s*/m', '', $content); |
|
640 | - $content = preg_replace('/\s*$/m', '', $content); |
|
641 | - |
|
642 | - // replace newlines with a single space |
|
643 | - $content = preg_replace('/\s+/', ' ', $content); |
|
644 | - |
|
645 | - // remove whitespace around meta characters |
|
646 | - // inspired by stackoverflow.com/questions/15195750/minify-compress-css-with-regex |
|
647 | - $content = preg_replace('/\s*([\*$~^|]?+=|[{};,>~]|!important\b)\s*/', '$1', $content); |
|
648 | - $content = preg_replace('/([\[(:])\s+/', '$1', $content); |
|
649 | - $content = preg_replace('/\s+([\]\)])/', '$1', $content); |
|
650 | - $content = preg_replace('/\s+(:)(?![^\}]*\{)/', '$1', $content); |
|
651 | - |
|
652 | - // whitespace around + and - can only be stripped in selectors, like |
|
653 | - // :nth-child(3+2n), not in things like calc(3px + 2px) or shorthands |
|
654 | - // like 3px -2px |
|
655 | - $content = preg_replace('/\s*([+-])\s*(?=[^}]*{)/', '$1', $content); |
|
656 | - |
|
657 | - // remove semicolon/whitespace followed by closing bracket |
|
658 | - $content = str_replace(';}', '}', $content); |
|
659 | - |
|
660 | - return trim($content); |
|
661 | - } |
|
662 | - |
|
663 | - /** |
|
664 | - * Check if file is small enough to be imported. |
|
665 | - * |
|
666 | - * @param string $path The path to the file |
|
667 | - * |
|
668 | - * @return bool |
|
669 | - */ |
|
670 | - protected function canImportBySize($path) |
|
671 | - { |
|
672 | - return ($size = @filesize($path)) && $size <= $this->maxImportSize * 1024; |
|
673 | - } |
|
435 | + ); |
|
436 | + |
|
437 | + // find all relative urls in css |
|
438 | + $matches = array(); |
|
439 | + foreach ($relativeRegexes as $relativeRegex) { |
|
440 | + if (preg_match_all($relativeRegex, $content, $regexMatches, PREG_SET_ORDER)) { |
|
441 | + $matches = array_merge($matches, $regexMatches); |
|
442 | + } |
|
443 | + } |
|
444 | + |
|
445 | + $search = array(); |
|
446 | + $replace = array(); |
|
447 | + |
|
448 | + // loop all urls |
|
449 | + foreach ($matches as $match) { |
|
450 | + // determine if it's a url() or an @import match |
|
451 | + $type = (strpos($match[0], '@import') === 0 ? 'import' : 'url'); |
|
452 | + |
|
453 | + // attempting to interpret GET-params makes no sense, so let's discard them for awhile |
|
454 | + $params = strrchr($match['path'], '?'); |
|
455 | + $url = $params ? substr($match['path'], 0, -strlen($params)) : $match['path']; |
|
456 | + |
|
457 | + // fix relative url |
|
458 | + $url = $converter->convert($url); |
|
459 | + |
|
460 | + // now that the path has been converted, re-apply GET-params |
|
461 | + $url .= $params; |
|
462 | + |
|
463 | + // build replacement |
|
464 | + $search[] = $match[0]; |
|
465 | + if ($type == 'url') { |
|
466 | + $replace[] = 'url('.$url.')'; |
|
467 | + } elseif ($type == 'import') { |
|
468 | + $replace[] = '@import "'.$url.'"'; |
|
469 | + } |
|
470 | + } |
|
471 | + |
|
472 | + // replace urls |
|
473 | + $content = str_replace($search, $replace, $content); |
|
474 | + |
|
475 | + return $content; |
|
476 | + } |
|
477 | + |
|
478 | + /** |
|
479 | + * Shorthand hex color codes. |
|
480 | + * #FF0000 -> #F00. |
|
481 | + * |
|
482 | + * @param string $content The CSS content to shorten the hex color codes for |
|
483 | + * |
|
484 | + * @return string |
|
485 | + */ |
|
486 | + protected function shortenHex($content) |
|
487 | + { |
|
488 | + $content = preg_replace('/(?<=[: ])#([0-9a-z])\\1([0-9a-z])\\2([0-9a-z])\\3(?=[; }])/i', '#$1$2$3', $content); |
|
489 | + |
|
490 | + // we can shorten some even more by replacing them with their color name |
|
491 | + $colors = array( |
|
492 | + '#F0FFFF' => 'azure', |
|
493 | + '#F5F5DC' => 'beige', |
|
494 | + '#A52A2A' => 'brown', |
|
495 | + '#FF7F50' => 'coral', |
|
496 | + '#FFD700' => 'gold', |
|
497 | + '#808080' => 'gray', |
|
498 | + '#008000' => 'green', |
|
499 | + '#4B0082' => 'indigo', |
|
500 | + '#FFFFF0' => 'ivory', |
|
501 | + '#F0E68C' => 'khaki', |
|
502 | + '#FAF0E6' => 'linen', |
|
503 | + '#800000' => 'maroon', |
|
504 | + '#000080' => 'navy', |
|
505 | + '#808000' => 'olive', |
|
506 | + '#CD853F' => 'peru', |
|
507 | + '#FFC0CB' => 'pink', |
|
508 | + '#DDA0DD' => 'plum', |
|
509 | + '#800080' => 'purple', |
|
510 | + '#F00' => 'red', |
|
511 | + '#FA8072' => 'salmon', |
|
512 | + '#A0522D' => 'sienna', |
|
513 | + '#C0C0C0' => 'silver', |
|
514 | + '#FFFAFA' => 'snow', |
|
515 | + '#D2B48C' => 'tan', |
|
516 | + '#FF6347' => 'tomato', |
|
517 | + '#EE82EE' => 'violet', |
|
518 | + '#F5DEB3' => 'wheat', |
|
519 | + ); |
|
520 | + |
|
521 | + return preg_replace_callback( |
|
522 | + '/(?<=[: ])('.implode(array_keys($colors), '|').')(?=[; }])/i', |
|
523 | + function ($match) use ($colors) { |
|
524 | + return $colors[strtoupper($match[0])]; |
|
525 | + }, |
|
526 | + $content |
|
527 | + ); |
|
528 | + } |
|
529 | + |
|
530 | + /** |
|
531 | + * Shorten CSS font weights. |
|
532 | + * |
|
533 | + * @param string $content The CSS content to shorten the font weights for |
|
534 | + * |
|
535 | + * @return string |
|
536 | + */ |
|
537 | + protected function shortenFontWeights($content) |
|
538 | + { |
|
539 | + $weights = array( |
|
540 | + 'normal' => 400, |
|
541 | + 'bold' => 700, |
|
542 | + ); |
|
543 | + |
|
544 | + $callback = function ($match) use ($weights) { |
|
545 | + return $match[1].$weights[$match[2]]; |
|
546 | + }; |
|
547 | + |
|
548 | + return preg_replace_callback('/(font-weight\s*:\s*)('.implode('|', array_keys($weights)).')(?=[;}])/', $callback, $content); |
|
549 | + } |
|
550 | + |
|
551 | + /** |
|
552 | + * Shorthand 0 values to plain 0, instead of e.g. -0em. |
|
553 | + * |
|
554 | + * @param string $content The CSS content to shorten the zero values for |
|
555 | + * |
|
556 | + * @return string |
|
557 | + */ |
|
558 | + protected function shortenZeroes($content) |
|
559 | + { |
|
560 | + // reusable bits of code throughout these regexes: |
|
561 | + // before & after are used to make sure we don't match lose unintended |
|
562 | + // 0-like values (e.g. in #000, or in http://url/1.0) |
|
563 | + // units can be stripped from 0 values, or used to recognize non 0 |
|
564 | + // values (where wa may be able to strip a .0 suffix) |
|
565 | + $before = '(?<=[:(, ])'; |
|
566 | + $after = '(?=[ ,);}])'; |
|
567 | + $units = '(em|ex|%|px|cm|mm|in|pt|pc|ch|rem|vh|vw|vmin|vmax|vm)'; |
|
568 | + |
|
569 | + // strip units after zeroes (0px -> 0) |
|
570 | + // NOTE: it should be safe to remove all units for a 0 value, but in |
|
571 | + // practice, Webkit (especially Safari) seems to stumble over at least |
|
572 | + // 0%, potentially other units as well. Only stripping 'px' for now. |
|
573 | + // @see https://github.com/matthiasmullie/minify/issues/60 |
|
574 | + $content = preg_replace('/'.$before.'(-?0*(\.0+)?)(?<=0)px'.$after.'/', '\\1', $content); |
|
575 | + |
|
576 | + // strip 0-digits (.0 -> 0) |
|
577 | + $content = preg_replace('/'.$before.'\.0+'.$units.'?'.$after.'/', '0\\1', $content); |
|
578 | + // strip trailing 0: 50.10 -> 50.1, 50.10px -> 50.1px |
|
579 | + $content = preg_replace('/'.$before.'(-?[0-9]+\.[0-9]+)0+'.$units.'?'.$after.'/', '\\1\\2', $content); |
|
580 | + // strip trailing 0: 50.00 -> 50, 50.00px -> 50px |
|
581 | + $content = preg_replace('/'.$before.'(-?[0-9]+)\.0+'.$units.'?'.$after.'/', '\\1\\2', $content); |
|
582 | + // strip leading 0: 0.1 -> .1, 01.1 -> 1.1 |
|
583 | + $content = preg_replace('/'.$before.'(-?)0+([0-9]*\.[0-9]+)'.$units.'?'.$after.'/', '\\1\\2\\3', $content); |
|
584 | + |
|
585 | + // strip negative zeroes (-0 -> 0) & truncate zeroes (00 -> 0) |
|
586 | + $content = preg_replace('/'.$before.'-?0+'.$units.'?'.$after.'/', '0\\1', $content); |
|
587 | + |
|
588 | + // remove zeroes where they make no sense in calc: e.g. calc(100px - 0) |
|
589 | + // the 0 doesn't have any effect, and this isn't even valid without unit |
|
590 | + // strip all `+ 0` or `- 0` occurrences: calc(10% + 0) -> calc(10%) |
|
591 | + // looped because there may be multiple 0s inside 1 group of parentheses |
|
592 | + do { |
|
593 | + $previous = $content; |
|
594 | + $content = preg_replace('/\(([^\(\)]+)\s+[\+\-]\s+0(\s+[^\(\)]+)?\)/', '(\\1\\2)', $content); |
|
595 | + } while ($content !== $previous); |
|
596 | + // strip all `0 +` occurrences: calc(0 + 10%) -> calc(10%) |
|
597 | + $content = preg_replace('/\(\s*0\s+\+\s+([^\(\)]+)\)/', '(\\1)', $content); |
|
598 | + // strip all `0 -` occurrences: calc(0 - 10%) -> calc(-10%) |
|
599 | + $content = preg_replace('/\(\s*0\s+\-\s+([^\(\)]+)\)/', '(-\\1)', $content); |
|
600 | + // I'm not going to attempt to optimize away `x * 0` instances: |
|
601 | + // it's dumb enough code already that it likely won't occur, and it's |
|
602 | + // too complex to do right (order of operations would have to be |
|
603 | + // respected etc) |
|
604 | + // what I cared about most here was fixing incorrectly truncated units |
|
605 | + |
|
606 | + return $content; |
|
607 | + } |
|
608 | + |
|
609 | + /** |
|
610 | + * Strip comments from source code. |
|
611 | + * |
|
612 | + * @param string $content |
|
613 | + * |
|
614 | + * @return string |
|
615 | + */ |
|
616 | + protected function stripEmptyTags($content) |
|
617 | + { |
|
618 | + return preg_replace('/(^|\}|;)[^\{\};]+\{\s*\}/', '\\1', $content); |
|
619 | + } |
|
620 | + |
|
621 | + /** |
|
622 | + * Strip comments from source code. |
|
623 | + */ |
|
624 | + protected function stripComments() |
|
625 | + { |
|
626 | + $this->registerPattern('/\/\*.*?\*\//s', ''); |
|
627 | + } |
|
628 | + |
|
629 | + /** |
|
630 | + * Strip whitespace. |
|
631 | + * |
|
632 | + * @param string $content The CSS content to strip the whitespace for |
|
633 | + * |
|
634 | + * @return string |
|
635 | + */ |
|
636 | + protected function stripWhitespace($content) |
|
637 | + { |
|
638 | + // remove leading & trailing whitespace |
|
639 | + $content = preg_replace('/^\s*/m', '', $content); |
|
640 | + $content = preg_replace('/\s*$/m', '', $content); |
|
641 | + |
|
642 | + // replace newlines with a single space |
|
643 | + $content = preg_replace('/\s+/', ' ', $content); |
|
644 | + |
|
645 | + // remove whitespace around meta characters |
|
646 | + // inspired by stackoverflow.com/questions/15195750/minify-compress-css-with-regex |
|
647 | + $content = preg_replace('/\s*([\*$~^|]?+=|[{};,>~]|!important\b)\s*/', '$1', $content); |
|
648 | + $content = preg_replace('/([\[(:])\s+/', '$1', $content); |
|
649 | + $content = preg_replace('/\s+([\]\)])/', '$1', $content); |
|
650 | + $content = preg_replace('/\s+(:)(?![^\}]*\{)/', '$1', $content); |
|
651 | + |
|
652 | + // whitespace around + and - can only be stripped in selectors, like |
|
653 | + // :nth-child(3+2n), not in things like calc(3px + 2px) or shorthands |
|
654 | + // like 3px -2px |
|
655 | + $content = preg_replace('/\s*([+-])\s*(?=[^}]*{)/', '$1', $content); |
|
656 | + |
|
657 | + // remove semicolon/whitespace followed by closing bracket |
|
658 | + $content = str_replace(';}', '}', $content); |
|
659 | + |
|
660 | + return trim($content); |
|
661 | + } |
|
662 | + |
|
663 | + /** |
|
664 | + * Check if file is small enough to be imported. |
|
665 | + * |
|
666 | + * @param string $path The path to the file |
|
667 | + * |
|
668 | + * @return bool |
|
669 | + */ |
|
670 | + protected function canImportBySize($path) |
|
671 | + { |
|
672 | + return ($size = @filesize($path)) && $size <= $this->maxImportSize * 1024; |
|
673 | + } |
|
674 | 674 | } |
@@ -82,7 +82,7 @@ discard block |
||
82 | 82 | } |
83 | 83 | |
84 | 84 | // add to top |
85 | - $content = implode('', $matches[0]).$content; |
|
85 | + $content = implode('', $matches[0]) . $content; |
|
86 | 86 | } |
87 | 87 | |
88 | 88 | return $content; |
@@ -207,7 +207,7 @@ discard block |
||
207 | 207 | // loop the matches |
208 | 208 | foreach ($matches as $match) { |
209 | 209 | // get the path for the file that will be imported |
210 | - $importPath = dirname($source).'/'.$match['path']; |
|
210 | + $importPath = dirname($source) . '/' . $match['path']; |
|
211 | 211 | |
212 | 212 | // only replace the import with the content if we can grab the |
213 | 213 | // content of the file |
@@ -215,7 +215,7 @@ discard block |
||
215 | 215 | // check if current file was not imported previously in the same |
216 | 216 | // import chain. |
217 | 217 | if (in_array($importPath, $parents)) { |
218 | - throw new FileImportException('Failed to import file "'.$importPath.'": circular reference detected.'); |
|
218 | + throw new FileImportException('Failed to import file "' . $importPath . '": circular reference detected.'); |
|
219 | 219 | } |
220 | 220 | |
221 | 221 | // grab referenced file & minify it (which may include importing |
@@ -225,7 +225,7 @@ discard block |
||
225 | 225 | |
226 | 226 | // check if this is only valid for certain media |
227 | 227 | if (!empty($match['media'])) { |
228 | - $importContent = '@media '.$match['media'].'{'.$importContent.'}'; |
|
228 | + $importContent = '@media ' . $match['media'] . '{' . $importContent . '}'; |
|
229 | 229 | } |
230 | 230 | |
231 | 231 | // add to replacement array |
@@ -254,7 +254,7 @@ discard block |
||
254 | 254 | protected function importFiles($source, $content) |
255 | 255 | { |
256 | 256 | $extensions = array_keys($this->importExtensions); |
257 | - $regex = '/url\((["\']?)((?!["\']?data:).*?\.('.implode('|', $extensions).'))\\1\)/i'; |
|
257 | + $regex = '/url\((["\']?)((?!["\']?data:).*?\.(' . implode('|', $extensions) . '))\\1\)/i'; |
|
258 | 258 | if ($extensions && preg_match_all($regex, $content, $matches, PREG_SET_ORDER)) { |
259 | 259 | $search = array(); |
260 | 260 | $replace = array(); |
@@ -263,7 +263,7 @@ discard block |
||
263 | 263 | foreach ($matches as $match) { |
264 | 264 | // get the path for the file that will be imported |
265 | 265 | $path = $match[2]; |
266 | - $path = dirname($source).'/'.$path; |
|
266 | + $path = dirname($source) . '/' . $path; |
|
267 | 267 | $extension = $match[3]; |
268 | 268 | |
269 | 269 | // only replace the import with the content if we're able to get |
@@ -275,7 +275,7 @@ discard block |
||
275 | 275 | |
276 | 276 | // build replacement |
277 | 277 | $search[] = $match[0]; |
278 | - $replace[] = 'url('.$this->importExtensions[$extension].';base64,'.$importContent.')'; |
|
278 | + $replace[] = 'url(' . $this->importExtensions[$extension] . ';base64,' . $importContent . ')'; |
|
279 | 279 | } |
280 | 280 | } |
281 | 281 | |
@@ -463,9 +463,9 @@ discard block |
||
463 | 463 | // build replacement |
464 | 464 | $search[] = $match[0]; |
465 | 465 | if ($type == 'url') { |
466 | - $replace[] = 'url('.$url.')'; |
|
466 | + $replace[] = 'url(' . $url . ')'; |
|
467 | 467 | } elseif ($type == 'import') { |
468 | - $replace[] = '@import "'.$url.'"'; |
|
468 | + $replace[] = '@import "' . $url . '"'; |
|
469 | 469 | } |
470 | 470 | } |
471 | 471 | |
@@ -519,8 +519,8 @@ discard block |
||
519 | 519 | ); |
520 | 520 | |
521 | 521 | return preg_replace_callback( |
522 | - '/(?<=[: ])('.implode(array_keys($colors), '|').')(?=[; }])/i', |
|
523 | - function ($match) use ($colors) { |
|
522 | + '/(?<=[: ])(' . implode(array_keys($colors), '|') . ')(?=[; }])/i', |
|
523 | + function($match) use ($colors) { |
|
524 | 524 | return $colors[strtoupper($match[0])]; |
525 | 525 | }, |
526 | 526 | $content |
@@ -541,11 +541,11 @@ discard block |
||
541 | 541 | 'bold' => 700, |
542 | 542 | ); |
543 | 543 | |
544 | - $callback = function ($match) use ($weights) { |
|
545 | - return $match[1].$weights[$match[2]]; |
|
544 | + $callback = function($match) use ($weights) { |
|
545 | + return $match[1] . $weights[$match[2]]; |
|
546 | 546 | }; |
547 | 547 | |
548 | - return preg_replace_callback('/(font-weight\s*:\s*)('.implode('|', array_keys($weights)).')(?=[;}])/', $callback, $content); |
|
548 | + return preg_replace_callback('/(font-weight\s*:\s*)(' . implode('|', array_keys($weights)) . ')(?=[;}])/', $callback, $content); |
|
549 | 549 | } |
550 | 550 | |
551 | 551 | /** |
@@ -571,19 +571,19 @@ discard block |
||
571 | 571 | // practice, Webkit (especially Safari) seems to stumble over at least |
572 | 572 | // 0%, potentially other units as well. Only stripping 'px' for now. |
573 | 573 | // @see https://github.com/matthiasmullie/minify/issues/60 |
574 | - $content = preg_replace('/'.$before.'(-?0*(\.0+)?)(?<=0)px'.$after.'/', '\\1', $content); |
|
574 | + $content = preg_replace('/' . $before . '(-?0*(\.0+)?)(?<=0)px' . $after . '/', '\\1', $content); |
|
575 | 575 | |
576 | 576 | // strip 0-digits (.0 -> 0) |
577 | - $content = preg_replace('/'.$before.'\.0+'.$units.'?'.$after.'/', '0\\1', $content); |
|
577 | + $content = preg_replace('/' . $before . '\.0+' . $units . '?' . $after . '/', '0\\1', $content); |
|
578 | 578 | // strip trailing 0: 50.10 -> 50.1, 50.10px -> 50.1px |
579 | - $content = preg_replace('/'.$before.'(-?[0-9]+\.[0-9]+)0+'.$units.'?'.$after.'/', '\\1\\2', $content); |
|
579 | + $content = preg_replace('/' . $before . '(-?[0-9]+\.[0-9]+)0+' . $units . '?' . $after . '/', '\\1\\2', $content); |
|
580 | 580 | // strip trailing 0: 50.00 -> 50, 50.00px -> 50px |
581 | - $content = preg_replace('/'.$before.'(-?[0-9]+)\.0+'.$units.'?'.$after.'/', '\\1\\2', $content); |
|
581 | + $content = preg_replace('/' . $before . '(-?[0-9]+)\.0+' . $units . '?' . $after . '/', '\\1\\2', $content); |
|
582 | 582 | // strip leading 0: 0.1 -> .1, 01.1 -> 1.1 |
583 | - $content = preg_replace('/'.$before.'(-?)0+([0-9]*\.[0-9]+)'.$units.'?'.$after.'/', '\\1\\2\\3', $content); |
|
583 | + $content = preg_replace('/' . $before . '(-?)0+([0-9]*\.[0-9]+)' . $units . '?' . $after . '/', '\\1\\2\\3', $content); |
|
584 | 584 | |
585 | 585 | // strip negative zeroes (-0 -> 0) & truncate zeroes (00 -> 0) |
586 | - $content = preg_replace('/'.$before.'-?0+'.$units.'?'.$after.'/', '0\\1', $content); |
|
586 | + $content = preg_replace('/' . $before . '-?0+' . $units . '?' . $after . '/', '0\\1', $content); |
|
587 | 587 | |
588 | 588 | // remove zeroes where they make no sense in calc: e.g. calc(100px - 0) |
589 | 589 | // the 0 doesn't have any effect, and this isn't even valid without unit |
@@ -117,14 +117,14 @@ discard block |
||
117 | 117 | { |
118 | 118 | call_user_func_array(array('parent', '__construct'), func_get_args()); |
119 | 119 | |
120 | - $dataDir = __DIR__.'/../data/js/'; |
|
120 | + $dataDir = __DIR__ . '/../data/js/'; |
|
121 | 121 | $options = FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES; |
122 | - $this->keywordsReserved = file($dataDir.'keywords_reserved.txt', $options); |
|
123 | - $this->keywordsBefore = file($dataDir.'keywords_before.txt', $options); |
|
124 | - $this->keywordsAfter = file($dataDir.'keywords_after.txt', $options); |
|
125 | - $this->operators = file($dataDir.'operators.txt', $options); |
|
126 | - $this->operatorsBefore = file($dataDir.'operators_before.txt', $options); |
|
127 | - $this->operatorsAfter = file($dataDir.'operators_after.txt', $options); |
|
122 | + $this->keywordsReserved = file($dataDir . 'keywords_reserved.txt', $options); |
|
123 | + $this->keywordsBefore = file($dataDir . 'keywords_before.txt', $options); |
|
124 | + $this->keywordsAfter = file($dataDir . 'keywords_after.txt', $options); |
|
125 | + $this->operators = file($dataDir . 'operators.txt', $options); |
|
126 | + $this->operatorsBefore = file($dataDir . 'operators_before.txt', $options); |
|
127 | + $this->operatorsAfter = file($dataDir . 'operators_after.txt', $options); |
|
128 | 128 | } |
129 | 129 | |
130 | 130 | /** |
@@ -149,7 +149,7 @@ discard block |
||
149 | 149 | * singe-line comment on the last line (in which case it would also |
150 | 150 | * be seen as part of that comment) |
151 | 151 | */ |
152 | - $content .= $js."\n;"; |
|
152 | + $content .= $js . "\n;"; |
|
153 | 153 | } |
154 | 154 | |
155 | 155 | /* |
@@ -214,9 +214,9 @@ discard block |
||
214 | 214 | { |
215 | 215 | // PHP only supports $this inside anonymous functions since 5.4 |
216 | 216 | $minifier = $this; |
217 | - $callback = function ($match) use ($minifier) { |
|
217 | + $callback = function($match) use ($minifier) { |
|
218 | 218 | $count = count($minifier->extracted); |
219 | - $placeholder = '/'.$count.'/'; |
|
219 | + $placeholder = '/' . $count . '/'; |
|
220 | 220 | $minifier->extracted[$placeholder] = $match[0]; |
221 | 221 | |
222 | 222 | return $placeholder; |
@@ -229,7 +229,7 @@ discard block |
||
229 | 229 | // likely part of a division, not a regex) |
230 | 230 | $after = '[\.,;\)\}]'; |
231 | 231 | $methods = '\.(exec|test|match|search|replace|split)\('; |
232 | - $this->registerPattern('/'.$pattern.'(?=\s*('.$after.'|'.$methods.'))/', $callback); |
|
232 | + $this->registerPattern('/' . $pattern . '(?=\s*(' . $after . '|' . $methods . '))/', $callback); |
|
233 | 233 | |
234 | 234 | // 1 more edge case: a regex can be followed by a lot more operators or |
235 | 235 | // keywords if there's a newline (ASI) in between, where the operator |
@@ -237,7 +237,7 @@ discard block |
||
237 | 237 | // (https://github.com/matthiasmullie/minify/issues/56) |
238 | 238 | $operators = $this->getOperatorsForRegex($this->operatorsBefore, '/'); |
239 | 239 | $operators += $this->getOperatorsForRegex($this->keywordsReserved, '/'); |
240 | - $this->registerPattern('/'.$pattern.'\s*\n(?=\s*('.implode('|', $operators).'))/', $callback); |
|
240 | + $this->registerPattern('/' . $pattern . '\s*\n(?=\s*(' . implode('|', $operators) . '))/', $callback); |
|
241 | 241 | } |
242 | 242 | |
243 | 243 | /** |
@@ -281,8 +281,8 @@ discard block |
||
281 | 281 | unset($operatorsBefore['+'], $operatorsBefore['-'], $operatorsAfter['+'], $operatorsAfter['-']); |
282 | 282 | $content = preg_replace( |
283 | 283 | array( |
284 | - '/('.implode('|', $operatorsBefore).')\s+/', |
|
285 | - '/\s+('.implode('|', $operatorsAfter).')/', |
|
284 | + '/(' . implode('|', $operatorsBefore) . ')\s+/', |
|
285 | + '/\s+(' . implode('|', $operatorsAfter) . ')/', |
|
286 | 286 | ), '\\1', $content |
287 | 287 | ); |
288 | 288 | |
@@ -295,8 +295,8 @@ discard block |
||
295 | 295 | ); |
296 | 296 | |
297 | 297 | // collapse whitespace around reserved words into single space |
298 | - $content = preg_replace('/(^|[;\}\s])\K('.implode('|', $keywordsBefore).')\s+/', '\\2 ', $content); |
|
299 | - $content = preg_replace('/\s+('.implode('|', $keywordsAfter).')(?=([;\{\s]|$))/', ' \\1', $content); |
|
298 | + $content = preg_replace('/(^|[;\}\s])\K(' . implode('|', $keywordsBefore) . ')\s+/', '\\2 ', $content); |
|
299 | + $content = preg_replace('/\s+(' . implode('|', $keywordsAfter) . ')(?=([;\{\s]|$))/', ' \\1', $content); |
|
300 | 300 | |
301 | 301 | /* |
302 | 302 | * We didn't strip whitespace after a couple of operators because they |
@@ -306,8 +306,8 @@ discard block |
||
306 | 306 | */ |
307 | 307 | $operatorsDiffBefore = array_diff($operators, $operatorsBefore); |
308 | 308 | $operatorsDiffAfter = array_diff($operators, $operatorsAfter); |
309 | - $content = preg_replace('/('.implode('|', $operatorsDiffBefore).')[^\S\n]+/', '\\1', $content); |
|
310 | - $content = preg_replace('/[^\S\n]+('.implode('|', $operatorsDiffAfter).')/', '\\1', $content); |
|
309 | + $content = preg_replace('/(' . implode('|', $operatorsDiffBefore) . ')[^\S\n]+/', '\\1', $content); |
|
310 | + $content = preg_replace('/[^\S\n]+(' . implode('|', $operatorsDiffAfter) . ')/', '\\1', $content); |
|
311 | 311 | |
312 | 312 | /* |
313 | 313 | * Get rid of double semicolons, except where they can be used like: |
@@ -381,7 +381,7 @@ discard block |
||
381 | 381 | |
382 | 382 | // don't confuse = with other assignment shortcuts (e.g. +=) |
383 | 383 | $chars = preg_quote('+-*\=<>%&|'); |
384 | - $operators['='] = '(?<!['.$chars.'])\='; |
|
384 | + $operators['='] = '(?<![' . $chars . '])\='; |
|
385 | 385 | |
386 | 386 | return $operators; |
387 | 387 | } |
@@ -402,8 +402,8 @@ discard block |
||
402 | 402 | $escaped = array_map('preg_quote', $keywords, $delimiter); |
403 | 403 | |
404 | 404 | // add word boundaries |
405 | - array_walk($keywords, function ($value) { |
|
406 | - return '\b'.$value.'\b'; |
|
405 | + array_walk($keywords, function($value) { |
|
406 | + return '\b' . $value . '\b'; |
|
407 | 407 | }); |
408 | 408 | |
409 | 409 | $keywords = array_combine($keywords, $escaped); |
@@ -423,7 +423,7 @@ discard block |
||
423 | 423 | // PHP only supports $this inside anonymous functions since 5.4 |
424 | 424 | $minifier = $this; |
425 | 425 | $keywords = $this->keywordsReserved; |
426 | - $callback = function ($match) use ($minifier, $keywords) { |
|
426 | + $callback = function($match) use ($minifier, $keywords) { |
|
427 | 427 | $property = trim($minifier->extracted[$match[1]], '\'"'); |
428 | 428 | |
429 | 429 | /* |
@@ -440,11 +440,11 @@ discard block |
||
440 | 440 | * array['key-here'] can't be replaced by array.key-here since '-' |
441 | 441 | * is not a valid character there. |
442 | 442 | */ |
443 | - if (!preg_match('/^'.$minifier::REGEX_VARIABLE.'$/u', $property)) { |
|
443 | + if (!preg_match('/^' . $minifier::REGEX_VARIABLE . '$/u', $property)) { |
|
444 | 444 | return $match[0]; |
445 | 445 | } |
446 | 446 | |
447 | - return '.'.$property; |
|
447 | + return '.' . $property; |
|
448 | 448 | }; |
449 | 449 | |
450 | 450 | /* |
@@ -465,9 +465,9 @@ discard block |
||
465 | 465 | * separate look-behind assertions, one for each keyword. |
466 | 466 | */ |
467 | 467 | $keywords = $this->getKeywordsForRegex($keywords); |
468 | - $keywords = '(?<!'.implode(')(?<!', $keywords).')'; |
|
468 | + $keywords = '(?<!' . implode(')(?<!', $keywords) . ')'; |
|
469 | 469 | |
470 | - return preg_replace_callback('/(?<='.$previousChar.'|\])'.$keywords.'\[\s*(([\'"])[0-9]+\\2)\s*\]/u', $callback, $content); |
|
470 | + return preg_replace_callback('/(?<=' . $previousChar . '|\])' . $keywords . '\[\s*(([\'"])[0-9]+\\2)\s*\]/u', $callback, $content); |
|
471 | 471 | } |
472 | 472 | |
473 | 473 | /** |
@@ -14,134 +14,134 @@ discard block |
||
14 | 14 | */ |
15 | 15 | class JS extends Minify |
16 | 16 | { |
17 | - /** |
|
18 | - * Var-matching regex based on https://stackoverflow.com/a/9337047/802993. |
|
19 | - * |
|
20 | - * Note that regular expressions using that bit must have the PCRE_UTF8 |
|
21 | - * pattern modifier (/u) set. |
|
22 | - * |
|
23 | - * @var string |
|
24 | - */ |
|
25 | - const REGEX_VARIABLE = '\b[$A-Z\_a-z\xaa\xb5\xba\xc0-\xd6\xd8-\xf6\xf8-\x{02c1}\x{02c6}-\x{02d1}\x{02e0}-\x{02e4}\x{02ec}\x{02ee}\x{0370}-\x{0374}\x{0376}\x{0377}\x{037a}-\x{037d}\x{0386}\x{0388}-\x{038a}\x{038c}\x{038e}-\x{03a1}\x{03a3}-\x{03f5}\x{03f7}-\x{0481}\x{048a}-\x{0527}\x{0531}-\x{0556}\x{0559}\x{0561}-\x{0587}\x{05d0}-\x{05ea}\x{05f0}-\x{05f2}\x{0620}-\x{064a}\x{066e}\x{066f}\x{0671}-\x{06d3}\x{06d5}\x{06e5}\x{06e6}\x{06ee}\x{06ef}\x{06fa}-\x{06fc}\x{06ff}\x{0710}\x{0712}-\x{072f}\x{074d}-\x{07a5}\x{07b1}\x{07ca}-\x{07ea}\x{07f4}\x{07f5}\x{07fa}\x{0800}-\x{0815}\x{081a}\x{0824}\x{0828}\x{0840}-\x{0858}\x{08a0}\x{08a2}-\x{08ac}\x{0904}-\x{0939}\x{093d}\x{0950}\x{0958}-\x{0961}\x{0971}-\x{0977}\x{0979}-\x{097f}\x{0985}-\x{098c}\x{098f}\x{0990}\x{0993}-\x{09a8}\x{09aa}-\x{09b0}\x{09b2}\x{09b6}-\x{09b9}\x{09bd}\x{09ce}\x{09dc}\x{09dd}\x{09df}-\x{09e1}\x{09f0}\x{09f1}\x{0a05}-\x{0a0a}\x{0a0f}\x{0a10}\x{0a13}-\x{0a28}\x{0a2a}-\x{0a30}\x{0a32}\x{0a33}\x{0a35}\x{0a36}\x{0a38}\x{0a39}\x{0a59}-\x{0a5c}\x{0a5e}\x{0a72}-\x{0a74}\x{0a85}-\x{0a8d}\x{0a8f}-\x{0a91}\x{0a93}-\x{0aa8}\x{0aaa}-\x{0ab0}\x{0ab2}\x{0ab3}\x{0ab5}-\x{0ab9}\x{0abd}\x{0ad0}\x{0ae0}\x{0ae1}\x{0b05}-\x{0b0c}\x{0b0f}\x{0b10}\x{0b13}-\x{0b28}\x{0b2a}-\x{0b30}\x{0b32}\x{0b33}\x{0b35}-\x{0b39}\x{0b3d}\x{0b5c}\x{0b5d}\x{0b5f}-\x{0b61}\x{0b71}\x{0b83}\x{0b85}-\x{0b8a}\x{0b8e}-\x{0b90}\x{0b92}-\x{0b95}\x{0b99}\x{0b9a}\x{0b9c}\x{0b9e}\x{0b9f}\x{0ba3}\x{0ba4}\x{0ba8}-\x{0baa}\x{0bae}-\x{0bb9}\x{0bd0}\x{0c05}-\x{0c0c}\x{0c0e}-\x{0c10}\x{0c12}-\x{0c28}\x{0c2a}-\x{0c33}\x{0c35}-\x{0c39}\x{0c3d}\x{0c58}\x{0c59}\x{0c60}\x{0c61}\x{0c85}-\x{0c8c}\x{0c8e}-\x{0c90}\x{0c92}-\x{0ca8}\x{0caa}-\x{0cb3}\x{0cb5}-\x{0cb9}\x{0cbd}\x{0cde}\x{0ce0}\x{0ce1}\x{0cf1}\x{0cf2}\x{0d05}-\x{0d0c}\x{0d0e}-\x{0d10}\x{0d12}-\x{0d3a}\x{0d3d}\x{0d4e}\x{0d60}\x{0d61}\x{0d7a}-\x{0d7f}\x{0d85}-\x{0d96}\x{0d9a}-\x{0db1}\x{0db3}-\x{0dbb}\x{0dbd}\x{0dc0}-\x{0dc6}\x{0e01}-\x{0e30}\x{0e32}\x{0e33}\x{0e40}-\x{0e46}\x{0e81}\x{0e82}\x{0e84}\x{0e87}\x{0e88}\x{0e8a}\x{0e8d}\x{0e94}-\x{0e97}\x{0e99}-\x{0e9f}\x{0ea1}-\x{0ea3}\x{0ea5}\x{0ea7}\x{0eaa}\x{0eab}\x{0ead}-\x{0eb0}\x{0eb2}\x{0eb3}\x{0ebd}\x{0ec0}-\x{0ec4}\x{0ec6}\x{0edc}-\x{0edf}\x{0f00}\x{0f40}-\x{0f47}\x{0f49}-\x{0f6c}\x{0f88}-\x{0f8c}\x{1000}-\x{102a}\x{103f}\x{1050}-\x{1055}\x{105a}-\x{105d}\x{1061}\x{1065}\x{1066}\x{106e}-\x{1070}\x{1075}-\x{1081}\x{108e}\x{10a0}-\x{10c5}\x{10c7}\x{10cd}\x{10d0}-\x{10fa}\x{10fc}-\x{1248}\x{124a}-\x{124d}\x{1250}-\x{1256}\x{1258}\x{125a}-\x{125d}\x{1260}-\x{1288}\x{128a}-\x{128d}\x{1290}-\x{12b0}\x{12b2}-\x{12b5}\x{12b8}-\x{12be}\x{12c0}\x{12c2}-\x{12c5}\x{12c8}-\x{12d6}\x{12d8}-\x{1310}\x{1312}-\x{1315}\x{1318}-\x{135a}\x{1380}-\x{138f}\x{13a0}-\x{13f4}\x{1401}-\x{166c}\x{166f}-\x{167f}\x{1681}-\x{169a}\x{16a0}-\x{16ea}\x{16ee}-\x{16f0}\x{1700}-\x{170c}\x{170e}-\x{1711}\x{1720}-\x{1731}\x{1740}-\x{1751}\x{1760}-\x{176c}\x{176e}-\x{1770}\x{1780}-\x{17b3}\x{17d7}\x{17dc}\x{1820}-\x{1877}\x{1880}-\x{18a8}\x{18aa}\x{18b0}-\x{18f5}\x{1900}-\x{191c}\x{1950}-\x{196d}\x{1970}-\x{1974}\x{1980}-\x{19ab}\x{19c1}-\x{19c7}\x{1a00}-\x{1a16}\x{1a20}-\x{1a54}\x{1aa7}\x{1b05}-\x{1b33}\x{1b45}-\x{1b4b}\x{1b83}-\x{1ba0}\x{1bae}\x{1baf}\x{1bba}-\x{1be5}\x{1c00}-\x{1c23}\x{1c4d}-\x{1c4f}\x{1c5a}-\x{1c7d}\x{1ce9}-\x{1cec}\x{1cee}-\x{1cf1}\x{1cf5}\x{1cf6}\x{1d00}-\x{1dbf}\x{1e00}-\x{1f15}\x{1f18}-\x{1f1d}\x{1f20}-\x{1f45}\x{1f48}-\x{1f4d}\x{1f50}-\x{1f57}\x{1f59}\x{1f5b}\x{1f5d}\x{1f5f}-\x{1f7d}\x{1f80}-\x{1fb4}\x{1fb6}-\x{1fbc}\x{1fbe}\x{1fc2}-\x{1fc4}\x{1fc6}-\x{1fcc}\x{1fd0}-\x{1fd3}\x{1fd6}-\x{1fdb}\x{1fe0}-\x{1fec}\x{1ff2}-\x{1ff4}\x{1ff6}-\x{1ffc}\x{2071}\x{207f}\x{2090}-\x{209c}\x{2102}\x{2107}\x{210a}-\x{2113}\x{2115}\x{2119}-\x{211d}\x{2124}\x{2126}\x{2128}\x{212a}-\x{212d}\x{212f}-\x{2139}\x{213c}-\x{213f}\x{2145}-\x{2149}\x{214e}\x{2160}-\x{2188}\x{2c00}-\x{2c2e}\x{2c30}-\x{2c5e}\x{2c60}-\x{2ce4}\x{2ceb}-\x{2cee}\x{2cf2}\x{2cf3}\x{2d00}-\x{2d25}\x{2d27}\x{2d2d}\x{2d30}-\x{2d67}\x{2d6f}\x{2d80}-\x{2d96}\x{2da0}-\x{2da6}\x{2da8}-\x{2dae}\x{2db0}-\x{2db6}\x{2db8}-\x{2dbe}\x{2dc0}-\x{2dc6}\x{2dc8}-\x{2dce}\x{2dd0}-\x{2dd6}\x{2dd8}-\x{2dde}\x{2e2f}\x{3005}-\x{3007}\x{3021}-\x{3029}\x{3031}-\x{3035}\x{3038}-\x{303c}\x{3041}-\x{3096}\x{309d}-\x{309f}\x{30a1}-\x{30fa}\x{30fc}-\x{30ff}\x{3105}-\x{312d}\x{3131}-\x{318e}\x{31a0}-\x{31ba}\x{31f0}-\x{31ff}\x{3400}-\x{4db5}\x{4e00}-\x{9fcc}\x{a000}-\x{a48c}\x{a4d0}-\x{a4fd}\x{a500}-\x{a60c}\x{a610}-\x{a61f}\x{a62a}\x{a62b}\x{a640}-\x{a66e}\x{a67f}-\x{a697}\x{a6a0}-\x{a6ef}\x{a717}-\x{a71f}\x{a722}-\x{a788}\x{a78b}-\x{a78e}\x{a790}-\x{a793}\x{a7a0}-\x{a7aa}\x{a7f8}-\x{a801}\x{a803}-\x{a805}\x{a807}-\x{a80a}\x{a80c}-\x{a822}\x{a840}-\x{a873}\x{a882}-\x{a8b3}\x{a8f2}-\x{a8f7}\x{a8fb}\x{a90a}-\x{a925}\x{a930}-\x{a946}\x{a960}-\x{a97c}\x{a984}-\x{a9b2}\x{a9cf}\x{aa00}-\x{aa28}\x{aa40}-\x{aa42}\x{aa44}-\x{aa4b}\x{aa60}-\x{aa76}\x{aa7a}\x{aa80}-\x{aaaf}\x{aab1}\x{aab5}\x{aab6}\x{aab9}-\x{aabd}\x{aac0}\x{aac2}\x{aadb}-\x{aadd}\x{aae0}-\x{aaea}\x{aaf2}-\x{aaf4}\x{ab01}-\x{ab06}\x{ab09}-\x{ab0e}\x{ab11}-\x{ab16}\x{ab20}-\x{ab26}\x{ab28}-\x{ab2e}\x{abc0}-\x{abe2}\x{ac00}-\x{d7a3}\x{d7b0}-\x{d7c6}\x{d7cb}-\x{d7fb}\x{f900}-\x{fa6d}\x{fa70}-\x{fad9}\x{fb00}-\x{fb06}\x{fb13}-\x{fb17}\x{fb1d}\x{fb1f}-\x{fb28}\x{fb2a}-\x{fb36}\x{fb38}-\x{fb3c}\x{fb3e}\x{fb40}\x{fb41}\x{fb43}\x{fb44}\x{fb46}-\x{fbb1}\x{fbd3}-\x{fd3d}\x{fd50}-\x{fd8f}\x{fd92}-\x{fdc7}\x{fdf0}-\x{fdfb}\x{fe70}-\x{fe74}\x{fe76}-\x{fefc}\x{ff21}-\x{ff3a}\x{ff41}-\x{ff5a}\x{ff66}-\x{ffbe}\x{ffc2}-\x{ffc7}\x{ffca}-\x{ffcf}\x{ffd2}-\x{ffd7}\x{ffda}-\x{ffdc}][$A-Z\_a-z\xaa\xb5\xba\xc0-\xd6\xd8-\xf6\xf8-\x{02c1}\x{02c6}-\x{02d1}\x{02e0}-\x{02e4}\x{02ec}\x{02ee}\x{0370}-\x{0374}\x{0376}\x{0377}\x{037a}-\x{037d}\x{0386}\x{0388}-\x{038a}\x{038c}\x{038e}-\x{03a1}\x{03a3}-\x{03f5}\x{03f7}-\x{0481}\x{048a}-\x{0527}\x{0531}-\x{0556}\x{0559}\x{0561}-\x{0587}\x{05d0}-\x{05ea}\x{05f0}-\x{05f2}\x{0620}-\x{064a}\x{066e}\x{066f}\x{0671}-\x{06d3}\x{06d5}\x{06e5}\x{06e6}\x{06ee}\x{06ef}\x{06fa}-\x{06fc}\x{06ff}\x{0710}\x{0712}-\x{072f}\x{074d}-\x{07a5}\x{07b1}\x{07ca}-\x{07ea}\x{07f4}\x{07f5}\x{07fa}\x{0800}-\x{0815}\x{081a}\x{0824}\x{0828}\x{0840}-\x{0858}\x{08a0}\x{08a2}-\x{08ac}\x{0904}-\x{0939}\x{093d}\x{0950}\x{0958}-\x{0961}\x{0971}-\x{0977}\x{0979}-\x{097f}\x{0985}-\x{098c}\x{098f}\x{0990}\x{0993}-\x{09a8}\x{09aa}-\x{09b0}\x{09b2}\x{09b6}-\x{09b9}\x{09bd}\x{09ce}\x{09dc}\x{09dd}\x{09df}-\x{09e1}\x{09f0}\x{09f1}\x{0a05}-\x{0a0a}\x{0a0f}\x{0a10}\x{0a13}-\x{0a28}\x{0a2a}-\x{0a30}\x{0a32}\x{0a33}\x{0a35}\x{0a36}\x{0a38}\x{0a39}\x{0a59}-\x{0a5c}\x{0a5e}\x{0a72}-\x{0a74}\x{0a85}-\x{0a8d}\x{0a8f}-\x{0a91}\x{0a93}-\x{0aa8}\x{0aaa}-\x{0ab0}\x{0ab2}\x{0ab3}\x{0ab5}-\x{0ab9}\x{0abd}\x{0ad0}\x{0ae0}\x{0ae1}\x{0b05}-\x{0b0c}\x{0b0f}\x{0b10}\x{0b13}-\x{0b28}\x{0b2a}-\x{0b30}\x{0b32}\x{0b33}\x{0b35}-\x{0b39}\x{0b3d}\x{0b5c}\x{0b5d}\x{0b5f}-\x{0b61}\x{0b71}\x{0b83}\x{0b85}-\x{0b8a}\x{0b8e}-\x{0b90}\x{0b92}-\x{0b95}\x{0b99}\x{0b9a}\x{0b9c}\x{0b9e}\x{0b9f}\x{0ba3}\x{0ba4}\x{0ba8}-\x{0baa}\x{0bae}-\x{0bb9}\x{0bd0}\x{0c05}-\x{0c0c}\x{0c0e}-\x{0c10}\x{0c12}-\x{0c28}\x{0c2a}-\x{0c33}\x{0c35}-\x{0c39}\x{0c3d}\x{0c58}\x{0c59}\x{0c60}\x{0c61}\x{0c85}-\x{0c8c}\x{0c8e}-\x{0c90}\x{0c92}-\x{0ca8}\x{0caa}-\x{0cb3}\x{0cb5}-\x{0cb9}\x{0cbd}\x{0cde}\x{0ce0}\x{0ce1}\x{0cf1}\x{0cf2}\x{0d05}-\x{0d0c}\x{0d0e}-\x{0d10}\x{0d12}-\x{0d3a}\x{0d3d}\x{0d4e}\x{0d60}\x{0d61}\x{0d7a}-\x{0d7f}\x{0d85}-\x{0d96}\x{0d9a}-\x{0db1}\x{0db3}-\x{0dbb}\x{0dbd}\x{0dc0}-\x{0dc6}\x{0e01}-\x{0e30}\x{0e32}\x{0e33}\x{0e40}-\x{0e46}\x{0e81}\x{0e82}\x{0e84}\x{0e87}\x{0e88}\x{0e8a}\x{0e8d}\x{0e94}-\x{0e97}\x{0e99}-\x{0e9f}\x{0ea1}-\x{0ea3}\x{0ea5}\x{0ea7}\x{0eaa}\x{0eab}\x{0ead}-\x{0eb0}\x{0eb2}\x{0eb3}\x{0ebd}\x{0ec0}-\x{0ec4}\x{0ec6}\x{0edc}-\x{0edf}\x{0f00}\x{0f40}-\x{0f47}\x{0f49}-\x{0f6c}\x{0f88}-\x{0f8c}\x{1000}-\x{102a}\x{103f}\x{1050}-\x{1055}\x{105a}-\x{105d}\x{1061}\x{1065}\x{1066}\x{106e}-\x{1070}\x{1075}-\x{1081}\x{108e}\x{10a0}-\x{10c5}\x{10c7}\x{10cd}\x{10d0}-\x{10fa}\x{10fc}-\x{1248}\x{124a}-\x{124d}\x{1250}-\x{1256}\x{1258}\x{125a}-\x{125d}\x{1260}-\x{1288}\x{128a}-\x{128d}\x{1290}-\x{12b0}\x{12b2}-\x{12b5}\x{12b8}-\x{12be}\x{12c0}\x{12c2}-\x{12c5}\x{12c8}-\x{12d6}\x{12d8}-\x{1310}\x{1312}-\x{1315}\x{1318}-\x{135a}\x{1380}-\x{138f}\x{13a0}-\x{13f4}\x{1401}-\x{166c}\x{166f}-\x{167f}\x{1681}-\x{169a}\x{16a0}-\x{16ea}\x{16ee}-\x{16f0}\x{1700}-\x{170c}\x{170e}-\x{1711}\x{1720}-\x{1731}\x{1740}-\x{1751}\x{1760}-\x{176c}\x{176e}-\x{1770}\x{1780}-\x{17b3}\x{17d7}\x{17dc}\x{1820}-\x{1877}\x{1880}-\x{18a8}\x{18aa}\x{18b0}-\x{18f5}\x{1900}-\x{191c}\x{1950}-\x{196d}\x{1970}-\x{1974}\x{1980}-\x{19ab}\x{19c1}-\x{19c7}\x{1a00}-\x{1a16}\x{1a20}-\x{1a54}\x{1aa7}\x{1b05}-\x{1b33}\x{1b45}-\x{1b4b}\x{1b83}-\x{1ba0}\x{1bae}\x{1baf}\x{1bba}-\x{1be5}\x{1c00}-\x{1c23}\x{1c4d}-\x{1c4f}\x{1c5a}-\x{1c7d}\x{1ce9}-\x{1cec}\x{1cee}-\x{1cf1}\x{1cf5}\x{1cf6}\x{1d00}-\x{1dbf}\x{1e00}-\x{1f15}\x{1f18}-\x{1f1d}\x{1f20}-\x{1f45}\x{1f48}-\x{1f4d}\x{1f50}-\x{1f57}\x{1f59}\x{1f5b}\x{1f5d}\x{1f5f}-\x{1f7d}\x{1f80}-\x{1fb4}\x{1fb6}-\x{1fbc}\x{1fbe}\x{1fc2}-\x{1fc4}\x{1fc6}-\x{1fcc}\x{1fd0}-\x{1fd3}\x{1fd6}-\x{1fdb}\x{1fe0}-\x{1fec}\x{1ff2}-\x{1ff4}\x{1ff6}-\x{1ffc}\x{2071}\x{207f}\x{2090}-\x{209c}\x{2102}\x{2107}\x{210a}-\x{2113}\x{2115}\x{2119}-\x{211d}\x{2124}\x{2126}\x{2128}\x{212a}-\x{212d}\x{212f}-\x{2139}\x{213c}-\x{213f}\x{2145}-\x{2149}\x{214e}\x{2160}-\x{2188}\x{2c00}-\x{2c2e}\x{2c30}-\x{2c5e}\x{2c60}-\x{2ce4}\x{2ceb}-\x{2cee}\x{2cf2}\x{2cf3}\x{2d00}-\x{2d25}\x{2d27}\x{2d2d}\x{2d30}-\x{2d67}\x{2d6f}\x{2d80}-\x{2d96}\x{2da0}-\x{2da6}\x{2da8}-\x{2dae}\x{2db0}-\x{2db6}\x{2db8}-\x{2dbe}\x{2dc0}-\x{2dc6}\x{2dc8}-\x{2dce}\x{2dd0}-\x{2dd6}\x{2dd8}-\x{2dde}\x{2e2f}\x{3005}-\x{3007}\x{3021}-\x{3029}\x{3031}-\x{3035}\x{3038}-\x{303c}\x{3041}-\x{3096}\x{309d}-\x{309f}\x{30a1}-\x{30fa}\x{30fc}-\x{30ff}\x{3105}-\x{312d}\x{3131}-\x{318e}\x{31a0}-\x{31ba}\x{31f0}-\x{31ff}\x{3400}-\x{4db5}\x{4e00}-\x{9fcc}\x{a000}-\x{a48c}\x{a4d0}-\x{a4fd}\x{a500}-\x{a60c}\x{a610}-\x{a61f}\x{a62a}\x{a62b}\x{a640}-\x{a66e}\x{a67f}-\x{a697}\x{a6a0}-\x{a6ef}\x{a717}-\x{a71f}\x{a722}-\x{a788}\x{a78b}-\x{a78e}\x{a790}-\x{a793}\x{a7a0}-\x{a7aa}\x{a7f8}-\x{a801}\x{a803}-\x{a805}\x{a807}-\x{a80a}\x{a80c}-\x{a822}\x{a840}-\x{a873}\x{a882}-\x{a8b3}\x{a8f2}-\x{a8f7}\x{a8fb}\x{a90a}-\x{a925}\x{a930}-\x{a946}\x{a960}-\x{a97c}\x{a984}-\x{a9b2}\x{a9cf}\x{aa00}-\x{aa28}\x{aa40}-\x{aa42}\x{aa44}-\x{aa4b}\x{aa60}-\x{aa76}\x{aa7a}\x{aa80}-\x{aaaf}\x{aab1}\x{aab5}\x{aab6}\x{aab9}-\x{aabd}\x{aac0}\x{aac2}\x{aadb}-\x{aadd}\x{aae0}-\x{aaea}\x{aaf2}-\x{aaf4}\x{ab01}-\x{ab06}\x{ab09}-\x{ab0e}\x{ab11}-\x{ab16}\x{ab20}-\x{ab26}\x{ab28}-\x{ab2e}\x{abc0}-\x{abe2}\x{ac00}-\x{d7a3}\x{d7b0}-\x{d7c6}\x{d7cb}-\x{d7fb}\x{f900}-\x{fa6d}\x{fa70}-\x{fad9}\x{fb00}-\x{fb06}\x{fb13}-\x{fb17}\x{fb1d}\x{fb1f}-\x{fb28}\x{fb2a}-\x{fb36}\x{fb38}-\x{fb3c}\x{fb3e}\x{fb40}\x{fb41}\x{fb43}\x{fb44}\x{fb46}-\x{fbb1}\x{fbd3}-\x{fd3d}\x{fd50}-\x{fd8f}\x{fd92}-\x{fdc7}\x{fdf0}-\x{fdfb}\x{fe70}-\x{fe74}\x{fe76}-\x{fefc}\x{ff21}-\x{ff3a}\x{ff41}-\x{ff5a}\x{ff66}-\x{ffbe}\x{ffc2}-\x{ffc7}\x{ffca}-\x{ffcf}\x{ffd2}-\x{ffd7}\x{ffda}-\x{ffdc}0-9\x{0300}-\x{036f}\x{0483}-\x{0487}\x{0591}-\x{05bd}\x{05bf}\x{05c1}\x{05c2}\x{05c4}\x{05c5}\x{05c7}\x{0610}-\x{061a}\x{064b}-\x{0669}\x{0670}\x{06d6}-\x{06dc}\x{06df}-\x{06e4}\x{06e7}\x{06e8}\x{06ea}-\x{06ed}\x{06f0}-\x{06f9}\x{0711}\x{0730}-\x{074a}\x{07a6}-\x{07b0}\x{07c0}-\x{07c9}\x{07eb}-\x{07f3}\x{0816}-\x{0819}\x{081b}-\x{0823}\x{0825}-\x{0827}\x{0829}-\x{082d}\x{0859}-\x{085b}\x{08e4}-\x{08fe}\x{0900}-\x{0903}\x{093a}-\x{093c}\x{093e}-\x{094f}\x{0951}-\x{0957}\x{0962}\x{0963}\x{0966}-\x{096f}\x{0981}-\x{0983}\x{09bc}\x{09be}-\x{09c4}\x{09c7}\x{09c8}\x{09cb}-\x{09cd}\x{09d7}\x{09e2}\x{09e3}\x{09e6}-\x{09ef}\x{0a01}-\x{0a03}\x{0a3c}\x{0a3e}-\x{0a42}\x{0a47}\x{0a48}\x{0a4b}-\x{0a4d}\x{0a51}\x{0a66}-\x{0a71}\x{0a75}\x{0a81}-\x{0a83}\x{0abc}\x{0abe}-\x{0ac5}\x{0ac7}-\x{0ac9}\x{0acb}-\x{0acd}\x{0ae2}\x{0ae3}\x{0ae6}-\x{0aef}\x{0b01}-\x{0b03}\x{0b3c}\x{0b3e}-\x{0b44}\x{0b47}\x{0b48}\x{0b4b}-\x{0b4d}\x{0b56}\x{0b57}\x{0b62}\x{0b63}\x{0b66}-\x{0b6f}\x{0b82}\x{0bbe}-\x{0bc2}\x{0bc6}-\x{0bc8}\x{0bca}-\x{0bcd}\x{0bd7}\x{0be6}-\x{0bef}\x{0c01}-\x{0c03}\x{0c3e}-\x{0c44}\x{0c46}-\x{0c48}\x{0c4a}-\x{0c4d}\x{0c55}\x{0c56}\x{0c62}\x{0c63}\x{0c66}-\x{0c6f}\x{0c82}\x{0c83}\x{0cbc}\x{0cbe}-\x{0cc4}\x{0cc6}-\x{0cc8}\x{0cca}-\x{0ccd}\x{0cd5}\x{0cd6}\x{0ce2}\x{0ce3}\x{0ce6}-\x{0cef}\x{0d02}\x{0d03}\x{0d3e}-\x{0d44}\x{0d46}-\x{0d48}\x{0d4a}-\x{0d4d}\x{0d57}\x{0d62}\x{0d63}\x{0d66}-\x{0d6f}\x{0d82}\x{0d83}\x{0dca}\x{0dcf}-\x{0dd4}\x{0dd6}\x{0dd8}-\x{0ddf}\x{0df2}\x{0df3}\x{0e31}\x{0e34}-\x{0e3a}\x{0e47}-\x{0e4e}\x{0e50}-\x{0e59}\x{0eb1}\x{0eb4}-\x{0eb9}\x{0ebb}\x{0ebc}\x{0ec8}-\x{0ecd}\x{0ed0}-\x{0ed9}\x{0f18}\x{0f19}\x{0f20}-\x{0f29}\x{0f35}\x{0f37}\x{0f39}\x{0f3e}\x{0f3f}\x{0f71}-\x{0f84}\x{0f86}\x{0f87}\x{0f8d}-\x{0f97}\x{0f99}-\x{0fbc}\x{0fc6}\x{102b}-\x{103e}\x{1040}-\x{1049}\x{1056}-\x{1059}\x{105e}-\x{1060}\x{1062}-\x{1064}\x{1067}-\x{106d}\x{1071}-\x{1074}\x{1082}-\x{108d}\x{108f}-\x{109d}\x{135d}-\x{135f}\x{1712}-\x{1714}\x{1732}-\x{1734}\x{1752}\x{1753}\x{1772}\x{1773}\x{17b4}-\x{17d3}\x{17dd}\x{17e0}-\x{17e9}\x{180b}-\x{180d}\x{1810}-\x{1819}\x{18a9}\x{1920}-\x{192b}\x{1930}-\x{193b}\x{1946}-\x{194f}\x{19b0}-\x{19c0}\x{19c8}\x{19c9}\x{19d0}-\x{19d9}\x{1a17}-\x{1a1b}\x{1a55}-\x{1a5e}\x{1a60}-\x{1a7c}\x{1a7f}-\x{1a89}\x{1a90}-\x{1a99}\x{1b00}-\x{1b04}\x{1b34}-\x{1b44}\x{1b50}-\x{1b59}\x{1b6b}-\x{1b73}\x{1b80}-\x{1b82}\x{1ba1}-\x{1bad}\x{1bb0}-\x{1bb9}\x{1be6}-\x{1bf3}\x{1c24}-\x{1c37}\x{1c40}-\x{1c49}\x{1c50}-\x{1c59}\x{1cd0}-\x{1cd2}\x{1cd4}-\x{1ce8}\x{1ced}\x{1cf2}-\x{1cf4}\x{1dc0}-\x{1de6}\x{1dfc}-\x{1dff}\x{200c}\x{200d}\x{203f}\x{2040}\x{2054}\x{20d0}-\x{20dc}\x{20e1}\x{20e5}-\x{20f0}\x{2cef}-\x{2cf1}\x{2d7f}\x{2de0}-\x{2dff}\x{302a}-\x{302f}\x{3099}\x{309a}\x{a620}-\x{a629}\x{a66f}\x{a674}-\x{a67d}\x{a69f}\x{a6f0}\x{a6f1}\x{a802}\x{a806}\x{a80b}\x{a823}-\x{a827}\x{a880}\x{a881}\x{a8b4}-\x{a8c4}\x{a8d0}-\x{a8d9}\x{a8e0}-\x{a8f1}\x{a900}-\x{a909}\x{a926}-\x{a92d}\x{a947}-\x{a953}\x{a980}-\x{a983}\x{a9b3}-\x{a9c0}\x{a9d0}-\x{a9d9}\x{aa29}-\x{aa36}\x{aa43}\x{aa4c}\x{aa4d}\x{aa50}-\x{aa59}\x{aa7b}\x{aab0}\x{aab2}-\x{aab4}\x{aab7}\x{aab8}\x{aabe}\x{aabf}\x{aac1}\x{aaeb}-\x{aaef}\x{aaf5}\x{aaf6}\x{abe3}-\x{abea}\x{abec}\x{abed}\x{abf0}-\x{abf9}\x{fb1e}\x{fe00}-\x{fe0f}\x{fe20}-\x{fe26}\x{fe33}\x{fe34}\x{fe4d}-\x{fe4f}\x{ff10}-\x{ff19}\x{ff3f}]*\b'; |
|
26 | - |
|
27 | - /** |
|
28 | - * Full list of JavaScript reserved words. |
|
29 | - * Will be loaded from /data/js/keywords_reserved.txt. |
|
30 | - * |
|
31 | - * @see https://mathiasbynens.be/notes/reserved-keywords |
|
32 | - * |
|
33 | - * @var string[] |
|
34 | - */ |
|
35 | - protected $keywordsReserved = array(); |
|
36 | - |
|
37 | - /** |
|
38 | - * List of JavaScript reserved words that accept a <variable, value, ...> |
|
39 | - * after them. Some end of lines are not the end of a statement, like with |
|
40 | - * these keywords. |
|
41 | - * |
|
42 | - * E.g.: we shouldn't insert a ; after this else |
|
43 | - * else |
|
44 | - * console.log('this is quite fine') |
|
45 | - * |
|
46 | - * Will be loaded from /data/js/keywords_before.txt |
|
47 | - * |
|
48 | - * @var string[] |
|
49 | - */ |
|
50 | - protected $keywordsBefore = array(); |
|
51 | - |
|
52 | - /** |
|
53 | - * List of JavaScript reserved words that accept a <variable, value, ...> |
|
54 | - * before them. Some end of lines are not the end of a statement, like when |
|
55 | - * continued by one of these keywords on the newline. |
|
56 | - * |
|
57 | - * E.g.: we shouldn't insert a ; before this instanceof |
|
58 | - * variable |
|
59 | - * instanceof String |
|
60 | - * |
|
61 | - * Will be loaded from /data/js/keywords_after.txt |
|
62 | - * |
|
63 | - * @var string[] |
|
64 | - */ |
|
65 | - protected $keywordsAfter = array(); |
|
66 | - |
|
67 | - /** |
|
68 | - * List of all JavaScript operators. |
|
69 | - * |
|
70 | - * Will be loaded from /data/js/operators.txt |
|
71 | - * |
|
72 | - * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators |
|
73 | - * |
|
74 | - * @var string[] |
|
75 | - */ |
|
76 | - protected $operators = array(); |
|
77 | - |
|
78 | - /** |
|
79 | - * List of JavaScript operators that accept a <variable, value, ...> after |
|
80 | - * them. Some end of lines are not the end of a statement, like with these |
|
81 | - * operators. |
|
82 | - * |
|
83 | - * Note: Most operators are fine, we've only removed !, ++ and --. |
|
84 | - * There can't be a newline separating ! and whatever it is negating. |
|
85 | - * ++ & -- have to be joined with the value they're in-/decrementing. |
|
86 | - * |
|
87 | - * Will be loaded from /data/js/operators_before.txt |
|
88 | - * |
|
89 | - * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators |
|
90 | - * |
|
91 | - * @var string[] |
|
92 | - */ |
|
93 | - protected $operatorsBefore = array(); |
|
94 | - |
|
95 | - /** |
|
96 | - * List of JavaScript operators that accept a <variable, value, ...> before |
|
97 | - * them. Some end of lines are not the end of a statement, like when |
|
98 | - * continued by one of these operators on the newline. |
|
99 | - * |
|
100 | - * Note: Most operators are fine, we've only removed ), ], ++ and --. |
|
101 | - * ++ & -- have to be joined with the value they're in-/decrementing. |
|
102 | - * ) & ] are "special" in that they have lots or usecases. () for example |
|
103 | - * is used for function calls, for grouping, in if () and for (), ... |
|
104 | - * |
|
105 | - * Will be loaded from /data/js/operators_after.txt |
|
106 | - * |
|
107 | - * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators |
|
108 | - * |
|
109 | - * @var string[] |
|
110 | - */ |
|
111 | - protected $operatorsAfter = array(); |
|
112 | - |
|
113 | - /** |
|
114 | - * {@inheritdoc} |
|
115 | - */ |
|
116 | - public function __construct() |
|
117 | - { |
|
118 | - call_user_func_array(array('parent', '__construct'), func_get_args()); |
|
119 | - |
|
120 | - $dataDir = __DIR__.'/../data/js/'; |
|
121 | - $options = FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES; |
|
122 | - $this->keywordsReserved = file($dataDir.'keywords_reserved.txt', $options); |
|
123 | - $this->keywordsBefore = file($dataDir.'keywords_before.txt', $options); |
|
124 | - $this->keywordsAfter = file($dataDir.'keywords_after.txt', $options); |
|
125 | - $this->operators = file($dataDir.'operators.txt', $options); |
|
126 | - $this->operatorsBefore = file($dataDir.'operators_before.txt', $options); |
|
127 | - $this->operatorsAfter = file($dataDir.'operators_after.txt', $options); |
|
128 | - } |
|
129 | - |
|
130 | - /** |
|
131 | - * Minify the data. |
|
132 | - * Perform JS optimizations. |
|
133 | - * |
|
134 | - * @param string[optional] $path Path to write the data to |
|
135 | - * |
|
136 | - * @return string The minified data |
|
137 | - */ |
|
138 | - public function execute($path = null) |
|
139 | - { |
|
140 | - $content = ''; |
|
141 | - |
|
142 | - // loop files |
|
143 | - foreach ($this->data as $source => $js) { |
|
144 | - /* |
|
17 | + /** |
|
18 | + * Var-matching regex based on https://stackoverflow.com/a/9337047/802993. |
|
19 | + * |
|
20 | + * Note that regular expressions using that bit must have the PCRE_UTF8 |
|
21 | + * pattern modifier (/u) set. |
|
22 | + * |
|
23 | + * @var string |
|
24 | + */ |
|
25 | + const REGEX_VARIABLE = '\b[$A-Z\_a-z\xaa\xb5\xba\xc0-\xd6\xd8-\xf6\xf8-\x{02c1}\x{02c6}-\x{02d1}\x{02e0}-\x{02e4}\x{02ec}\x{02ee}\x{0370}-\x{0374}\x{0376}\x{0377}\x{037a}-\x{037d}\x{0386}\x{0388}-\x{038a}\x{038c}\x{038e}-\x{03a1}\x{03a3}-\x{03f5}\x{03f7}-\x{0481}\x{048a}-\x{0527}\x{0531}-\x{0556}\x{0559}\x{0561}-\x{0587}\x{05d0}-\x{05ea}\x{05f0}-\x{05f2}\x{0620}-\x{064a}\x{066e}\x{066f}\x{0671}-\x{06d3}\x{06d5}\x{06e5}\x{06e6}\x{06ee}\x{06ef}\x{06fa}-\x{06fc}\x{06ff}\x{0710}\x{0712}-\x{072f}\x{074d}-\x{07a5}\x{07b1}\x{07ca}-\x{07ea}\x{07f4}\x{07f5}\x{07fa}\x{0800}-\x{0815}\x{081a}\x{0824}\x{0828}\x{0840}-\x{0858}\x{08a0}\x{08a2}-\x{08ac}\x{0904}-\x{0939}\x{093d}\x{0950}\x{0958}-\x{0961}\x{0971}-\x{0977}\x{0979}-\x{097f}\x{0985}-\x{098c}\x{098f}\x{0990}\x{0993}-\x{09a8}\x{09aa}-\x{09b0}\x{09b2}\x{09b6}-\x{09b9}\x{09bd}\x{09ce}\x{09dc}\x{09dd}\x{09df}-\x{09e1}\x{09f0}\x{09f1}\x{0a05}-\x{0a0a}\x{0a0f}\x{0a10}\x{0a13}-\x{0a28}\x{0a2a}-\x{0a30}\x{0a32}\x{0a33}\x{0a35}\x{0a36}\x{0a38}\x{0a39}\x{0a59}-\x{0a5c}\x{0a5e}\x{0a72}-\x{0a74}\x{0a85}-\x{0a8d}\x{0a8f}-\x{0a91}\x{0a93}-\x{0aa8}\x{0aaa}-\x{0ab0}\x{0ab2}\x{0ab3}\x{0ab5}-\x{0ab9}\x{0abd}\x{0ad0}\x{0ae0}\x{0ae1}\x{0b05}-\x{0b0c}\x{0b0f}\x{0b10}\x{0b13}-\x{0b28}\x{0b2a}-\x{0b30}\x{0b32}\x{0b33}\x{0b35}-\x{0b39}\x{0b3d}\x{0b5c}\x{0b5d}\x{0b5f}-\x{0b61}\x{0b71}\x{0b83}\x{0b85}-\x{0b8a}\x{0b8e}-\x{0b90}\x{0b92}-\x{0b95}\x{0b99}\x{0b9a}\x{0b9c}\x{0b9e}\x{0b9f}\x{0ba3}\x{0ba4}\x{0ba8}-\x{0baa}\x{0bae}-\x{0bb9}\x{0bd0}\x{0c05}-\x{0c0c}\x{0c0e}-\x{0c10}\x{0c12}-\x{0c28}\x{0c2a}-\x{0c33}\x{0c35}-\x{0c39}\x{0c3d}\x{0c58}\x{0c59}\x{0c60}\x{0c61}\x{0c85}-\x{0c8c}\x{0c8e}-\x{0c90}\x{0c92}-\x{0ca8}\x{0caa}-\x{0cb3}\x{0cb5}-\x{0cb9}\x{0cbd}\x{0cde}\x{0ce0}\x{0ce1}\x{0cf1}\x{0cf2}\x{0d05}-\x{0d0c}\x{0d0e}-\x{0d10}\x{0d12}-\x{0d3a}\x{0d3d}\x{0d4e}\x{0d60}\x{0d61}\x{0d7a}-\x{0d7f}\x{0d85}-\x{0d96}\x{0d9a}-\x{0db1}\x{0db3}-\x{0dbb}\x{0dbd}\x{0dc0}-\x{0dc6}\x{0e01}-\x{0e30}\x{0e32}\x{0e33}\x{0e40}-\x{0e46}\x{0e81}\x{0e82}\x{0e84}\x{0e87}\x{0e88}\x{0e8a}\x{0e8d}\x{0e94}-\x{0e97}\x{0e99}-\x{0e9f}\x{0ea1}-\x{0ea3}\x{0ea5}\x{0ea7}\x{0eaa}\x{0eab}\x{0ead}-\x{0eb0}\x{0eb2}\x{0eb3}\x{0ebd}\x{0ec0}-\x{0ec4}\x{0ec6}\x{0edc}-\x{0edf}\x{0f00}\x{0f40}-\x{0f47}\x{0f49}-\x{0f6c}\x{0f88}-\x{0f8c}\x{1000}-\x{102a}\x{103f}\x{1050}-\x{1055}\x{105a}-\x{105d}\x{1061}\x{1065}\x{1066}\x{106e}-\x{1070}\x{1075}-\x{1081}\x{108e}\x{10a0}-\x{10c5}\x{10c7}\x{10cd}\x{10d0}-\x{10fa}\x{10fc}-\x{1248}\x{124a}-\x{124d}\x{1250}-\x{1256}\x{1258}\x{125a}-\x{125d}\x{1260}-\x{1288}\x{128a}-\x{128d}\x{1290}-\x{12b0}\x{12b2}-\x{12b5}\x{12b8}-\x{12be}\x{12c0}\x{12c2}-\x{12c5}\x{12c8}-\x{12d6}\x{12d8}-\x{1310}\x{1312}-\x{1315}\x{1318}-\x{135a}\x{1380}-\x{138f}\x{13a0}-\x{13f4}\x{1401}-\x{166c}\x{166f}-\x{167f}\x{1681}-\x{169a}\x{16a0}-\x{16ea}\x{16ee}-\x{16f0}\x{1700}-\x{170c}\x{170e}-\x{1711}\x{1720}-\x{1731}\x{1740}-\x{1751}\x{1760}-\x{176c}\x{176e}-\x{1770}\x{1780}-\x{17b3}\x{17d7}\x{17dc}\x{1820}-\x{1877}\x{1880}-\x{18a8}\x{18aa}\x{18b0}-\x{18f5}\x{1900}-\x{191c}\x{1950}-\x{196d}\x{1970}-\x{1974}\x{1980}-\x{19ab}\x{19c1}-\x{19c7}\x{1a00}-\x{1a16}\x{1a20}-\x{1a54}\x{1aa7}\x{1b05}-\x{1b33}\x{1b45}-\x{1b4b}\x{1b83}-\x{1ba0}\x{1bae}\x{1baf}\x{1bba}-\x{1be5}\x{1c00}-\x{1c23}\x{1c4d}-\x{1c4f}\x{1c5a}-\x{1c7d}\x{1ce9}-\x{1cec}\x{1cee}-\x{1cf1}\x{1cf5}\x{1cf6}\x{1d00}-\x{1dbf}\x{1e00}-\x{1f15}\x{1f18}-\x{1f1d}\x{1f20}-\x{1f45}\x{1f48}-\x{1f4d}\x{1f50}-\x{1f57}\x{1f59}\x{1f5b}\x{1f5d}\x{1f5f}-\x{1f7d}\x{1f80}-\x{1fb4}\x{1fb6}-\x{1fbc}\x{1fbe}\x{1fc2}-\x{1fc4}\x{1fc6}-\x{1fcc}\x{1fd0}-\x{1fd3}\x{1fd6}-\x{1fdb}\x{1fe0}-\x{1fec}\x{1ff2}-\x{1ff4}\x{1ff6}-\x{1ffc}\x{2071}\x{207f}\x{2090}-\x{209c}\x{2102}\x{2107}\x{210a}-\x{2113}\x{2115}\x{2119}-\x{211d}\x{2124}\x{2126}\x{2128}\x{212a}-\x{212d}\x{212f}-\x{2139}\x{213c}-\x{213f}\x{2145}-\x{2149}\x{214e}\x{2160}-\x{2188}\x{2c00}-\x{2c2e}\x{2c30}-\x{2c5e}\x{2c60}-\x{2ce4}\x{2ceb}-\x{2cee}\x{2cf2}\x{2cf3}\x{2d00}-\x{2d25}\x{2d27}\x{2d2d}\x{2d30}-\x{2d67}\x{2d6f}\x{2d80}-\x{2d96}\x{2da0}-\x{2da6}\x{2da8}-\x{2dae}\x{2db0}-\x{2db6}\x{2db8}-\x{2dbe}\x{2dc0}-\x{2dc6}\x{2dc8}-\x{2dce}\x{2dd0}-\x{2dd6}\x{2dd8}-\x{2dde}\x{2e2f}\x{3005}-\x{3007}\x{3021}-\x{3029}\x{3031}-\x{3035}\x{3038}-\x{303c}\x{3041}-\x{3096}\x{309d}-\x{309f}\x{30a1}-\x{30fa}\x{30fc}-\x{30ff}\x{3105}-\x{312d}\x{3131}-\x{318e}\x{31a0}-\x{31ba}\x{31f0}-\x{31ff}\x{3400}-\x{4db5}\x{4e00}-\x{9fcc}\x{a000}-\x{a48c}\x{a4d0}-\x{a4fd}\x{a500}-\x{a60c}\x{a610}-\x{a61f}\x{a62a}\x{a62b}\x{a640}-\x{a66e}\x{a67f}-\x{a697}\x{a6a0}-\x{a6ef}\x{a717}-\x{a71f}\x{a722}-\x{a788}\x{a78b}-\x{a78e}\x{a790}-\x{a793}\x{a7a0}-\x{a7aa}\x{a7f8}-\x{a801}\x{a803}-\x{a805}\x{a807}-\x{a80a}\x{a80c}-\x{a822}\x{a840}-\x{a873}\x{a882}-\x{a8b3}\x{a8f2}-\x{a8f7}\x{a8fb}\x{a90a}-\x{a925}\x{a930}-\x{a946}\x{a960}-\x{a97c}\x{a984}-\x{a9b2}\x{a9cf}\x{aa00}-\x{aa28}\x{aa40}-\x{aa42}\x{aa44}-\x{aa4b}\x{aa60}-\x{aa76}\x{aa7a}\x{aa80}-\x{aaaf}\x{aab1}\x{aab5}\x{aab6}\x{aab9}-\x{aabd}\x{aac0}\x{aac2}\x{aadb}-\x{aadd}\x{aae0}-\x{aaea}\x{aaf2}-\x{aaf4}\x{ab01}-\x{ab06}\x{ab09}-\x{ab0e}\x{ab11}-\x{ab16}\x{ab20}-\x{ab26}\x{ab28}-\x{ab2e}\x{abc0}-\x{abe2}\x{ac00}-\x{d7a3}\x{d7b0}-\x{d7c6}\x{d7cb}-\x{d7fb}\x{f900}-\x{fa6d}\x{fa70}-\x{fad9}\x{fb00}-\x{fb06}\x{fb13}-\x{fb17}\x{fb1d}\x{fb1f}-\x{fb28}\x{fb2a}-\x{fb36}\x{fb38}-\x{fb3c}\x{fb3e}\x{fb40}\x{fb41}\x{fb43}\x{fb44}\x{fb46}-\x{fbb1}\x{fbd3}-\x{fd3d}\x{fd50}-\x{fd8f}\x{fd92}-\x{fdc7}\x{fdf0}-\x{fdfb}\x{fe70}-\x{fe74}\x{fe76}-\x{fefc}\x{ff21}-\x{ff3a}\x{ff41}-\x{ff5a}\x{ff66}-\x{ffbe}\x{ffc2}-\x{ffc7}\x{ffca}-\x{ffcf}\x{ffd2}-\x{ffd7}\x{ffda}-\x{ffdc}][$A-Z\_a-z\xaa\xb5\xba\xc0-\xd6\xd8-\xf6\xf8-\x{02c1}\x{02c6}-\x{02d1}\x{02e0}-\x{02e4}\x{02ec}\x{02ee}\x{0370}-\x{0374}\x{0376}\x{0377}\x{037a}-\x{037d}\x{0386}\x{0388}-\x{038a}\x{038c}\x{038e}-\x{03a1}\x{03a3}-\x{03f5}\x{03f7}-\x{0481}\x{048a}-\x{0527}\x{0531}-\x{0556}\x{0559}\x{0561}-\x{0587}\x{05d0}-\x{05ea}\x{05f0}-\x{05f2}\x{0620}-\x{064a}\x{066e}\x{066f}\x{0671}-\x{06d3}\x{06d5}\x{06e5}\x{06e6}\x{06ee}\x{06ef}\x{06fa}-\x{06fc}\x{06ff}\x{0710}\x{0712}-\x{072f}\x{074d}-\x{07a5}\x{07b1}\x{07ca}-\x{07ea}\x{07f4}\x{07f5}\x{07fa}\x{0800}-\x{0815}\x{081a}\x{0824}\x{0828}\x{0840}-\x{0858}\x{08a0}\x{08a2}-\x{08ac}\x{0904}-\x{0939}\x{093d}\x{0950}\x{0958}-\x{0961}\x{0971}-\x{0977}\x{0979}-\x{097f}\x{0985}-\x{098c}\x{098f}\x{0990}\x{0993}-\x{09a8}\x{09aa}-\x{09b0}\x{09b2}\x{09b6}-\x{09b9}\x{09bd}\x{09ce}\x{09dc}\x{09dd}\x{09df}-\x{09e1}\x{09f0}\x{09f1}\x{0a05}-\x{0a0a}\x{0a0f}\x{0a10}\x{0a13}-\x{0a28}\x{0a2a}-\x{0a30}\x{0a32}\x{0a33}\x{0a35}\x{0a36}\x{0a38}\x{0a39}\x{0a59}-\x{0a5c}\x{0a5e}\x{0a72}-\x{0a74}\x{0a85}-\x{0a8d}\x{0a8f}-\x{0a91}\x{0a93}-\x{0aa8}\x{0aaa}-\x{0ab0}\x{0ab2}\x{0ab3}\x{0ab5}-\x{0ab9}\x{0abd}\x{0ad0}\x{0ae0}\x{0ae1}\x{0b05}-\x{0b0c}\x{0b0f}\x{0b10}\x{0b13}-\x{0b28}\x{0b2a}-\x{0b30}\x{0b32}\x{0b33}\x{0b35}-\x{0b39}\x{0b3d}\x{0b5c}\x{0b5d}\x{0b5f}-\x{0b61}\x{0b71}\x{0b83}\x{0b85}-\x{0b8a}\x{0b8e}-\x{0b90}\x{0b92}-\x{0b95}\x{0b99}\x{0b9a}\x{0b9c}\x{0b9e}\x{0b9f}\x{0ba3}\x{0ba4}\x{0ba8}-\x{0baa}\x{0bae}-\x{0bb9}\x{0bd0}\x{0c05}-\x{0c0c}\x{0c0e}-\x{0c10}\x{0c12}-\x{0c28}\x{0c2a}-\x{0c33}\x{0c35}-\x{0c39}\x{0c3d}\x{0c58}\x{0c59}\x{0c60}\x{0c61}\x{0c85}-\x{0c8c}\x{0c8e}-\x{0c90}\x{0c92}-\x{0ca8}\x{0caa}-\x{0cb3}\x{0cb5}-\x{0cb9}\x{0cbd}\x{0cde}\x{0ce0}\x{0ce1}\x{0cf1}\x{0cf2}\x{0d05}-\x{0d0c}\x{0d0e}-\x{0d10}\x{0d12}-\x{0d3a}\x{0d3d}\x{0d4e}\x{0d60}\x{0d61}\x{0d7a}-\x{0d7f}\x{0d85}-\x{0d96}\x{0d9a}-\x{0db1}\x{0db3}-\x{0dbb}\x{0dbd}\x{0dc0}-\x{0dc6}\x{0e01}-\x{0e30}\x{0e32}\x{0e33}\x{0e40}-\x{0e46}\x{0e81}\x{0e82}\x{0e84}\x{0e87}\x{0e88}\x{0e8a}\x{0e8d}\x{0e94}-\x{0e97}\x{0e99}-\x{0e9f}\x{0ea1}-\x{0ea3}\x{0ea5}\x{0ea7}\x{0eaa}\x{0eab}\x{0ead}-\x{0eb0}\x{0eb2}\x{0eb3}\x{0ebd}\x{0ec0}-\x{0ec4}\x{0ec6}\x{0edc}-\x{0edf}\x{0f00}\x{0f40}-\x{0f47}\x{0f49}-\x{0f6c}\x{0f88}-\x{0f8c}\x{1000}-\x{102a}\x{103f}\x{1050}-\x{1055}\x{105a}-\x{105d}\x{1061}\x{1065}\x{1066}\x{106e}-\x{1070}\x{1075}-\x{1081}\x{108e}\x{10a0}-\x{10c5}\x{10c7}\x{10cd}\x{10d0}-\x{10fa}\x{10fc}-\x{1248}\x{124a}-\x{124d}\x{1250}-\x{1256}\x{1258}\x{125a}-\x{125d}\x{1260}-\x{1288}\x{128a}-\x{128d}\x{1290}-\x{12b0}\x{12b2}-\x{12b5}\x{12b8}-\x{12be}\x{12c0}\x{12c2}-\x{12c5}\x{12c8}-\x{12d6}\x{12d8}-\x{1310}\x{1312}-\x{1315}\x{1318}-\x{135a}\x{1380}-\x{138f}\x{13a0}-\x{13f4}\x{1401}-\x{166c}\x{166f}-\x{167f}\x{1681}-\x{169a}\x{16a0}-\x{16ea}\x{16ee}-\x{16f0}\x{1700}-\x{170c}\x{170e}-\x{1711}\x{1720}-\x{1731}\x{1740}-\x{1751}\x{1760}-\x{176c}\x{176e}-\x{1770}\x{1780}-\x{17b3}\x{17d7}\x{17dc}\x{1820}-\x{1877}\x{1880}-\x{18a8}\x{18aa}\x{18b0}-\x{18f5}\x{1900}-\x{191c}\x{1950}-\x{196d}\x{1970}-\x{1974}\x{1980}-\x{19ab}\x{19c1}-\x{19c7}\x{1a00}-\x{1a16}\x{1a20}-\x{1a54}\x{1aa7}\x{1b05}-\x{1b33}\x{1b45}-\x{1b4b}\x{1b83}-\x{1ba0}\x{1bae}\x{1baf}\x{1bba}-\x{1be5}\x{1c00}-\x{1c23}\x{1c4d}-\x{1c4f}\x{1c5a}-\x{1c7d}\x{1ce9}-\x{1cec}\x{1cee}-\x{1cf1}\x{1cf5}\x{1cf6}\x{1d00}-\x{1dbf}\x{1e00}-\x{1f15}\x{1f18}-\x{1f1d}\x{1f20}-\x{1f45}\x{1f48}-\x{1f4d}\x{1f50}-\x{1f57}\x{1f59}\x{1f5b}\x{1f5d}\x{1f5f}-\x{1f7d}\x{1f80}-\x{1fb4}\x{1fb6}-\x{1fbc}\x{1fbe}\x{1fc2}-\x{1fc4}\x{1fc6}-\x{1fcc}\x{1fd0}-\x{1fd3}\x{1fd6}-\x{1fdb}\x{1fe0}-\x{1fec}\x{1ff2}-\x{1ff4}\x{1ff6}-\x{1ffc}\x{2071}\x{207f}\x{2090}-\x{209c}\x{2102}\x{2107}\x{210a}-\x{2113}\x{2115}\x{2119}-\x{211d}\x{2124}\x{2126}\x{2128}\x{212a}-\x{212d}\x{212f}-\x{2139}\x{213c}-\x{213f}\x{2145}-\x{2149}\x{214e}\x{2160}-\x{2188}\x{2c00}-\x{2c2e}\x{2c30}-\x{2c5e}\x{2c60}-\x{2ce4}\x{2ceb}-\x{2cee}\x{2cf2}\x{2cf3}\x{2d00}-\x{2d25}\x{2d27}\x{2d2d}\x{2d30}-\x{2d67}\x{2d6f}\x{2d80}-\x{2d96}\x{2da0}-\x{2da6}\x{2da8}-\x{2dae}\x{2db0}-\x{2db6}\x{2db8}-\x{2dbe}\x{2dc0}-\x{2dc6}\x{2dc8}-\x{2dce}\x{2dd0}-\x{2dd6}\x{2dd8}-\x{2dde}\x{2e2f}\x{3005}-\x{3007}\x{3021}-\x{3029}\x{3031}-\x{3035}\x{3038}-\x{303c}\x{3041}-\x{3096}\x{309d}-\x{309f}\x{30a1}-\x{30fa}\x{30fc}-\x{30ff}\x{3105}-\x{312d}\x{3131}-\x{318e}\x{31a0}-\x{31ba}\x{31f0}-\x{31ff}\x{3400}-\x{4db5}\x{4e00}-\x{9fcc}\x{a000}-\x{a48c}\x{a4d0}-\x{a4fd}\x{a500}-\x{a60c}\x{a610}-\x{a61f}\x{a62a}\x{a62b}\x{a640}-\x{a66e}\x{a67f}-\x{a697}\x{a6a0}-\x{a6ef}\x{a717}-\x{a71f}\x{a722}-\x{a788}\x{a78b}-\x{a78e}\x{a790}-\x{a793}\x{a7a0}-\x{a7aa}\x{a7f8}-\x{a801}\x{a803}-\x{a805}\x{a807}-\x{a80a}\x{a80c}-\x{a822}\x{a840}-\x{a873}\x{a882}-\x{a8b3}\x{a8f2}-\x{a8f7}\x{a8fb}\x{a90a}-\x{a925}\x{a930}-\x{a946}\x{a960}-\x{a97c}\x{a984}-\x{a9b2}\x{a9cf}\x{aa00}-\x{aa28}\x{aa40}-\x{aa42}\x{aa44}-\x{aa4b}\x{aa60}-\x{aa76}\x{aa7a}\x{aa80}-\x{aaaf}\x{aab1}\x{aab5}\x{aab6}\x{aab9}-\x{aabd}\x{aac0}\x{aac2}\x{aadb}-\x{aadd}\x{aae0}-\x{aaea}\x{aaf2}-\x{aaf4}\x{ab01}-\x{ab06}\x{ab09}-\x{ab0e}\x{ab11}-\x{ab16}\x{ab20}-\x{ab26}\x{ab28}-\x{ab2e}\x{abc0}-\x{abe2}\x{ac00}-\x{d7a3}\x{d7b0}-\x{d7c6}\x{d7cb}-\x{d7fb}\x{f900}-\x{fa6d}\x{fa70}-\x{fad9}\x{fb00}-\x{fb06}\x{fb13}-\x{fb17}\x{fb1d}\x{fb1f}-\x{fb28}\x{fb2a}-\x{fb36}\x{fb38}-\x{fb3c}\x{fb3e}\x{fb40}\x{fb41}\x{fb43}\x{fb44}\x{fb46}-\x{fbb1}\x{fbd3}-\x{fd3d}\x{fd50}-\x{fd8f}\x{fd92}-\x{fdc7}\x{fdf0}-\x{fdfb}\x{fe70}-\x{fe74}\x{fe76}-\x{fefc}\x{ff21}-\x{ff3a}\x{ff41}-\x{ff5a}\x{ff66}-\x{ffbe}\x{ffc2}-\x{ffc7}\x{ffca}-\x{ffcf}\x{ffd2}-\x{ffd7}\x{ffda}-\x{ffdc}0-9\x{0300}-\x{036f}\x{0483}-\x{0487}\x{0591}-\x{05bd}\x{05bf}\x{05c1}\x{05c2}\x{05c4}\x{05c5}\x{05c7}\x{0610}-\x{061a}\x{064b}-\x{0669}\x{0670}\x{06d6}-\x{06dc}\x{06df}-\x{06e4}\x{06e7}\x{06e8}\x{06ea}-\x{06ed}\x{06f0}-\x{06f9}\x{0711}\x{0730}-\x{074a}\x{07a6}-\x{07b0}\x{07c0}-\x{07c9}\x{07eb}-\x{07f3}\x{0816}-\x{0819}\x{081b}-\x{0823}\x{0825}-\x{0827}\x{0829}-\x{082d}\x{0859}-\x{085b}\x{08e4}-\x{08fe}\x{0900}-\x{0903}\x{093a}-\x{093c}\x{093e}-\x{094f}\x{0951}-\x{0957}\x{0962}\x{0963}\x{0966}-\x{096f}\x{0981}-\x{0983}\x{09bc}\x{09be}-\x{09c4}\x{09c7}\x{09c8}\x{09cb}-\x{09cd}\x{09d7}\x{09e2}\x{09e3}\x{09e6}-\x{09ef}\x{0a01}-\x{0a03}\x{0a3c}\x{0a3e}-\x{0a42}\x{0a47}\x{0a48}\x{0a4b}-\x{0a4d}\x{0a51}\x{0a66}-\x{0a71}\x{0a75}\x{0a81}-\x{0a83}\x{0abc}\x{0abe}-\x{0ac5}\x{0ac7}-\x{0ac9}\x{0acb}-\x{0acd}\x{0ae2}\x{0ae3}\x{0ae6}-\x{0aef}\x{0b01}-\x{0b03}\x{0b3c}\x{0b3e}-\x{0b44}\x{0b47}\x{0b48}\x{0b4b}-\x{0b4d}\x{0b56}\x{0b57}\x{0b62}\x{0b63}\x{0b66}-\x{0b6f}\x{0b82}\x{0bbe}-\x{0bc2}\x{0bc6}-\x{0bc8}\x{0bca}-\x{0bcd}\x{0bd7}\x{0be6}-\x{0bef}\x{0c01}-\x{0c03}\x{0c3e}-\x{0c44}\x{0c46}-\x{0c48}\x{0c4a}-\x{0c4d}\x{0c55}\x{0c56}\x{0c62}\x{0c63}\x{0c66}-\x{0c6f}\x{0c82}\x{0c83}\x{0cbc}\x{0cbe}-\x{0cc4}\x{0cc6}-\x{0cc8}\x{0cca}-\x{0ccd}\x{0cd5}\x{0cd6}\x{0ce2}\x{0ce3}\x{0ce6}-\x{0cef}\x{0d02}\x{0d03}\x{0d3e}-\x{0d44}\x{0d46}-\x{0d48}\x{0d4a}-\x{0d4d}\x{0d57}\x{0d62}\x{0d63}\x{0d66}-\x{0d6f}\x{0d82}\x{0d83}\x{0dca}\x{0dcf}-\x{0dd4}\x{0dd6}\x{0dd8}-\x{0ddf}\x{0df2}\x{0df3}\x{0e31}\x{0e34}-\x{0e3a}\x{0e47}-\x{0e4e}\x{0e50}-\x{0e59}\x{0eb1}\x{0eb4}-\x{0eb9}\x{0ebb}\x{0ebc}\x{0ec8}-\x{0ecd}\x{0ed0}-\x{0ed9}\x{0f18}\x{0f19}\x{0f20}-\x{0f29}\x{0f35}\x{0f37}\x{0f39}\x{0f3e}\x{0f3f}\x{0f71}-\x{0f84}\x{0f86}\x{0f87}\x{0f8d}-\x{0f97}\x{0f99}-\x{0fbc}\x{0fc6}\x{102b}-\x{103e}\x{1040}-\x{1049}\x{1056}-\x{1059}\x{105e}-\x{1060}\x{1062}-\x{1064}\x{1067}-\x{106d}\x{1071}-\x{1074}\x{1082}-\x{108d}\x{108f}-\x{109d}\x{135d}-\x{135f}\x{1712}-\x{1714}\x{1732}-\x{1734}\x{1752}\x{1753}\x{1772}\x{1773}\x{17b4}-\x{17d3}\x{17dd}\x{17e0}-\x{17e9}\x{180b}-\x{180d}\x{1810}-\x{1819}\x{18a9}\x{1920}-\x{192b}\x{1930}-\x{193b}\x{1946}-\x{194f}\x{19b0}-\x{19c0}\x{19c8}\x{19c9}\x{19d0}-\x{19d9}\x{1a17}-\x{1a1b}\x{1a55}-\x{1a5e}\x{1a60}-\x{1a7c}\x{1a7f}-\x{1a89}\x{1a90}-\x{1a99}\x{1b00}-\x{1b04}\x{1b34}-\x{1b44}\x{1b50}-\x{1b59}\x{1b6b}-\x{1b73}\x{1b80}-\x{1b82}\x{1ba1}-\x{1bad}\x{1bb0}-\x{1bb9}\x{1be6}-\x{1bf3}\x{1c24}-\x{1c37}\x{1c40}-\x{1c49}\x{1c50}-\x{1c59}\x{1cd0}-\x{1cd2}\x{1cd4}-\x{1ce8}\x{1ced}\x{1cf2}-\x{1cf4}\x{1dc0}-\x{1de6}\x{1dfc}-\x{1dff}\x{200c}\x{200d}\x{203f}\x{2040}\x{2054}\x{20d0}-\x{20dc}\x{20e1}\x{20e5}-\x{20f0}\x{2cef}-\x{2cf1}\x{2d7f}\x{2de0}-\x{2dff}\x{302a}-\x{302f}\x{3099}\x{309a}\x{a620}-\x{a629}\x{a66f}\x{a674}-\x{a67d}\x{a69f}\x{a6f0}\x{a6f1}\x{a802}\x{a806}\x{a80b}\x{a823}-\x{a827}\x{a880}\x{a881}\x{a8b4}-\x{a8c4}\x{a8d0}-\x{a8d9}\x{a8e0}-\x{a8f1}\x{a900}-\x{a909}\x{a926}-\x{a92d}\x{a947}-\x{a953}\x{a980}-\x{a983}\x{a9b3}-\x{a9c0}\x{a9d0}-\x{a9d9}\x{aa29}-\x{aa36}\x{aa43}\x{aa4c}\x{aa4d}\x{aa50}-\x{aa59}\x{aa7b}\x{aab0}\x{aab2}-\x{aab4}\x{aab7}\x{aab8}\x{aabe}\x{aabf}\x{aac1}\x{aaeb}-\x{aaef}\x{aaf5}\x{aaf6}\x{abe3}-\x{abea}\x{abec}\x{abed}\x{abf0}-\x{abf9}\x{fb1e}\x{fe00}-\x{fe0f}\x{fe20}-\x{fe26}\x{fe33}\x{fe34}\x{fe4d}-\x{fe4f}\x{ff10}-\x{ff19}\x{ff3f}]*\b'; |
|
26 | + |
|
27 | + /** |
|
28 | + * Full list of JavaScript reserved words. |
|
29 | + * Will be loaded from /data/js/keywords_reserved.txt. |
|
30 | + * |
|
31 | + * @see https://mathiasbynens.be/notes/reserved-keywords |
|
32 | + * |
|
33 | + * @var string[] |
|
34 | + */ |
|
35 | + protected $keywordsReserved = array(); |
|
36 | + |
|
37 | + /** |
|
38 | + * List of JavaScript reserved words that accept a <variable, value, ...> |
|
39 | + * after them. Some end of lines are not the end of a statement, like with |
|
40 | + * these keywords. |
|
41 | + * |
|
42 | + * E.g.: we shouldn't insert a ; after this else |
|
43 | + * else |
|
44 | + * console.log('this is quite fine') |
|
45 | + * |
|
46 | + * Will be loaded from /data/js/keywords_before.txt |
|
47 | + * |
|
48 | + * @var string[] |
|
49 | + */ |
|
50 | + protected $keywordsBefore = array(); |
|
51 | + |
|
52 | + /** |
|
53 | + * List of JavaScript reserved words that accept a <variable, value, ...> |
|
54 | + * before them. Some end of lines are not the end of a statement, like when |
|
55 | + * continued by one of these keywords on the newline. |
|
56 | + * |
|
57 | + * E.g.: we shouldn't insert a ; before this instanceof |
|
58 | + * variable |
|
59 | + * instanceof String |
|
60 | + * |
|
61 | + * Will be loaded from /data/js/keywords_after.txt |
|
62 | + * |
|
63 | + * @var string[] |
|
64 | + */ |
|
65 | + protected $keywordsAfter = array(); |
|
66 | + |
|
67 | + /** |
|
68 | + * List of all JavaScript operators. |
|
69 | + * |
|
70 | + * Will be loaded from /data/js/operators.txt |
|
71 | + * |
|
72 | + * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators |
|
73 | + * |
|
74 | + * @var string[] |
|
75 | + */ |
|
76 | + protected $operators = array(); |
|
77 | + |
|
78 | + /** |
|
79 | + * List of JavaScript operators that accept a <variable, value, ...> after |
|
80 | + * them. Some end of lines are not the end of a statement, like with these |
|
81 | + * operators. |
|
82 | + * |
|
83 | + * Note: Most operators are fine, we've only removed !, ++ and --. |
|
84 | + * There can't be a newline separating ! and whatever it is negating. |
|
85 | + * ++ & -- have to be joined with the value they're in-/decrementing. |
|
86 | + * |
|
87 | + * Will be loaded from /data/js/operators_before.txt |
|
88 | + * |
|
89 | + * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators |
|
90 | + * |
|
91 | + * @var string[] |
|
92 | + */ |
|
93 | + protected $operatorsBefore = array(); |
|
94 | + |
|
95 | + /** |
|
96 | + * List of JavaScript operators that accept a <variable, value, ...> before |
|
97 | + * them. Some end of lines are not the end of a statement, like when |
|
98 | + * continued by one of these operators on the newline. |
|
99 | + * |
|
100 | + * Note: Most operators are fine, we've only removed ), ], ++ and --. |
|
101 | + * ++ & -- have to be joined with the value they're in-/decrementing. |
|
102 | + * ) & ] are "special" in that they have lots or usecases. () for example |
|
103 | + * is used for function calls, for grouping, in if () and for (), ... |
|
104 | + * |
|
105 | + * Will be loaded from /data/js/operators_after.txt |
|
106 | + * |
|
107 | + * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators |
|
108 | + * |
|
109 | + * @var string[] |
|
110 | + */ |
|
111 | + protected $operatorsAfter = array(); |
|
112 | + |
|
113 | + /** |
|
114 | + * {@inheritdoc} |
|
115 | + */ |
|
116 | + public function __construct() |
|
117 | + { |
|
118 | + call_user_func_array(array('parent', '__construct'), func_get_args()); |
|
119 | + |
|
120 | + $dataDir = __DIR__.'/../data/js/'; |
|
121 | + $options = FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES; |
|
122 | + $this->keywordsReserved = file($dataDir.'keywords_reserved.txt', $options); |
|
123 | + $this->keywordsBefore = file($dataDir.'keywords_before.txt', $options); |
|
124 | + $this->keywordsAfter = file($dataDir.'keywords_after.txt', $options); |
|
125 | + $this->operators = file($dataDir.'operators.txt', $options); |
|
126 | + $this->operatorsBefore = file($dataDir.'operators_before.txt', $options); |
|
127 | + $this->operatorsAfter = file($dataDir.'operators_after.txt', $options); |
|
128 | + } |
|
129 | + |
|
130 | + /** |
|
131 | + * Minify the data. |
|
132 | + * Perform JS optimizations. |
|
133 | + * |
|
134 | + * @param string[optional] $path Path to write the data to |
|
135 | + * |
|
136 | + * @return string The minified data |
|
137 | + */ |
|
138 | + public function execute($path = null) |
|
139 | + { |
|
140 | + $content = ''; |
|
141 | + |
|
142 | + // loop files |
|
143 | + foreach ($this->data as $source => $js) { |
|
144 | + /* |
|
145 | 145 | * Combine js: separating the scripts by a ; |
146 | 146 | * I'm also adding a newline: it will be eaten when whitespace is |
147 | 147 | * stripped, but we need to make sure we're not just appending |
@@ -149,10 +149,10 @@ discard block |
||
149 | 149 | * singe-line comment on the last line (in which case it would also |
150 | 150 | * be seen as part of that comment) |
151 | 151 | */ |
152 | - $content .= $js."\n;"; |
|
153 | - } |
|
152 | + $content .= $js."\n;"; |
|
153 | + } |
|
154 | 154 | |
155 | - /* |
|
155 | + /* |
|
156 | 156 | * Let's first take out strings, comments and regular expressions. |
157 | 157 | * All of these can contain JS code-like characters, and we should make |
158 | 158 | * sure any further magic ignores anything inside of these. |
@@ -163,164 +163,164 @@ discard block |
||
163 | 163 | * Comments will be removed altogether, strings and regular expressions |
164 | 164 | * will be replaced by placeholder text, which we'll restore later. |
165 | 165 | */ |
166 | - $this->extractStrings('\'"`'); |
|
167 | - $this->stripComments(); |
|
168 | - $this->extractRegex(); |
|
169 | - $content = $this->replace($content); |
|
166 | + $this->extractStrings('\'"`'); |
|
167 | + $this->stripComments(); |
|
168 | + $this->extractRegex(); |
|
169 | + $content = $this->replace($content); |
|
170 | 170 | |
171 | - $content = $this->propertyNotation($content); |
|
172 | - $content = $this->shortenBools($content); |
|
173 | - $content = $this->stripWhitespace($content); |
|
171 | + $content = $this->propertyNotation($content); |
|
172 | + $content = $this->shortenBools($content); |
|
173 | + $content = $this->stripWhitespace($content); |
|
174 | 174 | |
175 | - /* |
|
175 | + /* |
|
176 | 176 | * Earlier, we extracted strings & regular expressions and replaced them |
177 | 177 | * with placeholder text. This will restore them. |
178 | 178 | */ |
179 | - $content = $this->restoreExtractedData($content); |
|
180 | - |
|
181 | - return $content; |
|
182 | - } |
|
183 | - |
|
184 | - /** |
|
185 | - * Strip comments from source code. |
|
186 | - */ |
|
187 | - protected function stripComments() |
|
188 | - { |
|
189 | - // single-line comments |
|
190 | - $this->registerPattern('/\/\/.*$/m', ''); |
|
191 | - |
|
192 | - // multi-line comments |
|
193 | - $this->registerPattern('/\/\*.*?\*\//s', ''); |
|
194 | - } |
|
195 | - |
|
196 | - /** |
|
197 | - * JS can have /-delimited regular expressions, like: /ab+c/.match(string). |
|
198 | - * |
|
199 | - * The content inside the regex can contain characters that may be confused |
|
200 | - * for JS code: e.g. it could contain whitespace it needs to match & we |
|
201 | - * don't want to strip whitespace in there. |
|
202 | - * |
|
203 | - * The regex can be pretty simple: we don't have to care about comments, |
|
204 | - * (which also use slashes) because stripComments() will have stripped those |
|
205 | - * already. |
|
206 | - * |
|
207 | - * This method will replace all string content with simple REGEX# |
|
208 | - * placeholder text, so we've rid all regular expressions from characters |
|
209 | - * that may be misinterpreted. Original regex content will be saved in |
|
210 | - * $this->extracted and after doing all other minifying, we can restore the |
|
211 | - * original content via restoreRegex() |
|
212 | - */ |
|
213 | - protected function extractRegex() |
|
214 | - { |
|
215 | - // PHP only supports $this inside anonymous functions since 5.4 |
|
216 | - $minifier = $this; |
|
217 | - $callback = function ($match) use ($minifier) { |
|
218 | - $count = count($minifier->extracted); |
|
219 | - $placeholder = '/'.$count.'/'; |
|
220 | - $minifier->extracted[$placeholder] = $match[0]; |
|
221 | - |
|
222 | - return $placeholder; |
|
223 | - }; |
|
224 | - |
|
225 | - $pattern = '\/.+?(?<!\\\\)(\\\\\\\\)*\/[gimy]*(?![0-9a-zA-Z\/])'; |
|
226 | - |
|
227 | - // a regular expression can only be followed by a few operators or some |
|
228 | - // of the RegExp methods (a `\` followed by a variable or value is |
|
229 | - // likely part of a division, not a regex) |
|
230 | - $after = '[\.,;\)\}]'; |
|
231 | - $methods = '\.(exec|test|match|search|replace|split)\('; |
|
232 | - $this->registerPattern('/'.$pattern.'(?=\s*('.$after.'|'.$methods.'))/', $callback); |
|
233 | - |
|
234 | - // 1 more edge case: a regex can be followed by a lot more operators or |
|
235 | - // keywords if there's a newline (ASI) in between, where the operator |
|
236 | - // actually starts a new statement |
|
237 | - // (https://github.com/matthiasmullie/minify/issues/56) |
|
238 | - $operators = $this->getOperatorsForRegex($this->operatorsBefore, '/'); |
|
239 | - $operators += $this->getOperatorsForRegex($this->keywordsReserved, '/'); |
|
240 | - $this->registerPattern('/'.$pattern.'\s*\n(?=\s*('.implode('|', $operators).'))/', $callback); |
|
241 | - } |
|
242 | - |
|
243 | - /** |
|
244 | - * Strip whitespace. |
|
245 | - * |
|
246 | - * We won't strip *all* whitespace, but as much as possible. The thing that |
|
247 | - * we'll preserve are newlines we're unsure about. |
|
248 | - * JavaScript doesn't require statements to be terminated with a semicolon. |
|
249 | - * It will automatically fix missing semicolons with ASI (automatic semi- |
|
250 | - * colon insertion) at the end of line causing errors (without semicolon.) |
|
251 | - * |
|
252 | - * Because it's sometimes hard to tell if a newline is part of a statement |
|
253 | - * that should be terminated or not, we'll just leave some of them alone. |
|
254 | - * |
|
255 | - * @param string $content The content to strip the whitespace for |
|
256 | - * |
|
257 | - * @return string |
|
258 | - */ |
|
259 | - protected function stripWhitespace($content) |
|
260 | - { |
|
261 | - // uniform line endings, make them all line feed |
|
262 | - $content = str_replace(array("\r\n", "\r"), "\n", $content); |
|
263 | - |
|
264 | - // collapse all non-line feed whitespace into a single space |
|
265 | - $content = preg_replace('/[^\S\n]+/', ' ', $content); |
|
266 | - |
|
267 | - // strip leading & trailing whitespace |
|
268 | - $content = str_replace(array(" \n", "\n "), "\n", $content); |
|
269 | - |
|
270 | - // collapse consecutive line feeds into just 1 |
|
271 | - $content = preg_replace('/\n+/', "\n", $content); |
|
272 | - |
|
273 | - $operatorsBefore = $this->getOperatorsForRegex($this->operatorsBefore, '/'); |
|
274 | - $operatorsAfter = $this->getOperatorsForRegex($this->operatorsAfter, '/'); |
|
275 | - $operators = $this->getOperatorsForRegex($this->operators, '/'); |
|
276 | - $keywordsBefore = $this->getKeywordsForRegex($this->keywordsBefore, '/'); |
|
277 | - $keywordsAfter = $this->getKeywordsForRegex($this->keywordsAfter, '/'); |
|
278 | - |
|
279 | - // strip whitespace that ends in (or next line begin with) an operator |
|
280 | - // that allows statements to be broken up over multiple lines |
|
281 | - unset($operatorsBefore['+'], $operatorsBefore['-'], $operatorsAfter['+'], $operatorsAfter['-']); |
|
282 | - $content = preg_replace( |
|
283 | - array( |
|
284 | - '/('.implode('|', $operatorsBefore).')\s+/', |
|
285 | - '/\s+('.implode('|', $operatorsAfter).')/', |
|
286 | - ), '\\1', $content |
|
287 | - ); |
|
288 | - |
|
289 | - // make sure + and - can't be mistaken for, or joined into ++ and -- |
|
290 | - $content = preg_replace( |
|
291 | - array( |
|
292 | - '/(?<![\+\-])\s*([\+\-])(?![\+\-])/', |
|
293 | - '/(?<![\+\-])([\+\-])\s*(?![\+\-])/', |
|
294 | - ), '\\1', $content |
|
295 | - ); |
|
296 | - |
|
297 | - // collapse whitespace around reserved words into single space |
|
298 | - $content = preg_replace('/(^|[;\}\s])\K('.implode('|', $keywordsBefore).')\s+/', '\\2 ', $content); |
|
299 | - $content = preg_replace('/\s+('.implode('|', $keywordsAfter).')(?=([;\{\s]|$))/', ' \\1', $content); |
|
300 | - |
|
301 | - /* |
|
179 | + $content = $this->restoreExtractedData($content); |
|
180 | + |
|
181 | + return $content; |
|
182 | + } |
|
183 | + |
|
184 | + /** |
|
185 | + * Strip comments from source code. |
|
186 | + */ |
|
187 | + protected function stripComments() |
|
188 | + { |
|
189 | + // single-line comments |
|
190 | + $this->registerPattern('/\/\/.*$/m', ''); |
|
191 | + |
|
192 | + // multi-line comments |
|
193 | + $this->registerPattern('/\/\*.*?\*\//s', ''); |
|
194 | + } |
|
195 | + |
|
196 | + /** |
|
197 | + * JS can have /-delimited regular expressions, like: /ab+c/.match(string). |
|
198 | + * |
|
199 | + * The content inside the regex can contain characters that may be confused |
|
200 | + * for JS code: e.g. it could contain whitespace it needs to match & we |
|
201 | + * don't want to strip whitespace in there. |
|
202 | + * |
|
203 | + * The regex can be pretty simple: we don't have to care about comments, |
|
204 | + * (which also use slashes) because stripComments() will have stripped those |
|
205 | + * already. |
|
206 | + * |
|
207 | + * This method will replace all string content with simple REGEX# |
|
208 | + * placeholder text, so we've rid all regular expressions from characters |
|
209 | + * that may be misinterpreted. Original regex content will be saved in |
|
210 | + * $this->extracted and after doing all other minifying, we can restore the |
|
211 | + * original content via restoreRegex() |
|
212 | + */ |
|
213 | + protected function extractRegex() |
|
214 | + { |
|
215 | + // PHP only supports $this inside anonymous functions since 5.4 |
|
216 | + $minifier = $this; |
|
217 | + $callback = function ($match) use ($minifier) { |
|
218 | + $count = count($minifier->extracted); |
|
219 | + $placeholder = '/'.$count.'/'; |
|
220 | + $minifier->extracted[$placeholder] = $match[0]; |
|
221 | + |
|
222 | + return $placeholder; |
|
223 | + }; |
|
224 | + |
|
225 | + $pattern = '\/.+?(?<!\\\\)(\\\\\\\\)*\/[gimy]*(?![0-9a-zA-Z\/])'; |
|
226 | + |
|
227 | + // a regular expression can only be followed by a few operators or some |
|
228 | + // of the RegExp methods (a `\` followed by a variable or value is |
|
229 | + // likely part of a division, not a regex) |
|
230 | + $after = '[\.,;\)\}]'; |
|
231 | + $methods = '\.(exec|test|match|search|replace|split)\('; |
|
232 | + $this->registerPattern('/'.$pattern.'(?=\s*('.$after.'|'.$methods.'))/', $callback); |
|
233 | + |
|
234 | + // 1 more edge case: a regex can be followed by a lot more operators or |
|
235 | + // keywords if there's a newline (ASI) in between, where the operator |
|
236 | + // actually starts a new statement |
|
237 | + // (https://github.com/matthiasmullie/minify/issues/56) |
|
238 | + $operators = $this->getOperatorsForRegex($this->operatorsBefore, '/'); |
|
239 | + $operators += $this->getOperatorsForRegex($this->keywordsReserved, '/'); |
|
240 | + $this->registerPattern('/'.$pattern.'\s*\n(?=\s*('.implode('|', $operators).'))/', $callback); |
|
241 | + } |
|
242 | + |
|
243 | + /** |
|
244 | + * Strip whitespace. |
|
245 | + * |
|
246 | + * We won't strip *all* whitespace, but as much as possible. The thing that |
|
247 | + * we'll preserve are newlines we're unsure about. |
|
248 | + * JavaScript doesn't require statements to be terminated with a semicolon. |
|
249 | + * It will automatically fix missing semicolons with ASI (automatic semi- |
|
250 | + * colon insertion) at the end of line causing errors (without semicolon.) |
|
251 | + * |
|
252 | + * Because it's sometimes hard to tell if a newline is part of a statement |
|
253 | + * that should be terminated or not, we'll just leave some of them alone. |
|
254 | + * |
|
255 | + * @param string $content The content to strip the whitespace for |
|
256 | + * |
|
257 | + * @return string |
|
258 | + */ |
|
259 | + protected function stripWhitespace($content) |
|
260 | + { |
|
261 | + // uniform line endings, make them all line feed |
|
262 | + $content = str_replace(array("\r\n", "\r"), "\n", $content); |
|
263 | + |
|
264 | + // collapse all non-line feed whitespace into a single space |
|
265 | + $content = preg_replace('/[^\S\n]+/', ' ', $content); |
|
266 | + |
|
267 | + // strip leading & trailing whitespace |
|
268 | + $content = str_replace(array(" \n", "\n "), "\n", $content); |
|
269 | + |
|
270 | + // collapse consecutive line feeds into just 1 |
|
271 | + $content = preg_replace('/\n+/', "\n", $content); |
|
272 | + |
|
273 | + $operatorsBefore = $this->getOperatorsForRegex($this->operatorsBefore, '/'); |
|
274 | + $operatorsAfter = $this->getOperatorsForRegex($this->operatorsAfter, '/'); |
|
275 | + $operators = $this->getOperatorsForRegex($this->operators, '/'); |
|
276 | + $keywordsBefore = $this->getKeywordsForRegex($this->keywordsBefore, '/'); |
|
277 | + $keywordsAfter = $this->getKeywordsForRegex($this->keywordsAfter, '/'); |
|
278 | + |
|
279 | + // strip whitespace that ends in (or next line begin with) an operator |
|
280 | + // that allows statements to be broken up over multiple lines |
|
281 | + unset($operatorsBefore['+'], $operatorsBefore['-'], $operatorsAfter['+'], $operatorsAfter['-']); |
|
282 | + $content = preg_replace( |
|
283 | + array( |
|
284 | + '/('.implode('|', $operatorsBefore).')\s+/', |
|
285 | + '/\s+('.implode('|', $operatorsAfter).')/', |
|
286 | + ), '\\1', $content |
|
287 | + ); |
|
288 | + |
|
289 | + // make sure + and - can't be mistaken for, or joined into ++ and -- |
|
290 | + $content = preg_replace( |
|
291 | + array( |
|
292 | + '/(?<![\+\-])\s*([\+\-])(?![\+\-])/', |
|
293 | + '/(?<![\+\-])([\+\-])\s*(?![\+\-])/', |
|
294 | + ), '\\1', $content |
|
295 | + ); |
|
296 | + |
|
297 | + // collapse whitespace around reserved words into single space |
|
298 | + $content = preg_replace('/(^|[;\}\s])\K('.implode('|', $keywordsBefore).')\s+/', '\\2 ', $content); |
|
299 | + $content = preg_replace('/\s+('.implode('|', $keywordsAfter).')(?=([;\{\s]|$))/', ' \\1', $content); |
|
300 | + |
|
301 | + /* |
|
302 | 302 | * We didn't strip whitespace after a couple of operators because they |
303 | 303 | * could be used in different contexts and we can't be sure it's ok to |
304 | 304 | * strip the newlines. However, we can safely strip any non-line feed |
305 | 305 | * whitespace that follows them. |
306 | 306 | */ |
307 | - $operatorsDiffBefore = array_diff($operators, $operatorsBefore); |
|
308 | - $operatorsDiffAfter = array_diff($operators, $operatorsAfter); |
|
309 | - $content = preg_replace('/('.implode('|', $operatorsDiffBefore).')[^\S\n]+/', '\\1', $content); |
|
310 | - $content = preg_replace('/[^\S\n]+('.implode('|', $operatorsDiffAfter).')/', '\\1', $content); |
|
307 | + $operatorsDiffBefore = array_diff($operators, $operatorsBefore); |
|
308 | + $operatorsDiffAfter = array_diff($operators, $operatorsAfter); |
|
309 | + $content = preg_replace('/('.implode('|', $operatorsDiffBefore).')[^\S\n]+/', '\\1', $content); |
|
310 | + $content = preg_replace('/[^\S\n]+('.implode('|', $operatorsDiffAfter).')/', '\\1', $content); |
|
311 | 311 | |
312 | - /* |
|
312 | + /* |
|
313 | 313 | * Get rid of double semicolons, except where they can be used like: |
314 | 314 | * "for(v=1,_=b;;)", "for(v=1;;v++)" or "for(;;ja||(ja=true))". |
315 | 315 | * I'll safeguard these double semicolons inside for-loops by |
316 | 316 | * temporarily replacing them with an invalid condition: they won't have |
317 | 317 | * a double semicolon and will be easy to spot to restore afterwards. |
318 | 318 | */ |
319 | - $content = preg_replace('/\bfor\(([^;]*);;([^;]*)\)/', 'for(\\1;-;\\2)', $content); |
|
320 | - $content = preg_replace('/;+/', ';', $content); |
|
321 | - $content = preg_replace('/\bfor\(([^;]*);-;([^;]*)\)/', 'for(\\1;;\\2)', $content); |
|
319 | + $content = preg_replace('/\bfor\(([^;]*);;([^;]*)\)/', 'for(\\1;-;\\2)', $content); |
|
320 | + $content = preg_replace('/;+/', ';', $content); |
|
321 | + $content = preg_replace('/\bfor\(([^;]*);-;([^;]*)\)/', 'for(\\1;;\\2)', $content); |
|
322 | 322 | |
323 | - /* |
|
323 | + /* |
|
324 | 324 | * Next, we'll be removing all semicolons where ASI kicks in. |
325 | 325 | * for-loops however, can have an empty body (ending in only a |
326 | 326 | * semicolon), like: `for(i=1;i<3;i++);` |
@@ -330,9 +330,9 @@ discard block |
||
330 | 330 | * I'm going to double that semicolon (if any) so after the next line, |
331 | 331 | * which strips semicolons here & there, we're still left with this one. |
332 | 332 | */ |
333 | - $content = preg_replace('/(for\([^;]*;[^;]*;[^;\{]*\));(\}|$)/s', '\\1;;\\2', $content); |
|
333 | + $content = preg_replace('/(for\([^;]*;[^;]*;[^;\{]*\));(\}|$)/s', '\\1;;\\2', $content); |
|
334 | 334 | |
335 | - /* |
|
335 | + /* |
|
336 | 336 | * We also can't strip empty else-statements. Even though they're |
337 | 337 | * useless and probably shouldn't be in the code in the first place, we |
338 | 338 | * shouldn't be stripping the `;` that follows it as it breaks the code. |
@@ -340,114 +340,114 @@ discard block |
||
340 | 340 | * |
341 | 341 | * @see https://github.com/matthiasmullie/minify/issues/91 |
342 | 342 | */ |
343 | - $content = preg_replace('/else;/s', '', $content); |
|
343 | + $content = preg_replace('/else;/s', '', $content); |
|
344 | 344 | |
345 | - /* |
|
345 | + /* |
|
346 | 346 | * We also don't really want to terminate statements followed by closing |
347 | 347 | * curly braces (which we've ignored completely up until now) or end-of- |
348 | 348 | * script: ASI will kick in here & we're all about minifying. |
349 | 349 | * Semicolons at beginning of the file don't make any sense either. |
350 | 350 | */ |
351 | - $content = preg_replace('/;(\}|$)/s', '\\1', $content); |
|
352 | - $content = ltrim($content, ';'); |
|
353 | - |
|
354 | - // get rid of remaining whitespace af beginning/end |
|
355 | - return trim($content); |
|
356 | - } |
|
357 | - |
|
358 | - /** |
|
359 | - * We'll strip whitespace around certain operators with regular expressions. |
|
360 | - * This will prepare the given array by escaping all characters. |
|
361 | - * |
|
362 | - * @param string[] $operators |
|
363 | - * @param string $delimiter |
|
364 | - * |
|
365 | - * @return string[] |
|
366 | - */ |
|
367 | - protected function getOperatorsForRegex(array $operators, $delimiter = '/') |
|
368 | - { |
|
369 | - // escape operators for use in regex |
|
370 | - $delimiter = array_fill(0, count($operators), $delimiter); |
|
371 | - $escaped = array_map('preg_quote', $operators, $delimiter); |
|
372 | - |
|
373 | - $operators = array_combine($operators, $escaped); |
|
374 | - |
|
375 | - // ignore + & - for now, they'll get special treatment |
|
376 | - unset($operators['+'], $operators['-']); |
|
377 | - |
|
378 | - // dot can not just immediately follow a number; it can be confused for |
|
379 | - // decimal point, or calling a method on it, e.g. 42 .toString() |
|
380 | - $operators['.'] = '(?<![0-9]\s)\.'; |
|
381 | - |
|
382 | - // don't confuse = with other assignment shortcuts (e.g. +=) |
|
383 | - $chars = preg_quote('+-*\=<>%&|'); |
|
384 | - $operators['='] = '(?<!['.$chars.'])\='; |
|
385 | - |
|
386 | - return $operators; |
|
387 | - } |
|
388 | - |
|
389 | - /** |
|
390 | - * We'll strip whitespace around certain keywords with regular expressions. |
|
391 | - * This will prepare the given array by escaping all characters. |
|
392 | - * |
|
393 | - * @param string[] $keywords |
|
394 | - * @param string $delimiter |
|
395 | - * |
|
396 | - * @return string[] |
|
397 | - */ |
|
398 | - protected function getKeywordsForRegex(array $keywords, $delimiter = '/') |
|
399 | - { |
|
400 | - // escape keywords for use in regex |
|
401 | - $delimiter = array_fill(0, count($keywords), $delimiter); |
|
402 | - $escaped = array_map('preg_quote', $keywords, $delimiter); |
|
403 | - |
|
404 | - // add word boundaries |
|
405 | - array_walk($keywords, function ($value) { |
|
406 | - return '\b'.$value.'\b'; |
|
407 | - }); |
|
408 | - |
|
409 | - $keywords = array_combine($keywords, $escaped); |
|
410 | - |
|
411 | - return $keywords; |
|
412 | - } |
|
413 | - |
|
414 | - /** |
|
415 | - * Replaces all occurrences of array['key'] by array.key. |
|
416 | - * |
|
417 | - * @param string $content |
|
418 | - * |
|
419 | - * @return string |
|
420 | - */ |
|
421 | - protected function propertyNotation($content) |
|
422 | - { |
|
423 | - // PHP only supports $this inside anonymous functions since 5.4 |
|
424 | - $minifier = $this; |
|
425 | - $keywords = $this->keywordsReserved; |
|
426 | - $callback = function ($match) use ($minifier, $keywords) { |
|
427 | - $property = trim($minifier->extracted[$match[1]], '\'"'); |
|
428 | - |
|
429 | - /* |
|
351 | + $content = preg_replace('/;(\}|$)/s', '\\1', $content); |
|
352 | + $content = ltrim($content, ';'); |
|
353 | + |
|
354 | + // get rid of remaining whitespace af beginning/end |
|
355 | + return trim($content); |
|
356 | + } |
|
357 | + |
|
358 | + /** |
|
359 | + * We'll strip whitespace around certain operators with regular expressions. |
|
360 | + * This will prepare the given array by escaping all characters. |
|
361 | + * |
|
362 | + * @param string[] $operators |
|
363 | + * @param string $delimiter |
|
364 | + * |
|
365 | + * @return string[] |
|
366 | + */ |
|
367 | + protected function getOperatorsForRegex(array $operators, $delimiter = '/') |
|
368 | + { |
|
369 | + // escape operators for use in regex |
|
370 | + $delimiter = array_fill(0, count($operators), $delimiter); |
|
371 | + $escaped = array_map('preg_quote', $operators, $delimiter); |
|
372 | + |
|
373 | + $operators = array_combine($operators, $escaped); |
|
374 | + |
|
375 | + // ignore + & - for now, they'll get special treatment |
|
376 | + unset($operators['+'], $operators['-']); |
|
377 | + |
|
378 | + // dot can not just immediately follow a number; it can be confused for |
|
379 | + // decimal point, or calling a method on it, e.g. 42 .toString() |
|
380 | + $operators['.'] = '(?<![0-9]\s)\.'; |
|
381 | + |
|
382 | + // don't confuse = with other assignment shortcuts (e.g. +=) |
|
383 | + $chars = preg_quote('+-*\=<>%&|'); |
|
384 | + $operators['='] = '(?<!['.$chars.'])\='; |
|
385 | + |
|
386 | + return $operators; |
|
387 | + } |
|
388 | + |
|
389 | + /** |
|
390 | + * We'll strip whitespace around certain keywords with regular expressions. |
|
391 | + * This will prepare the given array by escaping all characters. |
|
392 | + * |
|
393 | + * @param string[] $keywords |
|
394 | + * @param string $delimiter |
|
395 | + * |
|
396 | + * @return string[] |
|
397 | + */ |
|
398 | + protected function getKeywordsForRegex(array $keywords, $delimiter = '/') |
|
399 | + { |
|
400 | + // escape keywords for use in regex |
|
401 | + $delimiter = array_fill(0, count($keywords), $delimiter); |
|
402 | + $escaped = array_map('preg_quote', $keywords, $delimiter); |
|
403 | + |
|
404 | + // add word boundaries |
|
405 | + array_walk($keywords, function ($value) { |
|
406 | + return '\b'.$value.'\b'; |
|
407 | + }); |
|
408 | + |
|
409 | + $keywords = array_combine($keywords, $escaped); |
|
410 | + |
|
411 | + return $keywords; |
|
412 | + } |
|
413 | + |
|
414 | + /** |
|
415 | + * Replaces all occurrences of array['key'] by array.key. |
|
416 | + * |
|
417 | + * @param string $content |
|
418 | + * |
|
419 | + * @return string |
|
420 | + */ |
|
421 | + protected function propertyNotation($content) |
|
422 | + { |
|
423 | + // PHP only supports $this inside anonymous functions since 5.4 |
|
424 | + $minifier = $this; |
|
425 | + $keywords = $this->keywordsReserved; |
|
426 | + $callback = function ($match) use ($minifier, $keywords) { |
|
427 | + $property = trim($minifier->extracted[$match[1]], '\'"'); |
|
428 | + |
|
429 | + /* |
|
430 | 430 | * Check if the property is a reserved keyword. In this context (as |
431 | 431 | * property of an object literal/array) it shouldn't matter, but IE8 |
432 | 432 | * freaks out with "Expected identifier". |
433 | 433 | */ |
434 | - if (in_array($property, $keywords)) { |
|
435 | - return $match[0]; |
|
436 | - } |
|
434 | + if (in_array($property, $keywords)) { |
|
435 | + return $match[0]; |
|
436 | + } |
|
437 | 437 | |
438 | - /* |
|
438 | + /* |
|
439 | 439 | * See if the property is in a variable-like format (e.g. |
440 | 440 | * array['key-here'] can't be replaced by array.key-here since '-' |
441 | 441 | * is not a valid character there. |
442 | 442 | */ |
443 | - if (!preg_match('/^'.$minifier::REGEX_VARIABLE.'$/u', $property)) { |
|
444 | - return $match[0]; |
|
445 | - } |
|
443 | + if (!preg_match('/^'.$minifier::REGEX_VARIABLE.'$/u', $property)) { |
|
444 | + return $match[0]; |
|
445 | + } |
|
446 | 446 | |
447 | - return '.'.$property; |
|
448 | - }; |
|
447 | + return '.'.$property; |
|
448 | + }; |
|
449 | 449 | |
450 | - /* |
|
450 | + /* |
|
451 | 451 | * Figure out if previous character is a variable name (of the array |
452 | 452 | * we want to use property notation on) - this is to make sure |
453 | 453 | * standalone ['value'] arrays aren't confused for keys-of-an-array. |
@@ -455,61 +455,61 @@ discard block |
||
455 | 455 | * regex implementation doesn't allow unfixed-length look-behind |
456 | 456 | * assertions. |
457 | 457 | */ |
458 | - preg_match('/(\[[^\]]+\])[^\]]*$/', static::REGEX_VARIABLE, $previousChar); |
|
459 | - $previousChar = $previousChar[1]; |
|
458 | + preg_match('/(\[[^\]]+\])[^\]]*$/', static::REGEX_VARIABLE, $previousChar); |
|
459 | + $previousChar = $previousChar[1]; |
|
460 | 460 | |
461 | - /* |
|
461 | + /* |
|
462 | 462 | * Make sure word preceding the ['value'] is not a keyword, e.g. |
463 | 463 | * return['x']. Because -again- PHP's regex implementation doesn't allow |
464 | 464 | * unfixed-length look-behind assertions, I'm just going to do a lot of |
465 | 465 | * separate look-behind assertions, one for each keyword. |
466 | 466 | */ |
467 | - $keywords = $this->getKeywordsForRegex($keywords); |
|
468 | - $keywords = '(?<!'.implode(')(?<!', $keywords).')'; |
|
469 | - |
|
470 | - return preg_replace_callback('/(?<='.$previousChar.'|\])'.$keywords.'\[\s*(([\'"])[0-9]+\\2)\s*\]/u', $callback, $content); |
|
471 | - } |
|
472 | - |
|
473 | - /** |
|
474 | - * Replaces true & false by !0 and !1. |
|
475 | - * |
|
476 | - * @param string $content |
|
477 | - * |
|
478 | - * @return string |
|
479 | - */ |
|
480 | - protected function shortenBools($content) |
|
481 | - { |
|
482 | - $content = preg_replace('/\btrue\b(?!:)/', '!0', $content); |
|
483 | - $content = preg_replace('/\bfalse\b(?!:)/', '!1', $content); |
|
484 | - |
|
485 | - // for(;;) is exactly the same as while(true) |
|
486 | - $content = preg_replace('/\bwhile\(!0\){/', 'for(;;){', $content); |
|
487 | - |
|
488 | - // now make sure we didn't turn any do ... while(true) into do ... for(;;) |
|
489 | - preg_match_all('/\bdo\b/', $content, $dos, PREG_OFFSET_CAPTURE | PREG_SET_ORDER); |
|
490 | - |
|
491 | - // go backward to make sure positional offsets aren't altered when $content changes |
|
492 | - $dos = array_reverse($dos); |
|
493 | - foreach ($dos as $do) { |
|
494 | - $offsetDo = $do[0][1]; |
|
495 | - |
|
496 | - // find all `while` (now `for`) following `do`: one of those must be |
|
497 | - // associated with the `do` and be turned back into `while` |
|
498 | - preg_match_all('/\bfor\(;;\)/', $content, $whiles, PREG_OFFSET_CAPTURE | PREG_SET_ORDER, $offsetDo); |
|
499 | - foreach ($whiles as $while) { |
|
500 | - $offsetWhile = $while[0][1]; |
|
501 | - |
|
502 | - $open = substr_count($content, '{', $offsetDo, $offsetWhile - $offsetDo); |
|
503 | - $close = substr_count($content, '}', $offsetDo, $offsetWhile - $offsetDo); |
|
504 | - if ($open === $close) { |
|
505 | - // only restore `while` if amount of `{` and `}` are the same; |
|
506 | - // otherwise, that `for` isn't associated with this `do` |
|
507 | - $content = substr_replace($content, 'while(!0)', $offsetWhile, strlen('for(;;)')); |
|
508 | - break; |
|
509 | - } |
|
510 | - } |
|
511 | - } |
|
512 | - |
|
513 | - return $content; |
|
514 | - } |
|
467 | + $keywords = $this->getKeywordsForRegex($keywords); |
|
468 | + $keywords = '(?<!'.implode(')(?<!', $keywords).')'; |
|
469 | + |
|
470 | + return preg_replace_callback('/(?<='.$previousChar.'|\])'.$keywords.'\[\s*(([\'"])[0-9]+\\2)\s*\]/u', $callback, $content); |
|
471 | + } |
|
472 | + |
|
473 | + /** |
|
474 | + * Replaces true & false by !0 and !1. |
|
475 | + * |
|
476 | + * @param string $content |
|
477 | + * |
|
478 | + * @return string |
|
479 | + */ |
|
480 | + protected function shortenBools($content) |
|
481 | + { |
|
482 | + $content = preg_replace('/\btrue\b(?!:)/', '!0', $content); |
|
483 | + $content = preg_replace('/\bfalse\b(?!:)/', '!1', $content); |
|
484 | + |
|
485 | + // for(;;) is exactly the same as while(true) |
|
486 | + $content = preg_replace('/\bwhile\(!0\){/', 'for(;;){', $content); |
|
487 | + |
|
488 | + // now make sure we didn't turn any do ... while(true) into do ... for(;;) |
|
489 | + preg_match_all('/\bdo\b/', $content, $dos, PREG_OFFSET_CAPTURE | PREG_SET_ORDER); |
|
490 | + |
|
491 | + // go backward to make sure positional offsets aren't altered when $content changes |
|
492 | + $dos = array_reverse($dos); |
|
493 | + foreach ($dos as $do) { |
|
494 | + $offsetDo = $do[0][1]; |
|
495 | + |
|
496 | + // find all `while` (now `for`) following `do`: one of those must be |
|
497 | + // associated with the `do` and be turned back into `while` |
|
498 | + preg_match_all('/\bfor\(;;\)/', $content, $whiles, PREG_OFFSET_CAPTURE | PREG_SET_ORDER, $offsetDo); |
|
499 | + foreach ($whiles as $while) { |
|
500 | + $offsetWhile = $while[0][1]; |
|
501 | + |
|
502 | + $open = substr_count($content, '{', $offsetDo, $offsetWhile - $offsetDo); |
|
503 | + $close = substr_count($content, '}', $offsetDo, $offsetWhile - $offsetDo); |
|
504 | + if ($open === $close) { |
|
505 | + // only restore `while` if amount of `{` and `}` are the same; |
|
506 | + // otherwise, that `for` isn't associated with this `do` |
|
507 | + $content = substr_replace($content, 'while(!0)', $offsetWhile, strlen('for(;;)')); |
|
508 | + break; |
|
509 | + } |
|
510 | + } |
|
511 | + } |
|
512 | + |
|
513 | + return $content; |
|
514 | + } |
|
515 | 515 | } |