@@ -11,8 +11,9 @@ |
||
11 | 11 | * @version 2.1 Beta 4 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('No direct access...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * Converts the given UTF-8 string into lowercase. |
@@ -11,8 +11,9 @@ discard block |
||
11 | 11 | * @version 2.1 Beta 4 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('No direct access...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * View a summary. |
@@ -23,8 +24,9 @@ discard block |
||
23 | 24 | global $context, $memberContext, $txt, $modSettings, $user_profile, $sourcedir, $scripturl, $smcFunc; |
24 | 25 | |
25 | 26 | // Attempt to load the member's profile data. |
26 | - if (!loadMemberContext($memID) || !isset($memberContext[$memID])) |
|
27 | - fatal_lang_error('not_a_user', false, 404); |
|
27 | + if (!loadMemberContext($memID) || !isset($memberContext[$memID])) { |
|
28 | + fatal_lang_error('not_a_user', false, 404); |
|
29 | + } |
|
28 | 30 | |
29 | 31 | // Set up the stuff and load the user. |
30 | 32 | $context += array( |
@@ -49,19 +51,21 @@ discard block |
||
49 | 51 | |
50 | 52 | // See if they have broken any warning levels... |
51 | 53 | list ($modSettings['warning_enable'], $modSettings['user_limit']) = explode(',', $modSettings['warning_settings']); |
52 | - if (!empty($modSettings['warning_mute']) && $modSettings['warning_mute'] <= $context['member']['warning']) |
|
53 | - $context['warning_status'] = $txt['profile_warning_is_muted']; |
|
54 | - elseif (!empty($modSettings['warning_moderate']) && $modSettings['warning_moderate'] <= $context['member']['warning']) |
|
55 | - $context['warning_status'] = $txt['profile_warning_is_moderation']; |
|
56 | - elseif (!empty($modSettings['warning_watch']) && $modSettings['warning_watch'] <= $context['member']['warning']) |
|
57 | - $context['warning_status'] = $txt['profile_warning_is_watch']; |
|
54 | + if (!empty($modSettings['warning_mute']) && $modSettings['warning_mute'] <= $context['member']['warning']) { |
|
55 | + $context['warning_status'] = $txt['profile_warning_is_muted']; |
|
56 | + } elseif (!empty($modSettings['warning_moderate']) && $modSettings['warning_moderate'] <= $context['member']['warning']) { |
|
57 | + $context['warning_status'] = $txt['profile_warning_is_moderation']; |
|
58 | + } elseif (!empty($modSettings['warning_watch']) && $modSettings['warning_watch'] <= $context['member']['warning']) { |
|
59 | + $context['warning_status'] = $txt['profile_warning_is_watch']; |
|
60 | + } |
|
58 | 61 | |
59 | 62 | // They haven't even been registered for a full day!? |
60 | 63 | $days_registered = (int) ((time() - $user_profile[$memID]['date_registered']) / (3600 * 24)); |
61 | - if (empty($user_profile[$memID]['date_registered']) || $days_registered < 1) |
|
62 | - $context['member']['posts_per_day'] = $txt['not_applicable']; |
|
63 | - else |
|
64 | - $context['member']['posts_per_day'] = comma_format($context['member']['real_posts'] / $days_registered, 3); |
|
64 | + if (empty($user_profile[$memID]['date_registered']) || $days_registered < 1) { |
|
65 | + $context['member']['posts_per_day'] = $txt['not_applicable']; |
|
66 | + } else { |
|
67 | + $context['member']['posts_per_day'] = comma_format($context['member']['real_posts'] / $days_registered, 3); |
|
68 | + } |
|
65 | 69 | |
66 | 70 | // Set the age... |
67 | 71 | if (empty($context['member']['birth_date']) || substr($context['member']['birth_date'], 0, 4) < 1002) |
@@ -70,8 +74,7 @@ discard block |
||
70 | 74 | 'age' => $txt['not_applicable'], |
71 | 75 | 'today_is_birthday' => false |
72 | 76 | ); |
73 | - } |
|
74 | - else |
|
77 | + } else |
|
75 | 78 | { |
76 | 79 | list ($birth_year, $birth_month, $birth_day) = sscanf($context['member']['birth_date'], '%d-%d-%d'); |
77 | 80 | $datearray = getdate(forum_time()); |
@@ -84,15 +87,16 @@ discard block |
||
84 | 87 | if (allowedTo('moderate_forum')) |
85 | 88 | { |
86 | 89 | // Make sure it's a valid ip address; otherwise, don't bother... |
87 | - if (preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/', $memberContext[$memID]['ip']) == 1 && empty($modSettings['disableHostnameLookup'])) |
|
88 | - $context['member']['hostname'] = host_from_ip($memberContext[$memID]['ip']); |
|
89 | - else |
|
90 | - $context['member']['hostname'] = ''; |
|
90 | + if (preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/', $memberContext[$memID]['ip']) == 1 && empty($modSettings['disableHostnameLookup'])) { |
|
91 | + $context['member']['hostname'] = host_from_ip($memberContext[$memID]['ip']); |
|
92 | + } else { |
|
93 | + $context['member']['hostname'] = ''; |
|
94 | + } |
|
91 | 95 | |
92 | 96 | $context['can_see_ip'] = true; |
97 | + } else { |
|
98 | + $context['can_see_ip'] = false; |
|
93 | 99 | } |
94 | - else |
|
95 | - $context['can_see_ip'] = false; |
|
96 | 100 | |
97 | 101 | // Are they hidden? |
98 | 102 | $context['member']['is_hidden'] = empty($user_profile[$memID]['show_online']); |
@@ -103,8 +107,9 @@ discard block |
||
103 | 107 | include_once($sourcedir . '/Who.php'); |
104 | 108 | $action = determineActions($user_profile[$memID]['url']); |
105 | 109 | |
106 | - if ($action !== false) |
|
107 | - $context['member']['action'] = $action; |
|
110 | + if ($action !== false) { |
|
111 | + $context['member']['action'] = $action; |
|
112 | + } |
|
108 | 113 | } |
109 | 114 | |
110 | 115 | // If the user is awaiting activation, and the viewer has permission - setup some activation context messages. |
@@ -167,13 +172,15 @@ discard block |
||
167 | 172 | { |
168 | 173 | // Work out what restrictions we actually have. |
169 | 174 | $ban_restrictions = array(); |
170 | - foreach (array('access', 'login', 'post') as $type) |
|
171 | - if ($row['cannot_' . $type]) |
|
175 | + foreach (array('access', 'login', 'post') as $type) { |
|
176 | + if ($row['cannot_' . $type]) |
|
172 | 177 | $ban_restrictions[] = $txt['ban_type_' . $type]; |
178 | + } |
|
173 | 179 | |
174 | 180 | // No actual ban in place? |
175 | - if (empty($ban_restrictions)) |
|
176 | - continue; |
|
181 | + if (empty($ban_restrictions)) { |
|
182 | + continue; |
|
183 | + } |
|
177 | 184 | |
178 | 185 | // Prepare the link for context. |
179 | 186 | $ban_explanation = sprintf($txt['user_cannot_due_to'], implode(', ', $ban_restrictions), '<a href="' . $scripturl . '?action=admin;area=ban;sa=edit;bg=' . $row['id_ban_group'] . '">' . $row['name'] . '</a>'); |
@@ -195,9 +202,10 @@ discard block |
||
195 | 202 | $context['print_custom_fields'] = array(); |
196 | 203 | |
197 | 204 | // Any custom profile fields? |
198 | - if (!empty($context['custom_fields'])) |
|
199 | - foreach ($context['custom_fields'] as $custom) |
|
205 | + if (!empty($context['custom_fields'])) { |
|
206 | + foreach ($context['custom_fields'] as $custom) |
|
200 | 207 | $context['print_custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom; |
208 | + } |
|
201 | 209 | |
202 | 210 | } |
203 | 211 | |
@@ -241,14 +249,16 @@ discard block |
||
241 | 249 | $row['extra'] = !empty($row['extra']) ? $smcFunc['json_decode']($row['extra'], true) : array(); |
242 | 250 | $alerts[$id_alert] = $row; |
243 | 251 | |
244 | - if (!empty($row['sender_id'])) |
|
245 | - $senders[] = $row['sender_id']; |
|
252 | + if (!empty($row['sender_id'])) { |
|
253 | + $senders[] = $row['sender_id']; |
|
254 | + } |
|
246 | 255 | } |
247 | 256 | $smcFunc['db_free_result']($request); |
248 | 257 | |
249 | 258 | $senders = loadMemberData($senders); |
250 | - foreach ($senders as $member) |
|
251 | - loadMemberContext($member); |
|
259 | + foreach ($senders as $member) { |
|
260 | + loadMemberContext($member); |
|
261 | + } |
|
252 | 262 | |
253 | 263 | // Now go through and actually make with the text. |
254 | 264 | loadLanguage('Alerts'); |
@@ -262,12 +272,15 @@ discard block |
||
262 | 272 | $msgs = array(); |
263 | 273 | foreach ($alerts as $id_alert => $alert) |
264 | 274 | { |
265 | - if (isset($alert['extra']['board'])) |
|
266 | - $boards[$alert['extra']['board']] = $txt['board_na']; |
|
267 | - if (isset($alert['extra']['topic'])) |
|
268 | - $topics[$alert['extra']['topic']] = $txt['topic_na']; |
|
269 | - if ($alert['content_type'] == 'msg') |
|
270 | - $msgs[$alert['content_id']] = $txt['topic_na']; |
|
275 | + if (isset($alert['extra']['board'])) { |
|
276 | + $boards[$alert['extra']['board']] = $txt['board_na']; |
|
277 | + } |
|
278 | + if (isset($alert['extra']['topic'])) { |
|
279 | + $topics[$alert['extra']['topic']] = $txt['topic_na']; |
|
280 | + } |
|
281 | + if ($alert['content_type'] == 'msg') { |
|
282 | + $msgs[$alert['content_id']] = $txt['topic_na']; |
|
283 | + } |
|
271 | 284 | } |
272 | 285 | |
273 | 286 | // Having figured out what boards etc. there are, let's now get the names of them if we can see them. If not, there's already a fallback set up. |
@@ -282,8 +295,9 @@ discard block |
||
282 | 295 | 'boards' => array_keys($boards), |
283 | 296 | ) |
284 | 297 | ); |
285 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
286 | - $boards[$row['id_board']] = '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>'; |
|
298 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
299 | + $boards[$row['id_board']] = '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>'; |
|
300 | + } |
|
287 | 301 | } |
288 | 302 | if (!empty($topics)) |
289 | 303 | { |
@@ -298,8 +312,9 @@ discard block |
||
298 | 312 | 'topics' => array_keys($topics), |
299 | 313 | ) |
300 | 314 | ); |
301 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
302 | - $topics[$row['id_topic']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['subject'] . '</a>'; |
|
315 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
316 | + $topics[$row['id_topic']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['subject'] . '</a>'; |
|
317 | + } |
|
303 | 318 | } |
304 | 319 | if (!empty($msgs)) |
305 | 320 | { |
@@ -314,26 +329,33 @@ discard block |
||
314 | 329 | 'msgs' => array_keys($msgs), |
315 | 330 | ) |
316 | 331 | ); |
317 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
318 | - $msgs[$row['id_msg']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>'; |
|
332 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
333 | + $msgs[$row['id_msg']] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>'; |
|
334 | + } |
|
319 | 335 | } |
320 | 336 | |
321 | 337 | // Now to go back through the alerts, reattach this extra information and then try to build the string out of it (if a hook didn't already) |
322 | 338 | foreach ($alerts as $id_alert => $alert) |
323 | 339 | { |
324 | - if (!empty($alert['text'])) |
|
325 | - continue; |
|
326 | - if (isset($alert['extra']['board'])) |
|
327 | - $alerts[$id_alert]['extra']['board_msg'] = $boards[$alert['extra']['board']]; |
|
328 | - if (isset($alert['extra']['topic'])) |
|
329 | - $alerts[$id_alert]['extra']['topic_msg'] = $topics[$alert['extra']['topic']]; |
|
330 | - if ($alert['content_type'] == 'msg') |
|
331 | - $alerts[$id_alert]['extra']['msg_msg'] = $msgs[$alert['content_id']]; |
|
332 | - if ($alert['content_type'] == 'profile') |
|
333 | - $alerts[$id_alert]['extra']['profile_msg'] = '<a href="' . $scripturl . '?action=profile;u=' . $alerts[$id_alert]['content_id'] . '">' . $alerts[$id_alert]['extra']['user_name'] . '</a>'; |
|
334 | - |
|
335 | - if (!empty($memberContext[$alert['sender_id']])) |
|
336 | - $alerts[$id_alert]['sender'] = &$memberContext[$alert['sender_id']]; |
|
340 | + if (!empty($alert['text'])) { |
|
341 | + continue; |
|
342 | + } |
|
343 | + if (isset($alert['extra']['board'])) { |
|
344 | + $alerts[$id_alert]['extra']['board_msg'] = $boards[$alert['extra']['board']]; |
|
345 | + } |
|
346 | + if (isset($alert['extra']['topic'])) { |
|
347 | + $alerts[$id_alert]['extra']['topic_msg'] = $topics[$alert['extra']['topic']]; |
|
348 | + } |
|
349 | + if ($alert['content_type'] == 'msg') { |
|
350 | + $alerts[$id_alert]['extra']['msg_msg'] = $msgs[$alert['content_id']]; |
|
351 | + } |
|
352 | + if ($alert['content_type'] == 'profile') { |
|
353 | + $alerts[$id_alert]['extra']['profile_msg'] = '<a href="' . $scripturl . '?action=profile;u=' . $alerts[$id_alert]['content_id'] . '">' . $alerts[$id_alert]['extra']['user_name'] . '</a>'; |
|
354 | + } |
|
355 | + |
|
356 | + if (!empty($memberContext[$alert['sender_id']])) { |
|
357 | + $alerts[$id_alert]['sender'] = &$memberContext[$alert['sender_id']]; |
|
358 | + } |
|
337 | 359 | |
338 | 360 | $string = 'alert_' . $alert['content_type'] . '_' . $alert['content_action']; |
339 | 361 | if (isset($txt[$string])) |
@@ -421,11 +443,11 @@ discard block |
||
421 | 443 | checkSession('request'); |
422 | 444 | |
423 | 445 | // Call it! |
424 | - if ($action == 'remove') |
|
425 | - alert_delete($toMark, $memID); |
|
426 | - |
|
427 | - else |
|
428 | - alert_mark($memID, $toMark, $action == 'read' ? 1 : 0); |
|
446 | + if ($action == 'remove') { |
|
447 | + alert_delete($toMark, $memID); |
|
448 | + } else { |
|
449 | + alert_mark($memID, $toMark, $action == 'read' ? 1 : 0); |
|
450 | + } |
|
429 | 451 | |
430 | 452 | // Set a nice update message. |
431 | 453 | $_SESSION['update_message'] = true; |
@@ -475,23 +497,27 @@ discard block |
||
475 | 497 | ); |
476 | 498 | |
477 | 499 | // Set the page title |
478 | - if (isset($_GET['sa']) && array_key_exists($_GET['sa'], $title)) |
|
479 | - $context['page_title'] = $txt['show' . $title[$_GET['sa']]]; |
|
480 | - else |
|
481 | - $context['page_title'] = $txt['showPosts']; |
|
500 | + if (isset($_GET['sa']) && array_key_exists($_GET['sa'], $title)) { |
|
501 | + $context['page_title'] = $txt['show' . $title[$_GET['sa']]]; |
|
502 | + } else { |
|
503 | + $context['page_title'] = $txt['showPosts']; |
|
504 | + } |
|
482 | 505 | |
483 | 506 | $context['page_title'] .= ' - ' . $user_profile[$memID]['real_name']; |
484 | 507 | |
485 | 508 | // Is the load average too high to allow searching just now? |
486 | - if (!empty($context['load_average']) && !empty($modSettings['loadavg_show_posts']) && $context['load_average'] >= $modSettings['loadavg_show_posts']) |
|
487 | - fatal_lang_error('loadavg_show_posts_disabled', false); |
|
509 | + if (!empty($context['load_average']) && !empty($modSettings['loadavg_show_posts']) && $context['load_average'] >= $modSettings['loadavg_show_posts']) { |
|
510 | + fatal_lang_error('loadavg_show_posts_disabled', false); |
|
511 | + } |
|
488 | 512 | |
489 | 513 | // If we're specifically dealing with attachments use that function! |
490 | - if (isset($_GET['sa']) && $_GET['sa'] == 'attach') |
|
491 | - return showAttachments($memID); |
|
514 | + if (isset($_GET['sa']) && $_GET['sa'] == 'attach') { |
|
515 | + return showAttachments($memID); |
|
516 | + } |
|
492 | 517 | // Instead, if we're dealing with unwatched topics (and the feature is enabled) use that other function. |
493 | - elseif (isset($_GET['sa']) && $_GET['sa'] == 'unwatchedtopics') |
|
494 | - return showUnwatched($memID); |
|
518 | + elseif (isset($_GET['sa']) && $_GET['sa'] == 'unwatchedtopics') { |
|
519 | + return showUnwatched($memID); |
|
520 | + } |
|
495 | 521 | |
496 | 522 | // Are we just viewing topics? |
497 | 523 | $context['is_topics'] = isset($_GET['sa']) && $_GET['sa'] == 'topics' ? true : false; |
@@ -514,27 +540,30 @@ discard block |
||
514 | 540 | $smcFunc['db_free_result']($request); |
515 | 541 | |
516 | 542 | // Trying to remove a message that doesn't exist. |
517 | - if (empty($info)) |
|
518 | - redirectexit('action=profile;u=' . $memID . ';area=showposts;start=' . $_GET['start']); |
|
543 | + if (empty($info)) { |
|
544 | + redirectexit('action=profile;u=' . $memID . ';area=showposts;start=' . $_GET['start']); |
|
545 | + } |
|
519 | 546 | |
520 | 547 | // We can be lazy, since removeMessage() will check the permissions for us. |
521 | 548 | require_once($sourcedir . '/RemoveTopic.php'); |
522 | 549 | removeMessage((int) $_GET['delete']); |
523 | 550 | |
524 | 551 | // Add it to the mod log. |
525 | - if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) |
|
526 | - logAction('delete', array('topic' => $info[2], 'subject' => $info[0], 'member' => $info[1], 'board' => $info[3])); |
|
552 | + if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) { |
|
553 | + logAction('delete', array('topic' => $info[2], 'subject' => $info[0], 'member' => $info[1], 'board' => $info[3])); |
|
554 | + } |
|
527 | 555 | |
528 | 556 | // Back to... where we are now ;). |
529 | 557 | redirectexit('action=profile;u=' . $memID . ';area=showposts;start=' . $_GET['start']); |
530 | 558 | } |
531 | 559 | |
532 | 560 | // Default to 10. |
533 | - if (empty($_REQUEST['viewscount']) || !is_numeric($_REQUEST['viewscount'])) |
|
534 | - $_REQUEST['viewscount'] = '10'; |
|
561 | + if (empty($_REQUEST['viewscount']) || !is_numeric($_REQUEST['viewscount'])) { |
|
562 | + $_REQUEST['viewscount'] = '10'; |
|
563 | + } |
|
535 | 564 | |
536 | - if ($context['is_topics']) |
|
537 | - $request = $smcFunc['db_query']('', ' |
|
565 | + if ($context['is_topics']) { |
|
566 | + $request = $smcFunc['db_query']('', ' |
|
538 | 567 | SELECT COUNT(*) |
539 | 568 | FROM {db_prefix}topics AS t' . ($user_info['query_see_board'] == '1=1' ? '' : ' |
540 | 569 | INNER JOIN {db_prefix}boards AS b ON (b.id_board = t.id_board AND {query_see_board})') . ' |
@@ -547,8 +576,8 @@ discard block |
||
547 | 576 | 'board' => $board, |
548 | 577 | ) |
549 | 578 | ); |
550 | - else |
|
551 | - $request = $smcFunc['db_query']('', ' |
|
579 | + } else { |
|
580 | + $request = $smcFunc['db_query']('', ' |
|
552 | 581 | SELECT COUNT(*) |
553 | 582 | FROM {db_prefix}messages AS m' . ($user_info['query_see_board'] == '1=1' ? '' : ' |
554 | 583 | INNER JOIN {db_prefix}boards AS b ON (b.id_board = m.id_board AND {query_see_board})') . ' |
@@ -561,6 +590,7 @@ discard block |
||
561 | 590 | 'board' => $board, |
562 | 591 | ) |
563 | 592 | ); |
593 | + } |
|
564 | 594 | list ($msgCount) = $smcFunc['db_fetch_row']($request); |
565 | 595 | $smcFunc['db_free_result']($request); |
566 | 596 | |
@@ -581,10 +611,11 @@ discard block |
||
581 | 611 | |
582 | 612 | $range_limit = ''; |
583 | 613 | |
584 | - if ($context['is_topics']) |
|
585 | - $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['topics_per_page']) ? $options['topics_per_page'] : $modSettings['defaultMaxTopics']; |
|
586 | - else |
|
587 | - $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
|
614 | + if ($context['is_topics']) { |
|
615 | + $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['topics_per_page']) ? $options['topics_per_page'] : $modSettings['defaultMaxTopics']; |
|
616 | + } else { |
|
617 | + $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
|
618 | + } |
|
588 | 619 | |
589 | 620 | $maxIndex = $maxPerPage; |
590 | 621 | |
@@ -610,9 +641,9 @@ discard block |
||
610 | 641 | { |
611 | 642 | $margin *= 5; |
612 | 643 | $range_limit = $reverse ? 't.id_first_msg < ' . ($min_msg_member + $margin) : 't.id_first_msg > ' . ($max_msg_member - $margin); |
644 | + } else { |
|
645 | + $range_limit = $reverse ? 'm.id_msg < ' . ($min_msg_member + $margin) : 'm.id_msg > ' . ($max_msg_member - $margin); |
|
613 | 646 | } |
614 | - else |
|
615 | - $range_limit = $reverse ? 'm.id_msg < ' . ($min_msg_member + $margin) : 'm.id_msg > ' . ($max_msg_member - $margin); |
|
616 | 647 | } |
617 | 648 | |
618 | 649 | // Find this user's posts. The left join on categories somehow makes this faster, weird as it looks. |
@@ -644,8 +675,7 @@ discard block |
||
644 | 675 | 'max' => $maxIndex, |
645 | 676 | ) |
646 | 677 | ); |
647 | - } |
|
648 | - else |
|
678 | + } else |
|
649 | 679 | { |
650 | 680 | $request = $smcFunc['db_query']('', ' |
651 | 681 | SELECT |
@@ -674,8 +704,9 @@ discard block |
||
674 | 704 | } |
675 | 705 | |
676 | 706 | // Make sure we quit this loop. |
677 | - if ($smcFunc['db_num_rows']($request) === $maxIndex || $looped) |
|
678 | - break; |
|
707 | + if ($smcFunc['db_num_rows']($request) === $maxIndex || $looped) { |
|
708 | + break; |
|
709 | + } |
|
679 | 710 | $looped = true; |
680 | 711 | $range_limit = ''; |
681 | 712 | } |
@@ -719,19 +750,21 @@ discard block |
||
719 | 750 | 'css_class' => $row['approved'] ? 'windowbg' : 'approvebg', |
720 | 751 | ); |
721 | 752 | |
722 | - if ($user_info['id'] == $row['id_member_started']) |
|
723 | - $board_ids['own'][$row['id_board']][] = $counter; |
|
753 | + if ($user_info['id'] == $row['id_member_started']) { |
|
754 | + $board_ids['own'][$row['id_board']][] = $counter; |
|
755 | + } |
|
724 | 756 | $board_ids['any'][$row['id_board']][] = $counter; |
725 | 757 | } |
726 | 758 | $smcFunc['db_free_result']($request); |
727 | 759 | |
728 | 760 | // All posts were retrieved in reverse order, get them right again. |
729 | - if ($reverse) |
|
730 | - $context['posts'] = array_reverse($context['posts'], true); |
|
761 | + if ($reverse) { |
|
762 | + $context['posts'] = array_reverse($context['posts'], true); |
|
763 | + } |
|
731 | 764 | |
732 | 765 | // These are all the permissions that are different from board to board.. |
733 | - if ($context['is_topics']) |
|
734 | - $permissions = array( |
|
766 | + if ($context['is_topics']) { |
|
767 | + $permissions = array( |
|
735 | 768 | 'own' => array( |
736 | 769 | 'post_reply_own' => 'can_reply', |
737 | 770 | ), |
@@ -739,8 +772,8 @@ discard block |
||
739 | 772 | 'post_reply_any' => 'can_reply', |
740 | 773 | ) |
741 | 774 | ); |
742 | - else |
|
743 | - $permissions = array( |
|
775 | + } else { |
|
776 | + $permissions = array( |
|
744 | 777 | 'own' => array( |
745 | 778 | 'post_reply_own' => 'can_reply', |
746 | 779 | 'delete_own' => 'can_delete', |
@@ -750,6 +783,7 @@ discard block |
||
750 | 783 | 'delete_any' => 'can_delete', |
751 | 784 | ) |
752 | 785 | ); |
786 | + } |
|
753 | 787 | |
754 | 788 | // For every permission in the own/any lists... |
755 | 789 | foreach ($permissions as $type => $list) |
@@ -760,19 +794,22 @@ discard block |
||
760 | 794 | $boards = boardsAllowedTo($permission); |
761 | 795 | |
762 | 796 | // Hmm, they can do it on all boards, can they? |
763 | - if (!empty($boards) && $boards[0] == 0) |
|
764 | - $boards = array_keys($board_ids[$type]); |
|
797 | + if (!empty($boards) && $boards[0] == 0) { |
|
798 | + $boards = array_keys($board_ids[$type]); |
|
799 | + } |
|
765 | 800 | |
766 | 801 | // Now go through each board they can do the permission on. |
767 | 802 | foreach ($boards as $board_id) |
768 | 803 | { |
769 | 804 | // There aren't any posts displayed from this board. |
770 | - if (!isset($board_ids[$type][$board_id])) |
|
771 | - continue; |
|
805 | + if (!isset($board_ids[$type][$board_id])) { |
|
806 | + continue; |
|
807 | + } |
|
772 | 808 | |
773 | 809 | // Set the permission to true ;). |
774 | - foreach ($board_ids[$type][$board_id] as $counter) |
|
775 | - $context['posts'][$counter][$allowed] = true; |
|
810 | + foreach ($board_ids[$type][$board_id] as $counter) { |
|
811 | + $context['posts'][$counter][$allowed] = true; |
|
812 | + } |
|
776 | 813 | } |
777 | 814 | } |
778 | 815 | } |
@@ -803,8 +840,9 @@ discard block |
||
803 | 840 | $boardsAllowed = boardsAllowedTo('view_attachments'); |
804 | 841 | |
805 | 842 | // Make sure we can't actually see anything... |
806 | - if (empty($boardsAllowed)) |
|
807 | - $boardsAllowed = array(-1); |
|
843 | + if (empty($boardsAllowed)) { |
|
844 | + $boardsAllowed = array(-1); |
|
845 | + } |
|
808 | 846 | |
809 | 847 | require_once($sourcedir . '/Subs-List.php'); |
810 | 848 | |
@@ -955,8 +993,8 @@ discard block |
||
955 | 993 | ) |
956 | 994 | ); |
957 | 995 | $attachments = array(); |
958 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
959 | - $attachments[] = array( |
|
996 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
997 | + $attachments[] = array( |
|
960 | 998 | 'id' => $row['id_attach'], |
961 | 999 | 'filename' => $row['filename'], |
962 | 1000 | 'downloads' => $row['downloads'], |
@@ -968,6 +1006,7 @@ discard block |
||
968 | 1006 | 'board_name' => $row['name'], |
969 | 1007 | 'approved' => $row['approved'], |
970 | 1008 | ); |
1009 | + } |
|
971 | 1010 | |
972 | 1011 | $smcFunc['db_free_result']($request); |
973 | 1012 | |
@@ -1022,8 +1061,9 @@ discard block |
||
1022 | 1061 | global $txt, $user_info, $scripturl, $modSettings, $context, $sourcedir; |
1023 | 1062 | |
1024 | 1063 | // Only the owner can see the list (if the function is enabled of course) |
1025 | - if ($user_info['id'] != $memID) |
|
1026 | - return; |
|
1064 | + if ($user_info['id'] != $memID) { |
|
1065 | + return; |
|
1066 | + } |
|
1027 | 1067 | |
1028 | 1068 | require_once($sourcedir . '/Subs-List.php'); |
1029 | 1069 | |
@@ -1169,8 +1209,9 @@ discard block |
||
1169 | 1209 | ); |
1170 | 1210 | |
1171 | 1211 | $topics = array(); |
1172 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1173 | - $topics[] = $row['id_topic']; |
|
1212 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1213 | + $topics[] = $row['id_topic']; |
|
1214 | + } |
|
1174 | 1215 | |
1175 | 1216 | $smcFunc['db_free_result']($request); |
1176 | 1217 | |
@@ -1190,8 +1231,9 @@ discard block |
||
1190 | 1231 | 'topics' => $topics, |
1191 | 1232 | ) |
1192 | 1233 | ); |
1193 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1194 | - $topicsInfo[] = $row; |
|
1234 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1235 | + $topicsInfo[] = $row; |
|
1236 | + } |
|
1195 | 1237 | $smcFunc['db_free_result']($request); |
1196 | 1238 | } |
1197 | 1239 | |
@@ -1239,8 +1281,9 @@ discard block |
||
1239 | 1281 | $context['page_title'] = $txt['statPanel_showStats'] . ' ' . $user_profile[$memID]['real_name']; |
1240 | 1282 | |
1241 | 1283 | // Is the load average too high to allow searching just now? |
1242 | - if (!empty($context['load_average']) && !empty($modSettings['loadavg_userstats']) && $context['load_average'] >= $modSettings['loadavg_userstats']) |
|
1243 | - fatal_lang_error('loadavg_userstats_disabled', false); |
|
1284 | + if (!empty($context['load_average']) && !empty($modSettings['loadavg_userstats']) && $context['load_average'] >= $modSettings['loadavg_userstats']) { |
|
1285 | + fatal_lang_error('loadavg_userstats_disabled', false); |
|
1286 | + } |
|
1244 | 1287 | |
1245 | 1288 | // General user statistics. |
1246 | 1289 | $timeDays = floor($user_profile[$memID]['total_time_logged_in'] / 86400); |
@@ -1398,11 +1441,13 @@ discard block |
||
1398 | 1441 | } |
1399 | 1442 | $smcFunc['db_free_result']($result); |
1400 | 1443 | |
1401 | - if ($maxPosts > 0) |
|
1402 | - for ($hour = 0; $hour < 24; $hour++) |
|
1444 | + if ($maxPosts > 0) { |
|
1445 | + for ($hour = 0; |
|
1446 | + } |
|
1447 | + $hour < 24; $hour++) |
|
1403 | 1448 | { |
1404 | - if (!isset($context['posts_by_time'][$hour])) |
|
1405 | - $context['posts_by_time'][$hour] = array( |
|
1449 | + if (!isset($context['posts_by_time'][$hour])) { |
|
1450 | + $context['posts_by_time'][$hour] = array( |
|
1406 | 1451 | 'hour' => $hour, |
1407 | 1452 | 'hour_format' => stripos($user_info['time_format'], '%p') === false ? $hour : date('g a', mktime($hour)), |
1408 | 1453 | 'posts' => 0, |
@@ -1410,7 +1455,7 @@ discard block |
||
1410 | 1455 | 'relative_percent' => 0, |
1411 | 1456 | 'is_last' => $hour == 23, |
1412 | 1457 | ); |
1413 | - else |
|
1458 | + } else |
|
1414 | 1459 | { |
1415 | 1460 | $context['posts_by_time'][$hour]['posts_percent'] = round(($context['posts_by_time'][$hour]['posts'] * 100) / $realPosts); |
1416 | 1461 | $context['posts_by_time'][$hour]['relative_percent'] = round(($context['posts_by_time'][$hour]['posts'] * 100) / $maxPosts); |
@@ -1443,8 +1488,9 @@ discard block |
||
1443 | 1488 | |
1444 | 1489 | foreach ($subActions as $sa => $action) |
1445 | 1490 | { |
1446 | - if (!allowedTo($action[2])) |
|
1447 | - unset($subActions[$sa]); |
|
1491 | + if (!allowedTo($action[2])) { |
|
1492 | + unset($subActions[$sa]); |
|
1493 | + } |
|
1448 | 1494 | } |
1449 | 1495 | |
1450 | 1496 | // Create the tabs for the template. |
@@ -1462,15 +1508,18 @@ discard block |
||
1462 | 1508 | ); |
1463 | 1509 | |
1464 | 1510 | // Moderation must be on to track edits. |
1465 | - if (empty($modSettings['userlog_enabled'])) |
|
1466 | - unset($context[$context['profile_menu_name']]['tab_data']['edits'], $subActions['edits']); |
|
1511 | + if (empty($modSettings['userlog_enabled'])) { |
|
1512 | + unset($context[$context['profile_menu_name']]['tab_data']['edits'], $subActions['edits']); |
|
1513 | + } |
|
1467 | 1514 | |
1468 | 1515 | // Group requests must be active to show it... |
1469 | - if (empty($modSettings['show_group_membership'])) |
|
1470 | - unset($context[$context['profile_menu_name']]['tab_data']['groupreq'], $subActions['groupreq']); |
|
1516 | + if (empty($modSettings['show_group_membership'])) { |
|
1517 | + unset($context[$context['profile_menu_name']]['tab_data']['groupreq'], $subActions['groupreq']); |
|
1518 | + } |
|
1471 | 1519 | |
1472 | - if (empty($subActions)) |
|
1473 | - fatal_lang_error('no_access', false); |
|
1520 | + if (empty($subActions)) { |
|
1521 | + fatal_lang_error('no_access', false); |
|
1522 | + } |
|
1474 | 1523 | |
1475 | 1524 | $keys = array_keys($subActions); |
1476 | 1525 | $default = array_shift($keys); |
@@ -1483,9 +1532,10 @@ discard block |
||
1483 | 1532 | $context['sub_template'] = $subActions[$context['tracking_area']][0]; |
1484 | 1533 | $call = call_helper($subActions[$context['tracking_area']][0], true); |
1485 | 1534 | |
1486 | - if (!empty($call)) |
|
1487 | - call_user_func($call, $memID); |
|
1488 | -} |
|
1535 | + if (!empty($call)) { |
|
1536 | + call_user_func($call, $memID); |
|
1537 | + } |
|
1538 | + } |
|
1489 | 1539 | |
1490 | 1540 | /** |
1491 | 1541 | * Handles tracking a user's activity |
@@ -1501,8 +1551,9 @@ discard block |
||
1501 | 1551 | isAllowedTo('moderate_forum'); |
1502 | 1552 | |
1503 | 1553 | $context['last_ip'] = $user_profile[$memID]['member_ip']; |
1504 | - if ($context['last_ip'] != $user_profile[$memID]['member_ip2']) |
|
1505 | - $context['last_ip2'] = $user_profile[$memID]['member_ip2']; |
|
1554 | + if ($context['last_ip'] != $user_profile[$memID]['member_ip2']) { |
|
1555 | + $context['last_ip2'] = $user_profile[$memID]['member_ip2']; |
|
1556 | + } |
|
1506 | 1557 | $context['member']['name'] = $user_profile[$memID]['real_name']; |
1507 | 1558 | |
1508 | 1559 | // Set the options for the list component. |
@@ -1668,8 +1719,9 @@ discard block |
||
1668 | 1719 | ) |
1669 | 1720 | ); |
1670 | 1721 | $message_members = array(); |
1671 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1672 | - $message_members[] = $row['id_member']; |
|
1722 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1723 | + $message_members[] = $row['id_member']; |
|
1724 | + } |
|
1673 | 1725 | $smcFunc['db_free_result']($request); |
1674 | 1726 | |
1675 | 1727 | // Fetch their names, cause of the GROUP BY doesn't like giving us that normally. |
@@ -1684,8 +1736,9 @@ discard block |
||
1684 | 1736 | 'ip_list' => $ips, |
1685 | 1737 | ) |
1686 | 1738 | ); |
1687 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1688 | - $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1739 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1740 | + $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1741 | + } |
|
1689 | 1742 | $smcFunc['db_free_result']($request); |
1690 | 1743 | } |
1691 | 1744 | |
@@ -1699,8 +1752,9 @@ discard block |
||
1699 | 1752 | 'ip_list' => $ips, |
1700 | 1753 | ) |
1701 | 1754 | ); |
1702 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1703 | - $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1755 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1756 | + $context['members_in_range'][$row['id_member']] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
1757 | + } |
|
1704 | 1758 | $smcFunc['db_free_result']($request); |
1705 | 1759 | } |
1706 | 1760 | } |
@@ -1760,8 +1814,8 @@ discard block |
||
1760 | 1814 | )) |
1761 | 1815 | ); |
1762 | 1816 | $error_messages = array(); |
1763 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1764 | - $error_messages[] = array( |
|
1817 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1818 | + $error_messages[] = array( |
|
1765 | 1819 | 'ip' => inet_dtop($row['ip']), |
1766 | 1820 | 'member_link' => $row['id_member'] > 0 ? '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>' : $row['display_name'], |
1767 | 1821 | 'message' => strtr($row['message'], array('<span class="remove">' => '', '</span>' => '')), |
@@ -1769,6 +1823,7 @@ discard block |
||
1769 | 1823 | 'time' => timeformat($row['log_time']), |
1770 | 1824 | 'timestamp' => forum_time(true, $row['log_time']), |
1771 | 1825 | ); |
1826 | + } |
|
1772 | 1827 | $smcFunc['db_free_result']($request); |
1773 | 1828 | |
1774 | 1829 | return $error_messages; |
@@ -1831,8 +1886,8 @@ discard block |
||
1831 | 1886 | )) |
1832 | 1887 | ); |
1833 | 1888 | $messages = array(); |
1834 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1835 | - $messages[] = array( |
|
1889 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1890 | + $messages[] = array( |
|
1836 | 1891 | 'ip' => inet_dtop($row['poster_ip']), |
1837 | 1892 | 'member_link' => empty($row['id_member']) ? $row['display_name'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>', |
1838 | 1893 | 'board' => array( |
@@ -1845,6 +1900,7 @@ discard block |
||
1845 | 1900 | 'time' => timeformat($row['poster_time']), |
1846 | 1901 | 'timestamp' => forum_time(true, $row['poster_time']) |
1847 | 1902 | ); |
1903 | + } |
|
1848 | 1904 | $smcFunc['db_free_result']($request); |
1849 | 1905 | |
1850 | 1906 | return $messages; |
@@ -1871,19 +1927,20 @@ discard block |
||
1871 | 1927 | $context['sub_template'] = 'trackIP'; |
1872 | 1928 | $context['page_title'] = $txt['profile']; |
1873 | 1929 | $context['base_url'] = $scripturl . '?action=trackip'; |
1874 | - } |
|
1875 | - else |
|
1930 | + } else |
|
1876 | 1931 | { |
1877 | 1932 | $context['ip'] = $user_profile[$memID]['member_ip']; |
1878 | 1933 | $context['base_url'] = $scripturl . '?action=profile;area=tracking;sa=ip;u=' . $memID; |
1879 | 1934 | } |
1880 | 1935 | |
1881 | 1936 | // Searching? |
1882 | - if (isset($_REQUEST['searchip'])) |
|
1883 | - $context['ip'] = trim($_REQUEST['searchip']); |
|
1937 | + if (isset($_REQUEST['searchip'])) { |
|
1938 | + $context['ip'] = trim($_REQUEST['searchip']); |
|
1939 | + } |
|
1884 | 1940 | |
1885 | - if (isValidIP($context['ip']) === false) |
|
1886 | - fatal_lang_error('invalid_tracking_ip', false); |
|
1941 | + if (isValidIP($context['ip']) === false) { |
|
1942 | + fatal_lang_error('invalid_tracking_ip', false); |
|
1943 | + } |
|
1887 | 1944 | |
1888 | 1945 | //mysql didn't support like search with varbinary |
1889 | 1946 | //$ip_var = str_replace('*', '%', $context['ip']); |
@@ -1891,8 +1948,9 @@ discard block |
||
1891 | 1948 | $ip_var = $context['ip']; |
1892 | 1949 | $ip_string = '= {inet:ip_address}'; |
1893 | 1950 | |
1894 | - if (empty($context['tracking_area'])) |
|
1895 | - $context['page_title'] = $txt['trackIP'] . ' - ' . $context['ip']; |
|
1951 | + if (empty($context['tracking_area'])) { |
|
1952 | + $context['page_title'] = $txt['trackIP'] . ' - ' . $context['ip']; |
|
1953 | + } |
|
1896 | 1954 | |
1897 | 1955 | $request = $smcFunc['db_query']('', ' |
1898 | 1956 | SELECT id_member, real_name AS display_name, member_ip |
@@ -1903,8 +1961,9 @@ discard block |
||
1903 | 1961 | ) |
1904 | 1962 | ); |
1905 | 1963 | $context['ips'] = array(); |
1906 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1907 | - $context['ips'][inet_dtop($row['member_ip'])][] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>'; |
|
1964 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1965 | + $context['ips'][inet_dtop($row['member_ip'])][] = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['display_name'] . '</a>'; |
|
1966 | + } |
|
1908 | 1967 | $smcFunc['db_free_result']($request); |
1909 | 1968 | |
1910 | 1969 | ksort($context['ips']); |
@@ -2133,8 +2192,9 @@ discard block |
||
2133 | 2192 | foreach ($context['whois_servers'] as $whois) |
2134 | 2193 | { |
2135 | 2194 | // Strip off the "decimal point" and anything following... |
2136 | - if (in_array((int) $context['ip'], $whois['range'])) |
|
2137 | - $context['auto_whois_server'] = $whois; |
|
2195 | + if (in_array((int) $context['ip'], $whois['range'])) { |
|
2196 | + $context['auto_whois_server'] = $whois; |
|
2197 | + } |
|
2138 | 2198 | } |
2139 | 2199 | } |
2140 | 2200 | } |
@@ -2151,10 +2211,11 @@ discard block |
||
2151 | 2211 | // Gonna want this for the list. |
2152 | 2212 | require_once($sourcedir . '/Subs-List.php'); |
2153 | 2213 | |
2154 | - if ($memID == 0) |
|
2155 | - $context['base_url'] = $scripturl . '?action=trackip'; |
|
2156 | - else |
|
2157 | - $context['base_url'] = $scripturl . '?action=profile;area=tracking;sa=ip;u=' . $memID; |
|
2214 | + if ($memID == 0) { |
|
2215 | + $context['base_url'] = $scripturl . '?action=trackip'; |
|
2216 | + } else { |
|
2217 | + $context['base_url'] = $scripturl . '?action=profile;area=tracking;sa=ip;u=' . $memID; |
|
2218 | + } |
|
2158 | 2219 | |
2159 | 2220 | // Start with the user messages. |
2160 | 2221 | $listOptions = array( |
@@ -2264,12 +2325,13 @@ discard block |
||
2264 | 2325 | ) |
2265 | 2326 | ); |
2266 | 2327 | $logins = array(); |
2267 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2268 | - $logins[] = array( |
|
2328 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2329 | + $logins[] = array( |
|
2269 | 2330 | 'time' => timeformat($row['time']), |
2270 | 2331 | 'ip' => inet_dtop($row['ip']), |
2271 | 2332 | 'ip2' => inet_dtop($row['ip2']), |
2272 | 2333 | ); |
2334 | + } |
|
2273 | 2335 | $smcFunc['db_free_result']($request); |
2274 | 2336 | |
2275 | 2337 | return $logins; |
@@ -2294,11 +2356,12 @@ discard block |
||
2294 | 2356 | ) |
2295 | 2357 | ); |
2296 | 2358 | $context['custom_field_titles'] = array(); |
2297 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2298 | - $context['custom_field_titles']['customfield_' . $row['col_name']] = array( |
|
2359 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2360 | + $context['custom_field_titles']['customfield_' . $row['col_name']] = array( |
|
2299 | 2361 | 'title' => $row['field_name'], |
2300 | 2362 | 'parse_bbc' => $row['bbc'], |
2301 | 2363 | ); |
2364 | + } |
|
2302 | 2365 | $smcFunc['db_free_result']($request); |
2303 | 2366 | |
2304 | 2367 | // Set the options for the error lists. |
@@ -2437,19 +2500,22 @@ discard block |
||
2437 | 2500 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2438 | 2501 | { |
2439 | 2502 | $extra = $smcFunc['json_decode']($row['extra'], true); |
2440 | - if (!empty($extra['applicator'])) |
|
2441 | - $members[] = $extra['applicator']; |
|
2503 | + if (!empty($extra['applicator'])) { |
|
2504 | + $members[] = $extra['applicator']; |
|
2505 | + } |
|
2442 | 2506 | |
2443 | 2507 | // Work out what the name of the action is. |
2444 | - if (isset($txt['trackEdit_action_' . $row['action']])) |
|
2445 | - $action_text = $txt['trackEdit_action_' . $row['action']]; |
|
2446 | - elseif (isset($txt[$row['action']])) |
|
2447 | - $action_text = $txt[$row['action']]; |
|
2508 | + if (isset($txt['trackEdit_action_' . $row['action']])) { |
|
2509 | + $action_text = $txt['trackEdit_action_' . $row['action']]; |
|
2510 | + } elseif (isset($txt[$row['action']])) { |
|
2511 | + $action_text = $txt[$row['action']]; |
|
2512 | + } |
|
2448 | 2513 | // Custom field? |
2449 | - elseif (isset($context['custom_field_titles'][$row['action']])) |
|
2450 | - $action_text = $context['custom_field_titles'][$row['action']]['title']; |
|
2451 | - else |
|
2452 | - $action_text = $row['action']; |
|
2514 | + elseif (isset($context['custom_field_titles'][$row['action']])) { |
|
2515 | + $action_text = $context['custom_field_titles'][$row['action']]['title']; |
|
2516 | + } else { |
|
2517 | + $action_text = $row['action']; |
|
2518 | + } |
|
2453 | 2519 | |
2454 | 2520 | // Parse BBC? |
2455 | 2521 | $parse_bbc = isset($context['custom_field_titles'][$row['action']]) && $context['custom_field_titles'][$row['action']]['parse_bbc'] ? true : false; |
@@ -2481,13 +2547,15 @@ discard block |
||
2481 | 2547 | ) |
2482 | 2548 | ); |
2483 | 2549 | $members = array(); |
2484 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2485 | - $members[$row['id_member']] = $row['real_name']; |
|
2550 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2551 | + $members[$row['id_member']] = $row['real_name']; |
|
2552 | + } |
|
2486 | 2553 | $smcFunc['db_free_result']($request); |
2487 | 2554 | |
2488 | - foreach ($edits as $key => $value) |
|
2489 | - if (isset($members[$value['id_member']])) |
|
2555 | + foreach ($edits as $key => $value) { |
|
2556 | + if (isset($members[$value['id_member']])) |
|
2490 | 2557 | $edits[$key]['member_link'] = '<a href="' . $scripturl . '?action=profile;u=' . $value['id_member'] . '">' . $members[$value['id_member']] . '</a>'; |
2558 | + } |
|
2491 | 2559 | } |
2492 | 2560 | |
2493 | 2561 | return $edits; |
@@ -2688,10 +2756,11 @@ discard block |
||
2688 | 2756 | $context['board'] = $board; |
2689 | 2757 | |
2690 | 2758 | // Determine which groups this user is in. |
2691 | - if (empty($user_profile[$memID]['additional_groups'])) |
|
2692 | - $curGroups = array(); |
|
2693 | - else |
|
2694 | - $curGroups = explode(',', $user_profile[$memID]['additional_groups']); |
|
2759 | + if (empty($user_profile[$memID]['additional_groups'])) { |
|
2760 | + $curGroups = array(); |
|
2761 | + } else { |
|
2762 | + $curGroups = explode(',', $user_profile[$memID]['additional_groups']); |
|
2763 | + } |
|
2695 | 2764 | $curGroups[] = $user_profile[$memID]['id_group']; |
2696 | 2765 | $curGroups[] = $user_profile[$memID]['id_post_group']; |
2697 | 2766 | |
@@ -2711,28 +2780,30 @@ discard block |
||
2711 | 2780 | $context['no_access_boards'] = array(); |
2712 | 2781 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2713 | 2782 | { |
2714 | - if (count(array_intersect($curGroups, explode(',', $row['member_groups']))) === 0 && !$row['is_mod']) |
|
2715 | - $context['no_access_boards'][] = array( |
|
2783 | + if (count(array_intersect($curGroups, explode(',', $row['member_groups']))) === 0 && !$row['is_mod']) { |
|
2784 | + $context['no_access_boards'][] = array( |
|
2716 | 2785 | 'id' => $row['id_board'], |
2717 | 2786 | 'name' => $row['name'], |
2718 | 2787 | 'is_last' => false, |
2719 | 2788 | ); |
2720 | - elseif ($row['id_profile'] != 1 || $row['is_mod']) |
|
2721 | - $context['boards'][$row['id_board']] = array( |
|
2789 | + } elseif ($row['id_profile'] != 1 || $row['is_mod']) { |
|
2790 | + $context['boards'][$row['id_board']] = array( |
|
2722 | 2791 | 'id' => $row['id_board'], |
2723 | 2792 | 'name' => $row['name'], |
2724 | 2793 | 'selected' => $board == $row['id_board'], |
2725 | 2794 | 'profile' => $row['id_profile'], |
2726 | 2795 | 'profile_name' => $context['profiles'][$row['id_profile']]['name'], |
2727 | 2796 | ); |
2797 | + } |
|
2728 | 2798 | } |
2729 | 2799 | $smcFunc['db_free_result']($request); |
2730 | 2800 | |
2731 | 2801 | require_once($sourcedir . '/Subs-Boards.php'); |
2732 | 2802 | sortBoards($context['boards']); |
2733 | 2803 | |
2734 | - if (!empty($context['no_access_boards'])) |
|
2735 | - $context['no_access_boards'][count($context['no_access_boards']) - 1]['is_last'] = true; |
|
2804 | + if (!empty($context['no_access_boards'])) { |
|
2805 | + $context['no_access_boards'][count($context['no_access_boards']) - 1]['is_last'] = true; |
|
2806 | + } |
|
2736 | 2807 | |
2737 | 2808 | $context['member']['permissions'] = array( |
2738 | 2809 | 'general' => array(), |
@@ -2741,8 +2812,9 @@ discard block |
||
2741 | 2812 | |
2742 | 2813 | // If you're an admin we know you can do everything, we might as well leave. |
2743 | 2814 | $context['member']['has_all_permissions'] = in_array(1, $curGroups); |
2744 | - if ($context['member']['has_all_permissions']) |
|
2745 | - return; |
|
2815 | + if ($context['member']['has_all_permissions']) { |
|
2816 | + return; |
|
2817 | + } |
|
2746 | 2818 | |
2747 | 2819 | $denied = array(); |
2748 | 2820 | |
@@ -2761,21 +2833,24 @@ discard block |
||
2761 | 2833 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
2762 | 2834 | { |
2763 | 2835 | // We don't know about this permission, it doesn't exist :P. |
2764 | - if (!isset($txt['permissionname_' . $row['permission']])) |
|
2765 | - continue; |
|
2836 | + if (!isset($txt['permissionname_' . $row['permission']])) { |
|
2837 | + continue; |
|
2838 | + } |
|
2766 | 2839 | |
2767 | - if (empty($row['add_deny'])) |
|
2768 | - $denied[] = $row['permission']; |
|
2840 | + if (empty($row['add_deny'])) { |
|
2841 | + $denied[] = $row['permission']; |
|
2842 | + } |
|
2769 | 2843 | |
2770 | 2844 | // Permissions that end with _own or _any consist of two parts. |
2771 | - if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) |
|
2772 | - $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2773 | - else |
|
2774 | - $name = $txt['permissionname_' . $row['permission']]; |
|
2845 | + if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) { |
|
2846 | + $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2847 | + } else { |
|
2848 | + $name = $txt['permissionname_' . $row['permission']]; |
|
2849 | + } |
|
2775 | 2850 | |
2776 | 2851 | // Add this permission if it doesn't exist yet. |
2777 | - if (!isset($context['member']['permissions']['general'][$row['permission']])) |
|
2778 | - $context['member']['permissions']['general'][$row['permission']] = array( |
|
2852 | + if (!isset($context['member']['permissions']['general'][$row['permission']])) { |
|
2853 | + $context['member']['permissions']['general'][$row['permission']] = array( |
|
2779 | 2854 | 'id' => $row['permission'], |
2780 | 2855 | 'groups' => array( |
2781 | 2856 | 'allowed' => array(), |
@@ -2785,6 +2860,7 @@ discard block |
||
2785 | 2860 | 'is_denied' => false, |
2786 | 2861 | 'is_global' => true, |
2787 | 2862 | ); |
2863 | + } |
|
2788 | 2864 | |
2789 | 2865 | // Add the membergroup to either the denied or the allowed groups. |
2790 | 2866 | $context['member']['permissions']['general'][$row['permission']]['groups'][empty($row['add_deny']) ? 'denied' : 'allowed'][] = $row['id_group'] == 0 ? $txt['membergroups_members'] : $row['group_name']; |
@@ -2818,18 +2894,20 @@ discard block |
||
2818 | 2894 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2819 | 2895 | { |
2820 | 2896 | // We don't know about this permission, it doesn't exist :P. |
2821 | - if (!isset($txt['permissionname_' . $row['permission']])) |
|
2822 | - continue; |
|
2897 | + if (!isset($txt['permissionname_' . $row['permission']])) { |
|
2898 | + continue; |
|
2899 | + } |
|
2823 | 2900 | |
2824 | 2901 | // The name of the permission using the format 'permission name' - 'own/any topic/event/etc.'. |
2825 | - if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) |
|
2826 | - $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2827 | - else |
|
2828 | - $name = $txt['permissionname_' . $row['permission']]; |
|
2902 | + if (in_array(substr($row['permission'], -4), array('_own', '_any')) && isset($txt['permissionname_' . substr($row['permission'], 0, -4)])) { |
|
2903 | + $name = $txt['permissionname_' . substr($row['permission'], 0, -4)] . ' - ' . $txt['permissionname_' . $row['permission']]; |
|
2904 | + } else { |
|
2905 | + $name = $txt['permissionname_' . $row['permission']]; |
|
2906 | + } |
|
2829 | 2907 | |
2830 | 2908 | // Create the structure for this permission. |
2831 | - if (!isset($context['member']['permissions']['board'][$row['permission']])) |
|
2832 | - $context['member']['permissions']['board'][$row['permission']] = array( |
|
2909 | + if (!isset($context['member']['permissions']['board'][$row['permission']])) { |
|
2910 | + $context['member']['permissions']['board'][$row['permission']] = array( |
|
2833 | 2911 | 'id' => $row['permission'], |
2834 | 2912 | 'groups' => array( |
2835 | 2913 | 'allowed' => array(), |
@@ -2839,6 +2917,7 @@ discard block |
||
2839 | 2917 | 'is_denied' => false, |
2840 | 2918 | 'is_global' => empty($board), |
2841 | 2919 | ); |
2920 | + } |
|
2842 | 2921 | |
2843 | 2922 | $context['member']['permissions']['board'][$row['permission']]['groups'][empty($row['add_deny']) ? 'denied' : 'allowed'][$row['id_group']] = $row['id_group'] == 0 ? $txt['membergroups_members'] : $row['group_name']; |
2844 | 2923 | |
@@ -2857,8 +2936,9 @@ discard block |
||
2857 | 2936 | global $modSettings, $context, $sourcedir, $txt, $scripturl; |
2858 | 2937 | |
2859 | 2938 | // Firstly, can we actually even be here? |
2860 | - if (!($context['user']['is_owner'] && allowedTo('view_warning_own')) && !allowedTo('view_warning_any') && !allowedTo('issue_warning') && !allowedTo('moderate_forum')) |
|
2861 | - fatal_lang_error('no_access', false); |
|
2939 | + if (!($context['user']['is_owner'] && allowedTo('view_warning_own')) && !allowedTo('view_warning_any') && !allowedTo('issue_warning') && !allowedTo('moderate_forum')) { |
|
2940 | + fatal_lang_error('no_access', false); |
|
2941 | + } |
|
2862 | 2942 | |
2863 | 2943 | // Make sure things which are disabled stay disabled. |
2864 | 2944 | $modSettings['warning_watch'] = !empty($modSettings['warning_watch']) ? $modSettings['warning_watch'] : 110; |
@@ -2945,9 +3025,10 @@ discard block |
||
2945 | 3025 | $modSettings['warning_mute'] => $txt['profile_warning_effect_own_muted'], |
2946 | 3026 | ); |
2947 | 3027 | $context['current_level'] = 0; |
2948 | - foreach ($context['level_effects'] as $limit => $dummy) |
|
2949 | - if ($context['member']['warning'] >= $limit) |
|
3028 | + foreach ($context['level_effects'] as $limit => $dummy) { |
|
3029 | + if ($context['member']['warning'] >= $limit) |
|
2950 | 3030 | $context['current_level'] = $limit; |
2951 | -} |
|
3031 | + } |
|
3032 | + } |
|
2952 | 3033 | |
2953 | 3034 | ?> |
2954 | 3035 | \ No newline at end of file |
@@ -15,8 +15,9 @@ discard block |
||
15 | 15 | * @version 2.1 Beta 4 |
16 | 16 | */ |
17 | 17 | |
18 | -if (!defined('SMF')) |
|
18 | +if (!defined('SMF')) { |
|
19 | 19 | die('No direct access...'); |
20 | +} |
|
20 | 21 | |
21 | 22 | /** |
22 | 23 | * The main designating function for modifying profiles. Loads up info, determins what to do, etc. |
@@ -29,18 +30,21 @@ discard block |
||
29 | 30 | global $modSettings, $memberContext, $profile_vars, $post_errors, $smcFunc; |
30 | 31 | |
31 | 32 | // Don't reload this as we may have processed error strings. |
32 | - if (empty($post_errors)) |
|
33 | - loadLanguage('Profile+Drafts'); |
|
33 | + if (empty($post_errors)) { |
|
34 | + loadLanguage('Profile+Drafts'); |
|
35 | + } |
|
34 | 36 | loadTemplate('Profile'); |
35 | 37 | |
36 | 38 | require_once($sourcedir . '/Subs-Menu.php'); |
37 | 39 | |
38 | 40 | // Did we get the user by name... |
39 | - if (isset($_REQUEST['user'])) |
|
40 | - $memberResult = loadMemberData($_REQUEST['user'], true, 'profile'); |
|
41 | + if (isset($_REQUEST['user'])) { |
|
42 | + $memberResult = loadMemberData($_REQUEST['user'], true, 'profile'); |
|
43 | + } |
|
41 | 44 | // ... or by id_member? |
42 | - elseif (!empty($_REQUEST['u'])) |
|
43 | - $memberResult = loadMemberData((int) $_REQUEST['u'], false, 'profile'); |
|
45 | + elseif (!empty($_REQUEST['u'])) { |
|
46 | + $memberResult = loadMemberData((int) $_REQUEST['u'], false, 'profile'); |
|
47 | + } |
|
44 | 48 | // If it was just ?action=profile, edit your own profile, but only if you're not a guest. |
45 | 49 | else |
46 | 50 | { |
@@ -50,8 +54,9 @@ discard block |
||
50 | 54 | } |
51 | 55 | |
52 | 56 | // Check if loadMemberData() has returned a valid result. |
53 | - if (!$memberResult) |
|
54 | - fatal_lang_error('not_a_user', false, 404); |
|
57 | + if (!$memberResult) { |
|
58 | + fatal_lang_error('not_a_user', false, 404); |
|
59 | + } |
|
55 | 60 | |
56 | 61 | // If all went well, we have a valid member ID! |
57 | 62 | list ($memID) = $memberResult; |
@@ -67,8 +72,9 @@ discard block |
||
67 | 72 | |
68 | 73 | // Group management isn't actually a permission. But we need it to be for this, so we need a phantom permission. |
69 | 74 | // And we care about what the current user can do, not what the user whose profile it is. |
70 | - if ($user_info['mod_cache']['gq'] != '0=1') |
|
71 | - $user_info['permissions'][] = 'approve_group_requests'; |
|
75 | + if ($user_info['mod_cache']['gq'] != '0=1') { |
|
76 | + $user_info['permissions'][] = 'approve_group_requests'; |
|
77 | + } |
|
72 | 78 | |
73 | 79 | // If paid subscriptions are enabled, make sure we actually have at least one subscription available... |
74 | 80 | $context['subs_available'] = false; |
@@ -436,21 +442,25 @@ discard block |
||
436 | 442 | foreach ($section['areas'] as $area_id => $area) |
437 | 443 | { |
438 | 444 | // If it said no permissions that meant it wasn't valid! |
439 | - if (empty($area['permission'][$context['user']['is_owner'] ? 'own' : 'any'])) |
|
440 | - $profile_areas[$section_id]['areas'][$area_id]['enabled'] = false; |
|
445 | + if (empty($area['permission'][$context['user']['is_owner'] ? 'own' : 'any'])) { |
|
446 | + $profile_areas[$section_id]['areas'][$area_id]['enabled'] = false; |
|
447 | + } |
|
441 | 448 | // Otherwise pick the right set. |
442 | - else |
|
443 | - $profile_areas[$section_id]['areas'][$area_id]['permission'] = $area['permission'][$context['user']['is_owner'] ? 'own' : 'any']; |
|
449 | + else { |
|
450 | + $profile_areas[$section_id]['areas'][$area_id]['permission'] = $area['permission'][$context['user']['is_owner'] ? 'own' : 'any']; |
|
451 | + } |
|
444 | 452 | |
445 | 453 | // Password required in most cases |
446 | - if (!empty($area['password'])) |
|
447 | - $context['password_areas'][] = $area_id; |
|
454 | + if (!empty($area['password'])) { |
|
455 | + $context['password_areas'][] = $area_id; |
|
456 | + } |
|
448 | 457 | } |
449 | 458 | } |
450 | 459 | |
451 | 460 | // Is there an updated message to show? |
452 | - if (isset($_GET['updated'])) |
|
453 | - $context['profile_updated'] = $txt['profile_updated_own']; |
|
461 | + if (isset($_GET['updated'])) { |
|
462 | + $context['profile_updated'] = $txt['profile_updated_own']; |
|
463 | + } |
|
454 | 464 | |
455 | 465 | // Set a few options for the menu. |
456 | 466 | $menuOptions = array( |
@@ -465,8 +475,9 @@ discard block |
||
465 | 475 | $profile_include_data = createMenu($profile_areas, $menuOptions); |
466 | 476 | |
467 | 477 | // No menu means no access. |
468 | - if (!$profile_include_data && (!$user_info['is_guest'] || validateSession())) |
|
469 | - fatal_lang_error('no_access', false); |
|
478 | + if (!$profile_include_data && (!$user_info['is_guest'] || validateSession())) { |
|
479 | + fatal_lang_error('no_access', false); |
|
480 | + } |
|
470 | 481 | |
471 | 482 | // Make a note of the Unique ID for this menu. |
472 | 483 | $context['profile_menu_id'] = $context['max_menu_id']; |
@@ -492,8 +503,9 @@ discard block |
||
492 | 503 | if ($current_area == $area_id) |
493 | 504 | { |
494 | 505 | // This can't happen - but is a security check. |
495 | - if ((isset($section['enabled']) && $section['enabled'] == false) || (isset($area['enabled']) && $area['enabled'] == false)) |
|
496 | - fatal_lang_error('no_access', false); |
|
506 | + if ((isset($section['enabled']) && $section['enabled'] == false) || (isset($area['enabled']) && $area['enabled'] == false)) { |
|
507 | + fatal_lang_error('no_access', false); |
|
508 | + } |
|
497 | 509 | |
498 | 510 | // Are we saving data in a valid area? |
499 | 511 | if (isset($area['sc']) && (isset($_REQUEST['save']) || $context['do_preview'])) |
@@ -512,12 +524,14 @@ discard block |
||
512 | 524 | } |
513 | 525 | |
514 | 526 | // Does this require session validating? |
515 | - if (!empty($area['validate']) || (isset($_REQUEST['save']) && !$context['user']['is_owner'])) |
|
516 | - $security_checks['validate'] = true; |
|
527 | + if (!empty($area['validate']) || (isset($_REQUEST['save']) && !$context['user']['is_owner'])) { |
|
528 | + $security_checks['validate'] = true; |
|
529 | + } |
|
517 | 530 | |
518 | 531 | // Permissions for good measure. |
519 | - if (!empty($profile_include_data['permission'])) |
|
520 | - $security_checks['permission'] = $profile_include_data['permission']; |
|
532 | + if (!empty($profile_include_data['permission'])) { |
|
533 | + $security_checks['permission'] = $profile_include_data['permission']; |
|
534 | + } |
|
521 | 535 | |
522 | 536 | // Either way got something. |
523 | 537 | $found_area = true; |
@@ -526,21 +540,26 @@ discard block |
||
526 | 540 | } |
527 | 541 | |
528 | 542 | // Oh dear, some serious security lapse is going on here... we'll put a stop to that! |
529 | - if (!$found_area) |
|
530 | - fatal_lang_error('no_access', false); |
|
543 | + if (!$found_area) { |
|
544 | + fatal_lang_error('no_access', false); |
|
545 | + } |
|
531 | 546 | |
532 | 547 | // Release this now. |
533 | 548 | unset($profile_areas); |
534 | 549 | |
535 | 550 | // Now the context is setup have we got any security checks to carry out additional to that above? |
536 | - if (isset($security_checks['session'])) |
|
537 | - checkSession($security_checks['session']); |
|
538 | - if (isset($security_checks['validate'])) |
|
539 | - validateSession(); |
|
540 | - if (isset($security_checks['validateToken'])) |
|
541 | - validateToken($token_name, $token_type); |
|
542 | - if (isset($security_checks['permission'])) |
|
543 | - isAllowedTo($security_checks['permission']); |
|
551 | + if (isset($security_checks['session'])) { |
|
552 | + checkSession($security_checks['session']); |
|
553 | + } |
|
554 | + if (isset($security_checks['validate'])) { |
|
555 | + validateSession(); |
|
556 | + } |
|
557 | + if (isset($security_checks['validateToken'])) { |
|
558 | + validateToken($token_name, $token_type); |
|
559 | + } |
|
560 | + if (isset($security_checks['permission'])) { |
|
561 | + isAllowedTo($security_checks['permission']); |
|
562 | + } |
|
544 | 563 | |
545 | 564 | // Create a token if needed. |
546 | 565 | if (isset($security_checks['needsToken']) || isset($security_checks['validateToken'])) |
@@ -550,8 +569,9 @@ discard block |
||
550 | 569 | } |
551 | 570 | |
552 | 571 | // File to include? |
553 | - if (isset($profile_include_data['file'])) |
|
554 | - require_once($sourcedir . '/' . $profile_include_data['file']); |
|
572 | + if (isset($profile_include_data['file'])) { |
|
573 | + require_once($sourcedir . '/' . $profile_include_data['file']); |
|
574 | + } |
|
555 | 575 | |
556 | 576 | // Build the link tree. |
557 | 577 | $context['linktree'][] = array( |
@@ -559,17 +579,19 @@ discard block |
||
559 | 579 | 'name' => sprintf($txt['profile_of_username'], $context['member']['name']), |
560 | 580 | ); |
561 | 581 | |
562 | - if (!empty($profile_include_data['label'])) |
|
563 | - $context['linktree'][] = array( |
|
582 | + if (!empty($profile_include_data['label'])) { |
|
583 | + $context['linktree'][] = array( |
|
564 | 584 | 'url' => $scripturl . '?action=profile' . ($memID != $user_info['id'] ? ';u=' . $memID : '') . ';area=' . $profile_include_data['current_area'], |
565 | 585 | 'name' => $profile_include_data['label'], |
566 | 586 | ); |
587 | + } |
|
567 | 588 | |
568 | - if (!empty($profile_include_data['current_subsection']) && $profile_include_data['subsections'][$profile_include_data['current_subsection']][0] != $profile_include_data['label']) |
|
569 | - $context['linktree'][] = array( |
|
589 | + if (!empty($profile_include_data['current_subsection']) && $profile_include_data['subsections'][$profile_include_data['current_subsection']][0] != $profile_include_data['label']) { |
|
590 | + $context['linktree'][] = array( |
|
570 | 591 | 'url' => $scripturl . '?action=profile' . ($memID != $user_info['id'] ? ';u=' . $memID : '') . ';area=' . $profile_include_data['current_area'] . ';sa=' . $profile_include_data['current_subsection'], |
571 | 592 | 'name' => $profile_include_data['subsections'][$profile_include_data['current_subsection']][0], |
572 | 593 | ); |
594 | + } |
|
573 | 595 | |
574 | 596 | // Set the template for this area and add the profile layer. |
575 | 597 | $context['sub_template'] = $profile_include_data['function']; |
@@ -595,12 +617,14 @@ discard block |
||
595 | 617 | if ($check_password) |
596 | 618 | { |
597 | 619 | // Check to ensure we're forcing SSL for authentication |
598 | - if (!empty($modSettings['force_ssl']) && empty($maintenance) && (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != 'on')) |
|
599 | - fatal_lang_error('login_ssl_required'); |
|
620 | + if (!empty($modSettings['force_ssl']) && empty($maintenance) && (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != 'on')) { |
|
621 | + fatal_lang_error('login_ssl_required'); |
|
622 | + } |
|
600 | 623 | |
601 | 624 | // You didn't even enter a password! |
602 | - if (trim($_POST['oldpasswrd']) == '') |
|
603 | - $post_errors[] = 'no_password'; |
|
625 | + if (trim($_POST['oldpasswrd']) == '') { |
|
626 | + $post_errors[] = 'no_password'; |
|
627 | + } |
|
604 | 628 | |
605 | 629 | // Since the password got modified due to all the $_POST cleaning, lets undo it so we can get the correct password |
606 | 630 | $_POST['oldpasswrd'] = un_htmlspecialchars($_POST['oldpasswrd']); |
@@ -609,42 +633,43 @@ discard block |
||
609 | 633 | $good_password = in_array(true, call_integration_hook('integrate_verify_password', array($cur_profile['member_name'], $_POST['oldpasswrd'], false)), true); |
610 | 634 | |
611 | 635 | // Bad password!!! |
612 | - if (!$good_password && !hash_verify_password($user_profile[$memID]['member_name'], un_htmlspecialchars(stripslashes($_POST['oldpasswrd'])), $user_info['passwd'])) |
|
613 | - $post_errors[] = 'bad_password'; |
|
636 | + if (!$good_password && !hash_verify_password($user_profile[$memID]['member_name'], un_htmlspecialchars(stripslashes($_POST['oldpasswrd'])), $user_info['passwd'])) { |
|
637 | + $post_errors[] = 'bad_password'; |
|
638 | + } |
|
614 | 639 | |
615 | 640 | // Warn other elements not to jump the gun and do custom changes! |
616 | - if (in_array('bad_password', $post_errors)) |
|
617 | - $context['password_auth_failed'] = true; |
|
641 | + if (in_array('bad_password', $post_errors)) { |
|
642 | + $context['password_auth_failed'] = true; |
|
643 | + } |
|
618 | 644 | } |
619 | 645 | |
620 | 646 | // Change the IP address in the database. |
621 | - if ($context['user']['is_owner']) |
|
622 | - $profile_vars['member_ip'] = $user_info['ip']; |
|
647 | + if ($context['user']['is_owner']) { |
|
648 | + $profile_vars['member_ip'] = $user_info['ip']; |
|
649 | + } |
|
623 | 650 | |
624 | 651 | // Now call the sub-action function... |
625 | 652 | if ($current_area == 'activateaccount') |
626 | 653 | { |
627 | - if (empty($post_errors)) |
|
628 | - activateAccount($memID); |
|
629 | - } |
|
630 | - elseif ($current_area == 'deleteaccount') |
|
654 | + if (empty($post_errors)) { |
|
655 | + activateAccount($memID); |
|
656 | + } |
|
657 | + } elseif ($current_area == 'deleteaccount') |
|
631 | 658 | { |
632 | 659 | if (empty($post_errors)) |
633 | 660 | { |
634 | 661 | deleteAccount2($memID); |
635 | 662 | redirectexit(); |
636 | 663 | } |
637 | - } |
|
638 | - elseif ($current_area == 'groupmembership' && empty($post_errors)) |
|
664 | + } elseif ($current_area == 'groupmembership' && empty($post_errors)) |
|
639 | 665 | { |
640 | 666 | $msg = groupMembership2($profile_vars, $post_errors, $memID); |
641 | 667 | |
642 | 668 | // Whatever we've done, we have nothing else to do here... |
643 | 669 | redirectexit('action=profile' . ($context['user']['is_owner'] ? '' : ';u=' . $memID) . ';area=groupmembership' . (!empty($msg) ? ';msg=' . $msg : '')); |
644 | - } |
|
645 | - elseif (in_array($current_area, array('account', 'forumprofile', 'theme'))) |
|
646 | - saveProfileFields(); |
|
647 | - else |
|
670 | + } elseif (in_array($current_area, array('account', 'forumprofile', 'theme'))) { |
|
671 | + saveProfileFields(); |
|
672 | + } else |
|
648 | 673 | { |
649 | 674 | $force_redirect = true; |
650 | 675 | // Ensure we include this. |
@@ -660,34 +685,36 @@ discard block |
||
660 | 685 | // Load the language file so we can give a nice explanation of the errors. |
661 | 686 | loadLanguage('Errors'); |
662 | 687 | $context['post_errors'] = $post_errors; |
663 | - } |
|
664 | - elseif (!empty($profile_vars)) |
|
688 | + } elseif (!empty($profile_vars)) |
|
665 | 689 | { |
666 | 690 | // If we've changed the password, notify any integration that may be listening in. |
667 | - if (isset($profile_vars['passwd'])) |
|
668 | - call_integration_hook('integrate_reset_pass', array($cur_profile['member_name'], $cur_profile['member_name'], $_POST['passwrd2'])); |
|
691 | + if (isset($profile_vars['passwd'])) { |
|
692 | + call_integration_hook('integrate_reset_pass', array($cur_profile['member_name'], $cur_profile['member_name'], $_POST['passwrd2'])); |
|
693 | + } |
|
669 | 694 | |
670 | 695 | updateMemberData($memID, $profile_vars); |
671 | 696 | |
672 | 697 | // What if this is the newest member? |
673 | - if ($modSettings['latestMember'] == $memID) |
|
674 | - updateStats('member'); |
|
675 | - elseif (isset($profile_vars['real_name'])) |
|
676 | - updateSettings(array('memberlist_updated' => time())); |
|
698 | + if ($modSettings['latestMember'] == $memID) { |
|
699 | + updateStats('member'); |
|
700 | + } elseif (isset($profile_vars['real_name'])) { |
|
701 | + updateSettings(array('memberlist_updated' => time())); |
|
702 | + } |
|
677 | 703 | |
678 | 704 | // If the member changed his/her birthdate, update calendar statistics. |
679 | - if (isset($profile_vars['birthdate']) || isset($profile_vars['real_name'])) |
|
680 | - updateSettings(array( |
|
705 | + if (isset($profile_vars['birthdate']) || isset($profile_vars['real_name'])) { |
|
706 | + updateSettings(array( |
|
681 | 707 | 'calendar_updated' => time(), |
682 | 708 | )); |
709 | + } |
|
683 | 710 | |
684 | 711 | // Anything worth logging? |
685 | 712 | if (!empty($context['log_changes']) && !empty($modSettings['modlog_enabled'])) |
686 | 713 | { |
687 | 714 | $log_changes = array(); |
688 | 715 | require_once($sourcedir . '/Logging.php'); |
689 | - foreach ($context['log_changes'] as $k => $v) |
|
690 | - $log_changes[] = array( |
|
716 | + foreach ($context['log_changes'] as $k => $v) { |
|
717 | + $log_changes[] = array( |
|
691 | 718 | 'action' => $k, |
692 | 719 | 'log_type' => 'user', |
693 | 720 | 'extra' => array_merge($v, array( |
@@ -695,14 +722,16 @@ discard block |
||
695 | 722 | 'member_affected' => $memID, |
696 | 723 | )), |
697 | 724 | ); |
725 | + } |
|
698 | 726 | |
699 | 727 | logActions($log_changes); |
700 | 728 | } |
701 | 729 | |
702 | 730 | // Have we got any post save functions to execute? |
703 | - if (!empty($context['profile_execute_on_save'])) |
|
704 | - foreach ($context['profile_execute_on_save'] as $saveFunc) |
|
731 | + if (!empty($context['profile_execute_on_save'])) { |
|
732 | + foreach ($context['profile_execute_on_save'] as $saveFunc) |
|
705 | 733 | $saveFunc(); |
734 | + } |
|
706 | 735 | |
707 | 736 | // Let them know it worked! |
708 | 737 | $context['profile_updated'] = $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $cur_profile['member_name']); |
@@ -716,27 +745,31 @@ discard block |
||
716 | 745 | if (!empty($post_errors)) |
717 | 746 | { |
718 | 747 | // Set all the errors so the template knows what went wrong. |
719 | - foreach ($post_errors as $error_type) |
|
720 | - $context['modify_error'][$error_type] = true; |
|
748 | + foreach ($post_errors as $error_type) { |
|
749 | + $context['modify_error'][$error_type] = true; |
|
750 | + } |
|
721 | 751 | } |
722 | 752 | // If it's you then we should redirect upon save. |
723 | - elseif (!empty($profile_vars) && $context['user']['is_owner'] && !$context['do_preview']) |
|
724 | - redirectexit('action=profile;area=' . $current_area . (!empty($current_sa) ? ';sa=' . $current_sa : '') . ';updated'); |
|
725 | - elseif (!empty($force_redirect)) |
|
726 | - redirectexit('action=profile' . ($context['user']['is_owner'] ? '' : ';u=' . $memID) . ';area=' . $current_area); |
|
753 | + elseif (!empty($profile_vars) && $context['user']['is_owner'] && !$context['do_preview']) { |
|
754 | + redirectexit('action=profile;area=' . $current_area . (!empty($current_sa) ? ';sa=' . $current_sa : '') . ';updated'); |
|
755 | + } elseif (!empty($force_redirect)) { |
|
756 | + redirectexit('action=profile' . ($context['user']['is_owner'] ? '' : ';u=' . $memID) . ';area=' . $current_area); |
|
757 | + } |
|
727 | 758 | |
728 | 759 | |
729 | 760 | // Get the right callable. |
730 | 761 | $call = call_helper($profile_include_data['function'], true); |
731 | 762 | |
732 | 763 | // Is it valid? |
733 | - if (!empty($call)) |
|
734 | - call_user_func($call, $memID); |
|
764 | + if (!empty($call)) { |
|
765 | + call_user_func($call, $memID); |
|
766 | + } |
|
735 | 767 | |
736 | 768 | // Set the page title if it's not already set... |
737 | - if (!isset($context['page_title'])) |
|
738 | - $context['page_title'] = $txt['profile'] . (isset($txt[$current_area]) ? ' - ' . $txt[$current_area] : ''); |
|
739 | -} |
|
769 | + if (!isset($context['page_title'])) { |
|
770 | + $context['page_title'] = $txt['profile'] . (isset($txt[$current_area]) ? ' - ' . $txt[$current_area] : ''); |
|
771 | + } |
|
772 | + } |
|
740 | 773 | |
741 | 774 | /** |
742 | 775 | * Set up the requirements for the profile popup - the area that is shown as the popup menu for the current user. |
@@ -859,16 +892,18 @@ discard block |
||
859 | 892 | if (!allowedTo('admin_forum') && $area != 'register') |
860 | 893 | { |
861 | 894 | // If it's the owner they can see two types of private fields, regardless. |
862 | - if ($memID == $user_info['id']) |
|
863 | - $where .= $area == 'summary' ? ' AND private < 3' : ' AND (private = 0 OR private = 2)'; |
|
864 | - else |
|
865 | - $where .= $area == 'summary' ? ' AND private < 2' : ' AND private = 0'; |
|
895 | + if ($memID == $user_info['id']) { |
|
896 | + $where .= $area == 'summary' ? ' AND private < 3' : ' AND (private = 0 OR private = 2)'; |
|
897 | + } else { |
|
898 | + $where .= $area == 'summary' ? ' AND private < 2' : ' AND private = 0'; |
|
899 | + } |
|
866 | 900 | } |
867 | 901 | |
868 | - if ($area == 'register') |
|
869 | - $where .= ' AND show_reg != 0'; |
|
870 | - elseif ($area != 'summary') |
|
871 | - $where .= ' AND show_profile = {string:area}'; |
|
902 | + if ($area == 'register') { |
|
903 | + $where .= ' AND show_reg != 0'; |
|
904 | + } elseif ($area != 'summary') { |
|
905 | + $where .= ' AND show_profile = {string:area}'; |
|
906 | + } |
|
872 | 907 | |
873 | 908 | // Load all the relevant fields - and data. |
874 | 909 | $request = $smcFunc['db_query']('', ' |
@@ -894,13 +929,15 @@ discard block |
||
894 | 929 | if (isset($_POST['customfield']) && isset($_POST['customfield'][$row['col_name']])) |
895 | 930 | { |
896 | 931 | $value = $smcFunc['htmlspecialchars']($_POST['customfield'][$row['col_name']]); |
897 | - if (in_array($row['field_type'], array('select', 'radio'))) |
|
898 | - $value = ($options = explode(',', $row['field_options'])) && isset($options[$value]) ? $options[$value] : ''; |
|
932 | + if (in_array($row['field_type'], array('select', 'radio'))) { |
|
933 | + $value = ($options = explode(',', $row['field_options'])) && isset($options[$value]) ? $options[$value] : ''; |
|
934 | + } |
|
899 | 935 | } |
900 | 936 | |
901 | 937 | // Don't show the "disabled" option for the "gender" field if we are on the "summary" area. |
902 | - if ($area == 'summary' && $row['col_name'] == 'cust_gender' && $value == 'Disabled') |
|
903 | - continue; |
|
938 | + if ($area == 'summary' && $row['col_name'] == 'cust_gender' && $value == 'Disabled') { |
|
939 | + continue; |
|
940 | + } |
|
904 | 941 | |
905 | 942 | // HTML for the input form. |
906 | 943 | $output_html = $value; |
@@ -909,8 +946,7 @@ discard block |
||
909 | 946 | $true = (!$exists && $row['default_value']) || $value; |
910 | 947 | $input_html = '<input type="checkbox" name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"' . ($true ? ' checked' : '') . '>'; |
911 | 948 | $output_html = $true ? $txt['yes'] : $txt['no']; |
912 | - } |
|
913 | - elseif ($row['field_type'] == 'select') |
|
949 | + } elseif ($row['field_type'] == 'select') |
|
914 | 950 | { |
915 | 951 | $input_html = '<select name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"><option value="-1"></option>'; |
916 | 952 | $options = explode(',', $row['field_options']); |
@@ -918,13 +954,13 @@ discard block |
||
918 | 954 | { |
919 | 955 | $true = (!$exists && $row['default_value'] == $v) || $value == $v; |
920 | 956 | $input_html .= '<option value="' . $k . '"' . ($true ? ' selected' : '') . '>' . $v . '</option>'; |
921 | - if ($true) |
|
922 | - $output_html = $v; |
|
957 | + if ($true) { |
|
958 | + $output_html = $v; |
|
959 | + } |
|
923 | 960 | } |
924 | 961 | |
925 | 962 | $input_html .= '</select>'; |
926 | - } |
|
927 | - elseif ($row['field_type'] == 'radio') |
|
963 | + } elseif ($row['field_type'] == 'radio') |
|
928 | 964 | { |
929 | 965 | $input_html = '<fieldset>'; |
930 | 966 | $options = explode(',', $row['field_options']); |
@@ -932,36 +968,37 @@ discard block |
||
932 | 968 | { |
933 | 969 | $true = (!$exists && $row['default_value'] == $v) || $value == $v; |
934 | 970 | $input_html .= '<label for="customfield_' . $row['col_name'] . '_' . $k . '"><input type="radio" name="customfield[' . $row['col_name'] . ']" id="customfield_' . $row['col_name'] . '_' . $k . '" value="' . $k . '"' . ($true ? ' checked' : '') . '>' . $v . '</label><br>'; |
935 | - if ($true) |
|
936 | - $output_html = $v; |
|
971 | + if ($true) { |
|
972 | + $output_html = $v; |
|
973 | + } |
|
937 | 974 | } |
938 | 975 | $input_html .= '</fieldset>'; |
939 | - } |
|
940 | - elseif ($row['field_type'] == 'text') |
|
976 | + } elseif ($row['field_type'] == 'text') |
|
941 | 977 | { |
942 | 978 | $input_html = '<input type="text" name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"' . ($row['field_length'] != 0 ? ' maxlength="' . $row['field_length'] . '"' : '') . ' size="' . ($row['field_length'] == 0 || $row['field_length'] >= 50 ? 50 : ($row['field_length'] > 30 ? 30 : ($row['field_length'] > 10 ? 20 : 10))) . '" value="' . un_htmlspecialchars($value) . '"' . ($row['show_reg'] == 2 ? ' required' : '') . '>'; |
943 | - } |
|
944 | - else |
|
979 | + } else |
|
945 | 980 | { |
946 | 981 | @list ($rows, $cols) = @explode(',', $row['default_value']); |
947 | 982 | $input_html = '<textarea name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"' . (!empty($rows) ? ' rows="' . $rows . '"' : '') . (!empty($cols) ? ' cols="' . $cols . '"' : '') . ($row['show_reg'] == 2 ? ' required' : '') . '>' . un_htmlspecialchars($value) . '</textarea>'; |
948 | 983 | } |
949 | 984 | |
950 | 985 | // Parse BBCode |
951 | - if ($row['bbc']) |
|
952 | - $output_html = parse_bbc($output_html); |
|
953 | - elseif ($row['field_type'] == 'textarea') |
|
954 | - // Allow for newlines at least |
|
986 | + if ($row['bbc']) { |
|
987 | + $output_html = parse_bbc($output_html); |
|
988 | + } elseif ($row['field_type'] == 'textarea') { |
|
989 | + // Allow for newlines at least |
|
955 | 990 | $output_html = strtr($output_html, array("\n" => '<br>')); |
991 | + } |
|
956 | 992 | |
957 | 993 | // Enclosing the user input within some other text? |
958 | - if (!empty($row['enclose']) && !empty($output_html)) |
|
959 | - $output_html = strtr($row['enclose'], array( |
|
994 | + if (!empty($row['enclose']) && !empty($output_html)) { |
|
995 | + $output_html = strtr($row['enclose'], array( |
|
960 | 996 | '{SCRIPTURL}' => $scripturl, |
961 | 997 | '{IMAGES_URL}' => $settings['images_url'], |
962 | 998 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
963 | 999 | '{INPUT}' => un_htmlspecialchars($output_html), |
964 | 1000 | )); |
1001 | + } |
|
965 | 1002 | |
966 | 1003 | $context['custom_fields'][] = array( |
967 | 1004 | 'name' => $row['field_name'], |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Get all birthdays within the given time range. |
@@ -60,8 +61,7 @@ discard block |
||
60 | 61 | 'max_year' => $year_high, |
61 | 62 | ) |
62 | 63 | ); |
63 | - } |
|
64 | - else |
|
64 | + } else |
|
65 | 65 | { |
66 | 66 | $result = $smcFunc['db_query']('birthday_array', ' |
67 | 67 | SELECT id_member, real_name, YEAR(birthdate) AS birth_year, birthdate |
@@ -91,10 +91,11 @@ discard block |
||
91 | 91 | $bday = array(); |
92 | 92 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
93 | 93 | { |
94 | - if ($year_low != $year_high) |
|
95 | - $age_year = substr($row['birthdate'], 5) < substr($high_date, 5) ? $year_high : $year_low; |
|
96 | - else |
|
97 | - $age_year = $year_low; |
|
94 | + if ($year_low != $year_high) { |
|
95 | + $age_year = substr($row['birthdate'], 5) < substr($high_date, 5) ? $year_high : $year_low; |
|
96 | + } else { |
|
97 | + $age_year = $year_low; |
|
98 | + } |
|
98 | 99 | |
99 | 100 | $bday[$age_year . substr($row['birthdate'], 4)][] = array( |
100 | 101 | 'id' => $row['id_member'], |
@@ -108,8 +109,9 @@ discard block |
||
108 | 109 | ksort($bday); |
109 | 110 | |
110 | 111 | // Set is_last, so the themes know when to stop placing separators. |
111 | - foreach ($bday as $mday => $array) |
|
112 | - $bday[$mday][count($array) - 1]['is_last'] = true; |
|
112 | + foreach ($bday as $mday => $array) { |
|
113 | + $bday[$mday][count($array) - 1]['is_last'] = true; |
|
114 | + } |
|
113 | 115 | |
114 | 116 | return $bday; |
115 | 117 | } |
@@ -133,8 +135,9 @@ discard block |
||
133 | 135 | static $timezone_array = array(); |
134 | 136 | require_once($sourcedir . '/Subs.php'); |
135 | 137 | |
136 | - if (empty($timezone_array['default'])) |
|
137 | - $timezone_array['default'] = timezone_open(date_default_timezone_get()); |
|
138 | + if (empty($timezone_array['default'])) { |
|
139 | + $timezone_array['default'] = timezone_open(date_default_timezone_get()); |
|
140 | + } |
|
138 | 141 | |
139 | 142 | $low_object = date_create($low_date); |
140 | 143 | $high_object = date_create($high_date); |
@@ -161,8 +164,9 @@ discard block |
||
161 | 164 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
162 | 165 | { |
163 | 166 | // If the attached topic is not approved then for the moment pretend it doesn't exist |
164 | - if (!empty($row['id_first_msg']) && $modSettings['postmod_active'] && !$row['approved']) |
|
165 | - continue; |
|
167 | + if (!empty($row['id_first_msg']) && $modSettings['postmod_active'] && !$row['approved']) { |
|
168 | + continue; |
|
169 | + } |
|
166 | 170 | |
167 | 171 | // Force a censor of the title - as often these are used by others. |
168 | 172 | censorText($row['title'], $use_permissions ? false : true); |
@@ -170,12 +174,14 @@ discard block |
||
170 | 174 | // Get the various time and date properties for this event |
171 | 175 | list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row); |
172 | 176 | |
173 | - if (empty($timezone_array[$tz])) |
|
174 | - $timezone_array[$tz] = timezone_open($tz); |
|
177 | + if (empty($timezone_array[$tz])) { |
|
178 | + $timezone_array[$tz] = timezone_open($tz); |
|
179 | + } |
|
175 | 180 | |
176 | 181 | // Sanity check |
177 | - if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) |
|
178 | - continue; |
|
182 | + if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) { |
|
183 | + continue; |
|
184 | + } |
|
179 | 185 | |
180 | 186 | // Get set up for the loop |
181 | 187 | $start_object = date_create($row['start_date'] . (!$allday ? ' ' . $row['start_time'] : ''), $timezone_array[$tz]); |
@@ -239,8 +245,8 @@ discard block |
||
239 | 245 | ); |
240 | 246 | |
241 | 247 | // If we're using permissions (calendar pages?) then just ouput normal contextual style information. |
242 | - if ($use_permissions) |
|
243 | - $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
248 | + if ($use_permissions) { |
|
249 | + $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
244 | 250 | 'href' => $row['id_board'] == 0 ? '' : $scripturl . '?topic=' . $row['id_topic'] . '.0', |
245 | 251 | 'link' => $row['id_board'] == 0 ? $row['title'] : '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['title'] . '</a>', |
246 | 252 | 'can_edit' => allowedTo('calendar_edit_any') || ($row['id_member'] == $user_info['id'] && allowedTo('calendar_edit_own')), |
@@ -248,9 +254,10 @@ discard block |
||
248 | 254 | 'can_export' => !empty($modSettings['cal_export']) ? true : false, |
249 | 255 | 'export_href' => $scripturl . '?action=calendar;sa=ical;eventid=' . $row['id_event'] . ';' . $context['session_var'] . '=' . $context['session_id'], |
250 | 256 | )); |
257 | + } |
|
251 | 258 | // Otherwise, this is going to be cached and the VIEWER'S permissions should apply... just put together some info. |
252 | - else |
|
253 | - $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
259 | + else { |
|
260 | + $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
254 | 261 | 'href' => $row['id_topic'] == 0 ? '' : $scripturl . '?topic=' . $row['id_topic'] . '.0', |
255 | 262 | 'link' => $row['id_topic'] == 0 ? $row['title'] : '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['title'] . '</a>', |
256 | 263 | 'can_edit' => false, |
@@ -260,6 +267,7 @@ discard block |
||
260 | 267 | 'poster' => $row['id_member'], |
261 | 268 | 'allowed_groups' => explode(',', $row['member_groups']), |
262 | 269 | )); |
270 | + } |
|
263 | 271 | |
264 | 272 | date_add($cal_date, date_interval_create_from_date_string('1 day')); |
265 | 273 | } |
@@ -269,8 +277,9 @@ discard block |
||
269 | 277 | // If we're doing normal contextual data, go through and make things clear to the templates ;). |
270 | 278 | if ($use_permissions) |
271 | 279 | { |
272 | - foreach ($events as $mday => $array) |
|
273 | - $events[$mday][count($array) - 1]['is_last'] = true; |
|
280 | + foreach ($events as $mday => $array) { |
|
281 | + $events[$mday][count($array) - 1]['is_last'] = true; |
|
282 | + } |
|
274 | 283 | } |
275 | 284 | |
276 | 285 | ksort($events); |
@@ -290,11 +299,12 @@ discard block |
||
290 | 299 | global $smcFunc; |
291 | 300 | |
292 | 301 | // Get the lowest and highest dates for "all years". |
293 | - if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) |
|
294 | - $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_dec} |
|
302 | + if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) { |
|
303 | + $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_dec} |
|
295 | 304 | OR event_date BETWEEN {date:all_year_jan} AND {date:all_year_high}'; |
296 | - else |
|
297 | - $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_high}'; |
|
305 | + } else { |
|
306 | + $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_high}'; |
|
307 | + } |
|
298 | 308 | |
299 | 309 | // Find some holidays... ;). |
300 | 310 | $result = $smcFunc['db_query']('', ' |
@@ -314,10 +324,11 @@ discard block |
||
314 | 324 | $holidays = array(); |
315 | 325 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
316 | 326 | { |
317 | - if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) |
|
318 | - $event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4); |
|
319 | - else |
|
320 | - $event_year = substr($low_date, 0, 4); |
|
327 | + if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) { |
|
328 | + $event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4); |
|
329 | + } else { |
|
330 | + $event_year = substr($low_date, 0, 4); |
|
331 | + } |
|
321 | 332 | |
322 | 333 | $holidays[$event_year . substr($row['event_date'], 4)][] = $row['title']; |
323 | 334 | } |
@@ -343,10 +354,12 @@ discard block |
||
343 | 354 | isAllowedTo('calendar_post'); |
344 | 355 | |
345 | 356 | // No board? No topic?!? |
346 | - if (empty($board)) |
|
347 | - fatal_lang_error('missing_board_id', false); |
|
348 | - if (empty($topic)) |
|
349 | - fatal_lang_error('missing_topic_id', false); |
|
357 | + if (empty($board)) { |
|
358 | + fatal_lang_error('missing_board_id', false); |
|
359 | + } |
|
360 | + if (empty($topic)) { |
|
361 | + fatal_lang_error('missing_topic_id', false); |
|
362 | + } |
|
350 | 363 | |
351 | 364 | // Administrator, Moderator, or owner. Period. |
352 | 365 | if (!allowedTo('admin_forum') && !allowedTo('moderate_board')) |
@@ -364,12 +377,14 @@ discard block |
||
364 | 377 | if ($row = $smcFunc['db_fetch_assoc']($result)) |
365 | 378 | { |
366 | 379 | // Not the owner of the topic. |
367 | - if ($row['id_member_started'] != $user_info['id']) |
|
368 | - fatal_lang_error('not_your_topic', 'user'); |
|
380 | + if ($row['id_member_started'] != $user_info['id']) { |
|
381 | + fatal_lang_error('not_your_topic', 'user'); |
|
382 | + } |
|
369 | 383 | } |
370 | 384 | // Topic/Board doesn't exist..... |
371 | - else |
|
372 | - fatal_lang_error('calendar_no_topic', 'general'); |
|
385 | + else { |
|
386 | + fatal_lang_error('calendar_no_topic', 'general'); |
|
387 | + } |
|
373 | 388 | $smcFunc['db_free_result']($result); |
374 | 389 | } |
375 | 390 | } |
@@ -457,14 +472,16 @@ discard block |
||
457 | 472 | if (!empty($calendarOptions['start_day'])) |
458 | 473 | { |
459 | 474 | $nShift -= $calendarOptions['start_day']; |
460 | - if ($nShift < 0) |
|
461 | - $nShift = 7 + $nShift; |
|
475 | + if ($nShift < 0) { |
|
476 | + $nShift = 7 + $nShift; |
|
477 | + } |
|
462 | 478 | } |
463 | 479 | |
464 | 480 | // Number of rows required to fit the month. |
465 | 481 | $nRows = floor(($month_info['last_day']['day_of_month'] + $nShift) / 7); |
466 | - if (($month_info['last_day']['day_of_month'] + $nShift) % 7) |
|
467 | - $nRows++; |
|
482 | + if (($month_info['last_day']['day_of_month'] + $nShift) % 7) { |
|
483 | + $nRows++; |
|
484 | + } |
|
468 | 485 | |
469 | 486 | // Fetch the arrays for birthdays, posted events, and holidays. |
470 | 487 | $bday = $calendarOptions['show_birthdays'] ? getBirthdayRange($month_info['first_day']['date'], $month_info['last_day']['date']) : array(); |
@@ -477,8 +494,9 @@ discard block |
||
477 | 494 | { |
478 | 495 | $calendarGrid['week_days'][] = $count; |
479 | 496 | $count++; |
480 | - if ($count == 7) |
|
481 | - $count = 0; |
|
497 | + if ($count == 7) { |
|
498 | + $count = 0; |
|
499 | + } |
|
482 | 500 | } |
483 | 501 | |
484 | 502 | // Iterate through each week. |
@@ -495,8 +513,9 @@ discard block |
||
495 | 513 | { |
496 | 514 | $nDay = ($nRow * 7) + $nCol - $nShift + 1; |
497 | 515 | |
498 | - if ($nDay < 1 || $nDay > $month_info['last_day']['day_of_month']) |
|
499 | - $nDay = 0; |
|
516 | + if ($nDay < 1 || $nDay > $month_info['last_day']['day_of_month']) { |
|
517 | + $nDay = 0; |
|
518 | + } |
|
500 | 519 | |
501 | 520 | $date = sprintf('%04d-%02d-%02d', $year, $month, $nDay); |
502 | 521 | |
@@ -514,8 +533,9 @@ discard block |
||
514 | 533 | } |
515 | 534 | |
516 | 535 | // What is the last day of the month? |
517 | - if ($is_previous === true) |
|
518 | - $calendarGrid['last_of_month'] = $month_info['last_day']['day_of_month']; |
|
536 | + if ($is_previous === true) { |
|
537 | + $calendarGrid['last_of_month'] = $month_info['last_day']['day_of_month']; |
|
538 | + } |
|
519 | 539 | |
520 | 540 | // We'll use the shift in the template. |
521 | 541 | $calendarGrid['shift'] = $nShift; |
@@ -549,8 +569,9 @@ discard block |
||
549 | 569 | { |
550 | 570 | // Here we offset accordingly to get things to the real start of a week. |
551 | 571 | $date_diff = $day_of_week - $calendarOptions['start_day']; |
552 | - if ($date_diff < 0) |
|
553 | - $date_diff += 7; |
|
572 | + if ($date_diff < 0) { |
|
573 | + $date_diff += 7; |
|
574 | + } |
|
554 | 575 | $new_timestamp = mktime(0, 0, 0, $month, $day, $year) - $date_diff * 86400; |
555 | 576 | $day = (int) strftime('%d', $new_timestamp); |
556 | 577 | $month = (int) strftime('%m', $new_timestamp); |
@@ -680,18 +701,20 @@ discard block |
||
680 | 701 | { |
681 | 702 | foreach ($date_events as $event_key => $event_val) |
682 | 703 | { |
683 | - if (in_array($event_val['id'], $temp)) |
|
684 | - unset($calendarGrid['events'][$date][$event_key]); |
|
685 | - else |
|
686 | - $temp[] = $event_val['id']; |
|
704 | + if (in_array($event_val['id'], $temp)) { |
|
705 | + unset($calendarGrid['events'][$date][$event_key]); |
|
706 | + } else { |
|
707 | + $temp[] = $event_val['id']; |
|
708 | + } |
|
687 | 709 | } |
688 | 710 | } |
689 | 711 | |
690 | 712 | // Give birthdays and holidays a friendly format, without the year |
691 | - if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
692 | - $date_format = '%b %d'; |
|
693 | - else |
|
694 | - $date_format = str_replace(array('%Y', '%y', '%G', '%g', '%C', '%c', '%D'), array('', '', '', '', '', '%b %d', '%m/%d'), $matches[0]); |
|
713 | + if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
714 | + $date_format = '%b %d'; |
|
715 | + } else { |
|
716 | + $date_format = str_replace(array('%Y', '%y', '%G', '%g', '%C', '%c', '%D'), array('', '', '', '', '', '%b %d', '%m/%d'), $matches[0]); |
|
717 | + } |
|
695 | 718 | |
696 | 719 | foreach (array('birthdays', 'holidays') as $type) |
697 | 720 | { |
@@ -790,8 +813,9 @@ discard block |
||
790 | 813 | // Holidays between now and now + days. |
791 | 814 | for ($i = $now; $i < $now + $days_for_index; $i += 86400) |
792 | 815 | { |
793 | - if (isset($cached_data['holidays'][strftime('%Y-%m-%d', $i)])) |
|
794 | - $return_data['calendar_holidays'] = array_merge($return_data['calendar_holidays'], $cached_data['holidays'][strftime('%Y-%m-%d', $i)]); |
|
816 | + if (isset($cached_data['holidays'][strftime('%Y-%m-%d', $i)])) { |
|
817 | + $return_data['calendar_holidays'] = array_merge($return_data['calendar_holidays'], $cached_data['holidays'][strftime('%Y-%m-%d', $i)]); |
|
818 | + } |
|
795 | 819 | } |
796 | 820 | } |
797 | 821 | |
@@ -803,8 +827,9 @@ discard block |
||
803 | 827 | $loop_date = strftime('%Y-%m-%d', $i); |
804 | 828 | if (isset($cached_data['birthdays'][$loop_date])) |
805 | 829 | { |
806 | - foreach ($cached_data['birthdays'][$loop_date] as $index => $dummy) |
|
807 | - $cached_data['birthdays'][strftime('%Y-%m-%d', $i)][$index]['is_today'] = $loop_date === $today['date']; |
|
830 | + foreach ($cached_data['birthdays'][$loop_date] as $index => $dummy) { |
|
831 | + $cached_data['birthdays'][strftime('%Y-%m-%d', $i)][$index]['is_today'] = $loop_date === $today['date']; |
|
832 | + } |
|
808 | 833 | $return_data['calendar_birthdays'] = array_merge($return_data['calendar_birthdays'], $cached_data['birthdays'][$loop_date]); |
809 | 834 | } |
810 | 835 | } |
@@ -819,8 +844,9 @@ discard block |
||
819 | 844 | $loop_date = strftime('%Y-%m-%d', $i); |
820 | 845 | |
821 | 846 | // No events today? Check the next day. |
822 | - if (empty($cached_data['events'][$loop_date])) |
|
823 | - continue; |
|
847 | + if (empty($cached_data['events'][$loop_date])) { |
|
848 | + continue; |
|
849 | + } |
|
824 | 850 | |
825 | 851 | // Loop through all events to add a few last-minute values. |
826 | 852 | foreach ($cached_data['events'][$loop_date] as $ev => $event) |
@@ -833,9 +859,9 @@ discard block |
||
833 | 859 | { |
834 | 860 | unset($cached_data['events'][$loop_date][$ev]); |
835 | 861 | continue; |
862 | + } else { |
|
863 | + $duplicates[$this_event['topic'] . $this_event['title']] = true; |
|
836 | 864 | } |
837 | - else |
|
838 | - $duplicates[$this_event['topic'] . $this_event['title']] = true; |
|
839 | 865 | |
840 | 866 | // Might be set to true afterwards, depending on the permissions. |
841 | 867 | $this_event['can_edit'] = false; |
@@ -843,16 +869,19 @@ discard block |
||
843 | 869 | $this_event['date'] = $loop_date; |
844 | 870 | } |
845 | 871 | |
846 | - if (!empty($cached_data['events'][$loop_date])) |
|
847 | - $return_data['calendar_events'] = array_merge($return_data['calendar_events'], $cached_data['events'][$loop_date]); |
|
872 | + if (!empty($cached_data['events'][$loop_date])) { |
|
873 | + $return_data['calendar_events'] = array_merge($return_data['calendar_events'], $cached_data['events'][$loop_date]); |
|
874 | + } |
|
848 | 875 | } |
849 | 876 | } |
850 | 877 | |
851 | 878 | // Mark the last item so that a list separator can be used in the template. |
852 | - for ($i = 0, $n = count($return_data['calendar_birthdays']); $i < $n; $i++) |
|
853 | - $return_data['calendar_birthdays'][$i]['is_last'] = !isset($return_data['calendar_birthdays'][$i + 1]); |
|
854 | - for ($i = 0, $n = count($return_data['calendar_events']); $i < $n; $i++) |
|
855 | - $return_data['calendar_events'][$i]['is_last'] = !isset($return_data['calendar_events'][$i + 1]); |
|
879 | + for ($i = 0, $n = count($return_data['calendar_birthdays']); $i < $n; $i++) { |
|
880 | + $return_data['calendar_birthdays'][$i]['is_last'] = !isset($return_data['calendar_birthdays'][$i + 1]); |
|
881 | + } |
|
882 | + for ($i = 0, $n = count($return_data['calendar_events']); $i < $n; $i++) { |
|
883 | + $return_data['calendar_events'][$i]['is_last'] = !isset($return_data['calendar_events'][$i + 1]); |
|
884 | + } |
|
856 | 885 | |
857 | 886 | return array( |
858 | 887 | 'data' => $return_data, |
@@ -900,37 +929,46 @@ discard block |
||
900 | 929 | if (isset($_POST['start_date'])) |
901 | 930 | { |
902 | 931 | $d = date_parse($_POST['start_date']); |
903 | - if (!empty($d['error_count']) || !empty($d['warning_count'])) |
|
904 | - fatal_lang_error('invalid_date', false); |
|
905 | - if (empty($d['year'])) |
|
906 | - fatal_lang_error('event_year_missing', false); |
|
907 | - if (empty($d['month'])) |
|
908 | - fatal_lang_error('event_month_missing', false); |
|
909 | - } |
|
910 | - elseif (isset($_POST['start_datetime'])) |
|
932 | + if (!empty($d['error_count']) || !empty($d['warning_count'])) { |
|
933 | + fatal_lang_error('invalid_date', false); |
|
934 | + } |
|
935 | + if (empty($d['year'])) { |
|
936 | + fatal_lang_error('event_year_missing', false); |
|
937 | + } |
|
938 | + if (empty($d['month'])) { |
|
939 | + fatal_lang_error('event_month_missing', false); |
|
940 | + } |
|
941 | + } elseif (isset($_POST['start_datetime'])) |
|
911 | 942 | { |
912 | 943 | $d = date_parse($_POST['start_datetime']); |
913 | - if (!empty($d['error_count']) || !empty($d['warning_count'])) |
|
914 | - fatal_lang_error('invalid_date', false); |
|
915 | - if (empty($d['year'])) |
|
916 | - fatal_lang_error('event_year_missing', false); |
|
917 | - if (empty($d['month'])) |
|
918 | - fatal_lang_error('event_month_missing', false); |
|
944 | + if (!empty($d['error_count']) || !empty($d['warning_count'])) { |
|
945 | + fatal_lang_error('invalid_date', false); |
|
946 | + } |
|
947 | + if (empty($d['year'])) { |
|
948 | + fatal_lang_error('event_year_missing', false); |
|
949 | + } |
|
950 | + if (empty($d['month'])) { |
|
951 | + fatal_lang_error('event_month_missing', false); |
|
952 | + } |
|
919 | 953 | } |
920 | 954 | // The 2.0 way |
921 | 955 | else |
922 | 956 | { |
923 | 957 | // No month? No year? |
924 | - if (!isset($_POST['month'])) |
|
925 | - fatal_lang_error('event_month_missing', false); |
|
926 | - if (!isset($_POST['year'])) |
|
927 | - fatal_lang_error('event_year_missing', false); |
|
958 | + if (!isset($_POST['month'])) { |
|
959 | + fatal_lang_error('event_month_missing', false); |
|
960 | + } |
|
961 | + if (!isset($_POST['year'])) { |
|
962 | + fatal_lang_error('event_year_missing', false); |
|
963 | + } |
|
928 | 964 | |
929 | 965 | // Check the month and year... |
930 | - if ($_POST['month'] < 1 || $_POST['month'] > 12) |
|
931 | - fatal_lang_error('invalid_month', false); |
|
932 | - if ($_POST['year'] < $modSettings['cal_minyear'] || $_POST['year'] > $modSettings['cal_maxyear']) |
|
933 | - fatal_lang_error('invalid_year', false); |
|
966 | + if ($_POST['month'] < 1 || $_POST['month'] > 12) { |
|
967 | + fatal_lang_error('invalid_month', false); |
|
968 | + } |
|
969 | + if ($_POST['year'] < $modSettings['cal_minyear'] || $_POST['year'] > $modSettings['cal_maxyear']) { |
|
970 | + fatal_lang_error('invalid_year', false); |
|
971 | + } |
|
934 | 972 | } |
935 | 973 | } |
936 | 974 | |
@@ -940,8 +978,9 @@ discard block |
||
940 | 978 | // If they want to us to calculate an end date, make sure it will fit in an acceptable range. |
941 | 979 | if (isset($_POST['span'])) |
942 | 980 | { |
943 | - if (($_POST['span'] < 1) || (!empty($modSettings['cal_maxspan']) && $_POST['span'] > $modSettings['cal_maxspan'])) |
|
944 | - fatal_lang_error('invalid_days_numb', false); |
|
981 | + if (($_POST['span'] < 1) || (!empty($modSettings['cal_maxspan']) && $_POST['span'] > $modSettings['cal_maxspan'])) { |
|
982 | + fatal_lang_error('invalid_days_numb', false); |
|
983 | + } |
|
945 | 984 | } |
946 | 985 | |
947 | 986 | // There is no need to validate the following values if we are just deleting the event. |
@@ -951,24 +990,29 @@ discard block |
||
951 | 990 | if (empty($_POST['start_date']) && empty($_POST['start_datetime'])) |
952 | 991 | { |
953 | 992 | // No day? |
954 | - if (!isset($_POST['day'])) |
|
955 | - fatal_lang_error('event_day_missing', false); |
|
993 | + if (!isset($_POST['day'])) { |
|
994 | + fatal_lang_error('event_day_missing', false); |
|
995 | + } |
|
956 | 996 | |
957 | 997 | // Bad day? |
958 | - if (!checkdate($_POST['month'], $_POST['day'], $_POST['year'])) |
|
959 | - fatal_lang_error('invalid_date', false); |
|
998 | + if (!checkdate($_POST['month'], $_POST['day'], $_POST['year'])) { |
|
999 | + fatal_lang_error('invalid_date', false); |
|
1000 | + } |
|
960 | 1001 | } |
961 | 1002 | |
962 | - if (!isset($_POST['evtitle']) && !isset($_POST['subject'])) |
|
963 | - fatal_lang_error('event_title_missing', false); |
|
964 | - elseif (!isset($_POST['evtitle'])) |
|
965 | - $_POST['evtitle'] = $_POST['subject']; |
|
1003 | + if (!isset($_POST['evtitle']) && !isset($_POST['subject'])) { |
|
1004 | + fatal_lang_error('event_title_missing', false); |
|
1005 | + } elseif (!isset($_POST['evtitle'])) { |
|
1006 | + $_POST['evtitle'] = $_POST['subject']; |
|
1007 | + } |
|
966 | 1008 | |
967 | 1009 | // No title? |
968 | - if ($smcFunc['htmltrim']($_POST['evtitle']) === '') |
|
969 | - fatal_lang_error('no_event_title', false); |
|
970 | - if ($smcFunc['strlen']($_POST['evtitle']) > 100) |
|
971 | - $_POST['evtitle'] = $smcFunc['substr']($_POST['evtitle'], 0, 100); |
|
1010 | + if ($smcFunc['htmltrim']($_POST['evtitle']) === '') { |
|
1011 | + fatal_lang_error('no_event_title', false); |
|
1012 | + } |
|
1013 | + if ($smcFunc['strlen']($_POST['evtitle']) > 100) { |
|
1014 | + $_POST['evtitle'] = $smcFunc['substr']($_POST['evtitle'], 0, 100); |
|
1015 | + } |
|
972 | 1016 | $_POST['evtitle'] = str_replace(';', '', $_POST['evtitle']); |
973 | 1017 | } |
974 | 1018 | } |
@@ -995,8 +1039,9 @@ discard block |
||
995 | 1039 | ); |
996 | 1040 | |
997 | 1041 | // No results, return false. |
998 | - if ($smcFunc['db_num_rows'] === 0) |
|
999 | - return false; |
|
1042 | + if ($smcFunc['db_num_rows'] === 0) { |
|
1043 | + return false; |
|
1044 | + } |
|
1000 | 1045 | |
1001 | 1046 | // Grab the results and return. |
1002 | 1047 | list ($poster) = $smcFunc['db_fetch_row']($request); |
@@ -1130,8 +1175,9 @@ discard block |
||
1130 | 1175 | call_integration_hook('integrate_modify_event', array($event_id, &$eventOptions, &$event_columns, &$event_parameters)); |
1131 | 1176 | |
1132 | 1177 | $column_clauses = array(); |
1133 | - foreach ($event_columns as $col => $crit) |
|
1134 | - $column_clauses[] = $col . ' = ' . $crit; |
|
1178 | + foreach ($event_columns as $col => $crit) { |
|
1179 | + $column_clauses[] = $col . ' = ' . $crit; |
|
1180 | + } |
|
1135 | 1181 | |
1136 | 1182 | $smcFunc['db_query']('', ' |
1137 | 1183 | UPDATE {db_prefix}calendar |
@@ -1216,8 +1262,9 @@ discard block |
||
1216 | 1262 | ); |
1217 | 1263 | |
1218 | 1264 | // If nothing returned, we are in poo, poo. |
1219 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
1220 | - return false; |
|
1265 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
1266 | + return false; |
|
1267 | + } |
|
1221 | 1268 | |
1222 | 1269 | $row = $smcFunc['db_fetch_assoc']($request); |
1223 | 1270 | $smcFunc['db_free_result']($request); |
@@ -1225,8 +1272,9 @@ discard block |
||
1225 | 1272 | list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row); |
1226 | 1273 | |
1227 | 1274 | // Sanity check |
1228 | - if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) |
|
1229 | - return false; |
|
1275 | + if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) { |
|
1276 | + return false; |
|
1277 | + } |
|
1230 | 1278 | |
1231 | 1279 | $return_value = array( |
1232 | 1280 | 'boards' => array(), |
@@ -1363,24 +1411,27 @@ discard block |
||
1363 | 1411 | |
1364 | 1412 | // Set $span, in case we need it |
1365 | 1413 | $span = isset($eventOptions['span']) ? $eventOptions['span'] : (isset($_POST['span']) ? $_POST['span'] : 0); |
1366 | - if ($span > 0) |
|
1367 | - $span = !empty($modSettings['cal_maxspan']) ? min($modSettings['cal_maxspan'], $span - 1) : $span - 1; |
|
1414 | + if ($span > 0) { |
|
1415 | + $span = !empty($modSettings['cal_maxspan']) ? min($modSettings['cal_maxspan'], $span - 1) : $span - 1; |
|
1416 | + } |
|
1368 | 1417 | |
1369 | 1418 | // Define the timezone for this event, falling back to the default if not provided |
1370 | - if (!empty($eventOptions['tz']) && in_array($eventOptions['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1371 | - $tz = $eventOptions['tz']; |
|
1372 | - elseif (!empty($_POST['tz']) && in_array($_POST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1373 | - $tz = $_POST['tz']; |
|
1374 | - else |
|
1375 | - $tz = getUserTimezone(); |
|
1419 | + if (!empty($eventOptions['tz']) && in_array($eventOptions['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1420 | + $tz = $eventOptions['tz']; |
|
1421 | + } elseif (!empty($_POST['tz']) && in_array($_POST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1422 | + $tz = $_POST['tz']; |
|
1423 | + } else { |
|
1424 | + $tz = getUserTimezone(); |
|
1425 | + } |
|
1376 | 1426 | |
1377 | 1427 | // Is this supposed to be an all day event, or should it have specific start and end times? |
1378 | - if (isset($eventOptions['allday'])) |
|
1379 | - $allday = $eventOptions['allday']; |
|
1380 | - elseif (empty($_POST['allday'])) |
|
1381 | - $allday = false; |
|
1382 | - else |
|
1383 | - $allday = true; |
|
1428 | + if (isset($eventOptions['allday'])) { |
|
1429 | + $allday = $eventOptions['allday']; |
|
1430 | + } elseif (empty($_POST['allday'])) { |
|
1431 | + $allday = false; |
|
1432 | + } else { |
|
1433 | + $allday = true; |
|
1434 | + } |
|
1384 | 1435 | |
1385 | 1436 | // Input might come as individual parameters... |
1386 | 1437 | $start_year = isset($eventOptions['year']) ? $eventOptions['year'] : (isset($_POST['year']) ? $_POST['year'] : null); |
@@ -1407,10 +1458,12 @@ discard block |
||
1407 | 1458 | $end_time_string = isset($eventOptions['end_time']) ? $eventOptions['end_time'] : (isset($_POST['end_time']) ? $_POST['end_time'] : null); |
1408 | 1459 | |
1409 | 1460 | // If the date and time were given in separate strings, combine them |
1410 | - if (empty($start_string) && isset($start_date_string)) |
|
1411 | - $start_string = $start_date_string . (isset($start_time_string) ? ' ' . $start_time_string : ''); |
|
1412 | - if (empty($end_string) && isset($end_date_string)) |
|
1413 | - $end_string = $end_date_string . (isset($end_time_string) ? ' ' . $end_time_string : ''); |
|
1461 | + if (empty($start_string) && isset($start_date_string)) { |
|
1462 | + $start_string = $start_date_string . (isset($start_time_string) ? ' ' . $start_time_string : ''); |
|
1463 | + } |
|
1464 | + if (empty($end_string) && isset($end_date_string)) { |
|
1465 | + $end_string = $end_date_string . (isset($end_time_string) ? ' ' . $end_time_string : ''); |
|
1466 | + } |
|
1414 | 1467 | |
1415 | 1468 | // If some form of string input was given, override individually defined options with it |
1416 | 1469 | if (isset($start_string)) |
@@ -1501,10 +1554,11 @@ discard block |
||
1501 | 1554 | if ($start_object >= $end_object) |
1502 | 1555 | { |
1503 | 1556 | $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, $start_hour, $start_minute, $start_second) . ' ' . $tz); |
1504 | - if ($span > 0) |
|
1505 | - date_add($end_object, date_interval_create_from_date_string($span . ' days')); |
|
1506 | - else |
|
1507 | - date_add($end_object, date_interval_create_from_date_string('1 hour')); |
|
1557 | + if ($span > 0) { |
|
1558 | + date_add($end_object, date_interval_create_from_date_string($span . ' days')); |
|
1559 | + } else { |
|
1560 | + date_add($end_object, date_interval_create_from_date_string('1 hour')); |
|
1561 | + } |
|
1508 | 1562 | } |
1509 | 1563 | |
1510 | 1564 | // Is $end_object too late? |
@@ -1517,9 +1571,9 @@ discard block |
||
1517 | 1571 | { |
1518 | 1572 | $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, $start_hour, $start_minute, $start_second) . ' ' . $tz); |
1519 | 1573 | date_add($end_object, date_interval_create_from_date_string($modSettings['cal_maxspan'] . ' days')); |
1574 | + } else { |
|
1575 | + $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, '11', '59', '59') . ' ' . $tz); |
|
1520 | 1576 | } |
1521 | - else |
|
1522 | - $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, '11', '59', '59') . ' ' . $tz); |
|
1523 | 1577 | } |
1524 | 1578 | } |
1525 | 1579 | |
@@ -1532,8 +1586,7 @@ discard block |
||
1532 | 1586 | $start_time = null; |
1533 | 1587 | $end_time = null; |
1534 | 1588 | $tz = null; |
1535 | - } |
|
1536 | - else |
|
1589 | + } else |
|
1537 | 1590 | { |
1538 | 1591 | $start_time = date_format($start_object, 'H:i:s'); |
1539 | 1592 | $end_time = date_format($end_object, 'H:i:s'); |
@@ -1559,19 +1612,21 @@ discard block |
||
1559 | 1612 | // First, try to create a better date format, ignoring the "time" elements. |
1560 | 1613 | if (empty($date_format)) |
1561 | 1614 | { |
1562 | - if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
1563 | - $date_format = '%F'; |
|
1564 | - else |
|
1565 | - $date_format = $matches[0]; |
|
1615 | + if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
1616 | + $date_format = '%F'; |
|
1617 | + } else { |
|
1618 | + $date_format = $matches[0]; |
|
1619 | + } |
|
1566 | 1620 | } |
1567 | 1621 | |
1568 | 1622 | // We want a fairly compact version of the time, but as close as possible to the user's settings. |
1569 | 1623 | if (empty($time_format)) |
1570 | 1624 | { |
1571 | - if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
1572 | - $time_format = '%k:%M'; |
|
1573 | - else |
|
1574 | - $time_format = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
1625 | + if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
1626 | + $time_format = '%k:%M'; |
|
1627 | + } else { |
|
1628 | + $time_format = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
1629 | + } |
|
1575 | 1630 | } |
1576 | 1631 | |
1577 | 1632 | // Should this be an all day event? |
@@ -1581,11 +1636,13 @@ discard block |
||
1581 | 1636 | $span = 1 + date_interval_format(date_diff(date_create($row['start_date']), date_create($row['end_date'])), '%d'); |
1582 | 1637 | |
1583 | 1638 | // We need to have a defined timezone in the steps below |
1584 | - if (empty($row['timezone'])) |
|
1585 | - $row['timezone'] = getUserTimezone(); |
|
1639 | + if (empty($row['timezone'])) { |
|
1640 | + $row['timezone'] = getUserTimezone(); |
|
1641 | + } |
|
1586 | 1642 | |
1587 | - if (empty($timezone_array[$row['timezone']])) |
|
1588 | - $timezone_array[$row['timezone']] = timezone_open($row['timezone']); |
|
1643 | + if (empty($timezone_array[$row['timezone']])) { |
|
1644 | + $timezone_array[$row['timezone']] = timezone_open($row['timezone']); |
|
1645 | + } |
|
1589 | 1646 | |
1590 | 1647 | // Get most of the standard date information for the start and end datetimes |
1591 | 1648 | $start = date_parse($row['start_date'] . (!$allday ? ' ' . $row['start_time'] : '')); |
@@ -1633,8 +1690,9 @@ discard block |
||
1633 | 1690 | global $smcFunc, $context, $user_info, $modSettings, $user_settings; |
1634 | 1691 | static $member_cache = array(); |
1635 | 1692 | |
1636 | - if (is_null($id_member) && $user_info['is_guest'] == false) |
|
1637 | - $id_member = $context['user']['id']; |
|
1693 | + if (is_null($id_member) && $user_info['is_guest'] == false) { |
|
1694 | + $id_member = $context['user']['id']; |
|
1695 | + } |
|
1638 | 1696 | |
1639 | 1697 | //check if the cache got the data |
1640 | 1698 | if (isset($id_member) && isset($member_cache[$id_member])) |
@@ -1663,11 +1721,13 @@ discard block |
||
1663 | 1721 | $smcFunc['db_free_result']($request); |
1664 | 1722 | } |
1665 | 1723 | |
1666 | - if (empty($timezone) || !in_array($timezone, timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1667 | - $timezone = isset($modSettings['default_timezone']) ? $modSettings['default_timezone'] : date_default_timezone_get(); |
|
1724 | + if (empty($timezone) || !in_array($timezone, timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1725 | + $timezone = isset($modSettings['default_timezone']) ? $modSettings['default_timezone'] : date_default_timezone_get(); |
|
1726 | + } |
|
1668 | 1727 | |
1669 | - if (isset($id_member)) |
|
1670 | - $member_cache[$id_member] = $timezone; |
|
1728 | + if (isset($id_member)) { |
|
1729 | + $member_cache[$id_member] = $timezone; |
|
1730 | + } |
|
1671 | 1731 | |
1672 | 1732 | return $timezone; |
1673 | 1733 | } |
@@ -1696,8 +1756,9 @@ discard block |
||
1696 | 1756 | ) |
1697 | 1757 | ); |
1698 | 1758 | $holidays = array(); |
1699 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1700 | - $holidays[] = $row; |
|
1759 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1760 | + $holidays[] = $row; |
|
1761 | + } |
|
1701 | 1762 | $smcFunc['db_free_result']($request); |
1702 | 1763 | |
1703 | 1764 | return $holidays; |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Entry point for the moderation center. |
@@ -26,8 +27,9 @@ discard block |
||
26 | 27 | global $smcFunc, $txt, $context, $scripturl, $modSettings, $user_info, $sourcedir, $options; |
27 | 28 | |
28 | 29 | // Don't run this twice... and don't conflict with the admin bar. |
29 | - if (isset($context['admin_area'])) |
|
30 | - return; |
|
30 | + if (isset($context['admin_area'])) { |
|
31 | + return; |
|
32 | + } |
|
31 | 33 | |
32 | 34 | $context['can_moderate_boards'] = $user_info['mod_cache']['bq'] != '0=1'; |
33 | 35 | $context['can_moderate_groups'] = $user_info['mod_cache']['gq'] != '0=1'; |
@@ -35,8 +37,9 @@ discard block |
||
35 | 37 | $context['can_moderate_users'] = allowedTo('moderate_forum'); |
36 | 38 | |
37 | 39 | // Everyone using this area must be allowed here! |
38 | - if (!$context['can_moderate_boards'] && !$context['can_moderate_groups'] && !$context['can_moderate_approvals'] && !$context['can_moderate_users']) |
|
39 | - isAllowedTo('access_mod_center'); |
|
40 | + if (!$context['can_moderate_boards'] && !$context['can_moderate_groups'] && !$context['can_moderate_approvals'] && !$context['can_moderate_users']) { |
|
41 | + isAllowedTo('access_mod_center'); |
|
42 | + } |
|
40 | 43 | |
41 | 44 | // We're gonna want a menu of some kind. |
42 | 45 | require_once($sourcedir . '/Subs-Menu.php'); |
@@ -195,8 +198,9 @@ discard block |
||
195 | 198 | unset($moderation_areas); |
196 | 199 | |
197 | 200 | // We got something - didn't we? DIDN'T WE! |
198 | - if ($mod_include_data == false) |
|
199 | - fatal_lang_error('no_access', false); |
|
201 | + if ($mod_include_data == false) { |
|
202 | + fatal_lang_error('no_access', false); |
|
203 | + } |
|
200 | 204 | |
201 | 205 | // Retain the ID information in case required by a subaction. |
202 | 206 | $context['moderation_menu_id'] = $context['max_menu_id']; |
@@ -219,22 +223,25 @@ discard block |
||
219 | 223 | 'url' => $scripturl . '?action=moderate', |
220 | 224 | 'name' => $txt['moderation_center'], |
221 | 225 | ); |
222 | - if (isset($mod_include_data['current_area']) && $mod_include_data['current_area'] != 'index') |
|
223 | - $context['linktree'][] = array( |
|
226 | + if (isset($mod_include_data['current_area']) && $mod_include_data['current_area'] != 'index') { |
|
227 | + $context['linktree'][] = array( |
|
224 | 228 | 'url' => $scripturl . '?action=moderate;area=' . $mod_include_data['current_area'], |
225 | 229 | 'name' => $mod_include_data['label'], |
226 | 230 | ); |
227 | - if (!empty($mod_include_data['current_subsection']) && $mod_include_data['subsections'][$mod_include_data['current_subsection']][0] != $mod_include_data['label']) |
|
228 | - $context['linktree'][] = array( |
|
231 | + } |
|
232 | + if (!empty($mod_include_data['current_subsection']) && $mod_include_data['subsections'][$mod_include_data['current_subsection']][0] != $mod_include_data['label']) { |
|
233 | + $context['linktree'][] = array( |
|
229 | 234 | 'url' => $scripturl . '?action=moderate;area=' . $mod_include_data['current_area'] . ';sa=' . $mod_include_data['current_subsection'], |
230 | 235 | 'name' => $mod_include_data['subsections'][$mod_include_data['current_subsection']][0], |
231 | 236 | ); |
237 | + } |
|
232 | 238 | |
233 | 239 | // Now - finally - the bit before the encore - the main performance of course! |
234 | 240 | if (!$dont_call) |
235 | 241 | { |
236 | - if (isset($mod_include_data['file'])) |
|
237 | - require_once($sourcedir . '/' . $mod_include_data['file']); |
|
242 | + if (isset($mod_include_data['file'])) { |
|
243 | + require_once($sourcedir . '/' . $mod_include_data['file']); |
|
244 | + } |
|
238 | 245 | |
239 | 246 | call_helper($mod_include_data['function']); |
240 | 247 | } |
@@ -259,8 +266,9 @@ discard block |
||
259 | 266 | // Load what blocks the user actually can see... |
260 | 267 | $valid_blocks = array(); |
261 | 268 | |
262 | - if ($context['can_moderate_groups']) |
|
263 | - $valid_blocks['g'] = 'GroupRequests'; |
|
269 | + if ($context['can_moderate_groups']) { |
|
270 | + $valid_blocks['g'] = 'GroupRequests'; |
|
271 | + } |
|
264 | 272 | if ($context['can_moderate_boards']) |
265 | 273 | { |
266 | 274 | $valid_blocks['r'] = 'ReportedPosts'; |
@@ -269,8 +277,9 @@ discard block |
||
269 | 277 | if ($context['can_moderate_users']) |
270 | 278 | { |
271 | 279 | // This falls under the category of moderating users as well... |
272 | - if (!$context['can_moderate_boards']) |
|
273 | - $valid_blocks['w'] = 'WatchedUsers'; |
|
280 | + if (!$context['can_moderate_boards']) { |
|
281 | + $valid_blocks['w'] = 'WatchedUsers'; |
|
282 | + } |
|
274 | 283 | |
275 | 284 | $valid_blocks['rm'] = 'ReportedMembers'; |
276 | 285 | } |
@@ -281,8 +290,9 @@ discard block |
||
281 | 290 | foreach ($valid_blocks as $k => $block) |
282 | 291 | { |
283 | 292 | $block = 'ModBlock' . $block; |
284 | - if (function_exists($block)) |
|
285 | - $context['mod_blocks'][] = $block(); |
|
293 | + if (function_exists($block)) { |
|
294 | + $context['mod_blocks'][] = $block(); |
|
295 | + } |
|
286 | 296 | } |
287 | 297 | |
288 | 298 | $context['admin_prefs'] = !empty($options['admin_preferences']) ? $smcFunc['json_decode']($options['admin_preferences'], true) : array(); |
@@ -309,8 +319,9 @@ discard block |
||
309 | 319 | ) |
310 | 320 | ); |
311 | 321 | $watched_users = array(); |
312 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
313 | - $watched_users[] = $row; |
|
322 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
323 | + $watched_users[] = $row; |
|
324 | + } |
|
314 | 325 | $smcFunc['db_free_result']($request); |
315 | 326 | |
316 | 327 | cache_put_data('recent_user_watches', $watched_users, 240); |
@@ -402,8 +413,9 @@ discard block |
||
402 | 413 | $note_owner = $smcFunc['db_num_rows']($get_owner); |
403 | 414 | $smcFunc['db_free_result']($get_owner); |
404 | 415 | |
405 | - if (empty($note_owner)) |
|
406 | - fatal_lang_error('mc_notes_delete_own', false); |
|
416 | + if (empty($note_owner)) { |
|
417 | + fatal_lang_error('mc_notes_delete_own', false); |
|
418 | + } |
|
407 | 419 | } |
408 | 420 | |
409 | 421 | // Lets delete it. |
@@ -460,12 +472,14 @@ discard block |
||
460 | 472 | ) |
461 | 473 | ); |
462 | 474 | $moderator_notes = array(); |
463 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
464 | - $moderator_notes[] = $row; |
|
475 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
476 | + $moderator_notes[] = $row; |
|
477 | + } |
|
465 | 478 | $smcFunc['db_free_result']($request); |
466 | 479 | |
467 | - if ($offset == 0) |
|
468 | - cache_put_data('moderator_notes', $moderator_notes, 240); |
|
480 | + if ($offset == 0) { |
|
481 | + cache_put_data('moderator_notes', $moderator_notes, 240); |
|
482 | + } |
|
469 | 483 | } |
470 | 484 | |
471 | 485 | // Lets construct a page index. |
@@ -504,8 +518,9 @@ discard block |
||
504 | 518 | // Got the info already? |
505 | 519 | $cachekey = md5($smcFunc['json_encode']($user_info['mod_cache']['bq'])); |
506 | 520 | $context['reported_posts'] = array(); |
507 | - if ($user_info['mod_cache']['bq'] == '0=1') |
|
508 | - return 'reported_posts_block'; |
|
521 | + if ($user_info['mod_cache']['bq'] == '0=1') { |
|
522 | + return 'reported_posts_block'; |
|
523 | + } |
|
509 | 524 | |
510 | 525 | if (($reported_posts = cache_get_data('reported_posts_' . $cachekey, 90)) === null) |
511 | 526 | { |
@@ -529,8 +544,9 @@ discard block |
||
529 | 544 | ) |
530 | 545 | ); |
531 | 546 | $reported_posts = array(); |
532 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
533 | - $reported_posts[] = $row; |
|
547 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
548 | + $reported_posts[] = $row; |
|
549 | + } |
|
534 | 550 | $smcFunc['db_free_result']($request); |
535 | 551 | |
536 | 552 | // Cache it. |
@@ -568,8 +584,9 @@ discard block |
||
568 | 584 | |
569 | 585 | $context['group_requests'] = array(); |
570 | 586 | // Make sure they can even moderate someone! |
571 | - if ($user_info['mod_cache']['gq'] == '0=1') |
|
572 | - return 'group_requests_block'; |
|
587 | + if ($user_info['mod_cache']['gq'] == '0=1') { |
|
588 | + return 'group_requests_block'; |
|
589 | + } |
|
573 | 590 | |
574 | 591 | // What requests are outstanding? |
575 | 592 | $request = $smcFunc['db_query']('', ' |
@@ -618,8 +635,9 @@ discard block |
||
618 | 635 | // Got the info already? |
619 | 636 | $cachekey = md5($smcFunc['json_encode']((int) allowedTo('moderate_forum'))); |
620 | 637 | $context['reported_users'] = array(); |
621 | - if (!allowedTo('moderate_forum')) |
|
622 | - return 'reported_users_block'; |
|
638 | + if (!allowedTo('moderate_forum')) { |
|
639 | + return 'reported_users_block'; |
|
640 | + } |
|
623 | 641 | |
624 | 642 | if (($reported_users = cache_get_data('reported_users_' . $cachekey, 90)) === null) |
625 | 643 | { |
@@ -642,8 +660,9 @@ discard block |
||
642 | 660 | ) |
643 | 661 | ); |
644 | 662 | $reported_users = array(); |
645 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
646 | - $reported_users[] = $row; |
|
663 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
664 | + $reported_users[] = $row; |
|
665 | + } |
|
647 | 666 | $smcFunc['db_free_result']($request); |
648 | 667 | |
649 | 668 | // Cache it. |
@@ -742,15 +761,15 @@ discard block |
||
742 | 761 | // Time to update. |
743 | 762 | updateSettings(array('last_mod_report_action' => time())); |
744 | 763 | recountOpenReports('members'); |
745 | - } |
|
746 | - elseif (isset($_POST['close']) && isset($_POST['close_selected'])) |
|
764 | + } elseif (isset($_POST['close']) && isset($_POST['close_selected'])) |
|
747 | 765 | { |
748 | 766 | checkSession(); |
749 | 767 | |
750 | 768 | // All the ones to update... |
751 | 769 | $toClose = array(); |
752 | - foreach ($_POST['close'] as $rid) |
|
753 | - $toClose[] = (int) $rid; |
|
770 | + foreach ($_POST['close'] as $rid) { |
|
771 | + $toClose[] = (int) $rid; |
|
772 | + } |
|
754 | 773 | |
755 | 774 | if (!empty($toClose)) |
756 | 775 | { |
@@ -903,8 +922,9 @@ discard block |
||
903 | 922 | global $context, $user_info; |
904 | 923 | |
905 | 924 | // You need to be allowed to moderate groups... |
906 | - if ($user_info['mod_cache']['gq'] == '0=1') |
|
907 | - isAllowedTo('manage_membergroups'); |
|
925 | + if ($user_info['mod_cache']['gq'] == '0=1') { |
|
926 | + isAllowedTo('manage_membergroups'); |
|
927 | + } |
|
908 | 928 | |
909 | 929 | // Load the group templates. |
910 | 930 | loadTemplate('ModerationCenter'); |
@@ -915,8 +935,9 @@ discard block |
||
915 | 935 | 'view' => 'ViewGroups', |
916 | 936 | ); |
917 | 937 | |
918 | - if (!isset($_GET['sa']) || !isset($subActions[$_GET['sa']])) |
|
919 | - $_GET['sa'] = 'view'; |
|
938 | + if (!isset($_GET['sa']) || !isset($subActions[$_GET['sa']])) { |
|
939 | + $_GET['sa'] = 'view'; |
|
940 | + } |
|
920 | 941 | $context['sub_action'] = $_GET['sa']; |
921 | 942 | |
922 | 943 | // Call the relevant function. |
@@ -946,8 +967,9 @@ discard block |
||
946 | 967 | 'id_notice' => $id_notice, |
947 | 968 | ) |
948 | 969 | ); |
949 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
950 | - fatal_lang_error('no_access', false); |
|
970 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
971 | + fatal_lang_error('no_access', false); |
|
972 | + } |
|
951 | 973 | list ($context['notice_body'], $context['notice_subject']) = $smcFunc['db_fetch_row']($request); |
952 | 974 | $smcFunc['db_free_result']($request); |
953 | 975 | |
@@ -984,18 +1006,20 @@ discard block |
||
984 | 1006 | checkSession(!is_array($_REQUEST['delete']) ? 'get' : 'post'); |
985 | 1007 | |
986 | 1008 | $toDelete = array(); |
987 | - if (!is_array($_REQUEST['delete'])) |
|
988 | - $toDelete[] = (int) $_REQUEST['delete']; |
|
989 | - else |
|
990 | - foreach ($_REQUEST['delete'] as $did) |
|
1009 | + if (!is_array($_REQUEST['delete'])) { |
|
1010 | + $toDelete[] = (int) $_REQUEST['delete']; |
|
1011 | + } else { |
|
1012 | + foreach ($_REQUEST['delete'] as $did) |
|
991 | 1013 | $toDelete[] = (int) $did; |
1014 | + } |
|
992 | 1015 | |
993 | 1016 | if (!empty($toDelete)) |
994 | 1017 | { |
995 | 1018 | require_once($sourcedir . '/RemoveTopic.php'); |
996 | 1019 | // If they don't have permission we'll let it error - either way no chance of a security slip here! |
997 | - foreach ($toDelete as $did) |
|
998 | - removeMessage($did); |
|
1020 | + foreach ($toDelete as $did) { |
|
1021 | + removeMessage($did); |
|
1022 | + } |
|
999 | 1023 | } |
1000 | 1024 | } |
1001 | 1025 | |
@@ -1004,20 +1028,21 @@ discard block |
||
1004 | 1028 | { |
1005 | 1029 | $approve_query = ''; |
1006 | 1030 | $delete_boards = array(); |
1007 | - } |
|
1008 | - else |
|
1031 | + } else |
|
1009 | 1032 | { |
1010 | 1033 | // Still obey permissions! |
1011 | 1034 | $approve_boards = boardsAllowedTo('approve_posts'); |
1012 | 1035 | $delete_boards = boardsAllowedTo('delete_any'); |
1013 | 1036 | |
1014 | - if ($approve_boards == array(0)) |
|
1015 | - $approve_query = ''; |
|
1016 | - elseif (!empty($approve_boards)) |
|
1017 | - $approve_query = ' AND m.id_board IN (' . implode(',', $approve_boards) . ')'; |
|
1037 | + if ($approve_boards == array(0)) { |
|
1038 | + $approve_query = ''; |
|
1039 | + } elseif (!empty($approve_boards)) { |
|
1040 | + $approve_query = ' AND m.id_board IN (' . implode(',', $approve_boards) . ')'; |
|
1041 | + } |
|
1018 | 1042 | // Nada, zip, etc... |
1019 | - else |
|
1020 | - $approve_query = ' AND 1=0'; |
|
1043 | + else { |
|
1044 | + $approve_query = ' AND 1=0'; |
|
1045 | + } |
|
1021 | 1046 | } |
1022 | 1047 | |
1023 | 1048 | require_once($sourcedir . '/Subs-List.php'); |
@@ -1116,10 +1141,11 @@ discard block |
||
1116 | 1141 | 'data' => array( |
1117 | 1142 | 'function' => function($member) use ($scripturl) |
1118 | 1143 | { |
1119 | - if ($member['last_post_id']) |
|
1120 | - return '<a href="' . $scripturl . '?msg=' . $member['last_post_id'] . '">' . $member['last_post'] . '</a>'; |
|
1121 | - else |
|
1122 | - return $member['last_post']; |
|
1144 | + if ($member['last_post_id']) { |
|
1145 | + return '<a href="' . $scripturl . '?msg=' . $member['last_post_id'] . '">' . $member['last_post'] . '</a>'; |
|
1146 | + } else { |
|
1147 | + return $member['last_post']; |
|
1148 | + } |
|
1123 | 1149 | }, |
1124 | 1150 | ), |
1125 | 1151 | ), |
@@ -1247,8 +1273,9 @@ discard block |
||
1247 | 1273 | ) |
1248 | 1274 | ); |
1249 | 1275 | $latest_posts = array(); |
1250 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1251 | - $latest_posts[$row['id_member']] = $row['last_post_id']; |
|
1276 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1277 | + $latest_posts[$row['id_member']] = $row['last_post_id']; |
|
1278 | + } |
|
1252 | 1279 | |
1253 | 1280 | if (!empty($latest_posts)) |
1254 | 1281 | { |
@@ -1439,15 +1466,17 @@ discard block |
||
1439 | 1466 | // Setup the direction stuff... |
1440 | 1467 | $context['order'] = isset($_REQUEST['sort']) && isset($sort_types[$_REQUEST['sort']]) ? $_REQUEST['sort'] : 'member'; |
1441 | 1468 | |
1442 | - if (!isset($search_params['string']) || (!empty($_REQUEST['search']) && $search_params['string'] != $_REQUEST['search'])) |
|
1443 | - $search_params_string = empty($_REQUEST['search']) ? '' : $_REQUEST['search']; |
|
1444 | - else |
|
1445 | - $search_params_string = $search_params['string']; |
|
1469 | + if (!isset($search_params['string']) || (!empty($_REQUEST['search']) && $search_params['string'] != $_REQUEST['search'])) { |
|
1470 | + $search_params_string = empty($_REQUEST['search']) ? '' : $_REQUEST['search']; |
|
1471 | + } else { |
|
1472 | + $search_params_string = $search_params['string']; |
|
1473 | + } |
|
1446 | 1474 | |
1447 | - if (isset($_REQUEST['search_type']) || empty($search_params['type']) || !isset($searchTypes[$search_params['type']])) |
|
1448 | - $search_params_type = isset($_REQUEST['search_type']) && isset($searchTypes[$_REQUEST['search_type']]) ? $_REQUEST['search_type'] : (isset($searchTypes[$context['order']]) ? $context['order'] : 'member'); |
|
1449 | - else |
|
1450 | - $search_params_type = $search_params['type']; |
|
1475 | + if (isset($_REQUEST['search_type']) || empty($search_params['type']) || !isset($searchTypes[$search_params['type']])) { |
|
1476 | + $search_params_type = isset($_REQUEST['search_type']) && isset($searchTypes[$_REQUEST['search_type']]) ? $_REQUEST['search_type'] : (isset($searchTypes[$context['order']]) ? $context['order'] : 'member'); |
|
1477 | + } else { |
|
1478 | + $search_params_type = $search_params['type']; |
|
1479 | + } |
|
1451 | 1480 | |
1452 | 1481 | $search_params = array( |
1453 | 1482 | 'string' => $search_params_string, |
@@ -1530,9 +1559,10 @@ discard block |
||
1530 | 1559 | ' . $rowData['reason'] . ' |
1531 | 1560 | </div>'; |
1532 | 1561 | |
1533 | - if (!empty($rowData['id_notice'])) |
|
1534 | - $output .= ' |
|
1562 | + if (!empty($rowData['id_notice'])) { |
|
1563 | + $output .= ' |
|
1535 | 1564 | <a href="' . $scripturl . '?action=moderate;area=notice;nid=' . $rowData['id_notice'] . '" onclick="window.open(this.href, \'\', \'scrollbars=yes,resizable=yes,width=400,height=250\');return false;" target="_blank" class="new_win" title="' . $txt['profile_warning_previous_notice'] . '"><span class="generic_icons filter centericon"></span></a>'; |
1565 | + } |
|
1536 | 1566 | return $output; |
1537 | 1567 | }, |
1538 | 1568 | ), |
@@ -1650,9 +1680,9 @@ discard block |
||
1650 | 1680 | global $smcFunc, $modSettings, $context, $txt, $scripturl, $sourcedir, $user_info; |
1651 | 1681 | |
1652 | 1682 | // Submitting a new one? |
1653 | - if (isset($_POST['add'])) |
|
1654 | - return ModifyWarningTemplate(); |
|
1655 | - elseif (isset($_POST['delete']) && !empty($_POST['deltpl'])) |
|
1683 | + if (isset($_POST['add'])) { |
|
1684 | + return ModifyWarningTemplate(); |
|
1685 | + } elseif (isset($_POST['delete']) && !empty($_POST['deltpl'])) |
|
1656 | 1686 | { |
1657 | 1687 | checkSession(); |
1658 | 1688 | validateToken('mod-wt'); |
@@ -1671,8 +1701,9 @@ discard block |
||
1671 | 1701 | 'current_member' => $user_info['id'], |
1672 | 1702 | ) |
1673 | 1703 | ); |
1674 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1675 | - logAction('delete_warn_template', array('template' => $row['recipient_name'])); |
|
1704 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1705 | + logAction('delete_warn_template', array('template' => $row['recipient_name'])); |
|
1706 | + } |
|
1676 | 1707 | $smcFunc['db_free_result']($request); |
1677 | 1708 | |
1678 | 1709 | // Do the deletes. |
@@ -1963,16 +1994,18 @@ discard block |
||
1963 | 1994 | ); |
1964 | 1995 | |
1965 | 1996 | // If it wasn't visible and now is they've effectively added it. |
1966 | - if ($context['template_data']['personal'] && !$recipient_id) |
|
1967 | - logAction('add_warn_template', array('template' => $_POST['template_title'])); |
|
1997 | + if ($context['template_data']['personal'] && !$recipient_id) { |
|
1998 | + logAction('add_warn_template', array('template' => $_POST['template_title'])); |
|
1999 | + } |
|
1968 | 2000 | // Conversely if they made it personal it's a delete. |
1969 | - elseif (!$context['template_data']['personal'] && $recipient_id) |
|
1970 | - logAction('delete_warn_template', array('template' => $_POST['template_title'])); |
|
2001 | + elseif (!$context['template_data']['personal'] && $recipient_id) { |
|
2002 | + logAction('delete_warn_template', array('template' => $_POST['template_title'])); |
|
2003 | + } |
|
1971 | 2004 | // Otherwise just an edit. |
1972 | - else |
|
1973 | - logAction('modify_warn_template', array('template' => $_POST['template_title'])); |
|
1974 | - } |
|
1975 | - else |
|
2005 | + else { |
|
2006 | + logAction('modify_warn_template', array('template' => $_POST['template_title'])); |
|
2007 | + } |
|
2008 | + } else |
|
1976 | 2009 | { |
1977 | 2010 | $smcFunc['db_insert']('', |
1978 | 2011 | '{db_prefix}log_comments', |
@@ -1992,17 +2025,18 @@ discard block |
||
1992 | 2025 | |
1993 | 2026 | // Get out of town... |
1994 | 2027 | redirectexit('action=moderate;area=warnings;sa=templates'); |
1995 | - } |
|
1996 | - else |
|
2028 | + } else |
|
1997 | 2029 | { |
1998 | 2030 | $context['warning_errors'] = array(); |
1999 | 2031 | $context['template_data']['title'] = !empty($_POST['template_title']) ? $_POST['template_title'] : ''; |
2000 | 2032 | $context['template_data']['body'] = !empty($_POST['template_body']) ? $_POST['template_body'] : $txt['mc_warning_template_body_default']; |
2001 | 2033 | $context['template_data']['personal'] = !empty($_POST['make_personal']); |
2002 | - if (empty($_POST['template_title'])) |
|
2003 | - $context['warning_errors'][] = $txt['mc_warning_template_error_no_title']; |
|
2004 | - if (empty($_POST['template_body'])) |
|
2005 | - $context['warning_errors'][] = $txt['mc_warning_template_error_no_body']; |
|
2034 | + if (empty($_POST['template_title'])) { |
|
2035 | + $context['warning_errors'][] = $txt['mc_warning_template_error_no_title']; |
|
2036 | + } |
|
2037 | + if (empty($_POST['template_body'])) { |
|
2038 | + $context['warning_errors'][] = $txt['mc_warning_template_error_no_body']; |
|
2039 | + } |
|
2006 | 2040 | } |
2007 | 2041 | } |
2008 | 2042 | |
@@ -2047,8 +2081,9 @@ discard block |
||
2047 | 2081 | // Now check other options! |
2048 | 2082 | $pref_binary = 0; |
2049 | 2083 | |
2050 | - if ($context['can_moderate_approvals'] && !empty($_POST['mod_notify_approval'])) |
|
2051 | - $pref_binary |= 4; |
|
2084 | + if ($context['can_moderate_approvals'] && !empty($_POST['mod_notify_approval'])) { |
|
2085 | + $pref_binary |= 4; |
|
2086 | + } |
|
2052 | 2087 | |
2053 | 2088 | // Put it all together. |
2054 | 2089 | $mod_prefs = '0||' . $pref_binary; |
@@ -2072,9 +2107,10 @@ discard block |
||
2072 | 2107 | unset($_SESSION['moderate_time']); |
2073 | 2108 | |
2074 | 2109 | // Clean any moderator tokens as well. |
2075 | - foreach ($_SESSION['token'] as $key => $token) |
|
2076 | - if (strpos($key, '-mod') !== false) |
|
2110 | + foreach ($_SESSION['token'] as $key => $token) { |
|
2111 | + if (strpos($key, '-mod') !== false) |
|
2077 | 2112 | unset($_SESSION['token'][$key]); |
2113 | + } |
|
2078 | 2114 | |
2079 | 2115 | redirectexit(); |
2080 | 2116 | } |
@@ -23,13 +23,13 @@ discard block |
||
23 | 23 | { |
24 | 24 | global $context, $txt; |
25 | 25 | |
26 | - if (!empty($context['simple_action'])) |
|
27 | - echo ' |
|
26 | + if (!empty($context['simple_action'])) { |
|
27 | + echo ' |
|
28 | 28 | <strong> |
29 | 29 | ', $context['error_title'], ' |
30 | 30 | </strong><br> |
31 | 31 | <div ', $context['error_code'], 'class="padding">', $context['error_message'], '</div>'; |
32 | - else |
|
32 | + } else |
|
33 | 33 | { |
34 | 34 | echo ' |
35 | 35 | <div id="fatal_error"> |
@@ -82,21 +82,23 @@ discard block |
||
82 | 82 | ', $txt['apply_filter_of_type'], ':'; |
83 | 83 | |
84 | 84 | $error_types = array(); |
85 | - foreach ($context['error_types'] as $type => $details) |
|
86 | - $error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>'; |
|
85 | + foreach ($context['error_types'] as $type => $details) { |
|
86 | + $error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>'; |
|
87 | + } |
|
87 | 88 | |
88 | 89 | echo ' |
89 | 90 | ', implode(' | ', $error_types), ' |
90 | 91 | </td> |
91 | 92 | </tr>'; |
92 | 93 | |
93 | - if ($context['has_filter']) |
|
94 | - echo ' |
|
94 | + if ($context['has_filter']) { |
|
95 | + echo ' |
|
95 | 96 | <tr> |
96 | 97 | <td colspan="3" class="windowbg"> |
97 | 98 | <strong> ', $txt['applying_filter'], ':</strong> ', $context['filter']['entity'], ' ', $context['filter']['value']['html'], ' [<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', '">', $txt['clear_filter'], '</a>] |
98 | 99 | </td> |
99 | 100 | </tr>'; |
101 | + } |
|
100 | 102 | |
101 | 103 | echo ' |
102 | 104 | <tr> |
@@ -107,11 +109,12 @@ discard block |
||
107 | 109 | </tr>'; |
108 | 110 | |
109 | 111 | // No errors, then show a message |
110 | - if (count($context['errors']) == 0) |
|
111 | - echo ' |
|
112 | + if (count($context['errors']) == 0) { |
|
113 | + echo ' |
|
112 | 114 | <tr class="windowbg"> |
113 | 115 | <td class="centertext" colspan="2">', $txt['errlog_no_entries'], '</td> |
114 | 116 | </tr>'; |
117 | + } |
|
115 | 118 | |
116 | 119 | // we have some errors, must be some mods installed :P |
117 | 120 | foreach ($context['errors'] as $error) |
@@ -125,19 +128,21 @@ discard block |
||
125 | 128 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? '' : ';desc', $context['has_filter'] ? $context['filter']['href'] : '', '" title="', $txt['reverse_direction'], '"><span class="generic_icons sort_' . $context['sort_direction'] . '"></span></a> |
126 | 129 | ', $error['time'], '<br>'; |
127 | 130 | |
128 | - if (!empty($error['member']['ip'])) |
|
129 | - echo ' |
|
131 | + if (!empty($error['member']['ip'])) { |
|
132 | + echo ' |
|
130 | 133 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=ip;value=', $error['member']['ip'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_ip'], '"><span class="generic_icons filter centericon"></span></a> |
131 | 134 | <strong><a href="', $scripturl, '?action=trackip;searchip=', $error['member']['ip'], '">', $error['member']['ip'], '</a></strong> <br>'; |
135 | + } |
|
132 | 136 | |
133 | 137 | echo ' |
134 | 138 | </div> |
135 | 139 | <div style="float: left; width: 50%; line-height: 1.8em; padding: 0 4px;">'; |
136 | 140 | |
137 | - if ($error['member']['session'] != '') |
|
138 | - echo ' |
|
141 | + if ($error['member']['session'] != '') { |
|
142 | + echo ' |
|
139 | 143 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=session;value=', $error['member']['session'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_session'], '"><span class="generic_icons filter centericon"></span></a> |
140 | 144 | ', $error['member']['session'], '<br>'; |
145 | + } |
|
141 | 146 | |
142 | 147 | echo ' |
143 | 148 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=error_type;value=', $error['error_type']['type'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_type'], '"><span class="generic_icons filter centericon"></span></a> |
@@ -151,8 +156,8 @@ discard block |
||
151 | 156 | <a style="display: table-cell;" href="', $error['url']['html'], '">', $error['url']['html'], '</a> |
152 | 157 | </div>'; |
153 | 158 | |
154 | - if (!empty($error['file'])) |
|
155 | - echo ' |
|
159 | + if (!empty($error['file'])) { |
|
160 | + echo ' |
|
156 | 161 | <div style="float: left; width: 100%; padding: 4px 0; line-height: 1.6em; border-top: 1px solid #e3e3e3;"> |
157 | 162 | <a style="display: table-cell; padding: 4px; width: 20px; vertical-align: top;" href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=file;value=', $error['file']['search'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_file'], '"><span class="generic_icons filter"></span></a> |
158 | 163 | <div> |
@@ -160,6 +165,7 @@ discard block |
||
160 | 165 | ', $txt['line'], ': ', $error['file']['line'], ' |
161 | 166 | </div> |
162 | 167 | </div>'; |
168 | + } |
|
163 | 169 | |
164 | 170 | echo ' |
165 | 171 | </td> |
@@ -187,9 +193,10 @@ discard block |
||
187 | 193 | </div> |
188 | 194 | </div>'; |
189 | 195 | |
190 | - if ($context['sort_direction'] == 'down') |
|
191 | - echo ' |
|
196 | + if ($context['sort_direction'] == 'down') { |
|
197 | + echo ' |
|
192 | 198 | <input type="hidden" name="desc" value="1">'; |
199 | + } |
|
193 | 200 | |
194 | 201 | echo ' |
195 | 202 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Create a menu. |
@@ -64,22 +65,26 @@ discard block |
||
64 | 65 | $menu_context['current_action'] = isset($menuOptions['action']) ? $menuOptions['action'] : $context['current_action']; |
65 | 66 | |
66 | 67 | // Allow extend *any* menu with a single hook |
67 | - if (!empty($menu_context['current_action'])) |
|
68 | - call_integration_hook('integrate_' . $menu_context['current_action'] . '_areas', array(&$menuData)); |
|
68 | + if (!empty($menu_context['current_action'])) { |
|
69 | + call_integration_hook('integrate_' . $menu_context['current_action'] . '_areas', array(&$menuData)); |
|
70 | + } |
|
69 | 71 | |
70 | 72 | // What is the current area selected? |
71 | - if (isset($menuOptions['current_area']) || isset($_GET['area'])) |
|
72 | - $menu_context['current_area'] = isset($menuOptions['current_area']) ? $menuOptions['current_area'] : $_GET['area']; |
|
73 | + if (isset($menuOptions['current_area']) || isset($_GET['area'])) { |
|
74 | + $menu_context['current_area'] = isset($menuOptions['current_area']) ? $menuOptions['current_area'] : $_GET['area']; |
|
75 | + } |
|
73 | 76 | |
74 | 77 | // Build a list of additional parameters that should go in the URL. |
75 | 78 | $menu_context['extra_parameters'] = ''; |
76 | - if (!empty($menuOptions['extra_url_parameters'])) |
|
77 | - foreach ($menuOptions['extra_url_parameters'] as $key => $value) |
|
79 | + if (!empty($menuOptions['extra_url_parameters'])) { |
|
80 | + foreach ($menuOptions['extra_url_parameters'] as $key => $value) |
|
78 | 81 | $menu_context['extra_parameters'] .= ';' . $key . '=' . $value; |
82 | + } |
|
79 | 83 | |
80 | 84 | // Only include the session ID in the URL if it's strictly necessary. |
81 | - if (empty($menuOptions['disable_url_session_check'])) |
|
82 | - $menu_context['extra_parameters'] .= ';' . $context['session_var'] . '=' . $context['session_id']; |
|
85 | + if (empty($menuOptions['disable_url_session_check'])) { |
|
86 | + $menu_context['extra_parameters'] .= ';' . $context['session_var'] . '=' . $context['session_id']; |
|
87 | + } |
|
83 | 88 | |
84 | 89 | $include_data = array(); |
85 | 90 | |
@@ -87,8 +92,9 @@ discard block |
||
87 | 92 | foreach ($menuData as $section_id => $section) |
88 | 93 | { |
89 | 94 | // Is this enabled - or has as permission check - which fails? |
90 | - if ((isset($section['enabled']) && $section['enabled'] == false) || (isset($section['permission']) && !allowedTo($section['permission']))) |
|
91 | - continue; |
|
95 | + if ((isset($section['enabled']) && $section['enabled'] == false) || (isset($section['permission']) && !allowedTo($section['permission']))) { |
|
96 | + continue; |
|
97 | + } |
|
92 | 98 | |
93 | 99 | // Now we cycle through the sections to pick the right area. |
94 | 100 | foreach ($section['areas'] as $area_id => $area) |
@@ -110,59 +116,57 @@ discard block |
||
110 | 116 | if (empty($area['hidden'])) |
111 | 117 | { |
112 | 118 | // First time this section? |
113 | - if (!isset($menu_context['sections'][$section_id])) |
|
114 | - $menu_context['sections'][$section_id]['title'] = $section['title']; |
|
119 | + if (!isset($menu_context['sections'][$section_id])) { |
|
120 | + $menu_context['sections'][$section_id]['title'] = $section['title']; |
|
121 | + } |
|
115 | 122 | |
116 | 123 | $menu_context['sections'][$section_id]['areas'][$area_id] = array('label' => isset($area['label']) ? $area['label'] : $txt[$area_id]); |
117 | 124 | // We'll need the ID as well... |
118 | 125 | $menu_context['sections'][$section_id]['id'] = $section_id; |
119 | 126 | // Does it have a custom URL? |
120 | - if (isset($area['custom_url'])) |
|
121 | - $menu_context['sections'][$section_id]['areas'][$area_id]['url'] = $area['custom_url']; |
|
127 | + if (isset($area['custom_url'])) { |
|
128 | + $menu_context['sections'][$section_id]['areas'][$area_id]['url'] = $area['custom_url']; |
|
129 | + } |
|
122 | 130 | |
123 | 131 | // Does this area have its own icon? |
124 | 132 | if (!isset($area['force_menu_into_arms_of_another_menu']) && $user_info['name'] == 'iamanoompaloompa') |
125 | 133 | { |
126 | 134 | $menu_context['sections'][$section_id]['areas'][$area_id] = $smcFunc['json_decode'](base64_decode('eyJsYWJlbCI6Ik9vbXBhIExvb21wYSIsInVybCI6Imh0dHBzOlwvXC9lbi53aWtpcGVkaWEub3JnXC93aWtpXC9Pb21wYV9Mb29tcGFzPyIsImljb24iOiI8aW1nIHNyYz1cImh0dHBzOlwvXC93d3cuc2ltcGxlbWFjaGluZXMub3JnXC9pbWFnZXNcL29vbXBhLmdpZlwiIGFsdD1cIkknbSBhbiBPb21wYSBMb29tcGFcIiBcLz4ifQ=='), true); |
127 | - } |
|
128 | - elseif (isset($area['icon'])) |
|
135 | + } elseif (isset($area['icon'])) |
|
129 | 136 | { |
130 | 137 | if (file_exists($settings['theme_dir'] . '/images/admin/' . $area['icon'])) |
131 | 138 | { |
132 | 139 | $menu_context['sections'][$section_id]['areas'][$area_id]['icon'] = '<img src="' . $settings['images_url'] . '/admin/' . $area['icon'] . '" alt="">'; |
133 | - } |
|
134 | - elseif (file_exists($settings['default_theme_dir'] . '/images/admin/' . $area['icon'])) |
|
140 | + } elseif (file_exists($settings['default_theme_dir'] . '/images/admin/' . $area['icon'])) |
|
135 | 141 | { |
136 | 142 | $menu_context['sections'][$section_id]['areas'][$area_id]['icon'] = '<img src="' . $settings['default_images_url'] . '/admin/' . $area['icon'] . '" alt="">'; |
143 | + } else { |
|
144 | + $menu_context['sections'][$section_id]['areas'][$area_id]['icon'] = '<span class="generic_icons ' . $area['icon'] . '"></span>'; |
|
137 | 145 | } |
138 | - else |
|
139 | - $menu_context['sections'][$section_id]['areas'][$area_id]['icon'] = '<span class="generic_icons ' . $area['icon'] . '"></span>'; |
|
146 | + } else { |
|
147 | + $menu_context['sections'][$section_id]['areas'][$area_id]['icon'] = '<span class="generic_icons ' . $area_id . '"></span>'; |
|
140 | 148 | } |
141 | - else |
|
142 | - $menu_context['sections'][$section_id]['areas'][$area_id]['icon'] = '<span class="generic_icons ' . $area_id . '"></span>'; |
|
143 | 149 | |
144 | 150 | if (isset($area['icon_class']) && empty($menu_context['sections'][$section_id]['areas'][$area_id]['icon'])) |
145 | 151 | { |
146 | 152 | $menu_context['sections'][$section_id]['areas'][$area_id]['icon_class'] = $menu_context['current_action'] . '_menu_icon ' . $area['icon_class']; |
147 | - } |
|
148 | - elseif (isset($area['icon'])) |
|
153 | + } elseif (isset($area['icon'])) |
|
149 | 154 | { |
150 | 155 | if (substr($area['icon'], -4) === '.png' || substr($area['icon'], -4) === '.gif') |
151 | 156 | { |
152 | 157 | if (file_exists($settings['theme_dir'] . '/images/admin/big/' . $area['icon'])) |
153 | 158 | { |
154 | 159 | $menu_context['sections'][$section_id]['areas'][$area_id]['icon_file'] = $settings['theme_url'] . '/images/admin/big/' . $area['icon']; |
155 | - } |
|
156 | - elseif (file_exists($settings['default_theme_dir'] . '/images/admin/big/' . $area['icon'])) |
|
160 | + } elseif (file_exists($settings['default_theme_dir'] . '/images/admin/big/' . $area['icon'])) |
|
157 | 161 | { |
158 | 162 | $menu_context['sections'][$section_id]['areas'][$area_id]['icon_file'] = $settings['default_theme_url'] . '/images/admin/big/' . $area['icon']; |
159 | 163 | } |
160 | 164 | } |
161 | 165 | |
162 | 166 | $menu_context['sections'][$section_id]['areas'][$area_id]['icon_class'] = $menu_context['current_action'] . '_menu_icon ' . str_replace(array('.png', '.gif'), '', $area['icon']); |
167 | + } else { |
|
168 | + $menu_context['sections'][$section_id]['areas'][$area_id]['icon_class'] = $menu_context['current_action'] . '_menu_icon ' . str_replace(array('.png', '.gif'), '', $area_id); |
|
163 | 169 | } |
164 | - else |
|
165 | - $menu_context['sections'][$section_id]['areas'][$area_id]['icon_class'] = $menu_context['current_action'] . '_menu_icon ' . str_replace(array('.png', '.gif'), '', $area_id); |
|
166 | 170 | |
167 | 171 | // This is a shortcut for Font-Icon users so they don't have to re-do whole CSS. |
168 | 172 | $menu_context['sections'][$section_id]['areas'][$area_id]['plain_class'] = !empty($area['icon']) ? $area['icon'] : ''; |
@@ -179,35 +183,41 @@ discard block |
||
179 | 183 | { |
180 | 184 | if ((empty($sub[1]) || allowedTo($sub[1])) && (!isset($sub['enabled']) || !empty($sub['enabled']))) |
181 | 185 | { |
182 | - if ($first_sa == null) |
|
183 | - $first_sa = $sa; |
|
186 | + if ($first_sa == null) { |
|
187 | + $first_sa = $sa; |
|
188 | + } |
|
184 | 189 | |
185 | 190 | $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$sa] = array('label' => $sub[0]); |
186 | 191 | // Custom URL? |
187 | - if (isset($sub['url'])) |
|
188 | - $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$sa]['url'] = $sub['url']; |
|
192 | + if (isset($sub['url'])) { |
|
193 | + $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$sa]['url'] = $sub['url']; |
|
194 | + } |
|
189 | 195 | |
190 | 196 | // A bit complicated - but is this set? |
191 | 197 | if ($menu_context['current_area'] == $area_id) |
192 | 198 | { |
193 | 199 | // Save which is the first... |
194 | - if (empty($first_sa)) |
|
195 | - $first_sa = $sa; |
|
200 | + if (empty($first_sa)) { |
|
201 | + $first_sa = $sa; |
|
202 | + } |
|
196 | 203 | |
197 | 204 | // Is this the current subsection? |
198 | - if (isset($_REQUEST['sa']) && $_REQUEST['sa'] == $sa) |
|
199 | - $menu_context['current_subsection'] = $sa; |
|
205 | + if (isset($_REQUEST['sa']) && $_REQUEST['sa'] == $sa) { |
|
206 | + $menu_context['current_subsection'] = $sa; |
|
207 | + } |
|
200 | 208 | // Otherwise is it the default? |
201 | - elseif (!isset($menu_context['current_subsection']) && !empty($sub[2])) |
|
202 | - $menu_context['current_subsection'] = $sa; |
|
209 | + elseif (!isset($menu_context['current_subsection']) && !empty($sub[2])) { |
|
210 | + $menu_context['current_subsection'] = $sa; |
|
211 | + } |
|
203 | 212 | } |
204 | 213 | |
205 | 214 | // Let's assume this is the last, for now. |
206 | 215 | $last_sa = $sa; |
207 | 216 | } |
208 | 217 | // Mark it as disabled... |
209 | - else |
|
210 | - $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$sa]['disabled'] = true; |
|
218 | + else { |
|
219 | + $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$sa]['disabled'] = true; |
|
220 | + } |
|
211 | 221 | } |
212 | 222 | |
213 | 223 | // Set which one is first, last and selected in the group. |
@@ -216,8 +226,9 @@ discard block |
||
216 | 226 | $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$context['right_to_left'] ? $last_sa : $first_sa]['is_first'] = true; |
217 | 227 | $menu_context['sections'][$section_id]['areas'][$area_id]['subsections'][$context['right_to_left'] ? $first_sa : $last_sa]['is_last'] = true; |
218 | 228 | |
219 | - if ($menu_context['current_area'] == $area_id && !isset($menu_context['current_subsection'])) |
|
220 | - $menu_context['current_subsection'] = $first_sa; |
|
229 | + if ($menu_context['current_area'] == $area_id && !isset($menu_context['current_subsection'])) { |
|
230 | + $menu_context['current_subsection'] = $first_sa; |
|
231 | + } |
|
221 | 232 | } |
222 | 233 | } |
223 | 234 | } |
@@ -251,23 +262,26 @@ discard block |
||
251 | 262 | $menu_context['base_url'] = isset($menuOptions['base_url']) ? $menuOptions['base_url'] : $scripturl . '?action=' . $menu_context['current_action']; |
252 | 263 | |
253 | 264 | // If we didn't find the area we were looking for go to a default one. |
254 | - if (isset($backup_area) && empty($found_section)) |
|
255 | - $menu_context['current_area'] = $backup_area; |
|
265 | + if (isset($backup_area) && empty($found_section)) { |
|
266 | + $menu_context['current_area'] = $backup_area; |
|
267 | + } |
|
256 | 268 | |
257 | 269 | // If there are sections quickly goes through all the sections to check if the base menu has an url |
258 | 270 | if (!empty($menu_context['current_section'])) |
259 | 271 | { |
260 | 272 | $menu_context['sections'][$menu_context['current_section']]['selected'] = true; |
261 | 273 | $menu_context['sections'][$menu_context['current_section']]['areas'][$menu_context['current_area']]['selected'] = true; |
262 | - if (!empty($menu_context['sections'][$menu_context['current_section']]['areas'][$menu_context['current_area']]['subsections'][$context['current_subaction']])) |
|
263 | - $menu_context['sections'][$menu_context['current_section']]['areas'][$menu_context['current_area']]['subsections'][$context['current_subaction']]['selected'] = true; |
|
274 | + if (!empty($menu_context['sections'][$menu_context['current_section']]['areas'][$menu_context['current_area']]['subsections'][$context['current_subaction']])) { |
|
275 | + $menu_context['sections'][$menu_context['current_section']]['areas'][$menu_context['current_area']]['subsections'][$context['current_subaction']]['selected'] = true; |
|
276 | + } |
|
264 | 277 | |
265 | - foreach ($menu_context['sections'] as $section_id => $section) |
|
266 | - foreach ($section['areas'] as $area_id => $area) |
|
278 | + foreach ($menu_context['sections'] as $section_id => $section) { |
|
279 | + foreach ($section['areas'] as $area_id => $area) |
|
267 | 280 | { |
268 | 281 | if (!isset($menu_context['sections'][$section_id]['url'])) |
269 | 282 | { |
270 | 283 | $menu_context['sections'][$section_id]['url'] = isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $area_id; |
284 | + } |
|
271 | 285 | break; |
272 | 286 | } |
273 | 287 | } |
@@ -278,8 +292,9 @@ discard block |
||
278 | 292 | { |
279 | 293 | // Never happened! |
280 | 294 | $context['max_menu_id']--; |
281 | - if ($context['max_menu_id'] == 0) |
|
282 | - unset($context['max_menu_id']); |
|
295 | + if ($context['max_menu_id'] == 0) { |
|
296 | + unset($context['max_menu_id']); |
|
297 | + } |
|
283 | 298 | |
284 | 299 | return false; |
285 | 300 | } |
@@ -290,8 +305,9 @@ discard block |
||
290 | 305 | $context['template_layers'][] = $menu_context['layer_name']; |
291 | 306 | |
292 | 307 | // Check we had something - for sanity sake. |
293 | - if (empty($include_data)) |
|
294 | - return false; |
|
308 | + if (empty($include_data)) { |
|
309 | + return false; |
|
310 | + } |
|
295 | 311 | |
296 | 312 | // Finally - return information on the selected item. |
297 | 313 | $include_data += array( |
@@ -314,12 +330,14 @@ discard block |
||
314 | 330 | global $context; |
315 | 331 | |
316 | 332 | $menu_name = $menu_id == 'last' && isset($context['max_menu_id']) && isset($context['menu_data_' . $context['max_menu_id']]) ? 'menu_data_' . $context['max_menu_id'] : 'menu_data_' . $menu_id; |
317 | - if (!isset($context[$menu_name])) |
|
318 | - return false; |
|
333 | + if (!isset($context[$menu_name])) { |
|
334 | + return false; |
|
335 | + } |
|
319 | 336 | |
320 | 337 | $layer_index = array_search($context[$menu_name]['layer_name'], $context['template_layers']); |
321 | - if ($layer_index !== false) |
|
322 | - unset($context['template_layers'][$layer_index]); |
|
338 | + if ($layer_index !== false) { |
|
339 | + unset($context['template_layers'][$layer_index]); |
|
340 | + } |
|
323 | 341 | |
324 | 342 | unset($context[$menu_name]); |
325 | 343 | } |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 4 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * The central part of the board - topic display. |
@@ -34,8 +35,9 @@ discard block |
||
34 | 35 | global $messages_request, $language, $smcFunc; |
35 | 36 | |
36 | 37 | // What are you gonna display if these are empty?! |
37 | - if (empty($topic)) |
|
38 | - fatal_lang_error('no_board', false); |
|
38 | + if (empty($topic)) { |
|
39 | + fatal_lang_error('no_board', false); |
|
40 | + } |
|
39 | 41 | |
40 | 42 | // Load the proper template. |
41 | 43 | loadTemplate('Display'); |
@@ -52,15 +54,17 @@ discard block |
||
52 | 54 | $context['messages_per_page'] = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
53 | 55 | |
54 | 56 | // Let's do some work on what to search index. |
55 | - if (count($_GET) > 2) |
|
56 | - foreach ($_GET as $k => $v) |
|
57 | + if (count($_GET) > 2) { |
|
58 | + foreach ($_GET as $k => $v) |
|
57 | 59 | { |
58 | 60 | if (!in_array($k, array('topic', 'board', 'start', session_name()))) |
59 | 61 | $context['robot_no_index'] = true; |
62 | + } |
|
60 | 63 | } |
61 | 64 | |
62 | - if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) |
|
63 | - $context['robot_no_index'] = true; |
|
65 | + if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) { |
|
66 | + $context['robot_no_index'] = true; |
|
67 | + } |
|
64 | 68 | |
65 | 69 | // Find the previous or next topic. Make a fuss if there are no more. |
66 | 70 | if (isset($_REQUEST['prev_next']) && ($_REQUEST['prev_next'] == 'prev' || $_REQUEST['prev_next'] == 'next')) |
@@ -172,8 +176,9 @@ discard block |
||
172 | 176 | $topic_parameters |
173 | 177 | ); |
174 | 178 | |
175 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
176 | - fatal_lang_error('not_a_topic', false, 404); |
|
179 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
180 | + fatal_lang_error('not_a_topic', false, 404); |
|
181 | + } |
|
177 | 182 | $context['topicinfo'] = $smcFunc['db_fetch_assoc']($request); |
178 | 183 | $smcFunc['db_free_result']($request); |
179 | 184 | |
@@ -210,8 +215,9 @@ discard block |
||
210 | 215 | $context['topic_unwatched'] = isset($context['topicinfo']['unwatched']) ? $context['topicinfo']['unwatched'] : 0; |
211 | 216 | |
212 | 217 | // Add up unapproved replies to get real number of replies... |
213 | - if ($modSettings['postmod_active'] && $approve_posts) |
|
214 | - $context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1); |
|
218 | + if ($modSettings['postmod_active'] && $approve_posts) { |
|
219 | + $context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1); |
|
220 | + } |
|
215 | 221 | |
216 | 222 | // If this topic has unapproved posts, we need to work out how many posts the user can see, for page indexing. |
217 | 223 | if ($modSettings['postmod_active'] && $context['topicinfo']['unapproved_posts'] && !$user_info['is_guest'] && !$approve_posts) |
@@ -231,11 +237,11 @@ discard block |
||
231 | 237 | $smcFunc['db_free_result']($request); |
232 | 238 | |
233 | 239 | $context['total_visible_posts'] = $context['num_replies'] + $myUnapprovedPosts + ($context['topicinfo']['approved'] ? 1 : 0); |
240 | + } elseif ($user_info['is_guest']) { |
|
241 | + $context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
242 | + } else { |
|
243 | + $context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
234 | 244 | } |
235 | - elseif ($user_info['is_guest']) |
|
236 | - $context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
237 | - else |
|
238 | - $context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
239 | 245 | |
240 | 246 | // The start isn't a number; it's information about what to do, where to go. |
241 | 247 | if (!is_numeric($_REQUEST['start'])) |
@@ -248,8 +254,7 @@ discard block |
||
248 | 254 | { |
249 | 255 | $context['start_from'] = $context['total_visible_posts'] - 1; |
250 | 256 | $_REQUEST['start'] = empty($options['view_newest_first']) ? $context['start_from'] : 0; |
251 | - } |
|
252 | - else |
|
257 | + } else |
|
253 | 258 | { |
254 | 259 | // Find the earliest unread message in the topic. (the use of topics here is just for both tables.) |
255 | 260 | $request = $smcFunc['db_query']('', ' |
@@ -277,9 +282,9 @@ discard block |
||
277 | 282 | if (substr($_REQUEST['start'], 0, 4) == 'from') |
278 | 283 | { |
279 | 284 | $timestamp = (int) substr($_REQUEST['start'], 4); |
280 | - if ($timestamp === 0) |
|
281 | - $_REQUEST['start'] = 0; |
|
282 | - else |
|
285 | + if ($timestamp === 0) { |
|
286 | + $_REQUEST['start'] = 0; |
|
287 | + } else |
|
283 | 288 | { |
284 | 289 | // Find the number of messages posted before said time... |
285 | 290 | $request = $smcFunc['db_query']('', ' |
@@ -307,11 +312,11 @@ discard block |
||
307 | 312 | elseif (substr($_REQUEST['start'], 0, 3) == 'msg') |
308 | 313 | { |
309 | 314 | $virtual_msg = (int) substr($_REQUEST['start'], 3); |
310 | - if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg']) |
|
311 | - $context['start_from'] = $context['total_visible_posts'] - 1; |
|
312 | - elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg']) |
|
313 | - $context['start_from'] = 0; |
|
314 | - else |
|
315 | + if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg']) { |
|
316 | + $context['start_from'] = $context['total_visible_posts'] - 1; |
|
317 | + } elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg']) { |
|
318 | + $context['start_from'] = 0; |
|
319 | + } else |
|
315 | 320 | { |
316 | 321 | // Find the start value for that message...... |
317 | 322 | $request = $smcFunc['db_query']('', ' |
@@ -394,21 +399,25 @@ discard block |
||
394 | 399 | ); |
395 | 400 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
396 | 401 | { |
397 | - if (empty($row['id_member'])) |
|
398 | - continue; |
|
402 | + if (empty($row['id_member'])) { |
|
403 | + continue; |
|
404 | + } |
|
399 | 405 | |
400 | - if (!empty($row['online_color'])) |
|
401 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
402 | - else |
|
403 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
406 | + if (!empty($row['online_color'])) { |
|
407 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
408 | + } else { |
|
409 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
410 | + } |
|
404 | 411 | |
405 | 412 | $is_buddy = in_array($row['id_member'], $user_info['buddies']); |
406 | - if ($is_buddy) |
|
407 | - $link = '<strong>' . $link . '</strong>'; |
|
413 | + if ($is_buddy) { |
|
414 | + $link = '<strong>' . $link . '</strong>'; |
|
415 | + } |
|
408 | 416 | |
409 | 417 | // Add them both to the list and to the more detailed list. |
410 | - if (!empty($row['show_online']) || allowedTo('moderate_forum')) |
|
411 | - $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
418 | + if (!empty($row['show_online']) || allowedTo('moderate_forum')) { |
|
419 | + $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
420 | + } |
|
412 | 421 | $context['view_members'][$row['log_time'] . $row['member_name']] = array( |
413 | 422 | 'id' => $row['id_member'], |
414 | 423 | 'username' => $row['member_name'], |
@@ -420,8 +429,9 @@ discard block |
||
420 | 429 | 'hidden' => empty($row['show_online']), |
421 | 430 | ); |
422 | 431 | |
423 | - if (empty($row['show_online'])) |
|
424 | - $context['view_num_hidden']++; |
|
432 | + if (empty($row['show_online'])) { |
|
433 | + $context['view_num_hidden']++; |
|
434 | + } |
|
425 | 435 | } |
426 | 436 | |
427 | 437 | // The number of guests is equal to the rows minus the ones we actually used ;). |
@@ -435,11 +445,13 @@ discard block |
||
435 | 445 | |
436 | 446 | // If all is set, but not allowed... just unset it. |
437 | 447 | $can_show_all = !empty($modSettings['enableAllMessages']) && $context['total_visible_posts'] > $context['messages_per_page'] && $context['total_visible_posts'] < $modSettings['enableAllMessages']; |
438 | - if (isset($_REQUEST['all']) && !$can_show_all) |
|
439 | - unset($_REQUEST['all']); |
|
448 | + if (isset($_REQUEST['all']) && !$can_show_all) { |
|
449 | + unset($_REQUEST['all']); |
|
450 | + } |
|
440 | 451 | // Otherwise, it must be allowed... so pretend start was -1. |
441 | - elseif (isset($_REQUEST['all'])) |
|
442 | - $_REQUEST['start'] = -1; |
|
452 | + elseif (isset($_REQUEST['all'])) { |
|
453 | + $_REQUEST['start'] = -1; |
|
454 | + } |
|
443 | 455 | |
444 | 456 | // Construct the page index, allowing for the .START method... |
445 | 457 | $context['page_index'] = constructPageIndex($scripturl . '?topic=' . $topic . '.%1$d', $_REQUEST['start'], $context['total_visible_posts'], $context['messages_per_page'], true); |
@@ -476,8 +488,9 @@ discard block |
||
476 | 488 | $_REQUEST['start'] = 0; |
477 | 489 | } |
478 | 490 | // They aren't using it, but the *option* is there, at least. |
479 | - else |
|
480 | - $context['page_index'] .= ' <a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> '; |
|
491 | + else { |
|
492 | + $context['page_index'] .= ' <a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> '; |
|
493 | + } |
|
481 | 494 | } |
482 | 495 | |
483 | 496 | // Build the link tree. |
@@ -493,14 +506,16 @@ discard block |
||
493 | 506 | if (!empty($board_info['moderators'])) |
494 | 507 | { |
495 | 508 | // Add a link for each moderator... |
496 | - foreach ($board_info['moderators'] as $mod) |
|
497 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
509 | + foreach ($board_info['moderators'] as $mod) { |
|
510 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
511 | + } |
|
498 | 512 | } |
499 | 513 | if (!empty($board_info['moderator_groups'])) |
500 | 514 | { |
501 | 515 | // Add a link for each moderator group as well... |
502 | - foreach ($board_info['moderator_groups'] as $mod_group) |
|
503 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
516 | + foreach ($board_info['moderator_groups'] as $mod_group) { |
|
517 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
518 | + } |
|
504 | 519 | } |
505 | 520 | |
506 | 521 | if (!empty($context['link_moderators'])) |
@@ -531,9 +546,9 @@ discard block |
||
531 | 546 | // For quick reply we need a response prefix in the default forum language. |
532 | 547 | if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix', 600))) |
533 | 548 | { |
534 | - if ($language === $user_info['language']) |
|
535 | - $context['response_prefix'] = $txt['response_prefix']; |
|
536 | - else |
|
549 | + if ($language === $user_info['language']) { |
|
550 | + $context['response_prefix'] = $txt['response_prefix']; |
|
551 | + } else |
|
537 | 552 | { |
538 | 553 | loadLanguage('index', $language, false); |
539 | 554 | $context['response_prefix'] = $txt['response_prefix']; |
@@ -565,8 +580,9 @@ discard block |
||
565 | 580 | list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row); |
566 | 581 | |
567 | 582 | // Sanity check |
568 | - if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) |
|
569 | - continue; |
|
583 | + if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) { |
|
584 | + continue; |
|
585 | + } |
|
570 | 586 | |
571 | 587 | $linked_calendar_event = array( |
572 | 588 | 'id' => $row['id_event'], |
@@ -615,8 +631,9 @@ discard block |
||
615 | 631 | } |
616 | 632 | $smcFunc['db_free_result']($request); |
617 | 633 | |
618 | - if (!empty($context['linked_calendar_events'])) |
|
619 | - $context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true; |
|
634 | + if (!empty($context['linked_calendar_events'])) { |
|
635 | + $context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true; |
|
636 | + } |
|
620 | 637 | } |
621 | 638 | |
622 | 639 | // Create the poll info if it exists. |
@@ -679,8 +696,9 @@ discard block |
||
679 | 696 | $smcFunc['db_free_result']($request); |
680 | 697 | |
681 | 698 | // Got we multi choice? |
682 | - if ($pollinfo['max_votes'] > 1) |
|
683 | - $realtotal = $pollinfo['total']; |
|
699 | + if ($pollinfo['max_votes'] > 1) { |
|
700 | + $realtotal = $pollinfo['total']; |
|
701 | + } |
|
684 | 702 | |
685 | 703 | // If this is a guest we need to do our best to work out if they have voted, and what they voted for. |
686 | 704 | if ($user_info['is_guest'] && $pollinfo['guest_vote'] && allowedTo('poll_vote')) |
@@ -693,20 +711,21 @@ discard block |
||
693 | 711 | foreach ($guestinfo as $i => $guestvoted) |
694 | 712 | { |
695 | 713 | $guestvoted = explode(',', $guestvoted); |
696 | - if ($guestvoted[0] == $context['topicinfo']['id_poll']) |
|
697 | - break; |
|
714 | + if ($guestvoted[0] == $context['topicinfo']['id_poll']) { |
|
715 | + break; |
|
716 | + } |
|
698 | 717 | } |
699 | 718 | // Has the poll been reset since guest voted? |
700 | 719 | if ($pollinfo['reset_poll'] > $guestvoted[1]) |
701 | 720 | { |
702 | 721 | // Remove the poll info from the cookie to allow guest to vote again |
703 | 722 | unset($guestinfo[$i]); |
704 | - if (!empty($guestinfo)) |
|
705 | - $_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo); |
|
706 | - else |
|
707 | - unset($_COOKIE['guest_poll_vote']); |
|
708 | - } |
|
709 | - else |
|
723 | + if (!empty($guestinfo)) { |
|
724 | + $_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo); |
|
725 | + } else { |
|
726 | + unset($_COOKIE['guest_poll_vote']); |
|
727 | + } |
|
728 | + } else |
|
710 | 729 | { |
711 | 730 | // What did they vote for? |
712 | 731 | unset($guestvoted[0], $guestvoted[1]); |
@@ -820,23 +839,29 @@ discard block |
||
820 | 839 | // Build the poll moderation button array. |
821 | 840 | $context['poll_buttons'] = array(); |
822 | 841 | |
823 | - if ($context['allow_return_vote']) |
|
824 | - $context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']); |
|
842 | + if ($context['allow_return_vote']) { |
|
843 | + $context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']); |
|
844 | + } |
|
825 | 845 | |
826 | - if ($context['show_view_results_button']) |
|
827 | - $context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults'); |
|
846 | + if ($context['show_view_results_button']) { |
|
847 | + $context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults'); |
|
848 | + } |
|
828 | 849 | |
829 | - if ($context['allow_change_vote']) |
|
830 | - $context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
850 | + if ($context['allow_change_vote']) { |
|
851 | + $context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
852 | + } |
|
831 | 853 | |
832 | - if ($context['allow_lock_poll']) |
|
833 | - $context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
854 | + if ($context['allow_lock_poll']) { |
|
855 | + $context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
856 | + } |
|
834 | 857 | |
835 | - if ($context['allow_edit_poll']) |
|
836 | - $context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
858 | + if ($context['allow_edit_poll']) { |
|
859 | + $context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
860 | + } |
|
837 | 861 | |
838 | - if ($context['can_remove_poll']) |
|
839 | - $context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
862 | + if ($context['can_remove_poll']) { |
|
863 | + $context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
864 | + } |
|
840 | 865 | |
841 | 866 | // Allow mods to add additional buttons here |
842 | 867 | call_integration_hook('integrate_poll_buttons'); |
@@ -871,9 +896,9 @@ discard block |
||
871 | 896 | { |
872 | 897 | $start_char = 'C'; |
873 | 898 | $page_id = $context['topicinfo']['id_first_msg']; |
899 | + } else { |
|
900 | + $start_char = null; |
|
874 | 901 | } |
875 | - else |
|
876 | - $start_char = null; |
|
877 | 902 | |
878 | 903 | $limit = $context['messages_per_page']; |
879 | 904 | |
@@ -888,17 +913,17 @@ discard block |
||
888 | 913 | { |
889 | 914 | $ascending = true; |
890 | 915 | $page_operator = '>='; |
891 | - } |
|
892 | - else |
|
916 | + } else |
|
893 | 917 | { |
894 | 918 | $ascending = false; |
895 | 919 | $page_operator = '<='; |
896 | 920 | } |
897 | 921 | |
898 | - if ($start_char === 'C') |
|
899 | - $limit_seek = $limit; |
|
900 | - else |
|
901 | - $limit_seek = $limit + 1; |
|
922 | + if ($start_char === 'C') { |
|
923 | + $limit_seek = $limit; |
|
924 | + } else { |
|
925 | + $limit_seek = $limit + 1; |
|
926 | + } |
|
902 | 927 | |
903 | 928 | $request = $smcFunc['db_query']('', ' |
904 | 929 | SELECT id_msg, id_member, approved |
@@ -921,21 +946,23 @@ discard block |
||
921 | 946 | $found_msg = false; |
922 | 947 | |
923 | 948 | // Fallback |
924 | - if ($smcFunc['db_num_rows']($request) < 1) |
|
925 | - unset($start_char); |
|
926 | - else |
|
949 | + if ($smcFunc['db_num_rows']($request) < 1) { |
|
950 | + unset($start_char); |
|
951 | + } else |
|
927 | 952 | { |
928 | 953 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
929 | 954 | { |
930 | 955 | // Check if the start msg is in our result |
931 | - if ($row['id_msg'] == $page_id) |
|
932 | - $found_msg = true; |
|
956 | + if ($row['id_msg'] == $page_id) { |
|
957 | + $found_msg = true; |
|
958 | + } |
|
933 | 959 | |
934 | 960 | // Skip the the start msg if we not in mode C |
935 | 961 | if ($start_char === 'C' || $row['id_msg'] != $page_id) |
936 | 962 | { |
937 | - if (!empty($row['id_member'])) |
|
938 | - $all_posters[$row['id_msg']] = $row['id_member']; |
|
963 | + if (!empty($row['id_member'])) { |
|
964 | + $all_posters[$row['id_msg']] = $row['id_member']; |
|
965 | + } |
|
939 | 966 | |
940 | 967 | $messages[] = $row['id_msg']; |
941 | 968 | } |
@@ -951,8 +978,9 @@ discard block |
||
951 | 978 | } |
952 | 979 | |
953 | 980 | // Before Page bring in the right order |
954 | - if (!empty($start_char) && $start_char === 'L') |
|
955 | - krsort($messages); |
|
981 | + if (!empty($start_char) && $start_char === 'L') { |
|
982 | + krsort($messages); |
|
983 | + } |
|
956 | 984 | } |
957 | 985 | |
958 | 986 | // Jump to page |
@@ -989,14 +1017,16 @@ discard block |
||
989 | 1017 | |
990 | 1018 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
991 | 1019 | { |
992 | - if (!empty($row['id_member'])) |
|
993 | - $all_posters[$row['id_msg']] = $row['id_member']; |
|
1020 | + if (!empty($row['id_member'])) { |
|
1021 | + $all_posters[$row['id_msg']] = $row['id_member']; |
|
1022 | + } |
|
994 | 1023 | $messages[] = $row['id_msg']; |
995 | 1024 | } |
996 | 1025 | |
997 | 1026 | // Sort the messages into the correct display order |
998 | - if (!$ascending) |
|
999 | - sort($messages); |
|
1027 | + if (!$ascending) { |
|
1028 | + sort($messages); |
|
1029 | + } |
|
1000 | 1030 | } |
1001 | 1031 | |
1002 | 1032 | // Remember the paging data for next time |
@@ -1016,8 +1046,9 @@ discard block |
||
1016 | 1046 | if (!$user_info['is_guest'] && !empty($messages)) |
1017 | 1047 | { |
1018 | 1048 | $mark_at_msg = max($messages); |
1019 | - if ($mark_at_msg >= $context['topicinfo']['id_last_msg']) |
|
1020 | - $mark_at_msg = $modSettings['maxMsgID']; |
|
1049 | + if ($mark_at_msg >= $context['topicinfo']['id_last_msg']) { |
|
1050 | + $mark_at_msg = $modSettings['maxMsgID']; |
|
1051 | + } |
|
1021 | 1052 | if ($mark_at_msg >= $context['topicinfo']['new_from']) |
1022 | 1053 | { |
1023 | 1054 | $smcFunc['db_insert']($context['topicinfo']['new_from'] == 0 ? 'ignore' : 'replace', |
@@ -1049,8 +1080,9 @@ discard block |
||
1049 | 1080 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1050 | 1081 | { |
1051 | 1082 | // Find if this topic is marked for notification... |
1052 | - if (!empty($row['id_topic'])) |
|
1053 | - $context['is_marked_notify'] = true; |
|
1083 | + if (!empty($row['id_topic'])) { |
|
1084 | + $context['is_marked_notify'] = true; |
|
1085 | + } |
|
1054 | 1086 | |
1055 | 1087 | // Only do this once, but mark the notifications as "not sent yet" for next time. |
1056 | 1088 | if (!empty($row['sent']) && $do_once) |
@@ -1072,8 +1104,9 @@ discard block |
||
1072 | 1104 | } |
1073 | 1105 | |
1074 | 1106 | // Have we recently cached the number of new topics in this board, and it's still a lot? |
1075 | - if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5) |
|
1076 | - $_SESSION['topicseen_cache'][$board]--; |
|
1107 | + if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5) { |
|
1108 | + $_SESSION['topicseen_cache'][$board]--; |
|
1109 | + } |
|
1077 | 1110 | // Mark board as seen if this is the only new topic. |
1078 | 1111 | elseif (isset($_REQUEST['topicseen'])) |
1079 | 1112 | { |
@@ -1097,14 +1130,16 @@ discard block |
||
1097 | 1130 | $smcFunc['db_free_result']($request); |
1098 | 1131 | |
1099 | 1132 | // If there're no real new topics in this board, mark the board as seen. |
1100 | - if (empty($numNewTopics)) |
|
1101 | - $_REQUEST['boardseen'] = true; |
|
1102 | - else |
|
1103 | - $_SESSION['topicseen_cache'][$board] = $numNewTopics; |
|
1133 | + if (empty($numNewTopics)) { |
|
1134 | + $_REQUEST['boardseen'] = true; |
|
1135 | + } else { |
|
1136 | + $_SESSION['topicseen_cache'][$board] = $numNewTopics; |
|
1137 | + } |
|
1104 | 1138 | } |
1105 | 1139 | // Probably one less topic - maybe not, but even if we decrease this too fast it will only make us look more often. |
1106 | - elseif (isset($_SESSION['topicseen_cache'][$board])) |
|
1107 | - $_SESSION['topicseen_cache'][$board]--; |
|
1140 | + elseif (isset($_SESSION['topicseen_cache'][$board])) { |
|
1141 | + $_SESSION['topicseen_cache'][$board]--; |
|
1142 | + } |
|
1108 | 1143 | |
1109 | 1144 | // Mark board as seen if we came using last post link from BoardIndex. (or other places...) |
1110 | 1145 | if (isset($_REQUEST['boardseen'])) |
@@ -1161,23 +1196,26 @@ discard block |
||
1161 | 1196 | $temp = array(); |
1162 | 1197 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1163 | 1198 | { |
1164 | - if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id'])) |
|
1165 | - continue; |
|
1199 | + if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id'])) { |
|
1200 | + continue; |
|
1201 | + } |
|
1166 | 1202 | |
1167 | 1203 | $temp[$row['id_attach']] = $row; |
1168 | 1204 | $temp[$row['id_attach']]['topic'] = $topic; |
1169 | 1205 | $temp[$row['id_attach']]['board'] = $board; |
1170 | 1206 | |
1171 | - if (!isset($context['loaded_attachments'][$row['id_msg']])) |
|
1172 | - $context['loaded_attachments'][$row['id_msg']] = array(); |
|
1207 | + if (!isset($context['loaded_attachments'][$row['id_msg']])) { |
|
1208 | + $context['loaded_attachments'][$row['id_msg']] = array(); |
|
1209 | + } |
|
1173 | 1210 | } |
1174 | 1211 | $smcFunc['db_free_result']($request); |
1175 | 1212 | |
1176 | 1213 | // This is better than sorting it with the query... |
1177 | 1214 | ksort($temp); |
1178 | 1215 | |
1179 | - foreach ($temp as $row) |
|
1180 | - $context['loaded_attachments'][$row['id_msg']][] = $row; |
|
1216 | + foreach ($temp as $row) { |
|
1217 | + $context['loaded_attachments'][$row['id_msg']][] = $row; |
|
1218 | + } |
|
1181 | 1219 | } |
1182 | 1220 | |
1183 | 1221 | $msg_parameters = array( |
@@ -1204,21 +1242,23 @@ discard block |
||
1204 | 1242 | ); |
1205 | 1243 | |
1206 | 1244 | // And the likes |
1207 | - if (!empty($modSettings['enable_likes'])) |
|
1208 | - $context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic); |
|
1245 | + if (!empty($modSettings['enable_likes'])) { |
|
1246 | + $context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic); |
|
1247 | + } |
|
1209 | 1248 | |
1210 | 1249 | // Go to the last message if the given time is beyond the time of the last message. |
1211 | - if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies']) |
|
1212 | - $context['start_from'] = $context['topicinfo']['num_replies']; |
|
1250 | + if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies']) { |
|
1251 | + $context['start_from'] = $context['topicinfo']['num_replies']; |
|
1252 | + } |
|
1213 | 1253 | |
1214 | 1254 | // Since the anchor information is needed on the top of the page we load these variables beforehand. |
1215 | 1255 | $context['first_message'] = isset($messages[$firstIndex]) ? $messages[$firstIndex] : $messages[0]; |
1216 | - if (empty($options['view_newest_first'])) |
|
1217 | - $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from']; |
|
1218 | - else |
|
1219 | - $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from']; |
|
1220 | - } |
|
1221 | - else |
|
1256 | + if (empty($options['view_newest_first'])) { |
|
1257 | + $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from']; |
|
1258 | + } else { |
|
1259 | + $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from']; |
|
1260 | + } |
|
1261 | + } else |
|
1222 | 1262 | { |
1223 | 1263 | $messages_request = false; |
1224 | 1264 | $context['first_message'] = 0; |
@@ -1254,8 +1294,9 @@ discard block |
||
1254 | 1294 | 'can_see_likes' => 'likes_view', |
1255 | 1295 | 'can_like' => 'likes_like', |
1256 | 1296 | ); |
1257 | - foreach ($common_permissions as $contextual => $perm) |
|
1258 | - $context[$contextual] = allowedTo($perm); |
|
1297 | + foreach ($common_permissions as $contextual => $perm) { |
|
1298 | + $context[$contextual] = allowedTo($perm); |
|
1299 | + } |
|
1259 | 1300 | |
1260 | 1301 | // Permissions with _any/_own versions. $context[YYY] => ZZZ_any/_own. |
1261 | 1302 | $anyown_permissions = array( |
@@ -1268,8 +1309,9 @@ discard block |
||
1268 | 1309 | 'can_reply_unapproved' => 'post_unapproved_replies', |
1269 | 1310 | 'can_view_warning' => 'profile_warning', |
1270 | 1311 | ); |
1271 | - foreach ($anyown_permissions as $contextual => $perm) |
|
1272 | - $context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own')); |
|
1312 | + foreach ($anyown_permissions as $contextual => $perm) { |
|
1313 | + $context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own')); |
|
1314 | + } |
|
1273 | 1315 | |
1274 | 1316 | if (!$user_info['is_admin'] && !$modSettings['topic_move_any']) |
1275 | 1317 | { |
@@ -1315,8 +1357,9 @@ discard block |
||
1315 | 1357 | // Check if the draft functions are enabled and that they have permission to use them (for quick reply.) |
1316 | 1358 | $context['drafts_save'] = !empty($modSettings['drafts_post_enabled']) && allowedTo('post_draft') && $context['can_reply']; |
1317 | 1359 | $context['drafts_autosave'] = !empty($context['drafts_save']) && !empty($modSettings['drafts_autosave_enabled']); |
1318 | - if (!empty($context['drafts_save'])) |
|
1319 | - loadLanguage('Drafts'); |
|
1360 | + if (!empty($context['drafts_save'])) { |
|
1361 | + loadLanguage('Drafts'); |
|
1362 | + } |
|
1320 | 1363 | |
1321 | 1364 | // When was the last time this topic was replied to? Should we warn them about it? |
1322 | 1365 | if (!empty($modSettings['oldTopicDays']) && ($context['can_reply'] || $context['can_reply_unapproved']) && empty($context['topicinfo']['is_sticky'])) |
@@ -1377,26 +1420,31 @@ discard block |
||
1377 | 1420 | // Message icons - customized icons are off? |
1378 | 1421 | $context['icons'] = getMessageIcons($board); |
1379 | 1422 | |
1380 | - if (!empty($context['icons'])) |
|
1381 | - $context['icons'][count($context['icons']) - 1]['is_last'] = true; |
|
1423 | + if (!empty($context['icons'])) { |
|
1424 | + $context['icons'][count($context['icons']) - 1]['is_last'] = true; |
|
1425 | + } |
|
1382 | 1426 | |
1383 | 1427 | // Build the normal button array. |
1384 | 1428 | $context['normal_buttons'] = array(); |
1385 | 1429 | |
1386 | - if ($context['can_reply']) |
|
1387 | - $context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true); |
|
1430 | + if ($context['can_reply']) { |
|
1431 | + $context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true); |
|
1432 | + } |
|
1388 | 1433 | |
1389 | - if ($context['can_add_poll']) |
|
1390 | - $context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
1434 | + if ($context['can_add_poll']) { |
|
1435 | + $context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
1436 | + } |
|
1391 | 1437 | |
1392 | - if ($context['can_mark_unread']) |
|
1393 | - $context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1438 | + if ($context['can_mark_unread']) { |
|
1439 | + $context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1440 | + } |
|
1394 | 1441 | |
1395 | - if ($context['can_print']) |
|
1396 | - $context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'); |
|
1442 | + if ($context['can_print']) { |
|
1443 | + $context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'); |
|
1444 | + } |
|
1397 | 1445 | |
1398 | - if ($context['can_set_notify']) |
|
1399 | - $context['normal_buttons']['notify'] = array( |
|
1446 | + if ($context['can_set_notify']) { |
|
1447 | + $context['normal_buttons']['notify'] = array( |
|
1400 | 1448 | 'text' => 'notify_topic_' . $context['topic_notification_mode'], |
1401 | 1449 | 'sub_buttons' => array( |
1402 | 1450 | array( |
@@ -1418,38 +1466,47 @@ discard block |
||
1418 | 1466 | ), |
1419 | 1467 | ), |
1420 | 1468 | ); |
1469 | + } |
|
1421 | 1470 | |
1422 | 1471 | // Build the mod button array |
1423 | 1472 | $context['mod_buttons'] = array(); |
1424 | 1473 | |
1425 | - if ($context['can_move']) |
|
1426 | - $context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1474 | + if ($context['can_move']) { |
|
1475 | + $context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1476 | + } |
|
1427 | 1477 | |
1428 | - if ($context['can_delete']) |
|
1429 | - $context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
1478 | + if ($context['can_delete']) { |
|
1479 | + $context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
1480 | + } |
|
1430 | 1481 | |
1431 | - if ($context['can_lock']) |
|
1432 | - $context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1482 | + if ($context['can_lock']) { |
|
1483 | + $context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1484 | + } |
|
1433 | 1485 | |
1434 | - if ($context['can_sticky']) |
|
1435 | - $context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1486 | + if ($context['can_sticky']) { |
|
1487 | + $context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1488 | + } |
|
1436 | 1489 | |
1437 | - if ($context['can_merge']) |
|
1438 | - $context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']); |
|
1490 | + if ($context['can_merge']) { |
|
1491 | + $context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']); |
|
1492 | + } |
|
1439 | 1493 | |
1440 | - if ($context['calendar_post']) |
|
1441 | - $context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1494 | + if ($context['calendar_post']) { |
|
1495 | + $context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1496 | + } |
|
1442 | 1497 | |
1443 | 1498 | // Restore topic. eh? No monkey business. |
1444 | - if ($context['can_restore_topic']) |
|
1445 | - $context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1499 | + if ($context['can_restore_topic']) { |
|
1500 | + $context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1501 | + } |
|
1446 | 1502 | |
1447 | 1503 | // Show a message in case a recently posted message became unapproved. |
1448 | 1504 | $context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false; |
1449 | 1505 | |
1450 | 1506 | // Don't want to show this forever... |
1451 | - if ($context['becomesUnapproved']) |
|
1452 | - unset($_SESSION['becomesUnapproved']); |
|
1507 | + if ($context['becomesUnapproved']) { |
|
1508 | + unset($_SESSION['becomesUnapproved']); |
|
1509 | + } |
|
1453 | 1510 | |
1454 | 1511 | // Allow adding new mod buttons easily. |
1455 | 1512 | // Note: $context['normal_buttons'] and $context['mod_buttons'] are added for backward compatibility with 2.0, but are deprecated and should not be used |
@@ -1458,12 +1515,14 @@ discard block |
||
1458 | 1515 | call_integration_hook('integrate_mod_buttons', array(&$context['mod_buttons'])); |
1459 | 1516 | |
1460 | 1517 | // Load the drafts js file |
1461 | - if ($context['drafts_autosave']) |
|
1462 | - loadJavaScriptFile('drafts.js', array('defer' => false), 'smf_drafts'); |
|
1518 | + if ($context['drafts_autosave']) { |
|
1519 | + loadJavaScriptFile('drafts.js', array('defer' => false), 'smf_drafts'); |
|
1520 | + } |
|
1463 | 1521 | |
1464 | 1522 | // Spellcheck |
1465 | - if ($context['show_spellchecking']) |
|
1466 | - loadJavaScriptFile('spellcheck.js', array('defer' => false), 'smf_spellcheck'); |
|
1523 | + if ($context['show_spellchecking']) { |
|
1524 | + loadJavaScriptFile('spellcheck.js', array('defer' => false), 'smf_spellcheck'); |
|
1525 | + } |
|
1467 | 1526 | |
1468 | 1527 | // topic.js |
1469 | 1528 | loadJavaScriptFile('topic.js', array('defer' => false), 'smf_topic'); |
@@ -1497,16 +1556,19 @@ discard block |
||
1497 | 1556 | static $counter = null; |
1498 | 1557 | |
1499 | 1558 | // If the query returned false, bail. |
1500 | - if ($messages_request == false) |
|
1501 | - return false; |
|
1559 | + if ($messages_request == false) { |
|
1560 | + return false; |
|
1561 | + } |
|
1502 | 1562 | |
1503 | 1563 | // Remember which message this is. (ie. reply #83) |
1504 | - if ($counter === null || $reset) |
|
1505 | - $counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start']; |
|
1564 | + if ($counter === null || $reset) { |
|
1565 | + $counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start']; |
|
1566 | + } |
|
1506 | 1567 | |
1507 | 1568 | // Start from the beginning... |
1508 | - if ($reset) |
|
1509 | - return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1569 | + if ($reset) { |
|
1570 | + return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1571 | + } |
|
1510 | 1572 | |
1511 | 1573 | // Attempt to get the next message. |
1512 | 1574 | $message = $smcFunc['db_fetch_assoc']($messages_request); |
@@ -1520,19 +1582,21 @@ discard block |
||
1520 | 1582 | if (empty($context['icon_sources'])) |
1521 | 1583 | { |
1522 | 1584 | $context['icon_sources'] = array(); |
1523 | - foreach ($context['stable_icons'] as $icon) |
|
1524 | - $context['icon_sources'][$icon] = 'images_url'; |
|
1585 | + foreach ($context['stable_icons'] as $icon) { |
|
1586 | + $context['icon_sources'][$icon] = 'images_url'; |
|
1587 | + } |
|
1525 | 1588 | } |
1526 | 1589 | |
1527 | 1590 | // Message Icon Management... check the images exist. |
1528 | 1591 | if (empty($modSettings['messageIconChecks_disable'])) |
1529 | 1592 | { |
1530 | 1593 | // If the current icon isn't known, then we need to do something... |
1531 | - if (!isset($context['icon_sources'][$message['icon']])) |
|
1532 | - $context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
1594 | + if (!isset($context['icon_sources'][$message['icon']])) { |
|
1595 | + $context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
1596 | + } |
|
1597 | + } elseif (!isset($context['icon_sources'][$message['icon']])) { |
|
1598 | + $context['icon_sources'][$message['icon']] = 'images_url'; |
|
1533 | 1599 | } |
1534 | - elseif (!isset($context['icon_sources'][$message['icon']])) |
|
1535 | - $context['icon_sources'][$message['icon']] = 'images_url'; |
|
1536 | 1600 | |
1537 | 1601 | // If you're a lazy bum, you probably didn't give a subject... |
1538 | 1602 | $message['subject'] = $message['subject'] != '' ? $message['subject'] : $txt['no_subject']; |
@@ -1557,8 +1621,7 @@ discard block |
||
1557 | 1621 | $memberContext[$message['id_member']]['email'] = $message['poster_email']; |
1558 | 1622 | $memberContext[$message['id_member']]['show_email'] = allowedTo('moderate_forum'); |
1559 | 1623 | $memberContext[$message['id_member']]['is_guest'] = true; |
1560 | - } |
|
1561 | - else |
|
1624 | + } else |
|
1562 | 1625 | { |
1563 | 1626 | // Define this here to make things a bit more readable |
1564 | 1627 | $can_view_warning = $context['user']['can_mod'] || allowedTo('view_warning_any') || ($message['id_member'] == $user_info['id'] && allowedTo('view_warning_own')); |
@@ -1581,8 +1644,9 @@ discard block |
||
1581 | 1644 | $message['body'] = parse_bbc($message['body'], $message['smileys_enabled'], $message['id_msg']); |
1582 | 1645 | |
1583 | 1646 | // If it's in the recycle bin we need to override whatever icon we did have. |
1584 | - if (!empty($board_info['recycle'])) |
|
1585 | - $message['icon'] = 'recycled'; |
|
1647 | + if (!empty($board_info['recycle'])) { |
|
1648 | + $message['icon'] = 'recycled'; |
|
1649 | + } |
|
1586 | 1650 | |
1587 | 1651 | require_once($sourcedir . '/Subs-Attachments.php'); |
1588 | 1652 | |
@@ -1626,32 +1690,36 @@ discard block |
||
1626 | 1690 | } |
1627 | 1691 | |
1628 | 1692 | // Are likes enable? |
1629 | - if (!empty($modSettings['enable_likes'])) |
|
1630 | - $output['likes'] = array( |
|
1693 | + if (!empty($modSettings['enable_likes'])) { |
|
1694 | + $output['likes'] = array( |
|
1631 | 1695 | 'count' => $message['likes'], |
1632 | 1696 | 'you' => in_array($message['id_msg'], $context['my_likes']), |
1633 | 1697 | 'can_like' => !$context['user']['is_guest'] && $message['id_member'] != $context['user']['id'] && !empty($context['can_like']), |
1634 | 1698 | ); |
1699 | + } |
|
1635 | 1700 | |
1636 | 1701 | // Is this user the message author? |
1637 | 1702 | $output['is_message_author'] = $message['id_member'] == $user_info['id']; |
1638 | - if (!empty($output['modified']['name'])) |
|
1639 | - $output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']); |
|
1703 | + if (!empty($output['modified']['name'])) { |
|
1704 | + $output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']); |
|
1705 | + } |
|
1640 | 1706 | |
1641 | 1707 | // Did they give a reason for editing? |
1642 | - if (!empty($output['modified']['name']) && !empty($output['modified']['reason'])) |
|
1643 | - $output['modified']['last_edit_text'] .= ' ' . sprintf($txt['last_edit_reason'], $output['modified']['reason']); |
|
1708 | + if (!empty($output['modified']['name']) && !empty($output['modified']['reason'])) { |
|
1709 | + $output['modified']['last_edit_text'] .= ' ' . sprintf($txt['last_edit_reason'], $output['modified']['reason']); |
|
1710 | + } |
|
1644 | 1711 | |
1645 | 1712 | // Any custom profile fields? |
1646 | - if (!empty($memberContext[$message['id_member']]['custom_fields'])) |
|
1647 | - foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom) |
|
1713 | + if (!empty($memberContext[$message['id_member']]['custom_fields'])) { |
|
1714 | + foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom) |
|
1648 | 1715 | $output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom; |
1716 | + } |
|
1649 | 1717 | |
1650 | - if (empty($options['view_newest_first'])) |
|
1651 | - $counter++; |
|
1652 | - |
|
1653 | - else |
|
1654 | - $counter--; |
|
1718 | + if (empty($options['view_newest_first'])) { |
|
1719 | + $counter++; |
|
1720 | + } else { |
|
1721 | + $counter--; |
|
1722 | + } |
|
1655 | 1723 | |
1656 | 1724 | call_integration_hook('integrate_prepare_display_context', array(&$output, &$message, $counter)); |
1657 | 1725 | |
@@ -1677,21 +1745,23 @@ discard block |
||
1677 | 1745 | $context['no_last_modified'] = true; |
1678 | 1746 | |
1679 | 1747 | // Prevent a preview image from being displayed twice. |
1680 | - if (isset($_GET['action']) && $_GET['action'] == 'dlattach' && isset($_GET['type']) && ($_GET['type'] == 'avatar' || $_GET['type'] == 'preview')) |
|
1681 | - return; |
|
1748 | + if (isset($_GET['action']) && $_GET['action'] == 'dlattach' && isset($_GET['type']) && ($_GET['type'] == 'avatar' || $_GET['type'] == 'preview')) { |
|
1749 | + return; |
|
1750 | + } |
|
1682 | 1751 | |
1683 | 1752 | // Make sure some attachment was requested! |
1684 | - if (!isset($_REQUEST['attach']) && !isset($_REQUEST['id'])) |
|
1685 | - fatal_lang_error('no_access', false); |
|
1753 | + if (!isset($_REQUEST['attach']) && !isset($_REQUEST['id'])) { |
|
1754 | + fatal_lang_error('no_access', false); |
|
1755 | + } |
|
1686 | 1756 | |
1687 | 1757 | $_REQUEST['attach'] = isset($_REQUEST['attach']) ? (int) $_REQUEST['attach'] : (int) $_REQUEST['id']; |
1688 | 1758 | |
1689 | 1759 | // Do we have a hook wanting to use our attachment system? We use $attachRequest to prevent accidental usage of $request. |
1690 | 1760 | $attachRequest = null; |
1691 | 1761 | call_integration_hook('integrate_download_request', array(&$attachRequest)); |
1692 | - if (!is_null($attachRequest) && $smcFunc['db_is_resource']($attachRequest)) |
|
1693 | - $request = $attachRequest; |
|
1694 | - else |
|
1762 | + if (!is_null($attachRequest) && $smcFunc['db_is_resource']($attachRequest)) { |
|
1763 | + $request = $attachRequest; |
|
1764 | + } else |
|
1695 | 1765 | { |
1696 | 1766 | // This checks only the current board for $board/$topic's permissions. |
1697 | 1767 | isAllowedTo('view_attachments'); |
@@ -1712,19 +1782,21 @@ discard block |
||
1712 | 1782 | ); |
1713 | 1783 | } |
1714 | 1784 | |
1715 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1716 | - fatal_lang_error('no_access', false); |
|
1785 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1786 | + fatal_lang_error('no_access', false); |
|
1787 | + } |
|
1717 | 1788 | |
1718 | 1789 | list ($id_folder, $real_filename, $file_hash, $file_ext, $id_attach, $attachment_type, $mime_type, $is_approved, $id_member) = $smcFunc['db_fetch_row']($request); |
1719 | 1790 | $smcFunc['db_free_result']($request); |
1720 | 1791 | |
1721 | 1792 | // If it isn't yet approved, do they have permission to view it? |
1722 | - if (!$is_approved && ($id_member == 0 || $user_info['id'] != $id_member) && ($attachment_type == 0 || $attachment_type == 3)) |
|
1723 | - isAllowedTo('approve_posts'); |
|
1793 | + if (!$is_approved && ($id_member == 0 || $user_info['id'] != $id_member) && ($attachment_type == 0 || $attachment_type == 3)) { |
|
1794 | + isAllowedTo('approve_posts'); |
|
1795 | + } |
|
1724 | 1796 | |
1725 | 1797 | // Update the download counter (unless it's a thumbnail). |
1726 | - if ($attachment_type != 3) |
|
1727 | - $smcFunc['db_query']('attach_download_increase', ' |
|
1798 | + if ($attachment_type != 3) { |
|
1799 | + $smcFunc['db_query']('attach_download_increase', ' |
|
1728 | 1800 | UPDATE LOW_PRIORITY {db_prefix}attachments |
1729 | 1801 | SET downloads = downloads + 1 |
1730 | 1802 | WHERE id_attach = {int:id_attach}', |
@@ -1732,15 +1804,15 @@ discard block |
||
1732 | 1804 | 'id_attach' => $id_attach, |
1733 | 1805 | ) |
1734 | 1806 | ); |
1807 | + } |
|
1735 | 1808 | |
1736 | 1809 | $filename = getAttachmentFilename($real_filename, $_REQUEST['attach'], $id_folder, false, $file_hash); |
1737 | 1810 | |
1738 | 1811 | // This is done to clear any output that was made before now. |
1739 | 1812 | ob_end_clean(); |
1740 | - if (!empty($modSettings['enableCompressedOutput']) && @filesize($filename) <= 4194304 && in_array($file_ext, array('txt', 'html', 'htm', 'js', 'doc', 'docx', 'rtf', 'css', 'php', 'log', 'xml', 'sql', 'c', 'java'))) |
|
1741 | - @ob_start('ob_gzhandler'); |
|
1742 | - |
|
1743 | - else |
|
1813 | + if (!empty($modSettings['enableCompressedOutput']) && @filesize($filename) <= 4194304 && in_array($file_ext, array('txt', 'html', 'htm', 'js', 'doc', 'docx', 'rtf', 'css', 'php', 'log', 'xml', 'sql', 'c', 'java'))) { |
|
1814 | + @ob_start('ob_gzhandler'); |
|
1815 | + } else |
|
1744 | 1816 | { |
1745 | 1817 | ob_start(); |
1746 | 1818 | header('Content-Encoding: none'); |
@@ -1783,8 +1855,9 @@ discard block |
||
1783 | 1855 | // Send the attachment headers. |
1784 | 1856 | header('Pragma: '); |
1785 | 1857 | |
1786 | - if (!isBrowser('gecko')) |
|
1787 | - header('Content-Transfer-Encoding: binary'); |
|
1858 | + if (!isBrowser('gecko')) { |
|
1859 | + header('Content-Transfer-Encoding: binary'); |
|
1860 | + } |
|
1788 | 1861 | |
1789 | 1862 | header('Expires: ' . gmdate('D, d M Y H:i:s', time() + 525600 * 60) . ' GMT'); |
1790 | 1863 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s', filemtime($filename)) . ' GMT'); |
@@ -1793,18 +1866,19 @@ discard block |
||
1793 | 1866 | header('ETag: ' . $eTag); |
1794 | 1867 | |
1795 | 1868 | // Make sure the mime type warrants an inline display. |
1796 | - if (isset($_REQUEST['image']) && !empty($mime_type) && strpos($mime_type, 'image/') !== 0) |
|
1797 | - unset($_REQUEST['image']); |
|
1869 | + if (isset($_REQUEST['image']) && !empty($mime_type) && strpos($mime_type, 'image/') !== 0) { |
|
1870 | + unset($_REQUEST['image']); |
|
1871 | + } |
|
1798 | 1872 | |
1799 | 1873 | // Does this have a mime type? |
1800 | - elseif (!empty($mime_type) && (isset($_REQUEST['image']) || !in_array($file_ext, array('jpg', 'gif', 'jpeg', 'x-ms-bmp', 'png', 'psd', 'tiff', 'iff')))) |
|
1801 | - header('Content-Type: ' . strtr($mime_type, array('image/bmp' => 'image/x-ms-bmp'))); |
|
1802 | - |
|
1803 | - else |
|
1874 | + elseif (!empty($mime_type) && (isset($_REQUEST['image']) || !in_array($file_ext, array('jpg', 'gif', 'jpeg', 'x-ms-bmp', 'png', 'psd', 'tiff', 'iff')))) { |
|
1875 | + header('Content-Type: ' . strtr($mime_type, array('image/bmp' => 'image/x-ms-bmp'))); |
|
1876 | + } else |
|
1804 | 1877 | { |
1805 | 1878 | header('Content-Type: ' . (isBrowser('ie') || isBrowser('opera') ? 'application/octetstream' : 'application/octet-stream')); |
1806 | - if (isset($_REQUEST['image'])) |
|
1807 | - unset($_REQUEST['image']); |
|
1879 | + if (isset($_REQUEST['image'])) { |
|
1880 | + unset($_REQUEST['image']); |
|
1881 | + } |
|
1808 | 1882 | } |
1809 | 1883 | |
1810 | 1884 | // Convert the file to UTF-8, cuz most browsers dig that. |
@@ -1812,23 +1886,22 @@ discard block |
||
1812 | 1886 | $disposition = !isset($_REQUEST['image']) ? 'attachment' : 'inline'; |
1813 | 1887 | |
1814 | 1888 | // Different browsers like different standards... |
1815 | - if (isBrowser('firefox')) |
|
1816 | - header('Content-Disposition: ' . $disposition . '; filename*=UTF-8\'\'' . rawurlencode(preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name))); |
|
1817 | - |
|
1818 | - elseif (isBrowser('opera')) |
|
1819 | - header('Content-Disposition: ' . $disposition . '; filename="' . preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name) . '"'); |
|
1820 | - |
|
1821 | - elseif (isBrowser('ie')) |
|
1822 | - header('Content-Disposition: ' . $disposition . '; filename="' . urlencode(preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name)) . '"'); |
|
1823 | - |
|
1824 | - else |
|
1825 | - header('Content-Disposition: ' . $disposition . '; filename="' . $utf8name . '"'); |
|
1889 | + if (isBrowser('firefox')) { |
|
1890 | + header('Content-Disposition: ' . $disposition . '; filename*=UTF-8\'\'' . rawurlencode(preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name))); |
|
1891 | + } elseif (isBrowser('opera')) { |
|
1892 | + header('Content-Disposition: ' . $disposition . '; filename="' . preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name) . '"'); |
|
1893 | + } elseif (isBrowser('ie')) { |
|
1894 | + header('Content-Disposition: ' . $disposition . '; filename="' . urlencode(preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name)) . '"'); |
|
1895 | + } else { |
|
1896 | + header('Content-Disposition: ' . $disposition . '; filename="' . $utf8name . '"'); |
|
1897 | + } |
|
1826 | 1898 | |
1827 | 1899 | // If this has an "image extension" - but isn't actually an image - then ensure it isn't cached cause of silly IE. |
1828 | - if (!isset($_REQUEST['image']) && in_array($file_ext, array('gif', 'jpg', 'bmp', 'png', 'jpeg', 'tiff'))) |
|
1829 | - header('Cache-Control: no-cache'); |
|
1830 | - else |
|
1831 | - header('Cache-Control: max-age=' . (525600 * 60) . ', private'); |
|
1900 | + if (!isset($_REQUEST['image']) && in_array($file_ext, array('gif', 'jpg', 'bmp', 'png', 'jpeg', 'tiff'))) { |
|
1901 | + header('Cache-Control: no-cache'); |
|
1902 | + } else { |
|
1903 | + header('Cache-Control: max-age=' . (525600 * 60) . ', private'); |
|
1904 | + } |
|
1832 | 1905 | |
1833 | 1906 | header('Content-Length: ' . filesize($filename)); |
1834 | 1907 | |
@@ -1838,20 +1911,23 @@ discard block |
||
1838 | 1911 | // Recode line endings for text files, if enabled. |
1839 | 1912 | if (!empty($modSettings['attachmentRecodeLineEndings']) && !isset($_REQUEST['image']) && in_array($file_ext, array('txt', 'css', 'htm', 'html', 'php', 'xml'))) |
1840 | 1913 | { |
1841 | - if (strpos($_SERVER['HTTP_USER_AGENT'], 'Windows') !== false) |
|
1842 | - $callback = function($buffer) |
|
1914 | + if (strpos($_SERVER['HTTP_USER_AGENT'], 'Windows') !== false) { |
|
1915 | + $callback = function($buffer) |
|
1843 | 1916 | { |
1844 | 1917 | return preg_replace('~[\r]?\n~', "\r\n", $buffer); |
1918 | + } |
|
1845 | 1919 | }; |
1846 | - elseif (strpos($_SERVER['HTTP_USER_AGENT'], 'Mac') !== false) |
|
1847 | - $callback = function($buffer) |
|
1920 | + elseif (strpos($_SERVER['HTTP_USER_AGENT'], 'Mac') !== false) { |
|
1921 | + $callback = function($buffer) |
|
1848 | 1922 | { |
1849 | 1923 | return preg_replace('~[\r]?\n~', "\r", $buffer); |
1924 | + } |
|
1850 | 1925 | }; |
1851 | - else |
|
1852 | - $callback = function($buffer) |
|
1926 | + else { |
|
1927 | + $callback = function($buffer) |
|
1853 | 1928 | { |
1854 | 1929 | return preg_replace('~[\r]?\n~', "\n", $buffer); |
1930 | + } |
|
1855 | 1931 | }; |
1856 | 1932 | } |
1857 | 1933 | |
@@ -1859,23 +1935,26 @@ discard block |
||
1859 | 1935 | if (filesize($filename) > 4194304) |
1860 | 1936 | { |
1861 | 1937 | // Forcibly end any output buffering going on. |
1862 | - while (@ob_get_level() > 0) |
|
1863 | - @ob_end_clean(); |
|
1938 | + while (@ob_get_level() > 0) { |
|
1939 | + @ob_end_clean(); |
|
1940 | + } |
|
1864 | 1941 | |
1865 | 1942 | $fp = fopen($filename, 'rb'); |
1866 | 1943 | while (!feof($fp)) |
1867 | 1944 | { |
1868 | - if (isset($callback)) |
|
1869 | - echo $callback(fread($fp, 8192)); |
|
1870 | - else |
|
1871 | - echo fread($fp, 8192); |
|
1945 | + if (isset($callback)) { |
|
1946 | + echo $callback(fread($fp, 8192)); |
|
1947 | + } else { |
|
1948 | + echo fread($fp, 8192); |
|
1949 | + } |
|
1872 | 1950 | flush(); |
1873 | 1951 | } |
1874 | 1952 | fclose($fp); |
1875 | 1953 | } |
1876 | 1954 | // On some of the less-bright hosts, readfile() is disabled. It's just a faster, more byte safe, version of what's in the if. |
1877 | - elseif (isset($callback) || @readfile($filename) === null) |
|
1878 | - echo isset($callback) ? $callback(file_get_contents($filename)) : file_get_contents($filename); |
|
1955 | + elseif (isset($callback) || @readfile($filename) === null) { |
|
1956 | + echo isset($callback) ? $callback(file_get_contents($filename)) : file_get_contents($filename); |
|
1957 | + } |
|
1879 | 1958 | |
1880 | 1959 | obExit(false); |
1881 | 1960 | } |
@@ -1888,8 +1967,9 @@ discard block |
||
1888 | 1967 | */ |
1889 | 1968 | function approved_attach_sort($a, $b) |
1890 | 1969 | { |
1891 | - if ($a['is_approved'] == $b['is_approved']) |
|
1892 | - return 0; |
|
1970 | + if ($a['is_approved'] == $b['is_approved']) { |
|
1971 | + return 0; |
|
1972 | + } |
|
1893 | 1973 | |
1894 | 1974 | return $a['is_approved'] > $b['is_approved'] ? -1 : 1; |
1895 | 1975 | } |
@@ -1906,16 +1986,19 @@ discard block |
||
1906 | 1986 | |
1907 | 1987 | require_once($sourcedir . '/RemoveTopic.php'); |
1908 | 1988 | |
1909 | - if (empty($_REQUEST['msgs'])) |
|
1910 | - redirectexit('topic=' . $topic . '.' . $_REQUEST['start']); |
|
1989 | + if (empty($_REQUEST['msgs'])) { |
|
1990 | + redirectexit('topic=' . $topic . '.' . $_REQUEST['start']); |
|
1991 | + } |
|
1911 | 1992 | |
1912 | 1993 | $messages = array(); |
1913 | - foreach ($_REQUEST['msgs'] as $dummy) |
|
1914 | - $messages[] = (int) $dummy; |
|
1994 | + foreach ($_REQUEST['msgs'] as $dummy) { |
|
1995 | + $messages[] = (int) $dummy; |
|
1996 | + } |
|
1915 | 1997 | |
1916 | 1998 | // We are restoring messages. We handle this in another place. |
1917 | - if (isset($_REQUEST['restore_selected'])) |
|
1918 | - redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1999 | + if (isset($_REQUEST['restore_selected'])) { |
|
2000 | + redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
2001 | + } |
|
1919 | 2002 | if (isset($_REQUEST['split_selection'])) |
1920 | 2003 | { |
1921 | 2004 | $request = $smcFunc['db_query']('', ' |
@@ -1934,8 +2017,9 @@ discard block |
||
1934 | 2017 | } |
1935 | 2018 | |
1936 | 2019 | // Allowed to delete any message? |
1937 | - if (allowedTo('delete_any')) |
|
1938 | - $allowed_all = true; |
|
2020 | + if (allowedTo('delete_any')) { |
|
2021 | + $allowed_all = true; |
|
2022 | + } |
|
1939 | 2023 | // Allowed to delete replies to their messages? |
1940 | 2024 | elseif (allowedTo('delete_replies')) |
1941 | 2025 | { |
@@ -1952,13 +2036,14 @@ discard block |
||
1952 | 2036 | $smcFunc['db_free_result']($request); |
1953 | 2037 | |
1954 | 2038 | $allowed_all = $starter == $user_info['id']; |
2039 | + } else { |
|
2040 | + $allowed_all = false; |
|
1955 | 2041 | } |
1956 | - else |
|
1957 | - $allowed_all = false; |
|
1958 | 2042 | |
1959 | 2043 | // Make sure they're allowed to delete their own messages, if not any. |
1960 | - if (!$allowed_all) |
|
1961 | - isAllowedTo('delete_own'); |
|
2044 | + if (!$allowed_all) { |
|
2045 | + isAllowedTo('delete_own'); |
|
2046 | + } |
|
1962 | 2047 | |
1963 | 2048 | // Allowed to remove which messages? |
1964 | 2049 | $request = $smcFunc['db_query']('', ' |
@@ -1978,8 +2063,9 @@ discard block |
||
1978 | 2063 | $messages = array(); |
1979 | 2064 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1980 | 2065 | { |
1981 | - if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time()) |
|
1982 | - continue; |
|
2066 | + if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time()) { |
|
2067 | + continue; |
|
2068 | + } |
|
1983 | 2069 | |
1984 | 2070 | $messages[$row['id_msg']] = array($row['subject'], $row['id_member']); |
1985 | 2071 | } |
@@ -2002,17 +2088,20 @@ discard block |
||
2002 | 2088 | foreach ($messages as $message => $info) |
2003 | 2089 | { |
2004 | 2090 | // Just skip the first message - if it's not the last. |
2005 | - if ($message == $first_message && $message != $last_message) |
|
2006 | - continue; |
|
2091 | + if ($message == $first_message && $message != $last_message) { |
|
2092 | + continue; |
|
2093 | + } |
|
2007 | 2094 | // If the first message is going then don't bother going back to the topic as we're effectively deleting it. |
2008 | - elseif ($message == $first_message) |
|
2009 | - $topicGone = true; |
|
2095 | + elseif ($message == $first_message) { |
|
2096 | + $topicGone = true; |
|
2097 | + } |
|
2010 | 2098 | |
2011 | 2099 | removeMessage($message); |
2012 | 2100 | |
2013 | 2101 | // Log this moderation action ;). |
2014 | - if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) |
|
2015 | - logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board)); |
|
2102 | + if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) { |
|
2103 | + logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board)); |
|
2104 | + } |
|
2016 | 2105 | } |
2017 | 2106 | |
2018 | 2107 | redirectexit(!empty($topicGone) ? 'board=' . $board : 'topic=' . $topic . '.' . $_REQUEST['start']); |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
122 | 123 | $smcFunc['db_free_result']($result); |
123 | 124 | |
124 | 125 | // Add this to the number of unapproved members |
125 | - if (!empty($changes['unapprovedMembers'])) |
|
126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
127 | - else |
|
128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
126 | + if (!empty($changes['unapprovedMembers'])) { |
|
127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
128 | + } else { |
|
129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
130 | + } |
|
129 | 131 | } |
130 | 132 | } |
131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
133 | 135 | break; |
134 | 136 | |
135 | 137 | case 'message': |
136 | - if ($parameter1 === true && $parameter2 !== null) |
|
137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
138 | - else |
|
138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
140 | + } else |
|
139 | 141 | { |
140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
175 | 177 | $parameter2 = text2words($parameter2); |
176 | 178 | |
177 | 179 | $inserts = array(); |
178 | - foreach ($parameter2 as $word) |
|
179 | - $inserts[] = array($word, $parameter1); |
|
180 | + foreach ($parameter2 as $word) { |
|
181 | + $inserts[] = array($word, $parameter1); |
|
182 | + } |
|
180 | 183 | |
181 | - if (!empty($inserts)) |
|
182 | - $smcFunc['db_insert']('ignore', |
|
184 | + if (!empty($inserts)) { |
|
185 | + $smcFunc['db_insert']('ignore', |
|
183 | 186 | '{db_prefix}log_search_subjects', |
184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
185 | 188 | $inserts, |
186 | 189 | array('word', 'id_topic') |
187 | 190 | ); |
191 | + } |
|
188 | 192 | } |
189 | 193 | break; |
190 | 194 | |
191 | 195 | case 'topic': |
192 | - if ($parameter1 === true) |
|
193 | - updateSettings(array('totalTopics' => true), true); |
|
194 | - else |
|
196 | + if ($parameter1 === true) { |
|
197 | + updateSettings(array('totalTopics' => true), true); |
|
198 | + } else |
|
195 | 199 | { |
196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
212 | 216 | |
213 | 217 | case 'postgroups': |
214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
216 | - return; |
|
219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
220 | + return; |
|
221 | + } |
|
217 | 222 | |
218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
228 | 233 | ) |
229 | 234 | ); |
230 | 235 | $postgroups = array(); |
231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
238 | + } |
|
233 | 239 | $smcFunc['db_free_result']($request); |
234 | 240 | |
235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
239 | 245 | } |
240 | 246 | |
241 | 247 | // Oh great, they've screwed their post groups. |
242 | - if (empty($postgroups)) |
|
243 | - return; |
|
248 | + if (empty($postgroups)) { |
|
249 | + return; |
|
250 | + } |
|
244 | 251 | |
245 | 252 | // Set all membergroups from most posts to least posts. |
246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
298 | 305 | { |
299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
300 | 307 | $parameters['members'] = $members; |
301 | - } |
|
302 | - elseif ($members === null) |
|
303 | - $condition = '1=1'; |
|
304 | - else |
|
308 | + } elseif ($members === null) { |
|
309 | + $condition = '1=1'; |
|
310 | + } else |
|
305 | 311 | { |
306 | 312 | $condition = 'id_member = {int:member}'; |
307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
341 | 347 | if (count($vars_to_integrate) != 0) |
342 | 348 | { |
343 | 349 | // Fetch a list of member_names if necessary |
344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
345 | - $member_names = array($user_info['username']); |
|
346 | - else |
|
350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
351 | + $member_names = array($user_info['username']); |
|
352 | + } else |
|
347 | 353 | { |
348 | 354 | $member_names = array(); |
349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
352 | 358 | WHERE ' . $condition, |
353 | 359 | $parameters |
354 | 360 | ); |
355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
356 | - $member_names[] = $row['member_name']; |
|
361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
362 | + $member_names[] = $row['member_name']; |
|
363 | + } |
|
357 | 364 | $smcFunc['db_free_result']($request); |
358 | 365 | } |
359 | 366 | |
360 | - if (!empty($member_names)) |
|
361 | - foreach ($vars_to_integrate as $var) |
|
367 | + if (!empty($member_names)) { |
|
368 | + foreach ($vars_to_integrate as $var) |
|
362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
370 | + } |
|
363 | 371 | } |
364 | 372 | } |
365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
367 | 375 | foreach ($data as $var => $val) |
368 | 376 | { |
369 | 377 | $type = 'string'; |
370 | - if (in_array($var, $knownInts)) |
|
371 | - $type = 'int'; |
|
372 | - elseif (in_array($var, $knownFloats)) |
|
373 | - $type = 'float'; |
|
374 | - elseif ($var == 'birthdate') |
|
375 | - $type = 'date'; |
|
376 | - elseif ($var == 'member_ip') |
|
377 | - $type = 'inet'; |
|
378 | - elseif ($var == 'member_ip2') |
|
379 | - $type = 'inet'; |
|
378 | + if (in_array($var, $knownInts)) { |
|
379 | + $type = 'int'; |
|
380 | + } elseif (in_array($var, $knownFloats)) { |
|
381 | + $type = 'float'; |
|
382 | + } elseif ($var == 'birthdate') { |
|
383 | + $type = 'date'; |
|
384 | + } elseif ($var == 'member_ip') { |
|
385 | + $type = 'inet'; |
|
386 | + } elseif ($var == 'member_ip2') { |
|
387 | + $type = 'inet'; |
|
388 | + } |
|
380 | 389 | |
381 | 390 | // Doing an increment? |
382 | 391 | if ($type == 'int' && ($val === '+' || $val === '-')) |
@@ -390,8 +399,9 @@ discard block |
||
390 | 399 | { |
391 | 400 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
392 | 401 | { |
393 | - if ($match[1] != '+ ') |
|
394 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
402 | + if ($match[1] != '+ ') { |
|
403 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
404 | + } |
|
395 | 405 | $type = 'raw'; |
396 | 406 | } |
397 | 407 | } |
@@ -412,8 +422,9 @@ discard block |
||
412 | 422 | // Clear any caching? |
413 | 423 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
414 | 424 | { |
415 | - if (!is_array($members)) |
|
416 | - $members = array($members); |
|
425 | + if (!is_array($members)) { |
|
426 | + $members = array($members); |
|
427 | + } |
|
417 | 428 | |
418 | 429 | foreach ($members as $member) |
419 | 430 | { |
@@ -446,29 +457,32 @@ discard block |
||
446 | 457 | { |
447 | 458 | global $modSettings, $smcFunc; |
448 | 459 | |
449 | - if (empty($changeArray) || !is_array($changeArray)) |
|
450 | - return; |
|
460 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
461 | + return; |
|
462 | + } |
|
451 | 463 | |
452 | 464 | $toRemove = array(); |
453 | 465 | |
454 | 466 | // Go check if there is any setting to be removed. |
455 | - foreach ($changeArray as $k => $v) |
|
456 | - if ($v === null) |
|
467 | + foreach ($changeArray as $k => $v) { |
|
468 | + if ($v === null) |
|
457 | 469 | { |
458 | 470 | // Found some, remove them from the original array and add them to ours. |
459 | 471 | unset($changeArray[$k]); |
472 | + } |
|
460 | 473 | $toRemove[] = $k; |
461 | 474 | } |
462 | 475 | |
463 | 476 | // Proceed with the deletion. |
464 | - if (!empty($toRemove)) |
|
465 | - $smcFunc['db_query']('', ' |
|
477 | + if (!empty($toRemove)) { |
|
478 | + $smcFunc['db_query']('', ' |
|
466 | 479 | DELETE FROM {db_prefix}settings |
467 | 480 | WHERE variable IN ({array_string:remove})', |
468 | 481 | array( |
469 | 482 | 'remove' => $toRemove, |
470 | 483 | ) |
471 | 484 | ); |
485 | + } |
|
472 | 486 | |
473 | 487 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
474 | 488 | if ($update) |
@@ -497,19 +511,22 @@ discard block |
||
497 | 511 | foreach ($changeArray as $variable => $value) |
498 | 512 | { |
499 | 513 | // Don't bother if it's already like that ;). |
500 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
501 | - continue; |
|
514 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
515 | + continue; |
|
516 | + } |
|
502 | 517 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
503 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
504 | - continue; |
|
518 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
519 | + continue; |
|
520 | + } |
|
505 | 521 | |
506 | 522 | $replaceArray[] = array($variable, $value); |
507 | 523 | |
508 | 524 | $modSettings[$variable] = $value; |
509 | 525 | } |
510 | 526 | |
511 | - if (empty($replaceArray)) |
|
512 | - return; |
|
527 | + if (empty($replaceArray)) { |
|
528 | + return; |
|
529 | + } |
|
513 | 530 | |
514 | 531 | $smcFunc['db_insert']('replace', |
515 | 532 | '{db_prefix}settings', |
@@ -555,14 +572,17 @@ discard block |
||
555 | 572 | $start_invalid = $start < 0; |
556 | 573 | |
557 | 574 | // Make sure $start is a proper variable - not less than 0. |
558 | - if ($start_invalid) |
|
559 | - $start = 0; |
|
575 | + if ($start_invalid) { |
|
576 | + $start = 0; |
|
577 | + } |
|
560 | 578 | // Not greater than the upper bound. |
561 | - elseif ($start >= $max_value) |
|
562 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
579 | + elseif ($start >= $max_value) { |
|
580 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
581 | + } |
|
563 | 582 | // And it has to be a multiple of $num_per_page! |
564 | - else |
|
565 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
583 | + else { |
|
584 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
585 | + } |
|
566 | 586 | |
567 | 587 | $context['current_page'] = $start / $num_per_page; |
568 | 588 | |
@@ -592,77 +612,87 @@ discard block |
||
592 | 612 | |
593 | 613 | // Show all the pages. |
594 | 614 | $display_page = 1; |
595 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
596 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
615 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
616 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
617 | + } |
|
597 | 618 | |
598 | 619 | // Show the right arrow. |
599 | 620 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
600 | - if ($start != $counter - $max_value && !$start_invalid) |
|
601 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
602 | - } |
|
603 | - else |
|
621 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
622 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
623 | + } |
|
624 | + } else |
|
604 | 625 | { |
605 | 626 | // If they didn't enter an odd value, pretend they did. |
606 | 627 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
607 | 628 | |
608 | 629 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
609 | - if (!empty($start) && $show_prevnext) |
|
610 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
611 | - else |
|
612 | - $pageindex .= ''; |
|
630 | + if (!empty($start) && $show_prevnext) { |
|
631 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
632 | + } else { |
|
633 | + $pageindex .= ''; |
|
634 | + } |
|
613 | 635 | |
614 | 636 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
615 | - if ($start > $num_per_page * $PageContiguous) |
|
616 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
637 | + if ($start > $num_per_page * $PageContiguous) { |
|
638 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
639 | + } |
|
617 | 640 | |
618 | 641 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
619 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
620 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
642 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
643 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
621 | 644 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
622 | 645 | '{FIRST_PAGE}' => $num_per_page, |
623 | 646 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
624 | 647 | '{PER_PAGE}' => $num_per_page, |
625 | 648 | )); |
649 | + } |
|
626 | 650 | |
627 | 651 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
628 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
629 | - if ($start >= $num_per_page * $nCont) |
|
652 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
653 | + if ($start >= $num_per_page * $nCont) |
|
630 | 654 | { |
631 | 655 | $tmpStart = $start - $num_per_page * $nCont; |
656 | + } |
|
632 | 657 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
633 | 658 | } |
634 | 659 | |
635 | 660 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
636 | - if (!$start_invalid) |
|
637 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
638 | - else |
|
639 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
661 | + if (!$start_invalid) { |
|
662 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
663 | + } else { |
|
664 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
665 | + } |
|
640 | 666 | |
641 | 667 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
642 | 668 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
643 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
644 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
669 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
670 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
645 | 671 | { |
646 | 672 | $tmpStart = $start + $num_per_page * $nCont; |
673 | + } |
|
647 | 674 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
648 | 675 | } |
649 | 676 | |
650 | 677 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
651 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
652 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
678 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
679 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
653 | 680 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
654 | 681 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
655 | 682 | '{LAST_PAGE}' => $tmpMaxPages, |
656 | 683 | '{PER_PAGE}' => $num_per_page, |
657 | 684 | )); |
685 | + } |
|
658 | 686 | |
659 | 687 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
660 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
661 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
688 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
689 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
690 | + } |
|
662 | 691 | |
663 | 692 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
664 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
665 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
693 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
694 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
695 | + } |
|
666 | 696 | } |
667 | 697 | $pageindex .= $settings['page_index']['extra_after']; |
668 | 698 | |
@@ -688,8 +718,9 @@ discard block |
||
688 | 718 | if ($decimal_separator === null) |
689 | 719 | { |
690 | 720 | // Not set for whatever reason? |
691 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
692 | - return $number; |
|
721 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
722 | + return $number; |
|
723 | + } |
|
693 | 724 | |
694 | 725 | // Cache these each load... |
695 | 726 | $thousands_separator = $matches[1]; |
@@ -723,17 +754,20 @@ discard block |
||
723 | 754 | static $unsupportedFormats, $finalizedFormats; |
724 | 755 | |
725 | 756 | // Offset the time. |
726 | - if (!$offset_type) |
|
727 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
757 | + if (!$offset_type) { |
|
758 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
759 | + } |
|
728 | 760 | // Just the forum offset? |
729 | - elseif ($offset_type == 'forum') |
|
730 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
731 | - else |
|
732 | - $time = $log_time; |
|
761 | + elseif ($offset_type == 'forum') { |
|
762 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
763 | + } else { |
|
764 | + $time = $log_time; |
|
765 | + } |
|
733 | 766 | |
734 | 767 | // We can't have a negative date (on Windows, at least.) |
735 | - if ($log_time < 0) |
|
736 | - $log_time = 0; |
|
768 | + if ($log_time < 0) { |
|
769 | + $log_time = 0; |
|
770 | + } |
|
737 | 771 | |
738 | 772 | // Today and Yesterday? |
739 | 773 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -750,24 +784,27 @@ discard block |
||
750 | 784 | { |
751 | 785 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
752 | 786 | $today_fmt = $h . ':%M' . $s . ' %p'; |
787 | + } else { |
|
788 | + $today_fmt = '%H:%M' . $s; |
|
753 | 789 | } |
754 | - else |
|
755 | - $today_fmt = '%H:%M' . $s; |
|
756 | 790 | |
757 | 791 | // Same day of the year, same year.... Today! |
758 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
759 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
792 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
793 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
794 | + } |
|
760 | 795 | |
761 | 796 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
762 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
763 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
797 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
798 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
799 | + } |
|
764 | 800 | } |
765 | 801 | |
766 | 802 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
767 | 803 | |
768 | 804 | // Use the cached formats if available |
769 | - if (is_null($finalizedFormats)) |
|
770 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
805 | + if (is_null($finalizedFormats)) { |
|
806 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
807 | + } |
|
771 | 808 | |
772 | 809 | // Make a supported version for this format if we don't already have one |
773 | 810 | if (empty($finalizedFormats[$str])) |
@@ -796,8 +833,9 @@ discard block |
||
796 | 833 | ); |
797 | 834 | |
798 | 835 | // No need to do this part again if we already did it once |
799 | - if (is_null($unsupportedFormats)) |
|
800 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
836 | + if (is_null($unsupportedFormats)) { |
|
837 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
838 | + } |
|
801 | 839 | if (empty($unsupportedFormats)) |
802 | 840 | { |
803 | 841 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -806,20 +844,23 @@ discard block |
||
806 | 844 | |
807 | 845 | // Windows will return false for unsupported formats |
808 | 846 | // Other operating systems return the format string as a literal |
809 | - if ($value === false || $value === $format) |
|
810 | - $unsupportedFormats[] = $format; |
|
847 | + if ($value === false || $value === $format) { |
|
848 | + $unsupportedFormats[] = $format; |
|
849 | + } |
|
811 | 850 | } |
812 | 851 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
813 | 852 | } |
814 | 853 | |
815 | 854 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
816 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
817 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
855 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
856 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
857 | + } |
|
818 | 858 | |
819 | 859 | // Substitute unsupported formats with supported ones |
820 | - if (!empty($unsupportedFormats)) |
|
821 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
860 | + if (!empty($unsupportedFormats)) { |
|
861 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
822 | 862 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
863 | + } |
|
823 | 864 | |
824 | 865 | // Remember this so we don't need to do it again |
825 | 866 | $finalizedFormats[$str] = $timeformat; |
@@ -828,33 +869,39 @@ discard block |
||
828 | 869 | |
829 | 870 | $str = $finalizedFormats[$str]; |
830 | 871 | |
831 | - if (!isset($locale_cache)) |
|
832 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
872 | + if (!isset($locale_cache)) { |
|
873 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
874 | + } |
|
833 | 875 | |
834 | 876 | if ($locale_cache !== false) |
835 | 877 | { |
836 | 878 | // Check if another process changed the locale |
837 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
838 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
879 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
880 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
881 | + } |
|
839 | 882 | |
840 | - if (!isset($non_twelve_hour)) |
|
841 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
842 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
843 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
883 | + if (!isset($non_twelve_hour)) { |
|
884 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
885 | + } |
|
886 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
887 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
888 | + } |
|
844 | 889 | |
845 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
846 | - if (strpos($str, $token) !== false) |
|
890 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
891 | + if (strpos($str, $token) !== false) |
|
847 | 892 | $str = str_replace($token, strftime($token, $time), $str); |
848 | - } |
|
849 | - else |
|
893 | + } |
|
894 | + } else |
|
850 | 895 | { |
851 | 896 | // Do-it-yourself time localization. Fun. |
852 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
853 | - if (strpos($str, $token) !== false) |
|
897 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
898 | + if (strpos($str, $token) !== false) |
|
854 | 899 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
900 | + } |
|
855 | 901 | |
856 | - if (strpos($str, '%p') !== false) |
|
857 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
902 | + if (strpos($str, '%p') !== false) { |
|
903 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
904 | + } |
|
858 | 905 | } |
859 | 906 | |
860 | 907 | // Format the time and then restore any literal percent characters |
@@ -877,16 +924,19 @@ discard block |
||
877 | 924 | static $translation = array(); |
878 | 925 | |
879 | 926 | // Determine the character set... Default to UTF-8 |
880 | - if (empty($context['character_set'])) |
|
881 | - $charset = 'UTF-8'; |
|
927 | + if (empty($context['character_set'])) { |
|
928 | + $charset = 'UTF-8'; |
|
929 | + } |
|
882 | 930 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
883 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
884 | - $charset = 'ISO-8859-1'; |
|
885 | - else |
|
886 | - $charset = $context['character_set']; |
|
931 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
932 | + $charset = 'ISO-8859-1'; |
|
933 | + } else { |
|
934 | + $charset = $context['character_set']; |
|
935 | + } |
|
887 | 936 | |
888 | - if (empty($translation)) |
|
889 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
937 | + if (empty($translation)) { |
|
938 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
939 | + } |
|
890 | 940 | |
891 | 941 | return strtr($string, $translation); |
892 | 942 | } |
@@ -908,8 +958,9 @@ discard block |
||
908 | 958 | global $smcFunc; |
909 | 959 | |
910 | 960 | // It was already short enough! |
911 | - if ($smcFunc['strlen']($subject) <= $len) |
|
912 | - return $subject; |
|
961 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
962 | + return $subject; |
|
963 | + } |
|
913 | 964 | |
914 | 965 | // Shorten it by the length it was too long, and strip off junk from the end. |
915 | 966 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -928,10 +979,11 @@ discard block |
||
928 | 979 | { |
929 | 980 | global $user_info, $modSettings; |
930 | 981 | |
931 | - if ($timestamp === null) |
|
932 | - $timestamp = time(); |
|
933 | - elseif ($timestamp == 0) |
|
934 | - return 0; |
|
982 | + if ($timestamp === null) { |
|
983 | + $timestamp = time(); |
|
984 | + } elseif ($timestamp == 0) { |
|
985 | + return 0; |
|
986 | + } |
|
935 | 987 | |
936 | 988 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
937 | 989 | } |
@@ -960,8 +1012,9 @@ discard block |
||
960 | 1012 | $array[$i] = $array[$j]; |
961 | 1013 | $array[$j] = $temp; |
962 | 1014 | |
963 | - for ($i = 1; $p[$i] == 0; $i++) |
|
964 | - $p[$i] = 1; |
|
1015 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
1016 | + $p[$i] = 1; |
|
1017 | + } |
|
965 | 1018 | |
966 | 1019 | $orders[] = $array; |
967 | 1020 | } |
@@ -993,12 +1046,14 @@ discard block |
||
993 | 1046 | static $disabled; |
994 | 1047 | |
995 | 1048 | // Don't waste cycles |
996 | - if ($message === '') |
|
997 | - return ''; |
|
1049 | + if ($message === '') { |
|
1050 | + return ''; |
|
1051 | + } |
|
998 | 1052 | |
999 | 1053 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
1000 | - if (!isset($context['utf8'])) |
|
1001 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1054 | + if (!isset($context['utf8'])) { |
|
1055 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1056 | + } |
|
1002 | 1057 | |
1003 | 1058 | // Clean up any cut/paste issues we may have |
1004 | 1059 | $message = sanitizeMSCutPaste($message); |
@@ -1010,13 +1065,15 @@ discard block |
||
1010 | 1065 | return $message; |
1011 | 1066 | } |
1012 | 1067 | |
1013 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
1014 | - $smileys = (bool) $smileys; |
|
1068 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
1069 | + $smileys = (bool) $smileys; |
|
1070 | + } |
|
1015 | 1071 | |
1016 | 1072 | if (empty($modSettings['enableBBC']) && $message !== false) |
1017 | 1073 | { |
1018 | - if ($smileys === true) |
|
1019 | - parsesmileys($message); |
|
1074 | + if ($smileys === true) { |
|
1075 | + parsesmileys($message); |
|
1076 | + } |
|
1020 | 1077 | |
1021 | 1078 | return $message; |
1022 | 1079 | } |
@@ -1029,8 +1086,9 @@ discard block |
||
1029 | 1086 | } |
1030 | 1087 | |
1031 | 1088 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
1032 | - if (!empty($modSettings['autoLinkUrls'])) |
|
1033 | - set_tld_regex(); |
|
1089 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
1090 | + set_tld_regex(); |
|
1091 | + } |
|
1034 | 1092 | |
1035 | 1093 | // Allow mods access before entering the main parse_bbc loop |
1036 | 1094 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1044,12 +1102,14 @@ discard block |
||
1044 | 1102 | |
1045 | 1103 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
1046 | 1104 | |
1047 | - foreach ($temp as $tag) |
|
1048 | - $disabled[trim($tag)] = true; |
|
1105 | + foreach ($temp as $tag) { |
|
1106 | + $disabled[trim($tag)] = true; |
|
1107 | + } |
|
1049 | 1108 | } |
1050 | 1109 | |
1051 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1052 | - $disabled['flash'] = true; |
|
1110 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1111 | + $disabled['flash'] = true; |
|
1112 | + } |
|
1053 | 1113 | |
1054 | 1114 | /* The following bbc are formatted as an array, with keys as follows: |
1055 | 1115 | |
@@ -1170,8 +1230,9 @@ discard block |
||
1170 | 1230 | $returnContext = ''; |
1171 | 1231 | |
1172 | 1232 | // BBC or the entire attachments feature is disabled |
1173 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
1174 | - return $data; |
|
1233 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
1234 | + return $data; |
|
1235 | + } |
|
1175 | 1236 | |
1176 | 1237 | // Save the attach ID. |
1177 | 1238 | $attachID = $data; |
@@ -1182,8 +1243,9 @@ discard block |
||
1182 | 1243 | $currentAttachment = parseAttachBBC($attachID); |
1183 | 1244 | |
1184 | 1245 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
1185 | - if (is_string($currentAttachment)) |
|
1186 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1246 | + if (is_string($currentAttachment)) { |
|
1247 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1248 | + } |
|
1187 | 1249 | |
1188 | 1250 | if (!empty($currentAttachment['is_image'])) |
1189 | 1251 | { |
@@ -1199,15 +1261,17 @@ discard block |
||
1199 | 1261 | $height = ' height="' . $currentAttachment['height'] . '"'; |
1200 | 1262 | } |
1201 | 1263 | |
1202 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
1203 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1204 | - else |
|
1205 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1264 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
1265 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1266 | + } else { |
|
1267 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1268 | + } |
|
1206 | 1269 | } |
1207 | 1270 | |
1208 | 1271 | // No image. Show a link. |
1209 | - else |
|
1210 | - $returnContext .= $currentAttachment['link']; |
|
1272 | + else { |
|
1273 | + $returnContext .= $currentAttachment['link']; |
|
1274 | + } |
|
1211 | 1275 | |
1212 | 1276 | // Gotta append what we just did. |
1213 | 1277 | $data = $returnContext; |
@@ -1238,8 +1302,9 @@ discard block |
||
1238 | 1302 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1239 | 1303 | { |
1240 | 1304 | // Do PHP code coloring? |
1241 | - if ($php_parts[$php_i] != '<?php') |
|
1242 | - continue; |
|
1305 | + if ($php_parts[$php_i] != '<?php') { |
|
1306 | + continue; |
|
1307 | + } |
|
1243 | 1308 | |
1244 | 1309 | $php_string = ''; |
1245 | 1310 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1255,8 +1320,9 @@ discard block |
||
1255 | 1320 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
1256 | 1321 | |
1257 | 1322 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1258 | - if ($context['browser']['is_opera']) |
|
1259 | - $data .= ' '; |
|
1323 | + if ($context['browser']['is_opera']) { |
|
1324 | + $data .= ' '; |
|
1325 | + } |
|
1260 | 1326 | } |
1261 | 1327 | }, |
1262 | 1328 | 'block_level' => true, |
@@ -1275,8 +1341,9 @@ discard block |
||
1275 | 1341 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1276 | 1342 | { |
1277 | 1343 | // Do PHP code coloring? |
1278 | - if ($php_parts[$php_i] != '<?php') |
|
1279 | - continue; |
|
1344 | + if ($php_parts[$php_i] != '<?php') { |
|
1345 | + continue; |
|
1346 | + } |
|
1280 | 1347 | |
1281 | 1348 | $php_string = ''; |
1282 | 1349 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1292,8 +1359,9 @@ discard block |
||
1292 | 1359 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
1293 | 1360 | |
1294 | 1361 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1295 | - if ($context['browser']['is_opera']) |
|
1296 | - $data[0] .= ' '; |
|
1362 | + if ($context['browser']['is_opera']) { |
|
1363 | + $data[0] .= ' '; |
|
1364 | + } |
|
1297 | 1365 | } |
1298 | 1366 | }, |
1299 | 1367 | 'block_level' => true, |
@@ -1331,11 +1399,13 @@ discard block |
||
1331 | 1399 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1332 | 1400 | 'validate' => function (&$tag, &$data, $disabled) |
1333 | 1401 | { |
1334 | - if (isset($disabled['url'])) |
|
1335 | - $tag['content'] = '$1'; |
|
1402 | + if (isset($disabled['url'])) { |
|
1403 | + $tag['content'] = '$1'; |
|
1404 | + } |
|
1336 | 1405 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
1337 | - if (empty($scheme)) |
|
1338 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
1406 | + if (empty($scheme)) { |
|
1407 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
1408 | + } |
|
1339 | 1409 | }, |
1340 | 1410 | 'disabled_content' => '<a href="$1" target="_blank" class="new_win">$1</a>', |
1341 | 1411 | ), |
@@ -1349,10 +1419,11 @@ discard block |
||
1349 | 1419 | { |
1350 | 1420 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1351 | 1421 | |
1352 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
1353 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1354 | - else |
|
1355 | - $css = ''; |
|
1422 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
1423 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1424 | + } else { |
|
1425 | + $css = ''; |
|
1426 | + } |
|
1356 | 1427 | |
1357 | 1428 | $data = $class . $css; |
1358 | 1429 | }, |
@@ -1402,14 +1473,16 @@ discard block |
||
1402 | 1473 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1403 | 1474 | if ($image_proxy_enabled) |
1404 | 1475 | { |
1405 | - if (empty($scheme)) |
|
1406 | - $data = 'http://' . ltrim($data, ':/'); |
|
1476 | + if (empty($scheme)) { |
|
1477 | + $data = 'http://' . ltrim($data, ':/'); |
|
1478 | + } |
|
1407 | 1479 | |
1408 | - if ($scheme != 'https') |
|
1409 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1480 | + if ($scheme != 'https') { |
|
1481 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1482 | + } |
|
1483 | + } elseif (empty($scheme)) { |
|
1484 | + $data = '//' . ltrim($data, ':/'); |
|
1410 | 1485 | } |
1411 | - elseif (empty($scheme)) |
|
1412 | - $data = '//' . ltrim($data, ':/'); |
|
1413 | 1486 | }, |
1414 | 1487 | 'disabled_content' => '($1)', |
1415 | 1488 | ), |
@@ -1425,14 +1498,16 @@ discard block |
||
1425 | 1498 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1426 | 1499 | if ($image_proxy_enabled) |
1427 | 1500 | { |
1428 | - if (empty($scheme)) |
|
1429 | - $data = 'http://' . ltrim($data, ':/'); |
|
1501 | + if (empty($scheme)) { |
|
1502 | + $data = 'http://' . ltrim($data, ':/'); |
|
1503 | + } |
|
1430 | 1504 | |
1431 | - if ($scheme != 'https') |
|
1432 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1505 | + if ($scheme != 'https') { |
|
1506 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1507 | + } |
|
1508 | + } elseif (empty($scheme)) { |
|
1509 | + $data = '//' . ltrim($data, ':/'); |
|
1433 | 1510 | } |
1434 | - elseif (empty($scheme)) |
|
1435 | - $data = '//' . ltrim($data, ':/'); |
|
1436 | 1511 | }, |
1437 | 1512 | 'disabled_content' => '($1)', |
1438 | 1513 | ), |
@@ -1444,8 +1519,9 @@ discard block |
||
1444 | 1519 | { |
1445 | 1520 | $data = strtr($data, array('<br>' => '')); |
1446 | 1521 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1447 | - if (empty($scheme)) |
|
1448 | - $data = '//' . ltrim($data, ':/'); |
|
1522 | + if (empty($scheme)) { |
|
1523 | + $data = '//' . ltrim($data, ':/'); |
|
1524 | + } |
|
1449 | 1525 | }, |
1450 | 1526 | ), |
1451 | 1527 | array( |
@@ -1456,13 +1532,14 @@ discard block |
||
1456 | 1532 | 'after' => '</a>', |
1457 | 1533 | 'validate' => function (&$tag, &$data, $disabled) |
1458 | 1534 | { |
1459 | - if (substr($data, 0, 1) == '#') |
|
1460 | - $data = '#post_' . substr($data, 1); |
|
1461 | - else |
|
1535 | + if (substr($data, 0, 1) == '#') { |
|
1536 | + $data = '#post_' . substr($data, 1); |
|
1537 | + } else |
|
1462 | 1538 | { |
1463 | 1539 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1464 | - if (empty($scheme)) |
|
1465 | - $data = '//' . ltrim($data, ':/'); |
|
1540 | + if (empty($scheme)) { |
|
1541 | + $data = '//' . ltrim($data, ':/'); |
|
1542 | + } |
|
1466 | 1543 | } |
1467 | 1544 | }, |
1468 | 1545 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1540,8 +1617,9 @@ discard block |
||
1540 | 1617 | { |
1541 | 1618 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
1542 | 1619 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
1543 | - if ($add_begin) |
|
1544 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1620 | + if ($add_begin) { |
|
1621 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1622 | + } |
|
1545 | 1623 | } |
1546 | 1624 | }, |
1547 | 1625 | 'block_level' => false, |
@@ -1672,10 +1750,11 @@ discard block |
||
1672 | 1750 | 'content' => '$1', |
1673 | 1751 | 'validate' => function (&$tag, &$data, $disabled) |
1674 | 1752 | { |
1675 | - if (is_numeric($data)) |
|
1676 | - $data = timeformat($data); |
|
1677 | - else |
|
1678 | - $tag['content'] = '[time]$1[/time]'; |
|
1753 | + if (is_numeric($data)) { |
|
1754 | + $data = timeformat($data); |
|
1755 | + } else { |
|
1756 | + $tag['content'] = '[time]$1[/time]'; |
|
1757 | + } |
|
1679 | 1758 | }, |
1680 | 1759 | ), |
1681 | 1760 | array( |
@@ -1702,8 +1781,9 @@ discard block |
||
1702 | 1781 | { |
1703 | 1782 | $data = strtr($data, array('<br>' => '')); |
1704 | 1783 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1705 | - if (empty($scheme)) |
|
1706 | - $data = '//' . ltrim($data, ':/'); |
|
1784 | + if (empty($scheme)) { |
|
1785 | + $data = '//' . ltrim($data, ':/'); |
|
1786 | + } |
|
1707 | 1787 | }, |
1708 | 1788 | ), |
1709 | 1789 | array( |
@@ -1715,8 +1795,9 @@ discard block |
||
1715 | 1795 | 'validate' => function (&$tag, &$data, $disabled) |
1716 | 1796 | { |
1717 | 1797 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1718 | - if (empty($scheme)) |
|
1719 | - $data = '//' . ltrim($data, ':/'); |
|
1798 | + if (empty($scheme)) { |
|
1799 | + $data = '//' . ltrim($data, ':/'); |
|
1800 | + } |
|
1720 | 1801 | }, |
1721 | 1802 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
1722 | 1803 | 'disabled_after' => ' ($1)', |
@@ -1736,8 +1817,9 @@ discard block |
||
1736 | 1817 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
1737 | 1818 | if ($message === false) |
1738 | 1819 | { |
1739 | - if (isset($temp_bbc)) |
|
1740 | - $bbc_codes = $temp_bbc; |
|
1820 | + if (isset($temp_bbc)) { |
|
1821 | + $bbc_codes = $temp_bbc; |
|
1822 | + } |
|
1741 | 1823 | usort($codes, function ($a, $b) { |
1742 | 1824 | return strcmp($a['tag'], $b['tag']); |
1743 | 1825 | }); |
@@ -1757,8 +1839,9 @@ discard block |
||
1757 | 1839 | ); |
1758 | 1840 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
1759 | 1841 | { |
1760 | - foreach ($itemcodes as $c => $dummy) |
|
1761 | - $bbc_codes[$c] = array(); |
|
1842 | + foreach ($itemcodes as $c => $dummy) { |
|
1843 | + $bbc_codes[$c] = array(); |
|
1844 | + } |
|
1762 | 1845 | } |
1763 | 1846 | |
1764 | 1847 | // Shhhh! |
@@ -1779,12 +1862,14 @@ discard block |
||
1779 | 1862 | foreach ($codes as $code) |
1780 | 1863 | { |
1781 | 1864 | // Make it easier to process parameters later |
1782 | - if (!empty($code['parameters'])) |
|
1783 | - ksort($code['parameters'], SORT_STRING); |
|
1865 | + if (!empty($code['parameters'])) { |
|
1866 | + ksort($code['parameters'], SORT_STRING); |
|
1867 | + } |
|
1784 | 1868 | |
1785 | 1869 | // If we are not doing every tag only do ones we are interested in. |
1786 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
1787 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1870 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
1871 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1872 | + } |
|
1788 | 1873 | } |
1789 | 1874 | $codes = null; |
1790 | 1875 | } |
@@ -1795,8 +1880,9 @@ discard block |
||
1795 | 1880 | // It's likely this will change if the message is modified. |
1796 | 1881 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
1797 | 1882 | |
1798 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
1799 | - return $temp; |
|
1883 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
1884 | + return $temp; |
|
1885 | + } |
|
1800 | 1886 | |
1801 | 1887 | $cache_t = microtime(); |
1802 | 1888 | } |
@@ -1828,8 +1914,9 @@ discard block |
||
1828 | 1914 | $disabled['flash'] = true; |
1829 | 1915 | |
1830 | 1916 | // @todo Change maybe? |
1831 | - if (!isset($_GET['images'])) |
|
1832 | - $disabled['img'] = true; |
|
1917 | + if (!isset($_GET['images'])) { |
|
1918 | + $disabled['img'] = true; |
|
1919 | + } |
|
1833 | 1920 | |
1834 | 1921 | // @todo Interface/setting to add more? |
1835 | 1922 | } |
@@ -1853,8 +1940,9 @@ discard block |
||
1853 | 1940 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
1854 | 1941 | |
1855 | 1942 | // Failsafe. |
1856 | - if ($pos === false || $last_pos > $pos) |
|
1857 | - $pos = strlen($message) + 1; |
|
1943 | + if ($pos === false || $last_pos > $pos) { |
|
1944 | + $pos = strlen($message) + 1; |
|
1945 | + } |
|
1858 | 1946 | |
1859 | 1947 | // Can't have a one letter smiley, URL, or email! (sorry.) |
1860 | 1948 | if ($last_pos < $pos - 1) |
@@ -1872,8 +1960,9 @@ discard block |
||
1872 | 1960 | |
1873 | 1961 | // <br> should be empty. |
1874 | 1962 | $empty_tags = array('br', 'hr'); |
1875 | - foreach ($empty_tags as $tag) |
|
1876 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1963 | + foreach ($empty_tags as $tag) { |
|
1964 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1965 | + } |
|
1877 | 1966 | |
1878 | 1967 | // b, u, i, s, pre... basic tags. |
1879 | 1968 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1882,8 +1971,9 @@ discard block |
||
1882 | 1971 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
1883 | 1972 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
1884 | 1973 | |
1885 | - if ($diff > 0) |
|
1886 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1974 | + if ($diff > 0) { |
|
1975 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1976 | + } |
|
1887 | 1977 | } |
1888 | 1978 | |
1889 | 1979 | // Do <img ...> - with security... action= -> action-. |
@@ -1896,8 +1986,9 @@ discard block |
||
1896 | 1986 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
1897 | 1987 | |
1898 | 1988 | // Remove action= from the URL - no funny business, now. |
1899 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
1900 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
1989 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
1990 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
1991 | + } |
|
1901 | 1992 | |
1902 | 1993 | // Check if the image is larger than allowed. |
1903 | 1994 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1918,9 +2009,9 @@ discard block |
||
1918 | 2009 | |
1919 | 2010 | // Set the new image tag. |
1920 | 2011 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
2012 | + } else { |
|
2013 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1921 | 2014 | } |
1922 | - else |
|
1923 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1924 | 2015 | } |
1925 | 2016 | |
1926 | 2017 | $data = strtr($data, $replaces); |
@@ -1933,16 +2024,18 @@ discard block |
||
1933 | 2024 | $no_autolink_area = false; |
1934 | 2025 | if (!empty($open_tags)) |
1935 | 2026 | { |
1936 | - foreach ($open_tags as $open_tag) |
|
1937 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
2027 | + foreach ($open_tags as $open_tag) { |
|
2028 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
1938 | 2029 | $no_autolink_area = true; |
2030 | + } |
|
1939 | 2031 | } |
1940 | 2032 | |
1941 | 2033 | // Don't go backwards. |
1942 | 2034 | // @todo Don't think is the real solution.... |
1943 | 2035 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
1944 | - if ($pos < $lastAutoPos) |
|
1945 | - $no_autolink_area = true; |
|
2036 | + if ($pos < $lastAutoPos) { |
|
2037 | + $no_autolink_area = true; |
|
2038 | + } |
|
1946 | 2039 | $lastAutoPos = $pos; |
1947 | 2040 | |
1948 | 2041 | if (!$no_autolink_area) |
@@ -2051,17 +2144,19 @@ discard block |
||
2051 | 2144 | if ($scheme == 'mailto') |
2052 | 2145 | { |
2053 | 2146 | $email_address = str_replace('mailto:', '', $url); |
2054 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
2055 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2056 | - else |
|
2057 | - return $url; |
|
2147 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
2148 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2149 | + } else { |
|
2150 | + return $url; |
|
2151 | + } |
|
2058 | 2152 | } |
2059 | 2153 | |
2060 | 2154 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
2061 | - if (empty($scheme)) |
|
2062 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
2063 | - else |
|
2064 | - $fullUrl = $url; |
|
2155 | + if (empty($scheme)) { |
|
2156 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
2157 | + } else { |
|
2158 | + $fullUrl = $url; |
|
2159 | + } |
|
2065 | 2160 | |
2066 | 2161 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
2067 | 2162 | }, $data); |
@@ -2110,16 +2205,18 @@ discard block |
||
2110 | 2205 | } |
2111 | 2206 | |
2112 | 2207 | // Are we there yet? Are we there yet? |
2113 | - if ($pos >= strlen($message) - 1) |
|
2114 | - break; |
|
2208 | + if ($pos >= strlen($message) - 1) { |
|
2209 | + break; |
|
2210 | + } |
|
2115 | 2211 | |
2116 | 2212 | $tags = strtolower($message[$pos + 1]); |
2117 | 2213 | |
2118 | 2214 | if ($tags == '/' && !empty($open_tags)) |
2119 | 2215 | { |
2120 | 2216 | $pos2 = strpos($message, ']', $pos + 1); |
2121 | - if ($pos2 == $pos + 2) |
|
2122 | - continue; |
|
2217 | + if ($pos2 == $pos + 2) { |
|
2218 | + continue; |
|
2219 | + } |
|
2123 | 2220 | |
2124 | 2221 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
2125 | 2222 | |
@@ -2129,8 +2226,9 @@ discard block |
||
2129 | 2226 | do |
2130 | 2227 | { |
2131 | 2228 | $tag = array_pop($open_tags); |
2132 | - if (!$tag) |
|
2133 | - break; |
|
2229 | + if (!$tag) { |
|
2230 | + break; |
|
2231 | + } |
|
2134 | 2232 | |
2135 | 2233 | if (!empty($tag['block_level'])) |
2136 | 2234 | { |
@@ -2144,10 +2242,11 @@ discard block |
||
2144 | 2242 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
2145 | 2243 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
2146 | 2244 | { |
2147 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2148 | - if ($temp['tag'] == $look_for) |
|
2245 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2246 | + if ($temp['tag'] == $look_for) |
|
2149 | 2247 | { |
2150 | 2248 | $block_level = !empty($temp['block_level']); |
2249 | + } |
|
2151 | 2250 | break; |
2152 | 2251 | } |
2153 | 2252 | } |
@@ -2169,15 +2268,15 @@ discard block |
||
2169 | 2268 | { |
2170 | 2269 | $open_tags = $to_close; |
2171 | 2270 | continue; |
2172 | - } |
|
2173 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2271 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2174 | 2272 | { |
2175 | 2273 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
2176 | 2274 | { |
2177 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2178 | - if ($temp['tag'] == $look_for) |
|
2275 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2276 | + if ($temp['tag'] == $look_for) |
|
2179 | 2277 | { |
2180 | 2278 | $block_level = !empty($temp['block_level']); |
2279 | + } |
|
2181 | 2280 | break; |
2182 | 2281 | } |
2183 | 2282 | } |
@@ -2185,8 +2284,9 @@ discard block |
||
2185 | 2284 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
2186 | 2285 | if (!$block_level) |
2187 | 2286 | { |
2188 | - foreach ($to_close as $tag) |
|
2189 | - array_push($open_tags, $tag); |
|
2287 | + foreach ($to_close as $tag) { |
|
2288 | + array_push($open_tags, $tag); |
|
2289 | + } |
|
2190 | 2290 | continue; |
2191 | 2291 | } |
2192 | 2292 | } |
@@ -2199,14 +2299,17 @@ discard block |
||
2199 | 2299 | |
2200 | 2300 | // See the comment at the end of the big loop - just eating whitespace ;). |
2201 | 2301 | $whitespace_regex = ''; |
2202 | - if (!empty($tag['block_level'])) |
|
2203 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2302 | + if (!empty($tag['block_level'])) { |
|
2303 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2304 | + } |
|
2204 | 2305 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
2205 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2206 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2306 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2307 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2308 | + } |
|
2207 | 2309 | |
2208 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2209 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2310 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2311 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2312 | + } |
|
2210 | 2313 | } |
2211 | 2314 | |
2212 | 2315 | if (!empty($to_close)) |
@@ -2219,8 +2322,9 @@ discard block |
||
2219 | 2322 | } |
2220 | 2323 | |
2221 | 2324 | // No tags for this character, so just keep going (fastest possible course.) |
2222 | - if (!isset($bbc_codes[$tags])) |
|
2223 | - continue; |
|
2325 | + if (!isset($bbc_codes[$tags])) { |
|
2326 | + continue; |
|
2327 | + } |
|
2224 | 2328 | |
2225 | 2329 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
2226 | 2330 | $tag = null; |
@@ -2229,44 +2333,52 @@ discard block |
||
2229 | 2333 | $pt_strlen = strlen($possible['tag']); |
2230 | 2334 | |
2231 | 2335 | // Not a match? |
2232 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
2233 | - continue; |
|
2336 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
2337 | + continue; |
|
2338 | + } |
|
2234 | 2339 | |
2235 | 2340 | $next_c = $message[$pos + 1 + $pt_strlen]; |
2236 | 2341 | |
2237 | 2342 | // A test validation? |
2238 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
2239 | - continue; |
|
2343 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
2344 | + continue; |
|
2345 | + } |
|
2240 | 2346 | // Do we want parameters? |
2241 | 2347 | elseif (!empty($possible['parameters'])) |
2242 | 2348 | { |
2243 | - if ($next_c != ' ') |
|
2244 | - continue; |
|
2245 | - } |
|
2246 | - elseif (isset($possible['type'])) |
|
2349 | + if ($next_c != ' ') { |
|
2350 | + continue; |
|
2351 | + } |
|
2352 | + } elseif (isset($possible['type'])) |
|
2247 | 2353 | { |
2248 | 2354 | // Do we need an equal sign? |
2249 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
2250 | - continue; |
|
2355 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
2356 | + continue; |
|
2357 | + } |
|
2251 | 2358 | // Maybe we just want a /... |
2252 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
2253 | - continue; |
|
2359 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
2360 | + continue; |
|
2361 | + } |
|
2254 | 2362 | // An immediate ]? |
2255 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
2256 | - continue; |
|
2363 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
2364 | + continue; |
|
2365 | + } |
|
2257 | 2366 | } |
2258 | 2367 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
2259 | - elseif ($next_c != ']') |
|
2260 | - continue; |
|
2368 | + elseif ($next_c != ']') { |
|
2369 | + continue; |
|
2370 | + } |
|
2261 | 2371 | |
2262 | 2372 | // Check allowed tree? |
2263 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
2264 | - continue; |
|
2265 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
2266 | - continue; |
|
2373 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
2374 | + continue; |
|
2375 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
2376 | + continue; |
|
2377 | + } |
|
2267 | 2378 | // If this is in the list of disallowed child tags, don't parse it. |
2268 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
2269 | - continue; |
|
2379 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
2380 | + continue; |
|
2381 | + } |
|
2270 | 2382 | |
2271 | 2383 | $pos1 = $pos + 1 + $pt_strlen + 1; |
2272 | 2384 | |
@@ -2278,8 +2390,9 @@ discard block |
||
2278 | 2390 | foreach ($open_tags as $open_quote) |
2279 | 2391 | { |
2280 | 2392 | // Every parent quote this quote has flips the styling |
2281 | - if ($open_quote['tag'] == 'quote') |
|
2282 | - $quote_alt = !$quote_alt; |
|
2393 | + if ($open_quote['tag'] == 'quote') { |
|
2394 | + $quote_alt = !$quote_alt; |
|
2395 | + } |
|
2283 | 2396 | } |
2284 | 2397 | // Add a class to the quote to style alternating blockquotes |
2285 | 2398 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2290,8 +2403,9 @@ discard block |
||
2290 | 2403 | { |
2291 | 2404 | // Build a regular expression for each parameter for the current tag. |
2292 | 2405 | $preg = array(); |
2293 | - foreach ($possible['parameters'] as $p => $info) |
|
2294 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2406 | + foreach ($possible['parameters'] as $p => $info) { |
|
2407 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2408 | + } |
|
2295 | 2409 | |
2296 | 2410 | // Extract the string that potentially holds our parameters. |
2297 | 2411 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2311,24 +2425,27 @@ discard block |
||
2311 | 2425 | |
2312 | 2426 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
2313 | 2427 | |
2314 | - if ($match) |
|
2315 | - $blob_counter = count($blobs) + 1; |
|
2428 | + if ($match) { |
|
2429 | + $blob_counter = count($blobs) + 1; |
|
2430 | + } |
|
2316 | 2431 | } |
2317 | 2432 | |
2318 | 2433 | // Didn't match our parameter list, try the next possible. |
2319 | - if (!$match) |
|
2320 | - continue; |
|
2434 | + if (!$match) { |
|
2435 | + continue; |
|
2436 | + } |
|
2321 | 2437 | |
2322 | 2438 | $params = array(); |
2323 | 2439 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
2324 | 2440 | { |
2325 | 2441 | $key = strtok(ltrim($matches[$i]), '='); |
2326 | - if (isset($possible['parameters'][$key]['value'])) |
|
2327 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2328 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
2329 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2330 | - else |
|
2331 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2442 | + if (isset($possible['parameters'][$key]['value'])) { |
|
2443 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2444 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
2445 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2446 | + } else { |
|
2447 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2448 | + } |
|
2332 | 2449 | |
2333 | 2450 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
2334 | 2451 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2336,23 +2453,26 @@ discard block |
||
2336 | 2453 | |
2337 | 2454 | foreach ($possible['parameters'] as $p => $info) |
2338 | 2455 | { |
2339 | - if (!isset($params['{' . $p . '}'])) |
|
2340 | - $params['{' . $p . '}'] = ''; |
|
2456 | + if (!isset($params['{' . $p . '}'])) { |
|
2457 | + $params['{' . $p . '}'] = ''; |
|
2458 | + } |
|
2341 | 2459 | } |
2342 | 2460 | |
2343 | 2461 | $tag = $possible; |
2344 | 2462 | |
2345 | 2463 | // Put the parameters into the string. |
2346 | - if (isset($tag['before'])) |
|
2347 | - $tag['before'] = strtr($tag['before'], $params); |
|
2348 | - if (isset($tag['after'])) |
|
2349 | - $tag['after'] = strtr($tag['after'], $params); |
|
2350 | - if (isset($tag['content'])) |
|
2351 | - $tag['content'] = strtr($tag['content'], $params); |
|
2464 | + if (isset($tag['before'])) { |
|
2465 | + $tag['before'] = strtr($tag['before'], $params); |
|
2466 | + } |
|
2467 | + if (isset($tag['after'])) { |
|
2468 | + $tag['after'] = strtr($tag['after'], $params); |
|
2469 | + } |
|
2470 | + if (isset($tag['content'])) { |
|
2471 | + $tag['content'] = strtr($tag['content'], $params); |
|
2472 | + } |
|
2352 | 2473 | |
2353 | 2474 | $pos1 += strlen($given_param_string); |
2354 | - } |
|
2355 | - else |
|
2475 | + } else |
|
2356 | 2476 | { |
2357 | 2477 | $tag = $possible; |
2358 | 2478 | $params = array(); |
@@ -2363,8 +2483,9 @@ discard block |
||
2363 | 2483 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
2364 | 2484 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
2365 | 2485 | { |
2366 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
2367 | - continue; |
|
2486 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
2487 | + continue; |
|
2488 | + } |
|
2368 | 2489 | |
2369 | 2490 | $tag = $itemcodes[$message[$pos + 1]]; |
2370 | 2491 | |
@@ -2385,9 +2506,9 @@ discard block |
||
2385 | 2506 | { |
2386 | 2507 | array_pop($open_tags); |
2387 | 2508 | $code = '</li>'; |
2509 | + } else { |
|
2510 | + $code = ''; |
|
2388 | 2511 | } |
2389 | - else |
|
2390 | - $code = ''; |
|
2391 | 2512 | |
2392 | 2513 | // Now we open a new tag. |
2393 | 2514 | $open_tags[] = array( |
@@ -2434,12 +2555,14 @@ discard block |
||
2434 | 2555 | } |
2435 | 2556 | |
2436 | 2557 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
2437 | - if ($tag === null) |
|
2438 | - continue; |
|
2558 | + if ($tag === null) { |
|
2559 | + continue; |
|
2560 | + } |
|
2439 | 2561 | |
2440 | 2562 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
2441 | - if (isset($inside['disallow_children'])) |
|
2442 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2563 | + if (isset($inside['disallow_children'])) { |
|
2564 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2565 | + } |
|
2443 | 2566 | |
2444 | 2567 | // Is this tag disabled? |
2445 | 2568 | if (isset($disabled[$tag['tag']])) |
@@ -2449,14 +2572,13 @@ discard block |
||
2449 | 2572 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
2450 | 2573 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
2451 | 2574 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
2452 | - } |
|
2453 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2575 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2454 | 2576 | { |
2455 | 2577 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
2456 | 2578 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
2579 | + } else { |
|
2580 | + $tag['content'] = $tag['disabled_content']; |
|
2457 | 2581 | } |
2458 | - else |
|
2459 | - $tag['content'] = $tag['disabled_content']; |
|
2460 | 2582 | } |
2461 | 2583 | |
2462 | 2584 | // we use this a lot |
@@ -2466,8 +2588,9 @@ discard block |
||
2466 | 2588 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
2467 | 2589 | { |
2468 | 2590 | $n = count($open_tags) - 1; |
2469 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
2470 | - $n--; |
|
2591 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
2592 | + $n--; |
|
2593 | + } |
|
2471 | 2594 | |
2472 | 2595 | // Close all the non block level tags so this tag isn't surrounded by them. |
2473 | 2596 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2479,12 +2602,15 @@ discard block |
||
2479 | 2602 | |
2480 | 2603 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
2481 | 2604 | $whitespace_regex = ''; |
2482 | - if (!empty($tag['block_level'])) |
|
2483 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2484 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2485 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2486 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2487 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2605 | + if (!empty($tag['block_level'])) { |
|
2606 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2607 | + } |
|
2608 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2609 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2610 | + } |
|
2611 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2612 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2613 | + } |
|
2488 | 2614 | |
2489 | 2615 | array_pop($open_tags); |
2490 | 2616 | } |
@@ -2502,16 +2628,19 @@ discard block |
||
2502 | 2628 | elseif ($tag['type'] == 'unparsed_content') |
2503 | 2629 | { |
2504 | 2630 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
2505 | - if ($pos2 === false) |
|
2506 | - continue; |
|
2631 | + if ($pos2 === false) { |
|
2632 | + continue; |
|
2633 | + } |
|
2507 | 2634 | |
2508 | 2635 | $data = substr($message, $pos1, $pos2 - $pos1); |
2509 | 2636 | |
2510 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
2511 | - $data = substr($data, 4); |
|
2637 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
2638 | + $data = substr($data, 4); |
|
2639 | + } |
|
2512 | 2640 | |
2513 | - if (isset($tag['validate'])) |
|
2514 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2641 | + if (isset($tag['validate'])) { |
|
2642 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2643 | + } |
|
2515 | 2644 | |
2516 | 2645 | $code = strtr($tag['content'], array('$1' => $data)); |
2517 | 2646 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2527,34 +2656,40 @@ discard block |
||
2527 | 2656 | if (isset($tag['quoted'])) |
2528 | 2657 | { |
2529 | 2658 | $quoted = substr($message, $pos1, 6) == '"'; |
2530 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2531 | - continue; |
|
2659 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2660 | + continue; |
|
2661 | + } |
|
2532 | 2662 | |
2533 | - if ($quoted) |
|
2534 | - $pos1 += 6; |
|
2663 | + if ($quoted) { |
|
2664 | + $pos1 += 6; |
|
2665 | + } |
|
2666 | + } else { |
|
2667 | + $quoted = false; |
|
2535 | 2668 | } |
2536 | - else |
|
2537 | - $quoted = false; |
|
2538 | 2669 | |
2539 | 2670 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2540 | - if ($pos2 === false) |
|
2541 | - continue; |
|
2671 | + if ($pos2 === false) { |
|
2672 | + continue; |
|
2673 | + } |
|
2542 | 2674 | |
2543 | 2675 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2544 | - if ($pos3 === false) |
|
2545 | - continue; |
|
2676 | + if ($pos3 === false) { |
|
2677 | + continue; |
|
2678 | + } |
|
2546 | 2679 | |
2547 | 2680 | $data = array( |
2548 | 2681 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
2549 | 2682 | substr($message, $pos1, $pos2 - $pos1) |
2550 | 2683 | ); |
2551 | 2684 | |
2552 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
2553 | - $data[0] = substr($data[0], 4); |
|
2685 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
2686 | + $data[0] = substr($data[0], 4); |
|
2687 | + } |
|
2554 | 2688 | |
2555 | 2689 | // Validation for my parking, please! |
2556 | - if (isset($tag['validate'])) |
|
2557 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2690 | + if (isset($tag['validate'])) { |
|
2691 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2692 | + } |
|
2558 | 2693 | |
2559 | 2694 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
2560 | 2695 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2571,23 +2706,27 @@ discard block |
||
2571 | 2706 | elseif ($tag['type'] == 'unparsed_commas_content') |
2572 | 2707 | { |
2573 | 2708 | $pos2 = strpos($message, ']', $pos1); |
2574 | - if ($pos2 === false) |
|
2575 | - continue; |
|
2709 | + if ($pos2 === false) { |
|
2710 | + continue; |
|
2711 | + } |
|
2576 | 2712 | |
2577 | 2713 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2578 | - if ($pos3 === false) |
|
2579 | - continue; |
|
2714 | + if ($pos3 === false) { |
|
2715 | + continue; |
|
2716 | + } |
|
2580 | 2717 | |
2581 | 2718 | // We want $1 to be the content, and the rest to be csv. |
2582 | 2719 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
2583 | 2720 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
2584 | 2721 | |
2585 | - if (isset($tag['validate'])) |
|
2586 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2722 | + if (isset($tag['validate'])) { |
|
2723 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2724 | + } |
|
2587 | 2725 | |
2588 | 2726 | $code = $tag['content']; |
2589 | - foreach ($data as $k => $d) |
|
2590 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2727 | + foreach ($data as $k => $d) { |
|
2728 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2729 | + } |
|
2591 | 2730 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
2592 | 2731 | $pos += strlen($code) - 1 + 2; |
2593 | 2732 | } |
@@ -2595,24 +2734,28 @@ discard block |
||
2595 | 2734 | elseif ($tag['type'] == 'unparsed_commas') |
2596 | 2735 | { |
2597 | 2736 | $pos2 = strpos($message, ']', $pos1); |
2598 | - if ($pos2 === false) |
|
2599 | - continue; |
|
2737 | + if ($pos2 === false) { |
|
2738 | + continue; |
|
2739 | + } |
|
2600 | 2740 | |
2601 | 2741 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
2602 | 2742 | |
2603 | - if (isset($tag['validate'])) |
|
2604 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2743 | + if (isset($tag['validate'])) { |
|
2744 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2745 | + } |
|
2605 | 2746 | |
2606 | 2747 | // Fix after, for disabled code mainly. |
2607 | - foreach ($data as $k => $d) |
|
2608 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2748 | + foreach ($data as $k => $d) { |
|
2749 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2750 | + } |
|
2609 | 2751 | |
2610 | 2752 | $open_tags[] = $tag; |
2611 | 2753 | |
2612 | 2754 | // Replace them out, $1, $2, $3, $4, etc. |
2613 | 2755 | $code = $tag['before']; |
2614 | - foreach ($data as $k => $d) |
|
2615 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2756 | + foreach ($data as $k => $d) { |
|
2757 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2758 | + } |
|
2616 | 2759 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
2617 | 2760 | $pos += strlen($code) - 1 + 2; |
2618 | 2761 | } |
@@ -2623,28 +2766,33 @@ discard block |
||
2623 | 2766 | if (isset($tag['quoted'])) |
2624 | 2767 | { |
2625 | 2768 | $quoted = substr($message, $pos1, 6) == '"'; |
2626 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2627 | - continue; |
|
2769 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2770 | + continue; |
|
2771 | + } |
|
2628 | 2772 | |
2629 | - if ($quoted) |
|
2630 | - $pos1 += 6; |
|
2773 | + if ($quoted) { |
|
2774 | + $pos1 += 6; |
|
2775 | + } |
|
2776 | + } else { |
|
2777 | + $quoted = false; |
|
2631 | 2778 | } |
2632 | - else |
|
2633 | - $quoted = false; |
|
2634 | 2779 | |
2635 | 2780 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2636 | - if ($pos2 === false) |
|
2637 | - continue; |
|
2781 | + if ($pos2 === false) { |
|
2782 | + continue; |
|
2783 | + } |
|
2638 | 2784 | |
2639 | 2785 | $data = substr($message, $pos1, $pos2 - $pos1); |
2640 | 2786 | |
2641 | 2787 | // Validation for my parking, please! |
2642 | - if (isset($tag['validate'])) |
|
2643 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2788 | + if (isset($tag['validate'])) { |
|
2789 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2790 | + } |
|
2644 | 2791 | |
2645 | 2792 | // For parsed content, we must recurse to avoid security problems. |
2646 | - if ($tag['type'] != 'unparsed_equals') |
|
2647 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2793 | + if ($tag['type'] != 'unparsed_equals') { |
|
2794 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2795 | + } |
|
2648 | 2796 | |
2649 | 2797 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
2650 | 2798 | |
@@ -2656,34 +2804,40 @@ discard block |
||
2656 | 2804 | } |
2657 | 2805 | |
2658 | 2806 | // If this is block level, eat any breaks after it. |
2659 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
2660 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2807 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
2808 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2809 | + } |
|
2661 | 2810 | |
2662 | 2811 | // Are we trimming outside this tag? |
2663 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
2664 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2812 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
2813 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2814 | + } |
|
2665 | 2815 | } |
2666 | 2816 | |
2667 | 2817 | // Close any remaining tags. |
2668 | - while ($tag = array_pop($open_tags)) |
|
2669 | - $message .= "\n" . $tag['after'] . "\n"; |
|
2818 | + while ($tag = array_pop($open_tags)) { |
|
2819 | + $message .= "\n" . $tag['after'] . "\n"; |
|
2820 | + } |
|
2670 | 2821 | |
2671 | 2822 | // Parse the smileys within the parts where it can be done safely. |
2672 | 2823 | if ($smileys === true) |
2673 | 2824 | { |
2674 | 2825 | $message_parts = explode("\n", $message); |
2675 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
2676 | - parsesmileys($message_parts[$i]); |
|
2826 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
2827 | + parsesmileys($message_parts[$i]); |
|
2828 | + } |
|
2677 | 2829 | |
2678 | 2830 | $message = implode('', $message_parts); |
2679 | 2831 | } |
2680 | 2832 | |
2681 | 2833 | // No smileys, just get rid of the markers. |
2682 | - else |
|
2683 | - $message = strtr($message, array("\n" => '')); |
|
2834 | + else { |
|
2835 | + $message = strtr($message, array("\n" => '')); |
|
2836 | + } |
|
2684 | 2837 | |
2685 | - if ($message !== '' && $message[0] === ' ') |
|
2686 | - $message = ' ' . substr($message, 1); |
|
2838 | + if ($message !== '' && $message[0] === ' ') { |
|
2839 | + $message = ' ' . substr($message, 1); |
|
2840 | + } |
|
2687 | 2841 | |
2688 | 2842 | // Cleanup whitespace. |
2689 | 2843 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2692,15 +2846,16 @@ discard block |
||
2692 | 2846 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
2693 | 2847 | |
2694 | 2848 | // Cache the output if it took some time... |
2695 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
2696 | - cache_put_data($cache_key, $message, 240); |
|
2849 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
2850 | + cache_put_data($cache_key, $message, 240); |
|
2851 | + } |
|
2697 | 2852 | |
2698 | 2853 | // If this was a force parse revert if needed. |
2699 | 2854 | if (!empty($parse_tags)) |
2700 | 2855 | { |
2701 | - if (empty($temp_bbc)) |
|
2702 | - $bbc_codes = array(); |
|
2703 | - else |
|
2856 | + if (empty($temp_bbc)) { |
|
2857 | + $bbc_codes = array(); |
|
2858 | + } else |
|
2704 | 2859 | { |
2705 | 2860 | $bbc_codes = $temp_bbc; |
2706 | 2861 | unset($temp_bbc); |
@@ -2727,8 +2882,9 @@ discard block |
||
2727 | 2882 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
2728 | 2883 | |
2729 | 2884 | // No smiley set at all?! |
2730 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
2731 | - return; |
|
2885 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
2886 | + return; |
|
2887 | + } |
|
2732 | 2888 | |
2733 | 2889 | // If smileyPregSearch hasn't been set, do it now. |
2734 | 2890 | if (empty($smileyPregSearch)) |
@@ -2739,8 +2895,7 @@ discard block |
||
2739 | 2895 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
2740 | 2896 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
2741 | 2897 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
2742 | - } |
|
2743 | - else |
|
2898 | + } else |
|
2744 | 2899 | { |
2745 | 2900 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
2746 | 2901 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2764,9 +2919,9 @@ discard block |
||
2764 | 2919 | $smcFunc['db_free_result']($result); |
2765 | 2920 | |
2766 | 2921 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
2922 | + } else { |
|
2923 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2767 | 2924 | } |
2768 | - else |
|
2769 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2770 | 2925 | } |
2771 | 2926 | |
2772 | 2927 | // The non-breaking-space is a complex thing... |
@@ -2843,35 +2998,41 @@ discard block |
||
2843 | 2998 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
2844 | 2999 | |
2845 | 3000 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
2846 | - if (!empty($context['flush_mail'])) |
|
2847 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3001 | + if (!empty($context['flush_mail'])) { |
|
3002 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2848 | 3003 | AddMailQueue(true); |
3004 | + } |
|
2849 | 3005 | |
2850 | 3006 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
2851 | 3007 | |
2852 | - if ($add) |
|
2853 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3008 | + if ($add) { |
|
3009 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3010 | + } |
|
2854 | 3011 | |
2855 | 3012 | // Put the session ID in. |
2856 | - if (defined('SID') && SID != '') |
|
2857 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3013 | + if (defined('SID') && SID != '') { |
|
3014 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3015 | + } |
|
2858 | 3016 | // Keep that debug in their for template debugging! |
2859 | - elseif (isset($_GET['debug'])) |
|
2860 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3017 | + elseif (isset($_GET['debug'])) { |
|
3018 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3019 | + } |
|
2861 | 3020 | |
2862 | 3021 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
2863 | 3022 | { |
2864 | - if (defined('SID') && SID != '') |
|
2865 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
3023 | + if (defined('SID') && SID != '') { |
|
3024 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
2866 | 3025 | function ($m) use ($scripturl) |
2867 | 3026 | { |
2868 | 3027 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
3028 | + } |
|
2869 | 3029 | }, $setLocation); |
2870 | - else |
|
2871 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
3030 | + else { |
|
3031 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
2872 | 3032 | function ($m) use ($scripturl) |
2873 | 3033 | { |
2874 | 3034 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
3035 | + } |
|
2875 | 3036 | }, $setLocation); |
2876 | 3037 | } |
2877 | 3038 | |
@@ -2882,8 +3043,9 @@ discard block |
||
2882 | 3043 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
2883 | 3044 | |
2884 | 3045 | // Debugging. |
2885 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
2886 | - $_SESSION['debug_redirect'] = $db_cache; |
|
3046 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3047 | + $_SESSION['debug_redirect'] = $db_cache; |
|
3048 | + } |
|
2887 | 3049 | |
2888 | 3050 | obExit(false); |
2889 | 3051 | } |
@@ -2902,51 +3064,60 @@ discard block |
||
2902 | 3064 | |
2903 | 3065 | // Attempt to prevent a recursive loop. |
2904 | 3066 | ++$level; |
2905 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
2906 | - exit; |
|
2907 | - if ($from_fatal_error) |
|
2908 | - $has_fatal_error = true; |
|
3067 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
3068 | + exit; |
|
3069 | + } |
|
3070 | + if ($from_fatal_error) { |
|
3071 | + $has_fatal_error = true; |
|
3072 | + } |
|
2909 | 3073 | |
2910 | 3074 | // Clear out the stat cache. |
2911 | 3075 | trackStats(); |
2912 | 3076 | |
2913 | 3077 | // If we have mail to send, send it. |
2914 | - if (!empty($context['flush_mail'])) |
|
2915 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3078 | + if (!empty($context['flush_mail'])) { |
|
3079 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2916 | 3080 | AddMailQueue(true); |
3081 | + } |
|
2917 | 3082 | |
2918 | 3083 | $do_header = $header === null ? !$header_done : $header; |
2919 | - if ($do_footer === null) |
|
2920 | - $do_footer = $do_header; |
|
3084 | + if ($do_footer === null) { |
|
3085 | + $do_footer = $do_header; |
|
3086 | + } |
|
2921 | 3087 | |
2922 | 3088 | // Has the template/header been done yet? |
2923 | 3089 | if ($do_header) |
2924 | 3090 | { |
2925 | 3091 | // Was the page title set last minute? Also update the HTML safe one. |
2926 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
2927 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3092 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
3093 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3094 | + } |
|
2928 | 3095 | |
2929 | 3096 | // Start up the session URL fixer. |
2930 | 3097 | ob_start('ob_sessrewrite'); |
2931 | 3098 | |
2932 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
2933 | - $buffers = explode(',', $settings['output_buffers']); |
|
2934 | - elseif (!empty($settings['output_buffers'])) |
|
2935 | - $buffers = $settings['output_buffers']; |
|
2936 | - else |
|
2937 | - $buffers = array(); |
|
3099 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
3100 | + $buffers = explode(',', $settings['output_buffers']); |
|
3101 | + } elseif (!empty($settings['output_buffers'])) { |
|
3102 | + $buffers = $settings['output_buffers']; |
|
3103 | + } else { |
|
3104 | + $buffers = array(); |
|
3105 | + } |
|
2938 | 3106 | |
2939 | - if (isset($modSettings['integrate_buffer'])) |
|
2940 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3107 | + if (isset($modSettings['integrate_buffer'])) { |
|
3108 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3109 | + } |
|
2941 | 3110 | |
2942 | - if (!empty($buffers)) |
|
2943 | - foreach ($buffers as $function) |
|
3111 | + if (!empty($buffers)) { |
|
3112 | + foreach ($buffers as $function) |
|
2944 | 3113 | { |
2945 | 3114 | $call = call_helper($function, true); |
3115 | + } |
|
2946 | 3116 | |
2947 | 3117 | // Is it valid? |
2948 | - if (!empty($call)) |
|
2949 | - ob_start($call); |
|
3118 | + if (!empty($call)) { |
|
3119 | + ob_start($call); |
|
3120 | + } |
|
2950 | 3121 | } |
2951 | 3122 | |
2952 | 3123 | // Display the screen in the logical order. |
@@ -2958,8 +3129,9 @@ discard block |
||
2958 | 3129 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
2959 | 3130 | |
2960 | 3131 | // Anything special to put out? |
2961 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
2962 | - echo $context['insert_after_template']; |
|
3132 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
3133 | + echo $context['insert_after_template']; |
|
3134 | + } |
|
2963 | 3135 | |
2964 | 3136 | // Just so we don't get caught in an endless loop of errors from the footer... |
2965 | 3137 | if (!$footer_done) |
@@ -2968,14 +3140,16 @@ discard block |
||
2968 | 3140 | template_footer(); |
2969 | 3141 | |
2970 | 3142 | // (since this is just debugging... it's okay that it's after </html>.) |
2971 | - if (!isset($_REQUEST['xml'])) |
|
2972 | - displayDebug(); |
|
3143 | + if (!isset($_REQUEST['xml'])) { |
|
3144 | + displayDebug(); |
|
3145 | + } |
|
2973 | 3146 | } |
2974 | 3147 | } |
2975 | 3148 | |
2976 | 3149 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
2977 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
2978 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3150 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
3151 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3152 | + } |
|
2979 | 3153 | |
2980 | 3154 | // For session check verification.... don't switch browsers... |
2981 | 3155 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -2984,9 +3158,10 @@ discard block |
||
2984 | 3158 | call_integration_hook('integrate_exit', array($do_footer)); |
2985 | 3159 | |
2986 | 3160 | // Don't exit if we're coming from index.php; that will pass through normally. |
2987 | - if (!$from_index) |
|
2988 | - exit; |
|
2989 | -} |
|
3161 | + if (!$from_index) { |
|
3162 | + exit; |
|
3163 | + } |
|
3164 | + } |
|
2990 | 3165 | |
2991 | 3166 | /** |
2992 | 3167 | * Get the size of a specified image with better error handling. |
@@ -3005,8 +3180,9 @@ discard block |
||
3005 | 3180 | $url = str_replace(' ', '%20', $url); |
3006 | 3181 | |
3007 | 3182 | // Can we pull this from the cache... please please? |
3008 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
3009 | - return $temp; |
|
3183 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
3184 | + return $temp; |
|
3185 | + } |
|
3010 | 3186 | $t = microtime(); |
3011 | 3187 | |
3012 | 3188 | // Get the host to pester... |
@@ -3016,12 +3192,10 @@ discard block |
||
3016 | 3192 | if ($url == '' || $url == 'http://' || $url == 'https://') |
3017 | 3193 | { |
3018 | 3194 | return false; |
3019 | - } |
|
3020 | - elseif (!isset($match[1])) |
|
3195 | + } elseif (!isset($match[1])) |
|
3021 | 3196 | { |
3022 | 3197 | $size = @getimagesize($url); |
3023 | - } |
|
3024 | - else |
|
3198 | + } else |
|
3025 | 3199 | { |
3026 | 3200 | // Try to connect to the server... give it half a second. |
3027 | 3201 | $temp = 0; |
@@ -3060,12 +3234,14 @@ discard block |
||
3060 | 3234 | } |
3061 | 3235 | |
3062 | 3236 | // If we didn't get it, we failed. |
3063 | - if (!isset($size)) |
|
3064 | - $size = false; |
|
3237 | + if (!isset($size)) { |
|
3238 | + $size = false; |
|
3239 | + } |
|
3065 | 3240 | |
3066 | 3241 | // If this took a long time, we may never have to do it again, but then again we might... |
3067 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
3068 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3242 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
3243 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3244 | + } |
|
3069 | 3245 | |
3070 | 3246 | // Didn't work. |
3071 | 3247 | return $size; |
@@ -3083,8 +3259,9 @@ discard block |
||
3083 | 3259 | |
3084 | 3260 | // Under SSI this function can be called more then once. That can cause some problems. |
3085 | 3261 | // So only run the function once unless we are forced to run it again. |
3086 | - if ($loaded && !$forceload) |
|
3087 | - return; |
|
3262 | + if ($loaded && !$forceload) { |
|
3263 | + return; |
|
3264 | + } |
|
3088 | 3265 | |
3089 | 3266 | $loaded = true; |
3090 | 3267 | |
@@ -3096,14 +3273,16 @@ discard block |
||
3096 | 3273 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
3097 | 3274 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
3098 | 3275 | { |
3099 | - if (trim($context['news_lines'][$i]) == '') |
|
3100 | - continue; |
|
3276 | + if (trim($context['news_lines'][$i]) == '') { |
|
3277 | + continue; |
|
3278 | + } |
|
3101 | 3279 | |
3102 | 3280 | // Clean it up for presentation ;). |
3103 | 3281 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
3104 | 3282 | } |
3105 | - if (!empty($context['news_lines'])) |
|
3106 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3283 | + if (!empty($context['news_lines'])) { |
|
3284 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3285 | + } |
|
3107 | 3286 | |
3108 | 3287 | if (!$user_info['is_guest']) |
3109 | 3288 | { |
@@ -3112,40 +3291,48 @@ discard block |
||
3112 | 3291 | $context['user']['alerts'] = &$user_info['alerts']; |
3113 | 3292 | |
3114 | 3293 | // Personal message popup... |
3115 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
3116 | - $context['user']['popup_messages'] = true; |
|
3117 | - else |
|
3118 | - $context['user']['popup_messages'] = false; |
|
3294 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
3295 | + $context['user']['popup_messages'] = true; |
|
3296 | + } else { |
|
3297 | + $context['user']['popup_messages'] = false; |
|
3298 | + } |
|
3119 | 3299 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
3120 | 3300 | |
3121 | - if (allowedTo('moderate_forum')) |
|
3122 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3301 | + if (allowedTo('moderate_forum')) { |
|
3302 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3303 | + } |
|
3123 | 3304 | |
3124 | 3305 | $context['user']['avatar'] = array(); |
3125 | 3306 | |
3126 | 3307 | // Check for gravatar first since we might be forcing them... |
3127 | 3308 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
3128 | 3309 | { |
3129 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
3130 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3131 | - else |
|
3132 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3310 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
3311 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3312 | + } else { |
|
3313 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3314 | + } |
|
3133 | 3315 | } |
3134 | 3316 | // Uploaded? |
3135 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
3136 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3317 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
3318 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3319 | + } |
|
3137 | 3320 | // Full URL? |
3138 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
3139 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3321 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
3322 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3323 | + } |
|
3140 | 3324 | // Otherwise we assume it's server stored. |
3141 | - elseif ($user_info['avatar']['url'] != '') |
|
3142 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3325 | + elseif ($user_info['avatar']['url'] != '') { |
|
3326 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3327 | + } |
|
3143 | 3328 | // No avatar at all? Fine, we have a big fat default avatar ;) |
3144 | - else |
|
3145 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3329 | + else { |
|
3330 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3331 | + } |
|
3146 | 3332 | |
3147 | - if (!empty($context['user']['avatar'])) |
|
3148 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3333 | + if (!empty($context['user']['avatar'])) { |
|
3334 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3335 | + } |
|
3149 | 3336 | |
3150 | 3337 | // Figure out how long they've been logged in. |
3151 | 3338 | $context['user']['total_time_logged_in'] = array( |
@@ -3153,8 +3340,7 @@ discard block |
||
3153 | 3340 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
3154 | 3341 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
3155 | 3342 | ); |
3156 | - } |
|
3157 | - else |
|
3343 | + } else |
|
3158 | 3344 | { |
3159 | 3345 | $context['user']['messages'] = 0; |
3160 | 3346 | $context['user']['unread_messages'] = 0; |
@@ -3162,12 +3348,14 @@ discard block |
||
3162 | 3348 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
3163 | 3349 | $context['user']['popup_messages'] = false; |
3164 | 3350 | |
3165 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
3166 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3351 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
3352 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3353 | + } |
|
3167 | 3354 | |
3168 | 3355 | // If we've upgraded recently, go easy on the passwords. |
3169 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
3170 | - $context['disable_login_hashing'] = true; |
|
3356 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
3357 | + $context['disable_login_hashing'] = true; |
|
3358 | + } |
|
3171 | 3359 | } |
3172 | 3360 | |
3173 | 3361 | // Setup the main menu items. |
@@ -3180,8 +3368,8 @@ discard block |
||
3180 | 3368 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
3181 | 3369 | |
3182 | 3370 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
3183 | - if ($context['show_pm_popup']) |
|
3184 | - addInlineJavaScript(' |
|
3371 | + if ($context['show_pm_popup']) { |
|
3372 | + addInlineJavaScript(' |
|
3185 | 3373 | jQuery(document).ready(function($) { |
3186 | 3374 | new smc_Popup({ |
3187 | 3375 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3189,15 +3377,17 @@ discard block |
||
3189 | 3377 | icon_class: \'generic_icons mail_new\' |
3190 | 3378 | }); |
3191 | 3379 | });'); |
3380 | + } |
|
3192 | 3381 | |
3193 | 3382 | // Add a generic "Are you sure?" confirmation message. |
3194 | 3383 | addInlineJavaScript(' |
3195 | 3384 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
3196 | 3385 | |
3197 | 3386 | // Now add the capping code for avatars. |
3198 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
3199 | - addInlineCss(' |
|
3387 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
3388 | + addInlineCss(' |
|
3200 | 3389 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
3390 | + } |
|
3201 | 3391 | |
3202 | 3392 | // This looks weird, but it's because BoardIndex.php references the variable. |
3203 | 3393 | $context['common_stats']['latest_member'] = array( |
@@ -3214,11 +3404,13 @@ discard block |
||
3214 | 3404 | ); |
3215 | 3405 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
3216 | 3406 | |
3217 | - if (empty($settings['theme_version'])) |
|
3218 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
3407 | + if (empty($settings['theme_version'])) { |
|
3408 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
3409 | + } |
|
3219 | 3410 | |
3220 | - if (!isset($context['page_title'])) |
|
3221 | - $context['page_title'] = ''; |
|
3411 | + if (!isset($context['page_title'])) { |
|
3412 | + $context['page_title'] = ''; |
|
3413 | + } |
|
3222 | 3414 | |
3223 | 3415 | // Set some specific vars. |
3224 | 3416 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3228,21 +3420,23 @@ discard block |
||
3228 | 3420 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
3229 | 3421 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
3230 | 3422 | |
3231 | - if (!empty($context['meta_keywords'])) |
|
3232 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3423 | + if (!empty($context['meta_keywords'])) { |
|
3424 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3425 | + } |
|
3233 | 3426 | |
3234 | - if (!empty($context['canonical_url'])) |
|
3235 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3427 | + if (!empty($context['canonical_url'])) { |
|
3428 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3429 | + } |
|
3236 | 3430 | |
3237 | - if (!empty($settings['og_image'])) |
|
3238 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3431 | + if (!empty($settings['og_image'])) { |
|
3432 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3433 | + } |
|
3239 | 3434 | |
3240 | 3435 | if (!empty($context['meta_description'])) |
3241 | 3436 | { |
3242 | 3437 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
3243 | 3438 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
3244 | - } |
|
3245 | - else |
|
3439 | + } else |
|
3246 | 3440 | { |
3247 | 3441 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
3248 | 3442 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3267,8 +3461,9 @@ discard block |
||
3267 | 3461 | $memory_needed = memoryReturnBytes($needed); |
3268 | 3462 | |
3269 | 3463 | // should we account for how much is currently being used? |
3270 | - if ($in_use) |
|
3271 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3464 | + if ($in_use) { |
|
3465 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3466 | + } |
|
3272 | 3467 | |
3273 | 3468 | // if more is needed, request it |
3274 | 3469 | if ($memory_current < $memory_needed) |
@@ -3291,8 +3486,9 @@ discard block |
||
3291 | 3486 | */ |
3292 | 3487 | function memoryReturnBytes($val) |
3293 | 3488 | { |
3294 | - if (is_integer($val)) |
|
3295 | - return $val; |
|
3489 | + if (is_integer($val)) { |
|
3490 | + return $val; |
|
3491 | + } |
|
3296 | 3492 | |
3297 | 3493 | // Separate the number from the designator |
3298 | 3494 | $val = trim($val); |
@@ -3328,10 +3524,11 @@ discard block |
||
3328 | 3524 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
3329 | 3525 | |
3330 | 3526 | // Are we debugging the template/html content? |
3331 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
3332 | - header('Content-Type: application/xhtml+xml'); |
|
3333 | - elseif (!isset($_REQUEST['xml'])) |
|
3334 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3527 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
3528 | + header('Content-Type: application/xhtml+xml'); |
|
3529 | + } elseif (!isset($_REQUEST['xml'])) { |
|
3530 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3531 | + } |
|
3335 | 3532 | } |
3336 | 3533 | |
3337 | 3534 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3340,8 +3537,9 @@ discard block |
||
3340 | 3537 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
3341 | 3538 | { |
3342 | 3539 | $position = array_search('body', $context['template_layers']); |
3343 | - if ($position === false) |
|
3344 | - $position = array_search('main', $context['template_layers']); |
|
3540 | + if ($position === false) { |
|
3541 | + $position = array_search('main', $context['template_layers']); |
|
3542 | + } |
|
3345 | 3543 | |
3346 | 3544 | if ($position !== false) |
3347 | 3545 | { |
@@ -3369,23 +3567,25 @@ discard block |
||
3369 | 3567 | |
3370 | 3568 | foreach ($securityFiles as $i => $securityFile) |
3371 | 3569 | { |
3372 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
3373 | - unset($securityFiles[$i]); |
|
3570 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
3571 | + unset($securityFiles[$i]); |
|
3572 | + } |
|
3374 | 3573 | } |
3375 | 3574 | |
3376 | 3575 | // We are already checking so many files...just few more doesn't make any difference! :P |
3377 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
3378 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3379 | - |
|
3380 | - else |
|
3381 | - $path = $modSettings['attachmentUploadDir']; |
|
3576 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
3577 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3578 | + } else { |
|
3579 | + $path = $modSettings['attachmentUploadDir']; |
|
3580 | + } |
|
3382 | 3581 | |
3383 | 3582 | secureDirectory($path, true); |
3384 | 3583 | secureDirectory($cachedir); |
3385 | 3584 | |
3386 | 3585 | // If agreement is enabled, at least the english version shall exists |
3387 | - if ($modSettings['requireAgreement']) |
|
3388 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3586 | + if ($modSettings['requireAgreement']) { |
|
3587 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3588 | + } |
|
3389 | 3589 | |
3390 | 3590 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
3391 | 3591 | { |
@@ -3400,18 +3600,21 @@ discard block |
||
3400 | 3600 | echo ' |
3401 | 3601 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
3402 | 3602 | |
3403 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
3404 | - echo ' |
|
3603 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
3604 | + echo ' |
|
3405 | 3605 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
3606 | + } |
|
3406 | 3607 | } |
3407 | 3608 | |
3408 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
3409 | - echo ' |
|
3609 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
3610 | + echo ' |
|
3410 | 3611 | <strong>', $txt['cache_writable'], '</strong><br>'; |
3612 | + } |
|
3411 | 3613 | |
3412 | - if (!empty($agreement)) |
|
3413 | - echo ' |
|
3614 | + if (!empty($agreement)) { |
|
3615 | + echo ' |
|
3414 | 3616 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
3617 | + } |
|
3415 | 3618 | |
3416 | 3619 | echo ' |
3417 | 3620 | </p> |
@@ -3426,16 +3629,18 @@ discard block |
||
3426 | 3629 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
3427 | 3630 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
3428 | 3631 | |
3429 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
3430 | - echo ' |
|
3632 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
3633 | + echo ' |
|
3431 | 3634 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
3635 | + } |
|
3432 | 3636 | |
3433 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
3434 | - echo ' |
|
3637 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
3638 | + echo ' |
|
3435 | 3639 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
3436 | - else |
|
3437 | - echo ' |
|
3640 | + } else { |
|
3641 | + echo ' |
|
3438 | 3642 | <div>', $txt['your_ban_expires_never'], '</div>'; |
3643 | + } |
|
3439 | 3644 | |
3440 | 3645 | echo ' |
3441 | 3646 | </div>'; |
@@ -3451,8 +3656,9 @@ discard block |
||
3451 | 3656 | global $forum_copyright, $software_year, $forum_version; |
3452 | 3657 | |
3453 | 3658 | // Don't display copyright for things like SSI. |
3454 | - if (!isset($forum_version) || !isset($software_year)) |
|
3455 | - return; |
|
3659 | + if (!isset($forum_version) || !isset($software_year)) { |
|
3660 | + return; |
|
3661 | + } |
|
3456 | 3662 | |
3457 | 3663 | // Put in the version... |
3458 | 3664 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3470,9 +3676,10 @@ discard block |
||
3470 | 3676 | $context['load_time'] = comma_format(round(array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)), 3)); |
3471 | 3677 | $context['load_queries'] = $db_count; |
3472 | 3678 | |
3473 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
3474 | - loadSubTemplate($layer . '_below', true); |
|
3475 | -} |
|
3679 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
3680 | + loadSubTemplate($layer . '_below', true); |
|
3681 | + } |
|
3682 | + } |
|
3476 | 3683 | |
3477 | 3684 | /** |
3478 | 3685 | * Output the Javascript files |
@@ -3503,8 +3710,7 @@ discard block |
||
3503 | 3710 | { |
3504 | 3711 | echo ' |
3505 | 3712 | var ', $key, ';'; |
3506 | - } |
|
3507 | - else |
|
3713 | + } else |
|
3508 | 3714 | { |
3509 | 3715 | echo ' |
3510 | 3716 | var ', $key, ' = ', $value, ';'; |
@@ -3519,26 +3725,27 @@ discard block |
||
3519 | 3725 | foreach ($context['javascript_files'] as $id => $js_file) |
3520 | 3726 | { |
3521 | 3727 | // Last minute call! allow theme authors to disable single files. |
3522 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3523 | - continue; |
|
3728 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3729 | + continue; |
|
3730 | + } |
|
3524 | 3731 | |
3525 | 3732 | // By default all files don't get minimized unless the file explicitly says so! |
3526 | 3733 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
3527 | 3734 | { |
3528 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
3529 | - $toMinifyDefer[] = $js_file; |
|
3530 | - |
|
3531 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
3532 | - $toMinify[] = $js_file; |
|
3735 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
3736 | + $toMinifyDefer[] = $js_file; |
|
3737 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
3738 | + $toMinify[] = $js_file; |
|
3739 | + } |
|
3533 | 3740 | |
3534 | 3741 | // Grab a random seed. |
3535 | - if (!isset($minSeed)) |
|
3536 | - $minSeed = $js_file['options']['seed']; |
|
3537 | - } |
|
3538 | - |
|
3539 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
3540 | - echo ' |
|
3742 | + if (!isset($minSeed)) { |
|
3743 | + $minSeed = $js_file['options']['seed']; |
|
3744 | + } |
|
3745 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
3746 | + echo ' |
|
3541 | 3747 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
3748 | + } |
|
3542 | 3749 | } |
3543 | 3750 | |
3544 | 3751 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3546,14 +3753,14 @@ discard block |
||
3546 | 3753 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
3547 | 3754 | |
3548 | 3755 | // Minify process couldn't work, print each individual files. |
3549 | - if (!empty($result) && is_array($result)) |
|
3550 | - foreach ($result as $minFailedFile) |
|
3756 | + if (!empty($result) && is_array($result)) { |
|
3757 | + foreach ($result as $minFailedFile) |
|
3551 | 3758 | echo ' |
3552 | 3759 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
3553 | - |
|
3554 | - else |
|
3555 | - echo ' |
|
3760 | + } else { |
|
3761 | + echo ' |
|
3556 | 3762 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
3763 | + } |
|
3557 | 3764 | } |
3558 | 3765 | |
3559 | 3766 | // Inline JavaScript - Actually useful some times! |
@@ -3564,8 +3771,9 @@ discard block |
||
3564 | 3771 | echo ' |
3565 | 3772 | <script>'; |
3566 | 3773 | |
3567 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
3568 | - echo $js_code; |
|
3774 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
3775 | + echo $js_code; |
|
3776 | + } |
|
3569 | 3777 | |
3570 | 3778 | echo ' |
3571 | 3779 | </script>'; |
@@ -3576,8 +3784,9 @@ discard block |
||
3576 | 3784 | echo ' |
3577 | 3785 | <script>'; |
3578 | 3786 | |
3579 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
3580 | - echo $js_code; |
|
3787 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
3788 | + echo $js_code; |
|
3789 | + } |
|
3581 | 3790 | |
3582 | 3791 | echo ' |
3583 | 3792 | </script>'; |
@@ -3602,8 +3811,9 @@ discard block |
||
3602 | 3811 | foreach ($context['css_files'] as $id => $file) |
3603 | 3812 | { |
3604 | 3813 | // Last minute call! allow theme authors to disable single files. |
3605 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3606 | - continue; |
|
3814 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3815 | + continue; |
|
3816 | + } |
|
3607 | 3817 | |
3608 | 3818 | // By default all files don't get minimized unless the file explicitly says so! |
3609 | 3819 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3611,12 +3821,12 @@ discard block |
||
3611 | 3821 | $toMinify[] = $file; |
3612 | 3822 | |
3613 | 3823 | // Grab a random seed. |
3614 | - if (!isset($minSeed)) |
|
3615 | - $minSeed = $file['options']['seed']; |
|
3824 | + if (!isset($minSeed)) { |
|
3825 | + $minSeed = $file['options']['seed']; |
|
3826 | + } |
|
3827 | + } else { |
|
3828 | + $normal[] = $file['fileUrl']; |
|
3616 | 3829 | } |
3617 | - |
|
3618 | - else |
|
3619 | - $normal[] = $file['fileUrl']; |
|
3620 | 3830 | } |
3621 | 3831 | |
3622 | 3832 | if (!empty($toMinify)) |
@@ -3624,28 +3834,30 @@ discard block |
||
3624 | 3834 | $result = custMinify($toMinify, 'css'); |
3625 | 3835 | |
3626 | 3836 | // Minify process couldn't work, print each individual files. |
3627 | - if (!empty($result) && is_array($result)) |
|
3628 | - foreach ($result as $minFailedFile) |
|
3837 | + if (!empty($result) && is_array($result)) { |
|
3838 | + foreach ($result as $minFailedFile) |
|
3629 | 3839 | echo ' |
3630 | 3840 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
3631 | - |
|
3632 | - else |
|
3633 | - echo ' |
|
3841 | + } else { |
|
3842 | + echo ' |
|
3634 | 3843 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
3844 | + } |
|
3635 | 3845 | } |
3636 | 3846 | |
3637 | 3847 | // Print the rest after the minified files. |
3638 | - if (!empty($normal)) |
|
3639 | - foreach ($normal as $nf) |
|
3848 | + if (!empty($normal)) { |
|
3849 | + foreach ($normal as $nf) |
|
3640 | 3850 | echo ' |
3641 | 3851 | <link rel="stylesheet" href="', $nf ,'">'; |
3852 | + } |
|
3642 | 3853 | |
3643 | 3854 | if ($db_show_debug === true) |
3644 | 3855 | { |
3645 | 3856 | // Try to keep only what's useful. |
3646 | 3857 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
3647 | - foreach ($context['css_files'] as $file) |
|
3648 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3858 | + foreach ($context['css_files'] as $file) { |
|
3859 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3860 | + } |
|
3649 | 3861 | } |
3650 | 3862 | |
3651 | 3863 | if (!empty($context['css_header'])) |
@@ -3653,9 +3865,10 @@ discard block |
||
3653 | 3865 | echo ' |
3654 | 3866 | <style>'; |
3655 | 3867 | |
3656 | - foreach ($context['css_header'] as $css) |
|
3657 | - echo $css .' |
|
3868 | + foreach ($context['css_header'] as $css) { |
|
3869 | + echo $css .' |
|
3658 | 3870 | '; |
3871 | + } |
|
3659 | 3872 | |
3660 | 3873 | echo' |
3661 | 3874 | </style>'; |
@@ -3679,15 +3892,17 @@ discard block |
||
3679 | 3892 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
3680 | 3893 | $data = !empty($data) ? $data : false; |
3681 | 3894 | |
3682 | - if (empty($type) || empty($data)) |
|
3683 | - return false; |
|
3895 | + if (empty($type) || empty($data)) { |
|
3896 | + return false; |
|
3897 | + } |
|
3684 | 3898 | |
3685 | 3899 | // Did we already did this? |
3686 | 3900 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
3687 | 3901 | |
3688 | 3902 | // Already done? |
3689 | - if (!empty($toCache)) |
|
3690 | - return true; |
|
3903 | + if (!empty($toCache)) { |
|
3904 | + return true; |
|
3905 | + } |
|
3691 | 3906 | |
3692 | 3907 | // No namespaces, sorry! |
3693 | 3908 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3769,8 +3984,9 @@ discard block |
||
3769 | 3984 | global $modSettings, $smcFunc; |
3770 | 3985 | |
3771 | 3986 | // Just make up a nice hash... |
3772 | - if ($new) |
|
3773 | - return sha1(md5($filename . time()) . mt_rand()); |
|
3987 | + if ($new) { |
|
3988 | + return sha1(md5($filename . time()) . mt_rand()); |
|
3989 | + } |
|
3774 | 3990 | |
3775 | 3991 | // Just make sure that attachment id is only a int |
3776 | 3992 | $attachment_id = (int) $attachment_id; |
@@ -3787,23 +4003,25 @@ discard block |
||
3787 | 4003 | 'id_attach' => $attachment_id, |
3788 | 4004 | )); |
3789 | 4005 | |
3790 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
3791 | - return false; |
|
4006 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
4007 | + return false; |
|
4008 | + } |
|
3792 | 4009 | |
3793 | 4010 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
3794 | 4011 | $smcFunc['db_free_result']($request); |
3795 | 4012 | } |
3796 | 4013 | |
3797 | 4014 | // Still no hash? mmm... |
3798 | - if (empty($file_hash)) |
|
3799 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4015 | + if (empty($file_hash)) { |
|
4016 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4017 | + } |
|
3800 | 4018 | |
3801 | 4019 | // Are we using multiple directories? |
3802 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
3803 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
3804 | - |
|
3805 | - else |
|
3806 | - $path = $modSettings['attachmentUploadDir']; |
|
4020 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
4021 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
4022 | + } else { |
|
4023 | + $path = $modSettings['attachmentUploadDir']; |
|
4024 | + } |
|
3807 | 4025 | |
3808 | 4026 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
3809 | 4027 | } |
@@ -3818,8 +4036,9 @@ discard block |
||
3818 | 4036 | function ip2range($fullip) |
3819 | 4037 | { |
3820 | 4038 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
3821 | - if ($fullip == 'unknown') |
|
3822 | - $fullip = '255.255.255.255'; |
|
4039 | + if ($fullip == 'unknown') { |
|
4040 | + $fullip = '255.255.255.255'; |
|
4041 | + } |
|
3823 | 4042 | |
3824 | 4043 | $ip_parts = explode('-', $fullip); |
3825 | 4044 | $ip_array = array(); |
@@ -3843,10 +4062,11 @@ discard block |
||
3843 | 4062 | $ip_array['low'] = $ip_parts[0]; |
3844 | 4063 | $ip_array['high'] = $ip_parts[1]; |
3845 | 4064 | return $ip_array; |
3846 | - } |
|
3847 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
4065 | + } elseif (count($ip_parts) == 2) { |
|
4066 | + // if ip 22.22.*-22.22.* |
|
3848 | 4067 | { |
3849 | 4068 | $valid_low = isValidIP($ip_parts[0]); |
4069 | + } |
|
3850 | 4070 | $valid_high = isValidIP($ip_parts[1]); |
3851 | 4071 | $count = 0; |
3852 | 4072 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3861,7 +4081,9 @@ discard block |
||
3861 | 4081 | $ip_parts[0] .= $mode . $min; |
3862 | 4082 | $valid_low = isValidIP($ip_parts[0]); |
3863 | 4083 | $count++; |
3864 | - if ($count > 9) break; |
|
4084 | + if ($count > 9) { |
|
4085 | + break; |
|
4086 | + } |
|
3865 | 4087 | } |
3866 | 4088 | } |
3867 | 4089 | |
@@ -3875,7 +4097,9 @@ discard block |
||
3875 | 4097 | $ip_parts[1] .= $mode . $max; |
3876 | 4098 | $valid_high = isValidIP($ip_parts[1]); |
3877 | 4099 | $count++; |
3878 | - if ($count > 9) break; |
|
4100 | + if ($count > 9) { |
|
4101 | + break; |
|
4102 | + } |
|
3879 | 4103 | } |
3880 | 4104 | } |
3881 | 4105 | |
@@ -3900,46 +4124,54 @@ discard block |
||
3900 | 4124 | { |
3901 | 4125 | global $modSettings; |
3902 | 4126 | |
3903 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
3904 | - return $host; |
|
4127 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
4128 | + return $host; |
|
4129 | + } |
|
3905 | 4130 | $t = microtime(); |
3906 | 4131 | |
3907 | 4132 | // Try the Linux host command, perhaps? |
3908 | 4133 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
3909 | 4134 | { |
3910 | - if (!isset($modSettings['host_to_dis'])) |
|
3911 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
3912 | - else |
|
3913 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4135 | + if (!isset($modSettings['host_to_dis'])) { |
|
4136 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
4137 | + } else { |
|
4138 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4139 | + } |
|
3914 | 4140 | |
3915 | 4141 | // Did host say it didn't find anything? |
3916 | - if (strpos($test, 'not found') !== false) |
|
3917 | - $host = ''; |
|
4142 | + if (strpos($test, 'not found') !== false) { |
|
4143 | + $host = ''; |
|
4144 | + } |
|
3918 | 4145 | // Invalid server option? |
3919 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
3920 | - updateSettings(array('host_to_dis' => 1)); |
|
4146 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
4147 | + updateSettings(array('host_to_dis' => 1)); |
|
4148 | + } |
|
3921 | 4149 | // Maybe it found something, after all? |
3922 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
3923 | - $host = $match[1]; |
|
4150 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
4151 | + $host = $match[1]; |
|
4152 | + } |
|
3924 | 4153 | } |
3925 | 4154 | |
3926 | 4155 | // This is nslookup; usually only Windows, but possibly some Unix? |
3927 | 4156 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
3928 | 4157 | { |
3929 | 4158 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
3930 | - if (strpos($test, 'Non-existent domain') !== false) |
|
3931 | - $host = ''; |
|
3932 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
3933 | - $host = $match[1]; |
|
4159 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
4160 | + $host = ''; |
|
4161 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
4162 | + $host = $match[1]; |
|
4163 | + } |
|
3934 | 4164 | } |
3935 | 4165 | |
3936 | 4166 | // This is the last try :/. |
3937 | - if (!isset($host) || $host === false) |
|
3938 | - $host = @gethostbyaddr($ip); |
|
4167 | + if (!isset($host) || $host === false) { |
|
4168 | + $host = @gethostbyaddr($ip); |
|
4169 | + } |
|
3939 | 4170 | |
3940 | 4171 | // It took a long time, so let's cache it! |
3941 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
3942 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4172 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
4173 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4174 | + } |
|
3943 | 4175 | |
3944 | 4176 | return $host; |
3945 | 4177 | } |
@@ -3975,20 +4207,21 @@ discard block |
||
3975 | 4207 | { |
3976 | 4208 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
3977 | 4209 | $total = 0; |
3978 | - for ($i = 0; $i < $max_chars; $i++) |
|
3979 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4210 | + for ($i = 0; $i < $max_chars; $i++) { |
|
4211 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4212 | + } |
|
3980 | 4213 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
3981 | 4214 | } |
3982 | 4215 | } |
3983 | 4216 | return array_unique($returned_ints); |
3984 | - } |
|
3985 | - else |
|
4217 | + } else |
|
3986 | 4218 | { |
3987 | 4219 | // Trim characters before and after and add slashes for database insertion. |
3988 | 4220 | $returned_words = array(); |
3989 | - foreach ($words as $word) |
|
3990 | - if (($word = trim($word, '-_\'')) !== '') |
|
4221 | + foreach ($words as $word) { |
|
4222 | + if (($word = trim($word, '-_\'')) !== '') |
|
3991 | 4223 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
4224 | + } |
|
3992 | 4225 | |
3993 | 4226 | // Filter out all words that occur more than once. |
3994 | 4227 | return array_unique($returned_words); |
@@ -4010,16 +4243,18 @@ discard block |
||
4010 | 4243 | global $settings, $txt; |
4011 | 4244 | |
4012 | 4245 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
4013 | - if (function_exists('template_create_button') && !$force_use) |
|
4014 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4246 | + if (function_exists('template_create_button') && !$force_use) { |
|
4247 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4248 | + } |
|
4015 | 4249 | |
4016 | - if (!$settings['use_image_buttons']) |
|
4017 | - return $txt[$alt]; |
|
4018 | - elseif (!empty($settings['use_buttons'])) |
|
4019 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4020 | - else |
|
4021 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4022 | -} |
|
4250 | + if (!$settings['use_image_buttons']) { |
|
4251 | + return $txt[$alt]; |
|
4252 | + } elseif (!empty($settings['use_buttons'])) { |
|
4253 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4254 | + } else { |
|
4255 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4256 | + } |
|
4257 | + } |
|
4023 | 4258 | |
4024 | 4259 | /** |
4025 | 4260 | * Sets up all of the top menu buttons |
@@ -4062,9 +4297,10 @@ discard block |
||
4062 | 4297 | var user_menus = new smc_PopupMenu(); |
4063 | 4298 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4064 | 4299 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
4065 | - if ($context['allow_pm']) |
|
4066 | - addInlineJavaScript(' |
|
4300 | + if ($context['allow_pm']) { |
|
4301 | + addInlineJavaScript(' |
|
4067 | 4302 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
4303 | + } |
|
4068 | 4304 | |
4069 | 4305 | if (!empty($modSettings['enable_ajax_alerts'])) |
4070 | 4306 | { |
@@ -4224,88 +4460,96 @@ discard block |
||
4224 | 4460 | |
4225 | 4461 | // Now we put the buttons in the context so the theme can use them. |
4226 | 4462 | $menu_buttons = array(); |
4227 | - foreach ($buttons as $act => $button) |
|
4228 | - if (!empty($button['show'])) |
|
4463 | + foreach ($buttons as $act => $button) { |
|
4464 | + if (!empty($button['show'])) |
|
4229 | 4465 | { |
4230 | 4466 | $button['active_button'] = false; |
4467 | + } |
|
4231 | 4468 | |
4232 | 4469 | // This button needs some action. |
4233 | - if (isset($button['action_hook'])) |
|
4234 | - $needs_action_hook = true; |
|
4470 | + if (isset($button['action_hook'])) { |
|
4471 | + $needs_action_hook = true; |
|
4472 | + } |
|
4235 | 4473 | |
4236 | 4474 | // Make sure the last button truly is the last button. |
4237 | 4475 | if (!empty($button['is_last'])) |
4238 | 4476 | { |
4239 | - if (isset($last_button)) |
|
4240 | - unset($menu_buttons[$last_button]['is_last']); |
|
4477 | + if (isset($last_button)) { |
|
4478 | + unset($menu_buttons[$last_button]['is_last']); |
|
4479 | + } |
|
4241 | 4480 | $last_button = $act; |
4242 | 4481 | } |
4243 | 4482 | |
4244 | 4483 | // Go through the sub buttons if there are any. |
4245 | - if (!empty($button['sub_buttons'])) |
|
4246 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4484 | + if (!empty($button['sub_buttons'])) { |
|
4485 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4247 | 4486 | { |
4248 | 4487 | if (empty($subbutton['show'])) |
4249 | 4488 | unset($button['sub_buttons'][$key]); |
4489 | + } |
|
4250 | 4490 | |
4251 | 4491 | // 2nd level sub buttons next... |
4252 | 4492 | if (!empty($subbutton['sub_buttons'])) |
4253 | 4493 | { |
4254 | 4494 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
4255 | 4495 | { |
4256 | - if (empty($sub_button2['show'])) |
|
4257 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4496 | + if (empty($sub_button2['show'])) { |
|
4497 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4498 | + } |
|
4258 | 4499 | } |
4259 | 4500 | } |
4260 | 4501 | } |
4261 | 4502 | |
4262 | 4503 | // Does this button have its own icon? |
4263 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
4264 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4265 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
4266 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4267 | - elseif (isset($button['icon'])) |
|
4268 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4269 | - else |
|
4270 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4504 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
4505 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4506 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
4507 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4508 | + } elseif (isset($button['icon'])) { |
|
4509 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4510 | + } else { |
|
4511 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4512 | + } |
|
4271 | 4513 | |
4272 | 4514 | $menu_buttons[$act] = $button; |
4273 | 4515 | } |
4274 | 4516 | |
4275 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
4276 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4517 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
4518 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4519 | + } |
|
4277 | 4520 | } |
4278 | 4521 | |
4279 | 4522 | $context['menu_buttons'] = $menu_buttons; |
4280 | 4523 | |
4281 | 4524 | // Logging out requires the session id in the url. |
4282 | - if (isset($context['menu_buttons']['logout'])) |
|
4283 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4525 | + if (isset($context['menu_buttons']['logout'])) { |
|
4526 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4527 | + } |
|
4284 | 4528 | |
4285 | 4529 | // Figure out which action we are doing so we can set the active tab. |
4286 | 4530 | // Default to home. |
4287 | 4531 | $current_action = 'home'; |
4288 | 4532 | |
4289 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
4290 | - $current_action = $context['current_action']; |
|
4291 | - elseif ($context['current_action'] == 'search2') |
|
4292 | - $current_action = 'search'; |
|
4293 | - elseif ($context['current_action'] == 'theme') |
|
4294 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4295 | - elseif ($context['current_action'] == 'register2') |
|
4296 | - $current_action = 'register'; |
|
4297 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
4298 | - $current_action = 'login'; |
|
4299 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
4300 | - $current_action = 'moderate'; |
|
4533 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
4534 | + $current_action = $context['current_action']; |
|
4535 | + } elseif ($context['current_action'] == 'search2') { |
|
4536 | + $current_action = 'search'; |
|
4537 | + } elseif ($context['current_action'] == 'theme') { |
|
4538 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4539 | + } elseif ($context['current_action'] == 'register2') { |
|
4540 | + $current_action = 'register'; |
|
4541 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
4542 | + $current_action = 'login'; |
|
4543 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
4544 | + $current_action = 'moderate'; |
|
4545 | + } |
|
4301 | 4546 | |
4302 | 4547 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
4303 | 4548 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
4304 | 4549 | { |
4305 | 4550 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
4306 | 4551 | $context[$current_action] = true; |
4307 | - } |
|
4308 | - elseif ($context['current_action'] == 'pm') |
|
4552 | + } elseif ($context['current_action'] == 'pm') |
|
4309 | 4553 | { |
4310 | 4554 | $current_action = 'self_pm'; |
4311 | 4555 | $context['self_pm'] = true; |
@@ -4346,12 +4590,14 @@ discard block |
||
4346 | 4590 | } |
4347 | 4591 | |
4348 | 4592 | // Not all actions are simple. |
4349 | - if (!empty($needs_action_hook)) |
|
4350 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4593 | + if (!empty($needs_action_hook)) { |
|
4594 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4595 | + } |
|
4351 | 4596 | |
4352 | - if (isset($context['menu_buttons'][$current_action])) |
|
4353 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4354 | -} |
|
4597 | + if (isset($context['menu_buttons'][$current_action])) { |
|
4598 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4599 | + } |
|
4600 | + } |
|
4355 | 4601 | |
4356 | 4602 | /** |
4357 | 4603 | * Generate a random seed and ensure it's stored in settings. |
@@ -4375,30 +4621,35 @@ discard block |
||
4375 | 4621 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
4376 | 4622 | global $context, $txt; |
4377 | 4623 | |
4378 | - if ($db_show_debug === true) |
|
4379 | - $context['debug']['hooks'][] = $hook; |
|
4624 | + if ($db_show_debug === true) { |
|
4625 | + $context['debug']['hooks'][] = $hook; |
|
4626 | + } |
|
4380 | 4627 | |
4381 | 4628 | // Need to have some control. |
4382 | - if (!isset($context['instances'])) |
|
4383 | - $context['instances'] = array(); |
|
4629 | + if (!isset($context['instances'])) { |
|
4630 | + $context['instances'] = array(); |
|
4631 | + } |
|
4384 | 4632 | |
4385 | 4633 | $results = array(); |
4386 | - if (empty($modSettings[$hook])) |
|
4387 | - return $results; |
|
4634 | + if (empty($modSettings[$hook])) { |
|
4635 | + return $results; |
|
4636 | + } |
|
4388 | 4637 | |
4389 | 4638 | $functions = explode(',', $modSettings[$hook]); |
4390 | 4639 | // Loop through each function. |
4391 | 4640 | foreach ($functions as $function) |
4392 | 4641 | { |
4393 | 4642 | // Hook has been marked as "disabled". Skip it! |
4394 | - if (strpos($function, '!') !== false) |
|
4395 | - continue; |
|
4643 | + if (strpos($function, '!') !== false) { |
|
4644 | + continue; |
|
4645 | + } |
|
4396 | 4646 | |
4397 | 4647 | $call = call_helper($function, true); |
4398 | 4648 | |
4399 | 4649 | // Is it valid? |
4400 | - if (!empty($call)) |
|
4401 | - $results[$function] = call_user_func_array($call, $parameters); |
|
4650 | + if (!empty($call)) { |
|
4651 | + $results[$function] = call_user_func_array($call, $parameters); |
|
4652 | + } |
|
4402 | 4653 | |
4403 | 4654 | // Whatever it was suppose to call, it failed :( |
4404 | 4655 | elseif (!empty($function)) |
@@ -4414,8 +4665,9 @@ discard block |
||
4414 | 4665 | } |
4415 | 4666 | |
4416 | 4667 | // "Assume" the file resides on $boarddir somewhere... |
4417 | - else |
|
4418 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4668 | + else { |
|
4669 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4670 | + } |
|
4419 | 4671 | } |
4420 | 4672 | } |
4421 | 4673 | |
@@ -4437,12 +4689,14 @@ discard block |
||
4437 | 4689 | global $smcFunc, $modSettings; |
4438 | 4690 | |
4439 | 4691 | // Any objects? |
4440 | - if ($object) |
|
4441 | - $function = $function . '#'; |
|
4692 | + if ($object) { |
|
4693 | + $function = $function . '#'; |
|
4694 | + } |
|
4442 | 4695 | |
4443 | 4696 | // Any files to load? |
4444 | - if (!empty($file) && is_string($file)) |
|
4445 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4697 | + if (!empty($file) && is_string($file)) { |
|
4698 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4699 | + } |
|
4446 | 4700 | |
4447 | 4701 | // Get the correct string. |
4448 | 4702 | $integration_call = $function; |
@@ -4464,13 +4718,14 @@ discard block |
||
4464 | 4718 | if (!empty($current_functions)) |
4465 | 4719 | { |
4466 | 4720 | $current_functions = explode(',', $current_functions); |
4467 | - if (in_array($integration_call, $current_functions)) |
|
4468 | - return; |
|
4721 | + if (in_array($integration_call, $current_functions)) { |
|
4722 | + return; |
|
4723 | + } |
|
4469 | 4724 | |
4470 | 4725 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
4726 | + } else { |
|
4727 | + $permanent_functions = array($integration_call); |
|
4471 | 4728 | } |
4472 | - else |
|
4473 | - $permanent_functions = array($integration_call); |
|
4474 | 4729 | |
4475 | 4730 | updateSettings(array($hook => implode(',', $permanent_functions))); |
4476 | 4731 | } |
@@ -4479,8 +4734,9 @@ discard block |
||
4479 | 4734 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4480 | 4735 | |
4481 | 4736 | // Do nothing, if it's already there. |
4482 | - if (in_array($integration_call, $functions)) |
|
4483 | - return; |
|
4737 | + if (in_array($integration_call, $functions)) { |
|
4738 | + return; |
|
4739 | + } |
|
4484 | 4740 | |
4485 | 4741 | $functions[] = $integration_call; |
4486 | 4742 | $modSettings[$hook] = implode(',', $functions); |
@@ -4503,12 +4759,14 @@ discard block |
||
4503 | 4759 | global $smcFunc, $modSettings; |
4504 | 4760 | |
4505 | 4761 | // Any objects? |
4506 | - if ($object) |
|
4507 | - $function = $function . '#'; |
|
4762 | + if ($object) { |
|
4763 | + $function = $function . '#'; |
|
4764 | + } |
|
4508 | 4765 | |
4509 | 4766 | // Any files to load? |
4510 | - if (!empty($file) && is_string($file)) |
|
4511 | - $function = $file . '|' . $function; |
|
4767 | + if (!empty($file) && is_string($file)) { |
|
4768 | + $function = $file . '|' . $function; |
|
4769 | + } |
|
4512 | 4770 | |
4513 | 4771 | // Get the correct string. |
4514 | 4772 | $integration_call = $function; |
@@ -4529,16 +4787,18 @@ discard block |
||
4529 | 4787 | { |
4530 | 4788 | $current_functions = explode(',', $current_functions); |
4531 | 4789 | |
4532 | - if (in_array($integration_call, $current_functions)) |
|
4533 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4790 | + if (in_array($integration_call, $current_functions)) { |
|
4791 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4792 | + } |
|
4534 | 4793 | } |
4535 | 4794 | |
4536 | 4795 | // Turn the function list into something usable. |
4537 | 4796 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4538 | 4797 | |
4539 | 4798 | // You can only remove it if it's available. |
4540 | - if (!in_array($integration_call, $functions)) |
|
4541 | - return; |
|
4799 | + if (!in_array($integration_call, $functions)) { |
|
4800 | + return; |
|
4801 | + } |
|
4542 | 4802 | |
4543 | 4803 | $functions = array_diff($functions, array($integration_call)); |
4544 | 4804 | $modSettings[$hook] = implode(',', $functions); |
@@ -4559,17 +4819,20 @@ discard block |
||
4559 | 4819 | global $context, $smcFunc, $txt, $db_show_debug; |
4560 | 4820 | |
4561 | 4821 | // Really? |
4562 | - if (empty($string)) |
|
4563 | - return false; |
|
4822 | + if (empty($string)) { |
|
4823 | + return false; |
|
4824 | + } |
|
4564 | 4825 | |
4565 | 4826 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
4566 | 4827 | // A closure? should be a callable one. |
4567 | - if (is_array($string) || $string instanceof Closure) |
|
4568 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4828 | + if (is_array($string) || $string instanceof Closure) { |
|
4829 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4830 | + } |
|
4569 | 4831 | |
4570 | 4832 | // No full objects, sorry! pass a method or a property instead! |
4571 | - if (is_object($string)) |
|
4572 | - return false; |
|
4833 | + if (is_object($string)) { |
|
4834 | + return false; |
|
4835 | + } |
|
4573 | 4836 | |
4574 | 4837 | // Stay vitaminized my friends... |
4575 | 4838 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4578,8 +4841,9 @@ discard block |
||
4578 | 4841 | $string = load_file($string); |
4579 | 4842 | |
4580 | 4843 | // Loaded file failed |
4581 | - if (empty($string)) |
|
4582 | - return false; |
|
4844 | + if (empty($string)) { |
|
4845 | + return false; |
|
4846 | + } |
|
4583 | 4847 | |
4584 | 4848 | // Found a method. |
4585 | 4849 | if (strpos($string, '::') !== false) |
@@ -4600,8 +4864,9 @@ discard block |
||
4600 | 4864 | // Add another one to the list. |
4601 | 4865 | if ($db_show_debug === true) |
4602 | 4866 | { |
4603 | - if (!isset($context['debug']['instances'])) |
|
4604 | - $context['debug']['instances'] = array(); |
|
4867 | + if (!isset($context['debug']['instances'])) { |
|
4868 | + $context['debug']['instances'] = array(); |
|
4869 | + } |
|
4605 | 4870 | |
4606 | 4871 | $context['debug']['instances'][$class] = $class; |
4607 | 4872 | } |
@@ -4611,13 +4876,15 @@ discard block |
||
4611 | 4876 | } |
4612 | 4877 | |
4613 | 4878 | // Right then. This is a call to a static method. |
4614 | - else |
|
4615 | - $func = array($class, $method); |
|
4879 | + else { |
|
4880 | + $func = array($class, $method); |
|
4881 | + } |
|
4616 | 4882 | } |
4617 | 4883 | |
4618 | 4884 | // Nope! just a plain regular function. |
4619 | - else |
|
4620 | - $func = $string; |
|
4885 | + else { |
|
4886 | + $func = $string; |
|
4887 | + } |
|
4621 | 4888 | |
4622 | 4889 | // Right, we got what we need, time to do some checks. |
4623 | 4890 | if (!is_callable($func, false, $callable_name)) |
@@ -4633,17 +4900,18 @@ discard block |
||
4633 | 4900 | else |
4634 | 4901 | { |
4635 | 4902 | // What are we gonna do about it? |
4636 | - if ($return) |
|
4637 | - return $func; |
|
4903 | + if ($return) { |
|
4904 | + return $func; |
|
4905 | + } |
|
4638 | 4906 | |
4639 | 4907 | // If this is a plain function, avoid the heat of calling call_user_func(). |
4640 | 4908 | else |
4641 | 4909 | { |
4642 | - if (is_array($func)) |
|
4643 | - call_user_func($func); |
|
4644 | - |
|
4645 | - else |
|
4646 | - $func(); |
|
4910 | + if (is_array($func)) { |
|
4911 | + call_user_func($func); |
|
4912 | + } else { |
|
4913 | + $func(); |
|
4914 | + } |
|
4647 | 4915 | } |
4648 | 4916 | } |
4649 | 4917 | } |
@@ -4660,31 +4928,34 @@ discard block |
||
4660 | 4928 | { |
4661 | 4929 | global $sourcedir, $txt, $boarddir, $settings; |
4662 | 4930 | |
4663 | - if (empty($string)) |
|
4664 | - return false; |
|
4931 | + if (empty($string)) { |
|
4932 | + return false; |
|
4933 | + } |
|
4665 | 4934 | |
4666 | 4935 | if (strpos($string, '|') !== false) |
4667 | 4936 | { |
4668 | 4937 | list ($file, $string) = explode('|', $string); |
4669 | 4938 | |
4670 | 4939 | // Match the wildcards to their regular vars. |
4671 | - if (empty($settings['theme_dir'])) |
|
4672 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4673 | - |
|
4674 | - else |
|
4675 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4940 | + if (empty($settings['theme_dir'])) { |
|
4941 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4942 | + } else { |
|
4943 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4944 | + } |
|
4676 | 4945 | |
4677 | 4946 | // Load the file if it can be loaded. |
4678 | - if (file_exists($absPath)) |
|
4679 | - require_once($absPath); |
|
4947 | + if (file_exists($absPath)) { |
|
4948 | + require_once($absPath); |
|
4949 | + } |
|
4680 | 4950 | |
4681 | 4951 | // No? try a fallback to $sourcedir |
4682 | 4952 | else |
4683 | 4953 | { |
4684 | 4954 | $absPath = $sourcedir .'/'. $file; |
4685 | 4955 | |
4686 | - if (file_exists($absPath)) |
|
4687 | - require_once($absPath); |
|
4956 | + if (file_exists($absPath)) { |
|
4957 | + require_once($absPath); |
|
4958 | + } |
|
4688 | 4959 | |
4689 | 4960 | // Sorry, can't do much for you at this point. |
4690 | 4961 | else |
@@ -4711,8 +4982,9 @@ discard block |
||
4711 | 4982 | global $user_info, $smcFunc; |
4712 | 4983 | |
4713 | 4984 | // Make sure we have something to work with. |
4714 | - if (empty($topic)) |
|
4715 | - return array(); |
|
4985 | + if (empty($topic)) { |
|
4986 | + return array(); |
|
4987 | + } |
|
4716 | 4988 | |
4717 | 4989 | |
4718 | 4990 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4735,8 +5007,9 @@ discard block |
||
4735 | 5007 | 'topic' => $topic, |
4736 | 5008 | ) |
4737 | 5009 | ); |
4738 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
4739 | - $temp[] = (int) $row['content_id']; |
|
5010 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
5011 | + $temp[] = (int) $row['content_id']; |
|
5012 | + } |
|
4740 | 5013 | |
4741 | 5014 | cache_put_data($cache_key, $temp, $ttl); |
4742 | 5015 | } |
@@ -4757,8 +5030,9 @@ discard block |
||
4757 | 5030 | { |
4758 | 5031 | global $context; |
4759 | 5032 | |
4760 | - if (empty($string)) |
|
4761 | - return $string; |
|
5033 | + if (empty($string)) { |
|
5034 | + return $string; |
|
5035 | + } |
|
4762 | 5036 | |
4763 | 5037 | // UTF-8 occurences of MS special characters |
4764 | 5038 | $findchars_utf8 = array( |
@@ -4799,10 +5073,11 @@ discard block |
||
4799 | 5073 | '--', // — |
4800 | 5074 | ); |
4801 | 5075 | |
4802 | - if ($context['utf8']) |
|
4803 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
4804 | - else |
|
4805 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
5076 | + if ($context['utf8']) { |
|
5077 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
5078 | + } else { |
|
5079 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
5080 | + } |
|
4806 | 5081 | |
4807 | 5082 | return $string; |
4808 | 5083 | } |
@@ -4821,49 +5096,59 @@ discard block |
||
4821 | 5096 | { |
4822 | 5097 | global $context; |
4823 | 5098 | |
4824 | - if (!isset($matches[2])) |
|
4825 | - return ''; |
|
5099 | + if (!isset($matches[2])) { |
|
5100 | + return ''; |
|
5101 | + } |
|
4826 | 5102 | |
4827 | 5103 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4828 | 5104 | |
4829 | 5105 | // remove left to right / right to left overrides |
4830 | - if ($num === 0x202D || $num === 0x202E) |
|
4831 | - return ''; |
|
5106 | + if ($num === 0x202D || $num === 0x202E) { |
|
5107 | + return ''; |
|
5108 | + } |
|
4832 | 5109 | |
4833 | 5110 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
4834 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
4835 | - return '&#' . $num . ';'; |
|
5111 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
5112 | + return '&#' . $num . ';'; |
|
5113 | + } |
|
4836 | 5114 | |
4837 | 5115 | if (empty($context['utf8'])) |
4838 | 5116 | { |
4839 | 5117 | // no control characters |
4840 | - if ($num < 0x20) |
|
4841 | - return ''; |
|
5118 | + if ($num < 0x20) { |
|
5119 | + return ''; |
|
5120 | + } |
|
4842 | 5121 | // text is text |
4843 | - elseif ($num < 0x80) |
|
4844 | - return chr($num); |
|
5122 | + elseif ($num < 0x80) { |
|
5123 | + return chr($num); |
|
5124 | + } |
|
4845 | 5125 | // all others get html-ised |
4846 | - else |
|
4847 | - return '&#' . $matches[2] . ';'; |
|
4848 | - } |
|
4849 | - else |
|
5126 | + else { |
|
5127 | + return '&#' . $matches[2] . ';'; |
|
5128 | + } |
|
5129 | + } else |
|
4850 | 5130 | { |
4851 | 5131 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
4852 | 5132 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
4853 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
4854 | - return ''; |
|
5133 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
5134 | + return ''; |
|
5135 | + } |
|
4855 | 5136 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4856 | - elseif ($num < 0x80) |
|
4857 | - return chr($num); |
|
5137 | + elseif ($num < 0x80) { |
|
5138 | + return chr($num); |
|
5139 | + } |
|
4858 | 5140 | // <0x800 (2048) |
4859 | - elseif ($num < 0x800) |
|
4860 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5141 | + elseif ($num < 0x800) { |
|
5142 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5143 | + } |
|
4861 | 5144 | // < 0x10000 (65536) |
4862 | - elseif ($num < 0x10000) |
|
4863 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5145 | + elseif ($num < 0x10000) { |
|
5146 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5147 | + } |
|
4864 | 5148 | // <= 0x10FFFF (1114111) |
4865 | - else |
|
4866 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5149 | + else { |
|
5150 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5151 | + } |
|
4867 | 5152 | } |
4868 | 5153 | } |
4869 | 5154 | |
@@ -4879,28 +5164,34 @@ discard block |
||
4879 | 5164 | */ |
4880 | 5165 | function fixchar__callback($matches) |
4881 | 5166 | { |
4882 | - if (!isset($matches[1])) |
|
4883 | - return ''; |
|
5167 | + if (!isset($matches[1])) { |
|
5168 | + return ''; |
|
5169 | + } |
|
4884 | 5170 | |
4885 | 5171 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
4886 | 5172 | |
4887 | 5173 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
4888 | 5174 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
4889 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
4890 | - return ''; |
|
5175 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
5176 | + return ''; |
|
5177 | + } |
|
4891 | 5178 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4892 | - elseif ($num < 0x80) |
|
4893 | - return chr($num); |
|
5179 | + elseif ($num < 0x80) { |
|
5180 | + return chr($num); |
|
5181 | + } |
|
4894 | 5182 | // <0x800 (2048) |
4895 | - elseif ($num < 0x800) |
|
4896 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5183 | + elseif ($num < 0x800) { |
|
5184 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5185 | + } |
|
4897 | 5186 | // < 0x10000 (65536) |
4898 | - elseif ($num < 0x10000) |
|
4899 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5187 | + elseif ($num < 0x10000) { |
|
5188 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5189 | + } |
|
4900 | 5190 | // <= 0x10FFFF (1114111) |
4901 | - else |
|
4902 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
4903 | -} |
|
5191 | + else { |
|
5192 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5193 | + } |
|
5194 | + } |
|
4904 | 5195 | |
4905 | 5196 | /** |
4906 | 5197 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4913,17 +5204,19 @@ discard block |
||
4913 | 5204 | */ |
4914 | 5205 | function entity_fix__callback($matches) |
4915 | 5206 | { |
4916 | - if (!isset($matches[2])) |
|
4917 | - return ''; |
|
5207 | + if (!isset($matches[2])) { |
|
5208 | + return ''; |
|
5209 | + } |
|
4918 | 5210 | |
4919 | 5211 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4920 | 5212 | |
4921 | 5213 | // we don't allow control characters, characters out of range, byte markers, etc |
4922 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
4923 | - return ''; |
|
4924 | - else |
|
4925 | - return '&#' . $num . ';'; |
|
4926 | -} |
|
5214 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
5215 | + return ''; |
|
5216 | + } else { |
|
5217 | + return '&#' . $num . ';'; |
|
5218 | + } |
|
5219 | + } |
|
4927 | 5220 | |
4928 | 5221 | /** |
4929 | 5222 | * Return a Gravatar URL based on |
@@ -4947,18 +5240,23 @@ discard block |
||
4947 | 5240 | $ratings = array('G', 'PG', 'R', 'X'); |
4948 | 5241 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
4949 | 5242 | $url_params = array(); |
4950 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
4951 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
4952 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
4953 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
4954 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
4955 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
4956 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
4957 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
5243 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
5244 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
5245 | + } |
|
5246 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
5247 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
5248 | + } |
|
5249 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
5250 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
5251 | + } |
|
5252 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
5253 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
4958 | 5254 | $size_string = $modSettings['avatar_max_height_external']; |
5255 | + } |
|
4959 | 5256 | |
4960 | - if (!empty($size_string)) |
|
4961 | - $url_params[] = 's=' . $size_string; |
|
5257 | + if (!empty($size_string)) { |
|
5258 | + $url_params[] = 's=' . $size_string; |
|
5259 | + } |
|
4962 | 5260 | } |
4963 | 5261 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
4964 | 5262 | |
@@ -4977,22 +5275,26 @@ discard block |
||
4977 | 5275 | static $timezones = null, $lastwhen = null; |
4978 | 5276 | |
4979 | 5277 | // No point doing this over if we already did it once |
4980 | - if (!empty($timezones) && $when == $lastwhen) |
|
4981 | - return $timezones; |
|
4982 | - else |
|
4983 | - $lastwhen = $when; |
|
5278 | + if (!empty($timezones) && $when == $lastwhen) { |
|
5279 | + return $timezones; |
|
5280 | + } else { |
|
5281 | + $lastwhen = $when; |
|
5282 | + } |
|
4984 | 5283 | |
4985 | 5284 | // Parseable datetime string? |
4986 | - if (is_int($timestamp = strtotime($when))) |
|
4987 | - $when = $timestamp; |
|
5285 | + if (is_int($timestamp = strtotime($when))) { |
|
5286 | + $when = $timestamp; |
|
5287 | + } |
|
4988 | 5288 | |
4989 | 5289 | // A Unix timestamp? |
4990 | - elseif (is_numeric($when)) |
|
4991 | - $when = intval($when); |
|
5290 | + elseif (is_numeric($when)) { |
|
5291 | + $when = intval($when); |
|
5292 | + } |
|
4992 | 5293 | |
4993 | 5294 | // Invalid value? Just get current Unix timestamp. |
4994 | - else |
|
4995 | - $when = time(); |
|
5295 | + else { |
|
5296 | + $when = time(); |
|
5297 | + } |
|
4996 | 5298 | |
4997 | 5299 | // We'll need these too |
4998 | 5300 | $date_when = date_create('@' . $when); |
@@ -5056,8 +5358,9 @@ discard block |
||
5056 | 5358 | foreach ($priority_countries as $country) |
5057 | 5359 | { |
5058 | 5360 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
5059 | - if (!empty($country_tzids)) |
|
5060 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5361 | + if (!empty($country_tzids)) { |
|
5362 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5363 | + } |
|
5061 | 5364 | } |
5062 | 5365 | |
5063 | 5366 | // Process the preferred timezones first, then the rest. |
@@ -5067,8 +5370,9 @@ discard block |
||
5067 | 5370 | foreach ($tzids as $tzid) |
5068 | 5371 | { |
5069 | 5372 | // We don't want UTC right now |
5070 | - if ($tzid == 'UTC') |
|
5071 | - continue; |
|
5373 | + if ($tzid == 'UTC') { |
|
5374 | + continue; |
|
5375 | + } |
|
5072 | 5376 | |
5073 | 5377 | $tz = timezone_open($tzid); |
5074 | 5378 | |
@@ -5089,8 +5393,9 @@ discard block |
||
5089 | 5393 | } |
5090 | 5394 | |
5091 | 5395 | // A time zone from a prioritized country? |
5092 | - if (in_array($tzid, $priority_tzids)) |
|
5093 | - $priority_zones[$tzkey] = true; |
|
5396 | + if (in_array($tzid, $priority_tzids)) { |
|
5397 | + $priority_zones[$tzkey] = true; |
|
5398 | + } |
|
5094 | 5399 | |
5095 | 5400 | // Keep track of the location and offset for this tzid |
5096 | 5401 | $tzid_parts = explode('/', $tzid); |
@@ -5109,15 +5414,17 @@ discard block |
||
5109 | 5414 | { |
5110 | 5415 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
5111 | 5416 | |
5112 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
5113 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5114 | - else |
|
5115 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5417 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
5418 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5419 | + } else { |
|
5420 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5421 | + } |
|
5116 | 5422 | |
5117 | - if (isset($priority_zones[$tzkey])) |
|
5118 | - $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5119 | - else |
|
5120 | - $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5423 | + if (isset($priority_zones[$tzkey])) { |
|
5424 | + $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5425 | + } else { |
|
5426 | + $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5427 | + } |
|
5121 | 5428 | } |
5122 | 5429 | |
5123 | 5430 | $timezones = array_merge( |
@@ -5171,9 +5478,9 @@ discard block |
||
5171 | 5478 | 'Indian/Kerguelen' => 'TFT', |
5172 | 5479 | ); |
5173 | 5480 | |
5174 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
5175 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5176 | - else |
|
5481 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
5482 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5483 | + } else |
|
5177 | 5484 | { |
5178 | 5485 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
5179 | 5486 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5201,8 +5508,9 @@ discard block |
||
5201 | 5508 | */ |
5202 | 5509 | function inet_ptod($ip_address) |
5203 | 5510 | { |
5204 | - if (!isValidIP($ip_address)) |
|
5205 | - return $ip_address; |
|
5511 | + if (!isValidIP($ip_address)) { |
|
5512 | + return $ip_address; |
|
5513 | + } |
|
5206 | 5514 | |
5207 | 5515 | $bin = inet_pton($ip_address); |
5208 | 5516 | return $bin; |
@@ -5214,13 +5522,15 @@ discard block |
||
5214 | 5522 | */ |
5215 | 5523 | function inet_dtop($bin) |
5216 | 5524 | { |
5217 | - if(empty($bin)) |
|
5218 | - return ''; |
|
5525 | + if(empty($bin)) { |
|
5526 | + return ''; |
|
5527 | + } |
|
5219 | 5528 | |
5220 | 5529 | global $db_type; |
5221 | 5530 | |
5222 | - if ($db_type == 'postgresql') |
|
5223 | - return $bin; |
|
5531 | + if ($db_type == 'postgresql') { |
|
5532 | + return $bin; |
|
5533 | + } |
|
5224 | 5534 | |
5225 | 5535 | $ip_address = inet_ntop($bin); |
5226 | 5536 | |
@@ -5245,26 +5555,32 @@ discard block |
||
5245 | 5555 | */ |
5246 | 5556 | function _safe_serialize($value) |
5247 | 5557 | { |
5248 | - if(is_null($value)) |
|
5249 | - return 'N;'; |
|
5558 | + if(is_null($value)) { |
|
5559 | + return 'N;'; |
|
5560 | + } |
|
5250 | 5561 | |
5251 | - if(is_bool($value)) |
|
5252 | - return 'b:'. (int) $value .';'; |
|
5562 | + if(is_bool($value)) { |
|
5563 | + return 'b:'. (int) $value .';'; |
|
5564 | + } |
|
5253 | 5565 | |
5254 | - if(is_int($value)) |
|
5255 | - return 'i:'. $value .';'; |
|
5566 | + if(is_int($value)) { |
|
5567 | + return 'i:'. $value .';'; |
|
5568 | + } |
|
5256 | 5569 | |
5257 | - if(is_float($value)) |
|
5258 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5570 | + if(is_float($value)) { |
|
5571 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
5572 | + } |
|
5259 | 5573 | |
5260 | - if(is_string($value)) |
|
5261 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5574 | + if(is_string($value)) { |
|
5575 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
5576 | + } |
|
5262 | 5577 | |
5263 | 5578 | if(is_array($value)) |
5264 | 5579 | { |
5265 | 5580 | $out = ''; |
5266 | - foreach($value as $k => $v) |
|
5267 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5581 | + foreach($value as $k => $v) { |
|
5582 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5583 | + } |
|
5268 | 5584 | |
5269 | 5585 | return 'a:'. count($value) .':{'. $out .'}'; |
5270 | 5586 | } |
@@ -5290,8 +5606,9 @@ discard block |
||
5290 | 5606 | |
5291 | 5607 | $out = _safe_serialize($value); |
5292 | 5608 | |
5293 | - if (isset($mbIntEnc)) |
|
5294 | - mb_internal_encoding($mbIntEnc); |
|
5609 | + if (isset($mbIntEnc)) { |
|
5610 | + mb_internal_encoding($mbIntEnc); |
|
5611 | + } |
|
5295 | 5612 | |
5296 | 5613 | return $out; |
5297 | 5614 | } |
@@ -5308,8 +5625,9 @@ discard block |
||
5308 | 5625 | function _safe_unserialize($str) |
5309 | 5626 | { |
5310 | 5627 | // Input is not a string. |
5311 | - if(empty($str) || !is_string($str)) |
|
5312 | - return false; |
|
5628 | + if(empty($str) || !is_string($str)) { |
|
5629 | + return false; |
|
5630 | + } |
|
5313 | 5631 | |
5314 | 5632 | $stack = array(); |
5315 | 5633 | $expected = array(); |
@@ -5325,43 +5643,38 @@ discard block |
||
5325 | 5643 | while($state != 1) |
5326 | 5644 | { |
5327 | 5645 | $type = isset($str[0]) ? $str[0] : ''; |
5328 | - if($type == '}') |
|
5329 | - $str = substr($str, 1); |
|
5330 | - |
|
5331 | - else if($type == 'N' && $str[1] == ';') |
|
5646 | + if($type == '}') { |
|
5647 | + $str = substr($str, 1); |
|
5648 | + } else if($type == 'N' && $str[1] == ';') |
|
5332 | 5649 | { |
5333 | 5650 | $value = null; |
5334 | 5651 | $str = substr($str, 2); |
5335 | - } |
|
5336 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5652 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5337 | 5653 | { |
5338 | 5654 | $value = $matches[1] == '1' ? true : false; |
5339 | 5655 | $str = substr($str, 4); |
5340 | - } |
|
5341 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5656 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5342 | 5657 | { |
5343 | 5658 | $value = (int)$matches[1]; |
5344 | 5659 | $str = $matches[2]; |
5345 | - } |
|
5346 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5660 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5347 | 5661 | { |
5348 | 5662 | $value = (float)$matches[1]; |
5349 | 5663 | $str = $matches[3]; |
5350 | - } |
|
5351 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5664 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5352 | 5665 | { |
5353 | 5666 | $value = substr($matches[2], 0, (int)$matches[1]); |
5354 | 5667 | $str = substr($matches[2], (int)$matches[1] + 2); |
5355 | - } |
|
5356 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5668 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5357 | 5669 | { |
5358 | 5670 | $expectedLength = (int)$matches[1]; |
5359 | 5671 | $str = $matches[2]; |
5360 | 5672 | } |
5361 | 5673 | |
5362 | 5674 | // Object or unknown/malformed type. |
5363 | - else |
|
5364 | - return false; |
|
5675 | + else { |
|
5676 | + return false; |
|
5677 | + } |
|
5365 | 5678 | |
5366 | 5679 | switch($state) |
5367 | 5680 | { |
@@ -5389,8 +5702,9 @@ discard block |
||
5389 | 5702 | if($type == '}') |
5390 | 5703 | { |
5391 | 5704 | // Array size is less than expected. |
5392 | - if(count($list) < end($expected)) |
|
5393 | - return false; |
|
5705 | + if(count($list) < end($expected)) { |
|
5706 | + return false; |
|
5707 | + } |
|
5394 | 5708 | |
5395 | 5709 | unset($list); |
5396 | 5710 | $list = &$stack[count($stack)-1]; |
@@ -5399,8 +5713,9 @@ discard block |
||
5399 | 5713 | // Go to terminal state if we're at the end of the root array. |
5400 | 5714 | array_pop($expected); |
5401 | 5715 | |
5402 | - if(count($expected) == 0) |
|
5403 | - $state = 1; |
|
5716 | + if(count($expected) == 0) { |
|
5717 | + $state = 1; |
|
5718 | + } |
|
5404 | 5719 | |
5405 | 5720 | break; |
5406 | 5721 | } |
@@ -5408,8 +5723,9 @@ discard block |
||
5408 | 5723 | if($type == 'i' || $type == 's') |
5409 | 5724 | { |
5410 | 5725 | // Array size exceeds expected length. |
5411 | - if(count($list) >= end($expected)) |
|
5412 | - return false; |
|
5726 | + if(count($list) >= end($expected)) { |
|
5727 | + return false; |
|
5728 | + } |
|
5413 | 5729 | |
5414 | 5730 | $key = $value; |
5415 | 5731 | $state = 3; |
@@ -5443,8 +5759,9 @@ discard block |
||
5443 | 5759 | } |
5444 | 5760 | |
5445 | 5761 | // Trailing data in input. |
5446 | - if(!empty($str)) |
|
5447 | - return false; |
|
5762 | + if(!empty($str)) { |
|
5763 | + return false; |
|
5764 | + } |
|
5448 | 5765 | |
5449 | 5766 | return $data; |
5450 | 5767 | } |
@@ -5467,8 +5784,9 @@ discard block |
||
5467 | 5784 | |
5468 | 5785 | $out = _safe_unserialize($str); |
5469 | 5786 | |
5470 | - if (isset($mbIntEnc)) |
|
5471 | - mb_internal_encoding($mbIntEnc); |
|
5787 | + if (isset($mbIntEnc)) { |
|
5788 | + mb_internal_encoding($mbIntEnc); |
|
5789 | + } |
|
5472 | 5790 | |
5473 | 5791 | return $out; |
5474 | 5792 | } |
@@ -5483,12 +5801,14 @@ discard block |
||
5483 | 5801 | function smf_chmod($file, $value = 0) |
5484 | 5802 | { |
5485 | 5803 | // No file? no checks! |
5486 | - if (empty($file)) |
|
5487 | - return false; |
|
5804 | + if (empty($file)) { |
|
5805 | + return false; |
|
5806 | + } |
|
5488 | 5807 | |
5489 | 5808 | // Already writable? |
5490 | - if (is_writable($file)) |
|
5491 | - return true; |
|
5809 | + if (is_writable($file)) { |
|
5810 | + return true; |
|
5811 | + } |
|
5492 | 5812 | |
5493 | 5813 | // Do we have a file or a dir? |
5494 | 5814 | $isDir = is_dir($file); |
@@ -5504,10 +5824,9 @@ discard block |
||
5504 | 5824 | { |
5505 | 5825 | $isWritable = true; |
5506 | 5826 | break; |
5827 | + } else { |
|
5828 | + @chmod($file, $val); |
|
5507 | 5829 | } |
5508 | - |
|
5509 | - else |
|
5510 | - @chmod($file, $val); |
|
5511 | 5830 | } |
5512 | 5831 | |
5513 | 5832 | return $isWritable; |
@@ -5526,8 +5845,9 @@ discard block |
||
5526 | 5845 | global $txt; |
5527 | 5846 | |
5528 | 5847 | // Come on... |
5529 | - if (empty($json) || !is_string($json)) |
|
5530 | - return array(); |
|
5848 | + if (empty($json) || !is_string($json)) { |
|
5849 | + return array(); |
|
5850 | + } |
|
5531 | 5851 | |
5532 | 5852 | $returnArray = @json_decode($json, $returnAsArray); |
5533 | 5853 | |
@@ -5565,11 +5885,11 @@ discard block |
||
5565 | 5885 | $jsonDebug = $jsonDebug[0]; |
5566 | 5886 | loadLanguage('Errors'); |
5567 | 5887 | |
5568 | - if (!empty($jsonDebug)) |
|
5569 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5570 | - |
|
5571 | - else |
|
5572 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5888 | + if (!empty($jsonDebug)) { |
|
5889 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5890 | + } else { |
|
5891 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
5892 | + } |
|
5573 | 5893 | |
5574 | 5894 | // Everyone expects an array. |
5575 | 5895 | return array(); |
@@ -5603,8 +5923,9 @@ discard block |
||
5603 | 5923 | global $db_show_debug, $modSettings; |
5604 | 5924 | |
5605 | 5925 | // Defensive programming anyone? |
5606 | - if (empty($data)) |
|
5607 | - return false; |
|
5926 | + if (empty($data)) { |
|
5927 | + return false; |
|
5928 | + } |
|
5608 | 5929 | |
5609 | 5930 | // Don't need extra stuff... |
5610 | 5931 | $db_show_debug = false; |
@@ -5612,11 +5933,11 @@ discard block |
||
5612 | 5933 | // Kill anything else. |
5613 | 5934 | ob_end_clean(); |
5614 | 5935 | |
5615 | - if (!empty($modSettings['CompressedOutput'])) |
|
5616 | - @ob_start('ob_gzhandler'); |
|
5617 | - |
|
5618 | - else |
|
5619 | - ob_start(); |
|
5936 | + if (!empty($modSettings['CompressedOutput'])) { |
|
5937 | + @ob_start('ob_gzhandler'); |
|
5938 | + } else { |
|
5939 | + ob_start(); |
|
5940 | + } |
|
5620 | 5941 | |
5621 | 5942 | // Set the header. |
5622 | 5943 | header($type); |
@@ -5648,8 +5969,9 @@ discard block |
||
5648 | 5969 | static $done = false; |
5649 | 5970 | |
5650 | 5971 | // If we don't need to do anything, don't |
5651 | - if (!$update && $done) |
|
5652 | - return; |
|
5972 | + if (!$update && $done) { |
|
5973 | + return; |
|
5974 | + } |
|
5653 | 5975 | |
5654 | 5976 | // Should we get a new copy of the official list of TLDs? |
5655 | 5977 | if ($update) |
@@ -5658,8 +5980,9 @@ discard block |
||
5658 | 5980 | $tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt'); |
5659 | 5981 | |
5660 | 5982 | // If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored. |
5661 | - if ($tlds === false) |
|
5662 | - $postapocalypticNightmare = true; |
|
5983 | + if ($tlds === false) { |
|
5984 | + $postapocalypticNightmare = true; |
|
5985 | + } |
|
5663 | 5986 | } |
5664 | 5987 | // If we aren't updating and the regex is valid, we're done |
5665 | 5988 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5674,10 +5997,11 @@ discard block |
||
5674 | 5997 | // Clean $tlds and convert it to an array |
5675 | 5998 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
5676 | 5999 | $line = trim($line); |
5677 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
5678 | - return false; |
|
5679 | - else |
|
5680 | - return true; |
|
6000 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
6001 | + return false; |
|
6002 | + } else { |
|
6003 | + return true; |
|
6004 | + } |
|
5681 | 6005 | }); |
5682 | 6006 | |
5683 | 6007 | // Convert Punycode to Unicode |
@@ -5731,8 +6055,9 @@ discard block |
||
5731 | 6055 | $idx += $digit * $w; |
5732 | 6056 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
5733 | 6057 | |
5734 | - if ($digit < $t) |
|
5735 | - break; |
|
6058 | + if ($digit < $t) { |
|
6059 | + break; |
|
6060 | + } |
|
5736 | 6061 | |
5737 | 6062 | $w = (int) ($w * ($base - $t)); |
5738 | 6063 | } |
@@ -5741,8 +6066,9 @@ discard block |
||
5741 | 6066 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
5742 | 6067 | $delta += intval($delta / ($deco_len + 1)); |
5743 | 6068 | |
5744 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
5745 | - $delta = intval($delta / ($base - $tmin)); |
|
6069 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
6070 | + $delta = intval($delta / ($base - $tmin)); |
|
6071 | + } |
|
5746 | 6072 | |
5747 | 6073 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
5748 | 6074 | $is_first = false; |
@@ -5751,8 +6077,9 @@ discard block |
||
5751 | 6077 | |
5752 | 6078 | if ($deco_len > 0) |
5753 | 6079 | { |
5754 | - for ($i = $deco_len; $i > $idx; $i--) |
|
5755 | - $decoded[$i] = $decoded[($i - 1)]; |
|
6080 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
6081 | + $decoded[$i] = $decoded[($i - 1)]; |
|
6082 | + } |
|
5756 | 6083 | } |
5757 | 6084 | $decoded[$idx++] = $char; |
5758 | 6085 | } |
@@ -5760,24 +6087,29 @@ discard block |
||
5760 | 6087 | foreach ($decoded as $k => $v) |
5761 | 6088 | { |
5762 | 6089 | // 7bit are transferred literally |
5763 | - if ($v < 128) |
|
5764 | - $output .= chr($v); |
|
6090 | + if ($v < 128) { |
|
6091 | + $output .= chr($v); |
|
6092 | + } |
|
5765 | 6093 | |
5766 | 6094 | // 2 bytes |
5767 | - elseif ($v < (1 << 11)) |
|
5768 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6095 | + elseif ($v < (1 << 11)) { |
|
6096 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6097 | + } |
|
5769 | 6098 | |
5770 | 6099 | // 3 bytes |
5771 | - elseif ($v < (1 << 16)) |
|
5772 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6100 | + elseif ($v < (1 << 16)) { |
|
6101 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6102 | + } |
|
5773 | 6103 | |
5774 | 6104 | // 4 bytes |
5775 | - elseif ($v < (1 << 21)) |
|
5776 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6105 | + elseif ($v < (1 << 21)) { |
|
6106 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6107 | + } |
|
5777 | 6108 | |
5778 | 6109 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5779 | - else |
|
5780 | - $output .= $safe_char; |
|
6110 | + else { |
|
6111 | + $output .= $safe_char; |
|
6112 | + } |
|
5781 | 6113 | } |
5782 | 6114 | |
5783 | 6115 | $output_parts[] = $output; |
@@ -5870,8 +6202,7 @@ discard block |
||
5870 | 6202 | |
5871 | 6203 | $strlen = 'mb_strlen'; |
5872 | 6204 | $substr = 'mb_substr'; |
5873 | - } |
|
5874 | - else |
|
6205 | + } else |
|
5875 | 6206 | { |
5876 | 6207 | $strlen = $smcFunc['strlen']; |
5877 | 6208 | $substr = $smcFunc['substr']; |
@@ -5885,20 +6216,21 @@ discard block |
||
5885 | 6216 | |
5886 | 6217 | $first = $substr($string, 0, 1); |
5887 | 6218 | |
5888 | - if (empty($index[$first])) |
|
5889 | - $index[$first] = array(); |
|
6219 | + if (empty($index[$first])) { |
|
6220 | + $index[$first] = array(); |
|
6221 | + } |
|
5890 | 6222 | |
5891 | 6223 | if ($strlen($string) > 1) |
5892 | 6224 | { |
5893 | 6225 | // Sanity check on recursion |
5894 | - if ($depth > 99) |
|
5895 | - $index[$first][$substr($string, 1)] = ''; |
|
5896 | - |
|
5897 | - else |
|
5898 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6226 | + if ($depth > 99) { |
|
6227 | + $index[$first][$substr($string, 1)] = ''; |
|
6228 | + } else { |
|
6229 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6230 | + } |
|
6231 | + } else { |
|
6232 | + $index[$first][''] = ''; |
|
5899 | 6233 | } |
5900 | - else |
|
5901 | - $index[$first][''] = ''; |
|
5902 | 6234 | |
5903 | 6235 | $depth--; |
5904 | 6236 | return $index; |
@@ -5921,9 +6253,9 @@ discard block |
||
5921 | 6253 | $key_regex = preg_quote($key, $delim); |
5922 | 6254 | $new_key = $key; |
5923 | 6255 | |
5924 | - if (empty($value)) |
|
5925 | - $sub_regex = ''; |
|
5926 | - else |
|
6256 | + if (empty($value)) { |
|
6257 | + $sub_regex = ''; |
|
6258 | + } else |
|
5927 | 6259 | { |
5928 | 6260 | $sub_regex = $index_to_regex($value, $delim); |
5929 | 6261 | |
@@ -5931,22 +6263,22 @@ discard block |
||
5931 | 6263 | { |
5932 | 6264 | $new_key_array = explode('(?'.'>', $sub_regex); |
5933 | 6265 | $new_key .= $new_key_array[0]; |
6266 | + } else { |
|
6267 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5934 | 6268 | } |
5935 | - else |
|
5936 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5937 | 6269 | } |
5938 | 6270 | |
5939 | - if ($depth > 1) |
|
5940 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
5941 | - else |
|
6271 | + if ($depth > 1) { |
|
6272 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
6273 | + } else |
|
5942 | 6274 | { |
5943 | 6275 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
5944 | 6276 | { |
5945 | 6277 | $regex[$new_key] = $key_regex . $sub_regex; |
5946 | 6278 | unset($index[$key]); |
6279 | + } else { |
|
6280 | + break; |
|
5947 | 6281 | } |
5948 | - else |
|
5949 | - break; |
|
5950 | 6282 | } |
5951 | 6283 | } |
5952 | 6284 | |
@@ -5955,10 +6287,11 @@ discard block |
||
5955 | 6287 | $l1 = $strlen($k1); |
5956 | 6288 | $l2 = $strlen($k2); |
5957 | 6289 | |
5958 | - if ($l1 == $l2) |
|
5959 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
5960 | - else |
|
5961 | - return $l1 > $l2 ? -1 : 1; |
|
6290 | + if ($l1 == $l2) { |
|
6291 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
6292 | + } else { |
|
6293 | + return $l1 > $l2 ? -1 : 1; |
|
6294 | + } |
|
5962 | 6295 | }); |
5963 | 6296 | |
5964 | 6297 | $depth--; |
@@ -5969,21 +6302,24 @@ discard block |
||
5969 | 6302 | $index = array(); |
5970 | 6303 | $regex = ''; |
5971 | 6304 | |
5972 | - foreach ($strings as $string) |
|
5973 | - $index = $add_string_to_index($string, $index); |
|
6305 | + foreach ($strings as $string) { |
|
6306 | + $index = $add_string_to_index($string, $index); |
|
6307 | + } |
|
5974 | 6308 | |
5975 | 6309 | if ($returnArray === true) |
5976 | 6310 | { |
5977 | 6311 | $regex = array(); |
5978 | - while (!empty($index)) |
|
5979 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6312 | + while (!empty($index)) { |
|
6313 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6314 | + } |
|
6315 | + } else { |
|
6316 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
5980 | 6317 | } |
5981 | - else |
|
5982 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
5983 | 6318 | |
5984 | 6319 | // Restore PHP's internal character encoding to whatever it was originally |
5985 | - if (!empty($current_encoding)) |
|
5986 | - mb_internal_encoding($current_encoding); |
|
6320 | + if (!empty($current_encoding)) { |
|
6321 | + mb_internal_encoding($current_encoding); |
|
6322 | + } |
|
5987 | 6323 | |
5988 | 6324 | return $regex; |
5989 | 6325 | } |
@@ -6021,13 +6357,15 @@ discard block |
||
6021 | 6357 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
6022 | 6358 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
6023 | 6359 | $headers = @get_headers($url); |
6024 | - if ($headers === false) |
|
6025 | - return false; |
|
6360 | + if ($headers === false) { |
|
6361 | + return false; |
|
6362 | + } |
|
6026 | 6363 | |
6027 | 6364 | // Now to see if it came back https... |
6028 | 6365 | // First check for a redirect status code in first row (301, 302, 307) |
6029 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
6030 | - return false; |
|
6366 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
6367 | + return false; |
|
6368 | + } |
|
6031 | 6369 | |
6032 | 6370 | // Search for the location entry to confirm https |
6033 | 6371 | $result = false; |