@@ -18,10 +18,10 @@ |
||
18 | 18 | */ |
19 | 19 | class Update_TLD_Regex extends SMF_BackgroundTask |
20 | 20 | { |
21 | - /** |
|
22 | - * This executes the task. It just calls set_tld_regex() in Subs.php |
|
23 | - * @return bool Always returns true |
|
24 | - */ |
|
21 | + /** |
|
22 | + * This executes the task. It just calls set_tld_regex() in Subs.php |
|
23 | + * @return bool Always returns true |
|
24 | + */ |
|
25 | 25 | public function execute() |
26 | 26 | { |
27 | 27 | global $sourcedir; |
@@ -20,7 +20,7 @@ |
||
20 | 20 | class MemberReportReply_Notify_Background extends SMF_BackgroundTask |
21 | 21 | { |
22 | 22 | /** |
23 | - * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed. |
|
23 | + * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed. |
|
24 | 24 | * @return bool Always returns true. |
25 | 25 | */ |
26 | 26 | public function execute() |
@@ -40,8 +40,9 @@ discard block |
||
40 | 40 | 'last_comment' => $this->_details['comment_id'], |
41 | 41 | ) |
42 | 42 | ); |
43 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
44 | - $possible_members[] = $row[0]; |
|
43 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
44 | + $possible_members[] = $row[0]; |
|
45 | + } |
|
45 | 46 | $smcFunc['db_free_result']($request); |
46 | 47 | |
47 | 48 | // Presumably, there are some people? |
@@ -50,8 +51,9 @@ discard block |
||
50 | 51 | $possible_members = array_flip(array_flip($possible_members)); |
51 | 52 | $possible_members = array_diff($possible_members, array($this->_details['sender_id'])); |
52 | 53 | } |
53 | - if (empty($possible_members)) |
|
54 | - return true; |
|
54 | + if (empty($possible_members)) { |
|
55 | + return true; |
|
56 | + } |
|
55 | 57 | |
56 | 58 | // We need to know who can moderate this board - and therefore who can see this report. |
57 | 59 | // First up, people who have moderate_board in the board this topic was in. |
@@ -73,8 +75,9 @@ discard block |
||
73 | 75 | { |
74 | 76 | foreach ($alert_bits as $type => $bitvalue) |
75 | 77 | { |
76 | - if ($pref_option['member_report_reply'] & $bitvalue) |
|
77 | - $notifies[$type][] = $member; |
|
78 | + if ($pref_option['member_report_reply'] & $bitvalue) { |
|
79 | + $notifies[$type][] = $member; |
|
80 | + } |
|
78 | 81 | } |
79 | 82 | } |
80 | 83 | |
@@ -136,8 +139,9 @@ discard block |
||
136 | 139 | ); |
137 | 140 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
138 | 141 | { |
139 | - if (empty($row['lngfile'])) |
|
140 | - $row['lngfile'] = $language; |
|
142 | + if (empty($row['lngfile'])) { |
|
143 | + $row['lngfile'] = $language; |
|
144 | + } |
|
141 | 145 | $emails[$row['lngfile']][$row['id_member']] = $row['email_address']; |
142 | 146 | } |
143 | 147 | $smcFunc['db_free_result']($request); |
@@ -155,8 +159,9 @@ discard block |
||
155 | 159 | $emaildata = loadEmailTemplate('reply_to_user_reports', $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang); |
156 | 160 | |
157 | 161 | // And do the actual sending... |
158 | - foreach ($recipients as $id_member => $email_address) |
|
159 | - sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'urptrpy' . $this->_details['comment_id'], $emaildata['is_html'], 3); |
|
162 | + foreach ($recipients as $id_member => $email_address) { |
|
163 | + sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'urptrpy' . $this->_details['comment_id'], $emaildata['is_html'], 3); |
|
164 | + } |
|
160 | 165 | } |
161 | 166 | } |
162 | 167 |
@@ -18,7 +18,7 @@ |
||
18 | 18 | class ApproveReply_Notify_Background extends SMF_BackgroundTask |
19 | 19 | { |
20 | 20 | /** |
21 | - * This executes the task - loads up the information, puts the email in the queue and inserts alerts. |
|
21 | + * This executes the task - loads up the information, puts the email in the queue and inserts alerts. |
|
22 | 22 | * @return bool Always returns true. |
23 | 23 | */ |
24 | 24 | public function execute() |
@@ -96,14 +96,15 @@ |
||
96 | 96 | } |
97 | 97 | |
98 | 98 | // Insert the alerts if any |
99 | - if (!empty($alert_rows)) |
|
100 | - $smcFunc['db_insert']('', |
|
99 | + if (!empty($alert_rows)) { |
|
100 | + $smcFunc['db_insert']('', |
|
101 | 101 | '{db_prefix}user_alerts', |
102 | 102 | array('alert_time' => 'int', 'id_member' => 'int', 'id_member_started' => 'int', 'member_name' => 'string', |
103 | 103 | 'content_type' => 'string', 'content_id' => 'int', 'content_action' => 'string', 'is_read' => 'int', 'extra' => 'string'), |
104 | 104 | $alert_rows, |
105 | 105 | array() |
106 | 106 | ); |
107 | + } |
|
107 | 108 | |
108 | 109 | return true; |
109 | 110 | } |
@@ -20,7 +20,7 @@ |
||
20 | 20 | class GroupReq_Notify_Background extends SMF_BackgroundTask |
21 | 21 | { |
22 | 22 | /** |
23 | - * This executes the task - loads up the information, puts the email in the queue and inserts any alerts as needed. |
|
23 | + * This executes the task - loads up the information, puts the email in the queue and inserts any alerts as needed. |
|
24 | 24 | * @return bool Always returns true. |
25 | 25 | */ |
26 | 26 | public function execute() |
@@ -37,8 +37,9 @@ discard block |
||
37 | 37 | ) |
38 | 38 | ); |
39 | 39 | $moderators = array(); |
40 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
41 | - $moderators[] = $row['id_member']; |
|
40 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
41 | + $moderators[] = $row['id_member']; |
|
42 | + } |
|
42 | 43 | $smcFunc['db_free_result']($request); |
43 | 44 | |
44 | 45 | require_once($sourcedir . '/Subs-Members.php'); |
@@ -59,11 +60,13 @@ discard block |
||
59 | 60 | { |
60 | 61 | if (!empty($prefs[$mod]['request_group'])) |
61 | 62 | { |
62 | - if ($prefs[$mod]['request_group'] & 0x01) |
|
63 | - $data['alert'][] = $mod; |
|
63 | + if ($prefs[$mod]['request_group'] & 0x01) { |
|
64 | + $data['alert'][] = $mod; |
|
65 | + } |
|
64 | 66 | |
65 | - if ($prefs[$mod]['request_group'] & 0x02) |
|
66 | - $data['email'][] = $mod; |
|
67 | + if ($prefs[$mod]['request_group'] & 0x02) { |
|
68 | + $data['email'][] = $mod; |
|
69 | + } |
|
67 | 70 | } |
68 | 71 | } |
69 | 72 |
@@ -240,8 +240,8 @@ |
||
240 | 240 | $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
241 | 241 | |
242 | 242 | $js_time_string = str_replace( |
243 | - array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
|
244 | - array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'), |
|
243 | + array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
|
244 | + array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'), |
|
245 | 245 | $time_string |
246 | 246 | ); |
247 | 247 |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 4 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Show the calendar. |
@@ -47,12 +48,14 @@ discard block |
||
47 | 48 | 'post' => 'CalendarPost', |
48 | 49 | ); |
49 | 50 | |
50 | - if (isset($_GET['sa']) && isset($subActions[$_GET['sa']])) |
|
51 | - return call_helper($subActions[$_GET['sa']]); |
|
51 | + if (isset($_GET['sa']) && isset($subActions[$_GET['sa']])) { |
|
52 | + return call_helper($subActions[$_GET['sa']]); |
|
53 | + } |
|
52 | 54 | |
53 | 55 | // You can't do anything if the calendar is off. |
54 | - if (empty($modSettings['cal_enabled'])) |
|
55 | - fatal_lang_error('calendar_off', false); |
|
56 | + if (empty($modSettings['cal_enabled'])) { |
|
57 | + fatal_lang_error('calendar_off', false); |
|
58 | + } |
|
56 | 59 | |
57 | 60 | // This is gonna be needed... |
58 | 61 | loadTemplate('Calendar'); |
@@ -88,22 +91,25 @@ discard block |
||
88 | 91 | $context['page_title'] = $txt['calendar']; |
89 | 92 | |
90 | 93 | // Ensure a default view is defined |
91 | - if (empty($modSettings['calendar_default_view'])) |
|
92 | - $modSettings['calendar_default_view'] = 'viewlist'; |
|
94 | + if (empty($modSettings['calendar_default_view'])) { |
|
95 | + $modSettings['calendar_default_view'] = 'viewlist'; |
|
96 | + } |
|
93 | 97 | |
94 | 98 | // What view do we want? |
95 | - if (isset($_GET['viewweek'])) |
|
96 | - $context['calendar_view'] = 'viewweek'; |
|
97 | - elseif (isset($_GET['viewmonth'])) |
|
98 | - $context['calendar_view'] = 'viewmonth'; |
|
99 | - elseif (isset($_GET['viewlist'])) |
|
100 | - $context['calendar_view'] = 'viewlist'; |
|
101 | - else |
|
102 | - $context['calendar_view'] = $modSettings['calendar_default_view']; |
|
99 | + if (isset($_GET['viewweek'])) { |
|
100 | + $context['calendar_view'] = 'viewweek'; |
|
101 | + } elseif (isset($_GET['viewmonth'])) { |
|
102 | + $context['calendar_view'] = 'viewmonth'; |
|
103 | + } elseif (isset($_GET['viewlist'])) { |
|
104 | + $context['calendar_view'] = 'viewlist'; |
|
105 | + } else { |
|
106 | + $context['calendar_view'] = $modSettings['calendar_default_view']; |
|
107 | + } |
|
103 | 108 | |
104 | 109 | // Don't let search engines index the non-default calendar pages |
105 | - if ($context['calendar_view'] !== $modSettings['calendar_default_view']) |
|
106 | - $context['robot_no_index'] = true; |
|
110 | + if ($context['calendar_view'] !== $modSettings['calendar_default_view']) { |
|
111 | + $context['robot_no_index'] = true; |
|
112 | + } |
|
107 | 113 | |
108 | 114 | // Get the current day of month... |
109 | 115 | require_once($sourcedir . '/Subs-Calendar.php'); |
@@ -164,16 +170,19 @@ discard block |
||
164 | 170 | ); |
165 | 171 | |
166 | 172 | // Make sure the year and month are in valid ranges. |
167 | - if ($curPage['month'] < 1 || $curPage['month'] > 12) |
|
168 | - fatal_lang_error('invalid_month', false); |
|
169 | - if ($curPage['year'] < $modSettings['cal_minyear'] || $curPage['year'] > $modSettings['cal_maxyear']) |
|
170 | - fatal_lang_error('invalid_year', false); |
|
173 | + if ($curPage['month'] < 1 || $curPage['month'] > 12) { |
|
174 | + fatal_lang_error('invalid_month', false); |
|
175 | + } |
|
176 | + if ($curPage['year'] < $modSettings['cal_minyear'] || $curPage['year'] > $modSettings['cal_maxyear']) { |
|
177 | + fatal_lang_error('invalid_year', false); |
|
178 | + } |
|
171 | 179 | // If we have a day clean that too. |
172 | 180 | if ($context['calendar_view'] != 'viewmonth') |
173 | 181 | { |
174 | 182 | $isValid = checkdate($curPage['month'], $curPage['day'], $curPage['year']); |
175 | - if (!$isValid) |
|
176 | - fatal_lang_error('invalid_day', false); |
|
183 | + if (!$isValid) { |
|
184 | + fatal_lang_error('invalid_day', false); |
|
185 | + } |
|
177 | 186 | } |
178 | 187 | |
179 | 188 | // Load all the context information needed to show the calendar grid. |
@@ -195,23 +204,26 @@ discard block |
||
195 | 204 | ); |
196 | 205 | |
197 | 206 | // Load up the main view. |
198 | - if ($context['calendar_view'] == 'viewlist') |
|
199 | - $context['calendar_grid_main'] = getCalendarList($curPage['start_date'], $curPage['end_date'], $calendarOptions); |
|
200 | - elseif ($context['calendar_view'] == 'viewweek') |
|
201 | - $context['calendar_grid_main'] = getCalendarWeek($curPage['month'], $curPage['year'], $curPage['day'], $calendarOptions); |
|
202 | - else |
|
203 | - $context['calendar_grid_main'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions); |
|
207 | + if ($context['calendar_view'] == 'viewlist') { |
|
208 | + $context['calendar_grid_main'] = getCalendarList($curPage['start_date'], $curPage['end_date'], $calendarOptions); |
|
209 | + } elseif ($context['calendar_view'] == 'viewweek') { |
|
210 | + $context['calendar_grid_main'] = getCalendarWeek($curPage['month'], $curPage['year'], $curPage['day'], $calendarOptions); |
|
211 | + } else { |
|
212 | + $context['calendar_grid_main'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions); |
|
213 | + } |
|
204 | 214 | |
205 | 215 | // Load up the previous and next months. |
206 | 216 | $context['calendar_grid_current'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions); |
207 | 217 | |
208 | 218 | // Only show previous month if it isn't pre-January of the min-year |
209 | - if ($context['calendar_grid_current']['previous_calendar']['year'] > $modSettings['cal_minyear'] || $curPage['month'] != 1) |
|
210 | - $context['calendar_grid_prev'] = getCalendarGrid($context['calendar_grid_current']['previous_calendar']['month'], $context['calendar_grid_current']['previous_calendar']['year'], $calendarOptions, true); |
|
219 | + if ($context['calendar_grid_current']['previous_calendar']['year'] > $modSettings['cal_minyear'] || $curPage['month'] != 1) { |
|
220 | + $context['calendar_grid_prev'] = getCalendarGrid($context['calendar_grid_current']['previous_calendar']['month'], $context['calendar_grid_current']['previous_calendar']['year'], $calendarOptions, true); |
|
221 | + } |
|
211 | 222 | |
212 | 223 | // Only show next month if it isn't post-December of the max-year |
213 | - if ($context['calendar_grid_current']['next_calendar']['year'] < $modSettings['cal_maxyear'] || $curPage['month'] != 12) |
|
214 | - $context['calendar_grid_next'] = getCalendarGrid($context['calendar_grid_current']['next_calendar']['month'], $context['calendar_grid_current']['next_calendar']['year'], $calendarOptions); |
|
224 | + if ($context['calendar_grid_current']['next_calendar']['year'] < $modSettings['cal_maxyear'] || $curPage['month'] != 12) { |
|
225 | + $context['calendar_grid_next'] = getCalendarGrid($context['calendar_grid_current']['next_calendar']['month'], $context['calendar_grid_current']['next_calendar']['year'], $calendarOptions); |
|
226 | + } |
|
215 | 227 | |
216 | 228 | // Basic template stuff. |
217 | 229 | $context['allow_calendar_event'] = allowedTo('calendar_post'); |
@@ -231,8 +243,9 @@ discard block |
||
231 | 243 | $context['blocks_disabled'] = !empty($modSettings['cal_disable_prev_next']) ? 1 : 0; |
232 | 244 | |
233 | 245 | // Set the page title to mention the month or week, too |
234 | - if ($context['calendar_view'] != 'viewlist') |
|
235 | - $context['page_title'] .= ' - ' . ($context['calendar_view'] == 'viewweek' ? $context['calendar_grid_main']['week_title'] : $txt['months'][$context['current_month']] . ' ' . $context['current_year']); |
|
246 | + if ($context['calendar_view'] != 'viewlist') { |
|
247 | + $context['page_title'] .= ' - ' . ($context['calendar_view'] == 'viewweek' ? $context['calendar_grid_main']['week_title'] : $txt['months'][$context['current_month']] . ' ' . $context['current_year']); |
|
248 | + } |
|
236 | 249 | |
237 | 250 | // Load up the linktree! |
238 | 251 | $context['linktree'][] = array( |
@@ -245,17 +258,19 @@ discard block |
||
245 | 258 | 'name' => $txt['months'][$context['current_month']] . ' ' . $context['current_year'] |
246 | 259 | ); |
247 | 260 | // If applicable, add the current week to the linktree. |
248 | - if ($context['calendar_view'] == 'viewweek') |
|
249 | - $context['linktree'][] = array( |
|
261 | + if ($context['calendar_view'] == 'viewweek') { |
|
262 | + $context['linktree'][] = array( |
|
250 | 263 | 'url' => $scripturl . '?action=calendar;viewweek;year=' . $context['current_year'] . ';month=' . $context['current_month'] . ';day=' . $context['current_day'], |
251 | 264 | 'name' => $context['calendar_grid_main']['week_title'], |
252 | 265 | ); |
266 | + } |
|
253 | 267 | |
254 | 268 | // Build the calendar button array. |
255 | 269 | $context['calendar_buttons'] = array(); |
256 | 270 | |
257 | - if ($context['can_post']) |
|
258 | - $context['calendar_buttons']['post_event'] = array('text' => 'calendar_post_event', 'image' => 'calendarpe.png', 'url' => $scripturl . '?action=calendar;sa=post;month=' . $context['current_month'] . ';year=' . $context['current_year'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
271 | + if ($context['can_post']) { |
|
272 | + $context['calendar_buttons']['post_event'] = array('text' => 'calendar_post_event', 'image' => 'calendarpe.png', 'url' => $scripturl . '?action=calendar;sa=post;month=' . $context['current_month'] . ';year=' . $context['current_year'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
273 | + } |
|
259 | 274 | |
260 | 275 | // Allow mods to add additional buttons here |
261 | 276 | call_integration_hook('integrate_calendar_buttons'); |
@@ -284,14 +299,16 @@ discard block |
||
284 | 299 | require_once($sourcedir . '/Subs.php'); |
285 | 300 | |
286 | 301 | // Cast this for safety... |
287 | - if (isset($_REQUEST['eventid'])) |
|
288 | - $_REQUEST['eventid'] = (int) $_REQUEST['eventid']; |
|
302 | + if (isset($_REQUEST['eventid'])) { |
|
303 | + $_REQUEST['eventid'] = (int) $_REQUEST['eventid']; |
|
304 | + } |
|
289 | 305 | |
290 | 306 | // We want a fairly compact version of the time, but as close as possible to the user's settings. |
291 | - if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
292 | - $time_string = '%k:%M'; |
|
293 | - else |
|
294 | - $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
307 | + if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
308 | + $time_string = '%k:%M'; |
|
309 | + } else { |
|
310 | + $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
311 | + } |
|
295 | 312 | |
296 | 313 | $js_time_string = str_replace( |
297 | 314 | array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
@@ -305,12 +322,14 @@ discard block |
||
305 | 322 | checkSession(); |
306 | 323 | |
307 | 324 | // Validate the post... |
308 | - if (!isset($_POST['link_to_board'])) |
|
309 | - validateEventPost(); |
|
325 | + if (!isset($_POST['link_to_board'])) { |
|
326 | + validateEventPost(); |
|
327 | + } |
|
310 | 328 | |
311 | 329 | // If you're not allowed to edit any events, you have to be the poster. |
312 | - if ($_REQUEST['eventid'] > 0 && !allowedTo('calendar_edit_any')) |
|
313 | - isAllowedTo('calendar_edit_' . (!empty($user_info['id']) && getEventPoster($_REQUEST['eventid']) == $user_info['id'] ? 'own' : 'any')); |
|
330 | + if ($_REQUEST['eventid'] > 0 && !allowedTo('calendar_edit_any')) { |
|
331 | + isAllowedTo('calendar_edit_' . (!empty($user_info['id']) && getEventPoster($_REQUEST['eventid']) == $user_info['id'] ? 'own' : 'any')); |
|
332 | + } |
|
314 | 333 | |
315 | 334 | // New - and directing? |
316 | 335 | if (isset($_POST['link_to_board']) || empty($modSettings['cal_allow_unlinked'])) |
@@ -333,8 +352,9 @@ discard block |
||
333 | 352 | } |
334 | 353 | |
335 | 354 | // Deleting... |
336 | - elseif (isset($_REQUEST['deleteevent'])) |
|
337 | - removeEvent($_REQUEST['eventid']); |
|
355 | + elseif (isset($_REQUEST['deleteevent'])) { |
|
356 | + removeEvent($_REQUEST['eventid']); |
|
357 | + } |
|
338 | 358 | |
339 | 359 | // ... or just update it? |
340 | 360 | else |
@@ -357,15 +377,13 @@ discard block |
||
357 | 377 | $year = $d['year']; |
358 | 378 | $month = $d['month']; |
359 | 379 | $day = $d['day']; |
360 | - } |
|
361 | - elseif (isset($_POST['start_datetime'])) |
|
380 | + } elseif (isset($_POST['start_datetime'])) |
|
362 | 381 | { |
363 | 382 | $d = date_parse($_POST['start_datetime']); |
364 | 383 | $year = $d['year']; |
365 | 384 | $month = $d['month']; |
366 | 385 | $day = $d['day']; |
367 | - } |
|
368 | - else |
|
386 | + } else |
|
369 | 387 | { |
370 | 388 | $today = getdate(); |
371 | 389 | $year = isset($_POST['year']) ? $_POST['year'] : $today['year']; |
@@ -399,13 +417,13 @@ discard block |
||
399 | 417 | $context['event'] = array_merge($context['event'], $eventDatetimes); |
400 | 418 | |
401 | 419 | $context['event']['last_day'] = (int) strftime('%d', mktime(0, 0, 0, $context['event']['month'] == 12 ? 1 : $context['event']['month'] + 1, 0, $context['event']['month'] == 12 ? $context['event']['year'] + 1 : $context['event']['year'])); |
402 | - } |
|
403 | - else |
|
420 | + } else |
|
404 | 421 | { |
405 | 422 | $context['event'] = getEventProperties($_REQUEST['eventid']); |
406 | 423 | |
407 | - if ($context['event'] === false) |
|
408 | - fatal_lang_error('no_access', false); |
|
424 | + if ($context['event'] === false) { |
|
425 | + fatal_lang_error('no_access', false); |
|
426 | + } |
|
409 | 427 | |
410 | 428 | // If it has a board, then they should be editing it within the topic. |
411 | 429 | if (!empty($context['event']['topic']['id']) && !empty($context['event']['topic']['first_msg'])) |
@@ -416,10 +434,11 @@ discard block |
||
416 | 434 | } |
417 | 435 | |
418 | 436 | // Make sure the user is allowed to edit this event. |
419 | - if ($context['event']['member'] != $user_info['id']) |
|
420 | - isAllowedTo('calendar_edit_any'); |
|
421 | - elseif (!allowedTo('calendar_edit_any')) |
|
422 | - isAllowedTo('calendar_edit_own'); |
|
437 | + if ($context['event']['member'] != $user_info['id']) { |
|
438 | + isAllowedTo('calendar_edit_any'); |
|
439 | + } elseif (!allowedTo('calendar_edit_any')) { |
|
440 | + isAllowedTo('calendar_edit_own'); |
|
441 | + } |
|
423 | 442 | } |
424 | 443 | |
425 | 444 | // An all day event? Set up some nice defaults in case the user wants to change that |
@@ -453,8 +472,7 @@ discard block |
||
453 | 472 | { |
454 | 473 | // You can post new events but can't link them to anything... |
455 | 474 | $context['event']['categories'] = array(); |
456 | - } |
|
457 | - else |
|
475 | + } else |
|
458 | 476 | { |
459 | 477 | // Load the list of boards and categories in the context. |
460 | 478 | require_once($sourcedir . '/Subs-MessageIndex.php'); |
@@ -541,12 +559,14 @@ discard block |
||
541 | 559 | global $smcFunc, $sourcedir, $forum_version, $modSettings, $webmaster_email, $mbname; |
542 | 560 | |
543 | 561 | // You can't export if the calendar export feature is off. |
544 | - if (empty($modSettings['cal_export'])) |
|
545 | - fatal_lang_error('calendar_export_off', false); |
|
562 | + if (empty($modSettings['cal_export'])) { |
|
563 | + fatal_lang_error('calendar_export_off', false); |
|
564 | + } |
|
546 | 565 | |
547 | 566 | // Goes without saying that this is required. |
548 | - if (!isset($_REQUEST['eventid'])) |
|
549 | - fatal_lang_error('no_access', false); |
|
567 | + if (!isset($_REQUEST['eventid'])) { |
|
568 | + fatal_lang_error('no_access', false); |
|
569 | + } |
|
550 | 570 | |
551 | 571 | // This is kinda wanted. |
552 | 572 | require_once($sourcedir . '/Subs-Calendar.php'); |
@@ -554,15 +574,17 @@ discard block |
||
554 | 574 | // Load up the event in question and check it exists. |
555 | 575 | $event = getEventProperties($_REQUEST['eventid']); |
556 | 576 | |
557 | - if ($event === false) |
|
558 | - fatal_lang_error('no_access', false); |
|
577 | + if ($event === false) { |
|
578 | + fatal_lang_error('no_access', false); |
|
579 | + } |
|
559 | 580 | |
560 | 581 | // Check the title isn't too long - iCal requires some formatting if so. |
561 | 582 | $title = str_split($event['title'], 30); |
562 | 583 | foreach ($title as $id => $line) |
563 | 584 | { |
564 | - if ($id != 0) |
|
565 | - $title[$id] = ' ' . $title[$id]; |
|
585 | + if ($id != 0) { |
|
586 | + $title[$id] = ' ' . $title[$id]; |
|
587 | + } |
|
566 | 588 | $title[$id] .= "\n"; |
567 | 589 | } |
568 | 590 | |
@@ -575,8 +597,7 @@ discard block |
||
575 | 597 | { |
576 | 598 | $datestart = date_format($start_date, 'Ymd\THis'); |
577 | 599 | $dateend = date_format($end_date, 'Ymd\THis'); |
578 | - } |
|
579 | - else |
|
600 | + } else |
|
580 | 601 | { |
581 | 602 | $datestart = date_format($start_date, 'Ymd'); |
582 | 603 | |
@@ -597,15 +618,18 @@ discard block |
||
597 | 618 | $filecontents .= 'DTSTART' . (!empty($event['start_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $datestart . "\n"; |
598 | 619 | |
599 | 620 | // event has a duration |
600 | - if ($event['start_iso_gmdate'] != $event['end_iso_gmdate']) |
|
601 | - $filecontents .= 'DTEND' . (!empty($event['end_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $dateend . "\n"; |
|
621 | + if ($event['start_iso_gmdate'] != $event['end_iso_gmdate']) { |
|
622 | + $filecontents .= 'DTEND' . (!empty($event['end_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $dateend . "\n"; |
|
623 | + } |
|
602 | 624 | |
603 | 625 | // event has changed? advance the sequence for this UID |
604 | - if ($event['sequence'] > 0) |
|
605 | - $filecontents .= 'SEQUENCE:' . $event['sequence'] . "\n"; |
|
626 | + if ($event['sequence'] > 0) { |
|
627 | + $filecontents .= 'SEQUENCE:' . $event['sequence'] . "\n"; |
|
628 | + } |
|
606 | 629 | |
607 | - if (!empty($event['location'])) |
|
608 | - $filecontents .= 'LOCATION:' . str_replace(',', '\,', $event['location']) . "\n"; |
|
630 | + if (!empty($event['location'])) { |
|
631 | + $filecontents .= 'LOCATION:' . str_replace(',', '\,', $event['location']) . "\n"; |
|
632 | + } |
|
609 | 633 | |
610 | 634 | $filecontents .= 'SUMMARY:' . implode('', $title); |
611 | 635 | $filecontents .= 'UID:' . $event['eventid'] . '@' . str_replace(' ', '-', $mbname) . "\n"; |
@@ -614,23 +638,26 @@ discard block |
||
614 | 638 | |
615 | 639 | // Send some standard headers. |
616 | 640 | ob_end_clean(); |
617 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
618 | - @ob_start('ob_gzhandler'); |
|
619 | - else |
|
620 | - ob_start(); |
|
641 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
642 | + @ob_start('ob_gzhandler'); |
|
643 | + } else { |
|
644 | + ob_start(); |
|
645 | + } |
|
621 | 646 | |
622 | 647 | // Send the file headers |
623 | 648 | header('Pragma: '); |
624 | 649 | header('Cache-Control: no-cache'); |
625 | - if (!isBrowser('gecko')) |
|
626 | - header('Content-Transfer-Encoding: binary'); |
|
650 | + if (!isBrowser('gecko')) { |
|
651 | + header('Content-Transfer-Encoding: binary'); |
|
652 | + } |
|
627 | 653 | header('Expires: ' . gmdate('D, d M Y H:i:s', time() + 525600 * 60) . ' GMT'); |
628 | 654 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s', time()) . 'GMT'); |
629 | 655 | header('Accept-Ranges: bytes'); |
630 | 656 | header('Connection: close'); |
631 | 657 | header('Content-Disposition: attachment; filename="' . $event['title'] . '.ics"'); |
632 | - if (empty($modSettings['enableCompressedOutput'])) |
|
633 | - header('Content-Length: ' . $smcFunc['strlen']($filecontents)); |
|
658 | + if (empty($modSettings['enableCompressedOutput'])) { |
|
659 | + header('Content-Length: ' . $smcFunc['strlen']($filecontents)); |
|
660 | + } |
|
634 | 661 | |
635 | 662 | // This is a calendar item! |
636 | 663 | header('Content-Type: text/calendar'); |
@@ -669,20 +696,17 @@ discard block |
||
669 | 696 | $context['sub_template'] = 'bcd'; |
670 | 697 | $context['linktree'][] = array('url' => $scripturl . '?action=clock;bcd', 'name' => 'BCD'); |
671 | 698 | $context['clockicons'] = safe_unserialize(base64_decode('YTo2OntzOjI6ImgxIjthOjI6e2k6MDtpOjI7aToxO2k6MTt9czoyOiJoMiI7YTo0OntpOjA7aTo4O2k6MTtpOjQ7aToyO2k6MjtpOjM7aToxO31zOjI6Im0xIjthOjM6e2k6MDtpOjQ7aToxO2k6MjtpOjI7aToxO31zOjI6Im0yIjthOjQ6e2k6MDtpOjg7aToxO2k6NDtpOjI7aToyO2k6MztpOjE7fXM6MjoiczEiO2E6Mzp7aTowO2k6NDtpOjE7aToyO2k6MjtpOjE7fXM6MjoiczIiO2E6NDp7aTowO2k6ODtpOjE7aTo0O2k6MjtpOjI7aTozO2k6MTt9fQ==')); |
672 | - } |
|
673 | - elseif (!$omfg && !isset($_REQUEST['time'])) |
|
699 | + } elseif (!$omfg && !isset($_REQUEST['time'])) |
|
674 | 700 | { |
675 | 701 | $context['sub_template'] = 'hms'; |
676 | 702 | $context['linktree'][] = array('url' => $scripturl . '?action=clock', 'name' => 'Binary'); |
677 | 703 | $context['clockicons'] = safe_unserialize(base64_decode('YTozOntzOjE6ImgiO2E6NTp7aTowO2k6MTY7aToxO2k6ODtpOjI7aTo0O2k6MztpOjI7aTo0O2k6MTt9czoxOiJtIjthOjY6e2k6MDtpOjMyO2k6MTtpOjE2O2k6MjtpOjg7aTozO2k6NDtpOjQ7aToyO2k6NTtpOjE7fXM6MToicyI7YTo2OntpOjA7aTozMjtpOjE7aToxNjtpOjI7aTo4O2k6MztpOjQ7aTo0O2k6MjtpOjU7aToxO319')); |
678 | - } |
|
679 | - elseif ($omfg) |
|
704 | + } elseif ($omfg) |
|
680 | 705 | { |
681 | 706 | $context['sub_template'] = 'omfg'; |
682 | 707 | $context['linktree'][] = array('url' => $scripturl . '?action=clock;omfg', 'name' => 'OMFG'); |
683 | 708 | $context['clockicons'] = safe_unserialize(base64_decode('YTo2OntzOjQ6InllYXIiO2E6Nzp7aTowO2k6NjQ7aToxO2k6MzI7aToyO2k6MTY7aTozO2k6ODtpOjQ7aTo0O2k6NTtpOjI7aTo2O2k6MTt9czo1OiJtb250aCI7YTo0OntpOjA7aTo4O2k6MTtpOjQ7aToyO2k6MjtpOjM7aToxO31zOjM6ImRheSI7YTo1OntpOjA7aToxNjtpOjE7aTo4O2k6MjtpOjQ7aTozO2k6MjtpOjQ7aToxO31zOjQ6ImhvdXIiO2E6NTp7aTowO2k6MTY7aToxO2k6ODtpOjI7aTo0O2k6MztpOjI7aTo0O2k6MTt9czozOiJtaW4iO2E6Njp7aTowO2k6MzI7aToxO2k6MTY7aToyO2k6ODtpOjM7aTo0O2k6NDtpOjI7aTo1O2k6MTt9czozOiJzZWMiO2E6Njp7aTowO2k6MzI7aToxO2k6MTY7aToyO2k6ODtpOjM7aTo0O2k6NDtpOjI7aTo1O2k6MTt9fQ==')); |
684 | - } |
|
685 | - elseif (isset($_REQUEST['time'])) |
|
709 | + } elseif (isset($_REQUEST['time'])) |
|
686 | 710 | { |
687 | 711 | $context['sub_template'] = 'thetime'; |
688 | 712 | $time = getdate($_REQUEST['time'] == 'now' ? time() : (int) $_REQUEST['time']); |
@@ -736,12 +760,13 @@ discard block |
||
736 | 760 | ), |
737 | 761 | ); |
738 | 762 | |
739 | - foreach ($context['clockicons'] as $t => $vs) |
|
740 | - foreach ($vs as $v => $dumb) |
|
763 | + foreach ($context['clockicons'] as $t => $vs) { |
|
764 | + foreach ($vs as $v => $dumb) |
|
741 | 765 | { |
742 | 766 | if ($$t >= $v) |
743 | 767 | { |
744 | 768 | $$t -= $v; |
769 | + } |
|
745 | 770 | $context['clockicons'][$t][$v] = true; |
746 | 771 | } |
747 | 772 | } |
@@ -1622,8 +1622,7 @@ |
||
1622 | 1622 | updateStats('topic'); |
1623 | 1623 | |
1624 | 1624 | // This function is needed to do the updateStats('subject') call. |
1625 | - $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : |
|
1626 | - function($string){ |
|
1625 | + $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) { |
|
1627 | 1626 | global $sourcedir; |
1628 | 1627 | if (function_exists('mb_strtolower')) |
1629 | 1628 | return mb_strtolower($string, 'UTF-8'); |
@@ -20,8 +20,9 @@ discard block |
||
20 | 20 | // ><html dir="ltr"><head><title>Error!</title></head><body>Sorry, this installer requires PHP!<div style="display: none;"> |
21 | 21 | |
22 | 22 | // Let's pull in useful classes |
23 | -if (!defined('SMF')) |
|
23 | +if (!defined('SMF')) { |
|
24 | 24 | define('SMF', 1); |
25 | +} |
|
25 | 26 | |
26 | 27 | require_once('Sources/Class-Package.php'); |
27 | 28 | |
@@ -63,10 +64,11 @@ discard block |
||
63 | 64 | |
64 | 65 | list ($charcode) = pg_fetch_row($request); |
65 | 66 | |
66 | - if ($charcode == 'UTF8') |
|
67 | - return true; |
|
68 | - else |
|
69 | - return false; |
|
67 | + if ($charcode == 'UTF8') { |
|
68 | + return true; |
|
69 | + } else { |
|
70 | + return false; |
|
71 | + } |
|
70 | 72 | }, |
71 | 73 | 'utf8_version' => '8.0', |
72 | 74 | 'utf8_version_check' => '$request = pg_query(\'SELECT version()\'); list ($version) = pg_fetch_row($request); list($pgl, $version) = explode(" ", $version); return $version;', |
@@ -76,12 +78,14 @@ discard block |
||
76 | 78 | $value = preg_replace('~[^A-Za-z0-9_\$]~', '', $value); |
77 | 79 | |
78 | 80 | // Is it reserved? |
79 | - if ($value == 'pg_') |
|
80 | - return $txt['error_db_prefix_reserved']; |
|
81 | + if ($value == 'pg_') { |
|
82 | + return $txt['error_db_prefix_reserved']; |
|
83 | + } |
|
81 | 84 | |
82 | 85 | // Is the prefix numeric? |
83 | - if (preg_match('~^\d~', $value)) |
|
84 | - return $txt['error_db_prefix_numeric']; |
|
86 | + if (preg_match('~^\d~', $value)) { |
|
87 | + return $txt['error_db_prefix_numeric']; |
|
88 | + } |
|
85 | 89 | |
86 | 90 | return true; |
87 | 91 | }, |
@@ -128,10 +132,11 @@ discard block |
||
128 | 132 | $incontext['skip'] = false; |
129 | 133 | |
130 | 134 | // Call the step and if it returns false that means pause! |
131 | - if (function_exists($step[2]) && $step[2]() === false) |
|
132 | - break; |
|
133 | - elseif (function_exists($step[2])) |
|
134 | - $incontext['current_step']++; |
|
135 | + if (function_exists($step[2]) && $step[2]() === false) { |
|
136 | + break; |
|
137 | + } elseif (function_exists($step[2])) { |
|
138 | + $incontext['current_step']++; |
|
139 | + } |
|
135 | 140 | |
136 | 141 | // No warnings pass on. |
137 | 142 | $incontext['warning'] = ''; |
@@ -147,8 +152,9 @@ discard block |
||
147 | 152 | global $databases; |
148 | 153 | |
149 | 154 | // Just so people using older versions of PHP aren't left in the cold. |
150 | - if (!isset($_SERVER['PHP_SELF'])) |
|
151 | - $_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php'; |
|
155 | + if (!isset($_SERVER['PHP_SELF'])) { |
|
156 | + $_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php'; |
|
157 | + } |
|
152 | 158 | |
153 | 159 | // Enable error reporting. |
154 | 160 | error_reporting(E_ALL); |
@@ -164,21 +170,23 @@ discard block |
||
164 | 170 | { |
165 | 171 | ob_start(); |
166 | 172 | |
167 | - if (ini_get('session.save_handler') == 'user') |
|
168 | - @ini_set('session.save_handler', 'files'); |
|
169 | - if (function_exists('session_start')) |
|
170 | - @session_start(); |
|
171 | - } |
|
172 | - else |
|
173 | + if (ini_get('session.save_handler') == 'user') { |
|
174 | + @ini_set('session.save_handler', 'files'); |
|
175 | + } |
|
176 | + if (function_exists('session_start')) { |
|
177 | + @session_start(); |
|
178 | + } |
|
179 | + } else |
|
173 | 180 | { |
174 | 181 | ob_start('ob_gzhandler'); |
175 | 182 | |
176 | - if (ini_get('session.save_handler') == 'user') |
|
177 | - @ini_set('session.save_handler', 'files'); |
|
183 | + if (ini_get('session.save_handler') == 'user') { |
|
184 | + @ini_set('session.save_handler', 'files'); |
|
185 | + } |
|
178 | 186 | session_start(); |
179 | 187 | |
180 | - if (!headers_sent()) |
|
181 | - echo '<!DOCTYPE html> |
|
188 | + if (!headers_sent()) { |
|
189 | + echo '<!DOCTYPE html> |
|
182 | 190 | <html> |
183 | 191 | <head> |
184 | 192 | <title>', htmlspecialchars($_GET['pass_string']), '</title> |
@@ -187,14 +195,16 @@ discard block |
||
187 | 195 | <strong>', htmlspecialchars($_GET['pass_string']), '</strong> |
188 | 196 | </body> |
189 | 197 | </html>'; |
198 | + } |
|
190 | 199 | exit; |
191 | 200 | } |
192 | 201 | |
193 | 202 | // Add slashes, as long as they aren't already being added. |
194 | - if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) |
|
195 | - foreach ($_POST as $k => $v) |
|
203 | + if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) { |
|
204 | + foreach ($_POST as $k => $v) |
|
196 | 205 | if (strpos($k, 'password') === false && strpos($k, 'db_passwd') === false) |
197 | 206 | $_POST[$k] = addslashes($v); |
207 | + } |
|
198 | 208 | |
199 | 209 | // This is really quite simple; if ?delete is on the URL, delete the installer... |
200 | 210 | if (isset($_GET['delete'])) |
@@ -215,8 +225,7 @@ discard block |
||
215 | 225 | $ftp->close(); |
216 | 226 | |
217 | 227 | unset($_SESSION['installer_temp_ftp']); |
218 | - } |
|
219 | - else |
|
228 | + } else |
|
220 | 229 | { |
221 | 230 | @unlink(__FILE__); |
222 | 231 | |
@@ -237,10 +246,11 @@ discard block |
||
237 | 246 | { |
238 | 247 | // Get PHP's default timezone, if set |
239 | 248 | $ini_tz = ini_get('date.timezone'); |
240 | - if (!empty($ini_tz)) |
|
241 | - $timezone_id = $ini_tz; |
|
242 | - else |
|
243 | - $timezone_id = ''; |
|
249 | + if (!empty($ini_tz)) { |
|
250 | + $timezone_id = $ini_tz; |
|
251 | + } else { |
|
252 | + $timezone_id = ''; |
|
253 | + } |
|
244 | 254 | |
245 | 255 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
246 | 256 | if (!in_array($timezone_id, timezone_identifiers_list())) |
@@ -270,8 +280,9 @@ discard block |
||
270 | 280 | $dir = dir(dirname(__FILE__) . '/Themes/default/languages'); |
271 | 281 | while ($entry = $dir->read()) |
272 | 282 | { |
273 | - if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') |
|
274 | - $incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12)); |
|
283 | + if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') { |
|
284 | + $incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12)); |
|
285 | + } |
|
275 | 286 | } |
276 | 287 | $dir->close(); |
277 | 288 | } |
@@ -306,10 +317,11 @@ discard block |
||
306 | 317 | } |
307 | 318 | |
308 | 319 | // Override the language file? |
309 | - if (isset($_GET['lang_file'])) |
|
310 | - $_SESSION['installer_temp_lang'] = $_GET['lang_file']; |
|
311 | - elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) |
|
312 | - $_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file']; |
|
320 | + if (isset($_GET['lang_file'])) { |
|
321 | + $_SESSION['installer_temp_lang'] = $_GET['lang_file']; |
|
322 | + } elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) { |
|
323 | + $_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file']; |
|
324 | + } |
|
313 | 325 | |
314 | 326 | // Make sure it exists, if it doesn't reset it. |
315 | 327 | if (!isset($_SESSION['installer_temp_lang']) || preg_match('~[^\\w_\\-.]~', $_SESSION['installer_temp_lang']) === 1 || !file_exists(dirname(__FILE__) . '/Themes/default/languages/' . $_SESSION['installer_temp_lang'])) |
@@ -318,8 +330,9 @@ discard block |
||
318 | 330 | list ($_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
319 | 331 | |
320 | 332 | // If we have english and some other language, use the other language. We Americans hate english :P. |
321 | - if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) |
|
322 | - list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
|
333 | + if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) { |
|
334 | + list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
|
335 | + } |
|
323 | 336 | } |
324 | 337 | |
325 | 338 | // And now include the actual language file itself. |
@@ -332,15 +345,18 @@ discard block |
||
332 | 345 | global $db_prefix, $db_connection, $sourcedir, $smcFunc, $modSettings; |
333 | 346 | global $db_server, $db_passwd, $db_type, $db_name, $db_user, $db_persist; |
334 | 347 | |
335 | - if (empty($sourcedir)) |
|
336 | - $sourcedir = dirname(__FILE__) . '/Sources'; |
|
348 | + if (empty($sourcedir)) { |
|
349 | + $sourcedir = dirname(__FILE__) . '/Sources'; |
|
350 | + } |
|
337 | 351 | |
338 | 352 | // Need this to check whether we need the database password. |
339 | 353 | require(dirname(__FILE__) . '/Settings.php'); |
340 | - if (!defined('SMF')) |
|
341 | - define('SMF', 1); |
|
342 | - if (empty($smcFunc)) |
|
343 | - $smcFunc = array(); |
|
354 | + if (!defined('SMF')) { |
|
355 | + define('SMF', 1); |
|
356 | + } |
|
357 | + if (empty($smcFunc)) { |
|
358 | + $smcFunc = array(); |
|
359 | + } |
|
344 | 360 | |
345 | 361 | $modSettings['disableQueryCheck'] = true; |
346 | 362 | |
@@ -348,8 +364,9 @@ discard block |
||
348 | 364 | if (!$db_connection) |
349 | 365 | { |
350 | 366 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
351 | - if (version_compare(PHP_VERSION, '5', '<')) |
|
352 | - require_once($sourcedir . '/Subs-Compat.php'); |
|
367 | + if (version_compare(PHP_VERSION, '5', '<')) { |
|
368 | + require_once($sourcedir . '/Subs-Compat.php'); |
|
369 | + } |
|
353 | 370 | |
354 | 371 | $db_options = array('persist' => $db_persist); |
355 | 372 | $port = ''; |
@@ -360,19 +377,20 @@ discard block |
||
360 | 377 | if ($db_type == 'mysql') |
361 | 378 | { |
362 | 379 | $port = ((int) $_POST['db_port'] == ini_get($db_type . 'default_port')) ? '' : (int) $_POST['db_port']; |
363 | - } |
|
364 | - elseif ($db_type == 'postgresql') |
|
380 | + } elseif ($db_type == 'postgresql') |
|
365 | 381 | { |
366 | 382 | // PostgreSQL doesn't have a default port setting in php.ini, so just check against the default |
367 | 383 | $port = ((int) $_POST['db_port'] == 5432) ? '' : (int) $_POST['db_port']; |
368 | 384 | } |
369 | 385 | } |
370 | 386 | |
371 | - if (!empty($port)) |
|
372 | - $db_options['port'] = $port; |
|
387 | + if (!empty($port)) { |
|
388 | + $db_options['port'] = $port; |
|
389 | + } |
|
373 | 390 | |
374 | - if (!$db_connection) |
|
375 | - $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options); |
|
391 | + if (!$db_connection) { |
|
392 | + $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options); |
|
393 | + } |
|
376 | 394 | } |
377 | 395 | } |
378 | 396 | |
@@ -400,8 +418,9 @@ discard block |
||
400 | 418 | // @todo REMOVE THIS!! |
401 | 419 | else |
402 | 420 | { |
403 | - if (function_exists('doStep' . $_GET['step'])) |
|
404 | - call_user_func('doStep' . $_GET['step']); |
|
421 | + if (function_exists('doStep' . $_GET['step'])) { |
|
422 | + call_user_func('doStep' . $_GET['step']); |
|
423 | + } |
|
405 | 424 | } |
406 | 425 | // Show the footer. |
407 | 426 | template_install_below(); |
@@ -419,8 +438,9 @@ discard block |
||
419 | 438 | $incontext['sub_template'] = 'welcome_message'; |
420 | 439 | |
421 | 440 | // Done the submission? |
422 | - if (isset($_POST['contbutt'])) |
|
423 | - return true; |
|
441 | + if (isset($_POST['contbutt'])) { |
|
442 | + return true; |
|
443 | + } |
|
424 | 444 | |
425 | 445 | // See if we think they have already installed it? |
426 | 446 | if (is_readable(dirname(__FILE__) . '/Settings.php')) |
@@ -428,14 +448,17 @@ discard block |
||
428 | 448 | $probably_installed = 0; |
429 | 449 | foreach (file(dirname(__FILE__) . '/Settings.php') as $line) |
430 | 450 | { |
431 | - if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) |
|
432 | - $probably_installed++; |
|
433 | - if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) |
|
434 | - $probably_installed++; |
|
451 | + if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) { |
|
452 | + $probably_installed++; |
|
453 | + } |
|
454 | + if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) { |
|
455 | + $probably_installed++; |
|
456 | + } |
|
435 | 457 | } |
436 | 458 | |
437 | - if ($probably_installed == 2) |
|
438 | - $incontext['warning'] = $txt['error_already_installed']; |
|
459 | + if ($probably_installed == 2) { |
|
460 | + $incontext['warning'] = $txt['error_already_installed']; |
|
461 | + } |
|
439 | 462 | } |
440 | 463 | |
441 | 464 | // Is some database support even compiled in? |
@@ -450,45 +473,54 @@ discard block |
||
450 | 473 | $databases[$key]['supported'] = false; |
451 | 474 | $notFoundSQLFile = true; |
452 | 475 | $txt['error_db_script_missing'] = sprintf($txt['error_db_script_missing'], 'install_' . $GLOBALS['db_script_version'] . '_' . $type . '.sql'); |
476 | + } else { |
|
477 | + $incontext['supported_databases'][] = $db; |
|
453 | 478 | } |
454 | - else |
|
455 | - $incontext['supported_databases'][] = $db; |
|
456 | 479 | } |
457 | 480 | } |
458 | 481 | |
459 | 482 | // Check the PHP version. |
460 | - if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) |
|
461 | - $error = 'error_php_too_low'; |
|
483 | + if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) { |
|
484 | + $error = 'error_php_too_low'; |
|
485 | + } |
|
462 | 486 | // Make sure we have a supported database |
463 | - elseif (empty($incontext['supported_databases'])) |
|
464 | - $error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing'; |
|
487 | + elseif (empty($incontext['supported_databases'])) { |
|
488 | + $error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing'; |
|
489 | + } |
|
465 | 490 | // How about session support? Some crazy sysadmin remove it? |
466 | - elseif (!function_exists('session_start')) |
|
467 | - $error = 'error_session_missing'; |
|
491 | + elseif (!function_exists('session_start')) { |
|
492 | + $error = 'error_session_missing'; |
|
493 | + } |
|
468 | 494 | // Make sure they uploaded all the files. |
469 | - elseif (!file_exists(dirname(__FILE__) . '/index.php')) |
|
470 | - $error = 'error_missing_files'; |
|
495 | + elseif (!file_exists(dirname(__FILE__) . '/index.php')) { |
|
496 | + $error = 'error_missing_files'; |
|
497 | + } |
|
471 | 498 | // Very simple check on the session.save_path for Windows. |
472 | 499 | // @todo Move this down later if they don't use database-driven sessions? |
473 | - elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') |
|
474 | - $error = 'error_session_save_path'; |
|
500 | + elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') { |
|
501 | + $error = 'error_session_save_path'; |
|
502 | + } |
|
475 | 503 | |
476 | 504 | // Since each of the three messages would look the same, anyway... |
477 | - if (isset($error)) |
|
478 | - $incontext['error'] = $txt[$error]; |
|
505 | + if (isset($error)) { |
|
506 | + $incontext['error'] = $txt[$error]; |
|
507 | + } |
|
479 | 508 | |
480 | 509 | // Mod_security blocks everything that smells funny. Let SMF handle security. |
481 | - if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) |
|
482 | - $incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again']; |
|
510 | + if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) { |
|
511 | + $incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again']; |
|
512 | + } |
|
483 | 513 | |
484 | 514 | // Confirm mbstring is loaded... |
485 | - if (!extension_loaded('mbstring')) |
|
486 | - $incontext['error'] = $txt['install_no_mbstring']; |
|
515 | + if (!extension_loaded('mbstring')) { |
|
516 | + $incontext['error'] = $txt['install_no_mbstring']; |
|
517 | + } |
|
487 | 518 | |
488 | 519 | // Check for https stream support. |
489 | 520 | $supported_streams = stream_get_wrappers(); |
490 | - if (!in_array('https', $supported_streams)) |
|
491 | - $incontext['warning'] = $txt['install_no_https']; |
|
521 | + if (!in_array('https', $supported_streams)) { |
|
522 | + $incontext['warning'] = $txt['install_no_https']; |
|
523 | + } |
|
492 | 524 | |
493 | 525 | return false; |
494 | 526 | } |
@@ -514,12 +546,14 @@ discard block |
||
514 | 546 | 'db_last_error.php', |
515 | 547 | ); |
516 | 548 | |
517 | - foreach ($incontext['detected_languages'] as $lang => $temp) |
|
518 | - $extra_files[] = 'Themes/default/languages/' . $lang; |
|
549 | + foreach ($incontext['detected_languages'] as $lang => $temp) { |
|
550 | + $extra_files[] = 'Themes/default/languages/' . $lang; |
|
551 | + } |
|
519 | 552 | |
520 | 553 | // With mod_security installed, we could attempt to fix it with .htaccess. |
521 | - if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) |
|
522 | - $writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.'; |
|
554 | + if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) { |
|
555 | + $writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.'; |
|
556 | + } |
|
523 | 557 | |
524 | 558 | $failed_files = array(); |
525 | 559 | |
@@ -535,12 +569,14 @@ discard block |
||
535 | 569 | @chmod(dirname(__FILE__) . '/' . $file, 0755); |
536 | 570 | |
537 | 571 | // Well, 755 hopefully worked... if not, try 777. |
538 | - if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) |
|
539 | - $failed_files[] = $file; |
|
572 | + if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) { |
|
573 | + $failed_files[] = $file; |
|
574 | + } |
|
540 | 575 | } |
541 | 576 | } |
542 | - foreach ($extra_files as $file) |
|
543 | - @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
577 | + foreach ($extra_files as $file) { |
|
578 | + @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
579 | + } |
|
544 | 580 | } |
545 | 581 | // Windows is trickier. Let's try opening for r+... |
546 | 582 | else |
@@ -550,30 +586,35 @@ discard block |
||
550 | 586 | foreach ($writable_files as $file) |
551 | 587 | { |
552 | 588 | // Folders can't be opened for write... but the index.php in them can ;) |
553 | - if (is_dir(dirname(__FILE__) . '/' . $file)) |
|
554 | - $file .= '/index.php'; |
|
589 | + if (is_dir(dirname(__FILE__) . '/' . $file)) { |
|
590 | + $file .= '/index.php'; |
|
591 | + } |
|
555 | 592 | |
556 | 593 | // Funny enough, chmod actually does do something on windows - it removes the read only attribute. |
557 | 594 | @chmod(dirname(__FILE__) . '/' . $file, 0777); |
558 | 595 | $fp = @fopen(dirname(__FILE__) . '/' . $file, 'r+'); |
559 | 596 | |
560 | 597 | // Hmm, okay, try just for write in that case... |
561 | - if (!is_resource($fp)) |
|
562 | - $fp = @fopen(dirname(__FILE__) . '/' . $file, 'w'); |
|
598 | + if (!is_resource($fp)) { |
|
599 | + $fp = @fopen(dirname(__FILE__) . '/' . $file, 'w'); |
|
600 | + } |
|
563 | 601 | |
564 | - if (!is_resource($fp)) |
|
565 | - $failed_files[] = $file; |
|
602 | + if (!is_resource($fp)) { |
|
603 | + $failed_files[] = $file; |
|
604 | + } |
|
566 | 605 | |
567 | 606 | @fclose($fp); |
568 | 607 | } |
569 | - foreach ($extra_files as $file) |
|
570 | - @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
608 | + foreach ($extra_files as $file) { |
|
609 | + @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
610 | + } |
|
571 | 611 | } |
572 | 612 | |
573 | 613 | $failure = count($failed_files) >= 1; |
574 | 614 | |
575 | - if (!isset($_SERVER)) |
|
576 | - return !$failure; |
|
615 | + if (!isset($_SERVER)) { |
|
616 | + return !$failure; |
|
617 | + } |
|
577 | 618 | |
578 | 619 | // Put the list into context. |
579 | 620 | $incontext['failed_files'] = $failed_files; |
@@ -621,19 +662,23 @@ discard block |
||
621 | 662 | |
622 | 663 | if (!isset($ftp) || $ftp->error !== false) |
623 | 664 | { |
624 | - if (!isset($ftp)) |
|
625 | - $ftp = new ftp_connection(null); |
|
665 | + if (!isset($ftp)) { |
|
666 | + $ftp = new ftp_connection(null); |
|
667 | + } |
|
626 | 668 | // Save the error so we can mess with listing... |
627 | - elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) |
|
628 | - $incontext['ftp_errors'][] = $ftp->last_message; |
|
669 | + elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) { |
|
670 | + $incontext['ftp_errors'][] = $ftp->last_message; |
|
671 | + } |
|
629 | 672 | |
630 | 673 | list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__)); |
631 | 674 | |
632 | - if (empty($_POST['ftp_path']) && $found_path) |
|
633 | - $_POST['ftp_path'] = $detect_path; |
|
675 | + if (empty($_POST['ftp_path']) && $found_path) { |
|
676 | + $_POST['ftp_path'] = $detect_path; |
|
677 | + } |
|
634 | 678 | |
635 | - if (!isset($_POST['ftp_username'])) |
|
636 | - $_POST['ftp_username'] = $username; |
|
679 | + if (!isset($_POST['ftp_username'])) { |
|
680 | + $_POST['ftp_username'] = $username; |
|
681 | + } |
|
637 | 682 | |
638 | 683 | // Set the username etc, into context. |
639 | 684 | $incontext['ftp'] = array( |
@@ -645,8 +690,7 @@ discard block |
||
645 | 690 | ); |
646 | 691 | |
647 | 692 | return false; |
648 | - } |
|
649 | - else |
|
693 | + } else |
|
650 | 694 | { |
651 | 695 | $_SESSION['installer_temp_ftp'] = array( |
652 | 696 | 'server' => $_POST['ftp_server'], |
@@ -660,10 +704,12 @@ discard block |
||
660 | 704 | |
661 | 705 | foreach ($failed_files as $file) |
662 | 706 | { |
663 | - if (!is_writable(dirname(__FILE__) . '/' . $file)) |
|
664 | - $ftp->chmod($file, 0755); |
|
665 | - if (!is_writable(dirname(__FILE__) . '/' . $file)) |
|
666 | - $ftp->chmod($file, 0777); |
|
707 | + if (!is_writable(dirname(__FILE__) . '/' . $file)) { |
|
708 | + $ftp->chmod($file, 0755); |
|
709 | + } |
|
710 | + if (!is_writable(dirname(__FILE__) . '/' . $file)) { |
|
711 | + $ftp->chmod($file, 0777); |
|
712 | + } |
|
667 | 713 | if (!is_writable(dirname(__FILE__) . '/' . $file)) |
668 | 714 | { |
669 | 715 | $failed_files_updated[] = $file; |
@@ -719,15 +765,17 @@ discard block |
||
719 | 765 | |
720 | 766 | if (!$foundOne) |
721 | 767 | { |
722 | - if (isset($db['default_host'])) |
|
723 | - $incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost'; |
|
768 | + if (isset($db['default_host'])) { |
|
769 | + $incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost'; |
|
770 | + } |
|
724 | 771 | if (isset($db['default_user'])) |
725 | 772 | { |
726 | 773 | $incontext['db']['user'] = ini_get($db['default_user']); |
727 | 774 | $incontext['db']['name'] = ini_get($db['default_user']); |
728 | 775 | } |
729 | - if (isset($db['default_password'])) |
|
730 | - $incontext['db']['pass'] = ini_get($db['default_password']); |
|
776 | + if (isset($db['default_password'])) { |
|
777 | + $incontext['db']['pass'] = ini_get($db['default_password']); |
|
778 | + } |
|
731 | 779 | |
732 | 780 | // For simplicity and less confusion, leave the port blank by default |
733 | 781 | $incontext['db']['port'] = ''; |
@@ -746,10 +794,10 @@ discard block |
||
746 | 794 | $incontext['db']['server'] = $_POST['db_server']; |
747 | 795 | $incontext['db']['prefix'] = $_POST['db_prefix']; |
748 | 796 | |
749 | - if (!empty($_POST['db_port'])) |
|
750 | - $incontext['db']['port'] = $_POST['db_port']; |
|
751 | - } |
|
752 | - else |
|
797 | + if (!empty($_POST['db_port'])) { |
|
798 | + $incontext['db']['port'] = $_POST['db_port']; |
|
799 | + } |
|
800 | + } else |
|
753 | 801 | { |
754 | 802 | $incontext['db']['prefix'] = 'smf_'; |
755 | 803 | } |
@@ -785,10 +833,11 @@ discard block |
||
785 | 833 | if (!empty($_POST['db_port'])) |
786 | 834 | { |
787 | 835 | // For MySQL, we can get the "default port" from PHP. PostgreSQL has no such option though. |
788 | - if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) |
|
789 | - $vars['db_port'] = (int) $_POST['db_port']; |
|
790 | - elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) |
|
791 | - $vars['db_port'] = (int) $_POST['db_port']; |
|
836 | + if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) { |
|
837 | + $vars['db_port'] = (int) $_POST['db_port']; |
|
838 | + } elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) { |
|
839 | + $vars['db_port'] = (int) $_POST['db_port']; |
|
840 | + } |
|
792 | 841 | } |
793 | 842 | |
794 | 843 | // God I hope it saved! |
@@ -801,8 +850,9 @@ discard block |
||
801 | 850 | // Make sure it works. |
802 | 851 | require(dirname(__FILE__) . '/Settings.php'); |
803 | 852 | |
804 | - if (empty($sourcedir)) |
|
805 | - $sourcedir = dirname(__FILE__) . '/Sources'; |
|
853 | + if (empty($sourcedir)) { |
|
854 | + $sourcedir = dirname(__FILE__) . '/Sources'; |
|
855 | + } |
|
806 | 856 | |
807 | 857 | // Better find the database file! |
808 | 858 | if (!file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
@@ -812,18 +862,21 @@ discard block |
||
812 | 862 | } |
813 | 863 | |
814 | 864 | // Now include it for database functions! |
815 | - if (!defined('SMF')) |
|
816 | - define('SMF', 1); |
|
865 | + if (!defined('SMF')) { |
|
866 | + define('SMF', 1); |
|
867 | + } |
|
817 | 868 | |
818 | 869 | $modSettings['disableQueryCheck'] = true; |
819 | - if (empty($smcFunc)) |
|
820 | - $smcFunc = array(); |
|
870 | + if (empty($smcFunc)) { |
|
871 | + $smcFunc = array(); |
|
872 | + } |
|
821 | 873 | |
822 | 874 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
823 | 875 | |
824 | 876 | // What - running PHP4? The shame! |
825 | - if (version_compare(PHP_VERSION, '5', '<')) |
|
826 | - require_once($sourcedir . '/Subs-Compat.php'); |
|
877 | + if (version_compare(PHP_VERSION, '5', '<')) { |
|
878 | + require_once($sourcedir . '/Subs-Compat.php'); |
|
879 | + } |
|
827 | 880 | |
828 | 881 | // Attempt a connection. |
829 | 882 | $needsDB = !empty($databases[$db_type]['always_has_db']); |
@@ -911,12 +964,14 @@ discard block |
||
911 | 964 | $incontext['page_title'] = $txt['install_settings']; |
912 | 965 | |
913 | 966 | // Let's see if we got the database type correct. |
914 | - if (isset($_POST['db_type'], $databases[$_POST['db_type']])) |
|
915 | - $db_type = $_POST['db_type']; |
|
967 | + if (isset($_POST['db_type'], $databases[$_POST['db_type']])) { |
|
968 | + $db_type = $_POST['db_type']; |
|
969 | + } |
|
916 | 970 | |
917 | 971 | // Else we'd better be able to get the connection. |
918 | - else |
|
919 | - load_database(); |
|
972 | + else { |
|
973 | + load_database(); |
|
974 | + } |
|
920 | 975 | |
921 | 976 | $db_type = isset($_POST['db_type']) ? $_POST['db_type'] : $db_type; |
922 | 977 | |
@@ -936,12 +991,14 @@ discard block |
||
936 | 991 | // Submitting? |
937 | 992 | if (isset($_POST['boardurl'])) |
938 | 993 | { |
939 | - if (substr($_POST['boardurl'], -10) == '/index.php') |
|
940 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
941 | - elseif (substr($_POST['boardurl'], -1) == '/') |
|
942 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
943 | - if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') |
|
944 | - $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
994 | + if (substr($_POST['boardurl'], -10) == '/index.php') { |
|
995 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
996 | + } elseif (substr($_POST['boardurl'], -1) == '/') { |
|
997 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
998 | + } |
|
999 | + if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') { |
|
1000 | + $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
1001 | + } |
|
945 | 1002 | |
946 | 1003 | // Save these variables. |
947 | 1004 | $vars = array( |
@@ -980,10 +1037,10 @@ discard block |
||
980 | 1037 | { |
981 | 1038 | $incontext['error'] = sprintf($txt['error_utf8_version'], $databases[$db_type]['utf8_version']); |
982 | 1039 | return false; |
983 | - } |
|
984 | - else |
|
985 | - // Set the character set here. |
|
1040 | + } else { |
|
1041 | + // Set the character set here. |
|
986 | 1042 | updateSettingsFile(array('db_character_set' => 'utf8')); |
1043 | + } |
|
987 | 1044 | } |
988 | 1045 | |
989 | 1046 | // Good, skip on. |
@@ -1003,8 +1060,9 @@ discard block |
||
1003 | 1060 | $incontext['continue'] = 1; |
1004 | 1061 | |
1005 | 1062 | // Already done? |
1006 | - if (isset($_POST['pop_done'])) |
|
1007 | - return true; |
|
1063 | + if (isset($_POST['pop_done'])) { |
|
1064 | + return true; |
|
1065 | + } |
|
1008 | 1066 | |
1009 | 1067 | // Reload settings. |
1010 | 1068 | require(dirname(__FILE__) . '/Settings.php'); |
@@ -1022,8 +1080,9 @@ discard block |
||
1022 | 1080 | $modSettings = array(); |
1023 | 1081 | if ($result !== false) |
1024 | 1082 | { |
1025 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
1026 | - $modSettings[$row['variable']] = $row['value']; |
|
1083 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
1084 | + $modSettings[$row['variable']] = $row['value']; |
|
1085 | + } |
|
1027 | 1086 | $smcFunc['db_free_result']($result); |
1028 | 1087 | |
1029 | 1088 | // Do they match? If so, this is just a refresh so charge on! |
@@ -1036,20 +1095,22 @@ discard block |
||
1036 | 1095 | $modSettings['disableQueryCheck'] = true; |
1037 | 1096 | |
1038 | 1097 | // If doing UTF8, select it. PostgreSQL requires passing it as a string... |
1039 | - if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) |
|
1040 | - $smcFunc['db_query']('', ' |
|
1098 | + if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) { |
|
1099 | + $smcFunc['db_query']('', ' |
|
1041 | 1100 | SET NAMES {string:utf8}', |
1042 | 1101 | array( |
1043 | 1102 | 'db_error_skip' => true, |
1044 | 1103 | 'utf8' => 'utf8', |
1045 | 1104 | ) |
1046 | 1105 | ); |
1106 | + } |
|
1047 | 1107 | |
1048 | 1108 | // Windows likes to leave the trailing slash, which yields to C:\path\to\SMF\/attachments... |
1049 | - if (substr(__DIR__, -1) == '\\') |
|
1050 | - $attachdir = __DIR__ . 'attachments'; |
|
1051 | - else |
|
1052 | - $attachdir = __DIR__ . '/attachments'; |
|
1109 | + if (substr(__DIR__, -1) == '\\') { |
|
1110 | + $attachdir = __DIR__ . 'attachments'; |
|
1111 | + } else { |
|
1112 | + $attachdir = __DIR__ . '/attachments'; |
|
1113 | + } |
|
1053 | 1114 | |
1054 | 1115 | $replaces = array( |
1055 | 1116 | '{$db_prefix}' => $db_prefix, |
@@ -1066,8 +1127,9 @@ discard block |
||
1066 | 1127 | |
1067 | 1128 | foreach ($txt as $key => $value) |
1068 | 1129 | { |
1069 | - if (substr($key, 0, 8) == 'default_') |
|
1070 | - $replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value); |
|
1130 | + if (substr($key, 0, 8) == 'default_') { |
|
1131 | + $replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value); |
|
1132 | + } |
|
1071 | 1133 | } |
1072 | 1134 | $replaces['{$default_reserved_names}'] = strtr($replaces['{$default_reserved_names}'], array('\\\\n' => '\\n')); |
1073 | 1135 | |
@@ -1082,8 +1144,9 @@ discard block |
||
1082 | 1144 | |
1083 | 1145 | while ($row = $smcFunc['db_fetch_assoc']($get_engines)) |
1084 | 1146 | { |
1085 | - if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') |
|
1086 | - $engines[] = $row['Engine']; |
|
1147 | + if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') { |
|
1148 | + $engines[] = $row['Engine']; |
|
1149 | + } |
|
1087 | 1150 | } |
1088 | 1151 | |
1089 | 1152 | // Done with this now |
@@ -1107,8 +1170,7 @@ discard block |
||
1107 | 1170 | $replaces['START TRANSACTION;'] = ''; |
1108 | 1171 | $replaces['COMMIT;'] = ''; |
1109 | 1172 | } |
1110 | - } |
|
1111 | - else |
|
1173 | + } else |
|
1112 | 1174 | { |
1113 | 1175 | $has_innodb = false; |
1114 | 1176 | } |
@@ -1130,21 +1192,24 @@ discard block |
||
1130 | 1192 | foreach ($sql_lines as $count => $line) |
1131 | 1193 | { |
1132 | 1194 | // No comments allowed! |
1133 | - if (substr(trim($line), 0, 1) != '#') |
|
1134 | - $current_statement .= "\n" . rtrim($line); |
|
1195 | + if (substr(trim($line), 0, 1) != '#') { |
|
1196 | + $current_statement .= "\n" . rtrim($line); |
|
1197 | + } |
|
1135 | 1198 | |
1136 | 1199 | // Is this the end of the query string? |
1137 | - if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) |
|
1138 | - continue; |
|
1200 | + if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) { |
|
1201 | + continue; |
|
1202 | + } |
|
1139 | 1203 | |
1140 | 1204 | // Does this table already exist? If so, don't insert more data into it! |
1141 | 1205 | if (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) != 0 && in_array($match[1], $exists)) |
1142 | 1206 | { |
1143 | 1207 | preg_match_all('~\)[,;]~', $current_statement, $matches); |
1144 | - if (!empty($matches[0])) |
|
1145 | - $incontext['sql_results']['insert_dups'] += count($matches[0]); |
|
1146 | - else |
|
1147 | - $incontext['sql_results']['insert_dups']++; |
|
1208 | + if (!empty($matches[0])) { |
|
1209 | + $incontext['sql_results']['insert_dups'] += count($matches[0]); |
|
1210 | + } else { |
|
1211 | + $incontext['sql_results']['insert_dups']++; |
|
1212 | + } |
|
1148 | 1213 | |
1149 | 1214 | $current_statement = ''; |
1150 | 1215 | continue; |
@@ -1153,8 +1218,9 @@ discard block |
||
1153 | 1218 | if ($smcFunc['db_query']('', $current_statement, array('security_override' => true, 'db_error_skip' => true), $db_connection) === false) |
1154 | 1219 | { |
1155 | 1220 | // Use the appropriate function based on the DB type |
1156 | - if ($db_type == 'mysql' || $db_type == 'mysqli') |
|
1157 | - $db_errorno = $db_type . '_errno'; |
|
1221 | + if ($db_type == 'mysql' || $db_type == 'mysqli') { |
|
1222 | + $db_errorno = $db_type . '_errno'; |
|
1223 | + } |
|
1158 | 1224 | |
1159 | 1225 | // Error 1050: Table already exists! |
1160 | 1226 | // @todo Needs to be made better! |
@@ -1169,18 +1235,18 @@ discard block |
||
1169 | 1235 | // MySQLi requires a connection object. It's optional with MySQL and Postgres |
1170 | 1236 | $incontext['failures'][$count] = $smcFunc['db_error']($db_connection); |
1171 | 1237 | } |
1172 | - } |
|
1173 | - else |
|
1238 | + } else |
|
1174 | 1239 | { |
1175 | - if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
1176 | - $incontext['sql_results']['tables']++; |
|
1177 | - elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
1240 | + if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) { |
|
1241 | + $incontext['sql_results']['tables']++; |
|
1242 | + } elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
1178 | 1243 | { |
1179 | 1244 | preg_match_all('~\)[,;]~', $current_statement, $matches); |
1180 | - if (!empty($matches[0])) |
|
1181 | - $incontext['sql_results']['inserts'] += count($matches[0]); |
|
1182 | - else |
|
1183 | - $incontext['sql_results']['inserts']++; |
|
1245 | + if (!empty($matches[0])) { |
|
1246 | + $incontext['sql_results']['inserts'] += count($matches[0]); |
|
1247 | + } else { |
|
1248 | + $incontext['sql_results']['inserts']++; |
|
1249 | + } |
|
1184 | 1250 | } |
1185 | 1251 | } |
1186 | 1252 | |
@@ -1193,15 +1259,17 @@ discard block |
||
1193 | 1259 | // Sort out the context for the SQL. |
1194 | 1260 | foreach ($incontext['sql_results'] as $key => $number) |
1195 | 1261 | { |
1196 | - if ($number == 0) |
|
1197 | - unset($incontext['sql_results'][$key]); |
|
1198 | - else |
|
1199 | - $incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number); |
|
1262 | + if ($number == 0) { |
|
1263 | + unset($incontext['sql_results'][$key]); |
|
1264 | + } else { |
|
1265 | + $incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number); |
|
1266 | + } |
|
1200 | 1267 | } |
1201 | 1268 | |
1202 | 1269 | // Make sure UTF will be used globally. |
1203 | - if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) |
|
1204 | - $newSettings[] = array('global_character_set', 'UTF-8'); |
|
1270 | + if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) { |
|
1271 | + $newSettings[] = array('global_character_set', 'UTF-8'); |
|
1272 | + } |
|
1205 | 1273 | |
1206 | 1274 | // Maybe we can auto-detect better cookie settings? |
1207 | 1275 | preg_match('~^http[s]?://([^\.]+?)([^/]*?)(/.*)?$~', $boardurl, $matches); |
@@ -1212,16 +1280,20 @@ discard block |
||
1212 | 1280 | $globalCookies = false; |
1213 | 1281 | |
1214 | 1282 | // Okay... let's see. Using a subdomain other than www.? (not a perfect check.) |
1215 | - if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www')))) |
|
1216 | - $globalCookies = true; |
|
1283 | + if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www')))) { |
|
1284 | + $globalCookies = true; |
|
1285 | + } |
|
1217 | 1286 | // If there's a / in the middle of the path, or it starts with ~... we want local. |
1218 | - if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false)) |
|
1219 | - $localCookies = true; |
|
1287 | + if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false)) { |
|
1288 | + $localCookies = true; |
|
1289 | + } |
|
1220 | 1290 | |
1221 | - if ($globalCookies) |
|
1222 | - $newSettings[] = array('globalCookies', '1'); |
|
1223 | - if ($localCookies) |
|
1224 | - $newSettings[] = array('localCookies', '1'); |
|
1291 | + if ($globalCookies) { |
|
1292 | + $newSettings[] = array('globalCookies', '1'); |
|
1293 | + } |
|
1294 | + if ($localCookies) { |
|
1295 | + $newSettings[] = array('localCookies', '1'); |
|
1296 | + } |
|
1225 | 1297 | } |
1226 | 1298 | |
1227 | 1299 | // Are we allowing stat collection? |
@@ -1239,16 +1311,17 @@ discard block |
||
1239 | 1311 | fwrite($fp, $out); |
1240 | 1312 | |
1241 | 1313 | $return_data = ''; |
1242 | - while (!feof($fp)) |
|
1243 | - $return_data .= fgets($fp, 128); |
|
1314 | + while (!feof($fp)) { |
|
1315 | + $return_data .= fgets($fp, 128); |
|
1316 | + } |
|
1244 | 1317 | |
1245 | 1318 | fclose($fp); |
1246 | 1319 | |
1247 | 1320 | // Get the unique site ID. |
1248 | 1321 | preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID); |
1249 | 1322 | |
1250 | - if (!empty($ID[1])) |
|
1251 | - $smcFunc['db_insert']('replace', |
|
1323 | + if (!empty($ID[1])) { |
|
1324 | + $smcFunc['db_insert']('replace', |
|
1252 | 1325 | $db_prefix . 'settings', |
1253 | 1326 | array('variable' => 'string', 'value' => 'string'), |
1254 | 1327 | array( |
@@ -1257,11 +1330,12 @@ discard block |
||
1257 | 1330 | ), |
1258 | 1331 | array('variable') |
1259 | 1332 | ); |
1333 | + } |
|
1260 | 1334 | } |
1261 | 1335 | } |
1262 | 1336 | // Don't remove stat collection unless we unchecked the box for real, not from the loop. |
1263 | - elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) |
|
1264 | - $smcFunc['db_query']('', ' |
|
1337 | + elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) { |
|
1338 | + $smcFunc['db_query']('', ' |
|
1265 | 1339 | DELETE FROM {db_prefix}settings |
1266 | 1340 | WHERE variable = {string:enable_sm_stats}', |
1267 | 1341 | array( |
@@ -1269,20 +1343,23 @@ discard block |
||
1269 | 1343 | 'db_error_skip' => true, |
1270 | 1344 | ) |
1271 | 1345 | ); |
1346 | + } |
|
1272 | 1347 | |
1273 | 1348 | // Are we enabling SSL? |
1274 | - if (!empty($_POST['force_ssl'])) |
|
1275 | - $newSettings[] = array('force_ssl', 2); |
|
1349 | + if (!empty($_POST['force_ssl'])) { |
|
1350 | + $newSettings[] = array('force_ssl', 2); |
|
1351 | + } |
|
1276 | 1352 | |
1277 | 1353 | // Setting a timezone is required. |
1278 | 1354 | if (!isset($modSettings['default_timezone']) && function_exists('date_default_timezone_set')) |
1279 | 1355 | { |
1280 | 1356 | // Get PHP's default timezone, if set |
1281 | 1357 | $ini_tz = ini_get('date.timezone'); |
1282 | - if (!empty($ini_tz)) |
|
1283 | - $timezone_id = $ini_tz; |
|
1284 | - else |
|
1285 | - $timezone_id = ''; |
|
1358 | + if (!empty($ini_tz)) { |
|
1359 | + $timezone_id = $ini_tz; |
|
1360 | + } else { |
|
1361 | + $timezone_id = ''; |
|
1362 | + } |
|
1286 | 1363 | |
1287 | 1364 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
1288 | 1365 | if (!in_array($timezone_id, timezone_identifiers_list())) |
@@ -1291,8 +1368,9 @@ discard block |
||
1291 | 1368 | $timezone_id = timezone_name_from_abbr('', $server_offset, 0); |
1292 | 1369 | } |
1293 | 1370 | |
1294 | - if (date_default_timezone_set($timezone_id)) |
|
1295 | - $newSettings[] = array('default_timezone', $timezone_id); |
|
1371 | + if (date_default_timezone_set($timezone_id)) { |
|
1372 | + $newSettings[] = array('default_timezone', $timezone_id); |
|
1373 | + } |
|
1296 | 1374 | } |
1297 | 1375 | |
1298 | 1376 | if (!empty($newSettings)) |
@@ -1323,16 +1401,18 @@ discard block |
||
1323 | 1401 | } |
1324 | 1402 | |
1325 | 1403 | // MySQL specific stuff |
1326 | - if (substr($db_type, 0, 5) != 'mysql') |
|
1327 | - return false; |
|
1404 | + if (substr($db_type, 0, 5) != 'mysql') { |
|
1405 | + return false; |
|
1406 | + } |
|
1328 | 1407 | |
1329 | 1408 | // Find database user privileges. |
1330 | 1409 | $privs = array(); |
1331 | 1410 | $get_privs = $smcFunc['db_query']('', 'SHOW PRIVILEGES', array()); |
1332 | 1411 | while ($row = $smcFunc['db_fetch_assoc']($get_privs)) |
1333 | 1412 | { |
1334 | - if ($row['Privilege'] == 'Alter') |
|
1335 | - $privs[] = $row['Privilege']; |
|
1413 | + if ($row['Privilege'] == 'Alter') { |
|
1414 | + $privs[] = $row['Privilege']; |
|
1415 | + } |
|
1336 | 1416 | } |
1337 | 1417 | $smcFunc['db_free_result']($get_privs); |
1338 | 1418 | |
@@ -1362,8 +1442,9 @@ discard block |
||
1362 | 1442 | $incontext['continue'] = 1; |
1363 | 1443 | |
1364 | 1444 | // Skipping? |
1365 | - if (!empty($_POST['skip'])) |
|
1366 | - return true; |
|
1445 | + if (!empty($_POST['skip'])) { |
|
1446 | + return true; |
|
1447 | + } |
|
1367 | 1448 | |
1368 | 1449 | // Need this to check whether we need the database password. |
1369 | 1450 | require(dirname(__FILE__) . '/Settings.php'); |
@@ -1380,18 +1461,22 @@ discard block |
||
1380 | 1461 | // We need this to properly hash the password for Admin |
1381 | 1462 | $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) { |
1382 | 1463 | global $sourcedir; |
1383 | - if (function_exists('mb_strtolower')) |
|
1384 | - return mb_strtolower($string, 'UTF-8'); |
|
1464 | + if (function_exists('mb_strtolower')) { |
|
1465 | + return mb_strtolower($string, 'UTF-8'); |
|
1466 | + } |
|
1385 | 1467 | require_once($sourcedir . '/Subs-Charset.php'); |
1386 | 1468 | return utf8_strtolower($string); |
1387 | 1469 | }; |
1388 | 1470 | |
1389 | - if (!isset($_POST['username'])) |
|
1390 | - $_POST['username'] = ''; |
|
1391 | - if (!isset($_POST['email'])) |
|
1392 | - $_POST['email'] = ''; |
|
1393 | - if (!isset($_POST['server_email'])) |
|
1394 | - $_POST['server_email'] = ''; |
|
1471 | + if (!isset($_POST['username'])) { |
|
1472 | + $_POST['username'] = ''; |
|
1473 | + } |
|
1474 | + if (!isset($_POST['email'])) { |
|
1475 | + $_POST['email'] = ''; |
|
1476 | + } |
|
1477 | + if (!isset($_POST['server_email'])) { |
|
1478 | + $_POST['server_email'] = ''; |
|
1479 | + } |
|
1395 | 1480 | |
1396 | 1481 | $incontext['username'] = htmlspecialchars(stripslashes($_POST['username'])); |
1397 | 1482 | $incontext['email'] = htmlspecialchars(stripslashes($_POST['email'])); |
@@ -1410,8 +1495,9 @@ discard block |
||
1410 | 1495 | 'admin_group' => 1, |
1411 | 1496 | ) |
1412 | 1497 | ); |
1413 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
1414 | - $incontext['skip'] = 1; |
|
1498 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
1499 | + $incontext['skip'] = 1; |
|
1500 | + } |
|
1415 | 1501 | $smcFunc['db_free_result']($request); |
1416 | 1502 | |
1417 | 1503 | // Trying to create an account? |
@@ -1442,8 +1528,9 @@ discard block |
||
1442 | 1528 | } |
1443 | 1529 | |
1444 | 1530 | // Update the webmaster's email? |
1445 | - if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) |
|
1446 | - updateSettingsFile(array('webmaster_email' => $_POST['server_email'])); |
|
1531 | + if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) { |
|
1532 | + updateSettingsFile(array('webmaster_email' => $_POST['server_email'])); |
|
1533 | + } |
|
1447 | 1534 | |
1448 | 1535 | // Work out whether we're going to have dodgy characters and remove them. |
1449 | 1536 | $invalid_characters = preg_match('~[<>&"\'=\\\]~', $_POST['username']) != 0; |
@@ -1466,32 +1553,27 @@ discard block |
||
1466 | 1553 | $smcFunc['db_free_result']($result); |
1467 | 1554 | |
1468 | 1555 | $incontext['account_existed'] = $txt['error_user_settings_taken']; |
1469 | - } |
|
1470 | - elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25) |
|
1556 | + } elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25) |
|
1471 | 1557 | { |
1472 | 1558 | // Try the previous step again. |
1473 | 1559 | $incontext['error'] = $_POST['username'] == '' ? $txt['error_username_left_empty'] : $txt['error_username_too_long']; |
1474 | 1560 | return false; |
1475 | - } |
|
1476 | - elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false) |
|
1561 | + } elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false) |
|
1477 | 1562 | { |
1478 | 1563 | // Try the previous step again. |
1479 | 1564 | $incontext['error'] = $txt['error_invalid_characters_username']; |
1480 | 1565 | return false; |
1481 | - } |
|
1482 | - elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255) |
|
1566 | + } elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255) |
|
1483 | 1567 | { |
1484 | 1568 | // One step back, this time fill out a proper admin email address. |
1485 | 1569 | $incontext['error'] = sprintf($txt['error_valid_admin_email_needed'], $_POST['username']); |
1486 | 1570 | return false; |
1487 | - } |
|
1488 | - elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255) |
|
1571 | + } elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255) |
|
1489 | 1572 | { |
1490 | 1573 | // One step back, this time fill out a proper admin email address. |
1491 | 1574 | $incontext['error'] = $txt['error_valid_server_email_needed']; |
1492 | 1575 | return false; |
1493 | - } |
|
1494 | - elseif ($_POST['username'] != '') |
|
1576 | + } elseif ($_POST['username'] != '') |
|
1495 | 1577 | { |
1496 | 1578 | $incontext['member_salt'] = substr(md5(mt_rand()), 0, 4); |
1497 | 1579 | |
@@ -1559,17 +1641,19 @@ discard block |
||
1559 | 1641 | reloadSettings(); |
1560 | 1642 | |
1561 | 1643 | // Bring a warning over. |
1562 | - if (!empty($incontext['account_existed'])) |
|
1563 | - $incontext['warning'] = $incontext['account_existed']; |
|
1644 | + if (!empty($incontext['account_existed'])) { |
|
1645 | + $incontext['warning'] = $incontext['account_existed']; |
|
1646 | + } |
|
1564 | 1647 | |
1565 | - if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) |
|
1566 | - $smcFunc['db_query']('', ' |
|
1648 | + if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) { |
|
1649 | + $smcFunc['db_query']('', ' |
|
1567 | 1650 | SET NAMES {string:db_character_set}', |
1568 | 1651 | array( |
1569 | 1652 | 'db_character_set' => $db_character_set, |
1570 | 1653 | 'db_error_skip' => true, |
1571 | 1654 | ) |
1572 | 1655 | ); |
1656 | + } |
|
1573 | 1657 | |
1574 | 1658 | // As track stats is by default enabled let's add some activity. |
1575 | 1659 | $smcFunc['db_insert']('ignore', |
@@ -1590,14 +1674,16 @@ discard block |
||
1590 | 1674 | // Only proceed if we can load the data. |
1591 | 1675 | if ($request) |
1592 | 1676 | { |
1593 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
1594 | - $modSettings[$row[0]] = $row[1]; |
|
1677 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
1678 | + $modSettings[$row[0]] = $row[1]; |
|
1679 | + } |
|
1595 | 1680 | $smcFunc['db_free_result']($request); |
1596 | 1681 | } |
1597 | 1682 | |
1598 | 1683 | // Automatically log them in ;) |
1599 | - if (isset($incontext['member_id']) && isset($incontext['member_salt'])) |
|
1600 | - setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt'])); |
|
1684 | + if (isset($incontext['member_id']) && isset($incontext['member_salt'])) { |
|
1685 | + setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt'])); |
|
1686 | + } |
|
1601 | 1687 | |
1602 | 1688 | $result = $smcFunc['db_query']('', ' |
1603 | 1689 | SELECT value |
@@ -1608,13 +1694,14 @@ discard block |
||
1608 | 1694 | 'db_error_skip' => true, |
1609 | 1695 | ) |
1610 | 1696 | ); |
1611 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
1612 | - list ($db_sessions) = $smcFunc['db_fetch_row']($result); |
|
1697 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
1698 | + list ($db_sessions) = $smcFunc['db_fetch_row']($result); |
|
1699 | + } |
|
1613 | 1700 | $smcFunc['db_free_result']($result); |
1614 | 1701 | |
1615 | - if (empty($db_sessions)) |
|
1616 | - $_SESSION['admin_time'] = time(); |
|
1617 | - else |
|
1702 | + if (empty($db_sessions)) { |
|
1703 | + $_SESSION['admin_time'] = time(); |
|
1704 | + } else |
|
1618 | 1705 | { |
1619 | 1706 | $_SERVER['HTTP_USER_AGENT'] = substr($_SERVER['HTTP_USER_AGENT'], 0, 211); |
1620 | 1707 | |
@@ -1638,8 +1725,9 @@ discard block |
||
1638 | 1725 | $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : |
1639 | 1726 | function($string){ |
1640 | 1727 | global $sourcedir; |
1641 | - if (function_exists('mb_strtolower')) |
|
1642 | - return mb_strtolower($string, 'UTF-8'); |
|
1728 | + if (function_exists('mb_strtolower')) { |
|
1729 | + return mb_strtolower($string, 'UTF-8'); |
|
1730 | + } |
|
1643 | 1731 | require_once($sourcedir . '/Subs-Charset.php'); |
1644 | 1732 | return utf8_strtolower($string); |
1645 | 1733 | }; |
@@ -1655,8 +1743,9 @@ discard block |
||
1655 | 1743 | ) |
1656 | 1744 | ); |
1657 | 1745 | $context['utf8'] = $db_character_set === 'utf8' || $txt['lang_character_set'] === 'UTF-8'; |
1658 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
1659 | - updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject'])); |
|
1746 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
1747 | + updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject'])); |
|
1748 | + } |
|
1660 | 1749 | $smcFunc['db_free_result']($request); |
1661 | 1750 | |
1662 | 1751 | // Now is the perfect time to fetch the SM files. |
@@ -1675,8 +1764,9 @@ discard block |
||
1675 | 1764 | |
1676 | 1765 | // Check if we need some stupid MySQL fix. |
1677 | 1766 | $server_version = $smcFunc['db_server_info'](); |
1678 | - if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) |
|
1679 | - updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
1767 | + if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) { |
|
1768 | + updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
1769 | + } |
|
1680 | 1770 | |
1681 | 1771 | // Some final context for the template. |
1682 | 1772 | $incontext['dir_still_writable'] = is_writable(dirname(__FILE__)) && substr(__FILE__, 1, 2) != ':\\'; |
@@ -1696,8 +1786,9 @@ discard block |
||
1696 | 1786 | $settingsArray = file(dirname(__FILE__) . '/Settings.php'); |
1697 | 1787 | |
1698 | 1788 | // @todo Do we just want to read the file in clean, and split it this way always? |
1699 | - if (count($settingsArray) == 1) |
|
1700 | - $settingsArray = preg_split('~[\r\n]~', $settingsArray[0]); |
|
1789 | + if (count($settingsArray) == 1) { |
|
1790 | + $settingsArray = preg_split('~[\r\n]~', $settingsArray[0]); |
|
1791 | + } |
|
1701 | 1792 | |
1702 | 1793 | for ($i = 0, $n = count($settingsArray); $i < $n; $i++) |
1703 | 1794 | { |
@@ -1712,19 +1803,22 @@ discard block |
||
1712 | 1803 | continue; |
1713 | 1804 | } |
1714 | 1805 | |
1715 | - if (trim($settingsArray[$i]) == '?' . '>') |
|
1716 | - $settingsArray[$i] = ''; |
|
1806 | + if (trim($settingsArray[$i]) == '?' . '>') { |
|
1807 | + $settingsArray[$i] = ''; |
|
1808 | + } |
|
1717 | 1809 | |
1718 | 1810 | // Don't trim or bother with it if it's not a variable. |
1719 | - if (substr($settingsArray[$i], 0, 1) != '$') |
|
1720 | - continue; |
|
1811 | + if (substr($settingsArray[$i], 0, 1) != '$') { |
|
1812 | + continue; |
|
1813 | + } |
|
1721 | 1814 | |
1722 | 1815 | $settingsArray[$i] = rtrim($settingsArray[$i]) . "\n"; |
1723 | 1816 | |
1724 | - foreach ($vars as $var => $val) |
|
1725 | - if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0) |
|
1817 | + foreach ($vars as $var => $val) { |
|
1818 | + if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0) |
|
1726 | 1819 | { |
1727 | 1820 | $comment = strstr($settingsArray[$i], '#'); |
1821 | + } |
|
1728 | 1822 | $settingsArray[$i] = '$' . $var . ' = \'' . $val . '\';' . ($comment != '' ? "\t\t" . $comment : "\n"); |
1729 | 1823 | unset($vars[$var]); |
1730 | 1824 | } |
@@ -1734,36 +1828,41 @@ discard block |
||
1734 | 1828 | if (!empty($vars)) |
1735 | 1829 | { |
1736 | 1830 | $settingsArray[$i++] = ''; |
1737 | - foreach ($vars as $var => $val) |
|
1738 | - $settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n"; |
|
1831 | + foreach ($vars as $var => $val) { |
|
1832 | + $settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n"; |
|
1833 | + } |
|
1739 | 1834 | } |
1740 | 1835 | |
1741 | 1836 | // Blank out the file - done to fix a oddity with some servers. |
1742 | 1837 | $fp = @fopen(dirname(__FILE__) . '/Settings.php', 'w'); |
1743 | - if (!$fp) |
|
1744 | - return false; |
|
1838 | + if (!$fp) { |
|
1839 | + return false; |
|
1840 | + } |
|
1745 | 1841 | fclose($fp); |
1746 | 1842 | |
1747 | 1843 | $fp = fopen(dirname(__FILE__) . '/Settings.php', 'r+'); |
1748 | 1844 | |
1749 | 1845 | // Gotta have one of these ;) |
1750 | - if (trim($settingsArray[0]) != '<?php') |
|
1751 | - fwrite($fp, "<?php\n"); |
|
1846 | + if (trim($settingsArray[0]) != '<?php') { |
|
1847 | + fwrite($fp, "<?php\n"); |
|
1848 | + } |
|
1752 | 1849 | |
1753 | 1850 | $lines = count($settingsArray); |
1754 | 1851 | for ($i = 0; $i < $lines - 1; $i++) |
1755 | 1852 | { |
1756 | 1853 | // Don't just write a bunch of blank lines. |
1757 | - if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') |
|
1758 | - fwrite($fp, strtr($settingsArray[$i], "\r", '')); |
|
1854 | + if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') { |
|
1855 | + fwrite($fp, strtr($settingsArray[$i], "\r", '')); |
|
1856 | + } |
|
1759 | 1857 | } |
1760 | 1858 | fwrite($fp, $settingsArray[$i] . '?' . '>'); |
1761 | 1859 | fclose($fp); |
1762 | 1860 | |
1763 | 1861 | // Even though on normal installations the filemtime should prevent this being used by the installer incorrectly |
1764 | 1862 | // it seems that there are times it might not. So let's MAKE it dump the cache. |
1765 | - if (function_exists('opcache_invalidate')) |
|
1766 | - opcache_invalidate(dirname(__FILE__) . '/Settings.php', true); |
|
1863 | + if (function_exists('opcache_invalidate')) { |
|
1864 | + opcache_invalidate(dirname(__FILE__) . '/Settings.php', true); |
|
1865 | + } |
|
1767 | 1866 | |
1768 | 1867 | return true; |
1769 | 1868 | } |
@@ -1788,9 +1887,9 @@ discard block |
||
1788 | 1887 | SecFilterScanPOST Off |
1789 | 1888 | </IfModule>'; |
1790 | 1889 | |
1791 | - if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) |
|
1792 | - return true; |
|
1793 | - elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess')) |
|
1890 | + if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) { |
|
1891 | + return true; |
|
1892 | + } elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess')) |
|
1794 | 1893 | { |
1795 | 1894 | $current_htaccess = implode('', file(dirname(__FILE__) . '/.htaccess')); |
1796 | 1895 | |
@@ -1802,29 +1901,28 @@ discard block |
||
1802 | 1901 | fwrite($ht_handle, $htaccess_addition); |
1803 | 1902 | fclose($ht_handle); |
1804 | 1903 | return true; |
1904 | + } else { |
|
1905 | + return false; |
|
1805 | 1906 | } |
1806 | - else |
|
1807 | - return false; |
|
1907 | + } else { |
|
1908 | + return true; |
|
1808 | 1909 | } |
1809 | - else |
|
1810 | - return true; |
|
1811 | - } |
|
1812 | - elseif (file_exists(dirname(__FILE__) . '/.htaccess')) |
|
1813 | - return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false; |
|
1814 | - elseif (is_writable(dirname(__FILE__))) |
|
1910 | + } elseif (file_exists(dirname(__FILE__) . '/.htaccess')) { |
|
1911 | + return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false; |
|
1912 | + } elseif (is_writable(dirname(__FILE__))) |
|
1815 | 1913 | { |
1816 | 1914 | if ($ht_handle = fopen(dirname(__FILE__) . '/.htaccess', 'w')) |
1817 | 1915 | { |
1818 | 1916 | fwrite($ht_handle, $htaccess_addition); |
1819 | 1917 | fclose($ht_handle); |
1820 | 1918 | return true; |
1919 | + } else { |
|
1920 | + return false; |
|
1821 | 1921 | } |
1822 | - else |
|
1922 | + } else { |
|
1823 | 1923 | return false; |
1824 | 1924 | } |
1825 | - else |
|
1826 | - return false; |
|
1827 | -} |
|
1925 | + } |
|
1828 | 1926 | |
1829 | 1927 | function template_install_above() |
1830 | 1928 | { |
@@ -1862,9 +1960,10 @@ discard block |
||
1862 | 1960 | <label for="installer_language">', $txt['installer_language'], ':</label> |
1863 | 1961 | <select id="installer_language" name="lang_file" onchange="location.href = \'', $installurl, '?lang_file=\' + this.options[this.selectedIndex].value;">'; |
1864 | 1962 | |
1865 | - foreach ($incontext['detected_languages'] as $lang => $name) |
|
1866 | - echo ' |
|
1963 | + foreach ($incontext['detected_languages'] as $lang => $name) { |
|
1964 | + echo ' |
|
1867 | 1965 | <option', isset($_SESSION['installer_temp_lang']) && $_SESSION['installer_temp_lang'] == $lang ? ' selected' : '', ' value="', $lang, '">', $name, '</option>'; |
1966 | + } |
|
1868 | 1967 | |
1869 | 1968 | echo ' |
1870 | 1969 | </select> |
@@ -1884,9 +1983,10 @@ discard block |
||
1884 | 1983 | <h2>', $txt['upgrade_progress'], '</h2> |
1885 | 1984 | <ul>'; |
1886 | 1985 | |
1887 | - foreach ($incontext['steps'] as $num => $step) |
|
1888 | - echo ' |
|
1986 | + foreach ($incontext['steps'] as $num => $step) { |
|
1987 | + echo ' |
|
1889 | 1988 | <li class="', $num < $incontext['current_step'] ? 'stepdone' : ($num == $incontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>'; |
1989 | + } |
|
1890 | 1990 | |
1891 | 1991 | echo ' |
1892 | 1992 | </ul> |
@@ -1911,20 +2011,23 @@ discard block |
||
1911 | 2011 | echo ' |
1912 | 2012 | <div>'; |
1913 | 2013 | |
1914 | - if (!empty($incontext['continue'])) |
|
1915 | - echo ' |
|
2014 | + if (!empty($incontext['continue'])) { |
|
2015 | + echo ' |
|
1916 | 2016 | <input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '" onclick="return submitThisOnce(this);" class="button_submit" />'; |
1917 | - if (!empty($incontext['skip'])) |
|
1918 | - echo ' |
|
2017 | + } |
|
2018 | + if (!empty($incontext['skip'])) { |
|
2019 | + echo ' |
|
1919 | 2020 | <input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="return submitThisOnce(this);" class="button_submit" />'; |
2021 | + } |
|
1920 | 2022 | echo ' |
1921 | 2023 | </div>'; |
1922 | 2024 | } |
1923 | 2025 | |
1924 | 2026 | // Show the closing form tag and other data only if not in the last step |
1925 | - if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) |
|
1926 | - echo ' |
|
2027 | + if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) { |
|
2028 | + echo ' |
|
1927 | 2029 | </form>'; |
2030 | + } |
|
1928 | 2031 | |
1929 | 2032 | echo ' |
1930 | 2033 | </div> |
@@ -1959,13 +2062,15 @@ discard block |
||
1959 | 2062 | </div>'; |
1960 | 2063 | |
1961 | 2064 | // Show the warnings, or not. |
1962 | - if (template_warning_divs()) |
|
1963 | - echo ' |
|
2065 | + if (template_warning_divs()) { |
|
2066 | + echo ' |
|
1964 | 2067 | <h3>', $txt['install_all_lovely'], '</h3>'; |
2068 | + } |
|
1965 | 2069 | |
1966 | 2070 | // Say we want the continue button! |
1967 | - if (empty($incontext['error'])) |
|
1968 | - $incontext['continue'] = 1; |
|
2071 | + if (empty($incontext['error'])) { |
|
2072 | + $incontext['continue'] = 1; |
|
2073 | + } |
|
1969 | 2074 | |
1970 | 2075 | // For the latest version stuff. |
1971 | 2076 | echo ' |
@@ -1999,8 +2104,8 @@ discard block |
||
1999 | 2104 | global $txt, $incontext; |
2000 | 2105 | |
2001 | 2106 | // Errors are very serious.. |
2002 | - if (!empty($incontext['error'])) |
|
2003 | - echo ' |
|
2107 | + if (!empty($incontext['error'])) { |
|
2108 | + echo ' |
|
2004 | 2109 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
2005 | 2110 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
2006 | 2111 | <strong style="text-decoration: underline;">', $txt['upgrade_critical_error'], '</strong><br> |
@@ -2008,9 +2113,10 @@ discard block |
||
2008 | 2113 | ', $incontext['error'], ' |
2009 | 2114 | </div> |
2010 | 2115 | </div>'; |
2116 | + } |
|
2011 | 2117 | // A warning message? |
2012 | - elseif (!empty($incontext['warning'])) |
|
2013 | - echo ' |
|
2118 | + elseif (!empty($incontext['warning'])) { |
|
2119 | + echo ' |
|
2014 | 2120 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
2015 | 2121 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
2016 | 2122 | <strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br> |
@@ -2018,6 +2124,7 @@ discard block |
||
2018 | 2124 | ', $incontext['warning'], ' |
2019 | 2125 | </div> |
2020 | 2126 | </div>'; |
2127 | + } |
|
2021 | 2128 | |
2022 | 2129 | return empty($incontext['error']) && empty($incontext['warning']); |
2023 | 2130 | } |
@@ -2033,27 +2140,30 @@ discard block |
||
2033 | 2140 | <li>', $incontext['failed_files']), '</li> |
2034 | 2141 | </ul>'; |
2035 | 2142 | |
2036 | - if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') |
|
2037 | - echo ' |
|
2143 | + if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') { |
|
2144 | + echo ' |
|
2038 | 2145 | <hr> |
2039 | 2146 | <p>', $txt['chmod_linux_info'], '</p> |
2040 | 2147 | <tt># chmod a+w ', implode(' ' . $incontext['detected_path'] . '/', $incontext['failed_files']), '</tt>'; |
2148 | + } |
|
2041 | 2149 | |
2042 | 2150 | // This is serious! |
2043 | - if (!template_warning_divs()) |
|
2044 | - return; |
|
2151 | + if (!template_warning_divs()) { |
|
2152 | + return; |
|
2153 | + } |
|
2045 | 2154 | |
2046 | 2155 | echo ' |
2047 | 2156 | <hr> |
2048 | 2157 | <p>', $txt['ftp_setup_info'], '</p>'; |
2049 | 2158 | |
2050 | - if (!empty($incontext['ftp_errors'])) |
|
2051 | - echo ' |
|
2159 | + if (!empty($incontext['ftp_errors'])) { |
|
2160 | + echo ' |
|
2052 | 2161 | <div class="error_message"> |
2053 | 2162 | ', $txt['error_ftp_no_connect'], '<br><br> |
2054 | 2163 | <code>', implode('<br>', $incontext['ftp_errors']), '</code> |
2055 | 2164 | </div> |
2056 | 2165 | <br>'; |
2166 | + } |
|
2057 | 2167 | |
2058 | 2168 | echo ' |
2059 | 2169 | <form action="', $incontext['form_url'], '" method="post"> |
@@ -2113,17 +2223,17 @@ discard block |
||
2113 | 2223 | <td> |
2114 | 2224 | <select name="db_type" id="db_type_input" onchange="toggleDBInput();">'; |
2115 | 2225 | |
2116 | - foreach ($incontext['supported_databases'] as $key => $db) |
|
2117 | - echo ' |
|
2226 | + foreach ($incontext['supported_databases'] as $key => $db) { |
|
2227 | + echo ' |
|
2118 | 2228 | <option value="', $key, '"', isset($_POST['db_type']) && $_POST['db_type'] == $key ? ' selected' : '', '>', $db['name'], '</option>'; |
2229 | + } |
|
2119 | 2230 | |
2120 | 2231 | echo ' |
2121 | 2232 | </select> |
2122 | 2233 | <div class="smalltext block">', $txt['db_settings_type_info'], '</div> |
2123 | 2234 | </td> |
2124 | 2235 | </tr>'; |
2125 | - } |
|
2126 | - else |
|
2236 | + } else |
|
2127 | 2237 | { |
2128 | 2238 | echo ' |
2129 | 2239 | <tr style="display: none;"> |
@@ -2315,9 +2425,10 @@ discard block |
||
2315 | 2425 | <div style="color: red;">', $txt['error_db_queries'], '</div> |
2316 | 2426 | <ul>'; |
2317 | 2427 | |
2318 | - foreach ($incontext['failures'] as $line => $fail) |
|
2319 | - echo ' |
|
2428 | + foreach ($incontext['failures'] as $line => $fail) { |
|
2429 | + echo ' |
|
2320 | 2430 | <li><strong>', $txt['error_db_queries_line'], $line + 1, ':</strong> ', nl2br(htmlspecialchars($fail)), '</li>'; |
2431 | + } |
|
2321 | 2432 | |
2322 | 2433 | echo ' |
2323 | 2434 | </ul>'; |
@@ -2378,15 +2489,16 @@ discard block |
||
2378 | 2489 | </tr> |
2379 | 2490 | </table>'; |
2380 | 2491 | |
2381 | - if ($incontext['require_db_confirm']) |
|
2382 | - echo ' |
|
2492 | + if ($incontext['require_db_confirm']) { |
|
2493 | + echo ' |
|
2383 | 2494 | <h2>', $txt['user_settings_database'], '</h2> |
2384 | 2495 | <p>', $txt['user_settings_database_info'], '</p> |
2385 | 2496 | |
2386 | 2497 | <div style="margin-bottom: 2ex; padding-', $txt['lang_rtl'] == false ? 'left' : 'right', ': 50px;"> |
2387 | 2498 | <input type="password" name="password3" size="30" class="input_password" /> |
2388 | 2499 | </div>'; |
2389 | -} |
|
2500 | + } |
|
2501 | + } |
|
2390 | 2502 | |
2391 | 2503 | // Tell them it's done, and to delete. |
2392 | 2504 | function template_delete_install() |
@@ -2399,14 +2511,15 @@ discard block |
||
2399 | 2511 | template_warning_divs(); |
2400 | 2512 | |
2401 | 2513 | // Install directory still writable? |
2402 | - if ($incontext['dir_still_writable']) |
|
2403 | - echo ' |
|
2514 | + if ($incontext['dir_still_writable']) { |
|
2515 | + echo ' |
|
2404 | 2516 | <em>', $txt['still_writable'], '</em><br> |
2405 | 2517 | <br>'; |
2518 | + } |
|
2406 | 2519 | |
2407 | 2520 | // Don't show the box if it's like 99% sure it won't work :P. |
2408 | - if ($incontext['probably_delete_install']) |
|
2409 | - echo ' |
|
2521 | + if ($incontext['probably_delete_install']) { |
|
2522 | + echo ' |
|
2410 | 2523 | <div style="margin: 1ex; font-weight: bold;"> |
2411 | 2524 | <label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete();" class="input_check" /> ', $txt['delete_installer'], !isset($_SESSION['installer_temp_ftp']) ? ' ' . $txt['delete_installer_maybe'] : '', '</label> |
2412 | 2525 | </div> |
@@ -2422,6 +2535,7 @@ discard block |
||
2422 | 2535 | } |
2423 | 2536 | </script> |
2424 | 2537 | <br>'; |
2538 | + } |
|
2425 | 2539 | |
2426 | 2540 | echo ' |
2427 | 2541 | ', sprintf($txt['go_to_your_forum'], $boardurl . '/index.php'), '<br> |
@@ -3031,8 +3031,7 @@ |
||
3031 | 3031 | <div class="roundframe"> |
3032 | 3032 | <div> |
3033 | 3033 | ', !empty($context['tfa_backup']) ? ' |
3034 | - <div class="smalltext error">' . $txt['tfa_backup_used_desc'] . '</div>' : |
|
3035 | - ($modSettings['tfa_mode'] == 2 ? ' |
|
3034 | + <div class="smalltext error">' . $txt['tfa_backup_used_desc'] . '</div>' : ($modSettings['tfa_mode'] == 2 ? ' |
|
3036 | 3035 | <div class="smalltext"><strong>' . $txt['tfa_forced_desc'] . '</strong></div>' : ''), ' |
3037 | 3036 | <div class="smalltext">', $txt['tfa_desc'], '</div> |
3038 | 3037 | <div id="basicinfo" style="width: 60%"> |
@@ -18,23 +18,25 @@ discard block |
||
18 | 18 | global $context; |
19 | 19 | |
20 | 20 | // Prevent Chrome from auto completing fields when viewing/editing other members profiles |
21 | - if (isBrowser('is_chrome') && !$context['user']['is_owner']) |
|
22 | - echo ' |
|
21 | + if (isBrowser('is_chrome') && !$context['user']['is_owner']) { |
|
22 | + echo ' |
|
23 | 23 | <script> |
24 | 24 | disableAutoComplete(); |
25 | 25 | </script>'; |
26 | + } |
|
26 | 27 | |
27 | 28 | // If an error occurred while trying to save previously, give the user a clue! |
28 | 29 | echo ' |
29 | 30 | ', template_error_message(); |
30 | 31 | |
31 | 32 | // If the profile was update successfully, let the user know this. |
32 | - if (!empty($context['profile_updated'])) |
|
33 | - echo ' |
|
33 | + if (!empty($context['profile_updated'])) { |
|
34 | + echo ' |
|
34 | 35 | <div class="infobox"> |
35 | 36 | ', $context['profile_updated'], ' |
36 | 37 | </div>'; |
37 | -} |
|
38 | + } |
|
39 | + } |
|
38 | 40 | |
39 | 41 | /** |
40 | 42 | * Template for any HTML needed below the profile (closing off divs/tables, etc.) |
@@ -102,8 +104,7 @@ discard block |
||
102 | 104 | if (empty($context['unread_alerts'])) |
103 | 105 | { |
104 | 106 | template_alerts_all_read(); |
105 | - } |
|
106 | - else |
|
107 | + } else |
|
107 | 108 | { |
108 | 109 | foreach ($context['unread_alerts'] as $id_alert => $details) |
109 | 110 | { |
@@ -164,10 +165,11 @@ discard block |
||
164 | 165 | <div class="custom_fields_above_name"> |
165 | 166 | <ul >'; |
166 | 167 | |
167 | - foreach ($context['print_custom_fields']['above_member'] as $field) |
|
168 | - if (!empty($field['output_html'])) |
|
168 | + foreach ($context['print_custom_fields']['above_member'] as $field) { |
|
169 | + if (!empty($field['output_html'])) |
|
169 | 170 | echo ' |
170 | 171 | <li>', $field['output_html'], '</li>'; |
172 | + } |
|
171 | 173 | |
172 | 174 | echo ' |
173 | 175 | </ul> |
@@ -188,10 +190,11 @@ discard block |
||
188 | 190 | <div class="custom_fields_below_avatar"> |
189 | 191 | <ul >'; |
190 | 192 | |
191 | - foreach ($context['print_custom_fields']['below_avatar'] as $field) |
|
192 | - if (!empty($field['output_html'])) |
|
193 | + foreach ($context['print_custom_fields']['below_avatar'] as $field) { |
|
194 | + if (!empty($field['output_html'])) |
|
193 | 195 | echo ' |
194 | 196 | <li>', $field['output_html'], '</li>'; |
197 | + } |
|
195 | 198 | |
196 | 199 | echo ' |
197 | 200 | </ul> |
@@ -202,22 +205,25 @@ discard block |
||
202 | 205 | echo ' |
203 | 206 | <ul class="clear">'; |
204 | 207 | // Email is only visible if it's your profile or you have the moderate_forum permission |
205 | - if ($context['member']['show_email']) |
|
206 | - echo ' |
|
208 | + if ($context['member']['show_email']) { |
|
209 | + echo ' |
|
207 | 210 | <li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>'; |
211 | + } |
|
208 | 212 | |
209 | 213 | // Don't show an icon if they haven't specified a website. |
210 | - if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) |
|
211 | - echo ' |
|
214 | + if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) { |
|
215 | + echo ' |
|
212 | 216 | <li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank" class="new_win">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
217 | + } |
|
213 | 218 | |
214 | 219 | // Are there any custom profile fields as icons? |
215 | 220 | if (!empty($context['print_custom_fields']['icons'])) |
216 | 221 | { |
217 | - foreach ($context['print_custom_fields']['icons'] as $field) |
|
218 | - if (!empty($field['output_html'])) |
|
222 | + foreach ($context['print_custom_fields']['icons'] as $field) { |
|
223 | + if (!empty($field['output_html'])) |
|
219 | 224 | echo ' |
220 | 225 | <li class="custom_field">', $field['output_html'], '</li>'; |
226 | + } |
|
221 | 227 | } |
222 | 228 | |
223 | 229 | echo ' |
@@ -225,23 +231,26 @@ discard block |
||
225 | 231 | <span id="userstatus">', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : ''; |
226 | 232 | |
227 | 233 | // Can they add this member as a buddy? |
228 | - if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) |
|
229 | - echo ' |
|
234 | + if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) { |
|
235 | + echo ' |
|
230 | 236 | <br><a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">[', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], ']</a>'; |
237 | + } |
|
231 | 238 | |
232 | 239 | echo ' |
233 | 240 | </span>'; |
234 | 241 | |
235 | - if (!$context['user']['is_owner'] && $context['can_send_pm']) |
|
236 | - echo ' |
|
242 | + if (!$context['user']['is_owner'] && $context['can_send_pm']) { |
|
243 | + echo ' |
|
237 | 244 | <a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>'; |
245 | + } |
|
238 | 246 | |
239 | 247 | echo ' |
240 | 248 | <a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>'; |
241 | 249 | |
242 | - if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) |
|
243 | - echo ' |
|
250 | + if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) { |
|
251 | + echo ' |
|
244 | 252 | <a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>'; |
253 | + } |
|
245 | 254 | |
246 | 255 | echo ' |
247 | 256 | <a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>'; |
@@ -253,10 +262,11 @@ discard block |
||
253 | 262 | <div class="custom_fields_bottom"> |
254 | 263 | <ul class="nolist">'; |
255 | 264 | |
256 | - foreach ($context['print_custom_fields']['bottom_poster'] as $field) |
|
257 | - if (!empty($field['output_html'])) |
|
265 | + foreach ($context['print_custom_fields']['bottom_poster'] as $field) { |
|
266 | + if (!empty($field['output_html'])) |
|
258 | 267 | echo ' |
259 | 268 | <li>', $field['output_html'], '</li>'; |
269 | + } |
|
260 | 270 | |
261 | 271 | echo ' |
262 | 272 | </ul> |
@@ -270,15 +280,17 @@ discard block |
||
270 | 280 | <div id="detailedinfo"> |
271 | 281 | <dl class="settings">'; |
272 | 282 | |
273 | - if ($context['user']['is_owner'] || $context['user']['is_admin']) |
|
274 | - echo ' |
|
283 | + if ($context['user']['is_owner'] || $context['user']['is_admin']) { |
|
284 | + echo ' |
|
275 | 285 | <dt>', $txt['username'], ': </dt> |
276 | 286 | <dd>', $context['member']['username'], '</dd>'; |
287 | + } |
|
277 | 288 | |
278 | - if (!isset($context['disabled_fields']['posts'])) |
|
279 | - echo ' |
|
289 | + if (!isset($context['disabled_fields']['posts'])) { |
|
290 | + echo ' |
|
280 | 291 | <dt>', $txt['profile_posts'], ': </dt> |
281 | 292 | <dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>'; |
293 | + } |
|
282 | 294 | |
283 | 295 | if ($context['member']['show_email']) |
284 | 296 | { |
@@ -287,15 +299,17 @@ discard block |
||
287 | 299 | <dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>'; |
288 | 300 | } |
289 | 301 | |
290 | - if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) |
|
291 | - echo ' |
|
302 | + if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) { |
|
303 | + echo ' |
|
292 | 304 | <dt>', $txt['custom_title'], ': </dt> |
293 | 305 | <dd>', $context['member']['title'], '</dd>'; |
306 | + } |
|
294 | 307 | |
295 | - if (!empty($context['member']['blurb'])) |
|
296 | - echo ' |
|
308 | + if (!empty($context['member']['blurb'])) { |
|
309 | + echo ' |
|
297 | 310 | <dt>', $txt['personal_text'], ': </dt> |
298 | 311 | <dd>', $context['member']['blurb'], '</dd>'; |
312 | + } |
|
299 | 313 | |
300 | 314 | echo ' |
301 | 315 | <dt>', $txt['age'], ':</dt> |
@@ -310,11 +324,12 @@ discard block |
||
310 | 324 | echo ' |
311 | 325 | <dl class="settings">'; |
312 | 326 | |
313 | - foreach ($context['print_custom_fields']['standard'] as $field) |
|
314 | - if (!empty($field['output_html'])) |
|
327 | + foreach ($context['print_custom_fields']['standard'] as $field) { |
|
328 | + if (!empty($field['output_html'])) |
|
315 | 329 | echo ' |
316 | 330 | <dt>', $field['name'], ':</dt> |
317 | 331 | <dd>', $field['output_html'], '</dd>'; |
332 | + } |
|
318 | 333 | |
319 | 334 | echo ' |
320 | 335 | </dl>'; |
@@ -332,9 +347,10 @@ discard block |
||
332 | 347 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>'; |
333 | 348 | |
334 | 349 | // Can we provide information on what this means? |
335 | - if (!empty($context['warning_status'])) |
|
336 | - echo ' |
|
350 | + if (!empty($context['warning_status'])) { |
|
351 | + echo ' |
|
337 | 352 | <span class="smalltext">(', $context['warning_status'], ')</span>'; |
353 | + } |
|
338 | 354 | |
339 | 355 | echo ' |
340 | 356 | </dd>'; |
@@ -345,9 +361,10 @@ discard block |
||
345 | 361 | { |
346 | 362 | |
347 | 363 | // If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves. |
348 | - if (!empty($context['activate_message'])) |
|
349 | - echo ' |
|
364 | + if (!empty($context['activate_message'])) { |
|
365 | + echo ' |
|
350 | 366 | <dt class="clear"><span class="alert">', $context['activate_message'], '</span> (<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>)</dt>'; |
367 | + } |
|
351 | 368 | |
352 | 369 | // If the current member is banned, show a message and possibly a link to the ban. |
353 | 370 | if (!empty($context['member']['bans'])) |
@@ -357,9 +374,10 @@ discard block |
||
357 | 374 | <dt class="clear" id="ban_info" style="display: none;"> |
358 | 375 | <strong>', $txt['user_banned_by_following'], ':</strong>'; |
359 | 376 | |
360 | - foreach ($context['member']['bans'] as $ban) |
|
361 | - echo ' |
|
377 | + foreach ($context['member']['bans'] as $ban) { |
|
378 | + echo ' |
|
362 | 379 | <br><span class="smalltext">', $ban['explanation'], '</span>'; |
380 | + } |
|
363 | 381 | |
364 | 382 | echo ' |
365 | 383 | </dt>'; |
@@ -373,30 +391,34 @@ discard block |
||
373 | 391 | // If the person looking is allowed, they can check the members IP address and hostname. |
374 | 392 | if ($context['can_see_ip']) |
375 | 393 | { |
376 | - if (!empty($context['member']['ip'])) |
|
377 | - echo ' |
|
394 | + if (!empty($context['member']['ip'])) { |
|
395 | + echo ' |
|
378 | 396 | <dt>', $txt['ip'], ': </dt> |
379 | 397 | <dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>'; |
398 | + } |
|
380 | 399 | |
381 | - if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) |
|
382 | - echo ' |
|
400 | + if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) { |
|
401 | + echo ' |
|
383 | 402 | <dt>', $txt['hostname'], ': </dt> |
384 | 403 | <dd>', $context['member']['hostname'], '</dd>'; |
404 | + } |
|
385 | 405 | } |
386 | 406 | |
387 | 407 | echo ' |
388 | 408 | <dt>', $txt['local_time'], ':</dt> |
389 | 409 | <dd>', $context['member']['local_time'], '</dd>'; |
390 | 410 | |
391 | - if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) |
|
392 | - echo ' |
|
411 | + if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) { |
|
412 | + echo ' |
|
393 | 413 | <dt>', $txt['language'], ':</dt> |
394 | 414 | <dd>', $context['member']['language'], '</dd>'; |
415 | + } |
|
395 | 416 | |
396 | - if ($context['member']['show_last_login']) |
|
397 | - echo ' |
|
417 | + if ($context['member']['show_last_login']) { |
|
418 | + echo ' |
|
398 | 419 | <dt>', $txt['lastLoggedIn'], ': </dt> |
399 | 420 | <dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>'; |
421 | + } |
|
400 | 422 | |
401 | 423 | echo ' |
402 | 424 | </dl>'; |
@@ -408,10 +430,11 @@ discard block |
||
408 | 430 | <div class="custom_fields_above_signature"> |
409 | 431 | <ul class="nolist">'; |
410 | 432 | |
411 | - foreach ($context['print_custom_fields']['above_signature'] as $field) |
|
412 | - if (!empty($field['output_html'])) |
|
433 | + foreach ($context['print_custom_fields']['above_signature'] as $field) { |
|
434 | + if (!empty($field['output_html'])) |
|
413 | 435 | echo ' |
414 | 436 | <li>', $field['output_html'], '</li>'; |
437 | + } |
|
415 | 438 | |
416 | 439 | echo ' |
417 | 440 | </ul> |
@@ -419,12 +442,13 @@ discard block |
||
419 | 442 | } |
420 | 443 | |
421 | 444 | // Show the users signature. |
422 | - if ($context['signature_enabled'] && !empty($context['member']['signature'])) |
|
423 | - echo ' |
|
445 | + if ($context['signature_enabled'] && !empty($context['member']['signature'])) { |
|
446 | + echo ' |
|
424 | 447 | <div class="signature"> |
425 | 448 | <h5>', $txt['signature'], ':</h5> |
426 | 449 | ', $context['member']['signature'], ' |
427 | 450 | </div>'; |
451 | + } |
|
428 | 452 | |
429 | 453 | // Are there any custom profile fields for below the signature? |
430 | 454 | if (!empty($context['print_custom_fields']['below_signature'])) |
@@ -433,10 +457,11 @@ discard block |
||
433 | 457 | <div class="custom_fields_below_signature"> |
434 | 458 | <ul class="nolist">'; |
435 | 459 | |
436 | - foreach ($context['print_custom_fields']['below_signature'] as $field) |
|
437 | - if (!empty($field['output_html'])) |
|
460 | + foreach ($context['print_custom_fields']['below_signature'] as $field) { |
|
461 | + if (!empty($field['output_html'])) |
|
438 | 462 | echo ' |
439 | 463 | <li>', $field['output_html'], '</li>'; |
464 | + } |
|
440 | 465 | |
441 | 466 | echo ' |
442 | 467 | </ul> |
@@ -481,62 +506,70 @@ discard block |
||
481 | 506 | </div> |
482 | 507 | <div class="list_posts">'; |
483 | 508 | |
484 | - if (!$post['approved']) |
|
485 | - echo ' |
|
509 | + if (!$post['approved']) { |
|
510 | + echo ' |
|
486 | 511 | <div class="approve_post"> |
487 | 512 | <em>', $txt['post_awaiting_approval'], '</em> |
488 | 513 | </div>'; |
514 | + } |
|
489 | 515 | |
490 | 516 | echo ' |
491 | 517 | ', $post['body'], ' |
492 | 518 | </div>'; |
493 | 519 | |
494 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
495 | - echo ' |
|
520 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
521 | + echo ' |
|
496 | 522 | <div class="floatright"> |
497 | 523 | <ul class="quickbuttons">'; |
524 | + } |
|
498 | 525 | |
499 | 526 | // If they *can* reply? |
500 | - if ($post['can_reply']) |
|
501 | - echo ' |
|
527 | + if ($post['can_reply']) { |
|
528 | + echo ' |
|
502 | 529 | <li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>'; |
530 | + } |
|
503 | 531 | |
504 | 532 | // If they *can* quote? |
505 | - if ($post['can_quote']) |
|
506 | - echo ' |
|
533 | + if ($post['can_quote']) { |
|
534 | + echo ' |
|
507 | 535 | <li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>'; |
536 | + } |
|
508 | 537 | |
509 | 538 | // How about... even... remove it entirely?! |
510 | - if ($post['can_delete']) |
|
511 | - echo ' |
|
539 | + if ($post['can_delete']) { |
|
540 | + echo ' |
|
512 | 541 | <li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
542 | + } |
|
513 | 543 | |
514 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
515 | - echo ' |
|
544 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
545 | + echo ' |
|
516 | 546 | </ul> |
517 | 547 | </div>'; |
548 | + } |
|
518 | 549 | |
519 | 550 | echo ' |
520 | 551 | </div>'; |
521 | 552 | } |
553 | + } else { |
|
554 | + template_show_list('attachments'); |
|
522 | 555 | } |
523 | - else |
|
524 | - template_show_list('attachments'); |
|
525 | 556 | |
526 | 557 | // No posts? Just end with a informative message. |
527 | - if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) |
|
528 | - echo ' |
|
558 | + if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) { |
|
559 | + echo ' |
|
529 | 560 | <div class="windowbg2"> |
530 | 561 | ', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), ' |
531 | 562 | </div>'; |
563 | + } |
|
532 | 564 | |
533 | 565 | // Show more page numbers. |
534 | - if (!empty($context['page_index'])) |
|
535 | - echo ' |
|
566 | + if (!empty($context['page_index'])) { |
|
567 | + echo ' |
|
536 | 568 | <div class="pagesection"> |
537 | 569 | <div class="pagelinks">', $context['page_index'], '</div> |
538 | 570 | </div>'; |
539 | -} |
|
571 | + } |
|
572 | + } |
|
540 | 573 | |
541 | 574 | /** |
542 | 575 | * Template for showing alerts within the alerts popup |
@@ -546,11 +579,12 @@ discard block |
||
546 | 579 | global $context, $txt, $scripturl; |
547 | 580 | |
548 | 581 | // Do we have an update message? |
549 | - if (!empty($context['update_message'])) |
|
550 | - echo ' |
|
582 | + if (!empty($context['update_message'])) { |
|
583 | + echo ' |
|
551 | 584 | <div class="infobox"> |
552 | 585 | ', $context['update_message'], '. |
553 | 586 | </div>'; |
587 | + } |
|
554 | 588 | |
555 | 589 | echo ' |
556 | 590 | <div class="cat_bar"> |
@@ -559,13 +593,12 @@ discard block |
||
559 | 593 | </h3> |
560 | 594 | </div>'; |
561 | 595 | |
562 | - if (empty($context['alerts'])) |
|
563 | - echo ' |
|
596 | + if (empty($context['alerts'])) { |
|
597 | + echo ' |
|
564 | 598 | <div class="information"> |
565 | 599 | ', $txt['alerts_none'], ' |
566 | 600 | </div>'; |
567 | - |
|
568 | - else |
|
601 | + } else |
|
569 | 602 | { |
570 | 603 | // Start the form. |
571 | 604 | echo ' |
@@ -627,12 +660,12 @@ discard block |
||
627 | 660 | </div>' : ''; |
628 | 661 | |
629 | 662 | // No drafts? Just show an informative message. |
630 | - if (empty($context['drafts'])) |
|
631 | - echo ' |
|
663 | + if (empty($context['drafts'])) { |
|
664 | + echo ' |
|
632 | 665 | <div class="windowbg2 centertext"> |
633 | 666 | ', $txt['draft_none'], ' |
634 | 667 | </div>'; |
635 | - else |
|
668 | + } else |
|
636 | 669 | { |
637 | 670 | // For every draft to be displayed, give it its own div, and show the important details of the draft. |
638 | 671 | foreach ($context['drafts'] as $draft) |
@@ -643,11 +676,13 @@ discard block |
||
643 | 676 | <div class="topic_details"> |
644 | 677 | <h5><strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> '; |
645 | 678 | |
646 | - if (!empty($draft['sticky'])) |
|
647 | - echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>'; |
|
679 | + if (!empty($draft['sticky'])) { |
|
680 | + echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>'; |
|
681 | + } |
|
648 | 682 | |
649 | - if (!empty($draft['locked'])) |
|
650 | - echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>'; |
|
683 | + if (!empty($draft['locked'])) { |
|
684 | + echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>'; |
|
685 | + } |
|
651 | 686 | |
652 | 687 | echo ' |
653 | 688 | </h5> |
@@ -680,12 +715,13 @@ discard block |
||
680 | 715 | { |
681 | 716 | global $context, $scripturl, $txt; |
682 | 717 | |
683 | - if (!empty($context['saved_successful'])) |
|
684 | - echo ' |
|
718 | + if (!empty($context['saved_successful'])) { |
|
719 | + echo ' |
|
685 | 720 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
686 | - elseif (!empty($context['saved_failed'])) |
|
687 | - echo ' |
|
721 | + } elseif (!empty($context['saved_failed'])) { |
|
722 | + echo ' |
|
688 | 723 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
724 | + } |
|
689 | 725 | |
690 | 726 | echo ' |
691 | 727 | <div id="edit_buddies"> |
@@ -699,24 +735,27 @@ discard block |
||
699 | 735 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
700 | 736 | <th scope="col">', $txt['status'], '</th>'; |
701 | 737 | |
702 | - if (allowedTo('moderate_forum')) |
|
703 | - echo ' |
|
738 | + if (allowedTo('moderate_forum')) { |
|
739 | + echo ' |
|
704 | 740 | <th scope="col">', $txt['email'], '</th>'; |
741 | + } |
|
705 | 742 | |
706 | - if (!empty($context['custom_pf'])) |
|
707 | - foreach ($context['custom_pf'] as $column) |
|
743 | + if (!empty($context['custom_pf'])) { |
|
744 | + foreach ($context['custom_pf'] as $column) |
|
708 | 745 | echo '<th scope="col">', $column['label'], '</th>'; |
746 | + } |
|
709 | 747 | |
710 | 748 | echo ' |
711 | 749 | <th scope="col">', $txt['remove'], '</th> |
712 | 750 | </tr>'; |
713 | 751 | |
714 | 752 | // If they don't have any buddies don't list them! |
715 | - if (empty($context['buddies'])) |
|
716 | - echo ' |
|
753 | + if (empty($context['buddies'])) { |
|
754 | + echo ' |
|
717 | 755 | <tr class="windowbg"> |
718 | 756 | <td colspan="', allowedTo('moderate_forum') ? '10' : '9', '"><strong>', $txt['no_buddies'], '</strong></td> |
719 | 757 | </tr>'; |
758 | + } |
|
720 | 759 | |
721 | 760 | // Now loop through each buddy showing info on each. |
722 | 761 | else |
@@ -728,15 +767,17 @@ discard block |
||
728 | 767 | <td>', $buddy['link'], '</td> |
729 | 768 | <td><a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a></td>'; |
730 | 769 | |
731 | - if ($buddy['show_email']) |
|
732 | - echo ' |
|
770 | + if ($buddy['show_email']) { |
|
771 | + echo ' |
|
733 | 772 | <td><a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a></td>'; |
773 | + } |
|
734 | 774 | |
735 | 775 | // Show the custom profile fields for this user. |
736 | - if (!empty($context['custom_pf'])) |
|
737 | - foreach ($context['custom_pf'] as $key => $column) |
|
776 | + if (!empty($context['custom_pf'])) { |
|
777 | + foreach ($context['custom_pf'] as $key => $column) |
|
738 | 778 | echo ' |
739 | 779 | <td class="lefttext">', $buddy['options'][$key], '</td>'; |
780 | + } |
|
740 | 781 | |
741 | 782 | echo ' |
742 | 783 | <td><a href="', $scripturl, '?action=profile;area=lists;sa=buddies;u=', $context['id_member'], ';remove=', $buddy['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['buddy_remove'], '"></span></a></td> |
@@ -766,9 +807,10 @@ discard block |
||
766 | 807 | </dl> |
767 | 808 | </div>'; |
768 | 809 | |
769 | - if (!empty($context['token_check'])) |
|
770 | - echo ' |
|
810 | + if (!empty($context['token_check'])) { |
|
811 | + echo ' |
|
771 | 812 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
813 | + } |
|
772 | 814 | |
773 | 815 | echo ' |
774 | 816 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -794,12 +836,13 @@ discard block |
||
794 | 836 | { |
795 | 837 | global $context, $scripturl, $txt; |
796 | 838 | |
797 | - if (!empty($context['saved_successful'])) |
|
798 | - echo ' |
|
839 | + if (!empty($context['saved_successful'])) { |
|
840 | + echo ' |
|
799 | 841 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
800 | - elseif (!empty($context['saved_failed'])) |
|
801 | - echo ' |
|
842 | + } elseif (!empty($context['saved_failed'])) { |
|
843 | + echo ' |
|
802 | 844 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
845 | + } |
|
803 | 846 | |
804 | 847 | echo ' |
805 | 848 | <div id="edit_buddies"> |
@@ -813,20 +856,22 @@ discard block |
||
813 | 856 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
814 | 857 | <th scope="col">', $txt['status'], '</th>'; |
815 | 858 | |
816 | - if (allowedTo('moderate_forum')) |
|
817 | - echo ' |
|
859 | + if (allowedTo('moderate_forum')) { |
|
860 | + echo ' |
|
818 | 861 | <th scope="col">', $txt['email'], '</th>'; |
862 | + } |
|
819 | 863 | |
820 | 864 | echo ' |
821 | 865 | <th scope="col">', $txt['ignore_remove'], '</th> |
822 | 866 | </tr>'; |
823 | 867 | |
824 | 868 | // If they don't have anyone on their ignore list, don't list it! |
825 | - if (empty($context['ignore_list'])) |
|
826 | - echo ' |
|
869 | + if (empty($context['ignore_list'])) { |
|
870 | + echo ' |
|
827 | 871 | <tr class="windowbg"> |
828 | 872 | <td colspan="', allowedTo('moderate_forum') ? '4' : '3', '"><strong>', $txt['no_ignore'], '</strong></td> |
829 | 873 | </tr>'; |
874 | + } |
|
830 | 875 | |
831 | 876 | // Now loop through each buddy showing info on each. |
832 | 877 | foreach ($context['ignore_list'] as $member) |
@@ -836,9 +881,10 @@ discard block |
||
836 | 881 | <td>', $member['link'], '</td> |
837 | 882 | <td><a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a></td>'; |
838 | 883 | |
839 | - if ($member['show_email']) |
|
840 | - echo ' |
|
884 | + if ($member['show_email']) { |
|
885 | + echo ' |
|
841 | 886 | <td><a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a></td>'; |
887 | + } |
|
842 | 888 | echo ' |
843 | 889 | <td><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a></td> |
844 | 890 | </tr>'; |
@@ -865,9 +911,10 @@ discard block |
||
865 | 911 | </dl> |
866 | 912 | </div>'; |
867 | 913 | |
868 | - if (!empty($context['token_check'])) |
|
869 | - echo ' |
|
914 | + if (!empty($context['token_check'])) { |
|
915 | + echo ' |
|
870 | 916 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
917 | + } |
|
871 | 918 | |
872 | 919 | echo ' |
873 | 920 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -912,9 +959,10 @@ discard block |
||
912 | 959 | <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>'; |
913 | 960 | |
914 | 961 | // Second address detected? |
915 | - if (!empty($context['last_ip2'])) |
|
916 | - echo ' |
|
962 | + if (!empty($context['last_ip2'])) { |
|
963 | + echo ' |
|
917 | 964 | , <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>'; |
965 | + } |
|
918 | 966 | |
919 | 967 | echo ' |
920 | 968 | </dd>'; |
@@ -979,9 +1027,10 @@ discard block |
||
979 | 1027 | <h3 class="catbg">', $txt['whois_title'], ' ', $context['ip'], '</h3> |
980 | 1028 | </div> |
981 | 1029 | <div class="windowbg2 noup">'; |
982 | - foreach ($context['whois_servers'] as $server) |
|
983 | - echo ' |
|
1030 | + foreach ($context['whois_servers'] as $server) { |
|
1031 | + echo ' |
|
984 | 1032 | <a href="', $server['url'], '" target="_blank" class="new_win"', isset($context['auto_whois_server']) && $context['auto_whois_server']['name'] == $server['name'] ? ' style="font-weight: bold;"' : '', '>', $server['name'], '</a><br>'; |
1033 | + } |
|
985 | 1034 | echo ' |
986 | 1035 | </div> |
987 | 1036 | <br>'; |
@@ -992,10 +1041,10 @@ discard block |
||
992 | 1041 | <div class="cat_bar"> |
993 | 1042 | <h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3> |
994 | 1043 | </div>'; |
995 | - if (empty($context['ips'])) |
|
996 | - echo ' |
|
1044 | + if (empty($context['ips'])) { |
|
1045 | + echo ' |
|
997 | 1046 | <p class="windowbg2 description"><em>', $txt['no_members_from_ip'], '</em></p>'; |
998 | - else |
|
1047 | + } else |
|
999 | 1048 | { |
1000 | 1049 | echo ' |
1001 | 1050 | <table class="table_grid"> |
@@ -1008,12 +1057,13 @@ discard block |
||
1008 | 1057 | <tbody>'; |
1009 | 1058 | |
1010 | 1059 | // Loop through each of the members and display them. |
1011 | - foreach ($context['ips'] as $ip => $memberlist) |
|
1012 | - echo ' |
|
1060 | + foreach ($context['ips'] as $ip => $memberlist) { |
|
1061 | + echo ' |
|
1013 | 1062 | <tr class="windowbg"> |
1014 | 1063 | <td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td> |
1015 | 1064 | <td>', implode(', ', $memberlist), '</td> |
1016 | 1065 | </tr>'; |
1066 | + } |
|
1017 | 1067 | |
1018 | 1068 | echo ' |
1019 | 1069 | </tbody> |
@@ -1059,8 +1109,7 @@ discard block |
||
1059 | 1109 | { |
1060 | 1110 | echo ' |
1061 | 1111 | <div class="information">', $txt['showPermissions_all'], '</div>'; |
1062 | - } |
|
1063 | - else |
|
1112 | + } else |
|
1064 | 1113 | { |
1065 | 1114 | echo ' |
1066 | 1115 | <div class="information">',$txt['showPermissions_help'], '</div> |
@@ -1074,9 +1123,10 @@ discard block |
||
1074 | 1123 | </div> |
1075 | 1124 | <div class="windowbg smalltext"> |
1076 | 1125 | ', $txt['showPermissions_restricted_boards_desc'], ':<br>'; |
1077 | - foreach ($context['no_access_boards'] as $no_access_board) |
|
1078 | - echo ' |
|
1126 | + foreach ($context['no_access_boards'] as $no_access_board) { |
|
1127 | + echo ' |
|
1079 | 1128 | <a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', '; |
1129 | + } |
|
1080 | 1130 | echo ' |
1081 | 1131 | </div>'; |
1082 | 1132 | } |
@@ -1108,12 +1158,13 @@ discard block |
||
1108 | 1158 | </td> |
1109 | 1159 | <td class="smalltext">'; |
1110 | 1160 | |
1111 | - if ($permission['is_denied']) |
|
1112 | - echo ' |
|
1161 | + if ($permission['is_denied']) { |
|
1162 | + echo ' |
|
1113 | 1163 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1114 | - else |
|
1115 | - echo ' |
|
1164 | + } else { |
|
1165 | + echo ' |
|
1116 | 1166 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
1167 | + } |
|
1117 | 1168 | |
1118 | 1169 | echo ' |
1119 | 1170 | </td> |
@@ -1123,10 +1174,10 @@ discard block |
||
1123 | 1174 | </tbody> |
1124 | 1175 | </table> |
1125 | 1176 | </div><br>'; |
1126 | - } |
|
1127 | - else |
|
1128 | - echo ' |
|
1177 | + } else { |
|
1178 | + echo ' |
|
1129 | 1179 | <p class="windowbg2">', $txt['showPermissions_none_general'], '</p>'; |
1180 | + } |
|
1130 | 1181 | |
1131 | 1182 | // Board permission section. |
1132 | 1183 | echo ' |
@@ -1136,14 +1187,16 @@ discard block |
||
1136 | 1187 | <a id="board_permissions"></a>', $txt['showPermissions_select'], ': |
1137 | 1188 | <select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();"> |
1138 | 1189 | <option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], ' </option>'; |
1139 | - if (!empty($context['boards'])) |
|
1140 | - echo ' |
|
1190 | + if (!empty($context['boards'])) { |
|
1191 | + echo ' |
|
1141 | 1192 | <option value="" disabled>---------------------------</option>'; |
1193 | + } |
|
1142 | 1194 | |
1143 | 1195 | // Fill the box with any local permission boards. |
1144 | - foreach ($context['boards'] as $board) |
|
1145 | - echo ' |
|
1196 | + foreach ($context['boards'] as $board) { |
|
1197 | + echo ' |
|
1146 | 1198 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>'; |
1199 | + } |
|
1147 | 1200 | |
1148 | 1201 | echo ' |
1149 | 1202 | </select> |
@@ -1174,8 +1227,7 @@ discard block |
||
1174 | 1227 | { |
1175 | 1228 | echo ' |
1176 | 1229 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1177 | - } |
|
1178 | - else |
|
1230 | + } else |
|
1179 | 1231 | { |
1180 | 1232 | echo ' |
1181 | 1233 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
@@ -1187,10 +1239,10 @@ discard block |
||
1187 | 1239 | echo ' |
1188 | 1240 | </tbody> |
1189 | 1241 | </table>'; |
1190 | - } |
|
1191 | - else |
|
1192 | - echo ' |
|
1242 | + } else { |
|
1243 | + echo ' |
|
1193 | 1244 | <p class="windowbg2">', $txt['showPermissions_none_board'], '</p>'; |
1245 | + } |
|
1194 | 1246 | echo ' |
1195 | 1247 | </div> |
1196 | 1248 | </div>'; |
@@ -1232,9 +1284,10 @@ discard block |
||
1232 | 1284 | </div>'; |
1233 | 1285 | |
1234 | 1286 | // If they haven't post at all, don't draw the graph. |
1235 | - if (empty($context['posts_by_time'])) |
|
1236 | - echo ' |
|
1287 | + if (empty($context['posts_by_time'])) { |
|
1288 | + echo ' |
|
1237 | 1289 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1290 | + } |
|
1238 | 1291 | // Otherwise do! |
1239 | 1292 | else |
1240 | 1293 | { |
@@ -1273,11 +1326,10 @@ discard block |
||
1273 | 1326 | </h3> |
1274 | 1327 | </div>'; |
1275 | 1328 | |
1276 | - if (empty($context['popular_boards'])) |
|
1277 | - echo ' |
|
1329 | + if (empty($context['popular_boards'])) { |
|
1330 | + echo ' |
|
1278 | 1331 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1279 | - |
|
1280 | - else |
|
1332 | + } else |
|
1281 | 1333 | { |
1282 | 1334 | echo ' |
1283 | 1335 | <dl class="stats">'; |
@@ -1308,10 +1360,10 @@ discard block |
||
1308 | 1360 | </h3> |
1309 | 1361 | </div>'; |
1310 | 1362 | |
1311 | - if (empty($context['board_activity'])) |
|
1312 | - echo ' |
|
1363 | + if (empty($context['board_activity'])) { |
|
1364 | + echo ' |
|
1313 | 1365 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1314 | - else |
|
1366 | + } else |
|
1315 | 1367 | { |
1316 | 1368 | echo ' |
1317 | 1369 | <dl class="stats">'; |
@@ -1359,41 +1411,46 @@ discard block |
||
1359 | 1411 | <h3 class="catbg profile_hd">'; |
1360 | 1412 | |
1361 | 1413 | // Don't say "Profile" if this isn't the profile... |
1362 | - if (!empty($context['profile_header_text'])) |
|
1363 | - echo ' |
|
1414 | + if (!empty($context['profile_header_text'])) { |
|
1415 | + echo ' |
|
1364 | 1416 | ', $context['profile_header_text']; |
1365 | - else |
|
1366 | - echo ' |
|
1417 | + } else { |
|
1418 | + echo ' |
|
1367 | 1419 | ', $txt['profile']; |
1420 | + } |
|
1368 | 1421 | |
1369 | 1422 | echo ' |
1370 | 1423 | </h3> |
1371 | 1424 | </div>'; |
1372 | 1425 | |
1373 | 1426 | // Have we some description? |
1374 | - if ($context['page_desc']) |
|
1375 | - echo ' |
|
1427 | + if ($context['page_desc']) { |
|
1428 | + echo ' |
|
1376 | 1429 | <p class="information">', $context['page_desc'], '</p>'; |
1430 | + } |
|
1377 | 1431 | |
1378 | 1432 | echo ' |
1379 | 1433 | <div class="roundframe">'; |
1380 | 1434 | |
1381 | 1435 | // Any bits at the start? |
1382 | - if (!empty($context['profile_prehtml'])) |
|
1383 | - echo ' |
|
1436 | + if (!empty($context['profile_prehtml'])) { |
|
1437 | + echo ' |
|
1384 | 1438 | <div>', $context['profile_prehtml'], '</div>'; |
1439 | + } |
|
1385 | 1440 | |
1386 | - if (!empty($context['profile_fields'])) |
|
1387 | - echo ' |
|
1441 | + if (!empty($context['profile_fields'])) { |
|
1442 | + echo ' |
|
1388 | 1443 | <dl class="settings">'; |
1444 | + } |
|
1389 | 1445 | |
1390 | 1446 | // Start the big old loop 'of love. |
1391 | 1447 | $lastItem = 'hr'; |
1392 | 1448 | foreach ($context['profile_fields'] as $key => $field) |
1393 | 1449 | { |
1394 | 1450 | // We add a little hack to be sure we never get more than one hr in a row! |
1395 | - if ($lastItem == 'hr' && $field['type'] == 'hr') |
|
1396 | - continue; |
|
1451 | + if ($lastItem == 'hr' && $field['type'] == 'hr') { |
|
1452 | + continue; |
|
1453 | + } |
|
1397 | 1454 | |
1398 | 1455 | $lastItem = $field['type']; |
1399 | 1456 | if ($field['type'] == 'hr') |
@@ -1402,48 +1459,50 @@ discard block |
||
1402 | 1459 | </dl> |
1403 | 1460 | <hr> |
1404 | 1461 | <dl class="settings">'; |
1405 | - } |
|
1406 | - elseif ($field['type'] == 'callback') |
|
1462 | + } elseif ($field['type'] == 'callback') |
|
1407 | 1463 | { |
1408 | 1464 | if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func'])) |
1409 | 1465 | { |
1410 | 1466 | $callback_func = 'template_profile_' . $field['callback_func']; |
1411 | 1467 | $callback_func(); |
1412 | 1468 | } |
1413 | - } |
|
1414 | - else |
|
1469 | + } else |
|
1415 | 1470 | { |
1416 | 1471 | echo ' |
1417 | 1472 | <dt> |
1418 | 1473 | <strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>'; |
1419 | 1474 | |
1420 | 1475 | // Does it have any subtext to show? |
1421 | - if (!empty($field['subtext'])) |
|
1422 | - echo ' |
|
1476 | + if (!empty($field['subtext'])) { |
|
1477 | + echo ' |
|
1423 | 1478 | <br> |
1424 | 1479 | <span class="smalltext">', $field['subtext'], '</span>'; |
1480 | + } |
|
1425 | 1481 | |
1426 | 1482 | echo ' |
1427 | 1483 | </dt> |
1428 | 1484 | <dd>'; |
1429 | 1485 | |
1430 | 1486 | // Want to put something infront of the box? |
1431 | - if (!empty($field['preinput'])) |
|
1432 | - echo ' |
|
1487 | + if (!empty($field['preinput'])) { |
|
1488 | + echo ' |
|
1433 | 1489 | ', $field['preinput']; |
1490 | + } |
|
1434 | 1491 | |
1435 | 1492 | // What type of data are we showing? |
1436 | - if ($field['type'] == 'label') |
|
1437 | - echo ' |
|
1493 | + if ($field['type'] == 'label') { |
|
1494 | + echo ' |
|
1438 | 1495 | ', $field['value']; |
1496 | + } |
|
1439 | 1497 | |
1440 | 1498 | // Maybe it's a text box - very likely! |
1441 | 1499 | elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url'))) |
1442 | 1500 | { |
1443 | - if ($field['type'] == 'int' || $field['type'] == 'float') |
|
1444 | - $type = 'number'; |
|
1445 | - else |
|
1446 | - $type = $field['type']; |
|
1501 | + if ($field['type'] == 'int' || $field['type'] == 'float') { |
|
1502 | + $type = 'number'; |
|
1503 | + } else { |
|
1504 | + $type = $field['type']; |
|
1505 | + } |
|
1447 | 1506 | $step = $field['type'] == 'float' ? ' step="0.1"' : ''; |
1448 | 1507 | |
1449 | 1508 | |
@@ -1451,9 +1510,10 @@ discard block |
||
1451 | 1510 | <input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' class="input_', $field['type'] == 'password' ? 'password' : 'text', '"', $step, '>'; |
1452 | 1511 | } |
1453 | 1512 | // You "checking" me out? ;) |
1454 | - elseif ($field['type'] == 'check') |
|
1455 | - echo ' |
|
1513 | + elseif ($field['type'] == 'check') { |
|
1514 | + echo ' |
|
1456 | 1515 | <input type="hidden" name="', $key, '" value="0"><input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" class="input_check" ', $field['input_attr'], '>'; |
1516 | + } |
|
1457 | 1517 | |
1458 | 1518 | // Always fun - select boxes! |
1459 | 1519 | elseif ($field['type'] == 'select') |
@@ -1464,13 +1524,15 @@ discard block |
||
1464 | 1524 | if (isset($field['options'])) |
1465 | 1525 | { |
1466 | 1526 | // Is this some code to generate the options? |
1467 | - if (!is_array($field['options'])) |
|
1468 | - $field['options'] = $field['options'](); |
|
1527 | + if (!is_array($field['options'])) { |
|
1528 | + $field['options'] = $field['options'](); |
|
1529 | + } |
|
1469 | 1530 | // Assuming we now have some! |
1470 | - if (is_array($field['options'])) |
|
1471 | - foreach ($field['options'] as $value => $name) |
|
1531 | + if (is_array($field['options'])) { |
|
1532 | + foreach ($field['options'] as $value => $name) |
|
1472 | 1533 | echo ' |
1473 | 1534 | <option value="', $value, '"', $value == $field['value'] ? ' selected' : '', '>', $name, '</option>'; |
1535 | + } |
|
1474 | 1536 | } |
1475 | 1537 | |
1476 | 1538 | echo ' |
@@ -1478,25 +1540,28 @@ discard block |
||
1478 | 1540 | } |
1479 | 1541 | |
1480 | 1542 | // Something to end with? |
1481 | - if (!empty($field['postinput'])) |
|
1482 | - echo ' |
|
1543 | + if (!empty($field['postinput'])) { |
|
1544 | + echo ' |
|
1483 | 1545 | ', $field['postinput']; |
1546 | + } |
|
1484 | 1547 | |
1485 | 1548 | echo ' |
1486 | 1549 | </dd>'; |
1487 | 1550 | } |
1488 | 1551 | } |
1489 | 1552 | |
1490 | - if (!empty($context['profile_fields'])) |
|
1491 | - echo ' |
|
1553 | + if (!empty($context['profile_fields'])) { |
|
1554 | + echo ' |
|
1492 | 1555 | </dl>'; |
1556 | + } |
|
1493 | 1557 | |
1494 | 1558 | // Are there any custom profile fields - if so print them! |
1495 | 1559 | if (!empty($context['custom_fields'])) |
1496 | 1560 | { |
1497 | - if ($lastItem != 'hr') |
|
1498 | - echo ' |
|
1561 | + if ($lastItem != 'hr') { |
|
1562 | + echo ' |
|
1499 | 1563 | <hr>'; |
1564 | + } |
|
1500 | 1565 | |
1501 | 1566 | echo ' |
1502 | 1567 | <dl class="settings">'; |
@@ -1519,13 +1584,14 @@ discard block |
||
1519 | 1584 | } |
1520 | 1585 | |
1521 | 1586 | // Any closing HTML? |
1522 | - if (!empty($context['profile_posthtml'])) |
|
1523 | - echo ' |
|
1587 | + if (!empty($context['profile_posthtml'])) { |
|
1588 | + echo ' |
|
1524 | 1589 | <div>', $context['profile_posthtml'], '</div>'; |
1590 | + } |
|
1525 | 1591 | |
1526 | 1592 | // Only show the password box if it's actually needed. |
1527 | - if ($context['require_password']) |
|
1528 | - echo ' |
|
1593 | + if ($context['require_password']) { |
|
1594 | + echo ' |
|
1529 | 1595 | <dl class="settings"> |
1530 | 1596 | <dt> |
1531 | 1597 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br> |
@@ -1535,18 +1601,21 @@ discard block |
||
1535 | 1601 | <input type="password" name="oldpasswrd" id="oldpasswrd" size="20" style="margin-right: 4ex;" class="input_password"> |
1536 | 1602 | </dd> |
1537 | 1603 | </dl>'; |
1604 | + } |
|
1538 | 1605 | |
1539 | 1606 | // The button shouldn't say "Change profile" unless we're changing the profile... |
1540 | - if (!empty($context['submit_button_text'])) |
|
1541 | - echo ' |
|
1607 | + if (!empty($context['submit_button_text'])) { |
|
1608 | + echo ' |
|
1542 | 1609 | <input type="submit" name="save" value="', $context['submit_button_text'], '" class="button_submit">'; |
1543 | - else |
|
1544 | - echo ' |
|
1610 | + } else { |
|
1611 | + echo ' |
|
1545 | 1612 | <input type="submit" name="save" value="', $txt['change_profile'], '" class="button_submit">'; |
1613 | + } |
|
1546 | 1614 | |
1547 | - if (!empty($context['token_check'])) |
|
1548 | - echo ' |
|
1615 | + if (!empty($context['token_check'])) { |
|
1616 | + echo ' |
|
1549 | 1617 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
1618 | + } |
|
1550 | 1619 | |
1551 | 1620 | echo ' |
1552 | 1621 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -1556,10 +1625,11 @@ discard block |
||
1556 | 1625 | </form>'; |
1557 | 1626 | |
1558 | 1627 | // Any final spellchecking stuff? |
1559 | - if (!empty($context['show_spellchecking'])) |
|
1560 | - echo ' |
|
1628 | + if (!empty($context['show_spellchecking'])) { |
|
1629 | + echo ' |
|
1561 | 1630 | <form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>'; |
1562 | -} |
|
1631 | + } |
|
1632 | + } |
|
1563 | 1633 | |
1564 | 1634 | /** |
1565 | 1635 | * Personal Message settings. |
@@ -1596,10 +1666,11 @@ discard block |
||
1596 | 1666 | <select name="pm_receive_from" id="pm_receive_from"> |
1597 | 1667 | <option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>'; |
1598 | 1668 | |
1599 | - if (!empty($modSettings['enable_buddylist'])) |
|
1600 | - echo ' |
|
1669 | + if (!empty($modSettings['enable_buddylist'])) { |
|
1670 | + echo ' |
|
1601 | 1671 | <option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option> |
1602 | 1672 | <option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>'; |
1673 | + } |
|
1603 | 1674 | |
1604 | 1675 | echo ' |
1605 | 1676 | <option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option> |
@@ -1641,11 +1712,12 @@ discard block |
||
1641 | 1712 | if (empty($setting) || !is_array($setting)) |
1642 | 1713 | { |
1643 | 1714 | // Insert a separator (unless this is the first item in the list) |
1644 | - if ($i !== $first_option_key) |
|
1645 | - echo ' |
|
1715 | + if ($i !== $first_option_key) { |
|
1716 | + echo ' |
|
1646 | 1717 | </dl> |
1647 | 1718 | <hr> |
1648 | 1719 | <dl class="settings">'; |
1720 | + } |
|
1649 | 1721 | |
1650 | 1722 | // Should we give a name to this section? |
1651 | 1723 | if (is_string($setting) && !empty($setting)) |
@@ -1653,48 +1725,52 @@ discard block |
||
1653 | 1725 | $titled_section = true; |
1654 | 1726 | echo ' |
1655 | 1727 | <dt><b>' . $setting . '</b></dt><dd></dd>'; |
1728 | + } else { |
|
1729 | + $titled_section = false; |
|
1656 | 1730 | } |
1657 | - else |
|
1658 | - $titled_section = false; |
|
1659 | 1731 | |
1660 | 1732 | continue; |
1661 | 1733 | } |
1662 | 1734 | |
1663 | 1735 | // Is this disabled? |
1664 | - if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) |
|
1665 | - continue; |
|
1666 | - elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
1667 | - continue; |
|
1668 | - elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) |
|
1669 | - continue; |
|
1670 | - elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) |
|
1671 | - continue; |
|
1672 | - elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) |
|
1673 | - continue; |
|
1674 | - elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage'])) |
|
1675 | - continue; |
|
1676 | - elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1677 | - continue; |
|
1678 | - elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1679 | - continue; |
|
1736 | + if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) { |
|
1737 | + continue; |
|
1738 | + } elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) { |
|
1739 | + continue; |
|
1740 | + } elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) { |
|
1741 | + continue; |
|
1742 | + } elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) { |
|
1743 | + continue; |
|
1744 | + } elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) { |
|
1745 | + continue; |
|
1746 | + } elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage'])) { |
|
1747 | + continue; |
|
1748 | + } elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1749 | + continue; |
|
1750 | + } elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1751 | + continue; |
|
1752 | + } |
|
1680 | 1753 | |
1681 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
1682 | - $setting['type'] = 'checkbox'; |
|
1683 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
1684 | - $setting['type'] = 'number'; |
|
1685 | - elseif ($setting['type'] == 'string') |
|
1686 | - $setting['type'] = 'text'; |
|
1754 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
1755 | + $setting['type'] = 'checkbox'; |
|
1756 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
1757 | + $setting['type'] = 'number'; |
|
1758 | + } elseif ($setting['type'] == 'string') { |
|
1759 | + $setting['type'] = 'text'; |
|
1760 | + } |
|
1687 | 1761 | |
1688 | - if (isset($setting['options'])) |
|
1689 | - $setting['type'] = 'list'; |
|
1762 | + if (isset($setting['options'])) { |
|
1763 | + $setting['type'] = 'list'; |
|
1764 | + } |
|
1690 | 1765 | |
1691 | 1766 | echo ' |
1692 | 1767 | <dt> |
1693 | 1768 | <label for="', $setting['id'], '">', !$titled_section ? '<b>' : '', $setting['label'], !$titled_section ? '</b>' : '', '</label>'; |
1694 | 1769 | |
1695 | - if (isset($setting['description'])) |
|
1696 | - echo ' |
|
1770 | + if (isset($setting['description'])) { |
|
1771 | + echo ' |
|
1697 | 1772 | <br><span class="smalltext">', $setting['description'], '</span>'; |
1773 | + } |
|
1698 | 1774 | echo ' |
1699 | 1775 | </dt> |
1700 | 1776 | <dd>'; |
@@ -1732,13 +1808,11 @@ discard block |
||
1732 | 1808 | |
1733 | 1809 | echo ' |
1734 | 1810 | <input type="number"', $min . $max . $step; |
1735 | - } |
|
1736 | - else if (isset($setting['type']) && $setting['type'] == 'url') |
|
1811 | + } else if (isset($setting['type']) && $setting['type'] == 'url') |
|
1737 | 1812 | { |
1738 | 1813 | echo' |
1739 | 1814 | <input type="url"'; |
1740 | - } |
|
1741 | - else |
|
1815 | + } else |
|
1742 | 1816 | { |
1743 | 1817 | echo ' |
1744 | 1818 | <input type="text"'; |
@@ -1777,8 +1851,8 @@ discard block |
||
1777 | 1851 | <dl class="settings">'; |
1778 | 1852 | |
1779 | 1853 | // Allow notification on announcements to be disabled? |
1780 | - if (!empty($modSettings['allow_disableAnnounce'])) |
|
1781 | - echo ' |
|
1854 | + if (!empty($modSettings['allow_disableAnnounce'])) { |
|
1855 | + echo ' |
|
1782 | 1856 | <dt> |
1783 | 1857 | <label for="notify_announcements">', $txt['notify_important_email'], '</label> |
1784 | 1858 | </dt> |
@@ -1786,9 +1860,10 @@ discard block |
||
1786 | 1860 | <input type="hidden" name="notify_announcements" value="0"> |
1787 | 1861 | <input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', ' class="input_check"> |
1788 | 1862 | </dd>'; |
1863 | + } |
|
1789 | 1864 | |
1790 | - if (!empty($modSettings['enable_ajax_alerts'])) |
|
1791 | - echo ' |
|
1865 | + if (!empty($modSettings['enable_ajax_alerts'])) { |
|
1866 | + echo ' |
|
1792 | 1867 | <dt> |
1793 | 1868 | <label for="notify_send_body">', $txt['notify_alert_timeout'], '</label> |
1794 | 1869 | </dt> |
@@ -1796,6 +1871,7 @@ discard block |
||
1796 | 1871 | <input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '" class="input_text"> |
1797 | 1872 | </dd> |
1798 | 1873 | '; |
1874 | + } |
|
1799 | 1875 | |
1800 | 1876 | echo ' |
1801 | 1877 | </dl> |
@@ -1825,9 +1901,10 @@ discard block |
||
1825 | 1901 | <td colspan="3">'; |
1826 | 1902 | $label = $txt['alert_opt_' . $opts[1]]; |
1827 | 1903 | $label_pos = isset($opts['label']) ? $opts['label'] : ''; |
1828 | - if ($label_pos == 'before') |
|
1829 | - echo ' |
|
1904 | + if ($label_pos == 'before') { |
|
1905 | + echo ' |
|
1830 | 1906 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
1907 | + } |
|
1831 | 1908 | |
1832 | 1909 | $this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0; |
1833 | 1910 | switch ($opts[0]) |
@@ -1839,17 +1916,19 @@ discard block |
||
1839 | 1916 | case 'select': |
1840 | 1917 | echo ' |
1841 | 1918 | <select name="opt_', $opts[1], '" id="opt_', $opts[1], '">'; |
1842 | - foreach ($opts['opts'] as $k => $v) |
|
1843 | - echo ' |
|
1919 | + foreach ($opts['opts'] as $k => $v) { |
|
1920 | + echo ' |
|
1844 | 1921 | <option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>'; |
1922 | + } |
|
1845 | 1923 | echo ' |
1846 | 1924 | </select>'; |
1847 | 1925 | break; |
1848 | 1926 | } |
1849 | 1927 | |
1850 | - if ($label_pos == 'after') |
|
1851 | - echo ' |
|
1928 | + if ($label_pos == 'after') { |
|
1929 | + echo ' |
|
1852 | 1930 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
1931 | + } |
|
1853 | 1932 | |
1854 | 1933 | echo ' |
1855 | 1934 | </td> |
@@ -1963,11 +2042,12 @@ discard block |
||
1963 | 2042 | <p class="information">', $txt['groupMembership_info'], '</p>'; |
1964 | 2043 | |
1965 | 2044 | // Do we have an update message? |
1966 | - if (!empty($context['update_message'])) |
|
1967 | - echo ' |
|
2045 | + if (!empty($context['update_message'])) { |
|
2046 | + echo ' |
|
1968 | 2047 | <div class="infobox"> |
1969 | 2048 | ', $context['update_message'], '. |
1970 | 2049 | </div>'; |
2050 | + } |
|
1971 | 2051 | |
1972 | 2052 | echo ' |
1973 | 2053 | <div id="groups">'; |
@@ -1989,8 +2069,7 @@ discard block |
||
1989 | 2069 | </div> |
1990 | 2070 | </div> |
1991 | 2071 | </div>'; |
1992 | - } |
|
1993 | - else |
|
2072 | + } else |
|
1994 | 2073 | { |
1995 | 2074 | echo ' |
1996 | 2075 | <div class="title_bar"> |
@@ -2002,27 +2081,30 @@ discard block |
||
2002 | 2081 | echo ' |
2003 | 2082 | <div class="windowbg" id="primdiv_', $group['id'], '">'; |
2004 | 2083 | |
2005 | - if ($context['can_edit_primary']) |
|
2006 | - echo ' |
|
2084 | + if ($context['can_edit_primary']) { |
|
2085 | + echo ' |
|
2007 | 2086 | <input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', ' class="input_radio">'; |
2087 | + } |
|
2008 | 2088 | |
2009 | 2089 | echo ' |
2010 | 2090 | <label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>'; |
2011 | 2091 | |
2012 | 2092 | // Can they leave their group? |
2013 | - if ($group['can_leave']) |
|
2014 | - echo ' |
|
2093 | + if ($group['can_leave']) { |
|
2094 | + echo ' |
|
2015 | 2095 | <a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>'; |
2096 | + } |
|
2016 | 2097 | |
2017 | 2098 | echo ' |
2018 | 2099 | </div>'; |
2019 | 2100 | } |
2020 | 2101 | |
2021 | - if ($context['can_edit_primary']) |
|
2022 | - echo ' |
|
2102 | + if ($context['can_edit_primary']) { |
|
2103 | + echo ' |
|
2023 | 2104 | <div class="padding righttext"> |
2024 | 2105 | <input type="submit" value="', $txt['make_primary'], '" class="button_submit"> |
2025 | 2106 | </div>'; |
2107 | + } |
|
2026 | 2108 | |
2027 | 2109 | // Any groups they can join? |
2028 | 2110 | if (!empty($context['groups']['available'])) |
@@ -2038,15 +2120,16 @@ discard block |
||
2038 | 2120 | <div class="windowbg"> |
2039 | 2121 | <strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), ''; |
2040 | 2122 | |
2041 | - if ($group['type'] == 3) |
|
2042 | - echo ' |
|
2123 | + if ($group['type'] == 3) { |
|
2124 | + echo ' |
|
2043 | 2125 | <a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>'; |
2044 | - elseif ($group['type'] == 2 && $group['pending']) |
|
2045 | - echo ' |
|
2126 | + } elseif ($group['type'] == 2 && $group['pending']) { |
|
2127 | + echo ' |
|
2046 | 2128 | <span class="floatright">', $txt['approval_pending'], '</span>'; |
2047 | - elseif ($group['type'] == 2) |
|
2048 | - echo ' |
|
2129 | + } elseif ($group['type'] == 2) { |
|
2130 | + echo ' |
|
2049 | 2131 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>'; |
2132 | + } |
|
2050 | 2133 | |
2051 | 2134 | echo ' |
2052 | 2135 | </div>'; |
@@ -2069,9 +2152,10 @@ discard block |
||
2069 | 2152 | |
2070 | 2153 | prevDiv.className = "windowbg"; |
2071 | 2154 | }'; |
2072 | - if (isset($context['groups']['member'][$context['primary_group']])) |
|
2073 | - echo ' |
|
2155 | + if (isset($context['groups']['member'][$context['primary_group']])) { |
|
2156 | + echo ' |
|
2074 | 2157 | highlightSelected("primdiv_' . $context['primary_group'] . '");'; |
2158 | + } |
|
2075 | 2159 | echo ' |
2076 | 2160 | </script>'; |
2077 | 2161 | } |
@@ -2079,9 +2163,10 @@ discard block |
||
2079 | 2163 | echo ' |
2080 | 2164 | </div>'; |
2081 | 2165 | |
2082 | - if (!empty($context['token_check'])) |
|
2083 | - echo ' |
|
2166 | + if (!empty($context['token_check'])) { |
|
2167 | + echo ' |
|
2084 | 2168 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2169 | + } |
|
2085 | 2170 | |
2086 | 2171 | echo ' |
2087 | 2172 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2128,14 +2213,15 @@ discard block |
||
2128 | 2213 | |
2129 | 2214 | foreach ($category['boards'] as $board) |
2130 | 2215 | { |
2131 | - if ($i == $limit) |
|
2132 | - echo ' |
|
2216 | + if ($i == $limit) { |
|
2217 | + echo ' |
|
2133 | 2218 | </ul> |
2134 | 2219 | </li> |
2135 | 2220 | </ul> |
2136 | 2221 | <ul class="ignoreboards floatright"> |
2137 | 2222 | <li class="category"> |
2138 | 2223 | <ul>'; |
2224 | + } |
|
2139 | 2225 | |
2140 | 2226 | echo ' |
2141 | 2227 | <li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;"> |
@@ -2181,10 +2267,11 @@ discard block |
||
2181 | 2267 | |
2182 | 2268 | // Work out the starting color. |
2183 | 2269 | $context['current_color'] = $context['colors'][0]; |
2184 | - foreach ($context['colors'] as $limit => $color) |
|
2185 | - if ($context['member']['warning'] >= $limit) |
|
2270 | + foreach ($context['colors'] as $limit => $color) { |
|
2271 | + if ($context['member']['warning'] >= $limit) |
|
2186 | 2272 | $context['current_color'] = $color; |
2187 | -} |
|
2273 | + } |
|
2274 | + } |
|
2188 | 2275 | |
2189 | 2276 | // Show all warnings of a user? |
2190 | 2277 | function template_viewWarning() |
@@ -2223,14 +2310,15 @@ discard block |
||
2223 | 2310 | </dd>'; |
2224 | 2311 | |
2225 | 2312 | // There's some impact of this? |
2226 | - if (!empty($context['level_effects'][$context['current_level']])) |
|
2227 | - echo ' |
|
2313 | + if (!empty($context['level_effects'][$context['current_level']])) { |
|
2314 | + echo ' |
|
2228 | 2315 | <dt> |
2229 | 2316 | <strong>', $txt['profile_viewwarning_impact'], ':</strong> |
2230 | 2317 | </dt> |
2231 | 2318 | <dd> |
2232 | 2319 | ', $context['level_effects'][$context['current_level']], ' |
2233 | 2320 | </dd>'; |
2321 | + } |
|
2234 | 2322 | |
2235 | 2323 | echo ' |
2236 | 2324 | </dl> |
@@ -2268,10 +2356,11 @@ discard block |
||
2268 | 2356 | |
2269 | 2357 | // Otherwise see what we can do...'; |
2270 | 2358 | |
2271 | - foreach ($context['notification_templates'] as $k => $type) |
|
2272 | - echo ' |
|
2359 | + foreach ($context['notification_templates'] as $k => $type) { |
|
2360 | + echo ' |
|
2273 | 2361 | if (index == ', $k, ') |
2274 | 2362 | document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";'; |
2363 | + } |
|
2275 | 2364 | |
2276 | 2365 | echo ' |
2277 | 2366 | } |
@@ -2281,10 +2370,11 @@ discard block |
||
2281 | 2370 | // Also set the right effect. |
2282 | 2371 | effectText = "";'; |
2283 | 2372 | |
2284 | - foreach ($context['level_effects'] as $limit => $text) |
|
2285 | - echo ' |
|
2373 | + foreach ($context['level_effects'] as $limit => $text) { |
|
2374 | + echo ' |
|
2286 | 2375 | if (slideAmount >= ', $limit, ') |
2287 | 2376 | effectText = "', $text, '";'; |
2377 | + } |
|
2288 | 2378 | |
2289 | 2379 | echo ' |
2290 | 2380 | setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\'); |
@@ -2299,31 +2389,34 @@ discard block |
||
2299 | 2389 | </h3> |
2300 | 2390 | </div>'; |
2301 | 2391 | |
2302 | - if (!$context['user']['is_owner']) |
|
2303 | - echo ' |
|
2392 | + if (!$context['user']['is_owner']) { |
|
2393 | + echo ' |
|
2304 | 2394 | <p class="information">', $txt['profile_warning_desc'], '</p>'; |
2395 | + } |
|
2305 | 2396 | |
2306 | 2397 | echo ' |
2307 | 2398 | <div class="windowbg"> |
2308 | 2399 | <dl class="settings">'; |
2309 | 2400 | |
2310 | - if (!$context['user']['is_owner']) |
|
2311 | - echo ' |
|
2401 | + if (!$context['user']['is_owner']) { |
|
2402 | + echo ' |
|
2312 | 2403 | <dt> |
2313 | 2404 | <strong>', $txt['profile_warning_name'], ':</strong> |
2314 | 2405 | </dt> |
2315 | 2406 | <dd> |
2316 | 2407 | <strong>', $context['member']['name'], '</strong> |
2317 | 2408 | </dd>'; |
2409 | + } |
|
2318 | 2410 | |
2319 | 2411 | echo ' |
2320 | 2412 | <dt> |
2321 | 2413 | <strong>', $txt['profile_warning_level'], ':</strong>'; |
2322 | 2414 | |
2323 | 2415 | // Is there only so much they can apply? |
2324 | - if ($context['warning_limit']) |
|
2325 | - echo ' |
|
2416 | + if ($context['warning_limit']) { |
|
2417 | + echo ' |
|
2326 | 2418 | <br><span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>'; |
2419 | + } |
|
2327 | 2420 | |
2328 | 2421 | echo ' |
2329 | 2422 | </dt> |
@@ -2376,9 +2469,10 @@ discard block |
||
2376 | 2469 | <option value="-1">', $txt['profile_warning_notify_template'], '</option> |
2377 | 2470 | <option value="-1" disabled>------------------------------</option>'; |
2378 | 2471 | |
2379 | - foreach ($context['notification_templates'] as $id_template => $template) |
|
2380 | - echo ' |
|
2472 | + foreach ($context['notification_templates'] as $id_template => $template) { |
|
2473 | + echo ' |
|
2381 | 2474 | <option value="', $id_template, '">', $template['title'], '</option>'; |
2475 | + } |
|
2382 | 2476 | |
2383 | 2477 | echo ' |
2384 | 2478 | </select> |
@@ -2390,9 +2484,10 @@ discard block |
||
2390 | 2484 | </dl> |
2391 | 2485 | <div class="righttext">'; |
2392 | 2486 | |
2393 | - if (!empty($context['token_check'])) |
|
2394 | - echo ' |
|
2487 | + if (!empty($context['token_check'])) { |
|
2488 | + echo ' |
|
2395 | 2489 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2490 | + } |
|
2396 | 2491 | |
2397 | 2492 | echo ' |
2398 | 2493 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2408,8 +2503,8 @@ discard block |
||
2408 | 2503 | echo ' |
2409 | 2504 | <script>'; |
2410 | 2505 | |
2411 | - if (!$context['user']['is_owner']) |
|
2412 | - echo ' |
|
2506 | + if (!$context['user']['is_owner']) { |
|
2507 | + echo ' |
|
2413 | 2508 | modifyWarnNotify(); |
2414 | 2509 | $(document).ready(function() { |
2415 | 2510 | $("#preview_button").click(function() { |
@@ -2448,6 +2543,7 @@ discard block |
||
2448 | 2543 | }); |
2449 | 2544 | return false; |
2450 | 2545 | }'; |
2546 | + } |
|
2451 | 2547 | |
2452 | 2548 | echo ' |
2453 | 2549 | </script>'; |
@@ -2470,16 +2566,18 @@ discard block |
||
2470 | 2566 | </div>'; |
2471 | 2567 | |
2472 | 2568 | // If deleting another account give them a lovely info box. |
2473 | - if (!$context['user']['is_owner']) |
|
2474 | - echo ' |
|
2569 | + if (!$context['user']['is_owner']) { |
|
2570 | + echo ' |
|
2475 | 2571 | <p class="information">', $txt['deleteAccount_desc'], '</p>'; |
2572 | + } |
|
2476 | 2573 | echo ' |
2477 | 2574 | <div class="windowbg2">'; |
2478 | 2575 | |
2479 | 2576 | // If they are deleting their account AND the admin needs to approve it - give them another piece of info ;) |
2480 | - if ($context['needs_approval']) |
|
2481 | - echo ' |
|
2577 | + if ($context['needs_approval']) { |
|
2578 | + echo ' |
|
2482 | 2579 | <div class="errorbox">', $txt['deleteAccount_approval'], '</div>'; |
2580 | + } |
|
2483 | 2581 | |
2484 | 2582 | // If the user is deleting their own account warn them first - and require a password! |
2485 | 2583 | if ($context['user']['is_owner']) |
@@ -2491,9 +2589,10 @@ discard block |
||
2491 | 2589 | <input type="password" name="oldpasswrd" size="20" class="input_password"> |
2492 | 2590 | <input type="submit" value="', $txt['yes'], '" class="button_submit">'; |
2493 | 2591 | |
2494 | - if (!empty($context['token_check'])) |
|
2495 | - echo ' |
|
2592 | + if (!empty($context['token_check'])) { |
|
2593 | + echo ' |
|
2496 | 2594 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2595 | + } |
|
2497 | 2596 | |
2498 | 2597 | echo ' |
2499 | 2598 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2519,9 +2618,10 @@ discard block |
||
2519 | 2618 | <option value="topics">', $txt['deleteAccount_topics'], '</option> |
2520 | 2619 | </select>'; |
2521 | 2620 | |
2522 | - if ($context['show_perma_delete']) |
|
2523 | - echo ' |
|
2621 | + if ($context['show_perma_delete']) { |
|
2622 | + echo ' |
|
2524 | 2623 | <br><label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1" class="input_check">', $txt['deleteAccount_permanent'], ':</label>'; |
2624 | + } |
|
2525 | 2625 | |
2526 | 2626 | echo ' |
2527 | 2627 | </div>'; |
@@ -2534,9 +2634,10 @@ discard block |
||
2534 | 2634 | <div> |
2535 | 2635 | <input type="submit" value="', $txt['delete'], '" class="button_submit">'; |
2536 | 2636 | |
2537 | - if (!empty($context['token_check'])) |
|
2538 | - echo ' |
|
2637 | + if (!empty($context['token_check'])) { |
|
2638 | + echo ' |
|
2539 | 2639 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2640 | + } |
|
2540 | 2641 | |
2541 | 2642 | echo ' |
2542 | 2643 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2562,8 +2663,8 @@ discard block |
||
2562 | 2663 | <hr>'; |
2563 | 2664 | |
2564 | 2665 | // Only show the password box if it's actually needed. |
2565 | - if ($context['require_password']) |
|
2566 | - echo ' |
|
2666 | + if ($context['require_password']) { |
|
2667 | + echo ' |
|
2567 | 2668 | <dl class="settings"> |
2568 | 2669 | <dt> |
2569 | 2670 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br> |
@@ -2573,13 +2674,15 @@ discard block |
||
2573 | 2674 | <input type="password" name="oldpasswrd" size="20" style="margin-right: 4ex;" class="input_password"> |
2574 | 2675 | </dd> |
2575 | 2676 | </dl>'; |
2677 | + } |
|
2576 | 2678 | |
2577 | 2679 | echo ' |
2578 | 2680 | <div class="righttext">'; |
2579 | 2681 | |
2580 | - if (!empty($context['token_check'])) |
|
2581 | - echo ' |
|
2682 | + if (!empty($context['token_check'])) { |
|
2683 | + echo ' |
|
2582 | 2684 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2685 | + } |
|
2583 | 2686 | |
2584 | 2687 | echo ' |
2585 | 2688 | <input type="submit" value="', $txt['change_profile'], '" class="button_submit"> |
@@ -2606,9 +2709,10 @@ discard block |
||
2606 | 2709 | <ul id="list_errors">'; |
2607 | 2710 | |
2608 | 2711 | // Cycle through each error and display an error message. |
2609 | - foreach ($context['post_errors'] as $error) |
|
2610 | - echo ' |
|
2712 | + foreach ($context['post_errors'] as $error) { |
|
2713 | + echo ' |
|
2611 | 2714 | <li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>'; |
2715 | + } |
|
2612 | 2716 | |
2613 | 2717 | echo ' |
2614 | 2718 | </ul>'; |
@@ -2634,12 +2738,13 @@ discard block |
||
2634 | 2738 | <select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 && !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>'; |
2635 | 2739 | |
2636 | 2740 | // Fill the select box with all primary member groups that can be assigned to a member. |
2637 | - foreach ($context['member_groups'] as $member_group) |
|
2638 | - if (!empty($member_group['can_be_primary'])) |
|
2741 | + foreach ($context['member_groups'] as $member_group) { |
|
2742 | + if (!empty($member_group['can_be_primary'])) |
|
2639 | 2743 | echo ' |
2640 | 2744 | <option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '> |
2641 | 2745 | ', $member_group['name'], ' |
2642 | 2746 | </option>'; |
2747 | + } |
|
2643 | 2748 | echo ' |
2644 | 2749 | </select> |
2645 | 2750 | </dd> |
@@ -2651,10 +2756,11 @@ discard block |
||
2651 | 2756 | <input type="hidden" name="additional_groups[]" value="0">'; |
2652 | 2757 | |
2653 | 2758 | // For each membergroup show a checkbox so members can be assigned to more than one group. |
2654 | - foreach ($context['member_groups'] as $member_group) |
|
2655 | - if ($member_group['can_be_additional']) |
|
2759 | + foreach ($context['member_groups'] as $member_group) { |
|
2760 | + if ($member_group['can_be_additional']) |
|
2656 | 2761 | echo ' |
2657 | 2762 | <label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', ' class="input_check"> ', $member_group['name'], '</label><br>'; |
2763 | + } |
|
2658 | 2764 | echo ' |
2659 | 2765 | </span> |
2660 | 2766 | <a href="javascript:void(0);" onclick="document.getElementById(\'additional_groupsList\').style.display = \'block\'; document.getElementById(\'additional_groupsLink\').style.display = \'none\'; return false;" id="additional_groupsLink" style="display: none;" class="toggle_down">', $txt['additional_membergroups_show'], '</a> |
@@ -2714,9 +2820,10 @@ discard block |
||
2714 | 2820 | <span class="smalltext">', $txt['sig_info'], '</span><br> |
2715 | 2821 | <br>'; |
2716 | 2822 | |
2717 | - if ($context['show_spellchecking']) |
|
2718 | - echo ' |
|
2823 | + if ($context['show_spellchecking']) { |
|
2824 | + echo ' |
|
2719 | 2825 | <input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button_submit">'; |
2826 | + } |
|
2720 | 2827 | |
2721 | 2828 | echo ' |
2722 | 2829 | </dt> |
@@ -2724,17 +2831,20 @@ discard block |
||
2724 | 2831 | <textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50" style="min-width: 50%; max-width: 99%;">', $context['member']['signature'], '</textarea><br>'; |
2725 | 2832 | |
2726 | 2833 | // If there is a limit at all! |
2727 | - if (!empty($context['signature_limits']['max_length'])) |
|
2728 | - echo ' |
|
2834 | + if (!empty($context['signature_limits']['max_length'])) { |
|
2835 | + echo ' |
|
2729 | 2836 | <span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>'; |
2837 | + } |
|
2730 | 2838 | |
2731 | - if (!empty($context['show_preview_button'])) |
|
2732 | - echo ' |
|
2839 | + if (!empty($context['show_preview_button'])) { |
|
2840 | + echo ' |
|
2733 | 2841 | <input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button_submit">'; |
2842 | + } |
|
2734 | 2843 | |
2735 | - if ($context['signature_warning']) |
|
2736 | - echo ' |
|
2844 | + if ($context['signature_warning']) { |
|
2845 | + echo ' |
|
2737 | 2846 | <span class="smalltext">', $context['signature_warning'], '</span>'; |
2847 | + } |
|
2738 | 2848 | |
2739 | 2849 | // Some javascript used to count how many characters have been used so far in the signature. |
2740 | 2850 | echo ' |
@@ -2778,9 +2888,10 @@ discard block |
||
2778 | 2888 | <div> |
2779 | 2889 | <select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">'; |
2780 | 2890 | // This lists all the file categories. |
2781 | - foreach ($context['avatars'] as $avatar) |
|
2782 | - echo ' |
|
2891 | + foreach ($context['avatars'] as $avatar) { |
|
2892 | + echo ' |
|
2783 | 2893 | <option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>'; |
2894 | + } |
|
2784 | 2895 | echo ' |
2785 | 2896 | </select> |
2786 | 2897 | </div> |
@@ -2835,16 +2946,17 @@ discard block |
||
2835 | 2946 | <div id="avatar_gravatar"> |
2836 | 2947 | <img src="' . $context['member']['avatar']['href'] . '" alt="" />'; |
2837 | 2948 | |
2838 | - if (empty($modSettings['gravatarAllowExtraEmail'])) |
|
2839 | - echo ' |
|
2949 | + if (empty($modSettings['gravatarAllowExtraEmail'])) { |
|
2950 | + echo ' |
|
2840 | 2951 | <div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>'; |
2841 | - else |
|
2952 | + } else |
|
2842 | 2953 | { |
2843 | 2954 | // Depending on other stuff, the stored value here might have some odd things in it from other areas. |
2844 | - if ($context['member']['avatar']['external'] == $context['member']['email']) |
|
2845 | - $textbox_value = ''; |
|
2846 | - else |
|
2847 | - $textbox_value = $context['member']['avatar']['external']; |
|
2955 | + if ($context['member']['avatar']['external'] == $context['member']['email']) { |
|
2956 | + $textbox_value = ''; |
|
2957 | + } else { |
|
2958 | + $textbox_value = $context['member']['avatar']['external']; |
|
2959 | + } |
|
2848 | 2960 | |
2849 | 2961 | echo ' |
2850 | 2962 | <div class="smalltext">', $txt['gravatar_alternateEmail'], '</div> |
@@ -2916,8 +3028,9 @@ discard block |
||
2916 | 3028 | $h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0; |
2917 | 3029 | |
2918 | 3030 | $suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : ''); |
2919 | - if (empty($suffix)) |
|
2920 | - return; |
|
3031 | + if (empty($suffix)) { |
|
3032 | + return; |
|
3033 | + } |
|
2921 | 3034 | |
2922 | 3035 | echo ' |
2923 | 3036 | <div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>'; |
@@ -2939,9 +3052,10 @@ discard block |
||
2939 | 3052 | <dd> |
2940 | 3053 | <select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;" style="margin-bottom: 4px;">'; |
2941 | 3054 | // Help the user by showing a list of common time formats. |
2942 | - foreach ($context['easy_timeformats'] as $time_format) |
|
2943 | - echo ' |
|
3055 | + foreach ($context['easy_timeformats'] as $time_format) { |
|
3056 | + echo ' |
|
2944 | 3057 | <option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>'; |
3058 | + } |
|
2945 | 3059 | echo ' |
2946 | 3060 | </select><br> |
2947 | 3061 | <input type="text" name="time_format" id="time_format" value="', $context['member']['time_format'], '" size="30" class="input_text"> |
@@ -2977,9 +3091,10 @@ discard block |
||
2977 | 3091 | </dt> |
2978 | 3092 | <dd> |
2979 | 3093 | <select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.gif\';">'; |
2980 | - foreach ($context['smiley_sets'] as $set) |
|
2981 | - echo ' |
|
3094 | + foreach ($context['smiley_sets'] as $set) { |
|
3095 | + echo ' |
|
2982 | 3096 | <option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>'; |
3097 | + } |
|
2983 | 3098 | echo ' |
2984 | 3099 | </select> <img id="smileypr" class="centericon" src="', $context['member']['smiley_set']['id'] != 'none' ? $modSettings['smileys_url'] . '/' . ($context['member']['smiley_set']['id'] != '' ? $context['member']['smiley_set']['id'] : (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'])) . '/smiley.gif' : $settings['images_url'] . '/blank.png', '" alt=":)" style="padding-left: 20px;"> |
2985 | 3100 | </dd>'; |
@@ -3030,10 +3145,11 @@ discard block |
||
3030 | 3145 | </div> |
3031 | 3146 | <div class="clear"></div>'; |
3032 | 3147 | |
3033 | - if (!empty($context['from_ajax'])) |
|
3034 | - echo ' |
|
3148 | + if (!empty($context['from_ajax'])) { |
|
3149 | + echo ' |
|
3035 | 3150 | <br> |
3036 | 3151 | <a href="javascript:self.close();"></a>'; |
3152 | + } |
|
3037 | 3153 | |
3038 | 3154 | echo ' |
3039 | 3155 | </div> |
@@ -3072,15 +3188,16 @@ discard block |
||
3072 | 3188 | <br /><div class="smalltext">', $txt['tfa_profile_desc'], '</div> |
3073 | 3189 | </dt> |
3074 | 3190 | <dd>'; |
3075 | - if (!$context['tfa_enabled'] && $context['user']['is_owner']) |
|
3076 | - echo ' |
|
3191 | + if (!$context['tfa_enabled'] && $context['user']['is_owner']) { |
|
3192 | + echo ' |
|
3077 | 3193 | <a href="', !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>'; |
3078 | - elseif (!$context['tfa_enabled']) |
|
3079 | - echo ' |
|
3194 | + } elseif (!$context['tfa_enabled']) { |
|
3195 | + echo ' |
|
3080 | 3196 | ', $txt['tfa_profile_disabled']; |
3081 | - else |
|
3082 | - echo ' |
|
3197 | + } else { |
|
3198 | + echo ' |
|
3083 | 3199 | ', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable'); |
3200 | + } |
|
3084 | 3201 | echo ' |
3085 | 3202 | </dd>'; |
3086 | 3203 | } |
@@ -21,7 +21,7 @@ |
||
21 | 21 | <div id="recent" class="main_section"> |
22 | 22 | <div class="cat_bar"> |
23 | 23 | <h3 class="catbg"> |
24 | - <span class="xx"></span>',$txt['recent_posts'],' |
|
24 | + <span class="xx"></span>',$txt['recent_posts'], ' |
|
25 | 25 | </h3> |
26 | 26 | </div> |
27 | 27 | <div class="pagesection">', $context['page_index'], '</div>'; |
@@ -43,28 +43,33 @@ discard block |
||
43 | 43 | </div> |
44 | 44 | <div class="list_posts">', $post['message'], '</div>'; |
45 | 45 | |
46 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
47 | - echo ' |
|
46 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
47 | + echo ' |
|
48 | 48 | <ul class="quickbuttons">'; |
49 | + } |
|
49 | 50 | |
50 | 51 | // If they *can* reply? |
51 | - if ($post['can_reply']) |
|
52 | - echo ' |
|
52 | + if ($post['can_reply']) { |
|
53 | + echo ' |
|
53 | 54 | <li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>'; |
55 | + } |
|
54 | 56 | |
55 | 57 | // If they *can* quote? |
56 | - if ($post['can_quote']) |
|
57 | - echo ' |
|
58 | + if ($post['can_quote']) { |
|
59 | + echo ' |
|
58 | 60 | <li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>'; |
61 | + } |
|
59 | 62 | |
60 | 63 | // How about... even... remove it entirely?! |
61 | - if ($post['can_delete']) |
|
62 | - echo ' |
|
64 | + if ($post['can_delete']) { |
|
65 | + echo ' |
|
63 | 66 | <li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';recent;', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
67 | + } |
|
64 | 68 | |
65 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
66 | - echo ' |
|
69 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
70 | + echo ' |
|
67 | 71 | </ul>'; |
72 | + } |
|
68 | 73 | |
69 | 74 | echo ' |
70 | 75 | </div>'; |
@@ -86,12 +91,13 @@ discard block |
||
86 | 91 | echo ' |
87 | 92 | <div id="recent" class="main_content">'; |
88 | 93 | |
89 | - if ($context['showCheckboxes']) |
|
90 | - echo ' |
|
94 | + if ($context['showCheckboxes']) { |
|
95 | + echo ' |
|
91 | 96 | <form action="', $scripturl, '?action=quickmod" method="post" accept-charset="', $context['character_set'], '" name="quickModForm" id="quickModForm" style="margin: 0;"> |
92 | 97 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
93 | 98 | <input type="hidden" name="qaction" value="markread"> |
94 | 99 | <input type="hidden" name="redirect_url" value="action=unread', (!empty($context['showing_all_topics']) ? ';all' : ''), $context['querystring_board_limits'], '">'; |
100 | + } |
|
95 | 101 | |
96 | 102 | if (!empty($context['topics'])) |
97 | 103 | { |
@@ -117,11 +123,12 @@ discard block |
||
117 | 123 | </div>'; |
118 | 124 | |
119 | 125 | // Show a "select all" box for quick moderation? |
120 | - if ($context['showCheckboxes']) |
|
121 | - echo ' |
|
126 | + if ($context['showCheckboxes']) { |
|
127 | + echo ' |
|
122 | 128 | <div class="moderation"> |
123 | 129 | <input type="checkbox" onclick="invertAll(this, this.form, \'topics[]\');" class="input_check"> |
124 | 130 | </div>'; |
131 | + } |
|
125 | 132 | |
126 | 133 | echo ' |
127 | 134 | </div> |
@@ -140,15 +147,18 @@ discard block |
||
140 | 147 | // Now we handle the icons |
141 | 148 | echo ' |
142 | 149 | <div class="icons floatright">'; |
143 | - if ($topic['is_locked']) |
|
144 | - echo ' |
|
150 | + if ($topic['is_locked']) { |
|
151 | + echo ' |
|
145 | 152 | <span class="generic_icons lock"></span>'; |
146 | - if ($topic['is_sticky']) |
|
147 | - echo ' |
|
153 | + } |
|
154 | + if ($topic['is_sticky']) { |
|
155 | + echo ' |
|
148 | 156 | <span class="generic_icons sticky"></span>'; |
149 | - if ($topic['is_poll']) |
|
150 | - echo ' |
|
157 | + } |
|
158 | + if ($topic['is_poll']) { |
|
159 | + echo ' |
|
151 | 160 | <span class="generic_icons poll"></span>'; |
161 | + } |
|
152 | 162 | echo ' |
153 | 163 | </div>'; |
154 | 164 | |
@@ -173,19 +183,21 @@ discard block |
||
173 | 183 | ', sprintf($txt['last_post_topic'], '<a href="' . $topic['last_post']['href'] . '">' . $topic['last_post']['time'] . '</a>', $topic['last_post']['member']['link']), ' |
174 | 184 | </div>'; |
175 | 185 | |
176 | - if ($context['showCheckboxes']) |
|
177 | - echo ' |
|
186 | + if ($context['showCheckboxes']) { |
|
187 | + echo ' |
|
178 | 188 | <div class="moderation"> |
179 | 189 | <input type="checkbox" name="topics[]" value="', $topic['id'], '" class="input_check"> |
180 | 190 | </div>'; |
191 | + } |
|
181 | 192 | |
182 | 193 | echo ' |
183 | 194 | </div>'; |
184 | 195 | } |
185 | 196 | |
186 | - if (empty($context['topics'])) |
|
187 | - echo ' |
|
197 | + if (empty($context['topics'])) { |
|
198 | + echo ' |
|
188 | 199 | <div style="display: none;"></div>'; |
200 | + } |
|
189 | 201 | |
190 | 202 | echo ' |
191 | 203 | </div> |
@@ -197,25 +209,27 @@ discard block |
||
197 | 209 | ', $context['menu_separator'], '<a href="#recent" class="topbottom floatleft">', $txt['go_up'], '</a> |
198 | 210 | <div class="pagelinks">', $context['page_index'], '</div> |
199 | 211 | </div>'; |
200 | - } |
|
201 | - else |
|
202 | - echo ' |
|
212 | + } else { |
|
213 | + echo ' |
|
203 | 214 | <div class="cat_bar"> |
204 | 215 | <h3 class="catbg centertext"> |
205 | 216 | ', $context['showing_all_topics'] ? $txt['topic_alert_none'] : $txt['unread_topics_visit_none'], ' |
206 | 217 | </h3> |
207 | 218 | </div>'; |
219 | + } |
|
208 | 220 | |
209 | - if ($context['showCheckboxes']) |
|
210 | - echo ' |
|
221 | + if ($context['showCheckboxes']) { |
|
222 | + echo ' |
|
211 | 223 | </form>'; |
224 | + } |
|
212 | 225 | |
213 | 226 | echo ' |
214 | 227 | </div>'; |
215 | 228 | |
216 | - if (empty($context['no_topic_listing'])) |
|
217 | - template_topic_legend(); |
|
218 | -} |
|
229 | + if (empty($context['no_topic_listing'])) { |
|
230 | + template_topic_legend(); |
|
231 | + } |
|
232 | + } |
|
219 | 233 | |
220 | 234 | /** |
221 | 235 | * Template for showing unread replies (eg new replies to topics you've posted in) |
@@ -227,12 +241,13 @@ discard block |
||
227 | 241 | echo ' |
228 | 242 | <div id="recent">'; |
229 | 243 | |
230 | - if ($context['showCheckboxes']) |
|
231 | - echo ' |
|
244 | + if ($context['showCheckboxes']) { |
|
245 | + echo ' |
|
232 | 246 | <form action="', $scripturl, '?action=quickmod" method="post" accept-charset="', $context['character_set'], '" name="quickModForm" id="quickModForm" style="margin: 0;"> |
233 | 247 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
234 | 248 | <input type="hidden" name="qaction" value="markread"> |
235 | 249 | <input type="hidden" name="redirect_url" value="action=unreadreplies', (!empty($context['showing_all_topics']) ? ';all' : ''), $context['querystring_board_limits'], '">'; |
250 | + } |
|
236 | 251 | |
237 | 252 | if (!empty($context['topics'])) |
238 | 253 | { |
@@ -258,11 +273,12 @@ discard block |
||
258 | 273 | </div>'; |
259 | 274 | |
260 | 275 | // Show a "select all" box for quick moderation? |
261 | - if ($context['showCheckboxes']) |
|
262 | - echo ' |
|
276 | + if ($context['showCheckboxes']) { |
|
277 | + echo ' |
|
263 | 278 | <div class="moderation"> |
264 | 279 | <input type="checkbox" onclick="invertAll(this, this.form, \'topics[]\');" class="input_check"> |
265 | 280 | </div>'; |
281 | + } |
|
266 | 282 | |
267 | 283 | echo ' |
268 | 284 | </div> |
@@ -281,15 +297,18 @@ discard block |
||
281 | 297 | // Now we handle the icons |
282 | 298 | echo ' |
283 | 299 | <div class="icons floatright">'; |
284 | - if ($topic['is_locked']) |
|
285 | - echo ' |
|
300 | + if ($topic['is_locked']) { |
|
301 | + echo ' |
|
286 | 302 | <span class="generic_icons lock"></span>'; |
287 | - if ($topic['is_sticky']) |
|
288 | - echo ' |
|
303 | + } |
|
304 | + if ($topic['is_sticky']) { |
|
305 | + echo ' |
|
289 | 306 | <span class="generic_icons sticky"></span>'; |
290 | - if ($topic['is_poll']) |
|
291 | - echo ' |
|
307 | + } |
|
308 | + if ($topic['is_poll']) { |
|
309 | + echo ' |
|
292 | 310 | <span class="generic_icons poll"></span>'; |
311 | + } |
|
293 | 312 | echo ' |
294 | 313 | </div>'; |
295 | 314 | |
@@ -314,11 +333,12 @@ discard block |
||
314 | 333 | ', sprintf($txt['last_post_topic'], '<a href="' . $topic['last_post']['href'] . '">' . $topic['last_post']['time'] . '</a>', $topic['last_post']['member']['link']), ' |
315 | 334 | </div>'; |
316 | 335 | |
317 | - if ($context['showCheckboxes']) |
|
318 | - echo ' |
|
336 | + if ($context['showCheckboxes']) { |
|
337 | + echo ' |
|
319 | 338 | <div class="moderation"> |
320 | 339 | <input type="checkbox" name="topics[]" value="', $topic['id'], '" class="input_check"> |
321 | 340 | </div>'; |
341 | + } |
|
322 | 342 | echo ' |
323 | 343 | </div>'; |
324 | 344 | } |
@@ -331,24 +351,26 @@ discard block |
||
331 | 351 | ', $context['menu_separator'], '<a href="#recent" class="topbottom floatleft">', $txt['go_up'], '</a> |
332 | 352 | <div class="pagelinks">', $context['page_index'], '</div> |
333 | 353 | </div>'; |
334 | - } |
|
335 | - else |
|
336 | - echo ' |
|
354 | + } else { |
|
355 | + echo ' |
|
337 | 356 | <div class="cat_bar"> |
338 | 357 | <h3 class="catbg centertext"> |
339 | 358 | ', $context['showing_all_topics'] ? $txt['topic_alert_none'] : $txt['unread_topics_visit_none'], ' |
340 | 359 | </h3> |
341 | 360 | </div>'; |
361 | + } |
|
342 | 362 | |
343 | - if ($context['showCheckboxes']) |
|
344 | - echo ' |
|
363 | + if ($context['showCheckboxes']) { |
|
364 | + echo ' |
|
345 | 365 | </form>'; |
366 | + } |
|
346 | 367 | |
347 | 368 | echo ' |
348 | 369 | </div>'; |
349 | 370 | |
350 | - if (empty($context['no_topic_listing'])) |
|
351 | - template_topic_legend(); |
|
352 | -} |
|
371 | + if (empty($context['no_topic_listing'])) { |
|
372 | + template_topic_legend(); |
|
373 | + } |
|
374 | + } |
|
353 | 375 | |
354 | 376 | ?> |
355 | 377 | \ No newline at end of file |
@@ -89,8 +89,9 @@ discard block |
||
89 | 89 | foreach ($section['areas'] as $i => $area) |
90 | 90 | { |
91 | 91 | // Not supposed to be printed? |
92 | - if (empty($area['label'])) |
|
93 | - continue; |
|
92 | + if (empty($area['label'])) { |
|
93 | + continue; |
|
94 | + } |
|
94 | 95 | |
95 | 96 | echo ' |
96 | 97 | <li', !empty($area['subsections']) ? ' class="subsections"' : '', '>'; |
@@ -99,8 +100,9 @@ discard block |
||
99 | 100 | <a class="', $area['icon_class'], !empty($area['selected']) ? ' chosen ' : '', '" href="', (isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $i), $menu_context['extra_parameters'], '">', $area['icon'], $area['label'], '</a>'; |
100 | 101 | |
101 | 102 | // Is this the current area, or just some area? |
102 | - if (!empty($area['selected']) && empty($context['tabs'])) |
|
103 | - $context['tabs'] = isset($area['subsections']) ? $area['subsections'] : array(); |
|
103 | + if (!empty($area['selected']) && empty($context['tabs'])) { |
|
104 | + $context['tabs'] = isset($area['subsections']) ? $area['subsections'] : array(); |
|
105 | + } |
|
104 | 106 | |
105 | 107 | // Are there any subsections? |
106 | 108 | if (!empty($area['subsections'])) |
@@ -110,8 +112,9 @@ discard block |
||
110 | 112 | |
111 | 113 | foreach ($area['subsections'] as $sa => $sub) |
112 | 114 | { |
113 | - if (!empty($sub['disabled'])) |
|
114 | - continue; |
|
115 | + if (!empty($sub['disabled'])) { |
|
116 | + continue; |
|
117 | + } |
|
115 | 118 | |
116 | 119 | $url = isset($sub['url']) ? $sub['url'] : (isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $i) . ';sa=' . $sa; |
117 | 120 | |
@@ -158,8 +161,9 @@ discard block |
||
158 | 161 | <h3 class="catbg">'; |
159 | 162 | |
160 | 163 | // The function is in Admin.template.php, but since this template is used elsewhere too better check if the function is available |
161 | - if (function_exists('template_admin_quick_search')) |
|
162 | - template_admin_quick_search(); |
|
164 | + if (function_exists('template_admin_quick_search')) { |
|
165 | + template_admin_quick_search(); |
|
166 | + } |
|
163 | 167 | |
164 | 168 | // Exactly how many tabs do we have? |
165 | 169 | if (!empty($context['tabs'])) |
@@ -174,30 +178,36 @@ discard block |
||
174 | 178 | } |
175 | 179 | |
176 | 180 | // Did this not even exist - or do we not have a label? |
177 | - if (!isset($tab_context['tabs'][$id])) |
|
178 | - $tab_context['tabs'][$id] = array('label' => $tab['label']); |
|
179 | - elseif (!isset($tab_context['tabs'][$id]['label'])) |
|
180 | - $tab_context['tabs'][$id]['label'] = $tab['label']; |
|
181 | + if (!isset($tab_context['tabs'][$id])) { |
|
182 | + $tab_context['tabs'][$id] = array('label' => $tab['label']); |
|
183 | + } elseif (!isset($tab_context['tabs'][$id]['label'])) { |
|
184 | + $tab_context['tabs'][$id]['label'] = $tab['label']; |
|
185 | + } |
|
181 | 186 | |
182 | 187 | // Has a custom URL defined in the main admin structure? |
183 | - if (isset($tab['url']) && !isset($tab_context['tabs'][$id]['url'])) |
|
184 | - $tab_context['tabs'][$id]['url'] = $tab['url']; |
|
188 | + if (isset($tab['url']) && !isset($tab_context['tabs'][$id]['url'])) { |
|
189 | + $tab_context['tabs'][$id]['url'] = $tab['url']; |
|
190 | + } |
|
185 | 191 | |
186 | 192 | // Any additional paramaters for the url? |
187 | - if (isset($tab['add_params']) && !isset($tab_context['tabs'][$id]['add_params'])) |
|
188 | - $tab_context['tabs'][$id]['add_params'] = $tab['add_params']; |
|
193 | + if (isset($tab['add_params']) && !isset($tab_context['tabs'][$id]['add_params'])) { |
|
194 | + $tab_context['tabs'][$id]['add_params'] = $tab['add_params']; |
|
195 | + } |
|
189 | 196 | |
190 | 197 | // Has it been deemed selected? |
191 | - if (!empty($tab['is_selected'])) |
|
192 | - $tab_context['tabs'][$id]['is_selected'] = true; |
|
198 | + if (!empty($tab['is_selected'])) { |
|
199 | + $tab_context['tabs'][$id]['is_selected'] = true; |
|
200 | + } |
|
193 | 201 | |
194 | 202 | // Does it have its own help? |
195 | - if (!empty($tab['help'])) |
|
196 | - $tab_context['tabs'][$id]['help'] = $tab['help']; |
|
203 | + if (!empty($tab['help'])) { |
|
204 | + $tab_context['tabs'][$id]['help'] = $tab['help']; |
|
205 | + } |
|
197 | 206 | |
198 | 207 | // Is this the last one? |
199 | - if (!empty($tab['is_last']) && !isset($tab_context['override_last'])) |
|
200 | - $tab_context['tabs'][$id]['is_last'] = true; |
|
208 | + if (!empty($tab['is_last']) && !isset($tab_context['override_last'])) { |
|
209 | + $tab_context['tabs'][$id]['is_last'] = true; |
|
210 | + } |
|
201 | 211 | } |
202 | 212 | |
203 | 213 | // Find the selected tab |
@@ -214,17 +224,18 @@ discard block |
||
214 | 224 | // Show an icon and/or a help item? |
215 | 225 | if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class']) || !empty($selected_tab['icon']) || !empty($tab_context['icon']) || !empty($selected_tab['help']) || !empty($tab_context['help'])) |
216 | 226 | { |
217 | - if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class'])) |
|
218 | - echo '<span class="', !empty($selected_tab['icon_class']) ? $selected_tab['icon_class'] : $tab_context['icon_class'], ' icon"></span>'; |
|
219 | - elseif (!empty($selected_tab['icon']) || !empty($tab_context['icon'])) |
|
220 | - echo '<img src="', $settings['images_url'], '/icons/', !empty($selected_tab['icon']) ? $selected_tab['icon'] : $tab_context['icon'], '" alt="" class="icon">'; |
|
227 | + if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class'])) { |
|
228 | + echo '<span class="', !empty($selected_tab['icon_class']) ? $selected_tab['icon_class'] : $tab_context['icon_class'], ' icon"></span>'; |
|
229 | + } elseif (!empty($selected_tab['icon']) || !empty($tab_context['icon'])) { |
|
230 | + echo '<img src="', $settings['images_url'], '/icons/', !empty($selected_tab['icon']) ? $selected_tab['icon'] : $tab_context['icon'], '" alt="" class="icon">'; |
|
231 | + } |
|
221 | 232 | |
222 | - if (!empty($selected_tab['help']) || !empty($tab_context['help'])) |
|
223 | - echo '<a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><span class="generic_icons help" title="', $txt['help'], '"></span></a>'; |
|
233 | + if (!empty($selected_tab['help']) || !empty($tab_context['help'])) { |
|
234 | + echo '<a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><span class="generic_icons help" title="', $txt['help'], '"></span></a>'; |
|
235 | + } |
|
224 | 236 | |
225 | 237 | echo $tab_context['title']; |
226 | - } |
|
227 | - else |
|
238 | + } else |
|
228 | 239 | { |
229 | 240 | echo ' |
230 | 241 | ', $tab_context['title']; |
@@ -237,11 +248,12 @@ discard block |
||
237 | 248 | } |
238 | 249 | |
239 | 250 | // Shall we use the tabs? Yes, it's the only known way! |
240 | - if (!empty($selected_tab['description']) || !empty($tab_context['description'])) |
|
241 | - echo ' |
|
251 | + if (!empty($selected_tab['description']) || !empty($tab_context['description'])) { |
|
252 | + echo ' |
|
242 | 253 | <p class="information"> |
243 | 254 | ', !empty($selected_tab['description']) ? $selected_tab['description'] : $tab_context['description'], ' |
244 | 255 | </p>'; |
256 | + } |
|
245 | 257 | |
246 | 258 | // Print out all the items in this tab (if any). |
247 | 259 | if (!empty($context['tabs'])) |
@@ -253,8 +265,9 @@ discard block |
||
253 | 265 | |
254 | 266 | foreach ($tab_context['tabs'] as $sa => $tab) |
255 | 267 | { |
256 | - if (!empty($tab['disabled'])) |
|
257 | - continue; |
|
268 | + if (!empty($tab['disabled'])) { |
|
269 | + continue; |
|
270 | + } |
|
258 | 271 | |
259 | 272 | if (!empty($tab['is_selected'])) |
260 | 273 | { |
@@ -262,12 +275,12 @@ discard block |
||
262 | 275 | <li> |
263 | 276 | <a class="active" href="', isset($tab['url']) ? $tab['url'] : $menu_context['base_url'] . ';area=' . $menu_context['current_area'] . ';sa=' . $sa, $menu_context['extra_parameters'], isset($tab['add_params']) ? $tab['add_params'] : '', '">', $tab['label'], '</a> |
264 | 277 | </li>'; |
265 | - } |
|
266 | - else |
|
267 | - echo ' |
|
278 | + } else { |
|
279 | + echo ' |
|
268 | 280 | <li> |
269 | 281 | <a href="', isset($tab['url']) ? $tab['url'] : $menu_context['base_url'] . ';area=' . $menu_context['current_area'] . ';sa=' . $sa, $menu_context['extra_parameters'], isset($tab['add_params']) ? $tab['add_params'] : '', '">', $tab['label'], '</a> |
270 | 282 | </li>'; |
283 | + } |
|
271 | 284 | } |
272 | 285 | |
273 | 286 | // the end of tabs |