@@ -20,17 +20,19 @@ discard block |
||
20 | 20 | echo ' |
21 | 21 | <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '" name="searchform" id="searchform">'; |
22 | 22 | |
23 | - if (!empty($context['search_errors'])) |
|
24 | - echo ' |
|
23 | + if (!empty($context['search_errors'])) { |
|
24 | + echo ' |
|
25 | 25 | <div class="errorbox"> |
26 | 26 | ', implode('<br>', $context['search_errors']['messages']), ' |
27 | 27 | </div>'; |
28 | + } |
|
28 | 29 | |
29 | - if (!empty($context['search_ignored'])) |
|
30 | - echo ' |
|
30 | + if (!empty($context['search_ignored'])) { |
|
31 | + echo ' |
|
31 | 32 | <div class="noticebox"> |
32 | 33 | ', $txt['search_warning_ignored_word' . (count($context['search_ignored']) == 1 ? '' : 's')], ': ', implode(', ', $context['search_ignored']), ' |
33 | 34 | </div>'; |
35 | + } |
|
34 | 36 | |
35 | 37 | echo ' |
36 | 38 | <div class="cat_bar"> |
@@ -48,9 +50,10 @@ discard block |
||
48 | 50 | <dd> |
49 | 51 | <input type="search" name="search" id="searchfor" ', !empty($context['search_params']['search']) ? ' value="' . $context['search_params']['search'] . '"' : '', ' maxlength="', $context['search_string_limit'], '" size="40">'; |
50 | 52 | |
51 | - if (empty($modSettings['search_simple_fulltext'])) |
|
52 | - echo ' |
|
53 | + if (empty($modSettings['search_simple_fulltext'])) { |
|
54 | + echo ' |
|
53 | 55 | <br><em class="smalltext">', $txt['search_example'], '</em>'; |
56 | + } |
|
54 | 57 | |
55 | 58 | echo ' |
56 | 59 | </dd> |
@@ -114,21 +117,23 @@ discard block |
||
114 | 117 | <input type="hidden" name="advanced" value="1">'; |
115 | 118 | |
116 | 119 | // Require an image to be typed to save spamming? |
117 | - if ($context['require_verification']) |
|
118 | - echo ' |
|
120 | + if ($context['require_verification']) { |
|
121 | + echo ' |
|
119 | 122 | <p> |
120 | 123 | <strong>', $txt['verification'], ':</strong> |
121 | 124 | ', template_control_verification($context['visual_verification_id'], 'all'), ' |
122 | 125 | </p>'; |
126 | + } |
|
123 | 127 | |
124 | 128 | // If $context['search_params']['topic'] is set, that means we're searching just one topic. |
125 | - if (!empty($context['search_params']['topic'])) |
|
126 | - echo ' |
|
129 | + if (!empty($context['search_params']['topic'])) { |
|
130 | + echo ' |
|
127 | 131 | <p> |
128 | 132 | ', $txt['search_specific_topic'], ' "', $context['search_topic']['link'], '". |
129 | 133 | </p> |
130 | 134 | <input type="hidden" name="topic" value="', $context['search_topic']['id'], '"> |
131 | 135 | <input type="submit" name="b_search" value="', $txt['search'], '" class="button">'; |
136 | + } |
|
132 | 137 | |
133 | 138 | echo ' |
134 | 139 | </div>'; |
@@ -238,17 +243,19 @@ discard block |
||
238 | 243 | <div class="roundframe">'; |
239 | 244 | |
240 | 245 | // Did they make any typos or mistakes, perhaps? |
241 | - if (isset($context['did_you_mean'])) |
|
242 | - echo ' |
|
246 | + if (isset($context['did_you_mean'])) { |
|
247 | + echo ' |
|
243 | 248 | <p> |
244 | 249 | ', $txt['search_did_you_mean'], ' <a href="', $scripturl, '?action=search2;params=', $context['did_you_mean_params'], '">', $context['did_you_mean'], '</a>. |
245 | 250 | </p>'; |
251 | + } |
|
246 | 252 | |
247 | - if (!empty($context['search_ignored'])) |
|
248 | - echo ' |
|
253 | + if (!empty($context['search_ignored'])) { |
|
254 | + echo ' |
|
249 | 255 | <p> |
250 | 256 | ', $txt['search_warning_ignored_word' . (count($context['search_ignored']) == 1 ? '' : 's')], ': ', implode(', ', $context['search_ignored']), ' |
251 | 257 | </p>'; |
258 | + } |
|
252 | 259 | |
253 | 260 | echo ' |
254 | 261 | <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '"> |
@@ -271,10 +278,11 @@ discard block |
||
271 | 278 | <input type="hidden" name="sort" value="', !empty($context['search_params']['sort']) ? $context['search_params']['sort'] : 'relevance', '"> |
272 | 279 | </div>'; |
273 | 280 | |
274 | - if (!empty($context['search_params']['brd'])) |
|
275 | - foreach ($context['search_params']['brd'] as $board_id) |
|
281 | + if (!empty($context['search_params']['brd'])) { |
|
282 | + foreach ($context['search_params']['brd'] as $board_id) |
|
276 | 283 | echo ' |
277 | 284 | <input type="hidden" name="brd[', $board_id, ']" value="', $board_id, '">'; |
285 | + } |
|
278 | 286 | |
279 | 287 | echo ' |
280 | 288 | </form> |
@@ -285,18 +293,20 @@ discard block |
||
285 | 293 | if ($context['compact']) |
286 | 294 | { |
287 | 295 | // Quick moderation set to checkboxes? Oh, how fun :/ |
288 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) |
|
289 | - echo ' |
|
296 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
297 | + echo ' |
|
290 | 298 | <form action="', $scripturl, '?action=quickmod" method="post" accept-charset="', $context['character_set'], '" name="topicForm">'; |
299 | + } |
|
291 | 300 | |
292 | 301 | echo ' |
293 | 302 | <div class="cat_bar"> |
294 | 303 | <h3 class="catbg"> |
295 | 304 | <span class="floatright">'; |
296 | 305 | |
297 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) |
|
298 | - echo ' |
|
306 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
307 | + echo ' |
|
299 | 308 | <input type="checkbox" onclick="invertAll(this, this.form, \'topics[]\');">'; |
309 | + } |
|
300 | 310 | echo ' |
301 | 311 | </span> |
302 | 312 | <span class="generic_icons filter"></span> ', $txt['mlist_search_results'], ': ', $context['search_params']['search'], ' |
@@ -304,15 +314,15 @@ discard block |
||
304 | 314 | </div>'; |
305 | 315 | |
306 | 316 | // Was anything even found? |
307 | - if (!empty($context['topics'])) |
|
308 | - echo ' |
|
317 | + if (!empty($context['topics'])) { |
|
318 | + echo ' |
|
309 | 319 | <div class="pagesection"> |
310 | 320 | <span>', $context['page_index'], '</span> |
311 | 321 | </div>'; |
312 | - |
|
313 | - else |
|
314 | - echo ' |
|
322 | + } else { |
|
323 | + echo ' |
|
315 | 324 | <div class="roundframe noup">', $txt['find_no_results'], '</div>'; |
325 | + } |
|
316 | 326 | |
317 | 327 | // While we have results to show ... |
318 | 328 | while ($topic = $context['get_topics']()) |
@@ -335,31 +345,35 @@ discard block |
||
335 | 345 | echo ' |
336 | 346 | <span class="floatright">'; |
337 | 347 | |
338 | - if ($options['display_quick_mod'] == 1) |
|
339 | - echo ' |
|
348 | + if ($options['display_quick_mod'] == 1) { |
|
349 | + echo ' |
|
340 | 350 | <input type="checkbox" name="topics[]" value="', $topic['id'], '">'; |
341 | - |
|
342 | - else |
|
351 | + } else |
|
343 | 352 | { |
344 | - if ($topic['quick_mod']['remove']) |
|
345 | - echo ' |
|
353 | + if ($topic['quick_mod']['remove']) { |
|
354 | + echo ' |
|
346 | 355 | <a href="', $scripturl, '?action=quickmod;board=' . $topic['board']['id'] . '.0;actions%5B', $topic['id'], '%5D=remove;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons delete" title="', $txt['remove_topic'], '"></span></a>'; |
356 | + } |
|
347 | 357 | |
348 | - if ($topic['quick_mod']['lock']) |
|
349 | - echo ' |
|
358 | + if ($topic['quick_mod']['lock']) { |
|
359 | + echo ' |
|
350 | 360 | <a href="', $scripturl, '?action=quickmod;board=' . $topic['board']['id'] . '.0;actions%5B', $topic['id'], '%5D=lock;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons lock" title="', $topic['is_locked'] ? $txt['set_unlock'] : $txt['set_lock'], '"></span></a>'; |
361 | + } |
|
351 | 362 | |
352 | - if ($topic['quick_mod']['lock'] || $topic['quick_mod']['remove']) |
|
353 | - echo ' |
|
363 | + if ($topic['quick_mod']['lock'] || $topic['quick_mod']['remove']) { |
|
364 | + echo ' |
|
354 | 365 | <br>'; |
366 | + } |
|
355 | 367 | |
356 | - if ($topic['quick_mod']['sticky']) |
|
357 | - echo ' |
|
368 | + if ($topic['quick_mod']['sticky']) { |
|
369 | + echo ' |
|
358 | 370 | <a href="', $scripturl, '?action=quickmod;board=' . $topic['board']['id'] . '.0;actions%5B', $topic['id'], '%5D=sticky;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons sticky" title="', $topic['is_sticky'] ? $txt['set_nonsticky'] : $txt['set_sticky'], '"></span></a>'; |
371 | + } |
|
359 | 372 | |
360 | - if ($topic['quick_mod']['move']) |
|
361 | - echo ' |
|
373 | + if ($topic['quick_mod']['move']) { |
|
374 | + echo ' |
|
362 | 375 | <a href="', $scripturl, '?action=movetopic;topic=', $topic['id'], '.0"><span class="generic_icons move" title="', $txt['move_topic'], '"></span></a>'; |
376 | + } |
|
363 | 377 | } |
364 | 378 | |
365 | 379 | echo ' |
@@ -369,20 +383,22 @@ discard block |
||
369 | 383 | echo ' |
370 | 384 | </div><!-- .block -->'; |
371 | 385 | |
372 | - if ($message['body_highlighted'] != '') |
|
373 | - echo ' |
|
386 | + if ($message['body_highlighted'] != '') { |
|
387 | + echo ' |
|
374 | 388 | <div class="list_posts double_height">', $message['body_highlighted'], '</div>'; |
389 | + } |
|
375 | 390 | } |
376 | 391 | |
377 | 392 | echo ' |
378 | 393 | </div><!-- $topic[css_class] -->'; |
379 | 394 | } |
380 | 395 | |
381 | - if (!empty($context['topics'])) |
|
382 | - echo ' |
|
396 | + if (!empty($context['topics'])) { |
|
397 | + echo ' |
|
383 | 398 | <div class="pagesection"> |
384 | 399 | <span>', $context['page_index'], '</span> |
385 | 400 | </div>'; |
401 | + } |
|
386 | 402 | |
387 | 403 | if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics'])) |
388 | 404 | { |
@@ -391,17 +407,19 @@ discard block |
||
391 | 407 | <select class="qaction" name="qaction"', $context['can_move'] ? ' onchange="this.form.move_to.disabled = (this.options[this.selectedIndex].value != \'move\');"' : '', '> |
392 | 408 | <option value="">--------</option>'; |
393 | 409 | |
394 | - foreach ($context['qmod_actions'] as $qmod_action) |
|
395 | - if ($context['can_' . $qmod_action]) |
|
410 | + foreach ($context['qmod_actions'] as $qmod_action) { |
|
411 | + if ($context['can_' . $qmod_action]) |
|
396 | 412 | echo ' |
397 | 413 | <option value="' . $qmod_action . '">' . $txt['quick_mod_' . $qmod_action] . '</option>'; |
414 | + } |
|
398 | 415 | |
399 | 416 | echo ' |
400 | 417 | </select>'; |
401 | 418 | |
402 | - if ($context['can_move']) |
|
403 | - echo ' |
|
419 | + if ($context['can_move']) { |
|
420 | + echo ' |
|
404 | 421 | <span id="quick_mod_jump_to"></span>'; |
422 | + } |
|
405 | 423 | |
406 | 424 | echo ' |
407 | 425 | <input type="hidden" name="redirect_url" value="', $scripturl . '?action=search2;params=' . $context['params'], '"> |
@@ -410,12 +428,12 @@ discard block |
||
410 | 428 | } |
411 | 429 | |
412 | 430 | |
413 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics'])) |
|
414 | - echo ' |
|
431 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics'])) { |
|
432 | + echo ' |
|
415 | 433 | <input type="hidden" name="' . $context['session_var'] . '" value="' . $context['session_id'] . '"> |
416 | 434 | </form>'; |
417 | - } |
|
418 | - else |
|
435 | + } |
|
436 | + } else |
|
419 | 437 | { |
420 | 438 | echo ' |
421 | 439 | <div class="cat_bar"> |
@@ -427,9 +445,10 @@ discard block |
||
427 | 445 | <span>', $context['page_index'], '</span> |
428 | 446 | </div>'; |
429 | 447 | |
430 | - if (empty($context['topics'])) |
|
431 | - echo ' |
|
448 | + if (empty($context['topics'])) { |
|
449 | + echo ' |
|
432 | 450 | <div class="information">(', $txt['search_no_results'], ')</div>'; |
451 | + } |
|
433 | 452 | |
434 | 453 | while ($topic = $context['get_topics']()) |
435 | 454 | { |
@@ -464,8 +483,8 @@ discard block |
||
464 | 483 | <div class="smalltext righttext" id="search_jump_to"></div> |
465 | 484 | <script>'; |
466 | 485 | |
467 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics']) && $context['can_move']) |
|
468 | - echo ' |
|
486 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics']) && $context['can_move']) { |
|
487 | + echo ' |
|
469 | 488 | if (typeof(window.XMLHttpRequest) != "undefined") |
470 | 489 | aJumpTo[aJumpTo.length] = new JumpTo({ |
471 | 490 | sContainerId: "quick_mod_jump_to", |
@@ -480,6 +499,7 @@ discard block |
||
480 | 499 | bDisabled: true, |
481 | 500 | sCustomName: "move_to" |
482 | 501 | });'; |
502 | + } |
|
483 | 503 | |
484 | 504 | echo ' |
485 | 505 | if (typeof(window.XMLHttpRequest) != "undefined") |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 4 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * !!!Compatibility!!! |
@@ -31,8 +32,9 @@ discard block |
||
31 | 32 | { |
32 | 33 | global $modSettings; |
33 | 34 | |
34 | - if (!$compat_mode) |
|
35 | - return $text; |
|
35 | + if (!$compat_mode) { |
|
36 | + return $text; |
|
37 | + } |
|
36 | 38 | |
37 | 39 | // Turn line breaks back into br's. |
38 | 40 | $text = strtr($text, array("\r" => '', "\n" => '<br>')); |
@@ -49,8 +51,9 @@ discard block |
||
49 | 51 | for ($i = 0, $n = count($parts); $i < $n; $i++) |
50 | 52 | { |
51 | 53 | // Value of 2 means we're inside the tag. |
52 | - if ($i % 4 == 2) |
|
53 | - $parts[$i] = strtr($parts[$i], array('[' => '[', ']' => ']', "'" => "'")); |
|
54 | + if ($i % 4 == 2) { |
|
55 | + $parts[$i] = strtr($parts[$i], array('[' => '[', ']' => ']', "'" => "'")); |
|
56 | + } |
|
54 | 57 | } |
55 | 58 | // Put our humpty dumpty message back together again. |
56 | 59 | $text = implode('', $parts); |
@@ -109,8 +112,9 @@ discard block |
||
109 | 112 | $text = preg_replace('~</p>\s*(?!<)~i', '</p><br>', $text); |
110 | 113 | |
111 | 114 | // Safari/webkit wraps lines in Wysiwyg in <div>'s. |
112 | - if (isBrowser('webkit')) |
|
113 | - $text = preg_replace(array('~<div(?:\s(?:[^<>]*?))?' . '>~i', '</div>'), array('<br>', ''), $text); |
|
115 | + if (isBrowser('webkit')) { |
|
116 | + $text = preg_replace(array('~<div(?:\s(?:[^<>]*?))?' . '>~i', '</div>'), array('<br>', ''), $text); |
|
117 | + } |
|
114 | 118 | |
115 | 119 | // If there's a trailing break get rid of it - Firefox tends to add one. |
116 | 120 | $text = preg_replace('~<br\s?/?' . '>$~i', '', $text); |
@@ -125,8 +129,9 @@ discard block |
||
125 | 129 | for ($i = 0, $n = count($parts); $i < $n; $i++) |
126 | 130 | { |
127 | 131 | // Value of 2 means we're inside the tag. |
128 | - if ($i % 4 == 2) |
|
129 | - $parts[$i] = strip_tags($parts[$i]); |
|
132 | + if ($i % 4 == 2) { |
|
133 | + $parts[$i] = strip_tags($parts[$i]); |
|
134 | + } |
|
130 | 135 | } |
131 | 136 | |
132 | 137 | $text = strtr(implode('', $parts), array('#smf_br_spec_grudge_cool!#' => '<br>')); |
@@ -152,18 +157,19 @@ discard block |
||
152 | 157 | { |
153 | 158 | $found = array_search($file, $smileysto); |
154 | 159 | // Note the weirdness here is to stop double spaces between smileys. |
155 | - if ($found) |
|
156 | - $matches[1][$k] = '-[]-smf_smily_start#|#' . $smcFunc['htmlspecialchars']($smileysfrom[$found]) . '-[]-smf_smily_end#|#'; |
|
157 | - else |
|
158 | - $matches[1][$k] = ''; |
|
160 | + if ($found) { |
|
161 | + $matches[1][$k] = '-[]-smf_smily_start#|#' . $smcFunc['htmlspecialchars']($smileysfrom[$found]) . '-[]-smf_smily_end#|#'; |
|
162 | + } else { |
|
163 | + $matches[1][$k] = ''; |
|
164 | + } |
|
159 | 165 | } |
160 | - } |
|
161 | - else |
|
166 | + } else |
|
162 | 167 | { |
163 | 168 | // Load all the smileys. |
164 | 169 | $names = array(); |
165 | - foreach ($matches[1] as $file) |
|
166 | - $names[] = $file; |
|
170 | + foreach ($matches[1] as $file) { |
|
171 | + $names[] = $file; |
|
172 | + } |
|
167 | 173 | $names = array_unique($names); |
168 | 174 | |
169 | 175 | if (!empty($names)) |
@@ -177,13 +183,15 @@ discard block |
||
177 | 183 | ) |
178 | 184 | ); |
179 | 185 | $mappings = array(); |
180 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
181 | - $mappings[$row['filename']] = $smcFunc['htmlspecialchars']($row['code']); |
|
186 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
187 | + $mappings[$row['filename']] = $smcFunc['htmlspecialchars']($row['code']); |
|
188 | + } |
|
182 | 189 | $smcFunc['db_free_result']($request); |
183 | 190 | |
184 | - foreach ($matches[1] as $k => $file) |
|
185 | - if (isset($mappings[$file])) |
|
191 | + foreach ($matches[1] as $k => $file) { |
|
192 | + if (isset($mappings[$file])) |
|
186 | 193 | $matches[1][$k] = '-[]-smf_smily_start#|#' . $mappings[$file] . '-[]-smf_smily_end#|#'; |
194 | + } |
|
187 | 195 | } |
188 | 196 | } |
189 | 197 | |
@@ -195,8 +203,9 @@ discard block |
||
195 | 203 | } |
196 | 204 | |
197 | 205 | // Only try to buy more time if the client didn't quit. |
198 | - if (connection_aborted() && $context['server']['is_apache']) |
|
199 | - @apache_reset_timeout(); |
|
206 | + if (connection_aborted() && $context['server']['is_apache']) { |
|
207 | + @apache_reset_timeout(); |
|
208 | + } |
|
200 | 209 | |
201 | 210 | $parts = preg_split('~(<[A-Za-z]+\s*[^<>]*?style="?[^<>"]+"?[^<>]*?(?:/?)>|</[A-Za-z]+>)~', $text, -1, PREG_SPLIT_DELIM_CAPTURE); |
202 | 211 | $replacement = ''; |
@@ -207,9 +216,9 @@ discard block |
||
207 | 216 | if (preg_match('~(<([A-Za-z]+)\s*[^<>]*?)style="?([^<>"]+)"?([^<>]*?(/?)>)~', $part, $matches) === 1) |
208 | 217 | { |
209 | 218 | // If it's being closed instantly, we can't deal with it...yet. |
210 | - if ($matches[5] === '/') |
|
211 | - continue; |
|
212 | - else |
|
219 | + if ($matches[5] === '/') { |
|
220 | + continue; |
|
221 | + } else |
|
213 | 222 | { |
214 | 223 | // Get an array of styles that apply to this element. (The strtr is there to combat HTML generated by Word.) |
215 | 224 | $styles = explode(';', strtr($matches[3], array('"' => ''))); |
@@ -225,8 +234,9 @@ discard block |
||
225 | 234 | $clean_type_value_pair = strtolower(strtr(trim($type_value_pair), '=', ':')); |
226 | 235 | |
227 | 236 | // Something like 'font-weight: bold' is expected here. |
228 | - if (strpos($clean_type_value_pair, ':') === false) |
|
229 | - continue; |
|
237 | + if (strpos($clean_type_value_pair, ':') === false) { |
|
238 | + continue; |
|
239 | + } |
|
230 | 240 | |
231 | 241 | // Capture the elements of a single style item (e.g. 'font-weight' and 'bold'). |
232 | 242 | list ($style_type, $style_value) = explode(':', $type_value_pair); |
@@ -248,8 +258,7 @@ discard block |
||
248 | 258 | { |
249 | 259 | $curCloseTags .= '[/u]'; |
250 | 260 | $replacement .= '[u]'; |
251 | - } |
|
252 | - elseif ($style_value == 'line-through') |
|
261 | + } elseif ($style_value == 'line-through') |
|
253 | 262 | { |
254 | 263 | $curCloseTags .= '[/s]'; |
255 | 264 | $replacement .= '[s]'; |
@@ -261,13 +270,11 @@ discard block |
||
261 | 270 | { |
262 | 271 | $curCloseTags .= '[/left]'; |
263 | 272 | $replacement .= '[left]'; |
264 | - } |
|
265 | - elseif ($style_value == 'center') |
|
273 | + } elseif ($style_value == 'center') |
|
266 | 274 | { |
267 | 275 | $curCloseTags .= '[/center]'; |
268 | 276 | $replacement .= '[center]'; |
269 | - } |
|
270 | - elseif ($style_value == 'right') |
|
277 | + } elseif ($style_value == 'right') |
|
271 | 278 | { |
272 | 279 | $curCloseTags .= '[/right]'; |
273 | 280 | $replacement .= '[right]'; |
@@ -289,8 +296,9 @@ discard block |
||
289 | 296 | |
290 | 297 | case 'font-size': |
291 | 298 | // Sometimes people put decimals where decimals should not be. |
292 | - if (preg_match('~(\d)+\.\d+(p[xt])~i', $style_value, $dec_matches) === 1) |
|
293 | - $style_value = $dec_matches[1] . $dec_matches[2]; |
|
299 | + if (preg_match('~(\d)+\.\d+(p[xt])~i', $style_value, $dec_matches) === 1) { |
|
300 | + $style_value = $dec_matches[1] . $dec_matches[2]; |
|
301 | + } |
|
294 | 302 | |
295 | 303 | $curCloseTags .= '[/size]'; |
296 | 304 | $replacement .= '[size=' . $style_value . ']'; |
@@ -298,8 +306,9 @@ discard block |
||
298 | 306 | |
299 | 307 | case 'font-family': |
300 | 308 | // Only get the first freaking font if there's a list! |
301 | - if (strpos($style_value, ',') !== false) |
|
302 | - $style_value = substr($style_value, 0, strpos($style_value, ',')); |
|
309 | + if (strpos($style_value, ',') !== false) { |
|
310 | + $style_value = substr($style_value, 0, strpos($style_value, ',')); |
|
311 | + } |
|
303 | 312 | |
304 | 313 | $curCloseTags .= '[/font]'; |
305 | 314 | $replacement .= '[font=' . strtr($style_value, array("'" => '')) . ']'; |
@@ -308,13 +317,15 @@ discard block |
||
308 | 317 | // This is a hack for images with dimensions embedded. |
309 | 318 | case 'width': |
310 | 319 | case 'height': |
311 | - if (preg_match('~[1-9]\d*~i', $style_value, $dimension) === 1) |
|
312 | - $extra_attr .= ' ' . $style_type . '="' . $dimension[0] . '"'; |
|
320 | + if (preg_match('~[1-9]\d*~i', $style_value, $dimension) === 1) { |
|
321 | + $extra_attr .= ' ' . $style_type . '="' . $dimension[0] . '"'; |
|
322 | + } |
|
313 | 323 | break; |
314 | 324 | |
315 | 325 | case 'list-style-type': |
316 | - if (preg_match('~none|disc|circle|square|decimal|decimal-leading-zero|lower-roman|upper-roman|lower-alpha|upper-alpha|lower-greek|lower-latin|upper-latin|hebrew|armenian|georgian|cjk-ideographic|hiragana|katakana|hiragana-iroha|katakana-iroha~i', $style_value, $listType) === 1) |
|
317 | - $extra_attr .= ' listtype="' . $listType[0] . '"'; |
|
326 | + if (preg_match('~none|disc|circle|square|decimal|decimal-leading-zero|lower-roman|upper-roman|lower-alpha|upper-alpha|lower-greek|lower-latin|upper-latin|hebrew|armenian|georgian|cjk-ideographic|hiragana|katakana|hiragana-iroha|katakana-iroha~i', $style_value, $listType) === 1) { |
|
327 | + $extra_attr .= ' listtype="' . $listType[0] . '"'; |
|
328 | + } |
|
318 | 329 | break; |
319 | 330 | } |
320 | 331 | } |
@@ -327,18 +338,17 @@ discard block |
||
327 | 338 | } |
328 | 339 | |
329 | 340 | // If there's something that still needs closing, push it to the stack. |
330 | - if (!empty($curCloseTags)) |
|
331 | - array_push($stack, array( |
|
341 | + if (!empty($curCloseTags)) { |
|
342 | + array_push($stack, array( |
|
332 | 343 | 'element' => strtolower($curElement), |
333 | 344 | 'closeTags' => $curCloseTags |
334 | 345 | ) |
335 | 346 | ); |
336 | - elseif (!empty($extra_attr)) |
|
337 | - $replacement .= $precedingStyle . $extra_attr . $afterStyle; |
|
347 | + } elseif (!empty($extra_attr)) { |
|
348 | + $replacement .= $precedingStyle . $extra_attr . $afterStyle; |
|
349 | + } |
|
338 | 350 | } |
339 | - } |
|
340 | - |
|
341 | - elseif (preg_match('~</([A-Za-z]+)>~', $part, $matches) === 1) |
|
351 | + } elseif (preg_match('~</([A-Za-z]+)>~', $part, $matches) === 1) |
|
342 | 352 | { |
343 | 353 | // Is this the element that we've been waiting for to be closed? |
344 | 354 | if (!empty($stack) && strtolower($matches[1]) === $stack[count($stack) - 1]['element']) |
@@ -348,28 +358,32 @@ discard block |
||
348 | 358 | } |
349 | 359 | |
350 | 360 | // Must've been something else. |
351 | - else |
|
352 | - $replacement .= $part; |
|
361 | + else { |
|
362 | + $replacement .= $part; |
|
363 | + } |
|
353 | 364 | } |
354 | 365 | // In all other cases, just add the part to the replacement. |
355 | - else |
|
356 | - $replacement .= $part; |
|
366 | + else { |
|
367 | + $replacement .= $part; |
|
368 | + } |
|
357 | 369 | } |
358 | 370 | |
359 | 371 | // Now put back the replacement in the text. |
360 | 372 | $text = $replacement; |
361 | 373 | |
362 | 374 | // We are not finished yet, request more time. |
363 | - if (connection_aborted() && $context['server']['is_apache']) |
|
364 | - @apache_reset_timeout(); |
|
375 | + if (connection_aborted() && $context['server']['is_apache']) { |
|
376 | + @apache_reset_timeout(); |
|
377 | + } |
|
365 | 378 | |
366 | 379 | // Let's pull out any legacy alignments. |
367 | 380 | while (preg_match('~<([A-Za-z]+)\s+[^<>]*?(align="*(left|center|right)"*)[^<>]*?(/?)>~i', $text, $matches) === 1) |
368 | 381 | { |
369 | 382 | // Find the position in the text of this tag over again. |
370 | 383 | $start_pos = strpos($text, $matches[0]); |
371 | - if ($start_pos === false) |
|
372 | - break; |
|
384 | + if ($start_pos === false) { |
|
385 | + break; |
|
386 | + } |
|
373 | 387 | |
374 | 388 | // End tag? |
375 | 389 | if ($matches[4] != '/' && strpos($text, '</' . $matches[1] . '>', $start_pos) !== false) |
@@ -383,8 +397,7 @@ discard block |
||
383 | 397 | |
384 | 398 | // Put the tags back into the body. |
385 | 399 | $text = substr($text, 0, $start_pos) . $tag . '[' . $matches[3] . ']' . $content . '[/' . $matches[3] . ']' . substr($text, $end_pos); |
386 | - } |
|
387 | - else |
|
400 | + } else |
|
388 | 401 | { |
389 | 402 | // Just get rid of this evil tag. |
390 | 403 | $text = substr($text, 0, $start_pos) . substr($text, $start_pos + strlen($matches[0])); |
@@ -397,8 +410,9 @@ discard block |
||
397 | 410 | // Find the position of this again. |
398 | 411 | $start_pos = strpos($text, $matches[0]); |
399 | 412 | $end_pos = false; |
400 | - if ($start_pos === false) |
|
401 | - break; |
|
413 | + if ($start_pos === false) { |
|
414 | + break; |
|
415 | + } |
|
402 | 416 | |
403 | 417 | // This must have an end tag - and we must find the right one. |
404 | 418 | $lower_text = strtolower($text); |
@@ -431,8 +445,9 @@ discard block |
||
431 | 445 | break; |
432 | 446 | } |
433 | 447 | } |
434 | - if ($end_pos === false) |
|
435 | - break; |
|
448 | + if ($end_pos === false) { |
|
449 | + break; |
|
450 | + } |
|
436 | 451 | |
437 | 452 | // Now work out what the attributes are. |
438 | 453 | $attribs = fetchTagAttributes($matches[1]); |
@@ -446,11 +461,11 @@ discard block |
||
446 | 461 | $v = (int) trim($v); |
447 | 462 | $v = empty($v) ? 1 : $v; |
448 | 463 | $tags[] = array('[size=' . $sizes_equivalence[$v] . ']', '[/size]'); |
464 | + } elseif ($s == 'face') { |
|
465 | + $tags[] = array('[font=' . trim(strtolower($v)) . ']', '[/font]'); |
|
466 | + } elseif ($s == 'color') { |
|
467 | + $tags[] = array('[color=' . trim(strtolower($v)) . ']', '[/color]'); |
|
449 | 468 | } |
450 | - elseif ($s == 'face') |
|
451 | - $tags[] = array('[font=' . trim(strtolower($v)) . ']', '[/font]'); |
|
452 | - elseif ($s == 'color') |
|
453 | - $tags[] = array('[color=' . trim(strtolower($v)) . ']', '[/color]'); |
|
454 | 469 | } |
455 | 470 | |
456 | 471 | // As before add in our tags. |
@@ -458,8 +473,9 @@ discard block |
||
458 | 473 | foreach ($tags as $tag) |
459 | 474 | { |
460 | 475 | $before .= $tag[0]; |
461 | - if (isset($tag[1])) |
|
462 | - $after = $tag[1] . $after; |
|
476 | + if (isset($tag[1])) { |
|
477 | + $after = $tag[1] . $after; |
|
478 | + } |
|
463 | 479 | } |
464 | 480 | |
465 | 481 | // Remove the tag so it's never checked again. |
@@ -470,8 +486,9 @@ discard block |
||
470 | 486 | } |
471 | 487 | |
472 | 488 | // Almost there, just a little more time. |
473 | - if (connection_aborted() && $context['server']['is_apache']) |
|
474 | - @apache_reset_timeout(); |
|
489 | + if (connection_aborted() && $context['server']['is_apache']) { |
|
490 | + @apache_reset_timeout(); |
|
491 | + } |
|
475 | 492 | |
476 | 493 | if (count($parts = preg_split('~<(/?)(li|ol|ul)([^>]*)>~i', $text, null, PREG_SPLIT_DELIM_CAPTURE)) > 1) |
477 | 494 | { |
@@ -527,12 +544,13 @@ discard block |
||
527 | 544 | { |
528 | 545 | $inList = true; |
529 | 546 | |
530 | - if ($tag === 'ol') |
|
531 | - $listType = 'decimal'; |
|
532 | - elseif (preg_match('~type="?(' . implode('|', array_keys($listTypeMapping)) . ')"?~', $parts[$i + 3], $match) === 1) |
|
533 | - $listType = $listTypeMapping[$match[1]]; |
|
534 | - else |
|
535 | - $listType = null; |
|
547 | + if ($tag === 'ol') { |
|
548 | + $listType = 'decimal'; |
|
549 | + } elseif (preg_match('~type="?(' . implode('|', array_keys($listTypeMapping)) . ')"?~', $parts[$i + 3], $match) === 1) { |
|
550 | + $listType = $listTypeMapping[$match[1]]; |
|
551 | + } else { |
|
552 | + $listType = null; |
|
553 | + } |
|
536 | 554 | |
537 | 555 | $listDepth++; |
538 | 556 | |
@@ -596,9 +614,7 @@ discard block |
||
596 | 614 | $parts[$i + 1] = ''; |
597 | 615 | $parts[$i + 2] = str_repeat("\t", $listDepth) . '[/list]'; |
598 | 616 | $parts[$i + 3] = ''; |
599 | - } |
|
600 | - |
|
601 | - else |
|
617 | + } else |
|
602 | 618 | { |
603 | 619 | // We're in a list item. |
604 | 620 | if ($listDepth > 0) |
@@ -635,9 +651,7 @@ discard block |
||
635 | 651 | $parts[$i + 1] = ''; |
636 | 652 | $parts[$i + 2] = ''; |
637 | 653 | $parts[$i + 3] = ''; |
638 | - } |
|
639 | - |
|
640 | - else |
|
654 | + } else |
|
641 | 655 | { |
642 | 656 | // Remove the trailing breaks from the list item. |
643 | 657 | $parts[$i] = preg_replace('~\s*<br\s*' . '/?' . '>\s*$~', '', $parts[$i]); |
@@ -675,8 +689,9 @@ discard block |
||
675 | 689 | $text .= str_repeat("\t", $listDepth) . '[/list]'; |
676 | 690 | } |
677 | 691 | |
678 | - for ($i = $listDepth; $i > 0; $i--) |
|
679 | - $text .= '[/li]' . "\n" . str_repeat("\t", $i - 1) . '[/list]'; |
|
692 | + for ($i = $listDepth; $i > 0; $i--) { |
|
693 | + $text .= '[/li]' . "\n" . str_repeat("\t", $i - 1) . '[/list]'; |
|
694 | + } |
|
680 | 695 | } |
681 | 696 | |
682 | 697 | // I love my own image... |
@@ -684,8 +699,9 @@ discard block |
||
684 | 699 | { |
685 | 700 | // Find the position of the image. |
686 | 701 | $start_pos = strpos($text, $matches[0]); |
687 | - if ($start_pos === false) |
|
688 | - break; |
|
702 | + if ($start_pos === false) { |
|
703 | + break; |
|
704 | + } |
|
689 | 705 | $end_pos = $start_pos + strlen($matches[0]); |
690 | 706 | |
691 | 707 | $params = ''; |
@@ -694,12 +710,13 @@ discard block |
||
694 | 710 | $attrs = fetchTagAttributes($matches[1]); |
695 | 711 | foreach ($attrs as $attrib => $value) |
696 | 712 | { |
697 | - if (in_array($attrib, array('width', 'height'))) |
|
698 | - $params .= ' ' . $attrib . '=' . (int) $value; |
|
699 | - elseif ($attrib == 'alt' && trim($value) != '') |
|
700 | - $params .= ' alt=' . trim($value); |
|
701 | - elseif ($attrib == 'src') |
|
702 | - $src = trim($value); |
|
713 | + if (in_array($attrib, array('width', 'height'))) { |
|
714 | + $params .= ' ' . $attrib . '=' . (int) $value; |
|
715 | + } elseif ($attrib == 'alt' && trim($value) != '') { |
|
716 | + $params .= ' alt=' . trim($value); |
|
717 | + } elseif ($attrib == 'src') { |
|
718 | + $src = trim($value); |
|
719 | + } |
|
703 | 720 | } |
704 | 721 | |
705 | 722 | $tag = ''; |
@@ -710,10 +727,11 @@ discard block |
||
710 | 727 | { |
711 | 728 | $baseURL = (isset($parsedURL['scheme']) ? $parsedURL['scheme'] : 'http') . '://' . $parsedURL['host'] . (empty($parsedURL['port']) ? '' : ':' . $parsedURL['port']); |
712 | 729 | |
713 | - if (substr($src, 0, 1) === '/') |
|
714 | - $src = $baseURL . $src; |
|
715 | - else |
|
716 | - $src = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $src; |
|
730 | + if (substr($src, 0, 1) === '/') { |
|
731 | + $src = $baseURL . $src; |
|
732 | + } else { |
|
733 | + $src = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $src; |
|
734 | + } |
|
717 | 735 | } |
718 | 736 | |
719 | 737 | $tag = '[img' . $params . ']' . $src . '[/img]'; |
@@ -891,20 +909,23 @@ discard block |
||
891 | 909 | }, |
892 | 910 | ); |
893 | 911 | |
894 | - foreach ($tags as $tag => $replace) |
|
895 | - $text = preg_replace_callback($tag, $replace, $text); |
|
912 | + foreach ($tags as $tag => $replace) { |
|
913 | + $text = preg_replace_callback($tag, $replace, $text); |
|
914 | + } |
|
896 | 915 | |
897 | 916 | // Please give us just a little more time. |
898 | - if (connection_aborted() && $context['server']['is_apache']) |
|
899 | - @apache_reset_timeout(); |
|
917 | + if (connection_aborted() && $context['server']['is_apache']) { |
|
918 | + @apache_reset_timeout(); |
|
919 | + } |
|
900 | 920 | |
901 | 921 | // What about URL's - the pain in the ass of the tag world. |
902 | 922 | while (preg_match('~<a\s+([^<>]*)>([^<>]*)</a>~i', $text, $matches) === 1) |
903 | 923 | { |
904 | 924 | // Find the position of the URL. |
905 | 925 | $start_pos = strpos($text, $matches[0]); |
906 | - if ($start_pos === false) |
|
907 | - break; |
|
926 | + if ($start_pos === false) { |
|
927 | + break; |
|
928 | + } |
|
908 | 929 | $end_pos = $start_pos + strlen($matches[0]); |
909 | 930 | |
910 | 931 | $tag_type = 'url'; |
@@ -918,8 +939,9 @@ discard block |
||
918 | 939 | $href = trim($value); |
919 | 940 | |
920 | 941 | // Are we dealing with an FTP link? |
921 | - if (preg_match('~^ftps?://~', $href) === 1) |
|
922 | - $tag_type = 'ftp'; |
|
942 | + if (preg_match('~^ftps?://~', $href) === 1) { |
|
943 | + $tag_type = 'ftp'; |
|
944 | + } |
|
923 | 945 | |
924 | 946 | // Or is this a link to an email address? |
925 | 947 | elseif (substr($href, 0, 7) == 'mailto:') |
@@ -933,28 +955,31 @@ discard block |
||
933 | 955 | { |
934 | 956 | $baseURL = (isset($parsedURL['scheme']) ? $parsedURL['scheme'] : 'http') . '://' . $parsedURL['host'] . (empty($parsedURL['port']) ? '' : ':' . $parsedURL['port']); |
935 | 957 | |
936 | - if (substr($href, 0, 1) === '/') |
|
937 | - $href = $baseURL . $href; |
|
938 | - else |
|
939 | - $href = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $href; |
|
958 | + if (substr($href, 0, 1) === '/') { |
|
959 | + $href = $baseURL . $href; |
|
960 | + } else { |
|
961 | + $href = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $href; |
|
962 | + } |
|
940 | 963 | } |
941 | 964 | } |
942 | 965 | |
943 | 966 | // External URL? |
944 | 967 | if ($attrib == 'target' && $tag_type == 'url') |
945 | 968 | { |
946 | - if (trim($value) == '_blank') |
|
947 | - $tag_type == 'iurl'; |
|
969 | + if (trim($value) == '_blank') { |
|
970 | + $tag_type == 'iurl'; |
|
971 | + } |
|
948 | 972 | } |
949 | 973 | } |
950 | 974 | |
951 | 975 | $tag = ''; |
952 | 976 | if ($href != '') |
953 | 977 | { |
954 | - if ($matches[2] == $href) |
|
955 | - $tag = '[' . $tag_type . ']' . $href . '[/' . $tag_type . ']'; |
|
956 | - else |
|
957 | - $tag = '[' . $tag_type . '=' . $href . ']' . $matches[2] . '[/' . $tag_type . ']'; |
|
978 | + if ($matches[2] == $href) { |
|
979 | + $tag = '[' . $tag_type . ']' . $href . '[/' . $tag_type . ']'; |
|
980 | + } else { |
|
981 | + $tag = '[' . $tag_type . '=' . $href . ']' . $matches[2] . '[/' . $tag_type . ']'; |
|
982 | + } |
|
958 | 983 | } |
959 | 984 | |
960 | 985 | // Replace the tag |
@@ -994,17 +1019,18 @@ discard block |
||
994 | 1019 | // We're either moving from the key to the attribute or we're in a string and this is fine. |
995 | 1020 | if ($text[$i] == '=') |
996 | 1021 | { |
997 | - if ($tag_state == 0) |
|
998 | - $tag_state = 1; |
|
999 | - elseif ($tag_state == 2) |
|
1000 | - $value .= '='; |
|
1022 | + if ($tag_state == 0) { |
|
1023 | + $tag_state = 1; |
|
1024 | + } elseif ($tag_state == 2) { |
|
1025 | + $value .= '='; |
|
1026 | + } |
|
1001 | 1027 | } |
1002 | 1028 | // A space is either moving from an attribute back to a potential key or in a string is fine. |
1003 | 1029 | elseif ($text[$i] == ' ') |
1004 | 1030 | { |
1005 | - if ($tag_state == 2) |
|
1006 | - $value .= ' '; |
|
1007 | - elseif ($tag_state == 1) |
|
1031 | + if ($tag_state == 2) { |
|
1032 | + $value .= ' '; |
|
1033 | + } elseif ($tag_state == 1) |
|
1008 | 1034 | { |
1009 | 1035 | $attribs[$key] = $value; |
1010 | 1036 | $key = $value = ''; |
@@ -1015,24 +1041,27 @@ discard block |
||
1015 | 1041 | elseif ($text[$i] == '"') |
1016 | 1042 | { |
1017 | 1043 | // Must be either going into or out of a string. |
1018 | - if ($tag_state == 1) |
|
1019 | - $tag_state = 2; |
|
1020 | - else |
|
1021 | - $tag_state = 1; |
|
1044 | + if ($tag_state == 1) { |
|
1045 | + $tag_state = 2; |
|
1046 | + } else { |
|
1047 | + $tag_state = 1; |
|
1048 | + } |
|
1022 | 1049 | } |
1023 | 1050 | // Otherwise it's fine. |
1024 | 1051 | else |
1025 | 1052 | { |
1026 | - if ($tag_state == 0) |
|
1027 | - $key .= $text[$i]; |
|
1028 | - else |
|
1029 | - $value .= $text[$i]; |
|
1053 | + if ($tag_state == 0) { |
|
1054 | + $key .= $text[$i]; |
|
1055 | + } else { |
|
1056 | + $value .= $text[$i]; |
|
1057 | + } |
|
1030 | 1058 | } |
1031 | 1059 | } |
1032 | 1060 | |
1033 | 1061 | // Anything left? |
1034 | - if ($key != '' && $value != '') |
|
1035 | - $attribs[$key] = $value; |
|
1062 | + if ($key != '' && $value != '') { |
|
1063 | + $attribs[$key] = $value; |
|
1064 | + } |
|
1036 | 1065 | |
1037 | 1066 | return $attribs; |
1038 | 1067 | } |
@@ -1050,15 +1079,17 @@ discard block |
||
1050 | 1079 | global $modSettings; |
1051 | 1080 | |
1052 | 1081 | // Don't care about the texts that are too short. |
1053 | - if (strlen($text) < 3) |
|
1054 | - return $text; |
|
1082 | + if (strlen($text) < 3) { |
|
1083 | + return $text; |
|
1084 | + } |
|
1055 | 1085 | |
1056 | 1086 | // A list of tags that's disabled by the admin. |
1057 | 1087 | $disabled = empty($modSettings['disabledBBC']) ? array() : array_flip(explode(',', strtolower($modSettings['disabledBBC']))); |
1058 | 1088 | |
1059 | 1089 | // Add flash if it's disabled as embedded tag. |
1060 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1061 | - $disabled['flash'] = true; |
|
1090 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1091 | + $disabled['flash'] = true; |
|
1092 | + } |
|
1062 | 1093 | |
1063 | 1094 | // Get a list of all the tags that are not disabled. |
1064 | 1095 | $all_tags = parse_bbc(false); |
@@ -1066,10 +1097,12 @@ discard block |
||
1066 | 1097 | $self_closing_tags = array(); |
1067 | 1098 | foreach ($all_tags as $tag) |
1068 | 1099 | { |
1069 | - if (!isset($disabled[$tag['tag']])) |
|
1070 | - $valid_tags[$tag['tag']] = !empty($tag['block_level']); |
|
1071 | - if (isset($tag['type']) && $tag['type'] == 'closed') |
|
1072 | - $self_closing_tags[] = $tag['tag']; |
|
1100 | + if (!isset($disabled[$tag['tag']])) { |
|
1101 | + $valid_tags[$tag['tag']] = !empty($tag['block_level']); |
|
1102 | + } |
|
1103 | + if (isset($tag['type']) && $tag['type'] == 'closed') { |
|
1104 | + $self_closing_tags[] = $tag['tag']; |
|
1105 | + } |
|
1073 | 1106 | } |
1074 | 1107 | |
1075 | 1108 | // Right - we're going to start by going through the whole lot to make sure we don't have align stuff crossed as this happens load and is stupid! |
@@ -1096,16 +1129,19 @@ discard block |
||
1096 | 1129 | $tagName = substr($match, $isClosingTag ? 2 : 1, -1); |
1097 | 1130 | |
1098 | 1131 | // We're closing the exact same tag that we opened. |
1099 | - if ($isClosingTag && $insideTag === $tagName) |
|
1100 | - $insideTag = null; |
|
1132 | + if ($isClosingTag && $insideTag === $tagName) { |
|
1133 | + $insideTag = null; |
|
1134 | + } |
|
1101 | 1135 | |
1102 | 1136 | // We're opening a tag and we're not yet inside one either |
1103 | - elseif (!$isClosingTag && $insideTag === null) |
|
1104 | - $insideTag = $tagName; |
|
1137 | + elseif (!$isClosingTag && $insideTag === null) { |
|
1138 | + $insideTag = $tagName; |
|
1139 | + } |
|
1105 | 1140 | |
1106 | 1141 | // In all other cases, this tag must be invalid |
1107 | - else |
|
1108 | - unset($matches[$i]); |
|
1142 | + else { |
|
1143 | + unset($matches[$i]); |
|
1144 | + } |
|
1109 | 1145 | } |
1110 | 1146 | |
1111 | 1147 | // The next one is gonna be the other one. |
@@ -1113,8 +1149,9 @@ discard block |
||
1113 | 1149 | } |
1114 | 1150 | |
1115 | 1151 | // We're still inside a tag and had no chance for closure? |
1116 | - if ($insideTag !== null) |
|
1117 | - $matches[] = '[/' . $insideTag . ']'; |
|
1152 | + if ($insideTag !== null) { |
|
1153 | + $matches[] = '[/' . $insideTag . ']'; |
|
1154 | + } |
|
1118 | 1155 | |
1119 | 1156 | // And a complete text string again. |
1120 | 1157 | $text = implode('', $matches); |
@@ -1123,8 +1160,9 @@ discard block |
||
1123 | 1160 | // Quickly remove any tags which are back to back. |
1124 | 1161 | $backToBackPattern = '~\\[(' . implode('|', array_diff(array_keys($valid_tags), array('td', 'anchor'))) . ')[^<>\\[\\]]*\\]\s*\\[/\\1\\]~'; |
1125 | 1162 | $lastlen = 0; |
1126 | - while (strlen($text) !== $lastlen) |
|
1127 | - $lastlen = strlen($text = preg_replace($backToBackPattern, '', $text)); |
|
1163 | + while (strlen($text) !== $lastlen) { |
|
1164 | + $lastlen = strlen($text = preg_replace($backToBackPattern, '', $text)); |
|
1165 | + } |
|
1128 | 1166 | |
1129 | 1167 | // Need to sort the tags my name length. |
1130 | 1168 | uksort($valid_tags, 'sort_array_length'); |
@@ -1161,8 +1199,9 @@ discard block |
||
1161 | 1199 | $isCompetingTag = in_array($tag, $competing_tags); |
1162 | 1200 | |
1163 | 1201 | // Check if this might be one of those cleaned out tags. |
1164 | - if ($tag === '') |
|
1165 | - continue; |
|
1202 | + if ($tag === '') { |
|
1203 | + continue; |
|
1204 | + } |
|
1166 | 1205 | |
1167 | 1206 | // Special case: inside [code] blocks any code is left untouched. |
1168 | 1207 | elseif ($tag === 'code') |
@@ -1173,8 +1212,9 @@ discard block |
||
1173 | 1212 | $inCode = false; |
1174 | 1213 | |
1175 | 1214 | // Reopen tags that were closed before the code block. |
1176 | - if (!empty($inlineElements)) |
|
1177 | - $parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']'; |
|
1215 | + if (!empty($inlineElements)) { |
|
1216 | + $parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']'; |
|
1217 | + } |
|
1178 | 1218 | } |
1179 | 1219 | |
1180 | 1220 | // We're outside a coding and nobbc block and opening it. |
@@ -1203,8 +1243,9 @@ discard block |
||
1203 | 1243 | $inNoBbc = false; |
1204 | 1244 | |
1205 | 1245 | // Some inline elements might've been closed that need reopening. |
1206 | - if (!empty($inlineElements)) |
|
1207 | - $parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']'; |
|
1246 | + if (!empty($inlineElements)) { |
|
1247 | + $parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']'; |
|
1248 | + } |
|
1208 | 1249 | } |
1209 | 1250 | |
1210 | 1251 | // We're outside a nobbc and coding block and opening it. |
@@ -1224,8 +1265,9 @@ discard block |
||
1224 | 1265 | } |
1225 | 1266 | |
1226 | 1267 | // So, we're inside one of the special blocks: ignore any tag. |
1227 | - elseif ($inCode || $inNoBbc) |
|
1228 | - continue; |
|
1268 | + elseif ($inCode || $inNoBbc) { |
|
1269 | + continue; |
|
1270 | + } |
|
1229 | 1271 | |
1230 | 1272 | // We're dealing with an opening tag. |
1231 | 1273 | if ($isOpeningTag) |
@@ -1266,8 +1308,9 @@ discard block |
||
1266 | 1308 | if ($parts[$j + 3] === $tag) |
1267 | 1309 | { |
1268 | 1310 | // If it's an opening tag, increase the level. |
1269 | - if ($parts[$j + 2] === '') |
|
1270 | - $curLevel++; |
|
1311 | + if ($parts[$j + 2] === '') { |
|
1312 | + $curLevel++; |
|
1313 | + } |
|
1271 | 1314 | |
1272 | 1315 | // A closing tag, decrease the level. |
1273 | 1316 | else |
@@ -1290,13 +1333,15 @@ discard block |
||
1290 | 1333 | { |
1291 | 1334 | if ($isCompetingTag) |
1292 | 1335 | { |
1293 | - if (!isset($competingElements[$tag])) |
|
1294 | - $competingElements[$tag] = array(); |
|
1336 | + if (!isset($competingElements[$tag])) { |
|
1337 | + $competingElements[$tag] = array(); |
|
1338 | + } |
|
1295 | 1339 | |
1296 | 1340 | $competingElements[$tag][] = $parts[$i + 4]; |
1297 | 1341 | |
1298 | - if (count($competingElements[$tag]) > 1) |
|
1299 | - $parts[$i] .= '[/' . $tag . ']'; |
|
1342 | + if (count($competingElements[$tag]) > 1) { |
|
1343 | + $parts[$i] .= '[/' . $tag . ']'; |
|
1344 | + } |
|
1300 | 1345 | } |
1301 | 1346 | |
1302 | 1347 | $inlineElements[$elementContent] = $tag; |
@@ -1316,15 +1361,17 @@ discard block |
||
1316 | 1361 | $addClosingTags = array(); |
1317 | 1362 | while ($element = array_pop($blockElements)) |
1318 | 1363 | { |
1319 | - if ($element === $tag) |
|
1320 | - break; |
|
1364 | + if ($element === $tag) { |
|
1365 | + break; |
|
1366 | + } |
|
1321 | 1367 | |
1322 | 1368 | // Still a block tag was open not equal to this tag. |
1323 | 1369 | $addClosingTags[] = $element['type']; |
1324 | 1370 | } |
1325 | 1371 | |
1326 | - if (!empty($addClosingTags)) |
|
1327 | - $parts[$i + 1] = '[/' . implode('][/', array_reverse($addClosingTags)) . ']' . $parts[$i + 1]; |
|
1372 | + if (!empty($addClosingTags)) { |
|
1373 | + $parts[$i + 1] = '[/' . implode('][/', array_reverse($addClosingTags)) . ']' . $parts[$i + 1]; |
|
1374 | + } |
|
1328 | 1375 | |
1329 | 1376 | // Apparently the closing tag was not found on the stack. |
1330 | 1377 | if (!is_string($element) || $element !== $tag) |
@@ -1334,8 +1381,7 @@ discard block |
||
1334 | 1381 | $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = ''; |
1335 | 1382 | continue; |
1336 | 1383 | } |
1337 | - } |
|
1338 | - else |
|
1384 | + } else |
|
1339 | 1385 | { |
1340 | 1386 | // Get rid of this closing tag! |
1341 | 1387 | $parts[$i + 1] = $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = ''; |
@@ -1364,53 +1410,62 @@ discard block |
||
1364 | 1410 | unset($inlineElements[$tagContentToBeClosed]); |
1365 | 1411 | |
1366 | 1412 | // Was this the tag we were looking for? |
1367 | - if ($tagToBeClosed === $tag) |
|
1368 | - break; |
|
1413 | + if ($tagToBeClosed === $tag) { |
|
1414 | + break; |
|
1415 | + } |
|
1369 | 1416 | |
1370 | 1417 | // Nope, close it and look further! |
1371 | - else |
|
1372 | - $parts[$i] .= '[/' . $tagToBeClosed . ']'; |
|
1418 | + else { |
|
1419 | + $parts[$i] .= '[/' . $tagToBeClosed . ']'; |
|
1420 | + } |
|
1373 | 1421 | } |
1374 | 1422 | |
1375 | 1423 | if ($isCompetingTag && !empty($competingElements[$tag])) |
1376 | 1424 | { |
1377 | 1425 | array_pop($competingElements[$tag]); |
1378 | 1426 | |
1379 | - if (count($competingElements[$tag]) > 0) |
|
1380 | - $parts[$i + 5] = '[' . $tag . $competingElements[$tag][count($competingElements[$tag]) - 1] . $parts[$i + 5]; |
|
1427 | + if (count($competingElements[$tag]) > 0) { |
|
1428 | + $parts[$i + 5] = '[' . $tag . $competingElements[$tag][count($competingElements[$tag]) - 1] . $parts[$i + 5]; |
|
1429 | + } |
|
1381 | 1430 | } |
1382 | 1431 | } |
1383 | 1432 | |
1384 | 1433 | // Unexpected closing tag, ex-ter-mi-nate. |
1385 | - else |
|
1386 | - $parts[$i + 1] = $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = ''; |
|
1434 | + else { |
|
1435 | + $parts[$i + 1] = $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = ''; |
|
1436 | + } |
|
1387 | 1437 | } |
1388 | 1438 | } |
1389 | 1439 | } |
1390 | 1440 | |
1391 | 1441 | // Close the code tags. |
1392 | - if ($inCode) |
|
1393 | - $parts[$i] .= '[/code]'; |
|
1442 | + if ($inCode) { |
|
1443 | + $parts[$i] .= '[/code]'; |
|
1444 | + } |
|
1394 | 1445 | |
1395 | 1446 | // The same for nobbc tags. |
1396 | - elseif ($inNoBbc) |
|
1397 | - $parts[$i] .= '[/nobbc]'; |
|
1447 | + elseif ($inNoBbc) { |
|
1448 | + $parts[$i] .= '[/nobbc]'; |
|
1449 | + } |
|
1398 | 1450 | |
1399 | 1451 | // Still inline tags left unclosed? Close them now, better late than never. |
1400 | - elseif (!empty($inlineElements)) |
|
1401 | - $parts[$i] .= '[/' . implode('][/', array_reverse($inlineElements)) . ']'; |
|
1452 | + elseif (!empty($inlineElements)) { |
|
1453 | + $parts[$i] .= '[/' . implode('][/', array_reverse($inlineElements)) . ']'; |
|
1454 | + } |
|
1402 | 1455 | |
1403 | 1456 | // Now close the block elements. |
1404 | - if (!empty($blockElements)) |
|
1405 | - $parts[$i] .= '[/' . implode('][/', array_reverse($blockElements)) . ']'; |
|
1457 | + if (!empty($blockElements)) { |
|
1458 | + $parts[$i] .= '[/' . implode('][/', array_reverse($blockElements)) . ']'; |
|
1459 | + } |
|
1406 | 1460 | |
1407 | 1461 | $text = implode('', $parts); |
1408 | 1462 | } |
1409 | 1463 | |
1410 | 1464 | // Final clean up of back to back tags. |
1411 | 1465 | $lastlen = 0; |
1412 | - while (strlen($text) !== $lastlen) |
|
1413 | - $lastlen = strlen($text = preg_replace($backToBackPattern, '', $text)); |
|
1466 | + while (strlen($text) !== $lastlen) { |
|
1467 | + $lastlen = strlen($text = preg_replace($backToBackPattern, '', $text)); |
|
1468 | + } |
|
1414 | 1469 | |
1415 | 1470 | return $text; |
1416 | 1471 | } |
@@ -1441,22 +1496,25 @@ discard block |
||
1441 | 1496 | $context['template_layers'] = array(); |
1442 | 1497 | // Lets make sure we aren't going to output anything nasty. |
1443 | 1498 | @ob_end_clean(); |
1444 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
1445 | - @ob_start('ob_gzhandler'); |
|
1446 | - else |
|
1447 | - @ob_start(); |
|
1499 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
1500 | + @ob_start('ob_gzhandler'); |
|
1501 | + } else { |
|
1502 | + @ob_start(); |
|
1503 | + } |
|
1448 | 1504 | |
1449 | 1505 | // If we don't have any locale better avoid broken js |
1450 | - if (empty($txt['lang_locale'])) |
|
1451 | - die(); |
|
1506 | + if (empty($txt['lang_locale'])) { |
|
1507 | + die(); |
|
1508 | + } |
|
1452 | 1509 | |
1453 | 1510 | $file_data = '(function ($) { |
1454 | 1511 | \'use strict\'; |
1455 | 1512 | |
1456 | 1513 | $.sceditor.locale[' . JavaScriptEscape($txt['lang_locale']) . '] = {'; |
1457 | - foreach ($editortxt as $key => $val) |
|
1458 | - $file_data .= ' |
|
1514 | + foreach ($editortxt as $key => $val) { |
|
1515 | + $file_data .= ' |
|
1459 | 1516 | ' . JavaScriptEscape($key) . ': ' . JavaScriptEscape($val) . ','; |
1517 | + } |
|
1460 | 1518 | |
1461 | 1519 | $file_data .= ' |
1462 | 1520 | dateFormat: "day.month.year" |
@@ -1524,8 +1582,9 @@ discard block |
||
1524 | 1582 | ) |
1525 | 1583 | ); |
1526 | 1584 | $icon_data = array(); |
1527 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1528 | - $icon_data[] = $row; |
|
1585 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1586 | + $icon_data[] = $row; |
|
1587 | + } |
|
1529 | 1588 | $smcFunc['db_free_result']($request); |
1530 | 1589 | |
1531 | 1590 | $icons = array(); |
@@ -1540,9 +1599,9 @@ discard block |
||
1540 | 1599 | } |
1541 | 1600 | |
1542 | 1601 | cache_put_data('posting_icons-' . $board_id, $icons, 480); |
1602 | + } else { |
|
1603 | + $icons = $temp; |
|
1543 | 1604 | } |
1544 | - else |
|
1545 | - $icons = $temp; |
|
1546 | 1605 | } |
1547 | 1606 | call_integration_hook('integrate_load_message_icons', array(&$icons)); |
1548 | 1607 | |
@@ -1585,8 +1644,9 @@ discard block |
||
1585 | 1644 | { |
1586 | 1645 | // Some general stuff. |
1587 | 1646 | $settings['smileys_url'] = $modSettings['smileys_url'] . '/' . $user_info['smiley_set']; |
1588 | - if (!empty($context['drafts_autosave'])) |
|
1589 | - $context['drafts_autosave_frequency'] = empty($modSettings['drafts_autosave_frequency']) ? 60000 : $modSettings['drafts_autosave_frequency'] * 1000; |
|
1647 | + if (!empty($context['drafts_autosave'])) { |
|
1648 | + $context['drafts_autosave_frequency'] = empty($modSettings['drafts_autosave_frequency']) ? 60000 : $modSettings['drafts_autosave_frequency'] * 1000; |
|
1649 | + } |
|
1590 | 1650 | |
1591 | 1651 | // This really has some WYSIWYG stuff. |
1592 | 1652 | loadCSSFile('jquery.sceditor.css', array('force_current' => false, 'validate' => true), 'smf_jquery_sceditor'); |
@@ -1603,8 +1663,9 @@ discard block |
||
1603 | 1663 | var bbc_quote = \'' . addcslashes($txt['quote'], "'") . '\'; |
1604 | 1664 | var bbc_search_on = \'' . addcslashes($txt['search_on'], "'") . '\';'); |
1605 | 1665 | // editor language file |
1606 | - if (!empty($txt['lang_locale']) && $txt['lang_locale'] != 'en_US') |
|
1607 | - loadJavaScriptFile($scripturl . '?action=loadeditorlocale', array('external' => true), 'sceditor_language'); |
|
1666 | + if (!empty($txt['lang_locale']) && $txt['lang_locale'] != 'en_US') { |
|
1667 | + loadJavaScriptFile($scripturl . '?action=loadeditorlocale', array('external' => true), 'sceditor_language'); |
|
1668 | + } |
|
1608 | 1669 | |
1609 | 1670 | $context['shortcuts_text'] = $txt['shortcuts' . (!empty($context['drafts_save']) ? '_drafts' : '') . (stripos($_SERVER['HTTP_USER_AGENT'], 'Macintosh') !== false ? '_mac' : (isBrowser('is_firefox') ? '_firefox' : ''))]; |
1610 | 1671 | $context['show_spellchecking'] = !empty($modSettings['enableSpellChecking']) && (function_exists('pspell_new') || (function_exists('enchant_broker_init') && ($txt['lang_character_set'] == 'UTF-8' || function_exists('iconv')))); |
@@ -1613,11 +1674,12 @@ discard block |
||
1613 | 1674 | loadJavaScriptFile('spellcheck.js', array('minimize' => true), 'smf_spellcheck'); |
1614 | 1675 | |
1615 | 1676 | // Some hidden information is needed in order to make the spell checking work. |
1616 | - if (!isset($_REQUEST['xml'])) |
|
1617 | - $context['insert_after_template'] .= ' |
|
1677 | + if (!isset($_REQUEST['xml'])) { |
|
1678 | + $context['insert_after_template'] .= ' |
|
1618 | 1679 | <form name="spell_form" id="spell_form" method="post" accept-charset="' . $context['character_set'] . '" target="spellWindow" action="' . $scripturl . '?action=spellcheck"> |
1619 | 1680 | <input type="hidden" name="spellstring" value=""> |
1620 | 1681 | </form>'; |
1682 | + } |
|
1621 | 1683 | } |
1622 | 1684 | } |
1623 | 1685 | |
@@ -1809,10 +1871,12 @@ discard block |
||
1809 | 1871 | |
1810 | 1872 | // Generate a list of buttons that shouldn't be shown - this should be the fastest way to do this. |
1811 | 1873 | $disabled_tags = array(); |
1812 | - if (!empty($modSettings['disabledBBC'])) |
|
1813 | - $disabled_tags = explode(',', $modSettings['disabledBBC']); |
|
1814 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1815 | - $disabled_tags[] = 'flash'; |
|
1874 | + if (!empty($modSettings['disabledBBC'])) { |
|
1875 | + $disabled_tags = explode(',', $modSettings['disabledBBC']); |
|
1876 | + } |
|
1877 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1878 | + $disabled_tags[] = 'flash'; |
|
1879 | + } |
|
1816 | 1880 | |
1817 | 1881 | foreach ($disabled_tags as $tag) |
1818 | 1882 | { |
@@ -1824,9 +1888,10 @@ discard block |
||
1824 | 1888 | $context['disabled_tags']['orderedlist'] = true; |
1825 | 1889 | } |
1826 | 1890 | |
1827 | - foreach ($editor_tag_map as $thisTag => $tagNameBBC) |
|
1828 | - if ($tag === $thisTag) |
|
1891 | + foreach ($editor_tag_map as $thisTag => $tagNameBBC) { |
|
1892 | + if ($tag === $thisTag) |
|
1829 | 1893 | $context['disabled_tags'][$tagNameBBC] = true; |
1894 | + } |
|
1830 | 1895 | |
1831 | 1896 | $context['disabled_tags'][$tag] = true; |
1832 | 1897 | } |
@@ -1837,8 +1902,9 @@ discard block |
||
1837 | 1902 | |
1838 | 1903 | foreach ($context['bbc_tags'] as $row => $tagRow) |
1839 | 1904 | { |
1840 | - if (!isset($context['bbc_toolbar'][$row])) |
|
1841 | - $context['bbc_toolbar'][$row] = array(); |
|
1905 | + if (!isset($context['bbc_toolbar'][$row])) { |
|
1906 | + $context['bbc_toolbar'][$row] = array(); |
|
1907 | + } |
|
1842 | 1908 | |
1843 | 1909 | $tagsRow = array(); |
1844 | 1910 | |
@@ -1874,20 +1940,21 @@ discard block |
||
1874 | 1940 | |
1875 | 1941 | $context['bbcodes_handlers'] .= ' |
1876 | 1942 | });'; |
1877 | - } |
|
1878 | - else |
|
1943 | + } else |
|
1879 | 1944 | { |
1880 | 1945 | $context['bbc_toolbar'][$row][] = implode(',', $tagsRow); |
1881 | 1946 | $tagsRow = array(); |
1882 | 1947 | } |
1883 | 1948 | } |
1884 | 1949 | |
1885 | - if (!empty($tagsRow)) |
|
1886 | - $context['bbc_toolbar'][$row][] = implode(',', $tagsRow); |
|
1950 | + if (!empty($tagsRow)) { |
|
1951 | + $context['bbc_toolbar'][$row][] = implode(',', $tagsRow); |
|
1952 | + } |
|
1887 | 1953 | } |
1888 | 1954 | |
1889 | - if (!empty($bbcodes_styles)) |
|
1890 | - addInlineCss($bbcodes_styles); |
|
1955 | + if (!empty($bbcodes_styles)) { |
|
1956 | + addInlineCss($bbcodes_styles); |
|
1957 | + } |
|
1891 | 1958 | } |
1892 | 1959 | |
1893 | 1960 | // Initialize smiley array... if not loaded before. |
@@ -1899,8 +1966,8 @@ discard block |
||
1899 | 1966 | ); |
1900 | 1967 | |
1901 | 1968 | // Load smileys - don't bother to run a query if we're not using the database's ones anyhow. |
1902 | - if (empty($modSettings['smiley_enable']) && $user_info['smiley_set'] != 'none') |
|
1903 | - $context['smileys']['postform'][] = array( |
|
1969 | + if (empty($modSettings['smiley_enable']) && $user_info['smiley_set'] != 'none') { |
|
1970 | + $context['smileys']['postform'][] = array( |
|
1904 | 1971 | 'smileys' => array( |
1905 | 1972 | array( |
1906 | 1973 | 'code' => ':)', |
@@ -1986,7 +2053,7 @@ discard block |
||
1986 | 2053 | ), |
1987 | 2054 | 'isLast' => true, |
1988 | 2055 | ); |
1989 | - elseif ($user_info['smiley_set'] != 'none') |
|
2056 | + } elseif ($user_info['smiley_set'] != 'none') |
|
1990 | 2057 | { |
1991 | 2058 | if (($temp = cache_get_data('posting_smileys', 480)) == null) |
1992 | 2059 | { |
@@ -2009,17 +2076,19 @@ discard block |
||
2009 | 2076 | |
2010 | 2077 | foreach ($context['smileys'] as $section => $smileyRows) |
2011 | 2078 | { |
2012 | - foreach ($smileyRows as $rowIndex => $smileys) |
|
2013 | - $context['smileys'][$section][$rowIndex]['smileys'][count($smileys['smileys']) - 1]['isLast'] = true; |
|
2079 | + foreach ($smileyRows as $rowIndex => $smileys) { |
|
2080 | + $context['smileys'][$section][$rowIndex]['smileys'][count($smileys['smileys']) - 1]['isLast'] = true; |
|
2081 | + } |
|
2014 | 2082 | |
2015 | - if (!empty($smileyRows)) |
|
2016 | - $context['smileys'][$section][count($smileyRows) - 1]['isLast'] = true; |
|
2083 | + if (!empty($smileyRows)) { |
|
2084 | + $context['smileys'][$section][count($smileyRows) - 1]['isLast'] = true; |
|
2085 | + } |
|
2017 | 2086 | } |
2018 | 2087 | |
2019 | 2088 | cache_put_data('posting_smileys', $context['smileys'], 480); |
2089 | + } else { |
|
2090 | + $context['smileys'] = $temp; |
|
2020 | 2091 | } |
2021 | - else |
|
2022 | - $context['smileys'] = $temp; |
|
2023 | 2092 | } |
2024 | 2093 | } |
2025 | 2094 | |
@@ -2035,12 +2104,15 @@ discard block |
||
2035 | 2104 | 'plugins' => 'undo', |
2036 | 2105 | 'bbcodeTrim' => true, |
2037 | 2106 | ); |
2038 | - if (!empty($context['controls']['richedit'][$editorOptions['id']]['locale'])) |
|
2039 | - $sce_options['locale'] = $context['controls']['richedit'][$editorOptions['id']]['locale']; |
|
2040 | - if (!empty($context['right_to_left'])) |
|
2041 | - $sce_options['rtl'] = true; |
|
2042 | - if ($editorOptions['id'] != 'quickReply') |
|
2043 | - $sce_options['autofocus'] = true; |
|
2107 | + if (!empty($context['controls']['richedit'][$editorOptions['id']]['locale'])) { |
|
2108 | + $sce_options['locale'] = $context['controls']['richedit'][$editorOptions['id']]['locale']; |
|
2109 | + } |
|
2110 | + if (!empty($context['right_to_left'])) { |
|
2111 | + $sce_options['rtl'] = true; |
|
2112 | + } |
|
2113 | + if ($editorOptions['id'] != 'quickReply') { |
|
2114 | + $sce_options['autofocus'] = true; |
|
2115 | + } |
|
2044 | 2116 | |
2045 | 2117 | $sce_options['emoticons'] = array(); |
2046 | 2118 | $sce_options['emoticonsDescriptions'] = array(); |
@@ -2057,10 +2129,11 @@ discard block |
||
2057 | 2129 | $countLocations--; |
2058 | 2130 | |
2059 | 2131 | unset($smiley_location); |
2060 | - if ($location == 'postform') |
|
2061 | - $smiley_location = &$sce_options['emoticons']['dropdown']; |
|
2062 | - elseif ($location == 'popup') |
|
2063 | - $smiley_location = &$sce_options['emoticons']['popup']; |
|
2132 | + if ($location == 'postform') { |
|
2133 | + $smiley_location = &$sce_options['emoticons']['dropdown']; |
|
2134 | + } elseif ($location == 'popup') { |
|
2135 | + $smiley_location = &$sce_options['emoticons']['popup']; |
|
2136 | + } |
|
2064 | 2137 | |
2065 | 2138 | $numRows = count($smileyRows); |
2066 | 2139 | |
@@ -2074,8 +2147,9 @@ discard block |
||
2074 | 2147 | $sce_options['emoticonsDescriptions'][$smiley['code']] = $smiley['description']; |
2075 | 2148 | } |
2076 | 2149 | |
2077 | - if (empty($smileyRow['isLast']) && $numRows != 1) |
|
2078 | - $smiley_location['-' . $emptyPlaceholder++] = ''; |
|
2150 | + if (empty($smileyRow['isLast']) && $numRows != 1) { |
|
2151 | + $smiley_location['-' . $emptyPlaceholder++] = ''; |
|
2152 | + } |
|
2079 | 2153 | } |
2080 | 2154 | } |
2081 | 2155 | } |
@@ -2090,8 +2164,9 @@ discard block |
||
2090 | 2164 | |
2091 | 2165 | $count_tags--; |
2092 | 2166 | |
2093 | - if (!empty($count_tags)) |
|
2094 | - $sce_options['toolbar'] .= '||'; |
|
2167 | + if (!empty($count_tags)) { |
|
2168 | + $sce_options['toolbar'] .= '||'; |
|
2169 | + } |
|
2095 | 2170 | } |
2096 | 2171 | } |
2097 | 2172 | |
@@ -2119,8 +2194,9 @@ discard block |
||
2119 | 2194 | loadTemplate('GenericControls'); |
2120 | 2195 | |
2121 | 2196 | // Some javascript ma'am? |
2122 | - if (!empty($verificationOptions['override_visual']) || (!empty($modSettings['visual_verification_type']) && !isset($verificationOptions['override_visual']))) |
|
2123 | - loadJavaScriptFile('captcha.js', array('minimize' => true), 'smf_captcha'); |
|
2197 | + if (!empty($verificationOptions['override_visual']) || (!empty($modSettings['visual_verification_type']) && !isset($verificationOptions['override_visual']))) { |
|
2198 | + loadJavaScriptFile('captcha.js', array('minimize' => true), 'smf_captcha'); |
|
2199 | + } |
|
2124 | 2200 | |
2125 | 2201 | $context['use_graphic_library'] = in_array('gd', get_loaded_extensions()); |
2126 | 2202 | |
@@ -2133,8 +2209,8 @@ discard block |
||
2133 | 2209 | $isNew = !isset($context['controls']['verification'][$verificationOptions['id']]); |
2134 | 2210 | |
2135 | 2211 | // Log this into our collection. |
2136 | - if ($isNew) |
|
2137 | - $context['controls']['verification'][$verificationOptions['id']] = array( |
|
2212 | + if ($isNew) { |
|
2213 | + $context['controls']['verification'][$verificationOptions['id']] = array( |
|
2138 | 2214 | 'id' => $verificationOptions['id'], |
2139 | 2215 | 'empty_field' => empty($verificationOptions['no_empty_field']), |
2140 | 2216 | 'show_visual' => !empty($verificationOptions['override_visual']) || (!empty($modSettings['visual_verification_type']) && !isset($verificationOptions['override_visual'])), |
@@ -2145,13 +2221,15 @@ discard block |
||
2145 | 2221 | 'questions' => array(), |
2146 | 2222 | 'can_recaptcha' => !empty($modSettings['recaptcha_enabled']) && !empty($modSettings['recaptcha_site_key']) && !empty($modSettings['recaptcha_secret_key']), |
2147 | 2223 | ); |
2224 | + } |
|
2148 | 2225 | $thisVerification = &$context['controls']['verification'][$verificationOptions['id']]; |
2149 | 2226 | |
2150 | 2227 | // Is there actually going to be anything? |
2151 | - if (empty($thisVerification['show_visual']) && empty($thisVerification['number_questions']) && empty($thisVerification['can_recaptcha'])) |
|
2152 | - return false; |
|
2153 | - elseif (!$isNew && !$do_test) |
|
2154 | - return true; |
|
2228 | + if (empty($thisVerification['show_visual']) && empty($thisVerification['number_questions']) && empty($thisVerification['can_recaptcha'])) { |
|
2229 | + return false; |
|
2230 | + } elseif (!$isNew && !$do_test) { |
|
2231 | + return true; |
|
2232 | + } |
|
2155 | 2233 | |
2156 | 2234 | // Sanitize reCAPTCHA fields? |
2157 | 2235 | if ($thisVerification['can_recaptcha']) |
@@ -2164,11 +2242,12 @@ discard block |
||
2164 | 2242 | } |
2165 | 2243 | |
2166 | 2244 | // Add javascript for the object. |
2167 | - if ($context['controls']['verification'][$verificationOptions['id']]['show_visual']) |
|
2168 | - $context['insert_after_template'] .= ' |
|
2245 | + if ($context['controls']['verification'][$verificationOptions['id']]['show_visual']) { |
|
2246 | + $context['insert_after_template'] .= ' |
|
2169 | 2247 | <script> |
2170 | 2248 | var verification' . $verificationOptions['id'] . 'Handle = new smfCaptcha("' . $thisVerification['image_href'] . '", "' . $verificationOptions['id'] . '", ' . ($context['use_graphic_library'] ? 1 : 0) . '); |
2171 | 2249 | </script>'; |
2250 | + } |
|
2172 | 2251 | |
2173 | 2252 | // If we want questions do we have a cache of all the IDs? |
2174 | 2253 | if (!empty($thisVerification['number_questions']) && empty($modSettings['question_id_cache'])) |
@@ -2191,8 +2270,9 @@ discard block |
||
2191 | 2270 | unset ($row['id_question']); |
2192 | 2271 | // Make them all lowercase. We can't directly use $smcFunc['strtolower'] with array_walk, so do it manually, eh? |
2193 | 2272 | $row['answers'] = $smcFunc['json_decode']($row['answers'], true); |
2194 | - foreach ($row['answers'] as $k => $v) |
|
2195 | - $row['answers'][$k] = $smcFunc['strtolower']($v); |
|
2273 | + foreach ($row['answers'] as $k => $v) { |
|
2274 | + $row['answers'][$k] = $smcFunc['strtolower']($v); |
|
2275 | + } |
|
2196 | 2276 | |
2197 | 2277 | $modSettings['question_id_cache']['questions'][$id_question] = $row; |
2198 | 2278 | $modSettings['question_id_cache']['langs'][$row['lngfile']][] = $id_question; |
@@ -2203,35 +2283,42 @@ discard block |
||
2203 | 2283 | } |
2204 | 2284 | } |
2205 | 2285 | |
2206 | - if (!isset($_SESSION[$verificationOptions['id'] . '_vv'])) |
|
2207 | - $_SESSION[$verificationOptions['id'] . '_vv'] = array(); |
|
2286 | + if (!isset($_SESSION[$verificationOptions['id'] . '_vv'])) { |
|
2287 | + $_SESSION[$verificationOptions['id'] . '_vv'] = array(); |
|
2288 | + } |
|
2208 | 2289 | |
2209 | 2290 | // Do we need to refresh the verification? |
2210 | - if (!$do_test && (!empty($_SESSION[$verificationOptions['id'] . '_vv']['did_pass']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['count']) || $_SESSION[$verificationOptions['id'] . '_vv']['count'] > 3) && empty($verificationOptions['dont_refresh'])) |
|
2211 | - $force_refresh = true; |
|
2212 | - else |
|
2213 | - $force_refresh = false; |
|
2291 | + if (!$do_test && (!empty($_SESSION[$verificationOptions['id'] . '_vv']['did_pass']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['count']) || $_SESSION[$verificationOptions['id'] . '_vv']['count'] > 3) && empty($verificationOptions['dont_refresh'])) { |
|
2292 | + $force_refresh = true; |
|
2293 | + } else { |
|
2294 | + $force_refresh = false; |
|
2295 | + } |
|
2214 | 2296 | |
2215 | 2297 | // This can also force a fresh, although unlikely. |
2216 | - if (($thisVerification['show_visual'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['code'])) || ($thisVerification['number_questions'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['q']))) |
|
2217 | - $force_refresh = true; |
|
2298 | + if (($thisVerification['show_visual'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['code'])) || ($thisVerification['number_questions'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['q']))) { |
|
2299 | + $force_refresh = true; |
|
2300 | + } |
|
2218 | 2301 | |
2219 | 2302 | $verification_errors = array(); |
2220 | 2303 | // Start with any testing. |
2221 | 2304 | if ($do_test) |
2222 | 2305 | { |
2223 | 2306 | // This cannot happen! |
2224 | - if (!isset($_SESSION[$verificationOptions['id'] . '_vv']['count'])) |
|
2225 | - fatal_lang_error('no_access', false); |
|
2307 | + if (!isset($_SESSION[$verificationOptions['id'] . '_vv']['count'])) { |
|
2308 | + fatal_lang_error('no_access', false); |
|
2309 | + } |
|
2226 | 2310 | // ... nor this! |
2227 | - if ($thisVerification['number_questions'] && (!isset($_SESSION[$verificationOptions['id'] . '_vv']['q']) || !isset($_REQUEST[$verificationOptions['id'] . '_vv']['q']))) |
|
2228 | - fatal_lang_error('no_access', false); |
|
2311 | + if ($thisVerification['number_questions'] && (!isset($_SESSION[$verificationOptions['id'] . '_vv']['q']) || !isset($_REQUEST[$verificationOptions['id'] . '_vv']['q']))) { |
|
2312 | + fatal_lang_error('no_access', false); |
|
2313 | + } |
|
2229 | 2314 | // Hmm, it's requested but not actually declared. This shouldn't happen. |
2230 | - if ($thisVerification['empty_field'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field'])) |
|
2231 | - fatal_lang_error('no_access', false); |
|
2315 | + if ($thisVerification['empty_field'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field'])) { |
|
2316 | + fatal_lang_error('no_access', false); |
|
2317 | + } |
|
2232 | 2318 | // While we're here, did the user do something bad? |
2233 | - if ($thisVerification['empty_field'] && !empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field']) && !empty($_REQUEST[$_SESSION[$verificationOptions['id'] . '_vv']['empty_field']])) |
|
2234 | - $verification_errors[] = 'wrong_verification_answer'; |
|
2319 | + if ($thisVerification['empty_field'] && !empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field']) && !empty($_REQUEST[$_SESSION[$verificationOptions['id'] . '_vv']['empty_field']])) { |
|
2320 | + $verification_errors[] = 'wrong_verification_answer'; |
|
2321 | + } |
|
2235 | 2322 | |
2236 | 2323 | if ($thisVerification['can_recaptcha']) |
2237 | 2324 | { |
@@ -2242,22 +2329,25 @@ discard block |
||
2242 | 2329 | { |
2243 | 2330 | $resp = $reCaptcha->verify($_POST['g-recaptcha-response'], $user_info['ip']); |
2244 | 2331 | |
2245 | - if (!$resp->isSuccess()) |
|
2246 | - $verification_errors[] = 'wrong_verification_code'; |
|
2332 | + if (!$resp->isSuccess()) { |
|
2333 | + $verification_errors[] = 'wrong_verification_code'; |
|
2334 | + } |
|
2335 | + } else { |
|
2336 | + $verification_errors[] = 'wrong_verification_code'; |
|
2247 | 2337 | } |
2248 | - else |
|
2249 | - $verification_errors[] = 'wrong_verification_code'; |
|
2250 | 2338 | } |
2251 | - if ($thisVerification['show_visual'] && (empty($_REQUEST[$verificationOptions['id'] . '_vv']['code']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['code']) || strtoupper($_REQUEST[$verificationOptions['id'] . '_vv']['code']) !== $_SESSION[$verificationOptions['id'] . '_vv']['code'])) |
|
2252 | - $verification_errors[] = 'wrong_verification_code'; |
|
2339 | + if ($thisVerification['show_visual'] && (empty($_REQUEST[$verificationOptions['id'] . '_vv']['code']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['code']) || strtoupper($_REQUEST[$verificationOptions['id'] . '_vv']['code']) !== $_SESSION[$verificationOptions['id'] . '_vv']['code'])) { |
|
2340 | + $verification_errors[] = 'wrong_verification_code'; |
|
2341 | + } |
|
2253 | 2342 | if ($thisVerification['number_questions']) |
2254 | 2343 | { |
2255 | 2344 | $incorrectQuestions = array(); |
2256 | 2345 | foreach ($_SESSION[$verificationOptions['id'] . '_vv']['q'] as $q) |
2257 | 2346 | { |
2258 | 2347 | // We don't have this question any more, thus no answers. |
2259 | - if (!isset($modSettings['question_id_cache']['questions'][$q])) |
|
2260 | - continue; |
|
2348 | + if (!isset($modSettings['question_id_cache']['questions'][$q])) { |
|
2349 | + continue; |
|
2350 | + } |
|
2261 | 2351 | // This is quite complex. We have our question but it might have multiple answers. |
2262 | 2352 | // First, did they actually answer this question? |
2263 | 2353 | if (!isset($_REQUEST[$verificationOptions['id'] . '_vv']['q'][$q]) || trim($_REQUEST[$verificationOptions['id'] . '_vv']['q'][$q]) == '') |
@@ -2269,24 +2359,28 @@ discard block |
||
2269 | 2359 | else |
2270 | 2360 | { |
2271 | 2361 | $given_answer = trim($smcFunc['htmlspecialchars'](strtolower($_REQUEST[$verificationOptions['id'] . '_vv']['q'][$q]))); |
2272 | - if (!in_array($given_answer, $modSettings['question_id_cache']['questions'][$q]['answers'])) |
|
2273 | - $incorrectQuestions[] = $q; |
|
2362 | + if (!in_array($given_answer, $modSettings['question_id_cache']['questions'][$q]['answers'])) { |
|
2363 | + $incorrectQuestions[] = $q; |
|
2364 | + } |
|
2274 | 2365 | } |
2275 | 2366 | } |
2276 | 2367 | |
2277 | - if (!empty($incorrectQuestions)) |
|
2278 | - $verification_errors[] = 'wrong_verification_answer'; |
|
2368 | + if (!empty($incorrectQuestions)) { |
|
2369 | + $verification_errors[] = 'wrong_verification_answer'; |
|
2370 | + } |
|
2279 | 2371 | } |
2280 | 2372 | } |
2281 | 2373 | |
2282 | 2374 | // Any errors means we refresh potentially. |
2283 | 2375 | if (!empty($verification_errors)) |
2284 | 2376 | { |
2285 | - if (empty($_SESSION[$verificationOptions['id'] . '_vv']['errors'])) |
|
2286 | - $_SESSION[$verificationOptions['id'] . '_vv']['errors'] = 0; |
|
2377 | + if (empty($_SESSION[$verificationOptions['id'] . '_vv']['errors'])) { |
|
2378 | + $_SESSION[$verificationOptions['id'] . '_vv']['errors'] = 0; |
|
2379 | + } |
|
2287 | 2380 | // Too many errors? |
2288 | - elseif ($_SESSION[$verificationOptions['id'] . '_vv']['errors'] > $thisVerification['max_errors']) |
|
2289 | - $force_refresh = true; |
|
2381 | + elseif ($_SESSION[$verificationOptions['id'] . '_vv']['errors'] > $thisVerification['max_errors']) { |
|
2382 | + $force_refresh = true; |
|
2383 | + } |
|
2290 | 2384 | |
2291 | 2385 | // Keep a track of these. |
2292 | 2386 | $_SESSION[$verificationOptions['id'] . '_vv']['errors']++; |
@@ -2319,8 +2413,9 @@ discard block |
||
2319 | 2413 | // Are we overriding the range? |
2320 | 2414 | $character_range = !empty($verificationOptions['override_range']) ? $verificationOptions['override_range'] : $context['standard_captcha_range']; |
2321 | 2415 | |
2322 | - for ($i = 0; $i < 6; $i++) |
|
2323 | - $_SESSION[$verificationOptions['id'] . '_vv']['code'] .= $character_range[array_rand($character_range)]; |
|
2416 | + for ($i = 0; $i < 6; $i++) { |
|
2417 | + $_SESSION[$verificationOptions['id'] . '_vv']['code'] .= $character_range[array_rand($character_range)]; |
|
2418 | + } |
|
2324 | 2419 | } |
2325 | 2420 | |
2326 | 2421 | // Getting some new questions? |
@@ -2328,8 +2423,9 @@ discard block |
||
2328 | 2423 | { |
2329 | 2424 | // Attempt to try the current page's language, followed by the user's preference, followed by the site default. |
2330 | 2425 | $possible_langs = array(); |
2331 | - if (isset($_SESSION['language'])) |
|
2332 | - $possible_langs[] = strtr($_SESSION['language'], array('-utf8' => '')); |
|
2426 | + if (isset($_SESSION['language'])) { |
|
2427 | + $possible_langs[] = strtr($_SESSION['language'], array('-utf8' => '')); |
|
2428 | + } |
|
2333 | 2429 | if (!empty($user_info['language'])); |
2334 | 2430 | $possible_langs[] = $user_info['language']; |
2335 | 2431 | $possible_langs[] = $language; |
@@ -2348,8 +2444,7 @@ discard block |
||
2348 | 2444 | } |
2349 | 2445 | } |
2350 | 2446 | } |
2351 | - } |
|
2352 | - else |
|
2447 | + } else |
|
2353 | 2448 | { |
2354 | 2449 | // Same questions as before. |
2355 | 2450 | $questionIDs = !empty($_SESSION[$verificationOptions['id'] . '_vv']['q']) ? $_SESSION[$verificationOptions['id'] . '_vv']['q'] : array(); |
@@ -2359,8 +2454,9 @@ discard block |
||
2359 | 2454 | // If we do have an empty field, it would be nice to hide it from legitimate users who shouldn't be populating it anyway. |
2360 | 2455 | if (!empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field'])) |
2361 | 2456 | { |
2362 | - if (!isset($context['html_headers'])) |
|
2363 | - $context['html_headers'] = ''; |
|
2457 | + if (!isset($context['html_headers'])) { |
|
2458 | + $context['html_headers'] = ''; |
|
2459 | + } |
|
2364 | 2460 | $context['html_headers'] .= '<style>.vv_special { display:none; }</style>'; |
2365 | 2461 | } |
2366 | 2462 | |
@@ -2386,11 +2482,13 @@ discard block |
||
2386 | 2482 | $_SESSION[$verificationOptions['id'] . '_vv']['count'] = empty($_SESSION[$verificationOptions['id'] . '_vv']['count']) ? 1 : $_SESSION[$verificationOptions['id'] . '_vv']['count'] + 1; |
2387 | 2483 | |
2388 | 2484 | // Return errors if we have them. |
2389 | - if (!empty($verification_errors)) |
|
2390 | - return $verification_errors; |
|
2485 | + if (!empty($verification_errors)) { |
|
2486 | + return $verification_errors; |
|
2487 | + } |
|
2391 | 2488 | // If we had a test that one, make a note. |
2392 | - elseif ($do_test) |
|
2393 | - $_SESSION[$verificationOptions['id'] . '_vv']['did_pass'] = true; |
|
2489 | + elseif ($do_test) { |
|
2490 | + $_SESSION[$verificationOptions['id'] . '_vv']['did_pass'] = true; |
|
2491 | + } |
|
2394 | 2492 | |
2395 | 2493 | // Say that everything went well chaps. |
2396 | 2494 | return true; |
@@ -2415,8 +2513,9 @@ discard block |
||
2415 | 2513 | call_integration_hook('integrate_autosuggest', array(&$searchTypes)); |
2416 | 2514 | |
2417 | 2515 | // If we're just checking the callback function is registered return true or false. |
2418 | - if ($checkRegistered != null) |
|
2419 | - return isset($searchTypes[$checkRegistered]) && function_exists('AutoSuggest_Search_' . $checkRegistered); |
|
2516 | + if ($checkRegistered != null) { |
|
2517 | + return isset($searchTypes[$checkRegistered]) && function_exists('AutoSuggest_Search_' . $checkRegistered); |
|
2518 | + } |
|
2420 | 2519 | |
2421 | 2520 | checkSession('get'); |
2422 | 2521 | loadTemplate('Xml'); |
@@ -2567,24 +2666,27 @@ discard block |
||
2567 | 2666 | foreach ($possible_versions as $ver) |
2568 | 2667 | { |
2569 | 2668 | $ver = trim($ver); |
2570 | - if (strpos($ver, 'SMF') === 0) |
|
2571 | - $versions[] = $ver; |
|
2669 | + if (strpos($ver, 'SMF') === 0) { |
|
2670 | + $versions[] = $ver; |
|
2671 | + } |
|
2572 | 2672 | } |
2573 | 2673 | } |
2574 | 2674 | $smcFunc['db_free_result']($request); |
2575 | 2675 | |
2576 | 2676 | // Just in case we don't have ANYthing. |
2577 | - if (empty($versions)) |
|
2578 | - $versions = array('SMF 2.0'); |
|
2677 | + if (empty($versions)) { |
|
2678 | + $versions = array('SMF 2.0'); |
|
2679 | + } |
|
2579 | 2680 | |
2580 | - foreach ($versions as $id => $version) |
|
2581 | - if (strpos($version, strtoupper($_REQUEST['search'])) !== false) |
|
2681 | + foreach ($versions as $id => $version) { |
|
2682 | + if (strpos($version, strtoupper($_REQUEST['search'])) !== false) |
|
2582 | 2683 | $xml_data['items']['children'][] = array( |
2583 | 2684 | 'attributes' => array( |
2584 | 2685 | 'id' => $id, |
2585 | 2686 | ), |
2586 | 2687 | 'value' => $version, |
2587 | 2688 | ); |
2689 | + } |
|
2588 | 2690 | |
2589 | 2691 | return $xml_data; |
2590 | 2692 | } |
@@ -30,8 +30,9 @@ discard block |
||
30 | 30 | * @version 2.1 Beta 4 |
31 | 31 | */ |
32 | 32 | |
33 | -if (!defined('SMF')) |
|
33 | +if (!defined('SMF')) { |
|
34 | 34 | die('No direct access...'); |
35 | +} |
|
35 | 36 | |
36 | 37 | /** |
37 | 38 | * Subaction handler - manages the action and delegates control to the proper |
@@ -103,12 +104,12 @@ discard block |
||
103 | 104 | cache_put_data('minimized_css', null); |
104 | 105 | |
105 | 106 | // Follow the sa or just go to administration. |
106 | - if (isset($_GET['sa']) && !empty($subActions[$_GET['sa']])) |
|
107 | - call_helper($subActions[$_GET['sa']]); |
|
108 | - |
|
109 | - else |
|
110 | - call_helper($subActions['admin']); |
|
111 | -} |
|
107 | + if (isset($_GET['sa']) && !empty($subActions[$_GET['sa']])) { |
|
108 | + call_helper($subActions[$_GET['sa']]); |
|
109 | + } else { |
|
110 | + call_helper($subActions['admin']); |
|
111 | + } |
|
112 | + } |
|
112 | 113 | |
113 | 114 | /** |
114 | 115 | * This function allows administration of themes and their settings, |
@@ -130,15 +131,16 @@ discard block |
||
130 | 131 | checkSession(); |
131 | 132 | validateToken('admin-tm'); |
132 | 133 | |
133 | - if (isset($_POST['options']['known_themes'])) |
|
134 | - foreach ($_POST['options']['known_themes'] as $key => $id) |
|
134 | + if (isset($_POST['options']['known_themes'])) { |
|
135 | + foreach ($_POST['options']['known_themes'] as $key => $id) |
|
135 | 136 | $_POST['options']['known_themes'][$key] = (int) $id; |
137 | + } else { |
|
138 | + fatal_lang_error('themes_none_selectable', false); |
|
139 | + } |
|
136 | 140 | |
137 | - else |
|
138 | - fatal_lang_error('themes_none_selectable', false); |
|
139 | - |
|
140 | - if (!in_array($_POST['options']['theme_guests'], $_POST['options']['known_themes'])) |
|
141 | - fatal_lang_error('themes_default_selectable', false); |
|
141 | + if (!in_array($_POST['options']['theme_guests'], $_POST['options']['known_themes'])) { |
|
142 | + fatal_lang_error('themes_default_selectable', false); |
|
143 | + } |
|
142 | 144 | |
143 | 145 | // Commit the new settings. |
144 | 146 | updateSettings(array( |
@@ -146,8 +148,9 @@ discard block |
||
146 | 148 | 'theme_guests' => $_POST['options']['theme_guests'], |
147 | 149 | 'knownThemes' => implode(',', $_POST['options']['known_themes']), |
148 | 150 | )); |
149 | - if ((int) $_POST['theme_reset'] == 0 || in_array($_POST['theme_reset'], $_POST['options']['known_themes'])) |
|
150 | - updateMemberData(null, array('id_theme' => (int) $_POST['theme_reset'])); |
|
151 | + if ((int) $_POST['theme_reset'] == 0 || in_array($_POST['theme_reset'], $_POST['options']['known_themes'])) { |
|
152 | + updateMemberData(null, array('id_theme' => (int) $_POST['theme_reset'])); |
|
153 | + } |
|
151 | 154 | |
152 | 155 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=admin'); |
153 | 156 | } |
@@ -166,8 +169,9 @@ discard block |
||
166 | 169 | // Look for a non existent theme directory. (ie theme87.) |
167 | 170 | $theme_dir = $boarddir . '/Themes/theme'; |
168 | 171 | $i = 1; |
169 | - while (file_exists($theme_dir . $i)) |
|
170 | - $i++; |
|
172 | + while (file_exists($theme_dir . $i)) { |
|
173 | + $i++; |
|
174 | + } |
|
171 | 175 | |
172 | 176 | $context['new_theme_name'] = 'theme' . $i; |
173 | 177 | |
@@ -189,8 +193,9 @@ discard block |
||
189 | 193 | loadLanguage('Admin'); |
190 | 194 | isAllowedTo('admin_forum'); |
191 | 195 | |
192 | - if (isset($_REQUEST['th'])) |
|
193 | - return SetThemeSettings(); |
|
196 | + if (isset($_REQUEST['th'])) { |
|
197 | + return SetThemeSettings(); |
|
198 | + } |
|
194 | 199 | |
195 | 200 | if (isset($_POST['save'])) |
196 | 201 | { |
@@ -274,12 +279,13 @@ discard block |
||
274 | 279 | $context['themes'] = array(); |
275 | 280 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
276 | 281 | { |
277 | - if (!isset($context['themes'][$row['id_theme']])) |
|
278 | - $context['themes'][$row['id_theme']] = array( |
|
282 | + if (!isset($context['themes'][$row['id_theme']])) { |
|
283 | + $context['themes'][$row['id_theme']] = array( |
|
279 | 284 | 'id' => $row['id_theme'], |
280 | 285 | 'num_default_options' => 0, |
281 | 286 | 'num_members' => 0, |
282 | 287 | ); |
288 | + } |
|
283 | 289 | $context['themes'][$row['id_theme']][$row['variable']] = $row['value']; |
284 | 290 | } |
285 | 291 | $smcFunc['db_free_result']($request); |
@@ -293,8 +299,9 @@ discard block |
||
293 | 299 | 'guest_member' => -1, |
294 | 300 | ) |
295 | 301 | ); |
296 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
297 | - $context['themes'][$row['id_theme']]['num_default_options'] = $row['value']; |
|
302 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
303 | + $context['themes'][$row['id_theme']]['num_default_options'] = $row['value']; |
|
304 | + } |
|
298 | 305 | $smcFunc['db_free_result']($request); |
299 | 306 | |
300 | 307 | // Need to make sure we don't do custom fields. |
@@ -305,8 +312,9 @@ discard block |
||
305 | 312 | ) |
306 | 313 | ); |
307 | 314 | $customFields = array(); |
308 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
309 | - $customFields[] = $row['col_name']; |
|
315 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
316 | + $customFields[] = $row['col_name']; |
|
317 | + } |
|
310 | 318 | $smcFunc['db_free_result']($request); |
311 | 319 | $customFieldsQuery = empty($customFields) ? '' : ('AND variable NOT IN ({array_string:custom_fields})'); |
312 | 320 | |
@@ -321,14 +329,16 @@ discard block |
||
321 | 329 | 'custom_fields' => empty($customFields) ? array() : $customFields, |
322 | 330 | ) |
323 | 331 | ); |
324 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
325 | - $context['themes'][$row['id_theme']]['num_members'] = $row['value']; |
|
332 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
333 | + $context['themes'][$row['id_theme']]['num_members'] = $row['value']; |
|
334 | + } |
|
326 | 335 | $smcFunc['db_free_result']($request); |
327 | 336 | |
328 | 337 | // There has to be a Settings template! |
329 | - foreach ($context['themes'] as $k => $v) |
|
330 | - if (empty($v['theme_dir']) || (!file_exists($v['theme_dir'] . '/Settings.template.php') && empty($v['num_members']))) |
|
338 | + foreach ($context['themes'] as $k => $v) { |
|
339 | + if (empty($v['theme_dir']) || (!file_exists($v['theme_dir'] . '/Settings.template.php') && empty($v['num_members']))) |
|
331 | 340 | unset($context['themes'][$k]); |
341 | + } |
|
332 | 342 | |
333 | 343 | loadTemplate('Themes'); |
334 | 344 | $context['sub_template'] = 'reset_list'; |
@@ -343,16 +353,19 @@ discard block |
||
343 | 353 | checkSession(); |
344 | 354 | validateToken('admin-sto'); |
345 | 355 | |
346 | - if (empty($_POST['options'])) |
|
347 | - $_POST['options'] = array(); |
|
348 | - if (empty($_POST['default_options'])) |
|
349 | - $_POST['default_options'] = array(); |
|
356 | + if (empty($_POST['options'])) { |
|
357 | + $_POST['options'] = array(); |
|
358 | + } |
|
359 | + if (empty($_POST['default_options'])) { |
|
360 | + $_POST['default_options'] = array(); |
|
361 | + } |
|
350 | 362 | |
351 | 363 | // Set up the sql query. |
352 | 364 | $setValues = array(); |
353 | 365 | |
354 | - foreach ($_POST['options'] as $opt => $val) |
|
355 | - $setValues[] = array(-1, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
366 | + foreach ($_POST['options'] as $opt => $val) { |
|
367 | + $setValues[] = array(-1, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
368 | + } |
|
356 | 369 | |
357 | 370 | $old_settings = array(); |
358 | 371 | foreach ($_POST['default_options'] as $opt => $val) |
@@ -366,8 +379,8 @@ discard block |
||
366 | 379 | if (!empty($setValues)) |
367 | 380 | { |
368 | 381 | // Are there options in non-default themes set that should be cleared? |
369 | - if (!empty($old_settings)) |
|
370 | - $smcFunc['db_query']('', ' |
|
382 | + if (!empty($old_settings)) { |
|
383 | + $smcFunc['db_query']('', ' |
|
371 | 384 | DELETE FROM {db_prefix}themes |
372 | 385 | WHERE id_theme != {int:default_theme} |
373 | 386 | AND id_member = {int:guest_member} |
@@ -378,6 +391,7 @@ discard block |
||
378 | 391 | 'old_settings' => $old_settings, |
379 | 392 | ) |
380 | 393 | ); |
394 | + } |
|
381 | 395 | |
382 | 396 | $smcFunc['db_insert']('replace', |
383 | 397 | '{db_prefix}themes', |
@@ -391,8 +405,7 @@ discard block |
||
391 | 405 | cache_put_data('theme_settings-1', null, 90); |
392 | 406 | |
393 | 407 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=reset'); |
394 | - } |
|
395 | - elseif (isset($_POST['submit']) && $_POST['who'] == 1) |
|
408 | + } elseif (isset($_POST['submit']) && $_POST['who'] == 1) |
|
396 | 409 | { |
397 | 410 | checkSession(); |
398 | 411 | validateToken('admin-sto'); |
@@ -405,9 +418,9 @@ discard block |
||
405 | 418 | $old_settings = array(); |
406 | 419 | foreach ($_POST['default_options'] as $opt => $val) |
407 | 420 | { |
408 | - if ($_POST['default_options_master'][$opt] == 0) |
|
409 | - continue; |
|
410 | - elseif ($_POST['default_options_master'][$opt] == 1) |
|
421 | + if ($_POST['default_options_master'][$opt] == 0) { |
|
422 | + continue; |
|
423 | + } elseif ($_POST['default_options_master'][$opt] == 1) |
|
411 | 424 | { |
412 | 425 | // Delete then insert for ease of database compatibility! |
413 | 426 | $smcFunc['db_query']('substring', ' |
@@ -433,8 +446,7 @@ discard block |
||
433 | 446 | ); |
434 | 447 | |
435 | 448 | $old_settings[] = $opt; |
436 | - } |
|
437 | - elseif ($_POST['default_options_master'][$opt] == 2) |
|
449 | + } elseif ($_POST['default_options_master'][$opt] == 2) |
|
438 | 450 | { |
439 | 451 | $smcFunc['db_query']('', ' |
440 | 452 | DELETE FROM {db_prefix}themes |
@@ -449,8 +461,8 @@ discard block |
||
449 | 461 | } |
450 | 462 | |
451 | 463 | // Delete options from other themes. |
452 | - if (!empty($old_settings)) |
|
453 | - $smcFunc['db_query']('', ' |
|
464 | + if (!empty($old_settings)) { |
|
465 | + $smcFunc['db_query']('', ' |
|
454 | 466 | DELETE FROM {db_prefix}themes |
455 | 467 | WHERE id_theme != {int:default_theme} |
456 | 468 | AND id_member > {int:no_member} |
@@ -461,12 +473,13 @@ discard block |
||
461 | 473 | 'old_settings' => $old_settings, |
462 | 474 | ) |
463 | 475 | ); |
476 | + } |
|
464 | 477 | |
465 | 478 | foreach ($_POST['options'] as $opt => $val) |
466 | 479 | { |
467 | - if ($_POST['options_master'][$opt] == 0) |
|
468 | - continue; |
|
469 | - elseif ($_POST['options_master'][$opt] == 1) |
|
480 | + if ($_POST['options_master'][$opt] == 0) { |
|
481 | + continue; |
|
482 | + } elseif ($_POST['options_master'][$opt] == 1) |
|
470 | 483 | { |
471 | 484 | // Delete then insert for ease of database compatibility - again! |
472 | 485 | $smcFunc['db_query']('substring', ' |
@@ -491,8 +504,7 @@ discard block |
||
491 | 504 | 'value' => (is_array($val) ? implode(',', $val) : $val), |
492 | 505 | ) |
493 | 506 | ); |
494 | - } |
|
495 | - elseif ($_POST['options_master'][$opt] == 2) |
|
507 | + } elseif ($_POST['options_master'][$opt] == 2) |
|
496 | 508 | { |
497 | 509 | $smcFunc['db_query']('', ' |
498 | 510 | DELETE FROM {db_prefix}themes |
@@ -509,8 +521,7 @@ discard block |
||
509 | 521 | } |
510 | 522 | |
511 | 523 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=reset'); |
512 | - } |
|
513 | - elseif (!empty($_GET['who']) && $_GET['who'] == 2) |
|
524 | + } elseif (!empty($_GET['who']) && $_GET['who'] == 2) |
|
514 | 525 | { |
515 | 526 | checkSession('get'); |
516 | 527 | validateToken('admin-stor', 'request'); |
@@ -525,8 +536,9 @@ discard block |
||
525 | 536 | ) |
526 | 537 | ); |
527 | 538 | $customFields = array(); |
528 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
529 | - $customFields[] = $row['col_name']; |
|
539 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
540 | + $customFields[] = $row['col_name']; |
|
541 | + } |
|
530 | 542 | $smcFunc['db_free_result']($request); |
531 | 543 | } |
532 | 544 | $customFieldsQuery = empty($customFields) ? '' : ('AND variable NOT IN ({array_string:custom_fields})'); |
@@ -581,13 +593,13 @@ discard block |
||
581 | 593 | ) |
582 | 594 | ); |
583 | 595 | $context['theme_options'] = array(); |
584 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
585 | - $context['theme_options'][$row['variable']] = $row['value']; |
|
596 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
597 | + $context['theme_options'][$row['variable']] = $row['value']; |
|
598 | + } |
|
586 | 599 | $smcFunc['db_free_result']($request); |
587 | 600 | |
588 | 601 | $context['theme_options_reset'] = false; |
589 | - } |
|
590 | - else |
|
602 | + } else |
|
591 | 603 | { |
592 | 604 | $context['theme_options'] = array(); |
593 | 605 | $context['theme_options_reset'] = true; |
@@ -596,8 +608,9 @@ discard block |
||
596 | 608 | foreach ($context['options'] as $i => $setting) |
597 | 609 | { |
598 | 610 | // Just skip separators |
599 | - if (!is_array($setting)) |
|
600 | - continue; |
|
611 | + if (!is_array($setting)) { |
|
612 | + continue; |
|
613 | + } |
|
601 | 614 | |
602 | 615 | // Is this disabled? |
603 | 616 | if (isset($setting['enabled']) && $setting['enabled'] === false) |
@@ -606,15 +619,17 @@ discard block |
||
606 | 619 | continue; |
607 | 620 | } |
608 | 621 | |
609 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
610 | - $context['options'][$i]['type'] = 'checkbox'; |
|
611 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
612 | - $context['options'][$i]['type'] = 'number'; |
|
613 | - elseif ($setting['type'] == 'string') |
|
614 | - $context['options'][$i]['type'] = 'text'; |
|
622 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
623 | + $context['options'][$i]['type'] = 'checkbox'; |
|
624 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
625 | + $context['options'][$i]['type'] = 'number'; |
|
626 | + } elseif ($setting['type'] == 'string') { |
|
627 | + $context['options'][$i]['type'] = 'text'; |
|
628 | + } |
|
615 | 629 | |
616 | - if (isset($setting['options'])) |
|
617 | - $context['options'][$i]['type'] = 'list'; |
|
630 | + if (isset($setting['options'])) { |
|
631 | + $context['options'][$i]['type'] = 'list'; |
|
632 | + } |
|
618 | 633 | |
619 | 634 | $context['options'][$i]['value'] = !isset($context['theme_options'][$setting['id']]) ? '' : $context['theme_options'][$setting['id']]; |
620 | 635 | } |
@@ -639,8 +654,9 @@ discard block |
||
639 | 654 | { |
640 | 655 | global $txt, $context, $settings, $modSettings, $smcFunc; |
641 | 656 | |
642 | - if (empty($_GET['th']) && empty($_GET['id'])) |
|
643 | - return ThemeAdmin(); |
|
657 | + if (empty($_GET['th']) && empty($_GET['id'])) { |
|
658 | + return ThemeAdmin(); |
|
659 | + } |
|
644 | 660 | |
645 | 661 | $_GET['th'] = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
646 | 662 | |
@@ -651,8 +667,9 @@ discard block |
||
651 | 667 | isAllowedTo('admin_forum'); |
652 | 668 | |
653 | 669 | // Validate inputs/user. |
654 | - if (empty($_GET['th'])) |
|
655 | - fatal_lang_error('no_theme', false); |
|
670 | + if (empty($_GET['th'])) { |
|
671 | + fatal_lang_error('no_theme', false); |
|
672 | + } |
|
656 | 673 | |
657 | 674 | // Fetch the smiley sets... |
658 | 675 | $sets = explode(',', 'none,' . $modSettings['smiley_sets_known']); |
@@ -660,8 +677,9 @@ discard block |
||
660 | 677 | $context['smiley_sets'] = array( |
661 | 678 | '' => $txt['smileys_no_default'] |
662 | 679 | ); |
663 | - foreach ($sets as $i => $set) |
|
664 | - $context['smiley_sets'][$set] = $smcFunc['htmlspecialchars']($set_names[$i]); |
|
680 | + foreach ($sets as $i => $set) { |
|
681 | + $context['smiley_sets'][$set] = $smcFunc['htmlspecialchars']($set_names[$i]); |
|
682 | + } |
|
665 | 683 | |
666 | 684 | $old_id = $settings['theme_id']; |
667 | 685 | $old_settings = $settings; |
@@ -686,8 +704,9 @@ discard block |
||
686 | 704 | if (file_exists($settings['theme_dir'] . '/index.template.php')) |
687 | 705 | { |
688 | 706 | $file_contents = implode('', file($settings['theme_dir'] . '/index.template.php')); |
689 | - if (preg_match('~\$settings\[\'theme_variants\'\]\s*=(.+?);~', $file_contents, $matches)) |
|
690 | - eval('global $settings;' . $matches[0]); |
|
707 | + if (preg_match('~\$settings\[\'theme_variants\'\]\s*=(.+?);~', $file_contents, $matches)) { |
|
708 | + eval('global $settings;' . $matches[0]); |
|
709 | + } |
|
691 | 710 | } |
692 | 711 | |
693 | 712 | // Let mods hook into the theme settings. |
@@ -699,37 +718,45 @@ discard block |
||
699 | 718 | checkSession(); |
700 | 719 | validateToken('admin-sts'); |
701 | 720 | |
702 | - if (empty($_POST['options'])) |
|
703 | - $_POST['options'] = array(); |
|
704 | - if (empty($_POST['default_options'])) |
|
705 | - $_POST['default_options'] = array(); |
|
721 | + if (empty($_POST['options'])) { |
|
722 | + $_POST['options'] = array(); |
|
723 | + } |
|
724 | + if (empty($_POST['default_options'])) { |
|
725 | + $_POST['default_options'] = array(); |
|
726 | + } |
|
706 | 727 | |
707 | 728 | // Make sure items are cast correctly. |
708 | 729 | foreach ($context['theme_settings'] as $item) |
709 | 730 | { |
710 | 731 | // Disregard this item if this is just a separator. |
711 | - if (!is_array($item)) |
|
712 | - continue; |
|
732 | + if (!is_array($item)) { |
|
733 | + continue; |
|
734 | + } |
|
713 | 735 | |
714 | 736 | foreach (array('options', 'default_options') as $option) |
715 | 737 | { |
716 | - if (!isset($_POST[$option][$item['id']])) |
|
717 | - continue; |
|
738 | + if (!isset($_POST[$option][$item['id']])) { |
|
739 | + continue; |
|
740 | + } |
|
718 | 741 | // Checkbox. |
719 | - elseif (empty($item['type'])) |
|
720 | - $_POST[$option][$item['id']] = $_POST[$option][$item['id']] ? 1 : 0; |
|
742 | + elseif (empty($item['type'])) { |
|
743 | + $_POST[$option][$item['id']] = $_POST[$option][$item['id']] ? 1 : 0; |
|
744 | + } |
|
721 | 745 | // Number |
722 | - elseif ($item['type'] == 'number') |
|
723 | - $_POST[$option][$item['id']] = (int) $_POST[$option][$item['id']]; |
|
746 | + elseif ($item['type'] == 'number') { |
|
747 | + $_POST[$option][$item['id']] = (int) $_POST[$option][$item['id']]; |
|
748 | + } |
|
724 | 749 | } |
725 | 750 | } |
726 | 751 | |
727 | 752 | // Set up the sql query. |
728 | 753 | $inserts = array(); |
729 | - foreach ($_POST['options'] as $opt => $val) |
|
730 | - $inserts[] = array(0, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
731 | - foreach ($_POST['default_options'] as $opt => $val) |
|
732 | - $inserts[] = array(0, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
|
754 | + foreach ($_POST['options'] as $opt => $val) { |
|
755 | + $inserts[] = array(0, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
756 | + } |
|
757 | + foreach ($_POST['default_options'] as $opt => $val) { |
|
758 | + $inserts[] = array(0, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
|
759 | + } |
|
733 | 760 | // If we're actually inserting something.. |
734 | 761 | if (!empty($inserts)) |
735 | 762 | { |
@@ -755,8 +782,9 @@ discard block |
||
755 | 782 | |
756 | 783 | foreach ($settings as $setting => $dummy) |
757 | 784 | { |
758 | - if (!in_array($setting, array('theme_url', 'theme_dir', 'images_url', 'template_dirs'))) |
|
759 | - $settings[$setting] = htmlspecialchars__recursive($settings[$setting]); |
|
785 | + if (!in_array($setting, array('theme_url', 'theme_dir', 'images_url', 'template_dirs'))) { |
|
786 | + $settings[$setting] = htmlspecialchars__recursive($settings[$setting]); |
|
787 | + } |
|
760 | 788 | } |
761 | 789 | |
762 | 790 | $context['settings'] = $context['theme_settings']; |
@@ -765,18 +793,21 @@ discard block |
||
765 | 793 | foreach ($context['settings'] as $i => $setting) |
766 | 794 | { |
767 | 795 | // Separators are dummies, so leave them alone. |
768 | - if (!is_array($setting)) |
|
769 | - continue; |
|
796 | + if (!is_array($setting)) { |
|
797 | + continue; |
|
798 | + } |
|
770 | 799 | |
771 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
772 | - $context['settings'][$i]['type'] = 'checkbox'; |
|
773 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
774 | - $context['settings'][$i]['type'] = 'number'; |
|
775 | - elseif ($setting['type'] == 'string') |
|
776 | - $context['settings'][$i]['type'] = 'text'; |
|
800 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
801 | + $context['settings'][$i]['type'] = 'checkbox'; |
|
802 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
803 | + $context['settings'][$i]['type'] = 'number'; |
|
804 | + } elseif ($setting['type'] == 'string') { |
|
805 | + $context['settings'][$i]['type'] = 'text'; |
|
806 | + } |
|
777 | 807 | |
778 | - if (isset($setting['options'])) |
|
779 | - $context['settings'][$i]['type'] = 'list'; |
|
808 | + if (isset($setting['options'])) { |
|
809 | + $context['settings'][$i]['type'] = 'list'; |
|
810 | + } |
|
780 | 811 | |
781 | 812 | $context['settings'][$i]['value'] = !isset($settings[$setting['id']]) ? '' : $settings[$setting['id']]; |
782 | 813 | } |
@@ -829,8 +860,9 @@ discard block |
||
829 | 860 | $themeID = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
830 | 861 | |
831 | 862 | // You can't delete the default theme! |
832 | - if ($themeID == 1) |
|
833 | - fatal_lang_error('no_access', false); |
|
863 | + if ($themeID == 1) { |
|
864 | + fatal_lang_error('no_access', false); |
|
865 | + } |
|
834 | 866 | |
835 | 867 | $theme_info = get_single_theme($themeID); |
836 | 868 | |
@@ -838,8 +870,9 @@ discard block |
||
838 | 870 | remove_theme($themeID); |
839 | 871 | |
840 | 872 | // And remove all its files and folders too. |
841 | - if (!empty($theme_info) && !empty($theme_info['theme_dir'])) |
|
842 | - remove_dir($theme_info['theme_dir']); |
|
873 | + if (!empty($theme_info) && !empty($theme_info['theme_dir'])) { |
|
874 | + remove_dir($theme_info['theme_dir']); |
|
875 | + } |
|
843 | 876 | |
844 | 877 | // Go back to the list page. |
845 | 878 | redirectexit('action=admin;area=theme;sa=list;' . $context['session_var'] . '=' . $context['session_id'] . ';done=removing'); |
@@ -864,12 +897,14 @@ discard block |
||
864 | 897 | $enableThemes = explode(',', $modSettings['enableThemes']); |
865 | 898 | |
866 | 899 | // Are we disabling it? |
867 | - if (isset($_GET['disabled'])) |
|
868 | - $enableThemes = array_diff($enableThemes, array($themeID)); |
|
900 | + if (isset($_GET['disabled'])) { |
|
901 | + $enableThemes = array_diff($enableThemes, array($themeID)); |
|
902 | + } |
|
869 | 903 | |
870 | 904 | // Nope? then enable it! |
871 | - else |
|
872 | - $enableThemes[] = (string) $themeID; |
|
905 | + else { |
|
906 | + $enableThemes[] = (string) $themeID; |
|
907 | + } |
|
873 | 908 | |
874 | 909 | // Update the setting. |
875 | 910 | $enableThemes = strtr(implode(',', $enableThemes), array(',,' => ',')); |
@@ -904,18 +939,21 @@ discard block |
||
904 | 939 | |
905 | 940 | $_SESSION['id_theme'] = 0; |
906 | 941 | |
907 | - if (isset($_GET['id'])) |
|
908 | - $_GET['th'] = $_GET['id']; |
|
942 | + if (isset($_GET['id'])) { |
|
943 | + $_GET['th'] = $_GET['id']; |
|
944 | + } |
|
909 | 945 | |
910 | 946 | // Saving a variant cause JS doesn't work - pretend it did ;) |
911 | 947 | if (isset($_POST['save'])) |
912 | 948 | { |
913 | 949 | // Which theme? |
914 | - foreach ($_POST['save'] as $k => $v) |
|
915 | - $_GET['th'] = (int) $k; |
|
950 | + foreach ($_POST['save'] as $k => $v) { |
|
951 | + $_GET['th'] = (int) $k; |
|
952 | + } |
|
916 | 953 | |
917 | - if (isset($_POST['vrt'][$k])) |
|
918 | - $_GET['vrt'] = $_POST['vrt'][$k]; |
|
954 | + if (isset($_POST['vrt'][$k])) { |
|
955 | + $_GET['vrt'] = $_POST['vrt'][$k]; |
|
956 | + } |
|
919 | 957 | } |
920 | 958 | |
921 | 959 | // Have we made a decision, or are we just browsing? |
@@ -1004,10 +1042,10 @@ discard block |
||
1004 | 1042 | ); |
1005 | 1043 | cache_put_data('theme_settings-' . $_GET['th'] . ':' . (int) $_REQUEST['u'], null, 90); |
1006 | 1044 | |
1007 | - if ($user_info['id'] == $_REQUEST['u']) |
|
1008 | - $_SESSION['id_variant'] = 0; |
|
1009 | - } |
|
1010 | - elseif ($_GET['th'] == 0) |
|
1045 | + if ($user_info['id'] == $_REQUEST['u']) { |
|
1046 | + $_SESSION['id_variant'] = 0; |
|
1047 | + } |
|
1048 | + } elseif ($_GET['th'] == 0) |
|
1011 | 1049 | { |
1012 | 1050 | // Remove any custom variants. |
1013 | 1051 | $smcFunc['db_query']('', ' |
@@ -1088,12 +1126,13 @@ discard block |
||
1088 | 1126 | ); |
1089 | 1127 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1090 | 1128 | { |
1091 | - if (!isset($context['available_themes'][$row['id_theme']])) |
|
1092 | - $context['available_themes'][$row['id_theme']] = array( |
|
1129 | + if (!isset($context['available_themes'][$row['id_theme']])) { |
|
1130 | + $context['available_themes'][$row['id_theme']] = array( |
|
1093 | 1131 | 'id' => $row['id_theme'], |
1094 | 1132 | 'selected' => $context['current_theme'] == $row['id_theme'], |
1095 | 1133 | 'num_users' => 0 |
1096 | 1134 | ); |
1135 | + } |
|
1097 | 1136 | $context['available_themes'][$row['id_theme']][$row['variable']] = $row['value']; |
1098 | 1137 | } |
1099 | 1138 | $smcFunc['db_free_result']($request); |
@@ -1106,9 +1145,9 @@ discard block |
||
1106 | 1145 | 'num_users' => 0 |
1107 | 1146 | ); |
1108 | 1147 | $guest_theme = 0; |
1148 | + } else { |
|
1149 | + $guest_theme = $modSettings['theme_guests']; |
|
1109 | 1150 | } |
1110 | - else |
|
1111 | - $guest_theme = $modSettings['theme_guests']; |
|
1112 | 1151 | |
1113 | 1152 | $request = $smcFunc['db_query']('', ' |
1114 | 1153 | SELECT id_theme, COUNT(*) AS the_count |
@@ -1121,15 +1160,17 @@ discard block |
||
1121 | 1160 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1122 | 1161 | { |
1123 | 1162 | // Figure out which theme it is they are REALLY using. |
1124 | - if (!empty($modSettings['knownThemes']) && !in_array($row['id_theme'], explode(',', $modSettings['knownThemes']))) |
|
1125 | - $row['id_theme'] = $guest_theme; |
|
1126 | - elseif (empty($modSettings['theme_allow'])) |
|
1127 | - $row['id_theme'] = $guest_theme; |
|
1163 | + if (!empty($modSettings['knownThemes']) && !in_array($row['id_theme'], explode(',', $modSettings['knownThemes']))) { |
|
1164 | + $row['id_theme'] = $guest_theme; |
|
1165 | + } elseif (empty($modSettings['theme_allow'])) { |
|
1166 | + $row['id_theme'] = $guest_theme; |
|
1167 | + } |
|
1128 | 1168 | |
1129 | - if (isset($context['available_themes'][$row['id_theme']])) |
|
1130 | - $context['available_themes'][$row['id_theme']]['num_users'] += $row['the_count']; |
|
1131 | - else |
|
1132 | - $context['available_themes'][$guest_theme]['num_users'] += $row['the_count']; |
|
1169 | + if (isset($context['available_themes'][$row['id_theme']])) { |
|
1170 | + $context['available_themes'][$row['id_theme']]['num_users'] += $row['the_count']; |
|
1171 | + } else { |
|
1172 | + $context['available_themes'][$guest_theme]['num_users'] += $row['the_count']; |
|
1173 | + } |
|
1133 | 1174 | } |
1134 | 1175 | $smcFunc['db_free_result']($request); |
1135 | 1176 | |
@@ -1148,8 +1189,9 @@ discard block |
||
1148 | 1189 | 'id_member' => isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? array(-1, $context['current_member']) : array(-1), |
1149 | 1190 | ) |
1150 | 1191 | ); |
1151 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1152 | - $variant_preferences[$row['id_theme']] = $row['value']; |
|
1192 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1193 | + $variant_preferences[$row['id_theme']] = $row['value']; |
|
1194 | + } |
|
1153 | 1195 | $smcFunc['db_free_result']($request); |
1154 | 1196 | } |
1155 | 1197 | |
@@ -1160,17 +1202,18 @@ discard block |
||
1160 | 1202 | foreach ($context['available_themes'] as $id_theme => $theme_data) |
1161 | 1203 | { |
1162 | 1204 | // Don't try to load the forum or board default theme's data... it doesn't have any! |
1163 | - if ($id_theme == 0) |
|
1164 | - continue; |
|
1205 | + if ($id_theme == 0) { |
|
1206 | + continue; |
|
1207 | + } |
|
1165 | 1208 | |
1166 | 1209 | // The thumbnail needs the correct path. |
1167 | 1210 | $settings['images_url'] = &$theme_data['images_url']; |
1168 | 1211 | |
1169 | - if (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php')) |
|
1170 | - include($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php'); |
|
1171 | - elseif (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php')) |
|
1172 | - include($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php'); |
|
1173 | - else |
|
1212 | + if (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php')) { |
|
1213 | + include($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php'); |
|
1214 | + } elseif (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php')) { |
|
1215 | + include($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php'); |
|
1216 | + } else |
|
1174 | 1217 | { |
1175 | 1218 | $txt['theme_thumbnail_href'] = $theme_data['images_url'] . '/thumbnail.png'; |
1176 | 1219 | $txt['theme_description'] = ''; |
@@ -1195,15 +1238,17 @@ discard block |
||
1195 | 1238 | loadLanguage('Settings'); |
1196 | 1239 | |
1197 | 1240 | $context['available_themes'][$id_theme]['variants'] = array(); |
1198 | - foreach ($settings['theme_variants'] as $variant) |
|
1199 | - $context['available_themes'][$id_theme]['variants'][$variant] = array( |
|
1241 | + foreach ($settings['theme_variants'] as $variant) { |
|
1242 | + $context['available_themes'][$id_theme]['variants'][$variant] = array( |
|
1200 | 1243 | 'label' => isset($txt['variant_' . $variant]) ? $txt['variant_' . $variant] : $variant, |
1201 | 1244 | 'thumbnail' => !file_exists($theme_data['theme_dir'] . '/images/thumbnail.png') || file_exists($theme_data['theme_dir'] . '/images/thumbnail_' . $variant . '.png') ? $theme_data['images_url'] . '/thumbnail_' . $variant . '.png' : ($theme_data['images_url'] . '/thumbnail.png'), |
1202 | 1245 | ); |
1246 | + } |
|
1203 | 1247 | |
1204 | 1248 | $context['available_themes'][$id_theme]['selected_variant'] = isset($_GET['vrt']) ? $_GET['vrt'] : (!empty($variant_preferences[$id_theme]) ? $variant_preferences[$id_theme] : (!empty($settings['default_variant']) ? $settings['default_variant'] : $settings['theme_variants'][0])); |
1205 | - if (!isset($context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail'])) |
|
1206 | - $context['available_themes'][$id_theme]['selected_variant'] = $settings['theme_variants'][0]; |
|
1249 | + if (!isset($context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail'])) { |
|
1250 | + $context['available_themes'][$id_theme]['selected_variant'] = $settings['theme_variants'][0]; |
|
1251 | + } |
|
1207 | 1252 | |
1208 | 1253 | $context['available_themes'][$id_theme]['thumbnail_href'] = $context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail']; |
1209 | 1254 | // Allow themes to override the text. |
@@ -1219,8 +1264,9 @@ discard block |
||
1219 | 1264 | // As long as we're not doing the default theme... |
1220 | 1265 | if (!isset($_REQUEST['u']) || $_REQUEST['u'] >= 0) |
1221 | 1266 | { |
1222 | - if ($guest_theme != 0) |
|
1223 | - $context['available_themes'][0] = $context['available_themes'][$guest_theme]; |
|
1267 | + if ($guest_theme != 0) { |
|
1268 | + $context['available_themes'][0] = $context['available_themes'][$guest_theme]; |
|
1269 | + } |
|
1224 | 1270 | |
1225 | 1271 | $context['available_themes'][0]['id'] = 0; |
1226 | 1272 | $context['available_themes'][0]['name'] = $txt['theme_forum_default']; |
@@ -1269,14 +1315,16 @@ discard block |
||
1269 | 1315 | $action = $smcFunc['htmlspecialchars'](trim($_GET['do'])); |
1270 | 1316 | |
1271 | 1317 | // Got any info from the specific form? |
1272 | - if (!isset($_POST['save_' . $action])) |
|
1273 | - fatal_lang_error('theme_install_no_action', false); |
|
1318 | + if (!isset($_POST['save_' . $action])) { |
|
1319 | + fatal_lang_error('theme_install_no_action', false); |
|
1320 | + } |
|
1274 | 1321 | |
1275 | 1322 | validateToken('admin-t-' . $action); |
1276 | 1323 | |
1277 | 1324 | // Hopefully the themes directory is writable, or we might have a problem. |
1278 | - if (!is_writable($themedir)) |
|
1279 | - fatal_lang_error('theme_install_write_error', 'critical'); |
|
1325 | + if (!is_writable($themedir)) { |
|
1326 | + fatal_lang_error('theme_install_write_error', 'critical'); |
|
1327 | + } |
|
1280 | 1328 | |
1281 | 1329 | // Call the function and handle the result. |
1282 | 1330 | $result = $subActions[$action](); |
@@ -1291,9 +1339,10 @@ discard block |
||
1291 | 1339 | } |
1292 | 1340 | |
1293 | 1341 | // Nope, show a nice error. |
1294 | - else |
|
1295 | - fatal_lang_error('theme_install_no_action', false); |
|
1296 | -} |
|
1342 | + else { |
|
1343 | + fatal_lang_error('theme_install_no_action', false); |
|
1344 | + } |
|
1345 | + } |
|
1297 | 1346 | |
1298 | 1347 | /** |
1299 | 1348 | * Installs a theme from a theme package. |
@@ -1309,8 +1358,9 @@ discard block |
||
1309 | 1358 | $dirtemp = $themedir . '/temp'; |
1310 | 1359 | |
1311 | 1360 | // Make sure the temp dir doesn't already exist |
1312 | - if (file_exists($dirtemp)) |
|
1313 | - remove_dir($dirtemp); |
|
1361 | + if (file_exists($dirtemp)) { |
|
1362 | + remove_dir($dirtemp); |
|
1363 | + } |
|
1314 | 1364 | |
1315 | 1365 | // Create the temp dir. |
1316 | 1366 | mkdir($dirtemp, 0777); |
@@ -1322,17 +1372,20 @@ discard block |
||
1322 | 1372 | smf_chmod($dirtemp, '0755'); |
1323 | 1373 | |
1324 | 1374 | // How about now? |
1325 | - if (!is_writable($dirtemp)) |
|
1326 | - fatal_lang_error('theme_install_write_error', 'critical'); |
|
1375 | + if (!is_writable($dirtemp)) { |
|
1376 | + fatal_lang_error('theme_install_write_error', 'critical'); |
|
1377 | + } |
|
1327 | 1378 | } |
1328 | 1379 | |
1329 | 1380 | // This happens when the admin session is gone and the user has to login again. |
1330 | - if (!isset($_FILES) || !isset($_FILES['theme_gz']) || empty($_FILES['theme_gz'])) |
|
1331 | - redirectexit('action=admin;area=theme;sa=admin;' . $context['session_var'] . '=' . $context['session_id']); |
|
1381 | + if (!isset($_FILES) || !isset($_FILES['theme_gz']) || empty($_FILES['theme_gz'])) { |
|
1382 | + redirectexit('action=admin;area=theme;sa=admin;' . $context['session_var'] . '=' . $context['session_id']); |
|
1383 | + } |
|
1332 | 1384 | |
1333 | 1385 | // Another error check layer, something went wrong with the upload. |
1334 | - if (isset($_FILES['theme_gz']['error']) && $_FILES['theme_gz']['error'] != 0) |
|
1335 | - fatal_lang_error('theme_install_error_file_' . $_FILES['theme_gz']['error'], false); |
|
1386 | + if (isset($_FILES['theme_gz']['error']) && $_FILES['theme_gz']['error'] != 0) { |
|
1387 | + fatal_lang_error('theme_install_error_file_' . $_FILES['theme_gz']['error'], false); |
|
1388 | + } |
|
1336 | 1389 | |
1337 | 1390 | // Get the theme's name. |
1338 | 1391 | $name = pathinfo($_FILES['theme_gz']['name'], PATHINFO_FILENAME); |
@@ -1363,11 +1416,10 @@ discard block |
||
1363 | 1416 | |
1364 | 1417 | // return all the info. |
1365 | 1418 | return $context['to_install']; |
1419 | + } else { |
|
1420 | + fatal_lang_error('theme_install_error_title', false); |
|
1421 | + } |
|
1366 | 1422 | } |
1367 | - |
|
1368 | - else |
|
1369 | - fatal_lang_error('theme_install_error_title', false); |
|
1370 | -} |
|
1371 | 1423 | |
1372 | 1424 | /** |
1373 | 1425 | * Makes a copy from the default theme, assigns a name for it and installs it. |
@@ -1381,15 +1433,17 @@ discard block |
||
1381 | 1433 | global $forum_version; |
1382 | 1434 | |
1383 | 1435 | // There's gotta be something to work with. |
1384 | - if (!isset($_REQUEST['copy']) || empty($_REQUEST['copy'])) |
|
1385 | - fatal_lang_error('theme_install_error_title', false); |
|
1436 | + if (!isset($_REQUEST['copy']) || empty($_REQUEST['copy'])) { |
|
1437 | + fatal_lang_error('theme_install_error_title', false); |
|
1438 | + } |
|
1386 | 1439 | |
1387 | 1440 | // Get a cleaner version. |
1388 | 1441 | $name = preg_replace('~[^A-Za-z0-9_\- ]~', '', $_REQUEST['copy']); |
1389 | 1442 | |
1390 | 1443 | // Is there a theme already named like this? |
1391 | - if (file_exists($themedir . '/' . $name)) |
|
1392 | - fatal_lang_error('theme_install_already_dir', false); |
|
1444 | + if (file_exists($themedir . '/' . $name)) { |
|
1445 | + fatal_lang_error('theme_install_already_dir', false); |
|
1446 | + } |
|
1393 | 1447 | |
1394 | 1448 | // This is a brand new theme so set all possible values. |
1395 | 1449 | $context['to_install'] = array( |
@@ -1409,8 +1463,9 @@ discard block |
||
1409 | 1463 | |
1410 | 1464 | // Buy some time. |
1411 | 1465 | @set_time_limit(600); |
1412 | - if (function_exists('apache_reset_timeout')) |
|
1413 | - @apache_reset_timeout(); |
|
1466 | + if (function_exists('apache_reset_timeout')) { |
|
1467 | + @apache_reset_timeout(); |
|
1468 | + } |
|
1414 | 1469 | |
1415 | 1470 | // Create subdirectories for css and javascript files. |
1416 | 1471 | mkdir($context['to_install']['theme_dir'] . '/css', 0777); |
@@ -1446,12 +1501,13 @@ discard block |
||
1446 | 1501 | |
1447 | 1502 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1448 | 1503 | { |
1449 | - if ($row['variable'] == 'theme_templates') |
|
1450 | - $theme_templates = $row['value']; |
|
1451 | - elseif ($row['variable'] == 'theme_layers') |
|
1452 | - $theme_layers = $row['value']; |
|
1453 | - else |
|
1454 | - continue; |
|
1504 | + if ($row['variable'] == 'theme_templates') { |
|
1505 | + $theme_templates = $row['value']; |
|
1506 | + } elseif ($row['variable'] == 'theme_layers') { |
|
1507 | + $theme_layers = $row['value']; |
|
1508 | + } else { |
|
1509 | + continue; |
|
1510 | + } |
|
1455 | 1511 | } |
1456 | 1512 | |
1457 | 1513 | $smcFunc['db_free_result']($request); |
@@ -1510,12 +1566,14 @@ discard block |
||
1510 | 1566 | global $themedir, $themeurl, $context; |
1511 | 1567 | |
1512 | 1568 | // Cannot use the theme dir as a theme dir. |
1513 | - if (!isset($_REQUEST['theme_dir']) || empty($_REQUEST['theme_dir']) || rtrim(realpath($_REQUEST['theme_dir']), '/\\') == realpath($themedir)) |
|
1514 | - fatal_lang_error('theme_install_invalid_dir', false); |
|
1569 | + if (!isset($_REQUEST['theme_dir']) || empty($_REQUEST['theme_dir']) || rtrim(realpath($_REQUEST['theme_dir']), '/\\') == realpath($themedir)) { |
|
1570 | + fatal_lang_error('theme_install_invalid_dir', false); |
|
1571 | + } |
|
1515 | 1572 | |
1516 | 1573 | // Check is there is "something" on the dir. |
1517 | - elseif (!is_dir($_REQUEST['theme_dir']) || !file_exists($_REQUEST['theme_dir'] . '/theme_info.xml')) |
|
1518 | - fatal_lang_error('theme_install_error', false); |
|
1574 | + elseif (!is_dir($_REQUEST['theme_dir']) || !file_exists($_REQUEST['theme_dir'] . '/theme_info.xml')) { |
|
1575 | + fatal_lang_error('theme_install_error', false); |
|
1576 | + } |
|
1519 | 1577 | |
1520 | 1578 | $name = basename($_REQUEST['theme_dir']); |
1521 | 1579 | $name = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $name); |
@@ -1559,24 +1617,27 @@ discard block |
||
1559 | 1617 | } |
1560 | 1618 | |
1561 | 1619 | // Any special layers? |
1562 | - if (isset($settings['catch_action']['layers'])) |
|
1563 | - $context['template_layers'] = $settings['catch_action']['layers']; |
|
1620 | + if (isset($settings['catch_action']['layers'])) { |
|
1621 | + $context['template_layers'] = $settings['catch_action']['layers']; |
|
1622 | + } |
|
1564 | 1623 | |
1565 | 1624 | // Any function to call? |
1566 | 1625 | if (isset($settings['catch_action']['function'])) |
1567 | 1626 | { |
1568 | 1627 | $hook = $settings['catch_action']['function']; |
1569 | 1628 | |
1570 | - if (!isset($settings['catch_action']['filename'])) |
|
1571 | - $settings['catch_action']['filename'] = ''; |
|
1629 | + if (!isset($settings['catch_action']['filename'])) { |
|
1630 | + $settings['catch_action']['filename'] = ''; |
|
1631 | + } |
|
1572 | 1632 | |
1573 | 1633 | add_integration_function('integrate_wrap_action', $hook, false, $settings['catch_action']['filename'], false); |
1574 | 1634 | call_integration_hook('integrate_wrap_action'); |
1575 | 1635 | } |
1576 | 1636 | // And finally, the main sub template ;). |
1577 | - if (isset($settings['catch_action']['sub_template'])) |
|
1578 | - $context['sub_template'] = $settings['catch_action']['sub_template']; |
|
1579 | -} |
|
1637 | + if (isset($settings['catch_action']['sub_template'])) { |
|
1638 | + $context['sub_template'] = $settings['catch_action']['sub_template']; |
|
1639 | + } |
|
1640 | + } |
|
1580 | 1641 | |
1581 | 1642 | /** |
1582 | 1643 | * Set an option via javascript. |
@@ -1595,12 +1656,14 @@ discard block |
||
1595 | 1656 | checkSession('get'); |
1596 | 1657 | |
1597 | 1658 | // This good-for-nothing pixel is being used to keep the session alive. |
1598 | - if (empty($_GET['var']) || !isset($_GET['val'])) |
|
1599 | - redirectexit($settings['images_url'] . '/blank.png'); |
|
1659 | + if (empty($_GET['var']) || !isset($_GET['val'])) { |
|
1660 | + redirectexit($settings['images_url'] . '/blank.png'); |
|
1661 | + } |
|
1600 | 1662 | |
1601 | 1663 | // Sorry, guests can't go any further than this. |
1602 | - if ($user_info['is_guest'] || $user_info['id'] == 0) |
|
1603 | - obExit(false); |
|
1664 | + if ($user_info['is_guest'] || $user_info['id'] == 0) { |
|
1665 | + obExit(false); |
|
1666 | + } |
|
1604 | 1667 | |
1605 | 1668 | $reservedVars = array( |
1606 | 1669 | 'actual_theme_url', |
@@ -1623,8 +1686,9 @@ discard block |
||
1623 | 1686 | ); |
1624 | 1687 | |
1625 | 1688 | // Can't change reserved vars. |
1626 | - if (in_array(strtolower($_GET['var']), $reservedVars)) |
|
1627 | - redirectexit($settings['images_url'] . '/blank.png'); |
|
1689 | + if (in_array(strtolower($_GET['var']), $reservedVars)) { |
|
1690 | + redirectexit($settings['images_url'] . '/blank.png'); |
|
1691 | + } |
|
1628 | 1692 | |
1629 | 1693 | // Use a specific theme? |
1630 | 1694 | if (isset($_GET['th']) || isset($_GET['id'])) |
@@ -1640,8 +1704,9 @@ discard block |
||
1640 | 1704 | { |
1641 | 1705 | $options['admin_preferences'] = !empty($options['admin_preferences']) ? $smcFunc['json_decode']($options['admin_preferences'], true) : array(); |
1642 | 1706 | // New thingy... |
1643 | - if (isset($_GET['admin_key']) && strlen($_GET['admin_key']) < 5) |
|
1644 | - $options['admin_preferences'][$_GET['admin_key']] = $_GET['val']; |
|
1707 | + if (isset($_GET['admin_key']) && strlen($_GET['admin_key']) < 5) { |
|
1708 | + $options['admin_preferences'][$_GET['admin_key']] = $_GET['val']; |
|
1709 | + } |
|
1645 | 1710 | |
1646 | 1711 | // Change the value to be something nice, |
1647 | 1712 | $_GET['val'] = $smcFunc['json_encode']($options['admin_preferences']); |
@@ -1671,8 +1736,9 @@ discard block |
||
1671 | 1736 | global $context, $scripturl, $boarddir, $smcFunc, $txt; |
1672 | 1737 | |
1673 | 1738 | // @todo Should this be removed? |
1674 | - if (isset($_REQUEST['preview'])) |
|
1675 | - die('die() with fire'); |
|
1739 | + if (isset($_REQUEST['preview'])) { |
|
1740 | + die('die() with fire'); |
|
1741 | + } |
|
1676 | 1742 | |
1677 | 1743 | isAllowedTo('admin_forum'); |
1678 | 1744 | loadTemplate('Themes'); |
@@ -1686,11 +1752,11 @@ discard block |
||
1686 | 1752 | foreach ($context['themes'] as $key => $theme) |
1687 | 1753 | { |
1688 | 1754 | // There has to be a Settings template! |
1689 | - if (!file_exists($theme['theme_dir'] . '/index.template.php') && !file_exists($theme['theme_dir'] . '/css/index.css')) |
|
1690 | - unset($context['themes'][$key]); |
|
1691 | - |
|
1692 | - else |
|
1693 | - $context['themes'][$key]['can_edit_style'] = file_exists($theme['theme_dir'] . '/css/index.css'); |
|
1755 | + if (!file_exists($theme['theme_dir'] . '/index.template.php') && !file_exists($theme['theme_dir'] . '/css/index.css')) { |
|
1756 | + unset($context['themes'][$key]); |
|
1757 | + } else { |
|
1758 | + $context['themes'][$key]['can_edit_style'] = file_exists($theme['theme_dir'] . '/css/index.css'); |
|
1759 | + } |
|
1694 | 1760 | } |
1695 | 1761 | |
1696 | 1762 | $context['sub_template'] = 'edit_list'; |
@@ -1705,22 +1771,24 @@ discard block |
||
1705 | 1771 | $context['theme_id'] = $currentTheme['id']; |
1706 | 1772 | $context['browse_title'] = sprintf($txt['themeadmin_browsing_theme'], $currentTheme['name']); |
1707 | 1773 | |
1708 | - if (!file_exists($currentTheme['theme_dir'] . '/index.template.php') && !file_exists($currentTheme['theme_dir'] . '/css/index.css')) |
|
1709 | - fatal_lang_error('theme_edit_missing', false); |
|
1774 | + if (!file_exists($currentTheme['theme_dir'] . '/index.template.php') && !file_exists($currentTheme['theme_dir'] . '/css/index.css')) { |
|
1775 | + fatal_lang_error('theme_edit_missing', false); |
|
1776 | + } |
|
1710 | 1777 | |
1711 | 1778 | if (!isset($_REQUEST['filename'])) |
1712 | 1779 | { |
1713 | 1780 | if (isset($_GET['directory'])) |
1714 | 1781 | { |
1715 | - if (substr($_GET['directory'], 0, 1) == '.') |
|
1716 | - $_GET['directory'] = ''; |
|
1717 | - else |
|
1782 | + if (substr($_GET['directory'], 0, 1) == '.') { |
|
1783 | + $_GET['directory'] = ''; |
|
1784 | + } else |
|
1718 | 1785 | { |
1719 | 1786 | $_GET['directory'] = preg_replace(array('~^[\./\\:\0\n\r]+~', '~[\\\\]~', '~/[\./]+~'), array('', '/', '/'), $_GET['directory']); |
1720 | 1787 | |
1721 | 1788 | $temp = realpath($currentTheme['theme_dir'] . '/' . $_GET['directory']); |
1722 | - if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) |
|
1723 | - $_GET['directory'] = ''; |
|
1789 | + if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) { |
|
1790 | + $_GET['directory'] = ''; |
|
1791 | + } |
|
1724 | 1792 | } |
1725 | 1793 | } |
1726 | 1794 | |
@@ -1739,37 +1807,39 @@ discard block |
||
1739 | 1807 | 'href' => $scripturl . '?action=admin;area=theme;th=' . $_GET['th'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=edit;directory=' . $temp, |
1740 | 1808 | 'size' => '', |
1741 | 1809 | )); |
1810 | + } else { |
|
1811 | + $context['theme_files'] = get_file_listing($currentTheme['theme_dir'], ''); |
|
1742 | 1812 | } |
1743 | - else |
|
1744 | - $context['theme_files'] = get_file_listing($currentTheme['theme_dir'], ''); |
|
1745 | 1813 | |
1746 | 1814 | $context['sub_template'] = 'edit_browse'; |
1747 | 1815 | |
1748 | 1816 | return; |
1749 | - } |
|
1750 | - else |
|
1817 | + } else |
|
1751 | 1818 | { |
1752 | - if (substr($_REQUEST['filename'], 0, 1) == '.') |
|
1753 | - $_REQUEST['filename'] = ''; |
|
1754 | - else |
|
1819 | + if (substr($_REQUEST['filename'], 0, 1) == '.') { |
|
1820 | + $_REQUEST['filename'] = ''; |
|
1821 | + } else |
|
1755 | 1822 | { |
1756 | 1823 | $_REQUEST['filename'] = preg_replace(array('~^[\./\\:\0\n\r]+~', '~[\\\\]~', '~/[\./]+~'), array('', '/', '/'), $_REQUEST['filename']); |
1757 | 1824 | |
1758 | 1825 | $temp = realpath($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
1759 | - if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) |
|
1760 | - $_REQUEST['filename'] = ''; |
|
1826 | + if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) { |
|
1827 | + $_REQUEST['filename'] = ''; |
|
1828 | + } |
|
1761 | 1829 | } |
1762 | 1830 | |
1763 | - if (empty($_REQUEST['filename'])) |
|
1764 | - fatal_lang_error('theme_edit_missing', false); |
|
1831 | + if (empty($_REQUEST['filename'])) { |
|
1832 | + fatal_lang_error('theme_edit_missing', false); |
|
1833 | + } |
|
1765 | 1834 | } |
1766 | 1835 | |
1767 | 1836 | if (isset($_POST['save'])) |
1768 | 1837 | { |
1769 | 1838 | if (checkSession('post', '', false) == '' && validateToken('admin-te-' . md5($_GET['th'] . '-' . $_REQUEST['filename']), 'post', false) == true) |
1770 | 1839 | { |
1771 | - if (is_array($_POST['entire_file'])) |
|
1772 | - $_POST['entire_file'] = implode("\n", $_POST['entire_file']); |
|
1840 | + if (is_array($_POST['entire_file'])) { |
|
1841 | + $_POST['entire_file'] = implode("\n", $_POST['entire_file']); |
|
1842 | + } |
|
1773 | 1843 | |
1774 | 1844 | $_POST['entire_file'] = rtrim(strtr($_POST['entire_file'], array("\r" => '', ' ' => "\t"))); |
1775 | 1845 | |
@@ -1781,10 +1851,11 @@ discard block |
||
1781 | 1851 | fclose($fp); |
1782 | 1852 | |
1783 | 1853 | $error = @file_get_contents($currentTheme['theme_url'] . '/tmp_' . session_id() . '.php'); |
1784 | - if (preg_match('~ <b>(\d+)</b><br( /)?' . '>$~i', $error) != 0) |
|
1785 | - $error_file = $currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'; |
|
1786 | - else |
|
1787 | - unlink($currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'); |
|
1854 | + if (preg_match('~ <b>(\d+)</b><br( /)?' . '>$~i', $error) != 0) { |
|
1855 | + $error_file = $currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'; |
|
1856 | + } else { |
|
1857 | + unlink($currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'); |
|
1858 | + } |
|
1788 | 1859 | } |
1789 | 1860 | |
1790 | 1861 | if (!isset($error_file)) |
@@ -1805,10 +1876,11 @@ discard block |
||
1805 | 1876 | $context['sub_template'] = 'edit_file'; |
1806 | 1877 | |
1807 | 1878 | // Recycle the submitted data. |
1808 | - if (is_array($_POST['entire_file'])) |
|
1809 | - $context['entire_file'] = $smcFunc['htmlspecialchars'](implode("\n", $_POST['entire_file'])); |
|
1810 | - else |
|
1811 | - $context['entire_file'] = $smcFunc['htmlspecialchars']($_POST['entire_file']); |
|
1879 | + if (is_array($_POST['entire_file'])) { |
|
1880 | + $context['entire_file'] = $smcFunc['htmlspecialchars'](implode("\n", $_POST['entire_file'])); |
|
1881 | + } else { |
|
1882 | + $context['entire_file'] = $smcFunc['htmlspecialchars']($_POST['entire_file']); |
|
1883 | + } |
|
1812 | 1884 | |
1813 | 1885 | $context['edit_filename'] = $smcFunc['htmlspecialchars']($_POST['filename']); |
1814 | 1886 | |
@@ -1831,17 +1903,17 @@ discard block |
||
1831 | 1903 | $context['sub_template'] = 'edit_style'; |
1832 | 1904 | |
1833 | 1905 | $context['entire_file'] = $smcFunc['htmlspecialchars'](strtr(file_get_contents($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']), array("\t" => ' '))); |
1834 | - } |
|
1835 | - elseif (substr($_REQUEST['filename'], -13) == '.template.php') |
|
1906 | + } elseif (substr($_REQUEST['filename'], -13) == '.template.php') |
|
1836 | 1907 | { |
1837 | 1908 | $context['sub_template'] = 'edit_template'; |
1838 | 1909 | |
1839 | - if (!isset($error_file)) |
|
1840 | - $file_data = file($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
|
1841 | - else |
|
1910 | + if (!isset($error_file)) { |
|
1911 | + $file_data = file($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
|
1912 | + } else |
|
1842 | 1913 | { |
1843 | - if (preg_match('~(<b>.+?</b>:.+?<b>).+?(</b>.+?<b>\d+</b>)<br( /)?' . '>$~i', $error, $match) != 0) |
|
1844 | - $context['parse_error'] = $match[1] . $_REQUEST['filename'] . $match[2]; |
|
1914 | + if (preg_match('~(<b>.+?</b>:.+?<b>).+?(</b>.+?<b>\d+</b>)<br( /)?' . '>$~i', $error, $match) != 0) { |
|
1915 | + $context['parse_error'] = $match[1] . $_REQUEST['filename'] . $match[2]; |
|
1916 | + } |
|
1845 | 1917 | $file_data = file($error_file); |
1846 | 1918 | unlink($error_file); |
1847 | 1919 | } |
@@ -1855,8 +1927,9 @@ discard block |
||
1855 | 1927 | // Try to format the functions a little nicer... |
1856 | 1928 | $context['file_parts'][$j]['data'] = trim($context['file_parts'][$j]['data']) . "\n"; |
1857 | 1929 | |
1858 | - if (empty($context['file_parts'][$j]['lines'])) |
|
1859 | - unset($context['file_parts'][$j]); |
|
1930 | + if (empty($context['file_parts'][$j]['lines'])) { |
|
1931 | + unset($context['file_parts'][$j]); |
|
1932 | + } |
|
1860 | 1933 | $context['file_parts'][++$j] = array('lines' => 0, 'line' => $i + 1, 'data' => ''); |
1861 | 1934 | } |
1862 | 1935 | |
@@ -1865,8 +1938,7 @@ discard block |
||
1865 | 1938 | } |
1866 | 1939 | |
1867 | 1940 | $context['entire_file'] = $smcFunc['htmlspecialchars'](strtr(implode('', $file_data), array("\t" => ' '))); |
1868 | - } |
|
1869 | - else |
|
1941 | + } else |
|
1870 | 1942 | { |
1871 | 1943 | $context['sub_template'] = 'edit_file'; |
1872 | 1944 | |
@@ -1892,8 +1964,9 @@ discard block |
||
1892 | 1964 | |
1893 | 1965 | $_GET['th'] = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
1894 | 1966 | |
1895 | - if (empty($_GET['th'])) |
|
1896 | - fatal_lang_error('theme_install_invalid_id'); |
|
1967 | + if (empty($_GET['th'])) { |
|
1968 | + fatal_lang_error('theme_install_invalid_id'); |
|
1969 | + } |
|
1897 | 1970 | |
1898 | 1971 | // Get the theme info. |
1899 | 1972 | $theme = get_single_theme($_GET['th']); |
@@ -1901,25 +1974,24 @@ discard block |
||
1901 | 1974 | |
1902 | 1975 | if (isset($_REQUEST['template']) && preg_match('~[\./\\\\:\0]~', $_REQUEST['template']) == 0) |
1903 | 1976 | { |
1904 | - if (file_exists($settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php')) |
|
1905 | - $filename = $settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php'; |
|
1906 | - |
|
1907 | - else |
|
1908 | - fatal_lang_error('no_access', false); |
|
1977 | + if (file_exists($settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php')) { |
|
1978 | + $filename = $settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php'; |
|
1979 | + } else { |
|
1980 | + fatal_lang_error('no_access', false); |
|
1981 | + } |
|
1909 | 1982 | |
1910 | 1983 | $fp = fopen($theme['theme_dir'] . '/' . $_REQUEST['template'] . '.template.php', 'w'); |
1911 | 1984 | fwrite($fp, file_get_contents($filename)); |
1912 | 1985 | fclose($fp); |
1913 | 1986 | |
1914 | 1987 | redirectexit('action=admin;area=theme;th=' . $context['theme_id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=copy'); |
1915 | - } |
|
1916 | - elseif (isset($_REQUEST['lang_file']) && preg_match('~^[^\./\\\\:\0]\.[^\./\\\\:\0]$~', $_REQUEST['lang_file']) != 0) |
|
1988 | + } elseif (isset($_REQUEST['lang_file']) && preg_match('~^[^\./\\\\:\0]\.[^\./\\\\:\0]$~', $_REQUEST['lang_file']) != 0) |
|
1917 | 1989 | { |
1918 | - if (file_exists($settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php')) |
|
1919 | - $filename = $settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php'; |
|
1920 | - |
|
1921 | - else |
|
1922 | - fatal_lang_error('no_access', false); |
|
1990 | + if (file_exists($settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php')) { |
|
1991 | + $filename = $settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php'; |
|
1992 | + } else { |
|
1993 | + fatal_lang_error('no_access', false); |
|
1994 | + } |
|
1923 | 1995 | |
1924 | 1996 | $fp = fopen($theme['theme_dir'] . '/languages/' . $_REQUEST['lang_file'] . '.php', 'w'); |
1925 | 1997 | fwrite($fp, file_get_contents($filename)); |
@@ -1934,16 +2006,18 @@ discard block |
||
1934 | 2006 | $dir = dir($settings['default_theme_dir']); |
1935 | 2007 | while ($entry = $dir->read()) |
1936 | 2008 | { |
1937 | - if (substr($entry, -13) == '.template.php') |
|
1938 | - $templates[] = substr($entry, 0, -13); |
|
2009 | + if (substr($entry, -13) == '.template.php') { |
|
2010 | + $templates[] = substr($entry, 0, -13); |
|
2011 | + } |
|
1939 | 2012 | } |
1940 | 2013 | $dir->close(); |
1941 | 2014 | |
1942 | 2015 | $dir = dir($settings['default_theme_dir'] . '/languages'); |
1943 | 2016 | while ($entry = $dir->read()) |
1944 | 2017 | { |
1945 | - if (preg_match('~^([^\.]+\.[^\.]+)\.php$~', $entry, $matches)) |
|
1946 | - $lang_files[] = $matches[1]; |
|
2018 | + if (preg_match('~^([^\.]+\.[^\.]+)\.php$~', $entry, $matches)) { |
|
2019 | + $lang_files[] = $matches[1]; |
|
2020 | + } |
|
1947 | 2021 | } |
1948 | 2022 | $dir->close(); |
1949 | 2023 | |
@@ -1951,21 +2025,23 @@ discard block |
||
1951 | 2025 | natcasesort($lang_files); |
1952 | 2026 | |
1953 | 2027 | $context['available_templates'] = array(); |
1954 | - foreach ($templates as $template) |
|
1955 | - $context['available_templates'][$template] = array( |
|
2028 | + foreach ($templates as $template) { |
|
2029 | + $context['available_templates'][$template] = array( |
|
1956 | 2030 | 'filename' => $template . '.template.php', |
1957 | 2031 | 'value' => $template, |
1958 | 2032 | 'already_exists' => false, |
1959 | 2033 | 'can_copy' => is_writable($theme['theme_dir']), |
1960 | 2034 | ); |
2035 | + } |
|
1961 | 2036 | $context['available_language_files'] = array(); |
1962 | - foreach ($lang_files as $file) |
|
1963 | - $context['available_language_files'][$file] = array( |
|
2037 | + foreach ($lang_files as $file) { |
|
2038 | + $context['available_language_files'][$file] = array( |
|
1964 | 2039 | 'filename' => $file . '.php', |
1965 | 2040 | 'value' => $file, |
1966 | 2041 | 'already_exists' => false, |
1967 | 2042 | 'can_copy' => file_exists($theme['theme_dir'] . '/languages') ? is_writable($theme['theme_dir'] . '/languages') : is_writable($theme['theme_dir']), |
1968 | 2043 | ); |
2044 | + } |
|
1969 | 2045 | |
1970 | 2046 | $dir = dir($theme['theme_dir']); |
1971 | 2047 | while ($entry = $dir->read()) |
@@ -38,8 +38,8 @@ discard block |
||
38 | 38 | } |
39 | 39 | </script>'; |
40 | 40 | |
41 | - if (!empty($context['poll_error']['messages'])) |
|
42 | - echo ' |
|
41 | + if (!empty($context['poll_error']['messages'])) { |
|
42 | + echo ' |
|
43 | 43 | <div class="errorbox"> |
44 | 44 | <dl class="poll_error"> |
45 | 45 | <dt> |
@@ -50,6 +50,7 @@ discard block |
||
50 | 50 | </dt> |
51 | 51 | </dl> |
52 | 52 | </div>'; |
53 | + } |
|
53 | 54 | |
54 | 55 | // Start the main poll form. |
55 | 56 | echo ' |
@@ -79,8 +80,9 @@ discard block |
||
79 | 80 | <input type="text" name="options[', $choice['id'], ']" id="options-', $choice['id'], '" value="', $choice['label'], '" size="80" maxlength="255">'; |
80 | 81 | |
81 | 82 | // Does this option have a vote count yet, or is it new? |
82 | - if ($choice['votes'] != -1) |
|
83 | - echo ' (', $choice['votes'], ' ', $txt['votes'], ')'; |
|
83 | + if ($choice['votes'] != -1) { |
|
84 | + echo ' (', $choice['votes'], ' ', $txt['votes'], ')'; |
|
85 | + } |
|
84 | 86 | |
85 | 87 | echo ' |
86 | 88 | </dd>'; |
@@ -118,14 +120,15 @@ discard block |
||
118 | 120 | <input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', '> |
119 | 121 | </dd>'; |
120 | 122 | |
121 | - if ($context['poll']['guest_vote_allowed']) |
|
122 | - echo ' |
|
123 | + if ($context['poll']['guest_vote_allowed']) { |
|
124 | + echo ' |
|
123 | 125 | <dt> |
124 | 126 | <label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label> |
125 | 127 | </dt> |
126 | 128 | <dd> |
127 | 129 | <input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll']['guest_vote']) ? ' checked' : '', '> |
128 | 130 | </dd>'; |
131 | + } |
|
129 | 132 | } |
130 | 133 | |
131 | 134 | echo ' |
@@ -141,12 +144,13 @@ discard block |
||
141 | 144 | </fieldset>'; |
142 | 145 | |
143 | 146 | // If this is an edit, we can allow them to reset the vote counts. |
144 | - if ($context['is_edit']) |
|
145 | - echo ' |
|
147 | + if ($context['is_edit']) { |
|
148 | + echo ' |
|
146 | 149 | <fieldset id="poll_reset"> |
147 | 150 | <legend>', $txt['reset_votes'], '</legend> |
148 | 151 | <input type="checkbox" name="resetVoteCount" value="on"> ' . $txt['reset_votes_check'] . ' |
149 | 152 | </fieldset>'; |
153 | + } |
|
150 | 154 | echo ' |
151 | 155 | <input type="submit" name="post" value="', $txt['save'], '" onclick="return submitThisOnce(this);" accesskey="s" class="button"> |
152 | 156 | </div><!-- .roundframe --> |
@@ -4051,7 +4051,7 @@ |
||
4051 | 4051 | * |
4052 | 4052 | * @param int $pmID The ID of the PM |
4053 | 4053 | * @param string $validFor Which folders this is valud for - can be 'inbox', 'outbox' or 'in_or_outbox' |
4054 | - * @return boolean Whether the PM is accessible in that folder for the current user |
|
4054 | + * @return boolean|null Whether the PM is accessible in that folder for the current user |
|
4055 | 4055 | */ |
4056 | 4056 | function isAccessiblePM($pmID, $validFor = 'in_or_outbox') |
4057 | 4057 | { |
@@ -15,8 +15,9 @@ discard block |
||
15 | 15 | * @version 2.1 Beta 4 |
16 | 16 | */ |
17 | 17 | |
18 | -if (!defined('SMF')) |
|
19 | - die('No direct access...'); |
|
18 | +if (!defined('SMF')) { |
|
19 | + die('No direct access...'); |
|
20 | +} |
|
20 | 21 | |
21 | 22 | /** |
22 | 23 | * This helps organize things... |
@@ -37,13 +38,14 @@ discard block |
||
37 | 38 | |
38 | 39 | loadLanguage('PersonalMessage+Drafts'); |
39 | 40 | |
40 | - if (!isset($_REQUEST['xml'])) |
|
41 | - loadTemplate('PersonalMessage'); |
|
41 | + if (!isset($_REQUEST['xml'])) { |
|
42 | + loadTemplate('PersonalMessage'); |
|
43 | + } |
|
42 | 44 | |
43 | 45 | // Load up the members maximum message capacity. |
44 | - if ($user_info['is_admin']) |
|
45 | - $context['message_limit'] = 0; |
|
46 | - elseif (($context['message_limit'] = cache_get_data('msgLimit:' . $user_info['id'], 360)) === null) |
|
46 | + if ($user_info['is_admin']) { |
|
47 | + $context['message_limit'] = 0; |
|
48 | + } elseif (($context['message_limit'] = cache_get_data('msgLimit:' . $user_info['id'], 360)) === null) |
|
47 | 49 | { |
48 | 50 | // @todo Why do we do this? It seems like if they have any limit we should use it. |
49 | 51 | $request = $smcFunc['db_query']('', ' |
@@ -78,8 +80,9 @@ discard block |
||
78 | 80 | } |
79 | 81 | |
80 | 82 | // a previous message was sent successfully? show a small indication. |
81 | - if (isset($_GET['done']) && ($_GET['done'] == 'sent')) |
|
82 | - $context['pm_sent'] = true; |
|
83 | + if (isset($_GET['done']) && ($_GET['done'] == 'sent')) { |
|
84 | + $context['pm_sent'] = true; |
|
85 | + } |
|
83 | 86 | |
84 | 87 | $context['labels'] = array(); |
85 | 88 | |
@@ -210,11 +213,11 @@ discard block |
||
210 | 213 | { |
211 | 214 | $_REQUEST['sa'] = ''; |
212 | 215 | MessageFolder(); |
213 | - } |
|
214 | - else |
|
216 | + } else |
|
215 | 217 | { |
216 | - if (!isset($_REQUEST['xml']) && $_REQUEST['sa'] != 'popup') |
|
217 | - messageIndexBar($_REQUEST['sa']); |
|
218 | + if (!isset($_REQUEST['xml']) && $_REQUEST['sa'] != 'popup') { |
|
219 | + messageIndexBar($_REQUEST['sa']); |
|
220 | + } |
|
218 | 221 | |
219 | 222 | call_helper($subActions[$_REQUEST['sa']]); |
220 | 223 | } |
@@ -291,16 +294,17 @@ discard block |
||
291 | 294 | ); |
292 | 295 | |
293 | 296 | // Handle labels. |
294 | - if (empty($context['currently_using_labels'])) |
|
295 | - unset($pm_areas['labels']); |
|
296 | - else |
|
297 | + if (empty($context['currently_using_labels'])) { |
|
298 | + unset($pm_areas['labels']); |
|
299 | + } else |
|
297 | 300 | { |
298 | 301 | // Note we send labels by id as it will have less problems in the querystring. |
299 | 302 | $unread_in_labels = 0; |
300 | 303 | foreach ($context['labels'] as $label) |
301 | 304 | { |
302 | - if ($label['id'] == -1) |
|
303 | - continue; |
|
305 | + if ($label['id'] == -1) { |
|
306 | + continue; |
|
307 | + } |
|
304 | 308 | |
305 | 309 | // Count the amount of unread items in labels. |
306 | 310 | $unread_in_labels += $label['unread_messages']; |
@@ -314,8 +318,9 @@ discard block |
||
314 | 318 | ); |
315 | 319 | } |
316 | 320 | |
317 | - if (!empty($unread_in_labels)) |
|
318 | - $pm_areas['labels']['title'] .= ' <span class="amt">' . $unread_in_labels . '</span>'; |
|
321 | + if (!empty($unread_in_labels)) { |
|
322 | + $pm_areas['labels']['title'] .= ' <span class="amt">' . $unread_in_labels . '</span>'; |
|
323 | + } |
|
319 | 324 | } |
320 | 325 | |
321 | 326 | $pm_areas['folders']['areas']['inbox']['unread_messages'] = &$context['labels'][-1]['unread_messages']; |
@@ -353,8 +358,9 @@ discard block |
||
353 | 358 | unset($pm_areas); |
354 | 359 | |
355 | 360 | // No menu means no access. |
356 | - if (!$pm_include_data && (!$user_info['is_guest'] || validateSession())) |
|
357 | - fatal_lang_error('no_access', false); |
|
361 | + if (!$pm_include_data && (!$user_info['is_guest'] || validateSession())) { |
|
362 | + fatal_lang_error('no_access', false); |
|
363 | + } |
|
358 | 364 | |
359 | 365 | // Make a note of the Unique ID for this menu. |
360 | 366 | $context['pm_menu_id'] = $context['max_menu_id']; |
@@ -365,9 +371,10 @@ discard block |
||
365 | 371 | $context['menu_item_selected'] = $current_area; |
366 | 372 | |
367 | 373 | // Set the template for this area and add the profile layer. |
368 | - if (!isset($_REQUEST['xml'])) |
|
369 | - $context['template_layers'][] = 'pm'; |
|
370 | -} |
|
374 | + if (!isset($_REQUEST['xml'])) { |
|
375 | + $context['template_layers'][] = 'pm'; |
|
376 | + } |
|
377 | + } |
|
371 | 378 | |
372 | 379 | /** |
373 | 380 | * The popup for when we ask for the popup from the user. |
@@ -399,8 +406,9 @@ discard block |
||
399 | 406 | ) |
400 | 407 | ); |
401 | 408 | $pms = array(); |
402 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
403 | - $pms[] = $row[0]; |
|
409 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
410 | + $pms[] = $row[0]; |
|
411 | + } |
|
404 | 412 | $smcFunc['db_free_result']($request); |
405 | 413 | |
406 | 414 | if (!empty($pms)) |
@@ -428,8 +436,9 @@ discard block |
||
428 | 436 | ); |
429 | 437 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
430 | 438 | { |
431 | - if (!empty($row['id_member_from'])) |
|
432 | - $senders[] = $row['id_member_from']; |
|
439 | + if (!empty($row['id_member_from'])) { |
|
440 | + $senders[] = $row['id_member_from']; |
|
441 | + } |
|
433 | 442 | |
434 | 443 | $row['replied_to_you'] = $row['id_pm'] != $row['id_pm_head']; |
435 | 444 | $row['time'] = timeformat($row['timestamp']); |
@@ -439,13 +448,15 @@ discard block |
||
439 | 448 | $smcFunc['db_free_result']($request); |
440 | 449 | |
441 | 450 | $senders = loadMemberData($senders); |
442 | - foreach ($senders as $member) |
|
443 | - loadMemberContext($member); |
|
451 | + foreach ($senders as $member) { |
|
452 | + loadMemberContext($member); |
|
453 | + } |
|
444 | 454 | |
445 | 455 | // Having loaded everyone, attach them to the PMs. |
446 | - foreach ($context['unread_pms'] as $id_pm => $details) |
|
447 | - if (!empty($memberContext[$details['id_member_from']])) |
|
448 | - $context['unread_pms'][$id_pm]['member'] = &$memberContext[$details['id_member_from']]; |
|
456 | + foreach ($context['unread_pms'] as $id_pm => $details) { |
|
457 | + if (!empty($memberContext[$details['id_member_from']])) |
|
458 | + $context['unread_pms'][$id_pm]['member'] = &$memberContext[$details['id_member_from']]; |
|
459 | + } |
|
449 | 460 | } |
450 | 461 | } |
451 | 462 | |
@@ -465,12 +476,13 @@ discard block |
||
465 | 476 | } |
466 | 477 | |
467 | 478 | // Make sure the starting location is valid. |
468 | - if (isset($_GET['start']) && $_GET['start'] != 'new') |
|
469 | - $_GET['start'] = (int) $_GET['start']; |
|
470 | - elseif (!isset($_GET['start']) && !empty($options['view_newest_pm_first'])) |
|
471 | - $_GET['start'] = 0; |
|
472 | - else |
|
473 | - $_GET['start'] = 'new'; |
|
479 | + if (isset($_GET['start']) && $_GET['start'] != 'new') { |
|
480 | + $_GET['start'] = (int) $_GET['start']; |
|
481 | + } elseif (!isset($_GET['start']) && !empty($options['view_newest_pm_first'])) { |
|
482 | + $_GET['start'] = 0; |
|
483 | + } else { |
|
484 | + $_GET['start'] = 'new'; |
|
485 | + } |
|
474 | 486 | |
475 | 487 | // Set up some basic theme stuff. |
476 | 488 | $context['from_or_to'] = $context['folder'] != 'sent' ? 'from' : 'to'; |
@@ -484,9 +496,10 @@ discard block |
||
484 | 496 | list ($sig_limits, $sig_bbc) = explode(':', $modSettings['signature_settings']); |
485 | 497 | $sig_limits = explode(',', $sig_limits); |
486 | 498 | |
487 | - if (!empty($sig_limits[5]) || !empty($sig_limits[6])) |
|
488 | - addInlineCss(' |
|
489 | - .signature img { ' . (!empty($sig_limits[5]) ? 'max-width: ' . (int) $sig_limits[5] . 'px; ' : '') . (!empty($sig_limits[6]) ? 'max-height: ' . (int) $sig_limits[6] . 'px; ' : '') . '}'); |
|
499 | + if (!empty($sig_limits[5]) || !empty($sig_limits[6])) { |
|
500 | + addInlineCss(' |
|
501 | + .signature img { ' . (!empty($sig_limits[5]) ? 'max-width: ' . (int) $sig_limits[5] . 'px; ' : '') . (!empty($sig_limits[6]) ? 'max-height: ' . (int) $sig_limits[6] . 'px; ' : '') . '}'); |
|
502 | + } |
|
490 | 503 | } |
491 | 504 | |
492 | 505 | $labelJoin = ''; |
@@ -498,8 +511,7 @@ discard block |
||
498 | 511 | { |
499 | 512 | $labelQuery = ' |
500 | 513 | AND pmr.in_inbox = 1'; |
501 | - } |
|
502 | - elseif ($context['folder'] != 'sent') |
|
514 | + } elseif ($context['folder'] != 'sent') |
|
503 | 515 | { |
504 | 516 | $labelJoin = ' |
505 | 517 | INNER JOIN {db_prefix}pm_labeled_messages AS pl ON (pl.id_pm = pmr.id_pm)'; |
@@ -541,22 +553,24 @@ discard block |
||
541 | 553 | $txt['delete_all'] = str_replace('PMBOX', $pmbox, $txt['delete_all']); |
542 | 554 | |
543 | 555 | // Now, build the link tree! |
544 | - if ($context['current_label_id'] == -1) |
|
545 | - $context['linktree'][] = array( |
|
556 | + if ($context['current_label_id'] == -1) { |
|
557 | + $context['linktree'][] = array( |
|
546 | 558 | 'url' => $scripturl . '?action=pm;f=' . $context['folder'], |
547 | 559 | 'name' => $pmbox |
548 | - ); |
|
560 | + ); |
|
561 | + } |
|
549 | 562 | |
550 | 563 | // Build it further for a label. |
551 | - if ($context['current_label_id'] != -1) |
|
552 | - $context['linktree'][] = array( |
|
564 | + if ($context['current_label_id'] != -1) { |
|
565 | + $context['linktree'][] = array( |
|
553 | 566 | 'url' => $scripturl . '?action=pm;f=' . $context['folder'] . ';l=' . $context['current_label_id'], |
554 | 567 | 'name' => $txt['pm_current_label'] . ': ' . $context['current_label'] |
555 | - ); |
|
568 | + ); |
|
569 | + } |
|
556 | 570 | |
557 | 571 | // Figure out how many messages there are. |
558 | - if ($context['folder'] == 'sent') |
|
559 | - $request = $smcFunc['db_query']('', ' |
|
572 | + if ($context['folder'] == 'sent') { |
|
573 | + $request = $smcFunc['db_query']('', ' |
|
560 | 574 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
561 | 575 | FROM {db_prefix}personal_messages AS pm |
562 | 576 | WHERE pm.id_member_from = {int:current_member} |
@@ -565,9 +579,9 @@ discard block |
||
565 | 579 | 'current_member' => $user_info['id'], |
566 | 580 | 'not_deleted' => 0, |
567 | 581 | ) |
568 | - ); |
|
569 | - else |
|
570 | - $request = $smcFunc['db_query']('', ' |
|
582 | + ); |
|
583 | + } else { |
|
584 | + $request = $smcFunc['db_query']('', ' |
|
571 | 585 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
572 | 586 | FROM {db_prefix}pm_recipients AS pmr' . ($context['display_mode'] == 2 ? ' |
573 | 587 | INNER JOIN {db_prefix}personal_messages AS pm ON (pm.id_pm = pmr.id_pm)' : '') . $labelJoin . ' |
@@ -577,7 +591,8 @@ discard block |
||
577 | 591 | 'current_member' => $user_info['id'], |
578 | 592 | 'not_deleted' => 0, |
579 | 593 | ) |
580 | - ); |
|
594 | + ); |
|
595 | + } |
|
581 | 596 | list ($max_messages) = $smcFunc['db_fetch_row']($request); |
582 | 597 | $smcFunc['db_free_result']($request); |
583 | 598 | |
@@ -586,10 +601,11 @@ discard block |
||
586 | 601 | $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
587 | 602 | |
588 | 603 | // Start on the last page. |
589 | - if (!is_numeric($_GET['start']) || $_GET['start'] >= $max_messages) |
|
590 | - $_GET['start'] = ($max_messages - 1) - (($max_messages - 1) % $maxPerPage); |
|
591 | - elseif ($_GET['start'] < 0) |
|
592 | - $_GET['start'] = 0; |
|
604 | + if (!is_numeric($_GET['start']) || $_GET['start'] >= $max_messages) { |
|
605 | + $_GET['start'] = ($max_messages - 1) - (($max_messages - 1) % $maxPerPage); |
|
606 | + } elseif ($_GET['start'] < 0) { |
|
607 | + $_GET['start'] = 0; |
|
608 | + } |
|
593 | 609 | |
594 | 610 | // ... but wait - what if we want to start from a specific message? |
595 | 611 | if (isset($_GET['pmid'])) |
@@ -597,19 +613,21 @@ discard block |
||
597 | 613 | $pmID = (int) $_GET['pmid']; |
598 | 614 | |
599 | 615 | // Make sure you have access to this PM. |
600 | - if (!isAccessiblePM($pmID, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) |
|
601 | - fatal_lang_error('no_access', false); |
|
616 | + if (!isAccessiblePM($pmID, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) { |
|
617 | + fatal_lang_error('no_access', false); |
|
618 | + } |
|
602 | 619 | |
603 | 620 | $context['current_pm'] = $pmID; |
604 | 621 | |
605 | 622 | // With only one page of PM's we're gonna want page 1. |
606 | - if ($max_messages <= $maxPerPage) |
|
607 | - $_GET['start'] = 0; |
|
623 | + if ($max_messages <= $maxPerPage) { |
|
624 | + $_GET['start'] = 0; |
|
625 | + } |
|
608 | 626 | // If we pass kstart we assume we're in the right place. |
609 | 627 | elseif (!isset($_GET['kstart'])) |
610 | 628 | { |
611 | - if ($context['folder'] == 'sent') |
|
612 | - $request = $smcFunc['db_query']('', ' |
|
629 | + if ($context['folder'] == 'sent') { |
|
630 | + $request = $smcFunc['db_query']('', ' |
|
613 | 631 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
614 | 632 | FROM {db_prefix}personal_messages |
615 | 633 | WHERE id_member_from = {int:current_member} |
@@ -620,9 +638,9 @@ discard block |
||
620 | 638 | 'not_deleted' => 0, |
621 | 639 | 'id_pm' => $pmID, |
622 | 640 | ) |
623 | - ); |
|
624 | - else |
|
625 | - $request = $smcFunc['db_query']('', ' |
|
641 | + ); |
|
642 | + } else { |
|
643 | + $request = $smcFunc['db_query']('', ' |
|
626 | 644 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
627 | 645 | FROM {db_prefix}pm_recipients AS pmr' . ($context['display_mode'] == 2 ? ' |
628 | 646 | INNER JOIN {db_prefix}personal_messages AS pm ON (pm.id_pm = pmr.id_pm)' : '') . $labelJoin . ' |
@@ -634,7 +652,8 @@ discard block |
||
634 | 652 | 'not_deleted' => 0, |
635 | 653 | 'id_pm' => $pmID, |
636 | 654 | ) |
637 | - ); |
|
655 | + ); |
|
656 | + } |
|
638 | 657 | |
639 | 658 | list ($_GET['start']) = $smcFunc['db_fetch_row']($request); |
640 | 659 | $smcFunc['db_free_result']($request); |
@@ -649,8 +668,9 @@ discard block |
||
649 | 668 | { |
650 | 669 | $pmsg = (int) $_GET['pmsg']; |
651 | 670 | |
652 | - if (!isAccessiblePM($pmsg, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) |
|
653 | - fatal_lang_error('no_access', false); |
|
671 | + if (!isAccessiblePM($pmsg, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) { |
|
672 | + fatal_lang_error('no_access', false); |
|
673 | + } |
|
654 | 674 | } |
655 | 675 | |
656 | 676 | // Set up the page index. |
@@ -744,8 +764,9 @@ discard block |
||
744 | 764 | { |
745 | 765 | if (!isset($recipients[$row['id_pm']])) |
746 | 766 | { |
747 | - if (isset($row['id_member_from'])) |
|
748 | - $posters[$row['id_pm']] = $row['id_member_from']; |
|
767 | + if (isset($row['id_member_from'])) { |
|
768 | + $posters[$row['id_pm']] = $row['id_member_from']; |
|
769 | + } |
|
749 | 770 | $pms[$row['id_pm']] = $row['id_pm']; |
750 | 771 | $recipients[$row['id_pm']] = array( |
751 | 772 | 'to' => array(), |
@@ -754,29 +775,33 @@ discard block |
||
754 | 775 | } |
755 | 776 | |
756 | 777 | // Keep track of the last message so we know what the head is without another query! |
757 | - if ((empty($pmID) && (empty($options['view_newest_pm_first']) || !isset($lastData))) || empty($lastData) || (!empty($pmID) && $pmID == $row['id_pm'])) |
|
758 | - $lastData = array( |
|
778 | + if ((empty($pmID) && (empty($options['view_newest_pm_first']) || !isset($lastData))) || empty($lastData) || (!empty($pmID) && $pmID == $row['id_pm'])) { |
|
779 | + $lastData = array( |
|
759 | 780 | 'id' => $row['id_pm'], |
760 | 781 | 'head' => $row['id_pm_head'], |
761 | - ); |
|
782 | + ); |
|
783 | + } |
|
762 | 784 | } |
763 | 785 | $smcFunc['db_free_result']($request); |
764 | 786 | |
765 | 787 | // Make sure that we have been given a correct head pm id! |
766 | - if ($context['display_mode'] == 2 && !empty($pmID) && $pmID != $lastData['id']) |
|
767 | - fatal_lang_error('no_access', false); |
|
788 | + if ($context['display_mode'] == 2 && !empty($pmID) && $pmID != $lastData['id']) { |
|
789 | + fatal_lang_error('no_access', false); |
|
790 | + } |
|
768 | 791 | |
769 | 792 | if (!empty($pms)) |
770 | 793 | { |
771 | 794 | // Select the correct current message. |
772 | - if (empty($pmID)) |
|
773 | - $context['current_pm'] = $lastData['id']; |
|
795 | + if (empty($pmID)) { |
|
796 | + $context['current_pm'] = $lastData['id']; |
|
797 | + } |
|
774 | 798 | |
775 | 799 | // This is a list of the pm's that are used for "full" display. |
776 | - if ($context['display_mode'] == 0) |
|
777 | - $display_pms = $pms; |
|
778 | - else |
|
779 | - $display_pms = array($context['current_pm']); |
|
800 | + if ($context['display_mode'] == 0) { |
|
801 | + $display_pms = $pms; |
|
802 | + } else { |
|
803 | + $display_pms = array($context['current_pm']); |
|
804 | + } |
|
780 | 805 | |
781 | 806 | // At this point we know the main id_pm's. But - if we are looking at conversations we need the others! |
782 | 807 | if ($context['display_mode'] == 2) |
@@ -798,16 +823,18 @@ discard block |
||
798 | 823 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
799 | 824 | { |
800 | 825 | // This is, frankly, a joke. We will put in a workaround for people sending to themselves - yawn! |
801 | - if ($context['folder'] == 'sent' && $row['id_member_from'] == $user_info['id'] && $row['deleted_by_sender'] == 1) |
|
802 | - continue; |
|
803 | - elseif ($row['id_member'] == $user_info['id'] & $row['deleted'] == 1) |
|
804 | - continue; |
|
805 | - |
|
806 | - if (!isset($recipients[$row['id_pm']])) |
|
807 | - $recipients[$row['id_pm']] = array( |
|
826 | + if ($context['folder'] == 'sent' && $row['id_member_from'] == $user_info['id'] && $row['deleted_by_sender'] == 1) { |
|
827 | + continue; |
|
828 | + } elseif ($row['id_member'] == $user_info['id'] & $row['deleted'] == 1) { |
|
829 | + continue; |
|
830 | + } |
|
831 | + |
|
832 | + if (!isset($recipients[$row['id_pm']])) { |
|
833 | + $recipients[$row['id_pm']] = array( |
|
808 | 834 | 'to' => array(), |
809 | 835 | 'bcc' => array() |
810 | - ); |
|
836 | + ); |
|
837 | + } |
|
811 | 838 | $display_pms[] = $row['id_pm']; |
812 | 839 | $posters[$row['id_pm']] = $row['id_member_from']; |
813 | 840 | } |
@@ -858,8 +885,9 @@ discard block |
||
858 | 885 | while ($row2 = $smcFunc['db_fetch_assoc']($request2)) |
859 | 886 | { |
860 | 887 | $l_id = $row2['id_label']; |
861 | - if (isset($context['labels'][$l_id])) |
|
862 | - $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
888 | + if (isset($context['labels'][$l_id])) { |
|
889 | + $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
890 | + } |
|
863 | 891 | } |
864 | 892 | |
865 | 893 | $smcFunc['db_free_result']($request2); |
@@ -876,9 +904,10 @@ discard block |
||
876 | 904 | // Make sure we don't load unnecessary data. |
877 | 905 | if ($context['display_mode'] == 1) |
878 | 906 | { |
879 | - foreach ($posters as $k => $v) |
|
880 | - if (!in_array($k, $display_pms)) |
|
881 | - unset($posters[$k]); |
|
907 | + foreach ($posters as $k => $v) { |
|
908 | + if (!in_array($k, $display_pms)) |
|
909 | + unset($posters[$k]); |
|
910 | + } |
|
882 | 911 | } |
883 | 912 | |
884 | 913 | // Load any users.... |
@@ -889,8 +918,9 @@ discard block |
||
889 | 918 | { |
890 | 919 | // Get the order right. |
891 | 920 | $orderBy = array(); |
892 | - foreach (array_reverse($pms) as $pm) |
|
893 | - $orderBy[] = 'pm.id_pm = ' . $pm; |
|
921 | + foreach (array_reverse($pms) as $pm) { |
|
922 | + $orderBy[] = 'pm.id_pm = ' . $pm; |
|
923 | + } |
|
894 | 924 | |
895 | 925 | // Seperate query for these bits! |
896 | 926 | $subjects_request = $smcFunc['db_query']('', ' |
@@ -936,9 +966,9 @@ discard block |
||
936 | 966 | // Allow mods to add additional buttons here |
937 | 967 | call_integration_hook('integrate_conversation_buttons'); |
938 | 968 | } |
939 | - } |
|
940 | - else |
|
941 | - $messages_request = false; |
|
969 | + } else { |
|
970 | + $messages_request = false; |
|
971 | + } |
|
942 | 972 | |
943 | 973 | $context['can_send_pm'] = allowedTo('pm_send'); |
944 | 974 | $context['can_send_email'] = allowedTo('moderate_forum'); |
@@ -949,11 +979,13 @@ discard block |
||
949 | 979 | if ($context['folder'] != 'sent' && !empty($context['labels'][(int) $context['current_label_id']]['unread_messages'])) |
950 | 980 | { |
951 | 981 | // If the display mode is "old sk00l" do them all... |
952 | - if ($context['display_mode'] == 0) |
|
953 | - markMessages(null, $context['current_label_id']); |
|
982 | + if ($context['display_mode'] == 0) { |
|
983 | + markMessages(null, $context['current_label_id']); |
|
984 | + } |
|
954 | 985 | // Otherwise do just the current one! |
955 | - elseif (!empty($context['current_pm'])) |
|
956 | - markMessages($display_pms, $context['current_label_id']); |
|
986 | + elseif (!empty($context['current_pm'])) { |
|
987 | + markMessages($display_pms, $context['current_label_id']); |
|
988 | + } |
|
957 | 989 | } |
958 | 990 | } |
959 | 991 | |
@@ -971,8 +1003,9 @@ discard block |
||
971 | 1003 | |
972 | 1004 | // Count the current message number.... |
973 | 1005 | static $counter = null; |
974 | - if ($counter === null || $reset) |
|
975 | - $counter = $context['start']; |
|
1006 | + if ($counter === null || $reset) { |
|
1007 | + $counter = $context['start']; |
|
1008 | + } |
|
976 | 1009 | |
977 | 1010 | static $temp_pm_selected = null; |
978 | 1011 | if ($temp_pm_selected === null) |
@@ -1017,19 +1050,22 @@ discard block |
||
1017 | 1050 | } |
1018 | 1051 | |
1019 | 1052 | // Bail if it's false, ie. no messages. |
1020 | - if ($messages_request == false) |
|
1021 | - return false; |
|
1053 | + if ($messages_request == false) { |
|
1054 | + return false; |
|
1055 | + } |
|
1022 | 1056 | |
1023 | 1057 | // Reset the data? |
1024 | - if ($reset == true) |
|
1025 | - return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1058 | + if ($reset == true) { |
|
1059 | + return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1060 | + } |
|
1026 | 1061 | |
1027 | 1062 | // Get the next one... bail if anything goes wrong. |
1028 | 1063 | $message = $smcFunc['db_fetch_assoc']($messages_request); |
1029 | 1064 | if (!$message) |
1030 | 1065 | { |
1031 | - if ($type != 'subject') |
|
1032 | - $smcFunc['db_free_result']($messages_request); |
|
1066 | + if ($type != 'subject') { |
|
1067 | + $smcFunc['db_free_result']($messages_request); |
|
1068 | + } |
|
1033 | 1069 | |
1034 | 1070 | return false; |
1035 | 1071 | } |
@@ -1049,8 +1085,7 @@ discard block |
||
1049 | 1085 | $memberContext[$message['id_member_from']]['email'] = ''; |
1050 | 1086 | $memberContext[$message['id_member_from']]['show_email'] = false; |
1051 | 1087 | $memberContext[$message['id_member_from']]['is_guest'] = true; |
1052 | - } |
|
1053 | - else |
|
1088 | + } else |
|
1054 | 1089 | { |
1055 | 1090 | $memberContext[$message['id_member_from']]['can_view_profile'] = allowedTo('profile_view') || ($message['id_member_from'] == $user_info['id'] && !$user_info['is_guest']); |
1056 | 1091 | $memberContext[$message['id_member_from']]['can_see_warning'] = !isset($context['disabled_fields']['warning_status']) && $memberContext[$message['id_member_from']]['warning_status'] && ($context['user']['can_mod'] || (!empty($modSettings['warning_show']) && ($modSettings['warning_show'] > 1 || $message['id_member_from'] == $user_info['id']))); |
@@ -1091,9 +1126,10 @@ discard block |
||
1091 | 1126 | $counter++; |
1092 | 1127 | |
1093 | 1128 | // Any custom profile fields? |
1094 | - if (!empty($memberContext[$message['id_member_from']]['custom_fields'])) |
|
1095 | - foreach ($memberContext[$message['id_member_from']]['custom_fields'] as $custom) |
|
1096 | - $output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom; |
|
1129 | + if (!empty($memberContext[$message['id_member_from']]['custom_fields'])) { |
|
1130 | + foreach ($memberContext[$message['id_member_from']]['custom_fields'] as $custom) |
|
1131 | + $output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom; |
|
1132 | + } |
|
1097 | 1133 | |
1098 | 1134 | call_integration_hook('integrate_prepare_pm_context', array(&$output, &$message, $counter)); |
1099 | 1135 | |
@@ -1117,22 +1153,28 @@ discard block |
||
1117 | 1153 | $context['search_params'][$k] = $v; |
1118 | 1154 | } |
1119 | 1155 | } |
1120 | - if (isset($_REQUEST['search'])) |
|
1121 | - $context['search_params']['search'] = un_htmlspecialchars($_REQUEST['search']); |
|
1156 | + if (isset($_REQUEST['search'])) { |
|
1157 | + $context['search_params']['search'] = un_htmlspecialchars($_REQUEST['search']); |
|
1158 | + } |
|
1122 | 1159 | |
1123 | - if (isset($context['search_params']['search'])) |
|
1124 | - $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1125 | - if (isset($context['search_params']['userspec'])) |
|
1126 | - $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1160 | + if (isset($context['search_params']['search'])) { |
|
1161 | + $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1162 | + } |
|
1163 | + if (isset($context['search_params']['userspec'])) { |
|
1164 | + $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1165 | + } |
|
1127 | 1166 | |
1128 | - if (!empty($context['search_params']['searchtype'])) |
|
1129 | - $context['search_params']['searchtype'] = 2; |
|
1167 | + if (!empty($context['search_params']['searchtype'])) { |
|
1168 | + $context['search_params']['searchtype'] = 2; |
|
1169 | + } |
|
1130 | 1170 | |
1131 | - if (!empty($context['search_params']['minage'])) |
|
1132 | - $context['search_params']['minage'] = (int) $context['search_params']['minage']; |
|
1171 | + if (!empty($context['search_params']['minage'])) { |
|
1172 | + $context['search_params']['minage'] = (int) $context['search_params']['minage']; |
|
1173 | + } |
|
1133 | 1174 | |
1134 | - if (!empty($context['search_params']['maxage'])) |
|
1135 | - $context['search_params']['maxage'] = (int) $context['search_params']['maxage']; |
|
1175 | + if (!empty($context['search_params']['maxage'])) { |
|
1176 | + $context['search_params']['maxage'] = (int) $context['search_params']['maxage']; |
|
1177 | + } |
|
1136 | 1178 | |
1137 | 1179 | $context['search_params']['subject_only'] = !empty($context['search_params']['subject_only']); |
1138 | 1180 | $context['search_params']['show_complete'] = !empty($context['search_params']['show_complete']); |
@@ -1159,8 +1201,9 @@ discard block |
||
1159 | 1201 | $context['search_errors']['messages'] = array(); |
1160 | 1202 | foreach ($context['search_errors'] as $search_error => $dummy) |
1161 | 1203 | { |
1162 | - if ($search_error == 'messages') |
|
1163 | - continue; |
|
1204 | + if ($search_error == 'messages') { |
|
1205 | + continue; |
|
1206 | + } |
|
1164 | 1207 | |
1165 | 1208 | $context['search_errors']['messages'][] = $txt['error_' . $search_error]; |
1166 | 1209 | } |
@@ -1182,8 +1225,9 @@ discard block |
||
1182 | 1225 | global $scripturl, $modSettings, $user_info, $context, $txt; |
1183 | 1226 | global $memberContext, $smcFunc; |
1184 | 1227 | |
1185 | - if (!empty($context['load_average']) && !empty($modSettings['loadavg_search']) && $context['load_average'] >= $modSettings['loadavg_search']) |
|
1186 | - fatal_lang_error('loadavg_search_disabled', false); |
|
1228 | + if (!empty($context['load_average']) && !empty($modSettings['loadavg_search']) && $context['load_average'] >= $modSettings['loadavg_search']) { |
|
1229 | + fatal_lang_error('loadavg_search_disabled', false); |
|
1230 | + } |
|
1187 | 1231 | |
1188 | 1232 | /** |
1189 | 1233 | * @todo For the moment force the folder to the inbox. |
@@ -1212,35 +1256,40 @@ discard block |
||
1212 | 1256 | $context['start'] = isset($_GET['start']) ? (int) $_GET['start'] : 0; |
1213 | 1257 | |
1214 | 1258 | // Store whether simple search was used (needed if the user wants to do another query). |
1215 | - if (!isset($search_params['advanced'])) |
|
1216 | - $search_params['advanced'] = empty($_REQUEST['advanced']) ? 0 : 1; |
|
1259 | + if (!isset($search_params['advanced'])) { |
|
1260 | + $search_params['advanced'] = empty($_REQUEST['advanced']) ? 0 : 1; |
|
1261 | + } |
|
1217 | 1262 | |
1218 | 1263 | // 1 => 'allwords' (default, don't set as param) / 2 => 'anywords'. |
1219 | - if (!empty($search_params['searchtype']) || (!empty($_REQUEST['searchtype']) && $_REQUEST['searchtype'] == 2)) |
|
1220 | - $search_params['searchtype'] = 2; |
|
1264 | + if (!empty($search_params['searchtype']) || (!empty($_REQUEST['searchtype']) && $_REQUEST['searchtype'] == 2)) { |
|
1265 | + $search_params['searchtype'] = 2; |
|
1266 | + } |
|
1221 | 1267 | |
1222 | 1268 | // Minimum age of messages. Default to zero (don't set param in that case). |
1223 | - if (!empty($search_params['minage']) || (!empty($_REQUEST['minage']) && $_REQUEST['minage'] > 0)) |
|
1224 | - $search_params['minage'] = !empty($search_params['minage']) ? (int) $search_params['minage'] : (int) $_REQUEST['minage']; |
|
1269 | + if (!empty($search_params['minage']) || (!empty($_REQUEST['minage']) && $_REQUEST['minage'] > 0)) { |
|
1270 | + $search_params['minage'] = !empty($search_params['minage']) ? (int) $search_params['minage'] : (int) $_REQUEST['minage']; |
|
1271 | + } |
|
1225 | 1272 | |
1226 | 1273 | // Maximum age of messages. Default to infinite (9999 days: param not set). |
1227 | - if (!empty($search_params['maxage']) || (!empty($_REQUEST['maxage']) && $_REQUEST['maxage'] != 9999)) |
|
1228 | - $search_params['maxage'] = !empty($search_params['maxage']) ? (int) $search_params['maxage'] : (int) $_REQUEST['maxage']; |
|
1274 | + if (!empty($search_params['maxage']) || (!empty($_REQUEST['maxage']) && $_REQUEST['maxage'] != 9999)) { |
|
1275 | + $search_params['maxage'] = !empty($search_params['maxage']) ? (int) $search_params['maxage'] : (int) $_REQUEST['maxage']; |
|
1276 | + } |
|
1229 | 1277 | |
1230 | 1278 | $search_params['subject_only'] = !empty($search_params['subject_only']) || !empty($_REQUEST['subject_only']); |
1231 | 1279 | $search_params['show_complete'] = !empty($search_params['show_complete']) || !empty($_REQUEST['show_complete']); |
1232 | 1280 | |
1233 | 1281 | // Default the user name to a wildcard matching every user (*). |
1234 | - if (!empty($search_params['user_spec']) || (!empty($_REQUEST['userspec']) && $_REQUEST['userspec'] != '*')) |
|
1235 | - $search_params['userspec'] = isset($search_params['userspec']) ? $search_params['userspec'] : $_REQUEST['userspec']; |
|
1282 | + if (!empty($search_params['user_spec']) || (!empty($_REQUEST['userspec']) && $_REQUEST['userspec'] != '*')) { |
|
1283 | + $search_params['userspec'] = isset($search_params['userspec']) ? $search_params['userspec'] : $_REQUEST['userspec']; |
|
1284 | + } |
|
1236 | 1285 | |
1237 | 1286 | // This will be full of all kinds of parameters! |
1238 | 1287 | $searchq_parameters = array(); |
1239 | 1288 | |
1240 | 1289 | // If there's no specific user, then don't mention it in the main query. |
1241 | - if (empty($search_params['userspec'])) |
|
1242 | - $userQuery = ''; |
|
1243 | - else |
|
1290 | + if (empty($search_params['userspec'])) { |
|
1291 | + $userQuery = ''; |
|
1292 | + } else |
|
1244 | 1293 | { |
1245 | 1294 | $userString = strtr($smcFunc['htmlspecialchars']($search_params['userspec'], ENT_QUOTES), array('"' => '"')); |
1246 | 1295 | $userString = strtr($userString, array('%' => '\%', '_' => '\_', '*' => '%', '?' => '_')); |
@@ -1252,8 +1301,9 @@ discard block |
||
1252 | 1301 | { |
1253 | 1302 | $possible_users[$k] = trim($possible_users[$k]); |
1254 | 1303 | |
1255 | - if (strlen($possible_users[$k]) == 0) |
|
1256 | - unset($possible_users[$k]); |
|
1304 | + if (strlen($possible_users[$k]) == 0) { |
|
1305 | + unset($possible_users[$k]); |
|
1306 | + } |
|
1257 | 1307 | } |
1258 | 1308 | |
1259 | 1309 | if (!empty($possible_users)) |
@@ -1265,8 +1315,9 @@ discard block |
||
1265 | 1315 | { |
1266 | 1316 | $where_params['name_' . $k] = $v; |
1267 | 1317 | $where_clause[] = '{raw:real_name} LIKE {string:name_' . $k . '}'; |
1268 | - if (!isset($where_params['real_name'])) |
|
1269 | - $where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name'; |
|
1318 | + if (!isset($where_params['real_name'])) { |
|
1319 | + $where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name'; |
|
1320 | + } |
|
1270 | 1321 | } |
1271 | 1322 | |
1272 | 1323 | // Who matches those criteria? |
@@ -1279,28 +1330,28 @@ discard block |
||
1279 | 1330 | ); |
1280 | 1331 | |
1281 | 1332 | // Simply do nothing if there're too many members matching the criteria. |
1282 | - if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch) |
|
1283 | - $userQuery = ''; |
|
1284 | - elseif ($smcFunc['db_num_rows']($request) == 0) |
|
1333 | + if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch) { |
|
1334 | + $userQuery = ''; |
|
1335 | + } elseif ($smcFunc['db_num_rows']($request) == 0) |
|
1285 | 1336 | { |
1286 | 1337 | $userQuery = 'AND pm.id_member_from = 0 AND ({raw:pm_from_name} LIKE {raw:guest_user_name_implode})'; |
1287 | 1338 | $searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR ' . ($smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name') . ' LIKE \'', $possible_users) . '\''; |
1288 | 1339 | $searchq_parameters['pm_from_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name'; |
1289 | - } |
|
1290 | - else |
|
1340 | + } else |
|
1291 | 1341 | { |
1292 | 1342 | $memberlist = array(); |
1293 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1294 | - $memberlist[] = $row['id_member']; |
|
1343 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1344 | + $memberlist[] = $row['id_member']; |
|
1345 | + } |
|
1295 | 1346 | $userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND ({raw:pm_from_name} LIKE {raw:guest_user_name_implode})))'; |
1296 | 1347 | $searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR ' . ($smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name') . ' LIKE \'', $possible_users) . '\''; |
1297 | 1348 | $searchq_parameters['member_list'] = $memberlist; |
1298 | 1349 | $searchq_parameters['pm_from_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name'; |
1299 | 1350 | } |
1300 | 1351 | $smcFunc['db_free_result']($request); |
1301 | - } |
|
1302 | - else |
|
1303 | - $userQuery = ''; |
|
1352 | + } else { |
|
1353 | + $userQuery = ''; |
|
1354 | + } |
|
1304 | 1355 | } |
1305 | 1356 | |
1306 | 1357 | // Setup the sorting variables... |
@@ -1308,8 +1359,9 @@ discard block |
||
1308 | 1359 | $sort_columns = array( |
1309 | 1360 | 'pm.id_pm', |
1310 | 1361 | ); |
1311 | - if (empty($search_params['sort']) && !empty($_REQUEST['sort'])) |
|
1312 | - list ($search_params['sort'], $search_params['sort_dir']) = array_pad(explode('|', $_REQUEST['sort']), 2, ''); |
|
1362 | + if (empty($search_params['sort']) && !empty($_REQUEST['sort'])) { |
|
1363 | + list ($search_params['sort'], $search_params['sort_dir']) = array_pad(explode('|', $_REQUEST['sort']), 2, ''); |
|
1364 | + } |
|
1313 | 1365 | $search_params['sort'] = !empty($search_params['sort']) && in_array($search_params['sort'], $sort_columns) ? $search_params['sort'] : 'pm.id_pm'; |
1314 | 1366 | $search_params['sort_dir'] = !empty($search_params['sort_dir']) && $search_params['sort_dir'] == 'asc' ? 'asc' : 'desc'; |
1315 | 1367 | |
@@ -1319,24 +1371,27 @@ discard block |
||
1319 | 1371 | if ($context['folder'] == 'inbox' && !empty($search_params['advanced']) && $context['currently_using_labels']) |
1320 | 1372 | { |
1321 | 1373 | // Came here from pagination? Put them back into $_REQUEST for sanitization. |
1322 | - if (isset($search_params['labels'])) |
|
1323 | - $_REQUEST['searchlabel'] = explode(',', $search_params['labels']); |
|
1374 | + if (isset($search_params['labels'])) { |
|
1375 | + $_REQUEST['searchlabel'] = explode(',', $search_params['labels']); |
|
1376 | + } |
|
1324 | 1377 | |
1325 | 1378 | // Assuming we have some labels - make them all integers. |
1326 | 1379 | if (!empty($_REQUEST['searchlabel']) && is_array($_REQUEST['searchlabel'])) |
1327 | 1380 | { |
1328 | - foreach ($_REQUEST['searchlabel'] as $key => $id) |
|
1329 | - $_REQUEST['searchlabel'][$key] = (int) $id; |
|
1330 | - } |
|
1331 | - else |
|
1332 | - $_REQUEST['searchlabel'] = array(); |
|
1381 | + foreach ($_REQUEST['searchlabel'] as $key => $id) { |
|
1382 | + $_REQUEST['searchlabel'][$key] = (int) $id; |
|
1383 | + } |
|
1384 | + } else { |
|
1385 | + $_REQUEST['searchlabel'] = array(); |
|
1386 | + } |
|
1333 | 1387 | |
1334 | 1388 | // Now that everything is cleaned up a bit, make the labels a param. |
1335 | 1389 | $search_params['labels'] = implode(',', $_REQUEST['searchlabel']); |
1336 | 1390 | |
1337 | 1391 | // No labels selected? That must be an error! |
1338 | - if (empty($_REQUEST['searchlabel'])) |
|
1339 | - $context['search_errors']['no_labels_selected'] = true; |
|
1392 | + if (empty($_REQUEST['searchlabel'])) { |
|
1393 | + $context['search_errors']['no_labels_selected'] = true; |
|
1394 | + } |
|
1340 | 1395 | // Otherwise prepare the query! |
1341 | 1396 | elseif (count($_REQUEST['searchlabel']) != count($context['labels'])) |
1342 | 1397 | { |
@@ -1359,8 +1414,7 @@ discard block |
||
1359 | 1414 | // Not searching the inbox - PM must be labeled |
1360 | 1415 | $labelQuery = ' AND pml.id_label IN ({array_int:labels})'; |
1361 | 1416 | $labelJoin = ' INNER JOIN {db_prefix}pm_labeled_messages AS pml ON (pml.id_pm = pmr.id_pm)'; |
1362 | - } |
|
1363 | - else |
|
1417 | + } else |
|
1364 | 1418 | { |
1365 | 1419 | // Searching the inbox - PM doesn't have to be labeled |
1366 | 1420 | $labelQuery = ' AND (' . substr($labelQuery, 5) . ' OR pml.id_label IN ({array_int:labels}))'; |
@@ -1375,8 +1429,9 @@ discard block |
||
1375 | 1429 | // What are we actually searching for? |
1376 | 1430 | $search_params['search'] = !empty($search_params['search']) ? $search_params['search'] : (isset($_REQUEST['search']) ? $_REQUEST['search'] : ''); |
1377 | 1431 | // If we ain't got nothing - we should error! |
1378 | - if (!isset($search_params['search']) || $search_params['search'] == '') |
|
1379 | - $context['search_errors']['invalid_search_string'] = true; |
|
1432 | + if (!isset($search_params['search']) || $search_params['search'] == '') { |
|
1433 | + $context['search_errors']['invalid_search_string'] = true; |
|
1434 | + } |
|
1380 | 1435 | |
1381 | 1436 | // Extract phrase parts first (e.g. some words "this is a phrase" some more words.) |
1382 | 1437 | preg_match_all('~(?:^|\s)([-]?)"([^"]+)"(?:$|\s)~' . ($context['utf8'] ? 'u' : ''), $search_params['search'], $matches, PREG_PATTERN_ORDER); |
@@ -1389,12 +1444,14 @@ discard block |
||
1389 | 1444 | $excludedWords = array(); |
1390 | 1445 | |
1391 | 1446 | // .. first, we check for things like -"some words", but not "-some words". |
1392 | - foreach ($matches[1] as $index => $word) |
|
1393 | - if ($word == '-') |
|
1447 | + foreach ($matches[1] as $index => $word) { |
|
1448 | + if ($word == '-') |
|
1394 | 1449 | { |
1395 | - $word = $smcFunc['strtolower'](trim($searchArray[$index])); |
|
1396 | - if (strlen($word) > 0) |
|
1397 | - $excludedWords[] = $word; |
|
1450 | + $word = $smcFunc['strtolower'](trim($searchArray[$index])); |
|
1451 | + } |
|
1452 | + if (strlen($word) > 0) { |
|
1453 | + $excludedWords[] = $word; |
|
1454 | + } |
|
1398 | 1455 | unset($searchArray[$index]); |
1399 | 1456 | } |
1400 | 1457 | |
@@ -1404,8 +1461,9 @@ discard block |
||
1404 | 1461 | if (strpos(trim($word), '-') === 0) |
1405 | 1462 | { |
1406 | 1463 | $word = substr($smcFunc['strtolower']($word), 1); |
1407 | - if (strlen($word) > 0) |
|
1408 | - $excludedWords[] = $word; |
|
1464 | + if (strlen($word) > 0) { |
|
1465 | + $excludedWords[] = $word; |
|
1466 | + } |
|
1409 | 1467 | unset($tempSearch[$index]); |
1410 | 1468 | } |
1411 | 1469 | } |
@@ -1416,9 +1474,9 @@ discard block |
||
1416 | 1474 | foreach ($searchArray as $index => $value) |
1417 | 1475 | { |
1418 | 1476 | $searchArray[$index] = $smcFunc['strtolower'](trim($value)); |
1419 | - if ($searchArray[$index] == '') |
|
1420 | - unset($searchArray[$index]); |
|
1421 | - else |
|
1477 | + if ($searchArray[$index] == '') { |
|
1478 | + unset($searchArray[$index]); |
|
1479 | + } else |
|
1422 | 1480 | { |
1423 | 1481 | // Sort out entities first. |
1424 | 1482 | $searchArray[$index] = $smcFunc['htmlspecialchars']($searchArray[$index]); |
@@ -1428,27 +1486,32 @@ discard block |
||
1428 | 1486 | |
1429 | 1487 | // Create an array of replacements for highlighting. |
1430 | 1488 | $context['mark'] = array(); |
1431 | - foreach ($searchArray as $word) |
|
1432 | - $context['mark'][$word] = '<strong class="highlight">' . $word . '</strong>'; |
|
1489 | + foreach ($searchArray as $word) { |
|
1490 | + $context['mark'][$word] = '<strong class="highlight">' . $word . '</strong>'; |
|
1491 | + } |
|
1433 | 1492 | |
1434 | 1493 | // This contains *everything* |
1435 | 1494 | $searchWords = array_merge($searchArray, $excludedWords); |
1436 | 1495 | |
1437 | 1496 | // Make sure at least one word is being searched for. |
1438 | - if (empty($searchArray)) |
|
1439 | - $context['search_errors']['invalid_search_string'] = true; |
|
1497 | + if (empty($searchArray)) { |
|
1498 | + $context['search_errors']['invalid_search_string'] = true; |
|
1499 | + } |
|
1440 | 1500 | |
1441 | 1501 | // Sort out the search query so the user can edit it - if they want. |
1442 | 1502 | $context['search_params'] = $search_params; |
1443 | - if (isset($context['search_params']['search'])) |
|
1444 | - $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1445 | - if (isset($context['search_params']['userspec'])) |
|
1446 | - $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1503 | + if (isset($context['search_params']['search'])) { |
|
1504 | + $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1505 | + } |
|
1506 | + if (isset($context['search_params']['userspec'])) { |
|
1507 | + $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1508 | + } |
|
1447 | 1509 | |
1448 | 1510 | // Now we have all the parameters, combine them together for pagination and the like... |
1449 | 1511 | $context['params'] = array(); |
1450 | - foreach ($search_params as $k => $v) |
|
1451 | - $context['params'][] = $k . '|\'|' . $v; |
|
1512 | + foreach ($search_params as $k => $v) { |
|
1513 | + $context['params'][] = $k . '|\'|' . $v; |
|
1514 | + } |
|
1452 | 1515 | $context['params'] = base64_encode(implode('|"|', $context['params'])); |
1453 | 1516 | |
1454 | 1517 | // Compile the subject query part. |
@@ -1456,26 +1519,31 @@ discard block |
||
1456 | 1519 | |
1457 | 1520 | foreach ($searchWords as $index => $word) |
1458 | 1521 | { |
1459 | - if ($word == '') |
|
1460 | - continue; |
|
1461 | - |
|
1462 | - if ($search_params['subject_only']) |
|
1463 | - $andQueryParts[] = 'pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '}'; |
|
1464 | - else |
|
1465 | - $andQueryParts[] = '(pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '} ' . (in_array($word, $excludedWords) ? 'AND pm.body NOT' : 'OR pm.body') . ' LIKE {string:search_' . $index . '})'; |
|
1522 | + if ($word == '') { |
|
1523 | + continue; |
|
1524 | + } |
|
1525 | + |
|
1526 | + if ($search_params['subject_only']) { |
|
1527 | + $andQueryParts[] = 'pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '}'; |
|
1528 | + } else { |
|
1529 | + $andQueryParts[] = '(pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '} ' . (in_array($word, $excludedWords) ? 'AND pm.body NOT' : 'OR pm.body') . ' LIKE {string:search_' . $index . '})'; |
|
1530 | + } |
|
1466 | 1531 | $searchq_parameters['search_' . $index] = '%' . strtr($word, array('_' => '\\_', '%' => '\\%')) . '%'; |
1467 | 1532 | } |
1468 | 1533 | |
1469 | 1534 | $searchQuery = ' 1=1'; |
1470 | - if (!empty($andQueryParts)) |
|
1471 | - $searchQuery = implode(!empty($search_params['searchtype']) && $search_params['searchtype'] == 2 ? ' OR ' : ' AND ', $andQueryParts); |
|
1535 | + if (!empty($andQueryParts)) { |
|
1536 | + $searchQuery = implode(!empty($search_params['searchtype']) && $search_params['searchtype'] == 2 ? ' OR ' : ' AND ', $andQueryParts); |
|
1537 | + } |
|
1472 | 1538 | |
1473 | 1539 | // Age limits? |
1474 | 1540 | $timeQuery = ''; |
1475 | - if (!empty($search_params['minage'])) |
|
1476 | - $timeQuery .= ' AND pm.msgtime < ' . (time() - $search_params['minage'] * 86400); |
|
1477 | - if (!empty($search_params['maxage'])) |
|
1478 | - $timeQuery .= ' AND pm.msgtime > ' . (time() - $search_params['maxage'] * 86400); |
|
1541 | + if (!empty($search_params['minage'])) { |
|
1542 | + $timeQuery .= ' AND pm.msgtime < ' . (time() - $search_params['minage'] * 86400); |
|
1543 | + } |
|
1544 | + if (!empty($search_params['maxage'])) { |
|
1545 | + $timeQuery .= ' AND pm.msgtime > ' . (time() - $search_params['maxage'] * 86400); |
|
1546 | + } |
|
1479 | 1547 | |
1480 | 1548 | // If we have errors - return back to the first screen... |
1481 | 1549 | if (!empty($context['search_errors'])) |
@@ -1561,8 +1629,9 @@ discard block |
||
1561 | 1629 | ) |
1562 | 1630 | ); |
1563 | 1631 | $real_pm_ids = array(); |
1564 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1565 | - $real_pm_ids[$row['id_pm_head']] = $row['id_pm']; |
|
1632 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1633 | + $real_pm_ids[$row['id_pm_head']] = $row['id_pm']; |
|
1634 | + } |
|
1566 | 1635 | $smcFunc['db_free_result']($request); |
1567 | 1636 | } |
1568 | 1637 | |
@@ -1592,8 +1661,9 @@ discard block |
||
1592 | 1661 | ); |
1593 | 1662 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1594 | 1663 | { |
1595 | - if ($context['folder'] == 'sent' || empty($row['bcc'])) |
|
1596 | - $recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>'; |
|
1664 | + if ($context['folder'] == 'sent' || empty($row['bcc'])) { |
|
1665 | + $recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>'; |
|
1666 | + } |
|
1597 | 1667 | |
1598 | 1668 | if ($row['id_member_to'] == $user_info['id'] && $context['folder'] != 'sent') |
1599 | 1669 | { |
@@ -1614,12 +1684,14 @@ discard block |
||
1614 | 1684 | while ($row2 = $smcFunc['db_fetch_assoc']($request2)) |
1615 | 1685 | { |
1616 | 1686 | $l_id = $row2['id_label']; |
1617 | - if (isset($context['labels'][$l_id])) |
|
1618 | - $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
1687 | + if (isset($context['labels'][$l_id])) { |
|
1688 | + $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
1689 | + } |
|
1619 | 1690 | |
1620 | 1691 | // Here we find the first label on a message - for linking to posts in results |
1621 | - if (!isset($context['first_label'][$row['id_pm']]) && $row['in_inbox'] != 1) |
|
1622 | - $context['first_label'][$row['id_pm']] = $l_id; |
|
1692 | + if (!isset($context['first_label'][$row['id_pm']]) && $row['in_inbox'] != 1) { |
|
1693 | + $context['first_label'][$row['id_pm']] = $l_id; |
|
1694 | + } |
|
1623 | 1695 | } |
1624 | 1696 | |
1625 | 1697 | $smcFunc['db_free_result']($request2); |
@@ -1746,8 +1818,9 @@ discard block |
||
1746 | 1818 | list ($postCount) = $smcFunc['db_fetch_row']($request); |
1747 | 1819 | $smcFunc['db_free_result']($request); |
1748 | 1820 | |
1749 | - if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) |
|
1750 | - fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
1821 | + if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) { |
|
1822 | + fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
1823 | + } |
|
1751 | 1824 | } |
1752 | 1825 | |
1753 | 1826 | // Quoting/Replying to a message? |
@@ -1756,8 +1829,9 @@ discard block |
||
1756 | 1829 | $pmsg = (int) $_REQUEST['pmsg']; |
1757 | 1830 | |
1758 | 1831 | // Make sure this is yours. |
1759 | - if (!isAccessiblePM($pmsg)) |
|
1760 | - fatal_lang_error('no_access', false); |
|
1832 | + if (!isAccessiblePM($pmsg)) { |
|
1833 | + fatal_lang_error('no_access', false); |
|
1834 | + } |
|
1761 | 1835 | |
1762 | 1836 | // Work out whether this is one you've received? |
1763 | 1837 | $request = $smcFunc['db_query']('', ' |
@@ -1794,8 +1868,9 @@ discard block |
||
1794 | 1868 | 'id_pm' => $pmsg, |
1795 | 1869 | ) |
1796 | 1870 | ); |
1797 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1798 | - fatal_lang_error('pm_not_yours', false); |
|
1871 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1872 | + fatal_lang_error('pm_not_yours', false); |
|
1873 | + } |
|
1799 | 1874 | $row_quoted = $smcFunc['db_fetch_assoc']($request); |
1800 | 1875 | $smcFunc['db_free_result']($request); |
1801 | 1876 | |
@@ -1806,9 +1881,9 @@ discard block |
||
1806 | 1881 | // Add 'Re: ' to it.... |
1807 | 1882 | if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix'))) |
1808 | 1883 | { |
1809 | - if ($language === $user_info['language']) |
|
1810 | - $context['response_prefix'] = $txt['response_prefix']; |
|
1811 | - else |
|
1884 | + if ($language === $user_info['language']) { |
|
1885 | + $context['response_prefix'] = $txt['response_prefix']; |
|
1886 | + } else |
|
1812 | 1887 | { |
1813 | 1888 | loadLanguage('index', $language, false); |
1814 | 1889 | $context['response_prefix'] = $txt['response_prefix']; |
@@ -1817,22 +1892,25 @@ discard block |
||
1817 | 1892 | cache_put_data('response_prefix', $context['response_prefix'], 600); |
1818 | 1893 | } |
1819 | 1894 | $form_subject = $row_quoted['subject']; |
1820 | - if ($context['reply'] && trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) |
|
1821 | - $form_subject = $context['response_prefix'] . $form_subject; |
|
1895 | + if ($context['reply'] && trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) { |
|
1896 | + $form_subject = $context['response_prefix'] . $form_subject; |
|
1897 | + } |
|
1822 | 1898 | |
1823 | 1899 | if (isset($_REQUEST['quote'])) |
1824 | 1900 | { |
1825 | 1901 | // Remove any nested quotes and <br>... |
1826 | 1902 | $form_message = preg_replace('~<br ?/?' . '>~i', "\n", $row_quoted['body']); |
1827 | - if (!empty($modSettings['removeNestedQuotes'])) |
|
1828 | - $form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message); |
|
1829 | - if (empty($row_quoted['id_member'])) |
|
1830 | - $form_message = '[quote author="' . $row_quoted['real_name'] . '"]' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1831 | - else |
|
1832 | - $form_message = '[quote author=' . $row_quoted['real_name'] . ' link=action=profile;u=' . $row_quoted['id_member'] . ' date=' . $row_quoted['msgtime'] . ']' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1833 | - } |
|
1834 | - else |
|
1835 | - $form_message = ''; |
|
1903 | + if (!empty($modSettings['removeNestedQuotes'])) { |
|
1904 | + $form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message); |
|
1905 | + } |
|
1906 | + if (empty($row_quoted['id_member'])) { |
|
1907 | + $form_message = '[quote author="' . $row_quoted['real_name'] . '"]' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1908 | + } else { |
|
1909 | + $form_message = '[quote author=' . $row_quoted['real_name'] . ' link=action=profile;u=' . $row_quoted['id_member'] . ' date=' . $row_quoted['msgtime'] . ']' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1910 | + } |
|
1911 | + } else { |
|
1912 | + $form_message = ''; |
|
1913 | + } |
|
1836 | 1914 | |
1837 | 1915 | // Do the BBC thang on the message. |
1838 | 1916 | $row_quoted['body'] = parse_bbc($row_quoted['body'], true, 'pm' . $row_quoted['id_pm']); |
@@ -1853,8 +1931,7 @@ discard block |
||
1853 | 1931 | 'timestamp' => forum_time(true, $row_quoted['msgtime']), |
1854 | 1932 | 'body' => $row_quoted['body'] |
1855 | 1933 | ); |
1856 | - } |
|
1857 | - else |
|
1934 | + } else |
|
1858 | 1935 | { |
1859 | 1936 | $context['quoted_message'] = false; |
1860 | 1937 | $form_subject = ''; |
@@ -1873,11 +1950,12 @@ discard block |
||
1873 | 1950 | if ($_REQUEST['u'] == 'all' && isset($row_quoted)) |
1874 | 1951 | { |
1875 | 1952 | // Firstly, to reply to all we clearly already have $row_quoted - so have the original member from. |
1876 | - if ($row_quoted['id_member'] != $user_info['id']) |
|
1877 | - $context['recipients']['to'][] = array( |
|
1953 | + if ($row_quoted['id_member'] != $user_info['id']) { |
|
1954 | + $context['recipients']['to'][] = array( |
|
1878 | 1955 | 'id' => $row_quoted['id_member'], |
1879 | 1956 | 'name' => $smcFunc['htmlspecialchars']($row_quoted['real_name']), |
1880 | - ); |
|
1957 | + ); |
|
1958 | + } |
|
1881 | 1959 | |
1882 | 1960 | // Now to get the others. |
1883 | 1961 | $request = $smcFunc['db_query']('', ' |
@@ -1893,18 +1971,19 @@ discard block |
||
1893 | 1971 | 'not_bcc' => 0, |
1894 | 1972 | ) |
1895 | 1973 | ); |
1896 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1897 | - $context['recipients']['to'][] = array( |
|
1974 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1975 | + $context['recipients']['to'][] = array( |
|
1898 | 1976 | 'id' => $row['id_member'], |
1899 | 1977 | 'name' => $row['real_name'], |
1900 | - ); |
|
1978 | + ); |
|
1979 | + } |
|
1901 | 1980 | $smcFunc['db_free_result']($request); |
1902 | - } |
|
1903 | - else |
|
1981 | + } else |
|
1904 | 1982 | { |
1905 | 1983 | $_REQUEST['u'] = explode(',', $_REQUEST['u']); |
1906 | - foreach ($_REQUEST['u'] as $key => $uID) |
|
1907 | - $_REQUEST['u'][$key] = (int) $uID; |
|
1984 | + foreach ($_REQUEST['u'] as $key => $uID) { |
|
1985 | + $_REQUEST['u'][$key] = (int) $uID; |
|
1986 | + } |
|
1908 | 1987 | |
1909 | 1988 | $_REQUEST['u'] = array_unique($_REQUEST['u']); |
1910 | 1989 | |
@@ -1918,22 +1997,24 @@ discard block |
||
1918 | 1997 | 'limit' => count($_REQUEST['u']), |
1919 | 1998 | ) |
1920 | 1999 | ); |
1921 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1922 | - $context['recipients']['to'][] = array( |
|
2000 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2001 | + $context['recipients']['to'][] = array( |
|
1923 | 2002 | 'id' => $row['id_member'], |
1924 | 2003 | 'name' => $row['real_name'], |
1925 | - ); |
|
2004 | + ); |
|
2005 | + } |
|
1926 | 2006 | $smcFunc['db_free_result']($request); |
1927 | 2007 | } |
1928 | 2008 | |
1929 | 2009 | // Get a literal name list in case the user has JavaScript disabled. |
1930 | 2010 | $names = array(); |
1931 | - foreach ($context['recipients']['to'] as $to) |
|
1932 | - $names[] = $to['name']; |
|
2011 | + foreach ($context['recipients']['to'] as $to) { |
|
2012 | + $names[] = $to['name']; |
|
2013 | + } |
|
1933 | 2014 | $context['to_value'] = empty($names) ? '' : '"' . implode('", "', $names) . '"'; |
1934 | - } |
|
1935 | - else |
|
1936 | - $context['to_value'] = ''; |
|
2015 | + } else { |
|
2016 | + $context['to_value'] = ''; |
|
2017 | + } |
|
1937 | 2018 | |
1938 | 2019 | // Set the defaults... |
1939 | 2020 | $context['subject'] = $form_subject; |
@@ -2003,8 +2084,9 @@ discard block |
||
2003 | 2084 | |
2004 | 2085 | // validate with loadMemberData() |
2005 | 2086 | $memberResult = loadMemberData($user_info['id'], false); |
2006 | - if (!$memberResult) |
|
2007 | - fatal_lang_error('not_a_user', false); |
|
2087 | + if (!$memberResult) { |
|
2088 | + fatal_lang_error('not_a_user', false); |
|
2089 | + } |
|
2008 | 2090 | list ($memID) = $memberResult; |
2009 | 2091 | |
2010 | 2092 | // drafts is where the functions reside |
@@ -2030,9 +2112,9 @@ discard block |
||
2030 | 2112 | $context['sub_template'] = 'send'; |
2031 | 2113 | loadJavaScriptFile('PersonalMessage.js', array('defer' => false, 'minimize' => true), 'smf_pms'); |
2032 | 2114 | loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest'); |
2033 | - } |
|
2034 | - else |
|
2035 | - $context['sub_template'] = 'pm'; |
|
2115 | + } else { |
|
2116 | + $context['sub_template'] = 'pm'; |
|
2117 | + } |
|
2036 | 2118 | |
2037 | 2119 | $context['page_title'] = $txt['send_message']; |
2038 | 2120 | |
@@ -2093,10 +2175,11 @@ discard block |
||
2093 | 2175 | ); |
2094 | 2176 | if ($smcFunc['db_num_rows']($request) == 0) |
2095 | 2177 | { |
2096 | - if (!isset($_REQUEST['xml'])) |
|
2097 | - fatal_lang_error('pm_not_yours', false); |
|
2098 | - else |
|
2099 | - $error_types[] = 'pm_not_yours'; |
|
2178 | + if (!isset($_REQUEST['xml'])) { |
|
2179 | + fatal_lang_error('pm_not_yours', false); |
|
2180 | + } else { |
|
2181 | + $error_types[] = 'pm_not_yours'; |
|
2182 | + } |
|
2100 | 2183 | } |
2101 | 2184 | $row_quoted = $smcFunc['db_fetch_assoc']($request); |
2102 | 2185 | $smcFunc['db_free_result']($request); |
@@ -2143,14 +2226,16 @@ discard block |
||
2143 | 2226 | $context['post_error'][$error_type] = true; |
2144 | 2227 | if (isset($txt['error_' . $error_type])) |
2145 | 2228 | { |
2146 | - if ($error_type == 'long_message') |
|
2147 | - $txt['error_' . $error_type] = sprintf($txt['error_' . $error_type], $modSettings['max_messageLength']); |
|
2229 | + if ($error_type == 'long_message') { |
|
2230 | + $txt['error_' . $error_type] = sprintf($txt['error_' . $error_type], $modSettings['max_messageLength']); |
|
2231 | + } |
|
2148 | 2232 | $context['post_error']['messages'][] = $txt['error_' . $error_type]; |
2149 | 2233 | } |
2150 | 2234 | |
2151 | 2235 | // If it's not a minor error flag it as such. |
2152 | - if (!in_array($error_type, array('new_reply', 'not_approved', 'new_replies', 'old_topic', 'need_qr_verification', 'no_subject'))) |
|
2153 | - $context['error_type'] = 'serious'; |
|
2236 | + if (!in_array($error_type, array('new_reply', 'not_approved', 'new_replies', 'old_topic', 'need_qr_verification', 'no_subject'))) { |
|
2237 | + $context['error_type'] = 'serious'; |
|
2238 | + } |
|
2154 | 2239 | } |
2155 | 2240 | |
2156 | 2241 | // We need to load the editor once more. |
@@ -2208,8 +2293,9 @@ discard block |
||
2208 | 2293 | require_once($sourcedir . '/Subs-Auth.php'); |
2209 | 2294 | |
2210 | 2295 | // PM Drafts enabled and needed? |
2211 | - if ($context['drafts_pm_save'] && (isset($_POST['save_draft']) || isset($_POST['id_pm_draft']))) |
|
2212 | - require_once($sourcedir . '/Drafts.php'); |
|
2296 | + if ($context['drafts_pm_save'] && (isset($_POST['save_draft']) || isset($_POST['id_pm_draft']))) { |
|
2297 | + require_once($sourcedir . '/Drafts.php'); |
|
2298 | + } |
|
2213 | 2299 | |
2214 | 2300 | loadLanguage('PersonalMessage', '', false); |
2215 | 2301 | |
@@ -2239,24 +2325,27 @@ discard block |
||
2239 | 2325 | |
2240 | 2326 | if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) |
2241 | 2327 | { |
2242 | - if (!isset($_REQUEST['xml'])) |
|
2243 | - fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
2244 | - else |
|
2245 | - $post_errors[] = 'pm_too_many_per_hour'; |
|
2328 | + if (!isset($_REQUEST['xml'])) { |
|
2329 | + fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
2330 | + } else { |
|
2331 | + $post_errors[] = 'pm_too_many_per_hour'; |
|
2332 | + } |
|
2246 | 2333 | } |
2247 | 2334 | } |
2248 | 2335 | |
2249 | 2336 | // If your session timed out, show an error, but do allow to re-submit. |
2250 | - if (!isset($_REQUEST['xml']) && checkSession('post', '', false) != '') |
|
2251 | - $post_errors[] = 'session_timeout'; |
|
2337 | + if (!isset($_REQUEST['xml']) && checkSession('post', '', false) != '') { |
|
2338 | + $post_errors[] = 'session_timeout'; |
|
2339 | + } |
|
2252 | 2340 | |
2253 | 2341 | $_REQUEST['subject'] = isset($_REQUEST['subject']) ? trim($_REQUEST['subject']) : ''; |
2254 | 2342 | $_REQUEST['to'] = empty($_POST['to']) ? (empty($_GET['to']) ? '' : $_GET['to']) : $_POST['to']; |
2255 | 2343 | $_REQUEST['bcc'] = empty($_POST['bcc']) ? (empty($_GET['bcc']) ? '' : $_GET['bcc']) : $_POST['bcc']; |
2256 | 2344 | |
2257 | 2345 | // Route the input from the 'u' parameter to the 'to'-list. |
2258 | - if (!empty($_POST['u'])) |
|
2259 | - $_POST['recipient_to'] = explode(',', $_POST['u']); |
|
2346 | + if (!empty($_POST['u'])) { |
|
2347 | + $_POST['recipient_to'] = explode(',', $_POST['u']); |
|
2348 | + } |
|
2260 | 2349 | |
2261 | 2350 | // Construct the list of recipients. |
2262 | 2351 | $recipientList = array(); |
@@ -2268,8 +2357,9 @@ discard block |
||
2268 | 2357 | $recipientList[$recipientType] = array(); |
2269 | 2358 | if (!empty($_POST['recipient_' . $recipientType]) && is_array($_POST['recipient_' . $recipientType])) |
2270 | 2359 | { |
2271 | - foreach ($_POST['recipient_' . $recipientType] as $recipient) |
|
2272 | - $recipientList[$recipientType][] = (int) $recipient; |
|
2360 | + foreach ($_POST['recipient_' . $recipientType] as $recipient) { |
|
2361 | + $recipientList[$recipientType][] = (int) $recipient; |
|
2362 | + } |
|
2273 | 2363 | } |
2274 | 2364 | |
2275 | 2365 | // Are there also literal names set? |
@@ -2283,10 +2373,11 @@ discard block |
||
2283 | 2373 | |
2284 | 2374 | foreach ($namedRecipientList[$recipientType] as $index => $recipient) |
2285 | 2375 | { |
2286 | - if (strlen(trim($recipient)) > 0) |
|
2287 | - $namedRecipientList[$recipientType][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($recipient))); |
|
2288 | - else |
|
2289 | - unset($namedRecipientList[$recipientType][$index]); |
|
2376 | + if (strlen(trim($recipient)) > 0) { |
|
2377 | + $namedRecipientList[$recipientType][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($recipient))); |
|
2378 | + } else { |
|
2379 | + unset($namedRecipientList[$recipientType][$index]); |
|
2380 | + } |
|
2290 | 2381 | } |
2291 | 2382 | |
2292 | 2383 | if (!empty($namedRecipientList[$recipientType])) |
@@ -2316,8 +2407,9 @@ discard block |
||
2316 | 2407 | } |
2317 | 2408 | |
2318 | 2409 | // Selected a recipient to be deleted? Remove them now. |
2319 | - if (!empty($_POST['delete_recipient'])) |
|
2320 | - $recipientList[$recipientType] = array_diff($recipientList[$recipientType], array((int) $_POST['delete_recipient'])); |
|
2410 | + if (!empty($_POST['delete_recipient'])) { |
|
2411 | + $recipientList[$recipientType] = array_diff($recipientList[$recipientType], array((int) $_POST['delete_recipient'])); |
|
2412 | + } |
|
2321 | 2413 | |
2322 | 2414 | // Make sure we don't include the same name twice |
2323 | 2415 | $recipientList[$recipientType] = array_unique($recipientList[$recipientType]); |
@@ -2327,8 +2419,9 @@ discard block |
||
2327 | 2419 | $is_recipient_change = !empty($_POST['delete_recipient']) || !empty($_POST['to_submit']) || !empty($_POST['bcc_submit']); |
2328 | 2420 | |
2329 | 2421 | // Check if there's at least one recipient. |
2330 | - if (empty($recipientList['to']) && empty($recipientList['bcc'])) |
|
2331 | - $post_errors[] = 'no_to'; |
|
2422 | + if (empty($recipientList['to']) && empty($recipientList['bcc'])) { |
|
2423 | + $post_errors[] = 'no_to'; |
|
2424 | + } |
|
2332 | 2425 | |
2333 | 2426 | // Make sure that we remove the members who did get it from the screen. |
2334 | 2427 | if (!$is_recipient_change) |
@@ -2342,28 +2435,31 @@ discard block |
||
2342 | 2435 | // Since we already have a post error, remove the previous one. |
2343 | 2436 | $post_errors = array_diff($post_errors, array('no_to')); |
2344 | 2437 | |
2345 | - foreach ($namesNotFound[$recipientType] as $name) |
|
2346 | - $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2438 | + foreach ($namesNotFound[$recipientType] as $name) { |
|
2439 | + $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2440 | + } |
|
2347 | 2441 | } |
2348 | 2442 | } |
2349 | 2443 | } |
2350 | 2444 | |
2351 | 2445 | // Did they make any mistakes? |
2352 | - if ($_REQUEST['subject'] == '') |
|
2353 | - $post_errors[] = 'no_subject'; |
|
2354 | - if (!isset($_REQUEST['message']) || $_REQUEST['message'] == '') |
|
2355 | - $post_errors[] = 'no_message'; |
|
2356 | - elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_REQUEST['message']) > $modSettings['max_messageLength']) |
|
2357 | - $post_errors[] = 'long_message'; |
|
2358 | - else |
|
2446 | + if ($_REQUEST['subject'] == '') { |
|
2447 | + $post_errors[] = 'no_subject'; |
|
2448 | + } |
|
2449 | + if (!isset($_REQUEST['message']) || $_REQUEST['message'] == '') { |
|
2450 | + $post_errors[] = 'no_message'; |
|
2451 | + } elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_REQUEST['message']) > $modSettings['max_messageLength']) { |
|
2452 | + $post_errors[] = 'long_message'; |
|
2453 | + } else |
|
2359 | 2454 | { |
2360 | 2455 | // Preparse the message. |
2361 | 2456 | $message = $_REQUEST['message']; |
2362 | 2457 | preparsecode($message); |
2363 | 2458 | |
2364 | 2459 | // Make sure there's still some content left without the tags. |
2365 | - if ($smcFunc['htmltrim'](strip_tags(parse_bbc($smcFunc['htmlspecialchars']($message, ENT_QUOTES), false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($message, '[html]') === false)) |
|
2366 | - $post_errors[] = 'no_message'; |
|
2460 | + if ($smcFunc['htmltrim'](strip_tags(parse_bbc($smcFunc['htmlspecialchars']($message, ENT_QUOTES), false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($message, '[html]') === false)) { |
|
2461 | + $post_errors[] = 'no_message'; |
|
2462 | + } |
|
2367 | 2463 | } |
2368 | 2464 | |
2369 | 2465 | // Wrong verification code? |
@@ -2375,13 +2471,15 @@ discard block |
||
2375 | 2471 | ); |
2376 | 2472 | $context['require_verification'] = create_control_verification($verificationOptions, true); |
2377 | 2473 | |
2378 | - if (is_array($context['require_verification'])) |
|
2379 | - $post_errors = array_merge($post_errors, $context['require_verification']); |
|
2474 | + if (is_array($context['require_verification'])) { |
|
2475 | + $post_errors = array_merge($post_errors, $context['require_verification']); |
|
2476 | + } |
|
2380 | 2477 | } |
2381 | 2478 | |
2382 | 2479 | // If they did, give a chance to make ammends. |
2383 | - if (!empty($post_errors) && !$is_recipient_change && !isset($_REQUEST['preview']) && !isset($_REQUEST['xml'])) |
|
2384 | - return messagePostError($post_errors, $namedRecipientList, $recipientList); |
|
2480 | + if (!empty($post_errors) && !$is_recipient_change && !isset($_REQUEST['preview']) && !isset($_REQUEST['xml'])) { |
|
2481 | + return messagePostError($post_errors, $namedRecipientList, $recipientList); |
|
2482 | + } |
|
2385 | 2483 | |
2386 | 2484 | // Want to take a second glance before you send? |
2387 | 2485 | if (isset($_REQUEST['preview'])) |
@@ -2412,8 +2510,9 @@ discard block |
||
2412 | 2510 | foreach ($namesNotFound as $recipientType => $names) |
2413 | 2511 | { |
2414 | 2512 | $post_errors[] = 'bad_' . $recipientType; |
2415 | - foreach ($names as $name) |
|
2416 | - $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2513 | + foreach ($names as $name) { |
|
2514 | + $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2515 | + } |
|
2417 | 2516 | } |
2418 | 2517 | |
2419 | 2518 | return messagePostError(array(), $namedRecipientList, $recipientList); |
@@ -2443,13 +2542,14 @@ discard block |
||
2443 | 2542 | checkSubmitOnce('check'); |
2444 | 2543 | |
2445 | 2544 | // Do the actual sending of the PM. |
2446 | - if (!empty($recipientList['to']) || !empty($recipientList['bcc'])) |
|
2447 | - $context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], true, null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0); |
|
2448 | - else |
|
2449 | - $context['send_log'] = array( |
|
2545 | + if (!empty($recipientList['to']) || !empty($recipientList['bcc'])) { |
|
2546 | + $context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], true, null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0); |
|
2547 | + } else { |
|
2548 | + $context['send_log'] = array( |
|
2450 | 2549 | 'sent' => array(), |
2451 | 2550 | 'failed' => array() |
2452 | - ); |
|
2551 | + ); |
|
2552 | + } |
|
2453 | 2553 | |
2454 | 2554 | // Mark the message as "replied to". |
2455 | 2555 | if (!empty($context['send_log']['sent']) && !empty($_REQUEST['replied_to']) && isset($_REQUEST['f']) && $_REQUEST['f'] == 'inbox') |
@@ -2467,11 +2567,12 @@ discard block |
||
2467 | 2567 | } |
2468 | 2568 | |
2469 | 2569 | // If one or more of the recipient were invalid, go back to the post screen with the failed usernames. |
2470 | - if (!empty($context['send_log']['failed'])) |
|
2471 | - return messagePostError($post_errors, $namesNotFound, array( |
|
2570 | + if (!empty($context['send_log']['failed'])) { |
|
2571 | + return messagePostError($post_errors, $namesNotFound, array( |
|
2472 | 2572 | 'to' => array_intersect($recipientList['to'], $context['send_log']['failed']), |
2473 | 2573 | 'bcc' => array_intersect($recipientList['bcc'], $context['send_log']['failed']) |
2474 | - )); |
|
2574 | + )); |
|
2575 | + } |
|
2475 | 2576 | |
2476 | 2577 | // Message sent successfully? |
2477 | 2578 | if (!empty($context['send_log']) && empty($context['send_log']['failed'])) |
@@ -2479,8 +2580,9 @@ discard block |
||
2479 | 2580 | $context['current_label_redirect'] = $context['current_label_redirect'] . ';done=sent'; |
2480 | 2581 | |
2481 | 2582 | // If we had a PM draft for this one, then its time to remove it since it was just sent |
2482 | - if ($context['drafts_pm_save'] && !empty($_POST['id_pm_draft'])) |
|
2483 | - DeleteDraft($_POST['id_pm_draft']); |
|
2583 | + if ($context['drafts_pm_save'] && !empty($_POST['id_pm_draft'])) { |
|
2584 | + DeleteDraft($_POST['id_pm_draft']); |
|
2585 | + } |
|
2484 | 2586 | } |
2485 | 2587 | |
2486 | 2588 | // Go back to the where they sent from, if possible... |
@@ -2495,24 +2597,28 @@ discard block |
||
2495 | 2597 | |
2496 | 2598 | checkSession('request'); |
2497 | 2599 | |
2498 | - if (isset($_REQUEST['del_selected'])) |
|
2499 | - $_REQUEST['pm_action'] = 'delete'; |
|
2600 | + if (isset($_REQUEST['del_selected'])) { |
|
2601 | + $_REQUEST['pm_action'] = 'delete'; |
|
2602 | + } |
|
2500 | 2603 | |
2501 | 2604 | if (isset($_REQUEST['pm_action']) && $_REQUEST['pm_action'] != '' && !empty($_REQUEST['pms']) && is_array($_REQUEST['pms'])) |
2502 | 2605 | { |
2503 | - foreach ($_REQUEST['pms'] as $pm) |
|
2504 | - $_REQUEST['pm_actions'][(int) $pm] = $_REQUEST['pm_action']; |
|
2606 | + foreach ($_REQUEST['pms'] as $pm) { |
|
2607 | + $_REQUEST['pm_actions'][(int) $pm] = $_REQUEST['pm_action']; |
|
2608 | + } |
|
2505 | 2609 | } |
2506 | 2610 | |
2507 | - if (empty($_REQUEST['pm_actions'])) |
|
2508 | - redirectexit($context['current_label_redirect']); |
|
2611 | + if (empty($_REQUEST['pm_actions'])) { |
|
2612 | + redirectexit($context['current_label_redirect']); |
|
2613 | + } |
|
2509 | 2614 | |
2510 | 2615 | // If we are in conversation, we may need to apply this to every message in the conversation. |
2511 | 2616 | if ($context['display_mode'] == 2 && isset($_REQUEST['conversation'])) |
2512 | 2617 | { |
2513 | 2618 | $id_pms = array(); |
2514 | - foreach ($_REQUEST['pm_actions'] as $pm => $dummy) |
|
2515 | - $id_pms[] = (int) $pm; |
|
2619 | + foreach ($_REQUEST['pm_actions'] as $pm => $dummy) { |
|
2620 | + $id_pms[] = (int) $pm; |
|
2621 | + } |
|
2516 | 2622 | |
2517 | 2623 | $request = $smcFunc['db_query']('', ' |
2518 | 2624 | SELECT id_pm_head, id_pm |
@@ -2523,8 +2629,9 @@ discard block |
||
2523 | 2629 | ) |
2524 | 2630 | ); |
2525 | 2631 | $pm_heads = array(); |
2526 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2527 | - $pm_heads[$row['id_pm_head']] = $row['id_pm']; |
|
2632 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2633 | + $pm_heads[$row['id_pm_head']] = $row['id_pm']; |
|
2634 | + } |
|
2528 | 2635 | $smcFunc['db_free_result']($request); |
2529 | 2636 | |
2530 | 2637 | $request = $smcFunc['db_query']('', ' |
@@ -2538,8 +2645,9 @@ discard block |
||
2538 | 2645 | // Copy the action from the single to PM to the others. |
2539 | 2646 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2540 | 2647 | { |
2541 | - if (isset($pm_heads[$row['id_pm_head']]) && isset($_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]])) |
|
2542 | - $_REQUEST['pm_actions'][$row['id_pm']] = $_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]]; |
|
2648 | + if (isset($pm_heads[$row['id_pm_head']]) && isset($_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]])) { |
|
2649 | + $_REQUEST['pm_actions'][$row['id_pm']] = $_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]]; |
|
2650 | + } |
|
2543 | 2651 | } |
2544 | 2652 | $smcFunc['db_free_result']($request); |
2545 | 2653 | } |
@@ -2550,22 +2658,21 @@ discard block |
||
2550 | 2658 | $labels = array(); |
2551 | 2659 | foreach ($_REQUEST['pm_actions'] as $pm => $action) |
2552 | 2660 | { |
2553 | - if ($action === 'delete') |
|
2554 | - $to_delete[] = (int) $pm; |
|
2555 | - else |
|
2661 | + if ($action === 'delete') { |
|
2662 | + $to_delete[] = (int) $pm; |
|
2663 | + } else |
|
2556 | 2664 | { |
2557 | 2665 | if (substr($action, 0, 4) == 'add_') |
2558 | 2666 | { |
2559 | 2667 | $type = 'add'; |
2560 | 2668 | $action = substr($action, 4); |
2561 | - } |
|
2562 | - elseif (substr($action, 0, 4) == 'rem_') |
|
2669 | + } elseif (substr($action, 0, 4) == 'rem_') |
|
2563 | 2670 | { |
2564 | 2671 | $type = 'rem'; |
2565 | 2672 | $action = substr($action, 4); |
2566 | - } |
|
2567 | - else |
|
2568 | - $type = 'unk'; |
|
2673 | + } else { |
|
2674 | + $type = 'unk'; |
|
2675 | + } |
|
2569 | 2676 | |
2570 | 2677 | if ($action == '-1' || (int) $action > 0) |
2571 | 2678 | { |
@@ -2576,8 +2683,9 @@ discard block |
||
2576 | 2683 | } |
2577 | 2684 | |
2578 | 2685 | // Deleting, it looks like? |
2579 | - if (!empty($to_delete)) |
|
2580 | - deleteMessages($to_delete, $context['display_mode'] == 2 ? null : $context['folder']); |
|
2686 | + if (!empty($to_delete)) { |
|
2687 | + deleteMessages($to_delete, $context['display_mode'] == 2 ? null : $context['folder']); |
|
2688 | + } |
|
2581 | 2689 | |
2582 | 2690 | // Are we labeling anything? |
2583 | 2691 | if (!empty($to_label) && $context['folder'] == 'inbox') |
@@ -2643,8 +2751,7 @@ discard block |
||
2643 | 2751 | } |
2644 | 2752 | |
2645 | 2753 | $smcFunc['db_free_result']($request2); |
2646 | - } |
|
2647 | - elseif ($type == 'rem') |
|
2754 | + } elseif ($type == 'rem') |
|
2648 | 2755 | { |
2649 | 2756 | // If we're removing from the inbox, see if we have at least one other label. |
2650 | 2757 | // This query is faster than the one above |
@@ -2676,21 +2783,25 @@ discard block |
||
2676 | 2783 | if ($to_label[$row['id_pm']] != '-1') |
2677 | 2784 | { |
2678 | 2785 | // If this label is in the list and we're not adding it, remove it |
2679 | - if (array_key_exists($to_label[$row['id_pm']], $labels) && $type !== 'add') |
|
2680 | - unset($labels[$to_label[$row['id_pm']]]); |
|
2681 | - else if ($type !== 'rem') |
|
2682 | - $labels[$to_label[$row['id_pm']]] = $to_label[$row['id_pm']]; |
|
2786 | + if (array_key_exists($to_label[$row['id_pm']], $labels) && $type !== 'add') { |
|
2787 | + unset($labels[$to_label[$row['id_pm']]]); |
|
2788 | + } else if ($type !== 'rem') { |
|
2789 | + $labels[$to_label[$row['id_pm']]] = $to_label[$row['id_pm']]; |
|
2790 | + } |
|
2683 | 2791 | } |
2684 | 2792 | |
2685 | 2793 | // Removing all labels or just removing the inbox label |
2686 | - if ($type == 'rem' && empty($labels)) |
|
2687 | - $in_inbox = (empty($context['can_remove_inbox']) ? 1 : 0); |
|
2794 | + if ($type == 'rem' && empty($labels)) { |
|
2795 | + $in_inbox = (empty($context['can_remove_inbox']) ? 1 : 0); |
|
2796 | + } |
|
2688 | 2797 | // Adding new labels, but removing inbox and applying new ones |
2689 | - elseif ($type == 'add' && !empty($options['pm_remove_inbox_label']) && !empty($labels)) |
|
2690 | - $in_inbox = 0; |
|
2798 | + elseif ($type == 'add' && !empty($options['pm_remove_inbox_label']) && !empty($labels)) { |
|
2799 | + $in_inbox = 0; |
|
2800 | + } |
|
2691 | 2801 | // Just adding it to the inbox |
2692 | - else |
|
2693 | - $in_inbox = 1; |
|
2802 | + else { |
|
2803 | + $in_inbox = 1; |
|
2804 | + } |
|
2694 | 2805 | |
2695 | 2806 | // Are we adding it to or removing it from the inbox? |
2696 | 2807 | if ($in_inbox != $row['in_inbox']) |
@@ -2732,8 +2843,9 @@ discard block |
||
2732 | 2843 | if (!empty($labels_to_apply)) |
2733 | 2844 | { |
2734 | 2845 | $inserts = array(); |
2735 | - foreach ($labels_to_apply as $label) |
|
2736 | - $inserts[] = array($row['id_pm'], $label); |
|
2846 | + foreach ($labels_to_apply as $label) { |
|
2847 | + $inserts[] = array($row['id_pm'], $label); |
|
2848 | + } |
|
2737 | 2849 | |
2738 | 2850 | $smcFunc['db_insert']('', |
2739 | 2851 | '{db_prefix}pm_labeled_messages', |
@@ -2777,11 +2889,13 @@ discard block |
||
2777 | 2889 | checkSession('get'); |
2778 | 2890 | |
2779 | 2891 | // If all then delete all messages the user has. |
2780 | - if ($_REQUEST['f'] == 'all') |
|
2781 | - deleteMessages(null, null); |
|
2892 | + if ($_REQUEST['f'] == 'all') { |
|
2893 | + deleteMessages(null, null); |
|
2894 | + } |
|
2782 | 2895 | // Otherwise just the selected folder. |
2783 | - else |
|
2784 | - deleteMessages(null, $_REQUEST['f'] != 'sent' ? 'inbox' : 'sent'); |
|
2896 | + else { |
|
2897 | + deleteMessages(null, $_REQUEST['f'] != 'sent' ? 'inbox' : 'sent'); |
|
2898 | + } |
|
2785 | 2899 | |
2786 | 2900 | // Done... all gone. |
2787 | 2901 | redirectexit($context['current_label_redirect']); |
@@ -2818,8 +2932,9 @@ discard block |
||
2818 | 2932 | 'msgtime' => $deleteTime, |
2819 | 2933 | ) |
2820 | 2934 | ); |
2821 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
2822 | - $toDelete[] = $row[0]; |
|
2935 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
2936 | + $toDelete[] = $row[0]; |
|
2937 | + } |
|
2823 | 2938 | $smcFunc['db_free_result']($request); |
2824 | 2939 | |
2825 | 2940 | // Select all messages in their inbox older than $deleteTime. |
@@ -2836,8 +2951,9 @@ discard block |
||
2836 | 2951 | 'msgtime' => $deleteTime, |
2837 | 2952 | ) |
2838 | 2953 | ); |
2839 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2840 | - $toDelete[] = $row['id_pm']; |
|
2954 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2955 | + $toDelete[] = $row['id_pm']; |
|
2956 | + } |
|
2841 | 2957 | $smcFunc['db_free_result']($request); |
2842 | 2958 | |
2843 | 2959 | // Delete the actual messages. |
@@ -2868,26 +2984,29 @@ discard block |
||
2868 | 2984 | { |
2869 | 2985 | global $user_info, $smcFunc; |
2870 | 2986 | |
2871 | - if ($owner === null) |
|
2872 | - $owner = array($user_info['id']); |
|
2873 | - elseif (empty($owner)) |
|
2874 | - return; |
|
2875 | - elseif (!is_array($owner)) |
|
2876 | - $owner = array($owner); |
|
2987 | + if ($owner === null) { |
|
2988 | + $owner = array($user_info['id']); |
|
2989 | + } elseif (empty($owner)) { |
|
2990 | + return; |
|
2991 | + } elseif (!is_array($owner)) { |
|
2992 | + $owner = array($owner); |
|
2993 | + } |
|
2877 | 2994 | |
2878 | 2995 | if ($personal_messages !== null) |
2879 | 2996 | { |
2880 | - if (empty($personal_messages) || !is_array($personal_messages)) |
|
2881 | - return; |
|
2997 | + if (empty($personal_messages) || !is_array($personal_messages)) { |
|
2998 | + return; |
|
2999 | + } |
|
2882 | 3000 | |
2883 | - foreach ($personal_messages as $index => $delete_id) |
|
2884 | - $personal_messages[$index] = (int) $delete_id; |
|
3001 | + foreach ($personal_messages as $index => $delete_id) { |
|
3002 | + $personal_messages[$index] = (int) $delete_id; |
|
3003 | + } |
|
2885 | 3004 | |
2886 | 3005 | $where = ' |
2887 | 3006 | AND id_pm IN ({array_int:pm_list})'; |
2888 | - } |
|
2889 | - else |
|
2890 | - $where = ''; |
|
3007 | + } else { |
|
3008 | + $where = ''; |
|
3009 | + } |
|
2891 | 3010 | |
2892 | 3011 | if ($folder == 'sent' || $folder === null) |
2893 | 3012 | { |
@@ -2922,17 +3041,19 @@ discard block |
||
2922 | 3041 | // ...And update the statistics accordingly - now including unread messages!. |
2923 | 3042 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2924 | 3043 | { |
2925 | - if ($row['is_read']) |
|
2926 | - updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'])); |
|
2927 | - else |
|
2928 | - updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'], 'unread_messages' => $where == '' ? 0 : 'unread_messages - ' . $row['num_deleted_messages'])); |
|
3044 | + if ($row['is_read']) { |
|
3045 | + updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'])); |
|
3046 | + } else { |
|
3047 | + updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'], 'unread_messages' => $where == '' ? 0 : 'unread_messages - ' . $row['num_deleted_messages'])); |
|
3048 | + } |
|
2929 | 3049 | |
2930 | 3050 | // If this is the current member we need to make their message count correct. |
2931 | 3051 | if ($user_info['id'] == $row['id_member']) |
2932 | 3052 | { |
2933 | 3053 | $user_info['messages'] -= $row['num_deleted_messages']; |
2934 | - if (!($row['is_read'])) |
|
2935 | - $user_info['unread_messages'] -= $row['num_deleted_messages']; |
|
3054 | + if (!($row['is_read'])) { |
|
3055 | + $user_info['unread_messages'] -= $row['num_deleted_messages']; |
|
3056 | + } |
|
2936 | 3057 | } |
2937 | 3058 | } |
2938 | 3059 | $smcFunc['db_free_result']($request); |
@@ -3000,8 +3121,9 @@ discard block |
||
3000 | 3121 | ) |
3001 | 3122 | ); |
3002 | 3123 | $remove_pms = array(); |
3003 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3004 | - $remove_pms[] = $row['sender']; |
|
3124 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3125 | + $remove_pms[] = $row['sender']; |
|
3126 | + } |
|
3005 | 3127 | $smcFunc['db_free_result']($request); |
3006 | 3128 | |
3007 | 3129 | if (!empty($remove_pms)) |
@@ -3046,8 +3168,9 @@ discard block |
||
3046 | 3168 | { |
3047 | 3169 | global $user_info, $context, $smcFunc; |
3048 | 3170 | |
3049 | - if ($owner === null) |
|
3050 | - $owner = $user_info['id']; |
|
3171 | + if ($owner === null) { |
|
3172 | + $owner = $user_info['id']; |
|
3173 | + } |
|
3051 | 3174 | |
3052 | 3175 | $in_inbox = ''; |
3053 | 3176 | |
@@ -3071,8 +3194,7 @@ discard block |
||
3071 | 3194 | } |
3072 | 3195 | |
3073 | 3196 | $smcFunc['db_free_result']($get_messages); |
3074 | - } |
|
3075 | - elseif ($label = '-1') |
|
3197 | + } elseif ($label = '-1') |
|
3076 | 3198 | { |
3077 | 3199 | // Marking all PMs in your inbox read |
3078 | 3200 | $in_inbox = ' |
@@ -3097,8 +3219,9 @@ discard block |
||
3097 | 3219 | { |
3098 | 3220 | if ($owner == $user_info['id']) |
3099 | 3221 | { |
3100 | - foreach ($context['labels'] as $label) |
|
3101 | - $context['labels'][(int) $label['id']]['unread_messages'] = 0; |
|
3222 | + foreach ($context['labels'] as $label) { |
|
3223 | + $context['labels'][(int) $label['id']]['unread_messages'] = 0; |
|
3224 | + } |
|
3102 | 3225 | } |
3103 | 3226 | |
3104 | 3227 | $result = $smcFunc['db_query']('', ' |
@@ -3118,8 +3241,9 @@ discard block |
||
3118 | 3241 | { |
3119 | 3242 | $total_unread += $row['num']; |
3120 | 3243 | |
3121 | - if ($owner != $user_info['id'] || empty($row['id_pm'])) |
|
3122 | - continue; |
|
3244 | + if ($owner != $user_info['id'] || empty($row['id_pm'])) { |
|
3245 | + continue; |
|
3246 | + } |
|
3123 | 3247 | |
3124 | 3248 | $this_labels = array(); |
3125 | 3249 | |
@@ -3143,11 +3267,13 @@ discard block |
||
3143 | 3267 | |
3144 | 3268 | $smcFunc['db_free_result']($result2); |
3145 | 3269 | |
3146 | - foreach ($this_labels as $this_label) |
|
3147 | - $context['labels'][$this_label]['unread_messages'] += $row['num']; |
|
3270 | + foreach ($this_labels as $this_label) { |
|
3271 | + $context['labels'][$this_label]['unread_messages'] += $row['num']; |
|
3272 | + } |
|
3148 | 3273 | |
3149 | - if ($row['in_inbox'] == 1) |
|
3150 | - $context['labels'][-1]['unread_messages'] += $row['num']; |
|
3274 | + if ($row['in_inbox'] == 1) { |
|
3275 | + $context['labels'][-1]['unread_messages'] += $row['num']; |
|
3276 | + } |
|
3151 | 3277 | } |
3152 | 3278 | $smcFunc['db_free_result']($result); |
3153 | 3279 | |
@@ -3156,8 +3282,9 @@ discard block |
||
3156 | 3282 | updateMemberData($owner, array('unread_messages' => $total_unread)); |
3157 | 3283 | |
3158 | 3284 | // If it was for the current member, reflect this in the $user_info array too. |
3159 | - if ($owner == $user_info['id']) |
|
3160 | - $user_info['unread_messages'] = $total_unread; |
|
3285 | + if ($owner == $user_info['id']) { |
|
3286 | + $user_info['unread_messages'] = $total_unread; |
|
3287 | + } |
|
3161 | 3288 | } |
3162 | 3289 | } |
3163 | 3290 | |
@@ -3185,8 +3312,9 @@ discard block |
||
3185 | 3312 | // Add all existing labels to the array to save, slashing them as necessary... |
3186 | 3313 | foreach ($context['labels'] as $label) |
3187 | 3314 | { |
3188 | - if ($label['id'] != -1) |
|
3189 | - $the_labels[$label['id']] = $label['name']; |
|
3315 | + if ($label['id'] != -1) { |
|
3316 | + $the_labels[$label['id']] = $label['name']; |
|
3317 | + } |
|
3190 | 3318 | } |
3191 | 3319 | |
3192 | 3320 | if (isset($_POST[$context['session_var']])) |
@@ -3205,8 +3333,9 @@ discard block |
||
3205 | 3333 | { |
3206 | 3334 | $_POST['label'] = strtr($smcFunc['htmlspecialchars'](trim($_POST['label'])), array(',' => ',')); |
3207 | 3335 | |
3208 | - if ($smcFunc['strlen']($_POST['label']) > 30) |
|
3209 | - $_POST['label'] = $smcFunc['substr']($_POST['label'], 0, 30); |
|
3336 | + if ($smcFunc['strlen']($_POST['label']) > 30) { |
|
3337 | + $_POST['label'] = $smcFunc['substr']($_POST['label'], 0, 30); |
|
3338 | + } |
|
3210 | 3339 | if ($_POST['label'] != '') |
3211 | 3340 | { |
3212 | 3341 | $the_labels[] = $_POST['label']; |
@@ -3227,23 +3356,24 @@ discard block |
||
3227 | 3356 | { |
3228 | 3357 | foreach ($the_labels as $id => $name) |
3229 | 3358 | { |
3230 | - if ($id == -1) |
|
3231 | - continue; |
|
3232 | - elseif (isset($_POST['label_name'][$id])) |
|
3359 | + if ($id == -1) { |
|
3360 | + continue; |
|
3361 | + } elseif (isset($_POST['label_name'][$id])) |
|
3233 | 3362 | { |
3234 | 3363 | $_POST['label_name'][$id] = trim(strtr($smcFunc['htmlspecialchars']($_POST['label_name'][$id]), array(',' => ','))); |
3235 | 3364 | |
3236 | - if ($smcFunc['strlen']($_POST['label_name'][$id]) > 30) |
|
3237 | - $_POST['label_name'][$id] = $smcFunc['substr']($_POST['label_name'][$id], 0, 30); |
|
3365 | + if ($smcFunc['strlen']($_POST['label_name'][$id]) > 30) { |
|
3366 | + $_POST['label_name'][$id] = $smcFunc['substr']($_POST['label_name'][$id], 0, 30); |
|
3367 | + } |
|
3238 | 3368 | if ($_POST['label_name'][$id] != '') |
3239 | 3369 | { |
3240 | 3370 | // Changing the name of this label? |
3241 | - if ($the_labels[$id] != $_POST['label_name'][$id]) |
|
3242 | - $label_updates[$id] = $_POST['label_name'][$id]; |
|
3371 | + if ($the_labels[$id] != $_POST['label_name'][$id]) { |
|
3372 | + $label_updates[$id] = $_POST['label_name'][$id]; |
|
3373 | + } |
|
3243 | 3374 | |
3244 | 3375 | $the_labels[(int) $id] = $_POST['label_name'][$id]; |
3245 | - } |
|
3246 | - else |
|
3376 | + } else |
|
3247 | 3377 | { |
3248 | 3378 | unset($the_labels[(int) $id]); |
3249 | 3379 | $labels_to_remove[] = $id; |
@@ -3257,8 +3387,9 @@ discard block |
||
3257 | 3387 | if (!empty($labels_to_add)) |
3258 | 3388 | { |
3259 | 3389 | $inserts = array(); |
3260 | - foreach ($labels_to_add AS $label) |
|
3261 | - $inserts[] = array($user_info['id'], $label); |
|
3390 | + foreach ($labels_to_add AS $label) { |
|
3391 | + $inserts[] = array($user_info['id'], $label); |
|
3392 | + } |
|
3262 | 3393 | |
3263 | 3394 | $smcFunc['db_insert']('', '{db_prefix}pm_labels', array('id_member' => 'int', 'name' => 'string-30'), $inserts, array()); |
3264 | 3395 | } |
@@ -3348,8 +3479,9 @@ discard block |
||
3348 | 3479 | // Each action... |
3349 | 3480 | foreach ($rule['actions'] as $k2 => $action) |
3350 | 3481 | { |
3351 | - if ($action['t'] != 'lab' || !in_array($action['v'], $labels_to_remove)) |
|
3352 | - continue; |
|
3482 | + if ($action['t'] != 'lab' || !in_array($action['v'], $labels_to_remove)) { |
|
3483 | + continue; |
|
3484 | + } |
|
3353 | 3485 | |
3354 | 3486 | $rule_changes[] = $rule['id']; |
3355 | 3487 | |
@@ -3364,8 +3496,8 @@ discard block |
||
3364 | 3496 | { |
3365 | 3497 | $rule_changes = array_unique($rule_changes); |
3366 | 3498 | // Update/delete as appropriate. |
3367 | - foreach ($rule_changes as $k => $id) |
|
3368 | - if (!empty($context['rules'][$id]['actions'])) |
|
3499 | + foreach ($rule_changes as $k => $id) { |
|
3500 | + if (!empty($context['rules'][$id]['actions'])) |
|
3369 | 3501 | { |
3370 | 3502 | $smcFunc['db_query']('', ' |
3371 | 3503 | UPDATE {db_prefix}pm_rules |
@@ -3377,13 +3509,14 @@ discard block |
||
3377 | 3509 | 'id_rule' => $id, |
3378 | 3510 | 'actions' => $smcFunc['json_encode']($context['rules'][$id]['actions']), |
3379 | 3511 | ) |
3380 | - ); |
|
3512 | + ); |
|
3513 | + } |
|
3381 | 3514 | unset($rule_changes[$k]); |
3382 | 3515 | } |
3383 | 3516 | |
3384 | 3517 | // Anything left here means it's lost all actions... |
3385 | - if (!empty($rule_changes)) |
|
3386 | - $smcFunc['db_query']('', ' |
|
3518 | + if (!empty($rule_changes)) { |
|
3519 | + $smcFunc['db_query']('', ' |
|
3387 | 3520 | DELETE FROM {db_prefix}pm_rules |
3388 | 3521 | WHERE id_rule IN ({array_int:rule_list}) |
3389 | 3522 | AND id_member = {int:current_member}', |
@@ -3391,7 +3524,8 @@ discard block |
||
3391 | 3524 | 'current_member' => $user_info['id'], |
3392 | 3525 | 'rule_list' => $rule_changes, |
3393 | 3526 | ) |
3394 | - ); |
|
3527 | + ); |
|
3528 | + } |
|
3395 | 3529 | } |
3396 | 3530 | |
3397 | 3531 | // Make sure we're not caching this! |
@@ -3461,8 +3595,9 @@ discard block |
||
3461 | 3595 | // Save the fields. |
3462 | 3596 | saveProfileFields(); |
3463 | 3597 | |
3464 | - if (!empty($profile_vars)) |
|
3465 | - updateMemberData($user_info['id'], $profile_vars); |
|
3598 | + if (!empty($profile_vars)) { |
|
3599 | + updateMemberData($user_info['id'], $profile_vars); |
|
3600 | + } |
|
3466 | 3601 | } |
3467 | 3602 | |
3468 | 3603 | setupProfileContext( |
@@ -3487,13 +3622,15 @@ discard block |
||
3487 | 3622 | global $user_info, $language, $modSettings, $smcFunc; |
3488 | 3623 | |
3489 | 3624 | // Check that this feature is even enabled! |
3490 | - if (empty($modSettings['enableReportPM']) || empty($_REQUEST['pmsg'])) |
|
3491 | - fatal_lang_error('no_access', false); |
|
3625 | + if (empty($modSettings['enableReportPM']) || empty($_REQUEST['pmsg'])) { |
|
3626 | + fatal_lang_error('no_access', false); |
|
3627 | + } |
|
3492 | 3628 | |
3493 | 3629 | $pmsg = (int) $_REQUEST['pmsg']; |
3494 | 3630 | |
3495 | - if (!isAccessiblePM($pmsg, 'inbox')) |
|
3496 | - fatal_lang_error('no_access', false); |
|
3631 | + if (!isAccessiblePM($pmsg, 'inbox')) { |
|
3632 | + fatal_lang_error('no_access', false); |
|
3633 | + } |
|
3497 | 3634 | |
3498 | 3635 | $context['pm_id'] = $pmsg; |
3499 | 3636 | $context['page_title'] = $txt['pm_report_title']; |
@@ -3515,8 +3652,9 @@ discard block |
||
3515 | 3652 | ) |
3516 | 3653 | ); |
3517 | 3654 | $context['admins'] = array(); |
3518 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3519 | - $context['admins'][$row['id_member']] = $row['real_name']; |
|
3655 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3656 | + $context['admins'][$row['id_member']] = $row['real_name']; |
|
3657 | + } |
|
3520 | 3658 | $smcFunc['db_free_result']($request); |
3521 | 3659 | |
3522 | 3660 | // How many admins in total? |
@@ -3545,8 +3683,9 @@ discard block |
||
3545 | 3683 | ) |
3546 | 3684 | ); |
3547 | 3685 | // Can only be a hacker here! |
3548 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
3549 | - fatal_lang_error('no_access', false); |
|
3686 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
3687 | + fatal_lang_error('no_access', false); |
|
3688 | + } |
|
3550 | 3689 | list ($subject, $body, $time, $memberFromID, $memberFromName) = $smcFunc['db_fetch_row']($request); |
3551 | 3690 | $smcFunc['db_free_result']($request); |
3552 | 3691 | |
@@ -3570,15 +3709,17 @@ discard block |
||
3570 | 3709 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
3571 | 3710 | { |
3572 | 3711 | // If it's hidden still don't reveal their names - privacy after all ;) |
3573 | - if ($row['bcc']) |
|
3574 | - $hidden_recipients++; |
|
3575 | - else |
|
3576 | - $recipients[] = '[url=' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . ']' . $row['to_name'] . '[/url]'; |
|
3712 | + if ($row['bcc']) { |
|
3713 | + $hidden_recipients++; |
|
3714 | + } else { |
|
3715 | + $recipients[] = '[url=' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . ']' . $row['to_name'] . '[/url]'; |
|
3716 | + } |
|
3577 | 3717 | } |
3578 | 3718 | $smcFunc['db_free_result']($request); |
3579 | 3719 | |
3580 | - if ($hidden_recipients) |
|
3581 | - $recipients[] = sprintf($txt['pm_report_pm_hidden'], $hidden_recipients); |
|
3720 | + if ($hidden_recipients) { |
|
3721 | + $recipients[] = sprintf($txt['pm_report_pm_hidden'], $hidden_recipients); |
|
3722 | + } |
|
3582 | 3723 | |
3583 | 3724 | // Now let's get out and loop through the admins. |
3584 | 3725 | $request = $smcFunc['db_query']('', ' |
@@ -3594,8 +3735,9 @@ discard block |
||
3594 | 3735 | ); |
3595 | 3736 | |
3596 | 3737 | // Maybe we shouldn't advertise this? |
3597 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
3598 | - fatal_lang_error('no_access', false); |
|
3738 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
3739 | + fatal_lang_error('no_access', false); |
|
3740 | + } |
|
3599 | 3741 | |
3600 | 3742 | $memberFromName = un_htmlspecialchars($memberFromName); |
3601 | 3743 | |
@@ -3614,8 +3756,9 @@ discard block |
||
3614 | 3756 | // Make the body. |
3615 | 3757 | $report_body = str_replace(array('{REPORTER}', '{SENDER}'), array(un_htmlspecialchars($user_info['name']), $memberFromName), $txt['pm_report_pm_user_sent']); |
3616 | 3758 | $report_body .= "\n" . '[b]' . $_POST['reason'] . '[/b]' . "\n\n"; |
3617 | - if (!empty($recipients)) |
|
3618 | - $report_body .= $txt['pm_report_pm_other_recipients'] . ' ' . implode(', ', $recipients) . "\n\n"; |
|
3759 | + if (!empty($recipients)) { |
|
3760 | + $report_body .= $txt['pm_report_pm_other_recipients'] . ' ' . implode(', ', $recipients) . "\n\n"; |
|
3761 | + } |
|
3619 | 3762 | $report_body .= $txt['pm_report_pm_unedited_below'] . "\n" . '[quote author=' . (empty($memberFromID) ? '"' . $memberFromName . '"' : $memberFromName . ' link=action=profile;u=' . $memberFromID . ' date=' . $time) . ']' . "\n" . un_htmlspecialchars($body) . '[/quote]'; |
3620 | 3763 | |
3621 | 3764 | // Plonk it in the array ;) |
@@ -3635,12 +3778,14 @@ discard block |
||
3635 | 3778 | $smcFunc['db_free_result']($request); |
3636 | 3779 | |
3637 | 3780 | // Send a different email for each language. |
3638 | - foreach ($messagesToSend as $lang => $message) |
|
3639 | - sendpm($message['recipients'], $message['subject'], $message['body']); |
|
3781 | + foreach ($messagesToSend as $lang => $message) { |
|
3782 | + sendpm($message['recipients'], $message['subject'], $message['body']); |
|
3783 | + } |
|
3640 | 3784 | |
3641 | 3785 | // Give the user their own language back! |
3642 | - if (!empty($modSettings['userLanguage'])) |
|
3643 | - loadLanguage('PersonalMessage', '', false); |
|
3786 | + if (!empty($modSettings['userLanguage'])) { |
|
3787 | + loadLanguage('PersonalMessage', '', false); |
|
3788 | + } |
|
3644 | 3789 | |
3645 | 3790 | // Leave them with a template. |
3646 | 3791 | $context['sub_template'] = 'report_message_complete'; |
@@ -3686,8 +3831,9 @@ discard block |
||
3686 | 3831 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
3687 | 3832 | { |
3688 | 3833 | // Hide hidden groups! |
3689 | - if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups')) |
|
3690 | - continue; |
|
3834 | + if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups')) { |
|
3835 | + continue; |
|
3836 | + } |
|
3691 | 3837 | |
3692 | 3838 | $context['groups'][$row['id_group']] = $row['group_name']; |
3693 | 3839 | } |
@@ -3713,9 +3859,10 @@ discard block |
||
3713 | 3859 | $context['rule'] = $context['rules'][$context['rid']]; |
3714 | 3860 | $members = array(); |
3715 | 3861 | // Need to get member names! |
3716 | - foreach ($context['rule']['criteria'] as $k => $criteria) |
|
3717 | - if ($criteria['t'] == 'mid' && !empty($criteria['v'])) |
|
3718 | - $members[(int) $criteria['v']] = $k; |
|
3862 | + foreach ($context['rule']['criteria'] as $k => $criteria) { |
|
3863 | + if ($criteria['t'] == 'mid' && !empty($criteria['v'])) |
|
3864 | + $members[(int) $criteria['v']] = $k; |
|
3865 | + } |
|
3719 | 3866 | |
3720 | 3867 | if (!empty($members)) |
3721 | 3868 | { |
@@ -3727,19 +3874,20 @@ discard block |
||
3727 | 3874 | 'member_list' => array_keys($members), |
3728 | 3875 | ) |
3729 | 3876 | ); |
3730 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3731 | - $context['rule']['criteria'][$members[$row['id_member']]]['v'] = $row['member_name']; |
|
3877 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3878 | + $context['rule']['criteria'][$members[$row['id_member']]]['v'] = $row['member_name']; |
|
3879 | + } |
|
3732 | 3880 | $smcFunc['db_free_result']($request); |
3733 | 3881 | } |
3734 | - } |
|
3735 | - else |
|
3736 | - $context['rule'] = array( |
|
3882 | + } else { |
|
3883 | + $context['rule'] = array( |
|
3737 | 3884 | 'id' => '', |
3738 | 3885 | 'name' => '', |
3739 | 3886 | 'criteria' => array(), |
3740 | 3887 | 'actions' => array(), |
3741 | 3888 | 'logic' => 'and', |
3742 | - ); |
|
3889 | + ); |
|
3890 | + } |
|
3743 | 3891 | } |
3744 | 3892 | // Saving? |
3745 | 3893 | elseif (isset($_GET['save'])) |
@@ -3749,22 +3897,25 @@ discard block |
||
3749 | 3897 | |
3750 | 3898 | // Name is easy! |
3751 | 3899 | $ruleName = $smcFunc['htmlspecialchars'](trim($_POST['rule_name'])); |
3752 | - if (empty($ruleName)) |
|
3753 | - fatal_lang_error('pm_rule_no_name', false); |
|
3900 | + if (empty($ruleName)) { |
|
3901 | + fatal_lang_error('pm_rule_no_name', false); |
|
3902 | + } |
|
3754 | 3903 | |
3755 | 3904 | // Sanity check... |
3756 | - if (empty($_POST['ruletype']) || empty($_POST['acttype'])) |
|
3757 | - fatal_lang_error('pm_rule_no_criteria', false); |
|
3905 | + if (empty($_POST['ruletype']) || empty($_POST['acttype'])) { |
|
3906 | + fatal_lang_error('pm_rule_no_criteria', false); |
|
3907 | + } |
|
3758 | 3908 | |
3759 | 3909 | // Let's do the criteria first - it's also hardest! |
3760 | 3910 | $criteria = array(); |
3761 | 3911 | foreach ($_POST['ruletype'] as $ind => $type) |
3762 | 3912 | { |
3763 | 3913 | // Check everything is here... |
3764 | - if ($type == 'gid' && (!isset($_POST['ruledefgroup'][$ind]) || !isset($context['groups'][$_POST['ruledefgroup'][$ind]]))) |
|
3765 | - continue; |
|
3766 | - elseif ($type != 'bud' && !isset($_POST['ruledef'][$ind])) |
|
3767 | - continue; |
|
3914 | + if ($type == 'gid' && (!isset($_POST['ruledefgroup'][$ind]) || !isset($context['groups'][$_POST['ruledefgroup'][$ind]]))) { |
|
3915 | + continue; |
|
3916 | + } elseif ($type != 'bud' && !isset($_POST['ruledef'][$ind])) { |
|
3917 | + continue; |
|
3918 | + } |
|
3768 | 3919 | |
3769 | 3920 | // Members need to be found. |
3770 | 3921 | if ($type == 'mid') |
@@ -3788,13 +3939,13 @@ discard block |
||
3788 | 3939 | $smcFunc['db_free_result']($request); |
3789 | 3940 | |
3790 | 3941 | $criteria[] = array('t' => 'mid', 'v' => $memID); |
3791 | - } |
|
3792 | - elseif ($type == 'bud') |
|
3793 | - $criteria[] = array('t' => 'bud', 'v' => 1); |
|
3794 | - elseif ($type == 'gid') |
|
3795 | - $criteria[] = array('t' => 'gid', 'v' => (int) $_POST['ruledefgroup'][$ind]); |
|
3796 | - elseif (in_array($type, array('sub', 'msg')) && trim($_POST['ruledef'][$ind]) != '') |
|
3797 | - $criteria[] = array('t' => $type, 'v' => $smcFunc['htmlspecialchars'](trim($_POST['ruledef'][$ind]))); |
|
3942 | + } elseif ($type == 'bud') { |
|
3943 | + $criteria[] = array('t' => 'bud', 'v' => 1); |
|
3944 | + } elseif ($type == 'gid') { |
|
3945 | + $criteria[] = array('t' => 'gid', 'v' => (int) $_POST['ruledefgroup'][$ind]); |
|
3946 | + } elseif (in_array($type, array('sub', 'msg')) && trim($_POST['ruledef'][$ind]) != '') { |
|
3947 | + $criteria[] = array('t' => $type, 'v' => $smcFunc['htmlspecialchars'](trim($_POST['ruledef'][$ind]))); |
|
3948 | + } |
|
3798 | 3949 | } |
3799 | 3950 | |
3800 | 3951 | // Also do the actions! |
@@ -3804,26 +3955,29 @@ discard block |
||
3804 | 3955 | foreach ($_POST['acttype'] as $ind => $type) |
3805 | 3956 | { |
3806 | 3957 | // Picking a valid label? |
3807 | - if ($type == 'lab' && (!isset($_POST['labdef'][$ind]) || !isset($context['labels'][$_POST['labdef'][$ind]]))) |
|
3808 | - continue; |
|
3958 | + if ($type == 'lab' && (!isset($_POST['labdef'][$ind]) || !isset($context['labels'][$_POST['labdef'][$ind]]))) { |
|
3959 | + continue; |
|
3960 | + } |
|
3809 | 3961 | |
3810 | 3962 | // Record what we're doing. |
3811 | - if ($type == 'del') |
|
3812 | - $doDelete = 1; |
|
3813 | - elseif ($type == 'lab') |
|
3814 | - $actions[] = array('t' => 'lab', 'v' => (int) $_POST['labdef'][$ind]); |
|
3963 | + if ($type == 'del') { |
|
3964 | + $doDelete = 1; |
|
3965 | + } elseif ($type == 'lab') { |
|
3966 | + $actions[] = array('t' => 'lab', 'v' => (int) $_POST['labdef'][$ind]); |
|
3967 | + } |
|
3815 | 3968 | } |
3816 | 3969 | |
3817 | - if (empty($criteria) || (empty($actions) && !$doDelete)) |
|
3818 | - fatal_lang_error('pm_rule_no_criteria', false); |
|
3970 | + if (empty($criteria) || (empty($actions) && !$doDelete)) { |
|
3971 | + fatal_lang_error('pm_rule_no_criteria', false); |
|
3972 | + } |
|
3819 | 3973 | |
3820 | 3974 | // What are we storing? |
3821 | 3975 | $criteria = $smcFunc['json_encode']($criteria); |
3822 | 3976 | $actions = $smcFunc['json_encode']($actions); |
3823 | 3977 | |
3824 | 3978 | // Create the rule? |
3825 | - if (empty($context['rid'])) |
|
3826 | - $smcFunc['db_insert']('', |
|
3979 | + if (empty($context['rid'])) { |
|
3980 | + $smcFunc['db_insert']('', |
|
3827 | 3981 | '{db_prefix}pm_rules', |
3828 | 3982 | array( |
3829 | 3983 | 'id_member' => 'int', 'rule_name' => 'string', 'criteria' => 'string', 'actions' => 'string', |
@@ -3833,9 +3987,9 @@ discard block |
||
3833 | 3987 | $user_info['id'], $ruleName, $criteria, $actions, $doDelete, $isOr, |
3834 | 3988 | ), |
3835 | 3989 | array('id_rule') |
3836 | - ); |
|
3837 | - else |
|
3838 | - $smcFunc['db_query']('', ' |
|
3990 | + ); |
|
3991 | + } else { |
|
3992 | + $smcFunc['db_query']('', ' |
|
3839 | 3993 | UPDATE {db_prefix}pm_rules |
3840 | 3994 | SET rule_name = {string:rule_name}, criteria = {string:criteria}, actions = {string:actions}, |
3841 | 3995 | delete_pm = {int:delete_pm}, is_or = {int:is_or} |
@@ -3850,7 +4004,8 @@ discard block |
||
3850 | 4004 | 'criteria' => $criteria, |
3851 | 4005 | 'actions' => $actions, |
3852 | 4006 | ) |
3853 | - ); |
|
4007 | + ); |
|
4008 | + } |
|
3854 | 4009 | |
3855 | 4010 | redirectexit('action=pm;sa=manrules'); |
3856 | 4011 | } |
@@ -3859,11 +4014,12 @@ discard block |
||
3859 | 4014 | { |
3860 | 4015 | checkSession(); |
3861 | 4016 | $toDelete = array(); |
3862 | - foreach ($_POST['delrule'] as $k => $v) |
|
3863 | - $toDelete[] = (int) $k; |
|
4017 | + foreach ($_POST['delrule'] as $k => $v) { |
|
4018 | + $toDelete[] = (int) $k; |
|
4019 | + } |
|
3864 | 4020 | |
3865 | - if (!empty($toDelete)) |
|
3866 | - $smcFunc['db_query']('', ' |
|
4021 | + if (!empty($toDelete)) { |
|
4022 | + $smcFunc['db_query']('', ' |
|
3867 | 4023 | DELETE FROM {db_prefix}pm_rules |
3868 | 4024 | WHERE id_rule IN ({array_int:delete_list}) |
3869 | 4025 | AND id_member = {int:current_member}', |
@@ -3871,7 +4027,8 @@ discard block |
||
3871 | 4027 | 'current_member' => $user_info['id'], |
3872 | 4028 | 'delete_list' => $toDelete, |
3873 | 4029 | ) |
3874 | - ); |
|
4030 | + ); |
|
4031 | + } |
|
3875 | 4032 | |
3876 | 4033 | redirectexit('action=pm;sa=manrules'); |
3877 | 4034 | } |
@@ -3890,8 +4047,9 @@ discard block |
||
3890 | 4047 | loadRules(); |
3891 | 4048 | |
3892 | 4049 | // No rules? |
3893 | - if (empty($context['rules'])) |
|
3894 | - return; |
|
4050 | + if (empty($context['rules'])) { |
|
4051 | + return; |
|
4052 | + } |
|
3895 | 4053 | |
3896 | 4054 | // Just unread ones? |
3897 | 4055 | $ruleQuery = $all_messages ? '' : ' AND pmr.is_new = 1'; |
@@ -3921,8 +4079,9 @@ discard block |
||
3921 | 4079 | // Loop through all the criteria hoping to make a match. |
3922 | 4080 | foreach ($rule['criteria'] as $criterium) |
3923 | 4081 | { |
3924 | - if (($criterium['t'] == 'mid' && $criterium['v'] == $row['id_member_from']) || ($criterium['t'] == 'gid' && $criterium['v'] == $row['id_group']) || ($criterium['t'] == 'sub' && strpos($row['subject'], $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($row['body'], $criterium['v']) !== false)) |
|
3925 | - $match = true; |
|
4082 | + if (($criterium['t'] == 'mid' && $criterium['v'] == $row['id_member_from']) || ($criterium['t'] == 'gid' && $criterium['v'] == $row['id_group']) || ($criterium['t'] == 'sub' && strpos($row['subject'], $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($row['body'], $criterium['v']) !== false)) { |
|
4083 | + $match = true; |
|
4084 | + } |
|
3926 | 4085 | // If we're adding and one criteria don't match then we stop! |
3927 | 4086 | elseif ($rule['logic'] == 'and') |
3928 | 4087 | { |
@@ -3934,17 +4093,18 @@ discard block |
||
3934 | 4093 | // If we have a match the rule must be true - act! |
3935 | 4094 | if ($match) |
3936 | 4095 | { |
3937 | - if ($rule['delete']) |
|
3938 | - $actions['deletes'][] = $row['id_pm']; |
|
3939 | - else |
|
4096 | + if ($rule['delete']) { |
|
4097 | + $actions['deletes'][] = $row['id_pm']; |
|
4098 | + } else |
|
3940 | 4099 | { |
3941 | 4100 | foreach ($rule['actions'] as $ruleAction) |
3942 | 4101 | { |
3943 | 4102 | if ($ruleAction['t'] == 'lab') |
3944 | 4103 | { |
3945 | 4104 | // Get a basic pot started! |
3946 | - if (!isset($actions['labels'][$row['id_pm']])) |
|
3947 | - $actions['labels'][$row['id_pm']] = array(); |
|
4105 | + if (!isset($actions['labels'][$row['id_pm']])) { |
|
4106 | + $actions['labels'][$row['id_pm']] = array(); |
|
4107 | + } |
|
3948 | 4108 | $actions['labels'][$row['id_pm']][] = $ruleAction['v']; |
3949 | 4109 | } |
3950 | 4110 | } |
@@ -3955,8 +4115,9 @@ discard block |
||
3955 | 4115 | $smcFunc['db_free_result']($request); |
3956 | 4116 | |
3957 | 4117 | // Deletes are easy! |
3958 | - if (!empty($actions['deletes'])) |
|
3959 | - deleteMessages($actions['deletes']); |
|
4118 | + if (!empty($actions['deletes'])) { |
|
4119 | + deleteMessages($actions['deletes']); |
|
4120 | + } |
|
3960 | 4121 | |
3961 | 4122 | // Relabel? |
3962 | 4123 | if (!empty($actions['labels'])) |
@@ -3983,8 +4144,7 @@ discard block |
||
3983 | 4144 | 'current_member' => $user_info['id'], |
3984 | 4145 | ) |
3985 | 4146 | ); |
3986 | - } |
|
3987 | - else |
|
4147 | + } else |
|
3988 | 4148 | { |
3989 | 4149 | $realLabels[] = $label['id']; |
3990 | 4150 | } |
@@ -3993,8 +4153,9 @@ discard block |
||
3993 | 4153 | |
3994 | 4154 | $inserts = array(); |
3995 | 4155 | // Now we insert the label info |
3996 | - foreach ($realLabels as $a_label) |
|
3997 | - $inserts[] = array($pm, $a_label); |
|
4156 | + foreach ($realLabels as $a_label) { |
|
4157 | + $inserts[] = array($pm, $a_label); |
|
4158 | + } |
|
3998 | 4159 | |
3999 | 4160 | $smcFunc['db_insert']('ignore', |
4000 | 4161 | '{db_prefix}pm_labeled_messages', |
@@ -4015,8 +4176,9 @@ discard block |
||
4015 | 4176 | { |
4016 | 4177 | global $user_info, $context, $smcFunc; |
4017 | 4178 | |
4018 | - if (isset($context['rules']) && !$reload) |
|
4019 | - return; |
|
4179 | + if (isset($context['rules']) && !$reload) { |
|
4180 | + return; |
|
4181 | + } |
|
4020 | 4182 | |
4021 | 4183 | $request = $smcFunc['db_query']('', ' |
4022 | 4184 | SELECT |
@@ -4040,8 +4202,9 @@ discard block |
||
4040 | 4202 | 'logic' => $row['is_or'] ? 'or' : 'and', |
4041 | 4203 | ); |
4042 | 4204 | |
4043 | - if ($row['delete_pm']) |
|
4044 | - $context['rules'][$row['id_rule']]['actions'][] = array('t' => 'del', 'v' => 1); |
|
4205 | + if ($row['delete_pm']) { |
|
4206 | + $context['rules'][$row['id_rule']]['actions'][] = array('t' => 'del', 'v' => 1); |
|
4207 | + } |
|
4045 | 4208 | } |
4046 | 4209 | $smcFunc['db_free_result']($request); |
4047 | 4210 | } |