Completed
Push — release-2.1 ( 6f6d35...dd7040 )
by Michael
11:13
created
Sources/tasks/Register-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 class Register_Notify_Background extends SMF_BackgroundTask
20 20
 {
21 21
 	/**
22
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
22
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23 23
 	 * @return bool Always returns true.
24 24
 	 */
25 25
 	public function execute()
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -43,9 +43,10 @@  discard block
 block discarded – undo
43 43
 
44 44
 		foreach ($prefs as $member => $pref_option)
45 45
 		{
46
-			foreach ($alert_bits as $type => $bitvalue)
47
-				if ($pref_option['member_register'] & $bitvalue)
46
+			foreach ($alert_bits as $type => $bitvalue) {
47
+							if ($pref_option['member_register'] & $bitvalue)
48 48
 					$notifies[$type][] = $member;
49
+			}
49 50
 		}
50 51
 
51 52
 		// Firstly, anyone who wants alerts.
@@ -101,8 +102,9 @@  discard block
 block discarded – undo
101 102
 			);
102 103
 			while ($row = $smcFunc['db_fetch_assoc']($request))
103 104
 			{
104
-				if (empty($row['lngfile']))
105
-					$row['lngfile'] = $language;
105
+				if (empty($row['lngfile'])) {
106
+									$row['lngfile'] = $language;
107
+				}
106 108
 				$emails[$row['lngfile']][$row['id_member']] = $row['email_address'];
107 109
 			}
108 110
 			$smcFunc['db_free_result']($request);
@@ -126,8 +128,9 @@  discard block
 block discarded – undo
126 128
 				$emaildata = loadEmailTemplate($emailtype, $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang);
127 129
 
128 130
 				// And do the actual sending...
129
-				foreach ($recipients as $id_member => $email_address)
130
-					sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'newmember' . $this->_details['new_member_id'], $emaildata['is_html'], 0);
131
+				foreach ($recipients as $id_member => $email_address) {
132
+									sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'newmember' . $this->_details['new_member_id'], $emaildata['is_html'], 0);
133
+				}
131 134
 			}
132 135
 		}
133 136
 
Please login to merge, or discard this patch.
Sources/tasks/MsgReport-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 class MsgReport_Notify_Background extends SMF_BackgroundTask
20 20
 {
21 21
 	/**
22
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
22
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23 23
 	 * @return bool Always returns true.
24 24
 	 */
25 25
 	public function execute()
Please login to merge, or discard this patch.
Braces   +15 added lines, -10 removed lines patch added patch discarded remove patch
@@ -40,8 +40,9 @@  discard block
 block discarded – undo
40 40
 				'current_board' => $this->_details['board_id'],
41 41
 			)
42 42
 		);
43
-		while ($row = $smcFunc['db_fetch_assoc']($request))
44
-			$members[] = $row['id_member'];
43
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
44
+					$members[] = $row['id_member'];
45
+		}
45 46
 		$smcFunc['db_free_result']($request);
46 47
 
47 48
 		// Thirdly, anyone assigned to be a moderator of this group as a group->board moderator.
@@ -58,8 +59,9 @@  discard block
 block discarded – undo
58 59
 			)
59 60
 		);
60 61
 
61
-		while ($row = $smcFunc['db_fetch_assoc']($request))
62
-			$members[] = $row['id_member'];
62
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
63
+					$members[] = $row['id_member'];
64
+		}
63 65
 		$smcFunc['db_free_result']($request);
64 66
 
65 67
 		// And now weed out the duplicates.
@@ -81,9 +83,10 @@  discard block
 block discarded – undo
81 83
 
82 84
 		foreach ($prefs as $member => $pref_option)
83 85
 		{
84
-			foreach ($alert_bits as $type => $bitvalue)
85
-				if ($pref_option['msg_report'] & $bitvalue)
86
+			foreach ($alert_bits as $type => $bitvalue) {
87
+							if ($pref_option['msg_report'] & $bitvalue)
86 88
 					$notifies[$type][] = $member;
89
+			}
87 90
 		}
88 91
 
89 92
 		// Firstly, anyone who wants alerts.
@@ -143,8 +146,9 @@  discard block
 block discarded – undo
143 146
 			);
144 147
 			while ($row = $smcFunc['db_fetch_assoc']($request))
145 148
 			{
146
-				if (empty($row['lngfile']))
147
-					$row['lngfile'] = $language;
149
+				if (empty($row['lngfile'])) {
150
+									$row['lngfile'] = $language;
151
+				}
148 152
 				$emails[$row['lngfile']][$row['id_member']] = $row['email_address'];
149 153
 			}
150 154
 			$smcFunc['db_free_result']($request);
@@ -177,8 +181,9 @@  discard block
 block discarded – undo
177 181
 				$emaildata = loadEmailTemplate('report_to_moderator', $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang);
178 182
 
179 183
 				// And do the actual sending...
180
-				foreach ($recipients as $id_member => $email_address)
181
-					sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'report' . $this->_details['report_id'], $emaildata['is_html'], 2);
184
+				foreach ($recipients as $id_member => $email_address) {
185
+									sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'report' . $this->_details['report_id'], $emaildata['is_html'], 2);
186
+				}
182 187
 			}
183 188
 		}
184 189
 
Please login to merge, or discard this patch.
Sources/tasks/UpdateTldRegex.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,10 +18,10 @@
 block discarded – undo
18 18
  */
19 19
 class Update_TLD_Regex extends SMF_BackgroundTask
20 20
 {
21
-    /**
22
-     * This executes the task. It just calls set_tld_regex() in Subs.php
23
-     * @return bool Always returns true
24
-     */
21
+	/**
22
+	 * This executes the task. It just calls set_tld_regex() in Subs.php
23
+	 * @return bool Always returns true
24
+	 */
25 25
 	public function execute()
26 26
  	{
27 27
 		global $sourcedir;
Please login to merge, or discard this patch.
Sources/tasks/MemberReportReply-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 class MemberReportReply_Notify_Background extends SMF_BackgroundTask
21 21
 {
22 22
 	/**
23
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
24 24
 	 * @return bool Always returns true.
25 25
 	 */
26 26
 	public function execute()
Please login to merge, or discard this patch.
Braces   +15 added lines, -10 removed lines patch added patch discarded remove patch
@@ -40,8 +40,9 @@  discard block
 block discarded – undo
40 40
 				'last_comment' => $this->_details['comment_id'],
41 41
 			)
42 42
 		);
43
-		while ($row = $smcFunc['db_fetch_row']($request))
44
-			$possible_members[] = $row[0];
43
+		while ($row = $smcFunc['db_fetch_row']($request)) {
44
+					$possible_members[] = $row[0];
45
+		}
45 46
 		$smcFunc['db_free_result']($request);
46 47
 
47 48
 		// Presumably, there are some people?
@@ -50,8 +51,9 @@  discard block
 block discarded – undo
50 51
 			$possible_members = array_flip(array_flip($possible_members));
51 52
 			$possible_members = array_diff($possible_members, array($this->_details['sender_id']));
52 53
 		}
53
-		if (empty($possible_members))
54
-			return true;
54
+		if (empty($possible_members)) {
55
+					return true;
56
+		}
55 57
 
56 58
 		// We need to know who can moderate this board - and therefore who can see this report.
57 59
 		// First up, people who have moderate_board in the board this topic was in.
@@ -73,8 +75,9 @@  discard block
 block discarded – undo
73 75
 		{
74 76
 			foreach ($alert_bits as $type => $bitvalue)
75 77
 			{
76
-				if ($pref_option['member_report_reply'] & $bitvalue)
77
-					$notifies[$type][] = $member;
78
+				if ($pref_option['member_report_reply'] & $bitvalue) {
79
+									$notifies[$type][] = $member;
80
+				}
78 81
 			}
79 82
 		}
80 83
 
@@ -136,8 +139,9 @@  discard block
 block discarded – undo
136 139
 			);
137 140
 			while ($row = $smcFunc['db_fetch_assoc']($request))
138 141
 			{
139
-				if (empty($row['lngfile']))
140
-					$row['lngfile'] = $language;
142
+				if (empty($row['lngfile'])) {
143
+									$row['lngfile'] = $language;
144
+				}
141 145
 				$emails[$row['lngfile']][$row['id_member']] = $row['email_address'];
142 146
 			}
143 147
 			$smcFunc['db_free_result']($request);
@@ -155,8 +159,9 @@  discard block
 block discarded – undo
155 159
 				$emaildata = loadEmailTemplate('reply_to_user_reports', $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang);
156 160
 
157 161
 				// And do the actual sending...
158
-				foreach ($recipients as $id_member => $email_address)
159
-					sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'urptrpy' . $this->_details['comment_id'], $emaildata['is_html'], 3);
162
+				foreach ($recipients as $id_member => $email_address) {
163
+									sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'urptrpy' . $this->_details['comment_id'], $emaildata['is_html'], 3);
164
+				}
160 165
 			}
161 166
 		}
162 167
 
Please login to merge, or discard this patch.
Sources/tasks/ApproveReply-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 class ApproveReply_Notify_Background extends SMF_BackgroundTask
19 19
 {
20 20
 	/**
21
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts.
21
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts.
22 22
 	 * @return bool Always returns true.
23 23
 	 */
24 24
 	public function execute()
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,14 +96,15 @@
 block discarded – undo
96 96
 		}
97 97
 
98 98
 		// Insert the alerts if any
99
-		if (!empty($alert_rows))
100
-			$smcFunc['db_insert']('',
99
+		if (!empty($alert_rows)) {
100
+					$smcFunc['db_insert']('',
101 101
 				'{db_prefix}user_alerts',
102 102
 				array('alert_time' => 'int', 'id_member' => 'int', 'id_member_started' => 'int', 'member_name' => 'string',
103 103
 					'content_type' => 'string', 'content_id' => 'int', 'content_action' => 'string', 'is_read' => 'int', 'extra' => 'string'),
104 104
 				$alert_rows,
105 105
 				array()
106 106
 			);
107
+		}
107 108
 
108 109
 		return true;
109 110
 	}
Please login to merge, or discard this patch.
Sources/tasks/GroupReq-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 class GroupReq_Notify_Background extends SMF_BackgroundTask
21 21
 {
22 22
 	/**
23
-     * This executes the task - loads up the information, puts the email in the queue and inserts any alerts as needed.
23
+	 * This executes the task - loads up the information, puts the email in the queue and inserts any alerts as needed.
24 24
 	 * @return bool Always returns true.
25 25
 	 */
26 26
 	public function execute()
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -37,8 +37,9 @@  discard block
 block discarded – undo
37 37
 			)
38 38
 		);
39 39
 		$moderators = array();
40
-		while ($row = $smcFunc['db_fetch_assoc']($request))
41
-			$moderators[] = $row['id_member'];
40
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
41
+					$moderators[] = $row['id_member'];
42
+		}
42 43
 		$smcFunc['db_free_result']($request);
43 44
 
44 45
 		require_once($sourcedir . '/Subs-Members.php');
@@ -59,11 +60,13 @@  discard block
 block discarded – undo
59 60
 			{
60 61
 				if (!empty($prefs[$mod]['request_group']))
61 62
 				{
62
-					if ($prefs[$mod]['request_group'] & 0x01)
63
-						$data['alert'][] = $mod;
63
+					if ($prefs[$mod]['request_group'] & 0x01) {
64
+											$data['alert'][] = $mod;
65
+					}
64 66
 
65
-					if ($prefs[$mod]['request_group'] & 0x02)
66
-						$data['email'][] = $mod;
67
+					if ($prefs[$mod]['request_group'] & 0x02) {
68
+											$data['email'][] = $mod;
69
+					}
67 70
 				}
68 71
 			}
69 72
 
Please login to merge, or discard this patch.
Sources/Calendar.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -240,8 +240,8 @@
 block discarded – undo
240 240
 		$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
241 241
 
242 242
 	$js_time_string = str_replace(
243
-		array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
244
-		array('H',  'G',  'h',  'g',  'i',  'A',  'a',  'h:i:s A', 'H:i', 's',  'H:i:s', 'H:i:s'),
243
+		array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'),
244
+		array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'),
245 245
 		$time_string
246 246
 	);
247 247
 
Please login to merge, or discard this patch.
Braces   +122 added lines, -97 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Show the calendar.
@@ -47,12 +48,14 @@  discard block
 block discarded – undo
47 48
 		'post' => 'CalendarPost',
48 49
 	);
49 50
 
50
-	if (isset($_GET['sa']) && isset($subActions[$_GET['sa']]))
51
-		return call_helper($subActions[$_GET['sa']]);
51
+	if (isset($_GET['sa']) && isset($subActions[$_GET['sa']])) {
52
+			return call_helper($subActions[$_GET['sa']]);
53
+	}
52 54
 
53 55
 	// You can't do anything if the calendar is off.
54
-	if (empty($modSettings['cal_enabled']))
55
-		fatal_lang_error('calendar_off', false);
56
+	if (empty($modSettings['cal_enabled'])) {
57
+			fatal_lang_error('calendar_off', false);
58
+	}
56 59
 
57 60
 	// This is gonna be needed...
58 61
 	loadTemplate('Calendar');
@@ -88,22 +91,25 @@  discard block
 block discarded – undo
88 91
 	$context['page_title'] = $txt['calendar'];
89 92
 
90 93
 	// Ensure a default view is defined
91
-	if (empty($modSettings['calendar_default_view']))
92
-		$modSettings['calendar_default_view'] = 'viewlist';
94
+	if (empty($modSettings['calendar_default_view'])) {
95
+			$modSettings['calendar_default_view'] = 'viewlist';
96
+	}
93 97
 
94 98
 	// What view do we want?
95
-	if (isset($_GET['viewweek']))
96
-		$context['calendar_view'] = 'viewweek';
97
-	elseif (isset($_GET['viewmonth']))
98
-		$context['calendar_view'] = 'viewmonth';
99
-	elseif (isset($_GET['viewlist']))
100
-		$context['calendar_view'] = 'viewlist';
101
-	else
102
-		$context['calendar_view'] = $modSettings['calendar_default_view'];
99
+	if (isset($_GET['viewweek'])) {
100
+			$context['calendar_view'] = 'viewweek';
101
+	} elseif (isset($_GET['viewmonth'])) {
102
+			$context['calendar_view'] = 'viewmonth';
103
+	} elseif (isset($_GET['viewlist'])) {
104
+			$context['calendar_view'] = 'viewlist';
105
+	} else {
106
+			$context['calendar_view'] = $modSettings['calendar_default_view'];
107
+	}
103 108
 
104 109
 	// Don't let search engines index the non-default calendar pages
105
-	if ($context['calendar_view'] !== $modSettings['calendar_default_view'])
106
-		$context['robot_no_index'] = true;
110
+	if ($context['calendar_view'] !== $modSettings['calendar_default_view']) {
111
+			$context['robot_no_index'] = true;
112
+	}
107 113
 
108 114
 	// Get the current day of month...
109 115
 	require_once($sourcedir . '/Subs-Calendar.php');
@@ -164,16 +170,19 @@  discard block
 block discarded – undo
164 170
 	);
165 171
 
166 172
 	// Make sure the year and month are in valid ranges.
167
-	if ($curPage['month'] < 1 || $curPage['month'] > 12)
168
-		fatal_lang_error('invalid_month', false);
169
-	if ($curPage['year'] < $modSettings['cal_minyear'] || $curPage['year'] > $modSettings['cal_maxyear'])
170
-		fatal_lang_error('invalid_year', false);
173
+	if ($curPage['month'] < 1 || $curPage['month'] > 12) {
174
+			fatal_lang_error('invalid_month', false);
175
+	}
176
+	if ($curPage['year'] < $modSettings['cal_minyear'] || $curPage['year'] > $modSettings['cal_maxyear']) {
177
+			fatal_lang_error('invalid_year', false);
178
+	}
171 179
 	// If we have a day clean that too.
172 180
 	if ($context['calendar_view'] != 'viewmonth')
173 181
 	{
174 182
 		$isValid = checkdate($curPage['month'], $curPage['day'], $curPage['year']);
175
-		if (!$isValid)
176
-			fatal_lang_error('invalid_day', false);
183
+		if (!$isValid) {
184
+					fatal_lang_error('invalid_day', false);
185
+		}
177 186
 	}
178 187
 
179 188
 	// Load all the context information needed to show the calendar grid.
@@ -195,23 +204,26 @@  discard block
 block discarded – undo
195 204
 	);
196 205
 
197 206
 	// Load up the main view.
198
-	if ($context['calendar_view'] == 'viewlist')
199
-		$context['calendar_grid_main'] = getCalendarList($curPage['start_date'], $curPage['end_date'], $calendarOptions);
200
-	elseif ($context['calendar_view'] == 'viewweek')
201
-		$context['calendar_grid_main'] = getCalendarWeek($curPage['month'], $curPage['year'], $curPage['day'], $calendarOptions);
202
-	else
203
-		$context['calendar_grid_main'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions);
207
+	if ($context['calendar_view'] == 'viewlist') {
208
+			$context['calendar_grid_main'] = getCalendarList($curPage['start_date'], $curPage['end_date'], $calendarOptions);
209
+	} elseif ($context['calendar_view'] == 'viewweek') {
210
+			$context['calendar_grid_main'] = getCalendarWeek($curPage['month'], $curPage['year'], $curPage['day'], $calendarOptions);
211
+	} else {
212
+			$context['calendar_grid_main'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions);
213
+	}
204 214
 
205 215
 	// Load up the previous and next months.
206 216
 	$context['calendar_grid_current'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions);
207 217
 
208 218
 	// Only show previous month if it isn't pre-January of the min-year
209
-	if ($context['calendar_grid_current']['previous_calendar']['year'] > $modSettings['cal_minyear'] || $curPage['month'] != 1)
210
-		$context['calendar_grid_prev'] = getCalendarGrid($context['calendar_grid_current']['previous_calendar']['month'], $context['calendar_grid_current']['previous_calendar']['year'], $calendarOptions, true);
219
+	if ($context['calendar_grid_current']['previous_calendar']['year'] > $modSettings['cal_minyear'] || $curPage['month'] != 1) {
220
+			$context['calendar_grid_prev'] = getCalendarGrid($context['calendar_grid_current']['previous_calendar']['month'], $context['calendar_grid_current']['previous_calendar']['year'], $calendarOptions, true);
221
+	}
211 222
 
212 223
 	// Only show next month if it isn't post-December of the max-year
213
-	if ($context['calendar_grid_current']['next_calendar']['year'] < $modSettings['cal_maxyear'] || $curPage['month'] != 12)
214
-		$context['calendar_grid_next'] = getCalendarGrid($context['calendar_grid_current']['next_calendar']['month'], $context['calendar_grid_current']['next_calendar']['year'], $calendarOptions);
224
+	if ($context['calendar_grid_current']['next_calendar']['year'] < $modSettings['cal_maxyear'] || $curPage['month'] != 12) {
225
+			$context['calendar_grid_next'] = getCalendarGrid($context['calendar_grid_current']['next_calendar']['month'], $context['calendar_grid_current']['next_calendar']['year'], $calendarOptions);
226
+	}
215 227
 
216 228
 	// Basic template stuff.
217 229
 	$context['allow_calendar_event'] = allowedTo('calendar_post');
@@ -231,8 +243,9 @@  discard block
 block discarded – undo
231 243
 	$context['blocks_disabled'] = !empty($modSettings['cal_disable_prev_next']) ? 1 : 0;
232 244
 
233 245
 	// Set the page title to mention the month or week, too
234
-	if ($context['calendar_view'] != 'viewlist')
235
-		$context['page_title'] .= ' - ' . ($context['calendar_view'] == 'viewweek' ? $context['calendar_grid_main']['week_title'] : $txt['months'][$context['current_month']] . ' ' . $context['current_year']);
246
+	if ($context['calendar_view'] != 'viewlist') {
247
+			$context['page_title'] .= ' - ' . ($context['calendar_view'] == 'viewweek' ? $context['calendar_grid_main']['week_title'] : $txt['months'][$context['current_month']] . ' ' . $context['current_year']);
248
+	}
236 249
 
237 250
 	// Load up the linktree!
238 251
 	$context['linktree'][] = array(
@@ -245,17 +258,19 @@  discard block
 block discarded – undo
245 258
 		'name' => $txt['months'][$context['current_month']] . ' ' . $context['current_year']
246 259
 	);
247 260
 	// If applicable, add the current week to the linktree.
248
-	if ($context['calendar_view'] == 'viewweek')
249
-		$context['linktree'][] = array(
261
+	if ($context['calendar_view'] == 'viewweek') {
262
+			$context['linktree'][] = array(
250 263
 			'url' => $scripturl . '?action=calendar;viewweek;year=' . $context['current_year'] . ';month=' . $context['current_month'] . ';day=' . $context['current_day'],
251 264
 			'name' => $context['calendar_grid_main']['week_title'],
252 265
 		);
266
+	}
253 267
 
254 268
 	// Build the calendar button array.
255 269
 	$context['calendar_buttons'] = array();
256 270
 
257
-	if ($context['can_post'])
258
-		$context['calendar_buttons']['post_event'] = array('text' => 'calendar_post_event', 'image' => 'calendarpe.png', 'url' => $scripturl . '?action=calendar;sa=post;month=' . $context['current_month'] . ';year=' . $context['current_year'] . ';' . $context['session_var'] . '=' . $context['session_id']);
271
+	if ($context['can_post']) {
272
+			$context['calendar_buttons']['post_event'] = array('text' => 'calendar_post_event', 'image' => 'calendarpe.png', 'url' => $scripturl . '?action=calendar;sa=post;month=' . $context['current_month'] . ';year=' . $context['current_year'] . ';' . $context['session_var'] . '=' . $context['session_id']);
273
+	}
259 274
 
260 275
 	// Allow mods to add additional buttons here
261 276
 	call_integration_hook('integrate_calendar_buttons');
@@ -284,14 +299,16 @@  discard block
 block discarded – undo
284 299
 	require_once($sourcedir . '/Subs.php');
285 300
 
286 301
 	// Cast this for safety...
287
-	if (isset($_REQUEST['eventid']))
288
-		$_REQUEST['eventid'] = (int) $_REQUEST['eventid'];
302
+	if (isset($_REQUEST['eventid'])) {
303
+			$_REQUEST['eventid'] = (int) $_REQUEST['eventid'];
304
+	}
289 305
 
290 306
 	// We want a fairly compact version of the time, but as close as possible to the user's settings.
291
-	if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
292
-		$time_string = '%k:%M';
293
-	else
294
-		$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
307
+	if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
308
+			$time_string = '%k:%M';
309
+	} else {
310
+			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
311
+	}
295 312
 
296 313
 	$js_time_string = str_replace(
297 314
 		array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
@@ -305,12 +322,14 @@  discard block
 block discarded – undo
305 322
 		checkSession();
306 323
 
307 324
 		// Validate the post...
308
-		if (!isset($_POST['link_to_board']))
309
-			validateEventPost();
325
+		if (!isset($_POST['link_to_board'])) {
326
+					validateEventPost();
327
+		}
310 328
 
311 329
 		// If you're not allowed to edit any events, you have to be the poster.
312
-		if ($_REQUEST['eventid'] > 0 && !allowedTo('calendar_edit_any'))
313
-			isAllowedTo('calendar_edit_' . (!empty($user_info['id']) && getEventPoster($_REQUEST['eventid']) == $user_info['id'] ? 'own' : 'any'));
330
+		if ($_REQUEST['eventid'] > 0 && !allowedTo('calendar_edit_any')) {
331
+					isAllowedTo('calendar_edit_' . (!empty($user_info['id']) && getEventPoster($_REQUEST['eventid']) == $user_info['id'] ? 'own' : 'any'));
332
+		}
314 333
 
315 334
 		// New - and directing?
316 335
 		if (isset($_POST['link_to_board']) || empty($modSettings['cal_allow_unlinked']))
@@ -333,8 +352,9 @@  discard block
 block discarded – undo
333 352
 		}
334 353
 
335 354
 		// Deleting...
336
-		elseif (isset($_REQUEST['deleteevent']))
337
-			removeEvent($_REQUEST['eventid']);
355
+		elseif (isset($_REQUEST['deleteevent'])) {
356
+					removeEvent($_REQUEST['eventid']);
357
+		}
338 358
 
339 359
 		// ... or just update it?
340 360
 		else
@@ -357,15 +377,13 @@  discard block
 block discarded – undo
357 377
 			$year = $d['year'];
358 378
 			$month = $d['month'];
359 379
 			$day = $d['day'];
360
-		}
361
-		elseif (isset($_POST['start_datetime']))
380
+		} elseif (isset($_POST['start_datetime']))
362 381
 		{
363 382
 			$d = date_parse($_POST['start_datetime']);
364 383
 			$year = $d['year'];
365 384
 			$month = $d['month'];
366 385
 			$day = $d['day'];
367
-		}
368
-		else
386
+		} else
369 387
 		{
370 388
 			$today = getdate();
371 389
 			$year = isset($_POST['year']) ? $_POST['year'] : $today['year'];
@@ -399,13 +417,13 @@  discard block
 block discarded – undo
399 417
 		$context['event'] = array_merge($context['event'], $eventDatetimes);
400 418
 
401 419
 		$context['event']['last_day'] = (int) strftime('%d', mktime(0, 0, 0, $context['event']['month'] == 12 ? 1 : $context['event']['month'] + 1, 0, $context['event']['month'] == 12 ? $context['event']['year'] + 1 : $context['event']['year']));
402
-	}
403
-	else
420
+	} else
404 421
 	{
405 422
 		$context['event'] = getEventProperties($_REQUEST['eventid']);
406 423
 
407
-		if ($context['event'] === false)
408
-			fatal_lang_error('no_access', false);
424
+		if ($context['event'] === false) {
425
+					fatal_lang_error('no_access', false);
426
+		}
409 427
 
410 428
 		// If it has a board, then they should be editing it within the topic.
411 429
 		if (!empty($context['event']['topic']['id']) && !empty($context['event']['topic']['first_msg']))
@@ -416,10 +434,11 @@  discard block
 block discarded – undo
416 434
 		}
417 435
 
418 436
 		// Make sure the user is allowed to edit this event.
419
-		if ($context['event']['member'] != $user_info['id'])
420
-			isAllowedTo('calendar_edit_any');
421
-		elseif (!allowedTo('calendar_edit_any'))
422
-			isAllowedTo('calendar_edit_own');
437
+		if ($context['event']['member'] != $user_info['id']) {
438
+					isAllowedTo('calendar_edit_any');
439
+		} elseif (!allowedTo('calendar_edit_any')) {
440
+					isAllowedTo('calendar_edit_own');
441
+		}
423 442
 	}
424 443
 
425 444
 	// An all day event? Set up some nice defaults in case the user wants to change that
@@ -453,8 +472,7 @@  discard block
 block discarded – undo
453 472
 	{
454 473
 		// You can post new events but can't link them to anything...
455 474
 		$context['event']['categories'] = array();
456
-	}
457
-	else
475
+	} else
458 476
 	{
459 477
 		// Load the list of boards and categories in the context.
460 478
 		require_once($sourcedir . '/Subs-MessageIndex.php');
@@ -541,12 +559,14 @@  discard block
 block discarded – undo
541 559
 	global $smcFunc, $sourcedir, $forum_version, $modSettings, $webmaster_email, $mbname;
542 560
 
543 561
 	// You can't export if the calendar export feature is off.
544
-	if (empty($modSettings['cal_export']))
545
-		fatal_lang_error('calendar_export_off', false);
562
+	if (empty($modSettings['cal_export'])) {
563
+			fatal_lang_error('calendar_export_off', false);
564
+	}
546 565
 
547 566
 	// Goes without saying that this is required.
548
-	if (!isset($_REQUEST['eventid']))
549
-		fatal_lang_error('no_access', false);
567
+	if (!isset($_REQUEST['eventid'])) {
568
+			fatal_lang_error('no_access', false);
569
+	}
550 570
 
551 571
 	// This is kinda wanted.
552 572
 	require_once($sourcedir . '/Subs-Calendar.php');
@@ -554,15 +574,17 @@  discard block
 block discarded – undo
554 574
 	// Load up the event in question and check it exists.
555 575
 	$event = getEventProperties($_REQUEST['eventid']);
556 576
 
557
-	if ($event === false)
558
-		fatal_lang_error('no_access', false);
577
+	if ($event === false) {
578
+			fatal_lang_error('no_access', false);
579
+	}
559 580
 
560 581
 	// Check the title isn't too long - iCal requires some formatting if so.
561 582
 	$title = str_split($event['title'], 30);
562 583
 	foreach ($title as $id => $line)
563 584
 	{
564
-		if ($id != 0)
565
-			$title[$id] = ' ' . $title[$id];
585
+		if ($id != 0) {
586
+					$title[$id] = ' ' . $title[$id];
587
+		}
566 588
 		$title[$id] .= "\n";
567 589
 	}
568 590
 
@@ -575,8 +597,7 @@  discard block
 block discarded – undo
575 597
 	{
576 598
 		$datestart = date_format($start_date, 'Ymd\THis');
577 599
 		$dateend = date_format($end_date, 'Ymd\THis');
578
-	}
579
-	else
600
+	} else
580 601
 	{
581 602
 		$datestart = date_format($start_date, 'Ymd');
582 603
 
@@ -597,15 +618,18 @@  discard block
 block discarded – undo
597 618
 	$filecontents .= 'DTSTART' . (!empty($event['start_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $datestart . "\n";
598 619
 
599 620
 	// event has a duration
600
-	if ($event['start_iso_gmdate'] != $event['end_iso_gmdate'])
601
-		$filecontents .= 'DTEND' . (!empty($event['end_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $dateend . "\n";
621
+	if ($event['start_iso_gmdate'] != $event['end_iso_gmdate']) {
622
+			$filecontents .= 'DTEND' . (!empty($event['end_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $dateend . "\n";
623
+	}
602 624
 
603 625
 	// event has changed? advance the sequence for this UID
604
-	if ($event['sequence'] > 0)
605
-		$filecontents .= 'SEQUENCE:' . $event['sequence'] . "\n";
626
+	if ($event['sequence'] > 0) {
627
+			$filecontents .= 'SEQUENCE:' . $event['sequence'] . "\n";
628
+	}
606 629
 
607
-	if (!empty($event['location']))
608
-		$filecontents .= 'LOCATION:' . str_replace(',', '\,', $event['location']) . "\n";
630
+	if (!empty($event['location'])) {
631
+			$filecontents .= 'LOCATION:' . str_replace(',', '\,', $event['location']) . "\n";
632
+	}
609 633
 
610 634
 	$filecontents .= 'SUMMARY:' . implode('', $title);
611 635
 	$filecontents .= 'UID:' . $event['eventid'] . '@' . str_replace(' ', '-', $mbname) . "\n";
@@ -614,23 +638,26 @@  discard block
 block discarded – undo
614 638
 
615 639
 	// Send some standard headers.
616 640
 	ob_end_clean();
617
-	if (!empty($modSettings['enableCompressedOutput']))
618
-		@ob_start('ob_gzhandler');
619
-	else
620
-		ob_start();
641
+	if (!empty($modSettings['enableCompressedOutput'])) {
642
+			@ob_start('ob_gzhandler');
643
+	} else {
644
+			ob_start();
645
+	}
621 646
 
622 647
 	// Send the file headers
623 648
 	header('Pragma: ');
624 649
 	header('Cache-Control: no-cache');
625
-	if (!isBrowser('gecko'))
626
-		header('Content-Transfer-Encoding: binary');
650
+	if (!isBrowser('gecko')) {
651
+			header('Content-Transfer-Encoding: binary');
652
+	}
627 653
 	header('Expires: ' . gmdate('D, d M Y H:i:s', time() + 525600 * 60) . ' GMT');
628 654
 	header('Last-Modified: ' . gmdate('D, d M Y H:i:s', time()) . 'GMT');
629 655
 	header('Accept-Ranges: bytes');
630 656
 	header('Connection: close');
631 657
 	header('Content-Disposition: attachment; filename="' . $event['title'] . '.ics"');
632
-	if (empty($modSettings['enableCompressedOutput']))
633
-		header('Content-Length: ' . $smcFunc['strlen']($filecontents));
658
+	if (empty($modSettings['enableCompressedOutput'])) {
659
+			header('Content-Length: ' . $smcFunc['strlen']($filecontents));
660
+	}
634 661
 
635 662
 	// This is a calendar item!
636 663
 	header('Content-Type: text/calendar');
@@ -669,20 +696,17 @@  discard block
 block discarded – undo
669 696
 		$context['sub_template'] = 'bcd';
670 697
 		$context['linktree'][] = array('url' => $scripturl . '?action=clock;bcd', 'name' => 'BCD');
671 698
 		$context['clockicons'] = $smcFunc['json_decode'](base64_decode('eyJoMSI6WzIsMV0sImgyIjpbOCw0LDIsMV0sIm0xIjpbNCwyLDFdLCJtMiI6WzgsNCwyLDFdLCJzMSI6WzQsMiwxXSwiczIiOls4LDQsMiwxXX0='), true);
672
-	}
673
-	elseif (!$omfg && !isset($_REQUEST['time']))
699
+	} elseif (!$omfg && !isset($_REQUEST['time']))
674 700
 	{
675 701
 		$context['sub_template'] = 'hms';
676 702
 		$context['linktree'][] = array('url' => $scripturl . '?action=clock', 'name' => 'Binary');
677 703
 		$context['clockicons'] = $smcFunc['json_decode'](base64_decode('eyJoIjpbMTYsOCw0LDIsMV0sIm0iOlszMiwxNiw4LDQsMiwxXSwicyI6WzMyLDE2LDgsNCwyLDFdfQ'), true);
678
-	}
679
-	elseif ($omfg)
704
+	} elseif ($omfg)
680 705
 	{
681 706
 		$context['sub_template'] = 'omfg';
682 707
 		$context['linktree'][] = array('url' => $scripturl . '?action=clock;omfg', 'name' => 'OMFG');
683 708
 		$context['clockicons'] = $smcFunc['json_decode'](base64_decode('eyJ5ZWFyIjpbNjQsMzIsMTYsOCw0LDIsMV0sIm1vbnRoIjpbOCw0LDIsMV0sImRheSI6WzE2LDgsNCwyLDFdLCJob3VyIjpbMTYsOCw0LDIsMV0sIm1pbiI6WzMyLDE2LDgsNCwyLDFdLCJzZWMiOlszMiwxNiw4LDQsMiwxXX0='), true);
684
-	}
685
-	elseif (isset($_REQUEST['time']))
709
+	} elseif (isset($_REQUEST['time']))
686 710
 	{
687 711
 		$context['sub_template'] = 'thetime';
688 712
 		$time = getdate($_REQUEST['time'] == 'now' ? time() : (int) $_REQUEST['time']);
@@ -736,12 +760,13 @@  discard block
 block discarded – undo
736 760
 			),
737 761
 		);
738 762
 
739
-		foreach ($context['clockicons'] as $t => $vs)
740
-			foreach ($vs as $v => $dumb)
763
+		foreach ($context['clockicons'] as $t => $vs) {
764
+					foreach ($vs as $v => $dumb)
741 765
 			{
742 766
 				if ($$t >= $v)
743 767
 				{
744 768
 					$$t -= $v;
769
+		}
745 770
 					$context['clockicons'][$t][$v] = true;
746 771
 				}
747 772
 			}
Please login to merge, or discard this patch.
other/install.php 2 patches
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1622,8 +1622,7 @@
 block discarded – undo
1622 1622
 	updateStats('topic');
1623 1623
 
1624 1624
 	// This function is needed to do the updateStats('subject') call.
1625
-	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' :
1626
-		function($string){
1625
+	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) {
1627 1626
 			global $sourcedir;
1628 1627
 			if (function_exists('mb_strtolower'))
1629 1628
 				return mb_strtolower($string, 'UTF-8');
Please login to merge, or discard this patch.
Braces   +447 added lines, -332 removed lines patch added patch discarded remove patch
@@ -20,8 +20,9 @@  discard block
 block discarded – undo
20 20
 // ><html dir="ltr"><head><title>Error!</title></head><body>Sorry, this installer requires PHP!<div style="display: none;">
21 21
 
22 22
 // Let's pull in useful classes
23
-if (!defined('SMF'))
23
+if (!defined('SMF')) {
24 24
 	define('SMF', 1);
25
+}
25 26
 
26 27
 require_once('Sources/Class-Package.php');
27 28
 
@@ -63,10 +64,11 @@  discard block
 block discarded – undo
63 64
 
64 65
 			list ($charcode) = pg_fetch_row($request);
65 66
 
66
-			if ($charcode == 'UTF8')
67
-				return true;
68
-			else
69
-				return false;
67
+			if ($charcode == 'UTF8') {
68
+							return true;
69
+			} else {
70
+							return false;
71
+			}
70 72
 		},
71 73
 		'utf8_version' => '8.0',
72 74
 		'utf8_version_check' => '$request = pg_query(\'SELECT version()\'); list ($version) = pg_fetch_row($request); list($pgl, $version) = explode(" ", $version); return $version;',
@@ -76,12 +78,14 @@  discard block
 block discarded – undo
76 78
 			$value = preg_replace('~[^A-Za-z0-9_\$]~', '', $value);
77 79
 
78 80
 			// Is it reserved?
79
-			if ($value == 'pg_')
80
-				return $txt['error_db_prefix_reserved'];
81
+			if ($value == 'pg_') {
82
+							return $txt['error_db_prefix_reserved'];
83
+			}
81 84
 
82 85
 			// Is the prefix numeric?
83
-			if (preg_match('~^\d~', $value))
84
-				return $txt['error_db_prefix_numeric'];
86
+			if (preg_match('~^\d~', $value)) {
87
+							return $txt['error_db_prefix_numeric'];
88
+			}
85 89
 
86 90
 			return true;
87 91
 		},
@@ -128,10 +132,11 @@  discard block
 block discarded – undo
128 132
 		$incontext['skip'] = false;
129 133
 
130 134
 		// Call the step and if it returns false that means pause!
131
-		if (function_exists($step[2]) && $step[2]() === false)
132
-			break;
133
-		elseif (function_exists($step[2]))
134
-			$incontext['current_step']++;
135
+		if (function_exists($step[2]) && $step[2]() === false) {
136
+					break;
137
+		} elseif (function_exists($step[2])) {
138
+					$incontext['current_step']++;
139
+		}
135 140
 
136 141
 		// No warnings pass on.
137 142
 		$incontext['warning'] = '';
@@ -147,8 +152,9 @@  discard block
 block discarded – undo
147 152
 	global $databases;
148 153
 
149 154
 	// Just so people using older versions of PHP aren't left in the cold.
150
-	if (!isset($_SERVER['PHP_SELF']))
151
-		$_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php';
155
+	if (!isset($_SERVER['PHP_SELF'])) {
156
+			$_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php';
157
+	}
152 158
 
153 159
 	// Enable error reporting.
154 160
 	error_reporting(E_ALL);
@@ -164,21 +170,23 @@  discard block
 block discarded – undo
164 170
 	{
165 171
 		ob_start();
166 172
 
167
-		if (ini_get('session.save_handler') == 'user')
168
-			@ini_set('session.save_handler', 'files');
169
-		if (function_exists('session_start'))
170
-			@session_start();
171
-	}
172
-	else
173
+		if (ini_get('session.save_handler') == 'user') {
174
+					@ini_set('session.save_handler', 'files');
175
+		}
176
+		if (function_exists('session_start')) {
177
+					@session_start();
178
+		}
179
+	} else
173 180
 	{
174 181
 		ob_start('ob_gzhandler');
175 182
 
176
-		if (ini_get('session.save_handler') == 'user')
177
-			@ini_set('session.save_handler', 'files');
183
+		if (ini_get('session.save_handler') == 'user') {
184
+					@ini_set('session.save_handler', 'files');
185
+		}
178 186
 		session_start();
179 187
 
180
-		if (!headers_sent())
181
-			echo '<!DOCTYPE html>
188
+		if (!headers_sent()) {
189
+					echo '<!DOCTYPE html>
182 190
 <html>
183 191
 	<head>
184 192
 		<title>', htmlspecialchars($_GET['pass_string']), '</title>
@@ -187,14 +195,16 @@  discard block
 block discarded – undo
187 195
 		<strong>', htmlspecialchars($_GET['pass_string']), '</strong>
188 196
 	</body>
189 197
 </html>';
198
+		}
190 199
 		exit;
191 200
 	}
192 201
 
193 202
 	// Add slashes, as long as they aren't already being added.
194
-	if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0)
195
-		foreach ($_POST as $k => $v)
203
+	if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) {
204
+			foreach ($_POST as $k => $v)
196 205
 			if (strpos($k, 'password') === false && strpos($k, 'db_passwd') === false)
197 206
 				$_POST[$k] = addslashes($v);
207
+	}
198 208
 
199 209
 	// This is really quite simple; if ?delete is on the URL, delete the installer...
200 210
 	if (isset($_GET['delete']))
@@ -215,8 +225,7 @@  discard block
 block discarded – undo
215 225
 			$ftp->close();
216 226
 
217 227
 			unset($_SESSION['installer_temp_ftp']);
218
-		}
219
-		else
228
+		} else
220 229
 		{
221 230
 			@unlink(__FILE__);
222 231
 
@@ -237,10 +246,11 @@  discard block
 block discarded – undo
237 246
 	{
238 247
 		// Get PHP's default timezone, if set
239 248
 		$ini_tz = ini_get('date.timezone');
240
-		if (!empty($ini_tz))
241
-			$timezone_id = $ini_tz;
242
-		else
243
-			$timezone_id = '';
249
+		if (!empty($ini_tz)) {
250
+					$timezone_id = $ini_tz;
251
+		} else {
252
+					$timezone_id = '';
253
+		}
244 254
 
245 255
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
246 256
 		if (!in_array($timezone_id, timezone_identifiers_list()))
@@ -270,8 +280,9 @@  discard block
 block discarded – undo
270 280
 		$dir = dir(dirname(__FILE__) . '/Themes/default/languages');
271 281
 		while ($entry = $dir->read())
272 282
 		{
273
-			if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php')
274
-				$incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12));
283
+			if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') {
284
+							$incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12));
285
+			}
275 286
 		}
276 287
 		$dir->close();
277 288
 	}
@@ -306,10 +317,11 @@  discard block
 block discarded – undo
306 317
 	}
307 318
 
308 319
 	// Override the language file?
309
-	if (isset($_GET['lang_file']))
310
-		$_SESSION['installer_temp_lang'] = $_GET['lang_file'];
311
-	elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file']))
312
-		$_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file'];
320
+	if (isset($_GET['lang_file'])) {
321
+			$_SESSION['installer_temp_lang'] = $_GET['lang_file'];
322
+	} elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) {
323
+			$_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file'];
324
+	}
313 325
 
314 326
 	// Make sure it exists, if it doesn't reset it.
315 327
 	if (!isset($_SESSION['installer_temp_lang']) || preg_match('~[^\\w_\\-.]~', $_SESSION['installer_temp_lang']) === 1 || !file_exists(dirname(__FILE__) . '/Themes/default/languages/' . $_SESSION['installer_temp_lang']))
@@ -318,8 +330,9 @@  discard block
 block discarded – undo
318 330
 		list ($_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
319 331
 
320 332
 		// If we have english and some other language, use the other language.  We Americans hate english :P.
321
-		if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1)
322
-			list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
333
+		if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) {
334
+					list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
335
+		}
323 336
 	}
324 337
 
325 338
 	// And now include the actual language file itself.
@@ -332,15 +345,18 @@  discard block
 block discarded – undo
332 345
 	global $db_prefix, $db_connection, $sourcedir, $smcFunc, $modSettings;
333 346
 	global $db_server, $db_passwd, $db_type, $db_name, $db_user, $db_persist;
334 347
 
335
-	if (empty($sourcedir))
336
-		$sourcedir = dirname(__FILE__) . '/Sources';
348
+	if (empty($sourcedir)) {
349
+			$sourcedir = dirname(__FILE__) . '/Sources';
350
+	}
337 351
 
338 352
 	// Need this to check whether we need the database password.
339 353
 	require(dirname(__FILE__) . '/Settings.php');
340
-	if (!defined('SMF'))
341
-		define('SMF', 1);
342
-	if (empty($smcFunc))
343
-		$smcFunc = array();
354
+	if (!defined('SMF')) {
355
+			define('SMF', 1);
356
+	}
357
+	if (empty($smcFunc)) {
358
+			$smcFunc = array();
359
+	}
344 360
 
345 361
 	$modSettings['disableQueryCheck'] = true;
346 362
 
@@ -348,8 +364,9 @@  discard block
 block discarded – undo
348 364
 	if (!$db_connection)
349 365
 	{
350 366
 		require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
351
-		if (version_compare(PHP_VERSION, '5', '<'))
352
-			require_once($sourcedir . '/Subs-Compat.php');
367
+		if (version_compare(PHP_VERSION, '5', '<')) {
368
+					require_once($sourcedir . '/Subs-Compat.php');
369
+		}
353 370
 
354 371
 		$db_options = array('persist' => $db_persist);
355 372
 		$port = '';
@@ -360,19 +377,20 @@  discard block
 block discarded – undo
360 377
 			if ($db_type == 'mysql')
361 378
 			{
362 379
 				$port = ((int) $_POST['db_port'] == ini_get($db_type . 'default_port')) ? '' : (int) $_POST['db_port'];
363
-			}
364
-			elseif ($db_type == 'postgresql')
380
+			} elseif ($db_type == 'postgresql')
365 381
 			{
366 382
 				// PostgreSQL doesn't have a default port setting in php.ini, so just check against the default
367 383
 				$port = ((int) $_POST['db_port'] == 5432) ? '' : (int) $_POST['db_port'];
368 384
 			}
369 385
 		}
370 386
 
371
-		if (!empty($port))
372
-			$db_options['port'] = $port;
387
+		if (!empty($port)) {
388
+					$db_options['port'] = $port;
389
+		}
373 390
 
374
-		if (!$db_connection)
375
-			$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options);
391
+		if (!$db_connection) {
392
+					$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options);
393
+		}
376 394
 	}
377 395
 }
378 396
 
@@ -400,8 +418,9 @@  discard block
 block discarded – undo
400 418
 		// @todo REMOVE THIS!!
401 419
 		else
402 420
 		{
403
-			if (function_exists('doStep' . $_GET['step']))
404
-				call_user_func('doStep' . $_GET['step']);
421
+			if (function_exists('doStep' . $_GET['step'])) {
422
+							call_user_func('doStep' . $_GET['step']);
423
+			}
405 424
 		}
406 425
 		// Show the footer.
407 426
 		template_install_below();
@@ -419,8 +438,9 @@  discard block
 block discarded – undo
419 438
 	$incontext['sub_template'] = 'welcome_message';
420 439
 
421 440
 	// Done the submission?
422
-	if (isset($_POST['contbutt']))
423
-		return true;
441
+	if (isset($_POST['contbutt'])) {
442
+			return true;
443
+	}
424 444
 
425 445
 	// See if we think they have already installed it?
426 446
 	if (is_readable(dirname(__FILE__) . '/Settings.php'))
@@ -428,14 +448,17 @@  discard block
 block discarded – undo
428 448
 		$probably_installed = 0;
429 449
 		foreach (file(dirname(__FILE__) . '/Settings.php') as $line)
430 450
 		{
431
-			if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line))
432
-				$probably_installed++;
433
-			if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line))
434
-				$probably_installed++;
451
+			if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) {
452
+							$probably_installed++;
453
+			}
454
+			if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) {
455
+							$probably_installed++;
456
+			}
435 457
 		}
436 458
 
437
-		if ($probably_installed == 2)
438
-			$incontext['warning'] = $txt['error_already_installed'];
459
+		if ($probably_installed == 2) {
460
+					$incontext['warning'] = $txt['error_already_installed'];
461
+		}
439 462
 	}
440 463
 
441 464
 	// Is some database support even compiled in?
@@ -450,45 +473,54 @@  discard block
 block discarded – undo
450 473
 				$databases[$key]['supported'] = false;
451 474
 				$notFoundSQLFile = true;
452 475
 				$txt['error_db_script_missing'] = sprintf($txt['error_db_script_missing'], 'install_' . $GLOBALS['db_script_version'] . '_' . $type . '.sql');
476
+			} else {
477
+							$incontext['supported_databases'][] = $db;
453 478
 			}
454
-			else
455
-				$incontext['supported_databases'][] = $db;
456 479
 		}
457 480
 	}
458 481
 
459 482
 	// Check the PHP version.
460
-	if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>=')))
461
-		$error = 'error_php_too_low';
483
+	if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) {
484
+			$error = 'error_php_too_low';
485
+	}
462 486
 	// Make sure we have a supported database
463
-	elseif (empty($incontext['supported_databases']))
464
-		$error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing';
487
+	elseif (empty($incontext['supported_databases'])) {
488
+			$error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing';
489
+	}
465 490
 	// How about session support?  Some crazy sysadmin remove it?
466
-	elseif (!function_exists('session_start'))
467
-		$error = 'error_session_missing';
491
+	elseif (!function_exists('session_start')) {
492
+			$error = 'error_session_missing';
493
+	}
468 494
 	// Make sure they uploaded all the files.
469
-	elseif (!file_exists(dirname(__FILE__) . '/index.php'))
470
-		$error = 'error_missing_files';
495
+	elseif (!file_exists(dirname(__FILE__) . '/index.php')) {
496
+			$error = 'error_missing_files';
497
+	}
471 498
 	// Very simple check on the session.save_path for Windows.
472 499
 	// @todo Move this down later if they don't use database-driven sessions?
473
-	elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\')
474
-		$error = 'error_session_save_path';
500
+	elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') {
501
+			$error = 'error_session_save_path';
502
+	}
475 503
 
476 504
 	// Since each of the three messages would look the same, anyway...
477
-	if (isset($error))
478
-		$incontext['error'] = $txt[$error];
505
+	if (isset($error)) {
506
+			$incontext['error'] = $txt[$error];
507
+	}
479 508
 
480 509
 	// Mod_security blocks everything that smells funny. Let SMF handle security.
481
-	if (!fixModSecurity() && !isset($_GET['overmodsecurity']))
482
-		$incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again'];
510
+	if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) {
511
+			$incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again'];
512
+	}
483 513
 
484 514
 	// Confirm mbstring is loaded...
485
-	if (!extension_loaded('mbstring'))
486
-		$incontext['error'] = $txt['install_no_mbstring'];
515
+	if (!extension_loaded('mbstring')) {
516
+			$incontext['error'] = $txt['install_no_mbstring'];
517
+	}
487 518
 
488 519
 	// Check for https stream support.
489 520
 	$supported_streams = stream_get_wrappers();
490
-	if (!in_array('https', $supported_streams))
491
-		$incontext['warning'] = $txt['install_no_https'];
521
+	if (!in_array('https', $supported_streams)) {
522
+			$incontext['warning'] = $txt['install_no_https'];
523
+	}
492 524
 
493 525
 	return false;
494 526
 }
@@ -514,12 +546,14 @@  discard block
 block discarded – undo
514 546
 		'db_last_error.php',
515 547
 	);
516 548
 
517
-	foreach ($incontext['detected_languages'] as $lang => $temp)
518
-		$extra_files[] = 'Themes/default/languages/' . $lang;
549
+	foreach ($incontext['detected_languages'] as $lang => $temp) {
550
+			$extra_files[] = 'Themes/default/languages/' . $lang;
551
+	}
519 552
 
520 553
 	// With mod_security installed, we could attempt to fix it with .htaccess.
521
-	if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules()))
522
-		$writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.';
554
+	if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) {
555
+			$writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.';
556
+	}
523 557
 
524 558
 	$failed_files = array();
525 559
 
@@ -531,20 +565,23 @@  discard block
 block discarded – undo
531 565
 		foreach ($writable_files as $file)
532 566
 		{
533 567
 			// Some files won't exist, try to address up front
534
-			if (!file_exists(dirname(__FILE__) . '/' . $file))
535
-				@touch(dirname(__FILE__) . '/' . $file);
568
+			if (!file_exists(dirname(__FILE__) . '/' . $file)) {
569
+							@touch(dirname(__FILE__) . '/' . $file);
570
+			}
536 571
 			// NOW do the writable check...
537 572
 			if (!is_writable(dirname(__FILE__) . '/' . $file))
538 573
 			{
539 574
 				@chmod(dirname(__FILE__) . '/' . $file, 0755);
540 575
 
541 576
 				// Well, 755 hopefully worked... if not, try 777.
542
-				if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777))
543
-					$failed_files[] = $file;
577
+				if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) {
578
+									$failed_files[] = $file;
579
+				}
544 580
 			}
545 581
 		}
546
-		foreach ($extra_files as $file)
547
-			@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
582
+		foreach ($extra_files as $file) {
583
+					@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
584
+		}
548 585
 	}
549 586
 	// Windows is trickier.  Let's try opening for r+...
550 587
 	else
@@ -554,30 +591,35 @@  discard block
 block discarded – undo
554 591
 		foreach ($writable_files as $file)
555 592
 		{
556 593
 			// Folders can't be opened for write... but the index.php in them can ;)
557
-			if (is_dir(dirname(__FILE__) . '/' . $file))
558
-				$file .= '/index.php';
594
+			if (is_dir(dirname(__FILE__) . '/' . $file)) {
595
+							$file .= '/index.php';
596
+			}
559 597
 
560 598
 			// Funny enough, chmod actually does do something on windows - it removes the read only attribute.
561 599
 			@chmod(dirname(__FILE__) . '/' . $file, 0777);
562 600
 			$fp = @fopen(dirname(__FILE__) . '/' . $file, 'r+');
563 601
 
564 602
 			// Hmm, okay, try just for write in that case...
565
-			if (!is_resource($fp))
566
-				$fp = @fopen(dirname(__FILE__) . '/' . $file, 'w');
603
+			if (!is_resource($fp)) {
604
+							$fp = @fopen(dirname(__FILE__) . '/' . $file, 'w');
605
+			}
567 606
 
568
-			if (!is_resource($fp))
569
-				$failed_files[] = $file;
607
+			if (!is_resource($fp)) {
608
+							$failed_files[] = $file;
609
+			}
570 610
 
571 611
 			@fclose($fp);
572 612
 		}
573
-		foreach ($extra_files as $file)
574
-			@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
613
+		foreach ($extra_files as $file) {
614
+					@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
615
+		}
575 616
 	}
576 617
 
577 618
 	$failure = count($failed_files) >= 1;
578 619
 
579
-	if (!isset($_SERVER))
580
-		return !$failure;
620
+	if (!isset($_SERVER)) {
621
+			return !$failure;
622
+	}
581 623
 
582 624
 	// Put the list into context.
583 625
 	$incontext['failed_files'] = $failed_files;
@@ -625,19 +667,23 @@  discard block
 block discarded – undo
625 667
 
626 668
 		if (!isset($ftp) || $ftp->error !== false)
627 669
 		{
628
-			if (!isset($ftp))
629
-				$ftp = new ftp_connection(null);
670
+			if (!isset($ftp)) {
671
+							$ftp = new ftp_connection(null);
672
+			}
630 673
 			// Save the error so we can mess with listing...
631
-			elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message))
632
-				$incontext['ftp_errors'][] = $ftp->last_message;
674
+			elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) {
675
+							$incontext['ftp_errors'][] = $ftp->last_message;
676
+			}
633 677
 
634 678
 			list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__));
635 679
 
636
-			if (empty($_POST['ftp_path']) && $found_path)
637
-				$_POST['ftp_path'] = $detect_path;
680
+			if (empty($_POST['ftp_path']) && $found_path) {
681
+							$_POST['ftp_path'] = $detect_path;
682
+			}
638 683
 
639
-			if (!isset($_POST['ftp_username']))
640
-				$_POST['ftp_username'] = $username;
684
+			if (!isset($_POST['ftp_username'])) {
685
+							$_POST['ftp_username'] = $username;
686
+			}
641 687
 
642 688
 			// Set the username etc, into context.
643 689
 			$incontext['ftp'] = array(
@@ -649,8 +695,7 @@  discard block
 block discarded – undo
649 695
 			);
650 696
 
651 697
 			return false;
652
-		}
653
-		else
698
+		} else
654 699
 		{
655 700
 			$_SESSION['installer_temp_ftp'] = array(
656 701
 				'server' => $_POST['ftp_server'],
@@ -664,10 +709,12 @@  discard block
 block discarded – undo
664 709
 
665 710
 			foreach ($failed_files as $file)
666 711
 			{
667
-				if (!is_writable(dirname(__FILE__) . '/' . $file))
668
-					$ftp->chmod($file, 0755);
669
-				if (!is_writable(dirname(__FILE__) . '/' . $file))
670
-					$ftp->chmod($file, 0777);
712
+				if (!is_writable(dirname(__FILE__) . '/' . $file)) {
713
+									$ftp->chmod($file, 0755);
714
+				}
715
+				if (!is_writable(dirname(__FILE__) . '/' . $file)) {
716
+									$ftp->chmod($file, 0777);
717
+				}
671 718
 				if (!is_writable(dirname(__FILE__) . '/' . $file))
672 719
 				{
673 720
 					$failed_files_updated[] = $file;
@@ -723,15 +770,17 @@  discard block
 block discarded – undo
723 770
 
724 771
 			if (!$foundOne)
725 772
 			{
726
-				if (isset($db['default_host']))
727
-					$incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost';
773
+				if (isset($db['default_host'])) {
774
+									$incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost';
775
+				}
728 776
 				if (isset($db['default_user']))
729 777
 				{
730 778
 					$incontext['db']['user'] = ini_get($db['default_user']);
731 779
 					$incontext['db']['name'] = ini_get($db['default_user']);
732 780
 				}
733
-				if (isset($db['default_password']))
734
-					$incontext['db']['pass'] = ini_get($db['default_password']);
781
+				if (isset($db['default_password'])) {
782
+									$incontext['db']['pass'] = ini_get($db['default_password']);
783
+				}
735 784
 
736 785
 				// For simplicity and less confusion, leave the port blank by default
737 786
 				$incontext['db']['port'] = '';
@@ -750,10 +799,10 @@  discard block
 block discarded – undo
750 799
 		$incontext['db']['server'] = $_POST['db_server'];
751 800
 		$incontext['db']['prefix'] = $_POST['db_prefix'];
752 801
 
753
-		if (!empty($_POST['db_port']))
754
-			$incontext['db']['port'] = $_POST['db_port'];
755
-	}
756
-	else
802
+		if (!empty($_POST['db_port'])) {
803
+					$incontext['db']['port'] = $_POST['db_port'];
804
+		}
805
+	} else
757 806
 	{
758 807
 		$incontext['db']['prefix'] = 'smf_';
759 808
 	}
@@ -789,10 +838,11 @@  discard block
 block discarded – undo
789 838
 		if (!empty($_POST['db_port']))
790 839
 		{
791 840
 			// For MySQL, we can get the "default port" from PHP. PostgreSQL has no such option though.
792
-			if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port'))
793
-				$vars['db_port'] = (int) $_POST['db_port'];
794
-			elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432)
795
-				$vars['db_port'] = (int) $_POST['db_port'];
841
+			if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) {
842
+							$vars['db_port'] = (int) $_POST['db_port'];
843
+			} elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) {
844
+							$vars['db_port'] = (int) $_POST['db_port'];
845
+			}
796 846
 		}
797 847
 
798 848
 		// God I hope it saved!
@@ -805,8 +855,9 @@  discard block
 block discarded – undo
805 855
 		// Make sure it works.
806 856
 		require(dirname(__FILE__) . '/Settings.php');
807 857
 
808
-		if (empty($sourcedir))
809
-			$sourcedir = dirname(__FILE__) . '/Sources';
858
+		if (empty($sourcedir)) {
859
+					$sourcedir = dirname(__FILE__) . '/Sources';
860
+		}
810 861
 
811 862
 		// Better find the database file!
812 863
 		if (!file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
@@ -816,18 +867,21 @@  discard block
 block discarded – undo
816 867
 		}
817 868
 
818 869
 		// Now include it for database functions!
819
-		if (!defined('SMF'))
820
-			define('SMF', 1);
870
+		if (!defined('SMF')) {
871
+					define('SMF', 1);
872
+		}
821 873
 
822 874
 		$modSettings['disableQueryCheck'] = true;
823
-		if (empty($smcFunc))
824
-			$smcFunc = array();
875
+		if (empty($smcFunc)) {
876
+					$smcFunc = array();
877
+		}
825 878
 
826 879
 			require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
827 880
 
828 881
 		// What - running PHP4? The shame!
829
-		if (version_compare(PHP_VERSION, '5', '<'))
830
-			require_once($sourcedir . '/Subs-Compat.php');
882
+		if (version_compare(PHP_VERSION, '5', '<')) {
883
+					require_once($sourcedir . '/Subs-Compat.php');
884
+		}
831 885
 
832 886
 		// Attempt a connection.
833 887
 		$needsDB = !empty($databases[$db_type]['always_has_db']);
@@ -915,12 +969,14 @@  discard block
 block discarded – undo
915 969
 	$incontext['page_title'] = $txt['install_settings'];
916 970
 
917 971
 	// Let's see if we got the database type correct.
918
-	if (isset($_POST['db_type'], $databases[$_POST['db_type']]))
919
-		$db_type = $_POST['db_type'];
972
+	if (isset($_POST['db_type'], $databases[$_POST['db_type']])) {
973
+			$db_type = $_POST['db_type'];
974
+	}
920 975
 
921 976
 	// Else we'd better be able to get the connection.
922
-	else
923
-		load_database();
977
+	else {
978
+			load_database();
979
+	}
924 980
 
925 981
 	$db_type = isset($_POST['db_type']) ? $_POST['db_type'] : $db_type;
926 982
 
@@ -940,12 +996,14 @@  discard block
 block discarded – undo
940 996
 	// Submitting?
941 997
 	if (isset($_POST['boardurl']))
942 998
 	{
943
-		if (substr($_POST['boardurl'], -10) == '/index.php')
944
-			$_POST['boardurl'] = substr($_POST['boardurl'], 0, -10);
945
-		elseif (substr($_POST['boardurl'], -1) == '/')
946
-			$_POST['boardurl'] = substr($_POST['boardurl'], 0, -1);
947
-		if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://')
948
-			$_POST['boardurl'] = 'http://' . $_POST['boardurl'];
999
+		if (substr($_POST['boardurl'], -10) == '/index.php') {
1000
+					$_POST['boardurl'] = substr($_POST['boardurl'], 0, -10);
1001
+		} elseif (substr($_POST['boardurl'], -1) == '/') {
1002
+					$_POST['boardurl'] = substr($_POST['boardurl'], 0, -1);
1003
+		}
1004
+		if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') {
1005
+					$_POST['boardurl'] = 'http://' . $_POST['boardurl'];
1006
+		}
949 1007
 
950 1008
 		// Save these variables.
951 1009
 		$vars = array(
@@ -984,10 +1042,10 @@  discard block
 block discarded – undo
984 1042
 			{
985 1043
 				$incontext['error'] = sprintf($txt['error_utf8_version'], $databases[$db_type]['utf8_version']);
986 1044
 				return false;
987
-			}
988
-			else
989
-				// Set the character set here.
1045
+			} else {
1046
+							// Set the character set here.
990 1047
 				updateSettingsFile(array('db_character_set' => 'utf8'));
1048
+			}
991 1049
 		}
992 1050
 
993 1051
 		// Good, skip on.
@@ -1007,8 +1065,9 @@  discard block
 block discarded – undo
1007 1065
 	$incontext['continue'] = 1;
1008 1066
 
1009 1067
 	// Already done?
1010
-	if (isset($_POST['pop_done']))
1011
-		return true;
1068
+	if (isset($_POST['pop_done'])) {
1069
+			return true;
1070
+	}
1012 1071
 
1013 1072
 	// Reload settings.
1014 1073
 	require(dirname(__FILE__) . '/Settings.php');
@@ -1026,8 +1085,9 @@  discard block
 block discarded – undo
1026 1085
 	$modSettings = array();
1027 1086
 	if ($result !== false)
1028 1087
 	{
1029
-		while ($row = $smcFunc['db_fetch_assoc']($result))
1030
-			$modSettings[$row['variable']] = $row['value'];
1088
+		while ($row = $smcFunc['db_fetch_assoc']($result)) {
1089
+					$modSettings[$row['variable']] = $row['value'];
1090
+		}
1031 1091
 		$smcFunc['db_free_result']($result);
1032 1092
 
1033 1093
 		// Do they match?  If so, this is just a refresh so charge on!
@@ -1040,20 +1100,22 @@  discard block
 block discarded – undo
1040 1100
 	$modSettings['disableQueryCheck'] = true;
1041 1101
 
1042 1102
 	// If doing UTF8, select it. PostgreSQL requires passing it as a string...
1043
-	if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support']))
1044
-		$smcFunc['db_query']('', '
1103
+	if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) {
1104
+			$smcFunc['db_query']('', '
1045 1105
 			SET NAMES {string:utf8}',
1046 1106
 			array(
1047 1107
 				'db_error_skip' => true,
1048 1108
 				'utf8' => 'utf8',
1049 1109
 			)
1050 1110
 		);
1111
+	}
1051 1112
 
1052 1113
 	// Windows likes to leave the trailing slash, which yields to C:\path\to\SMF\/attachments...
1053
-	if (substr(__DIR__, -1) == '\\')
1054
-		$attachdir = __DIR__ . 'attachments';
1055
-	else
1056
-		$attachdir = __DIR__ . '/attachments';
1114
+	if (substr(__DIR__, -1) == '\\') {
1115
+			$attachdir = __DIR__ . 'attachments';
1116
+	} else {
1117
+			$attachdir = __DIR__ . '/attachments';
1118
+	}
1057 1119
 
1058 1120
 	$replaces = array(
1059 1121
 		'{$db_prefix}' => $db_prefix,
@@ -1070,8 +1132,9 @@  discard block
 block discarded – undo
1070 1132
 
1071 1133
 	foreach ($txt as $key => $value)
1072 1134
 	{
1073
-		if (substr($key, 0, 8) == 'default_')
1074
-			$replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value);
1135
+		if (substr($key, 0, 8) == 'default_') {
1136
+					$replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value);
1137
+		}
1075 1138
 	}
1076 1139
 	$replaces['{$default_reserved_names}'] = strtr($replaces['{$default_reserved_names}'], array('\\\\n' => '\\n'));
1077 1140
 
@@ -1086,8 +1149,9 @@  discard block
 block discarded – undo
1086 1149
 
1087 1150
 		while ($row = $smcFunc['db_fetch_assoc']($get_engines))
1088 1151
 		{
1089
-			if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT')
1090
-				$engines[] = $row['Engine'];
1152
+			if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') {
1153
+							$engines[] = $row['Engine'];
1154
+			}
1091 1155
 		}
1092 1156
 
1093 1157
 		// Done with this now
@@ -1111,8 +1175,7 @@  discard block
 block discarded – undo
1111 1175
 			$replaces['START TRANSACTION;'] = '';
1112 1176
 			$replaces['COMMIT;'] = '';
1113 1177
 		}
1114
-	}
1115
-	else
1178
+	} else
1116 1179
 	{
1117 1180
 		$has_innodb = false;
1118 1181
 	}
@@ -1134,21 +1197,24 @@  discard block
 block discarded – undo
1134 1197
 	foreach ($sql_lines as $count => $line)
1135 1198
 	{
1136 1199
 		// No comments allowed!
1137
-		if (substr(trim($line), 0, 1) != '#')
1138
-			$current_statement .= "\n" . rtrim($line);
1200
+		if (substr(trim($line), 0, 1) != '#') {
1201
+					$current_statement .= "\n" . rtrim($line);
1202
+		}
1139 1203
 
1140 1204
 		// Is this the end of the query string?
1141
-		if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines)))
1142
-			continue;
1205
+		if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) {
1206
+					continue;
1207
+		}
1143 1208
 
1144 1209
 		// Does this table already exist?  If so, don't insert more data into it!
1145 1210
 		if (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) != 0 && in_array($match[1], $exists))
1146 1211
 		{
1147 1212
 			preg_match_all('~\)[,;]~', $current_statement, $matches);
1148
-			if (!empty($matches[0]))
1149
-				$incontext['sql_results']['insert_dups'] += count($matches[0]);
1150
-			else
1151
-				$incontext['sql_results']['insert_dups']++;
1213
+			if (!empty($matches[0])) {
1214
+							$incontext['sql_results']['insert_dups'] += count($matches[0]);
1215
+			} else {
1216
+							$incontext['sql_results']['insert_dups']++;
1217
+			}
1152 1218
 
1153 1219
 			$current_statement = '';
1154 1220
 			continue;
@@ -1157,8 +1223,9 @@  discard block
 block discarded – undo
1157 1223
 		if ($smcFunc['db_query']('', $current_statement, array('security_override' => true, 'db_error_skip' => true), $db_connection) === false)
1158 1224
 		{
1159 1225
 			// Use the appropriate function based on the DB type
1160
-			if ($db_type == 'mysql' || $db_type == 'mysqli')
1161
-				$db_errorno = $db_type . '_errno';
1226
+			if ($db_type == 'mysql' || $db_type == 'mysqli') {
1227
+							$db_errorno = $db_type . '_errno';
1228
+			}
1162 1229
 
1163 1230
 			// Error 1050: Table already exists!
1164 1231
 			// @todo Needs to be made better!
@@ -1173,18 +1240,18 @@  discard block
 block discarded – undo
1173 1240
 				// MySQLi requires a connection object. It's optional with MySQL and Postgres
1174 1241
 				$incontext['failures'][$count] = $smcFunc['db_error']($db_connection);
1175 1242
 			}
1176
-		}
1177
-		else
1243
+		} else
1178 1244
 		{
1179
-			if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1180
-				$incontext['sql_results']['tables']++;
1181
-			elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1245
+			if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) {
1246
+							$incontext['sql_results']['tables']++;
1247
+			} elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1182 1248
 			{
1183 1249
 				preg_match_all('~\)[,;]~', $current_statement, $matches);
1184
-				if (!empty($matches[0]))
1185
-					$incontext['sql_results']['inserts'] += count($matches[0]);
1186
-				else
1187
-					$incontext['sql_results']['inserts']++;
1250
+				if (!empty($matches[0])) {
1251
+									$incontext['sql_results']['inserts'] += count($matches[0]);
1252
+				} else {
1253
+									$incontext['sql_results']['inserts']++;
1254
+				}
1188 1255
 			}
1189 1256
 		}
1190 1257
 
@@ -1197,15 +1264,17 @@  discard block
 block discarded – undo
1197 1264
 	// Sort out the context for the SQL.
1198 1265
 	foreach ($incontext['sql_results'] as $key => $number)
1199 1266
 	{
1200
-		if ($number == 0)
1201
-			unset($incontext['sql_results'][$key]);
1202
-		else
1203
-			$incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number);
1267
+		if ($number == 0) {
1268
+					unset($incontext['sql_results'][$key]);
1269
+		} else {
1270
+					$incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number);
1271
+		}
1204 1272
 	}
1205 1273
 
1206 1274
 	// Make sure UTF will be used globally.
1207
-	if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8'])))
1208
-		$newSettings[] = array('global_character_set', 'UTF-8');
1275
+	if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) {
1276
+			$newSettings[] = array('global_character_set', 'UTF-8');
1277
+	}
1209 1278
 
1210 1279
 	// Maybe we can auto-detect better cookie settings?
1211 1280
 	preg_match('~^http[s]?://([^\.]+?)([^/]*?)(/.*)?$~', $boardurl, $matches);
@@ -1216,16 +1285,20 @@  discard block
 block discarded – undo
1216 1285
 		$globalCookies = false;
1217 1286
 
1218 1287
 		// Okay... let's see.  Using a subdomain other than www.? (not a perfect check.)
1219
-		if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www'))))
1220
-			$globalCookies = true;
1288
+		if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www')))) {
1289
+					$globalCookies = true;
1290
+		}
1221 1291
 		// If there's a / in the middle of the path, or it starts with ~... we want local.
1222
-		if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false))
1223
-			$localCookies = true;
1292
+		if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false)) {
1293
+					$localCookies = true;
1294
+		}
1224 1295
 
1225
-		if ($globalCookies)
1226
-			$newSettings[] = array('globalCookies', '1');
1227
-		if ($localCookies)
1228
-			$newSettings[] = array('localCookies', '1');
1296
+		if ($globalCookies) {
1297
+					$newSettings[] = array('globalCookies', '1');
1298
+		}
1299
+		if ($localCookies) {
1300
+					$newSettings[] = array('localCookies', '1');
1301
+		}
1229 1302
 	}
1230 1303
 
1231 1304
 	// Are we allowing stat collection?
@@ -1243,16 +1316,17 @@  discard block
 block discarded – undo
1243 1316
 			fwrite($fp, $out);
1244 1317
 
1245 1318
 			$return_data = '';
1246
-			while (!feof($fp))
1247
-				$return_data .= fgets($fp, 128);
1319
+			while (!feof($fp)) {
1320
+							$return_data .= fgets($fp, 128);
1321
+			}
1248 1322
 
1249 1323
 			fclose($fp);
1250 1324
 
1251 1325
 			// Get the unique site ID.
1252 1326
 			preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID);
1253 1327
 
1254
-			if (!empty($ID[1]))
1255
-				$smcFunc['db_insert']('replace',
1328
+			if (!empty($ID[1])) {
1329
+							$smcFunc['db_insert']('replace',
1256 1330
 					$db_prefix . 'settings',
1257 1331
 					array('variable' => 'string', 'value' => 'string'),
1258 1332
 					array(
@@ -1261,11 +1335,12 @@  discard block
 block discarded – undo
1261 1335
 					),
1262 1336
 					array('variable')
1263 1337
 				);
1338
+			}
1264 1339
 		}
1265 1340
 	}
1266 1341
 	// Don't remove stat collection unless we unchecked the box for real, not from the loop.
1267
-	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats']))
1268
-		$smcFunc['db_query']('', '
1342
+	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) {
1343
+			$smcFunc['db_query']('', '
1269 1344
 			DELETE FROM {db_prefix}settings
1270 1345
 			WHERE variable = {string:enable_sm_stats}',
1271 1346
 			array(
@@ -1273,20 +1348,23 @@  discard block
 block discarded – undo
1273 1348
 				'db_error_skip' => true,
1274 1349
 			)
1275 1350
 		);
1351
+	}
1276 1352
 
1277 1353
 	// Are we enabling SSL?
1278
-	if (!empty($_POST['force_ssl']))
1279
-		$newSettings[] = array('force_ssl', 2);
1354
+	if (!empty($_POST['force_ssl'])) {
1355
+			$newSettings[] = array('force_ssl', 2);
1356
+	}
1280 1357
 
1281 1358
 	// Setting a timezone is required.
1282 1359
 	if (!isset($modSettings['default_timezone']) && function_exists('date_default_timezone_set'))
1283 1360
 	{
1284 1361
 		// Get PHP's default timezone, if set
1285 1362
 		$ini_tz = ini_get('date.timezone');
1286
-		if (!empty($ini_tz))
1287
-			$timezone_id = $ini_tz;
1288
-		else
1289
-			$timezone_id = '';
1363
+		if (!empty($ini_tz)) {
1364
+					$timezone_id = $ini_tz;
1365
+		} else {
1366
+					$timezone_id = '';
1367
+		}
1290 1368
 
1291 1369
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
1292 1370
 		if (!in_array($timezone_id, timezone_identifiers_list()))
@@ -1295,8 +1373,9 @@  discard block
 block discarded – undo
1295 1373
 			$timezone_id = timezone_name_from_abbr('', $server_offset, 0);
1296 1374
 		}
1297 1375
 
1298
-		if (date_default_timezone_set($timezone_id))
1299
-			$newSettings[] = array('default_timezone', $timezone_id);
1376
+		if (date_default_timezone_set($timezone_id)) {
1377
+					$newSettings[] = array('default_timezone', $timezone_id);
1378
+		}
1300 1379
 	}
1301 1380
 
1302 1381
 	if (!empty($newSettings))
@@ -1327,16 +1406,18 @@  discard block
 block discarded – undo
1327 1406
 	}
1328 1407
 
1329 1408
 	// MySQL specific stuff
1330
-	if (substr($db_type, 0, 5) != 'mysql')
1331
-		return false;
1409
+	if (substr($db_type, 0, 5) != 'mysql') {
1410
+			return false;
1411
+	}
1332 1412
 
1333 1413
 	// Find database user privileges.
1334 1414
 	$privs = array();
1335 1415
 	$get_privs = $smcFunc['db_query']('', 'SHOW PRIVILEGES', array());
1336 1416
 	while ($row = $smcFunc['db_fetch_assoc']($get_privs))
1337 1417
 	{
1338
-		if ($row['Privilege'] == 'Alter')
1339
-			$privs[] = $row['Privilege'];
1418
+		if ($row['Privilege'] == 'Alter') {
1419
+					$privs[] = $row['Privilege'];
1420
+		}
1340 1421
 	}
1341 1422
 	$smcFunc['db_free_result']($get_privs);
1342 1423
 
@@ -1366,8 +1447,9 @@  discard block
 block discarded – undo
1366 1447
 	$incontext['continue'] = 1;
1367 1448
 
1368 1449
 	// Skipping?
1369
-	if (!empty($_POST['skip']))
1370
-		return true;
1450
+	if (!empty($_POST['skip'])) {
1451
+			return true;
1452
+	}
1371 1453
 
1372 1454
 	// Need this to check whether we need the database password.
1373 1455
 	require(dirname(__FILE__) . '/Settings.php');
@@ -1384,18 +1466,22 @@  discard block
 block discarded – undo
1384 1466
 	// We need this to properly hash the password for Admin
1385 1467
 	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) {
1386 1468
 			global $sourcedir;
1387
-			if (function_exists('mb_strtolower'))
1388
-				return mb_strtolower($string, 'UTF-8');
1469
+			if (function_exists('mb_strtolower')) {
1470
+							return mb_strtolower($string, 'UTF-8');
1471
+			}
1389 1472
 			require_once($sourcedir . '/Subs-Charset.php');
1390 1473
 			return utf8_strtolower($string);
1391 1474
 		};
1392 1475
 
1393
-	if (!isset($_POST['username']))
1394
-		$_POST['username'] = '';
1395
-	if (!isset($_POST['email']))
1396
-		$_POST['email'] = '';
1397
-	if (!isset($_POST['server_email']))
1398
-		$_POST['server_email'] = '';
1476
+	if (!isset($_POST['username'])) {
1477
+			$_POST['username'] = '';
1478
+	}
1479
+	if (!isset($_POST['email'])) {
1480
+			$_POST['email'] = '';
1481
+	}
1482
+	if (!isset($_POST['server_email'])) {
1483
+			$_POST['server_email'] = '';
1484
+	}
1399 1485
 
1400 1486
 	$incontext['username'] = htmlspecialchars(stripslashes($_POST['username']));
1401 1487
 	$incontext['email'] = htmlspecialchars(stripslashes($_POST['email']));
@@ -1414,8 +1500,9 @@  discard block
 block discarded – undo
1414 1500
 			'admin_group' => 1,
1415 1501
 		)
1416 1502
 	);
1417
-	if ($smcFunc['db_num_rows']($request) != 0)
1418
-		$incontext['skip'] = 1;
1503
+	if ($smcFunc['db_num_rows']($request) != 0) {
1504
+			$incontext['skip'] = 1;
1505
+	}
1419 1506
 	$smcFunc['db_free_result']($request);
1420 1507
 
1421 1508
 	// Trying to create an account?
@@ -1446,8 +1533,9 @@  discard block
 block discarded – undo
1446 1533
 		}
1447 1534
 
1448 1535
 		// Update the webmaster's email?
1449
-		if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]'))
1450
-			updateSettingsFile(array('webmaster_email' => $_POST['server_email']));
1536
+		if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) {
1537
+					updateSettingsFile(array('webmaster_email' => $_POST['server_email']));
1538
+		}
1451 1539
 
1452 1540
 		// Work out whether we're going to have dodgy characters and remove them.
1453 1541
 		$invalid_characters = preg_match('~[<>&"\'=\\\]~', $_POST['username']) != 0;
@@ -1470,32 +1558,27 @@  discard block
 block discarded – undo
1470 1558
 			$smcFunc['db_free_result']($result);
1471 1559
 
1472 1560
 			$incontext['account_existed'] = $txt['error_user_settings_taken'];
1473
-		}
1474
-		elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25)
1561
+		} elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25)
1475 1562
 		{
1476 1563
 			// Try the previous step again.
1477 1564
 			$incontext['error'] = $_POST['username'] == '' ? $txt['error_username_left_empty'] : $txt['error_username_too_long'];
1478 1565
 			return false;
1479
-		}
1480
-		elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false)
1566
+		} elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false)
1481 1567
 		{
1482 1568
 			// Try the previous step again.
1483 1569
 			$incontext['error'] = $txt['error_invalid_characters_username'];
1484 1570
 			return false;
1485
-		}
1486
-		elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255)
1571
+		} elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255)
1487 1572
 		{
1488 1573
 			// One step back, this time fill out a proper admin email address.
1489 1574
 			$incontext['error'] = sprintf($txt['error_valid_admin_email_needed'], $_POST['username']);
1490 1575
 			return false;
1491
-		}
1492
-		elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255)
1576
+		} elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255)
1493 1577
 		{
1494 1578
 			// One step back, this time fill out a proper admin email address.
1495 1579
 			$incontext['error'] = $txt['error_valid_server_email_needed'];
1496 1580
 			return false;
1497
-		}
1498
-		elseif ($_POST['username'] != '')
1581
+		} elseif ($_POST['username'] != '')
1499 1582
 		{
1500 1583
 			$incontext['member_salt'] = substr(md5(mt_rand()), 0, 4);
1501 1584
 
@@ -1563,17 +1646,19 @@  discard block
 block discarded – undo
1563 1646
 	reloadSettings();
1564 1647
 
1565 1648
 	// Bring a warning over.
1566
-	if (!empty($incontext['account_existed']))
1567
-		$incontext['warning'] = $incontext['account_existed'];
1649
+	if (!empty($incontext['account_existed'])) {
1650
+			$incontext['warning'] = $incontext['account_existed'];
1651
+	}
1568 1652
 
1569
-	if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support']))
1570
-		$smcFunc['db_query']('', '
1653
+	if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) {
1654
+			$smcFunc['db_query']('', '
1571 1655
 			SET NAMES {string:db_character_set}',
1572 1656
 			array(
1573 1657
 				'db_character_set' => $db_character_set,
1574 1658
 				'db_error_skip' => true,
1575 1659
 			)
1576 1660
 		);
1661
+	}
1577 1662
 
1578 1663
 	// As track stats is by default enabled let's add some activity.
1579 1664
 	$smcFunc['db_insert']('ignore',
@@ -1594,14 +1679,16 @@  discard block
 block discarded – undo
1594 1679
 	// Only proceed if we can load the data.
1595 1680
 	if ($request)
1596 1681
 	{
1597
-		while ($row = $smcFunc['db_fetch_row']($request))
1598
-			$modSettings[$row[0]] = $row[1];
1682
+		while ($row = $smcFunc['db_fetch_row']($request)) {
1683
+					$modSettings[$row[0]] = $row[1];
1684
+		}
1599 1685
 		$smcFunc['db_free_result']($request);
1600 1686
 	}
1601 1687
 
1602 1688
 	// Automatically log them in ;)
1603
-	if (isset($incontext['member_id']) && isset($incontext['member_salt']))
1604
-		setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt']));
1689
+	if (isset($incontext['member_id']) && isset($incontext['member_salt'])) {
1690
+			setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt']));
1691
+	}
1605 1692
 
1606 1693
 	$result = $smcFunc['db_query']('', '
1607 1694
 		SELECT value
@@ -1612,13 +1699,14 @@  discard block
 block discarded – undo
1612 1699
 			'db_error_skip' => true,
1613 1700
 		)
1614 1701
 	);
1615
-	if ($smcFunc['db_num_rows']($result) != 0)
1616
-		list ($db_sessions) = $smcFunc['db_fetch_row']($result);
1702
+	if ($smcFunc['db_num_rows']($result) != 0) {
1703
+			list ($db_sessions) = $smcFunc['db_fetch_row']($result);
1704
+	}
1617 1705
 	$smcFunc['db_free_result']($result);
1618 1706
 
1619
-	if (empty($db_sessions))
1620
-		$_SESSION['admin_time'] = time();
1621
-	else
1707
+	if (empty($db_sessions)) {
1708
+			$_SESSION['admin_time'] = time();
1709
+	} else
1622 1710
 	{
1623 1711
 		$_SERVER['HTTP_USER_AGENT'] = substr($_SERVER['HTTP_USER_AGENT'], 0, 211);
1624 1712
 
@@ -1642,8 +1730,9 @@  discard block
 block discarded – undo
1642 1730
 	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' :
1643 1731
 		function($string){
1644 1732
 			global $sourcedir;
1645
-			if (function_exists('mb_strtolower'))
1646
-				return mb_strtolower($string, 'UTF-8');
1733
+			if (function_exists('mb_strtolower')) {
1734
+							return mb_strtolower($string, 'UTF-8');
1735
+			}
1647 1736
 			require_once($sourcedir . '/Subs-Charset.php');
1648 1737
 			return utf8_strtolower($string);
1649 1738
 		};
@@ -1659,8 +1748,9 @@  discard block
 block discarded – undo
1659 1748
 		)
1660 1749
 	);
1661 1750
 	$context['utf8'] = $db_character_set === 'utf8' || $txt['lang_character_set'] === 'UTF-8';
1662
-	if ($smcFunc['db_num_rows']($request) > 0)
1663
-		updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject']));
1751
+	if ($smcFunc['db_num_rows']($request) > 0) {
1752
+			updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject']));
1753
+	}
1664 1754
 	$smcFunc['db_free_result']($request);
1665 1755
 
1666 1756
 	// Now is the perfect time to fetch the SM files.
@@ -1679,8 +1769,9 @@  discard block
 block discarded – undo
1679 1769
 
1680 1770
 	// Check if we need some stupid MySQL fix.
1681 1771
 	$server_version = $smcFunc['db_server_info']();
1682
-	if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51')))
1683
-		updateSettings(array('db_mysql_group_by_fix' => '1'));
1772
+	if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) {
1773
+			updateSettings(array('db_mysql_group_by_fix' => '1'));
1774
+	}
1684 1775
 
1685 1776
 	// Some final context for the template.
1686 1777
 	$incontext['dir_still_writable'] = is_writable(dirname(__FILE__)) && substr(__FILE__, 1, 2) != ':\\';
@@ -1700,8 +1791,9 @@  discard block
 block discarded – undo
1700 1791
 	$settingsArray = file(dirname(__FILE__) . '/Settings.php');
1701 1792
 
1702 1793
 	// @todo Do we just want to read the file in clean, and split it this way always?
1703
-	if (count($settingsArray) == 1)
1704
-		$settingsArray = preg_split('~[\r\n]~', $settingsArray[0]);
1794
+	if (count($settingsArray) == 1) {
1795
+			$settingsArray = preg_split('~[\r\n]~', $settingsArray[0]);
1796
+	}
1705 1797
 
1706 1798
 	for ($i = 0, $n = count($settingsArray); $i < $n; $i++)
1707 1799
 	{
@@ -1716,19 +1808,22 @@  discard block
 block discarded – undo
1716 1808
 			continue;
1717 1809
 		}
1718 1810
 
1719
-		if (trim($settingsArray[$i]) == '?' . '>')
1720
-			$settingsArray[$i] = '';
1811
+		if (trim($settingsArray[$i]) == '?' . '>') {
1812
+					$settingsArray[$i] = '';
1813
+		}
1721 1814
 
1722 1815
 		// Don't trim or bother with it if it's not a variable.
1723
-		if (substr($settingsArray[$i], 0, 1) != '$')
1724
-			continue;
1816
+		if (substr($settingsArray[$i], 0, 1) != '$') {
1817
+					continue;
1818
+		}
1725 1819
 
1726 1820
 		$settingsArray[$i] = rtrim($settingsArray[$i]) . "\n";
1727 1821
 
1728
-		foreach ($vars as $var => $val)
1729
-			if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0)
1822
+		foreach ($vars as $var => $val) {
1823
+					if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0)
1730 1824
 			{
1731 1825
 				$comment = strstr($settingsArray[$i], '#');
1826
+		}
1732 1827
 				$settingsArray[$i] = '$' . $var . ' = \'' . $val . '\';' . ($comment != '' ? "\t\t" . $comment : "\n");
1733 1828
 				unset($vars[$var]);
1734 1829
 			}
@@ -1738,36 +1833,41 @@  discard block
 block discarded – undo
1738 1833
 	if (!empty($vars))
1739 1834
 	{
1740 1835
 		$settingsArray[$i++] = '';
1741
-		foreach ($vars as $var => $val)
1742
-			$settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n";
1836
+		foreach ($vars as $var => $val) {
1837
+					$settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n";
1838
+		}
1743 1839
 	}
1744 1840
 
1745 1841
 	// Blank out the file - done to fix a oddity with some servers.
1746 1842
 	$fp = @fopen(dirname(__FILE__) . '/Settings.php', 'w');
1747
-	if (!$fp)
1748
-		return false;
1843
+	if (!$fp) {
1844
+			return false;
1845
+	}
1749 1846
 	fclose($fp);
1750 1847
 
1751 1848
 	$fp = fopen(dirname(__FILE__) . '/Settings.php', 'r+');
1752 1849
 
1753 1850
 	// Gotta have one of these ;)
1754
-	if (trim($settingsArray[0]) != '<?php')
1755
-		fwrite($fp, "<?php\n");
1851
+	if (trim($settingsArray[0]) != '<?php') {
1852
+			fwrite($fp, "<?php\n");
1853
+	}
1756 1854
 
1757 1855
 	$lines = count($settingsArray);
1758 1856
 	for ($i = 0; $i < $lines - 1; $i++)
1759 1857
 	{
1760 1858
 		// Don't just write a bunch of blank lines.
1761
-		if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '')
1762
-			fwrite($fp, strtr($settingsArray[$i], "\r", ''));
1859
+		if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') {
1860
+					fwrite($fp, strtr($settingsArray[$i], "\r", ''));
1861
+		}
1763 1862
 	}
1764 1863
 	fwrite($fp, $settingsArray[$i] . '?' . '>');
1765 1864
 	fclose($fp);
1766 1865
 
1767 1866
 	// Even though on normal installations the filemtime should prevent this being used by the installer incorrectly
1768 1867
 	// it seems that there are times it might not. So let's MAKE it dump the cache.
1769
-	if (function_exists('opcache_invalidate'))
1770
-		opcache_invalidate(dirname(__FILE__) . '/Settings.php', true);
1868
+	if (function_exists('opcache_invalidate')) {
1869
+			opcache_invalidate(dirname(__FILE__) . '/Settings.php', true);
1870
+	}
1771 1871
 
1772 1872
 	return true;
1773 1873
 }
@@ -1792,9 +1892,9 @@  discard block
 block discarded – undo
1792 1892
 	SecFilterScanPOST Off
1793 1893
 </IfModule>';
1794 1894
 
1795
-	if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules()))
1796
-		return true;
1797
-	elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess'))
1895
+	if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) {
1896
+			return true;
1897
+	} elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess'))
1798 1898
 	{
1799 1899
 		$current_htaccess = implode('', file(dirname(__FILE__) . '/.htaccess'));
1800 1900
 
@@ -1806,29 +1906,28 @@  discard block
 block discarded – undo
1806 1906
 				fwrite($ht_handle, $htaccess_addition);
1807 1907
 				fclose($ht_handle);
1808 1908
 				return true;
1909
+			} else {
1910
+							return false;
1809 1911
 			}
1810
-			else
1811
-				return false;
1912
+		} else {
1913
+					return true;
1812 1914
 		}
1813
-		else
1814
-			return true;
1815
-	}
1816
-	elseif (file_exists(dirname(__FILE__) . '/.htaccess'))
1817
-		return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false;
1818
-	elseif (is_writable(dirname(__FILE__)))
1915
+	} elseif (file_exists(dirname(__FILE__) . '/.htaccess')) {
1916
+			return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false;
1917
+	} elseif (is_writable(dirname(__FILE__)))
1819 1918
 	{
1820 1919
 		if ($ht_handle = fopen(dirname(__FILE__) . '/.htaccess', 'w'))
1821 1920
 		{
1822 1921
 			fwrite($ht_handle, $htaccess_addition);
1823 1922
 			fclose($ht_handle);
1824 1923
 			return true;
1924
+		} else {
1925
+					return false;
1825 1926
 		}
1826
-		else
1927
+	} else {
1827 1928
 			return false;
1828 1929
 	}
1829
-	else
1830
-		return false;
1831
-}
1930
+	}
1832 1931
 
1833 1932
 function template_install_above()
1834 1933
 {
@@ -1866,9 +1965,10 @@  discard block
 block discarded – undo
1866 1965
 								<label for="installer_language">', $txt['installer_language'], ':</label>
1867 1966
 								<select id="installer_language" name="lang_file" onchange="location.href = \'', $installurl, '?lang_file=\' + this.options[this.selectedIndex].value;">';
1868 1967
 
1869
-		foreach ($incontext['detected_languages'] as $lang => $name)
1870
-			echo '
1968
+		foreach ($incontext['detected_languages'] as $lang => $name) {
1969
+					echo '
1871 1970
 									<option', isset($_SESSION['installer_temp_lang']) && $_SESSION['installer_temp_lang'] == $lang ? ' selected' : '', ' value="', $lang, '">', $name, '</option>';
1971
+		}
1872 1972
 
1873 1973
 		echo '
1874 1974
 								</select>
@@ -1888,9 +1988,10 @@  discard block
 block discarded – undo
1888 1988
 						<h2>', $txt['upgrade_progress'], '</h2>
1889 1989
 						<ul>';
1890 1990
 
1891
-	foreach ($incontext['steps'] as $num => $step)
1892
-		echo '
1991
+	foreach ($incontext['steps'] as $num => $step) {
1992
+			echo '
1893 1993
 							<li class="', $num < $incontext['current_step'] ? 'stepdone' : ($num == $incontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>';
1994
+	}
1894 1995
 
1895 1996
 	echo '
1896 1997
 						</ul>
@@ -1915,20 +2016,23 @@  discard block
 block discarded – undo
1915 2016
 		echo '
1916 2017
 								<div>';
1917 2018
 
1918
-		if (!empty($incontext['continue']))
1919
-			echo '
2019
+		if (!empty($incontext['continue'])) {
2020
+					echo '
1920 2021
 									<input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '" onclick="return submitThisOnce(this);" class="button_submit" />';
1921
-		if (!empty($incontext['skip']))
1922
-			echo '
2022
+		}
2023
+		if (!empty($incontext['skip'])) {
2024
+					echo '
1923 2025
 									<input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="return submitThisOnce(this);" class="button_submit" />';
2026
+		}
1924 2027
 		echo '
1925 2028
 								</div>';
1926 2029
 	}
1927 2030
 
1928 2031
 	// Show the closing form tag and other data only if not in the last step
1929
-	if (count($incontext['steps']) - 1 !== (int) $incontext['current_step'])
1930
-		echo '
2032
+	if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) {
2033
+			echo '
1931 2034
 							</form>';
2035
+	}
1932 2036
 
1933 2037
 	echo '
1934 2038
 						</div>
@@ -1963,13 +2067,15 @@  discard block
 block discarded – undo
1963 2067
 		</div>';
1964 2068
 
1965 2069
 	// Show the warnings, or not.
1966
-	if (template_warning_divs())
1967
-		echo '
2070
+	if (template_warning_divs()) {
2071
+			echo '
1968 2072
 		<h3>', $txt['install_all_lovely'], '</h3>';
2073
+	}
1969 2074
 
1970 2075
 	// Say we want the continue button!
1971
-	if (empty($incontext['error']))
1972
-		$incontext['continue'] = 1;
2076
+	if (empty($incontext['error'])) {
2077
+			$incontext['continue'] = 1;
2078
+	}
1973 2079
 
1974 2080
 	// For the latest version stuff.
1975 2081
 	echo '
@@ -2003,8 +2109,8 @@  discard block
 block discarded – undo
2003 2109
 	global $txt, $incontext;
2004 2110
 
2005 2111
 	// Errors are very serious..
2006
-	if (!empty($incontext['error']))
2007
-		echo '
2112
+	if (!empty($incontext['error'])) {
2113
+			echo '
2008 2114
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
2009 2115
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
2010 2116
 			<strong style="text-decoration: underline;">', $txt['upgrade_critical_error'], '</strong><br>
@@ -2012,9 +2118,10 @@  discard block
 block discarded – undo
2012 2118
 				', $incontext['error'], '
2013 2119
 			</div>
2014 2120
 		</div>';
2121
+	}
2015 2122
 	// A warning message?
2016
-	elseif (!empty($incontext['warning']))
2017
-		echo '
2123
+	elseif (!empty($incontext['warning'])) {
2124
+			echo '
2018 2125
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
2019 2126
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
2020 2127
 			<strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br>
@@ -2022,6 +2129,7 @@  discard block
 block discarded – undo
2022 2129
 				', $incontext['warning'], '
2023 2130
 			</div>
2024 2131
 		</div>';
2132
+	}
2025 2133
 
2026 2134
 	return empty($incontext['error']) && empty($incontext['warning']);
2027 2135
 }
@@ -2037,27 +2145,30 @@  discard block
 block discarded – undo
2037 2145
 			<li>', $incontext['failed_files']), '</li>
2038 2146
 		</ul>';
2039 2147
 
2040
-	if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux')
2041
-		echo '
2148
+	if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') {
2149
+			echo '
2042 2150
 		<hr>
2043 2151
 		<p>', $txt['chmod_linux_info'], '</p>
2044 2152
 		<tt># chmod a+w ', implode(' ' . $incontext['detected_path'] . '/', $incontext['failed_files']), '</tt>';
2153
+	}
2045 2154
 
2046 2155
 	// This is serious!
2047
-	if (!template_warning_divs())
2048
-		return;
2156
+	if (!template_warning_divs()) {
2157
+			return;
2158
+	}
2049 2159
 
2050 2160
 	echo '
2051 2161
 		<hr>
2052 2162
 		<p>', $txt['ftp_setup_info'], '</p>';
2053 2163
 
2054
-	if (!empty($incontext['ftp_errors']))
2055
-		echo '
2164
+	if (!empty($incontext['ftp_errors'])) {
2165
+			echo '
2056 2166
 		<div class="error_message">
2057 2167
 			', $txt['error_ftp_no_connect'], '<br><br>
2058 2168
 			<code>', implode('<br>', $incontext['ftp_errors']), '</code>
2059 2169
 		</div>
2060 2170
 		<br>';
2171
+	}
2061 2172
 
2062 2173
 	echo '
2063 2174
 		<form action="', $incontext['form_url'], '" method="post">
@@ -2117,17 +2228,17 @@  discard block
 block discarded – undo
2117 2228
 				<td>
2118 2229
 					<select name="db_type" id="db_type_input" onchange="toggleDBInput();">';
2119 2230
 
2120
-	foreach ($incontext['supported_databases'] as $key => $db)
2121
-			echo '
2231
+	foreach ($incontext['supported_databases'] as $key => $db) {
2232
+				echo '
2122 2233
 						<option value="', $key, '"', isset($_POST['db_type']) && $_POST['db_type'] == $key ? ' selected' : '', '>', $db['name'], '</option>';
2234
+	}
2123 2235
 
2124 2236
 	echo '
2125 2237
 					</select>
2126 2238
 					<div class="smalltext block">', $txt['db_settings_type_info'], '</div>
2127 2239
 				</td>
2128 2240
 			</tr>';
2129
-	}
2130
-	else
2241
+	} else
2131 2242
 	{
2132 2243
 		echo '
2133 2244
 			<tr style="display: none;">
@@ -2319,9 +2430,10 @@  discard block
 block discarded – undo
2319 2430
 				<div style="color: red;">', $txt['error_db_queries'], '</div>
2320 2431
 				<ul>';
2321 2432
 
2322
-		foreach ($incontext['failures'] as $line => $fail)
2323
-			echo '
2433
+		foreach ($incontext['failures'] as $line => $fail) {
2434
+					echo '
2324 2435
 						<li><strong>', $txt['error_db_queries_line'], $line + 1, ':</strong> ', nl2br(htmlspecialchars($fail)), '</li>';
2436
+		}
2325 2437
 
2326 2438
 		echo '
2327 2439
 				</ul>';
@@ -2382,15 +2494,16 @@  discard block
 block discarded – undo
2382 2494
 			</tr>
2383 2495
 		</table>';
2384 2496
 
2385
-	if ($incontext['require_db_confirm'])
2386
-		echo '
2497
+	if ($incontext['require_db_confirm']) {
2498
+			echo '
2387 2499
 		<h2>', $txt['user_settings_database'], '</h2>
2388 2500
 		<p>', $txt['user_settings_database_info'], '</p>
2389 2501
 
2390 2502
 		<div style="margin-bottom: 2ex; padding-', $txt['lang_rtl'] == false ? 'left' : 'right', ': 50px;">
2391 2503
 			<input type="password" name="password3" size="30" />
2392 2504
 		</div>';
2393
-}
2505
+	}
2506
+	}
2394 2507
 
2395 2508
 // Tell them it's done, and to delete.
2396 2509
 function template_delete_install()
@@ -2403,14 +2516,15 @@  discard block
 block discarded – undo
2403 2516
 	template_warning_divs();
2404 2517
 
2405 2518
 	// Install directory still writable?
2406
-	if ($incontext['dir_still_writable'])
2407
-		echo '
2519
+	if ($incontext['dir_still_writable']) {
2520
+			echo '
2408 2521
 		<em>', $txt['still_writable'], '</em><br>
2409 2522
 		<br>';
2523
+	}
2410 2524
 
2411 2525
 	// Don't show the box if it's like 99% sure it won't work :P.
2412
-	if ($incontext['probably_delete_install'])
2413
-		echo '
2526
+	if ($incontext['probably_delete_install']) {
2527
+			echo '
2414 2528
 		<div style="margin: 1ex; font-weight: bold;">
2415 2529
 			<label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete();" /> ', $txt['delete_installer'], !isset($_SESSION['installer_temp_ftp']) ? ' ' . $txt['delete_installer_maybe'] : '', '</label>
2416 2530
 		</div>
@@ -2426,6 +2540,7 @@  discard block
 block discarded – undo
2426 2540
 			}
2427 2541
 		</script>
2428 2542
 		<br>';
2543
+	}
2429 2544
 
2430 2545
 	echo '
2431 2546
 		', sprintf($txt['go_to_your_forum'], $boardurl . '/index.php'), '<br>
Please login to merge, or discard this patch.
Themes/default/Profile.template.php 2 patches
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3031,8 +3031,7 @@
 block discarded – undo
3031 3031
 							<div class="roundframe">
3032 3032
 								<div>
3033 3033
 		', !empty($context['tfa_backup']) ? '
3034
-									<div class="smalltext error">' . $txt['tfa_backup_used_desc'] . '</div>' :
3035
-			($modSettings['tfa_mode'] == 2 ? '
3034
+									<div class="smalltext error">' . $txt['tfa_backup_used_desc'] . '</div>' : ($modSettings['tfa_mode'] == 2 ? '
3036 3035
 									<div class="smalltext"><strong>' . $txt['tfa_forced_desc'] . '</strong></div>' : ''), '
3037 3036
 									<div class="smalltext">', $txt['tfa_desc'], '</div>
3038 3037
 									<div id="basicinfo" style="width: 60%">
Please login to merge, or discard this patch.
Braces   +461 added lines, -344 removed lines patch added patch discarded remove patch
@@ -18,23 +18,25 @@  discard block
 block discarded – undo
18 18
 	global $context;
19 19
 
20 20
 	// Prevent Chrome from auto completing fields when viewing/editing other members profiles
21
-	if (isBrowser('is_chrome') && !$context['user']['is_owner'])
22
-		echo '
21
+	if (isBrowser('is_chrome') && !$context['user']['is_owner']) {
22
+			echo '
23 23
 	<script>
24 24
 		disableAutoComplete();
25 25
 	</script>';
26
+	}
26 27
 
27 28
 	// If an error occurred while trying to save previously, give the user a clue!
28 29
 	echo '
29 30
 					', template_error_message();
30 31
 
31 32
 	// If the profile was update successfully, let the user know this.
32
-	if (!empty($context['profile_updated']))
33
-		echo '
33
+	if (!empty($context['profile_updated'])) {
34
+			echo '
34 35
 					<div class="infobox">
35 36
 						', $context['profile_updated'], '
36 37
 					</div>';
37
-}
38
+	}
39
+	}
38 40
 
39 41
 /**
40 42
  * Template for any HTML needed below the profile (closing off divs/tables, etc.)
@@ -102,8 +104,7 @@  discard block
 block discarded – undo
102 104
 	if (empty($context['unread_alerts']))
103 105
 	{
104 106
 		template_alerts_all_read();
105
-	}
106
-	else
107
+	} else
107 108
 	{
108 109
 		foreach ($context['unread_alerts'] as $id_alert => $details)
109 110
 		{
@@ -164,10 +165,11 @@  discard block
 block discarded – undo
164 165
 			<div class="custom_fields_above_name">
165 166
 				<ul >';
166 167
 
167
-		foreach ($context['print_custom_fields']['above_member'] as $field)
168
-			if (!empty($field['output_html']))
168
+		foreach ($context['print_custom_fields']['above_member'] as $field) {
169
+					if (!empty($field['output_html']))
169 170
 				echo '
170 171
 					<li>', $field['output_html'], '</li>';
172
+		}
171 173
 
172 174
 		echo '
173 175
 				</ul>
@@ -188,10 +190,11 @@  discard block
 block discarded – undo
188 190
 			<div class="custom_fields_below_avatar">
189 191
 				<ul >';
190 192
 
191
-		foreach ($context['print_custom_fields']['below_avatar'] as $field)
192
-			if (!empty($field['output_html']))
193
+		foreach ($context['print_custom_fields']['below_avatar'] as $field) {
194
+					if (!empty($field['output_html']))
193 195
 				echo '
194 196
 					<li>', $field['output_html'], '</li>';
197
+		}
195 198
 
196 199
 		echo '
197 200
 				</ul>
@@ -202,22 +205,25 @@  discard block
 block discarded – undo
202 205
 		echo '
203 206
 			<ul class="clear">';
204 207
 	// Email is only visible if it's your profile or you have the moderate_forum permission
205
-	if ($context['member']['show_email'])
206
-		echo '
208
+	if ($context['member']['show_email']) {
209
+			echo '
207 210
 				<li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>';
211
+	}
208 212
 
209 213
 	// Don't show an icon if they haven't specified a website.
210
-	if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website']))
211
-		echo '
214
+	if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) {
215
+			echo '
212 216
 				<li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank" class="new_win">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>';
217
+	}
213 218
 
214 219
 	// Are there any custom profile fields as icons?
215 220
 	if (!empty($context['print_custom_fields']['icons']))
216 221
 	{
217
-		foreach ($context['print_custom_fields']['icons'] as $field)
218
-			if (!empty($field['output_html']))
222
+		foreach ($context['print_custom_fields']['icons'] as $field) {
223
+					if (!empty($field['output_html']))
219 224
 				echo '
220 225
 					<li class="custom_field">', $field['output_html'], '</li>';
226
+		}
221 227
 	}
222 228
 
223 229
 	echo '
@@ -225,23 +231,26 @@  discard block
 block discarded – undo
225 231
 			<span id="userstatus">', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : '';
226 232
 
227 233
 	// Can they add this member as a buddy?
228
-	if (!empty($context['can_have_buddy']) && !$context['user']['is_owner'])
229
-		echo '
234
+	if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) {
235
+			echo '
230 236
 				<br><a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">[', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], ']</a>';
237
+	}
231 238
 
232 239
 	echo '
233 240
 			</span>';
234 241
 
235
-	if (!$context['user']['is_owner'] && $context['can_send_pm'])
236
-		echo '
242
+	if (!$context['user']['is_owner'] && $context['can_send_pm']) {
243
+			echo '
237 244
 			<a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>';
245
+	}
238 246
 
239 247
 	echo '
240 248
 			<a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>';
241 249
 
242
-	if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled']))
243
-		echo '
250
+	if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) {
251
+			echo '
244 252
 			<a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>';
253
+	}
245 254
 
246 255
 	echo '
247 256
 			<a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>';
@@ -253,10 +262,11 @@  discard block
 block discarded – undo
253 262
 			<div class="custom_fields_bottom">
254 263
 				<ul class="nolist">';
255 264
 
256
-		foreach ($context['print_custom_fields']['bottom_poster'] as $field)
257
-			if (!empty($field['output_html']))
265
+		foreach ($context['print_custom_fields']['bottom_poster'] as $field) {
266
+					if (!empty($field['output_html']))
258 267
 				echo '
259 268
 					<li>', $field['output_html'], '</li>';
269
+		}
260 270
 
261 271
 		echo '
262 272
 				</ul>
@@ -270,15 +280,17 @@  discard block
 block discarded – undo
270 280
 		<div id="detailedinfo">
271 281
 			<dl class="settings">';
272 282
 
273
-	if ($context['user']['is_owner'] || $context['user']['is_admin'])
274
-		echo '
283
+	if ($context['user']['is_owner'] || $context['user']['is_admin']) {
284
+			echo '
275 285
 				<dt>', $txt['username'], ': </dt>
276 286
 				<dd>', $context['member']['username'], '</dd>';
287
+	}
277 288
 
278
-	if (!isset($context['disabled_fields']['posts']))
279
-		echo '
289
+	if (!isset($context['disabled_fields']['posts'])) {
290
+			echo '
280 291
 				<dt>', $txt['profile_posts'], ': </dt>
281 292
 				<dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>';
293
+	}
282 294
 
283 295
 	if ($context['member']['show_email'])
284 296
 	{
@@ -287,15 +299,17 @@  discard block
 block discarded – undo
287 299
 				<dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>';
288 300
 	}
289 301
 
290
-	if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title']))
291
-		echo '
302
+	if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) {
303
+			echo '
292 304
 				<dt>', $txt['custom_title'], ': </dt>
293 305
 				<dd>', $context['member']['title'], '</dd>';
306
+	}
294 307
 
295
-	if (!empty($context['member']['blurb']))
296
-		echo '
308
+	if (!empty($context['member']['blurb'])) {
309
+			echo '
297 310
 				<dt>', $txt['personal_text'], ': </dt>
298 311
 				<dd>', $context['member']['blurb'], '</dd>';
312
+	}
299 313
 
300 314
 	echo '
301 315
 				<dt>', $txt['age'], ':</dt>
@@ -310,11 +324,12 @@  discard block
 block discarded – undo
310 324
 		echo '
311 325
 				<dl class="settings">';
312 326
 
313
-		foreach ($context['print_custom_fields']['standard'] as $field)
314
-			if (!empty($field['output_html']))
327
+		foreach ($context['print_custom_fields']['standard'] as $field) {
328
+					if (!empty($field['output_html']))
315 329
 				echo '
316 330
 					<dt>', $field['name'], ':</dt>
317 331
 					<dd>', $field['output_html'], '</dd>';
332
+		}
318 333
 
319 334
 		echo '
320 335
 				</dl>';
@@ -332,9 +347,10 @@  discard block
 block discarded – undo
332 347
 						<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>';
333 348
 
334 349
 		// Can we provide information on what this means?
335
-		if (!empty($context['warning_status']))
336
-			echo '
350
+		if (!empty($context['warning_status'])) {
351
+					echo '
337 352
 						<span class="smalltext">(', $context['warning_status'], ')</span>';
353
+		}
338 354
 
339 355
 		echo '
340 356
 					</dd>';
@@ -345,9 +361,10 @@  discard block
 block discarded – undo
345 361
 	{
346 362
 
347 363
 		// If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves.
348
-		if (!empty($context['activate_message']))
349
-			echo '
364
+		if (!empty($context['activate_message'])) {
365
+					echo '
350 366
 					<dt class="clear"><span class="alert">', $context['activate_message'], '</span>&nbsp;(<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>)</dt>';
367
+		}
351 368
 
352 369
 		// If the current member is banned, show a message and possibly a link to the ban.
353 370
 		if (!empty($context['member']['bans']))
@@ -357,9 +374,10 @@  discard block
 block discarded – undo
357 374
 					<dt class="clear" id="ban_info" style="display: none;">
358 375
 						<strong>', $txt['user_banned_by_following'], ':</strong>';
359 376
 
360
-			foreach ($context['member']['bans'] as $ban)
361
-				echo '
377
+			foreach ($context['member']['bans'] as $ban) {
378
+							echo '
362 379
 						<br><span class="smalltext">', $ban['explanation'], '</span>';
380
+			}
363 381
 
364 382
 			echo '
365 383
 					</dt>';
@@ -373,30 +391,34 @@  discard block
 block discarded – undo
373 391
 	// If the person looking is allowed, they can check the members IP address and hostname.
374 392
 	if ($context['can_see_ip'])
375 393
 	{
376
-		if (!empty($context['member']['ip']))
377
-		echo '
394
+		if (!empty($context['member']['ip'])) {
395
+				echo '
378 396
 					<dt>', $txt['ip'], ': </dt>
379 397
 					<dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>';
398
+		}
380 399
 
381
-		if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip']))
382
-			echo '
400
+		if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) {
401
+					echo '
383 402
 					<dt>', $txt['hostname'], ': </dt>
384 403
 					<dd>', $context['member']['hostname'], '</dd>';
404
+		}
385 405
 	}
386 406
 
387 407
 	echo '
388 408
 					<dt>', $txt['local_time'], ':</dt>
389 409
 					<dd>', $context['member']['local_time'], '</dd>';
390 410
 
391
-	if (!empty($modSettings['userLanguage']) && !empty($context['member']['language']))
392
-		echo '
411
+	if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) {
412
+			echo '
393 413
 					<dt>', $txt['language'], ':</dt>
394 414
 					<dd>', $context['member']['language'], '</dd>';
415
+	}
395 416
 
396
-	if ($context['member']['show_last_login'])
397
-		echo '
417
+	if ($context['member']['show_last_login']) {
418
+			echo '
398 419
 					<dt>', $txt['lastLoggedIn'], ': </dt>
399 420
 					<dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>';
421
+	}
400 422
 
401 423
 	echo '
402 424
 				</dl>';
@@ -408,10 +430,11 @@  discard block
 block discarded – undo
408 430
 				<div class="custom_fields_above_signature">
409 431
 					<ul class="nolist">';
410 432
 
411
-		foreach ($context['print_custom_fields']['above_signature'] as $field)
412
-			if (!empty($field['output_html']))
433
+		foreach ($context['print_custom_fields']['above_signature'] as $field) {
434
+					if (!empty($field['output_html']))
413 435
 				echo '
414 436
 						<li>', $field['output_html'], '</li>';
437
+		}
415 438
 
416 439
 		echo '
417 440
 					</ul>
@@ -419,12 +442,13 @@  discard block
 block discarded – undo
419 442
 	}
420 443
 
421 444
 	// Show the users signature.
422
-	if ($context['signature_enabled'] && !empty($context['member']['signature']))
423
-		echo '
445
+	if ($context['signature_enabled'] && !empty($context['member']['signature'])) {
446
+			echo '
424 447
 				<div class="signature">
425 448
 					<h5>', $txt['signature'], ':</h5>
426 449
 					', $context['member']['signature'], '
427 450
 				</div>';
451
+	}
428 452
 
429 453
 	// Are there any custom profile fields for below the signature?
430 454
 	if (!empty($context['print_custom_fields']['below_signature']))
@@ -433,10 +457,11 @@  discard block
 block discarded – undo
433 457
 				<div class="custom_fields_below_signature">
434 458
 					<ul class="nolist">';
435 459
 
436
-		foreach ($context['print_custom_fields']['below_signature'] as $field)
437
-			if (!empty($field['output_html']))
460
+		foreach ($context['print_custom_fields']['below_signature'] as $field) {
461
+					if (!empty($field['output_html']))
438 462
 				echo '
439 463
 						<li>', $field['output_html'], '</li>';
464
+		}
440 465
 
441 466
 		echo '
442 467
 					</ul>
@@ -481,62 +506,70 @@  discard block
 block discarded – undo
481 506
 				</div>
482 507
 				<div class="list_posts">';
483 508
 
484
-			if (!$post['approved'])
485
-				echo '
509
+			if (!$post['approved']) {
510
+							echo '
486 511
 					<div class="approve_post">
487 512
 						<em>', $txt['post_awaiting_approval'], '</em>
488 513
 					</div>';
514
+			}
489 515
 
490 516
 			echo '
491 517
 					', $post['body'], '
492 518
 				</div>';
493 519
 
494
-			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete'])
495
-				echo '
520
+			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) {
521
+							echo '
496 522
 				<div class="floatright">
497 523
 					<ul class="quickbuttons">';
524
+			}
498 525
 
499 526
 			// If they *can* reply?
500
-			if ($post['can_reply'])
501
-				echo '
527
+			if ($post['can_reply']) {
528
+							echo '
502 529
 						<li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>';
530
+			}
503 531
 
504 532
 			// If they *can* quote?
505
-			if ($post['can_quote'])
506
-				echo '
533
+			if ($post['can_quote']) {
534
+							echo '
507 535
 						<li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>';
536
+			}
508 537
 
509 538
 			// How about... even... remove it entirely?!
510
-			if ($post['can_delete'])
511
-				echo '
539
+			if ($post['can_delete']) {
540
+							echo '
512 541
 						<li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>';
542
+			}
513 543
 
514
-			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete'])
515
-				echo '
544
+			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) {
545
+							echo '
516 546
 					</ul>
517 547
 				</div>';
548
+			}
518 549
 
519 550
 			echo '
520 551
 			</div>';
521 552
 		}
553
+	} else {
554
+			template_show_list('attachments');
522 555
 	}
523
-	else
524
-		template_show_list('attachments');
525 556
 
526 557
 	// No posts? Just end with a informative message.
527
-	if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts'])))
528
-		echo '
558
+	if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) {
559
+			echo '
529 560
 			<div class="windowbg2">
530 561
 				', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), '
531 562
 			</div>';
563
+	}
532 564
 
533 565
 	// Show more page numbers.
534
-	if (!empty($context['page_index']))
535
-		echo '
566
+	if (!empty($context['page_index'])) {
567
+			echo '
536 568
 		<div class="pagesection">
537 569
 			<div class="pagelinks">', $context['page_index'], '</div>
538 570
 		</div>';
539
-}
571
+	}
572
+	}
540 573
 
541 574
 /**
542 575
  * Template for showing alerts within the alerts popup
@@ -546,11 +579,12 @@  discard block
 block discarded – undo
546 579
 	global $context, $txt, $scripturl;
547 580
 
548 581
 	// Do we have an update message?
549
-	if (!empty($context['update_message']))
550
-		echo '
582
+	if (!empty($context['update_message'])) {
583
+			echo '
551 584
 		<div class="infobox">
552 585
 			', $context['update_message'], '.
553 586
 		</div>';
587
+	}
554 588
 
555 589
 	echo '
556 590
 		<div class="cat_bar">
@@ -559,13 +593,12 @@  discard block
 block discarded – undo
559 593
 			</h3>
560 594
 		</div>';
561 595
 
562
-	if (empty($context['alerts']))
563
-		echo '
596
+	if (empty($context['alerts'])) {
597
+			echo '
564 598
 		<div class="information">
565 599
 			', $txt['alerts_none'], '
566 600
 		</div>';
567
-
568
-	else
601
+	} else
569 602
 	{
570 603
 		// Start the form.
571 604
 		echo '
@@ -627,12 +660,12 @@  discard block
 block discarded – undo
627 660
 		</div>' : '';
628 661
 
629 662
 	// No drafts? Just show an informative message.
630
-	if (empty($context['drafts']))
631
-		echo '
663
+	if (empty($context['drafts'])) {
664
+			echo '
632 665
 		<div class="windowbg2 centertext">
633 666
 			', $txt['draft_none'], '
634 667
 		</div>';
635
-	else
668
+	} else
636 669
 	{
637 670
 		// For every draft to be displayed, give it its own div, and show the important details of the draft.
638 671
 		foreach ($context['drafts'] as $draft)
@@ -643,11 +676,13 @@  discard block
 block discarded – undo
643 676
 					<div class="topic_details">
644 677
 						<h5><strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> &nbsp; &nbsp;';
645 678
 
646
-			if (!empty($draft['sticky']))
647
-				echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>';
679
+			if (!empty($draft['sticky'])) {
680
+							echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>';
681
+			}
648 682
 
649
-			if (!empty($draft['locked']))
650
-				echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>';
683
+			if (!empty($draft['locked'])) {
684
+							echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>';
685
+			}
651 686
 
652 687
 			echo '
653 688
 						</h5>
@@ -680,12 +715,13 @@  discard block
 block discarded – undo
680 715
 {
681 716
 	global $context, $scripturl, $txt;
682 717
 
683
-	if (!empty($context['saved_successful']))
684
-		echo '
718
+	if (!empty($context['saved_successful'])) {
719
+			echo '
685 720
 					<div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>';
686
-	elseif (!empty($context['saved_failed']))
687
-		echo '
721
+	} elseif (!empty($context['saved_failed'])) {
722
+			echo '
688 723
 					<div class="errorbox">', $context['saved_failed'], '</div>';
724
+	}
689 725
 
690 726
 	echo '
691 727
 	<div id="edit_buddies">
@@ -699,24 +735,27 @@  discard block
 block discarded – undo
699 735
 				<th scope="col" class="quarter_table">', $txt['name'], '</th>
700 736
 				<th scope="col">', $txt['status'], '</th>';
701 737
 
702
-	if (allowedTo('moderate_forum'))
703
-		echo '
738
+	if (allowedTo('moderate_forum')) {
739
+			echo '
704 740
 				<th scope="col">', $txt['email'], '</th>';
741
+	}
705 742
 
706
-	if (!empty($context['custom_pf']))
707
-		foreach ($context['custom_pf'] as $column)
743
+	if (!empty($context['custom_pf'])) {
744
+			foreach ($context['custom_pf'] as $column)
708 745
 				echo '<th scope="col">', $column['label'], '</th>';
746
+	}
709 747
 
710 748
 	echo '
711 749
 				<th scope="col">', $txt['remove'], '</th>
712 750
 			</tr>';
713 751
 
714 752
 	// If they don't have any buddies don't list them!
715
-	if (empty($context['buddies']))
716
-		echo '
753
+	if (empty($context['buddies'])) {
754
+			echo '
717 755
 			<tr class="windowbg">
718 756
 				<td colspan="', allowedTo('moderate_forum') ? '10' : '9', '"><strong>', $txt['no_buddies'], '</strong></td>
719 757
 			</tr>';
758
+	}
720 759
 
721 760
 		// Now loop through each buddy showing info on each.
722 761
 	else
@@ -728,15 +767,17 @@  discard block
 block discarded – undo
728 767
 					<td>', $buddy['link'], '</td>
729 768
 					<td><a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a></td>';
730 769
 
731
-			if ($buddy['show_email'])
732
-				echo '
770
+			if ($buddy['show_email']) {
771
+							echo '
733 772
 					<td><a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a></td>';
773
+			}
734 774
 
735 775
 			// Show the custom profile fields for this user.
736
-			if (!empty($context['custom_pf']))
737
-				foreach ($context['custom_pf'] as $key => $column)
776
+			if (!empty($context['custom_pf'])) {
777
+							foreach ($context['custom_pf'] as $key => $column)
738 778
 					echo '
739 779
 						<td class="lefttext">', $buddy['options'][$key], '</td>';
780
+			}
740 781
 
741 782
 			echo '
742 783
 					<td><a href="', $scripturl, '?action=profile;area=lists;sa=buddies;u=', $context['id_member'], ';remove=', $buddy['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['buddy_remove'], '"></span></a></td>
@@ -766,9 +807,10 @@  discard block
 block discarded – undo
766 807
 			</dl>
767 808
 		</div>';
768 809
 
769
-	if (!empty($context['token_check']))
770
-		echo '
810
+	if (!empty($context['token_check'])) {
811
+			echo '
771 812
 			<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
813
+	}
772 814
 
773 815
 	echo '
774 816
 		<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -794,12 +836,13 @@  discard block
 block discarded – undo
794 836
 {
795 837
 	global $context, $scripturl, $txt;
796 838
 
797
-	if (!empty($context['saved_successful']))
798
-		echo '
839
+	if (!empty($context['saved_successful'])) {
840
+			echo '
799 841
 					<div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>';
800
-	elseif (!empty($context['saved_failed']))
801
-		echo '
842
+	} elseif (!empty($context['saved_failed'])) {
843
+			echo '
802 844
 					<div class="errorbox">', $context['saved_failed'], '</div>';
845
+	}
803 846
 
804 847
 	echo '
805 848
 	<div id="edit_buddies">
@@ -813,20 +856,22 @@  discard block
 block discarded – undo
813 856
 				<th scope="col" class="quarter_table">', $txt['name'], '</th>
814 857
 				<th scope="col">', $txt['status'], '</th>';
815 858
 
816
-	if (allowedTo('moderate_forum'))
817
-		echo '
859
+	if (allowedTo('moderate_forum')) {
860
+			echo '
818 861
 				<th scope="col">', $txt['email'], '</th>';
862
+	}
819 863
 
820 864
 	echo '
821 865
 				<th scope="col">', $txt['ignore_remove'], '</th>
822 866
 			</tr>';
823 867
 
824 868
 	// If they don't have anyone on their ignore list, don't list it!
825
-	if (empty($context['ignore_list']))
826
-		echo '
869
+	if (empty($context['ignore_list'])) {
870
+			echo '
827 871
 			<tr class="windowbg">
828 872
 				<td colspan="', allowedTo('moderate_forum') ? '4' : '3', '"><strong>', $txt['no_ignore'], '</strong></td>
829 873
 			</tr>';
874
+	}
830 875
 
831 876
 	// Now loop through each buddy showing info on each.
832 877
 	foreach ($context['ignore_list'] as $member)
@@ -836,9 +881,10 @@  discard block
 block discarded – undo
836 881
 				<td>', $member['link'], '</td>
837 882
 				<td><a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a></td>';
838 883
 
839
-		if ($member['show_email'])
840
-			echo '
884
+		if ($member['show_email']) {
885
+					echo '
841 886
 				<td><a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a></td>';
887
+		}
842 888
 		echo '
843 889
 				<td><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a></td>
844 890
 			</tr>';
@@ -865,9 +911,10 @@  discard block
 block discarded – undo
865 911
 			</dl>
866 912
 		</div>';
867 913
 
868
-	if (!empty($context['token_check']))
869
-		echo '
914
+	if (!empty($context['token_check'])) {
915
+			echo '
870 916
 		<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
917
+	}
871 918
 
872 919
 	echo '
873 920
 		<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -912,9 +959,10 @@  discard block
 block discarded – undo
912 959
 					<a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>';
913 960
 
914 961
 	// Second address detected?
915
-	if (!empty($context['last_ip2']))
916
-		echo '
962
+	if (!empty($context['last_ip2'])) {
963
+			echo '
917 964
 					, <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>';
965
+	}
918 966
 
919 967
 	echo '
920 968
 				</dd>';
@@ -979,9 +1027,10 @@  discard block
 block discarded – undo
979 1027
 				<h3 class="catbg">', $txt['whois_title'], ' ', $context['ip'], '</h3>
980 1028
 			</div>
981 1029
 			<div class="windowbg2 noup">';
982
-			foreach ($context['whois_servers'] as $server)
983
-			echo '
1030
+			foreach ($context['whois_servers'] as $server) {
1031
+						echo '
984 1032
 				<a href="', $server['url'], '" target="_blank" class="new_win"', isset($context['auto_whois_server']) && $context['auto_whois_server']['name'] == $server['name'] ? ' style="font-weight: bold;"' : '', '>', $server['name'], '</a><br>';
1033
+			}
985 1034
 			echo '
986 1035
 			</div>
987 1036
 			<br>';
@@ -992,10 +1041,10 @@  discard block
 block discarded – undo
992 1041
 		<div class="cat_bar">
993 1042
 			<h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3>
994 1043
 		</div>';
995
-	if (empty($context['ips']))
996
-		echo '
1044
+	if (empty($context['ips'])) {
1045
+			echo '
997 1046
 		<p class="windowbg2 description"><em>', $txt['no_members_from_ip'], '</em></p>';
998
-	else
1047
+	} else
999 1048
 	{
1000 1049
 		echo '
1001 1050
 		<table class="table_grid">
@@ -1008,12 +1057,13 @@  discard block
 block discarded – undo
1008 1057
 			<tbody>';
1009 1058
 
1010 1059
 		// Loop through each of the members and display them.
1011
-		foreach ($context['ips'] as $ip => $memberlist)
1012
-			echo '
1060
+		foreach ($context['ips'] as $ip => $memberlist) {
1061
+					echo '
1013 1062
 				<tr class="windowbg">
1014 1063
 					<td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td>
1015 1064
 					<td>', implode(', ', $memberlist), '</td>
1016 1065
 				</tr>';
1066
+		}
1017 1067
 
1018 1068
 		echo '
1019 1069
 			</tbody>
@@ -1059,8 +1109,7 @@  discard block
 block discarded – undo
1059 1109
 	{
1060 1110
 		echo '
1061 1111
 		<div class="information">', $txt['showPermissions_all'], '</div>';
1062
-	}
1063
-	else
1112
+	} else
1064 1113
 	{
1065 1114
 		echo '
1066 1115
 		<div class="information">',$txt['showPermissions_help'], '</div>
@@ -1074,9 +1123,10 @@  discard block
 block discarded – undo
1074 1123
 				</div>
1075 1124
 				<div class="windowbg smalltext">
1076 1125
 					', $txt['showPermissions_restricted_boards_desc'], ':<br>';
1077
-				foreach ($context['no_access_boards'] as $no_access_board)
1078
-					echo '
1126
+				foreach ($context['no_access_boards'] as $no_access_board) {
1127
+									echo '
1079 1128
 						<a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', ';
1129
+				}
1080 1130
 				echo '
1081 1131
 				</div>';
1082 1132
 		}
@@ -1108,12 +1158,13 @@  discard block
 block discarded – undo
1108 1158
 								</td>
1109 1159
 								<td class="smalltext">';
1110 1160
 
1111
-				if ($permission['is_denied'])
1112
-					echo '
1161
+				if ($permission['is_denied']) {
1162
+									echo '
1113 1163
 									<span class="alert">', $txt['showPermissions_denied'], ':&nbsp;', implode(', ', $permission['groups']['denied']), '</span>';
1114
-				else
1115
-					echo '
1164
+				} else {
1165
+									echo '
1116 1166
 									', $txt['showPermissions_given'], ':&nbsp;', implode(', ', $permission['groups']['allowed']);
1167
+				}
1117 1168
 
1118 1169
 					echo '
1119 1170
 								</td>
@@ -1123,10 +1174,10 @@  discard block
 block discarded – undo
1123 1174
 						</tbody>
1124 1175
 					</table>
1125 1176
 				</div><br>';
1126
-		}
1127
-		else
1128
-			echo '
1177
+		} else {
1178
+					echo '
1129 1179
 			<p class="windowbg2">', $txt['showPermissions_none_general'], '</p>';
1180
+		}
1130 1181
 
1131 1182
 		// Board permission section.
1132 1183
 		echo '
@@ -1136,14 +1187,16 @@  discard block
 block discarded – undo
1136 1187
 						<a id="board_permissions"></a>', $txt['showPermissions_select'], ':
1137 1188
 						<select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();">
1138 1189
 							<option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], '&nbsp;</option>';
1139
-				if (!empty($context['boards']))
1140
-					echo '
1190
+				if (!empty($context['boards'])) {
1191
+									echo '
1141 1192
 							<option value="" disabled>---------------------------</option>';
1193
+				}
1142 1194
 
1143 1195
 				// Fill the box with any local permission boards.
1144
-				foreach ($context['boards'] as $board)
1145
-					echo '
1196
+				foreach ($context['boards'] as $board) {
1197
+									echo '
1146 1198
 							<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>';
1199
+				}
1147 1200
 
1148 1201
 				echo '
1149 1202
 						</select>
@@ -1174,8 +1227,7 @@  discard block
 block discarded – undo
1174 1227
 				{
1175 1228
 					echo '
1176 1229
 							<span class="alert">', $txt['showPermissions_denied'], ':&nbsp;', implode(', ', $permission['groups']['denied']), '</span>';
1177
-				}
1178
-				else
1230
+				} else
1179 1231
 				{
1180 1232
 					echo '
1181 1233
 							', $txt['showPermissions_given'], ': &nbsp;', implode(', ', $permission['groups']['allowed']);
@@ -1187,10 +1239,10 @@  discard block
 block discarded – undo
1187 1239
 			echo '
1188 1240
 				</tbody>
1189 1241
 			</table>';
1190
-		}
1191
-		else
1192
-			echo '
1242
+		} else {
1243
+					echo '
1193 1244
 			<p class="windowbg2">', $txt['showPermissions_none_board'], '</p>';
1245
+		}
1194 1246
 	echo '
1195 1247
 			</div>
1196 1248
 		</div>';
@@ -1232,9 +1284,10 @@  discard block
 block discarded – undo
1232 1284
 			</div>';
1233 1285
 
1234 1286
 	// If they haven't post at all, don't draw the graph.
1235
-	if (empty($context['posts_by_time']))
1236
-		echo '
1287
+	if (empty($context['posts_by_time'])) {
1288
+			echo '
1237 1289
 			<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1290
+	}
1238 1291
 	// Otherwise do!
1239 1292
 	else
1240 1293
 	{
@@ -1273,11 +1326,10 @@  discard block
 block discarded – undo
1273 1326
 					</h3>
1274 1327
 				</div>';
1275 1328
 
1276
-	if (empty($context['popular_boards']))
1277
-		echo '
1329
+	if (empty($context['popular_boards'])) {
1330
+			echo '
1278 1331
 				<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1279
-
1280
-	else
1332
+	} else
1281 1333
 	{
1282 1334
 		echo '
1283 1335
 				<dl class="stats">';
@@ -1308,10 +1360,10 @@  discard block
 block discarded – undo
1308 1360
 					</h3>
1309 1361
 				</div>';
1310 1362
 
1311
-	if (empty($context['board_activity']))
1312
-		echo '
1363
+	if (empty($context['board_activity'])) {
1364
+			echo '
1313 1365
 				<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1314
-	else
1366
+	} else
1315 1367
 	{
1316 1368
 		echo '
1317 1369
 				<dl class="stats">';
@@ -1359,41 +1411,46 @@  discard block
 block discarded – undo
1359 1411
 				<h3 class="catbg profile_hd">';
1360 1412
 
1361 1413
 		// Don't say "Profile" if this isn't the profile...
1362
-		if (!empty($context['profile_header_text']))
1363
-			echo '
1414
+		if (!empty($context['profile_header_text'])) {
1415
+					echo '
1364 1416
 					', $context['profile_header_text'];
1365
-		else
1366
-			echo '
1417
+		} else {
1418
+					echo '
1367 1419
 					', $txt['profile'];
1420
+		}
1368 1421
 
1369 1422
 		echo '
1370 1423
 				</h3>
1371 1424
 			</div>';
1372 1425
 
1373 1426
 	// Have we some description?
1374
-	if ($context['page_desc'])
1375
-		echo '
1427
+	if ($context['page_desc']) {
1428
+			echo '
1376 1429
 			<p class="information">', $context['page_desc'], '</p>';
1430
+	}
1377 1431
 
1378 1432
 	echo '
1379 1433
 			<div class="roundframe">';
1380 1434
 
1381 1435
 	// Any bits at the start?
1382
-	if (!empty($context['profile_prehtml']))
1383
-		echo '
1436
+	if (!empty($context['profile_prehtml'])) {
1437
+			echo '
1384 1438
 				<div>', $context['profile_prehtml'], '</div>';
1439
+	}
1385 1440
 
1386
-	if (!empty($context['profile_fields']))
1387
-		echo '
1441
+	if (!empty($context['profile_fields'])) {
1442
+			echo '
1388 1443
 				<dl class="settings">';
1444
+	}
1389 1445
 
1390 1446
 	// Start the big old loop 'of love.
1391 1447
 	$lastItem = 'hr';
1392 1448
 	foreach ($context['profile_fields'] as $key => $field)
1393 1449
 	{
1394 1450
 		// We add a little hack to be sure we never get more than one hr in a row!
1395
-		if ($lastItem == 'hr' && $field['type'] == 'hr')
1396
-			continue;
1451
+		if ($lastItem == 'hr' && $field['type'] == 'hr') {
1452
+					continue;
1453
+		}
1397 1454
 
1398 1455
 		$lastItem = $field['type'];
1399 1456
 		if ($field['type'] == 'hr')
@@ -1402,48 +1459,50 @@  discard block
 block discarded – undo
1402 1459
 				</dl>
1403 1460
 				<hr>
1404 1461
 				<dl class="settings">';
1405
-		}
1406
-		elseif ($field['type'] == 'callback')
1462
+		} elseif ($field['type'] == 'callback')
1407 1463
 		{
1408 1464
 			if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func']))
1409 1465
 			{
1410 1466
 				$callback_func = 'template_profile_' . $field['callback_func'];
1411 1467
 				$callback_func();
1412 1468
 			}
1413
-		}
1414
-		else
1469
+		} else
1415 1470
 		{
1416 1471
 			echo '
1417 1472
 					<dt>
1418 1473
 						<strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>';
1419 1474
 
1420 1475
 			// Does it have any subtext to show?
1421
-			if (!empty($field['subtext']))
1422
-				echo '
1476
+			if (!empty($field['subtext'])) {
1477
+							echo '
1423 1478
 						<br>
1424 1479
 						<span class="smalltext">', $field['subtext'], '</span>';
1480
+			}
1425 1481
 
1426 1482
 			echo '
1427 1483
 					</dt>
1428 1484
 					<dd>';
1429 1485
 
1430 1486
 			// Want to put something infront of the box?
1431
-			if (!empty($field['preinput']))
1432
-				echo '
1487
+			if (!empty($field['preinput'])) {
1488
+							echo '
1433 1489
 						', $field['preinput'];
1490
+			}
1434 1491
 
1435 1492
 			// What type of data are we showing?
1436
-			if ($field['type'] == 'label')
1437
-				echo '
1493
+			if ($field['type'] == 'label') {
1494
+							echo '
1438 1495
 						', $field['value'];
1496
+			}
1439 1497
 
1440 1498
 			// Maybe it's a text box - very likely!
1441 1499
 			elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url')))
1442 1500
 			{
1443
-				if ($field['type'] == 'int' || $field['type'] == 'float')
1444
-					$type = 'number';
1445
-				else
1446
-					$type = $field['type'];
1501
+				if ($field['type'] == 'int' || $field['type'] == 'float') {
1502
+									$type = 'number';
1503
+				} else {
1504
+									$type = $field['type'];
1505
+				}
1447 1506
 				$step = $field['type'] == 'float' ? ' step="0.1"' : '';
1448 1507
 
1449 1508
 
@@ -1451,9 +1510,10 @@  discard block
 block discarded – undo
1451 1510
 						<input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' ', $step, '>';
1452 1511
 			}
1453 1512
 			// You "checking" me out? ;)
1454
-			elseif ($field['type'] == 'check')
1455
-				echo '
1513
+			elseif ($field['type'] == 'check') {
1514
+							echo '
1456 1515
 						<input type="hidden" name="', $key, '" value="0"><input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" ', $field['input_attr'], '>';
1516
+			}
1457 1517
 
1458 1518
 			// Always fun - select boxes!
1459 1519
 			elseif ($field['type'] == 'select')
@@ -1464,13 +1524,15 @@  discard block
 block discarded – undo
1464 1524
 				if (isset($field['options']))
1465 1525
 				{
1466 1526
 					// Is this some code to generate the options?
1467
-					if (!is_array($field['options']))
1468
-						$field['options'] = $field['options']();
1527
+					if (!is_array($field['options'])) {
1528
+											$field['options'] = $field['options']();
1529
+					}
1469 1530
 					// Assuming we now have some!
1470
-					if (is_array($field['options']))
1471
-						foreach ($field['options'] as $value => $name)
1531
+					if (is_array($field['options'])) {
1532
+											foreach ($field['options'] as $value => $name)
1472 1533
 							echo '
1473 1534
 								<option value="', $value, '"', $value == $field['value'] ? ' selected' : '', '>', $name, '</option>';
1535
+					}
1474 1536
 				}
1475 1537
 
1476 1538
 				echo '
@@ -1478,25 +1540,28 @@  discard block
 block discarded – undo
1478 1540
 			}
1479 1541
 
1480 1542
 			// Something to end with?
1481
-			if (!empty($field['postinput']))
1482
-				echo '
1543
+			if (!empty($field['postinput'])) {
1544
+							echo '
1483 1545
 							', $field['postinput'];
1546
+			}
1484 1547
 
1485 1548
 			echo '
1486 1549
 					</dd>';
1487 1550
 		}
1488 1551
 	}
1489 1552
 
1490
-	if (!empty($context['profile_fields']))
1491
-		echo '
1553
+	if (!empty($context['profile_fields'])) {
1554
+			echo '
1492 1555
 				</dl>';
1556
+	}
1493 1557
 
1494 1558
 	// Are there any custom profile fields - if so print them!
1495 1559
 	if (!empty($context['custom_fields']))
1496 1560
 	{
1497
-		if ($lastItem != 'hr')
1498
-			echo '
1561
+		if ($lastItem != 'hr') {
1562
+					echo '
1499 1563
 				<hr>';
1564
+		}
1500 1565
 
1501 1566
 		echo '
1502 1567
 				<dl class="settings">';
@@ -1519,13 +1584,14 @@  discard block
 block discarded – undo
1519 1584
 	}
1520 1585
 
1521 1586
 	// Any closing HTML?
1522
-	if (!empty($context['profile_posthtml']))
1523
-		echo '
1587
+	if (!empty($context['profile_posthtml'])) {
1588
+			echo '
1524 1589
 				<div>', $context['profile_posthtml'], '</div>';
1590
+	}
1525 1591
 
1526 1592
 	// Only show the password box if it's actually needed.
1527
-	if ($context['require_password'])
1528
-		echo '
1593
+	if ($context['require_password']) {
1594
+			echo '
1529 1595
 				<dl class="settings">
1530 1596
 					<dt>
1531 1597
 						<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br>
@@ -1535,18 +1601,21 @@  discard block
 block discarded – undo
1535 1601
 						<input type="password" name="oldpasswrd" id="oldpasswrd" size="20" style="margin-right: 4ex;">
1536 1602
 					</dd>
1537 1603
 				</dl>';
1604
+	}
1538 1605
 
1539 1606
 	// The button shouldn't say "Change profile" unless we're changing the profile...
1540
-	if (!empty($context['submit_button_text']))
1541
-		echo '
1607
+	if (!empty($context['submit_button_text'])) {
1608
+			echo '
1542 1609
 				<input type="submit" name="save" value="', $context['submit_button_text'], '" class="button_submit">';
1543
-	else
1544
-		echo '
1610
+	} else {
1611
+			echo '
1545 1612
 				<input type="submit" name="save" value="', $txt['change_profile'], '" class="button_submit">';
1613
+	}
1546 1614
 
1547
-	if (!empty($context['token_check']))
1548
-		echo '
1615
+	if (!empty($context['token_check'])) {
1616
+			echo '
1549 1617
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
1618
+	}
1550 1619
 
1551 1620
 	echo '
1552 1621
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -1556,10 +1625,11 @@  discard block
 block discarded – undo
1556 1625
 		</form>';
1557 1626
 
1558 1627
 	// Any final spellchecking stuff?
1559
-	if (!empty($context['show_spellchecking']))
1560
-		echo '
1628
+	if (!empty($context['show_spellchecking'])) {
1629
+			echo '
1561 1630
 		<form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>';
1562
-}
1631
+	}
1632
+	}
1563 1633
 
1564 1634
 /**
1565 1635
  * Personal Message settings.
@@ -1596,10 +1666,11 @@  discard block
 block discarded – undo
1596 1666
 										<select name="pm_receive_from" id="pm_receive_from">
1597 1667
 												<option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>';
1598 1668
 
1599
-	if (!empty($modSettings['enable_buddylist']))
1600
-		echo '
1669
+	if (!empty($modSettings['enable_buddylist'])) {
1670
+			echo '
1601 1671
 												<option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option>
1602 1672
 												<option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>';
1673
+	}
1603 1674
 
1604 1675
 	echo '
1605 1676
 												<option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option>
@@ -1642,11 +1713,12 @@  discard block
 block discarded – undo
1642 1713
 		if (empty($setting) || !is_array($setting))
1643 1714
 		{
1644 1715
 			// Insert a separator (unless this is the first item in the list)
1645
-			if ($i !== $first_option_key)
1646
-				echo '
1716
+			if ($i !== $first_option_key) {
1717
+							echo '
1647 1718
 				</dl>
1648 1719
 				<hr>
1649 1720
 				<dl class="settings">';
1721
+			}
1650 1722
 
1651 1723
 			// Should we give a name to this section?
1652 1724
 			if (is_string($setting) && !empty($setting))
@@ -1654,48 +1726,52 @@  discard block
 block discarded – undo
1654 1726
 				$titled_section = true;
1655 1727
 				echo '
1656 1728
 					<dt><strong>' . $setting . '</strong></dt><dd></dd>';
1729
+			} else {
1730
+							$titled_section = false;
1657 1731
 			}
1658
-			else
1659
-				$titled_section = false;
1660 1732
 
1661 1733
 			continue;
1662 1734
 		}
1663 1735
 
1664 1736
 		// Is this disabled?
1665
-		if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled']))
1666
-			continue;
1667
-		elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage']))
1668
-			continue;
1669
-		elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored']))
1670
-			continue;
1671
-		elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist']))
1672
-			continue;
1673
-		elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg']))
1674
-			continue;
1675
-		elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage']))
1676
-			continue;
1677
-		elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled']))))
1678
-			continue;
1679
-		elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled']))))
1680
-			continue;
1737
+		if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) {
1738
+					continue;
1739
+		} elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) {
1740
+					continue;
1741
+		} elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) {
1742
+					continue;
1743
+		} elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) {
1744
+					continue;
1745
+		} elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) {
1746
+					continue;
1747
+		} elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage'])) {
1748
+					continue;
1749
+		} elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) {
1750
+					continue;
1751
+		} elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) {
1752
+					continue;
1753
+		}
1681 1754
 
1682
-		if (!isset($setting['type']) || $setting['type'] == 'bool')
1683
-			$setting['type'] = 'checkbox';
1684
-		elseif ($setting['type'] == 'int' || $setting['type'] == 'integer')
1685
-			$setting['type'] = 'number';
1686
-		elseif ($setting['type'] == 'string')
1687
-			$setting['type'] = 'text';
1755
+		if (!isset($setting['type']) || $setting['type'] == 'bool') {
1756
+					$setting['type'] = 'checkbox';
1757
+		} elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') {
1758
+					$setting['type'] = 'number';
1759
+		} elseif ($setting['type'] == 'string') {
1760
+					$setting['type'] = 'text';
1761
+		}
1688 1762
 
1689
-		if (isset($setting['options']))
1690
-			$setting['type'] = 'list';
1763
+		if (isset($setting['options'])) {
1764
+					$setting['type'] = 'list';
1765
+		}
1691 1766
 
1692 1767
 		echo '
1693 1768
 					<dt>
1694 1769
 						<label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>';
1695 1770
 
1696
-		if (isset($setting['description']))
1697
-			echo '
1771
+		if (isset($setting['description'])) {
1772
+					echo '
1698 1773
 						<br><span class="smalltext">', $setting['description'], '</span>';
1774
+		}
1699 1775
 		echo '
1700 1776
 					</dt>
1701 1777
 					<dd>';
@@ -1733,13 +1809,11 @@  discard block
 block discarded – undo
1733 1809
 
1734 1810
 				echo '
1735 1811
 						<input type="number"', $min . $max . $step;
1736
-			}
1737
-			else if (isset($setting['type']) && $setting['type'] == 'url')
1812
+			} else if (isset($setting['type']) && $setting['type'] == 'url')
1738 1813
 			{
1739 1814
 				echo'
1740 1815
 						<input type="url"';
1741
-			}
1742
-			else
1816
+			} else
1743 1817
 			{
1744 1818
 				echo '
1745 1819
 						<input type="text"';
@@ -1778,8 +1852,8 @@  discard block
 block discarded – undo
1778 1852
 				<dl class="settings">';
1779 1853
 
1780 1854
 	// Allow notification on announcements to be disabled?
1781
-	if (!empty($modSettings['allow_disableAnnounce']))
1782
-		echo '
1855
+	if (!empty($modSettings['allow_disableAnnounce'])) {
1856
+			echo '
1783 1857
 					<dt>
1784 1858
 						<label for="notify_announcements">', $txt['notify_important_email'], '</label>
1785 1859
 					</dt>
@@ -1787,9 +1861,10 @@  discard block
 block discarded – undo
1787 1861
 						<input type="hidden" name="notify_announcements" value="0">
1788 1862
 						<input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', '>
1789 1863
 					</dd>';
1864
+	}
1790 1865
 
1791
-	if (!empty($modSettings['enable_ajax_alerts']))
1792
-		echo '
1866
+	if (!empty($modSettings['enable_ajax_alerts'])) {
1867
+			echo '
1793 1868
 					<dt>
1794 1869
 						<label for="notify_send_body">', $txt['notify_alert_timeout'], '</label>
1795 1870
 					</dt>
@@ -1797,6 +1872,7 @@  discard block
 block discarded – undo
1797 1872
 						<input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '">
1798 1873
 					</dd>
1799 1874
 		';
1875
+	}
1800 1876
 
1801 1877
 	echo '
1802 1878
 				</dl>
@@ -1826,9 +1902,10 @@  discard block
 block discarded – undo
1826 1902
 					<td colspan="3">';
1827 1903
 				$label = $txt['alert_opt_' . $opts[1]];
1828 1904
 				$label_pos = isset($opts['label']) ? $opts['label'] : '';
1829
-				if ($label_pos == 'before')
1830
-					echo '
1905
+				if ($label_pos == 'before') {
1906
+									echo '
1831 1907
 					<label for="opt_', $opts[1], '">', $label, '</label>';
1908
+				}
1832 1909
 
1833 1910
 				$this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0;
1834 1911
 				switch ($opts[0])
@@ -1840,17 +1917,19 @@  discard block
 block discarded – undo
1840 1917
 					case 'select':
1841 1918
 						echo '
1842 1919
 						<select name="opt_', $opts[1], '" id="opt_', $opts[1], '">';
1843
-						foreach ($opts['opts'] as $k => $v)
1844
-							echo '
1920
+						foreach ($opts['opts'] as $k => $v) {
1921
+													echo '
1845 1922
 							<option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>';
1923
+						}
1846 1924
 						echo '
1847 1925
 						</select>';
1848 1926
 						break;
1849 1927
 				}
1850 1928
 
1851
-				if ($label_pos == 'after')
1852
-					echo '
1929
+				if ($label_pos == 'after') {
1930
+									echo '
1853 1931
 					<label for="opt_', $opts[1], '">', $label, '</label>';
1932
+				}
1854 1933
 
1855 1934
 				echo '
1856 1935
 					</td>
@@ -1964,11 +2043,12 @@  discard block
 block discarded – undo
1964 2043
 			<p class="information">', $txt['groupMembership_info'], '</p>';
1965 2044
 
1966 2045
 	// Do we have an update message?
1967
-	if (!empty($context['update_message']))
1968
-		echo '
2046
+	if (!empty($context['update_message'])) {
2047
+			echo '
1969 2048
 			<div class="infobox">
1970 2049
 				', $context['update_message'], '.
1971 2050
 			</div>';
2051
+	}
1972 2052
 
1973 2053
 	echo '
1974 2054
 		<div id="groups">';
@@ -1990,8 +2070,7 @@  discard block
 block discarded – undo
1990 2070
 					</div>
1991 2071
 				</div>
1992 2072
 			</div>';
1993
-	}
1994
-	else
2073
+	} else
1995 2074
 	{
1996 2075
 		echo '
1997 2076
 			<div class="title_bar">
@@ -2003,27 +2082,30 @@  discard block
 block discarded – undo
2003 2082
 			echo '
2004 2083
 					<div class="windowbg" id="primdiv_', $group['id'], '">';
2005 2084
 
2006
-				if ($context['can_edit_primary'])
2007
-					echo '
2085
+				if ($context['can_edit_primary']) {
2086
+									echo '
2008 2087
 						<input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', '>';
2088
+				}
2009 2089
 
2010 2090
 				echo '
2011 2091
 						<label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>';
2012 2092
 
2013 2093
 				// Can they leave their group?
2014
-				if ($group['can_leave'])
2015
-					echo '
2094
+				if ($group['can_leave']) {
2095
+									echo '
2016 2096
 						<a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>';
2097
+				}
2017 2098
 
2018 2099
 				echo '
2019 2100
 					</div>';
2020 2101
 		}
2021 2102
 
2022
-		if ($context['can_edit_primary'])
2023
-			echo '
2103
+		if ($context['can_edit_primary']) {
2104
+					echo '
2024 2105
 			<div class="padding righttext">
2025 2106
 				<input type="submit" value="', $txt['make_primary'], '" class="button_submit">
2026 2107
 			</div>';
2108
+		}
2027 2109
 
2028 2110
 		// Any groups they can join?
2029 2111
 		if (!empty($context['groups']['available']))
@@ -2039,15 +2121,16 @@  discard block
 block discarded – undo
2039 2121
 					<div class="windowbg">
2040 2122
 						<strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '';
2041 2123
 
2042
-				if ($group['type'] == 3)
2043
-					echo '
2124
+				if ($group['type'] == 3) {
2125
+									echo '
2044 2126
 						<a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>';
2045
-				elseif ($group['type'] == 2 && $group['pending'])
2046
-					echo '
2127
+				} elseif ($group['type'] == 2 && $group['pending']) {
2128
+									echo '
2047 2129
 						<span class="floatright">', $txt['approval_pending'], '</span>';
2048
-				elseif ($group['type'] == 2)
2049
-					echo '
2130
+				} elseif ($group['type'] == 2) {
2131
+									echo '
2050 2132
 						<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>';
2133
+				}
2051 2134
 
2052 2135
 				echo '
2053 2136
 					</div>';
@@ -2070,9 +2153,10 @@  discard block
 block discarded – undo
2070 2153
 
2071 2154
 			prevDiv.className = "windowbg";
2072 2155
 		}';
2073
-		if (isset($context['groups']['member'][$context['primary_group']]))
2074
-			echo '
2156
+		if (isset($context['groups']['member'][$context['primary_group']])) {
2157
+					echo '
2075 2158
 		highlightSelected("primdiv_' . $context['primary_group'] . '");';
2159
+		}
2076 2160
 		echo '
2077 2161
 	</script>';
2078 2162
 	}
@@ -2080,9 +2164,10 @@  discard block
 block discarded – undo
2080 2164
 	echo '
2081 2165
 		</div>';
2082 2166
 
2083
-	if (!empty($context['token_check']))
2084
-		echo '
2167
+	if (!empty($context['token_check'])) {
2168
+			echo '
2085 2169
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2170
+	}
2086 2171
 
2087 2172
 	echo '
2088 2173
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2129,14 +2214,15 @@  discard block
 block discarded – undo
2129 2214
 
2130 2215
 		foreach ($category['boards'] as $board)
2131 2216
 		{
2132
-			if ($i == $limit)
2133
-				echo '
2217
+			if ($i == $limit) {
2218
+							echo '
2134 2219
 						</ul>
2135 2220
 					</li>
2136 2221
 				</ul>
2137 2222
 				<ul class="ignoreboards floatright">
2138 2223
 					<li class="category">
2139 2224
 						<ul>';
2225
+			}
2140 2226
 
2141 2227
 			echo '
2142 2228
 							<li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;">
@@ -2182,10 +2268,11 @@  discard block
 block discarded – undo
2182 2268
 
2183 2269
 	// Work out the starting color.
2184 2270
 	$context['current_color'] = $context['colors'][0];
2185
-	foreach ($context['colors'] as $limit => $color)
2186
-		if ($context['member']['warning'] >= $limit)
2271
+	foreach ($context['colors'] as $limit => $color) {
2272
+			if ($context['member']['warning'] >= $limit)
2187 2273
 			$context['current_color'] = $color;
2188
-}
2274
+	}
2275
+	}
2189 2276
 
2190 2277
 // Show all warnings of a user?
2191 2278
 function template_viewWarning()
@@ -2224,14 +2311,15 @@  discard block
 block discarded – undo
2224 2311
 				</dd>';
2225 2312
 
2226 2313
 		// There's some impact of this?
2227
-		if (!empty($context['level_effects'][$context['current_level']]))
2228
-			echo '
2314
+		if (!empty($context['level_effects'][$context['current_level']])) {
2315
+					echo '
2229 2316
 				<dt>
2230 2317
 					<strong>', $txt['profile_viewwarning_impact'], ':</strong>
2231 2318
 				</dt>
2232 2319
 				<dd>
2233 2320
 					', $context['level_effects'][$context['current_level']], '
2234 2321
 				</dd>';
2322
+		}
2235 2323
 
2236 2324
 		echo '
2237 2325
 			</dl>
@@ -2269,10 +2357,11 @@  discard block
 block discarded – undo
2269 2357
 
2270 2358
 			// Otherwise see what we can do...';
2271 2359
 
2272
-	foreach ($context['notification_templates'] as $k => $type)
2273
-		echo '
2360
+	foreach ($context['notification_templates'] as $k => $type) {
2361
+			echo '
2274 2362
 			if (index == ', $k, ')
2275 2363
 				document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";';
2364
+	}
2276 2365
 
2277 2366
 	echo '
2278 2367
 		}
@@ -2282,10 +2371,11 @@  discard block
 block discarded – undo
2282 2371
 			// Also set the right effect.
2283 2372
 			effectText = "";';
2284 2373
 
2285
-	foreach ($context['level_effects'] as $limit => $text)
2286
-		echo '
2374
+	foreach ($context['level_effects'] as $limit => $text) {
2375
+			echo '
2287 2376
 			if (slideAmount >= ', $limit, ')
2288 2377
 				effectText = "', $text, '";';
2378
+	}
2289 2379
 
2290 2380
 	echo '
2291 2381
 			setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\');
@@ -2300,31 +2390,34 @@  discard block
 block discarded – undo
2300 2390
 			</h3>
2301 2391
 		</div>';
2302 2392
 
2303
-	if (!$context['user']['is_owner'])
2304
-		echo '
2393
+	if (!$context['user']['is_owner']) {
2394
+			echo '
2305 2395
 		<p class="information">', $txt['profile_warning_desc'], '</p>';
2396
+	}
2306 2397
 
2307 2398
 	echo '
2308 2399
 		<div class="windowbg">
2309 2400
 			<dl class="settings">';
2310 2401
 
2311
-	if (!$context['user']['is_owner'])
2312
-		echo '
2402
+	if (!$context['user']['is_owner']) {
2403
+			echo '
2313 2404
 				<dt>
2314 2405
 					<strong>', $txt['profile_warning_name'], ':</strong>
2315 2406
 				</dt>
2316 2407
 				<dd>
2317 2408
 					<strong>', $context['member']['name'], '</strong>
2318 2409
 				</dd>';
2410
+	}
2319 2411
 
2320 2412
 	echo '
2321 2413
 				<dt>
2322 2414
 					<strong>', $txt['profile_warning_level'], ':</strong>';
2323 2415
 
2324 2416
 	// Is there only so much they can apply?
2325
-	if ($context['warning_limit'])
2326
-		echo '
2417
+	if ($context['warning_limit']) {
2418
+			echo '
2327 2419
 					<br><span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>';
2420
+	}
2328 2421
 
2329 2422
 	echo '
2330 2423
 				</dt>
@@ -2377,9 +2470,10 @@  discard block
 block discarded – undo
2377 2470
 						<option value="-1">', $txt['profile_warning_notify_template'], '</option>
2378 2471
 						<option value="-1" disabled>------------------------------</option>';
2379 2472
 
2380
-		foreach ($context['notification_templates'] as $id_template => $template)
2381
-			echo '
2473
+		foreach ($context['notification_templates'] as $id_template => $template) {
2474
+					echo '
2382 2475
 						<option value="', $id_template, '">', $template['title'], '</option>';
2476
+		}
2383 2477
 
2384 2478
 		echo '
2385 2479
 					</select>
@@ -2391,9 +2485,10 @@  discard block
 block discarded – undo
2391 2485
 			</dl>
2392 2486
 			<div class="righttext">';
2393 2487
 
2394
-	if (!empty($context['token_check']))
2395
-		echo '
2488
+	if (!empty($context['token_check'])) {
2489
+			echo '
2396 2490
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2491
+	}
2397 2492
 
2398 2493
 	echo '
2399 2494
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2409,8 +2504,8 @@  discard block
 block discarded – undo
2409 2504
 	echo '
2410 2505
 	<script>';
2411 2506
 
2412
-	if (!$context['user']['is_owner'])
2413
-		echo '
2507
+	if (!$context['user']['is_owner']) {
2508
+			echo '
2414 2509
 		modifyWarnNotify();
2415 2510
 		$(document).ready(function() {
2416 2511
 			$("#preview_button").click(function() {
@@ -2449,6 +2544,7 @@  discard block
 block discarded – undo
2449 2544
 			});
2450 2545
 			return false;
2451 2546
 		}';
2547
+	}
2452 2548
 
2453 2549
 	echo '
2454 2550
 	</script>';
@@ -2471,16 +2567,18 @@  discard block
 block discarded – undo
2471 2567
 			</div>';
2472 2568
 
2473 2569
 	// If deleting another account give them a lovely info box.
2474
-	if (!$context['user']['is_owner'])
2475
-		echo '
2570
+	if (!$context['user']['is_owner']) {
2571
+			echo '
2476 2572
 			<p class="information">', $txt['deleteAccount_desc'], '</p>';
2573
+	}
2477 2574
 	echo '
2478 2575
 			<div class="windowbg2">';
2479 2576
 
2480 2577
 	// If they are deleting their account AND the admin needs to approve it - give them another piece of info ;)
2481
-	if ($context['needs_approval'])
2482
-		echo '
2578
+	if ($context['needs_approval']) {
2579
+			echo '
2483 2580
 				<div class="errorbox">', $txt['deleteAccount_approval'], '</div>';
2581
+	}
2484 2582
 
2485 2583
 	// If the user is deleting their own account warn them first - and require a password!
2486 2584
 	if ($context['user']['is_owner'])
@@ -2492,9 +2590,10 @@  discard block
 block discarded – undo
2492 2590
 					<input type="password" name="oldpasswrd" size="20">&nbsp;&nbsp;&nbsp;&nbsp;
2493 2591
 					<input type="submit" value="', $txt['yes'], '" class="button_submit">';
2494 2592
 
2495
-		if (!empty($context['token_check']))
2496
-			echo '
2593
+		if (!empty($context['token_check'])) {
2594
+					echo '
2497 2595
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2596
+		}
2498 2597
 
2499 2598
 		echo '
2500 2599
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2520,9 +2619,10 @@  discard block
 block discarded – undo
2520 2619
 						<option value="topics">', $txt['deleteAccount_topics'], '</option>
2521 2620
 					</select>';
2522 2621
 
2523
-			if ($context['show_perma_delete'])
2524
-				echo '
2622
+			if ($context['show_perma_delete']) {
2623
+							echo '
2525 2624
 					<br><label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1">', $txt['deleteAccount_permanent'], ':</label>';
2625
+			}
2526 2626
 
2527 2627
 			echo '
2528 2628
 				</div>';
@@ -2535,9 +2635,10 @@  discard block
 block discarded – undo
2535 2635
 				<div>
2536 2636
 					<input type="submit" value="', $txt['delete'], '" class="button_submit">';
2537 2637
 
2538
-		if (!empty($context['token_check']))
2539
-			echo '
2638
+		if (!empty($context['token_check'])) {
2639
+					echo '
2540 2640
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2641
+		}
2541 2642
 
2542 2643
 		echo '
2543 2644
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2563,8 +2664,8 @@  discard block
 block discarded – undo
2563 2664
 					<hr>';
2564 2665
 
2565 2666
 	// Only show the password box if it's actually needed.
2566
-	if ($context['require_password'])
2567
-		echo '
2667
+	if ($context['require_password']) {
2668
+			echo '
2568 2669
 					<dl class="settings">
2569 2670
 						<dt>
2570 2671
 							<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br>
@@ -2574,13 +2675,15 @@  discard block
 block discarded – undo
2574 2675
 							<input type="password" name="oldpasswrd" size="20" style="margin-right: 4ex;">
2575 2676
 						</dd>
2576 2677
 					</dl>';
2678
+	}
2577 2679
 
2578 2680
 	echo '
2579 2681
 					<div class="righttext">';
2580 2682
 
2581
-		if (!empty($context['token_check']))
2582
-			echo '
2683
+		if (!empty($context['token_check'])) {
2684
+					echo '
2583 2685
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2686
+		}
2584 2687
 
2585 2688
 	echo '
2586 2689
 						<input type="submit" value="', $txt['change_profile'], '" class="button_submit">
@@ -2607,9 +2710,10 @@  discard block
 block discarded – undo
2607 2710
 			<ul id="list_errors">';
2608 2711
 
2609 2712
 		// Cycle through each error and display an error message.
2610
-		foreach ($context['post_errors'] as $error)
2611
-			echo '
2713
+		foreach ($context['post_errors'] as $error) {
2714
+					echo '
2612 2715
 				<li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>';
2716
+		}
2613 2717
 
2614 2718
 		echo '
2615 2719
 			</ul>';
@@ -2635,12 +2739,13 @@  discard block
 block discarded – undo
2635 2739
 								<select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 &amp;&amp; !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>';
2636 2740
 
2637 2741
 		// Fill the select box with all primary member groups that can be assigned to a member.
2638
-		foreach ($context['member_groups'] as $member_group)
2639
-			if (!empty($member_group['can_be_primary']))
2742
+		foreach ($context['member_groups'] as $member_group) {
2743
+					if (!empty($member_group['can_be_primary']))
2640 2744
 				echo '
2641 2745
 									<option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '>
2642 2746
 										', $member_group['name'], '
2643 2747
 									</option>';
2748
+		}
2644 2749
 		echo '
2645 2750
 								</select>
2646 2751
 							</dd>
@@ -2652,10 +2757,11 @@  discard block
 block discarded – undo
2652 2757
 									<input type="hidden" name="additional_groups[]" value="0">';
2653 2758
 
2654 2759
 		// For each membergroup show a checkbox so members can be assigned to more than one group.
2655
-		foreach ($context['member_groups'] as $member_group)
2656
-			if ($member_group['can_be_additional'])
2760
+		foreach ($context['member_groups'] as $member_group) {
2761
+					if ($member_group['can_be_additional'])
2657 2762
 				echo '
2658 2763
 									<label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', '> ', $member_group['name'], '</label><br>';
2764
+		}
2659 2765
 		echo '
2660 2766
 								</span>
2661 2767
 								<a href="javascript:void(0);" onclick="document.getElementById(\'additional_groupsList\').style.display = \'block\'; document.getElementById(\'additional_groupsLink\').style.display = \'none\'; return false;" id="additional_groupsLink" style="display: none;" class="toggle_down">', $txt['additional_membergroups_show'], '</a>
@@ -2715,9 +2821,10 @@  discard block
 block discarded – undo
2715 2821
 								<span class="smalltext">', $txt['sig_info'], '</span><br>
2716 2822
 								<br>';
2717 2823
 
2718
-	if ($context['show_spellchecking'])
2719
-		echo '
2824
+	if ($context['show_spellchecking']) {
2825
+			echo '
2720 2826
 								<input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button_submit">';
2827
+	}
2721 2828
 
2722 2829
 		echo '
2723 2830
 							</dt>
@@ -2725,17 +2832,20 @@  discard block
 block discarded – undo
2725 2832
 								<textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50" style="min-width: 50%; max-width: 99%;">', $context['member']['signature'], '</textarea><br>';
2726 2833
 
2727 2834
 	// If there is a limit at all!
2728
-	if (!empty($context['signature_limits']['max_length']))
2729
-		echo '
2835
+	if (!empty($context['signature_limits']['max_length'])) {
2836
+			echo '
2730 2837
 								<span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>';
2838
+	}
2731 2839
 
2732
-	if (!empty($context['show_preview_button']))
2733
-		echo '
2840
+	if (!empty($context['show_preview_button'])) {
2841
+			echo '
2734 2842
 								<input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button_submit">';
2843
+	}
2735 2844
 
2736
-	if ($context['signature_warning'])
2737
-		echo '
2845
+	if ($context['signature_warning']) {
2846
+			echo '
2738 2847
 								<span class="smalltext">', $context['signature_warning'], '</span>';
2848
+	}
2739 2849
 
2740 2850
 	// Some javascript used to count how many characters have been used so far in the signature.
2741 2851
 	echo '
@@ -2779,9 +2889,10 @@  discard block
 block discarded – undo
2779 2889
 									<div>
2780 2890
 										<select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">';
2781 2891
 		// This lists all the file categories.
2782
-		foreach ($context['avatars'] as $avatar)
2783
-			echo '
2892
+		foreach ($context['avatars'] as $avatar) {
2893
+					echo '
2784 2894
 											<option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>';
2895
+		}
2785 2896
 		echo '
2786 2897
 										</select>
2787 2898
 									</div>
@@ -2836,16 +2947,17 @@  discard block
 block discarded – undo
2836 2947
 								<div id="avatar_gravatar">
2837 2948
 									<img src="' . $context['member']['avatar']['href'] . '" alt="" />';
2838 2949
 
2839
-		if (empty($modSettings['gravatarAllowExtraEmail']))
2840
-			echo '
2950
+		if (empty($modSettings['gravatarAllowExtraEmail'])) {
2951
+					echo '
2841 2952
 									<div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>';
2842
-		else
2953
+		} else
2843 2954
 		{
2844 2955
 			// Depending on other stuff, the stored value here might have some odd things in it from other areas.
2845
-			if ($context['member']['avatar']['external'] == $context['member']['email'])
2846
-				$textbox_value = '';
2847
-			else
2848
-				$textbox_value = $context['member']['avatar']['external'];
2956
+			if ($context['member']['avatar']['external'] == $context['member']['email']) {
2957
+							$textbox_value = '';
2958
+			} else {
2959
+							$textbox_value = $context['member']['avatar']['external'];
2960
+			}
2849 2961
 
2850 2962
 			echo '
2851 2963
 									<div class="smalltext">', $txt['gravatar_alternateEmail'], '</div>
@@ -2917,8 +3029,9 @@  discard block
 block discarded – undo
2917 3029
 	$h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0;
2918 3030
 
2919 3031
 	$suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : '');
2920
-	if (empty($suffix))
2921
-		return;
3032
+	if (empty($suffix)) {
3033
+			return;
3034
+	}
2922 3035
 
2923 3036
 	echo '
2924 3037
 									<div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>';
@@ -2940,9 +3053,10 @@  discard block
 block discarded – undo
2940 3053
 							<dd>
2941 3054
 								<select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;" style="margin-bottom: 4px;">';
2942 3055
 	// Help the user by showing a list of common time formats.
2943
-	foreach ($context['easy_timeformats'] as $time_format)
2944
-		echo '
3056
+	foreach ($context['easy_timeformats'] as $time_format) {
3057
+			echo '
2945 3058
 									<option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>';
3059
+	}
2946 3060
 	echo '
2947 3061
 								</select><br>
2948 3062
 								<input type="text" name="time_format" id="time_format" value="', $context['member']['time_format'], '" size="30">
@@ -2978,9 +3092,10 @@  discard block
 block discarded – undo
2978 3092
 							</dt>
2979 3093
 							<dd>
2980 3094
 								<select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.gif\';">';
2981
-	foreach ($context['smiley_sets'] as $set)
2982
-		echo '
3095
+	foreach ($context['smiley_sets'] as $set) {
3096
+			echo '
2983 3097
 									<option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>';
3098
+	}
2984 3099
 	echo '
2985 3100
 								</select> <img id="smileypr" class="centericon" src="', $context['member']['smiley_set']['id'] != 'none' ? $modSettings['smileys_url'] . '/' . ($context['member']['smiley_set']['id'] != '' ? $context['member']['smiley_set']['id'] : (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'])) . '/smiley.gif' : $settings['images_url'] . '/blank.png', '" alt=":)"  style="padding-left: 20px;">
2986 3101
 							</dd>';
@@ -3031,10 +3146,11 @@  discard block
 block discarded – undo
3031 3146
 									</div>
3032 3147
 									<div class="clear"></div>';
3033 3148
 
3034
-	if (!empty($context['from_ajax']))
3035
-		echo '
3149
+	if (!empty($context['from_ajax'])) {
3150
+			echo '
3036 3151
 									<br>
3037 3152
 									<a href="javascript:self.close();"></a>';
3153
+	}
3038 3154
 
3039 3155
 	echo '
3040 3156
 								</div>
@@ -3073,15 +3189,16 @@  discard block
 block discarded – undo
3073 3189
 								<br><div class="smalltext">', $txt['tfa_profile_desc'], '</div>
3074 3190
 							</dt>
3075 3191
 							<dd>';
3076
-	if (!$context['tfa_enabled'] && $context['user']['is_owner'])
3077
-		echo '
3192
+	if (!$context['tfa_enabled'] && $context['user']['is_owner']) {
3193
+			echo '
3078 3194
 								<a href="', !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>';
3079
-	elseif (!$context['tfa_enabled'])
3080
-		echo '
3195
+	} elseif (!$context['tfa_enabled']) {
3196
+			echo '
3081 3197
 								', $txt['tfa_profile_disabled'];
3082
-	else
3083
-		echo '
3198
+	} else {
3199
+			echo '
3084 3200
 							', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable');
3201
+	}
3085 3202
 	echo '
3086 3203
 							</dd>';
3087 3204
 }
Please login to merge, or discard this patch.