Completed
Pull Request — release-2.1 (#4184)
by Mert
09:38
created
Sources/ReCaptcha/index.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,9 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 // Try to handle it with the upper level index.php. (it should know what to do.)
4
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
4
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
5 5
 	include (dirname(dirname(__FILE__)) . '/index.php');
6
-else
6
+} else {
7 7
 	exit;
8
+}
8 9
 
9 10
 ?>
10 11
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/tasks/index.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,9 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 // Try to handle it with the upper level index.php. (it should know what to do.)
4
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
4
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
5 5
 	include (dirname(dirname(__FILE__)) . '/index.php');
6
-else
6
+} else {
7 7
 	exit;
8
+}
8 9
 
9 10
 ?>
10 11
\ No newline at end of file
Please login to merge, or discard this patch.
avatars/Oxygen/index.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,9 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 // Try to handle it with the upper level index.php. (it should know what to do.)
4
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
4
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
5 5
 	include (dirname(dirname(__FILE__)) . '/index.php');
6
-else
6
+} else {
7 7
 	exit;
8
+}
8 9
 
9 10
 ?>
10 11
\ No newline at end of file
Please login to merge, or discard this patch.
avatars/index.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,8 @@
 block discarded – undo
12 12
 	header('Location: ' . $boardurl);
13 13
 }
14 14
 // Can't find it... just forget it.
15
-else
15
+else {
16 16
 	exit;
17
+}
17 18
 
18 19
 ?>
19 20
\ No newline at end of file
Please login to merge, or discard this patch.
Themes/default/Themes.template.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -645,12 +645,12 @@
 block discarded – undo
645 645
 					</dd>';
646 646
 		}
647 647
 		// A Textarea?
648
-        	elseif ($setting['type'] == 'textarea')
648
+			elseif ($setting['type'] == 'textarea')
649 649
 		{
650 650
 			echo '
651 651
 					<dd>
652 652
 						<textarea rows="4" style="width: 95%;" cols="40" name="', !empty($setting['default']) ? 'default_' : '', 'options[', $setting['id'], ']" id="', $setting['id'], '">', $setting['value'], '</textarea>';
653
-                echo '
653
+				echo '
654 654
                 			</dd>';
655 655
 		}
656 656
 		// A regular input box, then?
Please login to merge, or discard this patch.
Braces   +103 added lines, -80 removed lines patch added patch discarded remove patch
@@ -54,9 +54,10 @@  discard block
 block discarded – undo
54 54
 					<dd>
55 55
 						<div id="known_themes_list">';
56 56
 
57
-	foreach ($context['themes'] as $theme)
58
-		echo '
57
+	foreach ($context['themes'] as $theme) {
58
+			echo '
59 59
 							<label for="options-known_themes_', $theme['id'], '"><input type="checkbox" name="options[known_themes][]" id="options-known_themes_', $theme['id'], '" value="', $theme['id'], '"', $theme['known'] ? ' checked' : '', ' class="input_check"> ', $theme['name'], '</label><br>';
60
+	}
60 61
 
61 62
 		echo '
62 63
 						</div>
@@ -73,9 +74,10 @@  discard block
 block discarded – undo
73 74
 						<select name="options[theme_guests]" id="theme_guests">';
74 75
 
75 76
 	// Put an option for each theme in the select box.
76
-	foreach ($context['themes'] as $theme)
77
-		echo '
77
+	foreach ($context['themes'] as $theme) {
78
+			echo '
78 79
 							<option value="', $theme['id'], '"', $modSettings['theme_guests'] == $theme['id'] ? ' selected' : '', '>', $theme['name'], '</option>';
80
+	}
79 81
 
80 82
 	echo '
81 83
 						</select>
@@ -90,9 +92,10 @@  discard block
 block discarded – undo
90 92
 							<option value="0">', $txt['theme_forum_default'], '</option>';
91 93
 
92 94
 	// Same thing, this time for changing the theme of everyone.
93
-	foreach ($context['themes'] as $theme)
94
-		echo '
95
+	foreach ($context['themes'] as $theme) {
96
+			echo '
95 97
 							<option value="', $theme['id'], '">', $theme['name'], '</option>';
98
+	}
96 99
 
97 100
 	echo '
98 101
 						</select>
@@ -189,11 +192,12 @@  discard block
 block discarded – undo
189 192
 	global $context, $scripturl, $txt;
190 193
 
191 194
 	// Show a nice confirmation message.
192
-	if (isset($_GET['done']))
193
-		echo '
195
+	if (isset($_GET['done'])) {
196
+			echo '
194 197
 	<div class="infobox">
195 198
 		', $txt['theme_confirmed_' . $_GET['done']], '
196 199
 	</div>';
200
+	}
197 201
 
198 202
 	echo '
199 203
 	<div id="admincenter">';
@@ -356,11 +360,12 @@  discard block
 block discarded – undo
356 360
 		if (empty($setting) || !is_array($setting))
357 361
 		{
358 362
 			// Insert a separator (unless this is the first item in the list)
359
-			if ($i !== $first_option_key)
360
-				echo '
363
+			if ($i !== $first_option_key) {
364
+							echo '
361 365
 				</dl>
362 366
 				<hr>
363 367
 				<dl class="settings">';
368
+			}
364 369
 
365 370
 			// Should we give a name to this section?
366 371
 			if (is_string($setting) && !empty($setting))
@@ -368,9 +373,9 @@  discard block
 block discarded – undo
368 373
 				$titled_section = true;
369 374
 				echo '
370 375
 					<dt><b>' . $setting . '</b></dt><dd></dd>';
376
+			} else {
377
+							$titled_section = false;
371 378
 			}
372
-			else
373
-				$titled_section = false;
374 379
 
375 380
 			continue;
376 381
 		}
@@ -379,19 +384,21 @@  discard block
 block discarded – undo
379 384
 					<dt ', $context['theme_options_reset'] ? 'style="width:50%"' : '', '>';
380 385
 
381 386
 		// Show the change option box ?
382
-		if ($context['theme_options_reset'])
383
-			echo '
387
+		if ($context['theme_options_reset']) {
388
+					echo '
384 389
 						<span class="floatleft"><select name="', !empty($setting['default']) ? 'default_' : '', 'options_master[', $setting['id'], ']" onchange="this.form.options_', $setting['id'], '.disabled = this.selectedIndex != 1;">
385 390
 							<option value="0" selected>', $txt['themeadmin_reset_options_none'], '</option>
386 391
 							<option value="1">', $txt['themeadmin_reset_options_change'], '</option>
387 392
 							<option value="2">', $txt['themeadmin_reset_options_default'], '</option>
388 393
 						</select>&nbsp;</span>';
394
+		}
389 395
 
390 396
 		echo '
391 397
 						<label for="options_', $setting['id'], '">', !$titled_section ? '<b>' : '', $setting['label'], !$titled_section ? '</b>' : '', '</label>';
392
-		if (isset($setting['description']))
393
-			echo '
398
+		if (isset($setting['description'])) {
399
+					echo '
394 400
 						<br><span class="smalltext">', $setting['description'], '</span>';
401
+		}
395 402
 		echo '
396 403
 					</dt>';
397 404
 
@@ -433,13 +440,11 @@  discard block
 block discarded – undo
433 440
 
434 441
 				echo '
435 442
 						<input type="number"', $min . $max . $step;
436
-			}
437
-			else if (isset($setting['type']) && $setting['type'] == 'url')
443
+			} else if (isset($setting['type']) && $setting['type'] == 'url')
438 444
 			{
439 445
 				echo'
440 446
 						<input type="url"';
441
-			}
442
-			else
447
+			} else
443 448
 			{
444 449
 				echo '
445 450
 						<input type="text"';
@@ -483,8 +488,8 @@  discard block
 block discarded – undo
483 488
 			<br>';
484 489
 
485 490
 	// @todo Why can't I edit the default theme popup.
486
-	if ($context['theme_settings']['theme_id'] != 1)
487
-		echo '
491
+	if ($context['theme_settings']['theme_id'] != 1) {
492
+			echo '
488 493
 			<div class="cat_bar">
489 494
 				<h3 class="catbg config_hd">
490 495
 					', $txt['theme_edit'], '
@@ -500,6 +505,7 @@  discard block
 block discarded – undo
500 505
 					</li>
501 506
 				</ul>
502 507
 			</div>';
508
+	}
503 509
 
504 510
 	echo '
505 511
 			<div class="cat_bar">
@@ -553,9 +559,10 @@  discard block
 block discarded – undo
553 559
 					<dd>
554 560
 						<select id="variant" name="options[default_variant]" onchange="changeVariant(this.value)">';
555 561
 
556
-		foreach ($context['theme_variants'] as $key => $variant)
557
-			echo '
562
+		foreach ($context['theme_variants'] as $key => $variant) {
563
+					echo '
558 564
 							<option value="', $key, '"', $context['default_variant'] == $key ? ' selected' : '', '>', $variant['label'], '</option>';
565
+		}
559 566
 
560 567
 		echo '
561 568
 						</select>
@@ -590,11 +597,12 @@  discard block
 block discarded – undo
590 597
 		if (empty($setting) || !is_array($setting))
591 598
 		{
592 599
 			// We don't need a separator before the first list element
593
-			if ($i !== $first_setting_key)
594
-				echo '
600
+			if ($i !== $first_setting_key) {
601
+							echo '
595 602
 				</dl>
596 603
 				<hr>
597 604
 				<dl class="settings">';
605
+			}
598 606
 
599 607
 			// Add a fake heading?
600 608
 			if (is_string($setting) && !empty($setting))
@@ -602,9 +610,9 @@  discard block
 block discarded – undo
602 610
 				$titled_section = true;
603 611
 				echo '
604 612
 					<dt><b>' . $setting . '</b></dt><dd></dd>';
613
+			} else {
614
+							$titled_section = false;
605 615
 			}
606
-			else
607
-				$titled_section = false;
608 616
 
609 617
 			continue;
610 618
 		}
@@ -613,9 +621,10 @@  discard block
 block discarded – undo
613 621
 					<dt>
614 622
 						<label for="', $setting['id'], '">', !$titled_section ? '<b>' : '', $setting['label'], !$titled_section ? '</b>' : '', '</label>:';
615 623
 
616
-		if (isset($setting['description']))
617
-			echo '<br>
624
+		if (isset($setting['description'])) {
625
+					echo '<br>
618 626
 						<span class="smalltext">', $setting['description'], '</span>';
627
+		}
619 628
 
620 629
 		echo '
621 630
 					</dt>';
@@ -636,9 +645,10 @@  discard block
 block discarded – undo
636 645
 					<dd>
637 646
 						<select name="', !empty($setting['default']) ? 'default_' : '', 'options[', $setting['id'], ']" id="', $setting['id'], '">';
638 647
 
639
-			foreach ($setting['options'] as $value => $label)
640
-				echo '
648
+			foreach ($setting['options'] as $value => $label) {
649
+							echo '
641 650
 							<option value="', $value, '"', $value == $setting['value'] ? ' selected' : '', '>', $label, '</option>';
651
+			}
642 652
 
643 653
 			echo '
644 654
 						</select>
@@ -667,13 +677,11 @@  discard block
 block discarded – undo
667 677
 
668 678
 				echo '
669 679
 						<input type="number"', $min . $max . $step;
670
-			}
671
-			else if (isset($setting['type']) && $setting['type'] == 'url')
680
+			} else if (isset($setting['type']) && $setting['type'] == 'url')
672 681
 			{
673 682
 				echo'
674 683
 						<input type="url"';
675
-			}
676
-			else
684
+			} else
677 685
 			{
678 686
 				echo '
679 687
 						<input type="text"';
@@ -826,21 +834,23 @@  discard block
 block discarded – undo
826 834
 		<div class="windowbg">';
827 835
 
828 836
 	// Oops! there was an error :(
829
-	if (!empty($context['error_message']))
830
-		echo '
837
+	if (!empty($context['error_message'])) {
838
+			echo '
831 839
 			<p>
832 840
 				', $context['error_message'], '
833 841
 			</p>';
842
+	}
834 843
 
835 844
 	// Not much to show except a link back...
836
-	else
837
-		echo '
845
+	else {
846
+			echo '
838 847
 			<p>
839 848
 				<a href="', $scripturl, '?action=admin;area=theme;sa=list;th=', $context['installed_theme']['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $context['installed_theme']['name'], '</a> ', $txt['theme_' . (isset($context['installed_theme']['updated']) ? 'updated' : 'installed') . '_message'], '
840 849
 			</p>
841 850
 			<p>
842 851
 				<a href="', $scripturl, '?action=admin;area=theme;sa=admin;', $context['session_var'], '=', $context['session_id'], '">', $txt['back'], '</a>
843 852
 			</p>';
853
+	}
844 854
 
845 855
 	echo '
846 856
 		</div>
@@ -907,10 +917,11 @@  discard block
 block discarded – undo
907 917
 					<span class="floatleft">', $template['filename'], $template['already_exists'] ? ' <span class="error">(' . $txt['themeadmin_edit_exists'] . ')</span>' : '', '</span>
908 918
 					<span class="floatright">';
909 919
 
910
-		if ($template['can_copy'])
911
-			echo '<a href="', $scripturl, '?action=admin;area=theme;th=', $context['theme_id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=copy;template=', $template['value'], '" data-confirm="', $template['already_exists'] ? $txt['themeadmin_edit_overwrite_confirm'] : $txt['themeadmin_edit_copy_confirm'], '" class="you_sure">', $txt['themeadmin_edit_do_copy'], '</a>';
912
-		else
913
-			echo $txt['themeadmin_edit_no_copy'];
920
+		if ($template['can_copy']) {
921
+					echo '<a href="', $scripturl, '?action=admin;area=theme;th=', $context['theme_id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=copy;template=', $template['value'], '" data-confirm="', $template['already_exists'] ? $txt['themeadmin_edit_overwrite_confirm'] : $txt['themeadmin_edit_copy_confirm'], '" class="you_sure">', $txt['themeadmin_edit_do_copy'], '</a>';
922
+		} else {
923
+					echo $txt['themeadmin_edit_no_copy'];
924
+		}
914 925
 
915 926
 		echo '
916 927
 					</span>
@@ -933,11 +944,12 @@  discard block
 block discarded – undo
933 944
 	echo '
934 945
 	<div id="admincenter">';
935 946
 
936
-	if (!empty($context['browse_title']))
937
-		echo '
947
+	if (!empty($context['browse_title'])) {
948
+			echo '
938 949
 		<div class="cat_bar">
939 950
 			<h3 class="catbg">', $context['browse_title'], '</h3>
940 951
 		</div>';
952
+	}
941 953
 
942 954
 	echo '
943 955
 		<table class="table_grid tborder">
@@ -957,14 +969,13 @@  discard block
 block discarded – undo
957 969
 			<tr class="windowbg">
958 970
 				<td>';
959 971
 
960
-		if ($file['is_editable'])
961
-			echo '<a href="', $file['href'], '"', $file['is_template'] ? ' style="font-weight: bold;"' : '', '>', $file['filename'], '</a>';
962
-
963
-		elseif ($file['is_directory'])
964
-			echo '<a href="', $file['href'], '" class="is_directory"><span class="generic_icons folder"></span>', $file['filename'], '</a>';
965
-
966
-		else
967
-			echo $file['filename'];
972
+		if ($file['is_editable']) {
973
+					echo '<a href="', $file['href'], '"', $file['is_template'] ? ' style="font-weight: bold;"' : '', '>', $file['filename'], '</a>';
974
+		} elseif ($file['is_directory']) {
975
+					echo '<a href="', $file['href'], '" class="is_directory"><span class="generic_icons folder"></span>', $file['filename'], '</a>';
976
+		} else {
977
+					echo $file['filename'];
978
+		}
968 979
 
969 980
 		echo '
970 981
 				</td>
@@ -986,11 +997,12 @@  discard block
 block discarded – undo
986 997
 {
987 998
 	global $context, $settings, $scripturl, $txt;
988 999
 
989
-	if ($context['session_error'])
990
-		echo '
1000
+	if ($context['session_error']) {
1001
+			echo '
991 1002
 	<div class="errorbox">
992 1003
 		', $txt['error_session_timeout'], '
993 1004
 	</div>';
1005
+	}
994 1006
 
995 1007
 	// From now on no one can complain that editing css is difficult. If you disagree, go to www.w3schools.com.
996 1008
 	echo '
@@ -1053,17 +1065,18 @@  discard block
 block discarded – undo
1053 1065
 					try
1054 1066
 					{
1055 1067
 					';
1056
-	if (isBrowser('is_ie'))
1057
-		echo '
1068
+	if (isBrowser('is_ie')) {
1069
+			echo '
1058 1070
 						var sheets = frames["css_preview_box"].document.styleSheets;
1059 1071
 						for (var j = 0; j < sheets.length; j++)
1060 1072
 						{
1061 1073
 							if (sheets[j].id == "css_preview_box")
1062 1074
 								sheets[j].cssText = document.forms.stylesheetForm.entire_file.value;
1063 1075
 						}';
1064
-	else
1065
-		echo '
1076
+	} else {
1077
+			echo '
1066 1078
 						setInnerHTML(frames["css_preview_box"].document.getElementById("css_preview_sheet"), document.forms.stylesheetForm.entire_file.value);';
1079
+	}
1067 1080
 	echo '
1068 1081
 					}
1069 1082
 					catch (e)
@@ -1115,9 +1128,10 @@  discard block
 block discarded – undo
1115 1128
 			</div>
1116 1129
 			<div class="windowbg">';
1117 1130
 
1118
-	if (!$context['allow_save'])
1119
-		echo '
1131
+	if (!$context['allow_save']) {
1132
+			echo '
1120 1133
 				', $txt['theme_edit_no_save'], ': ', $context['allow_save_filename'], '<br>';
1134
+	}
1121 1135
 
1122 1136
 	echo '
1123 1137
 				<textarea name="entire_file" cols="80" rows="20" style="width: 96%; font-family: monospace; margin-top: 1ex; white-space: pre;" onkeyup="setPreviewTimeout();" onchange="refreshPreview(true);">', $context['entire_file'], '</textarea><br>
@@ -1130,9 +1144,10 @@  discard block
 block discarded – undo
1130 1144
 			<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';
1131 1145
 
1132 1146
 	// Hopefully it exists.
1133
-	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token']))
1134
-		echo '
1147
+	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'])) {
1148
+			echo '
1135 1149
 			<input type="hidden" name="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token_var'], '" value="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'], '">';
1150
+	}
1136 1151
 
1137 1152
 	echo '
1138 1153
 		</form>
@@ -1146,18 +1161,20 @@  discard block
 block discarded – undo
1146 1161
 {
1147 1162
 	global $context, $scripturl, $txt;
1148 1163
 
1149
-	if ($context['session_error'])
1150
-		echo '
1164
+	if ($context['session_error']) {
1165
+			echo '
1151 1166
 	<div class="errorbox">
1152 1167
 		', $txt['error_session_timeout'], '
1153 1168
 	</div>';
1169
+	}
1154 1170
 
1155
-	if (isset($context['parse_error']))
1156
-		echo '
1171
+	if (isset($context['parse_error'])) {
1172
+			echo '
1157 1173
 	<div class="errorbox">
1158 1174
 		', $txt['themeadmin_edit_error'], '
1159 1175
 			<div><pre>', $context['parse_error'], '</pre></div>
1160 1176
 	</div>';
1177
+	}
1161 1178
 
1162 1179
 	// Just show a big box.... gray out the Save button if it's not saveable... (ie. not 777.)
1163 1180
 	echo '
@@ -1168,16 +1185,18 @@  discard block
 block discarded – undo
1168 1185
 			</div>
1169 1186
 			<div class="windowbg">';
1170 1187
 
1171
-	if (!$context['allow_save'])
1172
-		echo '
1188
+	if (!$context['allow_save']) {
1189
+			echo '
1173 1190
 				', $txt['theme_edit_no_save'], ': ', $context['allow_save_filename'], '<br>';
1191
+	}
1174 1192
 
1175
-	foreach ($context['file_parts'] as $part)
1176
-		echo '
1193
+	foreach ($context['file_parts'] as $part) {
1194
+			echo '
1177 1195
 				<label for="on_line', $part['line'], '">', $txt['themeadmin_edit_on_line'], ' ', $part['line'], '</label>:<br>
1178 1196
 				<div class="centertext">
1179 1197
 					<textarea id="on_line', $part['line'], '" name="entire_file[]" cols="80" rows="', $part['lines'] > 14 ? '14' : $part['lines'], '" class="edit_file">', $part['data'], '</textarea>
1180 1198
 				</div>';
1199
+	}
1181 1200
 
1182 1201
 	echo '
1183 1202
 				<div class="padding righttext">
@@ -1186,9 +1205,10 @@  discard block
 block discarded – undo
1186 1205
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';
1187 1206
 
1188 1207
 	// Hopefully it exists.
1189
-	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token']))
1190
-		echo '
1208
+	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'])) {
1209
+			echo '
1191 1210
 					<input type="hidden" name="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token_var'], '" value="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'], '">';
1211
+	}
1192 1212
 
1193 1213
 	echo '
1194 1214
 				</div>
@@ -1204,18 +1224,20 @@  discard block
 block discarded – undo
1204 1224
 {
1205 1225
 	global $context, $scripturl, $txt;
1206 1226
 
1207
-	if ($context['session_error'])
1208
-		echo '
1227
+	if ($context['session_error']) {
1228
+			echo '
1209 1229
 	<div class="errorbox">
1210 1230
 		', $txt['error_session_timeout'], '
1211 1231
 	</div>';
1232
+	}
1212 1233
 
1213 1234
 	//Is this file writeable?
1214
-	if (!$context['allow_save'])
1215
-		echo '
1235
+	if (!$context['allow_save']) {
1236
+			echo '
1216 1237
 	<div class="errorbox">
1217 1238
 		', $txt['theme_edit_no_save'], ': ', $context['allow_save_filename'], '
1218 1239
 	</div>';
1240
+	}
1219 1241
 
1220 1242
 	// Just show a big box.... gray out the Save button if it's not saveable... (ie. not 777.)
1221 1243
 	echo '
@@ -1231,9 +1253,10 @@  discard block
 block discarded – undo
1231 1253
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';
1232 1254
 
1233 1255
 	// Hopefully it exists.
1234
-	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token']))
1235
-		echo '
1256
+	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'])) {
1257
+			echo '
1236 1258
 				<input type="hidden" name="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token_var'], '" value="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'], '">';
1259
+	}
1237 1260
 
1238 1261
 	echo '
1239 1262
 			</div>
Please login to merge, or discard this patch.
Sources/tasks/CreatePost-Notify.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 class CreatePost_Notify_Background extends SMF_BackgroundTask
19 19
 {
20 20
 	/**
21
-     * This handles notifications when a new post is created - new topic, reply, quotes and mentions.
21
+	 * This handles notifications when a new post is created - new topic, reply, quotes and mentions.
22 22
 	 * @return bool Always returns true
23 23
 	 */
24 24
 	public function execute()
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 
107 107
 			// Don't send a notification if the watching member ignored the member who made the action.
108 108
 			if (!empty($data['pm_ignore_list']) && in_array($data['id_member_updated'], explode(',', $data['pm_ignore_list'])))
109
-			    continue;
109
+				continue;
110 110
 			if (!in_array($type, array('reply', 'topic')) && $notify_types == 2 && $member != $data['id_member_started'])
111 111
 				continue;
112 112
 			elseif (in_array($type, array('reply', 'topic')) && $member == $posterOptions['id'])
Please login to merge, or discard this patch.
Braces   +62 added lines, -46 removed lines patch added patch discarded remove patch
@@ -73,8 +73,9 @@  discard block
 block discarded – undo
73 73
 		while ($row = $smcFunc['db_fetch_assoc']($request))
74 74
 		{
75 75
 			$groups = array_merge(array($row['id_group'], $row['id_post_group']), (empty($row['additional_groups']) ? array() : explode(',', $row['additional_groups'])));
76
-			if (!in_array(1, $groups) && count(array_intersect($groups, explode(',', $row['member_groups']))) == 0)
77
-				continue;
76
+			if (!in_array(1, $groups) && count(array_intersect($groups, explode(',', $row['member_groups']))) == 0) {
77
+							continue;
78
+			}
78 79
 
79 80
 			$members[] = $row['id_member'];
80 81
 			$watched[$row['id_member']] = $row;
@@ -82,8 +83,9 @@  discard block
 block discarded – undo
82 83
 
83 84
 		$smcFunc['db_free_result']($request);
84 85
 
85
-		if (empty($members))
86
-			return true;
86
+		if (empty($members)) {
87
+					return true;
88
+		}
87 89
 
88 90
 		$members = array_unique($members);
89 91
 		$prefs = getNotifyPrefs($members, '', true);
@@ -105,20 +107,23 @@  discard block
 block discarded – undo
105 107
 			$notify_types = !empty($prefs[$member]['msg_notify_type']) ? $prefs[$member]['msg_notify_type'] : 1;
106 108
 
107 109
 			// Don't send a notification if the watching member ignored the member who made the action.
108
-			if (!empty($data['pm_ignore_list']) && in_array($data['id_member_updated'], explode(',', $data['pm_ignore_list'])))
109
-			    continue;
110
-			if (!in_array($type, array('reply', 'topic')) && $notify_types == 2 && $member != $data['id_member_started'])
111
-				continue;
112
-			elseif (in_array($type, array('reply', 'topic')) && $member == $posterOptions['id'])
113
-				continue;
114
-			elseif (!in_array($type, array('reply', 'topic')) && $notify_types == 3)
115
-				continue;
116
-			elseif ($notify_types == 4)
117
-				continue;
110
+			if (!empty($data['pm_ignore_list']) && in_array($data['id_member_updated'], explode(',', $data['pm_ignore_list']))) {
111
+						    continue;
112
+			}
113
+			if (!in_array($type, array('reply', 'topic')) && $notify_types == 2 && $member != $data['id_member_started']) {
114
+							continue;
115
+			} elseif (in_array($type, array('reply', 'topic')) && $member == $posterOptions['id']) {
116
+							continue;
117
+			} elseif (!in_array($type, array('reply', 'topic')) && $notify_types == 3) {
118
+							continue;
119
+			} elseif ($notify_types == 4) {
120
+							continue;
121
+			}
118 122
 
119 123
 			if ($frequency > 2 || (!empty($frequency) && $data['sent']) || in_array($member, $done_members)
120
-				|| (!empty($this->_details['members_only']) && !in_array($member, $this->_details['members_only'])))
121
-				continue;
124
+				|| (!empty($this->_details['members_only']) && !in_array($member, $this->_details['members_only']))) {
125
+							continue;
126
+			}
122 127
 
123 128
 			// Watched topic?
124 129
 			if (!empty($data['id_topic']) && $type != 'topic' && !empty($prefs[$member]))
@@ -128,10 +133,12 @@  discard block
 block discarded – undo
128 133
 
129 134
 				if ($type == 'reply')
130 135
 				{
131
-					if (!empty($prefs[$member]['msg_receive_body']))
132
-						$message_type .= '_body';
133
-					if (!empty($frequency))
134
-						$message_type .= '_once';
136
+					if (!empty($prefs[$member]['msg_receive_body'])) {
137
+											$message_type .= '_body';
138
+					}
139
+					if (!empty($frequency)) {
140
+											$message_type .= '_once';
141
+					}
135 142
 				}
136 143
 
137 144
 				$content_type = 'topic';
@@ -144,12 +151,14 @@  discard block
 block discarded – undo
144 151
 				$content_type = 'board';
145 152
 
146 153
 				$message_type = !empty($frequency) ? 'notify_boards_once' : 'notify_boards';
147
-				if (!empty($prefs[$member]['msg_receive_body']))
148
-					$message_type .= '_body';
154
+				if (!empty($prefs[$member]['msg_receive_body'])) {
155
+									$message_type .= '_body';
156
+				}
149 157
 			}
150 158
 			// If neither of the above, this might be a redundent row due to the OR clause in our SQL query, skip
151
-			else
152
-				continue;
159
+			else {
160
+							continue;
161
+			}
153 162
 
154 163
 			if ($pref & 0x02)
155 164
 			{
@@ -212,14 +221,15 @@  discard block
 block discarded – undo
212 221
 		);
213 222
 
214 223
 		// Insert the alerts if any
215
-		if (!empty($alert_rows))
216
-			$smcFunc['db_insert']('',
224
+		if (!empty($alert_rows)) {
225
+					$smcFunc['db_insert']('',
217 226
 				'{db_prefix}user_alerts',
218 227
 				array('alert_time' => 'int', 'id_member' => 'int', 'id_member_started' => 'int', 'member_name' => 'string',
219 228
 					'content_type' => 'string', 'content_id' => 'int', 'content_action' => 'string', 'is_read' => 'int', 'extra' => 'string'),
220 229
 				$alert_rows,
221 230
 				array()
222 231
 			);
232
+		}
223 233
 
224 234
 		return true;
225 235
 	}
@@ -230,8 +240,9 @@  discard block
 block discarded – undo
230 240
 
231 241
 		foreach ($quotedMembers as $id => $member)
232 242
 		{
233
-			if (!isset($prefs[$id]) || $id == $posterOptions['id'] || empty($prefs[$id]['msg_quote']))
234
-				continue;
243
+			if (!isset($prefs[$id]) || $id == $posterOptions['id'] || empty($prefs[$id]['msg_quote'])) {
244
+							continue;
245
+			}
235 246
 
236 247
 			$done_members[] = $id;
237 248
 
@@ -283,32 +294,35 @@  discard block
 block discarded – undo
283 294
 		{
284 295
 			if (preg_match('/\[quote(.*)?\]/i', $block, $matches))
285 296
 			{
286
-				if ($quote_level == 0)
287
-					$message .= '[quote' . $matches[1] . ']';
297
+				if ($quote_level == 0) {
298
+									$message .= '[quote' . $matches[1] . ']';
299
+				}
288 300
 				$quote_level++;
289
-			}
290
-			elseif (preg_match('/\[\/quote\]/i', $block))
301
+			} elseif (preg_match('/\[\/quote\]/i', $block))
291 302
 			{
292
-				if ($quote_level <= 1)
293
-					$message .= '[/quote]';
303
+				if ($quote_level <= 1) {
304
+									$message .= '[/quote]';
305
+				}
294 306
 				if ($quote_level >= 1)
295 307
 				{
296 308
 					$quote_level--;
297 309
 					$message .= "\n";
298 310
 				}
311
+			} elseif ($quote_level <= 1) {
312
+							$message .= $block;
299 313
 			}
300
-			elseif ($quote_level <= 1)
301
-				$message .= $block;
302 314
 		}
303 315
 
304 316
 		preg_match_all('/\[quote.*?link=msg=([0-9]+).*?\]/i', $message, $matches);
305 317
 
306 318
 		$id_msgs = $matches[1];
307
-		foreach ($id_msgs as $k => $id_msg)
308
-			$id_msgs[$k] = (int) $id_msg;
319
+		foreach ($id_msgs as $k => $id_msg) {
320
+					$id_msgs[$k] = (int) $id_msg;
321
+		}
309 322
 
310
-		if (empty($id_msgs))
311
-			return array();
323
+		if (empty($id_msgs)) {
324
+					return array();
325
+		}
312 326
 
313 327
 		// Get the messages
314 328
 		$request = $smcFunc['db_query']('', '
@@ -326,8 +340,9 @@  discard block
 block discarded – undo
326 340
 		$members = array();
327 341
 		while ($row = $smcFunc['db_fetch_assoc']($request))
328 342
 		{
329
-			if ($posterOptions['id'] == $row['id_member'])
330
-				continue;
343
+			if ($posterOptions['id'] == $row['id_member']) {
344
+							continue;
345
+			}
331 346
 
332 347
 			$members[$row['id_member']] = $row;
333 348
 		}
@@ -341,10 +356,11 @@  discard block
 block discarded – undo
341 356
 
342 357
 		foreach ($members as $id => $member)
343 358
 		{
344
-			if (!empty($prefs[$id]['msg_mention']))
345
-				$done_members[] = $id;
346
-			else
347
-				continue;
359
+			if (!empty($prefs[$id]['msg_mention'])) {
360
+							$done_members[] = $id;
361
+			} else {
362
+							continue;
363
+			}
348 364
 
349 365
 			// Alerts' emails are always instant
350 366
 			if ($prefs[$id]['msg_mention'] & 0x02)
Please login to merge, or discard this patch.
Sources/tasks/Likes-Notify.php 1 patch
Braces   +19 added lines, -14 removed lines patch added patch discarded remove patch
@@ -51,30 +51,33 @@  discard block
 block discarded – undo
51 51
 				$ignored_members = explode(',', $row['pm_ignore_list']);
52 52
 
53 53
 				// If the user is in group 1 anywhere, they can see everything anyway.
54
-				if (in_array(1, $groups) || count(array_intersect($allowed, $groups)) != 0)
55
-					$author = $row['id_member'];
54
+				if (in_array(1, $groups) || count(array_intersect($allowed, $groups)) != 0) {
55
+									$author = $row['id_member'];
56
+				}
56 57
 			}
57 58
 			$smcFunc['db_free_result']($request);
58
-		}
59
-		else
59
+		} else
60 60
 		{
61 61
 			// This isn't something we know natively how to support. Call the hooks, if they're dealing with it, return false, otherwise return the user id.
62 62
 			$hook_results = call_integration_hook('integrate_find_like_author', array($this->_details['content_type'], $this->_details['content_id']));
63
-			foreach ($hook_results as $result)
64
-				if (!empty($result))
63
+			foreach ($hook_results as $result) {
64
+							if (!empty($result))
65 65
 				{
66 66
 					$author = $result;
67
+			}
67 68
 					break;
68 69
 				}
69 70
 		}
70 71
 
71 72
 		// If we didn't have a member... leave.
72
-		if (empty($author))
73
-			return true;
73
+		if (empty($author)) {
74
+					return true;
75
+		}
74 76
 
75 77
 		// If the person who sent the notification is the person whose content it is, do nothing.
76
-		if ($author == $this->_details['sender_id'])
77
-			return true;
78
+		if ($author == $this->_details['sender_id']) {
79
+					return true;
80
+		}
78 81
 
79 82
 		// If the person who sent the notification is on this person's ignore list, do nothing.
80 83
 		if (!empty($ignored_members) && in_array($this->_details['sender_id'], $ignored_members)) {
@@ -88,8 +91,9 @@  discard block
 block discarded – undo
88 91
 		// As a result, the value should really just be non empty.
89 92
 
90 93
 		// Check the value. If no value or it's empty, they didn't want alerts, oh well.
91
-		if (empty($prefs[$author][$this->_details['content_type'] . '_like']))
92
-			return true;
94
+		if (empty($prefs[$author][$this->_details['content_type'] . '_like'])) {
95
+					return true;
96
+		}
93 97
 
94 98
 		// Don't spam the alerts: if there is an existing unread alert of the
95 99
 		// requested type for the target user from the sender, don't make a new one.
@@ -109,8 +113,9 @@  discard block
 block discarded – undo
109 113
 			)
110 114
 		);
111 115
 
112
-		if ($smcFunc['db_num_rows']($request) > 0)
113
-			return true;
116
+		if ($smcFunc['db_num_rows']($request) > 0) {
117
+					return true;
118
+		}
114 119
 		$smcFunc['db_free_result']($request);
115 120
 
116 121
 		// Issue, update, move on.
Please login to merge, or discard this patch.
Sources/SearchAPI-Fulltext.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
 		if (!empty($modSettings['search_simple_fulltext']))
208 208
 		{
209
-			if($smcFunc['db_title'] == "PostgreSQL")
209
+			if ($smcFunc['db_title'] == "PostgreSQL")
210 210
 			{
211 211
 				$language_ftx = $smcFunc['db_search_language']();
212 212
 				
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 			// remove any indexed words that are used in the complex body search terms
225 225
 			$words['indexed_words'] = array_diff($words['indexed_words'], $words['complex_words']);
226 226
 
227
-			if($smcFunc['db_title'] == "PostgreSQL"){
227
+			if ($smcFunc['db_title'] == "PostgreSQL") {
228 228
 				$row = 0;
229 229
 				foreach ($words['indexed_words'] as $fulltextWord) {
230 230
 					$query_params['boolean_match'] .= ($row <> 0 ? '&' : '');
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 
241 241
 			// if we have bool terms to search, add them in
242 242
 			if ($query_params['boolean_match']) {
243
-				if($smcFunc['db_title'] == "PostgreSQL")
243
+				if ($smcFunc['db_title'] == "PostgreSQL")
244 244
 				{
245 245
 					$language_ftx = $smcFunc['db_search_language']();
246 246
 					
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 
254 254
 		}
255 255
 
256
-		$ignoreRequest = $smcFunc['db_search_query']('insert_into_log_messages_fulltext', ($smcFunc['db_support_ignore'] ? ( '
256
+		$ignoreRequest = $smcFunc['db_search_query']('insert_into_log_messages_fulltext', ($smcFunc['db_support_ignore'] ? ('
257 257
 			INSERT IGNORE INTO {db_prefix}' . $search_data['insert_into'] . '
258 258
 				(' . implode(', ', array_keys($query_select)) . ')') : '') . '
259 259
 			SELECT ' . implode(', ', $query_select) . '
Please login to merge, or discard this patch.
Braces   +44 added lines, -34 removed lines patch added patch discarded remove patch
@@ -11,8 +11,9 @@  discard block
 block discarded – undo
11 11
  * @version 2.1 Beta 4
12 12
  */
13 13
 
14
-if (!defined('SMF'))
14
+if (!defined('SMF')) {
15 15
 	die('No direct access...');
16
+}
16 17
 
17 18
 /**
18 19
  * Class fulltext_search
@@ -98,8 +99,9 @@  discard block
 block discarded – undo
98 99
 			$smcFunc['db_free_result']($request);
99 100
 		}
100 101
 		// 4 is the MySQL default...
101
-		else
102
-			$min_word_length = 4;
102
+		else {
103
+					$min_word_length = 4;
104
+		}
103 105
 
104 106
 		return $min_word_length;
105 107
 	}
@@ -138,8 +140,7 @@  discard block
 block discarded – undo
138 140
 					$wordsSearch['words'][] = trim($word, "/*- ");
139 141
 					$wordsSearch['complex_words'][] = count($subwords) === 1 ? $word : '"' . $word . '"';
140 142
 				}
141
-			}
142
-			elseif ($smcFunc['strlen'](trim($word, "/*- ")) < $this->min_word_length)
143
+			} elseif ($smcFunc['strlen'](trim($word, "/*- ")) < $this->min_word_length)
143 144
 			{
144 145
 				// short words have feelings too
145 146
 				$wordsSearch['words'][] = trim($word, "/*- ");
@@ -149,8 +150,9 @@  discard block
 block discarded – undo
149 150
 
150 151
 		$fulltextWord = count($subwords) === 1 ? $word : '"' . $word . '"';
151 152
 		$wordsSearch['indexed_words'][] = $fulltextWord;
152
-		if ($isExcluded)
153
-			$wordsExclude[] = $fulltextWord;
153
+		if ($isExcluded) {
154
+					$wordsExclude[] = $fulltextWord;
155
+		}
154 156
 	}
155 157
 
156 158
 	/**
@@ -166,41 +168,50 @@  discard block
 block discarded – undo
166 168
 		$query_where = array();
167 169
 		$query_params = $search_data['params'];
168 170
 
169
-		if ($query_params['id_search'])
170
-			$query_select['id_search'] = '{int:id_search}';
171
+		if ($query_params['id_search']) {
172
+					$query_select['id_search'] = '{int:id_search}';
173
+		}
171 174
 
172 175
 		$count = 0;
173
-		if (empty($modSettings['search_simple_fulltext']))
174
-			foreach ($words['words'] as $regularWord)
176
+		if (empty($modSettings['search_simple_fulltext'])) {
177
+					foreach ($words['words'] as $regularWord)
175 178
 			{
176 179
 				$query_where[] = 'm.body' . (in_array($regularWord, $query_params['excluded_words']) ? ' NOT' : '') . (empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? ' LIKE ' : 'RLIKE') . '{string:complex_body_' . $count . '}';
180
+		}
177 181
 				$query_params['complex_body_' . $count++] = empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? '%' . strtr($regularWord, array('_' => '\\_', '%' => '\\%')) . '%' : '[[:<:]]' . addcslashes(preg_replace(array('/([\[\]$.+*?|{}()])/'), array('[$1]'), $regularWord), '\\\'') . '[[:>:]]';
178 182
 			}
179 183
 
180
-		if ($query_params['user_query'])
181
-			$query_where[] = '{raw:user_query}';
182
-		if ($query_params['board_query'])
183
-			$query_where[] = 'm.id_board {raw:board_query}';
184
+		if ($query_params['user_query']) {
185
+					$query_where[] = '{raw:user_query}';
186
+		}
187
+		if ($query_params['board_query']) {
188
+					$query_where[] = 'm.id_board {raw:board_query}';
189
+		}
184 190
 
185
-		if ($query_params['topic'])
186
-			$query_where[] = 'm.id_topic = {int:topic}';
187
-		if ($query_params['min_msg_id'])
188
-			$query_where[] = 'm.id_msg >= {int:min_msg_id}';
189
-		if ($query_params['max_msg_id'])
190
-			$query_where[] = 'm.id_msg <= {int:max_msg_id}';
191
+		if ($query_params['topic']) {
192
+					$query_where[] = 'm.id_topic = {int:topic}';
193
+		}
194
+		if ($query_params['min_msg_id']) {
195
+					$query_where[] = 'm.id_msg >= {int:min_msg_id}';
196
+		}
197
+		if ($query_params['max_msg_id']) {
198
+					$query_where[] = 'm.id_msg <= {int:max_msg_id}';
199
+		}
191 200
 
192 201
 		$count = 0;
193
-		if (!empty($query_params['excluded_phrases']) && empty($modSettings['search_force_index']))
194
-			foreach ($query_params['excluded_phrases'] as $phrase)
202
+		if (!empty($query_params['excluded_phrases']) && empty($modSettings['search_force_index'])) {
203
+					foreach ($query_params['excluded_phrases'] as $phrase)
195 204
 			{
196 205
 				$query_where[] = 'subject NOT ' . (empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? ' LIKE ' : 'RLIKE') . '{string:exclude_subject_phrase_' . $count . '}';
206
+		}
197 207
 				$query_params['exclude_subject_phrase_' . $count++] = empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? '%' . strtr($phrase, array('_' => '\\_', '%' => '\\%')) . '%' : '[[:<:]]' . addcslashes(preg_replace(array('/([\[\]$.+*?|{}()])/'), array('[$1]'), $phrase), '\\\'') . '[[:>:]]';
198 208
 			}
199 209
 		$count = 0;
200
-		if (!empty($query_params['excluded_subject_words']) && empty($modSettings['search_force_index']))
201
-			foreach ($query_params['excluded_subject_words'] as $excludedWord)
210
+		if (!empty($query_params['excluded_subject_words']) && empty($modSettings['search_force_index'])) {
211
+					foreach ($query_params['excluded_subject_words'] as $excludedWord)
202 212
 			{
203 213
 				$query_where[] = 'subject NOT ' . (empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? ' LIKE ' : 'RLIKE') . '{string:exclude_subject_words_' . $count . '}';
214
+		}
204 215
 				$query_params['exclude_subject_words_' . $count++] = empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? '%' . strtr($excludedWord, array('_' => '\\_', '%' => '\\%')) . '%' : '[[:<:]]' . addcslashes(preg_replace(array('/([\[\]$.+*?|{}()])/'), array('[$1]'), $excludedWord), '\\\'') . '[[:>:]]';
205 216
 			}
206 217
 
@@ -212,12 +223,11 @@  discard block
 block discarded – undo
212 223
 
213 224
 				$query_where[] = 'to_tsvector({string:language_ftx},body) @@ to_tsquery({string:language_ftx},{string:body_match})';
214 225
 				$query_params['language_ftx'] = $language_ftx;
226
+			} else {
227
+							$query_where[] = 'MATCH (body) AGAINST ({string:body_match})';
215 228
 			}
216
-			else
217
-				$query_where[] = 'MATCH (body) AGAINST ({string:body_match})';
218 229
 			$query_params['body_match'] = implode(' ', array_diff($words['indexed_words'], $query_params['excluded_index_words']));
219
-		}
220
-		else
230
+		} else
221 231
 		{
222 232
 			$query_params['boolean_match'] = '';
223 233
 
@@ -231,10 +241,10 @@  discard block
 block discarded – undo
231 241
 					$query_params['boolean_match'] .= (in_array($fulltextWord, $query_params['excluded_index_words']) ? '!' : '') . $fulltextWord . ' ';
232 242
 					$row++;
233 243
 				}
234
-			}
235
-			else
236
-				foreach ($words['indexed_words'] as $fulltextWord)
244
+			} else {
245
+							foreach ($words['indexed_words'] as $fulltextWord)
237 246
 					$query_params['boolean_match'] .= (in_array($fulltextWord, $query_params['excluded_index_words']) ? '-' : '+') . $fulltextWord . ' ';
247
+			}
238 248
 
239 249
 			$query_params['boolean_match'] = substr($query_params['boolean_match'], 0, -1);
240 250
 
@@ -246,9 +256,9 @@  discard block
 block discarded – undo
246 256
 
247 257
 					$query_where[] = 'to_tsvector({string:language_ftx},body) @@ to_tsquery({string:language_ftx},{string:boolean_match})';
248 258
 					$query_params['language_ftx'] = $language_ftx;
259
+				} else {
260
+									$query_where[] = 'MATCH (body) AGAINST ({string:boolean_match} IN BOOLEAN MODE)';
249 261
 				}
250
-				else
251
-					$query_where[] = 'MATCH (body) AGAINST ({string:boolean_match} IN BOOLEAN MODE)';
252 262
 			}
253 263
 
254 264
 		}
Please login to merge, or discard this patch.
Sources/Post.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -256,8 +256,8 @@  discard block
 block discarded – undo
256 256
 			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
257 257
 
258 258
 		$js_time_string = str_replace(
259
-			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
260
-			array('H',  'G',  'h',  'g',  'i',  'A',  'a',  'h:i:s A', 'H:i', 's',  'H:i:s', 'H:i:s'),
259
+			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'),
260
+			array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'),
261 261
 			$time_string
262 262
 		);
263 263
 
@@ -1306,14 +1306,14 @@  discard block
 block discarded – undo
1306 1306
 	if (isset($context['name']) && isset($context['email']))
1307 1307
 	{
1308 1308
 		$context['posting_fields']['guestname'] = array(
1309
-			'dt' => '<span id="caption_guestname"' .  (isset($context['post_error']['long_name']) || isset($context['post_error']['no_name']) || isset($context['post_error']['bad_name']) ? ' class="error"' : '') . '>' . $txt['name'] . '</span>',
1309
+			'dt' => '<span id="caption_guestname"' . (isset($context['post_error']['long_name']) || isset($context['post_error']['no_name']) || isset($context['post_error']['bad_name']) ? ' class="error"' : '') . '>' . $txt['name'] . '</span>',
1310 1310
 			'dd' => '<input type="text" name="guestname" size="25" value="' . $context['name'] . '" class="input_text" required>',
1311 1311
 		);
1312 1312
 
1313 1313
 		if (empty($modSettings['guest_post_no_email']))
1314 1314
 		{
1315 1315
 			$context['posting_fields']['email'] = array(
1316
-				'dt' => '<span id="caption_email"' .  (isset($context['post_error']['no_email']) || isset($context['post_error']['bad_email']) ? ' class="error"' : '') . '>' . $txt['email'] . '</span>',
1316
+				'dt' => '<span id="caption_email"' . (isset($context['post_error']['no_email']) || isset($context['post_error']['bad_email']) ? ' class="error"' : '') . '>' . $txt['email'] . '</span>',
1317 1317
 				'dd' => '<input type="email" name="email" size="25" value="' . $context['email'] . '" class="input_text" required>',
1318 1318
 			);
1319 1319
 		}
Please login to merge, or discard this patch.
Braces   +659 added lines, -511 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Handles showing the post screen, loading the post to be modified, and loading any post quoted.
@@ -35,12 +36,14 @@  discard block
 block discarded – undo
35 36
 	global $sourcedir, $smcFunc, $language;
36 37
 
37 38
 	loadLanguage('Post');
38
-	if (!empty($modSettings['drafts_post_enabled']))
39
-		loadLanguage('Drafts');
39
+	if (!empty($modSettings['drafts_post_enabled'])) {
40
+			loadLanguage('Drafts');
41
+	}
40 42
 
41 43
 	// You can't reply with a poll... hacker.
42
-	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg']))
43
-		unset($_REQUEST['poll']);
44
+	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg'])) {
45
+			unset($_REQUEST['poll']);
46
+	}
44 47
 
45 48
 	// Posting an event?
46 49
 	$context['make_event'] = isset($_REQUEST['calendar']);
@@ -54,8 +57,9 @@  discard block
 block discarded – undo
54 57
 	$context['auto_notify'] = !empty($context['notify_prefs']['msg_auto_notify']);
55 58
 
56 59
 	// You must be posting to *some* board.
57
-	if (empty($board) && !$context['make_event'])
58
-		fatal_lang_error('no_board', false);
60
+	if (empty($board) && !$context['make_event']) {
61
+			fatal_lang_error('no_board', false);
62
+	}
59 63
 
60 64
 	require_once($sourcedir . '/Subs-Post.php');
61 65
 
@@ -78,10 +82,11 @@  discard block
 block discarded – undo
78 82
 			array(
79 83
 				'msg' => (int) $_REQUEST['msg'],
80 84
 		));
81
-		if ($smcFunc['db_num_rows']($request) != 1)
82
-			unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
83
-		else
84
-			list ($topic) = $smcFunc['db_fetch_row']($request);
85
+		if ($smcFunc['db_num_rows']($request) != 1) {
86
+					unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
87
+		} else {
88
+					list ($topic) = $smcFunc['db_fetch_row']($request);
89
+		}
85 90
 		$smcFunc['db_free_result']($request);
86 91
 	}
87 92
 
@@ -108,33 +113,36 @@  discard block
 block discarded – undo
108 113
 		$smcFunc['db_free_result']($request);
109 114
 
110 115
 		// If this topic already has a poll, they sure can't add another.
111
-		if (isset($_REQUEST['poll']) && $pollID > 0)
112
-			unset($_REQUEST['poll']);
116
+		if (isset($_REQUEST['poll']) && $pollID > 0) {
117
+					unset($_REQUEST['poll']);
118
+		}
113 119
 
114 120
 		if (empty($_REQUEST['msg']))
115 121
 		{
116
-			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any')))
117
-				is_not_guest();
122
+			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any'))) {
123
+							is_not_guest();
124
+			}
118 125
 
119 126
 			// By default the reply will be approved...
120 127
 			$context['becomes_approved'] = true;
121 128
 			if ($id_member_poster != $user_info['id'] || $user_info['is_guest'])
122 129
 			{
123
-				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
124
-					$context['becomes_approved'] = false;
125
-				else
126
-					isAllowedTo('post_reply_any');
127
-			}
128
-			elseif (!allowedTo('post_reply_any'))
130
+				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
131
+									$context['becomes_approved'] = false;
132
+				} else {
133
+									isAllowedTo('post_reply_any');
134
+				}
135
+			} elseif (!allowedTo('post_reply_any'))
129 136
 			{
130
-				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any')))
131
-					$context['becomes_approved'] = false;
132
-				else
133
-					isAllowedTo('post_reply_own');
137
+				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any'))) {
138
+									$context['becomes_approved'] = false;
139
+				} else {
140
+									isAllowedTo('post_reply_own');
141
+				}
134 142
 			}
143
+		} else {
144
+					$context['becomes_approved'] = true;
135 145
 		}
136
-		else
137
-			$context['becomes_approved'] = true;
138 146
 
139 147
 		$context['can_lock'] = allowedTo('lock_any') || ($user_info['id'] == $id_member_poster && allowedTo('lock_own'));
140 148
 		$context['can_sticky'] = allowedTo('make_sticky');
@@ -146,18 +154,19 @@  discard block
 block discarded – undo
146 154
 		$context['sticky'] = isset($_REQUEST['sticky']) ? !empty($_REQUEST['sticky']) : $sticky;
147 155
 
148 156
 		// Check whether this is a really old post being bumped...
149
-		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject']))
150
-			$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
151
-	}
152
-	else
157
+		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject'])) {
158
+					$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
159
+		}
160
+	} else
153 161
 	{
154 162
 		$context['becomes_approved'] = true;
155 163
 		if ((!$context['make_event'] || !empty($board)))
156 164
 		{
157
-			if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics'))
158
-				$context['becomes_approved'] = false;
159
-			else
160
-				isAllowedTo('post_new');
165
+			if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) {
166
+							$context['becomes_approved'] = false;
167
+			} else {
168
+							isAllowedTo('post_new');
169
+			}
161 170
 		}
162 171
 
163 172
 		$locked = 0;
@@ -193,20 +202,24 @@  discard block
 block discarded – undo
193 202
 	}
194 203
 
195 204
 	// Don't allow a post if it's locked and you aren't all powerful.
196
-	if ($locked && !allowedTo('moderate_board'))
197
-		fatal_lang_error('topic_locked', false);
205
+	if ($locked && !allowedTo('moderate_board')) {
206
+			fatal_lang_error('topic_locked', false);
207
+	}
198 208
 	// Check the users permissions - is the user allowed to add or post a poll?
199 209
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
200 210
 	{
201 211
 		// New topic, new poll.
202
-		if (empty($topic))
203
-			isAllowedTo('poll_post');
212
+		if (empty($topic)) {
213
+					isAllowedTo('poll_post');
214
+		}
204 215
 		// This is an old topic - but it is yours!  Can you add to it?
205
-		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any'))
206
-			isAllowedTo('poll_add_own');
216
+		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any')) {
217
+					isAllowedTo('poll_add_own');
218
+		}
207 219
 		// If you're not the owner, can you add to any poll?
208
-		else
209
-			isAllowedTo('poll_add_any');
220
+		else {
221
+					isAllowedTo('poll_add_any');
222
+		}
210 223
 
211 224
 		require_once($sourcedir . '/Subs-Members.php');
212 225
 		$allowedVoteGroups = groupsAllowedTo('poll_vote', $board);
@@ -235,8 +248,9 @@  discard block
 block discarded – undo
235 248
 	if ($context['make_event'])
236 249
 	{
237 250
 		// They might want to pick a board.
238
-		if (!isset($context['current_board']))
239
-			$context['current_board'] = 0;
251
+		if (!isset($context['current_board'])) {
252
+					$context['current_board'] = 0;
253
+		}
240 254
 
241 255
 		// Start loading up the event info.
242 256
 		$context['event'] = array();
@@ -250,10 +264,11 @@  discard block
 block discarded – undo
250 264
 		isAllowedTo('calendar_post');
251 265
 
252 266
 		// We want a fairly compact version of the time, but as close as possible to the user's settings.
253
-		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
254
-			$time_string = '%k:%M';
255
-		else
256
-			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
267
+		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
268
+					$time_string = '%k:%M';
269
+		} else {
270
+					$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
271
+		}
257 272
 
258 273
 		$js_time_string = str_replace(
259 274
 			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
@@ -275,8 +290,7 @@  discard block
 block discarded – undo
275 290
 			require_once($sourcedir . '/Subs-Calendar.php');
276 291
 			$eventProperties = getEventProperties($context['event']['id']);
277 292
 			$context['event'] = array_merge($context['event'], $eventProperties);
278
-		}
279
-		else
293
+		} else
280 294
 		{
281 295
 			// Get the current event information.
282 296
 			require_once($sourcedir . '/Subs-Calendar.php');
@@ -284,15 +298,18 @@  discard block
 block discarded – undo
284 298
 			$context['event'] = array_merge($context['event'], $eventProperties);
285 299
 
286 300
 			// Make sure the year and month are in the valid range.
287
-			if ($context['event']['month'] < 1 || $context['event']['month'] > 12)
288
-				fatal_lang_error('invalid_month', false);
289
-			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear'])
290
-				fatal_lang_error('invalid_year', false);
301
+			if ($context['event']['month'] < 1 || $context['event']['month'] > 12) {
302
+							fatal_lang_error('invalid_month', false);
303
+			}
304
+			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear']) {
305
+							fatal_lang_error('invalid_year', false);
306
+			}
291 307
 
292 308
 			// Get a list of boards they can post in.
293 309
 			$boards = boardsAllowedTo('post_new');
294
-			if (empty($boards))
295
-				fatal_lang_error('cannot_post_new', 'user');
310
+			if (empty($boards)) {
311
+							fatal_lang_error('cannot_post_new', 'user');
312
+			}
296 313
 
297 314
 			// Load a list of boards for this event in the context.
298 315
 			require_once($sourcedir . '/Subs-MessageIndex.php');
@@ -411,10 +428,11 @@  discard block
 block discarded – undo
411 428
 
412 429
 			if (!empty($context['new_replies']))
413 430
 			{
414
-				if ($context['new_replies'] == 1)
415
-					$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
416
-				else
417
-					$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
431
+				if ($context['new_replies'] == 1) {
432
+									$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
433
+				} else {
434
+									$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
435
+				}
418 436
 
419 437
 				$post_errors[] = 'new_replies';
420 438
 
@@ -426,9 +444,9 @@  discard block
 block discarded – undo
426 444
 	// Get a response prefix (like 'Re:') in the default forum language.
427 445
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
428 446
 	{
429
-		if ($language === $user_info['language'])
430
-			$context['response_prefix'] = $txt['response_prefix'];
431
-		else
447
+		if ($language === $user_info['language']) {
448
+					$context['response_prefix'] = $txt['response_prefix'];
449
+		} else
432 450
 		{
433 451
 			loadLanguage('index', $language, false);
434 452
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -441,8 +459,9 @@  discard block
 block discarded – undo
441 459
 	// Do we have a body, but an error happened.
442 460
 	if (isset($_REQUEST['message']) || isset($_REQUEST['quickReply']) || !empty($context['post_error']))
443 461
 	{
444
-		if (isset($_REQUEST['quickReply']))
445
-			$_REQUEST['message'] = $_REQUEST['quickReply'];
462
+		if (isset($_REQUEST['quickReply'])) {
463
+					$_REQUEST['message'] = $_REQUEST['quickReply'];
464
+		}
446 465
 
447 466
 		// Validate inputs.
448 467
 		if (empty($context['post_error']))
@@ -450,15 +469,17 @@  discard block
 block discarded – undo
450 469
 			// This means they didn't click Post and get an error.
451 470
 			$really_previewing = true;
452 471
 
453
-		}
454
-		else
472
+		} else
455 473
 		{
456
-			if (!isset($_REQUEST['subject']))
457
-				$_REQUEST['subject'] = '';
458
-			if (!isset($_REQUEST['message']))
459
-				$_REQUEST['message'] = '';
460
-			if (!isset($_REQUEST['icon']))
461
-				$_REQUEST['icon'] = 'xx';
474
+			if (!isset($_REQUEST['subject'])) {
475
+							$_REQUEST['subject'] = '';
476
+			}
477
+			if (!isset($_REQUEST['message'])) {
478
+							$_REQUEST['message'] = '';
479
+			}
480
+			if (!isset($_REQUEST['icon'])) {
481
+							$_REQUEST['icon'] = 'xx';
482
+			}
462 483
 
463 484
 			// They are previewing if they asked to preview (i.e. came from quick reply).
464 485
 			$really_previewing = !empty($_POST['preview']);
@@ -474,8 +495,9 @@  discard block
 block discarded – undo
474 495
 		$form_message = $smcFunc['htmlspecialchars']($_REQUEST['message'], ENT_QUOTES);
475 496
 
476 497
 		// Make sure the subject isn't too long - taking into account special characters.
477
-		if ($smcFunc['strlen']($form_subject) > 100)
478
-			$form_subject = $smcFunc['substr']($form_subject, 0, 100);
498
+		if ($smcFunc['strlen']($form_subject) > 100) {
499
+					$form_subject = $smcFunc['substr']($form_subject, 0, 100);
500
+		}
479 501
 
480 502
 		if (isset($_REQUEST['poll']))
481 503
 		{
@@ -487,8 +509,9 @@  discard block
 block discarded – undo
487 509
 			$_POST['options'] = empty($_POST['options']) ? array() : htmlspecialchars__recursive($_POST['options']);
488 510
 			foreach ($_POST['options'] as $option)
489 511
 			{
490
-				if (trim($option) == '')
491
-					continue;
512
+				if (trim($option) == '') {
513
+									continue;
514
+				}
492 515
 
493 516
 				$context['choices'][] = array(
494 517
 					'id' => $choice_id++,
@@ -550,13 +573,14 @@  discard block
 block discarded – undo
550 573
 				$context['preview_subject'] = $form_subject;
551 574
 
552 575
 				censorText($context['preview_subject']);
576
+			} else {
577
+							$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
553 578
 			}
554
-			else
555
-				$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
556 579
 
557 580
 			// Protect any CDATA blocks.
558
-			if (isset($_REQUEST['xml']))
559
-				$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
581
+			if (isset($_REQUEST['xml'])) {
582
+							$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
583
+			}
560 584
 		}
561 585
 
562 586
 		// Set up the checkboxes.
@@ -595,29 +619,32 @@  discard block
 block discarded – undo
595 619
 			);
596 620
 			// The message they were trying to edit was most likely deleted.
597 621
 			// @todo Change this error message?
598
-			if ($smcFunc['db_num_rows']($request) == 0)
599
-				fatal_lang_error('no_board', false);
622
+			if ($smcFunc['db_num_rows']($request) == 0) {
623
+							fatal_lang_error('no_board', false);
624
+			}
600 625
 			$row = $smcFunc['db_fetch_assoc']($request);
601 626
 
602 627
 			$attachment_stuff = array($row);
603
-			while ($row2 = $smcFunc['db_fetch_assoc']($request))
604
-				$attachment_stuff[] = $row2;
628
+			while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
629
+							$attachment_stuff[] = $row2;
630
+			}
605 631
 			$smcFunc['db_free_result']($request);
606 632
 
607 633
 			if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
608 634
 			{
609 635
 				// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
610
-				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
611
-					fatal_lang_error('modify_post_time_passed', false);
612
-				elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
613
-					isAllowedTo('modify_replies');
614
-				else
615
-					isAllowedTo('modify_own');
636
+				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
637
+									fatal_lang_error('modify_post_time_passed', false);
638
+				} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
639
+									isAllowedTo('modify_replies');
640
+				} else {
641
+									isAllowedTo('modify_own');
642
+				}
643
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
644
+							isAllowedTo('modify_replies');
645
+			} else {
646
+							isAllowedTo('modify_any');
616 647
 			}
617
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
618
-				isAllowedTo('modify_replies');
619
-			else
620
-				isAllowedTo('modify_any');
621 648
 
622 649
 			if ($context['can_announce'] && !empty($row['id_action']))
623 650
 			{
@@ -641,8 +668,9 @@  discard block
 block discarded – undo
641 668
 
642 669
 				while ($row = $smcFunc['db_fetch_assoc']($request))
643 670
 				{
644
-					if ($row['filesize'] <= 0)
645
-						continue;
671
+					if ($row['filesize'] <= 0) {
672
+											continue;
673
+					}
646 674
 					$context['current_attachments'][$row['id_attach']] = array(
647 675
 						'name' => $smcFunc['htmlspecialchars']($row['filename']),
648 676
 						'size' => $row['filesize'],
@@ -712,29 +740,32 @@  discard block
 block discarded – undo
712 740
 			)
713 741
 		);
714 742
 		// The message they were trying to edit was most likely deleted.
715
-		if ($smcFunc['db_num_rows']($request) == 0)
716
-			fatal_lang_error('no_message', false);
743
+		if ($smcFunc['db_num_rows']($request) == 0) {
744
+					fatal_lang_error('no_message', false);
745
+		}
717 746
 		$row = $smcFunc['db_fetch_assoc']($request);
718 747
 
719 748
 		$attachment_stuff = array($row);
720
-		while ($row2 = $smcFunc['db_fetch_assoc']($request))
721
-			$attachment_stuff[] = $row2;
749
+		while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
750
+					$attachment_stuff[] = $row2;
751
+		}
722 752
 		$smcFunc['db_free_result']($request);
723 753
 
724 754
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
725 755
 		{
726 756
 			// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
727
-			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
728
-				fatal_lang_error('modify_post_time_passed', false);
729
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
730
-				isAllowedTo('modify_replies');
731
-			else
732
-				isAllowedTo('modify_own');
757
+			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
758
+							fatal_lang_error('modify_post_time_passed', false);
759
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
760
+							isAllowedTo('modify_replies');
761
+			} else {
762
+							isAllowedTo('modify_own');
763
+			}
764
+		} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
765
+					isAllowedTo('modify_replies');
766
+		} else {
767
+					isAllowedTo('modify_any');
733 768
 		}
734
-		elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
735
-			isAllowedTo('modify_replies');
736
-		else
737
-			isAllowedTo('modify_any');
738 769
 
739 770
 		if ($context['can_announce'] && !empty($row['id_action']))
740 771
 		{
@@ -761,15 +792,17 @@  discard block
 block discarded – undo
761 792
 		$context['icon'] = $row['icon'];
762 793
 
763 794
 		// Show an "approve" box if the user can approve it, and the message isn't approved.
764
-		if (!$row['approved'] && !$context['show_approval'])
765
-			$context['show_approval'] = allowedTo('approve_posts');
795
+		if (!$row['approved'] && !$context['show_approval']) {
796
+					$context['show_approval'] = allowedTo('approve_posts');
797
+		}
766 798
 
767 799
 		// Sort the attachments so they are in the order saved
768 800
 		$temp = array();
769 801
 		foreach ($attachment_stuff as $attachment)
770 802
 		{
771
-			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable']))
772
-				$temp[$attachment['id_attach']] = $attachment;
803
+			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable'])) {
804
+							$temp[$attachment['id_attach']] = $attachment;
805
+			}
773 806
 
774 807
 		}
775 808
 		ksort($temp);
@@ -831,14 +864,16 @@  discard block
 block discarded – undo
831 864
 					'is_approved' => 1,
832 865
 				)
833 866
 			);
834
-			if ($smcFunc['db_num_rows']($request) == 0)
835
-				fatal_lang_error('quoted_post_deleted', false);
867
+			if ($smcFunc['db_num_rows']($request) == 0) {
868
+							fatal_lang_error('quoted_post_deleted', false);
869
+			}
836 870
 			list ($form_subject, $mname, $mdate, $form_message) = $smcFunc['db_fetch_row']($request);
837 871
 			$smcFunc['db_free_result']($request);
838 872
 
839 873
 			// Add 'Re: ' to the front of the quoted subject.
840
-			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
841
-				$form_subject = $context['response_prefix'] . $form_subject;
874
+			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
875
+							$form_subject = $context['response_prefix'] . $form_subject;
876
+			}
842 877
 
843 878
 			// Censor the message and subject.
844 879
 			censorText($form_message);
@@ -851,10 +886,11 @@  discard block
 block discarded – undo
851 886
 				for ($i = 0, $n = count($parts); $i < $n; $i++)
852 887
 				{
853 888
 					// It goes 0 = outside, 1 = begin tag, 2 = inside, 3 = close tag, repeat.
854
-					if ($i % 4 == 0)
855
-						$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
889
+					if ($i % 4 == 0) {
890
+											$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
856 891
 						{
857 892
 							return '[html]' . preg_replace('~<br\s?/?' . '>~i', '&lt;br /&gt;<br>', "$m[1]") . '[/html]';
893
+					}
858 894
 						}, $parts[$i]);
859 895
 				}
860 896
 				$form_message = implode('', $parts);
@@ -863,8 +899,9 @@  discard block
 block discarded – undo
863 899
 			$form_message = preg_replace('~<br ?/?' . '>~i', "\n", $form_message);
864 900
 
865 901
 			// Remove any nested quotes, if necessary.
866
-			if (!empty($modSettings['removeNestedQuotes']))
867
-				$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
902
+			if (!empty($modSettings['removeNestedQuotes'])) {
903
+							$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
904
+			}
868 905
 
869 906
 			// Add a quote string on the front and end.
870 907
 			$form_message = '[quote author=' . $mname . ' link=msg=' . (int) $_REQUEST['quote'] . ' date=' . $mdate . ']' . "\n" . rtrim($form_message) . "\n" . '[/quote]';
@@ -876,15 +913,15 @@  discard block
 block discarded – undo
876 913
 			$form_subject = $first_subject;
877 914
 
878 915
 			// Add 'Re: ' to the front of the subject.
879
-			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
880
-				$form_subject = $context['response_prefix'] . $form_subject;
916
+			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
917
+							$form_subject = $context['response_prefix'] . $form_subject;
918
+			}
881 919
 
882 920
 			// Censor the subject.
883 921
 			censorText($form_subject);
884 922
 
885 923
 			$form_message = '';
886
-		}
887
-		else
924
+		} else
888 925
 		{
889 926
 			$form_subject = isset($_GET['subject']) ? $_GET['subject'] : '';
890 927
 			$form_message = '';
@@ -902,13 +939,15 @@  discard block
 block discarded – undo
902 939
 		if (isset($_REQUEST['msg']))
903 940
 		{
904 941
 			$context['attachments']['quantity'] = count($context['current_attachments']);
905
-			foreach ($context['current_attachments'] as $attachment)
906
-				$context['attachments']['total_size'] += $attachment['size'];
942
+			foreach ($context['current_attachments'] as $attachment) {
943
+							$context['attachments']['total_size'] += $attachment['size'];
944
+			}
907 945
 		}
908 946
 
909 947
 		// A bit of house keeping first.
910
-		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1)
911
-			unset($_SESSION['temp_attachments']);
948
+		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1) {
949
+					unset($_SESSION['temp_attachments']);
950
+		}
912 951
 
913 952
 		if (!empty($_SESSION['temp_attachments']))
914 953
 		{
@@ -917,9 +956,10 @@  discard block
 block discarded – undo
917 956
 			{
918 957
 				foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
919 958
 				{
920
-					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
921
-						if (file_exists($attachment['tmp_name']))
959
+					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) {
960
+											if (file_exists($attachment['tmp_name']))
922 961
 							unlink($attachment['tmp_name']);
962
+					}
923 963
 				}
924 964
 				$post_errors[] = 'temp_attachments_gone';
925 965
 				$_SESSION['temp_attachments'] = array();
@@ -933,8 +973,9 @@  discard block
 block discarded – undo
933 973
 					// See if any files still exist before showing the warning message and the files attached.
934 974
 					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
935 975
 					{
936
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
937
-							continue;
976
+						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
977
+													continue;
978
+						}
938 979
 
939 980
 						if (file_exists($attachment['tmp_name']))
940 981
 						{
@@ -944,20 +985,21 @@  discard block
 block discarded – undo
944 985
 							break;
945 986
 						}
946 987
 					}
947
-				}
948
-				else
988
+				} else
949 989
 				{
950 990
 					// Since, they don't belong here. Let's inform the user that they exist..
951
-					if (!empty($topic))
952
-						$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
953
-					else
954
-						$delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp';
991
+					if (!empty($topic)) {
992
+											$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
993
+					} else {
994
+											$delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp';
995
+					}
955 996
 
956 997
 					// Compile a list of the files to show the user.
957 998
 					$file_list = array();
958
-					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
959
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
999
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) {
1000
+											if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
960 1001
 							$file_list[] = $attachment['name'];
1002
+					}
961 1003
 
962 1004
 					$_SESSION['temp_attachments']['post']['files'] = $file_list;
963 1005
 					$file_list = '<div class="attachments">' . implode('<br>', $file_list) . '</div>';
@@ -969,8 +1011,7 @@  discard block
 block discarded – undo
969 1011
 
970 1012
 						$post_errors[] = array('temp_attachments_found', array($delete_url, $goback_url, $file_list));
971 1013
 						$context['ignore_temp_attachments'] = true;
972
-					}
973
-					else
1014
+					} else
974 1015
 					{
975 1016
 						$post_errors[] = array('temp_attachments_lost', array($delete_url, $file_list));
976 1017
 						$context['ignore_temp_attachments'] = true;
@@ -978,16 +1019,19 @@  discard block
 block discarded – undo
978 1019
 				}
979 1020
 			}
980 1021
 
981
-			if (!empty($context['we_are_history']))
982
-				$post_errors[] = $context['we_are_history'];
1022
+			if (!empty($context['we_are_history'])) {
1023
+							$post_errors[] = $context['we_are_history'];
1024
+			}
983 1025
 
984 1026
 			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
985 1027
 			{
986
-				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files']))
987
-					break;
1028
+				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files'])) {
1029
+									break;
1030
+				}
988 1031
 
989
-				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
990
-					continue;
1032
+				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
1033
+									continue;
1034
+				}
991 1035
 
992 1036
 				if ($attachID == 'initial_error')
993 1037
 				{
@@ -1002,15 +1046,17 @@  discard block
 block discarded – undo
1002 1046
 				{
1003 1047
 					$txt['error_attach_errors'] = empty($txt['error_attach_errors']) ? '<br>' : '';
1004 1048
 					$txt['error_attach_errors'] .= vsprintf($txt['attach_warning'], $attachment['name']) . '<div style="padding: 0 1em;">';
1005
-					foreach ($attachment['errors'] as $error)
1006
-						$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1049
+					foreach ($attachment['errors'] as $error) {
1050
+											$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1051
+					}
1007 1052
 					$txt['error_attach_errors'] .= '</div>';
1008 1053
 					$post_errors[] = 'attach_errors';
1009 1054
 
1010 1055
 					// Take out the trash.
1011 1056
 					unset($_SESSION['temp_attachments'][$attachID]);
1012
-					if (file_exists($attachment['tmp_name']))
1013
-						unlink($attachment['tmp_name']);
1057
+					if (file_exists($attachment['tmp_name'])) {
1058
+											unlink($attachment['tmp_name']);
1059
+					}
1014 1060
 					continue;
1015 1061
 				}
1016 1062
 
@@ -1023,8 +1069,9 @@  discard block
 block discarded – undo
1023 1069
 
1024 1070
 				$context['attachments']['quantity']++;
1025 1071
 				$context['attachments']['total_size'] += $attachment['size'];
1026
-				if (!isset($context['files_in_session_warning']))
1027
-					$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1072
+				if (!isset($context['files_in_session_warning'])) {
1073
+									$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1074
+				}
1028 1075
 
1029 1076
 				$context['current_attachments'][$attachID] = array(
1030 1077
 					'name' => '<u>' . $smcFunc['htmlspecialchars']($attachment['name']) . '</u>',
@@ -1052,8 +1099,9 @@  discard block
 block discarded – undo
1052 1099
 	}
1053 1100
 
1054 1101
 	// If they came from quick reply, and have to enter verification details, give them some notice.
1055
-	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification']))
1056
-		$post_errors[] = 'need_qr_verification';
1102
+	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification'])) {
1103
+			$post_errors[] = 'need_qr_verification';
1104
+	}
1057 1105
 
1058 1106
 	/*
1059 1107
 	 * There are two error types: serious and minor. Serious errors
@@ -1070,52 +1118,56 @@  discard block
 block discarded – undo
1070 1118
 	{
1071 1119
 		loadLanguage('Errors');
1072 1120
 		$context['error_type'] = 'minor';
1073
-		foreach ($post_errors as $post_error)
1074
-			if (is_array($post_error))
1121
+		foreach ($post_errors as $post_error) {
1122
+					if (is_array($post_error))
1075 1123
 			{
1076 1124
 				$post_error_id = $post_error[0];
1125
+		}
1077 1126
 				$context['post_error'][$post_error_id] = vsprintf($txt['error_' . $post_error_id], $post_error[1]);
1078 1127
 
1079 1128
 				// If it's not a minor error flag it as such.
1080
-				if (!in_array($post_error_id, $minor_errors))
1081
-					$context['error_type'] = 'serious';
1082
-			}
1083
-			else
1129
+				if (!in_array($post_error_id, $minor_errors)) {
1130
+									$context['error_type'] = 'serious';
1131
+				}
1132
+			} else
1084 1133
 			{
1085 1134
 				$context['post_error'][$post_error] = $txt['error_' . $post_error];
1086 1135
 
1087 1136
 				// If it's not a minor error flag it as such.
1088
-				if (!in_array($post_error, $minor_errors))
1089
-					$context['error_type'] = 'serious';
1137
+				if (!in_array($post_error, $minor_errors)) {
1138
+									$context['error_type'] = 'serious';
1139
+				}
1090 1140
 			}
1091 1141
 	}
1092 1142
 
1093 1143
 	// What are you doing? Posting a poll, modifying, previewing, new post, or reply...
1094
-	if (isset($_REQUEST['poll']))
1095
-		$context['page_title'] = $txt['new_poll'];
1096
-	elseif ($context['make_event'])
1097
-		$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1098
-	elseif (isset($_REQUEST['msg']))
1099
-		$context['page_title'] = $txt['modify_msg'];
1100
-	elseif (isset($_REQUEST['subject'], $context['preview_subject']))
1101
-		$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1102
-	elseif (empty($topic))
1103
-		$context['page_title'] = $txt['start_new_topic'];
1104
-	else
1105
-		$context['page_title'] = $txt['post_reply'];
1144
+	if (isset($_REQUEST['poll'])) {
1145
+			$context['page_title'] = $txt['new_poll'];
1146
+	} elseif ($context['make_event']) {
1147
+			$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1148
+	} elseif (isset($_REQUEST['msg'])) {
1149
+			$context['page_title'] = $txt['modify_msg'];
1150
+	} elseif (isset($_REQUEST['subject'], $context['preview_subject'])) {
1151
+			$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1152
+	} elseif (empty($topic)) {
1153
+			$context['page_title'] = $txt['start_new_topic'];
1154
+	} else {
1155
+			$context['page_title'] = $txt['post_reply'];
1156
+	}
1106 1157
 
1107 1158
 	// Build the link tree.
1108
-	if (empty($topic))
1109
-		$context['linktree'][] = array(
1159
+	if (empty($topic)) {
1160
+			$context['linktree'][] = array(
1110 1161
 			'name' => '<em>' . $txt['start_new_topic'] . '</em>'
1111 1162
 		);
1112
-	else
1113
-		$context['linktree'][] = array(
1163
+	} else {
1164
+			$context['linktree'][] = array(
1114 1165
 			'url' => $scripturl . '?topic=' . $topic . '.' . $_REQUEST['start'],
1115 1166
 			'name' => $form_subject,
1116 1167
 			'extra_before' => '<span><strong class="nav">' . $context['page_title'] . ' (</strong></span>',
1117 1168
 			'extra_after' => '<span><strong class="nav">)</strong></span>'
1118 1169
 		);
1170
+	}
1119 1171
 
1120 1172
 	$context['subject'] = addcslashes($form_subject, '"');
1121 1173
 	$context['message'] = str_replace(array('"', '<', '>', '&nbsp;'), array('&quot;', '&lt;', '&gt;', ' '), $form_message);
@@ -1159,8 +1211,9 @@  discard block
 block discarded – undo
1159 1211
 	// Message icons - customized icons are off?
1160 1212
 	$context['icons'] = getMessageIcons($board);
1161 1213
 
1162
-	if (!empty($context['icons']))
1163
-		$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1214
+	if (!empty($context['icons'])) {
1215
+			$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1216
+	}
1164 1217
 
1165 1218
 	// Are we starting a poll? if set the poll icon as selected if its available
1166 1219
 	if (isset($_REQUEST['poll']))
@@ -1180,8 +1233,9 @@  discard block
 block discarded – undo
1180 1233
 	for ($i = 0, $n = count($context['icons']); $i < $n; $i++)
1181 1234
 	{
1182 1235
 		$context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value'];
1183
-		if ($context['icons'][$i]['selected'])
1184
-			$context['icon_url'] = $context['icons'][$i]['url'];
1236
+		if ($context['icons'][$i]['selected']) {
1237
+					$context['icon_url'] = $context['icons'][$i]['url'];
1238
+		}
1185 1239
 	}
1186 1240
 	if (empty($context['icon_url']))
1187 1241
 	{
@@ -1195,8 +1249,9 @@  discard block
 block discarded – undo
1195 1249
 		));
1196 1250
 	}
1197 1251
 
1198
-	if (!empty($topic) && !empty($modSettings['topicSummaryPosts']))
1199
-		getTopic();
1252
+	if (!empty($topic) && !empty($modSettings['topicSummaryPosts'])) {
1253
+			getTopic();
1254
+	}
1200 1255
 
1201 1256
 	// If the user can post attachments prepare the warning labels.
1202 1257
 	if ($context['can_post_attachment'])
@@ -1207,12 +1262,13 @@  discard block
 block discarded – undo
1207 1262
 		$context['attachment_restrictions'] = array();
1208 1263
 		$context['allowed_extensions'] = strtr(strtolower($modSettings['attachmentExtensions']), array(',' => ', '));
1209 1264
 		$attachmentRestrictionTypes = array('attachmentNumPerPostLimit', 'attachmentPostLimit', 'attachmentSizeLimit');
1210
-		foreach ($attachmentRestrictionTypes as $type)
1211
-			if (!empty($modSettings[$type]))
1265
+		foreach ($attachmentRestrictionTypes as $type) {
1266
+					if (!empty($modSettings[$type]))
1212 1267
 			{
1213 1268
 				// Show the max number of attachments if not 0.
1214 1269
 				if ($type == 'attachmentNumPerPostLimit')
1215 1270
 					$context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']);
1271
+		}
1216 1272
 			}
1217 1273
 	}
1218 1274
 
@@ -1246,8 +1302,8 @@  discard block
 block discarded – undo
1246 1302
 
1247 1303
 	if (!empty($context['current_attachments']))
1248 1304
 	{
1249
-		foreach ($context['current_attachments'] as $key => $mock)
1250
-			addInlineJavaScript('
1305
+		foreach ($context['current_attachments'] as $key => $mock) {
1306
+					addInlineJavaScript('
1251 1307
 	current_attachments.push({
1252 1308
 		name: '. JavaScriptEscape($mock['name']) . ',
1253 1309
 		size: '. $mock['size'] . ',
@@ -1256,6 +1312,7 @@  discard block
 block discarded – undo
1256 1312
 		type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') . ',
1257 1313
 		thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) . '
1258 1314
 	});', true);
1315
+		}
1259 1316
 	}
1260 1317
 
1261 1318
 	// File Upload.
@@ -1340,8 +1397,9 @@  discard block
 block discarded – undo
1340 1397
 
1341 1398
 
1342 1399
 	// Finally, load the template.
1343
-	if (!isset($_REQUEST['xml']))
1344
-		loadTemplate('Post');
1400
+	if (!isset($_REQUEST['xml'])) {
1401
+			loadTemplate('Post');
1402
+	}
1345 1403
 
1346 1404
 	call_integration_hook('integrate_post_end');
1347 1405
 }
@@ -1362,13 +1420,14 @@  discard block
 block discarded – undo
1362 1420
 	// Sneaking off, are we?
1363 1421
 	if (empty($_POST) && empty($topic))
1364 1422
 	{
1365
-		if (empty($_SERVER['CONTENT_LENGTH']))
1366
-			redirectexit('action=post;board=' . $board . '.0');
1367
-		else
1368
-			fatal_lang_error('post_upload_error', false);
1423
+		if (empty($_SERVER['CONTENT_LENGTH'])) {
1424
+					redirectexit('action=post;board=' . $board . '.0');
1425
+		} else {
1426
+					fatal_lang_error('post_upload_error', false);
1427
+		}
1428
+	} elseif (empty($_POST) && !empty($topic)) {
1429
+			redirectexit('action=post;topic=' . $topic . '.0');
1369 1430
 	}
1370
-	elseif (empty($_POST) && !empty($topic))
1371
-		redirectexit('action=post;topic=' . $topic . '.0');
1372 1431
 
1373 1432
 	// No need!
1374 1433
 	$context['robot_no_index'] = true;
@@ -1380,8 +1439,9 @@  discard block
 block discarded – undo
1380 1439
 	$post_errors = array();
1381 1440
 
1382 1441
 	// If the session has timed out, let the user re-submit their form.
1383
-	if (checkSession('post', '', false) != '')
1384
-		$post_errors[] = 'session_timeout';
1442
+	if (checkSession('post', '', false) != '') {
1443
+			$post_errors[] = 'session_timeout';
1444
+	}
1385 1445
 
1386 1446
 	// Wrong verification code?
1387 1447
 	if (!$user_info['is_admin'] && !$user_info['is_mod'] && !empty($modSettings['posts_require_captcha']) && ($user_info['posts'] < $modSettings['posts_require_captcha'] || ($user_info['is_guest'] && $modSettings['posts_require_captcha'] == -1)))
@@ -1391,33 +1451,38 @@  discard block
 block discarded – undo
1391 1451
 			'id' => 'post',
1392 1452
 		);
1393 1453
 		$context['require_verification'] = create_control_verification($verificationOptions, true);
1394
-		if (is_array($context['require_verification']))
1395
-			$post_errors = array_merge($post_errors, $context['require_verification']);
1454
+		if (is_array($context['require_verification'])) {
1455
+					$post_errors = array_merge($post_errors, $context['require_verification']);
1456
+		}
1396 1457
 	}
1397 1458
 
1398 1459
 	require_once($sourcedir . '/Subs-Post.php');
1399 1460
 	loadLanguage('Post');
1400 1461
 
1401 1462
 	// Drafts enabled and needed?
1402
-	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft'])))
1403
-		require_once($sourcedir . '/Drafts.php');
1463
+	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft']))) {
1464
+			require_once($sourcedir . '/Drafts.php');
1465
+	}
1404 1466
 
1405 1467
 	// First check to see if they are trying to delete any current attachments.
1406 1468
 	if (isset($_POST['attach_del']))
1407 1469
 	{
1408 1470
 		$keep_temp = array();
1409 1471
 		$keep_ids = array();
1410
-		foreach ($_POST['attach_del'] as $dummy)
1411
-			if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1472
+		foreach ($_POST['attach_del'] as $dummy) {
1473
+					if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1412 1474
 				$keep_temp[] = $dummy;
1413
-			else
1414
-				$keep_ids[] = (int) $dummy;
1475
+		}
1476
+			else {
1477
+							$keep_ids[] = (int) $dummy;
1478
+			}
1415 1479
 
1416
-		if (isset($_SESSION['temp_attachments']))
1417
-			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1480
+		if (isset($_SESSION['temp_attachments'])) {
1481
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1418 1482
 			{
1419 1483
 				if ((isset($_SESSION['temp_attachments']['post']['files'], $attachment['name']) && in_array($attachment['name'], $_SESSION['temp_attachments']['post']['files'])) || in_array($attachID, $keep_temp) || strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1420 1484
 					continue;
1485
+		}
1421 1486
 
1422 1487
 				unset($_SESSION['temp_attachments'][$attachID]);
1423 1488
 				unlink($attachment['tmp_name']);
@@ -1459,24 +1524,28 @@  discard block
 block discarded – undo
1459 1524
 		$smcFunc['db_free_result']($request);
1460 1525
 
1461 1526
 		// Though the topic should be there, it might have vanished.
1462
-		if (!is_array($topic_info))
1463
-			fatal_lang_error('topic_doesnt_exist', 404);
1527
+		if (!is_array($topic_info)) {
1528
+					fatal_lang_error('topic_doesnt_exist', 404);
1529
+		}
1464 1530
 
1465 1531
 		// Did this topic suddenly move? Just checking...
1466
-		if ($topic_info['id_board'] != $board)
1467
-			fatal_lang_error('not_a_topic');
1532
+		if ($topic_info['id_board'] != $board) {
1533
+					fatal_lang_error('not_a_topic');
1534
+		}
1468 1535
 	}
1469 1536
 
1470 1537
 	// Replying to a topic?
1471 1538
 	if (!empty($topic) && !isset($_REQUEST['msg']))
1472 1539
 	{
1473 1540
 		// Don't allow a post if it's locked.
1474
-		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board'))
1475
-			fatal_lang_error('topic_locked', false);
1541
+		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board')) {
1542
+					fatal_lang_error('topic_locked', false);
1543
+		}
1476 1544
 
1477 1545
 		// Sorry, multiple polls aren't allowed... yet.  You should stop giving me ideas :P.
1478
-		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0)
1479
-			unset($_REQUEST['poll']);
1546
+		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0) {
1547
+					unset($_REQUEST['poll']);
1548
+		}
1480 1549
 
1481 1550
 		// Do the permissions and approval stuff...
1482 1551
 		$becomesApproved = true;
@@ -1492,44 +1561,43 @@  discard block
 block discarded – undo
1492 1561
 
1493 1562
 			// Set a nice session var...
1494 1563
 			$_SESSION['becomesUnapproved'] = true;
1495
-		}
1496
-
1497
-		elseif ($topic_info['id_member_started'] != $user_info['id'])
1564
+		} elseif ($topic_info['id_member_started'] != $user_info['id'])
1498 1565
 		{
1499
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
1500
-				$becomesApproved = false;
1501
-
1502
-			else
1503
-				isAllowedTo('post_reply_any');
1504
-		}
1505
-		elseif (!allowedTo('post_reply_any'))
1566
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
1567
+							$becomesApproved = false;
1568
+			} else {
1569
+							isAllowedTo('post_reply_any');
1570
+			}
1571
+		} elseif (!allowedTo('post_reply_any'))
1506 1572
 		{
1507
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own'))
1508
-				$becomesApproved = false;
1509
-
1510
-			else
1511
-				isAllowedTo('post_reply_own');
1573
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) {
1574
+							$becomesApproved = false;
1575
+			} else {
1576
+							isAllowedTo('post_reply_own');
1577
+			}
1512 1578
 		}
1513 1579
 
1514 1580
 		if (isset($_POST['lock']))
1515 1581
 		{
1516 1582
 			// Nothing is changed to the lock.
1517
-			if ((empty($topic_info['locked']) && empty($_POST['lock'])) || (!empty($_POST['lock']) && !empty($topic_info['locked'])))
1518
-				unset($_POST['lock']);
1583
+			if ((empty($topic_info['locked']) && empty($_POST['lock'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) {
1584
+							unset($_POST['lock']);
1585
+			}
1519 1586
 
1520 1587
 			// You're have no permission to lock this topic.
1521
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1522
-				unset($_POST['lock']);
1588
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1589
+							unset($_POST['lock']);
1590
+			}
1523 1591
 
1524 1592
 			// You are allowed to (un)lock your own topic only.
1525 1593
 			elseif (!allowedTo('lock_any'))
1526 1594
 			{
1527 1595
 				// You cannot override a moderator lock.
1528
-				if ($topic_info['locked'] == 1)
1529
-					unset($_POST['lock']);
1530
-
1531
-				else
1532
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1596
+				if ($topic_info['locked'] == 1) {
1597
+									unset($_POST['lock']);
1598
+				} else {
1599
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1600
+				}
1533 1601
 			}
1534 1602
 			// Hail mighty moderator, (un)lock this topic immediately.
1535 1603
 			else
@@ -1537,19 +1605,21 @@  discard block
 block discarded – undo
1537 1605
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1538 1606
 
1539 1607
 				// Did someone (un)lock this while you were posting?
1540
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1541
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1608
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1609
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1610
+				}
1542 1611
 			}
1543 1612
 		}
1544 1613
 
1545 1614
 		// So you wanna (un)sticky this...let's see.
1546
-		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky')))
1547
-			unset($_POST['sticky']);
1548
-		elseif (isset($_POST['sticky']))
1615
+		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky'))) {
1616
+					unset($_POST['sticky']);
1617
+		} elseif (isset($_POST['sticky']))
1549 1618
 		{
1550 1619
 			// Did someone (un)sticky this while you were posting?
1551
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1552
-				$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1620
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1621
+							$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1622
+			}
1553 1623
 		}
1554 1624
 
1555 1625
 		// If drafts are enabled, then pass this off
@@ -1576,26 +1646,31 @@  discard block
 block discarded – undo
1576 1646
 
1577 1647
 		// Do like, the permissions, for safety and stuff...
1578 1648
 		$becomesApproved = true;
1579
-		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics'))
1580
-			$becomesApproved = false;
1581
-		else
1582
-			isAllowedTo('post_new');
1649
+		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) {
1650
+					$becomesApproved = false;
1651
+		} else {
1652
+					isAllowedTo('post_new');
1653
+		}
1583 1654
 
1584 1655
 		if (isset($_POST['lock']))
1585 1656
 		{
1586 1657
 			// New topics are by default not locked.
1587
-			if (empty($_POST['lock']))
1588
-				unset($_POST['lock']);
1658
+			if (empty($_POST['lock'])) {
1659
+							unset($_POST['lock']);
1660
+			}
1589 1661
 			// Besides, you need permission.
1590
-			elseif (!allowedTo(array('lock_any', 'lock_own')))
1591
-				unset($_POST['lock']);
1662
+			elseif (!allowedTo(array('lock_any', 'lock_own'))) {
1663
+							unset($_POST['lock']);
1664
+			}
1592 1665
 			// A moderator-lock (1) can override a user-lock (2).
1593
-			else
1594
-				$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1666
+			else {
1667
+							$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1668
+			}
1595 1669
 		}
1596 1670
 
1597
-		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky')))
1598
-			unset($_POST['sticky']);
1671
+		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky'))) {
1672
+					unset($_POST['sticky']);
1673
+		}
1599 1674
 
1600 1675
 		// Saving your new topic as a draft first?
1601 1676
 		if (!empty($modSettings['drafts_post_enabled']) && isset($_POST['save_draft']))
@@ -1620,31 +1695,37 @@  discard block
 block discarded – undo
1620 1695
 				'id_msg' => $_REQUEST['msg'],
1621 1696
 			)
1622 1697
 		);
1623
-		if ($smcFunc['db_num_rows']($request) == 0)
1624
-			fatal_lang_error('cant_find_messages', false);
1698
+		if ($smcFunc['db_num_rows']($request) == 0) {
1699
+					fatal_lang_error('cant_find_messages', false);
1700
+		}
1625 1701
 		$row = $smcFunc['db_fetch_assoc']($request);
1626 1702
 		$smcFunc['db_free_result']($request);
1627 1703
 
1628
-		if (!empty($topic_info['locked']) && !allowedTo('moderate_board'))
1629
-			fatal_lang_error('topic_locked', false);
1704
+		if (!empty($topic_info['locked']) && !allowedTo('moderate_board')) {
1705
+					fatal_lang_error('topic_locked', false);
1706
+		}
1630 1707
 
1631 1708
 		if (isset($_POST['lock']))
1632 1709
 		{
1633 1710
 			// Nothing changes to the lock status.
1634
-			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked'])))
1635
-				unset($_POST['lock']);
1711
+			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) {
1712
+							unset($_POST['lock']);
1713
+			}
1636 1714
 			// You're simply not allowed to (un)lock this.
1637
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1638
-				unset($_POST['lock']);
1715
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1716
+							unset($_POST['lock']);
1717
+			}
1639 1718
 			// You're only allowed to lock your own topics.
1640 1719
 			elseif (!allowedTo('lock_any'))
1641 1720
 			{
1642 1721
 				// You're not allowed to break a moderator's lock.
1643
-				if ($topic_info['locked'] == 1)
1644
-					unset($_POST['lock']);
1722
+				if ($topic_info['locked'] == 1) {
1723
+									unset($_POST['lock']);
1724
+				}
1645 1725
 				// Lock it with a soft lock or unlock it.
1646
-				else
1647
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1726
+				else {
1727
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1728
+				}
1648 1729
 			}
1649 1730
 			// You must be the moderator.
1650 1731
 			else
@@ -1652,44 +1733,46 @@  discard block
 block discarded – undo
1652 1733
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1653 1734
 
1654 1735
 				// Did someone (un)lock this while you were posting?
1655
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1656
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1736
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1737
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1738
+				}
1657 1739
 			}
1658 1740
 		}
1659 1741
 
1660 1742
 		// Change the sticky status of this topic?
1661
-		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky']))
1662
-			unset($_POST['sticky']);
1663
-		elseif (isset($_POST['sticky']))
1743
+		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky'])) {
1744
+					unset($_POST['sticky']);
1745
+		} elseif (isset($_POST['sticky']))
1664 1746
 		{
1665 1747
 			// Did someone (un)sticky this while you were posting?
1666
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1667
-				$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1748
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1749
+							$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1750
+			}
1668 1751
 		}
1669 1752
 
1670 1753
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
1671 1754
 		{
1672
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
1673
-				fatal_lang_error('modify_post_time_passed', false);
1674
-			elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
1675
-				isAllowedTo('modify_replies');
1676
-			else
1677
-				isAllowedTo('modify_own');
1678
-		}
1679
-		elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1755
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
1756
+							fatal_lang_error('modify_post_time_passed', false);
1757
+			} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
1758
+							isAllowedTo('modify_replies');
1759
+			} else {
1760
+							isAllowedTo('modify_own');
1761
+			}
1762
+		} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1680 1763
 		{
1681 1764
 			isAllowedTo('modify_replies');
1682 1765
 
1683 1766
 			// If you're modifying a reply, I say it better be logged...
1684 1767
 			$moderationAction = true;
1685
-		}
1686
-		else
1768
+		} else
1687 1769
 		{
1688 1770
 			isAllowedTo('modify_any');
1689 1771
 
1690 1772
 			// Log it, assuming you're not modifying your own post.
1691
-			if ($row['id_member'] != $user_info['id'])
1692
-				$moderationAction = true;
1773
+			if ($row['id_member'] != $user_info['id']) {
1774
+							$moderationAction = true;
1775
+			}
1693 1776
 		}
1694 1777
 
1695 1778
 		// If drafts are enabled, then lets send this off to save
@@ -1726,20 +1809,24 @@  discard block
 block discarded – undo
1726 1809
 		$_POST['guestname'] = !isset($_POST['guestname']) ? '' : trim($_POST['guestname']);
1727 1810
 		$_POST['email'] = !isset($_POST['email']) ? '' : trim($_POST['email']);
1728 1811
 
1729
-		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_')
1730
-			$post_errors[] = 'no_name';
1731
-		if ($smcFunc['strlen']($_POST['guestname']) > 25)
1732
-			$post_errors[] = 'long_name';
1812
+		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_') {
1813
+					$post_errors[] = 'no_name';
1814
+		}
1815
+		if ($smcFunc['strlen']($_POST['guestname']) > 25) {
1816
+					$post_errors[] = 'long_name';
1817
+		}
1733 1818
 
1734 1819
 		if (empty($modSettings['guest_post_no_email']))
1735 1820
 		{
1736 1821
 			// Only check if they changed it!
1737 1822
 			if (!isset($row) || $row['poster_email'] != $_POST['email'])
1738 1823
 			{
1739
-				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == ''))
1740
-					$post_errors[] = 'no_email';
1741
-				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL))
1742
-					$post_errors[] = 'bad_email';
1824
+				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == '')) {
1825
+									$post_errors[] = 'no_email';
1826
+				}
1827
+				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) {
1828
+									$post_errors[] = 'bad_email';
1829
+				}
1743 1830
 			}
1744 1831
 
1745 1832
 			// Now make sure this email address is not banned from posting.
@@ -1755,75 +1842,89 @@  discard block
 block discarded – undo
1755 1842
 	}
1756 1843
 
1757 1844
 	// Coming from the quickReply?
1758
-	if (isset($_POST['quickReply']))
1759
-		$_POST['message'] = $_POST['quickReply'];
1845
+	if (isset($_POST['quickReply'])) {
1846
+			$_POST['message'] = $_POST['quickReply'];
1847
+	}
1760 1848
 
1761 1849
 	// Check the subject and message.
1762
-	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '')
1763
-		$post_errors[] = 'no_subject';
1764
-	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '')
1765
-		$post_errors[] = 'no_message';
1766
-	elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
1767
-		$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1768
-	else
1850
+	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '') {
1851
+			$post_errors[] = 'no_subject';
1852
+	}
1853
+	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '') {
1854
+			$post_errors[] = 'no_message';
1855
+	} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) {
1856
+			$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1857
+	} else
1769 1858
 	{
1770 1859
 		// Prepare the message a bit for some additional testing.
1771 1860
 		$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
1772 1861
 
1773 1862
 		// Preparse code. (Zef)
1774
-		if ($user_info['is_guest'])
1775
-			$user_info['name'] = $_POST['guestname'];
1863
+		if ($user_info['is_guest']) {
1864
+					$user_info['name'] = $_POST['guestname'];
1865
+		}
1776 1866
 		preparsecode($_POST['message']);
1777 1867
 
1778 1868
 		// Let's see if there's still some content left without the tags.
1779
-		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false))
1780
-			$post_errors[] = 'no_message';
1869
+		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false)) {
1870
+					$post_errors[] = 'no_message';
1871
+		}
1872
+	}
1873
+	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '') {
1874
+			$post_errors[] = 'no_event';
1781 1875
 	}
1782
-	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '')
1783
-		$post_errors[] = 'no_event';
1784 1876
 	// You are not!
1785
-	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin'])
1786
-		fatal_error('Knave! Masquerader! Charlatan!', false);
1877
+	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin']) {
1878
+			fatal_error('Knave! Masquerader! Charlatan!', false);
1879
+	}
1787 1880
 
1788 1881
 	// Validate the poll...
1789 1882
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
1790 1883
 	{
1791
-		if (!empty($topic) && !isset($_REQUEST['msg']))
1792
-			fatal_lang_error('no_access', false);
1884
+		if (!empty($topic) && !isset($_REQUEST['msg'])) {
1885
+					fatal_lang_error('no_access', false);
1886
+		}
1793 1887
 
1794 1888
 		// This is a new topic... so it's a new poll.
1795
-		if (empty($topic))
1796
-			isAllowedTo('poll_post');
1889
+		if (empty($topic)) {
1890
+					isAllowedTo('poll_post');
1891
+		}
1797 1892
 		// Can you add to your own topics?
1798
-		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any'))
1799
-			isAllowedTo('poll_add_own');
1893
+		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any')) {
1894
+					isAllowedTo('poll_add_own');
1895
+		}
1800 1896
 		// Can you add polls to any topic, then?
1801
-		else
1802
-			isAllowedTo('poll_add_any');
1897
+		else {
1898
+					isAllowedTo('poll_add_any');
1899
+		}
1803 1900
 
1804
-		if (!isset($_POST['question']) || trim($_POST['question']) == '')
1805
-			$post_errors[] = 'no_question';
1901
+		if (!isset($_POST['question']) || trim($_POST['question']) == '') {
1902
+					$post_errors[] = 'no_question';
1903
+		}
1806 1904
 
1807 1905
 		$_POST['options'] = empty($_POST['options']) ? array() : htmltrim__recursive($_POST['options']);
1808 1906
 
1809 1907
 		// Get rid of empty ones.
1810
-		foreach ($_POST['options'] as $k => $option)
1811
-			if ($option == '')
1908
+		foreach ($_POST['options'] as $k => $option) {
1909
+					if ($option == '')
1812 1910
 				unset($_POST['options'][$k], $_POST['options'][$k]);
1911
+		}
1813 1912
 
1814 1913
 		// What are you going to vote between with one choice?!?
1815
-		if (count($_POST['options']) < 2)
1816
-			$post_errors[] = 'poll_few';
1817
-		elseif (count($_POST['options']) > 256)
1818
-			$post_errors[] = 'poll_many';
1914
+		if (count($_POST['options']) < 2) {
1915
+					$post_errors[] = 'poll_few';
1916
+		} elseif (count($_POST['options']) > 256) {
1917
+					$post_errors[] = 'poll_many';
1918
+		}
1819 1919
 	}
1820 1920
 
1821 1921
 	if ($posterIsGuest)
1822 1922
 	{
1823 1923
 		// If user is a guest, make sure the chosen name isn't taken.
1824 1924
 		require_once($sourcedir . '/Subs-Members.php');
1825
-		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name']))
1826
-			$post_errors[] = 'bad_name';
1925
+		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name'])) {
1926
+					$post_errors[] = 'bad_name';
1927
+		}
1827 1928
 	}
1828 1929
 	// If the user isn't a guest, get his or her name and email.
1829 1930
 	elseif (!isset($_REQUEST['msg']))
@@ -1854,8 +1955,9 @@  discard block
 block discarded – undo
1854 1955
 	}
1855 1956
 
1856 1957
 	// Make sure the user isn't spamming the board.
1857
-	if (!isset($_REQUEST['msg']))
1858
-		spamProtection('post');
1958
+	if (!isset($_REQUEST['msg'])) {
1959
+			spamProtection('post');
1960
+	}
1859 1961
 
1860 1962
 	// At about this point, we're posting and that's that.
1861 1963
 	ignore_user_abort(true);
@@ -1868,32 +1970,36 @@  discard block
 block discarded – undo
1868 1970
 	$_POST['modify_reason'] = empty($_POST['modify_reason']) ? '' : strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
1869 1971
 
1870 1972
 	// At this point, we want to make sure the subject isn't too long.
1871
-	if ($smcFunc['strlen']($_POST['subject']) > 100)
1872
-		$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
1973
+	if ($smcFunc['strlen']($_POST['subject']) > 100) {
1974
+			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
1975
+	}
1873 1976
 
1874 1977
 	// Same with the "why did you edit this" text.
1875
-	if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
1876
-		$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
1978
+	if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
1979
+			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
1980
+	}
1877 1981
 
1878 1982
 	// Make the poll...
1879 1983
 	if (isset($_REQUEST['poll']))
1880 1984
 	{
1881 1985
 		// Make sure that the user has not entered a ridiculous number of options..
1882
-		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0)
1883
-			$_POST['poll_max_votes'] = 1;
1884
-		elseif ($_POST['poll_max_votes'] > count($_POST['options']))
1885
-			$_POST['poll_max_votes'] = count($_POST['options']);
1886
-		else
1887
-			$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
1986
+		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0) {
1987
+					$_POST['poll_max_votes'] = 1;
1988
+		} elseif ($_POST['poll_max_votes'] > count($_POST['options'])) {
1989
+					$_POST['poll_max_votes'] = count($_POST['options']);
1990
+		} else {
1991
+					$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
1992
+		}
1888 1993
 
1889 1994
 		$_POST['poll_expire'] = (int) $_POST['poll_expire'];
1890 1995
 		$_POST['poll_expire'] = $_POST['poll_expire'] > 9999 ? 9999 : ($_POST['poll_expire'] < 0 ? 0 : $_POST['poll_expire']);
1891 1996
 
1892 1997
 		// Just set it to zero if it's not there..
1893
-		if (!isset($_POST['poll_hide']))
1894
-			$_POST['poll_hide'] = 0;
1895
-		else
1896
-			$_POST['poll_hide'] = (int) $_POST['poll_hide'];
1998
+		if (!isset($_POST['poll_hide'])) {
1999
+					$_POST['poll_hide'] = 0;
2000
+		} else {
2001
+					$_POST['poll_hide'] = (int) $_POST['poll_hide'];
2002
+		}
1897 2003
 		$_POST['poll_change_vote'] = isset($_POST['poll_change_vote']) ? 1 : 0;
1898 2004
 
1899 2005
 		$_POST['poll_guest_vote'] = isset($_POST['poll_guest_vote']) ? 1 : 0;
@@ -1902,16 +2008,19 @@  discard block
 block discarded – undo
1902 2008
 		{
1903 2009
 			require_once($sourcedir . '/Subs-Members.php');
1904 2010
 			$allowedVoteGroups = groupsAllowedTo('poll_vote', $board);
1905
-			if (!in_array(-1, $allowedVoteGroups['allowed']))
1906
-				$_POST['poll_guest_vote'] = 0;
2011
+			if (!in_array(-1, $allowedVoteGroups['allowed'])) {
2012
+							$_POST['poll_guest_vote'] = 0;
2013
+			}
1907 2014
 		}
1908 2015
 
1909 2016
 		// If the user tries to set the poll too far in advance, don't let them.
1910
-		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1)
1911
-			fatal_lang_error('poll_range_error', false);
2017
+		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1) {
2018
+					fatal_lang_error('poll_range_error', false);
2019
+		}
1912 2020
 		// Don't allow them to select option 2 for hidden results if it's not time limited.
1913
-		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2)
1914
-			$_POST['poll_hide'] = 1;
2021
+		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2) {
2022
+					$_POST['poll_hide'] = 1;
2023
+		}
1915 2024
 
1916 2025
 		// Clean up the question and answers.
1917 2026
 		$_POST['question'] = $smcFunc['htmlspecialchars']($_POST['question']);
@@ -1925,13 +2034,15 @@  discard block
 block discarded – undo
1925 2034
 	{
1926 2035
 		$attachIDs = array();
1927 2036
 		$attach_errors = array();
1928
-		if (!empty($context['we_are_history']))
1929
-			$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2037
+		if (!empty($context['we_are_history'])) {
2038
+					$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2039
+		}
1930 2040
 
1931 2041
 		foreach ($_SESSION['temp_attachments'] as  $attachID => $attachment)
1932 2042
 		{
1933
-			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1934
-				continue;
2043
+			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
2044
+							continue;
2045
+			}
1935 2046
 
1936 2047
 			// If there was an initial error just show that message.
1937 2048
 			if ($attachID == 'initial_error')
@@ -1960,12 +2071,13 @@  discard block
 block discarded – undo
1960 2071
 				if (createAttachment($attachmentOptions))
1961 2072
 				{
1962 2073
 					$attachIDs[] = $attachmentOptions['id'];
1963
-					if (!empty($attachmentOptions['thumb']))
1964
-						$attachIDs[] = $attachmentOptions['thumb'];
2074
+					if (!empty($attachmentOptions['thumb'])) {
2075
+											$attachIDs[] = $attachmentOptions['thumb'];
2076
+					}
1965 2077
 				}
2078
+			} else {
2079
+							$attach_errors[] = '<dt>&nbsp;</dt>';
1966 2080
 			}
1967
-			else
1968
-				$attach_errors[] = '<dt>&nbsp;</dt>';
1969 2081
 
1970 2082
 			if (!empty($attachmentOptions['errors']))
1971 2083
 			{
@@ -1977,14 +2089,16 @@  discard block
 block discarded – undo
1977 2089
 					if (!is_array($error))
1978 2090
 					{
1979 2091
 						$attach_errors[] = '<dd>' . $txt[$error] . '</dd>';
1980
-						if (in_array($error, $log_these))
1981
-							log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2092
+						if (in_array($error, $log_these)) {
2093
+													log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2094
+						}
2095
+					} else {
2096
+											$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
1982 2097
 					}
1983
-					else
1984
-						$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
1985 2098
 				}
1986
-				if (file_exists($attachment['tmp_name']))
1987
-					unlink($attachment['tmp_name']);
2099
+				if (file_exists($attachment['tmp_name'])) {
2100
+									unlink($attachment['tmp_name']);
2101
+				}
1988 2102
 			}
1989 2103
 		}
1990 2104
 		unset($_SESSION['temp_attachments']);
@@ -2025,24 +2139,24 @@  discard block
 block discarded – undo
2025 2139
 		);
2026 2140
 
2027 2141
 		call_integration_hook('integrate_poll_add_edit', array($id_poll, false));
2142
+	} else {
2143
+			$id_poll = 0;
2028 2144
 	}
2029
-	else
2030
-		$id_poll = 0;
2031 2145
 
2032 2146
 	// Creating a new topic?
2033 2147
 	$newTopic = empty($_REQUEST['msg']) && empty($topic);
2034 2148
 
2035 2149
 	// Check the icon.
2036
-	if (!isset($_POST['icon']))
2037
-		$_POST['icon'] = 'xx';
2038
-
2039
-	else
2150
+	if (!isset($_POST['icon'])) {
2151
+			$_POST['icon'] = 'xx';
2152
+	} else
2040 2153
 	{
2041 2154
 		$_POST['icon'] = $smcFunc['htmlspecialchars']($_POST['icon']);
2042 2155
 
2043 2156
 		// Need to figure it out if this is a valid icon name.
2044
-		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')))
2045
-			$_POST['icon'] = 'xx';
2157
+		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png'))) {
2158
+					$_POST['icon'] = 'xx';
2159
+		}
2046 2160
 	}
2047 2161
 
2048 2162
 	// Collect all parameters for the creation or modification of a post.
@@ -2083,8 +2197,9 @@  discard block
 block discarded – undo
2083 2197
 		}
2084 2198
 
2085 2199
 		// This will save some time...
2086
-		if (empty($approve_has_changed))
2087
-			unset($msgOptions['approved']);
2200
+		if (empty($approve_has_changed)) {
2201
+					unset($msgOptions['approved']);
2202
+		}
2088 2203
 
2089 2204
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2090 2205
 	}
@@ -2093,8 +2208,9 @@  discard block
 block discarded – undo
2093 2208
 	{
2094 2209
 		createPost($msgOptions, $topicOptions, $posterOptions);
2095 2210
 
2096
-		if (isset($topicOptions['id']))
2097
-			$topic = $topicOptions['id'];
2211
+		if (isset($topicOptions['id'])) {
2212
+					$topic = $topicOptions['id'];
2213
+		}
2098 2214
 	}
2099 2215
 
2100 2216
 	// Assign the previously uploaded attachments to the brand new message.
@@ -2106,8 +2222,9 @@  discard block
 block discarded – undo
2106 2222
 	}
2107 2223
 
2108 2224
 	// If we had a draft for this, its time to remove it since it was just posted
2109
-	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft']))
2110
-		DeleteDraft($_POST['id_draft']);
2225
+	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft'])) {
2226
+			DeleteDraft($_POST['id_draft']);
2227
+	}
2111 2228
 
2112 2229
 	// Editing or posting an event?
2113 2230
 	if (isset($_POST['calendar']) && (!isset($_REQUEST['eventid']) || $_REQUEST['eventid'] == -1))
@@ -2126,8 +2243,7 @@  discard block
 block discarded – undo
2126 2243
 			'member' => $user_info['id'],
2127 2244
 		);
2128 2245
 		insertEvent($eventOptions);
2129
-	}
2130
-	elseif (isset($_POST['calendar']))
2246
+	} elseif (isset($_POST['calendar']))
2131 2247
 	{
2132 2248
 		$_REQUEST['eventid'] = (int) $_REQUEST['eventid'];
2133 2249
 
@@ -2155,14 +2271,15 @@  discard block
 block discarded – undo
2155 2271
 		}
2156 2272
 
2157 2273
 		// Delete it?
2158
-		if (isset($_REQUEST['deleteevent']))
2159
-			$smcFunc['db_query']('', '
2274
+		if (isset($_REQUEST['deleteevent'])) {
2275
+					$smcFunc['db_query']('', '
2160 2276
 				DELETE FROM {db_prefix}calendar
2161 2277
 				WHERE id_event = {int:id_event}',
2162 2278
 				array(
2163 2279
 					'id_event' => $_REQUEST['eventid'],
2164 2280
 				)
2165 2281
 			);
2282
+		}
2166 2283
 		// ... or just update it?
2167 2284
 		else
2168 2285
 		{
@@ -2204,9 +2321,8 @@  discard block
 block discarded – undo
2204 2321
 			array($user_info['id'], $topic, 0),
2205 2322
 			array('id_member', 'id_topic', 'id_board')
2206 2323
 		);
2207
-	}
2208
-	elseif (!$newTopic)
2209
-		$smcFunc['db_query']('', '
2324
+	} elseif (!$newTopic) {
2325
+			$smcFunc['db_query']('', '
2210 2326
 			DELETE FROM {db_prefix}log_notify
2211 2327
 			WHERE id_member = {int:current_member}
2212 2328
 				AND id_topic = {int:current_topic}',
@@ -2215,16 +2331,20 @@  discard block
 block discarded – undo
2215 2331
 				'current_topic' => $topic,
2216 2332
 			)
2217 2333
 		);
2334
+	}
2218 2335
 
2219 2336
 	// Log an act of moderation - modifying.
2220
-	if (!empty($moderationAction))
2221
-		logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2337
+	if (!empty($moderationAction)) {
2338
+			logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2339
+	}
2222 2340
 
2223
-	if (isset($_POST['lock']) && $_POST['lock'] != 2)
2224
-		logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2341
+	if (isset($_POST['lock']) && $_POST['lock'] != 2) {
2342
+			logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2343
+	}
2225 2344
 
2226
-	if (isset($_POST['sticky']))
2227
-		logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2345
+	if (isset($_POST['sticky'])) {
2346
+			logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2347
+	}
2228 2348
 
2229 2349
 	// Returning to the topic?
2230 2350
 	if (!empty($_REQUEST['goback']))
@@ -2243,26 +2363,31 @@  discard block
 block discarded – undo
2243 2363
 		);
2244 2364
 	}
2245 2365
 
2246
-	if ($board_info['num_topics'] == 0)
2247
-		cache_put_data('board-' . $board, null, 120);
2366
+	if ($board_info['num_topics'] == 0) {
2367
+			cache_put_data('board-' . $board, null, 120);
2368
+	}
2248 2369
 
2249 2370
 	call_integration_hook('integrate_post2_end');
2250 2371
 
2251
-	if (!empty($_POST['announce_topic']))
2252
-		redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2372
+	if (!empty($_POST['announce_topic'])) {
2373
+			redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2374
+	}
2253 2375
 
2254
-	if (!empty($_POST['move']) && allowedTo('move_any'))
2255
-		redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2376
+	if (!empty($_POST['move']) && allowedTo('move_any')) {
2377
+			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2378
+	}
2256 2379
 
2257 2380
 	// Return to post if the mod is on.
2258
-	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback']))
2259
-		redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2260
-	elseif (!empty($_REQUEST['goback']))
2261
-		redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2381
+	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback'])) {
2382
+			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2383
+	} elseif (!empty($_REQUEST['goback'])) {
2384
+			redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2385
+	}
2262 2386
 	// Dut-dut-duh-duh-DUH-duh-dut-duh-duh!  *dances to the Final Fantasy Fanfare...*
2263
-	else
2264
-		redirectexit('board=' . $board . '.0');
2265
-}
2387
+	else {
2388
+			redirectexit('board=' . $board . '.0');
2389
+	}
2390
+	}
2266 2391
 
2267 2392
 /**
2268 2393
  * Handle the announce topic function (action=announce).
@@ -2280,8 +2405,9 @@  discard block
 block discarded – undo
2280 2405
 
2281 2406
 	validateSession();
2282 2407
 
2283
-	if (empty($topic))
2284
-		fatal_lang_error('topic_gone', false);
2408
+	if (empty($topic)) {
2409
+			fatal_lang_error('topic_gone', false);
2410
+	}
2285 2411
 
2286 2412
 	loadLanguage('Post');
2287 2413
 	loadTemplate('Post');
@@ -2308,8 +2434,9 @@  discard block
 block discarded – undo
2308 2434
 	global $txt, $context, $topic, $board_info, $smcFunc;
2309 2435
 
2310 2436
 	$groups = array_merge($board_info['groups'], array(1));
2311
-	foreach ($groups as $id => $group)
2312
-		$groups[$id] = (int) $group;
2437
+	foreach ($groups as $id => $group) {
2438
+			$groups[$id] = (int) $group;
2439
+	}
2313 2440
 
2314 2441
 	$context['groups'] = array();
2315 2442
 	if (in_array(0, $groups))
@@ -2352,8 +2479,9 @@  discard block
 block discarded – undo
2352 2479
 			'group_list' => $groups,
2353 2480
 		)
2354 2481
 	);
2355
-	while ($row = $smcFunc['db_fetch_assoc']($request))
2356
-		$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2482
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2483
+			$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2484
+	}
2357 2485
 	$smcFunc['db_free_result']($request);
2358 2486
 
2359 2487
 	// Get the subject of the topic we're about to announce.
@@ -2395,16 +2523,19 @@  discard block
 block discarded – undo
2395 2523
 	$context['start'] = empty($_REQUEST['start']) ? 0 : (int) $_REQUEST['start'];
2396 2524
 	$groups = array_merge($board_info['groups'], array(1));
2397 2525
 
2398
-	if (isset($_POST['membergroups']))
2399
-		$_POST['who'] = explode(',', $_POST['membergroups']);
2526
+	if (isset($_POST['membergroups'])) {
2527
+			$_POST['who'] = explode(',', $_POST['membergroups']);
2528
+	}
2400 2529
 
2401 2530
 	// Check whether at least one membergroup was selected.
2402
-	if (empty($_POST['who']))
2403
-		fatal_lang_error('no_membergroup_selected');
2531
+	if (empty($_POST['who'])) {
2532
+			fatal_lang_error('no_membergroup_selected');
2533
+	}
2404 2534
 
2405 2535
 	// Make sure all membergroups are integers and can access the board of the announcement.
2406
-	foreach ($_POST['who'] as $id => $mg)
2407
-		$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2536
+	foreach ($_POST['who'] as $id => $mg) {
2537
+			$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2538
+	}
2408 2539
 
2409 2540
 	// Get the topic subject and censor it.
2410 2541
 	$request = $smcFunc['db_query']('', '
@@ -2450,12 +2581,13 @@  discard block
 block discarded – undo
2450 2581
 	if ($smcFunc['db_num_rows']($request) == 0)
2451 2582
 	{
2452 2583
 		logAction('announce_topic', array('topic' => $topic), 'user');
2453
-		if (!empty($_REQUEST['move']) && allowedTo('move_any'))
2454
-			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2455
-		elseif (!empty($_REQUEST['goback']))
2456
-			redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2457
-		else
2458
-			redirectexit('board=' . $board . '.0');
2584
+		if (!empty($_REQUEST['move']) && allowedTo('move_any')) {
2585
+					redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2586
+		} elseif (!empty($_REQUEST['goback'])) {
2587
+					redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2588
+		} else {
2589
+					redirectexit('board=' . $board . '.0');
2590
+		}
2459 2591
 	}
2460 2592
 
2461 2593
 	$announcements = array();
@@ -2474,8 +2606,9 @@  discard block
 block discarded – undo
2474 2606
 	foreach ($rows as $row)
2475 2607
 	{
2476 2608
 		// Force them to have it?
2477
-		if (empty($prefs[$row['id_member']]['announcements']))
2478
-			continue;
2609
+		if (empty($prefs[$row['id_member']]['announcements'])) {
2610
+					continue;
2611
+		}
2479 2612
 
2480 2613
 		$cur_language = empty($row['lngfile']) || empty($modSettings['userLanguage']) ? $language : $row['lngfile'];
2481 2614
 
@@ -2503,8 +2636,9 @@  discard block
 block discarded – undo
2503 2636
 	}
2504 2637
 
2505 2638
 	// For each language send a different mail - low priority...
2506
-	foreach ($announcements as $lang => $mail)
2507
-		sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2639
+	foreach ($announcements as $lang => $mail) {
2640
+			sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2641
+	}
2508 2642
 
2509 2643
 	$context['percentage_done'] = round(100 * $context['start'] / $modSettings['latestMember'], 1);
2510 2644
 
@@ -2514,9 +2648,10 @@  discard block
 block discarded – undo
2514 2648
 	$context['sub_template'] = 'announcement_send';
2515 2649
 
2516 2650
 	// Go back to the correct language for the user ;).
2517
-	if (!empty($modSettings['userLanguage']))
2518
-		loadLanguage('Post');
2519
-}
2651
+	if (!empty($modSettings['userLanguage'])) {
2652
+			loadLanguage('Post');
2653
+	}
2654
+	}
2520 2655
 
2521 2656
 /**
2522 2657
  * Get the topic for display purposes.
@@ -2529,12 +2664,13 @@  discard block
 block discarded – undo
2529 2664
 {
2530 2665
 	global $topic, $modSettings, $context, $smcFunc, $counter, $options;
2531 2666
 
2532
-	if (isset($_REQUEST['xml']))
2533
-		$limit = '
2667
+	if (isset($_REQUEST['xml'])) {
2668
+			$limit = '
2534 2669
 		LIMIT ' . (empty($context['new_replies']) ? '0' : $context['new_replies']);
2535
-	else
2536
-		$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2670
+	} else {
2671
+			$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2537 2672
 		LIMIT ' . (int) $modSettings['topicSummaryPosts'];
2673
+	}
2538 2674
 
2539 2675
 	// If you're modifying, get only those posts before the current one. (otherwise get all.)
2540 2676
 	$request = $smcFunc['db_query']('', '
@@ -2572,8 +2708,9 @@  discard block
 block discarded – undo
2572 2708
 			'is_ignored' => !empty($modSettings['enable_buddylist']) && !empty($options['posts_apply_ignore_list']) && in_array($row['id_member'], $context['user']['ignoreusers']),
2573 2709
 		);
2574 2710
 
2575
-		if (!empty($context['new_replies']))
2576
-			$context['new_replies']--;
2711
+		if (!empty($context['new_replies'])) {
2712
+					$context['new_replies']--;
2713
+		}
2577 2714
 	}
2578 2715
 	$smcFunc['db_free_result']($request);
2579 2716
 }
@@ -2590,8 +2727,9 @@  discard block
 block discarded – undo
2590 2727
 	global $sourcedir, $smcFunc;
2591 2728
 
2592 2729
 	loadLanguage('Post');
2593
-	if (!isset($_REQUEST['xml']))
2594
-		loadTemplate('Post');
2730
+	if (!isset($_REQUEST['xml'])) {
2731
+			loadTemplate('Post');
2732
+	}
2595 2733
 
2596 2734
 	include_once($sourcedir . '/Subs-Post.php');
2597 2735
 
@@ -2622,8 +2760,9 @@  discard block
 block discarded – undo
2622 2760
 	$smcFunc['db_free_result']($request);
2623 2761
 
2624 2762
 	$context['sub_template'] = 'quotefast';
2625
-	if (!empty($row))
2626
-		$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2763
+	if (!empty($row)) {
2764
+			$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2765
+	}
2627 2766
 
2628 2767
 	if (!empty($can_view_post))
2629 2768
 	{
@@ -2656,8 +2795,9 @@  discard block
 block discarded – undo
2656 2795
 		}
2657 2796
 
2658 2797
 		// Remove any nested quotes.
2659
-		if (!empty($modSettings['removeNestedQuotes']))
2660
-			$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2798
+		if (!empty($modSettings['removeNestedQuotes'])) {
2799
+					$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2800
+		}
2661 2801
 
2662 2802
 		$lb = "\n";
2663 2803
 
@@ -2683,14 +2823,14 @@  discard block
 block discarded – undo
2683 2823
 				'time' => '',
2684 2824
 			),
2685 2825
 		);
2686
-	}
2687
-	else
2688
-		$context['quote'] = array(
2826
+	} else {
2827
+			$context['quote'] = array(
2689 2828
 			'xml' => '',
2690 2829
 			'mozilla' => '',
2691 2830
 			'text' => '',
2692 2831
 		);
2693
-}
2832
+	}
2833
+	}
2694 2834
 
2695 2835
 /**
2696 2836
  * Used to edit the body or subject of a message inline
@@ -2702,8 +2842,9 @@  discard block
 block discarded – undo
2702 2842
 	global $user_info, $context, $smcFunc, $language, $board_info;
2703 2843
 
2704 2844
 	// We have to have a topic!
2705
-	if (empty($topic))
2706
-		obExit(false);
2845
+	if (empty($topic)) {
2846
+			obExit(false);
2847
+	}
2707 2848
 
2708 2849
 	checkSession('get');
2709 2850
 	require_once($sourcedir . '/Subs-Post.php');
@@ -2729,31 +2870,35 @@  discard block
 block discarded – undo
2729 2870
 			'guest_id' => 0,
2730 2871
 		)
2731 2872
 	);
2732
-	if ($smcFunc['db_num_rows']($request) == 0)
2733
-		fatal_lang_error('no_board', false);
2873
+	if ($smcFunc['db_num_rows']($request) == 0) {
2874
+			fatal_lang_error('no_board', false);
2875
+	}
2734 2876
 	$row = $smcFunc['db_fetch_assoc']($request);
2735 2877
 	$smcFunc['db_free_result']($request);
2736 2878
 
2737 2879
 	// Change either body or subject requires permissions to modify messages.
2738 2880
 	if (isset($_POST['message']) || isset($_POST['subject']) || isset($_REQUEST['icon']))
2739 2881
 	{
2740
-		if (!empty($row['locked']))
2741
-			isAllowedTo('moderate_board');
2882
+		if (!empty($row['locked'])) {
2883
+					isAllowedTo('moderate_board');
2884
+		}
2742 2885
 
2743 2886
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
2744 2887
 		{
2745
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
2746
-				fatal_lang_error('modify_post_time_passed', false);
2747
-			elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
2748
-				isAllowedTo('modify_replies');
2749
-			else
2750
-				isAllowedTo('modify_own');
2888
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
2889
+							fatal_lang_error('modify_post_time_passed', false);
2890
+			} elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
2891
+							isAllowedTo('modify_replies');
2892
+			} else {
2893
+							isAllowedTo('modify_own');
2894
+			}
2751 2895
 		}
2752 2896
 		// Otherwise, they're locked out; someone who can modify the replies is needed.
2753
-		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
2754
-			isAllowedTo('modify_replies');
2755
-		else
2756
-			isAllowedTo('modify_any');
2897
+		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) {
2898
+					isAllowedTo('modify_replies');
2899
+		} else {
2900
+					isAllowedTo('modify_any');
2901
+		}
2757 2902
 
2758 2903
 		// Only log this action if it wasn't your message.
2759 2904
 		$moderationAction = $row['id_member'] != $user_info['id'];
@@ -2765,10 +2910,10 @@  discard block
 block discarded – undo
2765 2910
 		$_POST['subject'] = strtr($smcFunc['htmlspecialchars']($_POST['subject']), array("\r" => '', "\n" => '', "\t" => ''));
2766 2911
 
2767 2912
 		// Maximum number of characters.
2768
-		if ($smcFunc['strlen']($_POST['subject']) > 100)
2769
-			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2770
-	}
2771
-	elseif (isset($_POST['subject']))
2913
+		if ($smcFunc['strlen']($_POST['subject']) > 100) {
2914
+					$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2915
+		}
2916
+	} elseif (isset($_POST['subject']))
2772 2917
 	{
2773 2918
 		$post_errors[] = 'no_subject';
2774 2919
 		unset($_POST['subject']);
@@ -2780,13 +2925,11 @@  discard block
 block discarded – undo
2780 2925
 		{
2781 2926
 			$post_errors[] = 'no_message';
2782 2927
 			unset($_POST['message']);
2783
-		}
2784
-		elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2928
+		} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2785 2929
 		{
2786 2930
 			$post_errors[] = 'long_message';
2787 2931
 			unset($_POST['message']);
2788
-		}
2789
-		else
2932
+		} else
2790 2933
 		{
2791 2934
 			$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
2792 2935
 
@@ -2802,31 +2945,34 @@  discard block
 block discarded – undo
2802 2945
 
2803 2946
 	if (isset($_POST['lock']))
2804 2947
 	{
2805
-		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member']))
2806
-			unset($_POST['lock']);
2807
-		elseif (!allowedTo('lock_any'))
2948
+		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member'])) {
2949
+					unset($_POST['lock']);
2950
+		} elseif (!allowedTo('lock_any'))
2808 2951
 		{
2809
-			if ($row['locked'] == 1)
2810
-				unset($_POST['lock']);
2811
-			else
2812
-				$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
2952
+			if ($row['locked'] == 1) {
2953
+							unset($_POST['lock']);
2954
+			} else {
2955
+							$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
2956
+			}
2957
+		} elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked']) {
2958
+					unset($_POST['lock']);
2959
+		} else {
2960
+					$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2813 2961
 		}
2814
-		elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked'])
2815
-			unset($_POST['lock']);
2816
-		else
2817
-			$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2818 2962
 	}
2819 2963
 
2820
-	if (isset($_POST['sticky']) && !allowedTo('make_sticky'))
2821
-		unset($_POST['sticky']);
2964
+	if (isset($_POST['sticky']) && !allowedTo('make_sticky')) {
2965
+			unset($_POST['sticky']);
2966
+	}
2822 2967
 
2823 2968
 	if (isset($_POST['modify_reason']))
2824 2969
 	{
2825 2970
 		$_POST['modify_reason'] = strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
2826 2971
 
2827 2972
 		// Maximum number of characters.
2828
-		if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
2829
-			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2973
+		if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
2974
+					$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2975
+		}
2830 2976
 	}
2831 2977
 
2832 2978
 	if (empty($post_errors))
@@ -2863,8 +3009,9 @@  discard block
 block discarded – undo
2863 3009
 			}
2864 3010
 		}
2865 3011
 		// If nothing was changed there's no need to add an entry to the moderation log.
2866
-		else
2867
-			$moderationAction = false;
3012
+		else {
3013
+					$moderationAction = false;
3014
+		}
2868 3015
 
2869 3016
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2870 3017
 
@@ -2882,9 +3029,9 @@  discard block
 block discarded – undo
2882 3029
 			// Get the proper (default language) response prefix first.
2883 3030
 			if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
2884 3031
 			{
2885
-				if ($language === $user_info['language'])
2886
-					$context['response_prefix'] = $txt['response_prefix'];
2887
-				else
3032
+				if ($language === $user_info['language']) {
3033
+									$context['response_prefix'] = $txt['response_prefix'];
3034
+				} else
2888 3035
 				{
2889 3036
 					loadLanguage('index', $language, false);
2890 3037
 					$context['response_prefix'] = $txt['response_prefix'];
@@ -2906,8 +3053,9 @@  discard block
 block discarded – undo
2906 3053
 			);
2907 3054
 		}
2908 3055
 
2909
-		if (!empty($moderationAction))
2910
-			logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3056
+		if (!empty($moderationAction)) {
3057
+					logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3058
+		}
2911 3059
 	}
2912 3060
 
2913 3061
 	if (isset($_REQUEST['xml']))
@@ -2948,8 +3096,7 @@  discard block
 block discarded – undo
2948 3096
 			);
2949 3097
 
2950 3098
 			censorText($context['message']['subject']);
2951
-		}
2952
-		else
3099
+		} else
2953 3100
 		{
2954 3101
 			$context['message'] = array(
2955 3102
 				'id' => $row['id_msg'],
@@ -2961,15 +3108,16 @@  discard block
 block discarded – undo
2961 3108
 			loadLanguage('Errors');
2962 3109
 			foreach ($post_errors as $post_error)
2963 3110
 			{
2964
-				if ($post_error == 'long_message')
2965
-					$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
2966
-				else
2967
-					$context['message']['errors'][] = $txt['error_' . $post_error];
3111
+				if ($post_error == 'long_message') {
3112
+									$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
3113
+				} else {
3114
+									$context['message']['errors'][] = $txt['error_' . $post_error];
3115
+				}
2968 3116
 			}
2969 3117
 		}
3118
+	} else {
3119
+			obExit(false);
3120
+	}
2970 3121
 	}
2971
-	else
2972
-		obExit(false);
2973
-}
2974 3122
 
2975 3123
 ?>
2976 3124
\ No newline at end of file
Please login to merge, or discard this patch.