@@ -127,8 +127,8 @@ discard block |
||
127 | 127 | <div class="windowbg"> |
128 | 128 | <dl class="settings">'; |
129 | 129 | |
130 | - if (!empty($context['table_info'])) |
|
131 | - echo ' |
|
130 | + if (!empty($context['table_info'])) { |
|
131 | + echo ' |
|
132 | 132 | <dt> |
133 | 133 | <strong>', $txt['search_method_messages_table_space'], ':</strong> |
134 | 134 | </dt> |
@@ -141,6 +141,7 @@ discard block |
||
141 | 141 | <dd> |
142 | 142 | ', $context['table_info']['index_length'], ' |
143 | 143 | </dd>'; |
144 | + } |
|
144 | 145 | echo ' |
145 | 146 | </dl> |
146 | 147 | ', $context['double_index'] ? '<div class="noticebox"> |
@@ -163,17 +164,17 @@ discard block |
||
163 | 164 | <dd> |
164 | 165 | <span class="smalltext">'; |
165 | 166 | |
166 | - if (empty($context['fulltext_index']) && empty($context['cannot_create_fulltext'])) |
|
167 | - echo ' |
|
167 | + if (empty($context['fulltext_index']) && empty($context['cannot_create_fulltext'])) { |
|
168 | + echo ' |
|
168 | 169 | <strong>', $txt['search_index_label'], ':</strong> ', $txt['search_method_no_index_exists'], ' [<a href="', $scripturl, '?action=admin;area=managesearch;sa=createfulltext;', $context['session_var'], '=', $context['session_id'], ';', $context['admin-msm_token_var'], '=', $context['admin-msm_token'], '">', $txt['search_method_fulltext_create'], '</a>]'; |
169 | - |
|
170 | - elseif (empty($context['fulltext_index']) && !empty($context['cannot_create_fulltext'])) |
|
171 | - echo ' |
|
170 | + } elseif (empty($context['fulltext_index']) && !empty($context['cannot_create_fulltext'])) { |
|
171 | + echo ' |
|
172 | 172 | <strong>', $txt['search_index_label'], ':</strong> ', $txt['search_method_fulltext_cannot_create']; |
173 | - else |
|
174 | - echo ' |
|
173 | + } else { |
|
174 | + echo ' |
|
175 | 175 | <strong>', $txt['search_index_label'], ':</strong> ', $txt['search_method_index_already_exists'], ' [<a href="', $scripturl, '?action=admin;area=managesearch;sa=removefulltext;', $context['session_var'], '=', $context['session_id'], ';', $context['admin-msm_token_var'], '=', $context['admin-msm_token'], '">', $txt['search_method_fulltext_remove'], '</a>]<br> |
176 | 176 | <strong>', $txt['search_index_size'], ':</strong> ', $context['table_info']['fulltext_length']; |
177 | + } |
|
177 | 178 | echo ' |
178 | 179 | </span> |
179 | 180 | </dd>'; |
@@ -187,26 +188,27 @@ discard block |
||
187 | 188 | <dd> |
188 | 189 | <span class="smalltext">'; |
189 | 190 | |
190 | - if ($context['custom_index']) |
|
191 | - echo ' |
|
191 | + if ($context['custom_index']) { |
|
192 | + echo ' |
|
192 | 193 | <strong>', $txt['search_index_label'], ':</strong> ', $txt['search_method_index_already_exists'], ' [<a href="', $scripturl, '?action=admin;area=managesearch;sa=removecustom;', $context['session_var'], '=', $context['session_id'], ';', $context['admin-msm_token_var'], '=', $context['admin-msm_token'], '">', $txt['search_index_custom_remove'], '</a>]<br> |
193 | 194 | <strong>', $txt['search_index_size'], ':</strong> ', $context['table_info']['custom_index_length']; |
194 | - |
|
195 | - elseif ($context['partial_custom_index']) |
|
196 | - echo ' |
|
195 | + } elseif ($context['partial_custom_index']) { |
|
196 | + echo ' |
|
197 | 197 | <strong>', $txt['search_index_label'], ':</strong> ', $txt['search_method_index_partial'], ' [<a href="', $scripturl, '?action=admin;area=managesearch;sa=removecustom;', $context['session_var'], '=', $context['session_id'], ';', $context['admin-msm_token_var'], '=', $context['admin-msm_token'], '">', $txt['search_index_custom_remove'], '</a>] [<a href="', $scripturl, '?action=admin;area=managesearch;sa=createmsgindex;resume;', $context['session_var'], '=', $context['session_id'], ';', $context['admin-msm_token_var'], '=', $context['admin-msm_token'], '">', $txt['search_index_custom_resume'], '</a>]<br> |
198 | 198 | <strong>', $txt['search_index_size'], ':</strong> ', $context['table_info']['custom_index_length']; |
199 | - else |
|
200 | - echo ' |
|
199 | + } else { |
|
200 | + echo ' |
|
201 | 201 | <strong>', $txt['search_index_label'], ':</strong> ', $txt['search_method_no_index_exists'], ' [<a href="', $scripturl, '?action=admin;area=managesearch;sa=createmsgindex">', $txt['search_index_create_custom'], '</a>]'; |
202 | + } |
|
202 | 203 | echo ' |
203 | 204 | </span> |
204 | 205 | </dd>'; |
205 | 206 | |
206 | 207 | foreach ($context['search_apis'] as $api) |
207 | 208 | { |
208 | - if (empty($api['label']) || $api['has_template']) |
|
209 | - continue; |
|
209 | + if (empty($api['label']) || $api['has_template']) { |
|
210 | + continue; |
|
211 | + } |
|
210 | 212 | |
211 | 213 | echo ' |
212 | 214 | <dt> |
@@ -214,11 +216,12 @@ discard block |
||
214 | 216 | ', $api['label'], ' |
215 | 217 | </dt>'; |
216 | 218 | |
217 | - if ($api['desc']) |
|
218 | - echo ' |
|
219 | + if ($api['desc']) { |
|
220 | + echo ' |
|
219 | 221 | <dd> |
220 | 222 | <span class="smalltext">', $api['desc'], '</span> |
221 | 223 | </dd>'; |
224 | + } |
|
222 | 225 | } |
223 | 226 | |
224 | 227 | echo ' |
@@ -18,23 +18,25 @@ discard block |
||
18 | 18 | global $context; |
19 | 19 | |
20 | 20 | // Prevent Chrome from auto completing fields when viewing/editing other members profiles |
21 | - if (isBrowser('is_chrome') && !$context['user']['is_owner']) |
|
22 | - echo ' |
|
21 | + if (isBrowser('is_chrome') && !$context['user']['is_owner']) { |
|
22 | + echo ' |
|
23 | 23 | <script> |
24 | 24 | disableAutoComplete(); |
25 | 25 | </script>'; |
26 | + } |
|
26 | 27 | |
27 | 28 | // If an error occurred while trying to save previously, give the user a clue! |
28 | 29 | echo ' |
29 | 30 | ', template_error_message(); |
30 | 31 | |
31 | 32 | // If the profile was update successfully, let the user know this. |
32 | - if (!empty($context['profile_updated'])) |
|
33 | - echo ' |
|
33 | + if (!empty($context['profile_updated'])) { |
|
34 | + echo ' |
|
34 | 35 | <div class="infobox"> |
35 | 36 | ', $context['profile_updated'], ' |
36 | 37 | </div>'; |
37 | -} |
|
38 | + } |
|
39 | + } |
|
38 | 40 | |
39 | 41 | /** |
40 | 42 | * Template for any HTML needed below the profile (closing off divs/tables, etc.) |
@@ -99,19 +101,19 @@ discard block |
||
99 | 101 | </div> |
100 | 102 | <div class="alerts_unread">'; |
101 | 103 | |
102 | - if (empty($context['unread_alerts'])) |
|
103 | - template_alerts_all_read(); |
|
104 | - |
|
105 | - else |
|
104 | + if (empty($context['unread_alerts'])) { |
|
105 | + template_alerts_all_read(); |
|
106 | + } else |
|
106 | 107 | { |
107 | - foreach ($context['unread_alerts'] as $id_alert => $details) |
|
108 | - echo ' |
|
108 | + foreach ($context['unread_alerts'] as $id_alert => $details) { |
|
109 | + echo ' |
|
109 | 110 | <div class="unread"> |
110 | 111 | ', !empty($details['sender']) ? $details['sender']['avatar']['image'] : '', ' |
111 | 112 | <div class="details"> |
112 | 113 | ', !empty($details['icon']) ? $details['icon'] : '', '<span>', $details['text'], '</span> - ', $details['time'], ' |
113 | 114 | </div> |
114 | 115 | </div>'; |
116 | + } |
|
115 | 117 | } |
116 | 118 | |
117 | 119 | echo ' |
@@ -158,37 +160,41 @@ discard block |
||
158 | 160 | if (!empty($context['print_custom_fields']['above_member'])) |
159 | 161 | { |
160 | 162 | $fields = ''; |
161 | - foreach ($context['print_custom_fields']['above_member'] as $field) |
|
162 | - if (!empty($field['output_html'])) |
|
163 | + foreach ($context['print_custom_fields']['above_member'] as $field) { |
|
164 | + if (!empty($field['output_html'])) |
|
163 | 165 | $fields .= ' |
164 | 166 | <li>' . $field['output_html'] . '</li>'; |
167 | + } |
|
165 | 168 | |
166 | - if (!empty($fields)) |
|
167 | - echo ' |
|
169 | + if (!empty($fields)) { |
|
170 | + echo ' |
|
168 | 171 | <div class="custom_fields_above_name"> |
169 | 172 | <ul>', $fields, ' |
170 | 173 | </ul> |
171 | 174 | </div>'; |
175 | + } |
|
172 | 176 | } |
173 | 177 | |
174 | 178 | echo ' |
175 | 179 | <div class="username clear"> |
176 | 180 | <h4>'; |
177 | 181 | |
178 | - if (!empty($context['print_custom_fields']['before_member'])) |
|
179 | - foreach ($context['print_custom_fields']['before_member'] as $field) |
|
182 | + if (!empty($context['print_custom_fields']['before_member'])) { |
|
183 | + foreach ($context['print_custom_fields']['before_member'] as $field) |
|
180 | 184 | if (!empty($field['output_html'])) |
181 | 185 | echo ' |
182 | 186 | <span>', $field['output_html'], '</span>'; |
187 | + } |
|
183 | 188 | |
184 | 189 | echo ' |
185 | 190 | ', $context['member']['name']; |
186 | 191 | |
187 | - if (!empty($context['print_custom_fields']['after_member'])) |
|
188 | - foreach ($context['print_custom_fields']['after_member'] as $field) |
|
192 | + if (!empty($context['print_custom_fields']['after_member'])) { |
|
193 | + foreach ($context['print_custom_fields']['after_member'] as $field) |
|
189 | 194 | if (!empty($field['output_html'])) |
190 | 195 | echo ' |
191 | 196 | <span>', $field['output_html'], '</span>'; |
197 | + } |
|
192 | 198 | |
193 | 199 | |
194 | 200 | echo ' |
@@ -201,39 +207,44 @@ discard block |
||
201 | 207 | if (!empty($context['print_custom_fields']['below_avatar'])) |
202 | 208 | { |
203 | 209 | $fields = ''; |
204 | - foreach ($context['print_custom_fields']['below_avatar'] as $field) |
|
205 | - if (!empty($field['output_html'])) |
|
210 | + foreach ($context['print_custom_fields']['below_avatar'] as $field) { |
|
211 | + if (!empty($field['output_html'])) |
|
206 | 212 | $fields .= ' |
207 | 213 | <li>' . $field['output_html'] . '</li>'; |
214 | + } |
|
208 | 215 | |
209 | - if (!empty($fields)) |
|
210 | - echo ' |
|
216 | + if (!empty($fields)) { |
|
217 | + echo ' |
|
211 | 218 | <div class="custom_fields_below_avatar"> |
212 | 219 | <ul>', $fields, ' |
213 | 220 | </ul> |
214 | 221 | </div>'; |
222 | + } |
|
215 | 223 | } |
216 | 224 | |
217 | 225 | echo ' |
218 | 226 | <ul class="icon_fields clear">'; |
219 | 227 | |
220 | 228 | // Email is only visible if it's your profile or you have the moderate_forum permission |
221 | - if ($context['member']['show_email']) |
|
222 | - echo ' |
|
229 | + if ($context['member']['show_email']) { |
|
230 | + echo ' |
|
223 | 231 | <li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>'; |
232 | + } |
|
224 | 233 | |
225 | 234 | // Don't show an icon if they haven't specified a website. |
226 | - if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) |
|
227 | - echo ' |
|
235 | + if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) { |
|
236 | + echo ' |
|
228 | 237 | <li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank" rel="noopener">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
238 | + } |
|
229 | 239 | |
230 | 240 | // Are there any custom profile fields as icons? |
231 | 241 | if (!empty($context['print_custom_fields']['icons'])) |
232 | 242 | { |
233 | - foreach ($context['print_custom_fields']['icons'] as $field) |
|
234 | - if (!empty($field['output_html'])) |
|
243 | + foreach ($context['print_custom_fields']['icons'] as $field) { |
|
244 | + if (!empty($field['output_html'])) |
|
235 | 245 | echo ' |
236 | 246 | <li class="custom_field">', $field['output_html'], '</li>'; |
247 | + } |
|
237 | 248 | } |
238 | 249 | |
239 | 250 | echo ' |
@@ -242,24 +253,27 @@ discard block |
||
242 | 253 | ', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : ''; |
243 | 254 | |
244 | 255 | // Can they add this member as a buddy? |
245 | - if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) |
|
246 | - echo ' |
|
256 | + if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) { |
|
257 | + echo ' |
|
247 | 258 | <br> |
248 | 259 | <a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], '</a>'; |
260 | + } |
|
249 | 261 | |
250 | 262 | echo ' |
251 | 263 | </span>'; |
252 | 264 | |
253 | - if (!$context['user']['is_owner'] && $context['can_send_pm']) |
|
254 | - echo ' |
|
265 | + if (!$context['user']['is_owner'] && $context['can_send_pm']) { |
|
266 | + echo ' |
|
255 | 267 | <a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>'; |
268 | + } |
|
256 | 269 | |
257 | 270 | echo ' |
258 | 271 | <a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>'; |
259 | 272 | |
260 | - if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) |
|
261 | - echo ' |
|
273 | + if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) { |
|
274 | + echo ' |
|
262 | 275 | <a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>'; |
276 | + } |
|
263 | 277 | |
264 | 278 | echo ' |
265 | 279 | <a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>'; |
@@ -268,17 +282,19 @@ discard block |
||
268 | 282 | if (!empty($context['print_custom_fields']['bottom_poster'])) |
269 | 283 | { |
270 | 284 | $fields = ''; |
271 | - foreach ($context['print_custom_fields']['bottom_poster'] as $field) |
|
272 | - if (!empty($field['output_html'])) |
|
285 | + foreach ($context['print_custom_fields']['bottom_poster'] as $field) { |
|
286 | + if (!empty($field['output_html'])) |
|
273 | 287 | $fields .= ' |
274 | 288 | <li>' . $field['output_html'] . '</li>'; |
289 | + } |
|
275 | 290 | |
276 | - if (!empty($fields)) |
|
277 | - echo ' |
|
291 | + if (!empty($fields)) { |
|
292 | + echo ' |
|
278 | 293 | <div class="custom_fields_bottom"> |
279 | 294 | <ul class="nolist">', $fields, ' |
280 | 295 | </ul> |
281 | 296 | </div>'; |
297 | + } |
|
282 | 298 | } |
283 | 299 | |
284 | 300 | echo ' |
@@ -287,30 +303,35 @@ discard block |
||
287 | 303 | <div id="detailedinfo"> |
288 | 304 | <dl class="settings">'; |
289 | 305 | |
290 | - if ($context['user']['is_owner'] || $context['user']['is_admin']) |
|
291 | - echo ' |
|
306 | + if ($context['user']['is_owner'] || $context['user']['is_admin']) { |
|
307 | + echo ' |
|
292 | 308 | <dt>', $txt['username'], ': </dt> |
293 | 309 | <dd>', $context['member']['username'], '</dd>'; |
310 | + } |
|
294 | 311 | |
295 | - if (!isset($context['disabled_fields']['posts'])) |
|
296 | - echo ' |
|
312 | + if (!isset($context['disabled_fields']['posts'])) { |
|
313 | + echo ' |
|
297 | 314 | <dt>', $txt['profile_posts'], ': </dt> |
298 | 315 | <dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>'; |
316 | + } |
|
299 | 317 | |
300 | - if ($context['member']['show_email']) |
|
301 | - echo ' |
|
318 | + if ($context['member']['show_email']) { |
|
319 | + echo ' |
|
302 | 320 | <dt>', $txt['email'], ': </dt> |
303 | 321 | <dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>'; |
322 | + } |
|
304 | 323 | |
305 | - if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) |
|
306 | - echo ' |
|
324 | + if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) { |
|
325 | + echo ' |
|
307 | 326 | <dt>', $txt['custom_title'], ': </dt> |
308 | 327 | <dd>', $context['member']['title'], '</dd>'; |
328 | + } |
|
309 | 329 | |
310 | - if (!empty($context['member']['blurb'])) |
|
311 | - echo ' |
|
330 | + if (!empty($context['member']['blurb'])) { |
|
331 | + echo ' |
|
312 | 332 | <dt>', $txt['personal_text'], ': </dt> |
313 | 333 | <dd>', $context['member']['blurb'], '</dd>'; |
334 | + } |
|
314 | 335 | |
315 | 336 | echo ' |
316 | 337 | <dt>', $txt['age'], ':</dt> |
@@ -324,19 +345,21 @@ discard block |
||
324 | 345 | { |
325 | 346 | $fields = array(); |
326 | 347 | |
327 | - foreach ($context['print_custom_fields']['standard'] as $field) |
|
328 | - if (!empty($field['output_html'])) |
|
348 | + foreach ($context['print_custom_fields']['standard'] as $field) { |
|
349 | + if (!empty($field['output_html'])) |
|
329 | 350 | $fields[] = $field; |
351 | + } |
|
330 | 352 | |
331 | 353 | if (count($fields) > 0) |
332 | 354 | { |
333 | 355 | echo ' |
334 | 356 | <dl class="settings">'; |
335 | 357 | |
336 | - foreach ($fields as $field) |
|
337 | - echo ' |
|
358 | + foreach ($fields as $field) { |
|
359 | + echo ' |
|
338 | 360 | <dt>', $field['name'], ':</dt> |
339 | 361 | <dd>', $field['output_html'], '</dd>'; |
362 | + } |
|
340 | 363 | |
341 | 364 | echo ' |
342 | 365 | </dl>'; |
@@ -355,9 +378,10 @@ discard block |
||
355 | 378 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>'; |
356 | 379 | |
357 | 380 | // Can we provide information on what this means? |
358 | - if (!empty($context['warning_status'])) |
|
359 | - echo ' |
|
381 | + if (!empty($context['warning_status'])) { |
|
382 | + echo ' |
|
360 | 383 | <span class="smalltext">(', $context['warning_status'], ')</span>'; |
384 | + } |
|
361 | 385 | |
362 | 386 | echo ' |
363 | 387 | </dd>'; |
@@ -367,11 +391,12 @@ discard block |
||
367 | 391 | if (!empty($context['activate_message']) || !empty($context['member']['bans'])) |
368 | 392 | { |
369 | 393 | // If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves. |
370 | - if (!empty($context['activate_message'])) |
|
371 | - echo ' |
|
394 | + if (!empty($context['activate_message'])) { |
|
395 | + echo ' |
|
372 | 396 | <dt class="clear"> |
373 | 397 | <span class="alert">', $context['activate_message'], '</span> (<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>) |
374 | 398 | </dt>'; |
399 | + } |
|
375 | 400 | |
376 | 401 | // If the current member is banned, show a message and possibly a link to the ban. |
377 | 402 | if (!empty($context['member']['bans'])) |
@@ -383,10 +408,11 @@ discard block |
||
383 | 408 | <dt class="clear" id="ban_info" style="display: none;"> |
384 | 409 | <strong>', $txt['user_banned_by_following'], ':</strong>'; |
385 | 410 | |
386 | - foreach ($context['member']['bans'] as $ban) |
|
387 | - echo ' |
|
411 | + foreach ($context['member']['bans'] as $ban) { |
|
412 | + echo ' |
|
388 | 413 | <br> |
389 | 414 | <span class="smalltext">', $ban['explanation'], '</span>'; |
415 | + } |
|
390 | 416 | |
391 | 417 | echo ' |
392 | 418 | </dt>'; |
@@ -400,30 +426,34 @@ discard block |
||
400 | 426 | // If the person looking is allowed, they can check the members IP address and hostname. |
401 | 427 | if ($context['can_see_ip']) |
402 | 428 | { |
403 | - if (!empty($context['member']['ip'])) |
|
404 | - echo ' |
|
429 | + if (!empty($context['member']['ip'])) { |
|
430 | + echo ' |
|
405 | 431 | <dt>', $txt['ip'], ': </dt> |
406 | 432 | <dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>'; |
433 | + } |
|
407 | 434 | |
408 | - if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) |
|
409 | - echo ' |
|
435 | + if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) { |
|
436 | + echo ' |
|
410 | 437 | <dt>', $txt['hostname'], ': </dt> |
411 | 438 | <dd>', $context['member']['hostname'], '</dd>'; |
439 | + } |
|
412 | 440 | } |
413 | 441 | |
414 | 442 | echo ' |
415 | 443 | <dt>', $txt['local_time'], ':</dt> |
416 | 444 | <dd>', $context['member']['local_time'], '</dd>'; |
417 | 445 | |
418 | - if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) |
|
419 | - echo ' |
|
446 | + if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) { |
|
447 | + echo ' |
|
420 | 448 | <dt>', $txt['language'], ':</dt> |
421 | 449 | <dd>', $context['member']['language'], '</dd>'; |
450 | + } |
|
422 | 451 | |
423 | - if ($context['member']['show_last_login']) |
|
424 | - echo ' |
|
452 | + if ($context['member']['show_last_login']) { |
|
453 | + echo ' |
|
425 | 454 | <dt>', $txt['lastLoggedIn'], ': </dt> |
426 | 455 | <dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>'; |
456 | + } |
|
427 | 457 | |
428 | 458 | echo ' |
429 | 459 | </dl>'; |
@@ -432,42 +462,47 @@ discard block |
||
432 | 462 | if (!empty($context['print_custom_fields']['above_signature'])) |
433 | 463 | { |
434 | 464 | $fields = ''; |
435 | - foreach ($context['print_custom_fields']['above_signature'] as $field) |
|
436 | - if (!empty($field['output_html'])) |
|
465 | + foreach ($context['print_custom_fields']['above_signature'] as $field) { |
|
466 | + if (!empty($field['output_html'])) |
|
437 | 467 | $fields .= ' |
438 | 468 | <li>' . $field['output_html'] . '</li>'; |
469 | + } |
|
439 | 470 | |
440 | - if (!empty($fields)) |
|
441 | - echo ' |
|
471 | + if (!empty($fields)) { |
|
472 | + echo ' |
|
442 | 473 | <div class="custom_fields_above_signature"> |
443 | 474 | <ul class="nolist">', $fields, ' |
444 | 475 | </ul> |
445 | 476 | </div>'; |
477 | + } |
|
446 | 478 | } |
447 | 479 | |
448 | 480 | // Show the users signature. |
449 | - if ($context['signature_enabled'] && !empty($context['member']['signature'])) |
|
450 | - echo ' |
|
481 | + if ($context['signature_enabled'] && !empty($context['member']['signature'])) { |
|
482 | + echo ' |
|
451 | 483 | <div class="signature"> |
452 | 484 | <h5>', $txt['signature'], ':</h5> |
453 | 485 | ', $context['member']['signature'], ' |
454 | 486 | </div>'; |
487 | + } |
|
455 | 488 | |
456 | 489 | // Are there any custom profile fields for below the signature? |
457 | 490 | if (!empty($context['print_custom_fields']['below_signature'])) |
458 | 491 | { |
459 | 492 | $fields = ''; |
460 | - foreach ($context['print_custom_fields']['below_signature'] as $field) |
|
461 | - if (!empty($field['output_html'])) |
|
493 | + foreach ($context['print_custom_fields']['below_signature'] as $field) { |
|
494 | + if (!empty($field['output_html'])) |
|
462 | 495 | $fields .= ' |
463 | 496 | <li>' . $field['output_html'] . '</li>'; |
497 | + } |
|
464 | 498 | |
465 | - if (!empty($fields)) |
|
466 | - echo ' |
|
499 | + if (!empty($fields)) { |
|
500 | + echo ' |
|
467 | 501 | <div class="custom_fields_below_signature"> |
468 | 502 | <ul class="nolist">', $fields, ' |
469 | 503 | </ul> |
470 | 504 | </div>'; |
505 | + } |
|
471 | 506 | } |
472 | 507 | |
473 | 508 | echo ' |
@@ -509,62 +544,70 @@ discard block |
||
509 | 544 | </div> |
510 | 545 | <div class="list_posts">'; |
511 | 546 | |
512 | - if (!$post['approved']) |
|
513 | - echo ' |
|
547 | + if (!$post['approved']) { |
|
548 | + echo ' |
|
514 | 549 | <div class="approve_post"> |
515 | 550 | <em>', $txt['post_awaiting_approval'], '</em> |
516 | 551 | </div>'; |
552 | + } |
|
517 | 553 | |
518 | 554 | echo ' |
519 | 555 | ', $post['body'], ' |
520 | 556 | </div>'; |
521 | 557 | |
522 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
523 | - echo ' |
|
558 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
559 | + echo ' |
|
524 | 560 | <div class="floatright"> |
525 | 561 | <ul class="quickbuttons">'; |
562 | + } |
|
526 | 563 | |
527 | 564 | // If they *can* reply? |
528 | - if ($post['can_reply']) |
|
529 | - echo ' |
|
565 | + if ($post['can_reply']) { |
|
566 | + echo ' |
|
530 | 567 | <li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>'; |
568 | + } |
|
531 | 569 | |
532 | 570 | // If they *can* quote? |
533 | - if ($post['can_quote']) |
|
534 | - echo ' |
|
571 | + if ($post['can_quote']) { |
|
572 | + echo ' |
|
535 | 573 | <li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>'; |
574 | + } |
|
536 | 575 | |
537 | 576 | // How about... even... remove it entirely?! |
538 | - if ($post['can_delete']) |
|
539 | - echo ' |
|
577 | + if ($post['can_delete']) { |
|
578 | + echo ' |
|
540 | 579 | <li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
580 | + } |
|
541 | 581 | |
542 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
543 | - echo ' |
|
582 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
583 | + echo ' |
|
544 | 584 | </ul> |
545 | 585 | </div><!-- .floatright -->'; |
586 | + } |
|
546 | 587 | |
547 | 588 | echo ' |
548 | 589 | </div><!-- $post[css_class] -->'; |
549 | 590 | } |
591 | + } else { |
|
592 | + template_show_list('attachments'); |
|
550 | 593 | } |
551 | - else |
|
552 | - template_show_list('attachments'); |
|
553 | 594 | |
554 | 595 | // No posts? Just end with a informative message. |
555 | - if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) |
|
556 | - echo ' |
|
596 | + if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) { |
|
597 | + echo ' |
|
557 | 598 | <div class="windowbg"> |
558 | 599 | ', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), ' |
559 | 600 | </div>'; |
601 | + } |
|
560 | 602 | |
561 | 603 | // Show more page numbers. |
562 | - if (!empty($context['page_index'])) |
|
563 | - echo ' |
|
604 | + if (!empty($context['page_index'])) { |
|
605 | + echo ' |
|
564 | 606 | <div class="pagesection"> |
565 | 607 | <div class="pagelinks">', $context['page_index'], '</div> |
566 | 608 | </div>'; |
567 | -} |
|
609 | + } |
|
610 | + } |
|
568 | 611 | |
569 | 612 | /** |
570 | 613 | * Template for showing alerts within the alerts popup |
@@ -574,11 +617,12 @@ discard block |
||
574 | 617 | global $context, $txt, $scripturl; |
575 | 618 | |
576 | 619 | // Do we have an update message? |
577 | - if (!empty($context['update_message'])) |
|
578 | - echo ' |
|
620 | + if (!empty($context['update_message'])) { |
|
621 | + echo ' |
|
579 | 622 | <div class="infobox"> |
580 | 623 | ', $context['update_message'], ' |
581 | 624 | </div>'; |
625 | + } |
|
582 | 626 | |
583 | 627 | echo ' |
584 | 628 | <div class="cat_bar"> |
@@ -587,18 +631,18 @@ discard block |
||
587 | 631 | </h3> |
588 | 632 | </div>'; |
589 | 633 | |
590 | - if (empty($context['alerts'])) |
|
591 | - echo ' |
|
634 | + if (empty($context['alerts'])) { |
|
635 | + echo ' |
|
592 | 636 | <div class="information"> |
593 | 637 | ', $txt['alerts_none'], ' |
594 | 638 | </div>'; |
595 | - |
|
596 | - else |
|
639 | + } else |
|
597 | 640 | { |
598 | 641 | // Start the form if checkboxes are in use |
599 | - if ($context['showCheckboxes']) |
|
600 | - echo ' |
|
642 | + if ($context['showCheckboxes']) { |
|
643 | + echo ' |
|
601 | 644 | <form action="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;save" method="post" accept-charset="', $context['character_set'], '" id="mark_all">'; |
645 | + } |
|
602 | 646 | |
603 | 647 | echo ' |
604 | 648 | <table id="alerts" class="table_grid">'; |
@@ -614,9 +658,10 @@ discard block |
||
614 | 658 | <li><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;do=remove;aid=', $id, ';', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['delete'], '</a></li> |
615 | 659 | <li><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;do=', ($alert['is_read'] != 0 ? 'unread' : 'read'), ';aid=', $id, ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons ', $alert['is_read'] != 0 ? 'unread_button' : 'read_button', '"></span>', ($alert['is_read'] != 0 ? $txt['mark_unread'] : $txt['mark_read_short']), '</a></li>'; |
616 | 660 | |
617 | - if ($context['showCheckboxes']) |
|
618 | - echo ' |
|
661 | + if ($context['showCheckboxes']) { |
|
662 | + echo ' |
|
619 | 663 | <li><input type="checkbox" name="mark[', $id, ']" value="', $id, '"></li>'; |
664 | + } |
|
620 | 665 | |
621 | 666 | echo ' |
622 | 667 | </ul> |
@@ -631,8 +676,8 @@ discard block |
||
631 | 676 | ', $context['pagination'], ' |
632 | 677 | </div>'; |
633 | 678 | |
634 | - if ($context['showCheckboxes']) |
|
635 | - echo ' |
|
679 | + if ($context['showCheckboxes']) { |
|
680 | + echo ' |
|
636 | 681 | <div class="floatright"> |
637 | 682 | ', $txt['check_all'], ': <input type="checkbox" name="select_all" id="select_all"> |
638 | 683 | <select name="mark_as"> |
@@ -643,14 +688,16 @@ discard block |
||
643 | 688 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
644 | 689 | <input type="submit" name="req" value="', $txt['quick_mod_go'], '" class="button you_sure"> |
645 | 690 | </div>'; |
691 | + } |
|
646 | 692 | |
647 | 693 | echo ' |
648 | 694 | </div>'; |
649 | 695 | |
650 | - if ($context['showCheckboxes']) |
|
651 | - echo ' |
|
696 | + if ($context['showCheckboxes']) { |
|
697 | + echo ' |
|
652 | 698 | </form>'; |
653 | 699 | } |
700 | + } |
|
654 | 701 | } |
655 | 702 | |
656 | 703 | /** |
@@ -671,12 +718,12 @@ discard block |
||
671 | 718 | </div>' : ''; |
672 | 719 | |
673 | 720 | // No drafts? Just show an informative message. |
674 | - if (empty($context['drafts'])) |
|
675 | - echo ' |
|
721 | + if (empty($context['drafts'])) { |
|
722 | + echo ' |
|
676 | 723 | <div class="windowbg centertext"> |
677 | 724 | ', $txt['draft_none'], ' |
678 | 725 | </div>'; |
679 | - else |
|
726 | + } else |
|
680 | 727 | { |
681 | 728 | // For every draft to be displayed, give it its own div, and show the important details of the draft. |
682 | 729 | foreach ($context['drafts'] as $draft) |
@@ -688,13 +735,15 @@ discard block |
||
688 | 735 | <h5> |
689 | 736 | <strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> '; |
690 | 737 | |
691 | - if (!empty($draft['sticky'])) |
|
692 | - echo ' |
|
738 | + if (!empty($draft['sticky'])) { |
|
739 | + echo ' |
|
693 | 740 | <span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>'; |
741 | + } |
|
694 | 742 | |
695 | - if (!empty($draft['locked'])) |
|
696 | - echo ' |
|
743 | + if (!empty($draft['locked'])) { |
|
744 | + echo ' |
|
697 | 745 | <span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>'; |
746 | + } |
|
698 | 747 | |
699 | 748 | echo ' |
700 | 749 | </h5> |
@@ -727,13 +776,13 @@ discard block |
||
727 | 776 | { |
728 | 777 | global $context, $scripturl, $txt; |
729 | 778 | |
730 | - if (!empty($context['saved_successful'])) |
|
731 | - echo ' |
|
779 | + if (!empty($context['saved_successful'])) { |
|
780 | + echo ' |
|
732 | 781 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
733 | - |
|
734 | - elseif (!empty($context['saved_failed'])) |
|
735 | - echo ' |
|
782 | + } elseif (!empty($context['saved_failed'])) { |
|
783 | + echo ' |
|
736 | 784 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
785 | + } |
|
737 | 786 | |
738 | 787 | echo ' |
739 | 788 | <div id="edit_buddies"> |
@@ -748,14 +797,16 @@ discard block |
||
748 | 797 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
749 | 798 | <th scope="col">', $txt['status'], '</th>'; |
750 | 799 | |
751 | - if (allowedTo('moderate_forum')) |
|
752 | - echo ' |
|
800 | + if (allowedTo('moderate_forum')) { |
|
801 | + echo ' |
|
753 | 802 | <th scope="col">', $txt['email'], '</th>'; |
803 | + } |
|
754 | 804 | |
755 | - if (!empty($context['custom_pf'])) |
|
756 | - foreach ($context['custom_pf'] as $column) |
|
805 | + if (!empty($context['custom_pf'])) { |
|
806 | + foreach ($context['custom_pf'] as $column) |
|
757 | 807 | echo ' |
758 | 808 | <th scope="col">', $column['label'], '</th>'; |
809 | + } |
|
759 | 810 | |
760 | 811 | echo ' |
761 | 812 | <th scope="col">', $txt['remove'], '</th> |
@@ -764,13 +815,14 @@ discard block |
||
764 | 815 | <tbody>'; |
765 | 816 | |
766 | 817 | // If they don't have any buddies don't list them! |
767 | - if (empty($context['buddies'])) |
|
768 | - echo ' |
|
818 | + if (empty($context['buddies'])) { |
|
819 | + echo ' |
|
769 | 820 | <tr class="windowbg"> |
770 | 821 | <td colspan="', allowedTo('moderate_forum') ? '10' : '9', '"> |
771 | 822 | <strong>', $txt['no_buddies'], '</strong> |
772 | 823 | </td> |
773 | 824 | </tr>'; |
825 | + } |
|
774 | 826 | |
775 | 827 | // Now loop through each buddy showing info on each. |
776 | 828 | else |
@@ -784,17 +836,19 @@ discard block |
||
784 | 836 | <a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a> |
785 | 837 | </td>'; |
786 | 838 | |
787 | - if ($buddy['show_email']) |
|
788 | - echo ' |
|
839 | + if ($buddy['show_email']) { |
|
840 | + echo ' |
|
789 | 841 | <td> |
790 | 842 | <a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a> |
791 | 843 | </td>'; |
844 | + } |
|
792 | 845 | |
793 | 846 | // Show the custom profile fields for this user. |
794 | - if (!empty($context['custom_pf'])) |
|
795 | - foreach ($context['custom_pf'] as $key => $column) |
|
847 | + if (!empty($context['custom_pf'])) { |
|
848 | + foreach ($context['custom_pf'] as $key => $column) |
|
796 | 849 | echo ' |
797 | 850 | <td class="lefttext">', $buddy['options'][$key], '</td>'; |
851 | + } |
|
798 | 852 | |
799 | 853 | echo ' |
800 | 854 | <td> |
@@ -827,9 +881,10 @@ discard block |
||
827 | 881 | </dl> |
828 | 882 | </div>'; |
829 | 883 | |
830 | - if (!empty($context['token_check'])) |
|
831 | - echo ' |
|
884 | + if (!empty($context['token_check'])) { |
|
885 | + echo ' |
|
832 | 886 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
887 | + } |
|
833 | 888 | |
834 | 889 | echo ' |
835 | 890 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -855,13 +910,13 @@ discard block |
||
855 | 910 | { |
856 | 911 | global $context, $scripturl, $txt; |
857 | 912 | |
858 | - if (!empty($context['saved_successful'])) |
|
859 | - echo ' |
|
913 | + if (!empty($context['saved_successful'])) { |
|
914 | + echo ' |
|
860 | 915 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
861 | - |
|
862 | - elseif (!empty($context['saved_failed'])) |
|
863 | - echo ' |
|
916 | + } elseif (!empty($context['saved_failed'])) { |
|
917 | + echo ' |
|
864 | 918 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
919 | + } |
|
865 | 920 | |
866 | 921 | echo ' |
867 | 922 | <div id="edit_buddies"> |
@@ -876,9 +931,10 @@ discard block |
||
876 | 931 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
877 | 932 | <th scope="col">', $txt['status'], '</th>'; |
878 | 933 | |
879 | - if (allowedTo('moderate_forum')) |
|
880 | - echo ' |
|
934 | + if (allowedTo('moderate_forum')) { |
|
935 | + echo ' |
|
881 | 936 | <th scope="col">', $txt['email'], '</th>'; |
937 | + } |
|
882 | 938 | |
883 | 939 | echo ' |
884 | 940 | <th scope="col">', $txt['ignore_remove'], '</th> |
@@ -887,13 +943,14 @@ discard block |
||
887 | 943 | <tbody>'; |
888 | 944 | |
889 | 945 | // If they don't have anyone on their ignore list, don't list it! |
890 | - if (empty($context['ignore_list'])) |
|
891 | - echo ' |
|
946 | + if (empty($context['ignore_list'])) { |
|
947 | + echo ' |
|
892 | 948 | <tr class="windowbg"> |
893 | 949 | <td colspan="', allowedTo('moderate_forum') ? '4' : '3', '"> |
894 | 950 | <strong>', $txt['no_ignore'], '</strong> |
895 | 951 | </td> |
896 | 952 | </tr>'; |
953 | + } |
|
897 | 954 | |
898 | 955 | // Now loop through each buddy showing info on each. |
899 | 956 | foreach ($context['ignore_list'] as $member) |
@@ -905,11 +962,12 @@ discard block |
||
905 | 962 | <a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a> |
906 | 963 | </td>'; |
907 | 964 | |
908 | - if ($member['show_email']) |
|
909 | - echo ' |
|
965 | + if ($member['show_email']) { |
|
966 | + echo ' |
|
910 | 967 | <td> |
911 | 968 | <a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a> |
912 | 969 | </td>'; |
970 | + } |
|
913 | 971 | echo ' |
914 | 972 | <td> |
915 | 973 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a> |
@@ -939,9 +997,10 @@ discard block |
||
939 | 997 | </dl> |
940 | 998 | </div>'; |
941 | 999 | |
942 | - if (!empty($context['token_check'])) |
|
943 | - echo ' |
|
1000 | + if (!empty($context['token_check'])) { |
|
1001 | + echo ' |
|
944 | 1002 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
1003 | + } |
|
945 | 1004 | |
946 | 1005 | echo ' |
947 | 1006 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -987,9 +1046,10 @@ discard block |
||
987 | 1046 | <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>'; |
988 | 1047 | |
989 | 1048 | // Second address detected? |
990 | - if (!empty($context['last_ip2'])) |
|
991 | - echo ' |
|
1049 | + if (!empty($context['last_ip2'])) { |
|
1050 | + echo ' |
|
992 | 1051 | , <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>'; |
1052 | + } |
|
993 | 1053 | |
994 | 1054 | echo ' |
995 | 1055 | </dd>'; |
@@ -1055,9 +1115,10 @@ discard block |
||
1055 | 1115 | </div> |
1056 | 1116 | <div class="windowbg">'; |
1057 | 1117 | |
1058 | - foreach ($context['whois_servers'] as $server) |
|
1059 | - echo ' |
|
1118 | + foreach ($context['whois_servers'] as $server) { |
|
1119 | + echo ' |
|
1060 | 1120 | <a href="', $server['url'], '" target="_blank" rel="noopener"', '>', $server['name'], '</a><br>'; |
1121 | + } |
|
1061 | 1122 | echo ' |
1062 | 1123 | </div> |
1063 | 1124 | <br>'; |
@@ -1069,13 +1130,12 @@ discard block |
||
1069 | 1130 | <h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3> |
1070 | 1131 | </div>'; |
1071 | 1132 | |
1072 | - if (empty($context['ips'])) |
|
1073 | - echo ' |
|
1133 | + if (empty($context['ips'])) { |
|
1134 | + echo ' |
|
1074 | 1135 | <p class="windowbg description"> |
1075 | 1136 | <em>', $txt['no_members_from_ip'], '</em> |
1076 | 1137 | </p>'; |
1077 | - |
|
1078 | - else |
|
1138 | + } else |
|
1079 | 1139 | { |
1080 | 1140 | echo ' |
1081 | 1141 | <table class="table_grid"> |
@@ -1088,12 +1148,13 @@ discard block |
||
1088 | 1148 | <tbody>'; |
1089 | 1149 | |
1090 | 1150 | // Loop through each of the members and display them. |
1091 | - foreach ($context['ips'] as $ip => $memberlist) |
|
1092 | - echo ' |
|
1151 | + foreach ($context['ips'] as $ip => $memberlist) { |
|
1152 | + echo ' |
|
1093 | 1153 | <tr class="windowbg"> |
1094 | 1154 | <td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td> |
1095 | 1155 | <td>', implode(', ', $memberlist), '</td> |
1096 | 1156 | </tr>'; |
1157 | + } |
|
1097 | 1158 | |
1098 | 1159 | echo ' |
1099 | 1160 | </tbody> |
@@ -1135,11 +1196,10 @@ discard block |
||
1135 | 1196 | </h3> |
1136 | 1197 | </div>'; |
1137 | 1198 | |
1138 | - if ($context['member']['has_all_permissions']) |
|
1139 | - echo ' |
|
1199 | + if ($context['member']['has_all_permissions']) { |
|
1200 | + echo ' |
|
1140 | 1201 | <div class="information">', $txt['showPermissions_all'], '</div>'; |
1141 | - |
|
1142 | - else |
|
1202 | + } else |
|
1143 | 1203 | { |
1144 | 1204 | echo ' |
1145 | 1205 | <div class="information">',$txt['showPermissions_help'], '</div> |
@@ -1154,9 +1214,10 @@ discard block |
||
1154 | 1214 | <div class="windowbg smalltext"> |
1155 | 1215 | ', $txt['showPermissions_restricted_boards_desc'], ':<br>'; |
1156 | 1216 | |
1157 | - foreach ($context['no_access_boards'] as $no_access_board) |
|
1158 | - echo ' |
|
1217 | + foreach ($context['no_access_boards'] as $no_access_board) { |
|
1218 | + echo ' |
|
1159 | 1219 | <a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', '; |
1220 | + } |
|
1160 | 1221 | echo ' |
1161 | 1222 | </div>'; |
1162 | 1223 | } |
@@ -1188,12 +1249,13 @@ discard block |
||
1188 | 1249 | </td> |
1189 | 1250 | <td class="smalltext">'; |
1190 | 1251 | |
1191 | - if ($permission['is_denied']) |
|
1192 | - echo ' |
|
1252 | + if ($permission['is_denied']) { |
|
1253 | + echo ' |
|
1193 | 1254 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1194 | - else |
|
1195 | - echo ' |
|
1255 | + } else { |
|
1256 | + echo ' |
|
1196 | 1257 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
1258 | + } |
|
1197 | 1259 | |
1198 | 1260 | echo ' |
1199 | 1261 | </td> |
@@ -1204,10 +1266,10 @@ discard block |
||
1204 | 1266 | </table> |
1205 | 1267 | </div><!-- .tborder --> |
1206 | 1268 | <br>'; |
1207 | - } |
|
1208 | - else |
|
1209 | - echo ' |
|
1269 | + } else { |
|
1270 | + echo ' |
|
1210 | 1271 | <p class="windowbg">', $txt['showPermissions_none_general'], '</p>'; |
1272 | + } |
|
1211 | 1273 | |
1212 | 1274 | // Board permission section. |
1213 | 1275 | echo ' |
@@ -1218,14 +1280,16 @@ discard block |
||
1218 | 1280 | <select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();"> |
1219 | 1281 | <option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], '</option>'; |
1220 | 1282 | |
1221 | - if (!empty($context['boards'])) |
|
1222 | - echo ' |
|
1283 | + if (!empty($context['boards'])) { |
|
1284 | + echo ' |
|
1223 | 1285 | <option value="" disabled>---------------------------</option>'; |
1286 | + } |
|
1224 | 1287 | |
1225 | 1288 | // Fill the box with any local permission boards. |
1226 | - foreach ($context['boards'] as $board) |
|
1227 | - echo ' |
|
1289 | + foreach ($context['boards'] as $board) { |
|
1290 | + echo ' |
|
1228 | 1291 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>'; |
1292 | + } |
|
1229 | 1293 | |
1230 | 1294 | echo ' |
1231 | 1295 | </select> |
@@ -1254,13 +1318,13 @@ discard block |
||
1254 | 1318 | </td> |
1255 | 1319 | <td class="smalltext">'; |
1256 | 1320 | |
1257 | - if ($permission['is_denied']) |
|
1258 | - echo ' |
|
1321 | + if ($permission['is_denied']) { |
|
1322 | + echo ' |
|
1259 | 1323 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1260 | - |
|
1261 | - else |
|
1262 | - echo ' |
|
1324 | + } else { |
|
1325 | + echo ' |
|
1263 | 1326 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
1327 | + } |
|
1264 | 1328 | |
1265 | 1329 | echo ' |
1266 | 1330 | </td> |
@@ -1269,10 +1333,10 @@ discard block |
||
1269 | 1333 | echo ' |
1270 | 1334 | </tbody> |
1271 | 1335 | </table>'; |
1272 | - } |
|
1273 | - else |
|
1274 | - echo ' |
|
1336 | + } else { |
|
1337 | + echo ' |
|
1275 | 1338 | <p class="windowbg">', $txt['showPermissions_none_board'], '</p>'; |
1339 | + } |
|
1276 | 1340 | echo ' |
1277 | 1341 | </div><!-- #permissions -->'; |
1278 | 1342 | } |
@@ -1313,9 +1377,10 @@ discard block |
||
1313 | 1377 | </div>'; |
1314 | 1378 | |
1315 | 1379 | // If they haven't post at all, don't draw the graph. |
1316 | - if (empty($context['posts_by_time'])) |
|
1317 | - echo ' |
|
1380 | + if (empty($context['posts_by_time'])) { |
|
1381 | + echo ' |
|
1318 | 1382 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1383 | + } |
|
1319 | 1384 | |
1320 | 1385 | // Otherwise do! |
1321 | 1386 | else |
@@ -1324,8 +1389,8 @@ discard block |
||
1324 | 1389 | <ul class="activity_stats flow_hidden">'; |
1325 | 1390 | |
1326 | 1391 | // The labels. |
1327 | - foreach ($context['posts_by_time'] as $time_of_day) |
|
1328 | - echo ' |
|
1392 | + foreach ($context['posts_by_time'] as $time_of_day) { |
|
1393 | + echo ' |
|
1329 | 1394 | <li> |
1330 | 1395 | <div class="generic_bar vertical"> |
1331 | 1396 | <div class="bar" style="height: ', (int) $time_of_day['relative_percent'], '%;"> |
@@ -1334,6 +1399,7 @@ discard block |
||
1334 | 1399 | </div> |
1335 | 1400 | <span class="stats_hour">', $time_of_day['hour_format'], '</span> |
1336 | 1401 | </li>'; |
1402 | + } |
|
1337 | 1403 | |
1338 | 1404 | echo ' |
1339 | 1405 | </ul>'; |
@@ -1352,11 +1418,10 @@ discard block |
||
1352 | 1418 | </h3> |
1353 | 1419 | </div>'; |
1354 | 1420 | |
1355 | - if (empty($context['popular_boards'])) |
|
1356 | - echo ' |
|
1421 | + if (empty($context['popular_boards'])) { |
|
1422 | + echo ' |
|
1357 | 1423 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1358 | - |
|
1359 | - else |
|
1424 | + } else |
|
1360 | 1425 | { |
1361 | 1426 | echo ' |
1362 | 1427 | <dl class="stats">'; |
@@ -1386,10 +1451,10 @@ discard block |
||
1386 | 1451 | </h3> |
1387 | 1452 | </div>'; |
1388 | 1453 | |
1389 | - if (empty($context['board_activity'])) |
|
1390 | - echo ' |
|
1454 | + if (empty($context['board_activity'])) { |
|
1455 | + echo ' |
|
1391 | 1456 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1392 | - else |
|
1457 | + } else |
|
1393 | 1458 | { |
1394 | 1459 | echo ' |
1395 | 1460 | <dl class="stats">'; |
@@ -1440,90 +1505,97 @@ discard block |
||
1440 | 1505 | <h3 class="catbg profile_hd">'; |
1441 | 1506 | |
1442 | 1507 | // Don't say "Profile" if this isn't the profile... |
1443 | - if (!empty($context['profile_header_text'])) |
|
1444 | - echo ' |
|
1508 | + if (!empty($context['profile_header_text'])) { |
|
1509 | + echo ' |
|
1445 | 1510 | ', $context['profile_header_text']; |
1446 | - else |
|
1447 | - echo ' |
|
1511 | + } else { |
|
1512 | + echo ' |
|
1448 | 1513 | ', $txt['profile']; |
1514 | + } |
|
1449 | 1515 | |
1450 | 1516 | echo ' |
1451 | 1517 | </h3> |
1452 | 1518 | </div>'; |
1453 | 1519 | |
1454 | 1520 | // Have we some description? |
1455 | - if ($context['page_desc']) |
|
1456 | - echo ' |
|
1521 | + if ($context['page_desc']) { |
|
1522 | + echo ' |
|
1457 | 1523 | <p class="information">', $context['page_desc'], '</p>'; |
1524 | + } |
|
1458 | 1525 | |
1459 | 1526 | echo ' |
1460 | 1527 | <div class="roundframe">'; |
1461 | 1528 | |
1462 | 1529 | // Any bits at the start? |
1463 | - if (!empty($context['profile_prehtml'])) |
|
1464 | - echo ' |
|
1530 | + if (!empty($context['profile_prehtml'])) { |
|
1531 | + echo ' |
|
1465 | 1532 | <div>', $context['profile_prehtml'], '</div>'; |
1533 | + } |
|
1466 | 1534 | |
1467 | - if (!empty($context['profile_fields'])) |
|
1468 | - echo ' |
|
1535 | + if (!empty($context['profile_fields'])) { |
|
1536 | + echo ' |
|
1469 | 1537 | <dl class="settings">'; |
1538 | + } |
|
1470 | 1539 | |
1471 | 1540 | // Start the big old loop 'of love. |
1472 | 1541 | $lastItem = 'hr'; |
1473 | 1542 | foreach ($context['profile_fields'] as $key => $field) |
1474 | 1543 | { |
1475 | 1544 | // We add a little hack to be sure we never get more than one hr in a row! |
1476 | - if ($lastItem == 'hr' && $field['type'] == 'hr') |
|
1477 | - continue; |
|
1545 | + if ($lastItem == 'hr' && $field['type'] == 'hr') { |
|
1546 | + continue; |
|
1547 | + } |
|
1478 | 1548 | |
1479 | 1549 | $lastItem = $field['type']; |
1480 | - if ($field['type'] == 'hr') |
|
1481 | - echo ' |
|
1550 | + if ($field['type'] == 'hr') { |
|
1551 | + echo ' |
|
1482 | 1552 | </dl> |
1483 | 1553 | <hr> |
1484 | 1554 | <dl class="settings">'; |
1485 | - |
|
1486 | - elseif ($field['type'] == 'callback') |
|
1555 | + } elseif ($field['type'] == 'callback') |
|
1487 | 1556 | { |
1488 | 1557 | if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func'])) |
1489 | 1558 | { |
1490 | 1559 | $callback_func = 'template_profile_' . $field['callback_func']; |
1491 | 1560 | $callback_func(); |
1492 | 1561 | } |
1493 | - } |
|
1494 | - else |
|
1562 | + } else |
|
1495 | 1563 | { |
1496 | 1564 | echo ' |
1497 | 1565 | <dt> |
1498 | 1566 | <strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>'; |
1499 | 1567 | |
1500 | 1568 | // Does it have any subtext to show? |
1501 | - if (!empty($field['subtext'])) |
|
1502 | - echo ' |
|
1569 | + if (!empty($field['subtext'])) { |
|
1570 | + echo ' |
|
1503 | 1571 | <br> |
1504 | 1572 | <span class="smalltext">', $field['subtext'], '</span>'; |
1573 | + } |
|
1505 | 1574 | |
1506 | 1575 | echo ' |
1507 | 1576 | </dt> |
1508 | 1577 | <dd>'; |
1509 | 1578 | |
1510 | 1579 | // Want to put something infront of the box? |
1511 | - if (!empty($field['preinput'])) |
|
1512 | - echo ' |
|
1580 | + if (!empty($field['preinput'])) { |
|
1581 | + echo ' |
|
1513 | 1582 | ', $field['preinput']; |
1583 | + } |
|
1514 | 1584 | |
1515 | 1585 | // What type of data are we showing? |
1516 | - if ($field['type'] == 'label') |
|
1517 | - echo ' |
|
1586 | + if ($field['type'] == 'label') { |
|
1587 | + echo ' |
|
1518 | 1588 | ', $field['value']; |
1589 | + } |
|
1519 | 1590 | |
1520 | 1591 | // Maybe it's a text box - very likely! |
1521 | 1592 | elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url'))) |
1522 | 1593 | { |
1523 | - if ($field['type'] == 'int' || $field['type'] == 'float') |
|
1524 | - $type = 'number'; |
|
1525 | - else |
|
1526 | - $type = $field['type']; |
|
1594 | + if ($field['type'] == 'int' || $field['type'] == 'float') { |
|
1595 | + $type = 'number'; |
|
1596 | + } else { |
|
1597 | + $type = $field['type']; |
|
1598 | + } |
|
1527 | 1599 | $step = $field['type'] == 'float' ? ' step="0.1"' : ''; |
1528 | 1600 | |
1529 | 1601 | |
@@ -1531,10 +1603,11 @@ discard block |
||
1531 | 1603 | <input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' ', $step, '>'; |
1532 | 1604 | } |
1533 | 1605 | // You "checking" me out? ;) |
1534 | - elseif ($field['type'] == 'check') |
|
1535 | - echo ' |
|
1606 | + elseif ($field['type'] == 'check') { |
|
1607 | + echo ' |
|
1536 | 1608 | <input type="hidden" name="', $key, '" value="0"> |
1537 | 1609 | <input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" ', $field['input_attr'], '>'; |
1610 | + } |
|
1538 | 1611 | |
1539 | 1612 | // Always fun - select boxes! |
1540 | 1613 | elseif ($field['type'] == 'select') |
@@ -1545,14 +1618,16 @@ discard block |
||
1545 | 1618 | if (isset($field['options'])) |
1546 | 1619 | { |
1547 | 1620 | // Is this some code to generate the options? |
1548 | - if (!is_array($field['options'])) |
|
1549 | - $field['options'] = $field['options'](); |
|
1621 | + if (!is_array($field['options'])) { |
|
1622 | + $field['options'] = $field['options'](); |
|
1623 | + } |
|
1550 | 1624 | |
1551 | 1625 | // Assuming we now have some! |
1552 | - if (is_array($field['options'])) |
|
1553 | - foreach ($field['options'] as $value => $name) |
|
1626 | + if (is_array($field['options'])) { |
|
1627 | + foreach ($field['options'] as $value => $name) |
|
1554 | 1628 | echo ' |
1555 | 1629 | <option', is_numeric($value) ? ' value="" disabled' : ' value="' . $value . '"', $value === $field['value'] ? ' selected' : '', '>', $name, '</option>'; |
1630 | + } |
|
1556 | 1631 | } |
1557 | 1632 | |
1558 | 1633 | echo ' |
@@ -1560,31 +1635,34 @@ discard block |
||
1560 | 1635 | } |
1561 | 1636 | |
1562 | 1637 | // Something to end with? |
1563 | - if (!empty($field['postinput'])) |
|
1564 | - echo ' |
|
1638 | + if (!empty($field['postinput'])) { |
|
1639 | + echo ' |
|
1565 | 1640 | ', $field['postinput']; |
1641 | + } |
|
1566 | 1642 | |
1567 | 1643 | echo ' |
1568 | 1644 | </dd>'; |
1569 | 1645 | } |
1570 | 1646 | } |
1571 | 1647 | |
1572 | - if (!empty($context['profile_fields'])) |
|
1573 | - echo ' |
|
1648 | + if (!empty($context['profile_fields'])) { |
|
1649 | + echo ' |
|
1574 | 1650 | </dl>'; |
1651 | + } |
|
1575 | 1652 | |
1576 | 1653 | // Are there any custom profile fields - if so print them! |
1577 | 1654 | if (!empty($context['custom_fields'])) |
1578 | 1655 | { |
1579 | - if ($lastItem != 'hr') |
|
1580 | - echo ' |
|
1656 | + if ($lastItem != 'hr') { |
|
1657 | + echo ' |
|
1581 | 1658 | <hr>'; |
1659 | + } |
|
1582 | 1660 | |
1583 | 1661 | echo ' |
1584 | 1662 | <dl class="settings">'; |
1585 | 1663 | |
1586 | - foreach ($context['custom_fields'] as $field) |
|
1587 | - echo ' |
|
1664 | + foreach ($context['custom_fields'] as $field) { |
|
1665 | + echo ' |
|
1588 | 1666 | <dt> |
1589 | 1667 | <strong>', $field['name'], ': </strong><br> |
1590 | 1668 | <span class="smalltext">', $field['desc'], '</span> |
@@ -1592,19 +1670,21 @@ discard block |
||
1592 | 1670 | <dd> |
1593 | 1671 | ', $field['input_html'], ' |
1594 | 1672 | </dd>'; |
1673 | + } |
|
1595 | 1674 | |
1596 | 1675 | echo ' |
1597 | 1676 | </dl>'; |
1598 | 1677 | } |
1599 | 1678 | |
1600 | 1679 | // Any closing HTML? |
1601 | - if (!empty($context['profile_posthtml'])) |
|
1602 | - echo ' |
|
1680 | + if (!empty($context['profile_posthtml'])) { |
|
1681 | + echo ' |
|
1603 | 1682 | <div>', $context['profile_posthtml'], '</div>'; |
1683 | + } |
|
1604 | 1684 | |
1605 | 1685 | // Only show the password box if it's actually needed. |
1606 | - if ($context['require_password']) |
|
1607 | - echo ' |
|
1686 | + if ($context['require_password']) { |
|
1687 | + echo ' |
|
1608 | 1688 | <dl class="settings"> |
1609 | 1689 | <dt> |
1610 | 1690 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br> |
@@ -1614,18 +1694,21 @@ discard block |
||
1614 | 1694 | <input type="password" name="oldpasswrd" id="oldpasswrd" size="20"> |
1615 | 1695 | </dd> |
1616 | 1696 | </dl>'; |
1697 | + } |
|
1617 | 1698 | |
1618 | 1699 | // The button shouldn't say "Change profile" unless we're changing the profile... |
1619 | - if (!empty($context['submit_button_text'])) |
|
1620 | - echo ' |
|
1700 | + if (!empty($context['submit_button_text'])) { |
|
1701 | + echo ' |
|
1621 | 1702 | <input type="submit" name="save" value="', $context['submit_button_text'], '" class="button floatright">'; |
1622 | - else |
|
1623 | - echo ' |
|
1703 | + } else { |
|
1704 | + echo ' |
|
1624 | 1705 | <input type="submit" name="save" value="', $txt['change_profile'], '" class="button floatright">'; |
1706 | + } |
|
1625 | 1707 | |
1626 | - if (!empty($context['token_check'])) |
|
1627 | - echo ' |
|
1708 | + if (!empty($context['token_check'])) { |
|
1709 | + echo ' |
|
1628 | 1710 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
1711 | + } |
|
1629 | 1712 | |
1630 | 1713 | echo ' |
1631 | 1714 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -1635,10 +1718,11 @@ discard block |
||
1635 | 1718 | </form>'; |
1636 | 1719 | |
1637 | 1720 | // Any final spellchecking stuff? |
1638 | - if (!empty($context['show_spellchecking'])) |
|
1639 | - echo ' |
|
1721 | + if (!empty($context['show_spellchecking'])) { |
|
1722 | + echo ' |
|
1640 | 1723 | <form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>'; |
1641 | -} |
|
1724 | + } |
|
1725 | + } |
|
1642 | 1726 | |
1643 | 1727 | /** |
1644 | 1728 | * Personal Message settings. |
@@ -1675,10 +1759,11 @@ discard block |
||
1675 | 1759 | <select name="pm_receive_from" id="pm_receive_from"> |
1676 | 1760 | <option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>'; |
1677 | 1761 | |
1678 | - if (!empty($modSettings['enable_buddylist'])) |
|
1679 | - echo ' |
|
1762 | + if (!empty($modSettings['enable_buddylist'])) { |
|
1763 | + echo ' |
|
1680 | 1764 | <option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option> |
1681 | 1765 | <option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>'; |
1766 | + } |
|
1682 | 1767 | |
1683 | 1768 | echo ' |
1684 | 1769 | <option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option> |
@@ -1721,11 +1806,12 @@ discard block |
||
1721 | 1806 | if (empty($setting) || !is_array($setting)) |
1722 | 1807 | { |
1723 | 1808 | // Insert a separator (unless this is the first item in the list) |
1724 | - if ($i !== $first_option_key) |
|
1725 | - echo ' |
|
1809 | + if ($i !== $first_option_key) { |
|
1810 | + echo ' |
|
1726 | 1811 | </dl> |
1727 | 1812 | <hr> |
1728 | 1813 | <dl class="settings">'; |
1814 | + } |
|
1729 | 1815 | |
1730 | 1816 | // Should we give a name to this section? |
1731 | 1817 | if (is_string($setting) && !empty($setting)) |
@@ -1734,69 +1820,67 @@ discard block |
||
1734 | 1820 | echo ' |
1735 | 1821 | <dt><strong>' . $setting . '</strong></dt> |
1736 | 1822 | <dd></dd>'; |
1823 | + } else { |
|
1824 | + $titled_section = false; |
|
1737 | 1825 | } |
1738 | - else |
|
1739 | - $titled_section = false; |
|
1740 | 1826 | |
1741 | 1827 | continue; |
1742 | 1828 | } |
1743 | 1829 | |
1744 | 1830 | // Is this disabled? |
1745 | - if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) |
|
1746 | - continue; |
|
1747 | - |
|
1748 | - elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
1749 | - continue; |
|
1750 | - |
|
1751 | - elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) |
|
1752 | - continue; |
|
1753 | - |
|
1754 | - elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) |
|
1755 | - continue; |
|
1756 | - |
|
1757 | - elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) |
|
1758 | - continue; |
|
1759 | - |
|
1760 | - elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1761 | - continue; |
|
1762 | - |
|
1763 | - elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1764 | - continue; |
|
1831 | + if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) { |
|
1832 | + continue; |
|
1833 | + } elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) { |
|
1834 | + continue; |
|
1835 | + } elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) { |
|
1836 | + continue; |
|
1837 | + } elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) { |
|
1838 | + continue; |
|
1839 | + } elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) { |
|
1840 | + continue; |
|
1841 | + } elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1842 | + continue; |
|
1843 | + } elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1844 | + continue; |
|
1845 | + } |
|
1765 | 1846 | |
1766 | 1847 | // Some of these may not be set... Set to defaults here |
1767 | 1848 | $opts = array('topics_per_page', 'messages_per_page', 'display_quick_mod'); |
1768 | - if (in_array($setting['id'], $opts) && !isset($context['member']['options'][$setting['id']])) |
|
1769 | - $context['member']['options'][$setting['id']] = 0; |
|
1770 | - |
|
1771 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
1772 | - $setting['type'] = 'checkbox'; |
|
1773 | - |
|
1774 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
1775 | - $setting['type'] = 'number'; |
|
1849 | + if (in_array($setting['id'], $opts) && !isset($context['member']['options'][$setting['id']])) { |
|
1850 | + $context['member']['options'][$setting['id']] = 0; |
|
1851 | + } |
|
1776 | 1852 | |
1777 | - elseif ($setting['type'] == 'string') |
|
1778 | - $setting['type'] = 'text'; |
|
1853 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
1854 | + $setting['type'] = 'checkbox'; |
|
1855 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
1856 | + $setting['type'] = 'number'; |
|
1857 | + } elseif ($setting['type'] == 'string') { |
|
1858 | + $setting['type'] = 'text'; |
|
1859 | + } |
|
1779 | 1860 | |
1780 | - if (isset($setting['options'])) |
|
1781 | - $setting['type'] = 'list'; |
|
1861 | + if (isset($setting['options'])) { |
|
1862 | + $setting['type'] = 'list'; |
|
1863 | + } |
|
1782 | 1864 | |
1783 | 1865 | echo ' |
1784 | 1866 | <dt> |
1785 | 1867 | <label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>'; |
1786 | 1868 | |
1787 | - if (isset($setting['description'])) |
|
1788 | - echo ' |
|
1869 | + if (isset($setting['description'])) { |
|
1870 | + echo ' |
|
1789 | 1871 | <br> |
1790 | 1872 | <span class="smalltext">', $setting['description'], '</span>'; |
1873 | + } |
|
1791 | 1874 | echo ' |
1792 | 1875 | </dt> |
1793 | 1876 | <dd>'; |
1794 | 1877 | |
1795 | 1878 | // Display checkbox options |
1796 | - if ($setting['type'] == 'checkbox') |
|
1797 | - echo ' |
|
1879 | + if ($setting['type'] == 'checkbox') { |
|
1880 | + echo ' |
|
1798 | 1881 | <input type="hidden" name="default_options[' . $setting['id'] . ']" value="0"> |
1799 | 1882 | <input type="checkbox" name="default_options[', $setting['id'], ']" id="', $setting['id'], '"', !empty($context['member']['options'][$setting['id']]) ? ' checked' : '', ' value="1">'; |
1883 | + } |
|
1800 | 1884 | |
1801 | 1885 | // How about selection lists, we all love them |
1802 | 1886 | elseif ($setting['type'] == 'list') |
@@ -1804,9 +1888,10 @@ discard block |
||
1804 | 1888 | echo ' |
1805 | 1889 | <select name="default_options[', $setting['id'], ']" id="', $setting['id'], '"', '>'; |
1806 | 1890 | |
1807 | - foreach ($setting['options'] as $value => $label) |
|
1808 | - echo ' |
|
1891 | + foreach ($setting['options'] as $value => $label) { |
|
1892 | + echo ' |
|
1809 | 1893 | <option value="', $value, '"', $value == $context['member']['options'][$setting['id']] ? ' selected' : '', '>', $label, '</option>'; |
1894 | + } |
|
1810 | 1895 | |
1811 | 1896 | echo ' |
1812 | 1897 | </select>'; |
@@ -1822,14 +1907,13 @@ discard block |
||
1822 | 1907 | |
1823 | 1908 | echo ' |
1824 | 1909 | <input type="number"', $min . $max . $step; |
1825 | - } |
|
1826 | - elseif (isset($setting['type']) && $setting['type'] == 'url') |
|
1827 | - echo' |
|
1910 | + } elseif (isset($setting['type']) && $setting['type'] == 'url') { |
|
1911 | + echo' |
|
1828 | 1912 | <input type="url"'; |
1829 | - |
|
1830 | - else |
|
1831 | - echo ' |
|
1913 | + } else { |
|
1914 | + echo ' |
|
1832 | 1915 | <input type="text"'; |
1916 | + } |
|
1833 | 1917 | |
1834 | 1918 | echo ' name="default_options[', $setting['id'], ']" id="', $setting['id'], '" value="', isset($context['member']['options'][$setting['id']]) ? $context['member']['options'][$setting['id']] : $setting['value'], '"', $setting['type'] == 'number' ? ' size="5"' : '', '>'; |
1835 | 1919 | } |
@@ -1866,8 +1950,8 @@ discard block |
||
1866 | 1950 | <dl class="settings">'; |
1867 | 1951 | |
1868 | 1952 | // Allow notification on announcements to be disabled? |
1869 | - if (!empty($modSettings['allow_disableAnnounce'])) |
|
1870 | - echo ' |
|
1953 | + if (!empty($modSettings['allow_disableAnnounce'])) { |
|
1954 | + echo ' |
|
1871 | 1955 | <dt> |
1872 | 1956 | <label for="notify_announcements">', $txt['notify_important_email'], '</label> |
1873 | 1957 | </dt> |
@@ -1875,15 +1959,17 @@ discard block |
||
1875 | 1959 | <input type="hidden" name="notify_announcements" value="0"> |
1876 | 1960 | <input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', '> |
1877 | 1961 | </dd>'; |
1962 | + } |
|
1878 | 1963 | |
1879 | - if (!empty($modSettings['enable_ajax_alerts'])) |
|
1880 | - echo ' |
|
1964 | + if (!empty($modSettings['enable_ajax_alerts'])) { |
|
1965 | + echo ' |
|
1881 | 1966 | <dt> |
1882 | 1967 | <label for="notify_send_body">', $txt['notify_alert_timeout'], '</label> |
1883 | 1968 | </dt> |
1884 | 1969 | <dd> |
1885 | 1970 | <input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '"> |
1886 | 1971 | </dd>'; |
1972 | + } |
|
1887 | 1973 | |
1888 | 1974 | echo ' |
1889 | 1975 | </dl> |
@@ -1915,9 +2001,10 @@ discard block |
||
1915 | 2001 | |
1916 | 2002 | $label = $txt['alert_opt_' . $opts[1]]; |
1917 | 2003 | $label_pos = isset($opts['label']) ? $opts['label'] : ''; |
1918 | - if ($label_pos == 'before') |
|
1919 | - echo ' |
|
2004 | + if ($label_pos == 'before') { |
|
2005 | + echo ' |
|
1920 | 2006 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
2007 | + } |
|
1921 | 2008 | |
1922 | 2009 | $this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0; |
1923 | 2010 | switch ($opts[0]) |
@@ -1931,17 +2018,19 @@ discard block |
||
1931 | 2018 | echo ' |
1932 | 2019 | <select name="opt_', $opts[1], '" id="opt_', $opts[1], '">'; |
1933 | 2020 | |
1934 | - foreach ($opts['opts'] as $k => $v) |
|
1935 | - echo ' |
|
2021 | + foreach ($opts['opts'] as $k => $v) { |
|
2022 | + echo ' |
|
1936 | 2023 | <option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>'; |
2024 | + } |
|
1937 | 2025 | echo ' |
1938 | 2026 | </select>'; |
1939 | 2027 | break; |
1940 | 2028 | } |
1941 | 2029 | |
1942 | - if ($label_pos == 'after') |
|
1943 | - echo ' |
|
2030 | + if ($label_pos == 'after') { |
|
2031 | + echo ' |
|
1944 | 2032 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
2033 | + } |
|
1945 | 2034 | |
1946 | 2035 | echo ' |
1947 | 2036 | </td> |
@@ -2058,11 +2147,12 @@ discard block |
||
2058 | 2147 | <p class="information">', $txt['groupMembership_info'], '</p>'; |
2059 | 2148 | |
2060 | 2149 | // Do we have an update message? |
2061 | - if (!empty($context['update_message'])) |
|
2062 | - echo ' |
|
2150 | + if (!empty($context['update_message'])) { |
|
2151 | + echo ' |
|
2063 | 2152 | <div class="infobox"> |
2064 | 2153 | ', $context['update_message'], '. |
2065 | 2154 | </div>'; |
2155 | + } |
|
2066 | 2156 | |
2067 | 2157 | echo ' |
2068 | 2158 | <div id="groups">'; |
@@ -2084,8 +2174,7 @@ discard block |
||
2084 | 2174 | </div> |
2085 | 2175 | </div> |
2086 | 2176 | </div><!-- .groupmembership -->'; |
2087 | - } |
|
2088 | - else |
|
2177 | + } else |
|
2089 | 2178 | { |
2090 | 2179 | echo ' |
2091 | 2180 | <div class="title_bar"> |
@@ -2097,27 +2186,30 @@ discard block |
||
2097 | 2186 | echo ' |
2098 | 2187 | <div class="windowbg" id="primdiv_', $group['id'], '">'; |
2099 | 2188 | |
2100 | - if ($context['can_edit_primary']) |
|
2101 | - echo ' |
|
2189 | + if ($context['can_edit_primary']) { |
|
2190 | + echo ' |
|
2102 | 2191 | <input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', '>'; |
2192 | + } |
|
2103 | 2193 | |
2104 | 2194 | echo ' |
2105 | 2195 | <label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>'; |
2106 | 2196 | |
2107 | 2197 | // Can they leave their group? |
2108 | - if ($group['can_leave']) |
|
2109 | - echo ' |
|
2198 | + if ($group['can_leave']) { |
|
2199 | + echo ' |
|
2110 | 2200 | <a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>'; |
2201 | + } |
|
2111 | 2202 | |
2112 | 2203 | echo ' |
2113 | 2204 | </div><!-- .windowbg -->'; |
2114 | 2205 | } |
2115 | 2206 | |
2116 | - if ($context['can_edit_primary']) |
|
2117 | - echo ' |
|
2207 | + if ($context['can_edit_primary']) { |
|
2208 | + echo ' |
|
2118 | 2209 | <div class="padding righttext"> |
2119 | 2210 | <input type="submit" value="', $txt['make_primary'], '" class="button"> |
2120 | 2211 | </div>'; |
2212 | + } |
|
2121 | 2213 | |
2122 | 2214 | // Any groups they can join? |
2123 | 2215 | if (!empty($context['groups']['available'])) |
@@ -2133,17 +2225,16 @@ discard block |
||
2133 | 2225 | <div class="windowbg"> |
2134 | 2226 | <strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), ''; |
2135 | 2227 | |
2136 | - if ($group['type'] == 3) |
|
2137 | - echo ' |
|
2228 | + if ($group['type'] == 3) { |
|
2229 | + echo ' |
|
2138 | 2230 | <a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>'; |
2139 | - |
|
2140 | - elseif ($group['type'] == 2 && $group['pending']) |
|
2141 | - echo ' |
|
2231 | + } elseif ($group['type'] == 2 && $group['pending']) { |
|
2232 | + echo ' |
|
2142 | 2233 | <span class="floatright">', $txt['approval_pending'], '</span>'; |
2143 | - |
|
2144 | - elseif ($group['type'] == 2) |
|
2145 | - echo ' |
|
2234 | + } elseif ($group['type'] == 2) { |
|
2235 | + echo ' |
|
2146 | 2236 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>'; |
2237 | + } |
|
2147 | 2238 | |
2148 | 2239 | echo ' |
2149 | 2240 | </div><!-- .windowbg -->'; |
@@ -2166,9 +2257,10 @@ discard block |
||
2166 | 2257 | |
2167 | 2258 | prevDiv.className = "windowbg"; |
2168 | 2259 | }'; |
2169 | - if (isset($context['groups']['member'][$context['primary_group']])) |
|
2170 | - echo ' |
|
2260 | + if (isset($context['groups']['member'][$context['primary_group']])) { |
|
2261 | + echo ' |
|
2171 | 2262 | highlightSelected("primdiv_' . $context['primary_group'] . '");'; |
2263 | + } |
|
2172 | 2264 | |
2173 | 2265 | echo ' |
2174 | 2266 | </script>'; |
@@ -2177,9 +2269,10 @@ discard block |
||
2177 | 2269 | echo ' |
2178 | 2270 | </div><!-- #groups -->'; |
2179 | 2271 | |
2180 | - if (!empty($context['token_check'])) |
|
2181 | - echo ' |
|
2272 | + if (!empty($context['token_check'])) { |
|
2273 | + echo ' |
|
2182 | 2274 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2275 | + } |
|
2183 | 2276 | |
2184 | 2277 | echo ' |
2185 | 2278 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2227,14 +2320,15 @@ discard block |
||
2227 | 2320 | |
2228 | 2321 | foreach ($category['boards'] as $board) |
2229 | 2322 | { |
2230 | - if ($i == $limit) |
|
2231 | - echo ' |
|
2323 | + if ($i == $limit) { |
|
2324 | + echo ' |
|
2232 | 2325 | </ul> |
2233 | 2326 | </li> |
2234 | 2327 | </ul> |
2235 | 2328 | <ul class="ignoreboards floatright"> |
2236 | 2329 | <li class="category"> |
2237 | 2330 | <ul>'; |
2331 | + } |
|
2238 | 2332 | |
2239 | 2333 | echo ' |
2240 | 2334 | <li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;"> |
@@ -2279,10 +2373,11 @@ discard block |
||
2279 | 2373 | |
2280 | 2374 | // Work out the starting warning. |
2281 | 2375 | $context['current_warning_mode'] = $context['warning_mode'][0]; |
2282 | - foreach ($context['warning_mode'] as $limit => $warning) |
|
2283 | - if ($context['member']['warning'] >= $limit) |
|
2376 | + foreach ($context['warning_mode'] as $limit => $warning) { |
|
2377 | + if ($context['member']['warning'] >= $limit) |
|
2284 | 2378 | $context['current_warning_mode'] = $warning; |
2285 | -} |
|
2379 | + } |
|
2380 | + } |
|
2286 | 2381 | |
2287 | 2382 | // Show all warnings of a user? |
2288 | 2383 | function template_viewWarning() |
@@ -2317,14 +2412,15 @@ discard block |
||
2317 | 2412 | </dd>'; |
2318 | 2413 | |
2319 | 2414 | // There's some impact of this? |
2320 | - if (!empty($context['level_effects'][$context['current_level']])) |
|
2321 | - echo ' |
|
2415 | + if (!empty($context['level_effects'][$context['current_level']])) { |
|
2416 | + echo ' |
|
2322 | 2417 | <dt> |
2323 | 2418 | <strong>', $txt['profile_viewwarning_impact'], ':</strong> |
2324 | 2419 | </dt> |
2325 | 2420 | <dd> |
2326 | 2421 | ', $context['level_effects'][$context['current_level']], ' |
2327 | 2422 | </dd>'; |
2423 | + } |
|
2328 | 2424 | |
2329 | 2425 | echo ' |
2330 | 2426 | </dl> |
@@ -2362,10 +2458,11 @@ discard block |
||
2362 | 2458 | |
2363 | 2459 | // Otherwise see what we can do...'; |
2364 | 2460 | |
2365 | - foreach ($context['notification_templates'] as $k => $type) |
|
2366 | - echo ' |
|
2461 | + foreach ($context['notification_templates'] as $k => $type) { |
|
2462 | + echo ' |
|
2367 | 2463 | if (index == ', $k, ') |
2368 | 2464 | document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";'; |
2465 | + } |
|
2369 | 2466 | |
2370 | 2467 | echo ' |
2371 | 2468 | } |
@@ -2375,10 +2472,11 @@ discard block |
||
2375 | 2472 | // Also set the right effect. |
2376 | 2473 | effectText = "";'; |
2377 | 2474 | |
2378 | - foreach ($context['level_effects'] as $limit => $text) |
|
2379 | - echo ' |
|
2475 | + foreach ($context['level_effects'] as $limit => $text) { |
|
2476 | + echo ' |
|
2380 | 2477 | if (slideAmount >= ', $limit, ') |
2381 | 2478 | effectText = "', $text, '";'; |
2479 | + } |
|
2382 | 2480 | |
2383 | 2481 | echo ' |
2384 | 2482 | setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\'); |
@@ -2393,32 +2491,35 @@ discard block |
||
2393 | 2491 | </h3> |
2394 | 2492 | </div>'; |
2395 | 2493 | |
2396 | - if (!$context['user']['is_owner']) |
|
2397 | - echo ' |
|
2494 | + if (!$context['user']['is_owner']) { |
|
2495 | + echo ' |
|
2398 | 2496 | <p class="information">', $txt['profile_warning_desc'], '</p>'; |
2497 | + } |
|
2399 | 2498 | |
2400 | 2499 | echo ' |
2401 | 2500 | <div class="windowbg"> |
2402 | 2501 | <dl class="settings">'; |
2403 | 2502 | |
2404 | - if (!$context['user']['is_owner']) |
|
2405 | - echo ' |
|
2503 | + if (!$context['user']['is_owner']) { |
|
2504 | + echo ' |
|
2406 | 2505 | <dt> |
2407 | 2506 | <strong>', $txt['profile_warning_name'], ':</strong> |
2408 | 2507 | </dt> |
2409 | 2508 | <dd> |
2410 | 2509 | <strong>', $context['member']['name'], '</strong> |
2411 | 2510 | </dd>'; |
2511 | + } |
|
2412 | 2512 | |
2413 | 2513 | echo ' |
2414 | 2514 | <dt> |
2415 | 2515 | <strong>', $txt['profile_warning_level'], ':</strong>'; |
2416 | 2516 | |
2417 | 2517 | // Is there only so much they can apply? |
2418 | - if ($context['warning_limit']) |
|
2419 | - echo ' |
|
2518 | + if ($context['warning_limit']) { |
|
2519 | + echo ' |
|
2420 | 2520 | <br> |
2421 | 2521 | <span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>'; |
2522 | + } |
|
2422 | 2523 | |
2423 | 2524 | echo ' |
2424 | 2525 | </dt> |
@@ -2473,9 +2574,10 @@ discard block |
||
2473 | 2574 | <option value="-1">', $txt['profile_warning_notify_template'], '</option> |
2474 | 2575 | <option value="-1" disabled>------------------------------</option>'; |
2475 | 2576 | |
2476 | - foreach ($context['notification_templates'] as $id_template => $template) |
|
2477 | - echo ' |
|
2577 | + foreach ($context['notification_templates'] as $id_template => $template) { |
|
2578 | + echo ' |
|
2478 | 2579 | <option value="', $id_template, '">', $template['title'], '</option>'; |
2580 | + } |
|
2479 | 2581 | |
2480 | 2582 | echo ' |
2481 | 2583 | </select> |
@@ -2488,9 +2590,10 @@ discard block |
||
2488 | 2590 | </dl> |
2489 | 2591 | <div class="righttext">'; |
2490 | 2592 | |
2491 | - if (!empty($context['token_check'])) |
|
2492 | - echo ' |
|
2593 | + if (!empty($context['token_check'])) { |
|
2594 | + echo ' |
|
2493 | 2595 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2596 | + } |
|
2494 | 2597 | |
2495 | 2598 | echo ' |
2496 | 2599 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2506,8 +2609,8 @@ discard block |
||
2506 | 2609 | echo ' |
2507 | 2610 | <script>'; |
2508 | 2611 | |
2509 | - if (!$context['user']['is_owner']) |
|
2510 | - echo ' |
|
2612 | + if (!$context['user']['is_owner']) { |
|
2613 | + echo ' |
|
2511 | 2614 | modifyWarnNotify(); |
2512 | 2615 | $(document).ready(function() { |
2513 | 2616 | $("#preview_button").click(function() { |
@@ -2546,6 +2649,7 @@ discard block |
||
2546 | 2649 | }); |
2547 | 2650 | return false; |
2548 | 2651 | }'; |
2652 | + } |
|
2549 | 2653 | |
2550 | 2654 | echo ' |
2551 | 2655 | </script>'; |
@@ -2568,17 +2672,19 @@ discard block |
||
2568 | 2672 | </div>'; |
2569 | 2673 | |
2570 | 2674 | // If deleting another account give them a lovely info box. |
2571 | - if (!$context['user']['is_owner']) |
|
2572 | - echo ' |
|
2675 | + if (!$context['user']['is_owner']) { |
|
2676 | + echo ' |
|
2573 | 2677 | <p class="information">', $txt['deleteAccount_desc'], '</p>'; |
2678 | + } |
|
2574 | 2679 | |
2575 | 2680 | echo ' |
2576 | 2681 | <div class="windowbg">'; |
2577 | 2682 | |
2578 | 2683 | // If they are deleting their account AND the admin needs to approve it - give them another piece of info ;) |
2579 | - if ($context['needs_approval']) |
|
2580 | - echo ' |
|
2684 | + if ($context['needs_approval']) { |
|
2685 | + echo ' |
|
2581 | 2686 | <div class="errorbox">', $txt['deleteAccount_approval'], '</div>'; |
2687 | + } |
|
2582 | 2688 | |
2583 | 2689 | // If the user is deleting their own account warn them first - and require a password! |
2584 | 2690 | if ($context['user']['is_owner']) |
@@ -2590,9 +2696,10 @@ discard block |
||
2590 | 2696 | <input type="password" name="oldpasswrd" size="20"> |
2591 | 2697 | <input type="submit" value="', $txt['yes'], '" class="button">'; |
2592 | 2698 | |
2593 | - if (!empty($context['token_check'])) |
|
2594 | - echo ' |
|
2699 | + if (!empty($context['token_check'])) { |
|
2700 | + echo ' |
|
2595 | 2701 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2702 | + } |
|
2596 | 2703 | |
2597 | 2704 | echo ' |
2598 | 2705 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2622,10 +2729,11 @@ discard block |
||
2622 | 2729 | <option value="topics">', $txt['deleteAccount_topics'], '</option> |
2623 | 2730 | </select>'; |
2624 | 2731 | |
2625 | - if ($context['show_perma_delete']) |
|
2626 | - echo ' |
|
2732 | + if ($context['show_perma_delete']) { |
|
2733 | + echo ' |
|
2627 | 2734 | <br> |
2628 | 2735 | <label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1">', $txt['deleteAccount_permanent'], ':</label>'; |
2736 | + } |
|
2629 | 2737 | |
2630 | 2738 | echo ' |
2631 | 2739 | </div>'; |
@@ -2638,9 +2746,10 @@ discard block |
||
2638 | 2746 | <div> |
2639 | 2747 | <input type="submit" value="', $txt['delete'], '" class="button">'; |
2640 | 2748 | |
2641 | - if (!empty($context['token_check'])) |
|
2642 | - echo ' |
|
2749 | + if (!empty($context['token_check'])) { |
|
2750 | + echo ' |
|
2643 | 2751 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2752 | + } |
|
2644 | 2753 | |
2645 | 2754 | echo ' |
2646 | 2755 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2666,8 +2775,8 @@ discard block |
||
2666 | 2775 | <hr>'; |
2667 | 2776 | |
2668 | 2777 | // Only show the password box if it's actually needed. |
2669 | - if ($context['require_password']) |
|
2670 | - echo ' |
|
2778 | + if ($context['require_password']) { |
|
2779 | + echo ' |
|
2671 | 2780 | <dl class="settings"> |
2672 | 2781 | <dt> |
2673 | 2782 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br> |
@@ -2677,13 +2786,15 @@ discard block |
||
2677 | 2786 | <input type="password" name="oldpasswrd" size="20"> |
2678 | 2787 | </dd> |
2679 | 2788 | </dl>'; |
2789 | + } |
|
2680 | 2790 | |
2681 | 2791 | echo ' |
2682 | 2792 | <div class="righttext">'; |
2683 | 2793 | |
2684 | - if (!empty($context['token_check'])) |
|
2685 | - echo ' |
|
2794 | + if (!empty($context['token_check'])) { |
|
2795 | + echo ' |
|
2686 | 2796 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2797 | + } |
|
2687 | 2798 | |
2688 | 2799 | echo ' |
2689 | 2800 | <input type="submit" value="', $txt['change_profile'], '" class="button"> |
@@ -2710,9 +2821,10 @@ discard block |
||
2710 | 2821 | <ul id="list_errors">'; |
2711 | 2822 | |
2712 | 2823 | // Cycle through each error and display an error message. |
2713 | - foreach ($context['post_errors'] as $error) |
|
2714 | - echo ' |
|
2824 | + foreach ($context['post_errors'] as $error) { |
|
2825 | + echo ' |
|
2715 | 2826 | <li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>'; |
2827 | + } |
|
2716 | 2828 | |
2717 | 2829 | echo ' |
2718 | 2830 | </ul>'; |
@@ -2738,12 +2850,13 @@ discard block |
||
2738 | 2850 | <select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 && !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>'; |
2739 | 2851 | |
2740 | 2852 | // Fill the select box with all primary member groups that can be assigned to a member. |
2741 | - foreach ($context['member_groups'] as $member_group) |
|
2742 | - if (!empty($member_group['can_be_primary'])) |
|
2853 | + foreach ($context['member_groups'] as $member_group) { |
|
2854 | + if (!empty($member_group['can_be_primary'])) |
|
2743 | 2855 | echo ' |
2744 | 2856 | <option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '> |
2745 | 2857 | ', $member_group['name'], ' |
2746 | 2858 | </option>'; |
2859 | + } |
|
2747 | 2860 | |
2748 | 2861 | echo ' |
2749 | 2862 | </select> |
@@ -2756,10 +2869,11 @@ discard block |
||
2756 | 2869 | <input type="hidden" name="additional_groups[]" value="0">'; |
2757 | 2870 | |
2758 | 2871 | // For each membergroup show a checkbox so members can be assigned to more than one group. |
2759 | - foreach ($context['member_groups'] as $member_group) |
|
2760 | - if ($member_group['can_be_additional']) |
|
2872 | + foreach ($context['member_groups'] as $member_group) { |
|
2873 | + if ($member_group['can_be_additional']) |
|
2761 | 2874 | echo ' |
2762 | 2875 | <label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', '> ', $member_group['name'], '</label><br>'; |
2876 | + } |
|
2763 | 2877 | |
2764 | 2878 | echo ' |
2765 | 2879 | </span> |
@@ -2819,9 +2933,10 @@ discard block |
||
2819 | 2933 | <span class="smalltext">', $txt['sig_info'], '</span><br> |
2820 | 2934 | <br>'; |
2821 | 2935 | |
2822 | - if ($context['show_spellchecking']) |
|
2823 | - echo ' |
|
2936 | + if ($context['show_spellchecking']) { |
|
2937 | + echo ' |
|
2824 | 2938 | <input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button">'; |
2939 | + } |
|
2825 | 2940 | |
2826 | 2941 | echo ' |
2827 | 2942 | </dt> |
@@ -2829,17 +2944,20 @@ discard block |
||
2829 | 2944 | <textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50">', $context['member']['signature'], '</textarea><br>'; |
2830 | 2945 | |
2831 | 2946 | // If there is a limit at all! |
2832 | - if (!empty($context['signature_limits']['max_length'])) |
|
2833 | - echo ' |
|
2947 | + if (!empty($context['signature_limits']['max_length'])) { |
|
2948 | + echo ' |
|
2834 | 2949 | <span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>'; |
2950 | + } |
|
2835 | 2951 | |
2836 | - if (!empty($context['show_preview_button'])) |
|
2837 | - echo ' |
|
2952 | + if (!empty($context['show_preview_button'])) { |
|
2953 | + echo ' |
|
2838 | 2954 | <input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button floatright">'; |
2955 | + } |
|
2839 | 2956 | |
2840 | - if ($context['signature_warning']) |
|
2841 | - echo ' |
|
2957 | + if ($context['signature_warning']) { |
|
2958 | + echo ' |
|
2842 | 2959 | <span class="smalltext">', $context['signature_warning'], '</span>'; |
2960 | + } |
|
2843 | 2961 | |
2844 | 2962 | // Some javascript used to count how many characters have been used so far in the signature. |
2845 | 2963 | echo ' |
@@ -2870,38 +2988,43 @@ discard block |
||
2870 | 2988 | <label for="avatar_upload_box">', $txt['personal_picture'], '</label> |
2871 | 2989 | </strong>'; |
2872 | 2990 | |
2873 | - if (empty($modSettings['gravatarOverride'])) |
|
2874 | - echo ' |
|
2991 | + if (empty($modSettings['gravatarOverride'])) { |
|
2992 | + echo ' |
|
2875 | 2993 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_none" value="none"' . ($context['member']['avatar']['choice'] == 'none' ? ' checked="checked"' : '') . '> |
2876 | 2994 | <label for="avatar_choice_none"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2877 | 2995 | ' . $txt['no_avatar'] . ' |
2878 | 2996 | </label><br>'; |
2997 | + } |
|
2879 | 2998 | |
2880 | - if (!empty($context['member']['avatar']['allow_server_stored'])) |
|
2881 | - echo ' |
|
2999 | + if (!empty($context['member']['avatar']['allow_server_stored'])) { |
|
3000 | + echo ' |
|
2882 | 3001 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_server_stored" value="server_stored"' . ($context['member']['avatar']['choice'] == 'server_stored' ? ' checked="checked"' : '') . '> |
2883 | 3002 | <label for="avatar_choice_server_stored"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2884 | 3003 | ', $txt['choose_avatar_gallery'], ' |
2885 | 3004 | </label><br>'; |
3005 | + } |
|
2886 | 3006 | |
2887 | - if (!empty($context['member']['avatar']['allow_external'])) |
|
2888 | - echo ' |
|
3007 | + if (!empty($context['member']['avatar']['allow_external'])) { |
|
3008 | + echo ' |
|
2889 | 3009 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_external" value="external"' . ($context['member']['avatar']['choice'] == 'external' ? ' checked="checked"' : '') . '> |
2890 | 3010 | <label for="avatar_choice_external"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2891 | 3011 | ', $txt['my_own_pic'], ' |
2892 | 3012 | </label><br>'; |
3013 | + } |
|
2893 | 3014 | |
2894 | - if (!empty($context['member']['avatar']['allow_upload'])) |
|
2895 | - echo ' |
|
3015 | + if (!empty($context['member']['avatar']['allow_upload'])) { |
|
3016 | + echo ' |
|
2896 | 3017 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_upload" value="upload"' . ($context['member']['avatar']['choice'] == 'upload' ? ' checked="checked"' : '') . '> |
2897 | 3018 | <label for="avatar_choice_upload"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2898 | 3019 | ', $txt['avatar_will_upload'], ' |
2899 | 3020 | </label><br>'; |
3021 | + } |
|
2900 | 3022 | |
2901 | - if (!empty($context['member']['avatar']['allow_gravatar'])) |
|
2902 | - echo ' |
|
3023 | + if (!empty($context['member']['avatar']['allow_gravatar'])) { |
|
3024 | + echo ' |
|
2903 | 3025 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_gravatar" value="gravatar"' . ($context['member']['avatar']['choice'] == 'gravatar' ? ' checked="checked"' : '') . '> |
2904 | 3026 | <label for="avatar_choice_gravatar"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>' . $txt['use_gravatar'] . '</label>'; |
3027 | + } |
|
2905 | 3028 | |
2906 | 3029 | echo ' |
2907 | 3030 | </dt> |
@@ -2916,9 +3039,10 @@ discard block |
||
2916 | 3039 | <select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">'; |
2917 | 3040 | |
2918 | 3041 | // This lists all the file categories. |
2919 | - foreach ($context['avatars'] as $avatar) |
|
2920 | - echo ' |
|
3042 | + foreach ($context['avatars'] as $avatar) { |
|
3043 | + echo ' |
|
2921 | 3044 | <option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>'; |
3045 | + } |
|
2922 | 3046 | |
2923 | 3047 | echo ' |
2924 | 3048 | </select> |
@@ -2950,20 +3074,22 @@ discard block |
||
2950 | 3074 | } |
2951 | 3075 | |
2952 | 3076 | // If the user can link to an off server avatar, show them a box to input the address. |
2953 | - if (!empty($context['member']['avatar']['allow_external'])) |
|
2954 | - echo ' |
|
3077 | + if (!empty($context['member']['avatar']['allow_external'])) { |
|
3078 | + echo ' |
|
2955 | 3079 | <div id="avatar_external"> |
2956 | 3080 | <div class="smalltext">', $txt['avatar_by_url'], '</div>', !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_download_and_resize' ? template_max_size('external') : '', ' |
2957 | 3081 | <input type="text" name="userpicpersonal" size="45" value="', ((stristr($context['member']['avatar']['external'], 'http://') || stristr($context['member']['avatar']['external'], 'https://')) ? $context['member']['avatar']['external'] : 'http://'), '" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'external\');" onchange="if (typeof(previewExternalAvatar) != \'undefined\') previewExternalAvatar(this.value);"> |
2958 | 3082 | </div>'; |
3083 | + } |
|
2959 | 3084 | |
2960 | 3085 | // If the user is able to upload avatars to the server show them an upload box. |
2961 | - if (!empty($context['member']['avatar']['allow_upload'])) |
|
2962 | - echo ' |
|
3086 | + if (!empty($context['member']['avatar']['allow_upload'])) { |
|
3087 | + echo ' |
|
2963 | 3088 | <div id="avatar_upload"> |
2964 | 3089 | <input type="file" size="44" name="attachment" id="avatar_upload_box" value="" onchange="readfromUpload(this)" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'upload\');" accept="image/gif, image/jpeg, image/jpg, image/png">', template_max_size('upload'), ' |
2965 | 3090 | ', (!empty($context['member']['avatar']['id_attach']) ? '<br><img src="' . $context['member']['avatar']['href'] . (strpos($context['member']['avatar']['href'], '?') === false ? '?' : '&') . 'time=' . time() . '" alt="" id="attached_image"><input type="hidden" name="id_attach" value="' . $context['member']['avatar']['id_attach'] . '">' : ''), ' |
2966 | 3091 | </div>'; |
3092 | + } |
|
2967 | 3093 | |
2968 | 3094 | // if the user is able to use Gravatar avatars show then the image preview |
2969 | 3095 | if (!empty($context['member']['avatar']['allow_gravatar'])) |
@@ -2972,16 +3098,17 @@ discard block |
||
2972 | 3098 | <div id="avatar_gravatar"> |
2973 | 3099 | <img src="' . $context['member']['avatar']['href'] . '" alt="">'; |
2974 | 3100 | |
2975 | - if (empty($modSettings['gravatarAllowExtraEmail'])) |
|
2976 | - echo ' |
|
3101 | + if (empty($modSettings['gravatarAllowExtraEmail'])) { |
|
3102 | + echo ' |
|
2977 | 3103 | <div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>'; |
2978 | - else |
|
3104 | + } else |
|
2979 | 3105 | { |
2980 | 3106 | // Depending on other stuff, the stored value here might have some odd things in it from other areas. |
2981 | - if ($context['member']['avatar']['external'] == $context['member']['email']) |
|
2982 | - $textbox_value = ''; |
|
2983 | - else |
|
2984 | - $textbox_value = $context['member']['avatar']['external']; |
|
3107 | + if ($context['member']['avatar']['external'] == $context['member']['email']) { |
|
3108 | + $textbox_value = ''; |
|
3109 | + } else { |
|
3110 | + $textbox_value = $context['member']['avatar']['external']; |
|
3111 | + } |
|
2985 | 3112 | |
2986 | 3113 | echo ' |
2987 | 3114 | <div class="smalltext">', $txt['gravatar_alternateEmail'], '</div> |
@@ -3053,8 +3180,9 @@ discard block |
||
3053 | 3180 | $h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0; |
3054 | 3181 | |
3055 | 3182 | $suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : ''); |
3056 | - if (empty($suffix)) |
|
3057 | - return; |
|
3183 | + if (empty($suffix)) { |
|
3184 | + return; |
|
3185 | + } |
|
3058 | 3186 | |
3059 | 3187 | echo ' |
3060 | 3188 | <div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>'; |
@@ -3079,9 +3207,10 @@ discard block |
||
3079 | 3207 | <select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;">'; |
3080 | 3208 | |
3081 | 3209 | // Help the user by showing a list of common time formats. |
3082 | - foreach ($context['easy_timeformats'] as $time_format) |
|
3083 | - echo ' |
|
3210 | + foreach ($context['easy_timeformats'] as $time_format) { |
|
3211 | + echo ' |
|
3084 | 3212 | <option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>'; |
3213 | + } |
|
3085 | 3214 | |
3086 | 3215 | echo ' |
3087 | 3216 | </select> |
@@ -3119,9 +3248,10 @@ discard block |
||
3119 | 3248 | <dd> |
3120 | 3249 | <select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.png\';">'; |
3121 | 3250 | |
3122 | - foreach ($context['smiley_sets'] as $set) |
|
3123 | - echo ' |
|
3251 | + foreach ($context['smiley_sets'] as $set) { |
|
3252 | + echo ' |
|
3124 | 3253 | <option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>'; |
3254 | + } |
|
3125 | 3255 | |
3126 | 3256 | echo ' |
3127 | 3257 | </select> |
@@ -3143,17 +3273,17 @@ discard block |
||
3143 | 3273 | <div class="roundframe"> |
3144 | 3274 | <div>'; |
3145 | 3275 | |
3146 | - if (!empty($context['tfa_backup'])) |
|
3147 | - echo ' |
|
3276 | + if (!empty($context['tfa_backup'])) { |
|
3277 | + echo ' |
|
3148 | 3278 | <div class="smalltext error"> |
3149 | 3279 | ', $txt['tfa_backup_used_desc'], ' |
3150 | 3280 | </div>'; |
3151 | - |
|
3152 | - elseif ($modSettings['tfa_mode'] == 2) |
|
3153 | - echo ' |
|
3281 | + } elseif ($modSettings['tfa_mode'] == 2) { |
|
3282 | + echo ' |
|
3154 | 3283 | <div class="smalltext"> |
3155 | 3284 | <strong>', $txt['tfa_forced_desc'], '</strong> |
3156 | 3285 | </div>'; |
3286 | + } |
|
3157 | 3287 | |
3158 | 3288 | echo ' |
3159 | 3289 | <div class="smalltext"> |
@@ -3164,11 +3294,12 @@ discard block |
||
3164 | 3294 | <div class="block"> |
3165 | 3295 | <strong>', $txt['tfa_step1'], '</strong><br>'; |
3166 | 3296 | |
3167 | - if (!empty($context['tfa_pass_error'])) |
|
3168 | - echo ' |
|
3297 | + if (!empty($context['tfa_pass_error'])) { |
|
3298 | + echo ' |
|
3169 | 3299 | <div class="error smalltext"> |
3170 | 3300 | ', $txt['tfa_pass_invalid'], ' |
3171 | 3301 | </div>'; |
3302 | + } |
|
3172 | 3303 | |
3173 | 3304 | echo ' |
3174 | 3305 | <input type="password" name="passwd" size="25"', !empty($context['tfa_pass_error']) ? ' class="error"' : '', !empty($context['tfa_pass_value']) ? ' value="' . $context['tfa_pass_value'] . '"' : '', '> |
@@ -3181,11 +3312,12 @@ discard block |
||
3181 | 3312 | <div class="block"> |
3182 | 3313 | <strong>', $txt['tfa_step3'], '</strong><br>'; |
3183 | 3314 | |
3184 | - if (!empty($context['tfa_error'])) |
|
3185 | - echo ' |
|
3315 | + if (!empty($context['tfa_error'])) { |
|
3316 | + echo ' |
|
3186 | 3317 | <div class="error smalltext"> |
3187 | 3318 | ', $txt['tfa_code_invalid'], ' |
3188 | 3319 | </div>'; |
3320 | + } |
|
3189 | 3321 | |
3190 | 3322 | echo ' |
3191 | 3323 | <input type="text" name="tfa_code" size="25"', !empty($context['tfa_error']) ? ' class="error"' : '', !empty($context['tfa_value']) ? ' value="' . $context['tfa_value'] . '"' : '', '> |
@@ -3199,10 +3331,11 @@ discard block |
||
3199 | 3331 | <img src="', $context['tfa_qr_url'], '" alt=""> |
3200 | 3332 | </div>'; |
3201 | 3333 | |
3202 | - if (!empty($context['from_ajax'])) |
|
3203 | - echo ' |
|
3334 | + if (!empty($context['from_ajax'])) { |
|
3335 | + echo ' |
|
3204 | 3336 | <br> |
3205 | 3337 | <a href="javascript:self.close();"></a>'; |
3338 | + } |
|
3206 | 3339 | |
3207 | 3340 | echo ' |
3208 | 3341 | </div> |
@@ -3242,17 +3375,16 @@ discard block |
||
3242 | 3375 | </dt> |
3243 | 3376 | <dd>'; |
3244 | 3377 | |
3245 | - if (!$context['tfa_enabled'] && $context['user']['is_owner']) |
|
3246 | - echo ' |
|
3378 | + if (!$context['tfa_enabled'] && $context['user']['is_owner']) { |
|
3379 | + echo ' |
|
3247 | 3380 | <a href="', !empty($modSettings['force_ssl']) ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>'; |
3248 | - |
|
3249 | - elseif (!$context['tfa_enabled']) |
|
3250 | - echo ' |
|
3381 | + } elseif (!$context['tfa_enabled']) { |
|
3382 | + echo ' |
|
3251 | 3383 | ', $txt['tfa_profile_disabled']; |
3252 | - |
|
3253 | - else |
|
3254 | - echo ' |
|
3384 | + } else { |
|
3385 | + echo ' |
|
3255 | 3386 | ', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable'); |
3387 | + } |
|
3256 | 3388 | |
3257 | 3389 | echo ' |
3258 | 3390 | </dd>'; |
@@ -116,9 +116,10 @@ discard block |
||
116 | 116 | </div><!-- .windowbg --> |
117 | 117 | </div><!-- #manage_attachments -->'; |
118 | 118 | |
119 | - if (!empty($context['results'])) |
|
120 | - echo ' |
|
119 | + if (!empty($context['results'])) { |
|
120 | + echo ' |
|
121 | 121 | <div class="noticebox">', $context['results'], '</div>'; |
122 | + } |
|
122 | 123 | |
123 | 124 | echo ' |
124 | 125 | <div id="transfer" class="cat_bar"> |
@@ -133,9 +134,10 @@ discard block |
||
133 | 134 | <select name="from"> |
134 | 135 | <option value="0">', $txt['attachment_transfer_select'], '</option>'; |
135 | 136 | |
136 | - foreach ($context['attach_dirs'] as $id => $dir) |
|
137 | - echo ' |
|
137 | + foreach ($context['attach_dirs'] as $id => $dir) { |
|
138 | + echo ' |
|
138 | 139 | <option value="', $id, '">', $dir, '</option>'; |
140 | + } |
|
139 | 141 | |
140 | 142 | echo ' |
141 | 143 | </select> |
@@ -146,13 +148,14 @@ discard block |
||
146 | 148 | <option value="0">', $txt['attachment_transfer_auto_select'], '</option> |
147 | 149 | <option value="-1">', $txt['attachment_transfer_forum_root'], '</option>'; |
148 | 150 | |
149 | - if (!empty($context['base_dirs'])) |
|
150 | - foreach ($context['base_dirs'] as $id => $dir) |
|
151 | + if (!empty($context['base_dirs'])) { |
|
152 | + foreach ($context['base_dirs'] as $id => $dir) |
|
151 | 153 | echo ' |
152 | 154 | <option value="', $id, '">', $dir, '</option>'; |
153 | - else |
|
154 | - echo ' |
|
155 | + } else { |
|
156 | + echo ' |
|
155 | 157 | <option value="0" disabled>', $txt['attachment_transfer_no_base'], '</option>'; |
158 | + } |
|
156 | 159 | |
157 | 160 | echo ' |
158 | 161 | </select> |
@@ -162,18 +165,20 @@ discard block |
||
162 | 165 | <select name="to"> |
163 | 166 | <option value="0">', $txt['attachment_transfer_select'], '</option>'; |
164 | 167 | |
165 | - foreach ($context['attach_dirs'] as $id => $dir) |
|
166 | - echo ' |
|
168 | + foreach ($context['attach_dirs'] as $id => $dir) { |
|
169 | + echo ' |
|
167 | 170 | <option value="', $id, '">', $dir, '</option>'; |
171 | + } |
|
168 | 172 | |
169 | 173 | echo ' |
170 | 174 | </select> |
171 | 175 | </dd>'; |
172 | 176 | |
173 | - if (!empty($modSettings['attachmentDirFileLimit'])) |
|
174 | - echo ' |
|
177 | + if (!empty($modSettings['attachmentDirFileLimit'])) { |
|
178 | + echo ' |
|
175 | 179 | <dt>', $txt['attachment_transfer_empty'], '</dt> |
176 | 180 | <dd><input type="checkbox" name="empty_it"', $context['checked'] ? ' checked' : '', '></dd>'; |
181 | + } |
|
177 | 182 | |
178 | 183 | echo ' |
179 | 184 | </dl> |
@@ -209,8 +214,8 @@ discard block |
||
209 | 214 | global $context, $txt, $scripturl; |
210 | 215 | |
211 | 216 | // If we've completed just let them know! |
212 | - if ($context['completed']) |
|
213 | - echo ' |
|
217 | + if ($context['completed']) { |
|
218 | + echo ' |
|
214 | 219 | <div id="manage_attachments"> |
215 | 220 | <div class="cat_bar"> |
216 | 221 | <h3 class="catbg">', $txt['repair_attachments_complete'], '</h3> |
@@ -219,10 +224,11 @@ discard block |
||
219 | 224 | ', $txt['repair_attachments_complete_desc'], ' |
220 | 225 | </div> |
221 | 226 | </div>'; |
227 | + } |
|
222 | 228 | |
223 | 229 | // What about if no errors were even found? |
224 | - elseif (!$context['errors_found']) |
|
225 | - echo ' |
|
230 | + elseif (!$context['errors_found']) { |
|
231 | + echo ' |
|
226 | 232 | <div id="manage_attachments"> |
227 | 233 | <div class="cat_bar"> |
228 | 234 | <h3 class="catbg">', $txt['repair_attachments_complete'], '</h3> |
@@ -231,6 +237,7 @@ discard block |
||
231 | 237 | ', $txt['repair_attachments_no_errors'], ' |
232 | 238 | </div> |
233 | 239 | </div>'; |
240 | + } |
|
234 | 241 | |
235 | 242 | // Otherwise, I'm sad to say, we have a problem! |
236 | 243 | else |
@@ -245,11 +252,12 @@ discard block |
||
245 | 252 | <p>', $txt['repair_attachments_error_desc'], '</p>'; |
246 | 253 | |
247 | 254 | // Loop through each error reporting the status |
248 | - foreach ($context['repair_errors'] as $error => $number) |
|
249 | - if (!empty($number)) |
|
255 | + foreach ($context['repair_errors'] as $error => $number) { |
|
256 | + if (!empty($number)) |
|
250 | 257 | echo ' |
251 | 258 | <input type="checkbox" name="to_fix[]" id="', $error, '" value="', $error, '"> |
252 | 259 | <label for="', $error, '">', sprintf($txt['attach_repair_' . $error], $number), '</label><br>'; |
260 | + } |
|
253 | 261 | |
254 | 262 | echo ' |
255 | 263 | <br> |
@@ -268,8 +276,9 @@ discard block |
||
268 | 276 | { |
269 | 277 | global $modSettings; |
270 | 278 | |
271 | - if (!empty($modSettings['attachment_basedirectories'])) |
|
272 | - template_show_list('base_paths'); |
|
279 | + if (!empty($modSettings['attachment_basedirectories'])) { |
|
280 | + template_show_list('base_paths'); |
|
281 | + } |
|
273 | 282 | |
274 | 283 | template_show_list('attach_paths'); |
275 | 284 | } |
@@ -31,9 +31,10 @@ discard block |
||
31 | 31 | ', $txt['who_show1'], ' |
32 | 32 | <select name="show_top" onchange="document.forms.whoFilter.show.value = this.value; document.forms.whoFilter.submit();">'; |
33 | 33 | |
34 | - foreach ($context['show_methods'] as $value => $label) |
|
35 | - echo ' |
|
34 | + foreach ($context['show_methods'] as $value => $label) { |
|
35 | + echo ' |
|
36 | 36 | <option value="', $value, '" ', $value == $context['show_by'] ? ' selected' : '', '>', $label, '</option>'; |
37 | + } |
|
37 | 38 | echo ' |
38 | 39 | </select> |
39 | 40 | <noscript> |
@@ -58,20 +59,22 @@ discard block |
||
58 | 59 | <td>'; |
59 | 60 | |
60 | 61 | // Guests can't be messaged. |
61 | - if (!$member['is_guest']) |
|
62 | - echo ' |
|
62 | + if (!$member['is_guest']) { |
|
63 | + echo ' |
|
63 | 64 | <span class="contact_info floatright"> |
64 | 65 | ', $context['can_send_pm'] ? '<a href="' . $member['online']['href'] . '" title="' . $member['online']['text'] . '">' : '', $settings['use_image_buttons'] ? '<span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span>' : $member['online']['label'], $context['can_send_pm'] ? '</a>' : '', ' |
65 | 66 | </span>'; |
67 | + } |
|
66 | 68 | |
67 | 69 | echo ' |
68 | 70 | <span class="member', $member['is_hidden'] ? ' hidden' : '', '"> |
69 | 71 | ', $member['is_guest'] ? $member['name'] : '<a href="' . $member['href'] . '" title="' . $txt['profile_of'] . ' ' . $member['name'] . '"' . (empty($member['color']) ? '' : ' style="color: ' . $member['color'] . '"') . '>' . $member['name'] . '</a>', ' |
70 | 72 | </span>'; |
71 | 73 | |
72 | - if (!empty($member['ip'])) |
|
73 | - echo ' |
|
74 | + if (!empty($member['ip'])) { |
|
75 | + echo ' |
|
74 | 76 | (<a href="' . $scripturl . '?action=', ($member['is_guest'] ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $member['id']), ';searchip=' . $member['ip'] . '">' . $member['ip'] . '</a>)'; |
77 | + } |
|
75 | 78 | |
76 | 79 | echo ' |
77 | 80 | </td> |
@@ -81,13 +84,14 @@ discard block |
||
81 | 84 | } |
82 | 85 | |
83 | 86 | // No members? |
84 | - if (empty($context['members'])) |
|
85 | - echo ' |
|
87 | + if (empty($context['members'])) { |
|
88 | + echo ' |
|
86 | 89 | <tr class="windowbg"> |
87 | 90 | <td colspan="3"> |
88 | 91 | ', $txt['who_no_online_' . ($context['show_by'] == 'guests' || $context['show_by'] == 'spiders' ? $context['show_by'] : 'members')], ' |
89 | 92 | </td> |
90 | 93 | </tr>'; |
94 | + } |
|
91 | 95 | |
92 | 96 | echo ' |
93 | 97 | </tbody> |
@@ -98,9 +102,10 @@ discard block |
||
98 | 102 | ', $txt['who_show1'], ' |
99 | 103 | <select name="show" onchange="document.forms.whoFilter.submit();">'; |
100 | 104 | |
101 | - foreach ($context['show_methods'] as $value => $label) |
|
102 | - echo ' |
|
105 | + foreach ($context['show_methods'] as $value => $label) { |
|
106 | + echo ' |
|
103 | 107 | <option value="', $value, '" ', $value == $context['show_by'] ? ' selected' : '', '>', $label, '</option>'; |
108 | + } |
|
104 | 109 | echo ' |
105 | 110 | </select> |
106 | 111 | <noscript> |
@@ -129,17 +134,19 @@ discard block |
||
129 | 134 | |
130 | 135 | foreach ($context['credits'] as $section) |
131 | 136 | { |
132 | - if (isset($section['pretext'])) |
|
133 | - echo ' |
|
137 | + if (isset($section['pretext'])) { |
|
138 | + echo ' |
|
134 | 139 | <div class="windowbg"> |
135 | 140 | <p>', $section['pretext'], '</p> |
136 | 141 | </div>'; |
142 | + } |
|
137 | 143 | |
138 | - if (isset($section['title'])) |
|
139 | - echo ' |
|
144 | + if (isset($section['title'])) { |
|
145 | + echo ' |
|
140 | 146 | <div class="cat_bar"> |
141 | 147 | <h3 class="catbg">', $section['title'], '</h3> |
142 | 148 | </div>'; |
149 | + } |
|
143 | 150 | |
144 | 151 | echo ' |
145 | 152 | <div class="windowbg"> |
@@ -147,17 +154,18 @@ discard block |
||
147 | 154 | |
148 | 155 | foreach ($section['groups'] as $group) |
149 | 156 | { |
150 | - if (isset($group['title'])) |
|
151 | - echo ' |
|
157 | + if (isset($group['title'])) { |
|
158 | + echo ' |
|
152 | 159 | <dt> |
153 | 160 | <strong>', $group['title'], '</strong> |
154 | 161 | </dt> |
155 | 162 | <dd>'; |
163 | + } |
|
156 | 164 | |
157 | 165 | // Try to make this read nicely. |
158 | - if (count($group['members']) <= 2) |
|
159 | - echo implode(' ' . $txt['credits_and'] . ' ', $group['members']); |
|
160 | - else |
|
166 | + if (count($group['members']) <= 2) { |
|
167 | + echo implode(' ' . $txt['credits_and'] . ' ', $group['members']); |
|
168 | + } else |
|
161 | 169 | { |
162 | 170 | $last_peep = array_pop($group['members']); |
163 | 171 | echo implode(', ', $group['members']), ' ', $txt['credits_and'], ' ', $last_peep; |
@@ -170,9 +178,10 @@ discard block |
||
170 | 178 | echo ' |
171 | 179 | </dl>'; |
172 | 180 | |
173 | - if (isset($section['posttext'])) |
|
174 | - echo ' |
|
181 | + if (isset($section['posttext'])) { |
|
182 | + echo ' |
|
175 | 183 | <p class="posttext">', $section['posttext'], '</p>'; |
184 | + } |
|
176 | 185 | |
177 | 186 | echo ' |
178 | 187 | </div>'; |
@@ -187,26 +196,29 @@ discard block |
||
187 | 196 | </div> |
188 | 197 | <div class="windowbg">'; |
189 | 198 | |
190 | - if (!empty($context['credits_software_graphics']['graphics'])) |
|
191 | - echo ' |
|
199 | + if (!empty($context['credits_software_graphics']['graphics'])) { |
|
200 | + echo ' |
|
192 | 201 | <dl> |
193 | 202 | <dt><strong>', $txt['credits_graphics'], '</strong></dt> |
194 | 203 | <dd>', implode('</dd><dd>', $context['credits_software_graphics']['graphics']), '</dd> |
195 | 204 | </dl>'; |
205 | + } |
|
196 | 206 | |
197 | - if (!empty($context['credits_software_graphics']['software'])) |
|
198 | - echo ' |
|
207 | + if (!empty($context['credits_software_graphics']['software'])) { |
|
208 | + echo ' |
|
199 | 209 | <dl> |
200 | 210 | <dt><strong>', $txt['credits_software'], '</strong></dt> |
201 | 211 | <dd>', implode('</dd><dd>', $context['credits_software_graphics']['software']), '</dd> |
202 | 212 | </dl>'; |
213 | + } |
|
203 | 214 | |
204 | - if (!empty($context['credits_software_graphics']['fonts'])) |
|
205 | - echo ' |
|
215 | + if (!empty($context['credits_software_graphics']['fonts'])) { |
|
216 | + echo ' |
|
206 | 217 | <dl> |
207 | 218 | <dt><strong>', $txt['credits_fonts'], '</strong></dt> |
208 | 219 | <dd>', implode('</dd><dd>', $context['credits_software_graphics']['fonts']), '</dd> |
209 | 220 | </dl>'; |
221 | + } |
|
210 | 222 | echo ' |
211 | 223 | </div>'; |
212 | 224 | } |
@@ -222,14 +234,16 @@ discard block |
||
222 | 234 | <ul>'; |
223 | 235 | |
224 | 236 | // Display the credits. |
225 | - if (!empty($context['credits_modifications'])) |
|
226 | - echo ' |
|
237 | + if (!empty($context['credits_modifications'])) { |
|
238 | + echo ' |
|
227 | 239 | <li>', implode('</li><li>', $context['credits_modifications']), '</li>'; |
240 | + } |
|
228 | 241 | |
229 | 242 | // Legacy. |
230 | - if (!empty($context['copyrights']['mods'])) |
|
231 | - echo ' |
|
243 | + if (!empty($context['copyrights']['mods'])) { |
|
244 | + echo ' |
|
232 | 245 | <li>', implode('</li><li>', $context['copyrights']['mods']), '</li>'; |
246 | + } |
|
233 | 247 | |
234 | 248 | echo ' |
235 | 249 | </ul> |
@@ -54,18 +54,20 @@ discard block |
||
54 | 54 | <div class="windowbg" id="group_requests_panel"> |
55 | 55 | <ul>'; |
56 | 56 | |
57 | - foreach ($context['group_requests'] as $request) |
|
58 | - echo ' |
|
57 | + foreach ($context['group_requests'] as $request) { |
|
58 | + echo ' |
|
59 | 59 | <li class="smalltext"> |
60 | 60 | <a href="', $request['request_href'], '">', $request['group']['name'], '</a> ', $txt['mc_groupr_by'], ' ', $request['member']['link'], ' |
61 | 61 | </li>'; |
62 | + } |
|
62 | 63 | |
63 | 64 | // Don't have any watched users right now? |
64 | - if (empty($context['group_requests'])) |
|
65 | - echo ' |
|
65 | + if (empty($context['group_requests'])) { |
|
66 | + echo ' |
|
66 | 67 | <li> |
67 | 68 | <strong class="smalltext">', $txt['mc_group_requests_none'], '</strong> |
68 | 69 | </li>'; |
70 | + } |
|
69 | 71 | |
70 | 72 | echo ' |
71 | 73 | </ul> |
@@ -121,18 +123,20 @@ discard block |
||
121 | 123 | <div class="windowbg" id="watched_users_panel"> |
122 | 124 | <ul>'; |
123 | 125 | |
124 | - foreach ($context['watched_users'] as $user) |
|
125 | - echo ' |
|
126 | + foreach ($context['watched_users'] as $user) { |
|
127 | + echo ' |
|
126 | 128 | <li> |
127 | 129 | <span class="smalltext">', sprintf(!empty($user['last_login']) ? $txt['mc_seen'] : $txt['mc_seen_never'], $user['link'], $user['last_login']), '</span> |
128 | 130 | </li>'; |
131 | + } |
|
129 | 132 | |
130 | 133 | // Don't have any watched users right now? |
131 | - if (empty($context['watched_users'])) |
|
132 | - echo ' |
|
134 | + if (empty($context['watched_users'])) { |
|
135 | + echo ' |
|
133 | 136 | <li> |
134 | 137 | <strong class="smalltext">', $txt['mc_watched_users_none'], '</strong> |
135 | 138 | </li>'; |
139 | + } |
|
136 | 140 | |
137 | 141 | echo ' |
138 | 142 | </ul> |
@@ -188,18 +192,20 @@ discard block |
||
188 | 192 | <div class="windowbg" id="reported_posts_panel"> |
189 | 193 | <ul>'; |
190 | 194 | |
191 | - foreach ($context['reported_posts'] as $post) |
|
192 | - echo ' |
|
195 | + foreach ($context['reported_posts'] as $post) { |
|
196 | + echo ' |
|
193 | 197 | <li> |
194 | 198 | <span class="smalltext">', sprintf($txt['mc_post_report'], $post['report_link'], $post['author']['link']), '</span> |
195 | 199 | </li>'; |
200 | + } |
|
196 | 201 | |
197 | 202 | // Don't have any watched users right now? |
198 | - if (empty($context['reported_posts'])) |
|
199 | - echo ' |
|
203 | + if (empty($context['reported_posts'])) { |
|
204 | + echo ' |
|
200 | 205 | <li> |
201 | 206 | <strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong> |
202 | 207 | </li>'; |
208 | + } |
|
203 | 209 | |
204 | 210 | echo ' |
205 | 211 | </ul> |
@@ -255,18 +261,20 @@ discard block |
||
255 | 261 | <div class="windowbg" id="reported_users_panel"> |
256 | 262 | <ul>'; |
257 | 263 | |
258 | - foreach ($context['reported_users'] as $user) |
|
259 | - echo ' |
|
264 | + foreach ($context['reported_users'] as $user) { |
|
265 | + echo ' |
|
260 | 266 | <li> |
261 | 267 | <span class="smalltext">', $user['user']['link'], '</span> |
262 | 268 | </li>'; |
269 | + } |
|
263 | 270 | |
264 | 271 | // Don't have any watched users right now? |
265 | - if (empty($context['reported_users'])) |
|
266 | - echo ' |
|
272 | + if (empty($context['reported_users'])) { |
|
273 | + echo ' |
|
267 | 274 | <li> |
268 | 275 | <strong class="smalltext">', $txt['mc_reported_users_none'], '</strong> |
269 | 276 | </li>'; |
277 | + } |
|
270 | 278 | |
271 | 279 | echo ' |
272 | 280 | </ul> |
@@ -313,11 +321,12 @@ discard block |
||
313 | 321 | global $context, $txt, $scripturl; |
314 | 322 | |
315 | 323 | // Let them know the action was a success. |
316 | - if (!empty($context['report_post_action'])) |
|
317 | - echo ' |
|
324 | + if (!empty($context['report_post_action'])) { |
|
325 | + echo ' |
|
318 | 326 | <div class="infobox"> |
319 | 327 | ', $txt['report_action_' . $context['report_post_action']], ' |
320 | 328 | </div>'; |
329 | + } |
|
321 | 330 | |
322 | 331 | echo ' |
323 | 332 | <div id="modnotes"> |
@@ -333,11 +342,12 @@ discard block |
||
333 | 342 | <ul class="moderation_notes">'; |
334 | 343 | |
335 | 344 | // Cycle through the notes. |
336 | - foreach ($context['notes'] as $note) |
|
337 | - echo ' |
|
345 | + foreach ($context['notes'] as $note) { |
|
346 | + echo ' |
|
338 | 347 | <li class="smalltext"> |
339 | 348 | ', ($note['can_delete'] ? '<a href="' . $note['delete_href'] . ';' . $context['mod-modnote-del_token_var'] . '=' . $context['mod-modnote-del_token'] . '" data-confirm="' . $txt['mc_reportedp_delete_confirm'] . '" class="you_sure"><span class="generic_icons delete"></span></a>' : ''), $note['time'], ' <strong>', $note['author']['link'], ':</strong> ', $note['text'], ' |
340 | 349 | </li>'; |
350 | + } |
|
341 | 351 | |
342 | 352 | echo ' |
343 | 353 | </ul> |
@@ -378,18 +388,19 @@ discard block |
||
378 | 388 | $remove_button = create_button('delete', 'remove_message', 'remove'); |
379 | 389 | |
380 | 390 | // No posts? |
381 | - if (empty($context['unapproved_items'])) |
|
382 | - echo ' |
|
391 | + if (empty($context['unapproved_items'])) { |
|
392 | + echo ' |
|
383 | 393 | <div class="windowbg"> |
384 | 394 | <p class="centertext"> |
385 | 395 | ', $txt['mc_unapproved_' . $context['current_view'] . '_none_found'], ' |
386 | 396 | </p> |
387 | 397 | </div>'; |
388 | - else |
|
389 | - echo ' |
|
398 | + } else { |
|
399 | + echo ' |
|
390 | 400 | <div class="pagesection floatleft"> |
391 | 401 | ', $context['page_index'], ' |
392 | 402 | </div>'; |
403 | + } |
|
393 | 404 | |
394 | 405 | foreach ($context['unapproved_items'] as $item) |
395 | 406 | { |
@@ -408,14 +419,16 @@ discard block |
||
408 | 419 | <span class="floatright"> |
409 | 420 | <a href="', $scripturl, '?action=moderate;area=postmod;sa=', $context['current_view'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';approve=', $item['id'], '">', $approve_button, '</a>'; |
410 | 421 | |
411 | - if ($item['can_delete']) |
|
412 | - echo ' |
|
422 | + if ($item['can_delete']) { |
|
423 | + echo ' |
|
413 | 424 | ', $context['menu_separator'], ' |
414 | 425 | <a href="', $scripturl, '?action=moderate;area=postmod;sa=', $context['current_view'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';delete=', $item['id'], '">', $remove_button, '</a>'; |
426 | + } |
|
415 | 427 | |
416 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) |
|
417 | - echo ' |
|
428 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
429 | + echo ' |
|
418 | 430 | <input type="checkbox" name="item[]" value="', $item['id'], '" checked> '; |
431 | + } |
|
419 | 432 | |
420 | 433 | echo ' |
421 | 434 | </span> |
@@ -425,8 +438,8 @@ discard block |
||
425 | 438 | echo ' |
426 | 439 | <div class="pagesection">'; |
427 | 440 | |
428 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) |
|
429 | - echo ' |
|
441 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
442 | + echo ' |
|
430 | 443 | <div class="floatright"> |
431 | 444 | <select name="do" onchange="if (this.value != 0 && confirm(\'', $txt['mc_unapproved_sure'], '\')) submit();"> |
432 | 445 | <option value="0">', $txt['with_selected'], ':</option> |
@@ -438,12 +451,14 @@ discard block |
||
438 | 451 | <input type="submit" name="mc_go" value="', $txt['go'], '" class="button"> |
439 | 452 | </noscript> |
440 | 453 | </div>'; |
454 | + } |
|
441 | 455 | |
442 | - if (!empty($context['unapproved_items'])) |
|
443 | - echo ' |
|
456 | + if (!empty($context['unapproved_items'])) { |
|
457 | + echo ' |
|
444 | 458 | <div class="floatleft"> |
445 | 459 | <div class="pagelinks">', $context['page_index'], '</div> |
446 | 460 | </div>'; |
461 | + } |
|
447 | 462 | |
448 | 463 | echo ' |
449 | 464 | </div><!-- .pagesection --> |
@@ -464,8 +479,9 @@ discard block |
||
464 | 479 | |
465 | 480 | // We'll have a delete please bob. |
466 | 481 | // @todo Discuss this with the team and rewrite if required. |
467 | - if (empty($delete_button)) |
|
468 | - $delete_button = create_button('delete', 'remove_message', 'remove', 'class="centericon"'); |
|
482 | + if (empty($delete_button)) { |
|
483 | + $delete_button = create_button('delete', 'remove_message', 'remove', 'class="centericon"'); |
|
484 | + } |
|
469 | 485 | |
470 | 486 | $output_html = ' |
471 | 487 | <div> |
@@ -474,10 +490,11 @@ discard block |
||
474 | 490 | </div> |
475 | 491 | <div class="floatright">'; |
476 | 492 | |
477 | - if ($post['can_delete']) |
|
478 | - $output_html .= ' |
|
493 | + if ($post['can_delete']) { |
|
494 | + $output_html .= ' |
|
479 | 495 | <a href="' . $scripturl . '?action=moderate;area=userwatch;sa=post;delete=' . $post['id'] . ';start=' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" data-confirm="' . $txt['mc_watched_users_delete_post'] . '" class="you_sure">' . $delete_button . '</a> |
480 | 496 | <input type="checkbox" name="delete[]" value="' . $post['id'] . '">'; |
497 | + } |
|
481 | 498 | |
482 | 499 | $output_html .= ' |
483 | 500 | </div> |
@@ -521,12 +538,12 @@ discard block |
||
521 | 538 | <input type="submit" name="save" value="', $txt['save'], '" class="button"> |
522 | 539 | </div> |
523 | 540 | </form>'; |
524 | - } |
|
525 | - else |
|
526 | - echo ' |
|
541 | + } else { |
|
542 | + echo ' |
|
527 | 543 | <div class="windowbg"> |
528 | 544 | <div class="centertext">', $txt['mc_no_settings'], '</div> |
529 | 545 | </div>'; |
546 | + } |
|
530 | 547 | |
531 | 548 | echo ' |
532 | 549 | </div><!-- #modcenter -->'; |
@@ -622,13 +639,14 @@ discard block |
||
622 | 639 | </dd> |
623 | 640 | </dl>'; |
624 | 641 | |
625 | - if ($context['template_data']['can_edit_personal']) |
|
626 | - echo ' |
|
642 | + if ($context['template_data']['can_edit_personal']) { |
|
643 | + echo ' |
|
627 | 644 | <input type="checkbox" name="make_personal" id="make_personal"', $context['template_data']['personal'] ? ' checked' : '', '> |
628 | 645 | <label for="make_personal"> |
629 | 646 | <strong>', $txt['mc_warning_template_personal'], '</strong> |
630 | 647 | </label> |
631 | 648 | <p class="smalltext">', $txt['mc_warning_template_personal_desc'], '</p>'; |
649 | + } |
|
632 | 650 | |
633 | 651 | echo ' |
634 | 652 | <input type="submit" name="preview" id="preview_button" value="', $txt['preview'], '" class="button"> |
@@ -21,9 +21,10 @@ discard block |
||
21 | 21 | <div id="admincenter"> |
22 | 22 | <form action="', $scripturl, '?action=admin;area=paidsubscribe;sa=modify;sid=', $context['sub_id'], '" method="post">'; |
23 | 23 | |
24 | - if (!empty($context['disable_groups'])) |
|
25 | - echo ' |
|
24 | + if (!empty($context['disable_groups'])) { |
|
25 | + echo ' |
|
26 | 26 | <div class="noticebox">', $txt['paid_mod_edit_note'], '</div>'; |
27 | + } |
|
27 | 28 | |
28 | 29 | echo ' |
29 | 30 | <div class="cat_bar"> |
@@ -67,9 +68,10 @@ discard block |
||
67 | 68 | <option value="0"', $context['sub']['prim_group'] == 0 ? ' selected' : '', '>', $txt['paid_mod_no_group'], '</option>'; |
68 | 69 | |
69 | 70 | // Put each group into the box. |
70 | - foreach ($context['groups'] as $id => $name) |
|
71 | - echo ' |
|
71 | + foreach ($context['groups'] as $id => $name) { |
|
72 | + echo ' |
|
72 | 73 | <option value="', $id, '"', $context['sub']['prim_group'] == $id ? ' selected' : '', '>', $name, '</option>'; |
74 | + } |
|
73 | 75 | |
74 | 76 | echo ' |
75 | 77 | </select> |
@@ -81,12 +83,13 @@ discard block |
||
81 | 83 | <dd>'; |
82 | 84 | |
83 | 85 | // Put a checkbox in for each group |
84 | - foreach ($context['groups'] as $id => $name) |
|
85 | - echo ' |
|
86 | + foreach ($context['groups'] as $id => $name) { |
|
87 | + echo ' |
|
86 | 88 | <label for="addgroup_', $id, '"> |
87 | 89 | <input type="checkbox" id="addgroup_', $id, '" name="addgroup[', $id, ']"', in_array($id, $context['sub']['add_groups']) ? ' checked' : '', !empty($context['disable_groups']) ? ' disabled' : '', '> |
88 | 90 | <span class="smalltext">', $name, '</span> |
89 | 91 | </label><br>'; |
92 | + } |
|
90 | 93 | |
91 | 94 | echo ' |
92 | 95 | </dd> |
@@ -236,8 +239,8 @@ discard block |
||
236 | 239 | <dl class="settings">'; |
237 | 240 | |
238 | 241 | // Do we need a username? |
239 | - if ($context['action_type'] == 'add') |
|
240 | - echo ' |
|
242 | + if ($context['action_type'] == 'add') { |
|
243 | + echo ' |
|
241 | 244 | <dt> |
242 | 245 | <strong>', $txt['paid_username'], ':</strong><br> |
243 | 246 | <span class="smalltext">', $txt['one_username'], '</span> |
@@ -245,6 +248,7 @@ discard block |
||
245 | 248 | <dd> |
246 | 249 | <input type="text" name="name" id="name_control" value="', $context['sub']['username'], '" size="30"> |
247 | 250 | </dd>'; |
251 | + } |
|
248 | 252 | |
249 | 253 | echo ' |
250 | 254 | <dt> |
@@ -262,9 +266,10 @@ discard block |
||
262 | 266 | <select name="year" id="year" onchange="generateDays();">'; |
263 | 267 | |
264 | 268 | // Show a list of all the years we allow... |
265 | - for ($year = 2005; $year <= 2030; $year++) |
|
266 | - echo ' |
|
269 | + for ($year = 2005; $year <= 2030; $year++) { |
|
270 | + echo ' |
|
267 | 271 | <option value="', $year, '"', $year == $context['sub']['start']['year'] ? ' selected' : '', '>', $year, '</option>'; |
272 | + } |
|
268 | 273 | |
269 | 274 | echo ' |
270 | 275 | </select> |
@@ -272,9 +277,10 @@ discard block |
||
272 | 277 | <select name="month" id="month" onchange="generateDays();">'; |
273 | 278 | |
274 | 279 | // There are 12 months per year - ensure that they all get listed. |
275 | - for ($month = 1; $month <= 12; $month++) |
|
276 | - echo ' |
|
280 | + for ($month = 1; $month <= 12; $month++) { |
|
281 | + echo ' |
|
277 | 282 | <option value="', $month, '"', $month == $context['sub']['start']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>'; |
283 | + } |
|
278 | 284 | |
279 | 285 | echo ' |
280 | 286 | </select> |
@@ -282,9 +288,10 @@ discard block |
||
282 | 288 | <select name="day" id="day">'; |
283 | 289 | |
284 | 290 | // This prints out all the days in the current month - this changes dynamically as we switch months. |
285 | - for ($day = 1; $day <= $context['sub']['start']['last_day']; $day++) |
|
286 | - echo ' |
|
291 | + for ($day = 1; $day <= $context['sub']['start']['last_day']; $day++) { |
|
292 | + echo ' |
|
287 | 293 | <option value="', $day, '"', $day == $context['sub']['start']['day'] ? ' selected' : '', '>', $day, '</option>'; |
294 | + } |
|
288 | 295 | |
289 | 296 | echo ' |
290 | 297 | </select> |
@@ -296,9 +303,10 @@ discard block |
||
296 | 303 | <select name="yearend" id="yearend" onchange="generateDays(\'end\');">'; |
297 | 304 | |
298 | 305 | // Show a list of all the years we allow... |
299 | - for ($year = 2005; $year <= 2030; $year++) |
|
300 | - echo ' |
|
306 | + for ($year = 2005; $year <= 2030; $year++) { |
|
307 | + echo ' |
|
301 | 308 | <option value="', $year, '"', $year == $context['sub']['end']['year'] ? ' selected' : '', '>', $year, '</option>'; |
309 | + } |
|
302 | 310 | |
303 | 311 | echo ' |
304 | 312 | </select> |
@@ -306,9 +314,10 @@ discard block |
||
306 | 314 | <select name="monthend" id="monthend" onchange="generateDays(\'end\');">'; |
307 | 315 | |
308 | 316 | // There are 12 months per year - ensure that they all get listed. |
309 | - for ($month = 1; $month <= 12; $month++) |
|
310 | - echo ' |
|
317 | + for ($month = 1; $month <= 12; $month++) { |
|
318 | + echo ' |
|
311 | 319 | <option value="', $month, '"', $month == $context['sub']['end']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>'; |
320 | + } |
|
312 | 321 | |
313 | 322 | echo ' |
314 | 323 | </select> |
@@ -316,9 +325,10 @@ discard block |
||
316 | 325 | <select name="dayend" id="dayend">'; |
317 | 326 | |
318 | 327 | // This prints out all the days in the current month - this changes dynamically as we switch months. |
319 | - for ($day = 1; $day <= $context['sub']['end']['last_day']; $day++) |
|
320 | - echo ' |
|
328 | + for ($day = 1; $day <= $context['sub']['end']['last_day']; $day++) { |
|
329 | + echo ' |
|
321 | 330 | <option value="', $day, '"', $day == $context['sub']['end']['day'] ? ' selected' : '', '>', $day, '</option>'; |
331 | + } |
|
322 | 332 | |
323 | 333 | echo ' |
324 | 334 | </select> |
@@ -357,8 +367,8 @@ discard block |
||
357 | 367 | <div class="windowbg"> |
358 | 368 | <ul>'; |
359 | 369 | |
360 | - foreach ($context['pending_payments'] as $id => $payment) |
|
361 | - echo ' |
|
370 | + foreach ($context['pending_payments'] as $id => $payment) { |
|
371 | + echo ' |
|
362 | 372 | <li> |
363 | 373 | ', $payment['desc'], ' |
364 | 374 | <span class="floatleft"> |
@@ -368,6 +378,7 @@ discard block |
||
368 | 378 | <a href="', $scripturl, '?action=admin;area=paidsubscribe;sa=modifyuser;lid=', $context['log_id'], ';pending=', $id, ';remove">', $txt['pending_payments_remove'], '</a> |
369 | 379 | </span> |
370 | 380 | </li>'; |
381 | + } |
|
371 | 382 | |
372 | 383 | echo ' |
373 | 384 | </ul> |
@@ -392,12 +403,12 @@ discard block |
||
392 | 403 | <h3 class="catbg">', $txt['subscriptions'], '</h3> |
393 | 404 | </div>'; |
394 | 405 | |
395 | - if (empty($context['subscriptions'])) |
|
396 | - echo ' |
|
406 | + if (empty($context['subscriptions'])) { |
|
407 | + echo ' |
|
397 | 408 | <div class="information"> |
398 | 409 | ', $txt['paid_subs_none'], ' |
399 | 410 | </div>'; |
400 | - else |
|
411 | + } else |
|
401 | 412 | { |
402 | 413 | echo ' |
403 | 414 | <div class="information"> |
@@ -408,8 +419,9 @@ discard block |
||
408 | 419 | foreach ($context['subscriptions'] as $id => $subscription) |
409 | 420 | { |
410 | 421 | // Ignore the inactive ones... |
411 | - if (empty($subscription['active'])) |
|
412 | - continue; |
|
422 | + if (empty($subscription['active'])) { |
|
423 | + continue; |
|
424 | + } |
|
413 | 425 | |
414 | 426 | echo ' |
415 | 427 | <div class="cat_bar"> |
@@ -419,9 +431,10 @@ discard block |
||
419 | 431 | <p><strong>', $subscription['name'], '</strong></p> |
420 | 432 | <p class="smalltext">', $subscription['desc'], '</p>'; |
421 | 433 | |
422 | - if (!$subscription['flexible']) |
|
423 | - echo ' |
|
434 | + if (!$subscription['flexible']) { |
|
435 | + echo ' |
|
424 | 436 | <div><strong>', $txt['paid_duration'], ':</strong> ', $subscription['length'], '</div>'; |
437 | + } |
|
425 | 438 | |
426 | 439 | if ($context['user']['is_owner']) |
427 | 440 | { |
@@ -434,24 +447,25 @@ discard block |
||
434 | 447 | <select name="cur[', $subscription['id'], ']">'; |
435 | 448 | |
436 | 449 | // Print out the costs for this one. |
437 | - foreach ($subscription['costs'] as $duration => $value) |
|
438 | - echo ' |
|
450 | + foreach ($subscription['costs'] as $duration => $value) { |
|
451 | + echo ' |
|
439 | 452 | <option value="', $duration, '">', sprintf($modSettings['paid_currency_symbol'], $value), '/', $txt[$duration], '</option>'; |
453 | + } |
|
440 | 454 | |
441 | 455 | echo ' |
442 | 456 | </select>'; |
443 | - } |
|
444 | - else |
|
445 | - echo ' |
|
457 | + } else { |
|
458 | + echo ' |
|
446 | 459 | ', sprintf($modSettings['paid_currency_symbol'], $subscription['costs']['fixed']); |
460 | + } |
|
447 | 461 | |
448 | 462 | echo ' |
449 | 463 | <hr> |
450 | 464 | <input type="submit" name="sub_id[', $subscription['id'], ']" value="', $txt['paid_order'], '" class="button">'; |
451 | - } |
|
452 | - else |
|
453 | - echo ' |
|
465 | + } else { |
|
466 | + echo ' |
|
454 | 467 | <a href="', $scripturl, '?action=admin;area=paidsubscribe;sa=modifyuser;sid=', $subscription['id'], ';uid=', $context['member']['id'], (empty($context['current'][$subscription['id']]) ? '' : ';lid=' . $context['current'][$subscription['id']]['id']), '">', empty($context['current'][$subscription['id']]) ? $txt['paid_admin_add'] : $txt['paid_edit_subscription'], '</a>'; |
468 | + } |
|
455 | 469 | |
456 | 470 | echo ' |
457 | 471 | </div><!-- .windowbg -->'; |
@@ -478,18 +492,19 @@ discard block |
||
478 | 492 | </thead> |
479 | 493 | <tbody>'; |
480 | 494 | |
481 | - if (empty($context['current'])) |
|
482 | - echo ' |
|
495 | + if (empty($context['current'])) { |
|
496 | + echo ' |
|
483 | 497 | <tr class="windowbg"> |
484 | 498 | <td colspan="4"> |
485 | 499 | ', $txt['paid_none_yet'], ' |
486 | 500 | </td> |
487 | 501 | </tr>'; |
502 | + } |
|
488 | 503 | |
489 | 504 | foreach ($context['current'] as $sub) |
490 | 505 | { |
491 | - if (!$sub['hide']) |
|
492 | - echo ' |
|
506 | + if (!$sub['hide']) { |
|
507 | + echo ' |
|
493 | 508 | <tr class="windowbg"> |
494 | 509 | <td> |
495 | 510 | ', (allowedTo('admin_forum') ? '<a href="' . $scripturl . '?action=admin;area=paidsubscribe;sa=modifyuser;lid=' . $sub['id'] . '">' . $sub['name'] . '</a>' : $sub['name']), ' |
@@ -500,6 +515,7 @@ discard block |
||
500 | 515 | <td>', $sub['start'], '</td> |
501 | 516 | <td>', $sub['end'], '</td> |
502 | 517 | </tr>'; |
518 | + } |
|
503 | 519 | } |
504 | 520 | |
505 | 521 | echo ' |
@@ -551,15 +567,17 @@ discard block |
||
551 | 567 | ', $gateway['desc'], '<br> |
552 | 568 | <form action="', $gateway['form'], '" method="post">'; |
553 | 569 | |
554 | - if (!empty($gateway['javascript'])) |
|
555 | - echo ' |
|
570 | + if (!empty($gateway['javascript'])) { |
|
571 | + echo ' |
|
556 | 572 | <script> |
557 | 573 | ', $gateway['javascript'], ' |
558 | 574 | </script>'; |
575 | + } |
|
559 | 576 | |
560 | - foreach ($gateway['hidden'] as $name => $value) |
|
561 | - echo ' |
|
577 | + foreach ($gateway['hidden'] as $name => $value) { |
|
578 | + echo ' |
|
562 | 579 | <input type="hidden" id="', $gateway['id'], '_', $name, '" name="', $name, '" value="', $value, '">'; |
580 | + } |
|
563 | 581 | |
564 | 582 | echo ' |
565 | 583 | <br> |
@@ -20,17 +20,19 @@ discard block |
||
20 | 20 | echo ' |
21 | 21 | <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '" name="searchform" id="searchform">'; |
22 | 22 | |
23 | - if (!empty($context['search_errors'])) |
|
24 | - echo ' |
|
23 | + if (!empty($context['search_errors'])) { |
|
24 | + echo ' |
|
25 | 25 | <div class="errorbox"> |
26 | 26 | ', implode('<br>', $context['search_errors']['messages']), ' |
27 | 27 | </div>'; |
28 | + } |
|
28 | 29 | |
29 | - if (!empty($context['search_ignored'])) |
|
30 | - echo ' |
|
30 | + if (!empty($context['search_ignored'])) { |
|
31 | + echo ' |
|
31 | 32 | <div class="noticebox"> |
32 | 33 | ', $txt['search_warning_ignored_word' . (count($context['search_ignored']) == 1 ? '' : 's')], ': ', implode(', ', $context['search_ignored']), ' |
33 | 34 | </div>'; |
35 | + } |
|
34 | 36 | |
35 | 37 | echo ' |
36 | 38 | <div class="cat_bar"> |
@@ -48,9 +50,10 @@ discard block |
||
48 | 50 | <dd> |
49 | 51 | <input type="search" name="search" id="searchfor" ', !empty($context['search_params']['search']) ? ' value="' . $context['search_params']['search'] . '"' : '', ' maxlength="', $context['search_string_limit'], '" size="40">'; |
50 | 52 | |
51 | - if (empty($modSettings['search_simple_fulltext'])) |
|
52 | - echo ' |
|
53 | + if (empty($modSettings['search_simple_fulltext'])) { |
|
54 | + echo ' |
|
53 | 55 | <br><em class="smalltext">', $txt['search_example'], '</em>'; |
56 | + } |
|
54 | 57 | |
55 | 58 | echo ' |
56 | 59 | </dd> |
@@ -114,21 +117,23 @@ discard block |
||
114 | 117 | <input type="hidden" name="advanced" value="1">'; |
115 | 118 | |
116 | 119 | // Require an image to be typed to save spamming? |
117 | - if ($context['require_verification']) |
|
118 | - echo ' |
|
120 | + if ($context['require_verification']) { |
|
121 | + echo ' |
|
119 | 122 | <p> |
120 | 123 | <strong>', $txt['verification'], ':</strong> |
121 | 124 | ', template_control_verification($context['visual_verification_id'], 'all'), ' |
122 | 125 | </p>'; |
126 | + } |
|
123 | 127 | |
124 | 128 | // If $context['search_params']['topic'] is set, that means we're searching just one topic. |
125 | - if (!empty($context['search_params']['topic'])) |
|
126 | - echo ' |
|
129 | + if (!empty($context['search_params']['topic'])) { |
|
130 | + echo ' |
|
127 | 131 | <p> |
128 | 132 | ', $txt['search_specific_topic'], ' "', $context['search_topic']['link'], '". |
129 | 133 | </p> |
130 | 134 | <input type="hidden" name="topic" value="', $context['search_topic']['id'], '"> |
131 | 135 | <input type="submit" name="b_search" value="', $txt['search'], '" class="button">'; |
136 | + } |
|
132 | 137 | |
133 | 138 | echo ' |
134 | 139 | </div>'; |
@@ -158,14 +163,15 @@ discard block |
||
158 | 163 | |
159 | 164 | foreach ($category['boards'] as $board) |
160 | 165 | { |
161 | - if ($i == $limit) |
|
162 | - echo ' |
|
166 | + if ($i == $limit) { |
|
167 | + echo ' |
|
163 | 168 | </ul> |
164 | 169 | </li> |
165 | 170 | </ul> |
166 | 171 | <ul class="ignoreboards floatright"> |
167 | 172 | <li class="category"> |
168 | 173 | <ul>'; |
174 | + } |
|
169 | 175 | |
170 | 176 | echo ' |
171 | 177 | <li class="board"> |
@@ -253,17 +259,19 @@ discard block |
||
253 | 259 | <div class="roundframe">'; |
254 | 260 | |
255 | 261 | // Did they make any typos or mistakes, perhaps? |
256 | - if (isset($context['did_you_mean'])) |
|
257 | - echo ' |
|
262 | + if (isset($context['did_you_mean'])) { |
|
263 | + echo ' |
|
258 | 264 | <p> |
259 | 265 | ', $txt['search_did_you_mean'], ' <a href="', $scripturl, '?action=search2;params=', $context['did_you_mean_params'], '">', $context['did_you_mean'], '</a>. |
260 | 266 | </p>'; |
267 | + } |
|
261 | 268 | |
262 | - if (!empty($context['search_ignored'])) |
|
263 | - echo ' |
|
269 | + if (!empty($context['search_ignored'])) { |
|
270 | + echo ' |
|
264 | 271 | <p> |
265 | 272 | ', $txt['search_warning_ignored_word' . (count($context['search_ignored']) == 1 ? '' : 's')], ': ', implode(', ', $context['search_ignored']), ' |
266 | 273 | </p>'; |
274 | + } |
|
267 | 275 | |
268 | 276 | echo ' |
269 | 277 | <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '"> |
@@ -286,10 +294,11 @@ discard block |
||
286 | 294 | <input type="hidden" name="sort" value="', !empty($context['search_params']['sort']) ? $context['search_params']['sort'] : 'relevance', '"> |
287 | 295 | </div>'; |
288 | 296 | |
289 | - if (!empty($context['search_params']['brd'])) |
|
290 | - foreach ($context['search_params']['brd'] as $board_id) |
|
297 | + if (!empty($context['search_params']['brd'])) { |
|
298 | + foreach ($context['search_params']['brd'] as $board_id) |
|
291 | 299 | echo ' |
292 | 300 | <input type="hidden" name="brd[', $board_id, ']" value="', $board_id, '">'; |
301 | + } |
|
293 | 302 | |
294 | 303 | echo ' |
295 | 304 | </form> |
@@ -300,18 +309,20 @@ discard block |
||
300 | 309 | if ($context['compact']) |
301 | 310 | { |
302 | 311 | // Quick moderation set to checkboxes? Oh, how fun :/ |
303 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) |
|
304 | - echo ' |
|
312 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
313 | + echo ' |
|
305 | 314 | <form action="', $scripturl, '?action=quickmod" method="post" accept-charset="', $context['character_set'], '" name="topicForm">'; |
315 | + } |
|
306 | 316 | |
307 | 317 | echo ' |
308 | 318 | <div class="cat_bar"> |
309 | 319 | <h3 class="catbg"> |
310 | 320 | <span class="floatright">'; |
311 | 321 | |
312 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) |
|
313 | - echo ' |
|
322 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
323 | + echo ' |
|
314 | 324 | <input type="checkbox" onclick="invertAll(this, this.form, \'topics[]\');">'; |
325 | + } |
|
315 | 326 | echo ' |
316 | 327 | </span> |
317 | 328 | <span class="generic_icons filter"></span> ', $txt['mlist_search_results'], ': ', $context['search_params']['search'], ' |
@@ -319,15 +330,15 @@ discard block |
||
319 | 330 | </div>'; |
320 | 331 | |
321 | 332 | // Was anything even found? |
322 | - if (!empty($context['topics'])) |
|
323 | - echo ' |
|
333 | + if (!empty($context['topics'])) { |
|
334 | + echo ' |
|
324 | 335 | <div class="pagesection"> |
325 | 336 | <span>', $context['page_index'], '</span> |
326 | 337 | </div>'; |
327 | - |
|
328 | - else |
|
329 | - echo ' |
|
338 | + } else { |
|
339 | + echo ' |
|
330 | 340 | <div class="roundframe noup">', $txt['find_no_results'], '</div>'; |
341 | + } |
|
331 | 342 | |
332 | 343 | // While we have results to show ... |
333 | 344 | while ($topic = $context['get_topics']()) |
@@ -350,31 +361,35 @@ discard block |
||
350 | 361 | echo ' |
351 | 362 | <span class="floatright">'; |
352 | 363 | |
353 | - if ($options['display_quick_mod'] == 1) |
|
354 | - echo ' |
|
364 | + if ($options['display_quick_mod'] == 1) { |
|
365 | + echo ' |
|
355 | 366 | <input type="checkbox" name="topics[]" value="', $topic['id'], '">'; |
356 | - |
|
357 | - else |
|
367 | + } else |
|
358 | 368 | { |
359 | - if ($topic['quick_mod']['remove']) |
|
360 | - echo ' |
|
369 | + if ($topic['quick_mod']['remove']) { |
|
370 | + echo ' |
|
361 | 371 | <a href="', $scripturl, '?action=quickmod;board=' . $topic['board']['id'] . '.0;actions%5B', $topic['id'], '%5D=remove;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons delete" title="', $txt['remove_topic'], '"></span></a>'; |
372 | + } |
|
362 | 373 | |
363 | - if ($topic['quick_mod']['lock']) |
|
364 | - echo ' |
|
374 | + if ($topic['quick_mod']['lock']) { |
|
375 | + echo ' |
|
365 | 376 | <a href="', $scripturl, '?action=quickmod;board=' . $topic['board']['id'] . '.0;actions%5B', $topic['id'], '%5D=lock;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons lock" title="', $topic['is_locked'] ? $txt['set_unlock'] : $txt['set_lock'], '"></span></a>'; |
377 | + } |
|
366 | 378 | |
367 | - if ($topic['quick_mod']['lock'] || $topic['quick_mod']['remove']) |
|
368 | - echo ' |
|
379 | + if ($topic['quick_mod']['lock'] || $topic['quick_mod']['remove']) { |
|
380 | + echo ' |
|
369 | 381 | <br>'; |
382 | + } |
|
370 | 383 | |
371 | - if ($topic['quick_mod']['sticky']) |
|
372 | - echo ' |
|
384 | + if ($topic['quick_mod']['sticky']) { |
|
385 | + echo ' |
|
373 | 386 | <a href="', $scripturl, '?action=quickmod;board=' . $topic['board']['id'] . '.0;actions%5B', $topic['id'], '%5D=sticky;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons sticky" title="', $topic['is_sticky'] ? $txt['set_nonsticky'] : $txt['set_sticky'], '"></span></a>'; |
387 | + } |
|
374 | 388 | |
375 | - if ($topic['quick_mod']['move']) |
|
376 | - echo ' |
|
389 | + if ($topic['quick_mod']['move']) { |
|
390 | + echo ' |
|
377 | 391 | <a href="', $scripturl, '?action=movetopic;topic=', $topic['id'], '.0"><span class="generic_icons move" title="', $txt['move_topic'], '"></span></a>'; |
392 | + } |
|
378 | 393 | } |
379 | 394 | |
380 | 395 | echo ' |
@@ -384,20 +399,22 @@ discard block |
||
384 | 399 | echo ' |
385 | 400 | </div><!-- .block -->'; |
386 | 401 | |
387 | - if ($message['body_highlighted'] != '') |
|
388 | - echo ' |
|
402 | + if ($message['body_highlighted'] != '') { |
|
403 | + echo ' |
|
389 | 404 | <div class="list_posts double_height">', $message['body_highlighted'], '</div>'; |
405 | + } |
|
390 | 406 | } |
391 | 407 | |
392 | 408 | echo ' |
393 | 409 | </div><!-- $topic[css_class] -->'; |
394 | 410 | } |
395 | 411 | |
396 | - if (!empty($context['topics'])) |
|
397 | - echo ' |
|
412 | + if (!empty($context['topics'])) { |
|
413 | + echo ' |
|
398 | 414 | <div class="pagesection"> |
399 | 415 | <span>', $context['page_index'], '</span> |
400 | 416 | </div>'; |
417 | + } |
|
401 | 418 | |
402 | 419 | if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics'])) |
403 | 420 | { |
@@ -406,17 +423,19 @@ discard block |
||
406 | 423 | <select class="qaction" name="qaction"', $context['can_move'] ? ' onchange="this.form.move_to.disabled = (this.options[this.selectedIndex].value != \'move\');"' : '', '> |
407 | 424 | <option value="">--------</option>'; |
408 | 425 | |
409 | - foreach ($context['qmod_actions'] as $qmod_action) |
|
410 | - if ($context['can_' . $qmod_action]) |
|
426 | + foreach ($context['qmod_actions'] as $qmod_action) { |
|
427 | + if ($context['can_' . $qmod_action]) |
|
411 | 428 | echo ' |
412 | 429 | <option value="' . $qmod_action . '">' . $txt['quick_mod_' . $qmod_action] . '</option>'; |
430 | + } |
|
413 | 431 | |
414 | 432 | echo ' |
415 | 433 | </select>'; |
416 | 434 | |
417 | - if ($context['can_move']) |
|
418 | - echo ' |
|
435 | + if ($context['can_move']) { |
|
436 | + echo ' |
|
419 | 437 | <span id="quick_mod_jump_to"></span>'; |
438 | + } |
|
420 | 439 | |
421 | 440 | echo ' |
422 | 441 | <input type="hidden" name="redirect_url" value="', $scripturl . '?action=search2;params=' . $context['params'], '"> |
@@ -425,12 +444,12 @@ discard block |
||
425 | 444 | } |
426 | 445 | |
427 | 446 | |
428 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics'])) |
|
429 | - echo ' |
|
447 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics'])) { |
|
448 | + echo ' |
|
430 | 449 | <input type="hidden" name="' . $context['session_var'] . '" value="' . $context['session_id'] . '"> |
431 | 450 | </form>'; |
432 | - } |
|
433 | - else |
|
451 | + } |
|
452 | + } else |
|
434 | 453 | { |
435 | 454 | echo ' |
436 | 455 | <div class="cat_bar"> |
@@ -442,9 +461,10 @@ discard block |
||
442 | 461 | <span>', $context['page_index'], '</span> |
443 | 462 | </div>'; |
444 | 463 | |
445 | - if (empty($context['topics'])) |
|
446 | - echo ' |
|
464 | + if (empty($context['topics'])) { |
|
465 | + echo ' |
|
447 | 466 | <div class="information">(', $txt['search_no_results'], ')</div>'; |
467 | + } |
|
448 | 468 | |
449 | 469 | while ($topic = $context['get_topics']()) |
450 | 470 | { |
@@ -479,8 +499,8 @@ discard block |
||
479 | 499 | <div class="smalltext righttext" id="search_jump_to"></div> |
480 | 500 | <script>'; |
481 | 501 | |
482 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics']) && $context['can_move']) |
|
483 | - echo ' |
|
502 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics']) && $context['can_move']) { |
|
503 | + echo ' |
|
484 | 504 | if (typeof(window.XMLHttpRequest) != "undefined") |
485 | 505 | aJumpTo[aJumpTo.length] = new JumpTo({ |
486 | 506 | sContainerId: "quick_mod_jump_to", |
@@ -495,6 +515,7 @@ discard block |
||
495 | 515 | bDisabled: true, |
496 | 516 | sCustomName: "move_to" |
497 | 517 | });'; |
518 | + } |
|
498 | 519 | |
499 | 520 | echo ' |
500 | 521 | if (typeof(window.XMLHttpRequest) != "undefined") |
@@ -28,15 +28,17 @@ discard block |
||
28 | 28 | <form class="login" action="', $context['login_url'], '" name="frmLogin" id="frmLogin" method="post" accept-charset="', $context['character_set'], '">'; |
29 | 29 | |
30 | 30 | // Did they make a mistake last time? |
31 | - if (!empty($context['login_errors'])) |
|
32 | - echo ' |
|
31 | + if (!empty($context['login_errors'])) { |
|
32 | + echo ' |
|
33 | 33 | <div class="errorbox">', implode('<br>', $context['login_errors']), '</div> |
34 | 34 | <br>'; |
35 | + } |
|
35 | 36 | |
36 | 37 | // Or perhaps there's some special description for this time? |
37 | - if (isset($context['description'])) |
|
38 | - echo ' |
|
38 | + if (isset($context['description'])) { |
|
39 | + echo ' |
|
39 | 40 | <div class="information">', $context['description'], '</div>'; |
41 | + } |
|
40 | 42 | |
41 | 43 | // Now just get the basic information - username, password, etc. |
42 | 44 | echo ' |
@@ -55,19 +57,21 @@ discard block |
||
55 | 57 | <dd> |
56 | 58 | <select name="cookielength" id="cookielength">'; |
57 | 59 | |
58 | - foreach ($context['login_cookie_times'] as $cookie_time => $cookie_txt) |
|
59 | - echo ' |
|
60 | + foreach ($context['login_cookie_times'] as $cookie_time => $cookie_txt) { |
|
61 | + echo ' |
|
60 | 62 | <option value="', $cookie_time, '"', $modSettings['cookieTime'] == $cookie_time ? ' selected' : '', '>', $txt[$cookie_txt], '</option>'; |
63 | + } |
|
61 | 64 | |
62 | 65 | echo ' |
63 | 66 | </select> |
64 | 67 | </dd>'; |
65 | 68 | |
66 | 69 | // If they have deleted their account, give them a chance to change their mind. |
67 | - if (isset($context['login_show_undelete'])) |
|
68 | - echo ' |
|
70 | + if (isset($context['login_show_undelete'])) { |
|
71 | + echo ' |
|
69 | 72 | <dt class="alert">', $txt['undelete_account'], ':</dt> |
70 | 73 | <dd><input type="checkbox" name="undelete"></dd>'; |
74 | + } |
|
71 | 75 | |
72 | 76 | echo ' |
73 | 77 | </dl> |
@@ -85,8 +89,8 @@ discard block |
||
85 | 89 | document.getElementById("', !empty($context['from_ajax']) ? 'ajax_' : '', isset($context['default_username']) && $context['default_username'] != '' ? 'loginpass' : 'loginuser', '").focus(); |
86 | 90 | }, 150);'; |
87 | 91 | |
88 | - if (!empty($context['from_ajax'])) |
|
89 | - echo ' |
|
92 | + if (!empty($context['from_ajax'])) { |
|
93 | + echo ' |
|
90 | 94 | form = $("#frmLogin"); |
91 | 95 | form.submit(function(e) { |
92 | 96 | e.preventDefault(); |
@@ -119,16 +123,18 @@ discard block |
||
119 | 123 | |
120 | 124 | return false; |
121 | 125 | });'; |
126 | + } |
|
122 | 127 | |
123 | 128 | echo ' |
124 | 129 | </script> |
125 | 130 | </form>'; |
126 | 131 | |
127 | 132 | // It is a long story as to why we have this when we're clearly not going to use it. |
128 | - if (!empty($context['from_ajax'])) |
|
129 | - echo ' |
|
133 | + if (!empty($context['from_ajax'])) { |
|
134 | + echo ' |
|
130 | 135 | <br> |
131 | 136 | <a href="javascript:self.close();"></a>'; |
137 | + } |
|
132 | 138 | |
133 | 139 | echo ' |
134 | 140 | </div><!-- .roundframe --> |
@@ -151,11 +157,12 @@ discard block |
||
151 | 157 | </div> |
152 | 158 | <div class="roundframe">'; |
153 | 159 | |
154 | - if (!empty($context['tfa_error']) || !empty($context['tfa_backup_error'])) |
|
155 | - echo ' |
|
160 | + if (!empty($context['tfa_error']) || !empty($context['tfa_backup_error'])) { |
|
161 | + echo ' |
|
156 | 162 | <div class="error"> |
157 | 163 | ', $txt['tfa_' . (!empty($context['tfa_error']) ? 'code_' : 'backup_') . 'invalid'], ' |
158 | 164 | </div>'; |
165 | + } |
|
159 | 166 | |
160 | 167 | echo ' |
161 | 168 | <form action="', $context['tfa_url'], '" method="post" id="frmTfa"> |
@@ -183,8 +190,8 @@ discard block |
||
183 | 190 | <script> |
184 | 191 | form = $("#frmTfa");'; |
185 | 192 | |
186 | - if (!empty($context['from_ajax'])) |
|
187 | - echo ' |
|
193 | + if (!empty($context['from_ajax'])) { |
|
194 | + echo ' |
|
188 | 195 | form.submit(function(e) { |
189 | 196 | // If we are submitting backup code, let normal workflow follow since it redirects a couple times into a different page |
190 | 197 | if (form.find("input[name=tfa_backup]:first").val().length > 0) |
@@ -203,6 +210,7 @@ discard block |
||
203 | 210 | |
204 | 211 | return false; |
205 | 212 | });'; |
213 | + } |
|
206 | 214 | |
207 | 215 | echo ' |
208 | 216 | form.find("input[name=backup]").click(function(e) { |
@@ -234,10 +242,11 @@ discard block |
||
234 | 242 | <p class="information centertext"> |
235 | 243 | ', empty($context['kick_message']) ? $txt['only_members_can_access'] : $context['kick_message'], '<br>'; |
236 | 244 | |
237 | - if ($context['can_register']) |
|
238 | - echo sprintf($txt['login_below_or_register'], $scripturl . '?action=signup', $context['forum_name_html_safe']); |
|
239 | - else |
|
240 | - echo $txt['login_below']; |
|
245 | + if ($context['can_register']) { |
|
246 | + echo sprintf($txt['login_below_or_register'], $scripturl . '?action=signup', $context['forum_name_html_safe']); |
|
247 | + } else { |
|
248 | + echo $txt['login_below']; |
|
249 | + } |
|
241 | 250 | |
242 | 251 | // And now the login information. |
243 | 252 | echo ' |
@@ -256,9 +265,10 @@ discard block |
||
256 | 265 | <dd> |
257 | 266 | <select name="cookielength" id="cookielength">'; |
258 | 267 | |
259 | - foreach ($context['login_cookie_times'] as $cookie_time => $cookie_txt) |
|
260 | - echo ' |
|
268 | + foreach ($context['login_cookie_times'] as $cookie_time => $cookie_txt) { |
|
269 | + echo ' |
|
261 | 270 | <option value="', $cookie_time, '"', $modSettings['cookieTime'] == $cookie_time ? ' selected' : '', '>', $txt[$cookie_txt], '</option>'; |
271 | + } |
|
262 | 272 | |
263 | 273 | echo ' |
264 | 274 | </select> |
@@ -315,9 +325,10 @@ discard block |
||
315 | 325 | <dd> |
316 | 326 | <select name="cookielength" id="cookielength">'; |
317 | 327 | |
318 | - foreach ($context['login_cookie_times'] as $cookie_time => $cookie_txt) |
|
319 | - echo ' |
|
328 | + foreach ($context['login_cookie_times'] as $cookie_time => $cookie_txt) { |
|
329 | + echo ' |
|
320 | 330 | <option value="', $cookie_time, '"', $modSettings['cookieTime'] == $cookie_time ? ' selected' : '', '>', $txt[$cookie_txt], '</option>'; |
331 | + } |
|
321 | 332 | |
322 | 333 | echo ' |
323 | 334 | </select> |
@@ -351,9 +362,10 @@ discard block |
||
351 | 362 | </div> |
352 | 363 | <div class="roundframe centertext">'; |
353 | 364 | |
354 | - if (!empty($context['incorrect_password'])) |
|
355 | - echo ' |
|
365 | + if (!empty($context['incorrect_password'])) { |
|
366 | + echo ' |
|
356 | 367 | <div class="error">', $txt['admin_incorrect_password'], '</div>'; |
368 | + } |
|
357 | 369 | |
358 | 370 | echo ' |
359 | 371 | <strong>', $txt['password'], ':</strong> |
@@ -394,10 +406,11 @@ discard block |
||
394 | 406 | <dl>'; |
395 | 407 | |
396 | 408 | // You didn't even have an ID? |
397 | - if (empty($context['member_id'])) |
|
398 | - echo ' |
|
409 | + if (empty($context['member_id'])) { |
|
410 | + echo ' |
|
399 | 411 | <dt>', $txt['invalid_activation_username'], ':</dt> |
400 | 412 | <dd><input type="text" name="user" size="30"></dd>'; |
413 | + } |
|
401 | 414 | |
402 | 415 | echo ' |
403 | 416 | <dt>', $txt['invalid_activation_retry'], ':</dt> |
@@ -434,13 +447,14 @@ discard block |
||
434 | 447 | <dd><input type="password" name="passwd" size="30"></dd> |
435 | 448 | </dl>'; |
436 | 449 | |
437 | - if ($context['can_activate']) |
|
438 | - echo ' |
|
450 | + if ($context['can_activate']) { |
|
451 | + echo ' |
|
439 | 452 | <p>', $txt['invalid_activation_known'], '</p> |
440 | 453 | <dl> |
441 | 454 | <dt>', $txt['invalid_activation_retry'], ':</dt> |
442 | 455 | <dd><input type="text" name="code" size="30"></dd> |
443 | 456 | </dl>'; |
457 | + } |
|
444 | 458 | |
445 | 459 | echo ' |
446 | 460 | <p><input type="submit" value="', $txt['invalid_activation_resend'], '" class="button"></p> |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 4 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Ask them for their login information. (shows a page for the user to type |
@@ -29,8 +30,9 @@ discard block |
||
29 | 30 | global $txt, $context, $scripturl, $user_info; |
30 | 31 | |
31 | 32 | // You are already logged in, go take a tour of the boards |
32 | - if (!empty($user_info['id'])) |
|
33 | - redirectexit(); |
|
33 | + if (!empty($user_info['id'])) { |
|
34 | + redirectexit(); |
|
35 | + } |
|
34 | 36 | |
35 | 37 | // We need to load the Login template/language file. |
36 | 38 | loadLanguage('Login'); |
@@ -57,10 +59,11 @@ discard block |
||
57 | 59 | ); |
58 | 60 | |
59 | 61 | // Set the login URL - will be used when the login process is done (but careful not to send us to an attachment). |
60 | - if (isset($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'dlattach') === false && preg_match('~(board|topic)[=,]~', $_SESSION['old_url']) != 0) |
|
61 | - $_SESSION['login_url'] = $_SESSION['old_url']; |
|
62 | - elseif (isset($_SESSION['login_url']) && strpos($_SESSION['login_url'], 'dlattach') !== false) |
|
63 | - unset($_SESSION['login_url']); |
|
62 | + if (isset($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'dlattach') === false && preg_match('~(board|topic)[=,]~', $_SESSION['old_url']) != 0) { |
|
63 | + $_SESSION['login_url'] = $_SESSION['old_url']; |
|
64 | + } elseif (isset($_SESSION['login_url']) && strpos($_SESSION['login_url'], 'dlattach') !== false) { |
|
65 | + unset($_SESSION['login_url']); |
|
66 | + } |
|
64 | 67 | |
65 | 68 | // Create a one time token. |
66 | 69 | createToken('login'); |
@@ -92,8 +95,9 @@ discard block |
||
92 | 95 | global $cookiename, $modSettings, $context, $sourcedir, $maintenance; |
93 | 96 | |
94 | 97 | // Check to ensure we're forcing SSL for authentication |
95 | - if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) |
|
96 | - fatal_lang_error('login_ssl_required'); |
|
98 | + if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) { |
|
99 | + fatal_lang_error('login_ssl_required'); |
|
100 | + } |
|
97 | 101 | |
98 | 102 | // Load cookie authentication stuff. |
99 | 103 | require_once($sourcedir . '/Subs-Auth.php'); |
@@ -107,23 +111,26 @@ discard block |
||
107 | 111 | if (isset($_GET['sa']) && $_GET['sa'] == 'salt' && !$user_info['is_guest']) |
108 | 112 | { |
109 | 113 | // First check for 2.1 json-format cookie in $_COOKIE |
110 | - if (isset($_COOKIE[$cookiename]) && preg_match('~^{"0":\d+,"1":"[0-9a-f]*","2":\d+~', $_COOKIE[$cookiename]) === 1) |
|
111 | - list (,, $timeout) = $smcFunc['json_decode']($_COOKIE[$cookiename], true); |
|
114 | + if (isset($_COOKIE[$cookiename]) && preg_match('~^{"0":\d+,"1":"[0-9a-f]*","2":\d+~', $_COOKIE[$cookiename]) === 1) { |
|
115 | + list (,, $timeout) = $smcFunc['json_decode']($_COOKIE[$cookiename], true); |
|
116 | + } |
|
112 | 117 | |
113 | 118 | // Try checking for 2.1 json-format cookie in $_SESSION |
114 | - elseif (isset($_SESSION['login_' . $cookiename]) && preg_match('~^{"0":\d+,"1":"[0-9a-f]*","2":\d+~', $_SESSION['login_' . $cookiename]) === 1) |
|
115 | - list (,, $timeout) = $smcFunc['json_decode']($_SESSION['login_' . $cookiename]); |
|
119 | + elseif (isset($_SESSION['login_' . $cookiename]) && preg_match('~^{"0":\d+,"1":"[0-9a-f]*","2":\d+~', $_SESSION['login_' . $cookiename]) === 1) { |
|
120 | + list (,, $timeout) = $smcFunc['json_decode']($_SESSION['login_' . $cookiename]); |
|
121 | + } |
|
116 | 122 | |
117 | 123 | // Next, try checking for 2.0 serialized string cookie in $_COOKIE |
118 | - elseif (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;i:\d+;i:1;s:(0|128):"([a-fA-F0-9]{128})?";i:2;[id]:\d+;~', $_COOKIE[$cookiename]) === 1) |
|
119 | - list (,, $timeout) = safe_unserialize($_COOKIE[$cookiename]); |
|
124 | + elseif (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;i:\d+;i:1;s:(0|128):"([a-fA-F0-9]{128})?";i:2;[id]:\d+;~', $_COOKIE[$cookiename]) === 1) { |
|
125 | + list (,, $timeout) = safe_unserialize($_COOKIE[$cookiename]); |
|
126 | + } |
|
120 | 127 | |
121 | 128 | // Last, see if you need to fall back on checking for 2.0 serialized string cookie in $_SESSION |
122 | - elseif (isset($_SESSION['login_' . $cookiename]) && preg_match('~^a:[34]:\{i:0;i:\d+;i:1;s:(0|128):"([a-fA-F0-9]{128})?";i:2;[id]:\d+;~', $_SESSION['login_' . $cookiename]) === 1) |
|
123 | - list (,, $timeout) = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
124 | - |
|
125 | - else |
|
126 | - trigger_error('Login2(): Cannot be logged in without a session or cookie', E_USER_ERROR); |
|
129 | + elseif (isset($_SESSION['login_' . $cookiename]) && preg_match('~^a:[34]:\{i:0;i:\d+;i:1;s:(0|128):"([a-fA-F0-9]{128})?";i:2;[id]:\d+;~', $_SESSION['login_' . $cookiename]) === 1) { |
|
130 | + list (,, $timeout) = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
131 | + } else { |
|
132 | + trigger_error('Login2(): Cannot be logged in without a session or cookie', E_USER_ERROR); |
|
133 | + } |
|
127 | 134 | |
128 | 135 | $user_settings['password_salt'] = substr(md5(mt_rand()), 0, 4); |
129 | 136 | updateMemberData($user_info['id'], array('password_salt' => $user_settings['password_salt'])); |
@@ -143,24 +150,23 @@ discard block |
||
143 | 150 | elseif (isset($_GET['sa']) && $_GET['sa'] == 'check') |
144 | 151 | { |
145 | 152 | // Strike! You're outta there! |
146 | - if ($_GET['member'] != $user_info['id']) |
|
147 | - fatal_lang_error('login_cookie_error', false); |
|
153 | + if ($_GET['member'] != $user_info['id']) { |
|
154 | + fatal_lang_error('login_cookie_error', false); |
|
155 | + } |
|
148 | 156 | |
149 | 157 | $user_info['can_mod'] = allowedTo('access_mod_center') || (!$user_info['is_guest'] && ($user_info['mod_cache']['gq'] != '0=1' || $user_info['mod_cache']['bq'] != '0=1' || ($modSettings['postmod_active'] && !empty($user_info['mod_cache']['ap'])))); |
150 | 158 | |
151 | 159 | // Some whitelisting for login_url... |
152 | - if (empty($_SESSION['login_url'])) |
|
153 | - redirectexit(empty($user_settings['tfa_secret']) ? '' : 'action=logintfa'); |
|
154 | - elseif (!empty($_SESSION['login_url']) && (strpos($_SESSION['login_url'], 'http://') === false && strpos($_SESSION['login_url'], 'https://') === false)) |
|
160 | + if (empty($_SESSION['login_url'])) { |
|
161 | + redirectexit(empty($user_settings['tfa_secret']) ? '' : 'action=logintfa'); |
|
162 | + } elseif (!empty($_SESSION['login_url']) && (strpos($_SESSION['login_url'], 'http://') === false && strpos($_SESSION['login_url'], 'https://') === false)) |
|
155 | 163 | { |
156 | 164 | unset ($_SESSION['login_url']); |
157 | 165 | redirectexit(empty($user_settings['tfa_secret']) ? '' : 'action=logintfa'); |
158 | - } |
|
159 | - elseif (!empty($user_settings['tfa_secret'])) |
|
166 | + } elseif (!empty($user_settings['tfa_secret'])) |
|
160 | 167 | { |
161 | 168 | redirectexit('action=logintfa'); |
162 | - } |
|
163 | - else |
|
169 | + } else |
|
164 | 170 | { |
165 | 171 | // Best not to clutter the session data too much... |
166 | 172 | $temp = $_SESSION['login_url']; |
@@ -171,8 +177,9 @@ discard block |
||
171 | 177 | } |
172 | 178 | |
173 | 179 | // Beyond this point you are assumed to be a guest trying to login. |
174 | - if (!$user_info['is_guest']) |
|
175 | - redirectexit(); |
|
180 | + if (!$user_info['is_guest']) { |
|
181 | + redirectexit(); |
|
182 | + } |
|
176 | 183 | |
177 | 184 | // Are you guessing with a script? |
178 | 185 | checkSession(); |
@@ -180,18 +187,21 @@ discard block |
||
180 | 187 | spamProtection('login'); |
181 | 188 | |
182 | 189 | // Set the login_url if it's not already set (but careful not to send us to an attachment). |
183 | - if ((empty($_SESSION['login_url']) && isset($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'dlattach') === false && preg_match('~(board|topic)[=,]~', $_SESSION['old_url']) != 0) || (isset($_GET['quicklogin']) && isset($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'login') === false)) |
|
184 | - $_SESSION['login_url'] = $_SESSION['old_url']; |
|
190 | + if ((empty($_SESSION['login_url']) && isset($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'dlattach') === false && preg_match('~(board|topic)[=,]~', $_SESSION['old_url']) != 0) || (isset($_GET['quicklogin']) && isset($_SESSION['old_url']) && strpos($_SESSION['old_url'], 'login') === false)) { |
|
191 | + $_SESSION['login_url'] = $_SESSION['old_url']; |
|
192 | + } |
|
185 | 193 | |
186 | 194 | // Been guessing a lot, haven't we? |
187 | - if (isset($_SESSION['failed_login']) && $_SESSION['failed_login'] >= $modSettings['failed_login_threshold'] * 3) |
|
188 | - fatal_lang_error('login_threshold_fail', 'login'); |
|
195 | + if (isset($_SESSION['failed_login']) && $_SESSION['failed_login'] >= $modSettings['failed_login_threshold'] * 3) { |
|
196 | + fatal_lang_error('login_threshold_fail', 'login'); |
|
197 | + } |
|
189 | 198 | |
190 | 199 | // Set up the cookie length. (if it's invalid, just fall through and use the default.) |
191 | - if (isset($_POST['cookieneverexp']) || (!empty($_POST['cookielength']) && $_POST['cookielength'] == -1)) |
|
192 | - $modSettings['cookieTime'] = 3153600; |
|
193 | - elseif (!empty($_POST['cookielength']) && ($_POST['cookielength'] >= 1 && $_POST['cookielength'] <= 3153600)) |
|
194 | - $modSettings['cookieTime'] = (int) $_POST['cookielength']; |
|
200 | + if (isset($_POST['cookieneverexp']) || (!empty($_POST['cookielength']) && $_POST['cookielength'] == -1)) { |
|
201 | + $modSettings['cookieTime'] = 3153600; |
|
202 | + } elseif (!empty($_POST['cookielength']) && ($_POST['cookielength'] >= 1 && $_POST['cookielength'] <= 3153600)) { |
|
203 | + $modSettings['cookieTime'] = (int) $_POST['cookielength']; |
|
204 | + } |
|
195 | 205 | |
196 | 206 | // Login Cookie times. Format: time => txt |
197 | 207 | $context['login_cookie_times'] = array( |
@@ -320,8 +330,9 @@ discard block |
||
320 | 330 | $other_passwords[] = crypt(md5($_POST['passwrd']), md5($_POST['passwrd'])); |
321 | 331 | |
322 | 332 | // Snitz style - SHA-256. Technically, this is a downgrade, but most PHP configurations don't support sha256 anyway. |
323 | - if (strlen($user_settings['passwd']) == 64 && function_exists('mhash') && defined('MHASH_SHA256')) |
|
324 | - $other_passwords[] = bin2hex(mhash(MHASH_SHA256, $_POST['passwrd'])); |
|
333 | + if (strlen($user_settings['passwd']) == 64 && function_exists('mhash') && defined('MHASH_SHA256')) { |
|
334 | + $other_passwords[] = bin2hex(mhash(MHASH_SHA256, $_POST['passwrd'])); |
|
335 | + } |
|
325 | 336 | |
326 | 337 | // phpBB3 users new hashing. We now support it as well ;). |
327 | 338 | $other_passwords[] = phpBB3_password_check($_POST['passwrd'], $user_settings['passwd']); |
@@ -341,27 +352,29 @@ discard block |
||
341 | 352 | // Some common md5 ones. |
342 | 353 | $other_passwords[] = md5($user_settings['password_salt'] . $_POST['passwrd']); |
343 | 354 | $other_passwords[] = md5($_POST['passwrd'] . $user_settings['password_salt']); |
344 | - } |
|
345 | - elseif (strlen($user_settings['passwd']) == 40) |
|
355 | + } elseif (strlen($user_settings['passwd']) == 40) |
|
346 | 356 | { |
347 | 357 | // Maybe they are using a hash from before the password fix. |
348 | 358 | // This is also valid for SMF 1.1 to 2.0 style of hashing, changed to bcrypt in SMF 2.1 |
349 | 359 | $other_passwords[] = sha1(strtolower($user_settings['member_name']) . un_htmlspecialchars($_POST['passwrd'])); |
350 | 360 | |
351 | 361 | // BurningBoard3 style of hashing. |
352 | - if (!empty($modSettings['enable_password_conversion'])) |
|
353 | - $other_passwords[] = sha1($user_settings['password_salt'] . sha1($user_settings['password_salt'] . sha1($_POST['passwrd']))); |
|
362 | + if (!empty($modSettings['enable_password_conversion'])) { |
|
363 | + $other_passwords[] = sha1($user_settings['password_salt'] . sha1($user_settings['password_salt'] . sha1($_POST['passwrd']))); |
|
364 | + } |
|
354 | 365 | |
355 | 366 | // Perhaps we converted to UTF-8 and have a valid password being hashed differently. |
356 | 367 | if ($context['character_set'] == 'UTF-8' && !empty($modSettings['previousCharacterSet']) && $modSettings['previousCharacterSet'] != 'utf8') |
357 | 368 | { |
358 | 369 | // Try iconv first, for no particular reason. |
359 | - if (function_exists('iconv')) |
|
360 | - $other_passwords['iconv'] = sha1(strtolower(iconv('UTF-8', $modSettings['previousCharacterSet'], $user_settings['member_name'])) . un_htmlspecialchars(iconv('UTF-8', $modSettings['previousCharacterSet'], $_POST['passwrd']))); |
|
370 | + if (function_exists('iconv')) { |
|
371 | + $other_passwords['iconv'] = sha1(strtolower(iconv('UTF-8', $modSettings['previousCharacterSet'], $user_settings['member_name'])) . un_htmlspecialchars(iconv('UTF-8', $modSettings['previousCharacterSet'], $_POST['passwrd']))); |
|
372 | + } |
|
361 | 373 | |
362 | 374 | // Say it aint so, iconv failed! |
363 | - if (empty($other_passwords['iconv']) && function_exists('mb_convert_encoding')) |
|
364 | - $other_passwords[] = sha1(strtolower(mb_convert_encoding($user_settings['member_name'], 'UTF-8', $modSettings['previousCharacterSet'])) . un_htmlspecialchars(mb_convert_encoding($_POST['passwrd'], 'UTF-8', $modSettings['previousCharacterSet']))); |
|
375 | + if (empty($other_passwords['iconv']) && function_exists('mb_convert_encoding')) { |
|
376 | + $other_passwords[] = sha1(strtolower(mb_convert_encoding($user_settings['member_name'], 'UTF-8', $modSettings['previousCharacterSet'])) . un_htmlspecialchars(mb_convert_encoding($_POST['passwrd'], 'UTF-8', $modSettings['previousCharacterSet']))); |
|
377 | + } |
|
365 | 378 | } |
366 | 379 | } |
367 | 380 | |
@@ -391,8 +404,9 @@ discard block |
||
391 | 404 | $_SESSION['failed_login'] = isset($_SESSION['failed_login']) ? ($_SESSION['failed_login'] + 1) : 1; |
392 | 405 | |
393 | 406 | // Hmm... don't remember it, do you? Here, try the password reminder ;). |
394 | - if ($_SESSION['failed_login'] >= $modSettings['failed_login_threshold']) |
|
395 | - redirectexit('action=reminder'); |
|
407 | + if ($_SESSION['failed_login'] >= $modSettings['failed_login_threshold']) { |
|
408 | + redirectexit('action=reminder'); |
|
409 | + } |
|
396 | 410 | // We'll give you another chance... |
397 | 411 | else |
398 | 412 | { |
@@ -403,8 +417,7 @@ discard block |
||
403 | 417 | return; |
404 | 418 | } |
405 | 419 | } |
406 | - } |
|
407 | - elseif (!empty($user_settings['passwd_flood'])) |
|
420 | + } elseif (!empty($user_settings['passwd_flood'])) |
|
408 | 421 | { |
409 | 422 | // Let's be sure they weren't a little hacker. |
410 | 423 | validatePasswordFlood($user_settings['id_member'], $user_settings['member_name'], $user_settings['passwd_flood'], true); |
@@ -421,8 +434,9 @@ discard block |
||
421 | 434 | } |
422 | 435 | |
423 | 436 | // Check their activation status. |
424 | - if (!checkActivation()) |
|
425 | - return; |
|
437 | + if (!checkActivation()) { |
|
438 | + return; |
|
439 | + } |
|
426 | 440 | |
427 | 441 | DoLogin(); |
428 | 442 | } |
@@ -434,8 +448,9 @@ discard block |
||
434 | 448 | { |
435 | 449 | global $sourcedir, $txt, $context, $user_info, $modSettings, $scripturl; |
436 | 450 | |
437 | - if (!$user_info['is_guest'] || empty($context['tfa_member']) || empty($modSettings['tfa_mode'])) |
|
438 | - fatal_lang_error('no_access', false); |
|
451 | + if (!$user_info['is_guest'] || empty($context['tfa_member']) || empty($modSettings['tfa_mode'])) { |
|
452 | + fatal_lang_error('no_access', false); |
|
453 | + } |
|
439 | 454 | |
440 | 455 | loadLanguage('Profile'); |
441 | 456 | require_once($sourcedir . '/Class-TOTP.php'); |
@@ -443,8 +458,9 @@ discard block |
||
443 | 458 | $member = $context['tfa_member']; |
444 | 459 | |
445 | 460 | // Prevent replay attacks by limiting at least 2 minutes before they can log in again via 2FA |
446 | - if (time() - $member['last_login'] < 120) |
|
447 | - fatal_lang_error('tfa_wait', false); |
|
461 | + if (time() - $member['last_login'] < 120) { |
|
462 | + fatal_lang_error('tfa_wait', false); |
|
463 | + } |
|
448 | 464 | |
449 | 465 | $totp = new \TOTP\Auth($member['tfa_secret']); |
450 | 466 | $totp->setRange(1); |
@@ -458,8 +474,9 @@ discard block |
||
458 | 474 | if (!empty($_POST['tfa_code']) && empty($_POST['tfa_backup'])) |
459 | 475 | { |
460 | 476 | // Check to ensure we're forcing SSL for authentication |
461 | - if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) |
|
462 | - fatal_lang_error('login_ssl_required'); |
|
477 | + if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) { |
|
478 | + fatal_lang_error('login_ssl_required'); |
|
479 | + } |
|
463 | 480 | |
464 | 481 | $code = $_POST['tfa_code']; |
465 | 482 | |
@@ -469,20 +486,19 @@ discard block |
||
469 | 486 | |
470 | 487 | setTFACookie(3153600, $member['id_member'], hash_salt($member['tfa_backup'], $member['password_salt'])); |
471 | 488 | redirectexit(); |
472 | - } |
|
473 | - else |
|
489 | + } else |
|
474 | 490 | { |
475 | 491 | validatePasswordFlood($member['id_member'], $member['member_name'], $member['passwd_flood'], false, true); |
476 | 492 | |
477 | 493 | $context['tfa_error'] = true; |
478 | 494 | $context['tfa_value'] = $_POST['tfa_code']; |
479 | 495 | } |
480 | - } |
|
481 | - elseif (!empty($_POST['tfa_backup'])) |
|
496 | + } elseif (!empty($_POST['tfa_backup'])) |
|
482 | 497 | { |
483 | 498 | // Check to ensure we're forcing SSL for authentication |
484 | - if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) |
|
485 | - fatal_lang_error('login_ssl_required'); |
|
499 | + if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) { |
|
500 | + fatal_lang_error('login_ssl_required'); |
|
501 | + } |
|
486 | 502 | |
487 | 503 | $backup = $_POST['tfa_backup']; |
488 | 504 | |
@@ -496,8 +512,7 @@ discard block |
||
496 | 512 | )); |
497 | 513 | setTFACookie(3153600, $member['id_member'], hash_salt($member['tfa_backup'], $member['password_salt'])); |
498 | 514 | redirectexit('action=profile;area=tfasetup;backup'); |
499 | - } |
|
500 | - else |
|
515 | + } else |
|
501 | 516 | { |
502 | 517 | validatePasswordFlood($member['id_member'], $member['member_name'], $member['passwd_flood'], false, true); |
503 | 518 | |
@@ -520,8 +535,9 @@ discard block |
||
520 | 535 | { |
521 | 536 | global $context, $txt, $scripturl, $user_settings, $modSettings; |
522 | 537 | |
523 | - if (!isset($context['login_errors'])) |
|
524 | - $context['login_errors'] = array(); |
|
538 | + if (!isset($context['login_errors'])) { |
|
539 | + $context['login_errors'] = array(); |
|
540 | + } |
|
525 | 541 | |
526 | 542 | // What is the true activation status of this account? |
527 | 543 | $activation_status = $user_settings['is_activated'] > 10 ? $user_settings['is_activated'] - 10 : $user_settings['is_activated']; |
@@ -533,8 +549,9 @@ discard block |
||
533 | 549 | return false; |
534 | 550 | } |
535 | 551 | // Awaiting approval still? |
536 | - elseif ($activation_status == 3) |
|
537 | - fatal_lang_error('still_awaiting_approval', 'user'); |
|
552 | + elseif ($activation_status == 3) { |
|
553 | + fatal_lang_error('still_awaiting_approval', 'user'); |
|
554 | + } |
|
538 | 555 | // Awaiting deletion, changed their mind? |
539 | 556 | elseif ($activation_status == 4) |
540 | 557 | { |
@@ -542,8 +559,7 @@ discard block |
||
542 | 559 | { |
543 | 560 | updateMemberData($user_settings['id_member'], array('is_activated' => 1)); |
544 | 561 | updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 0 ? $modSettings['unapprovedMembers'] - 1 : 0))); |
545 | - } |
|
546 | - else |
|
562 | + } else |
|
547 | 563 | { |
548 | 564 | $context['disable_login_hashing'] = true; |
549 | 565 | $context['login_errors'][] = $txt['awaiting_delete_account']; |
@@ -583,8 +599,9 @@ discard block |
||
583 | 599 | setLoginCookie(60 * $modSettings['cookieTime'], $user_settings['id_member'], hash_salt($user_settings['passwd'], $user_settings['password_salt'])); |
584 | 600 | |
585 | 601 | // Reset the login threshold. |
586 | - if (isset($_SESSION['failed_login'])) |
|
587 | - unset($_SESSION['failed_login']); |
|
602 | + if (isset($_SESSION['failed_login'])) { |
|
603 | + unset($_SESSION['failed_login']); |
|
604 | + } |
|
588 | 605 | |
589 | 606 | $user_info['is_guest'] = false; |
590 | 607 | $user_settings['additional_groups'] = explode(',', $user_settings['additional_groups']); |
@@ -606,16 +623,18 @@ discard block |
||
606 | 623 | 'id_member' => $user_info['id'], |
607 | 624 | ) |
608 | 625 | ); |
609 | - if ($smcFunc['db_num_rows']($request) == 1) |
|
610 | - $_SESSION['first_login'] = true; |
|
611 | - else |
|
612 | - unset($_SESSION['first_login']); |
|
626 | + if ($smcFunc['db_num_rows']($request) == 1) { |
|
627 | + $_SESSION['first_login'] = true; |
|
628 | + } else { |
|
629 | + unset($_SESSION['first_login']); |
|
630 | + } |
|
613 | 631 | $smcFunc['db_free_result']($request); |
614 | 632 | |
615 | 633 | // You've logged in, haven't you? |
616 | 634 | $update = array('member_ip' => $user_info['ip'], 'member_ip2' => $_SERVER['BAN_CHECK_IP']); |
617 | - if (empty($user_settings['tfa_secret'])) |
|
618 | - $update['last_login'] = time(); |
|
635 | + if (empty($user_settings['tfa_secret'])) { |
|
636 | + $update['last_login'] = time(); |
|
637 | + } |
|
619 | 638 | updateMemberData($user_info['id'], $update); |
620 | 639 | |
621 | 640 | // Get rid of the online entry for that old guest.... |
@@ -629,8 +648,8 @@ discard block |
||
629 | 648 | $_SESSION['log_time'] = 0; |
630 | 649 | |
631 | 650 | // Log this entry, only if we have it enabled. |
632 | - if (!empty($modSettings['loginHistoryDays'])) |
|
633 | - $smcFunc['db_insert']('insert', |
|
651 | + if (!empty($modSettings['loginHistoryDays'])) { |
|
652 | + $smcFunc['db_insert']('insert', |
|
634 | 653 | '{db_prefix}member_logins', |
635 | 654 | array( |
636 | 655 | 'id_member' => 'int', 'time' => 'int', 'ip' => 'inet', 'ip2' => 'inet', |
@@ -642,13 +661,15 @@ discard block |
||
642 | 661 | 'id_member', 'time' |
643 | 662 | ) |
644 | 663 | ); |
664 | + } |
|
645 | 665 | |
646 | 666 | // Just log you back out if it's in maintenance mode and you AREN'T an admin. |
647 | - if (empty($maintenance) || allowedTo('admin_forum')) |
|
648 | - redirectexit('action=login2;sa=check;member=' . $user_info['id'], $context['server']['needs_login_fix']); |
|
649 | - else |
|
650 | - redirectexit('action=logout;' . $context['session_var'] . '=' . $context['session_id'], $context['server']['needs_login_fix']); |
|
651 | -} |
|
667 | + if (empty($maintenance) || allowedTo('admin_forum')) { |
|
668 | + redirectexit('action=login2;sa=check;member=' . $user_info['id'], $context['server']['needs_login_fix']); |
|
669 | + } else { |
|
670 | + redirectexit('action=logout;' . $context['session_var'] . '=' . $context['session_id'], $context['server']['needs_login_fix']); |
|
671 | + } |
|
672 | + } |
|
652 | 673 | |
653 | 674 | /** |
654 | 675 | * Logs the current user out of their account. |
@@ -664,13 +685,15 @@ discard block |
||
664 | 685 | global $sourcedir, $user_info, $user_settings, $context, $smcFunc, $cookiename, $modSettings; |
665 | 686 | |
666 | 687 | // Make sure they aren't being auto-logged out. |
667 | - if (!$internal) |
|
668 | - checkSession('get'); |
|
688 | + if (!$internal) { |
|
689 | + checkSession('get'); |
|
690 | + } |
|
669 | 691 | |
670 | 692 | require_once($sourcedir . '/Subs-Auth.php'); |
671 | 693 | |
672 | - if (isset($_SESSION['pack_ftp'])) |
|
673 | - $_SESSION['pack_ftp'] = null; |
|
694 | + if (isset($_SESSION['pack_ftp'])) { |
|
695 | + $_SESSION['pack_ftp'] = null; |
|
696 | + } |
|
674 | 697 | |
675 | 698 | // It won't be first login anymore. |
676 | 699 | unset($_SESSION['first_login']); |
@@ -698,8 +721,9 @@ discard block |
||
698 | 721 | |
699 | 722 | // And some other housekeeping while we're at it. |
700 | 723 | $salt = substr(md5(mt_rand()), 0, 4); |
701 | - if (!empty($user_info['id'])) |
|
702 | - updateMemberData($user_info['id'], array('password_salt' => $salt)); |
|
724 | + if (!empty($user_info['id'])) { |
|
725 | + updateMemberData($user_info['id'], array('password_salt' => $salt)); |
|
726 | + } |
|
703 | 727 | |
704 | 728 | if (!empty($modSettings['tfa_mode']) && !empty($user_info['id']) && !empty($_COOKIE[$cookiename . '_tfa'])) |
705 | 729 | { |
@@ -712,14 +736,13 @@ discard block |
||
712 | 736 | // Off to the merry board index we go! |
713 | 737 | if ($redirect) |
714 | 738 | { |
715 | - if (empty($_SESSION['logout_url'])) |
|
716 | - redirectexit('', $context['server']['needs_login_fix']); |
|
717 | - elseif (!empty($_SESSION['logout_url']) && (strpos($_SESSION['logout_url'], 'http://') === false && strpos($_SESSION['logout_url'], 'https://') === false)) |
|
739 | + if (empty($_SESSION['logout_url'])) { |
|
740 | + redirectexit('', $context['server']['needs_login_fix']); |
|
741 | + } elseif (!empty($_SESSION['logout_url']) && (strpos($_SESSION['logout_url'], 'http://') === false && strpos($_SESSION['logout_url'], 'https://') === false)) |
|
718 | 742 | { |
719 | 743 | unset ($_SESSION['logout_url']); |
720 | 744 | redirectexit(); |
721 | - } |
|
722 | - else |
|
745 | + } else |
|
723 | 746 | { |
724 | 747 | $temp = $_SESSION['logout_url']; |
725 | 748 | unset($_SESSION['logout_url']); |
@@ -752,8 +775,9 @@ discard block |
||
752 | 775 | function phpBB3_password_check($passwd, $passwd_hash) |
753 | 776 | { |
754 | 777 | // Too long or too short? |
755 | - if (strlen($passwd_hash) != 34) |
|
756 | - return; |
|
778 | + if (strlen($passwd_hash) != 34) { |
|
779 | + return; |
|
780 | + } |
|
757 | 781 | |
758 | 782 | // Range of characters allowed. |
759 | 783 | $range = './0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'; |
@@ -764,8 +788,9 @@ discard block |
||
764 | 788 | $salt = substr($passwd_hash, 4, 8); |
765 | 789 | |
766 | 790 | $hash = md5($salt . $passwd, true); |
767 | - for (; $count != 0; --$count) |
|
768 | - $hash = md5($hash . $passwd, true); |
|
791 | + for (; $count != 0; --$count) { |
|
792 | + $hash = md5($hash . $passwd, true); |
|
793 | + } |
|
769 | 794 | |
770 | 795 | $output = substr($passwd_hash, 0, 12); |
771 | 796 | $i = 0; |
@@ -774,21 +799,25 @@ discard block |
||
774 | 799 | $value = ord($hash[$i++]); |
775 | 800 | $output .= $range[$value & 0x3f]; |
776 | 801 | |
777 | - if ($i < 16) |
|
778 | - $value |= ord($hash[$i]) << 8; |
|
802 | + if ($i < 16) { |
|
803 | + $value |= ord($hash[$i]) << 8; |
|
804 | + } |
|
779 | 805 | |
780 | 806 | $output .= $range[($value >> 6) & 0x3f]; |
781 | 807 | |
782 | - if ($i++ >= 16) |
|
783 | - break; |
|
808 | + if ($i++ >= 16) { |
|
809 | + break; |
|
810 | + } |
|
784 | 811 | |
785 | - if ($i < 16) |
|
786 | - $value |= ord($hash[$i]) << 16; |
|
812 | + if ($i < 16) { |
|
813 | + $value |= ord($hash[$i]) << 16; |
|
814 | + } |
|
787 | 815 | |
788 | 816 | $output .= $range[($value >> 12) & 0x3f]; |
789 | 817 | |
790 | - if ($i++ >= 16) |
|
791 | - break; |
|
818 | + if ($i++ >= 16) { |
|
819 | + break; |
|
820 | + } |
|
792 | 821 | |
793 | 822 | $output .= $range[($value >> 18) & 0x3f]; |
794 | 823 | } |
@@ -820,8 +849,9 @@ discard block |
||
820 | 849 | require_once($sourcedir . '/Subs-Auth.php'); |
821 | 850 | setLoginCookie(-3600, 0); |
822 | 851 | |
823 | - if (isset($_SESSION['login_' . $cookiename])) |
|
824 | - unset($_SESSION['login_' . $cookiename]); |
|
852 | + if (isset($_SESSION['login_' . $cookiename])) { |
|
853 | + unset($_SESSION['login_' . $cookiename]); |
|
854 | + } |
|
825 | 855 | } |
826 | 856 | |
827 | 857 | // We need a member! |
@@ -835,8 +865,9 @@ discard block |
||
835 | 865 | } |
836 | 866 | |
837 | 867 | // Right, have we got a flood value? |
838 | - if ($password_flood_value !== false) |
|
839 | - @list ($time_stamp, $number_tries) = explode('|', $password_flood_value); |
|
868 | + if ($password_flood_value !== false) { |
|
869 | + @list ($time_stamp, $number_tries) = explode('|', $password_flood_value); |
|
870 | + } |
|
840 | 871 | |
841 | 872 | // Timestamp or number of tries invalid? |
842 | 873 | if (empty($number_tries) || empty($time_stamp)) |
@@ -852,15 +883,17 @@ discard block |
||
852 | 883 | $number_tries = $time_stamp < time() - 20 ? 2 : $number_tries; |
853 | 884 | |
854 | 885 | // They are trying too fast, make them wait longer |
855 | - if ($time_stamp < time() - 10) |
|
856 | - $time_stamp = time(); |
|
886 | + if ($time_stamp < time() - 10) { |
|
887 | + $time_stamp = time(); |
|
888 | + } |
|
857 | 889 | } |
858 | 890 | |
859 | 891 | $number_tries++; |
860 | 892 | |
861 | 893 | // Broken the law? |
862 | - if ($number_tries > 5) |
|
863 | - fatal_lang_error('login_threshold_brute_fail', 'login', [$member_name]); |
|
894 | + if ($number_tries > 5) { |
|
895 | + fatal_lang_error('login_threshold_brute_fail', 'login', [$member_name]); |
|
896 | + } |
|
864 | 897 | |
865 | 898 | // Otherwise set the members data. If they correct on their first attempt then we actually clear it, otherwise we set it! |
866 | 899 | updateMemberData($id_member, array('passwd_flood' => $was_correct && $number_tries == 1 ? '' : $time_stamp . '|' . $number_tries)); |