Inspection of "Suppress Phar handling alerts with open_basedir se..." - SimpleMachines/SMF2.1 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — release-2.1 ( 9fa566...084464 )

by Colin

created 2018-08-06 02:56 UTC

Status

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -419,8 +419,8 @@  discard block
 block discarded – undo
 										<div class="bar"></div>
 									</div>
 									<div class="attach-ui">
-										<a data-dz-remove class="button cancel">', $txt['modify_cancel'] ,'</a>
-										<a class="button upload">', $txt['upload'] ,'</a>
+										<a data-dz-remove class="button cancel">', $txt['modify_cancel'], '</a>
+										<a class="button upload">', $txt['upload'], '</a>
 									</div>
 								</div><!-- .attach-info -->
 							</div><!-- #au-template -->
@@ -437,10 +437,10 @@  discard block
 block discarded – undo
 							</dt>
 							<dd class="smalltext fallback">
 								<div id="attachUpload" class="descbox">
-									<h5>', $txt['attach_drop_zone'] ,'</h5>
-									<a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'] ,'</a>
-									<a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'] ,'</a>
-									<a class="button fileinput-button">', $txt['attach_add'] ,'</a>
+									<h5>', $txt['attach_drop_zone'], '</h5>
+									<a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'], '</a>
+									<a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'], '</a>
+									<a class="button fileinput-button">', $txt['attach_add'], '</a>
 									<div id="total-progress" class="progress_bar" role="progressBar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0">
 										<div class="bar"></div>
 									</div>
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
 	// Option to delete an event if user is editing one.
 	if ($context['make_event'] && !$context['event']['new'])
 		echo '
-						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">';
+						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'], '" class="button you_sure">';
 
 	echo '
 					</span>
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
 			});';
 
 	echo '
-			var oEditorID = "', $context['post_box_name'] ,'";
+			var oEditorID = "', $context['post_box_name'], '";
 			var oEditorObject = oEditorHandle_', $context['post_box_name'], ';
 		</script>';
 
@@ -836,7 +836,7 @@  discard block
 block discarded – undo
 			if ($context['can_quote'])
 				echo '
 					<ul class="quickbuttons" id="msg_', $post['id'], '_quote">
-						<li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'] ,'</a></li>
+						<li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li>
 						<li id="post_modify"><a href="#postmodify" onclick="return insertQuoteFast(', $post['id'], ');"><span class="generic_icons quote"></span>', $txt['quote'], '</a></li>
 					</ul>';
 
@@ -920,7 +920,7 @@  discard block
 block discarded – undo
 	<head>
 		<meta charset="', $context['character_set'], '">
 		<title>', $txt['spell_check'], '</title>
-		<link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'] ,'">
+		<link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'], '">
 		<style>
 			body, td {
 				font-size: small;
@@ -950,8 +950,8 @@  discard block
 block discarded – undo
 			var spell_formname = window.opener.spell_formname;
 			var spell_fieldname = window.opener.spell_fieldname;
 		</script>
-		<script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'] ,'"></script>
-		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script>
+		<script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'], '"></script>
+		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script>
 		<script>
 			', $context['spell_js'], '
 		</script>
@@ -995,7 +995,7 @@  discard block
 block discarded – undo
 	<head>
 		<meta charset="', $context['character_set'], '">
 		<title>', $txt['retrieving_quote'], '</title>
-		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script>
+		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script>
 	</head>
 	<body>
 		', $txt['retrieving_quote'], '

Please login to merge, or discard this patch.

Themes/default/BoardIndex.template.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,7 +70,7 @@  discard block
 block discarded – undo
 
 		echo '
 		<div class="main_container">
-			<div class="cat_bar ', $category['is_collapsed'] ? 'collapsed' : '','" id="category_', $category['id'], '">
+			<div class="cat_bar ', $category['is_collapsed'] ? 'collapsed' : '', '" id="category_', $category['id'], '">
 				<h3 class="catbg">';
 
 		// If this category even can collapse, show a link to collapse it.
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
 		foreach ($board['children'] as $child)
 		{
 			if (!$child['is_redirect'])
-				$child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>';
+				$child['link'] = '' . ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>';
 			else
 				$child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>';
 

Please login to merge, or discard this patch.

Sources/Profile-Modify.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1256,7 +1256,7 @@  discard block
 block discarded – undo
 			);
 			if (empty($value))
 			{
-				$deletes = array('id_theme' => 1 , 'variable' => $row['col_name'], 'id_member' => $memID);
+				$deletes = array('id_theme' => 1, 'variable' => $row['col_name'], 'id_member' => $memID);
 				unset($user_profile[$memID]['options'][$row['col_name']]);
 			}
 			else
@@ -1284,7 +1284,7 @@  discard block
 block discarded – undo
 				array('id_theme', 'variable', 'id_member')
 			);
 		if (!empty($deletes))
-			$smcFunc['db_query']('','
+			$smcFunc['db_query']('', '
 				DELETE FROM {db_prefix}themes
 				WHERE id_theme = {int:id_theme} AND
 						variable = {string:variable} AND

Please login to merge, or discard this patch.

Sources/Class-Punycode.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -136,7 +136,7 @@  discard block
 block discarded – undo
                 }
                 if ($c === $n) {
                     $q = $delta;
-                    for ($k = static::BASE;; $k += static::BASE) {
+                    for ($k = static::BASE; ; $k += static::BASE) {
                         $t = $this->calculateThreshold($k, $bias);
                         if ($q < $t) {
                             break;
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
             $oldi = $i;
             $w = 1;
 
-            for ($k = static::BASE;; $k += static::BASE) {
+            for ($k = static::BASE; ; $k += static::BASE) {
                 $digit = static::$decodeTable[$input[$pos++]];
                 $i = $i + ($digit * $w);
                 $t = $this->calculateThreshold($k, $bias);

Please login to merge, or discard this patch.

Sources/PackageGet.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -181,14 +181,14 @@  discard block
 block discarded – undo
 		{
 			collapsedDiv.show(\'slow\');
 			icon.removeClass(\'toggle_down\').addClass(\'toggle_up\');
-			icon.prop(\'title\', '. JavaScriptEscape($txt['hide']) .');
+			icon.prop(\'title\', '. JavaScriptEscape($txt['hide']) . ');
 		}
 
 		else
 		{
 			collapsedDiv.hide(\'slow\');
 			icon.removeClass(\'toggle_up\').addClass(\'toggle_down\');
-			icon.prop(\'title\', '. JavaScriptEscape($txt['show']) .');
+			icon.prop(\'title\', '. JavaScriptEscape($txt['show']) . ');
 		}
 	});', true);
 }
@@ -641,7 +641,7 @@  discard block
 block discarded – undo
 
 	// Setup the correct template, even though I'll admit we ain't downloading ;)
 	$context['sub_template'] = 'downloaded';
-	$allowext = array('.zip','.tgz','.gz');
+	$allowext = array('.zip', '.tgz', '.gz');
 	// @todo Use FTP if the Packages directory is not writable.
 
 	// Check the file was even sent!
@@ -653,13 +653,13 @@  discard block
 block discarded – undo
 	// Make sure it has a sane filename.
 	$_FILES['package']['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['package']['name']);
 	$extension = substr(strrchr(strtolower($_FILES['package']['name']), '.'), 0);
-	if(!in_array($extension, $allowext))
+	if (!in_array($extension, $allowext))
 	{
 		fatal_lang_error('package_upload_error_supports', false, array('zip, tgz, tar.gz'));
 	}
 
 	// We only need the filename...
-	$extension = ($extension == '.gz') ? '.tar.gz' : $extension ;
+	$extension = ($extension == '.gz') ? '.tar.gz' : $extension;
 	$packageName = time() . $extension;
 
 	// Setup the destination and throw an error if the file is already there!

Please login to merge, or discard this patch.

Sources/RepairBoards.php 1 patch

Spacing +35 added lines, -35 removed lines patch added patch discarded remove patch

@@ -232,7 +232,7 @@  discard block
 block discarded – undo
 					LEFT JOIN {db_prefix}topics AS t ON (t.id_topic = m.id_topic)
 				WHERE t.id_topic IS NULL
 				GROUP BY m.id_topic, m.id_board',
-			'fix_processing' => function ($row) use ($smcFunc)
+			'fix_processing' => function($row) use ($smcFunc)
 			{
 				global $salvageBoardID;
 
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
 			// Remove all topics that have zero messages in the messages table.
 			'fix_collect' => array(
 				'index' => 'id_topic',
-				'process' => function ($topics) use ($smcFunc)
+				'process' => function($topics) use ($smcFunc)
 				{
 					$smcFunc['db_query']('', '
 						DELETE FROM {db_prefix}topics
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
 				  AND p.id_poll IS NULL
 				GROUP BY o.id_poll, t.id_topic, t.id_board, t.id_member_started, m.member_name
 				  ',
-			'fix_processing' => function ($row) use ($smcFunc, $txt)
+			'fix_processing' => function($row) use ($smcFunc, $txt)
 			{
 				global $salvageBoardID;
 
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
 				{
 					// Only if we don't have a reasonable idea of where to put it.
 					createSalvageArea();
-					$row['id_board'] = (int)$salvageBoardID;
+					$row['id_board'] = (int) $salvageBoardID;
 				}
 
 				if (empty($row['id_topic']))
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
 					LEFT JOIN {db_prefix}topics AS t ON (t.id_poll = p.id_poll)
 				WHERE p.id_poll BETWEEN {STEP_LOW} AND {STEP_HIGH}
 					AND t.id_poll IS NULL',
-			'fix_processing' => function ($row) use ($smcFunc, $txt)
+			'fix_processing' => function($row) use ($smcFunc, $txt)
 			{
 				global $salvageBoardID;
 
@@ -603,7 +603,7 @@  discard block
 block discarded – undo
 				WHERE t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
 				GROUP BY t.id_topic, t.id_first_msg, t.id_last_msg, t.approved, mf.approved
 				ORDER BY t.id_topic',
-			'fix_processing' => function ($row) use ($smcFunc)
+			'fix_processing' => function($row) use ($smcFunc)
 			{
 				$row['firstmsg_approved'] = (int) $row['firstmsg_approved'];
 				$row['myid_first_msg'] = (int) $row['myid_first_msg'];
@@ -632,7 +632,7 @@  discard block
 block discarded – undo
 					)
 				);
 			},
-			'message_function' => function ($row) use ($txt, &$context)
+			'message_function' => function($row) use ($txt, &$context)
 			{
 				// A pretend error?
 				if ($row['id_first_msg'] == $row['myid_first_msg'] && $row['id_last_msg'] == $row['myid_last_msg'] && $row['approved'] == $row['firstmsg_approved'])
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
 				WHERE t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
 				GROUP BY t.id_topic, t.num_replies, mf.approved
 				ORDER BY t.id_topic',
-			'fix_processing' => function ($row)
+			'fix_processing' => function($row)
 			{
 				global $smcFunc;
 				$row['my_num_replies'] = (int) $row['my_num_replies'];
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
 					)
 				);
 			},
-			'message_function' => function ($row)
+			'message_function' => function($row)
 			{
 				global $txt, $context;
 
@@ -716,7 +716,7 @@  discard block
 block discarded – undo
 				GROUP BY t.id_topic, t.unapproved_posts
 				HAVING unapproved_posts != COUNT(mu.id_msg)
 				ORDER BY t.id_topic',
-			'fix_processing' => function ($row)
+			'fix_processing' => function($row)
 			{
 				global $smcFunc;
 				$row['my_unapproved_posts'] = (int) $row['my_unapproved_posts'];
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
 				WHERE b.id_board IS NULL
 					AND t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
 				GROUP BY t.id_board',
-			'fix_processing' => function ($row)
+			'fix_processing' => function($row)
 			{
 				global $smcFunc, $salvageCatID, $txt;
 				createSalvageArea();
@@ -803,7 +803,7 @@  discard block
 block discarded – undo
 				ORDER BY b.id_cat, b.id_board',
 			'fix_collect' => array(
 				'index' => 'id_cat',
-				'process' => function ($cats)
+				'process' => function($cats)
 				{
 					global $smcFunc, $salvageCatID;
 					createSalvageArea();
@@ -839,7 +839,7 @@  discard block
 block discarded – undo
 			// Last step-make sure all non-guest posters still exist.
 			'fix_collect' => array(
 				'index' => 'id_msg',
-				'process' => function ($msgs)
+				'process' => function($msgs)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -866,7 +866,7 @@  discard block
 block discarded – undo
 				ORDER BY b.id_parent, b.id_board',
 			'fix_collect' => array(
 				'index' => 'id_parent',
-				'process' => function ($parents)
+				'process' => function($parents)
 				{
 					global $smcFunc, $salvageBoardID, $salvageCatID;
 					createSalvageArea();
@@ -900,7 +900,7 @@  discard block
 block discarded – undo
 					AND p.id_poll IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_poll',
-				'process' => function ($polls)
+				'process' => function($polls)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -932,7 +932,7 @@  discard block
 block discarded – undo
 				ORDER BY cal.id_topic',
 			'fix_collect' => array(
 				'index' => 'id_topic',
-				'process' => function ($events)
+				'process' => function($events)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -962,7 +962,7 @@  discard block
 block discarded – undo
 					AND lt.id_member BETWEEN {STEP_LOW} AND {STEP_HIGH}',
 			'fix_collect' => array(
 				'index' => 'id_topic',
-				'process' => function ($topics)
+				'process' => function($topics)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -992,7 +992,7 @@  discard block
 block discarded – undo
 				GROUP BY lt.id_member',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members)
+				'process' => function($members)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1022,7 +1022,7 @@  discard block
 block discarded – undo
 				GROUP BY lb.id_board',
 			'fix_collect' => array(
 				'index' => 'id_board',
-				'process' => function ($boards)
+				'process' => function($boards)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1052,7 +1052,7 @@  discard block
 block discarded – undo
 				GROUP BY lb.id_member',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members) use ($smcFunc)
+				'process' => function($members) use ($smcFunc)
 				{
 					$smcFunc['db_query']('', '
 						DELETE FROM {db_prefix}log_boards
@@ -1081,7 +1081,7 @@  discard block
 block discarded – undo
 				GROUP BY lmr.id_board',
 			'fix_collect' => array(
 				'index' => 'id_board',
-				'process' => function ($boards) use ($smcFunc)
+				'process' => function($boards) use ($smcFunc)
 				{
 					$smcFunc['db_query']('', '
 						DELETE FROM {db_prefix}log_mark_read
@@ -1110,7 +1110,7 @@  discard block
 block discarded – undo
 				GROUP BY lmr.id_member',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members) use ($smcFunc)
+				'process' => function($members) use ($smcFunc)
 				{
 					$smcFunc['db_query']('', '
 						DELETE FROM {db_prefix}log_mark_read
@@ -1139,7 +1139,7 @@  discard block
 block discarded – undo
 				GROUP BY pmr.id_pm',
 			'fix_collect' => array(
 				'index' => 'id_pm',
-				'process' => function ($pms) use ($smcFunc)
+				'process' => function($pms) use ($smcFunc)
 				{
 					$smcFunc['db_query']('', '
 						DELETE FROM {db_prefix}pm_recipients
@@ -1169,7 +1169,7 @@  discard block
 block discarded – undo
 				GROUP BY pmr.id_member',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members)
+				'process' => function($members)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1199,7 +1199,7 @@  discard block
 block discarded – undo
 					AND mem.id_member IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_pm',
-				'process' => function ($guestMessages)
+				'process' => function($guestMessages)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1229,7 +1229,7 @@  discard block
 block discarded – undo
 				GROUP BY ln.id_member',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members) use ($smcFunc)
+				'process' => function($members) use ($smcFunc)
 				{
 					$smcFunc['db_query']('', '
 						DELETE FROM {db_prefix}log_notify
@@ -1256,7 +1256,7 @@  discard block
 block discarded – undo
 					LEFT JOIN {db_prefix}log_search_subjects AS lss ON (lss.id_topic = t.id_topic)
 				WHERE t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
 					AND lss.id_topic IS NULL',
-			'fix_full_processing' => function ($result)
+			'fix_full_processing' => function($result)
 			{
 				global $smcFunc;
 
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
 						array('word', 'id_topic')
 					);
 			},
-			'message_function' => function ($row)
+			'message_function' => function($row)
 			{
 				global $txt, $context;
 
@@ -1313,7 +1313,7 @@  discard block
 block discarded – undo
 					AND t.id_topic IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_topic',
-				'process' => function ($deleteTopics)
+				'process' => function($deleteTopics)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1343,7 +1343,7 @@  discard block
 block discarded – undo
 					AND mem.id_member IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members)
+				'process' => function($members)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1372,7 +1372,7 @@  discard block
 block discarded – undo
 					AND p.id_poll IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_poll',
-				'process' => function ($polls)
+				'process' => function($polls)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1401,7 +1401,7 @@  discard block
 block discarded – undo
 					AND lrc.id_report IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_report',
-				'process' => function ($reports)
+				'process' => function($reports)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1430,7 +1430,7 @@  discard block
 block discarded – undo
 					AND lr.id_report IS NULL',
 			'fix_collect' => array(
 				'index' => 'id_report',
-				'process' => function ($reports)
+				'process' => function($reports)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1460,7 +1460,7 @@  discard block
 block discarded – undo
 				GROUP BY lgr.id_member',
 			'fix_collect' => array(
 				'index' => 'id_member',
-				'process' => function ($members)
+				'process' => function($members)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '
@@ -1490,7 +1490,7 @@  discard block
 block discarded – undo
 				GROUP BY lgr.id_group',
 			'fix_collect' => array(
 				'index' => 'id_group',
-				'process' => function ($groups)
+				'process' => function($groups)
 				{
 					global $smcFunc;
 					$smcFunc['db_query']('', '

Please login to merge, or discard this patch.

Sources/QueryString.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -454,7 +454,7 @@
 block discarded – undo
 			break;
 		}
 		$binMask = str_pad($binMask, 32, '0');
-		$binMask = pack("H*" , $binMask);
+		$binMask = pack("H*", $binMask);
 
 		return ($ip_address & $binMask) == $cidr_network;
 	}

Please login to merge, or discard this patch.

Sources/ManageMaintenance.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -570,7 +570,7 @@  discard block
 block discarded – undo
 				WHERE table_name = {string:cur_table}
 				AND (data_type = \'character varying\' or data_type = \'text\')',
 				array(
-					'cur_table' => $db_prefix.$cur_table,
+					'cur_table' => $db_prefix . $cur_table,
 				)
 			);
 		else
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
 				WHERE  i.indrelid = {string:cur_table}::regclass
 				AND    i.indisprimary',
 				array(
-					'cur_table' => $db_prefix.$cur_table,
+					'cur_table' => $db_prefix . $cur_table,
 				)
 			);
 		else

Please login to merge, or discard this patch.

Sources/Class-SearchAPI.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -223,7 +223,7 @@  discard block
 block discarded – undo
 
 		global $smcFunc;
 
-		$result = $smcFunc['db_query']('','
+		$result = $smcFunc['db_query']('', '
 			SELECT DISTINCT id_search
 			FROM {db_prefix}log_search_results
 			WHERE id_msg = {int:id_msg}',
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
 		if (count($id_searchs) < 1)
 			return;
 
-		$smcFunc['db_query']('','
+		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}log_search_results
 			WHERE id_search in ({array_int:id_searchs})',
 			array(
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
 			)
 		);
 
-		$smcFunc['db_query']('','
+		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}log_search_topics
 			WHERE id_search in ({array_int:id_searchs})',
 			array(
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
 			)
 		);
 
-		$smcFunc['db_query']('','
+		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}log_search_messages
 			WHERE id_search in ({array_int:id_searchs})',
 			array(

Please login to merge, or discard this patch.

		@@ -181,14 +181,14 @@ discard block
		block discarded – undo
181	181	{
182	182	collapsedDiv.show(\'slow\');
183	183	icon.removeClass(\'toggle_down\').addClass(\'toggle_up\');
184		- icon.prop(\'title\', '. JavaScriptEscape($txt['hide']) .');
	184	+ icon.prop(\'title\', '. JavaScriptEscape($txt['hide']) . ');
185	185	}
186	186
187	187	else
188	188	{
189	189	collapsedDiv.hide(\'slow\');
190	190	icon.removeClass(\'toggle_up\').addClass(\'toggle_down\');
191		- icon.prop(\'title\', '. JavaScriptEscape($txt['show']) .');
	191	+ icon.prop(\'title\', '. JavaScriptEscape($txt['show']) . ');
192	192	}
193	193	});', true);
194	194	}
		@@ -641,7 +641,7 @@ discard block
		block discarded – undo
641	641
642	642	// Setup the correct template, even though I'll admit we ain't downloading ;)
643	643	$context['sub_template'] = 'downloaded';
644		- $allowext = array('.zip','.tgz','.gz');
	644	+ $allowext = array('.zip', '.tgz', '.gz');
645	645	// @todo Use FTP if the Packages directory is not writable.
646	646
647	647	// Check the file was even sent!
		@@ -653,13 +653,13 @@ discard block
		block discarded – undo
653	653	// Make sure it has a sane filename.
654	654	$_FILES['package']['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['package']['name']);
655	655	$extension = substr(strrchr(strtolower($_FILES['package']['name']), '.'), 0);
656		- if(!in_array($extension, $allowext))
	656	+ if (!in_array($extension, $allowext))
657	657	{
658	658	fatal_lang_error('package_upload_error_supports', false, array('zip, tgz, tar.gz'));
659	659	}
660	660
661	661	// We only need the filename...
662		- $extension = ($extension == '.gz') ? '.tar.gz' : $extension ;
	662	+ $extension = ($extension == '.gz') ? '.tar.gz' : $extension;
663	663	$packageName = time() . $extension;
664	664
665	665	// Setup the destination and throw an error if the file is already there!

		@@ -570,7 +570,7 @@ discard block
		block discarded – undo
570	570	WHERE table_name = {string:cur_table}
571	571	AND (data_type = \'character varying\' or data_type = \'text\')',
572	572	array(
573		- 'cur_table' => $db_prefix.$cur_table,
	573	+ 'cur_table' => $db_prefix . $cur_table,
574	574	)
575	575	);
576	576	else
		@@ -595,7 +595,7 @@ discard block
		block discarded – undo
595	595	WHERE i.indrelid = {string:cur_table}::regclass
596	596	AND i.indisprimary',
597	597	array(
598		- 'cur_table' => $db_prefix.$cur_table,
	598	+ 'cur_table' => $db_prefix . $cur_table,
599	599	)
600	600	);
601	601	else

		@@ -419,8 +419,8 @@ discard block
		block discarded – undo
419	419	<div class="bar"></div>
420	420	</div>
421	421	<div class="attach-ui">
422		- <a data-dz-remove class="button cancel">', $txt['modify_cancel'] ,'</a>
423		- <a class="button upload">', $txt['upload'] ,'</a>
	422	+ <a data-dz-remove class="button cancel">', $txt['modify_cancel'], '</a>
	423	+ <a class="button upload">', $txt['upload'], '</a>
424	424	</div>
425	425	</div><!-- .attach-info -->
426	426	</div><!-- #au-template -->
		@@ -437,10 +437,10 @@ discard block
		block discarded – undo
437	437	</dt>
438	438	<dd class="smalltext fallback">
439	439	<div id="attachUpload" class="descbox">
440		- <h5>', $txt['attach_drop_zone'] ,'</h5>
441		- <a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'] ,'</a>
442		- <a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'] ,'</a>
443		- <a class="button fileinput-button">', $txt['attach_add'] ,'</a>
	440	+ <h5>', $txt['attach_drop_zone'], '</h5>
	441	+ <a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'], '</a>
	442	+ <a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'], '</a>
	443	+ <a class="button fileinput-button">', $txt['attach_add'], '</a>
444	444	<div id="total-progress" class="progress_bar" role="progressBar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0">
445	445	<div class="bar"></div>
446	446	</div>
		@@ -550,7 +550,7 @@ discard block
		block discarded – undo
550	550	// Option to delete an event if user is editing one.
551	551	if ($context['make_event'] && !$context['event']['new'])
552	552	echo '
553		- <input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">';
	553	+ <input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'], '" class="button you_sure">';
554	554
555	555	echo '
556	556	</span>
		@@ -804,7 +804,7 @@ discard block
		block discarded – undo
804	804	});';
805	805
806	806	echo '
807		- var oEditorID = "', $context['post_box_name'] ,'";
	807	+ var oEditorID = "', $context['post_box_name'], '";
808	808	var oEditorObject = oEditorHandle_', $context['post_box_name'], ';
809	809	</script>';
810	810
		@@ -836,7 +836,7 @@ discard block
		block discarded – undo
836	836	if ($context['can_quote'])
837	837	echo '
838	838	<ul class="quickbuttons" id="msg_', $post['id'], '_quote">
839		- <li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'] ,'</a></li>
	839	+ <li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li>
840	840	<li id="post_modify"><a href="#postmodify" onclick="return insertQuoteFast(', $post['id'], ');"><span class="generic_icons quote"></span>', $txt['quote'], '</a></li>
841	841	</ul>';
842	842
		@@ -920,7 +920,7 @@ discard block
		block discarded – undo
920	920	<head>
921	921	<meta charset="', $context['character_set'], '">
922	922	<title>', $txt['spell_check'], '</title>
923		- <link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'] ,'">
	923	+ <link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'], '">
924	924	<style>
925	925	body, td {
926	926	font-size: small;
		@@ -950,8 +950,8 @@ discard block
		block discarded – undo
950	950	var spell_formname = window.opener.spell_formname;
951	951	var spell_fieldname = window.opener.spell_fieldname;
952	952	</script>
953		- <script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'] ,'"></script>
954		- <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script>
	953	+ <script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'], '"></script>
	954	+ <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script>
955	955	<script>
956	956	', $context['spell_js'], '
957	957	</script>
		@@ -995,7 +995,7 @@ discard block
		block discarded – undo
995	995	<head>
996	996	<meta charset="', $context['character_set'], '">
997	997	<title>', $txt['retrieving_quote'], '</title>
998		- <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script>
	998	+ <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script>
999	999	</head>
1000	1000	<body>
1001	1001	', $txt['retrieving_quote'], '

		@@ -70,7 +70,7 @@ discard block
		block discarded – undo
70	70
71	71	echo '
72	72	<div class="main_container">
73		- <div class="cat_bar ', $category['is_collapsed'] ? 'collapsed' : '','" id="category_', $category['id'], '">
	73	+ <div class="cat_bar ', $category['is_collapsed'] ? 'collapsed' : '', '" id="category_', $category['id'], '">
74	74	<h3 class="catbg">';
75	75
76	76	// If this category even can collapse, show a link to collapse it.
		@@ -249,7 +249,7 @@ discard block
		block discarded – undo
249	249	foreach ($board['children'] as $child)
250	250	{
251	251	if (!$child['is_redirect'])
252		- $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>';
	252	+ $child['link'] = '' . ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>';
253	253	else
254	254	$child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>';
255	255

		@@ -1256,7 +1256,7 @@ discard block
		block discarded – undo
1256	1256	);
1257	1257	if (empty($value))
1258	1258	{
1259		- $deletes = array('id_theme' => 1 , 'variable' => $row['col_name'], 'id_member' => $memID);
	1259	+ $deletes = array('id_theme' => 1, 'variable' => $row['col_name'], 'id_member' => $memID);
1260	1260	unset($user_profile[$memID]['options'][$row['col_name']]);
1261	1261	}
1262	1262	else
		@@ -1284,7 +1284,7 @@ discard block
		block discarded – undo
1284	1284	array('id_theme', 'variable', 'id_member')
1285	1285	);
1286	1286	if (!empty($deletes))
1287		- $smcFunc['db_query']('','
	1287	+ $smcFunc['db_query']('', '
1288	1288	DELETE FROM {db_prefix}themes
1289	1289	WHERE id_theme = {int:id_theme} AND
1290	1290	variable = {string:variable} AND

		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	}
137	137	if ($c === $n) {
138	138	$q = $delta;
139		- for ($k = static::BASE;; $k += static::BASE) {
	139	+ for ($k = static::BASE; ; $k += static::BASE) {
140	140	$t = $this->calculateThreshold($k, $bias);
141	141	if ($q < $t) {
142	142	break;
		@@ -224,7 +224,7 @@ discard block
		block discarded – undo
224	224	$oldi = $i;
225	225	$w = 1;
226	226
227		- for ($k = static::BASE;; $k += static::BASE) {
	227	+ for ($k = static::BASE; ; $k += static::BASE) {
228	228	$digit = static::$decodeTable[$input[$pos++]];
229	229	$i = $i + ($digit * $w);
230	230	$t = $this->calculateThreshold($k, $bias);

		@@ -232,7 +232,7 @@ discard block
		block discarded – undo
232	232	LEFT JOIN {db_prefix}topics AS t ON (t.id_topic = m.id_topic)
233	233	WHERE t.id_topic IS NULL
234	234	GROUP BY m.id_topic, m.id_board',
235		- 'fix_processing' => function ($row) use ($smcFunc)
	235	+ 'fix_processing' => function($row) use ($smcFunc)
236	236	{
237	237	global $salvageBoardID;
238	238
		@@ -318,7 +318,7 @@ discard block
		block discarded – undo
318	318	// Remove all topics that have zero messages in the messages table.
319	319	'fix_collect' => array(
320	320	'index' => 'id_topic',
321		- 'process' => function ($topics) use ($smcFunc)
	321	+ 'process' => function($topics) use ($smcFunc)
322	322	{
323	323	$smcFunc['db_query']('', '
324	324	DELETE FROM {db_prefix}topics
		@@ -355,7 +355,7 @@ discard block
		block discarded – undo
355	355	AND p.id_poll IS NULL
356	356	GROUP BY o.id_poll, t.id_topic, t.id_board, t.id_member_started, m.member_name
357	357	',
358		- 'fix_processing' => function ($row) use ($smcFunc, $txt)
	358	+ 'fix_processing' => function($row) use ($smcFunc, $txt)
359	359	{
360	360	global $salvageBoardID;
361	361
		@@ -366,7 +366,7 @@ discard block
		block discarded – undo
366	366	{
367	367	// Only if we don't have a reasonable idea of where to put it.
368	368	createSalvageArea();
369		- $row['id_board'] = (int)$salvageBoardID;
	369	+ $row['id_board'] = (int) $salvageBoardID;
370	370	}
371	371
372	372	if (empty($row['id_topic']))
		@@ -492,7 +492,7 @@ discard block
		block discarded – undo
492	492	LEFT JOIN {db_prefix}topics AS t ON (t.id_poll = p.id_poll)
493	493	WHERE p.id_poll BETWEEN {STEP_LOW} AND {STEP_HIGH}
494	494	AND t.id_poll IS NULL',
495		- 'fix_processing' => function ($row) use ($smcFunc, $txt)
	495	+ 'fix_processing' => function($row) use ($smcFunc, $txt)
496	496	{
497	497	global $salvageBoardID;
498	498
		@@ -603,7 +603,7 @@ discard block
		block discarded – undo
603	603	WHERE t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
604	604	GROUP BY t.id_topic, t.id_first_msg, t.id_last_msg, t.approved, mf.approved
605	605	ORDER BY t.id_topic',
606		- 'fix_processing' => function ($row) use ($smcFunc)
	606	+ 'fix_processing' => function($row) use ($smcFunc)
607	607	{
608	608	$row['firstmsg_approved'] = (int) $row['firstmsg_approved'];
609	609	$row['myid_first_msg'] = (int) $row['myid_first_msg'];
		@@ -632,7 +632,7 @@ discard block
		block discarded – undo
632	632	)
633	633	);
634	634	},
635		- 'message_function' => function ($row) use ($txt, &$context)
	635	+ 'message_function' => function($row) use ($txt, &$context)
636	636	{
637	637	// A pretend error?
638	638	if ($row['id_first_msg'] == $row['myid_first_msg'] && $row['id_last_msg'] == $row['myid_last_msg'] && $row['approved'] == $row['firstmsg_approved'])
		@@ -666,7 +666,7 @@ discard block
		block discarded – undo
666	666	WHERE t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
667	667	GROUP BY t.id_topic, t.num_replies, mf.approved
668	668	ORDER BY t.id_topic',
669		- 'fix_processing' => function ($row)
	669	+ 'fix_processing' => function($row)
670	670	{
671	671	global $smcFunc;
672	672	$row['my_num_replies'] = (int) $row['my_num_replies'];
		@@ -685,7 +685,7 @@ discard block
		block discarded – undo
685	685	)
686	686	);
687	687	},
688		- 'message_function' => function ($row)
	688	+ 'message_function' => function($row)
689	689	{
690	690	global $txt, $context;
691	691
		@@ -716,7 +716,7 @@ discard block
		block discarded – undo
716	716	GROUP BY t.id_topic, t.unapproved_posts
717	717	HAVING unapproved_posts != COUNT(mu.id_msg)
718	718	ORDER BY t.id_topic',
719		- 'fix_processing' => function ($row)
	719	+ 'fix_processing' => function($row)
720	720	{
721	721	global $smcFunc;
722	722	$row['my_unapproved_posts'] = (int) $row['my_unapproved_posts'];
		@@ -756,7 +756,7 @@ discard block
		block discarded – undo
756	756	WHERE b.id_board IS NULL
757	757	AND t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
758	758	GROUP BY t.id_board',
759		- 'fix_processing' => function ($row)
	759	+ 'fix_processing' => function($row)
760	760	{
761	761	global $smcFunc, $salvageCatID, $txt;
762	762	createSalvageArea();
		@@ -803,7 +803,7 @@ discard block
		block discarded – undo
803	803	ORDER BY b.id_cat, b.id_board',
804	804	'fix_collect' => array(
805	805	'index' => 'id_cat',
806		- 'process' => function ($cats)
	806	+ 'process' => function($cats)
807	807	{
808	808	global $smcFunc, $salvageCatID;
809	809	createSalvageArea();
		@@ -839,7 +839,7 @@ discard block
		block discarded – undo
839	839	// Last step-make sure all non-guest posters still exist.
840	840	'fix_collect' => array(
841	841	'index' => 'id_msg',
842		- 'process' => function ($msgs)
	842	+ 'process' => function($msgs)
843	843	{
844	844	global $smcFunc;
845	845	$smcFunc['db_query']('', '
		@@ -866,7 +866,7 @@ discard block
		block discarded – undo
866	866	ORDER BY b.id_parent, b.id_board',
867	867	'fix_collect' => array(
868	868	'index' => 'id_parent',
869		- 'process' => function ($parents)
	869	+ 'process' => function($parents)
870	870	{
871	871	global $smcFunc, $salvageBoardID, $salvageCatID;
872	872	createSalvageArea();
		@@ -900,7 +900,7 @@ discard block
		block discarded – undo
900	900	AND p.id_poll IS NULL',
901	901	'fix_collect' => array(
902	902	'index' => 'id_poll',
903		- 'process' => function ($polls)
	903	+ 'process' => function($polls)
904	904	{
905	905	global $smcFunc;
906	906	$smcFunc['db_query']('', '
		@@ -932,7 +932,7 @@ discard block
		block discarded – undo
932	932	ORDER BY cal.id_topic',
933	933	'fix_collect' => array(
934	934	'index' => 'id_topic',
935		- 'process' => function ($events)
	935	+ 'process' => function($events)
936	936	{
937	937	global $smcFunc;
938	938	$smcFunc['db_query']('', '
		@@ -962,7 +962,7 @@ discard block
		block discarded – undo
962	962	AND lt.id_member BETWEEN {STEP_LOW} AND {STEP_HIGH}',
963	963	'fix_collect' => array(
964	964	'index' => 'id_topic',
965		- 'process' => function ($topics)
	965	+ 'process' => function($topics)
966	966	{
967	967	global $smcFunc;
968	968	$smcFunc['db_query']('', '
		@@ -992,7 +992,7 @@ discard block
		block discarded – undo
992	992	GROUP BY lt.id_member',
993	993	'fix_collect' => array(
994	994	'index' => 'id_member',
995		- 'process' => function ($members)
	995	+ 'process' => function($members)
996	996	{
997	997	global $smcFunc;
998	998	$smcFunc['db_query']('', '
		@@ -1022,7 +1022,7 @@ discard block
		block discarded – undo
1022	1022	GROUP BY lb.id_board',
1023	1023	'fix_collect' => array(
1024	1024	'index' => 'id_board',
1025		- 'process' => function ($boards)
	1025	+ 'process' => function($boards)
1026	1026	{
1027	1027	global $smcFunc;
1028	1028	$smcFunc['db_query']('', '
		@@ -1052,7 +1052,7 @@ discard block
		block discarded – undo
1052	1052	GROUP BY lb.id_member',
1053	1053	'fix_collect' => array(
1054	1054	'index' => 'id_member',
1055		- 'process' => function ($members) use ($smcFunc)
	1055	+ 'process' => function($members) use ($smcFunc)
1056	1056	{
1057	1057	$smcFunc['db_query']('', '
1058	1058	DELETE FROM {db_prefix}log_boards
		@@ -1081,7 +1081,7 @@ discard block
		block discarded – undo
1081	1081	GROUP BY lmr.id_board',
1082	1082	'fix_collect' => array(
1083	1083	'index' => 'id_board',
1084		- 'process' => function ($boards) use ($smcFunc)
	1084	+ 'process' => function($boards) use ($smcFunc)
1085	1085	{
1086	1086	$smcFunc['db_query']('', '
1087	1087	DELETE FROM {db_prefix}log_mark_read
		@@ -1110,7 +1110,7 @@ discard block
		block discarded – undo
1110	1110	GROUP BY lmr.id_member',
1111	1111	'fix_collect' => array(
1112	1112	'index' => 'id_member',
1113		- 'process' => function ($members) use ($smcFunc)
	1113	+ 'process' => function($members) use ($smcFunc)
1114	1114	{
1115	1115	$smcFunc['db_query']('', '
1116	1116	DELETE FROM {db_prefix}log_mark_read
		@@ -1139,7 +1139,7 @@ discard block
		block discarded – undo
1139	1139	GROUP BY pmr.id_pm',
1140	1140	'fix_collect' => array(
1141	1141	'index' => 'id_pm',
1142		- 'process' => function ($pms) use ($smcFunc)
	1142	+ 'process' => function($pms) use ($smcFunc)
1143	1143	{
1144	1144	$smcFunc['db_query']('', '
1145	1145	DELETE FROM {db_prefix}pm_recipients
		@@ -1169,7 +1169,7 @@ discard block
		block discarded – undo
1169	1169	GROUP BY pmr.id_member',
1170	1170	'fix_collect' => array(
1171	1171	'index' => 'id_member',
1172		- 'process' => function ($members)
	1172	+ 'process' => function($members)
1173	1173	{
1174	1174	global $smcFunc;
1175	1175	$smcFunc['db_query']('', '
		@@ -1199,7 +1199,7 @@ discard block
		block discarded – undo
1199	1199	AND mem.id_member IS NULL',
1200	1200	'fix_collect' => array(
1201	1201	'index' => 'id_pm',
1202		- 'process' => function ($guestMessages)
	1202	+ 'process' => function($guestMessages)
1203	1203	{
1204	1204	global $smcFunc;
1205	1205	$smcFunc['db_query']('', '
		@@ -1229,7 +1229,7 @@ discard block
		block discarded – undo
1229	1229	GROUP BY ln.id_member',
1230	1230	'fix_collect' => array(
1231	1231	'index' => 'id_member',
1232		- 'process' => function ($members) use ($smcFunc)
	1232	+ 'process' => function($members) use ($smcFunc)
1233	1233	{
1234	1234	$smcFunc['db_query']('', '
1235	1235	DELETE FROM {db_prefix}log_notify
		@@ -1256,7 +1256,7 @@ discard block
		block discarded – undo
1256	1256	LEFT JOIN {db_prefix}log_search_subjects AS lss ON (lss.id_topic = t.id_topic)
1257	1257	WHERE t.id_topic BETWEEN {STEP_LOW} AND {STEP_HIGH}
1258	1258	AND lss.id_topic IS NULL',
1259		- 'fix_full_processing' => function ($result)
	1259	+ 'fix_full_processing' => function($result)
1260	1260	{
1261	1261	global $smcFunc;
1262	1262
		@@ -1285,7 +1285,7 @@ discard block
		block discarded – undo
1285	1285	array('word', 'id_topic')
1286	1286	);
1287	1287	},
1288		- 'message_function' => function ($row)
	1288	+ 'message_function' => function($row)
1289	1289	{
1290	1290	global $txt, $context;
1291	1291
		@@ -1313,7 +1313,7 @@ discard block
		block discarded – undo
1313	1313	AND t.id_topic IS NULL',
1314	1314	'fix_collect' => array(
1315	1315	'index' => 'id_topic',
1316		- 'process' => function ($deleteTopics)
	1316	+ 'process' => function($deleteTopics)
1317	1317	{
1318	1318	global $smcFunc;
1319	1319	$smcFunc['db_query']('', '
		@@ -1343,7 +1343,7 @@ discard block
		block discarded – undo
1343	1343	AND mem.id_member IS NULL',
1344	1344	'fix_collect' => array(
1345	1345	'index' => 'id_member',
1346		- 'process' => function ($members)
	1346	+ 'process' => function($members)
1347	1347	{
1348	1348	global $smcFunc;
1349	1349	$smcFunc['db_query']('', '
		@@ -1372,7 +1372,7 @@ discard block
		block discarded – undo
1372	1372	AND p.id_poll IS NULL',
1373	1373	'fix_collect' => array(
1374	1374	'index' => 'id_poll',
1375		- 'process' => function ($polls)
	1375	+ 'process' => function($polls)
1376	1376	{
1377	1377	global $smcFunc;
1378	1378	$smcFunc['db_query']('', '
		@@ -1401,7 +1401,7 @@ discard block
		block discarded – undo
1401	1401	AND lrc.id_report IS NULL',
1402	1402	'fix_collect' => array(
1403	1403	'index' => 'id_report',
1404		- 'process' => function ($reports)
	1404	+ 'process' => function($reports)
1405	1405	{
1406	1406	global $smcFunc;
1407	1407	$smcFunc['db_query']('', '
		@@ -1430,7 +1430,7 @@ discard block
		block discarded – undo
1430	1430	AND lr.id_report IS NULL',
1431	1431	'fix_collect' => array(
1432	1432	'index' => 'id_report',
1433		- 'process' => function ($reports)
	1433	+ 'process' => function($reports)
1434	1434	{
1435	1435	global $smcFunc;
1436	1436	$smcFunc['db_query']('', '
		@@ -1460,7 +1460,7 @@ discard block
		block discarded – undo
1460	1460	GROUP BY lgr.id_member',
1461	1461	'fix_collect' => array(
1462	1462	'index' => 'id_member',
1463		- 'process' => function ($members)
	1463	+ 'process' => function($members)
1464	1464	{
1465	1465	global $smcFunc;
1466	1466	$smcFunc['db_query']('', '
		@@ -1490,7 +1490,7 @@ discard block
		block discarded – undo
1490	1490	GROUP BY lgr.id_group',
1491	1491	'fix_collect' => array(
1492	1492	'index' => 'id_group',
1493		- 'process' => function ($groups)
	1493	+ 'process' => function($groups)
1494	1494	{
1495	1495	global $smcFunc;
1496	1496	$smcFunc['db_query']('', '

		@@ -454,7 +454,7 @@
		block discarded – undo
454	454	break;
455	455	}
456	456	$binMask = str_pad($binMask, 32, '0');
457		- $binMask = pack("H*" , $binMask);
	457	+ $binMask = pack("H*", $binMask);
458	458
459	459	return ($ip_address & $binMask) == $cidr_network;
460	460	}

		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223
224	224	global $smcFunc;
225	225
226		- $result = $smcFunc['db_query']('','
	226	+ $result = $smcFunc['db_query']('', '
227	227	SELECT DISTINCT id_search
228	228	FROM {db_prefix}log_search_results
229	229	WHERE id_msg = {int:id_msg}',
		@@ -239,7 +239,7 @@ discard block
		block discarded – undo
239	239	if (count($id_searchs) < 1)
240	240	return;
241	241
242		- $smcFunc['db_query']('','
	242	+ $smcFunc['db_query']('', '
243	243	DELETE FROM {db_prefix}log_search_results
244	244	WHERE id_search in ({array_int:id_searchs})',
245	245	array(
		@@ -247,7 +247,7 @@ discard block
		block discarded – undo
247	247	)
248	248	);
249	249
250		- $smcFunc['db_query']('','
	250	+ $smcFunc['db_query']('', '
251	251	DELETE FROM {db_prefix}log_search_topics
252	252	WHERE id_search in ({array_int:id_searchs})',
253	253	array(
		@@ -255,7 +255,7 @@ discard block
		block discarded – undo
255	255	)
256	256	);
257	257
258		- $smcFunc['db_query']('','
	258	+ $smcFunc['db_query']('', '
259	259	DELETE FROM {db_prefix}log_search_messages
260	260	WHERE id_search in ({array_int:id_searchs})',
261	261	array(

SimpleMachines / SMF2.1

Push — release-2.1 ( 9fa566...084464 )

Status

Category

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +35 added lines, -35 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch