Completed
Pull Request — release-2.1 (#3807)
by Martyn
07:18
created
Sources/Subs-Sound.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
  * Used by VerificationCode() (Register.php).
25 25
  *
26 26
  * @param string $word
27
- * @return boolean false on failure
27
+ * @return null|false false on failure
28 28
  */
29 29
 
30 30
 function createWaveFile($word)
Please login to merge, or discard this patch.
Braces   +32 added lines, -20 removed lines patch added patch discarded remove patch
@@ -15,8 +15,9 @@  discard block
 block discarded – undo
15 15
  * @version 2.1 Beta 3
16 16
  */
17 17
 
18
-if (!defined('SMF'))
18
+if (!defined('SMF')) {
19 19
 	die('No direct access...');
20
+}
20 21
 
21 22
 /**
22 23
  * Creates a wave file that spells the letters of $word.
@@ -32,8 +33,9 @@  discard block
 block discarded – undo
32 33
 	global $settings, $user_info;
33 34
 
34 35
 	// Allow max 2 requests per 20 seconds.
35
-	if (($ip = cache_get_data('wave_file/' . $user_info['ip'], 20)) > 2 || ($ip2 = cache_get_data('wave_file/' . $user_info['ip2'], 20)) > 2)
36
-		die(header('HTTP/1.1 400 Bad Request'));
36
+	if (($ip = cache_get_data('wave_file/' . $user_info['ip'], 20)) > 2 || ($ip2 = cache_get_data('wave_file/' . $user_info['ip2'], 20)) > 2) {
37
+			die(header('HTTP/1.1 400 Bad Request'));
38
+	}
37 39
 	cache_put_data('wave_file/' . $user_info['ip'], $ip ? $ip + 1 : 1, 20);
38 40
 	cache_put_data('wave_file/' . $user_info['ip2'], $ip2 ? $ip2 + 1 : 1, 20);
39 41
 
@@ -41,16 +43,19 @@  discard block
 block discarded – undo
41 43
 	mt_srand(end(unpack('n', md5($word . session_id()))));
42 44
 
43 45
 	// Try to see if there's a sound font in the user's language.
44
-	if (file_exists($settings['default_theme_dir'] . '/fonts/sound/a.' . $user_info['language'] . '.wav'))
45
-		$sound_language = $user_info['language'];
46
+	if (file_exists($settings['default_theme_dir'] . '/fonts/sound/a.' . $user_info['language'] . '.wav')) {
47
+			$sound_language = $user_info['language'];
48
+	}
46 49
 
47 50
 	// English should be there.
48
-	elseif (file_exists($settings['default_theme_dir'] . '/fonts/sound/a.english.wav'))
49
-		$sound_language = 'english';
51
+	elseif (file_exists($settings['default_theme_dir'] . '/fonts/sound/a.english.wav')) {
52
+			$sound_language = 'english';
53
+	}
50 54
 
51 55
 	// Guess not...
52
-	else
53
-		return false;
56
+	else {
57
+			return false;
58
+	}
54 59
 
55 60
 	// File names are in lower case so lets make sure that we are only using a lower case string
56 61
 	$word = strtolower($word);
@@ -60,20 +65,25 @@  discard block
 block discarded – undo
60 65
 	for ($i = 0; $i < strlen($word); $i++)
61 66
 	{
62 67
 		$sound_letter = implode('', file($settings['default_theme_dir'] . '/fonts/sound/' . $word{$i} . '.' . $sound_language . '.wav'));
63
-		if (strpos($sound_letter, 'data') === false)
64
-			return false;
68
+		if (strpos($sound_letter, 'data') === false) {
69
+					return false;
70
+		}
65 71
 
66 72
 		$sound_letter = substr($sound_letter, strpos($sound_letter, 'data') + 8);
67 73
 		switch ($word{$i} === 's' ? 0 : mt_rand(0, 2))
68 74
 		{
69
-			case 0 : for ($j = 0, $n = strlen($sound_letter); $j < $n; $j++)
70
-					for ($k = 0, $m = round(mt_rand(15, 25) / 10); $k < $m; $k++)
71
-						$sound_word .= $word{$i} === 's' ? $sound_letter{$j} : chr(mt_rand(max(ord($sound_letter{$j}) - 1, 0x00), min(ord($sound_letter{$j}) + 1, 0xFF)));
75
+			case 0 : for ($j = 0, $n = strlen($sound_letter); $j < $n; $j++) {
76
+								for ($k = 0, $m = round(mt_rand(15, 25) / 10);
77
+			}
78
+			$k < $m; $k++) {
79
+											$sound_word .= $word{$i} === 's' ? $sound_letter{$j} : chr(mt_rand(max(ord($sound_letter{$j}) - 1, 0x00), min(ord($sound_letter{$j}) + 1, 0xFF)));
80
+					}
72 81
 			break;
73 82
 
74 83
 			case 1:
75
-				for ($j = 0, $n = strlen($sound_letter) - 1; $j < $n; $j += 2)
76
-					$sound_word .= (mt_rand(0, 3) == 0 ? '' : $sound_letter{$j}) . (mt_rand(0, 3) === 0 ? $sound_letter{$j + 1} : $sound_letter{$j}) . (mt_rand(0, 3) === 0 ? $sound_letter{$j} : $sound_letter{$j + 1}) . $sound_letter{$j + 1} . (mt_rand(0, 3) == 0 ? $sound_letter{$j + 1} : '');
84
+				for ($j = 0, $n = strlen($sound_letter) - 1; $j < $n; $j += 2) {
85
+									$sound_word .= (mt_rand(0, 3) == 0 ? '' : $sound_letter{$j}) . (mt_rand(0, 3) === 0 ? $sound_letter{$j + 1} : $sound_letter{$j}) . (mt_rand(0, 3) === 0 ? $sound_letter{$j} : $sound_letter{$j + 1}) . $sound_letter{$j + 1} . (mt_rand(0, 3) == 0 ? $sound_letter{$j + 1} : '');
86
+				}
77 87
 				$sound_word .= str_repeat($sound_letter{$n}, 2);
78 88
 			break;
79 89
 
@@ -81,10 +91,12 @@  discard block
 block discarded – undo
81 91
 				$shift = 0;
82 92
 				for ($j = 0, $n = strlen($sound_letter); $j < $n; $j++)
83 93
 				{
84
-					if (mt_rand(0, 10) === 0)
85
-						$shift += mt_rand(-3, 3);
86
-					for ($k = 0, $m = round(mt_rand(15, 25) / 10); $k < $m; $k++)
87
-						$sound_word .= chr(min(max(ord($sound_letter{$j}) + $shift, 0x00), 0xFF));
94
+					if (mt_rand(0, 10) === 0) {
95
+											$shift += mt_rand(-3, 3);
96
+					}
97
+					for ($k = 0, $m = round(mt_rand(15, 25) / 10); $k < $m; $k++) {
98
+											$sound_word .= chr(min(max(ord($sound_letter{$j}) + $shift, 0x00), 0xFF));
99
+					}
88 100
 				}
89 101
 			break;
90 102
 
Please login to merge, or discard this patch.
Sources/Subs-Themes.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -425,7 +425,7 @@
 block discarded – undo
425 425
  *
426 426
  * This is a recursive function, it will call itself if there are subdirs inside the main directory.
427 427
  * @param string $path The absolute path to the directory to be removed
428
- * @return bool true when success, false on error.
428
+ * @return false|null true when success, false on error.
429 429
  */
430 430
 function remove_dir($path)
431 431
 {
Please login to merge, or discard this patch.
Braces   +67 added lines, -46 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Gets a single theme's info.
@@ -27,8 +28,9 @@  discard block
 block discarded – undo
27 28
 	global $smcFunc, $modSettings;
28 29
 
29 30
 	// No data, no fun!
30
-	if (empty($id))
31
-		return false;
31
+	if (empty($id)) {
32
+			return false;
33
+	}
32 34
 
33 35
 	// Make sure $id is an int.
34 36
 	$id = (int) $id;
@@ -171,8 +173,9 @@  discard block
 block discarded – undo
171 173
 	global $sourcedir, $forum_version, $txt, $scripturl, $context;
172 174
 	global $explicit_images;
173 175
 
174
-	if (empty($path))
175
-		return false;
176
+	if (empty($path)) {
177
+			return false;
178
+	}
176 179
 
177 180
 	$xml_data = array();
178 181
 	$explicit_images = false;
@@ -229,9 +232,10 @@  discard block
 block discarded – undo
229 232
 	);
230 233
 
231 234
 	// Assign the values to be stored.
232
-	foreach ($xml_elements as $var => $name)
233
-		if (!empty($theme_info_xml[$name]))
235
+	foreach ($xml_elements as $var => $name) {
236
+			if (!empty($theme_info_xml[$name]))
234 237
 			$xml_data[$var] = $theme_info_xml[$name];
238
+	}
235 239
 
236 240
 	// Add the supported versions.
237 241
 	$xml_data['install_for'] = $install_versions;
@@ -243,8 +247,9 @@  discard block
 block discarded – undo
243 247
 		$explicit_images = true;
244 248
 	}
245 249
 
246
-	if (!empty($theme_info_xml['extra']))
247
-		$xml_data += smf_json_decode($theme_info_xml['extra'], true);
250
+	if (!empty($theme_info_xml['extra'])) {
251
+			$xml_data += smf_json_decode($theme_info_xml['extra'], true);
252
+	}
248 253
 
249 254
 	return $xml_data;
250 255
 }
@@ -262,12 +267,14 @@  discard block
 block discarded – undo
262 267
 	global $settings, $explicit_images;
263 268
 
264 269
 	// External use? no problem!
265
-	if ($to_install)
266
-		$context['to_install'] = $to_install;
270
+	if ($to_install) {
271
+			$context['to_install'] = $to_install;
272
+	}
267 273
 
268 274
 	// One last check.
269
-	if (empty($context['to_install']['theme_dir']) || basename($context['to_install']['theme_dir']) == 'Themes')
270
-		fatal_lang_error('theme_install_invalid_dir', false);
275
+	if (empty($context['to_install']['theme_dir']) || basename($context['to_install']['theme_dir']) == 'Themes') {
276
+			fatal_lang_error('theme_install_invalid_dir', false);
277
+	}
271 278
 
272 279
 	// OK, is this a newer version of an already installed theme?
273 280
 	if (!empty($context['to_install']['version']))
@@ -292,8 +299,8 @@  discard block
 block discarded – undo
292 299
 		$smcFunc['db_free_result']($request);
293 300
 
294 301
 		// Got something, lets figure it out what to do next.
295
-		if (!empty($to_update) && !empty($to_update['version']))
296
-			switch (compareVersions($context['to_install']['version'], $to_update['version']))
302
+		if (!empty($to_update) && !empty($to_update['version'])) {
303
+					switch (compareVersions($context['to_install']['version'], $to_update['version']))
297 304
 			{
298 305
 				case 1: // Got a newer version, update the old entry.
299 306
 					$smcFunc['db_query']('', '
@@ -307,6 +314,7 @@  discard block
 block discarded – undo
307 314
 							'id_theme' => $to_update['id_theme'],
308 315
 						)
309 316
 					);
317
+		}
310 318
 
311 319
 					// Done with the update, tell the user about it.
312 320
 					$context['to_install']['updated'] = true;
@@ -372,13 +380,15 @@  discard block
 block discarded – undo
372 380
 				$context['to_install']['base_theme_url'] = $temp['theme_url'];
373 381
 				$context['to_install']['base_theme_dir'] = $temp['theme_dir'];
374 382
 
375
-				if (empty($explicit_images) && !empty($context['to_install']['base_theme_url']))
376
-					$context['to_install']['theme_url'] = $context['to_install']['base_theme_url'];
383
+				if (empty($explicit_images) && !empty($context['to_install']['base_theme_url'])) {
384
+									$context['to_install']['theme_url'] = $context['to_install']['base_theme_url'];
385
+				}
377 386
 			}
378 387
 
379 388
 			// Nope, sorry, couldn't find any theme already installed.
380
-			else
381
-				fatal_lang_error('package_get_error_theme_no_based_on_found', false, $context['to_install']['based_on']);
389
+			else {
390
+							fatal_lang_error('package_get_error_theme_no_based_on_found', false, $context['to_install']['based_on']);
391
+			}
382 392
 		}
383 393
 
384 394
 		unset($context['to_install']['based_on']);
@@ -401,16 +411,18 @@  discard block
 block discarded – undo
401 411
 	call_integration_hook('integrate_theme_install', array(&$context['to_install'], $id_theme));
402 412
 
403 413
 	$inserts = array();
404
-	foreach ($context['to_install'] as $var => $val)
405
-		$inserts[] = array($id_theme, $var, $val);
414
+	foreach ($context['to_install'] as $var => $val) {
415
+			$inserts[] = array($id_theme, $var, $val);
416
+	}
406 417
 
407
-	if (!empty($inserts))
408
-		$smcFunc['db_insert']('insert',
418
+	if (!empty($inserts)) {
419
+			$smcFunc['db_insert']('insert',
409 420
 			'{db_prefix}themes',
410 421
 			array('id_theme' => 'int', 'variable' => 'string-255', 'value' => 'string-65534'),
411 422
 			$inserts,
412 423
 			array('id_theme', 'variable')
413 424
 		);
425
+	}
414 426
 
415 427
 	// Update the known and enable Theme's settings.
416 428
 	$known = strtr($modSettings['knownThemes'] . ',' . $id_theme, array(',,' => ','));
@@ -429,21 +441,24 @@  discard block
 block discarded – undo
429 441
  */
430 442
 function remove_dir($path)
431 443
 {
432
-	if (empty($path))
433
-		return false;
444
+	if (empty($path)) {
445
+			return false;
446
+	}
434 447
 
435 448
 	if (is_dir($path))
436 449
 	{
437 450
 		$objects = scandir($path);
438 451
 
439
-		foreach ($objects as $object)
440
-			if ($object != '.' && $object != '..')
452
+		foreach ($objects as $object) {
453
+					if ($object != '.' && $object != '..')
441 454
 			{
442 455
 				if (filetype($path . '/' . $object) == 'dir')
443 456
 					remove_dir($path . '/' . $object);
457
+		}
444 458
 
445
-				else
446
-					unlink($path . '/' . $object);
459
+				else {
460
+									unlink($path . '/' . $object);
461
+				}
447 462
 			}
448 463
 	}
449 464
 
@@ -462,8 +477,9 @@  discard block
 block discarded – undo
462 477
 	global $smcFunc, $modSettings;
463 478
 
464 479
 	// Can't delete the default theme, sorry!
465
-	if (empty($themeID) || $themeID == 1)
466
-		return false;
480
+	if (empty($themeID) || $themeID == 1) {
481
+			return false;
482
+	}
467 483
 
468 484
 	$known = explode(',', $modSettings['knownThemes']);
469 485
 	$enable = explode(',', $modSettings['enableThemes']);
@@ -513,8 +529,9 @@  discard block
 block discarded – undo
513 529
 	updateSettings(array('enableThemes' => $enable, 'knownThemes' => $known));
514 530
 
515 531
 	// Fix it if the theme was the overall default theme.
516
-	if ($modSettings['theme_guests'] == $themeID)
517
-		updateSettings(array('theme_guests' => '1'));
532
+	if ($modSettings['theme_guests'] == $themeID) {
533
+			updateSettings(array('theme_guests' => '1'));
534
+	}
518 535
 
519 536
 	return true;
520 537
 }
@@ -531,13 +548,15 @@  discard block
 block discarded – undo
531 548
 	global $scripturl, $txt, $context;
532 549
 
533 550
 	// Is it even a directory?
534
-	if (!is_dir($path))
535
-		fatal_lang_error('error_invalid_dir', 'critical');
551
+	if (!is_dir($path)) {
552
+			fatal_lang_error('error_invalid_dir', 'critical');
553
+	}
536 554
 
537 555
 	$dir = dir($path);
538 556
 	$entries = array();
539
-	while ($entry = $dir->read())
540
-		$entries[] = $entry;
557
+	while ($entry = $dir->read()) {
558
+			$entries[] = $entry;
559
+	}
541 560
 	$dir->close();
542 561
 
543 562
 	natcasesort($entries);
@@ -548,11 +567,12 @@  discard block
 block discarded – undo
548 567
 	foreach ($entries as $entry)
549 568
 	{
550 569
 		// Skip all dot files, including .htaccess.
551
-		if (substr($entry, 0, 1) == '.' || $entry == 'CVS')
552
-			continue;
570
+		if (substr($entry, 0, 1) == '.' || $entry == 'CVS') {
571
+					continue;
572
+		}
553 573
 
554
-		if (is_dir($path . '/' . $entry))
555
-			$listing1[] = array(
574
+		if (is_dir($path . '/' . $entry)) {
575
+					$listing1[] = array(
556 576
 				'filename' => $entry,
557 577
 				'is_writable' => is_writable($path . '/' . $entry),
558 578
 				'is_directory' => true,
@@ -562,13 +582,14 @@  discard block
 block discarded – undo
562 582
 				'href' => $scripturl . '?action=admin;area=theme;th=' . $_GET['th'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=edit;directory=' . $relative . $entry,
563 583
 				'size' => '',
564 584
 			);
565
-		else
585
+		} else
566 586
 		{
567 587
 			$size = filesize($path . '/' . $entry);
568
-			if ($size > 2048 || $size == 1024)
569
-				$size = comma_format($size / 1024) . ' ' . $txt['themeadmin_edit_kilobytes'];
570
-			else
571
-				$size = comma_format($size) . ' ' . $txt['themeadmin_edit_bytes'];
588
+			if ($size > 2048 || $size == 1024) {
589
+							$size = comma_format($size / 1024) . ' ' . $txt['themeadmin_edit_kilobytes'];
590
+			} else {
591
+							$size = comma_format($size) . ' ' . $txt['themeadmin_edit_bytes'];
592
+			}
572 593
 
573 594
 			$listing2[] = array(
574 595
 				'filename' => $entry,
Please login to merge, or discard this patch.
Sources/Subs.php 4 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
  * - caches the formatting data from the setting for optimization.
677 677
  *
678 678
  * @param float $number A number
679
- * @param bool|int $override_decimal_count If set, will use the specified number of decimal places. Otherwise it's automatically determined
679
+ * @param integer $override_decimal_count If set, will use the specified number of decimal places. Otherwise it's automatically determined
680 680
  * @return string A formatted number
681 681
  */
682 682
 function comma_format($number, $override_decimal_count = false)
@@ -4987,7 +4987,7 @@  discard block
 block discarded – undo
4987 4987
 
4988 4988
 /**
4989 4989
  * @param string $ip_address An IP address in IPv4, IPv6 or decimal notation
4990
- * @return binary The IP address in binary or false
4990
+ * @return string The IP address in binary or false
4991 4991
  */
4992 4992
 function inet_ptod($ip_address)
4993 4993
 {
@@ -5385,7 +5385,7 @@  discard block
 block discarded – undo
5385 5385
  * It assumes the data is already a string.
5386 5386
  * @param string $data The data to print
5387 5387
  * @param string $type The content type. Defaults to Json.
5388
- * @return void
5388
+ * @return false|null
5389 5389
  */
5390 5390
 function smf_serverResponse($data = '', $type = 'Content-Type: application/json')
5391 5391
 {
Please login to merge, or discard this patch.
Indentation   -2 removed lines patch added patch discarded remove patch
@@ -5265,7 +5265,6 @@  discard block
 block discarded – undo
5265 5265
 
5266 5266
 /**
5267 5267
  * Tries different modes to make file/dirs writable. Wrapper function for chmod()
5268
-
5269 5268
  * @param string $file The file/dir full path.
5270 5269
  * @param int $value Not needed, added for legacy reasons.
5271 5270
  * @return boolean  true if the file/dir is already writable or the function was able to make it writable, false if the function couldn't make the file/dir writable.
@@ -5305,7 +5304,6 @@  discard block
 block discarded – undo
5305 5304
 
5306 5305
 /**
5307 5306
  * Wrapper function for json_decode() with error handling.
5308
-
5309 5307
  * @param string $json The string to decode.
5310 5308
  * @param bool $returnAsArray To return the decoded string as an array or an object, SMF only uses Arrays but to keep on compatibility with json_decode its set to false as default.
5311 5309
  * @param bool $logIt To specify if the error will be logged if theres any.
Please login to merge, or discard this patch.
Braces   +1279 added lines, -950 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Update some basic statistics.
@@ -122,10 +123,11 @@  discard block
 block discarded – undo
122 123
 						$smcFunc['db_free_result']($result);
123 124
 
124 125
 						// Add this to the number of unapproved members
125
-						if (!empty($changes['unapprovedMembers']))
126
-							$changes['unapprovedMembers'] += $coppa_approvals;
127
-						else
128
-							$changes['unapprovedMembers'] = $coppa_approvals;
126
+						if (!empty($changes['unapprovedMembers'])) {
127
+													$changes['unapprovedMembers'] += $coppa_approvals;
128
+						} else {
129
+													$changes['unapprovedMembers'] = $coppa_approvals;
130
+						}
129 131
 					}
130 132
 				}
131 133
 			}
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 			break;
134 136
 
135 137
 		case 'message':
136
-			if ($parameter1 === true && $parameter2 !== null)
137
-				updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
138
-			else
138
+			if ($parameter1 === true && $parameter2 !== null) {
139
+							updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
140
+			} else
139 141
 			{
140 142
 				// SUM and MAX on a smaller table is better for InnoDB tables.
141 143
 				$result = $smcFunc['db_query']('', '
@@ -175,23 +177,25 @@  discard block
 block discarded – undo
175 177
 				$parameter2 = text2words($parameter2);
176 178
 
177 179
 				$inserts = array();
178
-				foreach ($parameter2 as $word)
179
-					$inserts[] = array($word, $parameter1);
180
+				foreach ($parameter2 as $word) {
181
+									$inserts[] = array($word, $parameter1);
182
+				}
180 183
 
181
-				if (!empty($inserts))
182
-					$smcFunc['db_insert']('ignore',
184
+				if (!empty($inserts)) {
185
+									$smcFunc['db_insert']('ignore',
183 186
 						'{db_prefix}log_search_subjects',
184 187
 						array('word' => 'string', 'id_topic' => 'int'),
185 188
 						$inserts,
186 189
 						array('word', 'id_topic')
187 190
 					);
191
+				}
188 192
 			}
189 193
 			break;
190 194
 
191 195
 		case 'topic':
192
-			if ($parameter1 === true)
193
-				updateSettings(array('totalTopics' => true), true);
194
-			else
196
+			if ($parameter1 === true) {
197
+							updateSettings(array('totalTopics' => true), true);
198
+			} else
195 199
 			{
196 200
 				// Get the number of topics - a SUM is better for InnoDB tables.
197 201
 				// We also ignore the recycle bin here because there will probably be a bunch of one-post topics there.
@@ -212,8 +216,9 @@  discard block
 block discarded – undo
212 216
 
213 217
 		case 'postgroups':
214 218
 			// Parameter two is the updated columns: we should check to see if we base groups off any of these.
215
-			if ($parameter2 !== null && !in_array('posts', $parameter2))
216
-				return;
219
+			if ($parameter2 !== null && !in_array('posts', $parameter2)) {
220
+							return;
221
+			}
217 222
 
218 223
 			$postgroups = cache_get_data('updateStats:postgroups', 360);
219 224
 			if ($postgroups == null || $parameter1 == null)
@@ -228,8 +233,9 @@  discard block
 block discarded – undo
228 233
 					)
229 234
 				);
230 235
 				$postgroups = array();
231
-				while ($row = $smcFunc['db_fetch_assoc']($request))
232
-					$postgroups[$row['id_group']] = $row['min_posts'];
236
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
237
+									$postgroups[$row['id_group']] = $row['min_posts'];
238
+				}
233 239
 				$smcFunc['db_free_result']($request);
234 240
 
235 241
 				// Sort them this way because if it's done with MySQL it causes a filesort :(.
@@ -239,8 +245,9 @@  discard block
 block discarded – undo
239 245
 			}
240 246
 
241 247
 			// Oh great, they've screwed their post groups.
242
-			if (empty($postgroups))
243
-				return;
248
+			if (empty($postgroups)) {
249
+							return;
250
+			}
244 251
 
245 252
 			// Set all membergroups from most posts to least posts.
246 253
 			$conditions = '';
@@ -298,10 +305,9 @@  discard block
 block discarded – undo
298 305
 	{
299 306
 		$condition = 'id_member IN ({array_int:members})';
300 307
 		$parameters['members'] = $members;
301
-	}
302
-	elseif ($members === null)
303
-		$condition = '1=1';
304
-	else
308
+	} elseif ($members === null) {
309
+			$condition = '1=1';
310
+	} else
305 311
 	{
306 312
 		$condition = 'id_member = {int:member}';
307 313
 		$parameters['member'] = $members;
@@ -341,9 +347,9 @@  discard block
 block discarded – undo
341 347
 		if (count($vars_to_integrate) != 0)
342 348
 		{
343 349
 			// Fetch a list of member_names if necessary
344
-			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members)))
345
-				$member_names = array($user_info['username']);
346
-			else
350
+			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) {
351
+							$member_names = array($user_info['username']);
352
+			} else
347 353
 			{
348 354
 				$member_names = array();
349 355
 				$request = $smcFunc['db_query']('', '
@@ -352,14 +358,16 @@  discard block
 block discarded – undo
352 358
 					WHERE ' . $condition,
353 359
 					$parameters
354 360
 				);
355
-				while ($row = $smcFunc['db_fetch_assoc']($request))
356
-					$member_names[] = $row['member_name'];
361
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
362
+									$member_names[] = $row['member_name'];
363
+				}
357 364
 				$smcFunc['db_free_result']($request);
358 365
 			}
359 366
 
360
-			if (!empty($member_names))
361
-				foreach ($vars_to_integrate as $var)
367
+			if (!empty($member_names)) {
368
+							foreach ($vars_to_integrate as $var)
362 369
 					call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats));
370
+			}
363 371
 		}
364 372
 	}
365 373
 
@@ -367,16 +375,17 @@  discard block
 block discarded – undo
367 375
 	foreach ($data as $var => $val)
368 376
 	{
369 377
 		$type = 'string';
370
-		if (in_array($var, $knownInts))
371
-			$type = 'int';
372
-		elseif (in_array($var, $knownFloats))
373
-			$type = 'float';
374
-		elseif ($var == 'birthdate')
375
-			$type = 'date';
376
-		elseif ($var == 'member_ip')
377
-			$type = 'inet';
378
-		elseif ($var == 'member_ip2')
379
-			$type = 'inet';
378
+		if (in_array($var, $knownInts)) {
379
+					$type = 'int';
380
+		} elseif (in_array($var, $knownFloats)) {
381
+					$type = 'float';
382
+		} elseif ($var == 'birthdate') {
383
+					$type = 'date';
384
+		} elseif ($var == 'member_ip') {
385
+					$type = 'inet';
386
+		} elseif ($var == 'member_ip2') {
387
+					$type = 'inet';
388
+		}
380 389
 
381 390
 		// Doing an increment?
382 391
 		if ($type == 'int' && ($val === '+' || $val === '-'))
@@ -390,8 +399,9 @@  discard block
 block discarded – undo
390 399
 		{
391 400
 			if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match))
392 401
 			{
393
-				if ($match[1] != '+ ')
394
-					$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
402
+				if ($match[1] != '+ ') {
403
+									$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
404
+				}
395 405
 				$type = 'raw';
396 406
 			}
397 407
 		}
@@ -412,8 +422,9 @@  discard block
 block discarded – undo
412 422
 	// Clear any caching?
413 423
 	if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members))
414 424
 	{
415
-		if (!is_array($members))
416
-			$members = array($members);
425
+		if (!is_array($members)) {
426
+					$members = array($members);
427
+		}
417 428
 
418 429
 		foreach ($members as $member)
419 430
 		{
@@ -446,29 +457,32 @@  discard block
 block discarded – undo
446 457
 {
447 458
 	global $modSettings, $smcFunc;
448 459
 
449
-	if (empty($changeArray) || !is_array($changeArray))
450
-		return;
460
+	if (empty($changeArray) || !is_array($changeArray)) {
461
+			return;
462
+	}
451 463
 
452 464
 	$toRemove = array();
453 465
 
454 466
 	// Go check if there is any setting to be removed.
455
-	foreach ($changeArray as $k => $v)
456
-		if ($v === null)
467
+	foreach ($changeArray as $k => $v) {
468
+			if ($v === null)
457 469
 		{
458 470
 			// Found some, remove them from the original array and add them to ours.
459 471
 			unset($changeArray[$k]);
472
+	}
460 473
 			$toRemove[] = $k;
461 474
 		}
462 475
 
463 476
 	// Proceed with the deletion.
464
-	if (!empty($toRemove))
465
-		$smcFunc['db_query']('', '
477
+	if (!empty($toRemove)) {
478
+			$smcFunc['db_query']('', '
466 479
 			DELETE FROM {db_prefix}settings
467 480
 			WHERE variable IN ({array_string:remove})',
468 481
 			array(
469 482
 				'remove' => $toRemove,
470 483
 			)
471 484
 		);
485
+	}
472 486
 
473 487
 	// In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs.
474 488
 	if ($update)
@@ -497,19 +511,22 @@  discard block
 block discarded – undo
497 511
 	foreach ($changeArray as $variable => $value)
498 512
 	{
499 513
 		// Don't bother if it's already like that ;).
500
-		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value)
501
-			continue;
514
+		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) {
515
+					continue;
516
+		}
502 517
 		// If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it.
503
-		elseif (!isset($modSettings[$variable]) && empty($value))
504
-			continue;
518
+		elseif (!isset($modSettings[$variable]) && empty($value)) {
519
+					continue;
520
+		}
505 521
 
506 522
 		$replaceArray[] = array($variable, $value);
507 523
 
508 524
 		$modSettings[$variable] = $value;
509 525
 	}
510 526
 
511
-	if (empty($replaceArray))
512
-		return;
527
+	if (empty($replaceArray)) {
528
+			return;
529
+	}
513 530
 
514 531
 	$smcFunc['db_insert']('replace',
515 532
 		'{db_prefix}settings',
@@ -555,14 +572,17 @@  discard block
 block discarded – undo
555 572
 	$start_invalid = $start < 0;
556 573
 
557 574
 	// Make sure $start is a proper variable - not less than 0.
558
-	if ($start_invalid)
559
-		$start = 0;
575
+	if ($start_invalid) {
576
+			$start = 0;
577
+	}
560 578
 	// Not greater than the upper bound.
561
-	elseif ($start >= $max_value)
562
-		$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
579
+	elseif ($start >= $max_value) {
580
+			$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
581
+	}
563 582
 	// And it has to be a multiple of $num_per_page!
564
-	else
565
-		$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
583
+	else {
584
+			$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
585
+	}
566 586
 
567 587
 	$context['current_page'] = $start / $num_per_page;
568 588
 
@@ -592,77 +612,87 @@  discard block
 block discarded – undo
592 612
 
593 613
 		// Show all the pages.
594 614
 		$display_page = 1;
595
-		for ($counter = 0; $counter < $max_value; $counter += $num_per_page)
596
-			$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
615
+		for ($counter = 0; $counter < $max_value; $counter += $num_per_page) {
616
+					$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
617
+		}
597 618
 
598 619
 		// Show the right arrow.
599 620
 		$display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page);
600
-		if ($start != $counter - $max_value && !$start_invalid)
601
-			$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
602
-	}
603
-	else
621
+		if ($start != $counter - $max_value && !$start_invalid) {
622
+					$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
623
+		}
624
+	} else
604 625
 	{
605 626
 		// If they didn't enter an odd value, pretend they did.
606 627
 		$PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2;
607 628
 
608 629
 		// Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page)
609
-		if (!empty($start) && $show_prevnext)
610
-			$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
611
-		else
612
-			$pageindex .= '';
630
+		if (!empty($start) && $show_prevnext) {
631
+					$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
632
+		} else {
633
+					$pageindex .= '';
634
+		}
613 635
 
614 636
 		// Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15)
615
-		if ($start > $num_per_page * $PageContiguous)
616
-			$pageindex .= sprintf($base_link, 0, '1');
637
+		if ($start > $num_per_page * $PageContiguous) {
638
+					$pageindex .= sprintf($base_link, 0, '1');
639
+		}
617 640
 
618 641
 		// Show the ... after the first page.  (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page)
619
-		if ($start > $num_per_page * ($PageContiguous + 1))
620
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
642
+		if ($start > $num_per_page * ($PageContiguous + 1)) {
643
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
621 644
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
622 645
 				'{FIRST_PAGE}' => $num_per_page,
623 646
 				'{LAST_PAGE}' => $start - $num_per_page * $PageContiguous,
624 647
 				'{PER_PAGE}' => $num_per_page,
625 648
 			));
649
+		}
626 650
 
627 651
 		// Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page)
628
-		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--)
629
-			if ($start >= $num_per_page * $nCont)
652
+		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) {
653
+					if ($start >= $num_per_page * $nCont)
630 654
 			{
631 655
 				$tmpStart = $start - $num_per_page * $nCont;
656
+		}
632 657
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
633 658
 			}
634 659
 
635 660
 		// Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page)
636
-		if (!$start_invalid)
637
-			$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
638
-		else
639
-			$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
661
+		if (!$start_invalid) {
662
+					$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
663
+		} else {
664
+					$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
665
+		}
640 666
 
641 667
 		// Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page)
642 668
 		$tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page;
643
-		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++)
644
-			if ($start + $num_per_page * $nCont <= $tmpMaxPages)
669
+		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) {
670
+					if ($start + $num_per_page * $nCont <= $tmpMaxPages)
645 671
 			{
646 672
 				$tmpStart = $start + $num_per_page * $nCont;
673
+		}
647 674
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
648 675
 			}
649 676
 
650 677
 		// Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page)
651
-		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages)
652
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
678
+		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) {
679
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
653 680
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
654 681
 				'{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1),
655 682
 				'{LAST_PAGE}' => $tmpMaxPages,
656 683
 				'{PER_PAGE}' => $num_per_page,
657 684
 			));
685
+		}
658 686
 
659 687
 		// Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15<  next page)
660
-		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages)
661
-			$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
688
+		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) {
689
+					$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
690
+		}
662 691
 
663 692
 		// Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<)
664
-		if ($start != $tmpMaxPages && $show_prevnext)
665
-			$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
693
+		if ($start != $tmpMaxPages && $show_prevnext) {
694
+					$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
695
+		}
666 696
 	}
667 697
 	$pageindex .= $settings['page_index']['extra_after'];
668 698
 
@@ -688,8 +718,9 @@  discard block
 block discarded – undo
688 718
 	if ($decimal_separator === null)
689 719
 	{
690 720
 		// Not set for whatever reason?
691
-		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1)
692
-			return $number;
721
+		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) {
722
+					return $number;
723
+		}
693 724
 
694 725
 		// Cache these each load...
695 726
 		$thousands_separator = $matches[1];
@@ -721,17 +752,20 @@  discard block
 block discarded – undo
721 752
 	static $non_twelve_hour;
722 753
 
723 754
 	// Offset the time.
724
-	if (!$offset_type)
725
-		$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
755
+	if (!$offset_type) {
756
+			$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
757
+	}
726 758
 	// Just the forum offset?
727
-	elseif ($offset_type == 'forum')
728
-		$time = $log_time + $modSettings['time_offset'] * 3600;
729
-	else
730
-		$time = $log_time;
759
+	elseif ($offset_type == 'forum') {
760
+			$time = $log_time + $modSettings['time_offset'] * 3600;
761
+	} else {
762
+			$time = $log_time;
763
+	}
731 764
 
732 765
 	// We can't have a negative date (on Windows, at least.)
733
-	if ($log_time < 0)
734
-		$log_time = 0;
766
+	if ($log_time < 0) {
767
+			$log_time = 0;
768
+	}
735 769
 
736 770
 	// Today and Yesterday?
737 771
 	if ($modSettings['todayMod'] >= 1 && $show_today === true)
@@ -748,46 +782,53 @@  discard block
 block discarded – undo
748 782
 		{
749 783
 			$h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l';
750 784
 			$today_fmt = $h . ':%M' . $s . ' %p';
785
+		} else {
786
+					$today_fmt = '%H:%M' . $s;
751 787
 		}
752
-		else
753
-			$today_fmt = '%H:%M' . $s;
754 788
 
755 789
 		// Same day of the year, same year.... Today!
756
-		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year'])
757
-			return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
790
+		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) {
791
+					return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
792
+		}
758 793
 
759 794
 		// Day-of-year is one less and same year, or it's the first of the year and that's the last of the year...
760
-		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31))
761
-			return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
795
+		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) {
796
+					return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
797
+		}
762 798
 	}
763 799
 
764 800
 	$str = !is_bool($show_today) ? $show_today : $user_info['time_format'];
765 801
 
766 802
 	if (setlocale(LC_TIME, $txt['lang_locale']))
767 803
 	{
768
-		if (!isset($non_twelve_hour))
769
-			$non_twelve_hour = trim(strftime('%p')) === '';
770
-		if ($non_twelve_hour && strpos($str, '%p') !== false)
771
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
804
+		if (!isset($non_twelve_hour)) {
805
+					$non_twelve_hour = trim(strftime('%p')) === '';
806
+		}
807
+		if ($non_twelve_hour && strpos($str, '%p') !== false) {
808
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
809
+		}
772 810
 
773
-		foreach (array('%a', '%A', '%b', '%B') as $token)
774
-			if (strpos($str, $token) !== false)
811
+		foreach (array('%a', '%A', '%b', '%B') as $token) {
812
+					if (strpos($str, $token) !== false)
775 813
 				$str = str_replace($token, strftime($token, $time), $str);
776
-	}
777
-	else
814
+		}
815
+	} else
778 816
 	{
779 817
 		// Do-it-yourself time localization.  Fun.
780
-		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label)
781
-			if (strpos($str, $token) !== false)
818
+		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) {
819
+					if (strpos($str, $token) !== false)
782 820
 				$str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str);
821
+		}
783 822
 
784
-		if (strpos($str, '%p') !== false)
785
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
823
+		if (strpos($str, '%p') !== false) {
824
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
825
+		}
786 826
 	}
787 827
 
788 828
 	// Windows doesn't support %e; on some versions, strftime fails altogether if used, so let's prevent that.
789
-	if ($context['server']['is_windows'] && strpos($str, '%e') !== false)
790
-		$str = str_replace('%e', ltrim(strftime('%d', $time), '0'), $str);
829
+	if ($context['server']['is_windows'] && strpos($str, '%e') !== false) {
830
+			$str = str_replace('%e', ltrim(strftime('%d', $time), '0'), $str);
831
+	}
791 832
 
792 833
 	// Format any other characters..
793 834
 	return strftime($str, $time);
@@ -809,16 +850,19 @@  discard block
 block discarded – undo
809 850
 	static $translation = array();
810 851
 
811 852
 	// Determine the character set... Default to UTF-8
812
-	if (empty($context['character_set']))
813
-		$charset = 'UTF-8';
853
+	if (empty($context['character_set'])) {
854
+			$charset = 'UTF-8';
855
+	}
814 856
 	// Use ISO-8859-1 in place of non-supported ISO-8859 charsets...
815
-	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15')))
816
-		$charset = 'ISO-8859-1';
817
-	else
818
-		$charset = $context['character_set'];
857
+	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) {
858
+			$charset = 'ISO-8859-1';
859
+	} else {
860
+			$charset = $context['character_set'];
861
+	}
819 862
 
820
-	if (empty($translation))
821
-		$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
863
+	if (empty($translation)) {
864
+			$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
865
+	}
822 866
 
823 867
 	return strtr($string, $translation);
824 868
 }
@@ -840,8 +884,9 @@  discard block
 block discarded – undo
840 884
 	global $smcFunc;
841 885
 
842 886
 	// It was already short enough!
843
-	if ($smcFunc['strlen']($subject) <= $len)
844
-		return $subject;
887
+	if ($smcFunc['strlen']($subject) <= $len) {
888
+			return $subject;
889
+	}
845 890
 
846 891
 	// Shorten it by the length it was too long, and strip off junk from the end.
847 892
 	return $smcFunc['substr']($subject, 0, $len) . '...';
@@ -860,10 +905,11 @@  discard block
 block discarded – undo
860 905
 {
861 906
 	global $user_info, $modSettings;
862 907
 
863
-	if ($timestamp === null)
864
-		$timestamp = time();
865
-	elseif ($timestamp == 0)
866
-		return 0;
908
+	if ($timestamp === null) {
909
+			$timestamp = time();
910
+	} elseif ($timestamp == 0) {
911
+			return 0;
912
+	}
867 913
 
868 914
 	return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600;
869 915
 }
@@ -892,8 +938,9 @@  discard block
 block discarded – undo
892 938
 		$array[$i] = $array[$j];
893 939
 		$array[$j] = $temp;
894 940
 
895
-		for ($i = 1; $p[$i] == 0; $i++)
896
-			$p[$i] = 1;
941
+		for ($i = 1; $p[$i] == 0; $i++) {
942
+					$p[$i] = 1;
943
+		}
897 944
 
898 945
 		$orders[] = $array;
899 946
 	}
@@ -925,12 +972,14 @@  discard block
 block discarded – undo
925 972
 	static $disabled;
926 973
 
927 974
 	// Don't waste cycles
928
-	if ($message === '')
929
-		return '';
975
+	if ($message === '') {
976
+			return '';
977
+	}
930 978
 
931 979
 	// Just in case it wasn't determined yet whether UTF-8 is enabled.
932
-	if (!isset($context['utf8']))
933
-		$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
980
+	if (!isset($context['utf8'])) {
981
+			$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
982
+	}
934 983
 
935 984
 	// Clean up any cut/paste issues we may have
936 985
 	$message = sanitizeMSCutPaste($message);
@@ -942,13 +991,15 @@  discard block
 block discarded – undo
942 991
 		return $message;
943 992
 	}
944 993
 
945
-	if ($smileys !== null && ($smileys == '1' || $smileys == '0'))
946
-		$smileys = (bool) $smileys;
994
+	if ($smileys !== null && ($smileys == '1' || $smileys == '0')) {
995
+			$smileys = (bool) $smileys;
996
+	}
947 997
 
948 998
 	if (empty($modSettings['enableBBC']) && $message !== false)
949 999
 	{
950
-		if ($smileys === true)
951
-			parsesmileys($message);
1000
+		if ($smileys === true) {
1001
+					parsesmileys($message);
1002
+		}
952 1003
 
953 1004
 		return $message;
954 1005
 	}
@@ -961,8 +1012,9 @@  discard block
 block discarded – undo
961 1012
 	}
962 1013
 
963 1014
 	// Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker
964
-	if (!empty($modSettings['autoLinkUrls']))
965
-		set_tld_regex();
1015
+	if (!empty($modSettings['autoLinkUrls'])) {
1016
+			set_tld_regex();
1017
+	}
966 1018
 
967 1019
 	// Allow mods access before entering the main parse_bbc loop
968 1020
 	call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
@@ -976,12 +1028,14 @@  discard block
 block discarded – undo
976 1028
 
977 1029
 			$temp = explode(',', strtolower($modSettings['disabledBBC']));
978 1030
 
979
-			foreach ($temp as $tag)
980
-				$disabled[trim($tag)] = true;
1031
+			foreach ($temp as $tag) {
1032
+							$disabled[trim($tag)] = true;
1033
+			}
981 1034
 		}
982 1035
 
983
-		if (empty($modSettings['enableEmbeddedFlash']))
984
-			$disabled['flash'] = true;
1036
+		if (empty($modSettings['enableEmbeddedFlash'])) {
1037
+					$disabled['flash'] = true;
1038
+		}
985 1039
 
986 1040
 		/* The following bbc are formatted as an array, with keys as follows:
987 1041
 
@@ -1102,8 +1156,9 @@  discard block
 block discarded – undo
1102 1156
 					$returnContext = '';
1103 1157
 
1104 1158
 					// BBC or the entire attachments feature is disabled
1105
-					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach']))
1106
-						return $data;
1159
+					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) {
1160
+											return $data;
1161
+					}
1107 1162
 
1108 1163
 					// Save the attach ID.
1109 1164
 					$attachID = $data;
@@ -1114,8 +1169,9 @@  discard block
 block discarded – undo
1114 1169
 					$currentAttachment = parseAttachBBC($attachID);
1115 1170
 
1116 1171
 					// parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do.
1117
-					if (is_string($currentAttachment))
1118
-						return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1172
+					if (is_string($currentAttachment)) {
1173
+											return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1174
+					}
1119 1175
 
1120 1176
 					if (!empty($currentAttachment['is_image']))
1121 1177
 					{
@@ -1131,15 +1187,17 @@  discard block
 block discarded – undo
1131 1187
 							$height = ' height="' . $currentAttachment['height'] . '"';
1132 1188
 						}
1133 1189
 
1134
-						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1135
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '"></a>';
1136
-						else
1137
-							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . '/>';
1190
+						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) {
1191
+													$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '"></a>';
1192
+						} else {
1193
+													$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . '/>';
1194
+						}
1138 1195
 					}
1139 1196
 
1140 1197
 					// No image. Show a link.
1141
-					else
1142
-						$returnContext .= $currentAttachment['link'];
1198
+					else {
1199
+											$returnContext .= $currentAttachment['link'];
1200
+					}
1143 1201
 
1144 1202
 					// Gotta append what we just did.
1145 1203
 					$data = $returnContext;
@@ -1170,8 +1228,9 @@  discard block
 block discarded – undo
1170 1228
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1171 1229
 						{
1172 1230
 							// Do PHP code coloring?
1173
-							if ($php_parts[$php_i] != '&lt;?php')
1174
-								continue;
1231
+							if ($php_parts[$php_i] != '&lt;?php') {
1232
+															continue;
1233
+							}
1175 1234
 
1176 1235
 							$php_string = '';
1177 1236
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1187,8 +1246,9 @@  discard block
 block discarded – undo
1187 1246
 						$data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data);
1188 1247
 
1189 1248
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1190
-						if ($context['browser']['is_opera'])
1191
-							$data .= '&nbsp;';
1249
+						if ($context['browser']['is_opera']) {
1250
+													$data .= '&nbsp;';
1251
+						}
1192 1252
 					}
1193 1253
 				},
1194 1254
 				'block_level' => true,
@@ -1207,8 +1267,9 @@  discard block
 block discarded – undo
1207 1267
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1208 1268
 						{
1209 1269
 							// Do PHP code coloring?
1210
-							if ($php_parts[$php_i] != '&lt;?php')
1211
-								continue;
1270
+							if ($php_parts[$php_i] != '&lt;?php') {
1271
+															continue;
1272
+							}
1212 1273
 
1213 1274
 							$php_string = '';
1214 1275
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1224,8 +1285,9 @@  discard block
 block discarded – undo
1224 1285
 						$data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]);
1225 1286
 
1226 1287
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1227
-						if ($context['browser']['is_opera'])
1228
-							$data[0] .= '&nbsp;';
1288
+						if ($context['browser']['is_opera']) {
1289
+													$data[0] .= '&nbsp;';
1290
+						}
1229 1291
 					}
1230 1292
 				},
1231 1293
 				'block_level' => true,
@@ -1263,11 +1325,13 @@  discard block
 block discarded – undo
1263 1325
 				'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">',
1264 1326
 				'validate' => function (&$tag, &$data, $disabled)
1265 1327
 				{
1266
-					if (isset($disabled['url']))
1267
-						$tag['content'] = '$1';
1328
+					if (isset($disabled['url'])) {
1329
+											$tag['content'] = '$1';
1330
+					}
1268 1331
 					$scheme = parse_url($data[0], PHP_URL_SCHEME);
1269
-					if (empty($scheme))
1270
-						$data[0] = '//' . ltrim($data[0], ':/');
1332
+					if (empty($scheme)) {
1333
+											$data[0] = '//' . ltrim($data[0], ':/');
1334
+					}
1271 1335
 				},
1272 1336
 				'disabled_content' => '<a href="$1" target="_blank" class="new_win">$1</a>',
1273 1337
 			),
@@ -1314,14 +1378,16 @@  discard block
 block discarded – undo
1314 1378
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1315 1379
 					if ($image_proxy_enabled)
1316 1380
 					{
1317
-						if (empty($scheme))
1318
-							$data = 'http://' . ltrim($data, ':/');
1381
+						if (empty($scheme)) {
1382
+													$data = 'http://' . ltrim($data, ':/');
1383
+						}
1319 1384
 
1320
-						if ($scheme != 'https')
1321
-							$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1385
+						if ($scheme != 'https') {
1386
+													$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1387
+						}
1388
+					} elseif (empty($scheme)) {
1389
+											$data = '//' . ltrim($data, ':/');
1322 1390
 					}
1323
-					elseif (empty($scheme))
1324
-						$data = '//' . ltrim($data, ':/');
1325 1391
 				},
1326 1392
 				'disabled_content' => '($1)',
1327 1393
 			),
@@ -1337,14 +1403,16 @@  discard block
 block discarded – undo
1337 1403
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1338 1404
 					if ($image_proxy_enabled)
1339 1405
 					{
1340
-						if (empty($scheme))
1341
-							$data = 'http://' . ltrim($data, ':/');
1406
+						if (empty($scheme)) {
1407
+													$data = 'http://' . ltrim($data, ':/');
1408
+						}
1342 1409
 
1343
-						if ($scheme != 'https')
1344
-							$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1410
+						if ($scheme != 'https') {
1411
+													$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1412
+						}
1413
+					} elseif (empty($scheme)) {
1414
+											$data = '//' . ltrim($data, ':/');
1345 1415
 					}
1346
-					elseif (empty($scheme))
1347
-						$data = '//' . ltrim($data, ':/');
1348 1416
 				},
1349 1417
 				'disabled_content' => '($1)',
1350 1418
 			),
@@ -1356,8 +1424,9 @@  discard block
 block discarded – undo
1356 1424
 				{
1357 1425
 					$data = strtr($data, array('<br>' => ''));
1358 1426
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1359
-					if (empty($scheme))
1360
-						$data = '//' . ltrim($data, ':/');
1427
+					if (empty($scheme)) {
1428
+											$data = '//' . ltrim($data, ':/');
1429
+					}
1361 1430
 				},
1362 1431
 			),
1363 1432
 			array(
@@ -1368,13 +1437,14 @@  discard block
 block discarded – undo
1368 1437
 				'after' => '</a>',
1369 1438
 				'validate' => function (&$tag, &$data, $disabled)
1370 1439
 				{
1371
-					if (substr($data, 0, 1) == '#')
1372
-						$data = '#post_' . substr($data, 1);
1373
-					else
1440
+					if (substr($data, 0, 1) == '#') {
1441
+											$data = '#post_' . substr($data, 1);
1442
+					} else
1374 1443
 					{
1375 1444
 						$scheme = parse_url($data, PHP_URL_SCHEME);
1376
-						if (empty($scheme))
1377
-							$data = '//' . ltrim($data, ':/');
1445
+						if (empty($scheme)) {
1446
+													$data = '//' . ltrim($data, ':/');
1447
+						}
1378 1448
 					}
1379 1449
 				},
1380 1450
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
@@ -1452,8 +1522,9 @@  discard block
 block discarded – undo
1452 1522
 					{
1453 1523
 						$add_begin = substr(trim($data), 0, 5) != '&lt;?';
1454 1524
 						$data = highlight_php_code($add_begin ? '&lt;?php ' . $data . '?&gt;' : $data);
1455
-						if ($add_begin)
1456
-							$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1525
+						if ($add_begin) {
1526
+													$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1527
+						}
1457 1528
 					}
1458 1529
 				},
1459 1530
 				'block_level' => false,
@@ -1584,10 +1655,11 @@  discard block
 block discarded – undo
1584 1655
 				'content' => '$1',
1585 1656
 				'validate' => function (&$tag, &$data, $disabled)
1586 1657
 				{
1587
-					if (is_numeric($data))
1588
-						$data = timeformat($data);
1589
-					else
1590
-						$tag['content'] = '[time]$1[/time]';
1658
+					if (is_numeric($data)) {
1659
+											$data = timeformat($data);
1660
+					} else {
1661
+											$tag['content'] = '[time]$1[/time]';
1662
+					}
1591 1663
 				},
1592 1664
 			),
1593 1665
 			array(
@@ -1614,8 +1686,9 @@  discard block
 block discarded – undo
1614 1686
 				{
1615 1687
 					$data = strtr($data, array('<br>' => ''));
1616 1688
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1617
-					if (empty($scheme))
1618
-						$data = '//' . ltrim($data, ':/');
1689
+					if (empty($scheme)) {
1690
+											$data = '//' . ltrim($data, ':/');
1691
+					}
1619 1692
 				},
1620 1693
 			),
1621 1694
 			array(
@@ -1627,8 +1700,9 @@  discard block
 block discarded – undo
1627 1700
 				'validate' => function (&$tag, &$data, $disabled)
1628 1701
 				{
1629 1702
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1630
-					if (empty($scheme))
1631
-						$data = '//' . ltrim($data, ':/');
1703
+					if (empty($scheme)) {
1704
+											$data = '//' . ltrim($data, ':/');
1705
+					}
1632 1706
 				},
1633 1707
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
1634 1708
 				'disabled_after' => ' ($1)',
@@ -1648,8 +1722,9 @@  discard block
 block discarded – undo
1648 1722
 		// This is mainly for the bbc manager, so it's easy to add tags above.  Custom BBC should be added above this line.
1649 1723
 		if ($message === false)
1650 1724
 		{
1651
-			if (isset($temp_bbc))
1652
-				$bbc_codes = $temp_bbc;
1725
+			if (isset($temp_bbc)) {
1726
+							$bbc_codes = $temp_bbc;
1727
+			}
1653 1728
 			usort($codes, function ($a, $b) {
1654 1729
 				return strcmp($a['tag'], $b['tag']);
1655 1730
 			});
@@ -1669,8 +1744,9 @@  discard block
 block discarded – undo
1669 1744
 		);
1670 1745
 		if (!isset($disabled['li']) && !isset($disabled['list']))
1671 1746
 		{
1672
-			foreach ($itemcodes as $c => $dummy)
1673
-				$bbc_codes[$c] = array();
1747
+			foreach ($itemcodes as $c => $dummy) {
1748
+							$bbc_codes[$c] = array();
1749
+			}
1674 1750
 		}
1675 1751
 
1676 1752
 		// Shhhh!
@@ -1691,12 +1767,14 @@  discard block
 block discarded – undo
1691 1767
 		foreach ($codes as $code)
1692 1768
 		{
1693 1769
 			// Make it easier to process parameters later
1694
-			if (!empty($code['parameters']))
1695
-				ksort($code['parameters'], SORT_STRING);
1770
+			if (!empty($code['parameters'])) {
1771
+							ksort($code['parameters'], SORT_STRING);
1772
+			}
1696 1773
 
1697 1774
 			// If we are not doing every tag only do ones we are interested in.
1698
-			if (empty($parse_tags) || in_array($code['tag'], $parse_tags))
1699
-				$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
1775
+			if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) {
1776
+							$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
1777
+			}
1700 1778
 		}
1701 1779
 		$codes = null;
1702 1780
 	}
@@ -1707,8 +1785,9 @@  discard block
 block discarded – undo
1707 1785
 		// It's likely this will change if the message is modified.
1708 1786
 		$cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . json_encode($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']);
1709 1787
 
1710
-		if (($temp = cache_get_data($cache_key, 240)) != null)
1711
-			return $temp;
1788
+		if (($temp = cache_get_data($cache_key, 240)) != null) {
1789
+					return $temp;
1790
+		}
1712 1791
 
1713 1792
 		$cache_t = microtime();
1714 1793
 	}
@@ -1740,8 +1819,9 @@  discard block
 block discarded – undo
1740 1819
 		$disabled['flash'] = true;
1741 1820
 
1742 1821
 		// @todo Change maybe?
1743
-		if (!isset($_GET['images']))
1744
-			$disabled['img'] = true;
1822
+		if (!isset($_GET['images'])) {
1823
+					$disabled['img'] = true;
1824
+		}
1745 1825
 
1746 1826
 		// @todo Interface/setting to add more?
1747 1827
 	}
@@ -1765,8 +1845,9 @@  discard block
 block discarded – undo
1765 1845
 		$pos = isset($matches[0][1]) ? $matches[0][1] : false;
1766 1846
 
1767 1847
 		// Failsafe.
1768
-		if ($pos === false || $last_pos > $pos)
1769
-			$pos = strlen($message) + 1;
1848
+		if ($pos === false || $last_pos > $pos) {
1849
+					$pos = strlen($message) + 1;
1850
+		}
1770 1851
 
1771 1852
 		// Can't have a one letter smiley, URL, or email! (sorry.)
1772 1853
 		if ($last_pos < $pos - 1)
@@ -1785,8 +1866,9 @@  discard block
 block discarded – undo
1785 1866
 
1786 1867
 				// <br> should be empty.
1787 1868
 				$empty_tags = array('br', 'hr');
1788
-				foreach ($empty_tags as $tag)
1789
-					$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '[' . $tag . ' /]', $data);
1869
+				foreach ($empty_tags as $tag) {
1870
+									$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '[' . $tag . ' /]', $data);
1871
+				}
1790 1872
 
1791 1873
 				// b, u, i, s, pre... basic tags.
1792 1874
 				$closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote');
@@ -1795,8 +1877,9 @@  discard block
 block discarded – undo
1795 1877
 					$diff = substr_count($data, '&lt;' . $tag . '&gt;') - substr_count($data, '&lt;/' . $tag . '&gt;');
1796 1878
 					$data = strtr($data, array('&lt;' . $tag . '&gt;' => '<' . $tag . '>', '&lt;/' . $tag . '&gt;' => '</' . $tag . '>'));
1797 1879
 
1798
-					if ($diff > 0)
1799
-						$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
1880
+					if ($diff > 0) {
1881
+											$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
1882
+					}
1800 1883
 				}
1801 1884
 
1802 1885
 				// Do <img ...> - with security... action= -> action-.
@@ -1809,8 +1892,9 @@  discard block
 block discarded – undo
1809 1892
 						$alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^&quot;|&quot;$~', '', $matches[3][$match]);
1810 1893
 
1811 1894
 						// Remove action= from the URL - no funny business, now.
1812
-						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0)
1813
-							$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
1895
+						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) {
1896
+													$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
1897
+						}
1814 1898
 
1815 1899
 						// Check if the image is larger than allowed.
1816 1900
 						if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height']))
@@ -1831,9 +1915,9 @@  discard block
 block discarded – undo
1831 1915
 
1832 1916
 							// Set the new image tag.
1833 1917
 							$replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]';
1918
+						} else {
1919
+													$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
1834 1920
 						}
1835
-						else
1836
-							$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
1837 1921
 					}
1838 1922
 
1839 1923
 					$data = strtr($data, $replaces);
@@ -1846,16 +1930,18 @@  discard block
 block discarded – undo
1846 1930
 				$no_autolink_area = false;
1847 1931
 				if (!empty($open_tags))
1848 1932
 				{
1849
-					foreach ($open_tags as $open_tag)
1850
-						if (in_array($open_tag['tag'], $no_autolink_tags))
1933
+					foreach ($open_tags as $open_tag) {
1934
+											if (in_array($open_tag['tag'], $no_autolink_tags))
1851 1935
 							$no_autolink_area = true;
1936
+					}
1852 1937
 				}
1853 1938
 
1854 1939
 				// Don't go backwards.
1855 1940
 				// @todo Don't think is the real solution....
1856 1941
 				$lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0;
1857
-				if ($pos < $lastAutoPos)
1858
-					$no_autolink_area = true;
1942
+				if ($pos < $lastAutoPos) {
1943
+									$no_autolink_area = true;
1944
+				}
1859 1945
 				$lastAutoPos = $pos;
1860 1946
 
1861 1947
 				if (!$no_autolink_area)
@@ -1964,17 +2050,19 @@  discard block
 block discarded – undo
1964 2050
 							if ($scheme == 'mailto')
1965 2051
 							{
1966 2052
 								$email_address = str_replace('mailto:', '', $url);
1967
-								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false)
1968
-									return '[email=' . $email_address . ']' . $url . '[/email]';
1969
-								else
1970
-									return $url;
2053
+								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) {
2054
+																	return '[email=' . $email_address . ']' . $url . '[/email]';
2055
+								} else {
2056
+																	return $url;
2057
+								}
1971 2058
 							}
1972 2059
 
1973 2060
 							// Are we linking a schemeless URL or naked domain name (e.g. "example.com")?
1974
-							if (empty($scheme))
1975
-								$fullUrl = '//' . ltrim($url, ':/');
1976
-							else
1977
-								$fullUrl = $url;
2061
+							if (empty($scheme)) {
2062
+															$fullUrl = '//' . ltrim($url, ':/');
2063
+							} else {
2064
+															$fullUrl = $url;
2065
+							}
1978 2066
 
1979 2067
 							return '[url=&quot;' . str_replace(array('[', ']'), array('&#91;', '&#93;'), $fullUrl) . '&quot;]' . $url . '[/url]';
1980 2068
 						}, $data);
@@ -2023,16 +2111,18 @@  discard block
 block discarded – undo
2023 2111
 		}
2024 2112
 
2025 2113
 		// Are we there yet?  Are we there yet?
2026
-		if ($pos >= strlen($message) - 1)
2027
-			break;
2114
+		if ($pos >= strlen($message) - 1) {
2115
+					break;
2116
+		}
2028 2117
 
2029 2118
 		$tags = strtolower($message[$pos + 1]);
2030 2119
 
2031 2120
 		if ($tags == '/' && !empty($open_tags))
2032 2121
 		{
2033 2122
 			$pos2 = strpos($message, ']', $pos + 1);
2034
-			if ($pos2 == $pos + 2)
2035
-				continue;
2123
+			if ($pos2 == $pos + 2) {
2124
+							continue;
2125
+			}
2036 2126
 
2037 2127
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
2038 2128
 
@@ -2042,8 +2132,9 @@  discard block
 block discarded – undo
2042 2132
 			do
2043 2133
 			{
2044 2134
 				$tag = array_pop($open_tags);
2045
-				if (!$tag)
2046
-					break;
2135
+				if (!$tag) {
2136
+									break;
2137
+				}
2047 2138
 
2048 2139
 				if (!empty($tag['block_level']))
2049 2140
 				{
@@ -2057,10 +2148,11 @@  discard block
 block discarded – undo
2057 2148
 					// The idea is, if we are LOOKING for a block level tag, we can close them on the way.
2058 2149
 					if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]]))
2059 2150
 					{
2060
-						foreach ($bbc_codes[$look_for[0]] as $temp)
2061
-							if ($temp['tag'] == $look_for)
2151
+						foreach ($bbc_codes[$look_for[0]] as $temp) {
2152
+													if ($temp['tag'] == $look_for)
2062 2153
 							{
2063 2154
 								$block_level = !empty($temp['block_level']);
2155
+						}
2064 2156
 								break;
2065 2157
 							}
2066 2158
 					}
@@ -2082,15 +2174,15 @@  discard block
 block discarded – undo
2082 2174
 			{
2083 2175
 				$open_tags = $to_close;
2084 2176
 				continue;
2085
-			}
2086
-			elseif (!empty($to_close) && $tag['tag'] != $look_for)
2177
+			} elseif (!empty($to_close) && $tag['tag'] != $look_for)
2087 2178
 			{
2088 2179
 				if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]]))
2089 2180
 				{
2090
-					foreach ($bbc_codes[$look_for[0]] as $temp)
2091
-						if ($temp['tag'] == $look_for)
2181
+					foreach ($bbc_codes[$look_for[0]] as $temp) {
2182
+											if ($temp['tag'] == $look_for)
2092 2183
 						{
2093 2184
 							$block_level = !empty($temp['block_level']);
2185
+					}
2094 2186
 							break;
2095 2187
 						}
2096 2188
 				}
@@ -2098,8 +2190,9 @@  discard block
 block discarded – undo
2098 2190
 				// We're not looking for a block level tag (or maybe even a tag that exists...)
2099 2191
 				if (!$block_level)
2100 2192
 				{
2101
-					foreach ($to_close as $tag)
2102
-						array_push($open_tags, $tag);
2193
+					foreach ($to_close as $tag) {
2194
+											array_push($open_tags, $tag);
2195
+					}
2103 2196
 					continue;
2104 2197
 				}
2105 2198
 			}
@@ -2111,10 +2204,12 @@  discard block
 block discarded – undo
2111 2204
 				$pos2 = $pos - 1;
2112 2205
 
2113 2206
 				// See the comment at the end of the big loop - just eating whitespace ;).
2114
-				if (!empty($tag['block_level']) && substr($message, $pos, 4) == '<br>')
2115
-					$message = substr($message, 0, $pos) . substr($message, $pos + 4);
2116
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos), $matches) != 0)
2117
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2207
+				if (!empty($tag['block_level']) && substr($message, $pos, 4) == '<br>') {
2208
+									$message = substr($message, 0, $pos) . substr($message, $pos + 4);
2209
+				}
2210
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos), $matches) != 0) {
2211
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2212
+				}
2118 2213
 			}
2119 2214
 
2120 2215
 			if (!empty($to_close))
@@ -2127,8 +2222,9 @@  discard block
 block discarded – undo
2127 2222
 		}
2128 2223
 
2129 2224
 		// No tags for this character, so just keep going (fastest possible course.)
2130
-		if (!isset($bbc_codes[$tags]))
2131
-			continue;
2225
+		if (!isset($bbc_codes[$tags])) {
2226
+					continue;
2227
+		}
2132 2228
 
2133 2229
 		$inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1];
2134 2230
 		$tag = null;
@@ -2137,44 +2233,52 @@  discard block
 block discarded – undo
2137 2233
 			$pt_strlen = strlen($possible['tag']);
2138 2234
 
2139 2235
 			// Not a match?
2140
-			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag'])
2141
-				continue;
2236
+			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) {
2237
+							continue;
2238
+			}
2142 2239
 
2143 2240
 			$next_c = $message[$pos + 1 + $pt_strlen];
2144 2241
 
2145 2242
 			// A test validation?
2146
-			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0)
2147
-				continue;
2243
+			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) {
2244
+							continue;
2245
+			}
2148 2246
 			// Do we want parameters?
2149 2247
 			elseif (!empty($possible['parameters']))
2150 2248
 			{
2151
-				if ($next_c != ' ')
2152
-					continue;
2153
-			}
2154
-			elseif (isset($possible['type']))
2249
+				if ($next_c != ' ') {
2250
+									continue;
2251
+				}
2252
+			} elseif (isset($possible['type']))
2155 2253
 			{
2156 2254
 				// Do we need an equal sign?
2157
-				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=')
2158
-					continue;
2255
+				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') {
2256
+									continue;
2257
+				}
2159 2258
 				// Maybe we just want a /...
2160
-				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]')
2161
-					continue;
2259
+				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') {
2260
+									continue;
2261
+				}
2162 2262
 				// An immediate ]?
2163
-				if ($possible['type'] == 'unparsed_content' && $next_c != ']')
2164
-					continue;
2263
+				if ($possible['type'] == 'unparsed_content' && $next_c != ']') {
2264
+									continue;
2265
+				}
2165 2266
 			}
2166 2267
 			// No type means 'parsed_content', which demands an immediate ] without parameters!
2167
-			elseif ($next_c != ']')
2168
-				continue;
2268
+			elseif ($next_c != ']') {
2269
+							continue;
2270
+			}
2169 2271
 
2170 2272
 			// Check allowed tree?
2171
-			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents'])))
2172
-				continue;
2173
-			elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children']))
2174
-				continue;
2273
+			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) {
2274
+							continue;
2275
+			} elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) {
2276
+							continue;
2277
+			}
2175 2278
 			// If this is in the list of disallowed child tags, don't parse it.
2176
-			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children']))
2177
-				continue;
2279
+			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) {
2280
+							continue;
2281
+			}
2178 2282
 
2179 2283
 			$pos1 = $pos + 1 + $pt_strlen + 1;
2180 2284
 
@@ -2186,8 +2290,9 @@  discard block
 block discarded – undo
2186 2290
 				foreach ($open_tags as $open_quote)
2187 2291
 				{
2188 2292
 					// Every parent quote this quote has flips the styling
2189
-					if ($open_quote['tag'] == 'quote')
2190
-						$quote_alt = !$quote_alt;
2293
+					if ($open_quote['tag'] == 'quote') {
2294
+											$quote_alt = !$quote_alt;
2295
+					}
2191 2296
 				}
2192 2297
 				// Add a class to the quote to style alternating blockquotes
2193 2298
 				$possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">'));
@@ -2198,8 +2303,9 @@  discard block
 block discarded – undo
2198 2303
 			{
2199 2304
 				// Build a regular expression for each parameter for the current tag.
2200 2305
 				$preg = array();
2201
-				foreach ($possible['parameters'] as $p => $info)
2202
-					$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2306
+				foreach ($possible['parameters'] as $p => $info) {
2307
+									$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2308
+				}
2203 2309
 
2204 2310
 				// Extract the string that potentially holds our parameters.
2205 2311
 				$blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos));
@@ -2219,24 +2325,27 @@  discard block
 block discarded – undo
2219 2325
 
2220 2326
 					$match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0;
2221 2327
 
2222
-					if ($match)
2223
-						$blob_counter = count($blobs) + 1;
2328
+					if ($match) {
2329
+											$blob_counter = count($blobs) + 1;
2330
+					}
2224 2331
 				}
2225 2332
 
2226 2333
 				// Didn't match our parameter list, try the next possible.
2227
-				if (!$match)
2228
-					continue;
2334
+				if (!$match) {
2335
+									continue;
2336
+				}
2229 2337
 
2230 2338
 				$params = array();
2231 2339
 				for ($i = 1, $n = count($matches); $i < $n; $i += 2)
2232 2340
 				{
2233 2341
 					$key = strtok(ltrim($matches[$i]), '=');
2234
-					if (isset($possible['parameters'][$key]['value']))
2235
-						$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2236
-					elseif (isset($possible['parameters'][$key]['validate']))
2237
-						$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2238
-					else
2239
-						$params['{' . $key . '}'] = $matches[$i + 1];
2342
+					if (isset($possible['parameters'][$key]['value'])) {
2343
+											$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2344
+					} elseif (isset($possible['parameters'][$key]['validate'])) {
2345
+											$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2346
+					} else {
2347
+											$params['{' . $key . '}'] = $matches[$i + 1];
2348
+					}
2240 2349
 
2241 2350
 					// Just to make sure: replace any $ or { so they can't interpolate wrongly.
2242 2351
 					$params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '&#036;', '{' => '&#123;'));
@@ -2244,23 +2353,26 @@  discard block
 block discarded – undo
2244 2353
 
2245 2354
 				foreach ($possible['parameters'] as $p => $info)
2246 2355
 				{
2247
-					if (!isset($params['{' . $p . '}']))
2248
-						$params['{' . $p . '}'] = '';
2356
+					if (!isset($params['{' . $p . '}'])) {
2357
+											$params['{' . $p . '}'] = '';
2358
+					}
2249 2359
 				}
2250 2360
 
2251 2361
 				$tag = $possible;
2252 2362
 
2253 2363
 				// Put the parameters into the string.
2254
-				if (isset($tag['before']))
2255
-					$tag['before'] = strtr($tag['before'], $params);
2256
-				if (isset($tag['after']))
2257
-					$tag['after'] = strtr($tag['after'], $params);
2258
-				if (isset($tag['content']))
2259
-					$tag['content'] = strtr($tag['content'], $params);
2364
+				if (isset($tag['before'])) {
2365
+									$tag['before'] = strtr($tag['before'], $params);
2366
+				}
2367
+				if (isset($tag['after'])) {
2368
+									$tag['after'] = strtr($tag['after'], $params);
2369
+				}
2370
+				if (isset($tag['content'])) {
2371
+									$tag['content'] = strtr($tag['content'], $params);
2372
+				}
2260 2373
 
2261 2374
 				$pos1 += strlen($given_param_string);
2262
-			}
2263
-			else
2375
+			} else
2264 2376
 			{
2265 2377
 				$tag = $possible;
2266 2378
 				$params = array();
@@ -2271,8 +2383,9 @@  discard block
 block discarded – undo
2271 2383
 		// Item codes are complicated buggers... they are implicit [li]s and can make [list]s!
2272 2384
 		if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li']))
2273 2385
 		{
2274
-			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>')))
2275
-				continue;
2386
+			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) {
2387
+							continue;
2388
+			}
2276 2389
 
2277 2390
 			$tag = $itemcodes[$message[$pos + 1]];
2278 2391
 
@@ -2293,9 +2406,9 @@  discard block
 block discarded – undo
2293 2406
 			{
2294 2407
 				array_pop($open_tags);
2295 2408
 				$code = '</li>';
2409
+			} else {
2410
+							$code = '';
2296 2411
 			}
2297
-			else
2298
-				$code = '';
2299 2412
 
2300 2413
 			// Now we open a new tag.
2301 2414
 			$open_tags[] = array(
@@ -2342,12 +2455,14 @@  discard block
 block discarded – undo
2342 2455
 		}
2343 2456
 
2344 2457
 		// No tag?  Keep looking, then.  Silly people using brackets without actual tags.
2345
-		if ($tag === null)
2346
-			continue;
2458
+		if ($tag === null) {
2459
+					continue;
2460
+		}
2347 2461
 
2348 2462
 		// Propagate the list to the child (so wrapping the disallowed tag won't work either.)
2349
-		if (isset($inside['disallow_children']))
2350
-			$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2463
+		if (isset($inside['disallow_children'])) {
2464
+					$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2465
+		}
2351 2466
 
2352 2467
 		// Is this tag disabled?
2353 2468
 		if (isset($disabled[$tag['tag']]))
@@ -2357,14 +2472,13 @@  discard block
 block discarded – undo
2357 2472
 				$tag['before'] = !empty($tag['block_level']) ? '<div>' : '';
2358 2473
 				$tag['after'] = !empty($tag['block_level']) ? '</div>' : '';
2359 2474
 				$tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1');
2360
-			}
2361
-			elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2475
+			} elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2362 2476
 			{
2363 2477
 				$tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : '');
2364 2478
 				$tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : '');
2479
+			} else {
2480
+							$tag['content'] = $tag['disabled_content'];
2365 2481
 			}
2366
-			else
2367
-				$tag['content'] = $tag['disabled_content'];
2368 2482
 		}
2369 2483
 
2370 2484
 		// we use this a lot
@@ -2374,8 +2488,9 @@  discard block
 block discarded – undo
2374 2488
 		if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level']))
2375 2489
 		{
2376 2490
 			$n = count($open_tags) - 1;
2377
-			while (empty($open_tags[$n]['block_level']) && $n >= 0)
2378
-				$n--;
2491
+			while (empty($open_tags[$n]['block_level']) && $n >= 0) {
2492
+							$n--;
2493
+			}
2379 2494
 
2380 2495
 			// Close all the non block level tags so this tag isn't surrounded by them.
2381 2496
 			for ($i = count($open_tags) - 1; $i > $n; $i--)
@@ -2386,10 +2501,12 @@  discard block
 block discarded – undo
2386 2501
 				$pos1 += $ot_strlen + 2;
2387 2502
 
2388 2503
 				// Trim or eat trailing stuff... see comment at the end of the big loop.
2389
-				if (!empty($open_tags[$i]['block_level']) && substr($message, $pos, 4) == '<br>')
2390
-					$message = substr($message, 0, $pos) . substr($message, $pos + 4);
2391
-				if (!empty($open_tags[$i]['trim']) && $tag['trim'] != 'inside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos), $matches) != 0)
2392
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2504
+				if (!empty($open_tags[$i]['block_level']) && substr($message, $pos, 4) == '<br>') {
2505
+									$message = substr($message, 0, $pos) . substr($message, $pos + 4);
2506
+				}
2507
+				if (!empty($open_tags[$i]['trim']) && $tag['trim'] != 'inside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos), $matches) != 0) {
2508
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2509
+				}
2393 2510
 
2394 2511
 				array_pop($open_tags);
2395 2512
 			}
@@ -2407,16 +2524,19 @@  discard block
 block discarded – undo
2407 2524
 		elseif ($tag['type'] == 'unparsed_content')
2408 2525
 		{
2409 2526
 			$pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1);
2410
-			if ($pos2 === false)
2411
-				continue;
2527
+			if ($pos2 === false) {
2528
+							continue;
2529
+			}
2412 2530
 
2413 2531
 			$data = substr($message, $pos1, $pos2 - $pos1);
2414 2532
 
2415
-			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>')
2416
-				$data = substr($data, 4);
2533
+			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') {
2534
+							$data = substr($data, 4);
2535
+			}
2417 2536
 
2418
-			if (isset($tag['validate']))
2419
-				$tag['validate']($tag, $data, $disabled, $params);
2537
+			if (isset($tag['validate'])) {
2538
+							$tag['validate']($tag, $data, $disabled, $params);
2539
+			}
2420 2540
 
2421 2541
 			$code = strtr($tag['content'], array('$1' => $data));
2422 2542
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen);
@@ -2432,34 +2552,40 @@  discard block
 block discarded – undo
2432 2552
 			if (isset($tag['quoted']))
2433 2553
 			{
2434 2554
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2435
-				if ($tag['quoted'] != 'optional' && !$quoted)
2436
-					continue;
2555
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2556
+									continue;
2557
+				}
2437 2558
 
2438
-				if ($quoted)
2439
-					$pos1 += 6;
2559
+				if ($quoted) {
2560
+									$pos1 += 6;
2561
+				}
2562
+			} else {
2563
+							$quoted = false;
2440 2564
 			}
2441
-			else
2442
-				$quoted = false;
2443 2565
 
2444 2566
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2445
-			if ($pos2 === false)
2446
-				continue;
2567
+			if ($pos2 === false) {
2568
+							continue;
2569
+			}
2447 2570
 
2448 2571
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2449
-			if ($pos3 === false)
2450
-				continue;
2572
+			if ($pos3 === false) {
2573
+							continue;
2574
+			}
2451 2575
 
2452 2576
 			$data = array(
2453 2577
 				substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))),
2454 2578
 				substr($message, $pos1, $pos2 - $pos1)
2455 2579
 			);
2456 2580
 
2457
-			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>')
2458
-				$data[0] = substr($data[0], 4);
2581
+			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') {
2582
+							$data[0] = substr($data[0], 4);
2583
+			}
2459 2584
 
2460 2585
 			// Validation for my parking, please!
2461
-			if (isset($tag['validate']))
2462
-				$tag['validate']($tag, $data, $disabled, $params);
2586
+			if (isset($tag['validate'])) {
2587
+							$tag['validate']($tag, $data, $disabled, $params);
2588
+			}
2463 2589
 
2464 2590
 			$code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1]));
2465 2591
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
@@ -2476,23 +2602,27 @@  discard block
 block discarded – undo
2476 2602
 		elseif ($tag['type'] == 'unparsed_commas_content')
2477 2603
 		{
2478 2604
 			$pos2 = strpos($message, ']', $pos1);
2479
-			if ($pos2 === false)
2480
-				continue;
2605
+			if ($pos2 === false) {
2606
+							continue;
2607
+			}
2481 2608
 
2482 2609
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2483
-			if ($pos3 === false)
2484
-				continue;
2610
+			if ($pos3 === false) {
2611
+							continue;
2612
+			}
2485 2613
 
2486 2614
 			// We want $1 to be the content, and the rest to be csv.
2487 2615
 			$data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1));
2488 2616
 			$data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1);
2489 2617
 
2490
-			if (isset($tag['validate']))
2491
-				$tag['validate']($tag, $data, $disabled, $params);
2618
+			if (isset($tag['validate'])) {
2619
+							$tag['validate']($tag, $data, $disabled, $params);
2620
+			}
2492 2621
 
2493 2622
 			$code = $tag['content'];
2494
-			foreach ($data as $k => $d)
2495
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2623
+			foreach ($data as $k => $d) {
2624
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2625
+			}
2496 2626
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
2497 2627
 			$pos += strlen($code) - 1 + 2;
2498 2628
 		}
@@ -2500,24 +2630,28 @@  discard block
 block discarded – undo
2500 2630
 		elseif ($tag['type'] == 'unparsed_commas')
2501 2631
 		{
2502 2632
 			$pos2 = strpos($message, ']', $pos1);
2503
-			if ($pos2 === false)
2504
-				continue;
2633
+			if ($pos2 === false) {
2634
+							continue;
2635
+			}
2505 2636
 
2506 2637
 			$data = explode(',', substr($message, $pos1, $pos2 - $pos1));
2507 2638
 
2508
-			if (isset($tag['validate']))
2509
-				$tag['validate']($tag, $data, $disabled, $params);
2639
+			if (isset($tag['validate'])) {
2640
+							$tag['validate']($tag, $data, $disabled, $params);
2641
+			}
2510 2642
 
2511 2643
 			// Fix after, for disabled code mainly.
2512
-			foreach ($data as $k => $d)
2513
-				$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2644
+			foreach ($data as $k => $d) {
2645
+							$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2646
+			}
2514 2647
 
2515 2648
 			$open_tags[] = $tag;
2516 2649
 
2517 2650
 			// Replace them out, $1, $2, $3, $4, etc.
2518 2651
 			$code = $tag['before'];
2519
-			foreach ($data as $k => $d)
2520
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2652
+			foreach ($data as $k => $d) {
2653
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2654
+			}
2521 2655
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1);
2522 2656
 			$pos += strlen($code) - 1 + 2;
2523 2657
 		}
@@ -2528,28 +2662,33 @@  discard block
 block discarded – undo
2528 2662
 			if (isset($tag['quoted']))
2529 2663
 			{
2530 2664
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2531
-				if ($tag['quoted'] != 'optional' && !$quoted)
2532
-					continue;
2665
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2666
+									continue;
2667
+				}
2533 2668
 
2534
-				if ($quoted)
2535
-					$pos1 += 6;
2669
+				if ($quoted) {
2670
+									$pos1 += 6;
2671
+				}
2672
+			} else {
2673
+							$quoted = false;
2536 2674
 			}
2537
-			else
2538
-				$quoted = false;
2539 2675
 
2540 2676
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2541
-			if ($pos2 === false)
2542
-				continue;
2677
+			if ($pos2 === false) {
2678
+							continue;
2679
+			}
2543 2680
 
2544 2681
 			$data = substr($message, $pos1, $pos2 - $pos1);
2545 2682
 
2546 2683
 			// Validation for my parking, please!
2547
-			if (isset($tag['validate']))
2548
-				$tag['validate']($tag, $data, $disabled, $params);
2684
+			if (isset($tag['validate'])) {
2685
+							$tag['validate']($tag, $data, $disabled, $params);
2686
+			}
2549 2687
 
2550 2688
 			// For parsed content, we must recurse to avoid security problems.
2551
-			if ($tag['type'] != 'unparsed_equals')
2552
-				$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2689
+			if ($tag['type'] != 'unparsed_equals') {
2690
+							$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2691
+			}
2553 2692
 
2554 2693
 			$tag['after'] = strtr($tag['after'], array('$1' => $data));
2555 2694
 
@@ -2561,34 +2700,40 @@  discard block
 block discarded – undo
2561 2700
 		}
2562 2701
 
2563 2702
 		// If this is block level, eat any breaks after it.
2564
-		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>')
2565
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2703
+		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') {
2704
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2705
+		}
2566 2706
 
2567 2707
 		// Are we trimming outside this tag?
2568
-		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0)
2569
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2708
+		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0) {
2709
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2710
+		}
2570 2711
 	}
2571 2712
 
2572 2713
 	// Close any remaining tags.
2573
-	while ($tag = array_pop($open_tags))
2574
-		$message .= "\n" . $tag['after'] . "\n";
2714
+	while ($tag = array_pop($open_tags)) {
2715
+			$message .= "\n" . $tag['after'] . "\n";
2716
+	}
2575 2717
 
2576 2718
 	// Parse the smileys within the parts where it can be done safely.
2577 2719
 	if ($smileys === true)
2578 2720
 	{
2579 2721
 		$message_parts = explode("\n", $message);
2580
-		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2)
2581
-			parsesmileys($message_parts[$i]);
2722
+		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) {
2723
+					parsesmileys($message_parts[$i]);
2724
+		}
2582 2725
 
2583 2726
 		$message = implode('', $message_parts);
2584 2727
 	}
2585 2728
 
2586 2729
 	// No smileys, just get rid of the markers.
2587
-	else
2588
-		$message = strtr($message, array("\n" => ''));
2730
+	else {
2731
+			$message = strtr($message, array("\n" => ''));
2732
+	}
2589 2733
 
2590
-	if ($message !== '' && $message[0] === ' ')
2591
-		$message = '&nbsp;' . substr($message, 1);
2734
+	if ($message !== '' && $message[0] === ' ') {
2735
+			$message = '&nbsp;' . substr($message, 1);
2736
+	}
2592 2737
 
2593 2738
 	// Cleanup whitespace.
2594 2739
 	$message = strtr($message, array('  ' => ' &nbsp;', "\r" => '', "\n" => '<br>', '<br> ' => '<br>&nbsp;', '&#13;' => "\n"));
@@ -2597,15 +2742,16 @@  discard block
 block discarded – undo
2597 2742
 	call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
2598 2743
 
2599 2744
 	// Cache the output if it took some time...
2600
-	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05)
2601
-		cache_put_data($cache_key, $message, 240);
2745
+	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) {
2746
+			cache_put_data($cache_key, $message, 240);
2747
+	}
2602 2748
 
2603 2749
 	// If this was a force parse revert if needed.
2604 2750
 	if (!empty($parse_tags))
2605 2751
 	{
2606
-		if (empty($temp_bbc))
2607
-			$bbc_codes = array();
2608
-		else
2752
+		if (empty($temp_bbc)) {
2753
+					$bbc_codes = array();
2754
+		} else
2609 2755
 		{
2610 2756
 			$bbc_codes = $temp_bbc;
2611 2757
 			unset($temp_bbc);
@@ -2632,8 +2778,9 @@  discard block
 block discarded – undo
2632 2778
 	static $smileyPregSearch = null, $smileyPregReplacements = array();
2633 2779
 
2634 2780
 	// No smiley set at all?!
2635
-	if ($user_info['smiley_set'] == 'none' || trim($message) == '')
2636
-		return;
2781
+	if ($user_info['smiley_set'] == 'none' || trim($message) == '') {
2782
+			return;
2783
+	}
2637 2784
 
2638 2785
 	// If smileyPregSearch hasn't been set, do it now.
2639 2786
 	if (empty($smileyPregSearch))
@@ -2644,8 +2791,7 @@  discard block
 block discarded – undo
2644 2791
 			$smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)');
2645 2792
 			$smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif');
2646 2793
 			$smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', '');
2647
-		}
2648
-		else
2794
+		} else
2649 2795
 		{
2650 2796
 			// Load the smileys in reverse order by length so they don't get parsed wrong.
2651 2797
 			if (($temp = cache_get_data('parsing_smileys', 480)) == null)
@@ -2669,9 +2815,9 @@  discard block
 block discarded – undo
2669 2815
 				$smcFunc['db_free_result']($result);
2670 2816
 
2671 2817
 				cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480);
2818
+			} else {
2819
+							list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2672 2820
 			}
2673
-			else
2674
-				list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2675 2821
 		}
2676 2822
 
2677 2823
 		// The non-breaking-space is a complex thing...
@@ -2748,35 +2894,41 @@  discard block
 block discarded – undo
2748 2894
 	global $scripturl, $context, $modSettings, $db_show_debug, $db_cache;
2749 2895
 
2750 2896
 	// In case we have mail to send, better do that - as obExit doesn't always quite make it...
2751
-	if (!empty($context['flush_mail']))
2752
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2897
+	if (!empty($context['flush_mail'])) {
2898
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2753 2899
 		AddMailQueue(true);
2900
+	}
2754 2901
 
2755 2902
 	$add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:';
2756 2903
 
2757
-	if ($add)
2758
-		$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
2904
+	if ($add) {
2905
+			$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
2906
+	}
2759 2907
 
2760 2908
 	// Put the session ID in.
2761
-	if (defined('SID') && SID != '')
2762
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
2909
+	if (defined('SID') && SID != '') {
2910
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
2911
+	}
2763 2912
 	// Keep that debug in their for template debugging!
2764
-	elseif (isset($_GET['debug']))
2765
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
2913
+	elseif (isset($_GET['debug'])) {
2914
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
2915
+	}
2766 2916
 
2767 2917
 	if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed'])))
2768 2918
 	{
2769
-		if (defined('SID') && SID != '')
2770
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2919
+		if (defined('SID') && SID != '') {
2920
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2771 2921
 				function ($m) use ($scripturl)
2772 2922
 				{
2773 2923
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
2924
+		}
2774 2925
 				}, $setLocation);
2775
-		else
2776
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2926
+		else {
2927
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2777 2928
 				function ($m) use ($scripturl)
2778 2929
 				{
2779 2930
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
2931
+		}
2780 2932
 				}, $setLocation);
2781 2933
 	}
2782 2934
 
@@ -2787,8 +2939,9 @@  discard block
 block discarded – undo
2787 2939
 	header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302);
2788 2940
 
2789 2941
 	// Debugging.
2790
-	if (isset($db_show_debug) && $db_show_debug === true)
2791
-		$_SESSION['debug_redirect'] = $db_cache;
2942
+	if (isset($db_show_debug) && $db_show_debug === true) {
2943
+			$_SESSION['debug_redirect'] = $db_cache;
2944
+	}
2792 2945
 
2793 2946
 	obExit(false);
2794 2947
 }
@@ -2807,51 +2960,60 @@  discard block
 block discarded – undo
2807 2960
 
2808 2961
 	// Attempt to prevent a recursive loop.
2809 2962
 	++$level;
2810
-	if ($level > 1 && !$from_fatal_error && !$has_fatal_error)
2811
-		exit;
2812
-	if ($from_fatal_error)
2813
-		$has_fatal_error = true;
2963
+	if ($level > 1 && !$from_fatal_error && !$has_fatal_error) {
2964
+			exit;
2965
+	}
2966
+	if ($from_fatal_error) {
2967
+			$has_fatal_error = true;
2968
+	}
2814 2969
 
2815 2970
 	// Clear out the stat cache.
2816 2971
 	trackStats();
2817 2972
 
2818 2973
 	// If we have mail to send, send it.
2819
-	if (!empty($context['flush_mail']))
2820
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2974
+	if (!empty($context['flush_mail'])) {
2975
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2821 2976
 		AddMailQueue(true);
2977
+	}
2822 2978
 
2823 2979
 	$do_header = $header === null ? !$header_done : $header;
2824
-	if ($do_footer === null)
2825
-		$do_footer = $do_header;
2980
+	if ($do_footer === null) {
2981
+			$do_footer = $do_header;
2982
+	}
2826 2983
 
2827 2984
 	// Has the template/header been done yet?
2828 2985
 	if ($do_header)
2829 2986
 	{
2830 2987
 		// Was the page title set last minute? Also update the HTML safe one.
2831
-		if (!empty($context['page_title']) && empty($context['page_title_html_safe']))
2832
-			$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
2988
+		if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) {
2989
+					$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
2990
+		}
2833 2991
 
2834 2992
 		// Start up the session URL fixer.
2835 2993
 		ob_start('ob_sessrewrite');
2836 2994
 
2837
-		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers']))
2838
-			$buffers = explode(',', $settings['output_buffers']);
2839
-		elseif (!empty($settings['output_buffers']))
2840
-			$buffers = $settings['output_buffers'];
2841
-		else
2842
-			$buffers = array();
2995
+		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) {
2996
+					$buffers = explode(',', $settings['output_buffers']);
2997
+		} elseif (!empty($settings['output_buffers'])) {
2998
+					$buffers = $settings['output_buffers'];
2999
+		} else {
3000
+					$buffers = array();
3001
+		}
2843 3002
 
2844
-		if (isset($modSettings['integrate_buffer']))
2845
-			$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3003
+		if (isset($modSettings['integrate_buffer'])) {
3004
+					$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3005
+		}
2846 3006
 
2847
-		if (!empty($buffers))
2848
-			foreach ($buffers as $function)
3007
+		if (!empty($buffers)) {
3008
+					foreach ($buffers as $function)
2849 3009
 			{
2850 3010
 				$call = call_helper($function, true);
3011
+		}
2851 3012
 
2852 3013
 				// Is it valid?
2853
-				if (!empty($call))
2854
-					ob_start($call);
3014
+				if (!empty($call)) {
3015
+									ob_start($call);
3016
+				}
2855 3017
 			}
2856 3018
 
2857 3019
 		// Display the screen in the logical order.
@@ -2863,8 +3025,9 @@  discard block
 block discarded – undo
2863 3025
 		loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main');
2864 3026
 
2865 3027
 		// Anything special to put out?
2866
-		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml']))
2867
-			echo $context['insert_after_template'];
3028
+		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) {
3029
+					echo $context['insert_after_template'];
3030
+		}
2868 3031
 
2869 3032
 		// Just so we don't get caught in an endless loop of errors from the footer...
2870 3033
 		if (!$footer_done)
@@ -2873,14 +3036,16 @@  discard block
 block discarded – undo
2873 3036
 			template_footer();
2874 3037
 
2875 3038
 			// (since this is just debugging... it's okay that it's after </html>.)
2876
-			if (!isset($_REQUEST['xml']))
2877
-				displayDebug();
3039
+			if (!isset($_REQUEST['xml'])) {
3040
+							displayDebug();
3041
+			}
2878 3042
 		}
2879 3043
 	}
2880 3044
 
2881 3045
 	// Remember this URL in case someone doesn't like sending HTTP_REFERER.
2882
-	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false)
2883
-		$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3046
+	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) {
3047
+			$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3048
+	}
2884 3049
 
2885 3050
 	// For session check verification.... don't switch browsers...
2886 3051
 	$_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT'];
@@ -2889,9 +3054,10 @@  discard block
 block discarded – undo
2889 3054
 	call_integration_hook('integrate_exit', array($do_footer));
2890 3055
 
2891 3056
 	// Don't exit if we're coming from index.php; that will pass through normally.
2892
-	if (!$from_index)
2893
-		exit;
2894
-}
3057
+	if (!$from_index) {
3058
+			exit;
3059
+	}
3060
+	}
2895 3061
 
2896 3062
 /**
2897 3063
  * Get the size of a specified image with better error handling.
@@ -2910,8 +3076,9 @@  discard block
 block discarded – undo
2910 3076
 	$url = str_replace(' ', '%20', $url);
2911 3077
 
2912 3078
 	// Can we pull this from the cache... please please?
2913
-	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null)
2914
-		return $temp;
3079
+	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) {
3080
+			return $temp;
3081
+	}
2915 3082
 	$t = microtime();
2916 3083
 
2917 3084
 	// Get the host to pester...
@@ -2921,12 +3088,10 @@  discard block
 block discarded – undo
2921 3088
 	if ($url == '' || $url == 'http://' || $url == 'https://')
2922 3089
 	{
2923 3090
 		return false;
2924
-	}
2925
-	elseif (!isset($match[1]))
3091
+	} elseif (!isset($match[1]))
2926 3092
 	{
2927 3093
 		$size = @getimagesize($url);
2928
-	}
2929
-	else
3094
+	} else
2930 3095
 	{
2931 3096
 		// Try to connect to the server... give it half a second.
2932 3097
 		$temp = 0;
@@ -2965,12 +3130,14 @@  discard block
 block discarded – undo
2965 3130
 	}
2966 3131
 
2967 3132
 	// If we didn't get it, we failed.
2968
-	if (!isset($size))
2969
-		$size = false;
3133
+	if (!isset($size)) {
3134
+			$size = false;
3135
+	}
2970 3136
 
2971 3137
 	// If this took a long time, we may never have to do it again, but then again we might...
2972
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8)
2973
-		cache_put_data('url_image_size-' . md5($url), $size, 240);
3138
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) {
3139
+			cache_put_data('url_image_size-' . md5($url), $size, 240);
3140
+	}
2974 3141
 
2975 3142
 	// Didn't work.
2976 3143
 	return $size;
@@ -2988,8 +3155,9 @@  discard block
 block discarded – undo
2988 3155
 
2989 3156
 	// Under SSI this function can be called more then once.  That can cause some problems.
2990 3157
 	//   So only run the function once unless we are forced to run it again.
2991
-	if ($loaded && !$forceload)
2992
-		return;
3158
+	if ($loaded && !$forceload) {
3159
+			return;
3160
+	}
2993 3161
 
2994 3162
 	$loaded = true;
2995 3163
 
@@ -3001,14 +3169,16 @@  discard block
 block discarded – undo
3001 3169
 	$context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news'])))));
3002 3170
 	for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++)
3003 3171
 	{
3004
-		if (trim($context['news_lines'][$i]) == '')
3005
-			continue;
3172
+		if (trim($context['news_lines'][$i]) == '') {
3173
+					continue;
3174
+		}
3006 3175
 
3007 3176
 		// Clean it up for presentation ;).
3008 3177
 		$context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i);
3009 3178
 	}
3010
-	if (!empty($context['news_lines']))
3011
-		$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3179
+	if (!empty($context['news_lines'])) {
3180
+			$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3181
+	}
3012 3182
 
3013 3183
 	if (!$user_info['is_guest'])
3014 3184
 	{
@@ -3017,40 +3187,48 @@  discard block
 block discarded – undo
3017 3187
 		$context['user']['alerts'] = &$user_info['alerts'];
3018 3188
 
3019 3189
 		// Personal message popup...
3020
-		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0))
3021
-			$context['user']['popup_messages'] = true;
3022
-		else
3023
-			$context['user']['popup_messages'] = false;
3190
+		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) {
3191
+					$context['user']['popup_messages'] = true;
3192
+		} else {
3193
+					$context['user']['popup_messages'] = false;
3194
+		}
3024 3195
 		$_SESSION['unread_messages'] = $user_info['unread_messages'];
3025 3196
 
3026
-		if (allowedTo('moderate_forum'))
3027
-			$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3197
+		if (allowedTo('moderate_forum')) {
3198
+					$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3199
+		}
3028 3200
 
3029 3201
 		$context['user']['avatar'] = array();
3030 3202
 
3031 3203
 		// Check for gravatar first since we might be forcing them...
3032 3204
 		if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride']))
3033 3205
 		{
3034
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11)
3035
-				$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3036
-			else
3037
-				$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3206
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) {
3207
+							$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3208
+			} else {
3209
+							$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3210
+			}
3038 3211
 		}
3039 3212
 		// Uploaded?
3040
-		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach']))
3041
-			$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3213
+		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) {
3214
+					$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3215
+		}
3042 3216
 		// Full URL?
3043
-		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0)
3044
-			$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3217
+		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) {
3218
+					$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3219
+		}
3045 3220
 		// Otherwise we assume it's server stored.
3046
-		elseif ($user_info['avatar']['url'] != '')
3047
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3221
+		elseif ($user_info['avatar']['url'] != '') {
3222
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3223
+		}
3048 3224
 		// No avatar at all? Fine, we have a big fat default avatar ;)
3049
-		else
3050
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3225
+		else {
3226
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3227
+		}
3051 3228
 
3052
-		if (!empty($context['user']['avatar']))
3053
-			$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3229
+		if (!empty($context['user']['avatar'])) {
3230
+					$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3231
+		}
3054 3232
 
3055 3233
 		// Figure out how long they've been logged in.
3056 3234
 		$context['user']['total_time_logged_in'] = array(
@@ -3058,8 +3236,7 @@  discard block
 block discarded – undo
3058 3236
 			'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600),
3059 3237
 			'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60)
3060 3238
 		);
3061
-	}
3062
-	else
3239
+	} else
3063 3240
 	{
3064 3241
 		$context['user']['messages'] = 0;
3065 3242
 		$context['user']['unread_messages'] = 0;
@@ -3067,12 +3244,14 @@  discard block
 block discarded – undo
3067 3244
 		$context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0);
3068 3245
 		$context['user']['popup_messages'] = false;
3069 3246
 
3070
-		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1)
3071
-			$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3247
+		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) {
3248
+					$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3249
+		}
3072 3250
 
3073 3251
 		// If we've upgraded recently, go easy on the passwords.
3074
-		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime']))
3075
-			$context['disable_login_hashing'] = true;
3252
+		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) {
3253
+					$context['disable_login_hashing'] = true;
3254
+		}
3076 3255
 	}
3077 3256
 
3078 3257
 	// Setup the main menu items.
@@ -3085,8 +3264,8 @@  discard block
 block discarded – undo
3085 3264
 	$context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm');
3086 3265
 
3087 3266
 	// 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array.
3088
-	if ($context['show_pm_popup'])
3089
-		addInlineJavaScript('
3267
+	if ($context['show_pm_popup']) {
3268
+			addInlineJavaScript('
3090 3269
 		jQuery(document).ready(function($) {
3091 3270
 			new smc_Popup({
3092 3271
 				heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ',
@@ -3094,15 +3273,17 @@  discard block
 block discarded – undo
3094 3273
 				icon_class: \'generic_icons mail_new\'
3095 3274
 			});
3096 3275
 		});');
3276
+	}
3097 3277
 
3098 3278
 	// Add a generic "Are you sure?" confirmation message.
3099 3279
 	addInlineJavaScript('
3100 3280
 	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3101 3281
 
3102 3282
 	// Now add the capping code for avatars.
3103
-	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
3104
-		addInlineCss('
3283
+	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') {
3284
+			addInlineCss('
3105 3285
 img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }');
3286
+	}
3106 3287
 
3107 3288
 	// This looks weird, but it's because BoardIndex.php references the variable.
3108 3289
 	$context['common_stats']['latest_member'] = array(
@@ -3119,11 +3300,13 @@  discard block
 block discarded – undo
3119 3300
 	);
3120 3301
 	$context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']);
3121 3302
 
3122
-	if (empty($settings['theme_version']))
3123
-		addJavaScriptVar('smf_scripturl', $scripturl);
3303
+	if (empty($settings['theme_version'])) {
3304
+			addJavaScriptVar('smf_scripturl', $scripturl);
3305
+	}
3124 3306
 
3125
-	if (!isset($context['page_title']))
3126
-		$context['page_title'] = '';
3307
+	if (!isset($context['page_title'])) {
3308
+			$context['page_title'] = '';
3309
+	}
3127 3310
 
3128 3311
 	// Set some specific vars.
3129 3312
 	$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
@@ -3133,21 +3316,23 @@  discard block
 block discarded – undo
3133 3316
 	$context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']);
3134 3317
 	$context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']);
3135 3318
 
3136
-	if (!empty($context['meta_keywords']))
3137
-		$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3319
+	if (!empty($context['meta_keywords'])) {
3320
+			$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3321
+	}
3138 3322
 
3139
-	if (!empty($context['canonical_url']))
3140
-		$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3323
+	if (!empty($context['canonical_url'])) {
3324
+			$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3325
+	}
3141 3326
 
3142
-	if (!empty($settings['og_image']))
3143
-		$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3327
+	if (!empty($settings['og_image'])) {
3328
+			$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3329
+	}
3144 3330
 
3145 3331
 	if (!empty($context['meta_description']))
3146 3332
 	{
3147 3333
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']);
3148 3334
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']);
3149
-	}
3150
-	else
3335
+	} else
3151 3336
 	{
3152 3337
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']);
3153 3338
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']);
@@ -3172,8 +3357,9 @@  discard block
 block discarded – undo
3172 3357
 	$memory_needed = memoryReturnBytes($needed);
3173 3358
 
3174 3359
 	// should we account for how much is currently being used?
3175
-	if ($in_use)
3176
-		$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3360
+	if ($in_use) {
3361
+			$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3362
+	}
3177 3363
 
3178 3364
 	// if more is needed, request it
3179 3365
 	if ($memory_current < $memory_needed)
@@ -3196,8 +3382,9 @@  discard block
 block discarded – undo
3196 3382
  */
3197 3383
 function memoryReturnBytes($val)
3198 3384
 {
3199
-	if (is_integer($val))
3200
-		return $val;
3385
+	if (is_integer($val)) {
3386
+			return $val;
3387
+	}
3201 3388
 
3202 3389
 	// Separate the number from the designator
3203 3390
 	$val = trim($val);
@@ -3233,10 +3420,11 @@  discard block
 block discarded – undo
3233 3420
 		header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
3234 3421
 
3235 3422
 		// Are we debugging the template/html content?
3236
-		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie'))
3237
-			header('Content-Type: application/xhtml+xml');
3238
-		elseif (!isset($_REQUEST['xml']))
3239
-			header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3423
+		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) {
3424
+					header('Content-Type: application/xhtml+xml');
3425
+		} elseif (!isset($_REQUEST['xml'])) {
3426
+					header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3427
+		}
3240 3428
 	}
3241 3429
 
3242 3430
 	header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
@@ -3245,8 +3433,9 @@  discard block
 block discarded – undo
3245 3433
 	if ($context['in_maintenance'] && $context['user']['is_admin'])
3246 3434
 	{
3247 3435
 		$position = array_search('body', $context['template_layers']);
3248
-		if ($position === false)
3249
-			$position = array_search('main', $context['template_layers']);
3436
+		if ($position === false) {
3437
+					$position = array_search('main', $context['template_layers']);
3438
+		}
3250 3439
 
3251 3440
 		if ($position !== false)
3252 3441
 		{
@@ -3274,23 +3463,25 @@  discard block
 block discarded – undo
3274 3463
 
3275 3464
 			foreach ($securityFiles as $i => $securityFile)
3276 3465
 			{
3277
-				if (!file_exists($boarddir . '/' . $securityFile))
3278
-					unset($securityFiles[$i]);
3466
+				if (!file_exists($boarddir . '/' . $securityFile)) {
3467
+									unset($securityFiles[$i]);
3468
+				}
3279 3469
 			}
3280 3470
 
3281 3471
 			// We are already checking so many files...just few more doesn't make any difference! :P
3282
-			if (!empty($modSettings['currentAttachmentUploadDir']))
3283
-				$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3284
-
3285
-			else
3286
-				$path = $modSettings['attachmentUploadDir'];
3472
+			if (!empty($modSettings['currentAttachmentUploadDir'])) {
3473
+							$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3474
+			} else {
3475
+							$path = $modSettings['attachmentUploadDir'];
3476
+			}
3287 3477
 
3288 3478
 			secureDirectory($path, true);
3289 3479
 			secureDirectory($cachedir);
3290 3480
 
3291 3481
 			// If agreement is enabled, at least the english version shall exists
3292
-			if ($modSettings['requireAgreement'])
3293
-				$agreement = !file_exists($boarddir . '/agreement.txt');
3482
+			if ($modSettings['requireAgreement']) {
3483
+							$agreement = !file_exists($boarddir . '/agreement.txt');
3484
+			}
3294 3485
 
3295 3486
 			if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement))
3296 3487
 			{
@@ -3305,18 +3496,21 @@  discard block
 block discarded – undo
3305 3496
 					echo '
3306 3497
 				', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>';
3307 3498
 
3308
-					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~')
3309
-						echo '
3499
+					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') {
3500
+											echo '
3310 3501
 				', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>';
3502
+					}
3311 3503
 				}
3312 3504
 
3313
-				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir))
3314
-					echo '
3505
+				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) {
3506
+									echo '
3315 3507
 				<strong>', $txt['cache_writable'], '</strong><br>';
3508
+				}
3316 3509
 
3317
-				if (!empty($agreement))
3318
-					echo '
3510
+				if (!empty($agreement)) {
3511
+									echo '
3319 3512
 				<strong>', $txt['agreement_missing'], '</strong><br>';
3513
+				}
3320 3514
 
3321 3515
 				echo '
3322 3516
 			</p>
@@ -3331,16 +3525,18 @@  discard block
 block discarded – undo
3331 3525
 				<div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;">
3332 3526
 					', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']);
3333 3527
 
3334
-			if (!empty($_SESSION['ban']['cannot_post']['reason']))
3335
-				echo '
3528
+			if (!empty($_SESSION['ban']['cannot_post']['reason'])) {
3529
+							echo '
3336 3530
 					<div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>';
3531
+			}
3337 3532
 
3338
-			if (!empty($_SESSION['ban']['expire_time']))
3339
-				echo '
3533
+			if (!empty($_SESSION['ban']['expire_time'])) {
3534
+							echo '
3340 3535
 					<div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>';
3341
-			else
3342
-				echo '
3536
+			} else {
3537
+							echo '
3343 3538
 					<div>', $txt['your_ban_expires_never'], '</div>';
3539
+			}
3344 3540
 
3345 3541
 			echo '
3346 3542
 				</div>';
@@ -3356,8 +3552,9 @@  discard block
 block discarded – undo
3356 3552
 	global $forum_copyright, $software_year, $forum_version;
3357 3553
 
3358 3554
 	// Don't display copyright for things like SSI.
3359
-	if (!isset($forum_version) || !isset($software_year))
3360
-		return;
3555
+	if (!isset($forum_version) || !isset($software_year)) {
3556
+			return;
3557
+	}
3361 3558
 
3362 3559
 	// Put in the version...
3363 3560
 	printf($forum_copyright, $forum_version, $software_year);
@@ -3375,9 +3572,10 @@  discard block
 block discarded – undo
3375 3572
 	$context['load_time'] = comma_format(round(array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)), 3));
3376 3573
 	$context['load_queries'] = $db_count;
3377 3574
 
3378
-	foreach (array_reverse($context['template_layers']) as $layer)
3379
-		loadSubTemplate($layer . '_below', true);
3380
-}
3575
+	foreach (array_reverse($context['template_layers']) as $layer) {
3576
+			loadSubTemplate($layer . '_below', true);
3577
+	}
3578
+	}
3381 3579
 
3382 3580
 /**
3383 3581
  * Output the Javascript files
@@ -3408,8 +3606,7 @@  discard block
 block discarded – undo
3408 3606
 			{
3409 3607
 				echo '
3410 3608
 		var ', $key, ';';
3411
-			}
3412
-			else
3609
+			} else
3413 3610
 			{
3414 3611
 				echo '
3415 3612
 		var ', $key, ' = ', $value, ';';
@@ -3424,26 +3621,27 @@  discard block
 block discarded – undo
3424 3621
 	foreach ($context['javascript_files'] as $id => $js_file)
3425 3622
 	{
3426 3623
 		// Last minute call! allow theme authors to disable single files.
3427
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3428
-			continue;
3624
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3625
+					continue;
3626
+		}
3429 3627
 
3430 3628
 		// By default all files don't get minimized unless the file explicitly says so!
3431 3629
 		if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files']))
3432 3630
 		{
3433
-			if ($do_deferred && !empty($js_file['options']['defer']))
3434
-				$toMinifyDefer[] = $js_file;
3435
-
3436
-			elseif (!$do_deferred && empty($js_file['options']['defer']))
3437
-				$toMinify[] = $js_file;
3631
+			if ($do_deferred && !empty($js_file['options']['defer'])) {
3632
+							$toMinifyDefer[] = $js_file;
3633
+			} elseif (!$do_deferred && empty($js_file['options']['defer'])) {
3634
+							$toMinify[] = $js_file;
3635
+			}
3438 3636
 
3439 3637
 			// Grab a random seed.
3440
-			if (!isset($minSeed))
3441
-				$minSeed = $js_file['options']['seed'];
3442
-		}
3443
-
3444
-		elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer'])))
3445
-			echo '
3638
+			if (!isset($minSeed)) {
3639
+							$minSeed = $js_file['options']['seed'];
3640
+			}
3641
+		} elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) {
3642
+					echo '
3446 3643
 	<script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>';
3644
+		}
3447 3645
 	}
3448 3646
 
3449 3647
 	if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer)))
@@ -3451,14 +3649,14 @@  discard block
 block discarded – undo
3451 3649
 		$result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred);
3452 3650
 
3453 3651
 		// Minify process couldn't work, print each individual files.
3454
-		if (!empty($result) && is_array($result))
3455
-			foreach ($result as $minFailedFile)
3652
+		if (!empty($result) && is_array($result)) {
3653
+					foreach ($result as $minFailedFile)
3456 3654
 				echo '
3457 3655
 	<script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>';
3458
-
3459
-		else
3460
-			echo '
3656
+		} else {
3657
+					echo '
3461 3658
 	<script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>';
3659
+		}
3462 3660
 	}
3463 3661
 
3464 3662
 	// Inline JavaScript - Actually useful some times!
@@ -3469,8 +3667,9 @@  discard block
 block discarded – undo
3469 3667
 			echo '
3470 3668
 <script>';
3471 3669
 
3472
-			foreach ($context['javascript_inline']['defer'] as $js_code)
3473
-				echo $js_code;
3670
+			foreach ($context['javascript_inline']['defer'] as $js_code) {
3671
+							echo $js_code;
3672
+			}
3474 3673
 
3475 3674
 			echo '
3476 3675
 </script>';
@@ -3481,8 +3680,9 @@  discard block
 block discarded – undo
3481 3680
 			echo '
3482 3681
 	<script>';
3483 3682
 
3484
-			foreach ($context['javascript_inline']['standard'] as $js_code)
3485
-				echo $js_code;
3683
+			foreach ($context['javascript_inline']['standard'] as $js_code) {
3684
+							echo $js_code;
3685
+			}
3486 3686
 
3487 3687
 			echo '
3488 3688
 	</script>';
@@ -3507,8 +3707,9 @@  discard block
 block discarded – undo
3507 3707
 	foreach ($context['css_files'] as $id => $file)
3508 3708
 	{
3509 3709
 		// Last minute call! allow theme authors to disable single files.
3510
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3511
-			continue;
3710
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3711
+					continue;
3712
+		}
3512 3713
 
3513 3714
 		// By default all files don't get minimized unless the file explicitly says so!
3514 3715
 		if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files']))
@@ -3516,12 +3717,12 @@  discard block
 block discarded – undo
3516 3717
 			$toMinify[] = $file;
3517 3718
 
3518 3719
 			// Grab a random seed.
3519
-			if (!isset($minSeed))
3520
-				$minSeed = $file['options']['seed'];
3720
+			if (!isset($minSeed)) {
3721
+							$minSeed = $file['options']['seed'];
3722
+			}
3723
+		} else {
3724
+					$normal[] = $file['fileUrl'];
3521 3725
 		}
3522
-
3523
-		else
3524
-			$normal[] = $file['fileUrl'];
3525 3726
 	}
3526 3727
 
3527 3728
 	if (!empty($toMinify))
@@ -3529,28 +3730,30 @@  discard block
 block discarded – undo
3529 3730
 		$result = custMinify($toMinify, 'css');
3530 3731
 
3531 3732
 		// Minify process couldn't work, print each individual files.
3532
-		if (!empty($result) && is_array($result))
3533
-			foreach ($result as $minFailedFile)
3733
+		if (!empty($result) && is_array($result)) {
3734
+					foreach ($result as $minFailedFile)
3534 3735
 				echo '
3535 3736
 	<link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">';
3536
-
3537
-		else
3538
-			echo '
3737
+		} else {
3738
+					echo '
3539 3739
 	<link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">';
3740
+		}
3540 3741
 	}
3541 3742
 
3542 3743
 	// Print the rest after the minified files.
3543
-	if (!empty($normal))
3544
-		foreach ($normal as $nf)
3744
+	if (!empty($normal)) {
3745
+			foreach ($normal as $nf)
3545 3746
 			echo '
3546 3747
 	<link rel="stylesheet" href="', $nf ,'">';
3748
+	}
3547 3749
 
3548 3750
 	if ($db_show_debug === true)
3549 3751
 	{
3550 3752
 		// Try to keep only what's useful.
3551 3753
 		$repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => '');
3552
-		foreach ($context['css_files'] as $file)
3553
-			$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
3754
+		foreach ($context['css_files'] as $file) {
3755
+					$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
3756
+		}
3554 3757
 	}
3555 3758
 
3556 3759
 	if (!empty($context['css_header']))
@@ -3558,9 +3761,10 @@  discard block
 block discarded – undo
3558 3761
 		echo '
3559 3762
 	<style>';
3560 3763
 
3561
-		foreach ($context['css_header'] as $css)
3562
-			echo $css .'
3764
+		foreach ($context['css_header'] as $css) {
3765
+					echo $css .'
3563 3766
 	';
3767
+		}
3564 3768
 
3565 3769
 		echo'
3566 3770
 	</style>';
@@ -3584,15 +3788,17 @@  discard block
 block discarded – undo
3584 3788
 	$type = !empty($type) && in_array($type, $types) ? $type : false;
3585 3789
 	$data = !empty($data) ? $data : false;
3586 3790
 
3587
-	if (empty($type) || empty($data))
3588
-		return false;
3791
+	if (empty($type) || empty($data)) {
3792
+			return false;
3793
+	}
3589 3794
 
3590 3795
 	// Did we already did this?
3591 3796
 	$toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400);
3592 3797
 
3593 3798
 	// Already done?
3594
-	if (!empty($toCache))
3595
-		return true;
3799
+	if (!empty($toCache)) {
3800
+			return true;
3801
+	}
3596 3802
 
3597 3803
 	// Yep, need a bunch of files.
3598 3804
 	require_once($sourcedir . '/minify/src/Minify.php');
@@ -3680,8 +3886,9 @@  discard block
 block discarded – undo
3680 3886
 	global $modSettings, $smcFunc;
3681 3887
 
3682 3888
 	// Just make up a nice hash...
3683
-	if ($new)
3684
-		return sha1(md5($filename . time()) . mt_rand());
3889
+	if ($new) {
3890
+			return sha1(md5($filename . time()) . mt_rand());
3891
+	}
3685 3892
 
3686 3893
 	// Grab the file hash if it wasn't added.
3687 3894
 	// Left this for legacy.
@@ -3695,23 +3902,25 @@  discard block
 block discarded – undo
3695 3902
 				'id_attach' => $attachment_id,
3696 3903
 			));
3697 3904
 
3698
-		if ($smcFunc['db_num_rows']($request) === 0)
3699
-			return false;
3905
+		if ($smcFunc['db_num_rows']($request) === 0) {
3906
+					return false;
3907
+		}
3700 3908
 
3701 3909
 		list ($file_hash) = $smcFunc['db_fetch_row']($request);
3702 3910
 		$smcFunc['db_free_result']($request);
3703 3911
 	}
3704 3912
 
3705 3913
 	// Still no hash? mmm...
3706
-	if (empty($file_hash))
3707
-		$file_hash = sha1(md5($filename . time()) . mt_rand());
3914
+	if (empty($file_hash)) {
3915
+			$file_hash = sha1(md5($filename . time()) . mt_rand());
3916
+	}
3708 3917
 
3709 3918
 	// Are we using multiple directories?
3710
-	if (!empty($modSettings['currentAttachmentUploadDir']))
3711
-		$path = $modSettings['attachmentUploadDir'][$dir];
3712
-
3713
-	else
3714
-		$path = $modSettings['attachmentUploadDir'];
3919
+	if (!empty($modSettings['currentAttachmentUploadDir'])) {
3920
+			$path = $modSettings['attachmentUploadDir'][$dir];
3921
+	} else {
3922
+			$path = $modSettings['attachmentUploadDir'];
3923
+	}
3715 3924
 
3716 3925
 	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
3717 3926
 }
@@ -3726,8 +3935,9 @@  discard block
 block discarded – undo
3726 3935
 function ip2range($fullip)
3727 3936
 {
3728 3937
 	// Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.)
3729
-	if ($fullip == 'unknown')
3730
-		$fullip = '255.255.255.255';
3938
+	if ($fullip == 'unknown') {
3939
+			$fullip = '255.255.255.255';
3940
+	}
3731 3941
 
3732 3942
 	$ip_parts = explode('-', $fullip);
3733 3943
 	$ip_array = array();
@@ -3751,10 +3961,11 @@  discard block
 block discarded – undo
3751 3961
 		$ip_array['low'] = $ip_parts[0];
3752 3962
 		$ip_array['high'] = $ip_parts[1];
3753 3963
 		return $ip_array;
3754
-	}
3755
-	elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.*
3964
+	} elseif (count($ip_parts) == 2) {
3965
+		// if ip 22.22.*-22.22.*
3756 3966
 	{
3757 3967
 		$valid_low = isValidIP($ip_parts[0]);
3968
+	}
3758 3969
 		$valid_high = isValidIP($ip_parts[1]);
3759 3970
 		$count = 0;
3760 3971
 		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
@@ -3769,7 +3980,9 @@  discard block
 block discarded – undo
3769 3980
 				$ip_parts[0] .= $mode . $min;
3770 3981
 				$valid_low = isValidIP($ip_parts[0]);
3771 3982
 				$count++;
3772
-				if ($count > 9) break;
3983
+				if ($count > 9) {
3984
+					break;
3985
+				}
3773 3986
 			}
3774 3987
 		}
3775 3988
 
@@ -3783,7 +3996,9 @@  discard block
 block discarded – undo
3783 3996
 				$ip_parts[1] .= $mode . $max;
3784 3997
 				$valid_high = isValidIP($ip_parts[1]);
3785 3998
 				$count++;
3786
-				if ($count > 9) break;
3999
+				if ($count > 9) {
4000
+					break;
4001
+				}
3787 4002
 			}
3788 4003
 		}
3789 4004
 
@@ -3808,46 +4023,54 @@  discard block
 block discarded – undo
3808 4023
 {
3809 4024
 	global $modSettings;
3810 4025
 
3811
-	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null)
3812
-		return $host;
4026
+	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) {
4027
+			return $host;
4028
+	}
3813 4029
 	$t = microtime();
3814 4030
 
3815 4031
 	// Try the Linux host command, perhaps?
3816 4032
 	if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1)
3817 4033
 	{
3818
-		if (!isset($modSettings['host_to_dis']))
3819
-			$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
3820
-		else
3821
-			$test = @shell_exec('host ' . @escapeshellarg($ip));
4034
+		if (!isset($modSettings['host_to_dis'])) {
4035
+					$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
4036
+		} else {
4037
+					$test = @shell_exec('host ' . @escapeshellarg($ip));
4038
+		}
3822 4039
 
3823 4040
 		// Did host say it didn't find anything?
3824
-		if (strpos($test, 'not found') !== false)
3825
-			$host = '';
4041
+		if (strpos($test, 'not found') !== false) {
4042
+					$host = '';
4043
+		}
3826 4044
 		// Invalid server option?
3827
-		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis']))
3828
-			updateSettings(array('host_to_dis' => 1));
4045
+		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) {
4046
+					updateSettings(array('host_to_dis' => 1));
4047
+		}
3829 4048
 		// Maybe it found something, after all?
3830
-		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1)
3831
-			$host = $match[1];
4049
+		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) {
4050
+					$host = $match[1];
4051
+		}
3832 4052
 	}
3833 4053
 
3834 4054
 	// This is nslookup; usually only Windows, but possibly some Unix?
3835 4055
 	if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1)
3836 4056
 	{
3837 4057
 		$test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip));
3838
-		if (strpos($test, 'Non-existent domain') !== false)
3839
-			$host = '';
3840
-		elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1)
3841
-			$host = $match[1];
4058
+		if (strpos($test, 'Non-existent domain') !== false) {
4059
+					$host = '';
4060
+		} elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) {
4061
+					$host = $match[1];
4062
+		}
3842 4063
 	}
3843 4064
 
3844 4065
 	// This is the last try :/.
3845
-	if (!isset($host) || $host === false)
3846
-		$host = @gethostbyaddr($ip);
4066
+	if (!isset($host) || $host === false) {
4067
+			$host = @gethostbyaddr($ip);
4068
+	}
3847 4069
 
3848 4070
 	// It took a long time, so let's cache it!
3849
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5)
3850
-		cache_put_data('hostlookup-' . $ip, $host, 600);
4071
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) {
4072
+			cache_put_data('hostlookup-' . $ip, $host, 600);
4073
+	}
3851 4074
 
3852 4075
 	return $host;
3853 4076
 }
@@ -3883,20 +4106,21 @@  discard block
 block discarded – undo
3883 4106
 			{
3884 4107
 				$encrypted = substr(crypt($word, 'uk'), 2, $max_chars);
3885 4108
 				$total = 0;
3886
-				for ($i = 0; $i < $max_chars; $i++)
3887
-					$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4109
+				for ($i = 0; $i < $max_chars; $i++) {
4110
+									$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4111
+				}
3888 4112
 				$returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total;
3889 4113
 			}
3890 4114
 		}
3891 4115
 		return array_unique($returned_ints);
3892
-	}
3893
-	else
4116
+	} else
3894 4117
 	{
3895 4118
 		// Trim characters before and after and add slashes for database insertion.
3896 4119
 		$returned_words = array();
3897
-		foreach ($words as $word)
3898
-			if (($word = trim($word, '-_\'')) !== '')
4120
+		foreach ($words as $word) {
4121
+					if (($word = trim($word, '-_\'')) !== '')
3899 4122
 				$returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars);
4123
+		}
3900 4124
 
3901 4125
 		// Filter out all words that occur more than once.
3902 4126
 		return array_unique($returned_words);
@@ -3918,16 +4142,18 @@  discard block
 block discarded – undo
3918 4142
 	global $settings, $txt;
3919 4143
 
3920 4144
 	// Does the current loaded theme have this and we are not forcing the usage of this function?
3921
-	if (function_exists('template_create_button') && !$force_use)
3922
-		return template_create_button($name, $alt, $label = '', $custom = '');
4145
+	if (function_exists('template_create_button') && !$force_use) {
4146
+			return template_create_button($name, $alt, $label = '', $custom = '');
4147
+	}
3923 4148
 
3924
-	if (!$settings['use_image_buttons'])
3925
-		return $txt[$alt];
3926
-	elseif (!empty($settings['use_buttons']))
3927
-		return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
3928
-	else
3929
-		return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
3930
-}
4149
+	if (!$settings['use_image_buttons']) {
4150
+			return $txt[$alt];
4151
+	} elseif (!empty($settings['use_buttons'])) {
4152
+			return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
4153
+	} else {
4154
+			return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
4155
+	}
4156
+	}
3931 4157
 
3932 4158
 /**
3933 4159
  * Sets up all of the top menu buttons
@@ -3970,9 +4196,10 @@  discard block
 block discarded – undo
3970 4196
 	var user_menus = new smc_PopupMenu();
3971 4197
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
3972 4198
 	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
3973
-		if ($context['allow_pm'])
3974
-			addInlineJavaScript('
4199
+		if ($context['allow_pm']) {
4200
+					addInlineJavaScript('
3975 4201
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
4202
+		}
3976 4203
 
3977 4204
 		if (!empty($modSettings['enable_ajax_alerts']))
3978 4205
 		{
@@ -4132,88 +4359,96 @@  discard block
 block discarded – undo
4132 4359
 
4133 4360
 		// Now we put the buttons in the context so the theme can use them.
4134 4361
 		$menu_buttons = array();
4135
-		foreach ($buttons as $act => $button)
4136
-			if (!empty($button['show']))
4362
+		foreach ($buttons as $act => $button) {
4363
+					if (!empty($button['show']))
4137 4364
 			{
4138 4365
 				$button['active_button'] = false;
4366
+		}
4139 4367
 
4140 4368
 				// This button needs some action.
4141
-				if (isset($button['action_hook']))
4142
-					$needs_action_hook = true;
4369
+				if (isset($button['action_hook'])) {
4370
+									$needs_action_hook = true;
4371
+				}
4143 4372
 
4144 4373
 				// Make sure the last button truly is the last button.
4145 4374
 				if (!empty($button['is_last']))
4146 4375
 				{
4147
-					if (isset($last_button))
4148
-						unset($menu_buttons[$last_button]['is_last']);
4376
+					if (isset($last_button)) {
4377
+											unset($menu_buttons[$last_button]['is_last']);
4378
+					}
4149 4379
 					$last_button = $act;
4150 4380
 				}
4151 4381
 
4152 4382
 				// Go through the sub buttons if there are any.
4153
-				if (!empty($button['sub_buttons']))
4154
-					foreach ($button['sub_buttons'] as $key => $subbutton)
4383
+				if (!empty($button['sub_buttons'])) {
4384
+									foreach ($button['sub_buttons'] as $key => $subbutton)
4155 4385
 					{
4156 4386
 						if (empty($subbutton['show']))
4157 4387
 							unset($button['sub_buttons'][$key]);
4388
+				}
4158 4389
 
4159 4390
 						// 2nd level sub buttons next...
4160 4391
 						if (!empty($subbutton['sub_buttons']))
4161 4392
 						{
4162 4393
 							foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2)
4163 4394
 							{
4164
-								if (empty($sub_button2['show']))
4165
-									unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4395
+								if (empty($sub_button2['show'])) {
4396
+																	unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4397
+								}
4166 4398
 							}
4167 4399
 						}
4168 4400
 					}
4169 4401
 
4170 4402
 				// Does this button have its own icon?
4171
-				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon']))
4172
-					$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4173
-				elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon']))
4174
-					$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4175
-				elseif (isset($button['icon']))
4176
-					$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4177
-				else
4178
-					$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4403
+				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) {
4404
+									$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4405
+				} elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) {
4406
+									$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4407
+				} elseif (isset($button['icon'])) {
4408
+									$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4409
+				} else {
4410
+									$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4411
+				}
4179 4412
 
4180 4413
 				$menu_buttons[$act] = $button;
4181 4414
 			}
4182 4415
 
4183
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
4184
-			cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4416
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
4417
+					cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4418
+		}
4185 4419
 	}
4186 4420
 
4187 4421
 	$context['menu_buttons'] = $menu_buttons;
4188 4422
 
4189 4423
 	// Logging out requires the session id in the url.
4190
-	if (isset($context['menu_buttons']['logout']))
4191
-		$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4424
+	if (isset($context['menu_buttons']['logout'])) {
4425
+			$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4426
+	}
4192 4427
 
4193 4428
 	// Figure out which action we are doing so we can set the active tab.
4194 4429
 	// Default to home.
4195 4430
 	$current_action = 'home';
4196 4431
 
4197
-	if (isset($context['menu_buttons'][$context['current_action']]))
4198
-		$current_action = $context['current_action'];
4199
-	elseif ($context['current_action'] == 'search2')
4200
-		$current_action = 'search';
4201
-	elseif ($context['current_action'] == 'theme')
4202
-		$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4203
-	elseif ($context['current_action'] == 'register2')
4204
-		$current_action = 'register';
4205
-	elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder'))
4206
-		$current_action = 'login';
4207
-	elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center'])
4208
-		$current_action = 'moderate';
4432
+	if (isset($context['menu_buttons'][$context['current_action']])) {
4433
+			$current_action = $context['current_action'];
4434
+	} elseif ($context['current_action'] == 'search2') {
4435
+			$current_action = 'search';
4436
+	} elseif ($context['current_action'] == 'theme') {
4437
+			$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4438
+	} elseif ($context['current_action'] == 'register2') {
4439
+			$current_action = 'register';
4440
+	} elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) {
4441
+			$current_action = 'login';
4442
+	} elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) {
4443
+			$current_action = 'moderate';
4444
+	}
4209 4445
 
4210 4446
 	// There are certain exceptions to the above where we don't want anything on the menu highlighted.
4211 4447
 	if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner']))
4212 4448
 	{
4213 4449
 		$current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile';
4214 4450
 		$context[$current_action] = true;
4215
-	}
4216
-	elseif ($context['current_action'] == 'pm')
4451
+	} elseif ($context['current_action'] == 'pm')
4217 4452
 	{
4218 4453
 		$current_action = 'self_pm';
4219 4454
 		$context['self_pm'] = true;
@@ -4256,12 +4491,14 @@  discard block
 block discarded – undo
4256 4491
 	}
4257 4492
 
4258 4493
 	// Not all actions are simple.
4259
-	if (!empty($needs_action_hook))
4260
-		call_integration_hook('integrate_current_action', array(&$current_action));
4494
+	if (!empty($needs_action_hook)) {
4495
+			call_integration_hook('integrate_current_action', array(&$current_action));
4496
+	}
4261 4497
 
4262
-	if (isset($context['menu_buttons'][$current_action]))
4263
-		$context['menu_buttons'][$current_action]['active_button'] = true;
4264
-}
4498
+	if (isset($context['menu_buttons'][$current_action])) {
4499
+			$context['menu_buttons'][$current_action]['active_button'] = true;
4500
+	}
4501
+	}
4265 4502
 
4266 4503
 /**
4267 4504
  * Generate a random seed and ensure it's stored in settings.
@@ -4285,16 +4522,19 @@  discard block
 block discarded – undo
4285 4522
 	global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug;
4286 4523
 	global $context, $txt;
4287 4524
 
4288
-	if ($db_show_debug === true)
4289
-		$context['debug']['hooks'][] = $hook;
4525
+	if ($db_show_debug === true) {
4526
+			$context['debug']['hooks'][] = $hook;
4527
+	}
4290 4528
 
4291 4529
 	// Need to have some control.
4292
-	if (!isset($context['instances']))
4293
-		$context['instances'] = array();
4530
+	if (!isset($context['instances'])) {
4531
+			$context['instances'] = array();
4532
+	}
4294 4533
 
4295 4534
 	$results = array();
4296
-	if (empty($modSettings[$hook]))
4297
-		return $results;
4535
+	if (empty($modSettings[$hook])) {
4536
+			return $results;
4537
+	}
4298 4538
 
4299 4539
 	// Define some needed vars.
4300 4540
 	$function = false;
@@ -4304,14 +4544,16 @@  discard block
 block discarded – undo
4304 4544
 	foreach ($functions as $function)
4305 4545
 	{
4306 4546
 		// Hook has been marked as "disabled". Skip it!
4307
-		if (strpos($function, '!') !== false)
4308
-			continue;
4547
+		if (strpos($function, '!') !== false) {
4548
+					continue;
4549
+		}
4309 4550
 
4310 4551
 		$call = call_helper($function, true);
4311 4552
 
4312 4553
 		// Is it valid?
4313
-		if (!empty($call))
4314
-			$results[$function] = call_user_func_array($call, $parameters);
4554
+		if (!empty($call)) {
4555
+					$results[$function] = call_user_func_array($call, $parameters);
4556
+		}
4315 4557
 
4316 4558
 		// Whatever it was suppose to call, it failed :(
4317 4559
 		elseif (!empty($function))
@@ -4327,8 +4569,9 @@  discard block
 block discarded – undo
4327 4569
 			}
4328 4570
 
4329 4571
 			// "Assume" the file resides on $boarddir somewhere...
4330
-			else
4331
-				log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
4572
+			else {
4573
+							log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
4574
+			}
4332 4575
 		}
4333 4576
 	}
4334 4577
 
@@ -4350,12 +4593,14 @@  discard block
 block discarded – undo
4350 4593
 	global $smcFunc, $modSettings;
4351 4594
 
4352 4595
 	// Any objects?
4353
-	if ($object)
4354
-		$function = $function . '#';
4596
+	if ($object) {
4597
+			$function = $function . '#';
4598
+	}
4355 4599
 
4356 4600
 	// Any files  to load?
4357
-	if (!empty($file) && is_string($file))
4358
-		$function = $file . (!empty($function) ? '|' . $function : '');
4601
+	if (!empty($file) && is_string($file)) {
4602
+			$function = $file . (!empty($function) ? '|' . $function : '');
4603
+	}
4359 4604
 
4360 4605
 	// Get the correct string.
4361 4606
 	$integration_call = $function;
@@ -4377,13 +4622,14 @@  discard block
 block discarded – undo
4377 4622
 		if (!empty($current_functions))
4378 4623
 		{
4379 4624
 			$current_functions = explode(',', $current_functions);
4380
-			if (in_array($integration_call, $current_functions))
4381
-				return;
4625
+			if (in_array($integration_call, $current_functions)) {
4626
+							return;
4627
+			}
4382 4628
 
4383 4629
 			$permanent_functions = array_merge($current_functions, array($integration_call));
4630
+		} else {
4631
+					$permanent_functions = array($integration_call);
4384 4632
 		}
4385
-		else
4386
-			$permanent_functions = array($integration_call);
4387 4633
 
4388 4634
 		updateSettings(array($hook => implode(',', $permanent_functions)));
4389 4635
 	}
@@ -4392,8 +4638,9 @@  discard block
 block discarded – undo
4392 4638
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4393 4639
 
4394 4640
 	// Do nothing, if it's already there.
4395
-	if (in_array($integration_call, $functions))
4396
-		return;
4641
+	if (in_array($integration_call, $functions)) {
4642
+			return;
4643
+	}
4397 4644
 
4398 4645
 	$functions[] = $integration_call;
4399 4646
 	$modSettings[$hook] = implode(',', $functions);
@@ -4416,12 +4663,14 @@  discard block
 block discarded – undo
4416 4663
 	global $smcFunc, $modSettings;
4417 4664
 
4418 4665
 	// Any objects?
4419
-	if ($object)
4420
-		$function = $function . '#';
4666
+	if ($object) {
4667
+			$function = $function . '#';
4668
+	}
4421 4669
 
4422 4670
 	// Any files  to load?
4423
-	if (!empty($file) && is_string($file))
4424
-		$function = $file . '|' . $function;
4671
+	if (!empty($file) && is_string($file)) {
4672
+			$function = $file . '|' . $function;
4673
+	}
4425 4674
 
4426 4675
 	// Get the correct string.
4427 4676
 	$integration_call = $function;
@@ -4442,16 +4691,18 @@  discard block
 block discarded – undo
4442 4691
 	{
4443 4692
 		$current_functions = explode(',', $current_functions);
4444 4693
 
4445
-		if (in_array($integration_call, $current_functions))
4446
-			updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
4694
+		if (in_array($integration_call, $current_functions)) {
4695
+					updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
4696
+		}
4447 4697
 	}
4448 4698
 
4449 4699
 	// Turn the function list into something usable.
4450 4700
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4451 4701
 
4452 4702
 	// You can only remove it if it's available.
4453
-	if (!in_array($integration_call, $functions))
4454
-		return;
4703
+	if (!in_array($integration_call, $functions)) {
4704
+			return;
4705
+	}
4455 4706
 
4456 4707
 	$functions = array_diff($functions, array($integration_call));
4457 4708
 	$modSettings[$hook] = implode(',', $functions);
@@ -4472,17 +4723,20 @@  discard block
 block discarded – undo
4472 4723
 	global $context, $smcFunc, $txt, $db_show_debug;
4473 4724
 
4474 4725
 	// Really?
4475
-	if (empty($string))
4476
-		return false;
4726
+	if (empty($string)) {
4727
+			return false;
4728
+	}
4477 4729
 
4478 4730
 	// An array? should be a "callable" array IE array(object/class, valid_callable).
4479 4731
 	// A closure? should be a callable one.
4480
-	if (is_array($string) || $string instanceof Closure)
4481
-		return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
4732
+	if (is_array($string) || $string instanceof Closure) {
4733
+			return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
4734
+	}
4482 4735
 
4483 4736
 	// No full objects, sorry! pass a method or a property instead!
4484
-	if (is_object($string))
4485
-		return false;
4737
+	if (is_object($string)) {
4738
+			return false;
4739
+	}
4486 4740
 
4487 4741
 	// Stay vitaminized my friends...
4488 4742
 	$string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string));
@@ -4491,8 +4745,9 @@  discard block
 block discarded – undo
4491 4745
 	$string = load_file($string);
4492 4746
 
4493 4747
 	// Loaded file failed
4494
-	if (empty($string))
4495
-		return false;
4748
+	if (empty($string)) {
4749
+			return false;
4750
+	}
4496 4751
 
4497 4752
 	// Found a method.
4498 4753
 	if (strpos($string, '::') !== false)
@@ -4513,8 +4768,9 @@  discard block
 block discarded – undo
4513 4768
 				// Add another one to the list.
4514 4769
 				if ($db_show_debug === true)
4515 4770
 				{
4516
-					if (!isset($context['debug']['instances']))
4517
-						$context['debug']['instances'] = array();
4771
+					if (!isset($context['debug']['instances'])) {
4772
+											$context['debug']['instances'] = array();
4773
+					}
4518 4774
 
4519 4775
 					$context['debug']['instances'][$class] = $class;
4520 4776
 				}
@@ -4524,13 +4780,15 @@  discard block
 block discarded – undo
4524 4780
 		}
4525 4781
 
4526 4782
 		// Right then. This is a call to a static method.
4527
-		else
4528
-			$func = array($class, $method);
4783
+		else {
4784
+					$func = array($class, $method);
4785
+		}
4529 4786
 	}
4530 4787
 
4531 4788
 	// Nope! just a plain regular function.
4532
-	else
4533
-		$func = $string;
4789
+	else {
4790
+			$func = $string;
4791
+	}
4534 4792
 
4535 4793
 	// Right, we got what we need, time to do some checks.
4536 4794
 	if (!is_callable($func, false, $callable_name))
@@ -4546,17 +4804,18 @@  discard block
 block discarded – undo
4546 4804
 	else
4547 4805
 	{
4548 4806
 		// What are we gonna do about it?
4549
-		if ($return)
4550
-			return $func;
4807
+		if ($return) {
4808
+					return $func;
4809
+		}
4551 4810
 
4552 4811
 		// If this is a plain function, avoid the heat of calling call_user_func().
4553 4812
 		else
4554 4813
 		{
4555
-			if (is_array($func))
4556
-				call_user_func($func);
4557
-
4558
-			else
4559
-				$func();
4814
+			if (is_array($func)) {
4815
+							call_user_func($func);
4816
+			} else {
4817
+							$func();
4818
+			}
4560 4819
 		}
4561 4820
 	}
4562 4821
 }
@@ -4573,31 +4832,34 @@  discard block
 block discarded – undo
4573 4832
 {
4574 4833
 	global $sourcedir, $txt, $boarddir, $settings;
4575 4834
 
4576
-	if (empty($string))
4577
-		return false;
4835
+	if (empty($string)) {
4836
+			return false;
4837
+	}
4578 4838
 
4579 4839
 	if (strpos($string, '|') !== false)
4580 4840
 	{
4581 4841
 		list ($file, $string) = explode('|', $string);
4582 4842
 
4583 4843
 		// Match the wildcards to their regular vars.
4584
-		if (empty($settings['theme_dir']))
4585
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
4586
-
4587
-		else
4588
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
4844
+		if (empty($settings['theme_dir'])) {
4845
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
4846
+		} else {
4847
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
4848
+		}
4589 4849
 
4590 4850
 		// Load the file if it can be loaded.
4591
-		if (file_exists($absPath))
4592
-			require_once($absPath);
4851
+		if (file_exists($absPath)) {
4852
+					require_once($absPath);
4853
+		}
4593 4854
 
4594 4855
 		// No? try a fallback to $sourcedir
4595 4856
 		else
4596 4857
 		{
4597 4858
 			$absPath = $sourcedir .'/'. $file;
4598 4859
 
4599
-			if (file_exists($absPath))
4600
-				require_once($absPath);
4860
+			if (file_exists($absPath)) {
4861
+							require_once($absPath);
4862
+			}
4601 4863
 
4602 4864
 			// Sorry, can't do much for you at this point.
4603 4865
 			else
@@ -4624,8 +4886,9 @@  discard block
 block discarded – undo
4624 4886
 	global $user_info, $smcFunc;
4625 4887
 
4626 4888
 	// Make sure we have something to work with.
4627
-	if (empty($topic))
4628
-		return array();
4889
+	if (empty($topic)) {
4890
+			return array();
4891
+	}
4629 4892
 
4630 4893
 
4631 4894
 	// We already know the number of likes per message, we just want to know whether the current user liked it or not.
@@ -4648,8 +4911,9 @@  discard block
 block discarded – undo
4648 4911
 				'topic' => $topic,
4649 4912
 			)
4650 4913
 		);
4651
-		while ($row = $smcFunc['db_fetch_assoc']($request))
4652
-			$temp[] = (int) $row['content_id'];
4914
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
4915
+					$temp[] = (int) $row['content_id'];
4916
+		}
4653 4917
 
4654 4918
 		cache_put_data($cache_key, $temp, $ttl);
4655 4919
 	}
@@ -4670,8 +4934,9 @@  discard block
 block discarded – undo
4670 4934
 {
4671 4935
 	global $context;
4672 4936
 
4673
-	if (empty($string))
4674
-		return $string;
4937
+	if (empty($string)) {
4938
+			return $string;
4939
+	}
4675 4940
 
4676 4941
 	// UTF-8 occurences of MS special characters
4677 4942
 	$findchars_utf8 = array(
@@ -4712,10 +4977,11 @@  discard block
 block discarded – undo
4712 4977
 		'--',	// &mdash;
4713 4978
 	);
4714 4979
 
4715
-	if ($context['utf8'])
4716
-		$string = str_replace($findchars_utf8, $replacechars, $string);
4717
-	else
4718
-		$string = str_replace($findchars_iso, $replacechars, $string);
4980
+	if ($context['utf8']) {
4981
+			$string = str_replace($findchars_utf8, $replacechars, $string);
4982
+	} else {
4983
+			$string = str_replace($findchars_iso, $replacechars, $string);
4984
+	}
4719 4985
 
4720 4986
 	return $string;
4721 4987
 }
@@ -4734,49 +5000,59 @@  discard block
 block discarded – undo
4734 5000
 {
4735 5001
 	global $context;
4736 5002
 
4737
-	if (!isset($matches[2]))
4738
-		return '';
5003
+	if (!isset($matches[2])) {
5004
+			return '';
5005
+	}
4739 5006
 
4740 5007
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
4741 5008
 
4742 5009
 	// remove left to right / right to left overrides
4743
-	if ($num === 0x202D || $num === 0x202E)
4744
-		return '';
5010
+	if ($num === 0x202D || $num === 0x202E) {
5011
+			return '';
5012
+	}
4745 5013
 
4746 5014
 	// Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced
4747
-	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E)))
4748
-		return '&#' . $num . ';';
5015
+	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) {
5016
+			return '&#' . $num . ';';
5017
+	}
4749 5018
 
4750 5019
 	if (empty($context['utf8']))
4751 5020
 	{
4752 5021
 		// no control characters
4753
-		if ($num < 0x20)
4754
-			return '';
5022
+		if ($num < 0x20) {
5023
+					return '';
5024
+		}
4755 5025
 		// text is text
4756
-		elseif ($num < 0x80)
4757
-			return chr($num);
5026
+		elseif ($num < 0x80) {
5027
+					return chr($num);
5028
+		}
4758 5029
 		// all others get html-ised
4759
-		else
4760
-			return '&#' . $matches[2] . ';';
4761
-	}
4762
-	else
5030
+		else {
5031
+					return '&#' . $matches[2] . ';';
5032
+		}
5033
+	} else
4763 5034
 	{
4764 5035
 		// <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set
4765 5036
 		// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text)
4766
-		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF))
4767
-			return '';
5037
+		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) {
5038
+					return '';
5039
+		}
4768 5040
 		// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
4769
-		elseif ($num < 0x80)
4770
-			return chr($num);
5041
+		elseif ($num < 0x80) {
5042
+					return chr($num);
5043
+		}
4771 5044
 		// <0x800 (2048)
4772
-		elseif ($num < 0x800)
4773
-			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5045
+		elseif ($num < 0x800) {
5046
+					return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5047
+		}
4774 5048
 		// < 0x10000 (65536)
4775
-		elseif ($num < 0x10000)
4776
-			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5049
+		elseif ($num < 0x10000) {
5050
+					return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5051
+		}
4777 5052
 		// <= 0x10FFFF (1114111)
4778
-		else
4779
-			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5053
+		else {
5054
+					return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5055
+		}
4780 5056
 	}
4781 5057
 }
4782 5058
 
@@ -4792,28 +5068,34 @@  discard block
 block discarded – undo
4792 5068
  */
4793 5069
 function fixchar__callback($matches)
4794 5070
 {
4795
-	if (!isset($matches[1]))
4796
-		return '';
5071
+	if (!isset($matches[1])) {
5072
+			return '';
5073
+	}
4797 5074
 
4798 5075
 	$num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1];
4799 5076
 
4800 5077
 	// <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set
4801 5078
 	// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides
4802
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E)
4803
-		return '';
5079
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) {
5080
+			return '';
5081
+	}
4804 5082
 	// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
4805
-	elseif ($num < 0x80)
4806
-		return chr($num);
5083
+	elseif ($num < 0x80) {
5084
+			return chr($num);
5085
+	}
4807 5086
 	// <0x800 (2048)
4808
-	elseif ($num < 0x800)
4809
-		return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5087
+	elseif ($num < 0x800) {
5088
+			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5089
+	}
4810 5090
 	// < 0x10000 (65536)
4811
-	elseif ($num < 0x10000)
4812
-		return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5091
+	elseif ($num < 0x10000) {
5092
+			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5093
+	}
4813 5094
 	// <= 0x10FFFF (1114111)
4814
-	else
4815
-		return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
4816
-}
5095
+	else {
5096
+			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5097
+	}
5098
+	}
4817 5099
 
4818 5100
 /**
4819 5101
  * Strips out invalid html entities, replaces others with html style &#123; codes
@@ -4826,17 +5108,19 @@  discard block
 block discarded – undo
4826 5108
  */
4827 5109
 function entity_fix__callback($matches)
4828 5110
 {
4829
-	if (!isset($matches[2]))
4830
-		return '';
5111
+	if (!isset($matches[2])) {
5112
+			return '';
5113
+	}
4831 5114
 
4832 5115
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
4833 5116
 
4834 5117
 	// we don't allow control characters, characters out of range, byte markers, etc
4835
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E)
4836
-		return '';
4837
-	else
4838
-		return '&#' . $num . ';';
4839
-}
5118
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) {
5119
+			return '';
5120
+	} else {
5121
+			return '&#' . $num . ';';
5122
+	}
5123
+	}
4840 5124
 
4841 5125
 /**
4842 5126
  * Return a Gravatar URL based on
@@ -4860,18 +5144,23 @@  discard block
 block discarded – undo
4860 5144
 		$ratings = array('G', 'PG', 'R', 'X');
4861 5145
 		$defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank');
4862 5146
 		$url_params = array();
4863
-		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings))
4864
-			$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
4865
-		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults))
4866
-			$url_params[] = 'default=' . $modSettings['gravatarDefault'];
4867
-		if (!empty($modSettings['avatar_max_width_external']))
4868
-			$size_string = (int) $modSettings['avatar_max_width_external'];
4869
-		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string))
4870
-			if ((int) $modSettings['avatar_max_height_external'] < $size_string)
5147
+		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) {
5148
+					$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
5149
+		}
5150
+		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) {
5151
+					$url_params[] = 'default=' . $modSettings['gravatarDefault'];
5152
+		}
5153
+		if (!empty($modSettings['avatar_max_width_external'])) {
5154
+					$size_string = (int) $modSettings['avatar_max_width_external'];
5155
+		}
5156
+		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) {
5157
+					if ((int) $modSettings['avatar_max_height_external'] < $size_string)
4871 5158
 				$size_string = $modSettings['avatar_max_height_external'];
5159
+		}
4872 5160
 
4873
-		if (!empty($size_string))
4874
-			$url_params[] = 's=' . $size_string;
5161
+		if (!empty($size_string)) {
5162
+					$url_params[] = 's=' . $size_string;
5163
+		}
4875 5164
 	}
4876 5165
 	$http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www';
4877 5166
 
@@ -4890,22 +5179,26 @@  discard block
 block discarded – undo
4890 5179
 	static $timezones = null, $lastwhen = null;
4891 5180
 
4892 5181
 	// No point doing this over if we already did it once
4893
-	if (!empty($timezones) && $when == $lastwhen)
4894
-		return $timezones;
4895
-	else
4896
-		$lastwhen = $when;
5182
+	if (!empty($timezones) && $when == $lastwhen) {
5183
+			return $timezones;
5184
+	} else {
5185
+			$lastwhen = $when;
5186
+	}
4897 5187
 
4898 5188
 	// Parseable datetime string?
4899
-	if (is_int($timestamp = strtotime($when)))
4900
-		$when = $timestamp;
5189
+	if (is_int($timestamp = strtotime($when))) {
5190
+			$when = $timestamp;
5191
+	}
4901 5192
 
4902 5193
 	// A Unix timestamp?
4903
-	elseif (is_numeric($when))
4904
-		$when = intval($when);
5194
+	elseif (is_numeric($when)) {
5195
+			$when = intval($when);
5196
+	}
4905 5197
 
4906 5198
 	// Invalid value? Just get current Unix timestamp.
4907
-	else
4908
-		$when = time();
5199
+	else {
5200
+			$when = time();
5201
+	}
4909 5202
 
4910 5203
 	// We'll need this too
4911 5204
 	$later = (int) date_format(date_add(date_create('@' . $when), date_interval_create_from_date_string('1 year')), 'U');
@@ -4968,8 +5261,9 @@  discard block
 block discarded – undo
4968 5261
 	foreach ($priority_countries as $country)
4969 5262
 	{
4970 5263
 		$country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country)));
4971
-		if (!empty($country_tzids))
4972
-			$priority_tzids = array_merge($priority_tzids, $country_tzids);
5264
+		if (!empty($country_tzids)) {
5265
+					$priority_tzids = array_merge($priority_tzids, $country_tzids);
5266
+		}
4973 5267
 	}
4974 5268
 
4975 5269
 	// Process the preferred timezones first, then the rest.
@@ -4979,8 +5273,9 @@  discard block
 block discarded – undo
4979 5273
 	foreach ($tzids as $tzid)
4980 5274
 	{
4981 5275
 		// We don't want UTC right now
4982
-		if ($tzid == 'UTC')
4983
-			continue;
5276
+		if ($tzid == 'UTC') {
5277
+					continue;
5278
+		}
4984 5279
 
4985 5280
 		// First, get the set of transition rules for this tzid
4986 5281
 		$tzinfo = timezone_transitions_get(timezone_open($tzid), $when, $later);
@@ -4991,8 +5286,9 @@  discard block
 block discarded – undo
4991 5286
 			$tz_location = timezone_location_get(timezone_open($tzid));
4992 5287
 
4993 5288
 			// Kazakstan
4994
-			if ($tz_location['country_code'] == 'KZ')
4995
-				$tzinfo[0]['abbr'] = str_replace(array('+05', '+06'), array('AQTT', 'ALMT'), $tzinfo[0]['abbr']);
5289
+			if ($tz_location['country_code'] == 'KZ') {
5290
+							$tzinfo[0]['abbr'] = str_replace(array('+05', '+06'), array('AQTT', 'ALMT'), $tzinfo[0]['abbr']);
5291
+			}
4996 5292
 
4997 5293
 			// Russia likes to experiment with time zones
4998 5294
 			if ($tz_location['country_code'] == 'RU')
@@ -5003,19 +5299,22 @@  discard block
 block discarded – undo
5003 5299
 			}
5004 5300
 
5005 5301
 			// Still no good? We'll just mark it as a UTC offset
5006
-			if (strspn($tzinfo[0]['abbr'], '+-') > 0)
5007
-				$tzinfo[0]['abbr'] = 'UTC' . $tzinfo[0]['abbr'];
5302
+			if (strspn($tzinfo[0]['abbr'], '+-') > 0) {
5303
+							$tzinfo[0]['abbr'] = 'UTC' . $tzinfo[0]['abbr'];
5304
+			}
5008 5305
 		}
5009 5306
 
5010 5307
 		$tzkey = serialize($tzinfo);
5011 5308
 
5012 5309
 		// Don't overwrite our preferred tzids
5013
-		if (empty($zones[$tzkey]['tzid']))
5014
-			$zones[$tzkey]['tzid'] = $tzid;
5310
+		if (empty($zones[$tzkey]['tzid'])) {
5311
+					$zones[$tzkey]['tzid'] = $tzid;
5312
+		}
5015 5313
 
5016 5314
 		// A time zone from a prioritized country?
5017
-		if (in_array($tzid, $priority_tzids))
5018
-			$priority_zones[$tzkey] = true;
5315
+		if (in_array($tzid, $priority_tzids)) {
5316
+					$priority_zones[$tzkey] = true;
5317
+		}
5019 5318
 
5020 5319
 		// Keep track of the location and offset for this tzid
5021 5320
 		$tzid_parts = explode('/', $tzid);
@@ -5033,15 +5332,17 @@  discard block
 block discarded – undo
5033 5332
 	{
5034 5333
 		$tzinfo = unserialize($tzkey);
5035 5334
 
5036
-		if (!empty($timezone_descriptions[$tzvalue['tzid']]))
5037
-			$desc = $timezone_descriptions[$tzvalue['tzid']];
5038
-		else
5039
-			$desc = implode(', ', array_unique($tzvalue['locations']));
5335
+		if (!empty($timezone_descriptions[$tzvalue['tzid']])) {
5336
+					$desc = $timezone_descriptions[$tzvalue['tzid']];
5337
+		} else {
5338
+					$desc = implode(', ', array_unique($tzvalue['locations']));
5339
+		}
5040 5340
 
5041
-		if (isset($priority_zones[$tzkey]))
5042
-			$priority_timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format(date_create($tzvalue['tzid']), 'P') . ']';
5043
-		else
5044
-			$timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format(date_create($tzvalue['tzid']), 'P') . ']';
5341
+		if (isset($priority_zones[$tzkey])) {
5342
+					$priority_timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format(date_create($tzvalue['tzid']), 'P') . ']';
5343
+		} else {
5344
+					$timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format(date_create($tzvalue['tzid']), 'P') . ']';
5345
+		}
5045 5346
 	}
5046 5347
 
5047 5348
 	$timezones = array_merge(
@@ -5059,8 +5360,9 @@  discard block
 block discarded – undo
5059 5360
  */
5060 5361
 function inet_ptod($ip_address)
5061 5362
 {
5062
-	if (!isValidIP($ip_address))
5063
-		return $ip_address;
5363
+	if (!isValidIP($ip_address)) {
5364
+			return $ip_address;
5365
+	}
5064 5366
 
5065 5367
 	$bin = inet_pton($ip_address);
5066 5368
 	return $bin;
@@ -5072,13 +5374,15 @@  discard block
 block discarded – undo
5072 5374
  */
5073 5375
 function inet_dtop($bin)
5074 5376
 {
5075
-	if(empty($bin))
5076
-		return '';
5377
+	if(empty($bin)) {
5378
+			return '';
5379
+	}
5077 5380
 
5078 5381
 	global $db_type;
5079 5382
 
5080
-	if ($db_type == 'postgresql')
5081
-		return $bin;
5383
+	if ($db_type == 'postgresql') {
5384
+			return $bin;
5385
+	}
5082 5386
 
5083 5387
 	$ip_address = inet_ntop($bin);
5084 5388
 
@@ -5103,26 +5407,32 @@  discard block
 block discarded – undo
5103 5407
  */
5104 5408
 function _safe_serialize($value)
5105 5409
 {
5106
-	if(is_null($value))
5107
-		return 'N;';
5410
+	if(is_null($value)) {
5411
+			return 'N;';
5412
+	}
5108 5413
 
5109
-	if(is_bool($value))
5110
-		return 'b:'. (int) $value .';';
5414
+	if(is_bool($value)) {
5415
+			return 'b:'. (int) $value .';';
5416
+	}
5111 5417
 
5112
-	if(is_int($value))
5113
-		return 'i:'. $value .';';
5418
+	if(is_int($value)) {
5419
+			return 'i:'. $value .';';
5420
+	}
5114 5421
 
5115
-	if(is_float($value))
5116
-		return 'd:'. str_replace(',', '.', $value) .';';
5422
+	if(is_float($value)) {
5423
+			return 'd:'. str_replace(',', '.', $value) .';';
5424
+	}
5117 5425
 
5118
-	if(is_string($value))
5119
-		return 's:'. strlen($value) .':"'. $value .'";';
5426
+	if(is_string($value)) {
5427
+			return 's:'. strlen($value) .':"'. $value .'";';
5428
+	}
5120 5429
 
5121 5430
 	if(is_array($value))
5122 5431
 	{
5123 5432
 		$out = '';
5124
-		foreach($value as $k => $v)
5125
-			$out .= _safe_serialize($k) . _safe_serialize($v);
5433
+		foreach($value as $k => $v) {
5434
+					$out .= _safe_serialize($k) . _safe_serialize($v);
5435
+		}
5126 5436
 
5127 5437
 		return 'a:'. count($value) .':{'. $out .'}';
5128 5438
 	}
@@ -5148,8 +5458,9 @@  discard block
 block discarded – undo
5148 5458
 
5149 5459
 	$out = _safe_serialize($value);
5150 5460
 
5151
-	if (isset($mbIntEnc))
5152
-		mb_internal_encoding($mbIntEnc);
5461
+	if (isset($mbIntEnc)) {
5462
+			mb_internal_encoding($mbIntEnc);
5463
+	}
5153 5464
 
5154 5465
 	return $out;
5155 5466
 }
@@ -5166,8 +5477,9 @@  discard block
 block discarded – undo
5166 5477
 function _safe_unserialize($str)
5167 5478
 {
5168 5479
 	// Input  is not a string.
5169
-	if(empty($str) || !is_string($str))
5170
-		return false;
5480
+	if(empty($str) || !is_string($str)) {
5481
+			return false;
5482
+	}
5171 5483
 
5172 5484
 	$stack = array();
5173 5485
 	$expected = array();
@@ -5183,43 +5495,38 @@  discard block
 block discarded – undo
5183 5495
 	while($state != 1)
5184 5496
 	{
5185 5497
 		$type = isset($str[0]) ? $str[0] : '';
5186
-		if($type == '}')
5187
-			$str = substr($str, 1);
5188
-
5189
-		else if($type == 'N' && $str[1] == ';')
5498
+		if($type == '}') {
5499
+					$str = substr($str, 1);
5500
+		} else if($type == 'N' && $str[1] == ';')
5190 5501
 		{
5191 5502
 			$value = null;
5192 5503
 			$str = substr($str, 2);
5193
-		}
5194
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5504
+		} else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5195 5505
 		{
5196 5506
 			$value = $matches[1] == '1' ? true : false;
5197 5507
 			$str = substr($str, 4);
5198
-		}
5199
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5508
+		} else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5200 5509
 		{
5201 5510
 			$value = (int)$matches[1];
5202 5511
 			$str = $matches[2];
5203
-		}
5204
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5512
+		} else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5205 5513
 		{
5206 5514
 			$value = (float)$matches[1];
5207 5515
 			$str = $matches[3];
5208
-		}
5209
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5516
+		} else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5210 5517
 		{
5211 5518
 			$value = substr($matches[2], 0, (int)$matches[1]);
5212 5519
 			$str = substr($matches[2], (int)$matches[1] + 2);
5213
-		}
5214
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5520
+		} else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5215 5521
 		{
5216 5522
 			$expectedLength = (int)$matches[1];
5217 5523
 			$str = $matches[2];
5218 5524
 		}
5219 5525
 
5220 5526
 		// Object or unknown/malformed type.
5221
-		else
5222
-			return false;
5527
+		else {
5528
+					return false;
5529
+		}
5223 5530
 
5224 5531
 		switch($state)
5225 5532
 		{
@@ -5247,8 +5554,9 @@  discard block
 block discarded – undo
5247 5554
 				if($type == '}')
5248 5555
 				{
5249 5556
 					// Array size is less than expected.
5250
-					if(count($list) < end($expected))
5251
-						return false;
5557
+					if(count($list) < end($expected)) {
5558
+											return false;
5559
+					}
5252 5560
 
5253 5561
 					unset($list);
5254 5562
 					$list = &$stack[count($stack)-1];
@@ -5257,8 +5565,9 @@  discard block
 block discarded – undo
5257 5565
 					// Go to terminal state if we're at the end of the root array.
5258 5566
 					array_pop($expected);
5259 5567
 
5260
-					if(count($expected) == 0)
5261
-						$state = 1;
5568
+					if(count($expected) == 0) {
5569
+											$state = 1;
5570
+					}
5262 5571
 
5263 5572
 					break;
5264 5573
 				}
@@ -5266,8 +5575,9 @@  discard block
 block discarded – undo
5266 5575
 				if($type == 'i' || $type == 's')
5267 5576
 				{
5268 5577
 					// Array size exceeds expected length.
5269
-					if(count($list) >= end($expected))
5270
-						return false;
5578
+					if(count($list) >= end($expected)) {
5579
+											return false;
5580
+					}
5271 5581
 
5272 5582
 					$key = $value;
5273 5583
 					$state = 3;
@@ -5301,8 +5611,9 @@  discard block
 block discarded – undo
5301 5611
 	}
5302 5612
 
5303 5613
 	// Trailing data in input.
5304
-	if(!empty($str))
5305
-		return false;
5614
+	if(!empty($str)) {
5615
+			return false;
5616
+	}
5306 5617
 
5307 5618
 	return $data;
5308 5619
 }
@@ -5325,8 +5636,9 @@  discard block
 block discarded – undo
5325 5636
 
5326 5637
 	$out = _safe_unserialize($str);
5327 5638
 
5328
-	if (isset($mbIntEnc))
5329
-		mb_internal_encoding($mbIntEnc);
5639
+	if (isset($mbIntEnc)) {
5640
+			mb_internal_encoding($mbIntEnc);
5641
+	}
5330 5642
 
5331 5643
 	return $out;
5332 5644
 }
@@ -5341,12 +5653,14 @@  discard block
 block discarded – undo
5341 5653
 function smf_chmod($file, $value = 0)
5342 5654
 {
5343 5655
 	// No file? no checks!
5344
-	if (empty($file))
5345
-		return false;
5656
+	if (empty($file)) {
5657
+			return false;
5658
+	}
5346 5659
 
5347 5660
 	// Already writable?
5348
-	if (is_writable($file))
5349
-		return true;
5661
+	if (is_writable($file)) {
5662
+			return true;
5663
+	}
5350 5664
 
5351 5665
 	// Do we have a file or a dir?
5352 5666
 	$isDir = is_dir($file);
@@ -5362,10 +5676,9 @@  discard block
 block discarded – undo
5362 5676
 		{
5363 5677
 			$isWritable = true;
5364 5678
 			break;
5679
+		} else {
5680
+					@chmod($file, $val);
5365 5681
 		}
5366
-
5367
-		else
5368
-			@chmod($file, $val);
5369 5682
 	}
5370 5683
 
5371 5684
 	return $isWritable;
@@ -5384,8 +5697,9 @@  discard block
 block discarded – undo
5384 5697
 	global $txt;
5385 5698
 
5386 5699
 	// Come on...
5387
-	if (empty($json) || !is_string($json))
5388
-		return array();
5700
+	if (empty($json) || !is_string($json)) {
5701
+			return array();
5702
+	}
5389 5703
 
5390 5704
 	$returnArray = @json_decode($json, $returnAsArray);
5391 5705
 
@@ -5423,11 +5737,11 @@  discard block
 block discarded – undo
5423 5737
 		$jsonDebug = $jsonDebug[0];
5424 5738
 		loadLanguage('Errors');
5425 5739
 
5426
-		if (!empty($jsonDebug))
5427
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5428
-
5429
-		else
5430
-			log_error($txt['json_'. $jsonError], 'critical');
5740
+		if (!empty($jsonDebug)) {
5741
+					log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5742
+		} else {
5743
+					log_error($txt['json_'. $jsonError], 'critical');
5744
+		}
5431 5745
 
5432 5746
 		// Everyone expects an array.
5433 5747
 		return array();
@@ -5457,8 +5771,9 @@  discard block
 block discarded – undo
5457 5771
 	global $db_show_debug, $modSettings;
5458 5772
 
5459 5773
 	// Defensive programming anyone?
5460
-	if (empty($data))
5461
-		return false;
5774
+	if (empty($data)) {
5775
+			return false;
5776
+	}
5462 5777
 
5463 5778
 	// Don't need extra stuff...
5464 5779
 	$db_show_debug = false;
@@ -5466,11 +5781,11 @@  discard block
 block discarded – undo
5466 5781
 	// Kill anything else.
5467 5782
 	ob_end_clean();
5468 5783
 
5469
-	if (!empty($modSettings['CompressedOutput']))
5470
-		@ob_start('ob_gzhandler');
5471
-
5472
-	else
5473
-		ob_start();
5784
+	if (!empty($modSettings['CompressedOutput'])) {
5785
+			@ob_start('ob_gzhandler');
5786
+	} else {
5787
+			ob_start();
5788
+	}
5474 5789
 
5475 5790
 	// Set the header.
5476 5791
 	header($type);
@@ -5502,8 +5817,9 @@  discard block
 block discarded – undo
5502 5817
 	static $done = false;
5503 5818
 
5504 5819
 	// If we don't need to do anything, don't
5505
-	if (!$update && $done)
5506
-		return;
5820
+	if (!$update && $done) {
5821
+			return;
5822
+	}
5507 5823
 
5508 5824
 	// Should we get a new copy of the official list of TLDs?
5509 5825
 	if ($update)
@@ -5524,10 +5840,11 @@  discard block
 block discarded – undo
5524 5840
 		// Clean $tlds and convert it to an array
5525 5841
 		$tlds = array_filter(explode("\n", strtolower($tlds)), function($line) {
5526 5842
 			$line = trim($line);
5527
-			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false)
5528
-				return false;
5529
-			else
5530
-				return true;
5843
+			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) {
5844
+							return false;
5845
+			} else {
5846
+							return true;
5847
+			}
5531 5848
 		});
5532 5849
 
5533 5850
 		// Convert Punycode to Unicode
@@ -5581,8 +5898,9 @@  discard block
 block discarded – undo
5581 5898
 						$idx += $digit * $w;
5582 5899
 						$t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias));
5583 5900
 
5584
-						if ($digit < $t)
5585
-							break;
5901
+						if ($digit < $t) {
5902
+													break;
5903
+						}
5586 5904
 
5587 5905
 						$w = (int) ($w * ($base - $t));
5588 5906
 					}
@@ -5591,8 +5909,9 @@  discard block
 block discarded – undo
5591 5909
 					$delta = intval($is_first ? ($delta / $damp) : ($delta / 2));
5592 5910
 					$delta += intval($delta / ($deco_len + 1));
5593 5911
 
5594
-					for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base)
5595
-						$delta = intval($delta / ($base - $tmin));
5912
+					for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) {
5913
+											$delta = intval($delta / ($base - $tmin));
5914
+					}
5596 5915
 
5597 5916
 					$bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew));
5598 5917
 					$is_first = false;
@@ -5601,8 +5920,9 @@  discard block
 block discarded – undo
5601 5920
 
5602 5921
 					if ($deco_len > 0)
5603 5922
 					{
5604
-						for ($i = $deco_len; $i > $idx; $i--)
5605
-							$decoded[$i] = $decoded[($i - 1)];
5923
+						for ($i = $deco_len; $i > $idx; $i--) {
5924
+													$decoded[$i] = $decoded[($i - 1)];
5925
+						}
5606 5926
 					}
5607 5927
 					$decoded[$idx++] = $char;
5608 5928
 				}
@@ -5610,24 +5930,29 @@  discard block
 block discarded – undo
5610 5930
 				foreach ($decoded as $k => $v)
5611 5931
 				{
5612 5932
 					// 7bit are transferred literally
5613
-					if ($v < 128)
5614
-						$output .= chr($v);
5933
+					if ($v < 128) {
5934
+											$output .= chr($v);
5935
+					}
5615 5936
 
5616 5937
 					// 2 bytes
5617
-					elseif ($v < (1 << 11))
5618
-						$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
5938
+					elseif ($v < (1 << 11)) {
5939
+											$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
5940
+					}
5619 5941
 
5620 5942
 					// 3 bytes
5621
-					elseif ($v < (1 << 16))
5622
-						$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5943
+					elseif ($v < (1 << 16)) {
5944
+											$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5945
+					}
5623 5946
 
5624 5947
 					// 4 bytes
5625
-					elseif ($v < (1 << 21))
5626
-						$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5948
+					elseif ($v < (1 << 21)) {
5949
+											$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5950
+					}
5627 5951
 
5628 5952
 					//  'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k
5629
-					else
5630
-						$output .= $safe_char;
5953
+					else {
5954
+											$output .= $safe_char;
5955
+					}
5631 5956
 				}
5632 5957
 
5633 5958
 				$output_parts[] = $output;
@@ -5722,8 +6047,7 @@  discard block
 block discarded – undo
5722 6047
 
5723 6048
 		$strlen = 'mb_strlen';
5724 6049
 		$substr = 'mb_substr';
5725
-	}
5726
-	else
6050
+	} else
5727 6051
 	{
5728 6052
 		$strlen = $smcFunc['strlen'];
5729 6053
 		$substr = $smcFunc['substr'];
@@ -5737,20 +6061,21 @@  discard block
 block discarded – undo
5737 6061
 
5738 6062
 		$first = $substr($string, 0, 1);
5739 6063
 
5740
-		if (empty($index[$first]))
5741
-			$index[$first] = array();
6064
+		if (empty($index[$first])) {
6065
+					$index[$first] = array();
6066
+		}
5742 6067
 
5743 6068
 		if ($strlen($string) > 1)
5744 6069
 		{
5745 6070
 			// Sanity check on recursion
5746
-			if ($depth > 99)
5747
-				$index[$first][$substr($string, 1)] = '';
5748
-
5749
-			else
5750
-				$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6071
+			if ($depth > 99) {
6072
+							$index[$first][$substr($string, 1)] = '';
6073
+			} else {
6074
+							$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6075
+			}
6076
+		} else {
6077
+					$index[$first][''] = '';
5751 6078
 		}
5752
-		else
5753
-			$index[$first][''] = '';
5754 6079
 
5755 6080
 		$depth--;
5756 6081
 		return $index;
@@ -5773,9 +6098,9 @@  discard block
 block discarded – undo
5773 6098
 			$key_regex = preg_quote($key, $delim);
5774 6099
 			$new_key = $key;
5775 6100
 
5776
-			if (empty($value))
5777
-				$sub_regex = '';
5778
-			else
6101
+			if (empty($value)) {
6102
+							$sub_regex = '';
6103
+			} else
5779 6104
 			{
5780 6105
 				$sub_regex = $index_to_regex($value, $delim);
5781 6106
 
@@ -5783,22 +6108,22 @@  discard block
 block discarded – undo
5783 6108
 				{
5784 6109
 					$new_key_array = explode('(?'.'>', $sub_regex);
5785 6110
 					$new_key .= $new_key_array[0];
6111
+				} else {
6112
+									$sub_regex = '(?'.'>' . $sub_regex . ')';
5786 6113
 				}
5787
-				else
5788
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
5789 6114
 			}
5790 6115
 
5791
-			if ($depth > 1)
5792
-				$regex[$new_key] = $key_regex . $sub_regex;
5793
-			else
6116
+			if ($depth > 1) {
6117
+							$regex[$new_key] = $key_regex . $sub_regex;
6118
+			} else
5794 6119
 			{
5795 6120
 				if (($length += strlen($key_regex) + 1) < $max_length || empty($regex))
5796 6121
 				{
5797 6122
 					$regex[$new_key] = $key_regex . $sub_regex;
5798 6123
 					unset($index[$key]);
6124
+				} else {
6125
+									break;
5799 6126
 				}
5800
-				else
5801
-					break;
5802 6127
 			}
5803 6128
 		}
5804 6129
 
@@ -5807,10 +6132,11 @@  discard block
 block discarded – undo
5807 6132
 			$l1 = $strlen($k1);
5808 6133
 			$l2 = $strlen($k2);
5809 6134
 
5810
-			if ($l1 == $l2)
5811
-				return strcmp($k1, $k2) > 0 ? 1 : -1;
5812
-			else
5813
-				return $l1 > $l2 ? -1 : 1;
6135
+			if ($l1 == $l2) {
6136
+							return strcmp($k1, $k2) > 0 ? 1 : -1;
6137
+			} else {
6138
+							return $l1 > $l2 ? -1 : 1;
6139
+			}
5814 6140
 		});
5815 6141
 
5816 6142
 		$depth--;
@@ -5821,15 +6147,18 @@  discard block
 block discarded – undo
5821 6147
 	$index = array();
5822 6148
 	$regexes = array();
5823 6149
 
5824
-	foreach ($strings as $string)
5825
-		$index = $add_string_to_index($string, $index);
6150
+	foreach ($strings as $string) {
6151
+			$index = $add_string_to_index($string, $index);
6152
+	}
5826 6153
 
5827
-	while (!empty($index))
5828
-		$regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6154
+	while (!empty($index)) {
6155
+			$regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6156
+	}
5829 6157
 
5830 6158
 	// Restore PHP's internal character encoding to whatever it was originally
5831
-	if (!empty($current_encoding))
5832
-		mb_internal_encoding($current_encoding);
6159
+	if (!empty($current_encoding)) {
6160
+			mb_internal_encoding($current_encoding);
6161
+	}
5833 6162
 
5834 6163
 	return $regexes;
5835 6164
 }
Please login to merge, or discard this patch.
Spacing   +116 added lines, -116 removed lines patch added patch discarded remove patch
@@ -1097,7 +1097,7 @@  discard block
 block discarded – undo
1097 1097
 					'height' => array('optional' => true, 'match' => '(\d+)'),
1098 1098
 				),
1099 1099
 				'content' => '$1',
1100
-				'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1100
+				'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1101 1101
 				{
1102 1102
 					$returnContext = '';
1103 1103
 
@@ -1132,7 +1132,7 @@  discard block
 block discarded – undo
1132 1132
 						}
1133 1133
 
1134 1134
 						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1135
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '"></a>';
1135
+							$returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '"></a>';
1136 1136
 						else
1137 1137
 							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . '/>';
1138 1138
 					}
@@ -1161,7 +1161,7 @@  discard block
 block discarded – undo
1161 1161
 				'type' => 'unparsed_content',
1162 1162
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1163 1163
 				// @todo Maybe this can be simplified?
1164
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1164
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1165 1165
 				{
1166 1166
 					if (!isset($disabled['code']))
1167 1167
 					{
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
 				'type' => 'unparsed_equals_content',
1199 1199
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1200 1200
 				// @todo Maybe this can be simplified?
1201
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1201
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1202 1202
 				{
1203 1203
 					if (!isset($disabled['code']))
1204 1204
 					{
@@ -1242,7 +1242,7 @@  discard block
 block discarded – undo
1242 1242
 				'type' => 'unparsed_content',
1243 1243
 				'content' => '<a href="mailto:$1" class="bbc_email">$1</a>',
1244 1244
 				// @todo Should this respect guest_hideContacts?
1245
-				'validate' => function (&$tag, &$data, $disabled)
1245
+				'validate' => function(&$tag, &$data, $disabled)
1246 1246
 				{
1247 1247
 					$data = strtr($data, array('<br>' => ''));
1248 1248
 				},
@@ -1261,7 +1261,7 @@  discard block
 block discarded – undo
1261 1261
 				'type' => 'unparsed_commas_content',
1262 1262
 				'test' => '\d+,\d+\]',
1263 1263
 				'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">',
1264
-				'validate' => function (&$tag, &$data, $disabled)
1264
+				'validate' => function(&$tag, &$data, $disabled)
1265 1265
 				{
1266 1266
 					if (isset($disabled['url']))
1267 1267
 						$tag['content'] = '$1';
@@ -1306,7 +1306,7 @@  discard block
 block discarded – undo
1306 1306
 					'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
1307 1307
 				),
1308 1308
 				'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',
1309
-				'validate' => function (&$tag, &$data, $disabled)
1309
+				'validate' => function(&$tag, &$data, $disabled)
1310 1310
 				{
1311 1311
 					global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1312 1312
 
@@ -1329,7 +1329,7 @@  discard block
 block discarded – undo
1329 1329
 				'tag' => 'img',
1330 1330
 				'type' => 'unparsed_content',
1331 1331
 				'content' => '<img src="$1" alt="" class="bbc_img">',
1332
-				'validate' => function (&$tag, &$data, $disabled)
1332
+				'validate' => function(&$tag, &$data, $disabled)
1333 1333
 				{
1334 1334
 					global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1335 1335
 
@@ -1352,7 +1352,7 @@  discard block
 block discarded – undo
1352 1352
 				'tag' => 'iurl',
1353 1353
 				'type' => 'unparsed_content',
1354 1354
 				'content' => '<a href="$1" class="bbc_link">$1</a>',
1355
-				'validate' => function (&$tag, &$data, $disabled)
1355
+				'validate' => function(&$tag, &$data, $disabled)
1356 1356
 				{
1357 1357
 					$data = strtr($data, array('<br>' => ''));
1358 1358
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1366,7 +1366,7 @@  discard block
 block discarded – undo
1366 1366
 				'quoted' => 'optional',
1367 1367
 				'before' => '<a href="$1" class="bbc_link">',
1368 1368
 				'after' => '</a>',
1369
-				'validate' => function (&$tag, &$data, $disabled)
1369
+				'validate' => function(&$tag, &$data, $disabled)
1370 1370
 				{
1371 1371
 					if (substr($data, 0, 1) == '#')
1372 1372
 						$data = '#post_' . substr($data, 1);
@@ -1446,7 +1446,7 @@  discard block
 block discarded – undo
1446 1446
 				'tag' => 'php',
1447 1447
 				'type' => 'unparsed_content',
1448 1448
 				'content' => '<span class="phpcode">$1</span>',
1449
-				'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled)
1449
+				'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled)
1450 1450
 				{
1451 1451
 					if (!isset($disabled['php']))
1452 1452
 					{
@@ -1544,7 +1544,7 @@  discard block
 block discarded – undo
1544 1544
 				'test' => '[1-7]\]',
1545 1545
 				'before' => '<span style="font-size: $1;" class="bbc_size">',
1546 1546
 				'after' => '</span>',
1547
-				'validate' => function (&$tag, &$data, $disabled)
1547
+				'validate' => function(&$tag, &$data, $disabled)
1548 1548
 				{
1549 1549
 					$sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95);
1550 1550
 					$data = $sizes[$data] . 'em';
@@ -1582,7 +1582,7 @@  discard block
 block discarded – undo
1582 1582
 				'tag' => 'time',
1583 1583
 				'type' => 'unparsed_content',
1584 1584
 				'content' => '$1',
1585
-				'validate' => function (&$tag, &$data, $disabled)
1585
+				'validate' => function(&$tag, &$data, $disabled)
1586 1586
 				{
1587 1587
 					if (is_numeric($data))
1588 1588
 						$data = timeformat($data);
@@ -1610,7 +1610,7 @@  discard block
 block discarded – undo
1610 1610
 				'tag' => 'url',
1611 1611
 				'type' => 'unparsed_content',
1612 1612
 				'content' => '<a href="$1" class="bbc_link" target="_blank">$1</a>',
1613
-				'validate' => function (&$tag, &$data, $disabled)
1613
+				'validate' => function(&$tag, &$data, $disabled)
1614 1614
 				{
1615 1615
 					$data = strtr($data, array('<br>' => ''));
1616 1616
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1624,7 +1624,7 @@  discard block
 block discarded – undo
1624 1624
 				'quoted' => 'optional',
1625 1625
 				'before' => '<a href="$1" class="bbc_link" target="_blank">',
1626 1626
 				'after' => '</a>',
1627
-				'validate' => function (&$tag, &$data, $disabled)
1627
+				'validate' => function(&$tag, &$data, $disabled)
1628 1628
 				{
1629 1629
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1630 1630
 					if (empty($scheme))
@@ -1650,7 +1650,7 @@  discard block
 block discarded – undo
1650 1650
 		{
1651 1651
 			if (isset($temp_bbc))
1652 1652
 				$bbc_codes = $temp_bbc;
1653
-			usort($codes, function ($a, $b) {
1653
+			usort($codes, function($a, $b) {
1654 1654
 				return strcmp($a['tag'], $b['tag']);
1655 1655
 			});
1656 1656
 			return $codes;
@@ -1888,7 +1888,7 @@  discard block
 block discarded – undo
1888 1888
 										# a run of Unicode domain name characters and a dot
1889 1889
 										[\p{L}\p{M}\p{N}\-.:@]+\.
1890 1890
 										# and then a TLD valid in the DNS or the reserved "local" TLD
1891
-										(?:'. $modSettings['tld_regex'] .'|local)
1891
+										(?:'. $modSettings['tld_regex'] . '|local)
1892 1892
 									)
1893 1893
 									# followed by a non-domain character or end of line
1894 1894
 									(?=[^\p{L}\p{N}\-.]|$)
@@ -1956,7 +1956,7 @@  discard block
 block discarded – undo
1956 1956
 						)?
1957 1957
 						';
1958 1958
 
1959
-						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) {
1959
+						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) {
1960 1960
 							$url = array_shift($matches);
1961 1961
 
1962 1962
 							$scheme = parse_url($url, PHP_URL_SCHEME);
@@ -2685,7 +2685,7 @@  discard block
 block discarded – undo
2685 2685
 		for ($i = 0, $n = count($smileysfrom); $i < $n; $i++)
2686 2686
 		{
2687 2687
 			$specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES);
2688
-			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2688
+			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2689 2689
 
2690 2690
 			$smileyPregReplacements[$smileysfrom[$i]] = $smileyCode;
2691 2691
 
@@ -2702,7 +2702,7 @@  discard block
 block discarded – undo
2702 2702
 
2703 2703
 	// Replace away!
2704 2704
 	$message = preg_replace_callback($smileyPregSearch,
2705
-		function ($matches) use ($smileyPregReplacements)
2705
+		function($matches) use ($smileyPregReplacements)
2706 2706
 		{
2707 2707
 			return $smileyPregReplacements[$matches[1]];
2708 2708
 		}, $message);
@@ -2768,13 +2768,13 @@  discard block
 block discarded – undo
2768 2768
 	{
2769 2769
 		if (defined('SID') && SID != '')
2770 2770
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2771
-				function ($m) use ($scripturl)
2771
+				function($m) use ($scripturl)
2772 2772
 				{
2773
-					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
2773
+					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : "");
2774 2774
 				}, $setLocation);
2775 2775
 		else
2776 2776
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2777
-				function ($m) use ($scripturl)
2777
+				function($m) use ($scripturl)
2778 2778
 				{
2779 2779
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
2780 2780
 				}, $setLocation);
@@ -3097,7 +3097,7 @@  discard block
 block discarded – undo
3097 3097
 
3098 3098
 	// Add a generic "Are you sure?" confirmation message.
3099 3099
 	addInlineJavaScript('
3100
-	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3100
+	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';');
3101 3101
 
3102 3102
 	// Now add the capping code for avatars.
3103 3103
 	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
@@ -3458,7 +3458,7 @@  discard block
 block discarded – undo
3458 3458
 
3459 3459
 		else
3460 3460
 			echo '
3461
-	<script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>';
3461
+	<script src="', $settings['theme_url'], '/scripts/minified', ($do_deferred ? '_deferred' : ''), '.js', $minSeed, '"></script>';
3462 3462
 	}
3463 3463
 
3464 3464
 	// Inline JavaScript - Actually useful some times!
@@ -3536,14 +3536,14 @@  discard block
 block discarded – undo
3536 3536
 
3537 3537
 		else
3538 3538
 			echo '
3539
-	<link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">';
3539
+	<link rel="stylesheet" href="', $settings['theme_url'], '/css/minified.css', $minSeed, '">';
3540 3540
 	}
3541 3541
 
3542 3542
 	// Print the rest after the minified files.
3543 3543
 	if (!empty($normal))
3544 3544
 		foreach ($normal as $nf)
3545 3545
 			echo '
3546
-	<link rel="stylesheet" href="', $nf ,'">';
3546
+	<link rel="stylesheet" href="', $nf, '">';
3547 3547
 
3548 3548
 	if ($db_show_debug === true)
3549 3549
 	{
@@ -3559,7 +3559,7 @@  discard block
 block discarded – undo
3559 3559
 	<style>';
3560 3560
 
3561 3561
 		foreach ($context['css_header'] as $css)
3562
-			echo $css .'
3562
+			echo $css . '
3563 3563
 	';
3564 3564
 
3565 3565
 		echo'
@@ -3588,27 +3588,27 @@  discard block
 block discarded – undo
3588 3588
 		return false;
3589 3589
 
3590 3590
 	// Did we already did this?
3591
-	$toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400);
3591
+	$toCache = cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type, 86400);
3592 3592
 
3593 3593
 	// Already done?
3594 3594
 	if (!empty($toCache))
3595 3595
 		return true;
3596 3596
 
3597 3597
 	// No namespaces, sorry!
3598
-	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
3598
+	$classType = 'MatthiasMullie\\Minify\\' . strtoupper($type);
3599 3599
 
3600 3600
 	// Temp path.
3601
-	$cTempPath = $settings['theme_dir'] .'/'. ($type == 'css' ? 'css' : 'scripts') .'/';
3601
+	$cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/';
3602 3602
 
3603 3603
 	// What kind of file are we going to create?
3604
-	$toCreate = $cTempPath .'minified'. ($do_deferred ? '_deferred' : '') .'.'. $type;
3604
+	$toCreate = $cTempPath . 'minified' . ($do_deferred ? '_deferred' : '') . '.' . $type;
3605 3605
 
3606 3606
 	// File has to exists, if it isn't try to create it.
3607 3607
 	if ((!file_exists($toCreate) && @fopen($toCreate, 'w') === false) || !smf_chmod($toCreate))
3608 3608
 	{
3609 3609
 		loadLanguage('Errors');
3610 3610
 		log_error(sprintf($txt['file_not_created'], $toCreate), 'general');
3611
-		cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null);
3611
+		cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null);
3612 3612
 
3613 3613
 		// The process failed so roll back to print each individual file.
3614 3614
 		return $data;
@@ -3643,14 +3643,14 @@  discard block
 block discarded – undo
3643 3643
 	{
3644 3644
 		loadLanguage('Errors');
3645 3645
 		log_error(sprintf($txt['file_not_created'], $toCreate), 'general');
3646
-		cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null);
3646
+		cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null);
3647 3647
 
3648 3648
 		// The process failed so roll back to print each individual file.
3649 3649
 		return $data;
3650 3650
 	}
3651 3651
 
3652 3652
 	// And create a long lived cache entry.
3653
-	cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, $toCreate, 86400);
3653
+	cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, $toCreate, 86400);
3654 3654
 
3655 3655
 	return true;
3656 3656
 }
@@ -3707,7 +3707,7 @@  discard block
 block discarded – undo
3707 3707
 	else
3708 3708
 		$path = $modSettings['attachmentUploadDir'];
3709 3709
 
3710
-	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
3710
+	return $path . '/' . $attachment_id . '_' . $file_hash . '.dat';
3711 3711
 }
3712 3712
 
3713 3713
 /**
@@ -3751,10 +3751,10 @@  discard block
 block discarded – undo
3751 3751
 		$valid_low = isValidIP($ip_parts[0]);
3752 3752
 		$valid_high = isValidIP($ip_parts[1]);
3753 3753
 		$count = 0;
3754
-		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
3754
+		$mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.');
3755 3755
 		$max = ($mode == ':' ? 'ffff' : '255');
3756 3756
 		$min = 0;
3757
-		if(!$valid_low)
3757
+		if (!$valid_low)
3758 3758
 		{
3759 3759
 			$ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]);
3760 3760
 			$valid_low = isValidIP($ip_parts[0]);
@@ -3768,7 +3768,7 @@  discard block
 block discarded – undo
3768 3768
 		}
3769 3769
 
3770 3770
 		$count = 0;
3771
-		if(!$valid_high)
3771
+		if (!$valid_high)
3772 3772
 		{
3773 3773
 			$ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]);
3774 3774
 			$valid_high = isValidIP($ip_parts[1]);
@@ -3781,7 +3781,7 @@  discard block
 block discarded – undo
3781 3781
 			}
3782 3782
 		}
3783 3783
 
3784
-		if($valid_high && $valid_low)
3784
+		if ($valid_high && $valid_low)
3785 3785
 		{
3786 3786
 			$ip_array['low'] = $ip_parts[0];
3787 3787
 			$ip_array['high'] = $ip_parts[1];
@@ -3963,7 +3963,7 @@  discard block
 block discarded – undo
3963 3963
 		addInlineJavaScript('
3964 3964
 	var user_menus = new smc_PopupMenu();
3965 3965
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
3966
-	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
3966
+	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true);
3967 3967
 		if ($context['allow_pm'])
3968 3968
 			addInlineJavaScript('
3969 3969
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
@@ -4588,7 +4588,7 @@  discard block
 block discarded – undo
4588 4588
 		// No? try a fallback to $sourcedir
4589 4589
 		else
4590 4590
 		{
4591
-			$absPath = $sourcedir .'/'. $file;
4591
+			$absPath = $sourcedir . '/' . $file;
4592 4592
 
4593 4593
 			if (file_exists($absPath))
4594 4594
 				require_once($absPath);
@@ -4669,15 +4669,15 @@  discard block
 block discarded – undo
4669 4669
 
4670 4670
 	// UTF-8 occurences of MS special characters
4671 4671
 	$findchars_utf8 = array(
4672
-		"\xe2\80\x9a",	// single low-9 quotation mark
4673
-		"\xe2\80\x9e",	// double low-9 quotation mark
4674
-		"\xe2\80\xa6",	// horizontal ellipsis
4675
-		"\xe2\x80\x98",	// left single curly quote
4676
-		"\xe2\x80\x99",	// right single curly quote
4677
-		"\xe2\x80\x9c",	// left double curly quote
4678
-		"\xe2\x80\x9d",	// right double curly quote
4679
-		"\xe2\x80\x93",	// en dash
4680
-		"\xe2\x80\x94",	// em dash
4672
+		"\xe2\80\x9a", // single low-9 quotation mark
4673
+		"\xe2\80\x9e", // double low-9 quotation mark
4674
+		"\xe2\80\xa6", // horizontal ellipsis
4675
+		"\xe2\x80\x98", // left single curly quote
4676
+		"\xe2\x80\x99", // right single curly quote
4677
+		"\xe2\x80\x9c", // left double curly quote
4678
+		"\xe2\x80\x9d", // right double curly quote
4679
+		"\xe2\x80\x93", // en dash
4680
+		"\xe2\x80\x94", // em dash
4681 4681
 	);
4682 4682
 
4683 4683
 	// windows 1252 / iso equivalents
@@ -4695,15 +4695,15 @@  discard block
 block discarded – undo
4695 4695
 
4696 4696
 	// safe replacements
4697 4697
 	$replacechars = array(
4698
-		',',	// &sbquo;
4699
-		',,',	// &bdquo;
4700
-		'...',	// &hellip;
4701
-		"'",	// &lsquo;
4702
-		"'",	// &rsquo;
4703
-		'"',	// &ldquo;
4704
-		'"',	// &rdquo;
4705
-		'-',	// &ndash;
4706
-		'--',	// &mdash;
4698
+		',', // &sbquo;
4699
+		',,', // &bdquo;
4700
+		'...', // &hellip;
4701
+		"'", // &lsquo;
4702
+		"'", // &rsquo;
4703
+		'"', // &ldquo;
4704
+		'"', // &rdquo;
4705
+		'-', // &ndash;
4706
+		'--', // &mdash;
4707 4707
 	);
4708 4708
 
4709 4709
 	if ($context['utf8'])
@@ -5066,7 +5066,7 @@  discard block
 block discarded – undo
5066 5066
  */
5067 5067
 function inet_dtop($bin)
5068 5068
 {
5069
-	if(empty($bin))
5069
+	if (empty($bin))
5070 5070
 		return '';
5071 5071
 
5072 5072
 	global $db_type;
@@ -5097,28 +5097,28 @@  discard block
 block discarded – undo
5097 5097
  */
5098 5098
 function _safe_serialize($value)
5099 5099
 {
5100
-	if(is_null($value))
5100
+	if (is_null($value))
5101 5101
 		return 'N;';
5102 5102
 
5103
-	if(is_bool($value))
5104
-		return 'b:'. (int) $value .';';
5103
+	if (is_bool($value))
5104
+		return 'b:' . (int) $value . ';';
5105 5105
 
5106
-	if(is_int($value))
5107
-		return 'i:'. $value .';';
5106
+	if (is_int($value))
5107
+		return 'i:' . $value . ';';
5108 5108
 
5109
-	if(is_float($value))
5110
-		return 'd:'. str_replace(',', '.', $value) .';';
5109
+	if (is_float($value))
5110
+		return 'd:' . str_replace(',', '.', $value) . ';';
5111 5111
 
5112
-	if(is_string($value))
5113
-		return 's:'. strlen($value) .':"'. $value .'";';
5112
+	if (is_string($value))
5113
+		return 's:' . strlen($value) . ':"' . $value . '";';
5114 5114
 
5115
-	if(is_array($value))
5115
+	if (is_array($value))
5116 5116
 	{
5117 5117
 		$out = '';
5118
-		foreach($value as $k => $v)
5118
+		foreach ($value as $k => $v)
5119 5119
 			$out .= _safe_serialize($k) . _safe_serialize($v);
5120 5120
 
5121
-		return 'a:'. count($value) .':{'. $out .'}';
5121
+		return 'a:' . count($value) . ':{' . $out . '}';
5122 5122
 	}
5123 5123
 
5124 5124
 	// safe_serialize cannot serialize resources or objects.
@@ -5160,7 +5160,7 @@  discard block
 block discarded – undo
5160 5160
 function _safe_unserialize($str)
5161 5161
 {
5162 5162
 	// Input  is not a string.
5163
-	if(empty($str) || !is_string($str))
5163
+	if (empty($str) || !is_string($str))
5164 5164
 		return false;
5165 5165
 
5166 5166
 	$stack = array();
@@ -5174,40 +5174,40 @@  discard block
 block discarded – undo
5174 5174
 	 *   3 - in array, expecting value or another array
5175 5175
 	 */
5176 5176
 	$state = 0;
5177
-	while($state != 1)
5177
+	while ($state != 1)
5178 5178
 	{
5179 5179
 		$type = isset($str[0]) ? $str[0] : '';
5180
-		if($type == '}')
5180
+		if ($type == '}')
5181 5181
 			$str = substr($str, 1);
5182 5182
 
5183
-		else if($type == 'N' && $str[1] == ';')
5183
+		else if ($type == 'N' && $str[1] == ';')
5184 5184
 		{
5185 5185
 			$value = null;
5186 5186
 			$str = substr($str, 2);
5187 5187
 		}
5188
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5188
+		else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5189 5189
 		{
5190 5190
 			$value = $matches[1] == '1' ? true : false;
5191 5191
 			$str = substr($str, 4);
5192 5192
 		}
5193
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5193
+		else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5194 5194
 		{
5195
-			$value = (int)$matches[1];
5195
+			$value = (int) $matches[1];
5196 5196
 			$str = $matches[2];
5197 5197
 		}
5198
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5198
+		else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5199 5199
 		{
5200
-			$value = (float)$matches[1];
5200
+			$value = (float) $matches[1];
5201 5201
 			$str = $matches[3];
5202 5202
 		}
5203
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5203
+		else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";')
5204 5204
 		{
5205
-			$value = substr($matches[2], 0, (int)$matches[1]);
5206
-			$str = substr($matches[2], (int)$matches[1] + 2);
5205
+			$value = substr($matches[2], 0, (int) $matches[1]);
5206
+			$str = substr($matches[2], (int) $matches[1] + 2);
5207 5207
 		}
5208
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5208
+		else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5209 5209
 		{
5210
-			$expectedLength = (int)$matches[1];
5210
+			$expectedLength = (int) $matches[1];
5211 5211
 			$str = $matches[2];
5212 5212
 		}
5213 5213
 
@@ -5215,10 +5215,10 @@  discard block
 block discarded – undo
5215 5215
 		else
5216 5216
 			return false;
5217 5217
 
5218
-		switch($state)
5218
+		switch ($state)
5219 5219
 		{
5220 5220
 			case 3: // In array, expecting value or another array.
5221
-				if($type == 'a')
5221
+				if ($type == 'a')
5222 5222
 				{
5223 5223
 					$stack[] = &$list;
5224 5224
 					$list[$key] = array();
@@ -5227,7 +5227,7 @@  discard block
 block discarded – undo
5227 5227
 					$state = 2;
5228 5228
 					break;
5229 5229
 				}
5230
-				if($type != '}')
5230
+				if ($type != '}')
5231 5231
 				{
5232 5232
 					$list[$key] = $value;
5233 5233
 					$state = 2;
@@ -5238,29 +5238,29 @@  discard block
 block discarded – undo
5238 5238
 				return false;
5239 5239
 
5240 5240
 			case 2: // in array, expecting end of array or a key
5241
-				if($type == '}')
5241
+				if ($type == '}')
5242 5242
 				{
5243 5243
 					// Array size is less than expected.
5244
-					if(count($list) < end($expected))
5244
+					if (count($list) < end($expected))
5245 5245
 						return false;
5246 5246
 
5247 5247
 					unset($list);
5248
-					$list = &$stack[count($stack)-1];
5248
+					$list = &$stack[count($stack) - 1];
5249 5249
 					array_pop($stack);
5250 5250
 
5251 5251
 					// Go to terminal state if we're at the end of the root array.
5252 5252
 					array_pop($expected);
5253 5253
 
5254
-					if(count($expected) == 0)
5254
+					if (count($expected) == 0)
5255 5255
 						$state = 1;
5256 5256
 
5257 5257
 					break;
5258 5258
 				}
5259 5259
 
5260
-				if($type == 'i' || $type == 's')
5260
+				if ($type == 'i' || $type == 's')
5261 5261
 				{
5262 5262
 					// Array size exceeds expected length.
5263
-					if(count($list) >= end($expected))
5263
+					if (count($list) >= end($expected))
5264 5264
 						return false;
5265 5265
 
5266 5266
 					$key = $value;
@@ -5273,7 +5273,7 @@  discard block
 block discarded – undo
5273 5273
 
5274 5274
 			// Expecting array or value.
5275 5275
 			case 0:
5276
-				if($type == 'a')
5276
+				if ($type == 'a')
5277 5277
 				{
5278 5278
 					$data = array();
5279 5279
 					$list = &$data;
@@ -5282,7 +5282,7 @@  discard block
 block discarded – undo
5282 5282
 					break;
5283 5283
 				}
5284 5284
 
5285
-				if($type != '}')
5285
+				if ($type != '}')
5286 5286
 				{
5287 5287
 					$data = $value;
5288 5288
 					$state = 1;
@@ -5295,7 +5295,7 @@  discard block
 block discarded – undo
5295 5295
 	}
5296 5296
 
5297 5297
 	// Trailing data in input.
5298
-	if(!empty($str))
5298
+	if (!empty($str))
5299 5299
 		return false;
5300 5300
 
5301 5301
 	return $data;
@@ -5349,7 +5349,7 @@  discard block
 block discarded – undo
5349 5349
 	// Set different modes.
5350 5350
 	$chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666);
5351 5351
 
5352
-	foreach($chmodValues as $val)
5352
+	foreach ($chmodValues as $val)
5353 5353
 	{
5354 5354
 		// If it's writable, break out of the loop.
5355 5355
 		if (is_writable($file))
@@ -5384,13 +5384,13 @@  discard block
 block discarded – undo
5384 5384
 	$returnArray = @json_decode($json, $returnAsArray);
5385 5385
 
5386 5386
 	// PHP 5.3 so no json_last_error_msg()
5387
-	switch(json_last_error())
5387
+	switch (json_last_error())
5388 5388
 	{
5389 5389
 		case JSON_ERROR_NONE:
5390 5390
 			$jsonError = false;
5391 5391
 			break;
5392 5392
 		case JSON_ERROR_DEPTH:
5393
-			$jsonError =  'JSON_ERROR_DEPTH';
5393
+			$jsonError = 'JSON_ERROR_DEPTH';
5394 5394
 			break;
5395 5395
 		case JSON_ERROR_STATE_MISMATCH:
5396 5396
 			$jsonError = 'JSON_ERROR_STATE_MISMATCH';
@@ -5418,10 +5418,10 @@  discard block
 block discarded – undo
5418 5418
 		loadLanguage('Errors');
5419 5419
 
5420 5420
 		if (!empty($jsonDebug))
5421
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5421
+			log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5422 5422
 
5423 5423
 		else
5424
-			log_error($txt['json_'. $jsonError], 'critical');
5424
+			log_error($txt['json_' . $jsonError], 'critical');
5425 5425
 
5426 5426
 		// Everyone expects an array.
5427 5427
 		return array();
@@ -5525,7 +5525,7 @@  discard block
 block discarded – undo
5525 5525
 		});
5526 5526
 
5527 5527
 		// Convert Punycode to Unicode
5528
-		$tlds = array_map(function ($input) {
5528
+		$tlds = array_map(function($input) {
5529 5529
 			$prefix = 'xn--';
5530 5530
 			$safe_char = 0xFFFC;
5531 5531
 			$base = 36;
@@ -5541,7 +5541,7 @@  discard block
 block discarded – undo
5541 5541
 
5542 5542
 			foreach ($enco_parts as $encoded)
5543 5543
 			{
5544
-				if (strpos($encoded,$prefix) !== 0 || strlen(trim(str_replace($prefix,'',$encoded))) == 0)
5544
+				if (strpos($encoded, $prefix) !== 0 || strlen(trim(str_replace($prefix, '', $encoded))) == 0)
5545 5545
 				{
5546 5546
 					$output_parts[] = $encoded;
5547 5547
 					continue;
@@ -5552,7 +5552,7 @@  discard block
 block discarded – undo
5552 5552
 				$idx = 0;
5553 5553
 				$char = 0x80;
5554 5554
 				$decoded = array();
5555
-				$output='';
5555
+				$output = '';
5556 5556
 				$delim_pos = strrpos($encoded, '-');
5557 5557
 
5558 5558
 				if ($delim_pos > strlen($prefix))
@@ -5568,7 +5568,7 @@  discard block
 block discarded – undo
5568 5568
 
5569 5569
 				for ($enco_idx = $delim_pos ? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len)
5570 5570
 				{
5571
-					for ($old_idx = $idx, $w = 1, $k = $base; 1 ; $k += $base)
5571
+					for ($old_idx = $idx, $w = 1, $k = $base; 1; $k += $base)
5572 5572
 					{
5573 5573
 						$cp = ord($encoded{$enco_idx++});
5574 5574
 						$digit = ($cp - 48 < 10) ? $cp - 22 : (($cp - 65 < 26) ? $cp - 65 : (($cp - 97 < 26) ? $cp - 97 : $base));
@@ -5609,15 +5609,15 @@  discard block
 block discarded – undo
5609 5609
 
5610 5610
 					// 2 bytes
5611 5611
 					elseif ($v < (1 << 11))
5612
-						$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
5612
+						$output .= chr(192 + ($v >> 6)) . chr(128 + ($v & 63));
5613 5613
 
5614 5614
 					// 3 bytes
5615 5615
 					elseif ($v < (1 << 16))
5616
-						$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5616
+						$output .= chr(224 + ($v >> 12)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63));
5617 5617
 
5618 5618
 					// 4 bytes
5619 5619
 					elseif ($v < (1 << 21))
5620
-						$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5620
+						$output .= chr(240 + ($v >> 18)) . chr(128 + (($v >> 12) & 63)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63));
5621 5621
 
5622 5622
 					//  'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k
5623 5623
 					else
@@ -5724,7 +5724,7 @@  discard block
 block discarded – undo
5724 5724
 	}
5725 5725
 
5726 5726
 	// This recursive function creates the index array from the strings
5727
-	$add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
5727
+	$add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
5728 5728
 	{
5729 5729
 		static $depth = 0;
5730 5730
 		$depth++;
@@ -5751,7 +5751,7 @@  discard block
 block discarded – undo
5751 5751
 	};
5752 5752
 
5753 5753
 	// This recursive function turns the index array into a regular expression
5754
-	$index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex)
5754
+	$index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex)
5755 5755
 	{
5756 5756
 		static $depth = 0;
5757 5757
 		$depth++;
@@ -5775,11 +5775,11 @@  discard block
 block discarded – undo
5775 5775
 
5776 5776
 				if (count(array_keys($value)) == 1)
5777 5777
 				{
5778
-					$new_key_array = explode('(?'.'>', $sub_regex);
5778
+					$new_key_array = explode('(?' . '>', $sub_regex);
5779 5779
 					$new_key .= $new_key_array[0];
5780 5780
 				}
5781 5781
 				else
5782
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
5782
+					$sub_regex = '(?' . '>' . $sub_regex . ')';
5783 5783
 			}
5784 5784
 
5785 5785
 			if ($depth > 1)
@@ -5819,7 +5819,7 @@  discard block
 block discarded – undo
5819 5819
 		$index = $add_string_to_index($string, $index);
5820 5820
 
5821 5821
 	while (!empty($index))
5822
-		$regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
5822
+		$regexes[] = '(?' . '>' . $index_to_regex($index, $delim) . ')';
5823 5823
 
5824 5824
 	// Restore PHP's internal character encoding to whatever it was originally
5825 5825
 	if (!empty($current_encoding))
Please login to merge, or discard this patch.
Sources/Subscriptions-PayPal.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -402,7 +402,7 @@
 block discarded – undo
402 402
 	 * A private function to find out the subscription details.
403 403
 	 *
404 404
 	 * @access private
405
-	 * @return boolean|void False on failure, otherwise just sets $_POST['item_number']
405
+	 * @return false|null False on failure, otherwise just sets $_POST['item_number']
406 406
 	 */
407 407
 	private function _findSubscription()
408 408
 	{
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,7 +236,7 @@
 block discarded – undo
236 236
 			$header = 'POST /cgi-bin/webscr HTTP/1.1' . "\r\n";
237 237
 			$header .= 'Content-Type: application/x-www-form-urlencoded' . "\r\n";
238 238
 			$header .= 'Host: www.' . (!empty($modSettings['paidsubs_test']) ? 'sandbox.' : '') . 'paypal.com' . "\r\n";
239
-			$header .= 'Content-Length: ' . strlen ($requestString) . "\r\n";
239
+			$header .= 'Content-Length: ' . strlen($requestString) . "\r\n";
240 240
 			$header .= 'Connection: close' . "\r\n\r\n";
241 241
 
242 242
 			// Open the connection.
Please login to merge, or discard this patch.
Braces   +83 added lines, -61 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
 // This won't be dedicated without this - this must exist in each gateway!
15 15
 // SMF Payment Gateway: paypal
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Class for returning available form data for this gateway
@@ -118,8 +119,7 @@  discard block
 block discarded – undo
118 119
 		{
119 120
 			$return_data['hidden']['p3'] = 1;
120 121
 			$return_data['hidden']['t3'] = strtoupper(substr($period, 0, 1));
121
-		}
122
-		else
122
+		} else
123 123
 		{
124 124
 			preg_match('~(\d*)(\w)~', $sub_data['real_length'], $match);
125 125
 			$unit = $match[1];
@@ -130,14 +130,15 @@  discard block
 block discarded – undo
130 130
 		}
131 131
 
132 132
 		// If it's repeatable do some javascript to respect this idea.
133
-		if (!empty($sub_data['repeatable']))
134
-			$return_data['javascript'] = '
133
+		if (!empty($sub_data['repeatable'])) {
134
+					$return_data['javascript'] = '
135 135
 				document.write(\'<label for="do_paypal_recur"><input type="checkbox" name="do_paypal_recur" id="do_paypal_recur" checked onclick="switchPaypalRecur();" class="input_check">' . $txt['paid_make_recurring'] . '</label><br>\');
136 136
 
137 137
 				function switchPaypalRecur()
138 138
 				{
139 139
 					document.getElementById("paypal_cmd").value = document.getElementById("do_paypal_recur").checked ? "_xclick-subscriptions" : "_xclick";
140 140
 				}';
141
+		}
141 142
 
142 143
 		return $return_data;
143 144
 	}
@@ -160,20 +161,24 @@  discard block
 block discarded – undo
160 161
 		global $modSettings;
161 162
 
162 163
 		// Has the user set up an email address?
163
-		if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email'])))
164
-			return false;
164
+		if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) {
165
+					return false;
166
+		}
165 167
 		// Check the correct transaction types are even here.
166
-		if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email'])))
167
-			return false;
168
+		if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) {
169
+					return false;
170
+		}
168 171
 		// Correct email address?
169
-		if (!isset($_POST['business']))
170
-			$_POST['business'] = $_POST['receiver_email'];
172
+		if (!isset($_POST['business'])) {
173
+					$_POST['business'] = $_POST['receiver_email'];
174
+		}
171 175
 
172 176
 		// Are we testing?
173
-		if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails'])))))
174
-			return false;
175
-		elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails']))))
176
-			return false;
177
+		if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) {
178
+					return false;
179
+		} elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) {
180
+					return false;
181
+		}
177 182
 		return true;
178 183
 	}
179 184
 
@@ -192,15 +197,17 @@  discard block
 block discarded – undo
192 197
 		global $modSettings, $txt;
193 198
 
194 199
 		// Put this to some default value.
195
-		if (!isset($_POST['txn_type']))
196
-			$_POST['txn_type'] = '';
200
+		if (!isset($_POST['txn_type'])) {
201
+					$_POST['txn_type'] = '';
202
+		}
197 203
 
198 204
 		// Build the request string - starting with the minimum requirement.
199 205
 		$requestString = 'cmd=_notify-validate';
200 206
 
201 207
 		// Now my dear, add all the posted bits in the order we got them
202
-		foreach ($_POST as $k => $v)
203
-			$requestString .= '&' . $k . '=' . urlencode($v);
208
+		foreach ($_POST as $k => $v) {
209
+					$requestString .= '&' . $k . '=' . urlencode($v);
210
+		}
204 211
 
205 212
 		// Can we use curl?
206 213
 		if (function_exists('curl_init') && $curl = curl_init((!empty($modSettings['paidsubs_test']) ? 'https://www.sandbox.' : 'http://www.') . 'paypal.com/cgi-bin/webscr'))
@@ -240,14 +247,16 @@  discard block
 block discarded – undo
240 247
 			$header .= 'Connection: close' . "\r\n\r\n";
241 248
 
242 249
 			// Open the connection.
243
-			if (!empty($modSettings['paidsubs_test']))
244
-				$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
245
-			else
246
-				$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
250
+			if (!empty($modSettings['paidsubs_test'])) {
251
+							$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
252
+			} else {
253
+							$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
254
+			}
247 255
 
248 256
 			// Did it work?
249
-			if (!$fp)
250
-				generateSubscriptionError($txt['paypal_could_not_connect']);
257
+			if (!$fp) {
258
+							generateSubscriptionError($txt['paypal_could_not_connect']);
259
+			}
251 260
 
252 261
 			// Put the data to the port.
253 262
 			fputs($fp, $header . $requestString);
@@ -256,8 +265,9 @@  discard block
 block discarded – undo
256 265
 			while (!feof($fp))
257 266
 			{
258 267
 				$this->return_data = fgets($fp, 1024);
259
-				if (strcmp(trim($this->return_data), 'VERIFIED') === 0)
260
-					break;
268
+				if (strcmp(trim($this->return_data), 'VERIFIED') === 0) {
269
+									break;
270
+				}
261 271
 			}
262 272
 
263 273
 			// Clean up.
@@ -265,28 +275,34 @@  discard block
 block discarded – undo
265 275
 		}
266 276
 
267 277
 		// If this isn't verified then give up...
268
-		if (strcmp(trim($this->return_data), 'VERIFIED') !== 0)
269
-			exit;
278
+		if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) {
279
+					exit;
280
+		}
270 281
 
271 282
 		// Check that this is intended for us.
272
-		if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails'])))))
273
-			exit;
283
+		if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) {
284
+					exit;
285
+		}
274 286
 
275 287
 		// Is this a subscription - and if so is it a secondary payment that we need to process?
276 288
 		// If so, make sure we get it in the expected format. Seems PayPal sometimes sends it without urlencoding.
277
-		if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false)
278
-			$_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']);
279
-		if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false))
280
-			// Calculate the subscription it relates to!
289
+		if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) {
290
+					$_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']);
291
+		}
292
+		if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) {
293
+					// Calculate the subscription it relates to!
281 294
 			$this->_findSubscription();
295
+		}
282 296
 
283 297
 		// Verify the currency!
284
-		if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code']))
285
-			exit;
298
+		if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) {
299
+					exit;
300
+		}
286 301
 
287 302
 		// Can't exist if it doesn't contain anything.
288
-		if (empty($_POST['item_number']))
289
-			exit;
303
+		if (empty($_POST['item_number'])) {
304
+					exit;
305
+		}
290 306
 
291 307
 		// Return the id_sub and id_member
292 308
 		return explode('+', $_POST['item_number']);
@@ -299,10 +315,11 @@  discard block
 block discarded – undo
299 315
 	 */
300 316
 	public function isRefund()
301 317
 	{
302
-		if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed'))
303
-			return true;
304
-		else
305
-			return false;
318
+		if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) {
319
+					return true;
320
+		} else {
321
+					return false;
322
+		}
306 323
 	}
307 324
 
308 325
 	/**
@@ -312,10 +329,11 @@  discard block
 block discarded – undo
312 329
 	 */
313 330
 	public function isSubscription()
314 331
 	{
315
-		if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed')
316
-			return true;
317
-		else
318
-			return false;
332
+		if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') {
333
+					return true;
334
+		} else {
335
+					return false;
336
+		}
319 337
 	}
320 338
 
321 339
 	/**
@@ -325,10 +343,11 @@  discard block
 block discarded – undo
325 343
 	 */
326 344
 	public function isPayment()
327 345
 	{
328
-		if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept')
329
-			return true;
330
-		else
331
-			return false;
346
+		if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') {
347
+					return true;
348
+		} else {
349
+					return false;
350
+		}
332 351
 	}
333 352
 
334 353
 	/**
@@ -341,10 +360,11 @@  discard block
 block discarded – undo
341 360
 		// subscr_cancel is sent when the user cancels, subscr_eot is sent when the subscription reaches final payment
342 361
 		// Neither require us to *do* anything as per performCancel().
343 362
 		// subscr_eot, if sent, indicates an end of payments term.
344
-		if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot')
345
-			return true;
346
-		else
347
-			return false;
363
+		if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') {
364
+					return true;
365
+		} else {
366
+					return false;
367
+		}
348 368
 	}
349 369
 
350 370
 	/**
@@ -409,8 +429,9 @@  discard block
 block discarded – undo
409 429
 		global $smcFunc;
410 430
 
411 431
 		// Assume we have this?
412
-		if (empty($_POST['subscr_id']))
413
-			return false;
432
+		if (empty($_POST['subscr_id'])) {
433
+					return false;
434
+		}
414 435
 
415 436
 		// Do we have this in the database?
416 437
 		$request = $smcFunc['db_query']('', '
@@ -439,11 +460,12 @@  discard block
 block discarded – undo
439 460
 						'payer_email' => $_POST['payer_email'],
440 461
 					)
441 462
 				);
442
-				if ($smcFunc['db_num_rows']($request) === 0)
443
-					return false;
463
+				if ($smcFunc['db_num_rows']($request) === 0) {
464
+									return false;
465
+				}
466
+			} else {
467
+							return false;
444 468
 			}
445
-			else
446
-				return false;
447 469
 		}
448 470
 		list ($member_id, $subscription_id) = $smcFunc['db_fetch_row']($request);
449 471
 		$_POST['item_number'] = $member_id . '+' . $subscription_id;
Please login to merge, or discard this patch.
Sources/tasks/EventNew-Notify.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 {
22 22
 	/**
23 23
      * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
24
-	 * @return bool Always returns true
24
+	 * @return boolean|null Always returns true
25 25
 	 */
26 26
 	public function execute()
27 27
  	{
Please login to merge, or discard this patch.
Braces   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -32,8 +32,9 @@  discard block
 block discarded – undo
32 32
 		$members = membersAllowedTo('calendar_view');
33 33
 
34 34
 		// Don't alert the event creator
35
-		if (!empty($this->_details['sender_id']))
36
-			$members = array_diff($members, array($this->_details['sender_id']));
35
+		if (!empty($this->_details['sender_id'])) {
36
+					$members = array_diff($members, array($this->_details['sender_id']));
37
+		}
37 38
 
38 39
 		// Having successfully figured this out, now let's get the preferences of everyone.
39 40
 		require_once($sourcedir . '/Subs-Notify.php');
@@ -44,10 +45,11 @@  discard block
 block discarded – undo
44 45
 		if (!empty($this->_details['sender_id']) && empty($this->_details['sender_name']))
45 46
 		{
46 47
 			loadMemberData($this->_details['sender_id'], 'minimal');
47
-			if (!empty($user_profile[$this->_details['sender_id']]))
48
-				$this->_details['sender_name'] = $user_profile[$this->_details['sender_id']]['real_name'];
49
-			else
50
-				$this->_details['sender_id'] = 0;
48
+			if (!empty($user_profile[$this->_details['sender_id']])) {
49
+							$this->_details['sender_name'] = $user_profile[$this->_details['sender_id']]['real_name'];
50
+			} else {
51
+							$this->_details['sender_id'] = 0;
52
+			}
51 53
 		}
52 54
 
53 55
 		// So now we find out who wants what.
@@ -59,9 +61,10 @@  discard block
 block discarded – undo
59 61
 
60 62
 		foreach ($prefs as $member => $pref_option)
61 63
 		{
62
-			foreach ($alert_bits as $type => $bitvalue)
63
-				if ($pref_option['event_new'] & $bitvalue)
64
+			foreach ($alert_bits as $type => $bitvalue) {
65
+							if ($pref_option['event_new'] & $bitvalue)
64 66
 					$notifies[$type][] = $member;
67
+			}
65 68
 		}
66 69
 
67 70
 		// Firstly, anyone who wants alerts.
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 class Likes_Notify_Background extends SMF_BackgroundTask
20 20
 {
21 21
 	/**
22
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
22
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23 23
 	 * @return bool Always returns true
24 24
 	 */
25 25
 	public function execute()
Please login to merge, or discard this patch.
Sources/Xml.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 /**
81 81
  * Handles retrieving previews of news items, newsletters, signatures and warnings.
82 82
  * Calls the appropriate function based on $_POST['item']
83
- * @return void|bool Returns false if $_POST['item'] isn't set or isn't valid
83
+ * @return false|null Returns false if $_POST['item'] isn't set or isn't valid
84 84
  */
85 85
 function RetrievePreview()
86 86
 {
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -272,13 +272,13 @@
 block discarded – undo
272 272
 				$context['post_error']['messages'][] = $txt['mc_warning_template_error_no_body'];
273 273
 			// Add in few replacements.
274 274
 			/**
275
-			* These are the defaults:
276
-			* - {MEMBER} - Member Name. => current user for review
277
-			* - {MESSAGE} - Link to Offending Post. (If Applicable) => not applicable here, so not replaced
278
-			* - {FORUMNAME} - Forum Name.
279
-			* - {SCRIPTURL} - Web address of forum.
280
-			* - {REGARDS} - Standard email sign-off.
281
-			*/
275
+			 * These are the defaults:
276
+			 * - {MEMBER} - Member Name. => current user for review
277
+			 * - {MESSAGE} - Link to Offending Post. (If Applicable) => not applicable here, so not replaced
278
+			 * - {FORUMNAME} - Forum Name.
279
+			 * - {SCRIPTURL} - Web address of forum.
280
+			 * - {REGARDS} - Standard email sign-off.
281
+			 */
282 282
 			$find = array(
283 283
 				'{MEMBER}',
284 284
 				'{FORUMNAME}',
Please login to merge, or discard this patch.
Braces   +55 added lines, -42 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * The main handler and designator for AJAX stuff - jumpto, message icons and previews
@@ -32,8 +33,9 @@  discard block
 block discarded – undo
32 33
 	// Easy adding of sub actions.
33 34
 	call_integration_hook('integrate_XMLhttpMain_subActions', array(&$subActions));
34 35
 
35
-	if (!isset($_REQUEST['sa'], $subActions[$_REQUEST['sa']]))
36
-		fatal_lang_error('no_access', false);
36
+	if (!isset($_REQUEST['sa'], $subActions[$_REQUEST['sa']])) {
37
+			fatal_lang_error('no_access', false);
38
+	}
37 39
 
38 40
 	call_helper($subActions[$_REQUEST['sa']]);
39 41
 }
@@ -57,8 +59,9 @@  discard block
 block discarded – undo
57 59
 	foreach ($context['jump_to'] as $id_cat => $cat)
58 60
 	{
59 61
 		$context['jump_to'][$id_cat]['name'] = un_htmlspecialchars(strip_tags($cat['name']));
60
-		foreach ($cat['boards'] as $id_board => $board)
61
-			$context['jump_to'][$id_cat]['boards'][$id_board]['name'] = un_htmlspecialchars(strip_tags($board['name']));
62
+		foreach ($cat['boards'] as $id_board => $board) {
63
+					$context['jump_to'][$id_cat]['boards'][$id_board]['name'] = un_htmlspecialchars(strip_tags($board['name']));
64
+		}
62 65
 	}
63 66
 
64 67
 	$context['sub_template'] = 'jump_to';
@@ -95,8 +98,9 @@  discard block
 block discarded – undo
95 98
 
96 99
 	$context['sub_template'] = 'generic_xml';
97 100
 
98
-	if (!isset($_POST['item']) || !in_array($_POST['item'], $items))
99
-		return false;
101
+	if (!isset($_POST['item']) || !in_array($_POST['item'], $items)) {
102
+			return false;
103
+	}
100 104
 
101 105
 	$_POST['item']();
102 106
 }
@@ -112,10 +116,11 @@  discard block
 block discarded – undo
112 116
 
113 117
 	$errors = array();
114 118
 	$news = !isset($_POST['news'])? '' : $smcFunc['htmlspecialchars']($_POST['news'], ENT_QUOTES);
115
-	if (empty($news))
116
-		$errors[] = array('value' => 'no_news');
117
-	else
118
-		preparsecode($news);
119
+	if (empty($news)) {
120
+			$errors[] = array('value' => 'no_news');
121
+	} else {
122
+			preparsecode($news);
123
+	}
119 124
 
120 125
 	$context['xml_data'] = array(
121 126
 		'news' => array(
@@ -148,10 +153,12 @@  discard block
 block discarded – undo
148 153
 	$context['send_pm'] = !empty($_POST['send_pm']) ? 1 : 0;
149 154
 	$context['send_html'] = !empty($_POST['send_html']) ? 1 : 0;
150 155
 
151
-	if (empty($_POST['subject']))
152
-		$context['post_error']['messages'][] = $txt['error_no_subject'];
153
-	if (empty($_POST['message']))
154
-		$context['post_error']['messages'][] = $txt['error_no_message'];
156
+	if (empty($_POST['subject'])) {
157
+			$context['post_error']['messages'][] = $txt['error_no_subject'];
158
+	}
159
+	if (empty($_POST['message'])) {
160
+			$context['post_error']['messages'][] = $txt['error_no_message'];
161
+	}
155 162
 
156 163
 	prepareMailingForPreview();
157 164
 
@@ -196,38 +203,41 @@  discard block
 block discarded – undo
196 203
 		$preview_signature = !empty($_POST['signature']) ? $_POST['signature'] : $txt['no_signature_preview'];
197 204
 		$validation = profileValidateSignature($preview_signature);
198 205
 
199
-		if ($validation !== true && $validation !== false)
200
-			$errors[] = array('value' => $txt['profile_error_' . $validation], 'attributes' => array('type' => 'error'));
206
+		if ($validation !== true && $validation !== false) {
207
+					$errors[] = array('value' => $txt['profile_error_' . $validation], 'attributes' => array('type' => 'error'));
208
+		}
201 209
 
202 210
 		censorText($preview_signature);
203 211
 		$preview_signature = parse_bbc($preview_signature, true, 'sig' . $user);
204
-	}
205
-	elseif (!$can_change)
212
+	} elseif (!$can_change)
206 213
 	{
207
-		if ($is_owner)
208
-			$errors[] = array('value' => $txt['cannot_profile_extra_own'], 'attributes' => array('type' => 'error'));
209
-		else
210
-			$errors[] = array('value' => $txt['cannot_profile_extra_any'], 'attributes' => array('type' => 'error'));
214
+		if ($is_owner) {
215
+					$errors[] = array('value' => $txt['cannot_profile_extra_own'], 'attributes' => array('type' => 'error'));
216
+		} else {
217
+					$errors[] = array('value' => $txt['cannot_profile_extra_any'], 'attributes' => array('type' => 'error'));
218
+		}
219
+	} else {
220
+			$errors[] = array('value' => $txt['no_user_selected'], 'attributes' => array('type' => 'error'));
211 221
 	}
212
-	else
213
-		$errors[] = array('value' => $txt['no_user_selected'], 'attributes' => array('type' => 'error'));
214 222
 
215 223
 	$context['xml_data']['signatures'] = array(
216 224
 			'identifier' => 'signature',
217 225
 			'children' => array()
218 226
 		);
219
-	if (isset($current_signature))
220
-		$context['xml_data']['signatures']['children'][] = array(
227
+	if (isset($current_signature)) {
228
+			$context['xml_data']['signatures']['children'][] = array(
221 229
 					'value' => $current_signature,
222 230
 					'attributes' => array('type' => 'current'),
223 231
 				);
224
-	if (isset($preview_signature))
225
-		$context['xml_data']['signatures']['children'][] = array(
232
+	}
233
+	if (isset($preview_signature)) {
234
+			$context['xml_data']['signatures']['children'][] = array(
226 235
 					'value' => $preview_signature,
227 236
 					'attributes' => array('type' => 'preview'),
228 237
 				);
229
-	if (!empty($errors))
230
-		$context['xml_data']['errors'] = array(
238
+	}
239
+	if (!empty($errors)) {
240
+			$context['xml_data']['errors'] = array(
231 241
 			'identifier' => 'error',
232 242
 			'children' => array_merge(
233 243
 				array(
@@ -239,7 +249,8 @@  discard block
 block discarded – undo
239 249
 				$errors
240 250
 			),
241 251
 		);
242
-}
252
+	}
253
+	}
243 254
 
244 255
 /**
245 256
  * Handles previewing user warnings
@@ -261,15 +272,17 @@  discard block
 block discarded – undo
261 272
 		$context['preview_subject'] = !empty($_POST['title']) ? trim($smcFunc['htmlspecialchars']($_POST['title'])) : '';
262 273
 		if (isset($_POST['issuing']))
263 274
 		{
264
-			if (empty($_POST['title']) || empty($_POST['body']))
265
-				$context['post_error']['messages'][] = $txt['warning_notify_blank'];
266
-		}
267
-		else
275
+			if (empty($_POST['title']) || empty($_POST['body'])) {
276
+							$context['post_error']['messages'][] = $txt['warning_notify_blank'];
277
+			}
278
+		} else
268 279
 		{
269
-			if (empty($_POST['title']))
270
-				$context['post_error']['messages'][] = $txt['mc_warning_template_error_no_title'];
271
-			if (empty($_POST['body']))
272
-				$context['post_error']['messages'][] = $txt['mc_warning_template_error_no_body'];
280
+			if (empty($_POST['title'])) {
281
+							$context['post_error']['messages'][] = $txt['mc_warning_template_error_no_title'];
282
+			}
283
+			if (empty($_POST['body'])) {
284
+							$context['post_error']['messages'][] = $txt['mc_warning_template_error_no_body'];
285
+			}
273 286
 			// Add in few replacements.
274 287
 			/**
275 288
 			* These are the defaults:
@@ -300,9 +313,9 @@  discard block
 block discarded – undo
300 313
 			$warning_body = parse_bbc($warning_body, true);
301 314
 		}
302 315
 		$context['preview_message'] = $warning_body;
316
+	} else {
317
+			$context['post_error']['messages'][] = array('value' => $txt['cannot_issue_warning'], 'attributes' => array('type' => 'error'));
303 318
 	}
304
-	else
305
-		$context['post_error']['messages'][] = array('value' => $txt['cannot_issue_warning'], 'attributes' => array('type' => 'error'));
306 319
 
307 320
 	$context['sub_template'] = 'warning';
308 321
 }
Please login to merge, or discard this patch.
SSI.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1717,7 +1717,7 @@  discard block
 block discarded – undo
1717 1717
 /**
1718 1718
  * Show today's birthdays.
1719 1719
  * @param string $output_method The output method. If 'echo', displays a list of users, otherwise returns an array of info about them.
1720
- * @return void|array Displays a list of users or returns an array of info about them depending on output_method.
1720
+ * @return null|string Displays a list of users or returns an array of info about them depending on output_method.
1721 1721
  */
1722 1722
 function ssi_todaysBirthdays($output_method = 'echo')
1723 1723
 {
@@ -1746,7 +1746,7 @@  discard block
 block discarded – undo
1746 1746
 /**
1747 1747
  * Shows today's holidays.
1748 1748
  * @param string $output_method The output method. If 'echo', displays a list of holidays, otherwise returns an array of info about them.
1749
- * @return void|array Displays a list of holidays or returns an array of info about them depending on output_method
1749
+ * @return null|string Displays a list of holidays or returns an array of info about them depending on output_method
1750 1750
  */
1751 1751
 function ssi_todaysHolidays($output_method = 'echo')
1752 1752
 {
@@ -1773,7 +1773,7 @@  discard block
 block discarded – undo
1773 1773
 
1774 1774
 /**
1775 1775
  * @param string $output_method The output method. If 'echo', displays a list of events, otherwise returns an array of info about them.
1776
- * @return void|array Displays a list of events or returns an array of info about them depending on output_method
1776
+ * @return null|string Displays a list of events or returns an array of info about them depending on output_method
1777 1777
  */
1778 1778
 function ssi_todaysEvents($output_method = 'echo')
1779 1779
 {
@@ -1807,7 +1807,7 @@  discard block
 block discarded – undo
1807 1807
 /**
1808 1808
  * Shows today's calendar items (events, birthdays and holidays)
1809 1809
  * @param string $output_method The output method. If 'echo', displays a list of calendar items, otherwise returns an array of info about them.
1810
- * @return void|array Displays a list of calendar items or returns an array of info about them depending on output_method
1810
+ * @return null|string Displays a list of calendar items or returns an array of info about them depending on output_method
1811 1811
  */
1812 1812
 function ssi_todaysCalendar($output_method = 'echo')
1813 1813
 {
@@ -2198,7 +2198,7 @@  discard block
 block discarded – undo
2198 2198
  * @param int|string $id The ID or username of a user
2199 2199
  * @param string $password The password to check
2200 2200
  * @param bool $is_username If true, treats $id as a username rather than a user ID
2201
- * @return bool Whether or not the password is correct.
2201
+ * @return null|boolean Whether or not the password is correct.
2202 2202
  */
2203 2203
 function ssi_checkPassword($id = null, $password = null, $is_username = false)
2204 2204
 {
Please login to merge, or discard this patch.
Braces   +428 added lines, -304 removed lines patch added patch discarded remove patch
@@ -12,8 +12,9 @@  discard block
 block discarded – undo
12 12
  */
13 13
 
14 14
 // Don't do anything if SMF is already loaded.
15
-if (defined('SMF'))
15
+if (defined('SMF')) {
16 16
 	return true;
17
+}
17 18
 
18 19
 define('SMF', 'SSI');
19 20
 
@@ -26,21 +27,24 @@  discard block
 block discarded – undo
26 27
 
27 28
 // Remember the current configuration so it can be set back.
28 29
 $ssi_magic_quotes_runtime = function_exists('get_magic_quotes_gpc') && get_magic_quotes_runtime();
29
-if (function_exists('set_magic_quotes_runtime'))
30
+if (function_exists('set_magic_quotes_runtime')) {
30 31
 	@set_magic_quotes_runtime(0);
32
+}
31 33
 $time_start = microtime();
32 34
 
33 35
 // Just being safe...
34
-foreach (array('db_character_set', 'cachedir') as $variable)
36
+foreach (array('db_character_set', 'cachedir') as $variable) {
35 37
 	if (isset($GLOBALS[$variable]))
36 38
 		unset($GLOBALS[$variable]);
39
+}
37 40
 
38 41
 // Get the forum's settings for database and file paths.
39 42
 require_once(dirname(__FILE__) . '/Settings.php');
40 43
 
41 44
 // Make absolutely sure the cache directory is defined.
42
-if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache'))
45
+if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) {
43 46
 	$cachedir = $boarddir . '/cache';
47
+}
44 48
 
45 49
 $ssi_error_reporting = error_reporting(defined('E_STRICT') ? E_ALL | E_STRICT : E_ALL);
46 50
 /* Set this to one of three values depending on what you want to happen in the case of a fatal error.
@@ -51,12 +55,14 @@  discard block
 block discarded – undo
51 55
 $ssi_on_error_method = false;
52 56
 
53 57
 // Don't do john didley if the forum's been shut down completely.
54
-if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true))
58
+if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true)) {
55 59
 	die($mmessage);
60
+}
56 61
 
57 62
 // Fix for using the current directory as a path.
58
-if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.')
63
+if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') {
59 64
 	$sourcedir = dirname(__FILE__) . substr($sourcedir, 1);
65
+}
60 66
 
61 67
 // Load the important includes.
62 68
 require_once($sourcedir . '/QueryString.php');
@@ -81,34 +87,38 @@  discard block
 block discarded – undo
81 87
 cleanRequest();
82 88
 
83 89
 // Seed the random generator?
84
-if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69)
90
+if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) {
85 91
 	smf_seed_generator();
92
+}
86 93
 
87 94
 // Check on any hacking attempts.
88
-if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS']))
95
+if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) {
89 96
 	die('No direct access...');
90
-elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme)
97
+} elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme) {
91 98
 	die('No direct access...');
92
-elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme)
99
+} elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme) {
93 100
 	die('No direct access...');
94
-elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers)
101
+} elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers) {
95 102
 	die('No direct access...');
96
-if (isset($_REQUEST['context']))
103
+}
104
+if (isset($_REQUEST['context'])) {
97 105
 	die('No direct access...');
106
+}
98 107
 
99 108
 // Gzip output? (because it must be boolean and true, this can't be hacked.)
100
-if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>='))
109
+if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>=')) {
101 110
 	ob_start('ob_gzhandler');
102
-else
111
+} else {
103 112
 	$modSettings['enableCompressedOutput'] = '0';
113
+}
104 114
 
105 115
 // Primarily, this is to fix the URLs...
106 116
 ob_start('ob_sessrewrite');
107 117
 
108 118
 // Start the session... known to scramble SSI includes in cases...
109
-if (!headers_sent())
119
+if (!headers_sent()) {
110 120
 	loadSession();
111
-else
121
+} else
112 122
 {
113 123
 	if (isset($_COOKIE[session_name()]) || isset($_REQUEST[session_name()]))
114 124
 	{
@@ -142,12 +152,14 @@  discard block
 block discarded – undo
142 152
 loadTheme(isset($ssi_theme) ? (int) $ssi_theme : 0);
143 153
 
144 154
 // @todo: probably not the best place, but somewhere it should be set...
145
-if (!headers_sent())
155
+if (!headers_sent()) {
146 156
 	header('Content-Type: text/html; charset=' . (empty($modSettings['global_character_set']) ? (empty($txt['lang_character_set']) ? 'ISO-8859-1' : $txt['lang_character_set']) : $modSettings['global_character_set']));
157
+}
147 158
 
148 159
 // Take care of any banning that needs to be done.
149
-if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true))
160
+if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true)) {
150 161
 	is_not_banned();
162
+}
151 163
 
152 164
 // Do we allow guests in here?
153 165
 if (empty($ssi_guest_access) && empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && basename($_SERVER['PHP_SELF']) != 'SSI.php')
@@ -162,17 +174,19 @@  discard block
 block discarded – undo
162 174
 {
163 175
 	$context['template_layers'] = $ssi_layers;
164 176
 	template_header();
165
-}
166
-else
177
+} else {
167 178
 	setupThemeContext();
179
+}
168 180
 
169 181
 // Make sure they didn't muss around with the settings... but only if it's not cli.
170
-if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '')
182
+if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '') {
171 183
 	trigger_error($txt['ssi_session_broken'], E_USER_NOTICE);
184
+}
172 185
 
173 186
 // Without visiting the forum this session variable might not be set on submit.
174
-if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote'))
187
+if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote')) {
175 188
 	$_SESSION['USER_AGENT'] = $_SERVER['HTTP_USER_AGENT'];
189
+}
176 190
 
177 191
 // Have the ability to easily add functions to SSI.
178 192
 call_integration_hook('integrate_SSI');
@@ -183,15 +197,18 @@  discard block
 block discarded – undo
183 197
 	call_user_func('ssi_' . $_GET['ssi_function']);
184 198
 	exit;
185 199
 }
186
-if (isset($_GET['ssi_function']))
200
+if (isset($_GET['ssi_function'])) {
187 201
 	exit;
202
+}
188 203
 // You shouldn't just access SSI.php directly by URL!!
189
-elseif (basename($_SERVER['PHP_SELF']) == 'SSI.php')
204
+elseif (basename($_SERVER['PHP_SELF']) == 'SSI.php') {
190 205
 	die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\''));
206
+}
191 207
 
192 208
 error_reporting($ssi_error_reporting);
193
-if (function_exists('set_magic_quotes_runtime'))
209
+if (function_exists('set_magic_quotes_runtime')) {
194 210
 	@set_magic_quotes_runtime($ssi_magic_quotes_runtime);
211
+}
195 212
 
196 213
 return true;
197 214
 
@@ -201,9 +218,10 @@  discard block
 block discarded – undo
201 218
  */
202 219
 function ssi_shutdown()
203 220
 {
204
-	if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown')
205
-		template_footer();
206
-}
221
+	if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown') {
222
+			template_footer();
223
+	}
224
+	}
207 225
 
208 226
 /**
209 227
  * Display a welcome message, like: Hey, User, you have 0 messages, 0 are new.
@@ -216,15 +234,17 @@  discard block
 block discarded – undo
216 234
 
217 235
 	if ($output_method == 'echo')
218 236
 	{
219
-		if ($context['user']['is_guest'])
220
-			echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup');
221
-		else
222
-			echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : '';
237
+		if ($context['user']['is_guest']) {
238
+					echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup');
239
+		} else {
240
+					echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : '';
241
+		}
223 242
 	}
224 243
 	// Don't echo... then do what?!
225
-	else
226
-		return $context['user'];
227
-}
244
+	else {
245
+			return $context['user'];
246
+	}
247
+	}
228 248
 
229 249
 /**
230 250
  * Display a menu bar, like is displayed at the top of the forum.
@@ -235,12 +255,14 @@  discard block
 block discarded – undo
235 255
 {
236 256
 	global $context;
237 257
 
238
-	if ($output_method == 'echo')
239
-		template_menu();
258
+	if ($output_method == 'echo') {
259
+			template_menu();
260
+	}
240 261
 	// What else could this do?
241
-	else
242
-		return $context['menu_buttons'];
243
-}
262
+	else {
263
+			return $context['menu_buttons'];
264
+	}
265
+	}
244 266
 
245 267
 /**
246 268
  * Show a logout link.
@@ -252,20 +274,23 @@  discard block
 block discarded – undo
252 274
 {
253 275
 	global $context, $txt, $scripturl;
254 276
 
255
-	if ($redirect_to != '')
256
-		$_SESSION['logout_url'] = $redirect_to;
277
+	if ($redirect_to != '') {
278
+			$_SESSION['logout_url'] = $redirect_to;
279
+	}
257 280
 
258 281
 	// Guests can't log out.
259
-	if ($context['user']['is_guest'])
260
-		return false;
282
+	if ($context['user']['is_guest']) {
283
+			return false;
284
+	}
261 285
 
262 286
 	$link = '<a href="' . $scripturl . '?action=logout;' . $context['session_var'] . '=' . $context['session_id'] . '">' . $txt['logout'] . '</a>';
263 287
 
264
-	if ($output_method == 'echo')
265
-		echo $link;
266
-	else
267
-		return $link;
268
-}
288
+	if ($output_method == 'echo') {
289
+			echo $link;
290
+	} else {
291
+			return $link;
292
+	}
293
+	}
269 294
 
270 295
 /**
271 296
  * Recent post list:   [board] Subject by Poster    Date
@@ -281,17 +306,17 @@  discard block
 block discarded – undo
281 306
 	global $modSettings, $context;
282 307
 
283 308
 	// Excluding certain boards...
284
-	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0)
285
-		$exclude_boards = array($modSettings['recycle_board']);
286
-	else
287
-		$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
309
+	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) {
310
+			$exclude_boards = array($modSettings['recycle_board']);
311
+	} else {
312
+			$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
313
+	}
288 314
 
289 315
 	// What about including certain boards - note we do some protection here as pre-2.0 didn't have this parameter.
290 316
 	if (is_array($include_boards) || (int) $include_boards === $include_boards)
291 317
 	{
292 318
 		$include_boards = is_array($include_boards) ? $include_boards : array($include_boards);
293
-	}
294
-	elseif ($include_boards != null)
319
+	} elseif ($include_boards != null)
295 320
 	{
296 321
 		$include_boards = array();
297 322
 	}
@@ -328,8 +353,9 @@  discard block
 block discarded – undo
328 353
 {
329 354
 	global $modSettings;
330 355
 
331
-	if (empty($post_ids))
332
-		return;
356
+	if (empty($post_ids)) {
357
+			return;
358
+	}
333 359
 
334 360
 	// Allow the user to request more than one - why not?
335 361
 	$post_ids = is_array($post_ids) ? $post_ids : array($post_ids);
@@ -364,8 +390,9 @@  discard block
 block discarded – undo
364 390
 	global $scripturl, $txt, $user_info;
365 391
 	global $modSettings, $smcFunc, $context;
366 392
 
367
-	if (!empty($modSettings['enable_likes']))
368
-		$context['can_like'] = allowedTo('likes_like');
393
+	if (!empty($modSettings['enable_likes'])) {
394
+			$context['can_like'] = allowedTo('likes_like');
395
+	}
369 396
 
370 397
 	// Find all the posts. Newer ones will have higher IDs.
371 398
 	$request = $smcFunc['db_query']('substring', '
@@ -431,12 +458,13 @@  discard block
 block discarded – undo
431 458
 		);
432 459
 
433 460
 		// Get the likes for each message.
434
-		if (!empty($modSettings['enable_likes']))
435
-			$posts[$row['id_msg']]['likes'] = array(
461
+		if (!empty($modSettings['enable_likes'])) {
462
+					$posts[$row['id_msg']]['likes'] = array(
436 463
 				'count' => $row['likes'],
437 464
 				'you' => in_array($row['id_msg'], prepareLikesContext($row['id_topic'])),
438 465
 				'can_like' => !$context['user']['is_guest'] && $row['id_member'] != $context['user']['id'] && !empty($context['can_like']),
439 466
 			);
467
+		}
440 468
 	}
441 469
 	$smcFunc['db_free_result']($request);
442 470
 
@@ -444,13 +472,14 @@  discard block
 block discarded – undo
444 472
 	call_integration_hook('integrate_ssi_queryPosts', array(&$posts));
445 473
 
446 474
 	// Just return it.
447
-	if ($output_method != 'echo' || empty($posts))
448
-		return $posts;
475
+	if ($output_method != 'echo' || empty($posts)) {
476
+			return $posts;
477
+	}
449 478
 
450 479
 	echo '
451 480
 		<table style="border: none" class="ssi_table">';
452
-	foreach ($posts as $post)
453
-		echo '
481
+	foreach ($posts as $post) {
482
+			echo '
454 483
 			<tr>
455 484
 				<td style="text-align: right; vertical-align: top; white-space: nowrap">
456 485
 					[', $post['board']['link'], ']
@@ -464,6 +493,7 @@  discard block
 block discarded – undo
464 493
 					', $post['time'], '
465 494
 				</td>
466 495
 			</tr>';
496
+	}
467 497
 	echo '
468 498
 		</table>';
469 499
 }
@@ -481,25 +511,26 @@  discard block
 block discarded – undo
481 511
 	global $settings, $scripturl, $txt, $user_info;
482 512
 	global $modSettings, $smcFunc, $context;
483 513
 
484
-	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0)
485
-		$exclude_boards = array($modSettings['recycle_board']);
486
-	else
487
-		$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
514
+	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) {
515
+			$exclude_boards = array($modSettings['recycle_board']);
516
+	} else {
517
+			$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
518
+	}
488 519
 
489 520
 	// Only some boards?.
490 521
 	if (is_array($include_boards) || (int) $include_boards === $include_boards)
491 522
 	{
492 523
 		$include_boards = is_array($include_boards) ? $include_boards : array($include_boards);
493
-	}
494
-	elseif ($include_boards != null)
524
+	} elseif ($include_boards != null)
495 525
 	{
496 526
 		$output_method = $include_boards;
497 527
 		$include_boards = array();
498 528
 	}
499 529
 
500 530
 	$icon_sources = array();
501
-	foreach ($context['stable_icons'] as $icon)
502
-		$icon_sources[$icon] = 'images_url';
531
+	foreach ($context['stable_icons'] as $icon) {
532
+			$icon_sources[$icon] = 'images_url';
533
+	}
503 534
 
504 535
 	// Find all the posts in distinct topics.  Newer ones will have higher IDs.
505 536
 	$request = $smcFunc['db_query']('substring', '
@@ -524,13 +555,15 @@  discard block
 block discarded – undo
524 555
 		)
525 556
 	);
526 557
 	$topics = array();
527
-	while ($row = $smcFunc['db_fetch_assoc']($request))
528
-		$topics[$row['id_topic']] = $row;
558
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
559
+			$topics[$row['id_topic']] = $row;
560
+	}
529 561
 	$smcFunc['db_free_result']($request);
530 562
 
531 563
 	// Did we find anything? If not, bail.
532
-	if (empty($topics))
533
-		return array();
564
+	if (empty($topics)) {
565
+			return array();
566
+	}
534 567
 
535 568
 	$recycle_board = !empty($modSettings['recycle_enable']) && !empty($modSettings['recycle_board']) ? (int) $modSettings['recycle_board'] : 0;
536 569
 
@@ -558,19 +591,22 @@  discard block
 block discarded – undo
558 591
 	while ($row = $smcFunc['db_fetch_assoc']($request))
559 592
 	{
560 593
 		$row['body'] = strip_tags(strtr(parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']), array('<br>' => '&#10;')));
561
-		if ($smcFunc['strlen']($row['body']) > 128)
562
-			$row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...';
594
+		if ($smcFunc['strlen']($row['body']) > 128) {
595
+					$row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...';
596
+		}
563 597
 
564 598
 		// Censor the subject.
565 599
 		censorText($row['subject']);
566 600
 		censorText($row['body']);
567 601
 
568 602
 		// Recycled icon
569
-		if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board'])
570
-			$row['icon'] = 'recycled';
603
+		if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board']) {
604
+					$row['icon'] = 'recycled';
605
+		}
571 606
 
572
-		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']]))
573
-			$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
607
+		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) {
608
+					$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
609
+		}
574 610
 
575 611
 		// Build the array.
576 612
 		$posts[] = array(
@@ -609,13 +645,14 @@  discard block
 block discarded – undo
609 645
 	call_integration_hook('integrate_ssi_recentTopics', array(&$posts));
610 646
 
611 647
 	// Just return it.
612
-	if ($output_method != 'echo' || empty($posts))
613
-		return $posts;
648
+	if ($output_method != 'echo' || empty($posts)) {
649
+			return $posts;
650
+	}
614 651
 
615 652
 	echo '
616 653
 		<table style="border: none" class="ssi_table">';
617
-	foreach ($posts as $post)
618
-		echo '
654
+	foreach ($posts as $post) {
655
+			echo '
619 656
 			<tr>
620 657
 				<td style="text-align: right; vertical-align: top; white-space: nowrap">
621 658
 					[', $post['board']['link'], ']
@@ -629,6 +666,7 @@  discard block
 block discarded – undo
629 666
 					', $post['time'], '
630 667
 				</td>
631 668
 			</tr>';
669
+	}
632 670
 	echo '
633 671
 		</table>';
634 672
 }
@@ -653,27 +691,30 @@  discard block
 block discarded – undo
653 691
 		)
654 692
 	);
655 693
 	$return = array();
656
-	while ($row = $smcFunc['db_fetch_assoc']($request))
657
-		$return[] = array(
694
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
695
+			$return[] = array(
658 696
 			'id' => $row['id_member'],
659 697
 			'name' => $row['real_name'],
660 698
 			'href' => $scripturl . '?action=profile;u=' . $row['id_member'],
661 699
 			'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>',
662 700
 			'posts' => $row['posts']
663 701
 		);
702
+	}
664 703
 	$smcFunc['db_free_result']($request);
665 704
 
666 705
 	// If mods want to do somthing with this list of members, let them do that now.
667 706
 	call_integration_hook('integrate_ssi_topPoster', array(&$return));
668 707
 
669 708
 	// Just return all the top posters.
670
-	if ($output_method != 'echo')
671
-		return $return;
709
+	if ($output_method != 'echo') {
710
+			return $return;
711
+	}
672 712
 
673 713
 	// Make a quick array to list the links in.
674 714
 	$temp_array = array();
675
-	foreach ($return as $member)
676
-		$temp_array[] = $member['link'];
715
+	foreach ($return as $member) {
716
+			$temp_array[] = $member['link'];
717
+	}
677 718
 
678 719
 	echo implode(', ', $temp_array);
679 720
 }
@@ -705,8 +746,8 @@  discard block
 block discarded – undo
705 746
 		)
706 747
 	);
707 748
 	$boards = array();
708
-	while ($row = $smcFunc['db_fetch_assoc']($request))
709
-		$boards[] = array(
749
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
750
+			$boards[] = array(
710 751
 			'id' => $row['id_board'],
711 752
 			'num_posts' => $row['num_posts'],
712 753
 			'num_topics' => $row['num_topics'],
@@ -715,14 +756,16 @@  discard block
 block discarded – undo
715 756
 			'href' => $scripturl . '?board=' . $row['id_board'] . '.0',
716 757
 			'link' => '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>'
717 758
 		);
759
+	}
718 760
 	$smcFunc['db_free_result']($request);
719 761
 
720 762
 	// If mods want to do somthing with this list of boards, let them do that now.
721 763
 	call_integration_hook('integrate_ssi_topBoards', array(&$boards));
722 764
 
723 765
 	// If we shouldn't output or have nothing to output, just jump out.
724
-	if ($output_method != 'echo' || empty($boards))
725
-		return $boards;
766
+	if ($output_method != 'echo' || empty($boards)) {
767
+			return $boards;
768
+	}
726 769
 
727 770
 	echo '
728 771
 		<table class="ssi_table">
@@ -731,13 +774,14 @@  discard block
 block discarded – undo
731 774
 				<th style="text-align: left">', $txt['board_topics'], '</th>
732 775
 				<th style="text-align: left">', $txt['posts'], '</th>
733 776
 			</tr>';
734
-	foreach ($boards as $sBoard)
735
-		echo '
777
+	foreach ($boards as $sBoard) {
778
+			echo '
736 779
 			<tr>
737 780
 				<td>', $sBoard['link'], $sBoard['new'] ? ' <a href="' . $sBoard['href'] . '"><span class="new_posts">' . $txt['new'] . '</span></a>' : '', '</td>
738 781
 				<td style="text-align: right">', comma_format($sBoard['num_topics']), '</td>
739 782
 				<td style="text-align: right">', comma_format($sBoard['num_posts']), '</td>
740 783
 			</tr>';
784
+	}
741 785
 	echo '
742 786
 		</table>';
743 787
 }
@@ -770,12 +814,13 @@  discard block
 block discarded – undo
770 814
 			)
771 815
 		);
772 816
 		$topic_ids = array();
773
-		while ($row = $smcFunc['db_fetch_assoc']($request))
774
-			$topic_ids[] = $row['id_topic'];
817
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
818
+					$topic_ids[] = $row['id_topic'];
819
+		}
775 820
 		$smcFunc['db_free_result']($request);
821
+	} else {
822
+			$topic_ids = array();
776 823
 	}
777
-	else
778
-		$topic_ids = array();
779 824
 
780 825
 	$request = $smcFunc['db_query']('', '
781 826
 		SELECT m.subject, m.id_topic, t.num_views, t.num_replies
@@ -814,8 +859,9 @@  discard block
 block discarded – undo
814 859
 	// If mods want to do somthing with this list of topics, let them do that now.
815 860
 	call_integration_hook('integrate_ssi_topTopics', array(&$topics, $type));
816 861
 
817
-	if ($output_method != 'echo' || empty($topics))
818
-		return $topics;
862
+	if ($output_method != 'echo' || empty($topics)) {
863
+			return $topics;
864
+	}
819 865
 
820 866
 	echo '
821 867
 		<table class="ssi_table">
@@ -824,8 +870,8 @@  discard block
 block discarded – undo
824 870
 				<th style="text-align: left">', $txt['views'], '</th>
825 871
 				<th style="text-align: left">', $txt['replies'], '</th>
826 872
 			</tr>';
827
-	foreach ($topics as $sTopic)
828
-		echo '
873
+	foreach ($topics as $sTopic) {
874
+			echo '
829 875
 			<tr>
830 876
 				<td style="text-align: left">
831 877
 					', $sTopic['link'], '
@@ -833,6 +879,7 @@  discard block
 block discarded – undo
833 879
 				<td style="text-align: right">', comma_format($sTopic['num_views']), '</td>
834 880
 				<td style="text-align: right">', comma_format($sTopic['num_replies']), '</td>
835 881
 			</tr>';
882
+	}
836 883
 	echo '
837 884
 		</table>';
838 885
 }
@@ -868,12 +915,13 @@  discard block
 block discarded – undo
868 915
 {
869 916
 	global $txt, $context;
870 917
 
871
-	if ($output_method == 'echo')
872
-		echo '
918
+	if ($output_method == 'echo') {
919
+			echo '
873 920
 	', sprintf($txt['welcome_newest_member'], $context['common_stats']['latest_member']['link']), '<br>';
874
-	else
875
-		return $context['common_stats']['latest_member'];
876
-}
921
+	} else {
922
+			return $context['common_stats']['latest_member'];
923
+	}
924
+	}
877 925
 
878 926
 /**
879 927
  * Fetches a random member.
@@ -922,8 +970,9 @@  discard block
 block discarded – undo
922 970
 	}
923 971
 
924 972
 	// Just to be sure put the random generator back to something... random.
925
-	if ($random_type != '')
926
-		mt_srand(time());
973
+	if ($random_type != '') {
974
+			mt_srand(time());
975
+	}
927 976
 
928 977
 	return $result;
929 978
 }
@@ -936,8 +985,9 @@  discard block
 block discarded – undo
936 985
  */
937 986
 function ssi_fetchMember($member_ids = array(), $output_method = 'echo')
938 987
 {
939
-	if (empty($member_ids))
940
-		return;
988
+	if (empty($member_ids)) {
989
+			return;
990
+	}
941 991
 
942 992
 	// Can have more than one member if you really want...
943 993
 	$member_ids = is_array($member_ids) ? $member_ids : array($member_ids);
@@ -962,8 +1012,9 @@  discard block
 block discarded – undo
962 1012
  */
963 1013
 function ssi_fetchGroupMembers($group_id = null, $output_method = 'echo')
964 1014
 {
965
-	if ($group_id === null)
966
-		return;
1015
+	if ($group_id === null) {
1016
+			return;
1017
+	}
967 1018
 
968 1019
 	$query_where = '
969 1020
 		id_group = {int:id_group}
@@ -990,8 +1041,9 @@  discard block
 block discarded – undo
990 1041
 {
991 1042
 	global $smcFunc, $memberContext;
992 1043
 
993
-	if ($query_where === null)
994
-		return;
1044
+	if ($query_where === null) {
1045
+			return;
1046
+	}
995 1047
 
996 1048
 	// Fetch the members in question.
997 1049
 	$request = $smcFunc['db_query']('', '
@@ -1004,12 +1056,14 @@  discard block
 block discarded – undo
1004 1056
 		))
1005 1057
 	);
1006 1058
 	$members = array();
1007
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1008
-		$members[] = $row['id_member'];
1059
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
1060
+			$members[] = $row['id_member'];
1061
+	}
1009 1062
 	$smcFunc['db_free_result']($request);
1010 1063
 
1011
-	if (empty($members))
1012
-		return array();
1064
+	if (empty($members)) {
1065
+			return array();
1066
+	}
1013 1067
 
1014 1068
 	// If mods want to do somthing with this list of members, let them do that now.
1015 1069
 	call_integration_hook('integrate_ssi_queryMembers', array(&$members));
@@ -1018,23 +1072,25 @@  discard block
 block discarded – undo
1018 1072
 	loadMemberData($members);
1019 1073
 
1020 1074
 	// Draw the table!
1021
-	if ($output_method == 'echo')
1022
-		echo '
1075
+	if ($output_method == 'echo') {
1076
+			echo '
1023 1077
 		<table style="border: none" class="ssi_table">';
1078
+	}
1024 1079
 
1025 1080
 	$query_members = array();
1026 1081
 	foreach ($members as $member)
1027 1082
 	{
1028 1083
 		// Load their context data.
1029
-		if (!loadMemberContext($member))
1030
-			continue;
1084
+		if (!loadMemberContext($member)) {
1085
+					continue;
1086
+		}
1031 1087
 
1032 1088
 		// Store this member's information.
1033 1089
 		$query_members[$member] = $memberContext[$member];
1034 1090
 
1035 1091
 		// Only do something if we're echo'ing.
1036
-		if ($output_method == 'echo')
1037
-			echo '
1092
+		if ($output_method == 'echo') {
1093
+					echo '
1038 1094
 			<tr>
1039 1095
 				<td style="text-align: right; vertical-align: top; white-space: nowrap">
1040 1096
 					', $query_members[$member]['link'], '
@@ -1042,12 +1098,14 @@  discard block
 block discarded – undo
1042 1098
 					<br>', $query_members[$member]['avatar']['image'], '
1043 1099
 				</td>
1044 1100
 			</tr>';
1101
+		}
1045 1102
 	}
1046 1103
 
1047 1104
 	// End the table if appropriate.
1048
-	if ($output_method == 'echo')
1049
-		echo '
1105
+	if ($output_method == 'echo') {
1106
+			echo '
1050 1107
 		</table>';
1108
+	}
1051 1109
 
1052 1110
 	// Send back the data.
1053 1111
 	return $query_members;
@@ -1062,8 +1120,9 @@  discard block
 block discarded – undo
1062 1120
 {
1063 1121
 	global $txt, $scripturl, $modSettings, $smcFunc;
1064 1122
 
1065
-	if (!allowedTo('view_stats'))
1066
-		return;
1123
+	if (!allowedTo('view_stats')) {
1124
+			return;
1125
+	}
1067 1126
 
1068 1127
 	$totals = array(
1069 1128
 		'members' => $modSettings['totalMembers'],
@@ -1092,8 +1151,9 @@  discard block
 block discarded – undo
1092 1151
 	// If mods want to do somthing with the board stats, let them do that now.
1093 1152
 	call_integration_hook('integrate_ssi_boardStats', array(&$totals));
1094 1153
 
1095
-	if ($output_method != 'echo')
1096
-		return $totals;
1154
+	if ($output_method != 'echo') {
1155
+			return $totals;
1156
+	}
1097 1157
 
1098 1158
 	echo '
1099 1159
 		', $txt['total_members'], ': <a href="', $scripturl . '?action=mlist">', comma_format($totals['members']), '</a><br>
@@ -1122,8 +1182,8 @@  discard block
 block discarded – undo
1122 1182
 	call_integration_hook('integrate_ssi_whosOnline', array(&$return));
1123 1183
 
1124 1184
 	// Add some redundancy for backwards compatibility reasons.
1125
-	if ($output_method != 'echo')
1126
-		return $return + array(
1185
+	if ($output_method != 'echo') {
1186
+			return $return + array(
1127 1187
 			'users' => $return['users_online'],
1128 1188
 			'guests' => $return['num_guests'],
1129 1189
 			'hidden' => $return['num_users_hidden'],
@@ -1131,29 +1191,35 @@  discard block
 block discarded – undo
1131 1191
 			'num_users' => $return['num_users_online'],
1132 1192
 			'total_users' => $return['num_users_online'] + $return['num_guests'],
1133 1193
 		);
1194
+	}
1134 1195
 
1135 1196
 	echo '
1136 1197
 		', comma_format($return['num_guests']), ' ', $return['num_guests'] == 1 ? $txt['guest'] : $txt['guests'], ', ', comma_format($return['num_users_online']), ' ', $return['num_users_online'] == 1 ? $txt['user'] : $txt['users'];
1137 1198
 
1138 1199
 	$bracketList = array();
1139
-	if (!empty($user_info['buddies']))
1140
-		$bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']);
1141
-	if (!empty($return['num_spiders']))
1142
-		$bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']);
1143
-	if (!empty($return['num_users_hidden']))
1144
-		$bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden'];
1200
+	if (!empty($user_info['buddies'])) {
1201
+			$bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']);
1202
+	}
1203
+	if (!empty($return['num_spiders'])) {
1204
+			$bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']);
1205
+	}
1206
+	if (!empty($return['num_users_hidden'])) {
1207
+			$bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden'];
1208
+	}
1145 1209
 
1146
-	if (!empty($bracketList))
1147
-		echo ' (' . implode(', ', $bracketList) . ')';
1210
+	if (!empty($bracketList)) {
1211
+			echo ' (' . implode(', ', $bracketList) . ')';
1212
+	}
1148 1213
 
1149 1214
 	echo '<br>
1150 1215
 			', implode(', ', $return['list_users_online']);
1151 1216
 
1152 1217
 	// Showing membergroups?
1153
-	if (!empty($settings['show_group_key']) && !empty($return['membergroups']))
1154
-		echo '<br>
1218
+	if (!empty($settings['show_group_key']) && !empty($return['membergroups'])) {
1219
+			echo '<br>
1155 1220
 			[' . implode(']&nbsp;&nbsp;[', $return['membergroups']) . ']';
1156
-}
1221
+	}
1222
+	}
1157 1223
 
1158 1224
 /**
1159 1225
  * Just like whosOnline except it also logs the online presence.
@@ -1164,11 +1230,12 @@  discard block
 block discarded – undo
1164 1230
 {
1165 1231
 	writeLog();
1166 1232
 
1167
-	if ($output_method != 'echo')
1168
-		return ssi_whosOnline($output_method);
1169
-	else
1170
-		ssi_whosOnline($output_method);
1171
-}
1233
+	if ($output_method != 'echo') {
1234
+			return ssi_whosOnline($output_method);
1235
+	} else {
1236
+			ssi_whosOnline($output_method);
1237
+	}
1238
+	}
1172 1239
 
1173 1240
 // Shows a login box.
1174 1241
 /**
@@ -1181,11 +1248,13 @@  discard block
 block discarded – undo
1181 1248
 {
1182 1249
 	global $scripturl, $txt, $user_info, $context;
1183 1250
 
1184
-	if ($redirect_to != '')
1185
-		$_SESSION['login_url'] = $redirect_to;
1251
+	if ($redirect_to != '') {
1252
+			$_SESSION['login_url'] = $redirect_to;
1253
+	}
1186 1254
 
1187
-	if ($output_method != 'echo' || !$user_info['is_guest'])
1188
-		return $user_info['is_guest'];
1255
+	if ($output_method != 'echo' || !$user_info['is_guest']) {
1256
+			return $user_info['is_guest'];
1257
+	}
1189 1258
 
1190 1259
 	// Create a login token
1191 1260
 	createToken('login');
@@ -1237,8 +1306,9 @@  discard block
 block discarded – undo
1237 1306
 
1238 1307
 	$boardsAllowed = array_intersect(boardsAllowedTo('poll_view'), boardsAllowedTo('poll_vote'));
1239 1308
 
1240
-	if (empty($boardsAllowed))
1241
-		return array();
1309
+	if (empty($boardsAllowed)) {
1310
+			return array();
1311
+	}
1242 1312
 
1243 1313
 	$request = $smcFunc['db_query']('', '
1244 1314
 		SELECT p.id_poll, p.question, t.id_topic, p.max_votes, p.guest_vote, p.hide_results, p.expire_time
@@ -1271,12 +1341,14 @@  discard block
 block discarded – undo
1271 1341
 	$smcFunc['db_free_result']($request);
1272 1342
 
1273 1343
 	// This user has voted on all the polls.
1274
-	if (empty($row) || !is_array($row))
1275
-		return array();
1344
+	if (empty($row) || !is_array($row)) {
1345
+			return array();
1346
+	}
1276 1347
 
1277 1348
 	// If this is a guest who's voted we'll through ourselves to show poll to show the results.
1278
-	if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote'])))))
1279
-		return ssi_showPoll($row['id_topic'], $output_method);
1349
+	if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))))) {
1350
+			return ssi_showPoll($row['id_topic'], $output_method);
1351
+	}
1280 1352
 
1281 1353
 	$request = $smcFunc['db_query']('', '
1282 1354
 		SELECT COUNT(DISTINCT id_member)
@@ -1340,8 +1412,9 @@  discard block
 block discarded – undo
1340 1412
 	// If mods want to do somthing with this list of polls, let them do that now.
1341 1413
 	call_integration_hook('integrate_ssi_recentPoll', array(&$return, $topPollInstead));
1342 1414
 
1343
-	if ($output_method != 'echo')
1344
-		return $return;
1415
+	if ($output_method != 'echo') {
1416
+			return $return;
1417
+	}
1345 1418
 
1346 1419
 	if ($allow_view_results)
1347 1420
 	{
@@ -1350,19 +1423,20 @@  discard block
 block discarded – undo
1350 1423
 			<strong>', $return['question'], '</strong><br>
1351 1424
 			', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : '';
1352 1425
 
1353
-		foreach ($return['options'] as $option)
1354
-			echo '
1426
+		foreach ($return['options'] as $option) {
1427
+					echo '
1355 1428
 			<label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
1429
+		}
1356 1430
 
1357 1431
 		echo '
1358 1432
 			<input type="submit" value="', $txt['poll_vote'], '" class="button_submit">
1359 1433
 			<input type="hidden" name="poll" value="', $return['id'], '">
1360 1434
 			<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1361 1435
 		</form>';
1436
+	} else {
1437
+			echo $txt['poll_cannot_see'];
1438
+	}
1362 1439
 	}
1363
-	else
1364
-		echo $txt['poll_cannot_see'];
1365
-}
1366 1440
 
1367 1441
 /**
1368 1442
  * Shows the poll from the specified topic
@@ -1376,13 +1450,15 @@  discard block
 block discarded – undo
1376 1450
 
1377 1451
 	$boardsAllowed = boardsAllowedTo('poll_view');
1378 1452
 
1379
-	if (empty($boardsAllowed))
1380
-		return array();
1453
+	if (empty($boardsAllowed)) {
1454
+			return array();
1455
+	}
1381 1456
 
1382
-	if ($topic === null && isset($_REQUEST['ssi_topic']))
1383
-		$topic = (int) $_REQUEST['ssi_topic'];
1384
-	else
1385
-		$topic = (int) $topic;
1457
+	if ($topic === null && isset($_REQUEST['ssi_topic'])) {
1458
+			$topic = (int) $_REQUEST['ssi_topic'];
1459
+	} else {
1460
+			$topic = (int) $topic;
1461
+	}
1386 1462
 
1387 1463
 	$request = $smcFunc['db_query']('', '
1388 1464
 		SELECT
@@ -1403,17 +1479,18 @@  discard block
 block discarded – undo
1403 1479
 	);
1404 1480
 
1405 1481
 	// Either this topic has no poll, or the user cannot view it.
1406
-	if ($smcFunc['db_num_rows']($request) == 0)
1407
-		return array();
1482
+	if ($smcFunc['db_num_rows']($request) == 0) {
1483
+			return array();
1484
+	}
1408 1485
 
1409 1486
 	$row = $smcFunc['db_fetch_assoc']($request);
1410 1487
 	$smcFunc['db_free_result']($request);
1411 1488
 
1412 1489
 	// Check if they can vote.
1413 1490
 	$already_voted = false;
1414
-	if (!empty($row['expire_time']) && $row['expire_time'] < time())
1415
-		$allow_vote = false;
1416
-	elseif ($user_info['is_guest'])
1491
+	if (!empty($row['expire_time']) && $row['expire_time'] < time()) {
1492
+			$allow_vote = false;
1493
+	} elseif ($user_info['is_guest'])
1417 1494
 	{
1418 1495
 		// There's a difference between "allowed to vote" and "already voted"...
1419 1496
 		$allow_vote = $row['guest_vote'];
@@ -1423,10 +1500,9 @@  discard block
 block discarded – undo
1423 1500
 		{
1424 1501
 			$already_voted = true;
1425 1502
 		}
1426
-	}
1427
-	elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board']))
1428
-		$allow_vote = false;
1429
-	else
1503
+	} elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board'])) {
1504
+			$allow_vote = false;
1505
+	} else
1430 1506
 	{
1431 1507
 		$request = $smcFunc['db_query']('', '
1432 1508
 			SELECT id_member
@@ -1508,8 +1584,9 @@  discard block
 block discarded – undo
1508 1584
 	// If mods want to do somthing with this poll, let them do that now.
1509 1585
 	call_integration_hook('integrate_ssi_showPoll', array(&$return));
1510 1586
 
1511
-	if ($output_method != 'echo')
1512
-		return $return;
1587
+	if ($output_method != 'echo') {
1588
+			return $return;
1589
+	}
1513 1590
 
1514 1591
 	if ($return['allow_vote'])
1515 1592
 	{
@@ -1518,17 +1595,17 @@  discard block
 block discarded – undo
1518 1595
 				<strong>', $return['question'], '</strong><br>
1519 1596
 				', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : '';
1520 1597
 
1521
-		foreach ($return['options'] as $option)
1522
-			echo '
1598
+		foreach ($return['options'] as $option) {
1599
+					echo '
1523 1600
 				<label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
1601
+		}
1524 1602
 
1525 1603
 		echo '
1526 1604
 				<input type="submit" value="', $txt['poll_vote'], '" class="button_submit">
1527 1605
 				<input type="hidden" name="poll" value="', $return['id'], '">
1528 1606
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1529 1607
 			</form>';
1530
-	}
1531
-	else
1608
+	} else
1532 1609
 	{
1533 1610
 		echo '
1534 1611
 			<div class="ssi_poll">
@@ -1608,27 +1685,32 @@  discard block
 block discarded – undo
1608 1685
 			'is_approved' => 1,
1609 1686
 		)
1610 1687
 	);
1611
-	if ($smcFunc['db_num_rows']($request) == 0)
1612
-		die;
1688
+	if ($smcFunc['db_num_rows']($request) == 0) {
1689
+			die;
1690
+	}
1613 1691
 	$row = $smcFunc['db_fetch_assoc']($request);
1614 1692
 	$smcFunc['db_free_result']($request);
1615 1693
 
1616
-	if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time']))
1617
-		redirectexit('topic=' . $row['id_topic'] . '.0');
1694
+	if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time'])) {
1695
+			redirectexit('topic=' . $row['id_topic'] . '.0');
1696
+	}
1618 1697
 
1619 1698
 	// Too many options checked?
1620
-	if (count($_REQUEST['options']) > $row['max_votes'])
1621
-		redirectexit('topic=' . $row['id_topic'] . '.0');
1699
+	if (count($_REQUEST['options']) > $row['max_votes']) {
1700
+			redirectexit('topic=' . $row['id_topic'] . '.0');
1701
+	}
1622 1702
 
1623 1703
 	// It's a guest who has already voted?
1624 1704
 	if ($user_info['is_guest'])
1625 1705
 	{
1626 1706
 		// Guest voting disabled?
1627
-		if (!$row['guest_vote'])
1628
-			redirectexit('topic=' . $row['id_topic'] . '.0');
1707
+		if (!$row['guest_vote']) {
1708
+					redirectexit('topic=' . $row['id_topic'] . '.0');
1709
+		}
1629 1710
 		// Already voted?
1630
-		elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote'])))
1631
-			redirectexit('topic=' . $row['id_topic'] . '.0');
1711
+		elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))) {
1712
+					redirectexit('topic=' . $row['id_topic'] . '.0');
1713
+		}
1632 1714
 	}
1633 1715
 
1634 1716
 	$sOptions = array();
@@ -1682,11 +1764,13 @@  discard block
 block discarded – undo
1682 1764
 {
1683 1765
 	global $scripturl, $txt, $context;
1684 1766
 
1685
-	if (!allowedTo('search_posts'))
1686
-		return;
1767
+	if (!allowedTo('search_posts')) {
1768
+			return;
1769
+	}
1687 1770
 
1688
-	if ($output_method != 'echo')
1689
-		return $scripturl . '?action=search';
1771
+	if ($output_method != 'echo') {
1772
+			return $scripturl . '?action=search';
1773
+	}
1690 1774
 
1691 1775
 	echo '
1692 1776
 		<form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '">
@@ -1708,8 +1792,9 @@  discard block
 block discarded – undo
1708 1792
 	// If mods want to do somthing with the news, let them do that now. Don't need to pass the news line itself, since it is already in $context.
1709 1793
 	call_integration_hook('integrate_ssi_news');
1710 1794
 
1711
-	if ($output_method != 'echo')
1712
-		return $context['random_news_line'];
1795
+	if ($output_method != 'echo') {
1796
+			return $context['random_news_line'];
1797
+	}
1713 1798
 
1714 1799
 	echo $context['random_news_line'];
1715 1800
 }
@@ -1723,8 +1808,9 @@  discard block
 block discarded – undo
1723 1808
 {
1724 1809
 	global $scripturl, $modSettings, $user_info;
1725 1810
 
1726
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view'))
1727
-		return;
1811
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view')) {
1812
+			return;
1813
+	}
1728 1814
 
1729 1815
 	$eventOptions = array(
1730 1816
 		'include_birthdays' => true,
@@ -1735,13 +1821,15 @@  discard block
 block discarded – undo
1735 1821
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1736 1822
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1737 1823
 
1738
-	if ($output_method != 'echo')
1739
-		return $return['calendar_birthdays'];
1824
+	if ($output_method != 'echo') {
1825
+			return $return['calendar_birthdays'];
1826
+	}
1740 1827
 
1741
-	foreach ($return['calendar_birthdays'] as $member)
1742
-		echo '
1828
+	foreach ($return['calendar_birthdays'] as $member) {
1829
+			echo '
1743 1830
 			<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">' . $member['name'] . '</span>' . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>' . (!$member['is_last'] ? ', ' : '');
1744
-}
1831
+	}
1832
+	}
1745 1833
 
1746 1834
 /**
1747 1835
  * Shows today's holidays.
@@ -1752,8 +1840,9 @@  discard block
 block discarded – undo
1752 1840
 {
1753 1841
 	global $modSettings, $user_info;
1754 1842
 
1755
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
1756
-		return;
1843
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
1844
+			return;
1845
+	}
1757 1846
 
1758 1847
 	$eventOptions = array(
1759 1848
 		'include_holidays' => true,
@@ -1764,8 +1853,9 @@  discard block
 block discarded – undo
1764 1853
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1765 1854
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1766 1855
 
1767
-	if ($output_method != 'echo')
1768
-		return $return['calendar_holidays'];
1856
+	if ($output_method != 'echo') {
1857
+			return $return['calendar_holidays'];
1858
+	}
1769 1859
 
1770 1860
 	echo '
1771 1861
 		', implode(', ', $return['calendar_holidays']);
@@ -1779,8 +1869,9 @@  discard block
 block discarded – undo
1779 1869
 {
1780 1870
 	global $modSettings, $user_info;
1781 1871
 
1782
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
1783
-		return;
1872
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
1873
+			return;
1874
+	}
1784 1875
 
1785 1876
 	$eventOptions = array(
1786 1877
 		'include_events' => true,
@@ -1791,14 +1882,16 @@  discard block
 block discarded – undo
1791 1882
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1792 1883
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1793 1884
 
1794
-	if ($output_method != 'echo')
1795
-		return $return['calendar_events'];
1885
+	if ($output_method != 'echo') {
1886
+			return $return['calendar_events'];
1887
+	}
1796 1888
 
1797 1889
 	foreach ($return['calendar_events'] as $event)
1798 1890
 	{
1799
-		if ($event['can_edit'])
1800
-			echo '
1891
+		if ($event['can_edit']) {
1892
+					echo '
1801 1893
 	<a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> ';
1894
+		}
1802 1895
 		echo '
1803 1896
 	' . $event['link'] . (!$event['is_last'] ? ', ' : '');
1804 1897
 	}
@@ -1813,8 +1906,9 @@  discard block
 block discarded – undo
1813 1906
 {
1814 1907
 	global $modSettings, $txt, $scripturl, $user_info;
1815 1908
 
1816
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
1817
-		return;
1909
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
1910
+			return;
1911
+	}
1818 1912
 
1819 1913
 	$eventOptions = array(
1820 1914
 		'include_birthdays' => allowedTo('profile_view'),
@@ -1827,19 +1921,22 @@  discard block
 block discarded – undo
1827 1921
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1828 1922
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1829 1923
 
1830
-	if ($output_method != 'echo')
1831
-		return $return;
1924
+	if ($output_method != 'echo') {
1925
+			return $return;
1926
+	}
1832 1927
 
1833
-	if (!empty($return['calendar_holidays']))
1834
-		echo '
1928
+	if (!empty($return['calendar_holidays'])) {
1929
+			echo '
1835 1930
 			<span class="holiday">' . $txt['calendar_prompt'] . ' ' . implode(', ', $return['calendar_holidays']) . '<br></span>';
1931
+	}
1836 1932
 	if (!empty($return['calendar_birthdays']))
1837 1933
 	{
1838 1934
 		echo '
1839 1935
 			<span class="birthday">' . $txt['birthdays_upcoming'] . '</span> ';
1840
-		foreach ($return['calendar_birthdays'] as $member)
1841
-			echo '
1936
+		foreach ($return['calendar_birthdays'] as $member) {
1937
+					echo '
1842 1938
 			<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', !$member['is_last'] ? ', ' : '';
1939
+		}
1843 1940
 		echo '
1844 1941
 			<br>';
1845 1942
 	}
@@ -1849,9 +1946,10 @@  discard block
 block discarded – undo
1849 1946
 			<span class="event">' . $txt['events_upcoming'] . '</span> ';
1850 1947
 		foreach ($return['calendar_events'] as $event)
1851 1948
 		{
1852
-			if ($event['can_edit'])
1853
-				echo '
1949
+			if ($event['can_edit']) {
1950
+							echo '
1854 1951
 			<a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> ';
1952
+			}
1855 1953
 			echo '
1856 1954
 			' . $event['link'] . (!$event['is_last'] ? ', ' : '');
1857 1955
 		}
@@ -1875,25 +1973,29 @@  discard block
 block discarded – undo
1875 1973
 	loadLanguage('Stats');
1876 1974
 
1877 1975
 	// Must be integers....
1878
-	if ($limit === null)
1879
-		$limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5;
1880
-	else
1881
-		$limit = (int) $limit;
1882
-
1883
-	if ($start === null)
1884
-		$start = isset($_GET['start']) ? (int) $_GET['start'] : 0;
1885
-	else
1886
-		$start = (int) $start;
1887
-
1888
-	if ($board !== null)
1889
-		$board = (int) $board;
1890
-	elseif (isset($_GET['board']))
1891
-		$board = (int) $_GET['board'];
1892
-
1893
-	if ($length === null)
1894
-		$length = isset($_GET['length']) ? (int) $_GET['length'] : 0;
1895
-	else
1896
-		$length = (int) $length;
1976
+	if ($limit === null) {
1977
+			$limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5;
1978
+	} else {
1979
+			$limit = (int) $limit;
1980
+	}
1981
+
1982
+	if ($start === null) {
1983
+			$start = isset($_GET['start']) ? (int) $_GET['start'] : 0;
1984
+	} else {
1985
+			$start = (int) $start;
1986
+	}
1987
+
1988
+	if ($board !== null) {
1989
+			$board = (int) $board;
1990
+	} elseif (isset($_GET['board'])) {
1991
+			$board = (int) $_GET['board'];
1992
+	}
1993
+
1994
+	if ($length === null) {
1995
+			$length = isset($_GET['length']) ? (int) $_GET['length'] : 0;
1996
+	} else {
1997
+			$length = (int) $length;
1998
+	}
1897 1999
 
1898 2000
 	$limit = max(0, $limit);
1899 2001
 	$start = max(0, $start);
@@ -1911,17 +2013,19 @@  discard block
 block discarded – undo
1911 2013
 	);
1912 2014
 	if ($smcFunc['db_num_rows']($request) == 0)
1913 2015
 	{
1914
-		if ($output_method == 'echo')
1915
-			die($txt['ssi_no_guests']);
1916
-		else
1917
-			return array();
2016
+		if ($output_method == 'echo') {
2017
+					die($txt['ssi_no_guests']);
2018
+		} else {
2019
+					return array();
2020
+		}
1918 2021
 	}
1919 2022
 	list ($board) = $smcFunc['db_fetch_row']($request);
1920 2023
 	$smcFunc['db_free_result']($request);
1921 2024
 
1922 2025
 	$icon_sources = array();
1923
-	foreach ($context['stable_icons'] as $icon)
1924
-		$icon_sources[$icon] = 'images_url';
2026
+	foreach ($context['stable_icons'] as $icon) {
2027
+			$icon_sources[$icon] = 'images_url';
2028
+	}
1925 2029
 
1926 2030
 	if (!empty($modSettings['enable_likes']))
1927 2031
 	{
@@ -1945,12 +2049,14 @@  discard block
 block discarded – undo
1945 2049
 		)
1946 2050
 	);
1947 2051
 	$posts = array();
1948
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1949
-		$posts[] = $row['id_first_msg'];
2052
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2053
+			$posts[] = $row['id_first_msg'];
2054
+	}
1950 2055
 	$smcFunc['db_free_result']($request);
1951 2056
 
1952
-	if (empty($posts))
1953
-		return array();
2057
+	if (empty($posts)) {
2058
+			return array();
2059
+	}
1954 2060
 
1955 2061
 	// Find the posts.
1956 2062
 	$request = $smcFunc['db_query']('', '
@@ -1980,24 +2086,28 @@  discard block
 block discarded – undo
1980 2086
 			$last_space = strrpos($row['body'], ' ');
1981 2087
 			$last_open = strrpos($row['body'], '<');
1982 2088
 			$last_close = strrpos($row['body'], '>');
1983
-			if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6)
1984
-				$cutoff = $last_open;
1985
-			elseif (empty($last_close) || $last_close < $last_open)
1986
-				$cutoff = $last_space;
2089
+			if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6) {
2090
+							$cutoff = $last_open;
2091
+			} elseif (empty($last_close) || $last_close < $last_open) {
2092
+							$cutoff = $last_space;
2093
+			}
1987 2094
 
1988
-			if ($cutoff !== false)
1989
-				$row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff);
2095
+			if ($cutoff !== false) {
2096
+							$row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff);
2097
+			}
1990 2098
 			$row['body'] .= '...';
1991 2099
 		}
1992 2100
 
1993 2101
 		$row['body'] = parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']);
1994 2102
 
1995
-		if (!empty($recycle_board) && $row['id_board'] == $recycle_board)
1996
-			$row['icon'] = 'recycled';
2103
+		if (!empty($recycle_board) && $row['id_board'] == $recycle_board) {
2104
+					$row['icon'] = 'recycled';
2105
+		}
1997 2106
 
1998 2107
 		// Check that this message icon is there...
1999
-		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']]))
2000
-			$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
2108
+		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) {
2109
+					$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
2110
+		}
2001 2111
 
2002 2112
 		censorText($row['subject']);
2003 2113
 		censorText($row['body']);
@@ -2034,16 +2144,18 @@  discard block
 block discarded – undo
2034 2144
 	}
2035 2145
 	$smcFunc['db_free_result']($request);
2036 2146
 
2037
-	if (empty($return))
2038
-		return $return;
2147
+	if (empty($return)) {
2148
+			return $return;
2149
+	}
2039 2150
 
2040 2151
 	$return[count($return) - 1]['is_last'] = true;
2041 2152
 
2042 2153
 	// If mods want to do somthing with this list of posts, let them do that now.
2043 2154
 	call_integration_hook('integrate_ssi_boardNews', array(&$return));
2044 2155
 
2045
-	if ($output_method != 'echo')
2046
-		return $return;
2156
+	if ($output_method != 'echo') {
2157
+			return $return;
2158
+	}
2047 2159
 
2048 2160
 	foreach ($return as $news)
2049 2161
 	{
@@ -2095,9 +2207,10 @@  discard block
 block discarded – undo
2095 2207
 		echo '
2096 2208
 			</div>';
2097 2209
 
2098
-		if (!$news['is_last'])
2099
-			echo '
2210
+		if (!$news['is_last']) {
2211
+					echo '
2100 2212
 			<hr>';
2213
+		}
2101 2214
 	}
2102 2215
 }
2103 2216
 
@@ -2111,8 +2224,9 @@  discard block
 block discarded – undo
2111 2224
 {
2112 2225
 	global $user_info, $scripturl, $modSettings, $txt, $context, $smcFunc;
2113 2226
 
2114
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
2115
-		return;
2227
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
2228
+			return;
2229
+	}
2116 2230
 
2117 2231
 	// Find all events which are happening in the near future that the member can see.
2118 2232
 	$request = $smcFunc['db_query']('', '
@@ -2137,20 +2251,23 @@  discard block
 block discarded – undo
2137 2251
 	while ($row = $smcFunc['db_fetch_assoc']($request))
2138 2252
 	{
2139 2253
 		// Check if we've already come by an event linked to this same topic with the same title... and don't display it if we have.
2140
-		if (!empty($duplicates[$row['title'] . $row['id_topic']]))
2141
-			continue;
2254
+		if (!empty($duplicates[$row['title'] . $row['id_topic']])) {
2255
+					continue;
2256
+		}
2142 2257
 
2143 2258
 		// Censor the title.
2144 2259
 		censorText($row['title']);
2145 2260
 
2146
-		if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false)))
2147
-			$date = strftime('%Y-%m-%d', forum_time(false));
2148
-		else
2149
-			$date = $row['start_date'];
2261
+		if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false))) {
2262
+					$date = strftime('%Y-%m-%d', forum_time(false));
2263
+		} else {
2264
+					$date = $row['start_date'];
2265
+		}
2150 2266
 
2151 2267
 		// If the topic it is attached to is not approved then don't link it.
2152
-		if (!empty($row['id_first_msg']) && !$row['approved'])
2153
-			$row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0;
2268
+		if (!empty($row['id_first_msg']) && !$row['approved']) {
2269
+					$row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0;
2270
+		}
2154 2271
 
2155 2272
 		$return[$date][] = array(
2156 2273
 			'id' => $row['id_event'],
@@ -2169,24 +2286,27 @@  discard block
 block discarded – undo
2169 2286
 	}
2170 2287
 	$smcFunc['db_free_result']($request);
2171 2288
 
2172
-	foreach ($return as $mday => $array)
2173
-		$return[$mday][count($array) - 1]['is_last'] = true;
2289
+	foreach ($return as $mday => $array) {
2290
+			$return[$mday][count($array) - 1]['is_last'] = true;
2291
+	}
2174 2292
 
2175 2293
 	// If mods want to do somthing with this list of events, let them do that now.
2176 2294
 	call_integration_hook('integrate_ssi_recentEvents', array(&$return));
2177 2295
 
2178
-	if ($output_method != 'echo' || empty($return))
2179
-		return $return;
2296
+	if ($output_method != 'echo' || empty($return)) {
2297
+			return $return;
2298
+	}
2180 2299
 
2181 2300
 	// Well the output method is echo.
2182 2301
 	echo '
2183 2302
 			<span class="event">' . $txt['events'] . '</span> ';
2184
-	foreach ($return as $mday => $array)
2185
-		foreach ($array as $event)
2303
+	foreach ($return as $mday => $array) {
2304
+			foreach ($array as $event)
2186 2305
 		{
2187 2306
 			if ($event['can_edit'])
2188 2307
 				echo '
2189 2308
 				<a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> ';
2309
+	}
2190 2310
 
2191 2311
 			echo '
2192 2312
 				' . $event['link'] . (!$event['is_last'] ? ', ' : '');
@@ -2205,8 +2325,9 @@  discard block
 block discarded – undo
2205 2325
 	global $smcFunc;
2206 2326
 
2207 2327
 	// If $id is null, this was most likely called from a query string and should do nothing.
2208
-	if ($id === null)
2209
-		return;
2328
+	if ($id === null) {
2329
+			return;
2330
+	}
2210 2331
 
2211 2332
 	$request = $smcFunc['db_query']('', '
2212 2333
 		SELECT passwd, member_name, is_activated
@@ -2238,8 +2359,9 @@  discard block
 block discarded – undo
2238 2359
 	$attachments_boards = boardsAllowedTo('view_attachments');
2239 2360
 
2240 2361
 	// No boards?  Adios amigo.
2241
-	if (empty($attachments_boards))
2242
-		return array();
2362
+	if (empty($attachments_boards)) {
2363
+			return array();
2364
+	}
2243 2365
 
2244 2366
 	// Is it an array?
2245 2367
 	$attachment_ext = (array) $attachment_ext;
@@ -2323,8 +2445,9 @@  discard block
 block discarded – undo
2323 2445
 	call_integration_hook('integrate_ssi_recentAttachments', array(&$attachments));
2324 2446
 
2325 2447
 	// So you just want an array?  Here you can have it.
2326
-	if ($output_method == 'array' || empty($attachments))
2327
-		return $attachments;
2448
+	if ($output_method == 'array' || empty($attachments)) {
2449
+			return $attachments;
2450
+	}
2328 2451
 
2329 2452
 	// Give them the default.
2330 2453
 	echo '
@@ -2335,14 +2458,15 @@  discard block
 block discarded – undo
2335 2458
 				<th style="text-align: left; padding: 2">', $txt['downloads'], '</th>
2336 2459
 				<th style="text-align: left; padding: 2">', $txt['filesize'], '</th>
2337 2460
 			</tr>';
2338
-	foreach ($attachments as $attach)
2339
-		echo '
2461
+	foreach ($attachments as $attach) {
2462
+			echo '
2340 2463
 			<tr>
2341 2464
 				<td>', $attach['file']['link'], '</td>
2342 2465
 				<td>', $attach['member']['link'], '</td>
2343 2466
 				<td style="text-align: center">', $attach['file']['downloads'], '</td>
2344 2467
 				<td>', $attach['file']['filesize'], '</td>
2345 2468
 			</tr>';
2469
+	}
2346 2470
 	echo '
2347 2471
 		</table>';
2348 2472
 }
Please login to merge, or discard this patch.
Themes/default/Calendar.template.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
  *
61 61
  * @param string $grid_name The grid name
62 62
  * @param bool $is_mini Is this a mini grid?
63
- * @return void|bool Returns false if the grid doesn't exist.
63
+ * @return false|null Returns false if the grid doesn't exist.
64 64
  */
65 65
 function template_show_month_grid($grid_name, $is_mini = false)
66 66
 {
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
  * Shows a weekly grid
313 313
  *
314 314
  * @param string $grid_name The name of the grid
315
- * @return void|bool Returns false if the grid doesn't exist
315
+ * @return false|null Returns false if the grid doesn't exist
316 316
  */
317 317
 function template_show_week_grid($grid_name)
318 318
 {
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -253,9 +253,9 @@  discard block
 block discarded – undo
253 253
 					{
254 254
 						// Sort events by start time (all day events will be listed first)
255 255
 						uasort($day['events'], function ($a, $b) {
256
-						    if ($a['start_timestamp'] == $b['start_timestamp'])
257
-						        return 0;
258
-						    return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
256
+							if ($a['start_timestamp'] == $b['start_timestamp'])
257
+								return 0;
258
+							return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
259 259
 						});
260 260
 
261 261
 						echo '
@@ -436,9 +436,9 @@  discard block
 block discarded – undo
436 436
 							{
437 437
 								// Sort events by start time (all day events will be listed first)
438 438
 								uasort($day['events'], function ($a, $b) {
439
-								    if ($a['start_timestamp'] == $b['start_timestamp'])
440
-								        return 0;
441
-								    return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
439
+									if ($a['start_timestamp'] == $b['start_timestamp'])
440
+										return 0;
441
+									return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
442 442
 								});
443 443
 
444 444
 								foreach ($day['events'] as $event)
Please login to merge, or discard this patch.
Braces   +122 added lines, -92 removed lines patch added patch discarded remove patch
@@ -40,8 +40,7 @@  discard block
 block discarded – undo
40 40
 				', template_show_week_grid('main'), '
41 41
 			</div>
42 42
 		';
43
-	}
44
-	else
43
+	} else
45 44
 	{
46 45
 		echo '
47 46
 			<div id="main_grid">
@@ -67,17 +66,19 @@  discard block
 block discarded – undo
67 66
 	global $context, $settings, $txt, $scripturl, $modSettings;
68 67
 
69 68
 	// If the grid doesn't exist, no point in proceeding.
70
-	if (!isset($context['calendar_grid_' . $grid_name]))
71
-		return false;
69
+	if (!isset($context['calendar_grid_' . $grid_name])) {
70
+			return false;
71
+	}
72 72
 
73 73
 	// A handy little pointer variable.
74 74
 	$calendar_data = &$context['calendar_grid_' . $grid_name];
75 75
 
76 76
 	// Some conditions for whether or not we should show the week links *here*.
77
-	if (isset($calendar_data['show_week_links']) && ($calendar_data['show_week_links'] == 3 || (($calendar_data['show_week_links'] == 1 && $is_mini === true) || $calendar_data['show_week_links'] == 2 && $is_mini === false)))
78
-		$show_week_links = true;
79
-	else
80
-		$show_week_links = false;
77
+	if (isset($calendar_data['show_week_links']) && ($calendar_data['show_week_links'] == 3 || (($calendar_data['show_week_links'] == 1 && $is_mini === true) || $calendar_data['show_week_links'] == 2 && $is_mini === false))) {
78
+			$show_week_links = true;
79
+	} else {
80
+			$show_week_links = false;
81
+	}
81 82
 
82 83
 	// Assuming that we've not disabled it, show the title block!
83 84
 	if (empty($calendar_data['disable_title']))
@@ -124,8 +125,9 @@  discard block
 block discarded – undo
124 125
 		echo '<tr>';
125 126
 
126 127
 		// If we're showing week links, there's an extra column ahead of the week links, so let's think ahead and be prepared!
127
-		if ($show_week_links === true)
128
-			echo '<th>&nbsp;</th>';
128
+		if ($show_week_links === true) {
129
+					echo '<th>&nbsp;</th>';
130
+		}
129 131
 
130 132
 		// Now, loop through each actual day of the week.
131 133
 		foreach ($calendar_data['week_days'] as $day)
@@ -172,27 +174,29 @@  discard block
 block discarded – undo
172 174
 				// Additional classes are given for events, holidays, and birthdays.
173 175
 				if (!empty($day['events']) && !empty($calendar_data['highlight']['events']))
174 176
 				{
175
-					if ($is_mini === true && in_array($calendar_data['highlight']['events'], array(1, 3)))
176
-						$classes[] = 'events';
177
-					elseif ($is_mini === false && in_array($calendar_data['highlight']['events'], array(2, 3)))
178
-						$classes[] = 'events';
177
+					if ($is_mini === true && in_array($calendar_data['highlight']['events'], array(1, 3))) {
178
+											$classes[] = 'events';
179
+					} elseif ($is_mini === false && in_array($calendar_data['highlight']['events'], array(2, 3))) {
180
+											$classes[] = 'events';
181
+					}
179 182
 				}
180 183
 				if (!empty($day['holidays']) && !empty($calendar_data['highlight']['holidays']))
181 184
 				{
182
-					if ($is_mini === true && in_array($calendar_data['highlight']['holidays'], array(1, 3)))
183
-						$classes[] = 'holidays';
184
-					elseif ($is_mini === false && in_array($calendar_data['highlight']['holidays'], array(2, 3)))
185
-						$classes[] = 'holidays';
185
+					if ($is_mini === true && in_array($calendar_data['highlight']['holidays'], array(1, 3))) {
186
+											$classes[] = 'holidays';
187
+					} elseif ($is_mini === false && in_array($calendar_data['highlight']['holidays'], array(2, 3))) {
188
+											$classes[] = 'holidays';
189
+					}
186 190
 				}
187 191
 				if (!empty($day['birthdays']) && !empty($calendar_data['highlight']['birthdays']))
188 192
 				{
189
-					if ($is_mini === true && in_array($calendar_data['highlight']['birthdays'], array(1, 3)))
190
-						$classes[] = 'birthdays';
191
-					elseif ($is_mini === false && in_array($calendar_data['highlight']['birthdays'], array(2, 3)))
192
-						$classes[] = 'birthdays';
193
+					if ($is_mini === true && in_array($calendar_data['highlight']['birthdays'], array(1, 3))) {
194
+											$classes[] = 'birthdays';
195
+					} elseif ($is_mini === false && in_array($calendar_data['highlight']['birthdays'], array(2, 3))) {
196
+											$classes[] = 'birthdays';
197
+					}
193 198
 				}
194
-			}
195
-			else
199
+			} else
196 200
 			{
197 201
 				// Default Classes (either compact or comfortable and disabled).
198 202
 				$classes[] = !empty($calendar_data['size']) && $calendar_data['size'] == 'small' ? 'compact' : 'comfortable';
@@ -210,17 +214,19 @@  discard block
 block discarded – undo
210 214
 				$title_prefix = !empty($day['is_first_of_month']) && $context['current_month'] == $calendar_data['current_month'] && $is_mini === false ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$calendar_data['current_month']] . ' ' : $txt['months_titles'][$calendar_data['current_month']] . ' ') : '';
211 215
 
212 216
 				// The actual day number - be it a link, or just plain old text!
213
-				if (!empty($modSettings['cal_daysaslink']) && $context['can_post'])
214
-					echo '<a href="', $scripturl, '?action=calendar;sa=post;year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>';
215
-				else
216
-					echo '<span class="day_text">', $title_prefix, $day['day'], '</span>';
217
+				if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) {
218
+									echo '<a href="', $scripturl, '?action=calendar;sa=post;year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>';
219
+				} else {
220
+									echo '<span class="day_text">', $title_prefix, $day['day'], '</span>';
221
+				}
217 222
 
218 223
 				// A lot of stuff, we're not showing on mini-calendars to conserve space.
219 224
 				if ($is_mini === false)
220 225
 				{
221 226
 					// Holidays are always fun, let's show them!
222
-					if (!empty($day['holidays']))
223
-						echo '<div class="smalltext holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $day['holidays']), '</div>';
227
+					if (!empty($day['holidays'])) {
228
+											echo '<div class="smalltext holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $day['holidays']), '</div>';
229
+					}
224 230
 
225 231
 					// Happy Birthday Dear, Member!
226 232
 					if (!empty($day['birthdays']))
@@ -238,14 +244,16 @@  discard block
 block discarded – undo
238 244
 							echo '<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', $member['is_last'] || ($count == 10 && $use_js_hide) ? '' : ', ';
239 245
 
240 246
 							// 9...10! Let's stop there.
241
-							if ($birthday_count == 10 && $use_js_hide)
242
-								// !!TODO - Inline CSS and JavaScript should be moved.
247
+							if ($birthday_count == 10 && $use_js_hide) {
248
+															// !!TODO - Inline CSS and JavaScript should be moved.
243 249
 								echo '<span class="hidelink" id="bdhidelink_', $day['day'], '">...<br><a href="', $scripturl, '?action=calendar;month=', $calendar_data['current_month'], ';year=', $calendar_data['current_year'], ';showbd" onclick="document.getElementById(\'bdhide_', $day['day'], '\').style.display = \'\'; document.getElementById(\'bdhidelink_', $day['day'], '\').style.display = \'none\'; return false;">(', sprintf($txt['calendar_click_all'], count($day['birthdays'])), ')</a></span><span id="bdhide_', $day['day'], '" style="display: none;">, ';
250
+							}
244 251
 
245 252
 							++$birthday_count;
246 253
 						}
247
-						if ($use_js_hide)
248
-							echo '</span>';
254
+						if ($use_js_hide) {
255
+													echo '</span>';
256
+						}
249 257
 
250 258
 						echo '</div>';
251 259
 					}
@@ -255,8 +263,9 @@  discard block
 block discarded – undo
255 263
 					{
256 264
 						// Sort events by start time (all day events will be listed first)
257 265
 						uasort($day['events'], function($a, $b) {
258
-						    if ($a['start_timestamp'] == $b['start_timestamp'])
259
-						        return 0;
266
+						    if ($a['start_timestamp'] == $b['start_timestamp']) {
267
+						    						        return 0;
268
+						    }
260 269
 						    return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
261 270
 						});
262 271
 
@@ -272,17 +281,19 @@  discard block
 block discarded – undo
272 281
 
273 282
 							echo '<div class="event_wrapper', $event['starts_today'] == true ? ' event_starts_today' : '', $event['ends_today'] == true ? ' event_ends_today' : '', $event['allday'] == true ? ' allday' : '', $event['is_selected'] ? ' sel_event' : '', '">', $event['link'], '<br><span class="event_time', empty($event_icons_needed) ? ' floatright' : '', '">';
274 283
 
275
-							if (!empty($event['start_time_local']) && $event['starts_today'] == true)
276
-								echo trim(str_replace(':00 ', ' ', $event['start_time_local']));
277
-							elseif (!empty($event['end_time_local']) && $event['ends_today'] == true)
278
-								echo strtolower($txt['ends']), ' ', trim(str_replace(':00 ', ' ', $event['end_time_local']));
279
-							elseif (!empty($event['allday']))
280
-								echo $txt['calendar_allday'];
284
+							if (!empty($event['start_time_local']) && $event['starts_today'] == true) {
285
+															echo trim(str_replace(':00 ', ' ', $event['start_time_local']));
286
+							} elseif (!empty($event['end_time_local']) && $event['ends_today'] == true) {
287
+															echo strtolower($txt['ends']), ' ', trim(str_replace(':00 ', ' ', $event['end_time_local']));
288
+							} elseif (!empty($event['allday'])) {
289
+															echo $txt['calendar_allday'];
290
+							}
281 291
 
282 292
 							echo '</span>';
283 293
 
284
-							if (!empty($event['location']))
285
-								echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
294
+							if (!empty($event['location'])) {
295
+															echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
296
+							}
286 297
 
287 298
 							if ($event['can_edit'] || $event['can_export'])
288 299
 							{
@@ -319,10 +330,11 @@  discard block
 block discarded – undo
319 330
 			// Otherwise, assuming it's not a mini-calendar, we can show previous / next month days!
320 331
 			elseif ($is_mini === false)
321 332
 			{
322
-				if (empty($current_month_started) && !empty($context['calendar_grid_prev']))
323
-					echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_prev']['current_year'], ';month=', $context['calendar_grid_prev']['current_month'], '">', $context['calendar_grid_prev']['last_of_month'] - $calendar_data['shift']-- +1, '</a>';
324
-				elseif (!empty($current_month_started) && !empty($context['calendar_grid_next']))
325
-					echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_next']['current_year'], ';month=', $context['calendar_grid_next']['current_month'], '">', $current_month_started + 1 == $count ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$context['calendar_grid_next']['current_month']] . ' ' : $txt['months_titles'][$context['calendar_grid_next']['current_month']] . ' ') : '', $final_count++, '</a>';
333
+				if (empty($current_month_started) && !empty($context['calendar_grid_prev'])) {
334
+									echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_prev']['current_year'], ';month=', $context['calendar_grid_prev']['current_month'], '">', $context['calendar_grid_prev']['last_of_month'] - $calendar_data['shift']-- +1, '</a>';
335
+				} elseif (!empty($current_month_started) && !empty($context['calendar_grid_next'])) {
336
+									echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_next']['current_year'], ';month=', $context['calendar_grid_next']['current_month'], '">', $current_month_started + 1 == $count ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$context['calendar_grid_next']['current_month']] . ' ' : $txt['months_titles'][$context['calendar_grid_next']['current_month']] . ' ') : '', $final_count++, '</a>';
337
+				}
326 338
 			}
327 339
 
328 340
 			// Close this day and increase var count.
@@ -334,8 +346,9 @@  discard block
 block discarded – undo
334 346
 	}
335 347
 
336 348
 	// Quick Month Navigation + Post Event Link on Main Grids!
337
-	if ($is_mini === false)
338
-		template_calendar_base($show_week_links === true ? 8 : 7);
349
+	if ($is_mini === false) {
350
+			template_calendar_base($show_week_links === true ? 8 : 7);
351
+	}
339 352
 
340 353
 	// The end of our main table.
341 354
 	echo '</table>';
@@ -352,8 +365,9 @@  discard block
 block discarded – undo
352 365
 	global $context, $settings, $txt, $scripturl, $modSettings;
353 366
 
354 367
 	// We might have no reason to proceed, if the variable isn't there.
355
-	if (!isset($context['calendar_grid_' . $grid_name]))
356
-		return false;
368
+	if (!isset($context['calendar_grid_' . $grid_name])) {
369
+			return false;
370
+	}
357 371
 
358 372
 	// Handy pointer.
359 373
 	$calendar_data = &$context['calendar_grid_' . $grid_name];
@@ -389,8 +403,9 @@  discard block
 block discarded – undo
389 403
 					}
390 404
 
391 405
 					// The Month Title + Week Number...
392
-					if (!empty($calendar_data['week_title']))
393
-							echo $calendar_data['week_title'];
406
+					if (!empty($calendar_data['week_title'])) {
407
+												echo $calendar_data['week_title'];
408
+					}
394 409
 
395 410
 					echo '
396 411
 					</h3>
@@ -426,10 +441,11 @@  discard block
 block discarded – undo
426 441
 						<tr class="days_wrapper">
427 442
 							<td class="', implode(' ', $classes), ' act_day">';
428 443
 							// Should the day number be a link?
429
-							if (!empty($modSettings['cal_daysaslink']) && $context['can_post'])
430
-								echo '<a href="', $scripturl, '?action=calendar;sa=post;month=', $month_data['current_month'], ';year=', $month_data['current_year'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['days'][$day['day_of_week']], ' - ', $day['day'], '</a>';
431
-							else
432
-								echo $txt['days'][$day['day_of_week']], ' - ', $day['day'];
444
+							if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) {
445
+															echo '<a href="', $scripturl, '?action=calendar;sa=post;month=', $month_data['current_month'], ';year=', $month_data['current_year'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['days'][$day['day_of_week']], ' - ', $day['day'], '</a>';
446
+							} else {
447
+															echo $txt['days'][$day['day_of_week']], ' - ', $day['day'];
448
+							}
433 449
 
434 450
 							echo '</td>
435 451
 							<td class="', implode(' ', $classes), '', empty($day['events']) ? (' disabled' . ($context['can_post'] ? ' week_post' : '')) : ' events', ' event_col" data-css-prefix="' . $txt['events'] . ' ', (empty($day['events']) && empty($context['can_post'])) ? $txt['none'] : '', '">';
@@ -438,8 +454,9 @@  discard block
 block discarded – undo
438 454
 							{
439 455
 								// Sort events by start time (all day events will be listed first)
440 456
 								uasort($day['events'], function($a, $b) {
441
-								    if ($a['start_timestamp'] == $b['start_timestamp'])
442
-								        return 0;
457
+								    if ($a['start_timestamp'] == $b['start_timestamp']) {
458
+								    								        return 0;
459
+								    }
443 460
 								    return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
444 461
 								});
445 462
 
@@ -451,15 +468,17 @@  discard block
 block discarded – undo
451 468
 
452 469
 									echo $event['link'], '<br><span class="event_time', empty($event_icons_needed) ? ' floatright' : '', '">';
453 470
 
454
-									if (!empty($event['start_time_local']))
455
-										echo trim($event['start_time_local']), !empty($event['end_time_local']) ? ' &ndash; ' . trim($event['end_time_local']) : '';
456
-									else
457
-										echo $txt['calendar_allday'];
471
+									if (!empty($event['start_time_local'])) {
472
+																			echo trim($event['start_time_local']), !empty($event['end_time_local']) ? ' &ndash; ' . trim($event['end_time_local']) : '';
473
+									} else {
474
+																			echo $txt['calendar_allday'];
475
+									}
458 476
 
459 477
 									echo '</span>';
460 478
 
461
-									if (!empty($event['location']))
462
-										echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
479
+									if (!empty($event['location'])) {
480
+																			echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
481
+									}
463 482
 
464 483
 									if (!empty($event_icons_needed))
465 484
 									{
@@ -496,8 +515,7 @@  discard block
 block discarded – undo
496 515
 									</div>
497 516
 									<br class="clear">';
498 517
 								}
499
-							}
500
-							else
518
+							} else
501 519
 							{
502 520
 								if (!empty($context['can_post']))
503 521
 								{
@@ -510,8 +528,9 @@  discard block
 block discarded – undo
510 528
 							echo '</td>
511 529
 							<td class="', implode(' ', $classes), !empty($day['holidays']) ? ' holidays' : ' disabled', ' holiday_col" data-css-prefix="' . $txt['calendar_prompt'] . ' ">';
512 530
 							// Show any holidays!
513
-							if (!empty($day['holidays']))
514
-								echo implode('<br>', $day['holidays']);
531
+							if (!empty($day['holidays'])) {
532
+															echo implode('<br>', $day['holidays']);
533
+							}
515 534
 
516 535
 							echo '</td>
517 536
 							<td class="', implode(' ', $classes), '', !empty($day['birthdays']) ? ' birthdays' : ' disabled', ' birthday_col" data-css-prefix="' . $txt['birthdays'] . ' ">';
@@ -531,8 +550,9 @@  discard block
 block discarded – undo
531 550
 				}
532 551
 
533 552
 				// We'll show the lower column after our last month is shown.
534
-				if ($iteration == $num_months)
535
-					template_calendar_base(4);
553
+				if ($iteration == $num_months) {
554
+									template_calendar_base(4);
555
+				}
536 556
 
537 557
 				// Increase iteration for loop counting.
538 558
 				++$iteration;
@@ -594,8 +614,9 @@  discard block
 block discarded – undo
594 614
 	echo '
595 615
 		<form action="', $scripturl, '?action=calendar;sa=post" method="post" name="postevent" accept-charset="', $context['character_set'], '" onsubmit="submitonce(this);smc_saveEntities(\'postevent\', [\'evtitle\']);" style="margin: 0;">';
596 616
 
597
-	if (!empty($context['event']['new']))
598
-		echo '<input type="hidden" name="eventid" value="', $context['event']['eventid'], '">';
617
+	if (!empty($context['event']['new'])) {
618
+			echo '<input type="hidden" name="eventid" value="', $context['event']['eventid'], '">';
619
+	}
599 620
 
600 621
 	// Start the main table.
601 622
 	echo '
@@ -645,9 +666,10 @@  discard block
 block discarded – undo
645 666
 		{
646 667
 			echo '
647 668
 								<optgroup label="', $category['name'], '">';
648
-			foreach ($category['boards'] as $board)
649
-				echo '
669
+			foreach ($category['boards'] as $board) {
670
+							echo '
650 671
 									<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=&gt;' : '', ' ', $board['name'], '&nbsp;</option>';
672
+			}
651 673
 			echo '
652 674
 								</optgroup>';
653 675
 		}
@@ -683,9 +705,10 @@  discard block
 block discarded – undo
683 705
 							<span class="label">', $txt['calendar_timezone'], '</span>
684 706
 							<select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>';
685 707
 
686
-	foreach ($context['all_timezones'] as $tz => $tzname)
687
-		echo '
708
+	foreach ($context['all_timezones'] as $tz => $tzname) {
709
+			echo '
688 710
 								<option value="', $tz, '"', $tz == $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>';
711
+	}
689 712
 
690 713
 	echo '
691 714
 							</select>
@@ -700,9 +723,10 @@  discard block
 block discarded – undo
700 723
 	echo '
701 724
 				<input type="submit" value="', empty($context['event']['new']) ? $txt['save'] : $txt['post'], '" class="button_submit">';
702 725
 	// Delete button?
703
-	if (empty($context['event']['new']))
704
-		echo '
726
+	if (empty($context['event']['new'])) {
727
+			echo '
705 728
 				<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['calendar_confirm_delete'], '" class="button_submit you_sure">';
729
+	}
706 730
 
707 731
 	echo '
708 732
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -746,9 +770,10 @@  discard block
 block discarded – undo
746 770
 
747 771
 		foreach ($context['clockicons'] as $t => $v)
748 772
 		{
749
-			foreach ($v as $i)
750
-				echo '
773
+			foreach ($v as $i) {
774
+							echo '
751 775
 			icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');';
776
+			}
752 777
 		}
753 778
 
754 779
 		echo '
@@ -773,13 +798,14 @@  discard block
 block discarded – undo
773 798
 
774 799
 		foreach ($context['clockicons'] as $t => $v)
775 800
 		{
776
-			foreach ($v as $i)
777
-				echo '
801
+			foreach ($v as $i) {
802
+							echo '
778 803
 			if (', $t, ' >= ', $i, ')
779 804
 			{
780 805
 				turnon.push("', $t, '_', $i, '");
781 806
 				', $t, ' -= ', $i, ';
782 807
 			}';
808
+			}
783 809
 		}
784 810
 
785 811
 		echo '
@@ -843,9 +869,10 @@  discard block
 block discarded – undo
843 869
 
844 870
 	foreach ($context['clockicons'] as $t => $v)
845 871
 	{
846
-		foreach ($v as $i)
847
-			echo '
872
+		foreach ($v as $i) {
873
+					echo '
848 874
 		icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');';
875
+		}
849 876
 	}
850 877
 
851 878
 	echo '
@@ -862,13 +889,14 @@  discard block
 block discarded – undo
862 889
 
863 890
 	foreach ($context['clockicons'] as $t => $v)
864 891
 	{
865
-		foreach ($v as $i)
866
-			echo '
892
+		foreach ($v as $i) {
893
+					echo '
867 894
 		if (', $t, ' >= ', $i, ')
868 895
 		{
869 896
 			turnon.push("', $t, '_', $i, '");
870 897
 			', $t, ' -= ', $i, ';
871 898
 		}';
899
+		}
872 900
 	}
873 901
 
874 902
 	echo '
@@ -927,9 +955,10 @@  discard block
 block discarded – undo
927 955
 
928 956
 	foreach ($context['clockicons'] as $t => $v)
929 957
 	{
930
-		foreach ($v as $i)
931
-			echo '
958
+		foreach ($v as $i) {
959
+					echo '
932 960
 		icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');';
961
+		}
933 962
 	}
934 963
 
935 964
 	echo '
@@ -950,13 +979,14 @@  discard block
 block discarded – undo
950 979
 
951 980
 	foreach ($context['clockicons'] as $t => $v)
952 981
 	{
953
-		foreach ($v as $i)
954
-		echo '
982
+		foreach ($v as $i) {
983
+				echo '
955 984
 		if (', $t, ' >= ', $i, ')
956 985
 		{
957 986
 			turnon.push("', $t, '_', $i, '");
958 987
 			', $t, ' -= ', $i, ';
959 988
 		}';
989
+		}
960 990
 	}
961 991
 
962 992
 	echo '
Please login to merge, or discard this patch.
Themes/default/GenericControls.template.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
  * @param int|string $verify_id The verification control ID
228 228
  * @param string $display_type What type to display. Can be 'single' to only show one verification option or 'all' to show all of them
229 229
  * @param bool $reset Whether to reset the internal tracking counter
230
- * @return bool False if there's nothing else to show, true if $display_type is 'single', nothing otherwise
230
+ * @return boolean|null False if there's nothing else to show, true if $display_type is 'single', nothing otherwise
231 231
  */
232 232
 function template_control_verification($verify_id, $display_type = 'all', $reset = false)
233 233
 {
Please login to merge, or discard this patch.
Braces   +76 added lines, -58 removed lines patch added patch discarded remove patch
@@ -53,14 +53,15 @@  discard block
 block discarded – undo
53 53
 			foreach ($context['smileys'] as $location => $smileyRows)
54 54
 			{
55 55
 				$countLocations--;
56
-				if ($location == 'postform')
57
-					echo '
56
+				if ($location == 'postform') {
57
+									echo '
58 58
 						dropdown:
59 59
 						{';
60
-				elseif ($location == 'popup')
61
-					echo '
60
+				} elseif ($location == 'popup') {
61
+									echo '
62 62
 						popup:
63 63
 						{';
64
+				}
64 65
 
65 66
 				$numRows = count($smileyRows);
66 67
 				// This is needed because otherwise the editor will remove all the duplicate (empty) keys and leave only 1 additional line
@@ -72,20 +73,21 @@  discard block
 block discarded – undo
72 73
 						echo '
73 74
 								', JavaScriptEscape($smiley['code']), ': ', JavaScriptEscape($settings['smileys_url'] . '/' . $smiley['filename']), empty($smiley['isLast']) ? ',' : '';
74 75
 					}
75
-					if (empty($smileyRow['isLast']) && $numRows != 1)
76
-						echo ',
76
+					if (empty($smileyRow['isLast']) && $numRows != 1) {
77
+											echo ',
77 78
 						\'-', $emptyPlaceholder++, '\': \'\',';
79
+					}
78 80
 				}
79 81
 				echo '
80 82
 						}', $countLocations != 0 ? ',' : '';
81 83
 			}
82 84
 			echo '
83 85
 					}';
84
-		}
85
-		else
86
-			echo ',
86
+		} else {
87
+					echo ',
87 88
 					emoticons:
88 89
 					{}';
90
+		}
89 91
 
90 92
 		if ($context['show_bbc'] && $bbcContainer !== null)
91 93
 		{
@@ -96,15 +98,16 @@  discard block
 block discarded – undo
96 98
 			{
97 99
 				echo implode('|', $buttonRow);
98 100
 				$count_tags--;
99
-				if (!empty($count_tags))
100
-					echo '||';
101
+				if (!empty($count_tags)) {
102
+									echo '||';
103
+				}
101 104
 			}
102 105
 
103 106
 			echo '",';
104
-		}
105
-		else
106
-			echo ',
107
+		} else {
108
+					echo ',
107 109
 					toolbar: "",';
110
+		}
108 111
 
109 112
 		echo '
110 113
 				});
@@ -145,43 +148,48 @@  discard block
 block discarded – undo
145 148
 		</span>';
146 149
 
147 150
 	$tempTab = $context['tabindex'];
148
-	if (!empty($context['drafts_pm_save']))
149
-		$tempTab++;
150
-	elseif (!empty($context['drafts_save']))
151
-		$tempTab++;
152
-	elseif ($editor_context['preview_type'])
153
-		$tempTab++;
154
-	elseif ($context['show_spellchecking'])
155
-		$tempTab++;
151
+	if (!empty($context['drafts_pm_save'])) {
152
+			$tempTab++;
153
+	} elseif (!empty($context['drafts_save'])) {
154
+			$tempTab++;
155
+	} elseif ($editor_context['preview_type']) {
156
+			$tempTab++;
157
+	} elseif ($context['show_spellchecking']) {
158
+			$tempTab++;
159
+	}
156 160
 
157 161
 	$tempTab++;
158 162
 	$context['tabindex'] = $tempTab;
159 163
 
160
-	if (!empty($context['drafts_pm_save']))
161
-		echo '
164
+	if (!empty($context['drafts_pm_save'])) {
165
+			echo '
162 166
 		<input type="submit" name="save_draft" value="', $txt['draft_save'], '" tabindex="',  --$tempTab, '" onclick="submitThisOnce(this);" accesskey="d" class="button_submit">
163 167
 		<input type="hidden" id="id_pm_draft" name="id_pm_draft" value="', empty($context['id_pm_draft']) ? 0 : $context['id_pm_draft'], '">';
168
+	}
164 169
 
165
-	if (!empty($context['drafts_save']))
166
-		echo '
170
+	if (!empty($context['drafts_save'])) {
171
+			echo '
167 172
 		<input type="submit" name="save_draft" value="', $txt['draft_save'], '" tabindex="', --$tempTab, '" onclick="return confirm(' . JavaScriptEscape($txt['draft_save_note']) . ') && submitThisOnce(this);" accesskey="d" class="button_submit">
168 173
 		<input type="hidden" id="id_draft" name="id_draft" value="', empty($context['id_draft']) ? 0 : $context['id_draft'], '">';
174
+	}
169 175
 
170
-	if ($context['show_spellchecking'])
171
-		echo '
176
+	if ($context['show_spellchecking']) {
177
+			echo '
172 178
 		<input type="button" value="', $txt['spell_check'], '" tabindex="', --$tempTab, '" onclick="oEditorHandle_', $editor_id, '.spellCheckStart();" class="button_submit">';
179
+	}
173 180
 
174
-	if ($editor_context['preview_type'])
175
-		echo '
181
+	if ($editor_context['preview_type']) {
182
+			echo '
176 183
 		<input type="submit" name="preview" value="', isset($editor_context['labels']['preview_button']) ? $editor_context['labels']['preview_button'] : $txt['preview'], '" tabindex="', --$tempTab, '" onclick="', $editor_context['preview_type'] == 2 ? 'return event.ctrlKey || previewPost();' : 'return submitThisOnce(this);', '" accesskey="p" class="button_submit">';
184
+	}
177 185
 
178 186
 
179 187
 	echo '
180 188
 		<input type="submit" value="', isset($editor_context['labels']['post_button']) ? $editor_context['labels']['post_button'] : $txt['post'], '" name="post" tabindex="', --$tempTab, '" onclick="return submitThisOnce(this);" accesskey="s" class="button_submit">';
181 189
 
182 190
 	// Load in the PM autosaver if it's enabled
183
-	if (!empty($context['drafts_pm_save']) && !empty($context['drafts_autosave']))
184
-		echo '
191
+	if (!empty($context['drafts_pm_save']) && !empty($context['drafts_autosave'])) {
192
+			echo '
185 193
 		<span class="righttext padding" style="display: block">
186 194
 			<span id="throbber" style="display:none"><img src="' . $settings['images_url'] . '/loading_sm.gif" alt="" class="centericon">&nbsp;</span>
187 195
 			<span id="draft_lastautosave" ></span>
@@ -199,10 +207,11 @@  discard block
 block discarded – undo
199 207
 				iFreq: ', (empty($modSettings['drafts_autosave_frequency']) ? 60000 : $modSettings['drafts_autosave_frequency'] * 1000), '
200 208
 			});
201 209
 		</script>';
210
+	}
202 211
 
203 212
 	// Start an instance of the auto saver if its enabled
204
-	if (!empty($context['drafts_save']) && !empty($context['drafts_autosave']))
205
-		echo '
213
+	if (!empty($context['drafts_save']) && !empty($context['drafts_autosave'])) {
214
+			echo '
206 215
 		<span class="righttext padding" style="display: block">
207 216
 			<span id="throbber" style="display:none"><img src="' . $settings['images_url'] . '/loading_sm.gif" alt="" class="centericon">&nbsp;</span>
208 217
 			<span id="draft_lastautosave" ></span>
@@ -219,7 +228,8 @@  discard block
 block discarded – undo
219 228
 				iFreq: ', $context['drafts_autosave_frequency'], '
220 229
 			});
221 230
 		</script>';
222
-}
231
+	}
232
+	}
223 233
 
224 234
 /**
225 235
  * This template displays a verification form
@@ -236,35 +246,40 @@  discard block
 block discarded – undo
236 246
 	$verify_context = &$context['controls']['verification'][$verify_id];
237 247
 
238 248
 	// Keep track of where we are.
239
-	if (empty($verify_context['tracking']) || $reset)
240
-		$verify_context['tracking'] = 0;
249
+	if (empty($verify_context['tracking']) || $reset) {
250
+			$verify_context['tracking'] = 0;
251
+	}
241 252
 
242 253
 	// How many items are there to display in total.
243 254
 	$total_items = count($verify_context['questions']) + ($verify_context['show_visual'] || $verify_context['can_recaptcha'] ? 1 : 0);
244 255
 
245 256
 	// If we've gone too far, stop.
246
-	if ($verify_context['tracking'] > $total_items)
247
-		return false;
257
+	if ($verify_context['tracking'] > $total_items) {
258
+			return false;
259
+	}
248 260
 
249 261
 	// Loop through each item to show them.
250 262
 	for ($i = 0; $i < $total_items; $i++)
251 263
 	{
252 264
 		// If we're after a single item only show it if we're in the right place.
253
-		if ($display_type == 'single' && $verify_context['tracking'] != $i)
254
-			continue;
265
+		if ($display_type == 'single' && $verify_context['tracking'] != $i) {
266
+					continue;
267
+		}
255 268
 
256
-		if ($display_type != 'single')
257
-			echo '
269
+		if ($display_type != 'single') {
270
+					echo '
258 271
 			<div id="verification_control_', $i, '" class="verification_control">';
272
+		}
259 273
 
260 274
 		// Display empty field, but only if we have one, and it's the first time.
261
-		if ($verify_context['empty_field'] && empty($i))
262
-			echo '
275
+		if ($verify_context['empty_field'] && empty($i)) {
276
+					echo '
263 277
 				<div class="smalltext vv_special">
264 278
 					', $txt['visual_verification_hidden'], ':
265 279
 					<input type="text" name="', $_SESSION[$verify_id . '_vv']['empty_field'], '" autocomplete="off" size="30" value="">
266 280
 				</div>
267 281
 				<br>';
282
+		}
268 283
 
269 284
 		// Do the actual stuff
270 285
 		if ($i == 0)
@@ -278,17 +293,18 @@  discard block
 block discarded – undo
278 293
 
279 294
 			if ($verify_context['show_visual'])
280 295
 			{
281
-				if ($context['use_graphic_library'])
282
-					echo '
296
+				if ($context['use_graphic_library']) {
297
+									echo '
283 298
 				<img src="', $verify_context['image_href'], '" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '">';
284
-				else
285
-					echo '
299
+				} else {
300
+									echo '
286 301
 				<img src="', $verify_context['image_href'], ';letter=1" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '_1">
287 302
 				<img src="', $verify_context['image_href'], ';letter=2" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '_2">
288 303
 				<img src="', $verify_context['image_href'], ';letter=3" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '_3">
289 304
 				<img src="', $verify_context['image_href'], ';letter=4" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '_4">
290 305
 				<img src="', $verify_context['image_href'], ';letter=5" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '_5">
291 306
 				<img src="', $verify_context['image_href'], ';letter=6" alt="', $txt['visual_verification_description'], '" id="verification_image_', $verify_id, '_6">';
307
+				}
292 308
 
293 309
 				echo '
294 310
 				<div class="smalltext" style="margin: 4px 0 8px 0;">
@@ -297,8 +313,7 @@  discard block
 block discarded – undo
297 313
 					<input type="text" name="', $verify_id, '_vv[code]" value="', !empty($verify_context['text_value']) ? $verify_context['text_value'] : '', '" size="30" tabindex="', $context['tabindex']++, '" class="input_text" required>
298 314
 				</div>';
299 315
 			}
300
-		}
301
-		else
316
+		} else
302 317
 		{
303 318
 			// Where in the question array is this question?
304 319
 			$qIndex = $verify_context['show_visual'] ? $i - 1 : $i;
@@ -310,21 +325,24 @@  discard block
 block discarded – undo
310 325
 				</div>';
311 326
 		}
312 327
 
313
-		if ($display_type != 'single')
314
-			echo '
328
+		if ($display_type != 'single') {
329
+					echo '
315 330
 			</div>';
331
+		}
316 332
 
317 333
 		// If we were displaying just one and we did it, break.
318
-		if ($display_type == 'single' && $verify_context['tracking'] == $i)
319
-			break;
334
+		if ($display_type == 'single' && $verify_context['tracking'] == $i) {
335
+					break;
336
+		}
320 337
 	}
321 338
 
322 339
 	// Assume we found something, always,
323 340
 	$verify_context['tracking']++;
324 341
 
325 342
 	// Tell something displaying piecemeal to keep going.
326
-	if ($display_type == 'single')
327
-		return true;
328
-}
343
+	if ($display_type == 'single') {
344
+			return true;
345
+	}
346
+	}
329 347
 
330 348
 ?>
Please login to merge, or discard this patch.