Completed
Pull Request — release-2.1 (#4670)
by Fran
13:14
created
Sources/DbExtra-postgresql.php 1 patch
Braces   +43 added lines, -32 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Add the functions implemented in this file to the $smcFunc array.
@@ -23,8 +24,8 @@  discard block
 block discarded – undo
23 24
 {
24 25
 	global $smcFunc;
25 26
 
26
-	if (!isset($smcFunc['db_backup_table']) || $smcFunc['db_backup_table'] != 'smf_db_backup_table')
27
-		$smcFunc += array(
27
+	if (!isset($smcFunc['db_backup_table']) || $smcFunc['db_backup_table'] != 'smf_db_backup_table') {
28
+			$smcFunc += array(
28 29
 			'db_backup_table' => 'smf_db_backup_table',
29 30
 			'db_optimize_table' => 'smf_db_optimize_table',
30 31
 			'db_table_sql' => 'smf_db_table_sql',
@@ -33,7 +34,8 @@  discard block
 block discarded – undo
33 34
 			'db_get_vendor' => 'smf_db_get_vendor',
34 35
 			'db_allow_persistent' => 'smf_db_allow_persistent',
35 36
 		);
36
-}
37
+	}
38
+	}
37 39
 
38 40
 /**
39 41
  * Backup $table to $backup_table.
@@ -49,13 +51,14 @@  discard block
 block discarded – undo
49 51
 
50 52
 	// Do we need to drop it first?
51 53
 	$tables = smf_db_list_tables(false, $backup_table);
52
-	if (!empty($tables))
53
-		$smcFunc['db_query']('', '
54
+	if (!empty($tables)) {
55
+			$smcFunc['db_query']('', '
54 56
 			DROP TABLE {raw:backup_table}',
55 57
 			array(
56 58
 				'backup_table' => $backup_table,
57 59
 			)
58 60
 		);
61
+	}
59 62
 
60 63
 	/**
61 64
 	 * @todo Should we create backups of sequences as well?
@@ -118,8 +121,9 @@  discard block
 block discarded – undo
118 121
 			)
119 122
 		);
120 123
 
121
-	if (!$request)
122
-		return -1;
124
+	if (!$request) {
125
+			return -1;
126
+	}
123 127
 
124 128
 	$request = $smcFunc['db_query']('', '
125 129
 		SELECT pg_relation_size(C.oid) AS "size"
@@ -137,11 +141,12 @@  discard block
 block discarded – undo
137 141
 	$row = $smcFunc['db_fetch_assoc']($request);
138 142
 	$smcFunc['db_free_result']($request);
139 143
 
140
-	if (isset($row['size']))
141
-			return ($old_size - $row['size']) / 1024;
142
-	else
143
-		return 0;
144
-}
144
+	if (isset($row['size'])) {
145
+				return ($old_size - $row['size']) / 1024;
146
+	} else {
147
+			return 0;
148
+	}
149
+	}
145 150
 
146 151
 /**
147 152
  * This function lists all tables in the database.
@@ -168,8 +173,9 @@  discard block
 block discarded – undo
168 173
 	);
169 174
 
170 175
 	$tables = array();
171
-	while ($row = $smcFunc['db_fetch_row']($request))
172
-		$tables[] = $row[0];
176
+	while ($row = $smcFunc['db_fetch_row']($request)) {
177
+			$tables[] = $row[0];
178
+	}
173 179
 	$smcFunc['db_free_result']($request);
174 180
 
175 181
 	return $tables;
@@ -210,12 +216,14 @@  discard block
 block discarded – undo
210 216
 	);
211 217
 	while ($row = $smcFunc['db_fetch_assoc']($result))
212 218
 	{
213
-		if ($row['data_type'] == 'character varying')
214
-			$row['data_type'] = 'varchar';
215
-		elseif ($row['data_type'] == 'character')
216
-			$row['data_type'] = 'char';
217
-		if ($row['character_maximum_length'])
218
-			$row['data_type'] .= '(' . $row['character_maximum_length'] . ')';
219
+		if ($row['data_type'] == 'character varying') {
220
+					$row['data_type'] = 'varchar';
221
+		} elseif ($row['data_type'] == 'character') {
222
+					$row['data_type'] = 'char';
223
+		}
224
+		if ($row['character_maximum_length']) {
225
+					$row['data_type'] .= '(' . $row['character_maximum_length'] . ')';
226
+		}
219 227
 
220 228
 		// Make the CREATE for this column.
221 229
 		$schema_create .= ' "' . $row['column_name'] . '" ' . $row['data_type'] . ($row['is_nullable'] != 'YES' ? ' NOT NULL' : '');
@@ -266,13 +274,14 @@  discard block
 block discarded – undo
266 274
 	{
267 275
 		if ($row['is_primary'])
268 276
 		{
269
-			if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0)
270
-				continue;
277
+			if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0) {
278
+							continue;
279
+			}
271 280
 
272 281
 			$index_create .= $crlf . 'ALTER TABLE ' . $tableName . ' ADD PRIMARY KEY ("' . $matches[1] . '");';
282
+		} else {
283
+					$index_create .= $crlf . $row['inddef'] . ';';
273 284
 		}
274
-		else
275
-			$index_create .= $crlf . $row['inddef'] . ';';
276 285
 	}
277 286
 	$smcFunc['db_free_result']($result);
278 287
 
@@ -291,8 +300,9 @@  discard block
 block discarded – undo
291 300
 	global $db_connection;
292 301
 	static $ver;
293 302
 
294
-	if(!empty($ver))
295
-		return $ver;
303
+	if(!empty($ver)) {
304
+			return $ver;
305
+	}
296 306
 
297 307
 	$ver = pg_version($db_connection)['server'];
298 308
 
@@ -317,10 +327,11 @@  discard block
 block discarded – undo
317 327
 function smf_db_allow_persistent()
318 328
 {
319 329
 	$value = ini_get('pgsql.allow_persistent');
320
-	if (strtolower($value) == 'on' || strtolower($value) == 'true' || $value == '1')
321
-		return true;
322
-	else
323
-		return false;
324
-}
330
+	if (strtolower($value) == 'on' || strtolower($value) == 'true' || $value == '1') {
331
+			return true;
332
+	} else {
333
+			return false;
334
+	}
335
+	}
325 336
 
326 337
 ?>
327 338
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/Subs-Post.php 1 patch
Braces   +520 added lines, -389 removed lines patch added patch discarded remove patch
@@ -15,8 +15,9 @@  discard block
 block discarded – undo
15 15
  * @version 2.1 Beta 4
16 16
  */
17 17
 
18
-if (!defined('SMF'))
18
+if (!defined('SMF')) {
19 19
 	die('No direct access...');
20
+}
20 21
 
21 22
 /**
22 23
  * Takes a message and parses it, returning nothing.
@@ -31,8 +32,9 @@  discard block
 block discarded – undo
31 32
 	global $user_info, $modSettings, $context, $sourcedir;
32 33
 
33 34
 	// This line makes all languages *theoretically* work even with the wrong charset ;).
34
-	if (empty($context['utf8']))
35
-		$message = preg_replace('~&#(\d{4,5}|[2-9]\d{2,4}|1[2-9]\d);~', '&#$1;', $message);
35
+	if (empty($context['utf8'])) {
36
+			$message = preg_replace('~&#(\d{4,5}|[2-9]\d{2,4}|1[2-9]\d);~', '&#$1;', $message);
37
+	}
36 38
 
37 39
 	// Clean up after nobbc ;).
38 40
 	$message = preg_replace_callback('~\[nobbc\](.+?)\[/nobbc\]~is', function($a)
@@ -47,17 +49,19 @@  discard block
 block discarded – undo
47 49
 	$message = preg_replace('~\.{100,}~', '...', $message);
48 50
 
49 51
 	// Trim off trailing quotes - these often happen by accident.
50
-	while (substr($message, -7) == '[quote]')
51
-		$message = substr($message, 0, -7);
52
-	while (substr($message, 0, 8) == '[/quote]')
53
-		$message = substr($message, 8);
52
+	while (substr($message, -7) == '[quote]') {
53
+			$message = substr($message, 0, -7);
54
+	}
55
+	while (substr($message, 0, 8) == '[/quote]') {
56
+			$message = substr($message, 8);
57
+	}
54 58
 
55 59
 	// Find all code blocks, work out whether we'd be parsing them, then ensure they are all closed.
56 60
 	$in_tag = false;
57 61
 	$had_tag = false;
58 62
 	$codeopen = 0;
59
-	if (preg_match_all('~(\[(/)*code(?:=[^\]]+)?\])~is', $message, $matches))
60
-		foreach ($matches[0] as $index => $dummy)
63
+	if (preg_match_all('~(\[(/)*code(?:=[^\]]+)?\])~is', $message, $matches)) {
64
+			foreach ($matches[0] as $index => $dummy)
61 65
 		{
62 66
 			// Closing?
63 67
 			if (!empty($matches[2][$index]))
@@ -65,6 +69,7 @@  discard block
 block discarded – undo
65 69
 				// If it's closing and we're not in a tag we need to open it...
66 70
 				if (!$in_tag)
67 71
 					$codeopen = true;
72
+	}
68 73
 				// Either way we ain't in one any more.
69 74
 				$in_tag = false;
70 75
 			}
@@ -73,17 +78,20 @@  discard block
 block discarded – undo
73 78
 			{
74 79
 				$had_tag = true;
75 80
 				// If we're in a tag don't do nought!
76
-				if (!$in_tag)
77
-					$in_tag = true;
81
+				if (!$in_tag) {
82
+									$in_tag = true;
83
+				}
78 84
 			}
79 85
 		}
80 86
 
81 87
 	// If we have an open tag, close it.
82
-	if ($in_tag)
83
-		$message .= '[/code]';
88
+	if ($in_tag) {
89
+			$message .= '[/code]';
90
+	}
84 91
 	// Open any ones that need to be open, only if we've never had a tag.
85
-	if ($codeopen && !$had_tag)
86
-		$message = '[code]' . $message;
92
+	if ($codeopen && !$had_tag) {
93
+			$message = '[code]' . $message;
94
+	}
87 95
 
88 96
 	// Replace code BBC with placeholders. We'll restore them at the end.
89 97
 	$parts = preg_split('~(\[/code\]|\[code(?:=[^\]]+)?\])~i', $message, -1, PREG_SPLIT_DELIM_CAPTURE);
@@ -108,23 +116,26 @@  discard block
 block discarded – undo
108 116
 	fixTags($message);
109 117
 
110 118
 	// Replace /me.+?\n with [me=name]dsf[/me]\n.
111
-	if (strpos($user_info['name'], '[') !== false || strpos($user_info['name'], ']') !== false || strpos($user_info['name'], '\'') !== false || strpos($user_info['name'], '"') !== false)
112
-		$message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me="' . $user_info['name'] . '"]$2[/me]', $message);
113
-	else
114
-		$message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me=' . $user_info['name'] . ']$2[/me]', $message);
119
+	if (strpos($user_info['name'], '[') !== false || strpos($user_info['name'], ']') !== false || strpos($user_info['name'], '\'') !== false || strpos($user_info['name'], '"') !== false) {
120
+			$message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me="' . $user_info['name'] . '"]$2[/me]', $message);
121
+	} else {
122
+			$message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me=' . $user_info['name'] . ']$2[/me]', $message);
123
+	}
115 124
 
116 125
 	if (!$previewing && strpos($message, '[html]') !== false)
117 126
 	{
118
-		if (allowedTo('admin_forum'))
119
-			$message = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m) {
127
+		if (allowedTo('admin_forum')) {
128
+					$message = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m) {
120 129
 				return '[html]' . strtr(un_htmlspecialchars($m[1]), array("\n" => '
', '  ' => '  ', '[' => '[', ']' => ']')) . '[/html]';
130
+		}
121 131
 			}, $message);
122 132
 
123 133
 		// We should edit them out, or else if an admin edits the message they will get shown...
124 134
 		else
125 135
 		{
126
-			while (strpos($message, '[html]') !== false)
127
-				$message = preg_replace('~\[[/]?html\]~i', '', $message);
136
+			while (strpos($message, '[html]') !== false) {
137
+							$message = preg_replace('~\[[/]?html\]~i', '', $message);
138
+			}
128 139
 		}
129 140
 	}
130 141
 
@@ -146,10 +157,12 @@  discard block
 block discarded – undo
146 157
 
147 158
 	$list_open = substr_count($message, '[list]') + substr_count($message, '[list ');
148 159
 	$list_close = substr_count($message, '[/list]');
149
-	if ($list_close - $list_open > 0)
150
-		$message = str_repeat('[list]', $list_close - $list_open) . $message;
151
-	if ($list_open - $list_close > 0)
152
-		$message = $message . str_repeat('[/list]', $list_open - $list_close);
160
+	if ($list_close - $list_open > 0) {
161
+			$message = str_repeat('[list]', $list_close - $list_open) . $message;
162
+	}
163
+	if ($list_open - $list_close > 0) {
164
+			$message = $message . str_repeat('[/list]', $list_open - $list_close);
165
+	}
153 166
 
154 167
 	$mistake_fixes = array(
155 168
 		// Find [table]s not followed by [tr].
@@ -198,8 +211,9 @@  discard block
 block discarded – undo
198 211
 	);
199 212
 
200 213
 	// Fix up some use of tables without [tr]s, etc. (it has to be done more than once to catch it all.)
201
-	for ($j = 0; $j < 3; $j++)
202
-		$message = preg_replace(array_keys($mistake_fixes), $mistake_fixes, $message);
214
+	for ($j = 0; $j < 3; $j++) {
215
+			$message = preg_replace(array_keys($mistake_fixes), $mistake_fixes, $message);
216
+	}
203 217
 
204 218
 	// Remove empty bbc from the sections outside the code tags
205 219
 	$allowedEmpty = array(
@@ -210,24 +224,28 @@  discard block
 block discarded – undo
210 224
 	require_once($sourcedir . '/Subs.php');
211 225
 
212 226
 	$alltags = array();
213
-	foreach (($codes = parse_bbc(false)) as $code)
214
-		if (!in_array($code['tag'], $allowedEmpty))
227
+	foreach (($codes = parse_bbc(false)) as $code) {
228
+			if (!in_array($code['tag'], $allowedEmpty))
215 229
 			$alltags[] = $code['tag'];
230
+	}
216 231
 
217 232
 	$alltags_regex = '\b' . implode("\b|\b", array_unique($alltags)) . '\b';
218 233
 
219
-	while (preg_match('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', $message))
220
-		$message = preg_replace('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', '', $message);
234
+	while (preg_match('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', $message)) {
235
+			$message = preg_replace('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', '', $message);
236
+	}
221 237
 
222 238
 	// Restore code blocks
223
-	if (!empty($code_tags))
224
-		$message = str_replace(array_keys($code_tags), array_values($code_tags), $message);
239
+	if (!empty($code_tags)) {
240
+			$message = str_replace(array_keys($code_tags), array_values($code_tags), $message);
241
+	}
225 242
 
226 243
 	// Restore white space entities
227
-	if (!$previewing)
228
-		$message = strtr($message, array('  ' => '&nbsp; ', "\n" => '<br>', $context['utf8'] ? "\xC2\xA0" : "\xA0" => '&nbsp;'));
229
-	else
230
-		$message = strtr($message, array('  ' => '&nbsp; ', $context['utf8'] ? "\xC2\xA0" : "\xA0" => '&nbsp;'));
244
+	if (!$previewing) {
245
+			$message = strtr($message, array('  ' => '&nbsp; ', "\n" => '<br>', $context['utf8'] ? "\xC2\xA0" : "\xA0" => '&nbsp;'));
246
+	} else {
247
+			$message = strtr($message, array('  ' => '&nbsp; ', $context['utf8'] ? "\xC2\xA0" : "\xA0" => '&nbsp;'));
248
+	}
231 249
 
232 250
 	// Now let's quickly clean up things that will slow our parser (which are common in posted code.)
233 251
 	$message = strtr($message, array('[]' => '&#91;]', '[&#039;' => '&#91;&#039;'));
@@ -270,8 +288,9 @@  discard block
 block discarded – undo
270 288
 		return "[time]" . timeformat("$m[1]", false) . "[/time]";
271 289
 	}, $message);
272 290
 
273
-	if (!empty($code_tags))
274
-		$message = str_replace(array_keys($code_tags), array_values($code_tags), $message);
291
+	if (!empty($code_tags)) {
292
+			$message = str_replace(array_keys($code_tags), array_values($code_tags), $message);
293
+	}
275 294
 
276 295
 	// Change breaks back to \n's and &nsbp; back to spaces.
277 296
 	return preg_replace('~<br( /)?' . '>~', "\n", str_replace('&nbsp;', ' ', $message));
@@ -352,8 +371,9 @@  discard block
 block discarded – undo
352 371
 	);
353 372
 
354 373
 	// Fix each type of tag.
355
-	foreach ($fixArray as $param)
356
-		fixTag($message, $param['tag'], $param['protocols'], $param['embeddedUrl'], $param['hasEqualSign'], !empty($param['hasExtra']));
374
+	foreach ($fixArray as $param) {
375
+			fixTag($message, $param['tag'], $param['protocols'], $param['embeddedUrl'], $param['hasEqualSign'], !empty($param['hasExtra']));
376
+	}
357 377
 
358 378
 	// Now fix possible security problems with images loading links automatically...
359 379
 	$message = preg_replace_callback('~(\[img.*?\])(.+?)\[/img\]~is', function($m)
@@ -378,10 +398,11 @@  discard block
 block discarded – undo
378 398
 {
379 399
 	global $boardurl, $scripturl;
380 400
 
381
-	if (preg_match('~^([^:]+://[^/]+)~', $boardurl, $match) != 0)
382
-		$domain_url = $match[1];
383
-	else
384
-		$domain_url = $boardurl . '/';
401
+	if (preg_match('~^([^:]+://[^/]+)~', $boardurl, $match) != 0) {
402
+			$domain_url = $match[1];
403
+	} else {
404
+			$domain_url = $boardurl . '/';
405
+	}
385 406
 
386 407
 	$replaces = array();
387 408
 
@@ -389,11 +410,11 @@  discard block
 block discarded – undo
389 410
 	{
390 411
 		$quoted = preg_match('~\[(' . $myTag . ')=&quot;~', $message);
391 412
 		preg_match_all('~\[(' . $myTag . ')=' . ($quoted ? '&quot;(.*?)&quot;' : '([^\]]*?)') . '\](?:(.+?)\[/(' . $myTag . ')\])?~is', $message, $matches);
413
+	} elseif ($hasEqualSign) {
414
+			preg_match_all('~\[(' . $myTag . ')=([^\]]*?)\](?:(.+?)\[/(' . $myTag . ')\])?~is', $message, $matches);
415
+	} else {
416
+			preg_match_all('~\[(' . $myTag . ($hasExtra ? '(?:[^\]]*?)' : '') . ')\](.+?)\[/(' . $myTag . ')\]~is', $message, $matches);
392 417
 	}
393
-	elseif ($hasEqualSign)
394
-		preg_match_all('~\[(' . $myTag . ')=([^\]]*?)\](?:(.+?)\[/(' . $myTag . ')\])?~is', $message, $matches);
395
-	else
396
-		preg_match_all('~\[(' . $myTag . ($hasExtra ? '(?:[^\]]*?)' : '') . ')\](.+?)\[/(' . $myTag . ')\]~is', $message, $matches);
397 418
 
398 419
 	foreach ($matches[0] as $k => $dummy)
399 420
 	{
@@ -406,49 +427,53 @@  discard block
 block discarded – undo
406 427
 		foreach ($protocols as $protocol)
407 428
 		{
408 429
 			$found = strncasecmp($replace, $protocol . '://', strlen($protocol) + 3) === 0;
409
-			if ($found)
410
-				break;
430
+			if ($found) {
431
+							break;
432
+			}
411 433
 		}
412 434
 
413 435
 		if (!$found && $protocols[0] == 'http')
414 436
 		{
415
-			if (substr($replace, 0, 1) == '/' && substr($replace, 0, 2) != '//')
416
-				$replace = $domain_url . $replace;
417
-			elseif (substr($replace, 0, 1) == '?')
418
-				$replace = $scripturl . $replace;
419
-			elseif (substr($replace, 0, 1) == '#' && $embeddedUrl)
437
+			if (substr($replace, 0, 1) == '/' && substr($replace, 0, 2) != '//') {
438
+							$replace = $domain_url . $replace;
439
+			} elseif (substr($replace, 0, 1) == '?') {
440
+							$replace = $scripturl . $replace;
441
+			} elseif (substr($replace, 0, 1) == '#' && $embeddedUrl)
420 442
 			{
421 443
 				$replace = '#' . preg_replace('~[^A-Za-z0-9_\-#]~', '', substr($replace, 1));
422 444
 				$this_tag = 'iurl';
423 445
 				$this_close = 'iurl';
446
+			} elseif (substr($replace, 0, 2) != '//') {
447
+							$replace = $protocols[0] . '://' . $replace;
424 448
 			}
425
-			elseif (substr($replace, 0, 2) != '//')
426
-				$replace = $protocols[0] . '://' . $replace;
427
-		}
428
-		elseif (!$found && $protocols[0] == 'ftp')
429
-			$replace = $protocols[0] . '://' . preg_replace('~^(?!ftps?)[^:]+://~', '', $replace);
430
-		elseif (!$found)
431
-			$replace = $protocols[0] . '://' . $replace;
432
-
433
-		if ($hasEqualSign && $embeddedUrl)
434
-			$replaces[$matches[0][$k]] = '[' . $this_tag . '=&quot;' . $replace . '&quot;]' . (empty($matches[4][$k]) ? '' : $matches[3][$k] . '[/' . $this_close . ']');
435
-		elseif ($hasEqualSign)
436
-			$replaces['[' . $matches[1][$k] . '=' . $matches[2][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']';
437
-		elseif ($embeddedUrl)
438
-			$replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']' . $matches[2][$k] . '[/' . $this_close . ']';
439
-		else
440
-			$replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . ']' . $replace . '[/' . $this_close . ']';
449
+		} elseif (!$found && $protocols[0] == 'ftp') {
450
+					$replace = $protocols[0] . '://' . preg_replace('~^(?!ftps?)[^:]+://~', '', $replace);
451
+		} elseif (!$found) {
452
+					$replace = $protocols[0] . '://' . $replace;
453
+		}
454
+
455
+		if ($hasEqualSign && $embeddedUrl) {
456
+					$replaces[$matches[0][$k]] = '[' . $this_tag . '=&quot;' . $replace . '&quot;]' . (empty($matches[4][$k]) ? '' : $matches[3][$k] . '[/' . $this_close . ']');
457
+		} elseif ($hasEqualSign) {
458
+					$replaces['[' . $matches[1][$k] . '=' . $matches[2][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']';
459
+		} elseif ($embeddedUrl) {
460
+					$replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']' . $matches[2][$k] . '[/' . $this_close . ']';
461
+		} else {
462
+					$replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . ']' . $replace . '[/' . $this_close . ']';
463
+		}
441 464
 	}
442 465
 
443 466
 	foreach ($replaces as $k => $v)
444 467
 	{
445
-		if ($k == $v)
446
-			unset($replaces[$k]);
468
+		if ($k == $v) {
469
+					unset($replaces[$k]);
470
+		}
447 471
 	}
448 472
 
449
-	if (!empty($replaces))
450
-		$message = strtr($message, $replaces);
451
-}
473
+	if (!empty($replaces)) {
474
+			$message = strtr($message, $replaces);
475
+	}
476
+	}
452 477
 
453 478
 /**
454 479
  * This function sends an email to the specified recipient(s).
@@ -492,8 +517,9 @@  discard block
 block discarded – undo
492 517
 	}
493 518
 
494 519
 	// Nothing left? Nothing else to do
495
-	if (empty($to_array))
496
-		return true;
520
+	if (empty($to_array)) {
521
+			return true;
522
+	}
497 523
 
498 524
 	// Once upon a time, Hotmail could not interpret non-ASCII mails.
499 525
 	// In honour of those days, it's still called the 'hotmail fix'.
@@ -510,15 +536,17 @@  discard block
 block discarded – undo
510 536
 		}
511 537
 
512 538
 		// Call this function recursively for the hotmail addresses.
513
-		if (!empty($hotmail_to))
514
-			$mail_result = sendmail($hotmail_to, $subject, $message, $from, $message_id, $send_html, $priority, true, $is_private);
539
+		if (!empty($hotmail_to)) {
540
+					$mail_result = sendmail($hotmail_to, $subject, $message, $from, $message_id, $send_html, $priority, true, $is_private);
541
+		}
515 542
 
516 543
 		// The remaining addresses no longer need the fix.
517 544
 		$hotmail_fix = false;
518 545
 
519 546
 		// No other addresses left? Return instantly.
520
-		if (empty($to_array))
521
-			return $mail_result;
547
+		if (empty($to_array)) {
548
+					return $mail_result;
549
+		}
522 550
 	}
523 551
 
524 552
 	// Get rid of entities.
@@ -543,13 +571,15 @@  discard block
 block discarded – undo
543 571
 	$headers .= 'Return-Path: ' . (empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from']) . $line_break;
544 572
 	$headers .= 'Date: ' . gmdate('D, d M Y H:i:s') . ' -0000' . $line_break;
545 573
 
546
-	if ($message_id !== null && empty($modSettings['mail_no_message_id']))
547
-		$headers .= 'Message-ID: <' . md5($scripturl . microtime()) . '-' . $message_id . strstr(empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from'], '@') . '>' . $line_break;
574
+	if ($message_id !== null && empty($modSettings['mail_no_message_id'])) {
575
+			$headers .= 'Message-ID: <' . md5($scripturl . microtime()) . '-' . $message_id . strstr(empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from'], '@') . '>' . $line_break;
576
+	}
548 577
 	$headers .= 'X-Mailer: SMF' . $line_break;
549 578
 
550 579
 	// Pass this to the integration before we start modifying the output -- it'll make it easier later.
551
-	if (in_array(false, call_integration_hook('integrate_outgoing_email', array(&$subject, &$message, &$headers, &$to_array)), true))
552
-		return false;
580
+	if (in_array(false, call_integration_hook('integrate_outgoing_email', array(&$subject, &$message, &$headers, &$to_array)), true)) {
581
+			return false;
582
+	}
553 583
 
554 584
 	// Save the original message...
555 585
 	$orig_message = $message;
@@ -598,17 +628,19 @@  discard block
 block discarded – undo
598 628
 	}
599 629
 
600 630
 	// Are we using the mail queue, if so this is where we butt in...
601
-	if ($priority != 0)
602
-		return AddMailQueue(false, $to_array, $subject, $message, $headers, $send_html, $priority, $is_private);
631
+	if ($priority != 0) {
632
+			return AddMailQueue(false, $to_array, $subject, $message, $headers, $send_html, $priority, $is_private);
633
+	}
603 634
 
604 635
 	// If it's a priority mail, send it now - note though that this should NOT be used for sending many at once.
605 636
 	elseif (!empty($modSettings['mail_limit']))
606 637
 	{
607 638
 		list ($last_mail_time, $mails_this_minute) = @explode('|', $modSettings['mail_recent']);
608
-		if (empty($mails_this_minute) || time() > $last_mail_time + 60)
609
-			$new_queue_stat = time() . '|' . 1;
610
-		else
611
-			$new_queue_stat = $last_mail_time . '|' . ((int) $mails_this_minute + 1);
639
+		if (empty($mails_this_minute) || time() > $last_mail_time + 60) {
640
+					$new_queue_stat = time() . '|' . 1;
641
+		} else {
642
+					$new_queue_stat = $last_mail_time . '|' . ((int) $mails_this_minute + 1);
643
+		}
612 644
 
613 645
 		updateSettings(array('mail_recent' => $new_queue_stat));
614 646
 	}
@@ -642,8 +674,7 @@  discard block
 block discarded – undo
642 674
 					log_error(sprintf($txt['mail_send_unable'], $to));
643 675
 					$mail_result = false;
644 676
 				}
645
-			}
646
-			catch(ErrorException $e)
677
+			} catch(ErrorException $e)
647 678
 			{
648 679
 				log_error($e->getMessage(), 'general', $e->getFile(), $e->getLine());
649 680
 				log_error(sprintf($txt['mail_send_unable'], $to));
@@ -653,12 +684,13 @@  discard block
 block discarded – undo
653 684
 
654 685
 			// Wait, wait, I'm still sending here!
655 686
 			@set_time_limit(300);
656
-			if (function_exists('apache_reset_timeout'))
657
-				@apache_reset_timeout();
687
+			if (function_exists('apache_reset_timeout')) {
688
+							@apache_reset_timeout();
689
+			}
658 690
 		}
691
+	} else {
692
+			$mail_result = $mail_result && smtp_mail($to_array, $subject, $message, $headers);
659 693
 	}
660
-	else
661
-		$mail_result = $mail_result && smtp_mail($to_array, $subject, $message, $headers);
662 694
 
663 695
 	// Everything go smoothly?
664 696
 	return $mail_result;
@@ -684,8 +716,9 @@  discard block
 block discarded – undo
684 716
 	static $cur_insert = array();
685 717
 	static $cur_insert_len = 0;
686 718
 
687
-	if ($cur_insert_len == 0)
688
-		$cur_insert = array();
719
+	if ($cur_insert_len == 0) {
720
+			$cur_insert = array();
721
+	}
689 722
 
690 723
 	// If we're flushing, make the final inserts - also if we're near the MySQL length limit!
691 724
 	if (($flush || $cur_insert_len > 800000) && !empty($cur_insert))
@@ -760,8 +793,9 @@  discard block
 block discarded – undo
760 793
 	}
761 794
 
762 795
 	// If they are using SSI there is a good chance obExit will never be called.  So lets be nice and flush it for them.
763
-	if (SMF === 'SSI' || SMF === 'BACKGROUND')
764
-		return AddMailQueue(true);
796
+	if (SMF === 'SSI' || SMF === 'BACKGROUND') {
797
+			return AddMailQueue(true);
798
+	}
765 799
 
766 800
 	return true;
767 801
 }
@@ -792,23 +826,26 @@  discard block
 block discarded – undo
792 826
 		'sent' => array()
793 827
 	);
794 828
 
795
-	if ($from === null)
796
-		$from = array(
829
+	if ($from === null) {
830
+			$from = array(
797 831
 			'id' => $user_info['id'],
798 832
 			'name' => $user_info['name'],
799 833
 			'username' => $user_info['username']
800 834
 		);
835
+	}
801 836
 
802 837
 	// This is the one that will go in their inbox.
803 838
 	$htmlmessage = $smcFunc['htmlspecialchars']($message, ENT_QUOTES);
804 839
 	preparsecode($htmlmessage);
805 840
 	$htmlsubject = strtr($smcFunc['htmlspecialchars']($subject), array("\r" => '', "\n" => '', "\t" => ''));
806
-	if ($smcFunc['strlen']($htmlsubject) > 100)
807
-		$htmlsubject = $smcFunc['substr']($htmlsubject, 0, 100);
841
+	if ($smcFunc['strlen']($htmlsubject) > 100) {
842
+			$htmlsubject = $smcFunc['substr']($htmlsubject, 0, 100);
843
+	}
808 844
 
809 845
 	// Make sure is an array
810
-	if (!is_array($recipients))
811
-		$recipients = array($recipients);
846
+	if (!is_array($recipients)) {
847
+			$recipients = array($recipients);
848
+	}
812 849
 
813 850
 	// Integrated PMs
814 851
 	call_integration_hook('integrate_personal_message', array(&$recipients, &$from, &$subject, &$message));
@@ -836,21 +873,23 @@  discard block
 block discarded – undo
836 873
 				'usernames' => array_keys($usernames),
837 874
 			)
838 875
 		);
839
-		while ($row = $smcFunc['db_fetch_assoc']($request))
840
-			if (isset($usernames[$smcFunc['strtolower']($row['member_name'])]))
876
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
877
+					if (isset($usernames[$smcFunc['strtolower']($row['member_name'])]))
841 878
 				$usernames[$smcFunc['strtolower']($row['member_name'])] = $row['id_member'];
879
+		}
842 880
 		$smcFunc['db_free_result']($request);
843 881
 
844 882
 		// Replace the usernames with IDs. Drop usernames that couldn't be found.
845
-		foreach ($recipients as $rec_type => $rec)
846
-			foreach ($rec as $id => $member)
883
+		foreach ($recipients as $rec_type => $rec) {
884
+					foreach ($rec as $id => $member)
847 885
 			{
848 886
 				if (is_numeric($recipients[$rec_type][$id]))
849 887
 					continue;
888
+		}
850 889
 
851
-				if (!empty($usernames[$member]))
852
-					$recipients[$rec_type][$id] = $usernames[$member];
853
-				else
890
+				if (!empty($usernames[$member])) {
891
+									$recipients[$rec_type][$id] = $usernames[$member];
892
+				} else
854 893
 				{
855 894
 					$log['failed'][$id] = sprintf($txt['pm_error_user_not_found'], $recipients[$rec_type][$id]);
856 895
 					unset($recipients[$rec_type][$id]);
@@ -888,8 +927,9 @@  discard block
 block discarded – undo
888 927
 		$delete = false;
889 928
 		foreach ($criteria as $criterium)
890 929
 		{
891
-			if (($criterium['t'] == 'mid' && $criterium['v'] == $from['id']) || ($criterium['t'] == 'gid' && in_array($criterium['v'], $user_info['groups'])) || ($criterium['t'] == 'sub' && strpos($subject, $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($message, $criterium['v']) !== false))
892
-				$delete = true;
930
+			if (($criterium['t'] == 'mid' && $criterium['v'] == $from['id']) || ($criterium['t'] == 'gid' && in_array($criterium['v'], $user_info['groups'])) || ($criterium['t'] == 'sub' && strpos($subject, $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($message, $criterium['v']) !== false)) {
931
+							$delete = true;
932
+			}
893 933
 			// If we're adding and one criteria don't match then we stop!
894 934
 			elseif (!$row['is_or'])
895 935
 			{
@@ -897,8 +937,9 @@  discard block
 block discarded – undo
897 937
 				break;
898 938
 			}
899 939
 		}
900
-		if ($delete)
901
-			$deletes[$row['id_member']] = 1;
940
+		if ($delete) {
941
+					$deletes[$row['id_member']] = 1;
942
+		}
902 943
 	}
903 944
 	$smcFunc['db_free_result']($request);
904 945
 
@@ -913,8 +954,9 @@  discard block
 block discarded – undo
913 954
 			array(
914 955
 			)
915 956
 		);
916
-		while ($row = $smcFunc['db_fetch_assoc']($request))
917
-			$message_limit_cache[$row['id_group']] = $row['max_messages'];
957
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
958
+					$message_limit_cache[$row['id_group']] = $row['max_messages'];
959
+		}
918 960
 		$smcFunc['db_free_result']($request);
919 961
 	}
920 962
 
@@ -922,8 +964,9 @@  discard block
 block discarded – undo
922 964
 	require_once($sourcedir . '/Subs-Members.php');
923 965
 	$pmReadGroups = groupsAllowedTo('pm_read');
924 966
 
925
-	if (empty($modSettings['permission_enable_deny']))
926
-		$pmReadGroups['denied'] = array();
967
+	if (empty($modSettings['permission_enable_deny'])) {
968
+			$pmReadGroups['denied'] = array();
969
+	}
927 970
 
928 971
 	// Load their alert preferences
929 972
 	require_once($sourcedir . '/Subs-Notify.php');
@@ -955,8 +998,9 @@  discard block
 block discarded – undo
955 998
 	while ($row = $smcFunc['db_fetch_assoc']($request))
956 999
 	{
957 1000
 		// Don't do anything for members to be deleted!
958
-		if (isset($deletes[$row['id_member']]))
959
-			continue;
1001
+		if (isset($deletes[$row['id_member']])) {
1002
+					continue;
1003
+		}
960 1004
 
961 1005
 		// Load the preferences for this member (if any)
962 1006
 		$prefs = !empty($notifyPrefs[$row['id_member']]) ? $notifyPrefs[$row['id_member']] : array();
@@ -977,8 +1021,9 @@  discard block
 block discarded – undo
977 1021
 		{
978 1022
 			foreach ($groups as $id)
979 1023
 			{
980
-				if (isset($message_limit_cache[$id]) && $message_limit != 0 && $message_limit < $message_limit_cache[$id])
981
-					$message_limit = $message_limit_cache[$id];
1024
+				if (isset($message_limit_cache[$id]) && $message_limit != 0 && $message_limit < $message_limit_cache[$id]) {
1025
+									$message_limit = $message_limit_cache[$id];
1026
+				}
982 1027
 			}
983 1028
 
984 1029
 			if ($message_limit > 0 && $message_limit <= $row['instant_messages'])
@@ -1026,8 +1071,9 @@  discard block
 block discarded – undo
1026 1071
 	$smcFunc['db_free_result']($request);
1027 1072
 
1028 1073
 	// Only 'send' the message if there are any recipients left.
1029
-	if (empty($all_to))
1030
-		return $log;
1074
+	if (empty($all_to)) {
1075
+			return $log;
1076
+	}
1031 1077
 
1032 1078
 	// Insert the message itself and then grab the last insert id.
1033 1079
 	$id_pm = $smcFunc['db_insert']('',
@@ -1048,8 +1094,8 @@  discard block
 block discarded – undo
1048 1094
 	if (!empty($id_pm))
1049 1095
 	{
1050 1096
 		// If this is new we need to set it part of it's own conversation.
1051
-		if (empty($pm_head))
1052
-			$smcFunc['db_query']('', '
1097
+		if (empty($pm_head)) {
1098
+					$smcFunc['db_query']('', '
1053 1099
 				UPDATE {db_prefix}personal_messages
1054 1100
 				SET id_pm_head = {int:id_pm_head}
1055 1101
 				WHERE id_pm = {int:id_pm_head}',
@@ -1057,6 +1103,7 @@  discard block
 block discarded – undo
1057 1103
 					'id_pm_head' => $id_pm,
1058 1104
 				)
1059 1105
 			);
1106
+		}
1060 1107
 
1061 1108
 		// Some people think manually deleting personal_messages is fun... it's not. We protect against it though :)
1062 1109
 		$smcFunc['db_query']('', '
@@ -1072,8 +1119,9 @@  discard block
 block discarded – undo
1072 1119
 		foreach ($all_to as $to)
1073 1120
 		{
1074 1121
 			$insertRows[] = array($id_pm, $to, in_array($to, $recipients['bcc']) ? 1 : 0, isset($deletes[$to]) ? 1 : 0, 1);
1075
-			if (!in_array($to, $recipients['bcc']))
1076
-				$to_list[] = $to;
1122
+			if (!in_array($to, $recipients['bcc'])) {
1123
+							$to_list[] = $to;
1124
+			}
1077 1125
 		}
1078 1126
 
1079 1127
 		$smcFunc['db_insert']('insert',
@@ -1091,9 +1139,9 @@  discard block
 block discarded – undo
1091 1139
 	{
1092 1140
 		censorText($message);
1093 1141
 		$message = trim(un_htmlspecialchars(strip_tags(strtr(parse_bbc($smcFunc['htmlspecialchars']($message), false), array('<br>' => "\n", '</div>' => "\n", '</li>' => "\n", '&#91;' => '[', '&#93;' => ']')))));
1142
+	} else {
1143
+			$message = '';
1094 1144
 	}
1095
-	else
1096
-		$message = '';
1097 1145
 
1098 1146
 	$to_names = array();
1099 1147
 	if (count($to_list) > 1)
@@ -1106,8 +1154,9 @@  discard block
 block discarded – undo
1106 1154
 				'to_members' => $to_list,
1107 1155
 			)
1108 1156
 		);
1109
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1110
-			$to_names[] = un_htmlspecialchars($row['real_name']);
1157
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1158
+					$to_names[] = un_htmlspecialchars($row['real_name']);
1159
+		}
1111 1160
 		$smcFunc['db_free_result']($request);
1112 1161
 	}
1113 1162
 	$replacements = array(
@@ -1135,11 +1184,13 @@  discard block
 block discarded – undo
1135 1184
 	loadLanguage('index+PersonalMessage');
1136 1185
 
1137 1186
 	// Add one to their unread and read message counts.
1138
-	foreach ($all_to as $k => $id)
1139
-		if (isset($deletes[$id]))
1187
+	foreach ($all_to as $k => $id) {
1188
+			if (isset($deletes[$id]))
1140 1189
 			unset($all_to[$k]);
1141
-	if (!empty($all_to))
1142
-		updateMemberData($all_to, array('instant_messages' => '+', 'unread_messages' => '+', 'new_pm' => 1));
1190
+	}
1191
+	if (!empty($all_to)) {
1192
+			updateMemberData($all_to, array('instant_messages' => '+', 'unread_messages' => '+', 'new_pm' => 1));
1193
+	}
1143 1194
 
1144 1195
 	return $log;
1145 1196
 }
@@ -1169,15 +1220,17 @@  discard block
 block discarded – undo
1169 1220
 		// Let's, for now, assume there are only &#021;'ish characters.
1170 1221
 		$simple = true;
1171 1222
 
1172
-		foreach ($matches[1] as $entity)
1173
-			if ($entity > 128)
1223
+		foreach ($matches[1] as $entity) {
1224
+					if ($entity > 128)
1174 1225
 				$simple = false;
1226
+		}
1175 1227
 		unset($matches);
1176 1228
 
1177
-		if ($simple)
1178
-			$string = preg_replace_callback('~&#(\d{3,8});~', function($m)
1229
+		if ($simple) {
1230
+					$string = preg_replace_callback('~&#(\d{3,8});~', function($m)
1179 1231
 			{
1180 1232
 				return chr("$m[1]");
1233
+		}
1181 1234
 			}, $string);
1182 1235
 		else
1183 1236
 		{
@@ -1185,8 +1238,9 @@  discard block
 block discarded – undo
1185 1238
 			if (!$context['utf8'] && function_exists('iconv'))
1186 1239
 			{
1187 1240
 				$newstring = @iconv($context['character_set'], 'UTF-8', $string);
1188
-				if ($newstring)
1189
-					$string = $newstring;
1241
+				if ($newstring) {
1242
+									$string = $newstring;
1243
+				}
1190 1244
 			}
1191 1245
 
1192 1246
 			$string = preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $string);
@@ -1202,23 +1256,25 @@  discard block
 block discarded – undo
1202 1256
 		if (!$context['utf8'] && function_exists('iconv'))
1203 1257
 		{
1204 1258
 			$newstring = @iconv($context['character_set'], 'UTF-8', $string);
1205
-			if ($newstring)
1206
-				$string = $newstring;
1259
+			if ($newstring) {
1260
+							$string = $newstring;
1261
+			}
1207 1262
 		}
1208 1263
 
1209 1264
 		$entityConvert = function($m)
1210 1265
 		{
1211 1266
 			$c = $m[1];
1212
-			if (strlen($c) === 1 && ord($c[0]) <= 0x7F)
1213
-				return $c;
1214
-			elseif (strlen($c) === 2 && ord($c[0]) >= 0xC0 && ord($c[0]) <= 0xDF)
1215
-				return "&#" . (((ord($c[0]) ^ 0xC0) << 6) + (ord($c[1]) ^ 0x80)) . ";";
1216
-			elseif (strlen($c) === 3 && ord($c[0]) >= 0xE0 && ord($c[0]) <= 0xEF)
1217
-				return "&#" . (((ord($c[0]) ^ 0xE0) << 12) + ((ord($c[1]) ^ 0x80) << 6) + (ord($c[2]) ^ 0x80)) . ";";
1218
-			elseif (strlen($c) === 4 && ord($c[0]) >= 0xF0 && ord($c[0]) <= 0xF7)
1219
-				return "&#" . (((ord($c[0]) ^ 0xF0) << 18) + ((ord($c[1]) ^ 0x80) << 12) + ((ord($c[2]) ^ 0x80) << 6) + (ord($c[3]) ^ 0x80)) . ";";
1220
-			else
1221
-				return "";
1267
+			if (strlen($c) === 1 && ord($c[0]) <= 0x7F) {
1268
+							return $c;
1269
+			} elseif (strlen($c) === 2 && ord($c[0]) >= 0xC0 && ord($c[0]) <= 0xDF) {
1270
+							return "&#" . (((ord($c[0]) ^ 0xC0) << 6) + (ord($c[1]) ^ 0x80)) . ";";
1271
+			} elseif (strlen($c) === 3 && ord($c[0]) >= 0xE0 && ord($c[0]) <= 0xEF) {
1272
+							return "&#" . (((ord($c[0]) ^ 0xE0) << 12) + ((ord($c[1]) ^ 0x80) << 6) + (ord($c[2]) ^ 0x80)) . ";";
1273
+			} elseif (strlen($c) === 4 && ord($c[0]) >= 0xF0 && ord($c[0]) <= 0xF7) {
1274
+							return "&#" . (((ord($c[0]) ^ 0xF0) << 18) + ((ord($c[1]) ^ 0x80) << 12) + ((ord($c[2]) ^ 0x80) << 6) + (ord($c[3]) ^ 0x80)) . ";";
1275
+			} else {
1276
+							return "";
1277
+			}
1222 1278
 		};
1223 1279
 
1224 1280
 		// Convert all 'special' characters to HTML entities.
@@ -1232,19 +1288,20 @@  discard block
 block discarded – undo
1232 1288
 		$string = base64_encode($string);
1233 1289
 
1234 1290
 		// Show the characterset and the transfer-encoding for header strings.
1235
-		if ($with_charset)
1236
-			$string = '=?' . $charset . '?B?' . $string . '?=';
1291
+		if ($with_charset) {
1292
+					$string = '=?' . $charset . '?B?' . $string . '?=';
1293
+		}
1237 1294
 
1238 1295
 		// Break it up in lines (mail body).
1239
-		else
1240
-			$string = chunk_split($string, 76, $line_break);
1296
+		else {
1297
+					$string = chunk_split($string, 76, $line_break);
1298
+		}
1241 1299
 
1242 1300
 		return array($charset, $string, 'base64');
1301
+	} else {
1302
+			return array($charset, $string, '7bit');
1303
+	}
1243 1304
 	}
1244
-
1245
-	else
1246
-		return array($charset, $string, '7bit');
1247
-}
1248 1305
 
1249 1306
 /**
1250 1307
  * Sends mail, like mail() but over SMTP.
@@ -1268,8 +1325,9 @@  discard block
 block discarded – undo
1268 1325
 	if ($modSettings['mail_type'] == 3 && $modSettings['smtp_username'] != '' && $modSettings['smtp_password'] != '')
1269 1326
 	{
1270 1327
 		$socket = fsockopen($modSettings['smtp_host'], 110, $errno, $errstr, 2);
1271
-		if (!$socket && (substr($modSettings['smtp_host'], 0, 5) == 'smtp.' || substr($modSettings['smtp_host'], 0, 11) == 'ssl://smtp.'))
1272
-			$socket = fsockopen(strtr($modSettings['smtp_host'], array('smtp.' => 'pop.')), 110, $errno, $errstr, 2);
1328
+		if (!$socket && (substr($modSettings['smtp_host'], 0, 5) == 'smtp.' || substr($modSettings['smtp_host'], 0, 11) == 'ssl://smtp.')) {
1329
+					$socket = fsockopen(strtr($modSettings['smtp_host'], array('smtp.' => 'pop.')), 110, $errno, $errstr, 2);
1330
+		}
1273 1331
 
1274 1332
 		if ($socket)
1275 1333
 		{
@@ -1290,8 +1348,9 @@  discard block
 block discarded – undo
1290 1348
 		// Maybe we can still save this?  The port might be wrong.
1291 1349
 		if (substr($modSettings['smtp_host'], 0, 4) == 'ssl:' && (empty($modSettings['smtp_port']) || $modSettings['smtp_port'] == 25))
1292 1350
 		{
1293
-			if ($socket = fsockopen($modSettings['smtp_host'], 465, $errno, $errstr, 3))
1294
-				log_error($txt['smtp_port_ssl']);
1351
+			if ($socket = fsockopen($modSettings['smtp_host'], 465, $errno, $errstr, 3)) {
1352
+							log_error($txt['smtp_port_ssl']);
1353
+			}
1295 1354
 		}
1296 1355
 
1297 1356
 		// Unable to connect!  Don't show any error message, but just log one and try to continue anyway.
@@ -1303,20 +1362,23 @@  discard block
 block discarded – undo
1303 1362
 	}
1304 1363
 
1305 1364
 	// Wait for a response of 220, without "-" continuer.
1306
-	if (!server_parse(null, $socket, '220'))
1307
-		return false;
1365
+	if (!server_parse(null, $socket, '220')) {
1366
+			return false;
1367
+	}
1308 1368
 
1309 1369
 	// Try and determine the servers name, fall back to the mail servers if not found
1310 1370
 	$helo = false;
1311
-	if (function_exists('gethostname') && gethostname() !== false)
1312
-		$helo = gethostname();
1313
-	elseif (function_exists('php_uname'))
1314
-		$helo = php_uname('n');
1315
-	elseif (array_key_exists('SERVER_NAME', $_SERVER) && !empty($_SERVER['SERVER_NAME']))
1316
-		$helo = $_SERVER['SERVER_NAME'];
1371
+	if (function_exists('gethostname') && gethostname() !== false) {
1372
+			$helo = gethostname();
1373
+	} elseif (function_exists('php_uname')) {
1374
+			$helo = php_uname('n');
1375
+	} elseif (array_key_exists('SERVER_NAME', $_SERVER) && !empty($_SERVER['SERVER_NAME'])) {
1376
+			$helo = $_SERVER['SERVER_NAME'];
1377
+	}
1317 1378
 
1318
-	if (empty($helo))
1319
-		$helo = $modSettings['smtp_host'];
1379
+	if (empty($helo)) {
1380
+			$helo = $modSettings['smtp_host'];
1381
+	}
1320 1382
 
1321 1383
 	// SMTP = 1, SMTP - STARTTLS = 2
1322 1384
 	if (in_array($modSettings['mail_type'], array(1, 2)) && $modSettings['smtp_username'] != '' && $modSettings['smtp_password'] != '')
@@ -1328,33 +1390,39 @@  discard block
 block discarded – undo
1328 1390
 			if ($modSettings['mail_type'] == 2 && preg_match("~250( |-)STARTTLS~mi", $response))
1329 1391
 			{
1330 1392
 				// Send STARTTLS to enable encryption
1331
-				if (!server_parse('STARTTLS', $socket, '220'))
1332
-					return false;
1393
+				if (!server_parse('STARTTLS', $socket, '220')) {
1394
+									return false;
1395
+				}
1333 1396
 				// Enable the encryption
1334
-				if (!@stream_socket_enable_crypto($socket, true, STREAM_CRYPTO_METHOD_TLS_CLIENT))
1335
-					return false;
1397
+				if (!@stream_socket_enable_crypto($socket, true, STREAM_CRYPTO_METHOD_TLS_CLIENT)) {
1398
+									return false;
1399
+				}
1336 1400
 				// Send the EHLO command again
1337
-				if (!server_parse('EHLO ' . $helo, $socket, null) == '250')
1338
-					return false;
1401
+				if (!server_parse('EHLO ' . $helo, $socket, null) == '250') {
1402
+									return false;
1403
+				}
1339 1404
 			}
1340 1405
 
1341
-			if (!server_parse('AUTH LOGIN', $socket, '334'))
1342
-				return false;
1406
+			if (!server_parse('AUTH LOGIN', $socket, '334')) {
1407
+							return false;
1408
+			}
1343 1409
 			// Send the username and password, encoded.
1344
-			if (!server_parse(base64_encode($modSettings['smtp_username']), $socket, '334'))
1345
-				return false;
1410
+			if (!server_parse(base64_encode($modSettings['smtp_username']), $socket, '334')) {
1411
+							return false;
1412
+			}
1346 1413
 			// The password is already encoded ;)
1347
-			if (!server_parse($modSettings['smtp_password'], $socket, '235'))
1348
-				return false;
1414
+			if (!server_parse($modSettings['smtp_password'], $socket, '235')) {
1415
+							return false;
1416
+			}
1417
+		} elseif (!server_parse('HELO ' . $helo, $socket, '250')) {
1418
+					return false;
1349 1419
 		}
1350
-		elseif (!server_parse('HELO ' . $helo, $socket, '250'))
1351
-			return false;
1352
-	}
1353
-	else
1420
+	} else
1354 1421
 	{
1355 1422
 		// Just say "helo".
1356
-		if (!server_parse('HELO ' . $helo, $socket, '250'))
1357
-			return false;
1423
+		if (!server_parse('HELO ' . $helo, $socket, '250')) {
1424
+					return false;
1425
+		}
1358 1426
 	}
1359 1427
 
1360 1428
 	// Fix the message for any lines beginning with a period! (the first is ignored, you see.)
@@ -1367,31 +1435,38 @@  discard block
 block discarded – undo
1367 1435
 		// Reset the connection to send another email.
1368 1436
 		if ($i != 0)
1369 1437
 		{
1370
-			if (!server_parse('RSET', $socket, '250'))
1371
-				return false;
1438
+			if (!server_parse('RSET', $socket, '250')) {
1439
+							return false;
1440
+			}
1372 1441
 		}
1373 1442
 
1374 1443
 		// From, to, and then start the data...
1375
-		if (!server_parse('MAIL FROM: <' . (empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from']) . '>', $socket, '250'))
1376
-			return false;
1377
-		if (!server_parse('RCPT TO: <' . $mail_to . '>', $socket, '250'))
1378
-			return false;
1379
-		if (!server_parse('DATA', $socket, '354'))
1380
-			return false;
1444
+		if (!server_parse('MAIL FROM: <' . (empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from']) . '>', $socket, '250')) {
1445
+					return false;
1446
+		}
1447
+		if (!server_parse('RCPT TO: <' . $mail_to . '>', $socket, '250')) {
1448
+					return false;
1449
+		}
1450
+		if (!server_parse('DATA', $socket, '354')) {
1451
+					return false;
1452
+		}
1381 1453
 		fputs($socket, 'Subject: ' . $subject . "\r\n");
1382
-		if (strlen($mail_to) > 0)
1383
-			fputs($socket, 'To: <' . $mail_to . '>' . "\r\n");
1454
+		if (strlen($mail_to) > 0) {
1455
+					fputs($socket, 'To: <' . $mail_to . '>' . "\r\n");
1456
+		}
1384 1457
 		fputs($socket, $headers . "\r\n\r\n");
1385 1458
 		fputs($socket, $message . "\r\n");
1386 1459
 
1387 1460
 		// Send a ., or in other words "end of data".
1388
-		if (!server_parse('.', $socket, '250'))
1389
-			return false;
1461
+		if (!server_parse('.', $socket, '250')) {
1462
+					return false;
1463
+		}
1390 1464
 
1391 1465
 		// Almost done, almost done... don't stop me just yet!
1392 1466
 		@set_time_limit(300);
1393
-		if (function_exists('apache_reset_timeout'))
1394
-			@apache_reset_timeout();
1467
+		if (function_exists('apache_reset_timeout')) {
1468
+					@apache_reset_timeout();
1469
+		}
1395 1470
 	}
1396 1471
 	fputs($socket, 'QUIT' . "\r\n");
1397 1472
 	fclose($socket);
@@ -1415,8 +1490,9 @@  discard block
 block discarded – undo
1415 1490
 {
1416 1491
 	global $txt;
1417 1492
 
1418
-	if ($message !== null)
1419
-		fputs($socket, $message . "\r\n");
1493
+	if ($message !== null) {
1494
+			fputs($socket, $message . "\r\n");
1495
+	}
1420 1496
 
1421 1497
 	// No response yet.
1422 1498
 	$server_response = '';
@@ -1432,8 +1508,9 @@  discard block
 block discarded – undo
1432 1508
 		$response .= $server_response;
1433 1509
 	}
1434 1510
 
1435
-	if ($code === null)
1436
-		return substr($server_response, 0, 3);
1511
+	if ($code === null) {
1512
+			return substr($server_response, 0, 3);
1513
+	}
1437 1514
 
1438 1515
 	if (substr($server_response, 0, 3) != $code)
1439 1516
 	{
@@ -1463,8 +1540,9 @@  discard block
 block discarded – undo
1463 1540
 	// Create a pspell or enchant dictionary resource
1464 1541
 	$dict = spell_init();
1465 1542
 
1466
-	if (!isset($_POST['spellstring']) || !$dict)
1467
-		die;
1543
+	if (!isset($_POST['spellstring']) || !$dict) {
1544
+			die;
1545
+	}
1468 1546
 
1469 1547
 	// Construct a bit of Javascript code.
1470 1548
 	$context['spell_js'] = '
@@ -1482,8 +1560,9 @@  discard block
 block discarded – undo
1482 1560
 		$check_word = explode('|', $alphas[$i]);
1483 1561
 
1484 1562
 		// If the word is a known word, or spelled right...
1485
-		if (in_array($smcFunc['strtolower']($check_word[0]), $known_words) || spell_check($dict, $check_word[0]) || !isset($check_word[2]))
1486
-			continue;
1563
+		if (in_array($smcFunc['strtolower']($check_word[0]), $known_words) || spell_check($dict, $check_word[0]) || !isset($check_word[2])) {
1564
+					continue;
1565
+		}
1487 1566
 
1488 1567
 		// Find the word, and move up the "last occurrence" to here.
1489 1568
 		$found_words = true;
@@ -1497,20 +1576,23 @@  discard block
 block discarded – undo
1497 1576
 		if (!empty($suggestions))
1498 1577
 		{
1499 1578
 			// But first check they aren't going to be censored - no naughty words!
1500
-			foreach ($suggestions as $k => $word)
1501
-				if ($suggestions[$k] != censorText($word))
1579
+			foreach ($suggestions as $k => $word) {
1580
+							if ($suggestions[$k] != censorText($word))
1502 1581
 					unset($suggestions[$k]);
1582
+			}
1503 1583
 
1504
-			if (!empty($suggestions))
1505
-				$context['spell_js'] .= '"' . implode('", "', $suggestions) . '"';
1584
+			if (!empty($suggestions)) {
1585
+							$context['spell_js'] .= '"' . implode('", "', $suggestions) . '"';
1586
+			}
1506 1587
 		}
1507 1588
 
1508 1589
 		$context['spell_js'] .= ']),';
1509 1590
 	}
1510 1591
 
1511 1592
 	// If words were found, take off the last comma.
1512
-	if ($found_words)
1513
-		$context['spell_js'] = substr($context['spell_js'], 0, -1);
1593
+	if ($found_words) {
1594
+			$context['spell_js'] = substr($context['spell_js'], 0, -1);
1595
+	}
1514 1596
 
1515 1597
 	$context['spell_js'] .= '
1516 1598
 		);';
@@ -1545,11 +1627,13 @@  discard block
 block discarded – undo
1545 1627
 	global $user_info, $smcFunc;
1546 1628
 
1547 1629
 	// Can't do it if there's no topics.
1548
-	if (empty($topics))
1549
-		return;
1630
+	if (empty($topics)) {
1631
+			return;
1632
+	}
1550 1633
 	// It must be an array - it must!
1551
-	if (!is_array($topics))
1552
-		$topics = array($topics);
1634
+	if (!is_array($topics)) {
1635
+			$topics = array($topics);
1636
+	}
1553 1637
 
1554 1638
 	// Get the subject and body...
1555 1639
 	$result = $smcFunc['db_query']('', '
@@ -1597,14 +1681,15 @@  discard block
 block discarded – undo
1597 1681
 	}
1598 1682
 	$smcFunc['db_free_result']($result);
1599 1683
 
1600
-	if (!empty($task_rows))
1601
-		$smcFunc['db_insert']('',
1684
+	if (!empty($task_rows)) {
1685
+			$smcFunc['db_insert']('',
1602 1686
 			'{db_prefix}background_tasks',
1603 1687
 			array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'),
1604 1688
 			$task_rows,
1605 1689
 			array('id_task')
1606 1690
 		);
1607
-}
1691
+	}
1692
+	}
1608 1693
 
1609 1694
 /**
1610 1695
  * Create a post, either as new topic (id_topic = 0) or in an existing one.
@@ -1642,9 +1727,9 @@  discard block
 block discarded – undo
1642 1727
 	$msgOptions['send_notifications'] = isset($msgOptions['send_notifications']) ? (bool) $msgOptions['send_notifications'] : true;
1643 1728
 
1644 1729
 	// We need to know if the topic is approved. If we're told that's great - if not find out.
1645
-	if (!$modSettings['postmod_active'])
1646
-		$topicOptions['is_approved'] = true;
1647
-	elseif (!empty($topicOptions['id']) && !isset($topicOptions['is_approved']))
1730
+	if (!$modSettings['postmod_active']) {
1731
+			$topicOptions['is_approved'] = true;
1732
+	} elseif (!empty($topicOptions['id']) && !isset($topicOptions['is_approved']))
1648 1733
 	{
1649 1734
 		$request = $smcFunc['db_query']('', '
1650 1735
 			SELECT approved
@@ -1667,8 +1752,7 @@  discard block
 block discarded – undo
1667 1752
 			$posterOptions['id'] = 0;
1668 1753
 			$posterOptions['name'] = $txt['guest_title'];
1669 1754
 			$posterOptions['email'] = '';
1670
-		}
1671
-		elseif ($posterOptions['id'] != $user_info['id'])
1755
+		} elseif ($posterOptions['id'] != $user_info['id'])
1672 1756
 		{
1673 1757
 			$request = $smcFunc['db_query']('', '
1674 1758
 				SELECT member_name, email_address
@@ -1686,12 +1770,11 @@  discard block
 block discarded – undo
1686 1770
 				$posterOptions['id'] = 0;
1687 1771
 				$posterOptions['name'] = $txt['guest_title'];
1688 1772
 				$posterOptions['email'] = '';
1773
+			} else {
1774
+							list ($posterOptions['name'], $posterOptions['email']) = $smcFunc['db_fetch_row']($request);
1689 1775
 			}
1690
-			else
1691
-				list ($posterOptions['name'], $posterOptions['email']) = $smcFunc['db_fetch_row']($request);
1692 1776
 			$smcFunc['db_free_result']($request);
1693
-		}
1694
-		else
1777
+		} else
1695 1778
 		{
1696 1779
 			$posterOptions['name'] = $user_info['name'];
1697 1780
 			$posterOptions['email'] = $user_info['email'];
@@ -1701,8 +1784,9 @@  discard block
 block discarded – undo
1701 1784
 	if (!empty($modSettings['enable_mentions']))
1702 1785
 	{
1703 1786
 		$msgOptions['mentioned_members'] = Mentions::getMentionedMembers($msgOptions['body']);
1704
-		if (!empty($msgOptions['mentioned_members']))
1705
-			$msgOptions['body'] = Mentions::getBody($msgOptions['body'], $msgOptions['mentioned_members']);
1787
+		if (!empty($msgOptions['mentioned_members'])) {
1788
+					$msgOptions['body'] = Mentions::getBody($msgOptions['body'], $msgOptions['mentioned_members']);
1789
+		}
1706 1790
 	}
1707 1791
 
1708 1792
 	// It's do or die time: forget any user aborts!
@@ -1735,12 +1819,13 @@  discard block
 block discarded – undo
1735 1819
 	);
1736 1820
 
1737 1821
 	// Something went wrong creating the message...
1738
-	if (empty($msgOptions['id']))
1739
-		return false;
1822
+	if (empty($msgOptions['id'])) {
1823
+			return false;
1824
+	}
1740 1825
 
1741 1826
 	// Fix the attachments.
1742
-	if (!empty($msgOptions['attachments']))
1743
-		$smcFunc['db_query']('', '
1827
+	if (!empty($msgOptions['attachments'])) {
1828
+			$smcFunc['db_query']('', '
1744 1829
 			UPDATE {db_prefix}attachments
1745 1830
 			SET id_msg = {int:id_msg}
1746 1831
 			WHERE id_attach IN ({array_int:attachment_list})',
@@ -1749,6 +1834,7 @@  discard block
 block discarded – undo
1749 1834
 				'id_msg' => $msgOptions['id'],
1750 1835
 			)
1751 1836
 		);
1837
+	}
1752 1838
 
1753 1839
 	// What if we want to export new posts out to a CMS?
1754 1840
 	call_integration_hook('integrate_after_create_post', array($msgOptions, $topicOptions, $posterOptions, $message_columns, $message_parameters));
@@ -1825,20 +1911,23 @@  discard block
 block discarded – undo
1825 1911
 			'id_topic' => $topicOptions['id'],
1826 1912
 			'counter_increment' => 1,
1827 1913
 		);
1828
-		if ($msgOptions['approved'])
1829
-			$topics_columns = array(
1914
+		if ($msgOptions['approved']) {
1915
+					$topics_columns = array(
1830 1916
 				'id_member_updated = {int:poster_id}',
1831 1917
 				'id_last_msg = {int:id_msg}',
1832 1918
 				'num_replies = num_replies + {int:counter_increment}',
1833 1919
 			);
1834
-		else
1835
-			$topics_columns = array(
1920
+		} else {
1921
+					$topics_columns = array(
1836 1922
 				'unapproved_posts = unapproved_posts + {int:counter_increment}',
1837 1923
 			);
1838
-		if ($topicOptions['lock_mode'] !== null)
1839
-			$topics_columns[] = 'locked = {int:locked}';
1840
-		if ($topicOptions['sticky_mode'] !== null)
1841
-			$topics_columns[] = 'is_sticky = {int:is_sticky}';
1924
+		}
1925
+		if ($topicOptions['lock_mode'] !== null) {
1926
+					$topics_columns[] = 'locked = {int:locked}';
1927
+		}
1928
+		if ($topicOptions['sticky_mode'] !== null) {
1929
+					$topics_columns[] = 'is_sticky = {int:is_sticky}';
1930
+		}
1842 1931
 
1843 1932
 		call_integration_hook('integrate_modify_topic', array(&$topics_columns, &$update_parameters, &$msgOptions, &$topicOptions, &$posterOptions));
1844 1933
 
@@ -1867,8 +1956,8 @@  discard block
 block discarded – undo
1867 1956
 	);
1868 1957
 
1869 1958
 	// Increase the number of posts and topics on the board.
1870
-	if ($msgOptions['approved'])
1871
-		$smcFunc['db_query']('', '
1959
+	if ($msgOptions['approved']) {
1960
+			$smcFunc['db_query']('', '
1872 1961
 			UPDATE {db_prefix}boards
1873 1962
 			SET num_posts = num_posts + 1' . ($new_topic ? ', num_topics = num_topics + 1' : '') . '
1874 1963
 			WHERE id_board = {int:id_board}',
@@ -1876,7 +1965,7 @@  discard block
 block discarded – undo
1876 1965
 				'id_board' => $topicOptions['board'],
1877 1966
 			)
1878 1967
 		);
1879
-	else
1968
+	} else
1880 1969
 	{
1881 1970
 		$smcFunc['db_query']('', '
1882 1971
 			UPDATE {db_prefix}boards
@@ -1946,8 +2035,8 @@  discard block
 block discarded – undo
1946 2035
 		}
1947 2036
 	}
1948 2037
 
1949
-	if ($msgOptions['approved'] && empty($topicOptions['is_approved']))
1950
-		$smcFunc['db_insert']('',
2038
+	if ($msgOptions['approved'] && empty($topicOptions['is_approved'])) {
2039
+			$smcFunc['db_insert']('',
1951 2040
 			'{db_prefix}background_tasks',
1952 2041
 			array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'),
1953 2042
 			array(
@@ -1959,19 +2048,22 @@  discard block
 block discarded – undo
1959 2048
 			),
1960 2049
 			array('id_task')
1961 2050
 		);
2051
+	}
1962 2052
 
1963 2053
 	// If there's a custom search index, it may need updating...
1964 2054
 	require_once($sourcedir . '/Search.php');
1965 2055
 	$searchAPI = findSearchAPI();
1966
-	if (is_callable(array($searchAPI, 'postCreated')))
1967
-		$searchAPI->postCreated($msgOptions, $topicOptions, $posterOptions);
2056
+	if (is_callable(array($searchAPI, 'postCreated'))) {
2057
+			$searchAPI->postCreated($msgOptions, $topicOptions, $posterOptions);
2058
+	}
1968 2059
 
1969 2060
 	// Increase the post counter for the user that created the post.
1970 2061
 	if (!empty($posterOptions['update_post_count']) && !empty($posterOptions['id']) && $msgOptions['approved'])
1971 2062
 	{
1972 2063
 		// Are you the one that happened to create this post?
1973
-		if ($user_info['id'] == $posterOptions['id'])
1974
-			$user_info['posts']++;
2064
+		if ($user_info['id'] == $posterOptions['id']) {
2065
+					$user_info['posts']++;
2066
+		}
1975 2067
 		updateMemberData($posterOptions['id'], array('posts' => '+'));
1976 2068
 	}
1977 2069
 
@@ -1979,19 +2071,21 @@  discard block
 block discarded – undo
1979 2071
 	$_SESSION['last_read_topic'] = 0;
1980 2072
 
1981 2073
 	// Better safe than sorry.
1982
-	if (isset($_SESSION['topicseen_cache'][$topicOptions['board']]))
1983
-		$_SESSION['topicseen_cache'][$topicOptions['board']]--;
2074
+	if (isset($_SESSION['topicseen_cache'][$topicOptions['board']])) {
2075
+			$_SESSION['topicseen_cache'][$topicOptions['board']]--;
2076
+	}
1984 2077
 
1985 2078
 	// Update all the stats so everyone knows about this new topic and message.
1986 2079
 	updateStats('message', true, $msgOptions['id']);
1987 2080
 
1988 2081
 	// Update the last message on the board assuming it's approved AND the topic is.
1989
-	if ($msgOptions['approved'])
1990
-		updateLastMessages($topicOptions['board'], $new_topic || !empty($topicOptions['is_approved']) ? $msgOptions['id'] : 0);
2082
+	if ($msgOptions['approved']) {
2083
+			updateLastMessages($topicOptions['board'], $new_topic || !empty($topicOptions['is_approved']) ? $msgOptions['id'] : 0);
2084
+	}
1991 2085
 
1992 2086
 	// Queue createPost background notification
1993
-	if ($msgOptions['send_notifications'] && $msgOptions['approved'])
1994
-		$smcFunc['db_insert']('',
2087
+	if ($msgOptions['send_notifications'] && $msgOptions['approved']) {
2088
+			$smcFunc['db_insert']('',
1995 2089
 			'{db_prefix}background_tasks',
1996 2090
 			array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'),
1997 2091
 			array('$sourcedir/tasks/CreatePost-Notify.php', 'CreatePost_Notify_Background', $smcFunc['json_encode'](array(
@@ -2002,6 +2096,7 @@  discard block
 block discarded – undo
2002 2096
 			)), 0),
2003 2097
 			array('id_task')
2004 2098
 		);
2099
+	}
2005 2100
 
2006 2101
 	// Alright, done now... we can abort now, I guess... at least this much is done.
2007 2102
 	ignore_user_abort($previous_ignore_user_abort);
@@ -2028,14 +2123,18 @@  discard block
 block discarded – undo
2028 2123
 
2029 2124
 	// This is longer than it has to be, but makes it so we only set/change what we have to.
2030 2125
 	$messages_columns = array();
2031
-	if (isset($posterOptions['name']))
2032
-		$messages_columns['poster_name'] = $posterOptions['name'];
2033
-	if (isset($posterOptions['email']))
2034
-		$messages_columns['poster_email'] = $posterOptions['email'];
2035
-	if (isset($msgOptions['icon']))
2036
-		$messages_columns['icon'] = $msgOptions['icon'];
2037
-	if (isset($msgOptions['subject']))
2038
-		$messages_columns['subject'] = $msgOptions['subject'];
2126
+	if (isset($posterOptions['name'])) {
2127
+			$messages_columns['poster_name'] = $posterOptions['name'];
2128
+	}
2129
+	if (isset($posterOptions['email'])) {
2130
+			$messages_columns['poster_email'] = $posterOptions['email'];
2131
+	}
2132
+	if (isset($msgOptions['icon'])) {
2133
+			$messages_columns['icon'] = $msgOptions['icon'];
2134
+	}
2135
+	if (isset($msgOptions['subject'])) {
2136
+			$messages_columns['subject'] = $msgOptions['subject'];
2137
+	}
2039 2138
 	if (isset($msgOptions['body']))
2040 2139
 	{
2041 2140
 		$messages_columns['body'] = $msgOptions['body'];
@@ -2062,8 +2161,9 @@  discard block
 block discarded – undo
2062 2161
 		$messages_columns['modified_reason'] = $msgOptions['modify_reason'];
2063 2162
 		$messages_columns['id_msg_modified'] = $modSettings['maxMsgID'];
2064 2163
 	}
2065
-	if (isset($msgOptions['smileys_enabled']))
2066
-		$messages_columns['smileys_enabled'] = empty($msgOptions['smileys_enabled']) ? 0 : 1;
2164
+	if (isset($msgOptions['smileys_enabled'])) {
2165
+			$messages_columns['smileys_enabled'] = empty($msgOptions['smileys_enabled']) ? 0 : 1;
2166
+	}
2067 2167
 
2068 2168
 	// Which columns need to be ints?
2069 2169
 	$messageInts = array('modified_time', 'id_msg_modified', 'smileys_enabled');
@@ -2081,23 +2181,27 @@  discard block
 block discarded – undo
2081 2181
 		{
2082 2182
 			preg_match_all('/\[member\=([0-9]+)\]([^\[]*)\[\/member\]/U', $msgOptions['old_body'], $match);
2083 2183
 
2084
-			if (isset($match[1]) && isset($match[2]) && is_array($match[1]) && is_array($match[2]))
2085
-				foreach ($match[1] as $i => $oldID)
2184
+			if (isset($match[1]) && isset($match[2]) && is_array($match[1]) && is_array($match[2])) {
2185
+							foreach ($match[1] as $i => $oldID)
2086 2186
 					$oldmentions[$oldID] = array('id' => $oldID, 'real_name' => $match[2][$i]);
2187
+			}
2087 2188
 
2088
-			if (empty($modSettings['search_custom_index_config']))
2089
-				unset($msgOptions['old_body']);
2189
+			if (empty($modSettings['search_custom_index_config'])) {
2190
+							unset($msgOptions['old_body']);
2191
+			}
2090 2192
 		}
2091 2193
 
2092 2194
 		$mentions = Mentions::getMentionedMembers($msgOptions['body']);
2093 2195
 		$messages_columns['body'] = $msgOptions['body'] = Mentions::getBody($msgOptions['body'], $mentions);
2094 2196
 
2095 2197
 		// Remove the poster.
2096
-		if (isset($mentions[$user_info['id']]))
2097
-			unset($mentions[$user_info['id']]);
2198
+		if (isset($mentions[$user_info['id']])) {
2199
+					unset($mentions[$user_info['id']]);
2200
+		}
2098 2201
 
2099
-		if (isset($oldmentions[$user_info['id']]))
2100
-			unset($oldmentions[$user_info['id']]);
2202
+		if (isset($oldmentions[$user_info['id']])) {
2203
+					unset($oldmentions[$user_info['id']]);
2204
+		}
2101 2205
 
2102 2206
 		if (is_array($mentions) && is_array($oldmentions) && count(array_diff_key($mentions, $oldmentions)) > 0 && count($mentions) > count($oldmentions))
2103 2207
 		{
@@ -2127,8 +2231,9 @@  discard block
 block discarded – undo
2127 2231
 	}
2128 2232
 
2129 2233
 	// Nothing to do?
2130
-	if (empty($messages_columns))
2131
-		return true;
2234
+	if (empty($messages_columns)) {
2235
+			return true;
2236
+	}
2132 2237
 
2133 2238
 	// Change the post.
2134 2239
 	$smcFunc['db_query']('', '
@@ -2189,8 +2294,9 @@  discard block
 block discarded – undo
2189 2294
 	// If there's a custom search index, it needs to be modified...
2190 2295
 	require_once($sourcedir . '/Search.php');
2191 2296
 	$searchAPI = findSearchAPI();
2192
-	if (is_callable(array($searchAPI, 'postModified')))
2193
-		$searchAPI->postModified($msgOptions, $topicOptions, $posterOptions);
2297
+	if (is_callable(array($searchAPI, 'postModified'))) {
2298
+			$searchAPI->postModified($msgOptions, $topicOptions, $posterOptions);
2299
+	}
2194 2300
 
2195 2301
 	if (isset($msgOptions['subject']))
2196 2302
 	{
@@ -2204,14 +2310,16 @@  discard block
 block discarded – undo
2204 2310
 				'id_first_msg' => $msgOptions['id'],
2205 2311
 			)
2206 2312
 		);
2207
-		if ($smcFunc['db_num_rows']($request) == 1)
2208
-			updateStats('subject', $topicOptions['id'], $msgOptions['subject']);
2313
+		if ($smcFunc['db_num_rows']($request) == 1) {
2314
+					updateStats('subject', $topicOptions['id'], $msgOptions['subject']);
2315
+		}
2209 2316
 		$smcFunc['db_free_result']($request);
2210 2317
 	}
2211 2318
 
2212 2319
 	// Finally, if we are setting the approved state we need to do much more work :(
2213
-	if ($modSettings['postmod_active'] && isset($msgOptions['approved']))
2214
-		approvePosts($msgOptions['id'], $msgOptions['approved']);
2320
+	if ($modSettings['postmod_active'] && isset($msgOptions['approved'])) {
2321
+			approvePosts($msgOptions['id'], $msgOptions['approved']);
2322
+	}
2215 2323
 
2216 2324
 	return true;
2217 2325
 }
@@ -2228,11 +2336,13 @@  discard block
 block discarded – undo
2228 2336
 {
2229 2337
 	global $smcFunc;
2230 2338
 
2231
-	if (!is_array($msgs))
2232
-		$msgs = array($msgs);
2339
+	if (!is_array($msgs)) {
2340
+			$msgs = array($msgs);
2341
+	}
2233 2342
 
2234
-	if (empty($msgs))
2235
-		return false;
2343
+	if (empty($msgs)) {
2344
+			return false;
2345
+	}
2236 2346
 
2237 2347
 	// May as well start at the beginning, working out *what* we need to change.
2238 2348
 	$request = $smcFunc['db_query']('', '
@@ -2264,20 +2374,22 @@  discard block
 block discarded – undo
2264 2374
 		$topics[] = $row['id_topic'];
2265 2375
 
2266 2376
 		// Ensure our change array exists already.
2267
-		if (!isset($topic_changes[$row['id_topic']]))
2268
-			$topic_changes[$row['id_topic']] = array(
2377
+		if (!isset($topic_changes[$row['id_topic']])) {
2378
+					$topic_changes[$row['id_topic']] = array(
2269 2379
 				'id_last_msg' => $row['id_last_msg'],
2270 2380
 				'approved' => $row['topic_approved'],
2271 2381
 				'replies' => 0,
2272 2382
 				'unapproved_posts' => 0,
2273 2383
 			);
2274
-		if (!isset($board_changes[$row['id_board']]))
2275
-			$board_changes[$row['id_board']] = array(
2384
+		}
2385
+		if (!isset($board_changes[$row['id_board']])) {
2386
+					$board_changes[$row['id_board']] = array(
2276 2387
 				'posts' => 0,
2277 2388
 				'topics' => 0,
2278 2389
 				'unapproved_posts' => 0,
2279 2390
 				'unapproved_topics' => 0,
2280 2391
 			);
2392
+		}
2281 2393
 
2282 2394
 		// If it's the first message then the topic state changes!
2283 2395
 		if ($row['id_msg'] == $row['id_first_msg'])
@@ -2298,14 +2410,13 @@  discard block
 block discarded – undo
2298 2410
 				'poster' => $row['id_member'],
2299 2411
 				'new_topic' => true,
2300 2412
 			);
2301
-		}
2302
-		else
2413
+		} else
2303 2414
 		{
2304 2415
 			$topic_changes[$row['id_topic']]['replies'] += $approve ? 1 : -1;
2305 2416
 
2306 2417
 			// This will be a post... but don't notify unless it's not followed by approved ones.
2307
-			if ($row['id_msg'] > $row['id_last_msg'])
2308
-				$notification_posts[$row['id_topic']] = array(
2418
+			if ($row['id_msg'] > $row['id_last_msg']) {
2419
+							$notification_posts[$row['id_topic']] = array(
2309 2420
 					'id' => $row['id_msg'],
2310 2421
 					'body' => $row['body'],
2311 2422
 					'subject' => $row['subject'],
@@ -2316,28 +2427,33 @@  discard block
 block discarded – undo
2316 2427
 					'new_topic' => false,
2317 2428
 					'msg' => $row['id_msg'],
2318 2429
 				);
2430
+			}
2319 2431
 		}
2320 2432
 
2321 2433
 		// If this is being approved and id_msg is higher than the current id_last_msg then it changes.
2322
-		if ($approve && $row['id_msg'] > $topic_changes[$row['id_topic']]['id_last_msg'])
2323
-			$topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_msg'];
2434
+		if ($approve && $row['id_msg'] > $topic_changes[$row['id_topic']]['id_last_msg']) {
2435
+					$topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_msg'];
2436
+		}
2324 2437
 		// If this is being unapproved, and it's equal to the id_last_msg we need to find a new one!
2325
-		elseif (!$approve)
2326
-			// Default to the first message and then we'll override in a bit ;)
2438
+		elseif (!$approve) {
2439
+					// Default to the first message and then we'll override in a bit ;)
2327 2440
 			$topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_first_msg'];
2441
+		}
2328 2442
 
2329 2443
 		$topic_changes[$row['id_topic']]['unapproved_posts'] += $approve ? -1 : 1;
2330 2444
 		$board_changes[$row['id_board']]['unapproved_posts'] += $approve ? -1 : 1;
2331 2445
 		$board_changes[$row['id_board']]['posts'] += $approve ? 1 : -1;
2332 2446
 
2333 2447
 		// Post count for the user?
2334
-		if ($row['id_member'] && empty($row['count_posts']))
2335
-			$member_post_changes[$row['id_member']] = isset($member_post_changes[$row['id_member']]) ? $member_post_changes[$row['id_member']] + 1 : 1;
2448
+		if ($row['id_member'] && empty($row['count_posts'])) {
2449
+					$member_post_changes[$row['id_member']] = isset($member_post_changes[$row['id_member']]) ? $member_post_changes[$row['id_member']] + 1 : 1;
2450
+		}
2336 2451
 	}
2337 2452
 	$smcFunc['db_free_result']($request);
2338 2453
 
2339
-	if (empty($msgs))
2340
-		return;
2454
+	if (empty($msgs)) {
2455
+			return;
2456
+	}
2341 2457
 
2342 2458
 	// Now we have the differences make the changes, first the easy one.
2343 2459
 	$smcFunc['db_query']('', '
@@ -2364,14 +2480,15 @@  discard block
 block discarded – undo
2364 2480
 				'approved' => 1,
2365 2481
 			)
2366 2482
 		);
2367
-		while ($row = $smcFunc['db_fetch_assoc']($request))
2368
-			$topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_last_msg'];
2483
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
2484
+					$topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_last_msg'];
2485
+		}
2369 2486
 		$smcFunc['db_free_result']($request);
2370 2487
 	}
2371 2488
 
2372 2489
 	// ... next the topics...
2373
-	foreach ($topic_changes as $id => $changes)
2374
-		$smcFunc['db_query']('', '
2490
+	foreach ($topic_changes as $id => $changes) {
2491
+			$smcFunc['db_query']('', '
2375 2492
 			UPDATE {db_prefix}topics
2376 2493
 			SET approved = {int:approved}, unapproved_posts = unapproved_posts + {int:unapproved_posts},
2377 2494
 				num_replies = num_replies + {int:num_replies}, id_last_msg = {int:id_last_msg}
@@ -2384,10 +2501,11 @@  discard block
 block discarded – undo
2384 2501
 				'id_topic' => $id,
2385 2502
 			)
2386 2503
 		);
2504
+	}
2387 2505
 
2388 2506
 	// ... finally the boards...
2389
-	foreach ($board_changes as $id => $changes)
2390
-		$smcFunc['db_query']('', '
2507
+	foreach ($board_changes as $id => $changes) {
2508
+			$smcFunc['db_query']('', '
2391 2509
 			UPDATE {db_prefix}boards
2392 2510
 			SET num_posts = num_posts + {int:num_posts}, unapproved_posts = unapproved_posts + {int:unapproved_posts},
2393 2511
 				num_topics = num_topics + {int:num_topics}, unapproved_topics = unapproved_topics + {int:unapproved_topics}
@@ -2400,13 +2518,14 @@  discard block
 block discarded – undo
2400 2518
 				'id_board' => $id,
2401 2519
 			)
2402 2520
 		);
2521
+	}
2403 2522
 
2404 2523
 	// Finally, least importantly, notifications!
2405 2524
 	if ($approve)
2406 2525
 	{
2407 2526
 		$task_rows = array();
2408
-		foreach (array_merge($notification_topics, $notification_posts) as $topic)
2409
-			$task_rows[] = array(
2527
+		foreach (array_merge($notification_topics, $notification_posts) as $topic) {
2528
+					$task_rows[] = array(
2410 2529
 				'$sourcedir/tasks/CreatePost-Notify.php', 'CreatePost_Notify_Background', $smcFunc['json_encode'](array(
2411 2530
 					'msgOptions' => array(
2412 2531
 						'id' => $topic['msg'],
@@ -2424,14 +2543,16 @@  discard block
 block discarded – undo
2424 2543
 					'type' => $topic['new_topic'] ? 'topic' : 'reply',
2425 2544
 				)), 0
2426 2545
 			);
2546
+		}
2427 2547
 
2428
-		if ($notify)
2429
-			$smcFunc['db_insert']('',
2548
+		if ($notify) {
2549
+					$smcFunc['db_insert']('',
2430 2550
 				'{db_prefix}background_tasks',
2431 2551
 				array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'),
2432 2552
 				$task_rows,
2433 2553
 				array('id_task')
2434 2554
 			);
2555
+		}
2435 2556
 
2436 2557
 		$smcFunc['db_query']('', '
2437 2558
 			DELETE FROM {db_prefix}approval_queue
@@ -2447,8 +2568,9 @@  discard block
 block discarded – undo
2447 2568
 	else
2448 2569
 	{
2449 2570
 		$msgInserts = array();
2450
-		foreach ($msgs as $msg)
2451
-			$msgInserts[] = array($msg);
2571
+		foreach ($msgs as $msg) {
2572
+					$msgInserts[] = array($msg);
2573
+		}
2452 2574
 
2453 2575
 		$smcFunc['db_insert']('ignore',
2454 2576
 			'{db_prefix}approval_queue',
@@ -2462,9 +2584,10 @@  discard block
 block discarded – undo
2462 2584
 	updateLastMessages(array_keys($board_changes));
2463 2585
 
2464 2586
 	// Post count for the members?
2465
-	if (!empty($member_post_changes))
2466
-		foreach ($member_post_changes as $id_member => $count_change)
2587
+	if (!empty($member_post_changes)) {
2588
+			foreach ($member_post_changes as $id_member => $count_change)
2467 2589
 			updateMemberData($id_member, array('posts' => 'posts ' . ($approve ? '+' : '-') . ' ' . $count_change));
2590
+	}
2468 2591
 
2469 2592
 	return true;
2470 2593
 }
@@ -2481,11 +2604,13 @@  discard block
 block discarded – undo
2481 2604
 {
2482 2605
 	global $smcFunc;
2483 2606
 
2484
-	if (!is_array($topics))
2485
-		$topics = array($topics);
2607
+	if (!is_array($topics)) {
2608
+			$topics = array($topics);
2609
+	}
2486 2610
 
2487
-	if (empty($topics))
2488
-		return false;
2611
+	if (empty($topics)) {
2612
+			return false;
2613
+	}
2489 2614
 
2490 2615
 	$approve_type = $approve ? 0 : 1;
2491 2616
 
@@ -2501,8 +2626,9 @@  discard block
 block discarded – undo
2501 2626
 		)
2502 2627
 	);
2503 2628
 	$msgs = array();
2504
-	while ($row = $smcFunc['db_fetch_assoc']($request))
2505
-		$msgs[] = $row['id_msg'];
2629
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2630
+			$msgs[] = $row['id_msg'];
2631
+	}
2506 2632
 	$smcFunc['db_free_result']($request);
2507 2633
 
2508 2634
 	return approvePosts($msgs, $approve);
@@ -2525,11 +2651,13 @@  discard block
 block discarded – undo
2525 2651
 	global $board_info, $board, $smcFunc;
2526 2652
 
2527 2653
 	// Please - let's be sane.
2528
-	if (empty($setboards))
2529
-		return false;
2654
+	if (empty($setboards)) {
2655
+			return false;
2656
+	}
2530 2657
 
2531
-	if (!is_array($setboards))
2532
-		$setboards = array($setboards);
2658
+	if (!is_array($setboards)) {
2659
+			$setboards = array($setboards);
2660
+	}
2533 2661
 
2534 2662
 	// If we don't know the id_msg we need to find it.
2535 2663
 	if (!$id_msg)
@@ -2547,15 +2675,16 @@  discard block
 block discarded – undo
2547 2675
 			)
2548 2676
 		);
2549 2677
 		$lastMsg = array();
2550
-		while ($row = $smcFunc['db_fetch_assoc']($request))
2551
-			$lastMsg[$row['id_board']] = $row['id_msg'];
2678
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
2679
+					$lastMsg[$row['id_board']] = $row['id_msg'];
2680
+		}
2552 2681
 		$smcFunc['db_free_result']($request);
2553
-	}
2554
-	else
2682
+	} else
2555 2683
 	{
2556 2684
 		// Just to note - there should only be one board passed if we are doing this.
2557
-		foreach ($setboards as $id_board)
2558
-			$lastMsg[$id_board] = $id_msg;
2685
+		foreach ($setboards as $id_board) {
2686
+					$lastMsg[$id_board] = $id_msg;
2687
+		}
2559 2688
 	}
2560 2689
 
2561 2690
 	$parent_boards = array();
@@ -2570,10 +2699,11 @@  discard block
 block discarded – undo
2570 2699
 			$lastModified[$id_board] = 0;
2571 2700
 		}
2572 2701
 
2573
-		if (!empty($board) && $id_board == $board)
2574
-			$parents = $board_info['parent_boards'];
2575
-		else
2576
-			$parents = getBoardParents($id_board);
2702
+		if (!empty($board) && $id_board == $board) {
2703
+					$parents = $board_info['parent_boards'];
2704
+		} else {
2705
+					$parents = getBoardParents($id_board);
2706
+		}
2577 2707
 
2578 2708
 		// Ignore any parents on the top child level.
2579 2709
 		// @todo Why?
@@ -2582,10 +2712,11 @@  discard block
 block discarded – undo
2582 2712
 			if ($parent['level'] != 0)
2583 2713
 			{
2584 2714
 				// If we're already doing this one as a board, is this a higher last modified?
2585
-				if (isset($lastModified[$id]) && $lastModified[$id_board] > $lastModified[$id])
2586
-					$lastModified[$id] = $lastModified[$id_board];
2587
-				elseif (!isset($lastModified[$id]) && (!isset($parent_boards[$id]) || $parent_boards[$id] < $lastModified[$id_board]))
2588
-					$parent_boards[$id] = $lastModified[$id_board];
2715
+				if (isset($lastModified[$id]) && $lastModified[$id_board] > $lastModified[$id]) {
2716
+									$lastModified[$id] = $lastModified[$id_board];
2717
+				} elseif (!isset($lastModified[$id]) && (!isset($parent_boards[$id]) || $parent_boards[$id] < $lastModified[$id_board])) {
2718
+									$parent_boards[$id] = $lastModified[$id_board];
2719
+				}
2589 2720
 			}
2590 2721
 		}
2591 2722
 	}
@@ -2598,23 +2729,24 @@  discard block
 block discarded – undo
2598 2729
 	// Finally, to save on queries make the changes...
2599 2730
 	foreach ($parent_boards as $id => $msg)
2600 2731
 	{
2601
-		if (!isset($parent_updates[$msg]))
2602
-			$parent_updates[$msg] = array($id);
2603
-		else
2604
-			$parent_updates[$msg][] = $id;
2732
+		if (!isset($parent_updates[$msg])) {
2733
+					$parent_updates[$msg] = array($id);
2734
+		} else {
2735
+					$parent_updates[$msg][] = $id;
2736
+		}
2605 2737
 	}
2606 2738
 
2607 2739
 	foreach ($lastMsg as $id => $msg)
2608 2740
 	{
2609
-		if (!isset($board_updates[$msg . '-' . $lastModified[$id]]))
2610
-			$board_updates[$msg . '-' . $lastModified[$id]] = array(
2741
+		if (!isset($board_updates[$msg . '-' . $lastModified[$id]])) {
2742
+					$board_updates[$msg . '-' . $lastModified[$id]] = array(
2611 2743
 				'id' => $msg,
2612 2744
 				'updated' => $lastModified[$id],
2613 2745
 				'boards' => array($id)
2614 2746
 			);
2615
-
2616
-		else
2617
-			$board_updates[$msg . '-' . $lastModified[$id]]['boards'][] = $id;
2747
+		} else {
2748
+					$board_updates[$msg . '-' . $lastModified[$id]]['boards'][] = $id;
2749
+		}
2618 2750
 	}
2619 2751
 
2620 2752
 	// Now commit the changes!
@@ -2706,11 +2838,13 @@  discard block
 block discarded – undo
2706 2838
 	global $txt, $mbname, $scripturl, $settings;
2707 2839
 
2708 2840
 	// First things first, load up the email templates language file, if we need to.
2709
-	if ($loadLang)
2710
-		loadLanguage('EmailTemplates', $lang);
2841
+	if ($loadLang) {
2842
+			loadLanguage('EmailTemplates', $lang);
2843
+	}
2711 2844
 
2712
-	if (!isset($txt[$template . '_subject']) || !isset($txt[$template . '_body']))
2713
-		fatal_lang_error('email_no_template', 'template', array($template));
2845
+	if (!isset($txt[$template . '_subject']) || !isset($txt[$template . '_body'])) {
2846
+			fatal_lang_error('email_no_template', 'template', array($template));
2847
+	}
2714 2848
 
2715 2849
 	$ret = array(
2716 2850
 		'subject' => $txt[$template . '_subject'],
@@ -2760,17 +2894,18 @@  discard block
 block discarded – undo
2760 2894
 function user_info_callback($matches)
2761 2895
 {
2762 2896
 	global $user_info;
2763
-	if (empty($matches[1]))
2764
-		return '';
2897
+	if (empty($matches[1])) {
2898
+			return '';
2899
+	}
2765 2900
 
2766 2901
 	$use_ref = true;
2767 2902
 	$ref = &$user_info;
2768 2903
 
2769 2904
 	foreach (explode('.', $matches[1]) as $index)
2770 2905
 	{
2771
-		if ($use_ref && isset($ref[$index]))
2772
-			$ref = &$ref[$index];
2773
-		else
2906
+		if ($use_ref && isset($ref[$index])) {
2907
+					$ref = &$ref[$index];
2908
+		} else
2774 2909
 		{
2775 2910
 			$use_ref = false;
2776 2911
 			break;
@@ -2807,8 +2942,7 @@  discard block
 block discarded – undo
2807 2942
 		if (!empty($lang_locale) && enchant_broker_dict_exists($context['enchant_broker'], $lang_locale))
2808 2943
 		{
2809 2944
 			$enchant_link = enchant_broker_request_dict($context['enchant_broker'], $lang_locale);
2810
-		}
2811
-		elseif (enchant_broker_dict_exists($context['enchant_broker'], $txt['lang_dictionary']))
2945
+		} elseif (enchant_broker_dict_exists($context['enchant_broker'], $txt['lang_dictionary']))
2812 2946
 		{
2813 2947
 			$enchant_link = enchant_broker_request_dict($context['enchant_broker'], $txt['lang_dictionary']);
2814 2948
 		}
@@ -2818,8 +2952,7 @@  discard block
 block discarded – undo
2818 2952
 		{
2819 2953
 			$context['provider'] = 'enchant';
2820 2954
 			return $enchant_link;
2821
-		}
2822
-		else
2955
+		} else
2823 2956
 		{
2824 2957
 			// Free up any resources used...
2825 2958
 			@enchant_broker_free($context['enchant_broker']);
@@ -2840,8 +2973,9 @@  discard block
 block discarded – undo
2840 2973
 		$pspell_link = pspell_new($txt['lang_dictionary'], $txt['lang_spelling'], '', strtr($context['character_set'], array('iso-' => 'iso', 'ISO-' => 'iso')), PSPELL_FAST | PSPELL_RUN_TOGETHER);
2841 2974
 
2842 2975
 		// Most people don't have anything but English installed... So we use English as a last resort.
2843
-		if (!$pspell_link)
2844
-			$pspell_link = pspell_new('en', '', '', '', PSPELL_FAST | PSPELL_RUN_TOGETHER);
2976
+		if (!$pspell_link) {
2977
+					$pspell_link = pspell_new('en', '', '', '', PSPELL_FAST | PSPELL_RUN_TOGETHER);
2978
+		}
2845 2979
 
2846 2980
 		error_reporting($old);
2847 2981
 		ob_end_clean();
@@ -2881,8 +3015,7 @@  discard block
 block discarded – undo
2881 3015
 			$word = iconv($txt['lang_character_set'], 'UTF-8', $word);
2882 3016
 		}
2883 3017
 		return enchant_dict_check($dict, $word);
2884
-	}
2885
-	elseif ($context['provider'] == 'pspell')
3018
+	} elseif ($context['provider'] == 'pspell')
2886 3019
 	{
2887 3020
 		return pspell_check($dict, $word);
2888 3021
 	}
@@ -2918,13 +3051,11 @@  discard block
 block discarded – undo
2918 3051
 			}
2919 3052
 
2920 3053
 			return $suggestions;
2921
-		}
2922
-		else
3054
+		} else
2923 3055
 		{
2924 3056
 			return enchant_dict_suggest($dict, $word);
2925 3057
 		}
2926
-	}
2927
-	elseif ($context['provider'] == 'pspell')
3058
+	} elseif ($context['provider'] == 'pspell')
2928 3059
 	{
2929 3060
 		return pspell_suggest($dict, $word);
2930 3061
 	}
Please login to merge, or discard this patch.
Sources/Post.php 1 patch
Braces   +674 added lines, -521 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Handles showing the post screen, loading the post to be modified, and loading any post quoted.
@@ -35,12 +36,14 @@  discard block
 block discarded – undo
35 36
 	global $sourcedir, $smcFunc, $language;
36 37
 
37 38
 	loadLanguage('Post');
38
-	if (!empty($modSettings['drafts_post_enabled']))
39
-		loadLanguage('Drafts');
39
+	if (!empty($modSettings['drafts_post_enabled'])) {
40
+			loadLanguage('Drafts');
41
+	}
40 42
 
41 43
 	// You can't reply with a poll... hacker.
42
-	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg']))
43
-		unset($_REQUEST['poll']);
44
+	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg'])) {
45
+			unset($_REQUEST['poll']);
46
+	}
44 47
 
45 48
 	// Posting an event?
46 49
 	$context['make_event'] = isset($_REQUEST['calendar']);
@@ -58,12 +61,14 @@  discard block
 block discarded – undo
58 61
 	{
59 62
 		// Get ids of all the boards they can post in.
60 63
 		$post_permissions = array('post_new');
61
-		if ($modSettings['postmod_active'])
62
-			$post_permissions[] = 'post_unapproved_topics';
64
+		if ($modSettings['postmod_active']) {
65
+					$post_permissions[] = 'post_unapproved_topics';
66
+		}
63 67
 
64 68
 		$boards = boardsAllowedTo($post_permissions);
65
-		if (empty($boards))
66
-			fatal_lang_error('cannot_post_new', false);
69
+		if (empty($boards)) {
70
+					fatal_lang_error('cannot_post_new', false);
71
+		}
67 72
 
68 73
 		// Get a list of boards for the select menu
69 74
 		require_once($sourcedir . '/Subs-MessageIndex.php');
@@ -76,8 +81,9 @@  discard block
 block discarded – undo
76 81
 		$board_list = getBoardList($boardListOptions);
77 82
 	}
78 83
 	// Let's keep things simple for ourselves below
79
-	else
80
-		$boards = array($board);
84
+	else {
85
+			$boards = array($board);
86
+	}
81 87
 
82 88
 	require_once($sourcedir . '/Subs-Post.php');
83 89
 
@@ -100,10 +106,11 @@  discard block
 block discarded – undo
100 106
 			array(
101 107
 				'msg' => (int) $_REQUEST['msg'],
102 108
 		));
103
-		if ($smcFunc['db_num_rows']($request) != 1)
104
-			unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
105
-		else
106
-			list ($topic) = $smcFunc['db_fetch_row']($request);
109
+		if ($smcFunc['db_num_rows']($request) != 1) {
110
+					unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
111
+		} else {
112
+					list ($topic) = $smcFunc['db_fetch_row']($request);
113
+		}
107 114
 		$smcFunc['db_free_result']($request);
108 115
 	}
109 116
 
@@ -130,33 +137,36 @@  discard block
 block discarded – undo
130 137
 		$smcFunc['db_free_result']($request);
131 138
 
132 139
 		// If this topic already has a poll, they sure can't add another.
133
-		if (isset($_REQUEST['poll']) && $pollID > 0)
134
-			unset($_REQUEST['poll']);
140
+		if (isset($_REQUEST['poll']) && $pollID > 0) {
141
+					unset($_REQUEST['poll']);
142
+		}
135 143
 
136 144
 		if (empty($_REQUEST['msg']))
137 145
 		{
138
-			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any')))
139
-				is_not_guest();
146
+			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any'))) {
147
+							is_not_guest();
148
+			}
140 149
 
141 150
 			// By default the reply will be approved...
142 151
 			$context['becomes_approved'] = true;
143 152
 			if ($id_member_poster != $user_info['id'] || $user_info['is_guest'])
144 153
 			{
145
-				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
146
-					$context['becomes_approved'] = false;
147
-				else
148
-					isAllowedTo('post_reply_any');
149
-			}
150
-			elseif (!allowedTo('post_reply_any'))
154
+				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
155
+									$context['becomes_approved'] = false;
156
+				} else {
157
+									isAllowedTo('post_reply_any');
158
+				}
159
+			} elseif (!allowedTo('post_reply_any'))
151 160
 			{
152
-				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any')))
153
-					$context['becomes_approved'] = false;
154
-				else
155
-					isAllowedTo('post_reply_own');
161
+				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any'))) {
162
+									$context['becomes_approved'] = false;
163
+				} else {
164
+									isAllowedTo('post_reply_own');
165
+				}
156 166
 			}
167
+		} else {
168
+					$context['becomes_approved'] = true;
157 169
 		}
158
-		else
159
-			$context['becomes_approved'] = true;
160 170
 
161 171
 		$context['can_lock'] = allowedTo('lock_any') || ($user_info['id'] == $id_member_poster && allowedTo('lock_own'));
162 172
 		$context['can_sticky'] = allowedTo('make_sticky');
@@ -171,17 +181,18 @@  discard block
 block discarded – undo
171 181
 		$context['sticky'] = isset($_REQUEST['sticky']) ? !empty($_REQUEST['sticky']) : $sticky;
172 182
 
173 183
 		// Check whether this is a really old post being bumped...
174
-		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject']))
175
-			$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
176
-	}
177
-	else
184
+		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject'])) {
185
+					$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
186
+		}
187
+	} else
178 188
 	{
179 189
 		// @todo Should use JavaScript to hide and show the warning based on the selection in the board select menu
180 190
 		$context['becomes_approved'] = true;
181
-		if ($modSettings['postmod_active'] && !allowedTo('post_new', $boards, true) && allowedTo('post_unapproved_topics', $boards, true))
182
-			$context['becomes_approved'] = false;
183
-		else
184
-			isAllowedTo('post_new', $boards, true);
191
+		if ($modSettings['postmod_active'] && !allowedTo('post_new', $boards, true) && allowedTo('post_unapproved_topics', $boards, true)) {
192
+					$context['becomes_approved'] = false;
193
+		} else {
194
+					isAllowedTo('post_new', $boards, true);
195
+		}
185 196
 
186 197
 		$locked = 0;
187 198
 		$context['already_locked'] = 0;
@@ -211,27 +222,32 @@  discard block
 block discarded – undo
211 222
 	if (empty($_REQUEST['message']) && empty($_REQUEST['preview']) && !empty($_SESSION['already_attached']))
212 223
 	{
213 224
 		require_once($sourcedir . '/ManageAttachments.php');
214
-		foreach ($_SESSION['already_attached'] as $attachID => $attachment)
215
-			removeAttachments(array('id_attach' => $attachID));
225
+		foreach ($_SESSION['already_attached'] as $attachID => $attachment) {
226
+					removeAttachments(array('id_attach' => $attachID));
227
+		}
216 228
 
217 229
 		unset($_SESSION['already_attached']);
218 230
 	}
219 231
 
220 232
 	// Don't allow a post if it's locked and you aren't all powerful.
221
-	if ($locked && !allowedTo('moderate_board'))
222
-		fatal_lang_error('topic_locked', false);
233
+	if ($locked && !allowedTo('moderate_board')) {
234
+			fatal_lang_error('topic_locked', false);
235
+	}
223 236
 	// Check the users permissions - is the user allowed to add or post a poll?
224 237
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
225 238
 	{
226 239
 		// New topic, new poll.
227
-		if (empty($topic))
228
-			isAllowedTo('poll_post');
240
+		if (empty($topic)) {
241
+					isAllowedTo('poll_post');
242
+		}
229 243
 		// This is an old topic - but it is yours!  Can you add to it?
230
-		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any'))
231
-			isAllowedTo('poll_add_own');
244
+		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any')) {
245
+					isAllowedTo('poll_add_own');
246
+		}
232 247
 		// If you're not the owner, can you add to any poll?
233
-		else
234
-			isAllowedTo('poll_add_any');
248
+		else {
249
+					isAllowedTo('poll_add_any');
250
+		}
235 251
 
236 252
 		if (!empty($board))
237 253
 		{
@@ -240,8 +256,9 @@  discard block
 block discarded – undo
240 256
 			$guest_vote_enabled = in_array(-1, $allowedVoteGroups['allowed']);
241 257
 		}
242 258
 		// No board, so we'll have to check this again in Post2
243
-		else
244
-			$guest_vote_enabled = true;
259
+		else {
260
+					$guest_vote_enabled = true;
261
+		}
245 262
 
246 263
 		// Set up the poll options.
247 264
 		$context['poll_options'] = array(
@@ -267,8 +284,9 @@  discard block
 block discarded – undo
267 284
 	if ($context['make_event'])
268 285
 	{
269 286
 		// They might want to pick a board.
270
-		if (!isset($context['current_board']))
271
-			$context['current_board'] = 0;
287
+		if (!isset($context['current_board'])) {
288
+					$context['current_board'] = 0;
289
+		}
272 290
 
273 291
 		// Start loading up the event info.
274 292
 		$context['event'] = array();
@@ -282,10 +300,11 @@  discard block
 block discarded – undo
282 300
 		isAllowedTo('calendar_post');
283 301
 
284 302
 		// We want a fairly compact version of the time, but as close as possible to the user's settings.
285
-		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
286
-			$time_string = '%k:%M';
287
-		else
288
-			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
303
+		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
304
+					$time_string = '%k:%M';
305
+		} else {
306
+					$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
307
+		}
289 308
 
290 309
 		$js_time_string = str_replace(
291 310
 			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
@@ -307,8 +326,7 @@  discard block
 block discarded – undo
307 326
 			require_once($sourcedir . '/Subs-Calendar.php');
308 327
 			$eventProperties = getEventProperties($context['event']['id']);
309 328
 			$context['event'] = array_merge($context['event'], $eventProperties);
310
-		}
311
-		else
329
+		} else
312 330
 		{
313 331
 			// Get the current event information.
314 332
 			require_once($sourcedir . '/Subs-Calendar.php');
@@ -316,10 +334,12 @@  discard block
 block discarded – undo
316 334
 			$context['event'] = array_merge($context['event'], $eventProperties);
317 335
 
318 336
 			// Make sure the year and month are in the valid range.
319
-			if ($context['event']['month'] < 1 || $context['event']['month'] > 12)
320
-				fatal_lang_error('invalid_month', false);
321
-			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear'])
322
-				fatal_lang_error('invalid_year', false);
337
+			if ($context['event']['month'] < 1 || $context['event']['month'] > 12) {
338
+							fatal_lang_error('invalid_month', false);
339
+			}
340
+			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear']) {
341
+							fatal_lang_error('invalid_year', false);
342
+			}
323 343
 
324 344
 			$context['event']['categories'] = $board_list;
325 345
 		}
@@ -430,10 +450,11 @@  discard block
 block discarded – undo
430 450
 
431 451
 			if (!empty($context['new_replies']))
432 452
 			{
433
-				if ($context['new_replies'] == 1)
434
-					$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
435
-				else
436
-					$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
453
+				if ($context['new_replies'] == 1) {
454
+									$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
455
+				} else {
456
+									$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
457
+				}
437 458
 
438 459
 				$post_errors[] = 'new_replies';
439 460
 
@@ -445,9 +466,9 @@  discard block
 block discarded – undo
445 466
 	// Get a response prefix (like 'Re:') in the default forum language.
446 467
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
447 468
 	{
448
-		if ($language === $user_info['language'])
449
-			$context['response_prefix'] = $txt['response_prefix'];
450
-		else
469
+		if ($language === $user_info['language']) {
470
+					$context['response_prefix'] = $txt['response_prefix'];
471
+		} else
451 472
 		{
452 473
 			loadLanguage('index', $language, false);
453 474
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -460,23 +481,26 @@  discard block
 block discarded – undo
460 481
 	// Do we have a body, but an error happened.
461 482
 	if (isset($_REQUEST['message']) || isset($_REQUEST['quickReply']) || !empty($context['post_error']))
462 483
 	{
463
-		if (isset($_REQUEST['quickReply']))
464
-			$_REQUEST['message'] = $_REQUEST['quickReply'];
484
+		if (isset($_REQUEST['quickReply'])) {
485
+					$_REQUEST['message'] = $_REQUEST['quickReply'];
486
+		}
465 487
 
466 488
 		// Validate inputs.
467 489
 		if (empty($context['post_error']))
468 490
 		{
469 491
 			// This means they didn't click Post and get an error.
470 492
 			$really_previewing = true;
471
-		}
472
-		else
493
+		} else
473 494
 		{
474
-			if (!isset($_REQUEST['subject']))
475
-				$_REQUEST['subject'] = '';
476
-			if (!isset($_REQUEST['message']))
477
-				$_REQUEST['message'] = '';
478
-			if (!isset($_REQUEST['icon']))
479
-				$_REQUEST['icon'] = 'xx';
495
+			if (!isset($_REQUEST['subject'])) {
496
+							$_REQUEST['subject'] = '';
497
+			}
498
+			if (!isset($_REQUEST['message'])) {
499
+							$_REQUEST['message'] = '';
500
+			}
501
+			if (!isset($_REQUEST['icon'])) {
502
+							$_REQUEST['icon'] = 'xx';
503
+			}
480 504
 
481 505
 			// They are previewing if they asked to preview (i.e. came from quick reply).
482 506
 			$really_previewing = !empty($_POST['preview']);
@@ -492,8 +516,9 @@  discard block
 block discarded – undo
492 516
 		$form_message = $smcFunc['htmlspecialchars']($_REQUEST['message'], ENT_QUOTES);
493 517
 
494 518
 		// Make sure the subject isn't too long - taking into account special characters.
495
-		if ($smcFunc['strlen']($form_subject) > 100)
496
-			$form_subject = $smcFunc['substr']($form_subject, 0, 100);
519
+		if ($smcFunc['strlen']($form_subject) > 100) {
520
+					$form_subject = $smcFunc['substr']($form_subject, 0, 100);
521
+		}
497 522
 
498 523
 		if (isset($_REQUEST['poll']))
499 524
 		{
@@ -505,8 +530,9 @@  discard block
 block discarded – undo
505 530
 			$_POST['options'] = empty($_POST['options']) ? array() : htmlspecialchars__recursive($_POST['options']);
506 531
 			foreach ($_POST['options'] as $option)
507 532
 			{
508
-				if (trim($option) == '')
509
-					continue;
533
+				if (trim($option) == '') {
534
+									continue;
535
+				}
510 536
 
511 537
 				$context['choices'][] = array(
512 538
 					'id' => $choice_id++,
@@ -568,13 +594,14 @@  discard block
 block discarded – undo
568 594
 				$context['preview_subject'] = $form_subject;
569 595
 
570 596
 				censorText($context['preview_subject']);
597
+			} else {
598
+							$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
571 599
 			}
572
-			else
573
-				$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
574 600
 
575 601
 			// Protect any CDATA blocks.
576
-			if (isset($_REQUEST['xml']))
577
-				$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
602
+			if (isset($_REQUEST['xml'])) {
603
+							$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
604
+			}
578 605
 		}
579 606
 
580 607
 		// Set up the checkboxes.
@@ -613,29 +640,32 @@  discard block
 block discarded – undo
613 640
 			);
614 641
 			// The message they were trying to edit was most likely deleted.
615 642
 			// @todo Change this error message?
616
-			if ($smcFunc['db_num_rows']($request) == 0)
617
-				fatal_lang_error('no_board', false);
643
+			if ($smcFunc['db_num_rows']($request) == 0) {
644
+							fatal_lang_error('no_board', false);
645
+			}
618 646
 			$row = $smcFunc['db_fetch_assoc']($request);
619 647
 
620 648
 			$attachment_stuff = array($row);
621
-			while ($row2 = $smcFunc['db_fetch_assoc']($request))
622
-				$attachment_stuff[] = $row2;
649
+			while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
650
+							$attachment_stuff[] = $row2;
651
+			}
623 652
 			$smcFunc['db_free_result']($request);
624 653
 
625 654
 			if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
626 655
 			{
627 656
 				// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
628
-				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
629
-					fatal_lang_error('modify_post_time_passed', false);
630
-				elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
631
-					isAllowedTo('modify_replies');
632
-				else
633
-					isAllowedTo('modify_own');
657
+				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
658
+									fatal_lang_error('modify_post_time_passed', false);
659
+				} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
660
+									isAllowedTo('modify_replies');
661
+				} else {
662
+									isAllowedTo('modify_own');
663
+				}
664
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
665
+							isAllowedTo('modify_replies');
666
+			} else {
667
+							isAllowedTo('modify_any');
634 668
 			}
635
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
636
-				isAllowedTo('modify_replies');
637
-			else
638
-				isAllowedTo('modify_any');
639 669
 
640 670
 			if ($context['can_announce'] && !empty($row['id_action']))
641 671
 			{
@@ -659,8 +689,9 @@  discard block
 block discarded – undo
659 689
 
660 690
 				while ($row = $smcFunc['db_fetch_assoc']($request))
661 691
 				{
662
-					if ($row['filesize'] <= 0)
663
-						continue;
692
+					if ($row['filesize'] <= 0) {
693
+											continue;
694
+					}
664 695
 					$context['current_attachments'][$row['id_attach']] = array(
665 696
 						'name' => $smcFunc['htmlspecialchars']($row['filename']),
666 697
 						'size' => $row['filesize'],
@@ -730,29 +761,32 @@  discard block
 block discarded – undo
730 761
 			)
731 762
 		);
732 763
 		// The message they were trying to edit was most likely deleted.
733
-		if ($smcFunc['db_num_rows']($request) == 0)
734
-			fatal_lang_error('no_message', false);
764
+		if ($smcFunc['db_num_rows']($request) == 0) {
765
+					fatal_lang_error('no_message', false);
766
+		}
735 767
 		$row = $smcFunc['db_fetch_assoc']($request);
736 768
 
737 769
 		$attachment_stuff = array($row);
738
-		while ($row2 = $smcFunc['db_fetch_assoc']($request))
739
-			$attachment_stuff[] = $row2;
770
+		while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
771
+					$attachment_stuff[] = $row2;
772
+		}
740 773
 		$smcFunc['db_free_result']($request);
741 774
 
742 775
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
743 776
 		{
744 777
 			// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
745
-			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
746
-				fatal_lang_error('modify_post_time_passed', false);
747
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
748
-				isAllowedTo('modify_replies');
749
-			else
750
-				isAllowedTo('modify_own');
778
+			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
779
+							fatal_lang_error('modify_post_time_passed', false);
780
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
781
+							isAllowedTo('modify_replies');
782
+			} else {
783
+							isAllowedTo('modify_own');
784
+			}
785
+		} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
786
+					isAllowedTo('modify_replies');
787
+		} else {
788
+					isAllowedTo('modify_any');
751 789
 		}
752
-		elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
753
-			isAllowedTo('modify_replies');
754
-		else
755
-			isAllowedTo('modify_any');
756 790
 
757 791
 		if ($context['can_announce'] && !empty($row['id_action']))
758 792
 		{
@@ -779,15 +813,17 @@  discard block
 block discarded – undo
779 813
 		$context['icon'] = $row['icon'];
780 814
 
781 815
 		// Show an "approve" box if the user can approve it, and the message isn't approved.
782
-		if (!$row['approved'] && !$context['show_approval'])
783
-			$context['show_approval'] = allowedTo('approve_posts');
816
+		if (!$row['approved'] && !$context['show_approval']) {
817
+					$context['show_approval'] = allowedTo('approve_posts');
818
+		}
784 819
 
785 820
 		// Sort the attachments so they are in the order saved
786 821
 		$temp = array();
787 822
 		foreach ($attachment_stuff as $attachment)
788 823
 		{
789
-			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable']))
790
-				$temp[$attachment['id_attach']] = $attachment;
824
+			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable'])) {
825
+							$temp[$attachment['id_attach']] = $attachment;
826
+			}
791 827
 
792 828
 		}
793 829
 		ksort($temp);
@@ -849,14 +885,16 @@  discard block
 block discarded – undo
849 885
 					'is_approved' => 1,
850 886
 				)
851 887
 			);
852
-			if ($smcFunc['db_num_rows']($request) == 0)
853
-				fatal_lang_error('quoted_post_deleted', false);
888
+			if ($smcFunc['db_num_rows']($request) == 0) {
889
+							fatal_lang_error('quoted_post_deleted', false);
890
+			}
854 891
 			list ($form_subject, $mname, $mdate, $form_message) = $smcFunc['db_fetch_row']($request);
855 892
 			$smcFunc['db_free_result']($request);
856 893
 
857 894
 			// Add 'Re: ' to the front of the quoted subject.
858
-			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
859
-				$form_subject = $context['response_prefix'] . $form_subject;
895
+			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
896
+							$form_subject = $context['response_prefix'] . $form_subject;
897
+			}
860 898
 
861 899
 			// Censor the message and subject.
862 900
 			censorText($form_message);
@@ -869,10 +907,11 @@  discard block
 block discarded – undo
869 907
 				for ($i = 0, $n = count($parts); $i < $n; $i++)
870 908
 				{
871 909
 					// It goes 0 = outside, 1 = begin tag, 2 = inside, 3 = close tag, repeat.
872
-					if ($i % 4 == 0)
873
-						$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
910
+					if ($i % 4 == 0) {
911
+											$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
874 912
 						{
875 913
 							return '[html]' . preg_replace('~<br\s?/?' . '>~i', '&lt;br /&gt;<br>', "$m[1]") . '[/html]';
914
+					}
876 915
 						}, $parts[$i]);
877 916
 				}
878 917
 				$form_message = implode('', $parts);
@@ -881,8 +920,9 @@  discard block
 block discarded – undo
881 920
 			$form_message = preg_replace('~<br ?/?' . '>~i', "\n", $form_message);
882 921
 
883 922
 			// Remove any nested quotes, if necessary.
884
-			if (!empty($modSettings['removeNestedQuotes']))
885
-				$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
923
+			if (!empty($modSettings['removeNestedQuotes'])) {
924
+							$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
925
+			}
886 926
 
887 927
 			// Add a quote string on the front and end.
888 928
 			$form_message = '[quote author=' . $mname . ' link=msg=' . (int) $_REQUEST['quote'] . ' date=' . $mdate . ']' . "\n" . rtrim($form_message) . "\n" . '[/quote]';
@@ -894,15 +934,15 @@  discard block
 block discarded – undo
894 934
 			$form_subject = $first_subject;
895 935
 
896 936
 			// Add 'Re: ' to the front of the subject.
897
-			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
898
-				$form_subject = $context['response_prefix'] . $form_subject;
937
+			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
938
+							$form_subject = $context['response_prefix'] . $form_subject;
939
+			}
899 940
 
900 941
 			// Censor the subject.
901 942
 			censorText($form_subject);
902 943
 
903 944
 			$form_message = '';
904
-		}
905
-		else
945
+		} else
906 946
 		{
907 947
 			$form_subject = isset($_GET['subject']) ? $_GET['subject'] : '';
908 948
 			$form_message = '';
@@ -921,13 +961,15 @@  discard block
 block discarded – undo
921 961
 		if (isset($_REQUEST['msg']))
922 962
 		{
923 963
 			$context['attachments']['quantity'] = count($context['current_attachments']);
924
-			foreach ($context['current_attachments'] as $attachment)
925
-				$context['attachments']['total_size'] += $attachment['size'];
964
+			foreach ($context['current_attachments'] as $attachment) {
965
+							$context['attachments']['total_size'] += $attachment['size'];
966
+			}
926 967
 		}
927 968
 
928 969
 		// A bit of house keeping first.
929
-		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1)
930
-			unset($_SESSION['temp_attachments']);
970
+		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1) {
971
+					unset($_SESSION['temp_attachments']);
972
+		}
931 973
 
932 974
 		if (!empty($_SESSION['temp_attachments']))
933 975
 		{
@@ -936,9 +978,10 @@  discard block
 block discarded – undo
936 978
 			{
937 979
 				foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
938 980
 				{
939
-					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
940
-						if (file_exists($attachment['tmp_name']))
981
+					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) {
982
+											if (file_exists($attachment['tmp_name']))
941 983
 							unlink($attachment['tmp_name']);
984
+					}
942 985
 				}
943 986
 				$post_errors[] = 'temp_attachments_gone';
944 987
 				$_SESSION['temp_attachments'] = array();
@@ -952,8 +995,9 @@  discard block
 block discarded – undo
952 995
 					// See if any files still exist before showing the warning message and the files attached.
953 996
 					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
954 997
 					{
955
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
956
-							continue;
998
+						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
999
+													continue;
1000
+						}
957 1001
 
958 1002
 						if (file_exists($attachment['tmp_name']))
959 1003
 						{
@@ -963,20 +1007,21 @@  discard block
 block discarded – undo
963 1007
 							break;
964 1008
 						}
965 1009
 					}
966
-				}
967
-				else
1010
+				} else
968 1011
 				{
969 1012
 					// Since, they don't belong here. Let's inform the user that they exist..
970
-					if (!empty($topic))
971
-						$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
972
-					else
973
-						$delete_url = $scripturl . '?action=post' . (!empty($board) ? ';board=' . $board : '') . ';delete_temp';
1013
+					if (!empty($topic)) {
1014
+											$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
1015
+					} else {
1016
+											$delete_url = $scripturl . '?action=post' . (!empty($board) ? ';board=' . $board : '') . ';delete_temp';
1017
+					}
974 1018
 
975 1019
 					// Compile a list of the files to show the user.
976 1020
 					$file_list = array();
977
-					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
978
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
1021
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) {
1022
+											if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
979 1023
 							$file_list[] = $attachment['name'];
1024
+					}
980 1025
 
981 1026
 					$_SESSION['temp_attachments']['post']['files'] = $file_list;
982 1027
 					$file_list = '<div class="attachments">' . implode('<br>', $file_list) . '</div>';
@@ -988,8 +1033,7 @@  discard block
 block discarded – undo
988 1033
 
989 1034
 						$post_errors[] = array('temp_attachments_found', array($delete_url, $goback_url, $file_list));
990 1035
 						$context['ignore_temp_attachments'] = true;
991
-					}
992
-					else
1036
+					} else
993 1037
 					{
994 1038
 						$post_errors[] = array('temp_attachments_lost', array($delete_url, $file_list));
995 1039
 						$context['ignore_temp_attachments'] = true;
@@ -997,16 +1041,19 @@  discard block
 block discarded – undo
997 1041
 				}
998 1042
 			}
999 1043
 
1000
-			if (!empty($context['we_are_history']))
1001
-				$post_errors[] = $context['we_are_history'];
1044
+			if (!empty($context['we_are_history'])) {
1045
+							$post_errors[] = $context['we_are_history'];
1046
+			}
1002 1047
 
1003 1048
 			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1004 1049
 			{
1005
-				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files']))
1006
-					break;
1050
+				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files'])) {
1051
+									break;
1052
+				}
1007 1053
 
1008
-				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1009
-					continue;
1054
+				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
1055
+									continue;
1056
+				}
1010 1057
 
1011 1058
 				if ($attachID == 'initial_error')
1012 1059
 				{
@@ -1021,15 +1068,17 @@  discard block
 block discarded – undo
1021 1068
 				{
1022 1069
 					$txt['error_attach_errors'] = empty($txt['error_attach_errors']) ? '<br>' : '';
1023 1070
 					$txt['error_attach_errors'] .= vsprintf($txt['attach_warning'], $attachment['name']) . '<div style="padding: 0 1em;">';
1024
-					foreach ($attachment['errors'] as $error)
1025
-						$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1071
+					foreach ($attachment['errors'] as $error) {
1072
+											$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1073
+					}
1026 1074
 					$txt['error_attach_errors'] .= '</div>';
1027 1075
 					$post_errors[] = 'attach_errors';
1028 1076
 
1029 1077
 					// Take out the trash.
1030 1078
 					unset($_SESSION['temp_attachments'][$attachID]);
1031
-					if (file_exists($attachment['tmp_name']))
1032
-						unlink($attachment['tmp_name']);
1079
+					if (file_exists($attachment['tmp_name'])) {
1080
+											unlink($attachment['tmp_name']);
1081
+					}
1033 1082
 					continue;
1034 1083
 				}
1035 1084
 
@@ -1042,8 +1091,9 @@  discard block
 block discarded – undo
1042 1091
 
1043 1092
 				$context['attachments']['quantity']++;
1044 1093
 				$context['attachments']['total_size'] += $attachment['size'];
1045
-				if (!isset($context['files_in_session_warning']))
1046
-					$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1094
+				if (!isset($context['files_in_session_warning'])) {
1095
+									$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1096
+				}
1047 1097
 
1048 1098
 				$context['current_attachments'][$attachID] = array(
1049 1099
 					'name' => '<u>' . $smcFunc['htmlspecialchars']($attachment['name']) . '</u>',
@@ -1071,8 +1121,9 @@  discard block
 block discarded – undo
1071 1121
 	}
1072 1122
 
1073 1123
 	// If they came from quick reply, and have to enter verification details, give them some notice.
1074
-	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification']))
1075
-		$post_errors[] = 'need_qr_verification';
1124
+	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification'])) {
1125
+			$post_errors[] = 'need_qr_verification';
1126
+	}
1076 1127
 
1077 1128
 	/*
1078 1129
 	 * There are two error types: serious and minor. Serious errors
@@ -1089,52 +1140,56 @@  discard block
 block discarded – undo
1089 1140
 	{
1090 1141
 		loadLanguage('Errors');
1091 1142
 		$context['error_type'] = 'minor';
1092
-		foreach ($post_errors as $post_error)
1093
-			if (is_array($post_error))
1143
+		foreach ($post_errors as $post_error) {
1144
+					if (is_array($post_error))
1094 1145
 			{
1095 1146
 				$post_error_id = $post_error[0];
1147
+		}
1096 1148
 				$context['post_error'][$post_error_id] = vsprintf($txt['error_' . $post_error_id], $post_error[1]);
1097 1149
 
1098 1150
 				// If it's not a minor error flag it as such.
1099
-				if (!in_array($post_error_id, $minor_errors))
1100
-					$context['error_type'] = 'serious';
1101
-			}
1102
-			else
1151
+				if (!in_array($post_error_id, $minor_errors)) {
1152
+									$context['error_type'] = 'serious';
1153
+				}
1154
+			} else
1103 1155
 			{
1104 1156
 				$context['post_error'][$post_error] = $txt['error_' . $post_error];
1105 1157
 
1106 1158
 				// If it's not a minor error flag it as such.
1107
-				if (!in_array($post_error, $minor_errors))
1108
-					$context['error_type'] = 'serious';
1159
+				if (!in_array($post_error, $minor_errors)) {
1160
+									$context['error_type'] = 'serious';
1161
+				}
1109 1162
 			}
1110 1163
 	}
1111 1164
 
1112 1165
 	// What are you doing? Posting a poll, modifying, previewing, new post, or reply...
1113
-	if (isset($_REQUEST['poll']))
1114
-		$context['page_title'] = $txt['new_poll'];
1115
-	elseif ($context['make_event'])
1116
-		$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1117
-	elseif (isset($_REQUEST['msg']))
1118
-		$context['page_title'] = $txt['modify_msg'];
1119
-	elseif (isset($_REQUEST['subject'], $context['preview_subject']))
1120
-		$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1121
-	elseif (empty($topic))
1122
-		$context['page_title'] = $txt['start_new_topic'];
1123
-	else
1124
-		$context['page_title'] = $txt['post_reply'];
1166
+	if (isset($_REQUEST['poll'])) {
1167
+			$context['page_title'] = $txt['new_poll'];
1168
+	} elseif ($context['make_event']) {
1169
+			$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1170
+	} elseif (isset($_REQUEST['msg'])) {
1171
+			$context['page_title'] = $txt['modify_msg'];
1172
+	} elseif (isset($_REQUEST['subject'], $context['preview_subject'])) {
1173
+			$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1174
+	} elseif (empty($topic)) {
1175
+			$context['page_title'] = $txt['start_new_topic'];
1176
+	} else {
1177
+			$context['page_title'] = $txt['post_reply'];
1178
+	}
1125 1179
 
1126 1180
 	// Build the link tree.
1127
-	if (empty($topic))
1128
-		$context['linktree'][] = array(
1181
+	if (empty($topic)) {
1182
+			$context['linktree'][] = array(
1129 1183
 			'name' => '<em>' . $txt['start_new_topic'] . '</em>'
1130 1184
 		);
1131
-	else
1132
-		$context['linktree'][] = array(
1185
+	} else {
1186
+			$context['linktree'][] = array(
1133 1187
 			'url' => $scripturl . '?topic=' . $topic . '.' . $_REQUEST['start'],
1134 1188
 			'name' => $form_subject,
1135 1189
 			'extra_before' => '<span><strong class="nav">' . $context['page_title'] . ' (</strong></span>',
1136 1190
 			'extra_after' => '<span><strong class="nav">)</strong></span>'
1137 1191
 		);
1192
+	}
1138 1193
 
1139 1194
 	$context['subject'] = addcslashes($form_subject, '"');
1140 1195
 	$context['message'] = str_replace(array('"', '<', '>', '&nbsp;'), array('&quot;', '&lt;', '&gt;', ' '), $form_message);
@@ -1178,8 +1233,9 @@  discard block
 block discarded – undo
1178 1233
 	// Message icons - customized icons are off?
1179 1234
 	$context['icons'] = getMessageIcons(!empty($board) ? $board : 0);
1180 1235
 
1181
-	if (!empty($context['icons']))
1182
-		$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1236
+	if (!empty($context['icons'])) {
1237
+			$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1238
+	}
1183 1239
 
1184 1240
 	// Are we starting a poll? if set the poll icon as selected if its available
1185 1241
 	if (isset($_REQUEST['poll']))
@@ -1199,8 +1255,9 @@  discard block
 block discarded – undo
1199 1255
 	for ($i = 0, $n = count($context['icons']); $i < $n; $i++)
1200 1256
 	{
1201 1257
 		$context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value'];
1202
-		if ($context['icons'][$i]['selected'])
1203
-			$context['icon_url'] = $context['icons'][$i]['url'];
1258
+		if ($context['icons'][$i]['selected']) {
1259
+					$context['icon_url'] = $context['icons'][$i]['url'];
1260
+		}
1204 1261
 	}
1205 1262
 	if (empty($context['icon_url']))
1206 1263
 	{
@@ -1214,8 +1271,9 @@  discard block
 block discarded – undo
1214 1271
 		));
1215 1272
 	}
1216 1273
 
1217
-	if (!empty($topic) && !empty($modSettings['topicSummaryPosts']))
1218
-		getTopic();
1274
+	if (!empty($topic) && !empty($modSettings['topicSummaryPosts'])) {
1275
+			getTopic();
1276
+	}
1219 1277
 
1220 1278
 	// If the user can post attachments prepare the warning labels.
1221 1279
 	if ($context['can_post_attachment'])
@@ -1226,12 +1284,13 @@  discard block
 block discarded – undo
1226 1284
 		$context['attachment_restrictions'] = array();
1227 1285
 		$context['allowed_extensions'] = strtr(strtolower($modSettings['attachmentExtensions']), array(',' => ', '));
1228 1286
 		$attachmentRestrictionTypes = array('attachmentNumPerPostLimit', 'attachmentPostLimit', 'attachmentSizeLimit');
1229
-		foreach ($attachmentRestrictionTypes as $type)
1230
-			if (!empty($modSettings[$type]))
1287
+		foreach ($attachmentRestrictionTypes as $type) {
1288
+					if (!empty($modSettings[$type]))
1231 1289
 			{
1232 1290
 				// Show the max number of attachments if not 0.
1233 1291
 				if ($type == 'attachmentNumPerPostLimit')
1234 1292
 					$context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']);
1293
+		}
1235 1294
 			}
1236 1295
 	}
1237 1296
 
@@ -1265,8 +1324,8 @@  discard block
 block discarded – undo
1265 1324
 
1266 1325
 	if (!empty($context['current_attachments']))
1267 1326
 	{
1268
-		foreach ($context['current_attachments'] as $key => $mock)
1269
-			addInlineJavaScript('
1327
+		foreach ($context['current_attachments'] as $key => $mock) {
1328
+					addInlineJavaScript('
1270 1329
 	current_attachments.push({
1271 1330
 		name: '. JavaScriptEscape($mock['name']) . ',
1272 1331
 		size: '. $mock['size'] . ',
@@ -1275,6 +1334,7 @@  discard block
 block discarded – undo
1275 1334
 		type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') . ',
1276 1335
 		thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) . '
1277 1336
 	});', true);
1337
+		}
1278 1338
 	}
1279 1339
 
1280 1340
 	// File Upload.
@@ -1349,9 +1409,10 @@  discard block
 block discarded – undo
1349 1409
 			$context['posting_fields']['board']['dd'] .= '
1350 1410
 							<optgroup label="' . $category['name'] . '">';
1351 1411
 
1352
-			foreach ($category['boards'] as $brd)
1353
-				$context['posting_fields']['board']['dd'] .= '
1412
+			foreach ($category['boards'] as $brd) {
1413
+							$context['posting_fields']['board']['dd'] .= '
1354 1414
 								<option value="' . $brd['id'] . '"' . ($brd['selected'] ? ' selected' : '') . '>' . ($brd['child_level'] > 0 ? str_repeat('==', $brd['child_level'] - 1) . '=&gt;' : '') . ' ' . $brd['name'] . '</option>';
1415
+			}
1355 1416
 
1356 1417
 			$context['posting_fields']['board']['dd'] .= '
1357 1418
 							</optgroup>';
@@ -1382,8 +1443,9 @@  discard block
 block discarded – undo
1382 1443
 
1383 1444
 
1384 1445
 	// Finally, load the template.
1385
-	if (!isset($_REQUEST['xml']))
1386
-		loadTemplate('Post');
1446
+	if (!isset($_REQUEST['xml'])) {
1447
+			loadTemplate('Post');
1448
+	}
1387 1449
 
1388 1450
 	call_integration_hook('integrate_post_end');
1389 1451
 }
@@ -1404,13 +1466,14 @@  discard block
 block discarded – undo
1404 1466
 	// Sneaking off, are we?
1405 1467
 	if (empty($_POST) && empty($topic))
1406 1468
 	{
1407
-		if (empty($_SERVER['CONTENT_LENGTH']))
1408
-			redirectexit('action=post;board=' . $board . '.0');
1409
-		else
1410
-			fatal_lang_error('post_upload_error', false);
1469
+		if (empty($_SERVER['CONTENT_LENGTH'])) {
1470
+					redirectexit('action=post;board=' . $board . '.0');
1471
+		} else {
1472
+					fatal_lang_error('post_upload_error', false);
1473
+		}
1474
+	} elseif (empty($_POST) && !empty($topic)) {
1475
+			redirectexit('action=post;topic=' . $topic . '.0');
1411 1476
 	}
1412
-	elseif (empty($_POST) && !empty($topic))
1413
-		redirectexit('action=post;topic=' . $topic . '.0');
1414 1477
 
1415 1478
 	// No need!
1416 1479
 	$context['robot_no_index'] = true;
@@ -1422,8 +1485,9 @@  discard block
 block discarded – undo
1422 1485
 	$post_errors = array();
1423 1486
 
1424 1487
 	// If the session has timed out, let the user re-submit their form.
1425
-	if (checkSession('post', '', false) != '')
1426
-		$post_errors[] = 'session_timeout';
1488
+	if (checkSession('post', '', false) != '') {
1489
+			$post_errors[] = 'session_timeout';
1490
+	}
1427 1491
 
1428 1492
 	// Wrong verification code?
1429 1493
 	if (!$user_info['is_admin'] && !$user_info['is_mod'] && !empty($modSettings['posts_require_captcha']) && ($user_info['posts'] < $modSettings['posts_require_captcha'] || ($user_info['is_guest'] && $modSettings['posts_require_captcha'] == -1)))
@@ -1433,33 +1497,38 @@  discard block
 block discarded – undo
1433 1497
 			'id' => 'post',
1434 1498
 		);
1435 1499
 		$context['require_verification'] = create_control_verification($verificationOptions, true);
1436
-		if (is_array($context['require_verification']))
1437
-			$post_errors = array_merge($post_errors, $context['require_verification']);
1500
+		if (is_array($context['require_verification'])) {
1501
+					$post_errors = array_merge($post_errors, $context['require_verification']);
1502
+		}
1438 1503
 	}
1439 1504
 
1440 1505
 	require_once($sourcedir . '/Subs-Post.php');
1441 1506
 	loadLanguage('Post');
1442 1507
 
1443 1508
 	// Drafts enabled and needed?
1444
-	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft'])))
1445
-		require_once($sourcedir . '/Drafts.php');
1509
+	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft']))) {
1510
+			require_once($sourcedir . '/Drafts.php');
1511
+	}
1446 1512
 
1447 1513
 	// First check to see if they are trying to delete any current attachments.
1448 1514
 	if (isset($_POST['attach_del']))
1449 1515
 	{
1450 1516
 		$keep_temp = array();
1451 1517
 		$keep_ids = array();
1452
-		foreach ($_POST['attach_del'] as $dummy)
1453
-			if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1518
+		foreach ($_POST['attach_del'] as $dummy) {
1519
+					if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1454 1520
 				$keep_temp[] = $dummy;
1455
-			else
1456
-				$keep_ids[] = (int) $dummy;
1521
+		}
1522
+			else {
1523
+							$keep_ids[] = (int) $dummy;
1524
+			}
1457 1525
 
1458
-		if (isset($_SESSION['temp_attachments']))
1459
-			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1526
+		if (isset($_SESSION['temp_attachments'])) {
1527
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1460 1528
 			{
1461 1529
 				if ((isset($_SESSION['temp_attachments']['post']['files'], $attachment['name']) && in_array($attachment['name'], $_SESSION['temp_attachments']['post']['files'])) || in_array($attachID, $keep_temp) || strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1462 1530
 					continue;
1531
+		}
1463 1532
 
1464 1533
 				unset($_SESSION['temp_attachments'][$attachID]);
1465 1534
 				unlink($attachment['tmp_name']);
@@ -1491,8 +1560,9 @@  discard block
 block discarded – undo
1491 1560
 	{
1492 1561
 		require_once($sourcedir . '/ManageAttachments.php');
1493 1562
 
1494
-		foreach ($_SESSION['already_attached'] as $attachID => $attachment)
1495
-			removeAttachments(array('id_attach' => $attachID));
1563
+		foreach ($_SESSION['already_attached'] as $attachID => $attachment) {
1564
+					removeAttachments(array('id_attach' => $attachID));
1565
+		}
1496 1566
 
1497 1567
 		unset($_SESSION['already_attached']);
1498 1568
 
@@ -1515,12 +1585,14 @@  discard block
 block discarded – undo
1515 1585
 		$smcFunc['db_free_result']($request);
1516 1586
 
1517 1587
 		// Though the topic should be there, it might have vanished.
1518
-		if (!is_array($topic_info))
1519
-			fatal_lang_error('topic_doesnt_exist', 404);
1588
+		if (!is_array($topic_info)) {
1589
+					fatal_lang_error('topic_doesnt_exist', 404);
1590
+		}
1520 1591
 
1521 1592
 		// Did this topic suddenly move? Just checking...
1522
-		if ($topic_info['id_board'] != $board)
1523
-			fatal_lang_error('not_a_topic');
1593
+		if ($topic_info['id_board'] != $board) {
1594
+					fatal_lang_error('not_a_topic');
1595
+		}
1524 1596
 
1525 1597
 		// Do the permissions and approval stuff...
1526 1598
 		$becomesApproved = true;
@@ -1543,49 +1615,50 @@  discard block
 block discarded – undo
1543 1615
 	if (!empty($topic) && !isset($_REQUEST['msg']))
1544 1616
 	{
1545 1617
 		// Don't allow a post if it's locked.
1546
-		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board'))
1547
-			fatal_lang_error('topic_locked', false);
1618
+		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board')) {
1619
+					fatal_lang_error('topic_locked', false);
1620
+		}
1548 1621
 
1549 1622
 		// Sorry, multiple polls aren't allowed... yet.  You should stop giving me ideas :P.
1550
-		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0)
1551
-			unset($_REQUEST['poll']);
1552
-
1553
-		elseif ($topic_info['id_member_started'] != $user_info['id'])
1554
-		{
1555
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
1556
-				$becomesApproved = false;
1557
-
1558
-			else
1559
-				isAllowedTo('post_reply_any');
1560
-		}
1561
-		elseif (!allowedTo('post_reply_any'))
1623
+		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0) {
1624
+					unset($_REQUEST['poll']);
1625
+		} elseif ($topic_info['id_member_started'] != $user_info['id'])
1626
+		{
1627
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
1628
+							$becomesApproved = false;
1629
+			} else {
1630
+							isAllowedTo('post_reply_any');
1631
+			}
1632
+		} elseif (!allowedTo('post_reply_any'))
1562 1633
 		{
1563
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own'))
1564
-				$becomesApproved = false;
1565
-
1566
-			else
1567
-				isAllowedTo('post_reply_own');
1634
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) {
1635
+							$becomesApproved = false;
1636
+			} else {
1637
+							isAllowedTo('post_reply_own');
1638
+			}
1568 1639
 		}
1569 1640
 
1570 1641
 		if (isset($_POST['lock']))
1571 1642
 		{
1572 1643
 			// Nothing is changed to the lock.
1573
-			if (empty($topic_info['locked']) == empty($_POST['lock']))
1574
-				unset($_POST['lock']);
1644
+			if (empty($topic_info['locked']) == empty($_POST['lock'])) {
1645
+							unset($_POST['lock']);
1646
+			}
1575 1647
 
1576 1648
 			// You're have no permission to lock this topic.
1577
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1578
-				unset($_POST['lock']);
1649
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1650
+							unset($_POST['lock']);
1651
+			}
1579 1652
 
1580 1653
 			// You are allowed to (un)lock your own topic only.
1581 1654
 			elseif (!allowedTo('lock_any'))
1582 1655
 			{
1583 1656
 				// You cannot override a moderator lock.
1584
-				if ($topic_info['locked'] == 1)
1585
-					unset($_POST['lock']);
1586
-
1587
-				else
1588
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1657
+				if ($topic_info['locked'] == 1) {
1658
+									unset($_POST['lock']);
1659
+				} else {
1660
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1661
+				}
1589 1662
 			}
1590 1663
 			// Hail mighty moderator, (un)lock this topic immediately.
1591 1664
 			else
@@ -1593,19 +1666,21 @@  discard block
 block discarded – undo
1593 1666
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1594 1667
 
1595 1668
 				// Did someone (un)lock this while you were posting?
1596
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1597
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1669
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1670
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1671
+				}
1598 1672
 			}
1599 1673
 		}
1600 1674
 
1601 1675
 		// So you wanna (un)sticky this...let's see.
1602
-		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky')))
1603
-			unset($_POST['sticky']);
1604
-		elseif (isset($_POST['sticky']))
1676
+		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky'))) {
1677
+					unset($_POST['sticky']);
1678
+		} elseif (isset($_POST['sticky']))
1605 1679
 		{
1606 1680
 			// Did someone (un)sticky this while you were posting?
1607
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1608
-				$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1681
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1682
+							$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1683
+			}
1609 1684
 		}
1610 1685
 
1611 1686
 		// If drafts are enabled, then pass this off
@@ -1632,26 +1707,31 @@  discard block
 block discarded – undo
1632 1707
 
1633 1708
 		// Do like, the permissions, for safety and stuff...
1634 1709
 		$becomesApproved = true;
1635
-		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics'))
1636
-			$becomesApproved = false;
1637
-		else
1638
-			isAllowedTo('post_new');
1710
+		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) {
1711
+					$becomesApproved = false;
1712
+		} else {
1713
+					isAllowedTo('post_new');
1714
+		}
1639 1715
 
1640 1716
 		if (isset($_POST['lock']))
1641 1717
 		{
1642 1718
 			// New topics are by default not locked.
1643
-			if (empty($_POST['lock']))
1644
-				unset($_POST['lock']);
1719
+			if (empty($_POST['lock'])) {
1720
+							unset($_POST['lock']);
1721
+			}
1645 1722
 			// Besides, you need permission.
1646
-			elseif (!allowedTo(array('lock_any', 'lock_own')))
1647
-				unset($_POST['lock']);
1723
+			elseif (!allowedTo(array('lock_any', 'lock_own'))) {
1724
+							unset($_POST['lock']);
1725
+			}
1648 1726
 			// A moderator-lock (1) can override a user-lock (2).
1649
-			else
1650
-				$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1727
+			else {
1728
+							$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1729
+			}
1651 1730
 		}
1652 1731
 
1653
-		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky')))
1654
-			unset($_POST['sticky']);
1732
+		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky'))) {
1733
+					unset($_POST['sticky']);
1734
+		}
1655 1735
 
1656 1736
 		// Saving your new topic as a draft first?
1657 1737
 		if (!empty($modSettings['drafts_post_enabled']) && isset($_POST['save_draft']))
@@ -1676,31 +1756,37 @@  discard block
 block discarded – undo
1676 1756
 				'id_msg' => $_REQUEST['msg'],
1677 1757
 			)
1678 1758
 		);
1679
-		if ($smcFunc['db_num_rows']($request) == 0)
1680
-			fatal_lang_error('cant_find_messages', false);
1759
+		if ($smcFunc['db_num_rows']($request) == 0) {
1760
+					fatal_lang_error('cant_find_messages', false);
1761
+		}
1681 1762
 		$row = $smcFunc['db_fetch_assoc']($request);
1682 1763
 		$smcFunc['db_free_result']($request);
1683 1764
 
1684
-		if (!empty($topic_info['locked']) && !allowedTo('moderate_board'))
1685
-			fatal_lang_error('topic_locked', false);
1765
+		if (!empty($topic_info['locked']) && !allowedTo('moderate_board')) {
1766
+					fatal_lang_error('topic_locked', false);
1767
+		}
1686 1768
 
1687 1769
 		if (isset($_POST['lock']))
1688 1770
 		{
1689 1771
 			// Nothing changes to the lock status.
1690
-			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked'])))
1691
-				unset($_POST['lock']);
1772
+			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) {
1773
+							unset($_POST['lock']);
1774
+			}
1692 1775
 			// You're simply not allowed to (un)lock this.
1693
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1694
-				unset($_POST['lock']);
1776
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1777
+							unset($_POST['lock']);
1778
+			}
1695 1779
 			// You're only allowed to lock your own topics.
1696 1780
 			elseif (!allowedTo('lock_any'))
1697 1781
 			{
1698 1782
 				// You're not allowed to break a moderator's lock.
1699
-				if ($topic_info['locked'] == 1)
1700
-					unset($_POST['lock']);
1783
+				if ($topic_info['locked'] == 1) {
1784
+									unset($_POST['lock']);
1785
+				}
1701 1786
 				// Lock it with a soft lock or unlock it.
1702
-				else
1703
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1787
+				else {
1788
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1789
+				}
1704 1790
 			}
1705 1791
 			// You must be the moderator.
1706 1792
 			else
@@ -1708,44 +1794,46 @@  discard block
 block discarded – undo
1708 1794
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1709 1795
 
1710 1796
 				// Did someone (un)lock this while you were posting?
1711
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1712
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1797
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1798
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1799
+				}
1713 1800
 			}
1714 1801
 		}
1715 1802
 
1716 1803
 		// Change the sticky status of this topic?
1717
-		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky']))
1718
-			unset($_POST['sticky']);
1719
-		elseif (isset($_POST['sticky']))
1804
+		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky'])) {
1805
+					unset($_POST['sticky']);
1806
+		} elseif (isset($_POST['sticky']))
1720 1807
 		{
1721 1808
 			// Did someone (un)sticky this while you were posting?
1722
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1723
-				$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1809
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1810
+							$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1811
+			}
1724 1812
 		}
1725 1813
 
1726 1814
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
1727 1815
 		{
1728
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
1729
-				fatal_lang_error('modify_post_time_passed', false);
1730
-			elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
1731
-				isAllowedTo('modify_replies');
1732
-			else
1733
-				isAllowedTo('modify_own');
1734
-		}
1735
-		elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1816
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
1817
+							fatal_lang_error('modify_post_time_passed', false);
1818
+			} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
1819
+							isAllowedTo('modify_replies');
1820
+			} else {
1821
+							isAllowedTo('modify_own');
1822
+			}
1823
+		} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1736 1824
 		{
1737 1825
 			isAllowedTo('modify_replies');
1738 1826
 
1739 1827
 			// If you're modifying a reply, I say it better be logged...
1740 1828
 			$moderationAction = true;
1741
-		}
1742
-		else
1829
+		} else
1743 1830
 		{
1744 1831
 			isAllowedTo('modify_any');
1745 1832
 
1746 1833
 			// Log it, assuming you're not modifying your own post.
1747
-			if ($row['id_member'] != $user_info['id'])
1748
-				$moderationAction = true;
1834
+			if ($row['id_member'] != $user_info['id']) {
1835
+							$moderationAction = true;
1836
+			}
1749 1837
 		}
1750 1838
 
1751 1839
 		// If drafts are enabled, then lets send this off to save
@@ -1784,20 +1872,24 @@  discard block
 block discarded – undo
1784 1872
 		$_POST['guestname'] = !isset($_POST['guestname']) ? '' : trim($_POST['guestname']);
1785 1873
 		$_POST['email'] = !isset($_POST['email']) ? '' : trim($_POST['email']);
1786 1874
 
1787
-		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_')
1788
-			$post_errors[] = 'no_name';
1789
-		if ($smcFunc['strlen']($_POST['guestname']) > 25)
1790
-			$post_errors[] = 'long_name';
1875
+		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_') {
1876
+					$post_errors[] = 'no_name';
1877
+		}
1878
+		if ($smcFunc['strlen']($_POST['guestname']) > 25) {
1879
+					$post_errors[] = 'long_name';
1880
+		}
1791 1881
 
1792 1882
 		if (empty($modSettings['guest_post_no_email']))
1793 1883
 		{
1794 1884
 			// Only check if they changed it!
1795 1885
 			if (!isset($row) || $row['poster_email'] != $_POST['email'])
1796 1886
 			{
1797
-				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == ''))
1798
-					$post_errors[] = 'no_email';
1799
-				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL))
1800
-					$post_errors[] = 'bad_email';
1887
+				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == '')) {
1888
+									$post_errors[] = 'no_email';
1889
+				}
1890
+				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) {
1891
+									$post_errors[] = 'bad_email';
1892
+				}
1801 1893
 			}
1802 1894
 
1803 1895
 			// Now make sure this email address is not banned from posting.
@@ -1813,81 +1905,95 @@  discard block
 block discarded – undo
1813 1905
 	}
1814 1906
 
1815 1907
 	// Coming from the quickReply?
1816
-	if (isset($_POST['quickReply']))
1817
-		$_POST['message'] = $_POST['quickReply'];
1908
+	if (isset($_POST['quickReply'])) {
1909
+			$_POST['message'] = $_POST['quickReply'];
1910
+	}
1818 1911
 
1819 1912
 	// Check the subject and message.
1820
-	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '')
1821
-		$post_errors[] = 'no_subject';
1822
-	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '')
1823
-		$post_errors[] = 'no_message';
1824
-	elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
1825
-		$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1826
-	else
1913
+	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '') {
1914
+			$post_errors[] = 'no_subject';
1915
+	}
1916
+	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '') {
1917
+			$post_errors[] = 'no_message';
1918
+	} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) {
1919
+			$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1920
+	} else
1827 1921
 	{
1828 1922
 		// Prepare the message a bit for some additional testing.
1829 1923
 		$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
1830 1924
 
1831 1925
 		// Preparse code. (Zef)
1832
-		if ($user_info['is_guest'])
1833
-			$user_info['name'] = $_POST['guestname'];
1926
+		if ($user_info['is_guest']) {
1927
+					$user_info['name'] = $_POST['guestname'];
1928
+		}
1834 1929
 		preparsecode($_POST['message']);
1835 1930
 
1836 1931
 		// Youtube BBC would be stripped out in the next check without this
1837 1932
 		$context['allowed_html_tags'][] = '<iframe>';
1838 1933
 
1839 1934
 		// Let's see if there's still some content left without the tags.
1840
-		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false))
1841
-			$post_errors[] = 'no_message';
1935
+		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false)) {
1936
+					$post_errors[] = 'no_message';
1937
+		}
1842 1938
 
1843 1939
 		// Remove iframe from the list
1844 1940
 		array_pop($context['allowed_html_tags']);
1845 1941
 	}
1846
-	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '')
1847
-		$post_errors[] = 'no_event';
1942
+	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '') {
1943
+			$post_errors[] = 'no_event';
1944
+	}
1848 1945
 	// You are not!
1849
-	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin'])
1850
-		fatal_error('Knave! Masquerader! Charlatan!', false);
1946
+	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin']) {
1947
+			fatal_error('Knave! Masquerader! Charlatan!', false);
1948
+	}
1851 1949
 
1852 1950
 	// Validate the poll...
1853 1951
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
1854 1952
 	{
1855
-		if (!empty($topic) && !isset($_REQUEST['msg']))
1856
-			fatal_lang_error('no_access', false);
1953
+		if (!empty($topic) && !isset($_REQUEST['msg'])) {
1954
+					fatal_lang_error('no_access', false);
1955
+		}
1857 1956
 
1858 1957
 		// This is a new topic... so it's a new poll.
1859
-		if (empty($topic))
1860
-			isAllowedTo('poll_post');
1958
+		if (empty($topic)) {
1959
+					isAllowedTo('poll_post');
1960
+		}
1861 1961
 		// Can you add to your own topics?
1862
-		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any'))
1863
-			isAllowedTo('poll_add_own');
1962
+		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any')) {
1963
+					isAllowedTo('poll_add_own');
1964
+		}
1864 1965
 		// Can you add polls to any topic, then?
1865
-		else
1866
-			isAllowedTo('poll_add_any');
1966
+		else {
1967
+					isAllowedTo('poll_add_any');
1968
+		}
1867 1969
 
1868
-		if (!isset($_POST['question']) || trim($_POST['question']) == '')
1869
-			$post_errors[] = 'no_question';
1970
+		if (!isset($_POST['question']) || trim($_POST['question']) == '') {
1971
+					$post_errors[] = 'no_question';
1972
+		}
1870 1973
 
1871 1974
 		$_POST['options'] = empty($_POST['options']) ? array() : htmltrim__recursive($_POST['options']);
1872 1975
 
1873 1976
 		// Get rid of empty ones.
1874
-		foreach ($_POST['options'] as $k => $option)
1875
-			if ($option == '')
1977
+		foreach ($_POST['options'] as $k => $option) {
1978
+					if ($option == '')
1876 1979
 				unset($_POST['options'][$k], $_POST['options'][$k]);
1980
+		}
1877 1981
 
1878 1982
 		// What are you going to vote between with one choice?!?
1879
-		if (count($_POST['options']) < 2)
1880
-			$post_errors[] = 'poll_few';
1881
-		elseif (count($_POST['options']) > 256)
1882
-			$post_errors[] = 'poll_many';
1983
+		if (count($_POST['options']) < 2) {
1984
+					$post_errors[] = 'poll_few';
1985
+		} elseif (count($_POST['options']) > 256) {
1986
+					$post_errors[] = 'poll_many';
1987
+		}
1883 1988
 	}
1884 1989
 
1885 1990
 	if ($posterIsGuest)
1886 1991
 	{
1887 1992
 		// If user is a guest, make sure the chosen name isn't taken.
1888 1993
 		require_once($sourcedir . '/Subs-Members.php');
1889
-		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name']))
1890
-			$post_errors[] = 'bad_name';
1994
+		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name'])) {
1995
+					$post_errors[] = 'bad_name';
1996
+		}
1891 1997
 	}
1892 1998
 	// If the user isn't a guest, get his or her name and email.
1893 1999
 	elseif (!isset($_REQUEST['msg']))
@@ -1918,8 +2024,9 @@  discard block
 block discarded – undo
1918 2024
 	}
1919 2025
 
1920 2026
 	// Make sure the user isn't spamming the board.
1921
-	if (!isset($_REQUEST['msg']))
1922
-		spamProtection('post');
2027
+	if (!isset($_REQUEST['msg'])) {
2028
+			spamProtection('post');
2029
+	}
1923 2030
 
1924 2031
 	// At about this point, we're posting and that's that.
1925 2032
 	ignore_user_abort(true);
@@ -1932,32 +2039,36 @@  discard block
 block discarded – undo
1932 2039
 	$_POST['modify_reason'] = empty($_POST['modify_reason']) ? '' : strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
1933 2040
 
1934 2041
 	// At this point, we want to make sure the subject isn't too long.
1935
-	if ($smcFunc['strlen']($_POST['subject']) > 100)
1936
-		$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2042
+	if ($smcFunc['strlen']($_POST['subject']) > 100) {
2043
+			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2044
+	}
1937 2045
 
1938 2046
 	// Same with the "why did you edit this" text.
1939
-	if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
1940
-		$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2047
+	if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
2048
+			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2049
+	}
1941 2050
 
1942 2051
 	// Make the poll...
1943 2052
 	if (isset($_REQUEST['poll']))
1944 2053
 	{
1945 2054
 		// Make sure that the user has not entered a ridiculous number of options..
1946
-		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0)
1947
-			$_POST['poll_max_votes'] = 1;
1948
-		elseif ($_POST['poll_max_votes'] > count($_POST['options']))
1949
-			$_POST['poll_max_votes'] = count($_POST['options']);
1950
-		else
1951
-			$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
2055
+		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0) {
2056
+					$_POST['poll_max_votes'] = 1;
2057
+		} elseif ($_POST['poll_max_votes'] > count($_POST['options'])) {
2058
+					$_POST['poll_max_votes'] = count($_POST['options']);
2059
+		} else {
2060
+					$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
2061
+		}
1952 2062
 
1953 2063
 		$_POST['poll_expire'] = (int) $_POST['poll_expire'];
1954 2064
 		$_POST['poll_expire'] = $_POST['poll_expire'] > 9999 ? 9999 : ($_POST['poll_expire'] < 0 ? 0 : $_POST['poll_expire']);
1955 2065
 
1956 2066
 		// Just set it to zero if it's not there..
1957
-		if (!isset($_POST['poll_hide']))
1958
-			$_POST['poll_hide'] = 0;
1959
-		else
1960
-			$_POST['poll_hide'] = (int) $_POST['poll_hide'];
2067
+		if (!isset($_POST['poll_hide'])) {
2068
+					$_POST['poll_hide'] = 0;
2069
+		} else {
2070
+					$_POST['poll_hide'] = (int) $_POST['poll_hide'];
2071
+		}
1961 2072
 		$_POST['poll_change_vote'] = isset($_POST['poll_change_vote']) ? 1 : 0;
1962 2073
 
1963 2074
 		$_POST['poll_guest_vote'] = isset($_POST['poll_guest_vote']) ? 1 : 0;
@@ -1966,16 +2077,19 @@  discard block
 block discarded – undo
1966 2077
 		{
1967 2078
 			require_once($sourcedir . '/Subs-Members.php');
1968 2079
 			$allowedVoteGroups = groupsAllowedTo('poll_vote', $board);
1969
-			if (!in_array(-1, $allowedVoteGroups['allowed']))
1970
-				$_POST['poll_guest_vote'] = 0;
2080
+			if (!in_array(-1, $allowedVoteGroups['allowed'])) {
2081
+							$_POST['poll_guest_vote'] = 0;
2082
+			}
1971 2083
 		}
1972 2084
 
1973 2085
 		// If the user tries to set the poll too far in advance, don't let them.
1974
-		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1)
1975
-			fatal_lang_error('poll_range_error', false);
2086
+		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1) {
2087
+					fatal_lang_error('poll_range_error', false);
2088
+		}
1976 2089
 		// Don't allow them to select option 2 for hidden results if it's not time limited.
1977
-		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2)
1978
-			$_POST['poll_hide'] = 1;
2090
+		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2) {
2091
+					$_POST['poll_hide'] = 1;
2092
+		}
1979 2093
 
1980 2094
 		// Clean up the question and answers.
1981 2095
 		$_POST['question'] = $smcFunc['htmlspecialchars']($_POST['question']);
@@ -1989,13 +2103,15 @@  discard block
 block discarded – undo
1989 2103
 	{
1990 2104
 		$attachIDs = array();
1991 2105
 		$attach_errors = array();
1992
-		if (!empty($context['we_are_history']))
1993
-			$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2106
+		if (!empty($context['we_are_history'])) {
2107
+					$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2108
+		}
1994 2109
 
1995 2110
 		foreach ($_SESSION['temp_attachments'] as  $attachID => $attachment)
1996 2111
 		{
1997
-			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1998
-				continue;
2112
+			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
2113
+							continue;
2114
+			}
1999 2115
 
2000 2116
 			// If there was an initial error just show that message.
2001 2117
 			if ($attachID == 'initial_error')
@@ -2024,12 +2140,13 @@  discard block
 block discarded – undo
2024 2140
 				if (createAttachment($attachmentOptions))
2025 2141
 				{
2026 2142
 					$attachIDs[] = $attachmentOptions['id'];
2027
-					if (!empty($attachmentOptions['thumb']))
2028
-						$attachIDs[] = $attachmentOptions['thumb'];
2143
+					if (!empty($attachmentOptions['thumb'])) {
2144
+											$attachIDs[] = $attachmentOptions['thumb'];
2145
+					}
2029 2146
 				}
2147
+			} else {
2148
+							$attach_errors[] = '<dt>&nbsp;</dt>';
2030 2149
 			}
2031
-			else
2032
-				$attach_errors[] = '<dt>&nbsp;</dt>';
2033 2150
 
2034 2151
 			if (!empty($attachmentOptions['errors']))
2035 2152
 			{
@@ -2041,14 +2158,16 @@  discard block
 block discarded – undo
2041 2158
 					if (!is_array($error))
2042 2159
 					{
2043 2160
 						$attach_errors[] = '<dd>' . $txt[$error] . '</dd>';
2044
-						if (in_array($error, $log_these))
2045
-							log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2161
+						if (in_array($error, $log_these)) {
2162
+													log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2163
+						}
2164
+					} else {
2165
+											$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
2046 2166
 					}
2047
-					else
2048
-						$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
2049 2167
 				}
2050
-				if (file_exists($attachment['tmp_name']))
2051
-					unlink($attachment['tmp_name']);
2168
+				if (file_exists($attachment['tmp_name'])) {
2169
+									unlink($attachment['tmp_name']);
2170
+				}
2052 2171
 			}
2053 2172
 		}
2054 2173
 		unset($_SESSION['temp_attachments']);
@@ -2089,24 +2208,24 @@  discard block
 block discarded – undo
2089 2208
 		);
2090 2209
 
2091 2210
 		call_integration_hook('integrate_poll_add_edit', array($id_poll, false));
2211
+	} else {
2212
+			$id_poll = 0;
2092 2213
 	}
2093
-	else
2094
-		$id_poll = 0;
2095 2214
 
2096 2215
 	// Creating a new topic?
2097 2216
 	$newTopic = empty($_REQUEST['msg']) && empty($topic);
2098 2217
 
2099 2218
 	// Check the icon.
2100
-	if (!isset($_POST['icon']))
2101
-		$_POST['icon'] = 'xx';
2102
-
2103
-	else
2219
+	if (!isset($_POST['icon'])) {
2220
+			$_POST['icon'] = 'xx';
2221
+	} else
2104 2222
 	{
2105 2223
 		$_POST['icon'] = $smcFunc['htmlspecialchars']($_POST['icon']);
2106 2224
 
2107 2225
 		// Need to figure it out if this is a valid icon name.
2108
-		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')))
2109
-			$_POST['icon'] = 'xx';
2226
+		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png'))) {
2227
+					$_POST['icon'] = 'xx';
2228
+		}
2110 2229
 	}
2111 2230
 
2112 2231
 	// Collect all parameters for the creation or modification of a post.
@@ -2147,8 +2266,9 @@  discard block
 block discarded – undo
2147 2266
 		}
2148 2267
 
2149 2268
 		// This will save some time...
2150
-		if (empty($approve_has_changed))
2151
-			unset($msgOptions['approved']);
2269
+		if (empty($approve_has_changed)) {
2270
+					unset($msgOptions['approved']);
2271
+		}
2152 2272
 
2153 2273
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2154 2274
 	}
@@ -2157,8 +2277,9 @@  discard block
 block discarded – undo
2157 2277
 	{
2158 2278
 		createPost($msgOptions, $topicOptions, $posterOptions);
2159 2279
 
2160
-		if (isset($topicOptions['id']))
2161
-			$topic = $topicOptions['id'];
2280
+		if (isset($topicOptions['id'])) {
2281
+					$topic = $topicOptions['id'];
2282
+		}
2162 2283
 	}
2163 2284
 
2164 2285
 	// Are there attachments already uploaded and waiting to be assigned?
@@ -2170,8 +2291,9 @@  discard block
 block discarded – undo
2170 2291
 	}
2171 2292
 
2172 2293
 	// If we had a draft for this, its time to remove it since it was just posted
2173
-	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft']))
2174
-		DeleteDraft($_POST['id_draft']);
2294
+	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft'])) {
2295
+			DeleteDraft($_POST['id_draft']);
2296
+	}
2175 2297
 
2176 2298
 	// Editing or posting an event?
2177 2299
 	if (isset($_POST['calendar']) && (!isset($_REQUEST['eventid']) || $_REQUEST['eventid'] == -1))
@@ -2190,8 +2312,7 @@  discard block
 block discarded – undo
2190 2312
 			'member' => $user_info['id'],
2191 2313
 		);
2192 2314
 		insertEvent($eventOptions);
2193
-	}
2194
-	elseif (isset($_POST['calendar']))
2315
+	} elseif (isset($_POST['calendar']))
2195 2316
 	{
2196 2317
 		$_REQUEST['eventid'] = (int) $_REQUEST['eventid'];
2197 2318
 
@@ -2219,14 +2340,15 @@  discard block
 block discarded – undo
2219 2340
 		}
2220 2341
 
2221 2342
 		// Delete it?
2222
-		if (isset($_REQUEST['deleteevent']))
2223
-			$smcFunc['db_query']('', '
2343
+		if (isset($_REQUEST['deleteevent'])) {
2344
+					$smcFunc['db_query']('', '
2224 2345
 				DELETE FROM {db_prefix}calendar
2225 2346
 				WHERE id_event = {int:id_event}',
2226 2347
 				array(
2227 2348
 					'id_event' => $_REQUEST['eventid'],
2228 2349
 				)
2229 2350
 			);
2351
+		}
2230 2352
 		// ... or just update it?
2231 2353
 		else
2232 2354
 		{
@@ -2268,9 +2390,8 @@  discard block
 block discarded – undo
2268 2390
 			array($user_info['id'], $topic, 0),
2269 2391
 			array('id_member', 'id_topic', 'id_board')
2270 2392
 		);
2271
-	}
2272
-	elseif (!$newTopic)
2273
-		$smcFunc['db_query']('', '
2393
+	} elseif (!$newTopic) {
2394
+			$smcFunc['db_query']('', '
2274 2395
 			DELETE FROM {db_prefix}log_notify
2275 2396
 			WHERE id_member = {int:current_member}
2276 2397
 				AND id_topic = {int:current_topic}',
@@ -2279,16 +2400,20 @@  discard block
 block discarded – undo
2279 2400
 				'current_topic' => $topic,
2280 2401
 			)
2281 2402
 		);
2403
+	}
2282 2404
 
2283 2405
 	// Log an act of moderation - modifying.
2284
-	if (!empty($moderationAction))
2285
-		logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2406
+	if (!empty($moderationAction)) {
2407
+			logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2408
+	}
2286 2409
 
2287
-	if (isset($_POST['lock']) && $_POST['lock'] != 2)
2288
-		logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2410
+	if (isset($_POST['lock']) && $_POST['lock'] != 2) {
2411
+			logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2412
+	}
2289 2413
 
2290
-	if (isset($_POST['sticky']))
2291
-		logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2414
+	if (isset($_POST['sticky'])) {
2415
+			logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2416
+	}
2292 2417
 
2293 2418
 	// Returning to the topic?
2294 2419
 	if (!empty($_REQUEST['goback']))
@@ -2307,26 +2432,31 @@  discard block
 block discarded – undo
2307 2432
 		);
2308 2433
 	}
2309 2434
 
2310
-	if ($board_info['num_topics'] == 0)
2311
-		cache_put_data('board-' . $board, null, 120);
2435
+	if ($board_info['num_topics'] == 0) {
2436
+			cache_put_data('board-' . $board, null, 120);
2437
+	}
2312 2438
 
2313 2439
 	call_integration_hook('integrate_post2_end');
2314 2440
 
2315
-	if (!empty($_POST['announce_topic']) && allowedTo('announce_topic'))
2316
-		redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2441
+	if (!empty($_POST['announce_topic']) && allowedTo('announce_topic')) {
2442
+			redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2443
+	}
2317 2444
 
2318
-	if (!empty($_POST['move']) && allowedTo('move_any'))
2319
-		redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2445
+	if (!empty($_POST['move']) && allowedTo('move_any')) {
2446
+			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2447
+	}
2320 2448
 
2321 2449
 	// Return to post if the mod is on.
2322
-	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback']))
2323
-		redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2324
-	elseif (!empty($_REQUEST['goback']))
2325
-		redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2450
+	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback'])) {
2451
+			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2452
+	} elseif (!empty($_REQUEST['goback'])) {
2453
+			redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2454
+	}
2326 2455
 	// Dut-dut-duh-duh-DUH-duh-dut-duh-duh!  *dances to the Final Fantasy Fanfare...*
2327
-	else
2328
-		redirectexit('board=' . $board . '.0');
2329
-}
2456
+	else {
2457
+			redirectexit('board=' . $board . '.0');
2458
+	}
2459
+	}
2330 2460
 
2331 2461
 /**
2332 2462
  * Handle the announce topic function (action=announce).
@@ -2344,8 +2474,9 @@  discard block
 block discarded – undo
2344 2474
 
2345 2475
 	validateSession();
2346 2476
 
2347
-	if (empty($topic))
2348
-		fatal_lang_error('topic_gone', false);
2477
+	if (empty($topic)) {
2478
+			fatal_lang_error('topic_gone', false);
2479
+	}
2349 2480
 
2350 2481
 	loadLanguage('Post');
2351 2482
 	loadTemplate('Post');
@@ -2372,8 +2503,9 @@  discard block
 block discarded – undo
2372 2503
 	global $txt, $context, $topic, $board_info, $smcFunc;
2373 2504
 
2374 2505
 	$groups = array_merge($board_info['groups'], array(1));
2375
-	foreach ($groups as $id => $group)
2376
-		$groups[$id] = (int) $group;
2506
+	foreach ($groups as $id => $group) {
2507
+			$groups[$id] = (int) $group;
2508
+	}
2377 2509
 
2378 2510
 	$context['groups'] = array();
2379 2511
 	if (in_array(0, $groups))
@@ -2416,8 +2548,9 @@  discard block
 block discarded – undo
2416 2548
 			'group_list' => $groups,
2417 2549
 		)
2418 2550
 	);
2419
-	while ($row = $smcFunc['db_fetch_assoc']($request))
2420
-		$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2551
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2552
+			$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2553
+	}
2421 2554
 	$smcFunc['db_free_result']($request);
2422 2555
 
2423 2556
 	// Get the subject of the topic we're about to announce.
@@ -2459,16 +2592,19 @@  discard block
 block discarded – undo
2459 2592
 	$context['start'] = empty($_REQUEST['start']) ? 0 : (int) $_REQUEST['start'];
2460 2593
 	$groups = array_merge($board_info['groups'], array(1));
2461 2594
 
2462
-	if (isset($_POST['membergroups']))
2463
-		$_POST['who'] = explode(',', $_POST['membergroups']);
2595
+	if (isset($_POST['membergroups'])) {
2596
+			$_POST['who'] = explode(',', $_POST['membergroups']);
2597
+	}
2464 2598
 
2465 2599
 	// Check whether at least one membergroup was selected.
2466
-	if (empty($_POST['who']))
2467
-		fatal_lang_error('no_membergroup_selected');
2600
+	if (empty($_POST['who'])) {
2601
+			fatal_lang_error('no_membergroup_selected');
2602
+	}
2468 2603
 
2469 2604
 	// Make sure all membergroups are integers and can access the board of the announcement.
2470
-	foreach ($_POST['who'] as $id => $mg)
2471
-		$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2605
+	foreach ($_POST['who'] as $id => $mg) {
2606
+			$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2607
+	}
2472 2608
 
2473 2609
 	// Get the topic subject and censor it.
2474 2610
 	$request = $smcFunc['db_query']('', '
@@ -2514,12 +2650,13 @@  discard block
 block discarded – undo
2514 2650
 	if ($smcFunc['db_num_rows']($request) == 0)
2515 2651
 	{
2516 2652
 		logAction('announce_topic', array('topic' => $topic), 'user');
2517
-		if (!empty($_REQUEST['move']) && allowedTo('move_any'))
2518
-			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2519
-		elseif (!empty($_REQUEST['goback']))
2520
-			redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2521
-		else
2522
-			redirectexit('board=' . $board . '.0');
2653
+		if (!empty($_REQUEST['move']) && allowedTo('move_any')) {
2654
+					redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2655
+		} elseif (!empty($_REQUEST['goback'])) {
2656
+					redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2657
+		} else {
2658
+					redirectexit('board=' . $board . '.0');
2659
+		}
2523 2660
 	}
2524 2661
 
2525 2662
 	$announcements = array();
@@ -2538,8 +2675,9 @@  discard block
 block discarded – undo
2538 2675
 	foreach ($rows as $row)
2539 2676
 	{
2540 2677
 		// Force them to have it?
2541
-		if (empty($prefs[$row['id_member']]['announcements']))
2542
-			continue;
2678
+		if (empty($prefs[$row['id_member']]['announcements'])) {
2679
+					continue;
2680
+		}
2543 2681
 
2544 2682
 		$cur_language = empty($row['lngfile']) || empty($modSettings['userLanguage']) ? $language : $row['lngfile'];
2545 2683
 
@@ -2567,8 +2705,9 @@  discard block
 block discarded – undo
2567 2705
 	}
2568 2706
 
2569 2707
 	// For each language send a different mail - low priority...
2570
-	foreach ($announcements as $lang => $mail)
2571
-		sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2708
+	foreach ($announcements as $lang => $mail) {
2709
+			sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2710
+	}
2572 2711
 
2573 2712
 	$context['percentage_done'] = round(100 * $context['start'] / $modSettings['latestMember'], 1);
2574 2713
 
@@ -2578,9 +2717,10 @@  discard block
 block discarded – undo
2578 2717
 	$context['sub_template'] = 'announcement_send';
2579 2718
 
2580 2719
 	// Go back to the correct language for the user ;).
2581
-	if (!empty($modSettings['userLanguage']))
2582
-		loadLanguage('Post');
2583
-}
2720
+	if (!empty($modSettings['userLanguage'])) {
2721
+			loadLanguage('Post');
2722
+	}
2723
+	}
2584 2724
 
2585 2725
 /**
2586 2726
  * Get the topic for display purposes.
@@ -2593,12 +2733,13 @@  discard block
 block discarded – undo
2593 2733
 {
2594 2734
 	global $topic, $modSettings, $context, $smcFunc, $counter, $options;
2595 2735
 
2596
-	if (isset($_REQUEST['xml']))
2597
-		$limit = '
2736
+	if (isset($_REQUEST['xml'])) {
2737
+			$limit = '
2598 2738
 		LIMIT ' . (empty($context['new_replies']) ? '0' : $context['new_replies']);
2599
-	else
2600
-		$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2739
+	} else {
2740
+			$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2601 2741
 		LIMIT ' . (int) $modSettings['topicSummaryPosts'];
2742
+	}
2602 2743
 
2603 2744
 	// If you're modifying, get only those posts before the current one. (otherwise get all.)
2604 2745
 	$request = $smcFunc['db_query']('', '
@@ -2636,8 +2777,9 @@  discard block
 block discarded – undo
2636 2777
 			'is_ignored' => !empty($modSettings['enable_buddylist']) && !empty($options['posts_apply_ignore_list']) && in_array($row['id_member'], $context['user']['ignoreusers']),
2637 2778
 		);
2638 2779
 
2639
-		if (!empty($context['new_replies']))
2640
-			$context['new_replies']--;
2780
+		if (!empty($context['new_replies'])) {
2781
+					$context['new_replies']--;
2782
+		}
2641 2783
 	}
2642 2784
 	$smcFunc['db_free_result']($request);
2643 2785
 }
@@ -2654,8 +2796,9 @@  discard block
 block discarded – undo
2654 2796
 	global $sourcedir, $smcFunc;
2655 2797
 
2656 2798
 	loadLanguage('Post');
2657
-	if (!isset($_REQUEST['xml']))
2658
-		loadTemplate('Post');
2799
+	if (!isset($_REQUEST['xml'])) {
2800
+			loadTemplate('Post');
2801
+	}
2659 2802
 
2660 2803
 	include_once($sourcedir . '/Subs-Post.php');
2661 2804
 
@@ -2686,8 +2829,9 @@  discard block
 block discarded – undo
2686 2829
 	$smcFunc['db_free_result']($request);
2687 2830
 
2688 2831
 	$context['sub_template'] = 'quotefast';
2689
-	if (!empty($row))
2690
-		$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2832
+	if (!empty($row)) {
2833
+			$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2834
+	}
2691 2835
 
2692 2836
 	if (!empty($can_view_post))
2693 2837
 	{
@@ -2720,8 +2864,9 @@  discard block
 block discarded – undo
2720 2864
 		}
2721 2865
 
2722 2866
 		// Remove any nested quotes.
2723
-		if (!empty($modSettings['removeNestedQuotes']))
2724
-			$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2867
+		if (!empty($modSettings['removeNestedQuotes'])) {
2868
+					$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2869
+		}
2725 2870
 
2726 2871
 		$lb = "\n";
2727 2872
 
@@ -2747,14 +2892,14 @@  discard block
 block discarded – undo
2747 2892
 				'time' => '',
2748 2893
 			),
2749 2894
 		);
2750
-	}
2751
-	else
2752
-		$context['quote'] = array(
2895
+	} else {
2896
+			$context['quote'] = array(
2753 2897
 			'xml' => '',
2754 2898
 			'mozilla' => '',
2755 2899
 			'text' => '',
2756 2900
 		);
2757
-}
2901
+	}
2902
+	}
2758 2903
 
2759 2904
 /**
2760 2905
  * Used to edit the body or subject of a message inline
@@ -2766,8 +2911,9 @@  discard block
 block discarded – undo
2766 2911
 	global $user_info, $context, $smcFunc, $language, $board_info;
2767 2912
 
2768 2913
 	// We have to have a topic!
2769
-	if (empty($topic))
2770
-		obExit(false);
2914
+	if (empty($topic)) {
2915
+			obExit(false);
2916
+	}
2771 2917
 
2772 2918
 	checkSession('get');
2773 2919
 	require_once($sourcedir . '/Subs-Post.php');
@@ -2793,31 +2939,35 @@  discard block
 block discarded – undo
2793 2939
 			'guest_id' => 0,
2794 2940
 		)
2795 2941
 	);
2796
-	if ($smcFunc['db_num_rows']($request) == 0)
2797
-		fatal_lang_error('no_board', false);
2942
+	if ($smcFunc['db_num_rows']($request) == 0) {
2943
+			fatal_lang_error('no_board', false);
2944
+	}
2798 2945
 	$row = $smcFunc['db_fetch_assoc']($request);
2799 2946
 	$smcFunc['db_free_result']($request);
2800 2947
 
2801 2948
 	// Change either body or subject requires permissions to modify messages.
2802 2949
 	if (isset($_POST['message']) || isset($_POST['subject']) || isset($_REQUEST['icon']))
2803 2950
 	{
2804
-		if (!empty($row['locked']))
2805
-			isAllowedTo('moderate_board');
2951
+		if (!empty($row['locked'])) {
2952
+					isAllowedTo('moderate_board');
2953
+		}
2806 2954
 
2807 2955
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
2808 2956
 		{
2809
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
2810
-				fatal_lang_error('modify_post_time_passed', false);
2811
-			elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
2812
-				isAllowedTo('modify_replies');
2813
-			else
2814
-				isAllowedTo('modify_own');
2957
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
2958
+							fatal_lang_error('modify_post_time_passed', false);
2959
+			} elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
2960
+							isAllowedTo('modify_replies');
2961
+			} else {
2962
+							isAllowedTo('modify_own');
2963
+			}
2815 2964
 		}
2816 2965
 		// Otherwise, they're locked out; someone who can modify the replies is needed.
2817
-		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
2818
-			isAllowedTo('modify_replies');
2819
-		else
2820
-			isAllowedTo('modify_any');
2966
+		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) {
2967
+					isAllowedTo('modify_replies');
2968
+		} else {
2969
+					isAllowedTo('modify_any');
2970
+		}
2821 2971
 
2822 2972
 		// Only log this action if it wasn't your message.
2823 2973
 		$moderationAction = $row['id_member'] != $user_info['id'];
@@ -2829,10 +2979,10 @@  discard block
 block discarded – undo
2829 2979
 		$_POST['subject'] = strtr($smcFunc['htmlspecialchars']($_POST['subject']), array("\r" => '', "\n" => '', "\t" => ''));
2830 2980
 
2831 2981
 		// Maximum number of characters.
2832
-		if ($smcFunc['strlen']($_POST['subject']) > 100)
2833
-			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2834
-	}
2835
-	elseif (isset($_POST['subject']))
2982
+		if ($smcFunc['strlen']($_POST['subject']) > 100) {
2983
+					$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2984
+		}
2985
+	} elseif (isset($_POST['subject']))
2836 2986
 	{
2837 2987
 		$post_errors[] = 'no_subject';
2838 2988
 		unset($_POST['subject']);
@@ -2844,13 +2994,11 @@  discard block
 block discarded – undo
2844 2994
 		{
2845 2995
 			$post_errors[] = 'no_message';
2846 2996
 			unset($_POST['message']);
2847
-		}
2848
-		elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2997
+		} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2849 2998
 		{
2850 2999
 			$post_errors[] = 'long_message';
2851 3000
 			unset($_POST['message']);
2852
-		}
2853
-		else
3001
+		} else
2854 3002
 		{
2855 3003
 			$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
2856 3004
 
@@ -2866,31 +3014,34 @@  discard block
 block discarded – undo
2866 3014
 
2867 3015
 	if (isset($_POST['lock']))
2868 3016
 	{
2869
-		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member']))
2870
-			unset($_POST['lock']);
2871
-		elseif (!allowedTo('lock_any'))
3017
+		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member'])) {
3018
+					unset($_POST['lock']);
3019
+		} elseif (!allowedTo('lock_any'))
2872 3020
 		{
2873
-			if ($row['locked'] == 1)
2874
-				unset($_POST['lock']);
2875
-			else
2876
-				$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
3021
+			if ($row['locked'] == 1) {
3022
+							unset($_POST['lock']);
3023
+			} else {
3024
+							$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
3025
+			}
3026
+		} elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked']) {
3027
+					unset($_POST['lock']);
3028
+		} else {
3029
+					$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2877 3030
 		}
2878
-		elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked'])
2879
-			unset($_POST['lock']);
2880
-		else
2881
-			$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2882 3031
 	}
2883 3032
 
2884
-	if (isset($_POST['sticky']) && !allowedTo('make_sticky'))
2885
-		unset($_POST['sticky']);
3033
+	if (isset($_POST['sticky']) && !allowedTo('make_sticky')) {
3034
+			unset($_POST['sticky']);
3035
+	}
2886 3036
 
2887 3037
 	if (isset($_POST['modify_reason']))
2888 3038
 	{
2889 3039
 		$_POST['modify_reason'] = strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
2890 3040
 
2891 3041
 		// Maximum number of characters.
2892
-		if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
2893
-			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
3042
+		if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
3043
+					$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
3044
+		}
2894 3045
 	}
2895 3046
 
2896 3047
 	if (empty($post_errors))
@@ -2927,8 +3078,9 @@  discard block
 block discarded – undo
2927 3078
 			}
2928 3079
 		}
2929 3080
 		// If nothing was changed there's no need to add an entry to the moderation log.
2930
-		else
2931
-			$moderationAction = false;
3081
+		else {
3082
+					$moderationAction = false;
3083
+		}
2932 3084
 
2933 3085
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2934 3086
 
@@ -2946,9 +3098,9 @@  discard block
 block discarded – undo
2946 3098
 			// Get the proper (default language) response prefix first.
2947 3099
 			if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
2948 3100
 			{
2949
-				if ($language === $user_info['language'])
2950
-					$context['response_prefix'] = $txt['response_prefix'];
2951
-				else
3101
+				if ($language === $user_info['language']) {
3102
+									$context['response_prefix'] = $txt['response_prefix'];
3103
+				} else
2952 3104
 				{
2953 3105
 					loadLanguage('index', $language, false);
2954 3106
 					$context['response_prefix'] = $txt['response_prefix'];
@@ -2970,8 +3122,9 @@  discard block
 block discarded – undo
2970 3122
 			);
2971 3123
 		}
2972 3124
 
2973
-		if (!empty($moderationAction))
2974
-			logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3125
+		if (!empty($moderationAction)) {
3126
+					logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3127
+		}
2975 3128
 	}
2976 3129
 
2977 3130
 	if (isset($_REQUEST['xml']))
@@ -3012,8 +3165,7 @@  discard block
 block discarded – undo
3012 3165
 			);
3013 3166
 
3014 3167
 			censorText($context['message']['subject']);
3015
-		}
3016
-		else
3168
+		} else
3017 3169
 		{
3018 3170
 			$context['message'] = array(
3019 3171
 				'id' => $row['id_msg'],
@@ -3025,15 +3177,16 @@  discard block
 block discarded – undo
3025 3177
 			loadLanguage('Errors');
3026 3178
 			foreach ($post_errors as $post_error)
3027 3179
 			{
3028
-				if ($post_error == 'long_message')
3029
-					$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
3030
-				else
3031
-					$context['message']['errors'][] = $txt['error_' . $post_error];
3180
+				if ($post_error == 'long_message') {
3181
+									$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
3182
+				} else {
3183
+									$context['message']['errors'][] = $txt['error_' . $post_error];
3184
+				}
3032 3185
 			}
3033 3186
 		}
3187
+	} else {
3188
+			obExit(false);
3189
+	}
3034 3190
 	}
3035
-	else
3036
-		obExit(false);
3037
-}
3038 3191
 
3039 3192
 ?>
3040 3193
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/ManageMembergroups.php 1 patch
Braces   +128 added lines, -88 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 
20 21
 /**
@@ -44,8 +45,9 @@  discard block
 block discarded – undo
44 45
 	$_REQUEST['sa'] = isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']]) ? $_REQUEST['sa'] : (allowedTo('manage_membergroups') ? 'index' : 'settings');
45 46
 
46 47
 	// Is it elsewhere?
47
-	if (isset($subActions[$_REQUEST['sa']][2]))
48
-		require_once($sourcedir . '/' . $subActions[$_REQUEST['sa']][2]);
48
+	if (isset($subActions[$_REQUEST['sa']][2])) {
49
+			require_once($sourcedir . '/' . $subActions[$_REQUEST['sa']][2]);
50
+	}
49 51
 
50 52
 	// Do the permission check, you might not be allowed her.
51 53
 	isAllowedTo($subActions[$_REQUEST['sa']][1]);
@@ -104,19 +106,20 @@  discard block
 block discarded – undo
104 106
 					'function' => function($rowData) use ($scripturl)
105 107
 					{
106 108
 						// Since the moderator group has no explicit members, no link is needed.
107
-						if ($rowData['id_group'] == 3)
108
-							$group_name = $rowData['group_name'];
109
-						else
109
+						if ($rowData['id_group'] == 3) {
110
+													$group_name = $rowData['group_name'];
111
+						} else
110 112
 						{
111 113
 							$color_style = empty($rowData['online_color']) ? '' : sprintf(' style="color: %1$s;"', $rowData['online_color']);
112 114
 							$group_name = sprintf('<a href="%1$s?action=admin;area=membergroups;sa=members;group=%2$d"%3$s>%4$s</a>', $scripturl, $rowData['id_group'], $color_style, $rowData['group_name']);
113 115
 						}
114 116
 
115 117
 						// Add a help option for moderator and administrator.
116
-						if ($rowData['id_group'] == 1)
117
-							$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
118
-						elseif ($rowData['id_group'] == 3)
119
-							$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
118
+						if ($rowData['id_group'] == 1) {
119
+													$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
120
+						} elseif ($rowData['id_group'] == 3) {
121
+													$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
122
+						}
120 123
 
121 124
 						return $group_name;
122 125
 					},
@@ -329,12 +332,14 @@  discard block
 block discarded – undo
329 332
 		call_integration_hook('integrate_add_membergroup', array($id_group, $postCountBasedGroup));
330 333
 
331 334
 		// Update the post groups now, if this is a post group!
332
-		if (isset($_POST['min_posts']))
333
-			updateStats('postgroups');
335
+		if (isset($_POST['min_posts'])) {
336
+					updateStats('postgroups');
337
+		}
334 338
 
335 339
 		// You cannot set permissions for post groups if they are disabled.
336
-		if ($postCountBasedGroup && empty($modSettings['permission_enable_postgroups']))
337
-			$_POST['perm_type'] = '';
340
+		if ($postCountBasedGroup && empty($modSettings['permission_enable_postgroups'])) {
341
+					$_POST['perm_type'] = '';
342
+		}
338 343
 
339 344
 		if ($_POST['perm_type'] == 'predefined')
340 345
 		{
@@ -364,8 +369,9 @@  discard block
 block discarded – undo
364 369
 				$smcFunc['db_free_result']($request);
365 370
 
366 371
 				// Protected groups are... well, protected!
367
-				if ($copy_type == 1)
368
-					fatal_lang_error('membergroup_does_not_exist');
372
+				if ($copy_type == 1) {
373
+									fatal_lang_error('membergroup_does_not_exist');
374
+				}
369 375
 			}
370 376
 
371 377
 			// Don't allow copying of a real priviledged person!
@@ -383,18 +389,20 @@  discard block
 block discarded – undo
383 389
 			$inserts = array();
384 390
 			while ($row = $smcFunc['db_fetch_assoc']($request))
385 391
 			{
386
-				if (empty($context['illegal_permissions']) || !in_array($row['permission'], $context['illegal_permissions']))
387
-					$inserts[] = array($id_group, $row['permission'], $row['add_deny']);
392
+				if (empty($context['illegal_permissions']) || !in_array($row['permission'], $context['illegal_permissions'])) {
393
+									$inserts[] = array($id_group, $row['permission'], $row['add_deny']);
394
+				}
388 395
 			}
389 396
 			$smcFunc['db_free_result']($request);
390 397
 
391
-			if (!empty($inserts))
392
-				$smcFunc['db_insert']('insert',
398
+			if (!empty($inserts)) {
399
+							$smcFunc['db_insert']('insert',
393 400
 					'{db_prefix}permissions',
394 401
 					array('id_group' => 'int', 'permission' => 'string', 'add_deny' => 'int'),
395 402
 					$inserts,
396 403
 					array('id_group', 'permission')
397 404
 				);
405
+			}
398 406
 
399 407
 			$request = $smcFunc['db_query']('', '
400 408
 				SELECT id_profile, permission, add_deny
@@ -405,17 +413,19 @@  discard block
 block discarded – undo
405 413
 				)
406 414
 			);
407 415
 			$inserts = array();
408
-			while ($row = $smcFunc['db_fetch_assoc']($request))
409
-				$inserts[] = array($id_group, $row['id_profile'], $row['permission'], $row['add_deny']);
416
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
417
+							$inserts[] = array($id_group, $row['id_profile'], $row['permission'], $row['add_deny']);
418
+			}
410 419
 			$smcFunc['db_free_result']($request);
411 420
 
412
-			if (!empty($inserts))
413
-				$smcFunc['db_insert']('insert',
421
+			if (!empty($inserts)) {
422
+							$smcFunc['db_insert']('insert',
414 423
 					'{db_prefix}board_permissions',
415 424
 					array('id_group' => 'int', 'id_profile' => 'int', 'permission' => 'string', 'add_deny' => 'int'),
416 425
 					$inserts,
417 426
 					array('id_group', 'id_profile', 'permission')
418 427
 				);
428
+			}
419 429
 
420 430
 			// Also get some membergroup information if we're copying and not copying from guests...
421 431
 			if ($copy_id > 0 && $_POST['perm_type'] == 'copy')
@@ -468,14 +478,15 @@  discard block
 block discarded – undo
468 478
 		$changed_boards['allow'] = array();
469 479
 		$changed_boards['deny'] = array();
470 480
 		$changed_boards['ignore'] = array();
471
-		foreach ($accesses as $group_id => $action)
472
-			$changed_boards[$action][] = (int) $group_id;
481
+		foreach ($accesses as $group_id => $action) {
482
+					$changed_boards[$action][] = (int) $group_id;
483
+		}
473 484
 
474 485
 		foreach (array('allow', 'deny') as $board_action)
475 486
 		{
476 487
 			// Only do this if they have special access requirements.
477
-			if (!empty($changed_boards[$board_action]))
478
-				$smcFunc['db_query']('', '
488
+			if (!empty($changed_boards[$board_action])) {
489
+							$smcFunc['db_query']('', '
479 490
 					UPDATE {db_prefix}boards
480 491
 					SET {raw:column} = CASE WHEN {raw:column} = {string:blank_string} THEN {string:group_id_string} ELSE CONCAT({raw:column}, {string:comma_group}) END
481 492
 					WHERE id_board IN ({array_int:board_list})',
@@ -487,11 +498,13 @@  discard block
 block discarded – undo
487 498
 						'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups',
488 499
 					)
489 500
 				);
501
+			}
490 502
 		}
491 503
 
492 504
 		// If this is joinable then set it to show group membership in people's profiles.
493
-		if (empty($modSettings['show_group_membership']) && $_POST['group_type'] > 1)
494
-			updateSettings(array('show_group_membership' => 1));
505
+		if (empty($modSettings['show_group_membership']) && $_POST['group_type'] > 1) {
506
+					updateSettings(array('show_group_membership' => 1));
507
+		}
495 508
 
496 509
 		// Rebuild the group cache.
497 510
 		updateSettings(array(
@@ -512,8 +525,9 @@  discard block
 block discarded – undo
512 525
 	$context['undefined_group'] = !isset($_REQUEST['postgroup']) && !isset($_REQUEST['generalgroup']);
513 526
 	$context['allow_protected'] = allowedTo('admin_forum');
514 527
 
515
-	if (!empty($modSettings['deny_boards_access']))
516
-		loadLanguage('ManagePermissions');
528
+	if (!empty($modSettings['deny_boards_access'])) {
529
+			loadLanguage('ManagePermissions');
530
+	}
517 531
 
518 532
 	$result = $smcFunc['db_query']('', '
519 533
 		SELECT id_group, group_name
@@ -530,11 +544,12 @@  discard block
 block discarded – undo
530 544
 		)
531 545
 	);
532 546
 	$context['groups'] = array();
533
-	while ($row = $smcFunc['db_fetch_assoc']($result))
534
-		$context['groups'][] = array(
547
+	while ($row = $smcFunc['db_fetch_assoc']($result)) {
548
+			$context['groups'][] = array(
535 549
 			'id' => $row['id_group'],
536 550
 			'name' => $row['group_name']
537 551
 		);
552
+	}
538 553
 	$smcFunc['db_free_result']($result);
539 554
 
540 555
 	$request = $smcFunc['db_query']('', '
@@ -551,12 +566,13 @@  discard block
 block discarded – undo
551 566
 	while ($row = $smcFunc['db_fetch_assoc']($request))
552 567
 	{
553 568
 		// This category hasn't been set up yet..
554
-		if (!isset($context['categories'][$row['id_cat']]))
555
-			$context['categories'][$row['id_cat']] = array(
569
+		if (!isset($context['categories'][$row['id_cat']])) {
570
+					$context['categories'][$row['id_cat']] = array(
556 571
 				'id' => $row['id_cat'],
557 572
 				'name' => $row['cat_name'],
558 573
 				'boards' => array()
559 574
 			);
575
+		}
560 576
 
561 577
 		// Set this board up, and let the template know when it's a child.  (indent them..)
562 578
 		$context['categories'][$row['id_cat']]['boards'][$row['id_board']] = array(
@@ -604,8 +620,9 @@  discard block
 block discarded – undo
604 620
 	require_once($sourcedir . '/Subs-Membergroups.php');
605 621
 	$result = deleteMembergroups((int) $_REQUEST['group']);
606 622
 	// Need to throw a warning if it went wrong, but this is the only one we have a message for...
607
-	if ($result === 'group_cannot_delete_sub')
608
-		fatal_lang_error('membergroups_cannot_delete_paid', false);
623
+	if ($result === 'group_cannot_delete_sub') {
624
+			fatal_lang_error('membergroups_cannot_delete_paid', false);
625
+	}
609 626
 
610 627
 	// Go back to the membergroup index.
611 628
 	redirectexit('action=admin;area=membergroups;');
@@ -627,8 +644,9 @@  discard block
 block discarded – undo
627 644
 
628 645
 	$_REQUEST['group'] = isset($_REQUEST['group']) && $_REQUEST['group'] > 0 ? (int) $_REQUEST['group'] : 0;
629 646
 
630
-	if (!empty($modSettings['deny_boards_access']))
631
-		loadLanguage('ManagePermissions');
647
+	if (!empty($modSettings['deny_boards_access'])) {
648
+			loadLanguage('ManagePermissions');
649
+	}
632 650
 
633 651
 	// Make sure this group is editable.
634 652
 	if (!empty($_REQUEST['group']))
@@ -650,8 +668,9 @@  discard block
 block discarded – undo
650 668
 	}
651 669
 
652 670
 	// Now, do we have a valid id?
653
-	if (empty($_REQUEST['group']))
654
-		fatal_lang_error('membergroup_does_not_exist', false);
671
+	if (empty($_REQUEST['group'])) {
672
+			fatal_lang_error('membergroup_does_not_exist', false);
673
+	}
655 674
 
656 675
 	// People who can manage boards are a bit special.
657 676
 	require_once($sourcedir . '/Subs-Members.php');
@@ -682,8 +701,9 @@  discard block
 block discarded – undo
682 701
 		require_once($sourcedir . '/Subs-Membergroups.php');
683 702
 		$result = deleteMembergroups($_REQUEST['group']);
684 703
 		// Need to throw a warning if it went wrong, but this is the only one we have a message for...
685
-		if ($result === 'group_cannot_delete_sub')
686
-			fatal_lang_error('membergroups_cannot_delete_paid', false);
704
+		if ($result === 'group_cannot_delete_sub') {
705
+					fatal_lang_error('membergroups_cannot_delete_paid', false);
706
+		}
687 707
 
688 708
 		redirectexit('action=admin;area=membergroups;');
689 709
 	}
@@ -760,16 +780,18 @@  discard block
 block discarded – undo
760 780
 				$request = $smcFunc['db_query']('', '
761 781
 					SELECT id_board
762 782
 					FROM {db_prefix}boards');
763
-				while ($row = $smcFunc['db_fetch_assoc']($request))
764
-					$accesses[(int) $row['id_board']] = 'allow';
783
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
784
+									$accesses[(int) $row['id_board']] = 'allow';
785
+				}
765 786
 				$smcFunc['db_free_result']($request);
766 787
 			}
767 788
 
768 789
 			$changed_boards['allow'] = array();
769 790
 			$changed_boards['deny'] = array();
770 791
 			$changed_boards['ignore'] = array();
771
-			foreach ($accesses as $group_id => $action)
772
-				$changed_boards[$action][] = (int) $group_id;
792
+			foreach ($accesses as $group_id => $action) {
793
+							$changed_boards[$action][] = (int) $group_id;
794
+			}
773 795
 
774 796
 			foreach (array('allow', 'deny') as $board_action)
775 797
 			{
@@ -785,8 +807,8 @@  discard block
 block discarded – undo
785 807
 						'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups',
786 808
 					)
787 809
 				);
788
-				while ($row = $smcFunc['db_fetch_assoc']($request))
789
-					$smcFunc['db_query']('', '
810
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
811
+									$smcFunc['db_query']('', '
790 812
 						UPDATE {db_prefix}boards
791 813
 						SET {raw:column} = {string:member_group_access}
792 814
 						WHERE id_board = {int:current_board}',
@@ -796,11 +818,12 @@  discard block
 block discarded – undo
796 818
 							'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups',
797 819
 						)
798 820
 					);
821
+				}
799 822
 				$smcFunc['db_free_result']($request);
800 823
 
801 824
 				// Add the membergroup to all boards that hadn't been set yet.
802
-				if (!empty($changed_boards[$board_action]))
803
-					$smcFunc['db_query']('', '
825
+				if (!empty($changed_boards[$board_action])) {
826
+									$smcFunc['db_query']('', '
804 827
 						UPDATE {db_prefix}boards
805 828
 						SET {raw:column} = CASE WHEN {raw:column} = {string:blank_string} THEN {string:group_id_string} ELSE CONCAT({raw:column}, {string:comma_group}) END
806 829
 						WHERE id_board IN ({array_int:board_list})
@@ -814,6 +837,7 @@  discard block
 block discarded – undo
814 837
 							'column' => $board_action == 'allow' ? 'member_groups' : 'deny_member_groups',
815 838
 						)
816 839
 					);
840
+				}
817 841
 			}
818 842
 		}
819 843
 
@@ -839,12 +863,14 @@  discard block
 block discarded – undo
839 863
 				)
840 864
 			);
841 865
 			$updates = array();
842
-			while ($row = $smcFunc['db_fetch_assoc']($request))
843
-				$updates[$row['additional_groups']][] = $row['id_member'];
866
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
867
+							$updates[$row['additional_groups']][] = $row['id_member'];
868
+			}
844 869
 			$smcFunc['db_free_result']($request);
845 870
 
846
-			foreach ($updates as $additional_groups => $memberArray)
847
-				updateMemberData($memberArray, array('additional_groups' => implode(',', array_diff(explode(',', $additional_groups), array((int) $_REQUEST['group'])))));
871
+			foreach ($updates as $additional_groups => $memberArray) {
872
+							updateMemberData($memberArray, array('additional_groups' => implode(',', array_diff(explode(',', $additional_groups), array((int) $_REQUEST['group'])))));
873
+			}
848 874
 
849 875
 			// Sorry, but post groups can't moderate boards
850 876
 			$smcFunc['db_query']('', '
@@ -854,8 +880,7 @@  discard block
 block discarded – undo
854 880
 					'current_group' => (int) $_REQUEST['group'],
855 881
 				)
856 882
 			);
857
-		}
858
-		elseif ($_REQUEST['group'] != 3)
883
+		} elseif ($_REQUEST['group'] != 3)
859 884
 		{
860 885
 			// Making it a hidden group? If so remove everyone with it as primary group (Actually, just make them additional).
861 886
 			if ($_POST['group_hidden'] == 2)
@@ -870,8 +895,9 @@  discard block
 block discarded – undo
870 895
 					)
871 896
 				);
872 897
 				$updates = array();
873
-				while ($row = $smcFunc['db_fetch_assoc']($request))
874
-					$updates[$row['additional_groups']][] = $row['id_member'];
898
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
899
+									$updates[$row['additional_groups']][] = $row['id_member'];
900
+				}
875 901
 				$smcFunc['db_free_result']($request);
876 902
 
877 903
 				foreach ($updates as $additional_groups => $memberArray)
@@ -913,8 +939,9 @@  discard block
 block discarded – undo
913 939
 			$smcFunc['db_free_result']($request);
914 940
 
915 941
 			// Do we need to update the setting?
916
-			if ((empty($modSettings['show_group_membership']) && $have_joinable) || (!empty($modSettings['show_group_membership']) && !$have_joinable))
917
-				updateSettings(array('show_group_membership' => $have_joinable ? 1 : 0));
942
+			if ((empty($modSettings['show_group_membership']) && $have_joinable) || (!empty($modSettings['show_group_membership']) && !$have_joinable)) {
943
+							updateSettings(array('show_group_membership' => $have_joinable ? 1 : 0));
944
+			}
918 945
 		}
919 946
 
920 947
 		// Do we need to set inherited permissions?
@@ -947,8 +974,9 @@  discard block
 block discarded – undo
947 974
 				{
948 975
 					$moderators[$k] = trim($moderators[$k]);
949 976
 
950
-					if (strlen($moderators[$k]) == 0)
951
-						unset($moderators[$k]);
977
+					if (strlen($moderators[$k]) == 0) {
978
+											unset($moderators[$k]);
979
+					}
952 980
 				}
953 981
 
954 982
 				// Find all the id_member's for the member_name's in the list.
@@ -964,8 +992,9 @@  discard block
 block discarded – undo
964 992
 							'count' => count($moderators),
965 993
 						)
966 994
 					);
967
-					while ($row = $smcFunc['db_fetch_assoc']($request))
968
-						$group_moderators[] = $row['id_member'];
995
+					while ($row = $smcFunc['db_fetch_assoc']($request)) {
996
+											$group_moderators[] = $row['id_member'];
997
+					}
969 998
 					$smcFunc['db_free_result']($request);
970 999
 				}
971 1000
 			}
@@ -973,8 +1002,9 @@  discard block
 block discarded – undo
973 1002
 			if (!empty($_POST['moderator_list']))
974 1003
 			{
975 1004
 				$moderators = array();
976
-				foreach ($_POST['moderator_list'] as $moderator)
977
-					$moderators[] = (int) $moderator;
1005
+				foreach ($_POST['moderator_list'] as $moderator) {
1006
+									$moderators[] = (int) $moderator;
1007
+				}
978 1008
 
979 1009
 				if (!empty($moderators))
980 1010
 				{
@@ -988,8 +1018,9 @@  discard block
 block discarded – undo
988 1018
 							'num_moderators' => count($moderators),
989 1019
 						)
990 1020
 					);
991
-					while ($row = $smcFunc['db_fetch_assoc']($request))
992
-						$group_moderators[] = $row['id_member'];
1021
+					while ($row = $smcFunc['db_fetch_assoc']($request)) {
1022
+											$group_moderators[] = $row['id_member'];
1023
+					}
993 1024
 					$smcFunc['db_free_result']($request);
994 1025
 				}
995 1026
 			}
@@ -1001,8 +1032,9 @@  discard block
 block discarded – undo
1001 1032
 			if (!empty($group_moderators))
1002 1033
 			{
1003 1034
 				$mod_insert = array();
1004
-				foreach ($group_moderators as $moderator)
1005
-					$mod_insert[] = array($_REQUEST['group'], $moderator);
1035
+				foreach ($group_moderators as $moderator) {
1036
+									$mod_insert[] = array($_REQUEST['group'], $moderator);
1037
+				}
1006 1038
 
1007 1039
 				$smcFunc['db_insert']('insert',
1008 1040
 					'{db_prefix}group_moderators',
@@ -1036,8 +1068,9 @@  discard block
 block discarded – undo
1036 1068
 			'current_group' => (int) $_REQUEST['group'],
1037 1069
 		)
1038 1070
 	);
1039
-	if ($smcFunc['db_num_rows']($request) == 0)
1040
-		fatal_lang_error('membergroup_does_not_exist', false);
1071
+	if ($smcFunc['db_num_rows']($request) == 0) {
1072
+			fatal_lang_error('membergroup_does_not_exist', false);
1073
+	}
1041 1074
 	$row = $smcFunc['db_fetch_assoc']($request);
1042 1075
 	$smcFunc['db_free_result']($request);
1043 1076
 
@@ -1074,14 +1107,16 @@  discard block
 block discarded – undo
1074 1107
 		)
1075 1108
 	);
1076 1109
 	$context['group']['moderators'] = array();
1077
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1078
-		$context['group']['moderators'][$row['id_member']] = $row['real_name'];
1110
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
1111
+			$context['group']['moderators'][$row['id_member']] = $row['real_name'];
1112
+	}
1079 1113
 	$smcFunc['db_free_result']($request);
1080 1114
 
1081 1115
 	$context['group']['moderator_list'] = empty($context['group']['moderators']) ? '' : '&quot;' . implode('&quot;, &quot;', $context['group']['moderators']) . '&quot;';
1082 1116
 
1083
-	if (!empty($context['group']['moderators']))
1084
-		list ($context['group']['last_moderator_id']) = array_slice(array_keys($context['group']['moderators']), -1);
1117
+	if (!empty($context['group']['moderators'])) {
1118
+			list ($context['group']['last_moderator_id']) = array_slice(array_keys($context['group']['moderators']), -1);
1119
+	}
1085 1120
 
1086 1121
 	// Get a list of boards this membergroup is allowed to see.
1087 1122
 	$context['boards'] = array();
@@ -1101,12 +1136,13 @@  discard block
 block discarded – undo
1101 1136
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1102 1137
 		{
1103 1138
 			// This category hasn't been set up yet..
1104
-			if (!isset($context['categories'][$row['id_cat']]))
1105
-				$context['categories'][$row['id_cat']] = array(
1139
+			if (!isset($context['categories'][$row['id_cat']])) {
1140
+							$context['categories'][$row['id_cat']] = array(
1106 1141
 					'id' => $row['id_cat'],
1107 1142
 					'name' => $row['cat_name'],
1108 1143
 					'boards' => array()
1109 1144
 				);
1145
+			}
1110 1146
 
1111 1147
 			// Set this board up, and let the template know when it's a child.  (indent them..)
1112 1148
 			$context['categories'][$row['id_cat']]['boards'][$row['id_board']] = array(
@@ -1154,19 +1190,22 @@  discard block
 block discarded – undo
1154 1190
 				$image_info = getimagesize($settings['default_theme_dir'] . '/images/membericons/' . $value);
1155 1191
 
1156 1192
 				// If this is bigger than 128 in width or 32 in height, skip this one.
1157
-				if ($image_info == false || $image_info[0] > 128 || $image_info[1] > 32)
1158
-					continue;
1193
+				if ($image_info == false || $image_info[0] > 128 || $image_info[1] > 32) {
1194
+									continue;
1195
+				}
1159 1196
 
1160 1197
 				// Else it's valid. Add it in.
1161
-				else
1162
-					$context['possible_icons'][] = $value;
1198
+				else {
1199
+									$context['possible_icons'][] = $value;
1200
+				}
1163 1201
 			}
1164 1202
 		}
1165 1203
 	}
1166 1204
 
1167 1205
 	// Insert our JS, if we have possible icons.
1168
-	if (!empty($context['possible_icons']))
1169
-		loadJavaScriptFile('icondropdown.js', array('validate' => true, 'minimize' => true), 'smf_icondropdown');
1206
+	if (!empty($context['possible_icons'])) {
1207
+			loadJavaScriptFile('icondropdown.js', array('validate' => true, 'minimize' => true), 'smf_icondropdown');
1208
+	}
1170 1209
 
1171 1210
 	loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest');
1172 1211
 
@@ -1188,8 +1227,9 @@  discard block
 block discarded – undo
1188 1227
 		)
1189 1228
 	);
1190 1229
 	$context['inheritable_groups'] = array();
1191
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1192
-		$context['inheritable_groups'][$row['id_group']] = $row['group_name'];
1230
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
1231
+			$context['inheritable_groups'][$row['id_group']] = $row['group_name'];
1232
+	}
1193 1233
 	$smcFunc['db_free_result']($request);
1194 1234
 
1195 1235
 	call_integration_hook('integrate_view_membergroup');
Please login to merge, or discard this patch.
Sources/PersonalMessage.php 1 patch
Braces   +633 added lines, -471 removed lines patch added patch discarded remove patch
@@ -15,8 +15,9 @@  discard block
 block discarded – undo
15 15
  * @version 2.1 Beta 4
16 16
  */
17 17
 
18
-if (!defined('SMF'))
18
+if (!defined('SMF')) {
19 19
 	die('No direct access...');
20
+}
20 21
 
21 22
 /**
22 23
  * This helps organize things...
@@ -37,13 +38,14 @@  discard block
 block discarded – undo
37 38
 
38 39
 	loadLanguage('PersonalMessage+Drafts');
39 40
 
40
-	if (!isset($_REQUEST['xml']))
41
-		loadTemplate('PersonalMessage');
41
+	if (!isset($_REQUEST['xml'])) {
42
+			loadTemplate('PersonalMessage');
43
+	}
42 44
 
43 45
 	// Load up the members maximum message capacity.
44
-	if ($user_info['is_admin'])
45
-		$context['message_limit'] = 0;
46
-	elseif (($context['message_limit'] = cache_get_data('msgLimit:' . $user_info['id'], 360)) === null)
46
+	if ($user_info['is_admin']) {
47
+			$context['message_limit'] = 0;
48
+	} elseif (($context['message_limit'] = cache_get_data('msgLimit:' . $user_info['id'], 360)) === null)
47 49
 	{
48 50
 		// @todo Why do we do this?  It seems like if they have any limit we should use it.
49 51
 		$request = $smcFunc['db_query']('', '
@@ -78,8 +80,9 @@  discard block
 block discarded – undo
78 80
 	}
79 81
 
80 82
 	// a previous message was sent successfully? show a small indication.
81
-	if (isset($_GET['done']) && ($_GET['done'] == 'sent'))
82
-		$context['pm_sent'] = true;
83
+	if (isset($_GET['done']) && ($_GET['done'] == 'sent')) {
84
+			$context['pm_sent'] = true;
85
+	}
83 86
 
84 87
 	$context['labels'] = array();
85 88
 
@@ -210,11 +213,11 @@  discard block
 block discarded – undo
210 213
 	{
211 214
 		$_REQUEST['sa'] = '';
212 215
 		MessageFolder();
213
-	}
214
-	else
216
+	} else
215 217
 	{
216
-		if (!isset($_REQUEST['xml']) && $_REQUEST['sa'] != 'popup')
217
-			messageIndexBar($_REQUEST['sa']);
218
+		if (!isset($_REQUEST['xml']) && $_REQUEST['sa'] != 'popup') {
219
+					messageIndexBar($_REQUEST['sa']);
220
+		}
218 221
 
219 222
 		call_helper($subActions[$_REQUEST['sa']]);
220 223
 	}
@@ -291,16 +294,17 @@  discard block
 block discarded – undo
291 294
 	);
292 295
 
293 296
 	// Handle labels.
294
-	if (empty($context['currently_using_labels']))
295
-		unset($pm_areas['labels']);
296
-	else
297
+	if (empty($context['currently_using_labels'])) {
298
+			unset($pm_areas['labels']);
299
+	} else
297 300
 	{
298 301
 		// Note we send labels by id as it will have less problems in the querystring.
299 302
 		$unread_in_labels = 0;
300 303
 		foreach ($context['labels'] as $label)
301 304
 		{
302
-			if ($label['id'] == -1)
303
-				continue;
305
+			if ($label['id'] == -1) {
306
+							continue;
307
+			}
304 308
 
305 309
 			// Count the amount of unread items in labels.
306 310
 			$unread_in_labels += $label['unread_messages'];
@@ -314,8 +318,9 @@  discard block
 block discarded – undo
314 318
 			);
315 319
 		}
316 320
 
317
-		if (!empty($unread_in_labels))
318
-			$pm_areas['labels']['title'] .= ' <span class="amt">' . $unread_in_labels . '</span>';
321
+		if (!empty($unread_in_labels)) {
322
+					$pm_areas['labels']['title'] .= ' <span class="amt">' . $unread_in_labels . '</span>';
323
+		}
319 324
 	}
320 325
 
321 326
 	$pm_areas['folders']['areas']['inbox']['unread_messages'] = &$context['labels'][-1]['unread_messages'];
@@ -353,8 +358,9 @@  discard block
 block discarded – undo
353 358
 	unset($pm_areas);
354 359
 
355 360
 	// No menu means no access.
356
-	if (!$pm_include_data && (!$user_info['is_guest'] || validateSession()))
357
-		fatal_lang_error('no_access', false);
361
+	if (!$pm_include_data && (!$user_info['is_guest'] || validateSession())) {
362
+			fatal_lang_error('no_access', false);
363
+	}
358 364
 
359 365
 	// Make a note of the Unique ID for this menu.
360 366
 	$context['pm_menu_id'] = $context['max_menu_id'];
@@ -365,9 +371,10 @@  discard block
 block discarded – undo
365 371
 	$context['menu_item_selected'] = $current_area;
366 372
 
367 373
 	// Set the template for this area and add the profile layer.
368
-	if (!isset($_REQUEST['xml']))
369
-		$context['template_layers'][] = 'pm';
370
-}
374
+	if (!isset($_REQUEST['xml'])) {
375
+			$context['template_layers'][] = 'pm';
376
+	}
377
+	}
371 378
 
372 379
 /**
373 380
  * The popup for when we ask for the popup from the user.
@@ -399,8 +406,9 @@  discard block
 block discarded – undo
399 406
 		)
400 407
 	);
401 408
 	$pms = array();
402
-	while ($row = $smcFunc['db_fetch_row']($request))
403
-		$pms[] = $row[0];
409
+	while ($row = $smcFunc['db_fetch_row']($request)) {
410
+			$pms[] = $row[0];
411
+	}
404 412
 	$smcFunc['db_free_result']($request);
405 413
 
406 414
 	if (!empty($pms))
@@ -428,8 +436,9 @@  discard block
 block discarded – undo
428 436
 		);
429 437
 		while ($row = $smcFunc['db_fetch_assoc']($request))
430 438
 		{
431
-			if (!empty($row['id_member_from']))
432
-				$senders[] = $row['id_member_from'];
439
+			if (!empty($row['id_member_from'])) {
440
+							$senders[] = $row['id_member_from'];
441
+			}
433 442
 
434 443
 			$row['replied_to_you'] = $row['id_pm'] != $row['id_pm_head'];
435 444
 			$row['time'] = timeformat($row['timestamp']);
@@ -439,13 +448,15 @@  discard block
 block discarded – undo
439 448
 		$smcFunc['db_free_result']($request);
440 449
 
441 450
 		$senders = loadMemberData($senders);
442
-		foreach ($senders as $member)
443
-			loadMemberContext($member);
451
+		foreach ($senders as $member) {
452
+					loadMemberContext($member);
453
+		}
444 454
 
445 455
 		// Having loaded everyone, attach them to the PMs.
446
-		foreach ($context['unread_pms'] as $id_pm => $details)
447
-			if (!empty($memberContext[$details['id_member_from']]))
456
+		foreach ($context['unread_pms'] as $id_pm => $details) {
457
+					if (!empty($memberContext[$details['id_member_from']]))
448 458
 				$context['unread_pms'][$id_pm]['member'] = &$memberContext[$details['id_member_from']];
459
+		}
449 460
 	}
450 461
 }
451 462
 
@@ -465,12 +476,13 @@  discard block
 block discarded – undo
465 476
 	}
466 477
 
467 478
 	// Make sure the starting location is valid.
468
-	if (isset($_GET['start']) && $_GET['start'] != 'new')
469
-		$_GET['start'] = (int) $_GET['start'];
470
-	elseif (!isset($_GET['start']) && !empty($options['view_newest_pm_first']))
471
-		$_GET['start'] = 0;
472
-	else
473
-		$_GET['start'] = 'new';
479
+	if (isset($_GET['start']) && $_GET['start'] != 'new') {
480
+			$_GET['start'] = (int) $_GET['start'];
481
+	} elseif (!isset($_GET['start']) && !empty($options['view_newest_pm_first'])) {
482
+			$_GET['start'] = 0;
483
+	} else {
484
+			$_GET['start'] = 'new';
485
+	}
474 486
 
475 487
 	// Set up some basic theme stuff.
476 488
 	$context['from_or_to'] = $context['folder'] != 'sent' ? 'from' : 'to';
@@ -487,8 +499,7 @@  discard block
 block discarded – undo
487 499
 	{
488 500
 		$labelQuery = '
489 501
 			AND pmr.in_inbox = 1';
490
-	}
491
-	elseif ($context['folder'] != 'sent')
502
+	} elseif ($context['folder'] != 'sent')
492 503
 	{
493 504
 		$labelJoin = '
494 505
 			INNER JOIN {db_prefix}pm_labeled_messages AS pl ON (pl.id_pm = pmr.id_pm)';
@@ -530,22 +541,24 @@  discard block
 block discarded – undo
530 541
 	$txt['delete_all'] = str_replace('PMBOX', $pmbox, $txt['delete_all']);
531 542
 
532 543
 	// Now, build the link tree!
533
-	if ($context['current_label_id'] == -1)
534
-		$context['linktree'][] = array(
544
+	if ($context['current_label_id'] == -1) {
545
+			$context['linktree'][] = array(
535 546
 			'url' => $scripturl . '?action=pm;f=' . $context['folder'],
536 547
 			'name' => $pmbox
537 548
 		);
549
+	}
538 550
 
539 551
 	// Build it further for a label.
540
-	if ($context['current_label_id'] != -1)
541
-		$context['linktree'][] = array(
552
+	if ($context['current_label_id'] != -1) {
553
+			$context['linktree'][] = array(
542 554
 			'url' => $scripturl . '?action=pm;f=' . $context['folder'] . ';l=' . $context['current_label_id'],
543 555
 			'name' => $txt['pm_current_label'] . ': ' . $context['current_label']
544 556
 		);
557
+	}
545 558
 
546 559
 	// Figure out how many messages there are.
547
-	if ($context['folder'] == 'sent')
548
-		$request = $smcFunc['db_query']('', '
560
+	if ($context['folder'] == 'sent') {
561
+			$request = $smcFunc['db_query']('', '
549 562
 			SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ')
550 563
 			FROM {db_prefix}personal_messages AS pm
551 564
 			WHERE pm.id_member_from = {int:current_member}
@@ -555,8 +568,8 @@  discard block
 block discarded – undo
555 568
 				'not_deleted' => 0,
556 569
 			)
557 570
 		);
558
-	else
559
-		$request = $smcFunc['db_query']('', '
571
+	} else {
572
+			$request = $smcFunc['db_query']('', '
560 573
 			SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ')
561 574
 			FROM {db_prefix}pm_recipients AS pmr' . ($context['display_mode'] == 2 ? '
562 575
 				INNER JOIN {db_prefix}personal_messages AS pm ON (pm.id_pm = pmr.id_pm)' : '') . $labelJoin . '
@@ -567,6 +580,7 @@  discard block
 block discarded – undo
567 580
 				'not_deleted' => 0,
568 581
 			)
569 582
 		);
583
+	}
570 584
 	list ($max_messages) = $smcFunc['db_fetch_row']($request);
571 585
 	$smcFunc['db_free_result']($request);
572 586
 
@@ -575,10 +589,11 @@  discard block
 block discarded – undo
575 589
 	$maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages'];
576 590
 
577 591
 	// Start on the last page.
578
-	if (!is_numeric($_GET['start']) || $_GET['start'] >= $max_messages)
579
-		$_GET['start'] = ($max_messages - 1) - (($max_messages - 1) % $maxPerPage);
580
-	elseif ($_GET['start'] < 0)
581
-		$_GET['start'] = 0;
592
+	if (!is_numeric($_GET['start']) || $_GET['start'] >= $max_messages) {
593
+			$_GET['start'] = ($max_messages - 1) - (($max_messages - 1) % $maxPerPage);
594
+	} elseif ($_GET['start'] < 0) {
595
+			$_GET['start'] = 0;
596
+	}
582 597
 
583 598
 	// ... but wait - what if we want to start from a specific message?
584 599
 	if (isset($_GET['pmid']))
@@ -586,19 +601,21 @@  discard block
 block discarded – undo
586 601
 		$pmID = (int) $_GET['pmid'];
587 602
 
588 603
 		// Make sure you have access to this PM.
589
-		if (!isAccessiblePM($pmID, $context['folder'] == 'sent' ? 'outbox' : 'inbox'))
590
-			fatal_lang_error('no_access', false);
604
+		if (!isAccessiblePM($pmID, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) {
605
+					fatal_lang_error('no_access', false);
606
+		}
591 607
 
592 608
 		$context['current_pm'] = $pmID;
593 609
 
594 610
 		// With only one page of PM's we're gonna want page 1.
595
-		if ($max_messages <= $maxPerPage)
596
-			$_GET['start'] = 0;
611
+		if ($max_messages <= $maxPerPage) {
612
+					$_GET['start'] = 0;
613
+		}
597 614
 		// If we pass kstart we assume we're in the right place.
598 615
 		elseif (!isset($_GET['kstart']))
599 616
 		{
600
-			if ($context['folder'] == 'sent')
601
-				$request = $smcFunc['db_query']('', '
617
+			if ($context['folder'] == 'sent') {
618
+							$request = $smcFunc['db_query']('', '
602 619
 					SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ')
603 620
 					FROM {db_prefix}personal_messages
604 621
 					WHERE id_member_from = {int:current_member}
@@ -610,8 +627,8 @@  discard block
 block discarded – undo
610 627
 						'id_pm' => $pmID,
611 628
 					)
612 629
 				);
613
-			else
614
-				$request = $smcFunc['db_query']('', '
630
+			} else {
631
+							$request = $smcFunc['db_query']('', '
615 632
 					SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ')
616 633
 					FROM {db_prefix}pm_recipients AS pmr' . ($context['display_mode'] == 2 ? '
617 634
 						INNER JOIN {db_prefix}personal_messages AS pm ON (pm.id_pm = pmr.id_pm)' : '') . $labelJoin . '
@@ -624,6 +641,7 @@  discard block
 block discarded – undo
624 641
 						'id_pm' => $pmID,
625 642
 					)
626 643
 				);
644
+			}
627 645
 
628 646
 			list ($_GET['start']) = $smcFunc['db_fetch_row']($request);
629 647
 			$smcFunc['db_free_result']($request);
@@ -638,8 +656,9 @@  discard block
 block discarded – undo
638 656
 	{
639 657
 		$pmsg = (int) $_GET['pmsg'];
640 658
 
641
-		if (!isAccessiblePM($pmsg, $context['folder'] == 'sent' ? 'outbox' : 'inbox'))
642
-			fatal_lang_error('no_access', false);
659
+		if (!isAccessiblePM($pmsg, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) {
660
+					fatal_lang_error('no_access', false);
661
+		}
643 662
 	}
644 663
 
645 664
 	// Set up the page index.
@@ -734,8 +753,9 @@  discard block
 block discarded – undo
734 753
 	{
735 754
 		if (!isset($recipients[$row['id_pm']]))
736 755
 		{
737
-			if (isset($row['id_member_from']))
738
-				$posters[$row['id_pm']] = $row['id_member_from'];
756
+			if (isset($row['id_member_from'])) {
757
+							$posters[$row['id_pm']] = $row['id_member_from'];
758
+			}
739 759
 			$pms[$row['id_pm']] = $row['id_pm'];
740 760
 			$recipients[$row['id_pm']] = array(
741 761
 				'to' => array(),
@@ -744,29 +764,33 @@  discard block
 block discarded – undo
744 764
 		}
745 765
 
746 766
 		// Keep track of the last message so we know what the head is without another query!
747
-		if ((empty($pmID) && (empty($options['view_newest_pm_first']) || !isset($lastData))) || empty($lastData) || (!empty($pmID) && $pmID == $row['id_pm']))
748
-			$lastData = array(
767
+		if ((empty($pmID) && (empty($options['view_newest_pm_first']) || !isset($lastData))) || empty($lastData) || (!empty($pmID) && $pmID == $row['id_pm'])) {
768
+					$lastData = array(
749 769
 				'id' => $row['id_pm'],
750 770
 				'head' => $row['id_pm_head'],
751 771
 			);
772
+		}
752 773
 	}
753 774
 	$smcFunc['db_free_result']($request);
754 775
 
755 776
 	// Make sure that we have been given a correct head pm id!
756
-	if ($context['display_mode'] == 2 && !empty($pmID) && $pmID != $lastData['id'])
757
-		fatal_lang_error('no_access', false);
777
+	if ($context['display_mode'] == 2 && !empty($pmID) && $pmID != $lastData['id']) {
778
+			fatal_lang_error('no_access', false);
779
+	}
758 780
 
759 781
 	if (!empty($pms))
760 782
 	{
761 783
 		// Select the correct current message.
762
-		if (empty($pmID))
763
-			$context['current_pm'] = $lastData['id'];
784
+		if (empty($pmID)) {
785
+					$context['current_pm'] = $lastData['id'];
786
+		}
764 787
 
765 788
 		// This is a list of the pm's that are used for "full" display.
766
-		if ($context['display_mode'] == 0)
767
-			$display_pms = $pms;
768
-		else
769
-			$display_pms = array($context['current_pm']);
789
+		if ($context['display_mode'] == 0) {
790
+					$display_pms = $pms;
791
+		} else {
792
+					$display_pms = array($context['current_pm']);
793
+		}
770 794
 
771 795
 		// At this point we know the main id_pm's. But - if we are looking at conversations we need the others!
772 796
 		if ($context['display_mode'] == 2)
@@ -788,16 +812,18 @@  discard block
 block discarded – undo
788 812
 			while ($row = $smcFunc['db_fetch_assoc']($request))
789 813
 			{
790 814
 				// This is, frankly, a joke. We will put in a workaround for people sending to themselves - yawn!
791
-				if ($context['folder'] == 'sent' && $row['id_member_from'] == $user_info['id'] && $row['deleted_by_sender'] == 1)
792
-					continue;
793
-				elseif ($row['id_member'] == $user_info['id'] & $row['deleted'] == 1)
794
-					continue;
815
+				if ($context['folder'] == 'sent' && $row['id_member_from'] == $user_info['id'] && $row['deleted_by_sender'] == 1) {
816
+									continue;
817
+				} elseif ($row['id_member'] == $user_info['id'] & $row['deleted'] == 1) {
818
+									continue;
819
+				}
795 820
 
796
-				if (!isset($recipients[$row['id_pm']]))
797
-					$recipients[$row['id_pm']] = array(
821
+				if (!isset($recipients[$row['id_pm']])) {
822
+									$recipients[$row['id_pm']] = array(
798 823
 						'to' => array(),
799 824
 						'bcc' => array()
800 825
 					);
826
+				}
801 827
 				$display_pms[] = $row['id_pm'];
802 828
 				$posters[$row['id_pm']] = $row['id_member_from'];
803 829
 			}
@@ -848,8 +874,9 @@  discard block
 block discarded – undo
848 874
 				while ($row2 = $smcFunc['db_fetch_assoc']($request2))
849 875
 				{
850 876
 					$l_id = $row2['id_label'];
851
-					if (isset($context['labels'][$l_id]))
852
-						$context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']);
877
+					if (isset($context['labels'][$l_id])) {
878
+											$context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']);
879
+					}
853 880
 				}
854 881
 
855 882
 				$smcFunc['db_free_result']($request2);
@@ -866,9 +893,10 @@  discard block
 block discarded – undo
866 893
 		// Make sure we don't load unnecessary data.
867 894
 		if ($context['display_mode'] == 1)
868 895
 		{
869
-			foreach ($posters as $k => $v)
870
-				if (!in_array($k, $display_pms))
896
+			foreach ($posters as $k => $v) {
897
+							if (!in_array($k, $display_pms))
871 898
 					unset($posters[$k]);
899
+			}
872 900
 		}
873 901
 
874 902
 		// Load any users....
@@ -879,8 +907,9 @@  discard block
 block discarded – undo
879 907
 		{
880 908
 			// Get the order right.
881 909
 			$orderBy = array();
882
-			foreach (array_reverse($pms) as $pm)
883
-				$orderBy[] = 'pm.id_pm = ' . $pm;
910
+			foreach (array_reverse($pms) as $pm) {
911
+							$orderBy[] = 'pm.id_pm = ' . $pm;
912
+			}
884 913
 
885 914
 			// Seperate query for these bits!
886 915
 			$subjects_request = $smcFunc['db_query']('', '
@@ -926,9 +955,9 @@  discard block
 block discarded – undo
926 955
 			// Allow mods to add additional buttons here
927 956
 			call_integration_hook('integrate_conversation_buttons');
928 957
 		}
958
+	} else {
959
+			$messages_request = false;
929 960
 	}
930
-	else
931
-		$messages_request = false;
932 961
 
933 962
 	$context['can_send_pm'] = allowedTo('pm_send');
934 963
 	$context['can_send_email'] = allowedTo('moderate_forum');
@@ -939,11 +968,13 @@  discard block
 block discarded – undo
939 968
 	if ($context['folder'] != 'sent' && !empty($context['labels'][(int) $context['current_label_id']]['unread_messages']))
940 969
 	{
941 970
 		// If the display mode is "old sk00l" do them all...
942
-		if ($context['display_mode'] == 0)
943
-			markMessages(null, $context['current_label_id']);
971
+		if ($context['display_mode'] == 0) {
972
+					markMessages(null, $context['current_label_id']);
973
+		}
944 974
 		// Otherwise do just the current one!
945
-		elseif (!empty($context['current_pm']))
946
-			markMessages($display_pms, $context['current_label_id']);
975
+		elseif (!empty($context['current_pm'])) {
976
+					markMessages($display_pms, $context['current_label_id']);
977
+		}
947 978
 	}
948 979
 }
949 980
 
@@ -961,8 +992,9 @@  discard block
 block discarded – undo
961 992
 
962 993
 	// Count the current message number....
963 994
 	static $counter = null;
964
-	if ($counter === null || $reset)
965
-		$counter = $context['start'];
995
+	if ($counter === null || $reset) {
996
+			$counter = $context['start'];
997
+	}
966 998
 
967 999
 	static $temp_pm_selected = null;
968 1000
 	if ($temp_pm_selected === null)
@@ -1007,19 +1039,22 @@  discard block
 block discarded – undo
1007 1039
 	}
1008 1040
 
1009 1041
 	// Bail if it's false, ie. no messages.
1010
-	if ($messages_request == false)
1011
-		return false;
1042
+	if ($messages_request == false) {
1043
+			return false;
1044
+	}
1012 1045
 
1013 1046
 	// Reset the data?
1014
-	if ($reset == true)
1015
-		return @$smcFunc['db_data_seek']($messages_request, 0);
1047
+	if ($reset == true) {
1048
+			return @$smcFunc['db_data_seek']($messages_request, 0);
1049
+	}
1016 1050
 
1017 1051
 	// Get the next one... bail if anything goes wrong.
1018 1052
 	$message = $smcFunc['db_fetch_assoc']($messages_request);
1019 1053
 	if (!$message)
1020 1054
 	{
1021
-		if ($type != 'subject')
1022
-			$smcFunc['db_free_result']($messages_request);
1055
+		if ($type != 'subject') {
1056
+					$smcFunc['db_free_result']($messages_request);
1057
+		}
1023 1058
 
1024 1059
 		return false;
1025 1060
 	}
@@ -1039,8 +1074,7 @@  discard block
 block discarded – undo
1039 1074
 		$memberContext[$message['id_member_from']]['email'] = '';
1040 1075
 		$memberContext[$message['id_member_from']]['show_email'] = false;
1041 1076
 		$memberContext[$message['id_member_from']]['is_guest'] = true;
1042
-	}
1043
-	else
1077
+	} else
1044 1078
 	{
1045 1079
 		$memberContext[$message['id_member_from']]['can_view_profile'] = allowedTo('profile_view') || ($message['id_member_from'] == $user_info['id'] && !$user_info['is_guest']);
1046 1080
 		$memberContext[$message['id_member_from']]['can_see_warning'] = !isset($context['disabled_fields']['warning_status']) && $memberContext[$message['id_member_from']]['warning_status'] && ($context['user']['can_mod'] || (!empty($modSettings['warning_show']) && ($modSettings['warning_show'] > 1 || $message['id_member_from'] == $user_info['id'])));
@@ -1081,9 +1115,10 @@  discard block
 block discarded – undo
1081 1115
 	$counter++;
1082 1116
 
1083 1117
 	// Any custom profile fields?
1084
-	if (!empty($memberContext[$message['id_member_from']]['custom_fields']))
1085
-		foreach ($memberContext[$message['id_member_from']]['custom_fields'] as $custom)
1118
+	if (!empty($memberContext[$message['id_member_from']]['custom_fields'])) {
1119
+			foreach ($memberContext[$message['id_member_from']]['custom_fields'] as $custom)
1086 1120
 			$output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom;
1121
+	}
1087 1122
 
1088 1123
 	call_integration_hook('integrate_prepare_pm_context', array(&$output, &$message, $counter));
1089 1124
 
@@ -1107,22 +1142,28 @@  discard block
 block discarded – undo
1107 1142
 			$context['search_params'][$k] = $v;
1108 1143
 		}
1109 1144
 	}
1110
-	if (isset($_REQUEST['search']))
1111
-		$context['search_params']['search'] = un_htmlspecialchars($_REQUEST['search']);
1145
+	if (isset($_REQUEST['search'])) {
1146
+			$context['search_params']['search'] = un_htmlspecialchars($_REQUEST['search']);
1147
+	}
1112 1148
 
1113
-	if (isset($context['search_params']['search']))
1114
-		$context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']);
1115
-	if (isset($context['search_params']['userspec']))
1116
-		$context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']);
1149
+	if (isset($context['search_params']['search'])) {
1150
+			$context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']);
1151
+	}
1152
+	if (isset($context['search_params']['userspec'])) {
1153
+			$context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']);
1154
+	}
1117 1155
 
1118
-	if (!empty($context['search_params']['searchtype']))
1119
-		$context['search_params']['searchtype'] = 2;
1156
+	if (!empty($context['search_params']['searchtype'])) {
1157
+			$context['search_params']['searchtype'] = 2;
1158
+	}
1120 1159
 
1121
-	if (!empty($context['search_params']['minage']))
1122
-		$context['search_params']['minage'] = (int) $context['search_params']['minage'];
1160
+	if (!empty($context['search_params']['minage'])) {
1161
+			$context['search_params']['minage'] = (int) $context['search_params']['minage'];
1162
+	}
1123 1163
 
1124
-	if (!empty($context['search_params']['maxage']))
1125
-		$context['search_params']['maxage'] = (int) $context['search_params']['maxage'];
1164
+	if (!empty($context['search_params']['maxage'])) {
1165
+			$context['search_params']['maxage'] = (int) $context['search_params']['maxage'];
1166
+	}
1126 1167
 
1127 1168
 	$context['search_params']['subject_only'] = !empty($context['search_params']['subject_only']);
1128 1169
 	$context['search_params']['show_complete'] = !empty($context['search_params']['show_complete']);
@@ -1149,8 +1190,9 @@  discard block
 block discarded – undo
1149 1190
 		$context['search_errors']['messages'] = array();
1150 1191
 		foreach ($context['search_errors'] as $search_error => $dummy)
1151 1192
 		{
1152
-			if ($search_error == 'messages')
1153
-				continue;
1193
+			if ($search_error == 'messages') {
1194
+							continue;
1195
+			}
1154 1196
 
1155 1197
 			$context['search_errors']['messages'][] = $txt['error_' . $search_error];
1156 1198
 		}
@@ -1172,8 +1214,9 @@  discard block
 block discarded – undo
1172 1214
 	global $scripturl, $modSettings, $user_info, $context, $txt;
1173 1215
 	global $memberContext, $smcFunc;
1174 1216
 
1175
-	if (!empty($context['load_average']) && !empty($modSettings['loadavg_search']) && $context['load_average'] >= $modSettings['loadavg_search'])
1176
-		fatal_lang_error('loadavg_search_disabled', false);
1217
+	if (!empty($context['load_average']) && !empty($modSettings['loadavg_search']) && $context['load_average'] >= $modSettings['loadavg_search']) {
1218
+			fatal_lang_error('loadavg_search_disabled', false);
1219
+	}
1177 1220
 
1178 1221
 	/**
1179 1222
 	 * @todo For the moment force the folder to the inbox.
@@ -1202,35 +1245,40 @@  discard block
 block discarded – undo
1202 1245
 	$context['start'] = isset($_GET['start']) ? (int) $_GET['start'] : 0;
1203 1246
 
1204 1247
 	// Store whether simple search was used (needed if the user wants to do another query).
1205
-	if (!isset($search_params['advanced']))
1206
-		$search_params['advanced'] = empty($_REQUEST['advanced']) ? 0 : 1;
1248
+	if (!isset($search_params['advanced'])) {
1249
+			$search_params['advanced'] = empty($_REQUEST['advanced']) ? 0 : 1;
1250
+	}
1207 1251
 
1208 1252
 	// 1 => 'allwords' (default, don't set as param) / 2 => 'anywords'.
1209
-	if (!empty($search_params['searchtype']) || (!empty($_REQUEST['searchtype']) && $_REQUEST['searchtype'] == 2))
1210
-		$search_params['searchtype'] = 2;
1253
+	if (!empty($search_params['searchtype']) || (!empty($_REQUEST['searchtype']) && $_REQUEST['searchtype'] == 2)) {
1254
+			$search_params['searchtype'] = 2;
1255
+	}
1211 1256
 
1212 1257
 	// Minimum age of messages. Default to zero (don't set param in that case).
1213
-	if (!empty($search_params['minage']) || (!empty($_REQUEST['minage']) && $_REQUEST['minage'] > 0))
1214
-		$search_params['minage'] = !empty($search_params['minage']) ? (int) $search_params['minage'] : (int) $_REQUEST['minage'];
1258
+	if (!empty($search_params['minage']) || (!empty($_REQUEST['minage']) && $_REQUEST['minage'] > 0)) {
1259
+			$search_params['minage'] = !empty($search_params['minage']) ? (int) $search_params['minage'] : (int) $_REQUEST['minage'];
1260
+	}
1215 1261
 
1216 1262
 	// Maximum age of messages. Default to infinite (9999 days: param not set).
1217
-	if (!empty($search_params['maxage']) || (!empty($_REQUEST['maxage']) && $_REQUEST['maxage'] != 9999))
1218
-		$search_params['maxage'] = !empty($search_params['maxage']) ? (int) $search_params['maxage'] : (int) $_REQUEST['maxage'];
1263
+	if (!empty($search_params['maxage']) || (!empty($_REQUEST['maxage']) && $_REQUEST['maxage'] != 9999)) {
1264
+			$search_params['maxage'] = !empty($search_params['maxage']) ? (int) $search_params['maxage'] : (int) $_REQUEST['maxage'];
1265
+	}
1219 1266
 
1220 1267
 	$search_params['subject_only'] = !empty($search_params['subject_only']) || !empty($_REQUEST['subject_only']);
1221 1268
 	$search_params['show_complete'] = !empty($search_params['show_complete']) || !empty($_REQUEST['show_complete']);
1222 1269
 
1223 1270
 	// Default the user name to a wildcard matching every user (*).
1224
-	if (!empty($search_params['user_spec']) || (!empty($_REQUEST['userspec']) && $_REQUEST['userspec'] != '*'))
1225
-		$search_params['userspec'] = isset($search_params['userspec']) ? $search_params['userspec'] : $_REQUEST['userspec'];
1271
+	if (!empty($search_params['user_spec']) || (!empty($_REQUEST['userspec']) && $_REQUEST['userspec'] != '*')) {
1272
+			$search_params['userspec'] = isset($search_params['userspec']) ? $search_params['userspec'] : $_REQUEST['userspec'];
1273
+	}
1226 1274
 
1227 1275
 	// This will be full of all kinds of parameters!
1228 1276
 	$searchq_parameters = array();
1229 1277
 
1230 1278
 	// If there's no specific user, then don't mention it in the main query.
1231
-	if (empty($search_params['userspec']))
1232
-		$userQuery = '';
1233
-	else
1279
+	if (empty($search_params['userspec'])) {
1280
+			$userQuery = '';
1281
+	} else
1234 1282
 	{
1235 1283
 		$userString = strtr($smcFunc['htmlspecialchars']($search_params['userspec'], ENT_QUOTES), array('&quot;' => '"'));
1236 1284
 		$userString = strtr($userString, array('%' => '\%', '_' => '\_', '*' => '%', '?' => '_'));
@@ -1242,8 +1290,9 @@  discard block
 block discarded – undo
1242 1290
 		{
1243 1291
 			$possible_users[$k] = trim($possible_users[$k]);
1244 1292
 
1245
-			if (strlen($possible_users[$k]) == 0)
1246
-				unset($possible_users[$k]);
1293
+			if (strlen($possible_users[$k]) == 0) {
1294
+							unset($possible_users[$k]);
1295
+			}
1247 1296
 		}
1248 1297
 
1249 1298
 		if (!empty($possible_users))
@@ -1255,8 +1304,9 @@  discard block
 block discarded – undo
1255 1304
 			{
1256 1305
 				$where_params['name_' . $k] = $v;
1257 1306
 				$where_clause[] = '{raw:real_name} LIKE {string:name_' . $k . '}';
1258
-				if (!isset($where_params['real_name']))
1259
-					$where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name';
1307
+				if (!isset($where_params['real_name'])) {
1308
+									$where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name';
1309
+				}
1260 1310
 			}
1261 1311
 
1262 1312
 			// Who matches those criteria?
@@ -1269,28 +1319,28 @@  discard block
 block discarded – undo
1269 1319
 			);
1270 1320
 
1271 1321
 			// Simply do nothing if there're too many members matching the criteria.
1272
-			if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch)
1273
-				$userQuery = '';
1274
-			elseif ($smcFunc['db_num_rows']($request) == 0)
1322
+			if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch) {
1323
+							$userQuery = '';
1324
+			} elseif ($smcFunc['db_num_rows']($request) == 0)
1275 1325
 			{
1276 1326
 				$userQuery = 'AND pm.id_member_from = 0 AND ({raw:pm_from_name} LIKE {raw:guest_user_name_implode})';
1277 1327
 				$searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR ' . ($smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name') . ' LIKE \'', $possible_users) . '\'';
1278 1328
 				$searchq_parameters['pm_from_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name';
1279
-			}
1280
-			else
1329
+			} else
1281 1330
 			{
1282 1331
 				$memberlist = array();
1283
-				while ($row = $smcFunc['db_fetch_assoc']($request))
1284
-					$memberlist[] = $row['id_member'];
1332
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
1333
+									$memberlist[] = $row['id_member'];
1334
+				}
1285 1335
 				$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND ({raw:pm_from_name} LIKE {raw:guest_user_name_implode})))';
1286 1336
 				$searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR ' . ($smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name') . ' LIKE \'', $possible_users) . '\'';
1287 1337
 				$searchq_parameters['member_list'] = $memberlist;
1288 1338
 				$searchq_parameters['pm_from_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name';
1289 1339
 			}
1290 1340
 			$smcFunc['db_free_result']($request);
1341
+		} else {
1342
+					$userQuery = '';
1291 1343
 		}
1292
-		else
1293
-			$userQuery = '';
1294 1344
 	}
1295 1345
 
1296 1346
 	// Setup the sorting variables...
@@ -1298,8 +1348,9 @@  discard block
 block discarded – undo
1298 1348
 	$sort_columns = array(
1299 1349
 		'pm.id_pm',
1300 1350
 	);
1301
-	if (empty($search_params['sort']) && !empty($_REQUEST['sort']))
1302
-		list ($search_params['sort'], $search_params['sort_dir']) = array_pad(explode('|', $_REQUEST['sort']), 2, '');
1351
+	if (empty($search_params['sort']) && !empty($_REQUEST['sort'])) {
1352
+			list ($search_params['sort'], $search_params['sort_dir']) = array_pad(explode('|', $_REQUEST['sort']), 2, '');
1353
+	}
1303 1354
 	$search_params['sort'] = !empty($search_params['sort']) && in_array($search_params['sort'], $sort_columns) ? $search_params['sort'] : 'pm.id_pm';
1304 1355
 	$search_params['sort_dir'] = !empty($search_params['sort_dir']) && $search_params['sort_dir'] == 'asc' ? 'asc' : 'desc';
1305 1356
 
@@ -1309,24 +1360,27 @@  discard block
 block discarded – undo
1309 1360
 	if ($context['folder'] == 'inbox' && !empty($search_params['advanced']) && $context['currently_using_labels'])
1310 1361
 	{
1311 1362
 		// Came here from pagination?  Put them back into $_REQUEST for sanitization.
1312
-		if (isset($search_params['labels']))
1313
-			$_REQUEST['searchlabel'] = explode(',', $search_params['labels']);
1363
+		if (isset($search_params['labels'])) {
1364
+					$_REQUEST['searchlabel'] = explode(',', $search_params['labels']);
1365
+		}
1314 1366
 
1315 1367
 		// Assuming we have some labels - make them all integers.
1316 1368
 		if (!empty($_REQUEST['searchlabel']) && is_array($_REQUEST['searchlabel']))
1317 1369
 		{
1318
-			foreach ($_REQUEST['searchlabel'] as $key => $id)
1319
-				$_REQUEST['searchlabel'][$key] = (int) $id;
1370
+			foreach ($_REQUEST['searchlabel'] as $key => $id) {
1371
+							$_REQUEST['searchlabel'][$key] = (int) $id;
1372
+			}
1373
+		} else {
1374
+					$_REQUEST['searchlabel'] = array();
1320 1375
 		}
1321
-		else
1322
-			$_REQUEST['searchlabel'] = array();
1323 1376
 
1324 1377
 		// Now that everything is cleaned up a bit, make the labels a param.
1325 1378
 		$search_params['labels'] = implode(',', $_REQUEST['searchlabel']);
1326 1379
 
1327 1380
 		// No labels selected? That must be an error!
1328
-		if (empty($_REQUEST['searchlabel']))
1329
-			$context['search_errors']['no_labels_selected'] = true;
1381
+		if (empty($_REQUEST['searchlabel'])) {
1382
+					$context['search_errors']['no_labels_selected'] = true;
1383
+		}
1330 1384
 		// Otherwise prepare the query!
1331 1385
 		elseif (count($_REQUEST['searchlabel']) != count($context['labels']))
1332 1386
 		{
@@ -1349,8 +1403,7 @@  discard block
 block discarded – undo
1349 1403
 					// Not searching the inbox - PM must be labeled
1350 1404
 					$labelQuery = ' AND pml.id_label IN ({array_int:labels})';
1351 1405
 					$labelJoin = ' INNER JOIN {db_prefix}pm_labeled_messages AS pml ON (pml.id_pm = pmr.id_pm)';
1352
-				}
1353
-				else
1406
+				} else
1354 1407
 				{
1355 1408
 					// Searching the inbox - PM doesn't have to be labeled
1356 1409
 					$labelQuery = ' AND (' . substr($labelQuery, 5) . ' OR pml.id_label IN ({array_int:labels}))';
@@ -1365,8 +1418,9 @@  discard block
 block discarded – undo
1365 1418
 	// What are we actually searching for?
1366 1419
 	$search_params['search'] = !empty($search_params['search']) ? $search_params['search'] : (isset($_REQUEST['search']) ? $_REQUEST['search'] : '');
1367 1420
 	// If we ain't got nothing - we should error!
1368
-	if (!isset($search_params['search']) || $search_params['search'] == '')
1369
-		$context['search_errors']['invalid_search_string'] = true;
1421
+	if (!isset($search_params['search']) || $search_params['search'] == '') {
1422
+			$context['search_errors']['invalid_search_string'] = true;
1423
+	}
1370 1424
 
1371 1425
 	// Extract phrase parts first (e.g. some words "this is a phrase" some more words.)
1372 1426
 	preg_match_all('~(?:^|\s)([-]?)"([^"]+)"(?:$|\s)~' . ($context['utf8'] ? 'u' : ''), $search_params['search'], $matches, PREG_PATTERN_ORDER);
@@ -1379,12 +1433,14 @@  discard block
 block discarded – undo
1379 1433
 	$excludedWords = array();
1380 1434
 
1381 1435
 	// .. first, we check for things like -"some words", but not "-some words".
1382
-	foreach ($matches[1] as $index => $word)
1383
-		if ($word == '-')
1436
+	foreach ($matches[1] as $index => $word) {
1437
+			if ($word == '-')
1384 1438
 		{
1385 1439
 			$word = $smcFunc['strtolower'](trim($searchArray[$index]));
1386
-			if (strlen($word) > 0)
1387
-				$excludedWords[] = $word;
1440
+	}
1441
+			if (strlen($word) > 0) {
1442
+							$excludedWords[] = $word;
1443
+			}
1388 1444
 			unset($searchArray[$index]);
1389 1445
 		}
1390 1446
 
@@ -1394,8 +1450,9 @@  discard block
 block discarded – undo
1394 1450
 		if (strpos(trim($word), '-') === 0)
1395 1451
 		{
1396 1452
 			$word = substr($smcFunc['strtolower']($word), 1);
1397
-			if (strlen($word) > 0)
1398
-				$excludedWords[] = $word;
1453
+			if (strlen($word) > 0) {
1454
+							$excludedWords[] = $word;
1455
+			}
1399 1456
 			unset($tempSearch[$index]);
1400 1457
 		}
1401 1458
 	}
@@ -1406,9 +1463,9 @@  discard block
 block discarded – undo
1406 1463
 	foreach ($searchArray as $index => $value)
1407 1464
 	{
1408 1465
 		$searchArray[$index] = $smcFunc['strtolower'](trim($value));
1409
-		if ($searchArray[$index] == '')
1410
-			unset($searchArray[$index]);
1411
-		else
1466
+		if ($searchArray[$index] == '') {
1467
+					unset($searchArray[$index]);
1468
+		} else
1412 1469
 		{
1413 1470
 			// Sort out entities first.
1414 1471
 			$searchArray[$index] = $smcFunc['htmlspecialchars']($searchArray[$index]);
@@ -1418,27 +1475,32 @@  discard block
 block discarded – undo
1418 1475
 
1419 1476
 	// Create an array of replacements for highlighting.
1420 1477
 	$context['mark'] = array();
1421
-	foreach ($searchArray as $word)
1422
-		$context['mark'][$word] = '<strong class="highlight">' . $word . '</strong>';
1478
+	foreach ($searchArray as $word) {
1479
+			$context['mark'][$word] = '<strong class="highlight">' . $word . '</strong>';
1480
+	}
1423 1481
 
1424 1482
 	// This contains *everything*
1425 1483
 	$searchWords = array_merge($searchArray, $excludedWords);
1426 1484
 
1427 1485
 	// Make sure at least one word is being searched for.
1428
-	if (empty($searchArray))
1429
-		$context['search_errors']['invalid_search_string'] = true;
1486
+	if (empty($searchArray)) {
1487
+			$context['search_errors']['invalid_search_string'] = true;
1488
+	}
1430 1489
 
1431 1490
 	// Sort out the search query so the user can edit it - if they want.
1432 1491
 	$context['search_params'] = $search_params;
1433
-	if (isset($context['search_params']['search']))
1434
-		$context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']);
1435
-	if (isset($context['search_params']['userspec']))
1436
-		$context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']);
1492
+	if (isset($context['search_params']['search'])) {
1493
+			$context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']);
1494
+	}
1495
+	if (isset($context['search_params']['userspec'])) {
1496
+			$context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']);
1497
+	}
1437 1498
 
1438 1499
 	// Now we have all the parameters, combine them together for pagination and the like...
1439 1500
 	$context['params'] = array();
1440
-	foreach ($search_params as $k => $v)
1441
-		$context['params'][] = $k . '|\'|' . $v;
1501
+	foreach ($search_params as $k => $v) {
1502
+			$context['params'][] = $k . '|\'|' . $v;
1503
+	}
1442 1504
 	$context['params'] = base64_encode(implode('|"|', $context['params']));
1443 1505
 
1444 1506
 	// Compile the subject query part.
@@ -1446,26 +1508,31 @@  discard block
 block discarded – undo
1446 1508
 
1447 1509
 	foreach ($searchWords as $index => $word)
1448 1510
 	{
1449
-		if ($word == '')
1450
-			continue;
1511
+		if ($word == '') {
1512
+					continue;
1513
+		}
1451 1514
 
1452
-		if ($search_params['subject_only'])
1453
-			$andQueryParts[] = 'pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '}';
1454
-		else
1455
-			$andQueryParts[] = '(pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '} ' . (in_array($word, $excludedWords) ? 'AND pm.body NOT' : 'OR pm.body') . ' LIKE {string:search_' . $index . '})';
1515
+		if ($search_params['subject_only']) {
1516
+					$andQueryParts[] = 'pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '}';
1517
+		} else {
1518
+					$andQueryParts[] = '(pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '} ' . (in_array($word, $excludedWords) ? 'AND pm.body NOT' : 'OR pm.body') . ' LIKE {string:search_' . $index . '})';
1519
+		}
1456 1520
 		$searchq_parameters['search_' . $index] = '%' . strtr($word, array('_' => '\\_', '%' => '\\%')) . '%';
1457 1521
 	}
1458 1522
 
1459 1523
 	$searchQuery = ' 1=1';
1460
-	if (!empty($andQueryParts))
1461
-		$searchQuery = implode(!empty($search_params['searchtype']) && $search_params['searchtype'] == 2 ? ' OR ' : ' AND ', $andQueryParts);
1524
+	if (!empty($andQueryParts)) {
1525
+			$searchQuery = implode(!empty($search_params['searchtype']) && $search_params['searchtype'] == 2 ? ' OR ' : ' AND ', $andQueryParts);
1526
+	}
1462 1527
 
1463 1528
 	// Age limits?
1464 1529
 	$timeQuery = '';
1465
-	if (!empty($search_params['minage']))
1466
-		$timeQuery .= ' AND pm.msgtime < ' . (time() - $search_params['minage'] * 86400);
1467
-	if (!empty($search_params['maxage']))
1468
-		$timeQuery .= ' AND pm.msgtime > ' . (time() - $search_params['maxage'] * 86400);
1530
+	if (!empty($search_params['minage'])) {
1531
+			$timeQuery .= ' AND pm.msgtime < ' . (time() - $search_params['minage'] * 86400);
1532
+	}
1533
+	if (!empty($search_params['maxage'])) {
1534
+			$timeQuery .= ' AND pm.msgtime > ' . (time() - $search_params['maxage'] * 86400);
1535
+	}
1469 1536
 
1470 1537
 	// If we have errors - return back to the first screen...
1471 1538
 	if (!empty($context['search_errors']))
@@ -1551,8 +1618,9 @@  discard block
 block discarded – undo
1551 1618
 			)
1552 1619
 		);
1553 1620
 		$real_pm_ids = array();
1554
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1555
-			$real_pm_ids[$row['id_pm_head']] = $row['id_pm'];
1621
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1622
+					$real_pm_ids[$row['id_pm_head']] = $row['id_pm'];
1623
+		}
1556 1624
 		$smcFunc['db_free_result']($request);
1557 1625
 	}
1558 1626
 
@@ -1582,8 +1650,9 @@  discard block
 block discarded – undo
1582 1650
 		);
1583 1651
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1584 1652
 		{
1585
-			if ($context['folder'] == 'sent' || empty($row['bcc']))
1586
-				$recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>';
1653
+			if ($context['folder'] == 'sent' || empty($row['bcc'])) {
1654
+							$recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>';
1655
+			}
1587 1656
 
1588 1657
 			if ($row['id_member_to'] == $user_info['id'] && $context['folder'] != 'sent')
1589 1658
 			{
@@ -1604,12 +1673,14 @@  discard block
 block discarded – undo
1604 1673
 				while ($row2 = $smcFunc['db_fetch_assoc']($request2))
1605 1674
 				{
1606 1675
 					$l_id = $row2['id_label'];
1607
-					if (isset($context['labels'][$l_id]))
1608
-						$context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']);
1676
+					if (isset($context['labels'][$l_id])) {
1677
+											$context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']);
1678
+					}
1609 1679
 
1610 1680
 					// Here we find the first label on a message - for linking to posts in results
1611
-					if (!isset($context['first_label'][$row['id_pm']]) && $row['in_inbox'] != 1)
1612
-						$context['first_label'][$row['id_pm']] = $l_id;
1681
+					if (!isset($context['first_label'][$row['id_pm']]) && $row['in_inbox'] != 1) {
1682
+											$context['first_label'][$row['id_pm']] = $l_id;
1683
+					}
1613 1684
 				}
1614 1685
 
1615 1686
 				$smcFunc['db_free_result']($request2);
@@ -1736,8 +1807,9 @@  discard block
 block discarded – undo
1736 1807
 		list ($postCount) = $smcFunc['db_fetch_row']($request);
1737 1808
 		$smcFunc['db_free_result']($request);
1738 1809
 
1739
-		if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour'])
1740
-			fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour']));
1810
+		if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) {
1811
+					fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour']));
1812
+		}
1741 1813
 	}
1742 1814
 
1743 1815
 	// Quoting/Replying to a message?
@@ -1746,8 +1818,9 @@  discard block
 block discarded – undo
1746 1818
 		$pmsg = (int) $_REQUEST['pmsg'];
1747 1819
 
1748 1820
 		// Make sure this is yours.
1749
-		if (!isAccessiblePM($pmsg))
1750
-			fatal_lang_error('no_access', false);
1821
+		if (!isAccessiblePM($pmsg)) {
1822
+					fatal_lang_error('no_access', false);
1823
+		}
1751 1824
 
1752 1825
 		// Work out whether this is one you've received?
1753 1826
 		$request = $smcFunc['db_query']('', '
@@ -1784,8 +1857,9 @@  discard block
 block discarded – undo
1784 1857
 				'id_pm' => $pmsg,
1785 1858
 			)
1786 1859
 		);
1787
-		if ($smcFunc['db_num_rows']($request) == 0)
1788
-			fatal_lang_error('pm_not_yours', false);
1860
+		if ($smcFunc['db_num_rows']($request) == 0) {
1861
+					fatal_lang_error('pm_not_yours', false);
1862
+		}
1789 1863
 		$row_quoted = $smcFunc['db_fetch_assoc']($request);
1790 1864
 		$smcFunc['db_free_result']($request);
1791 1865
 
@@ -1796,9 +1870,9 @@  discard block
 block discarded – undo
1796 1870
 		// Add 'Re: ' to it....
1797 1871
 		if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
1798 1872
 		{
1799
-			if ($language === $user_info['language'])
1800
-				$context['response_prefix'] = $txt['response_prefix'];
1801
-			else
1873
+			if ($language === $user_info['language']) {
1874
+							$context['response_prefix'] = $txt['response_prefix'];
1875
+			} else
1802 1876
 			{
1803 1877
 				loadLanguage('index', $language, false);
1804 1878
 				$context['response_prefix'] = $txt['response_prefix'];
@@ -1807,22 +1881,25 @@  discard block
 block discarded – undo
1807 1881
 			cache_put_data('response_prefix', $context['response_prefix'], 600);
1808 1882
 		}
1809 1883
 		$form_subject = $row_quoted['subject'];
1810
-		if ($context['reply'] && trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
1811
-			$form_subject = $context['response_prefix'] . $form_subject;
1884
+		if ($context['reply'] && trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
1885
+					$form_subject = $context['response_prefix'] . $form_subject;
1886
+		}
1812 1887
 
1813 1888
 		if (isset($_REQUEST['quote']))
1814 1889
 		{
1815 1890
 			// Remove any nested quotes and <br>...
1816 1891
 			$form_message = preg_replace('~<br ?/?' . '>~i', "\n", $row_quoted['body']);
1817
-			if (!empty($modSettings['removeNestedQuotes']))
1818
-				$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
1819
-			if (empty($row_quoted['id_member']))
1820
-				$form_message = '[quote author=&quot;' . $row_quoted['real_name'] . '&quot;]' . "\n" . $form_message . "\n" . '[/quote]';
1821
-			else
1822
-				$form_message = '[quote author=' . $row_quoted['real_name'] . ' link=action=profile;u=' . $row_quoted['id_member'] . ' date=' . $row_quoted['msgtime'] . ']' . "\n" . $form_message . "\n" . '[/quote]';
1892
+			if (!empty($modSettings['removeNestedQuotes'])) {
1893
+							$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
1894
+			}
1895
+			if (empty($row_quoted['id_member'])) {
1896
+							$form_message = '[quote author=&quot;' . $row_quoted['real_name'] . '&quot;]' . "\n" . $form_message . "\n" . '[/quote]';
1897
+			} else {
1898
+							$form_message = '[quote author=' . $row_quoted['real_name'] . ' link=action=profile;u=' . $row_quoted['id_member'] . ' date=' . $row_quoted['msgtime'] . ']' . "\n" . $form_message . "\n" . '[/quote]';
1899
+			}
1900
+		} else {
1901
+					$form_message = '';
1823 1902
 		}
1824
-		else
1825
-			$form_message = '';
1826 1903
 
1827 1904
 		// Do the BBC thang on the message.
1828 1905
 		$row_quoted['body'] = parse_bbc($row_quoted['body'], true, 'pm' . $row_quoted['id_pm']);
@@ -1843,8 +1920,7 @@  discard block
 block discarded – undo
1843 1920
 			'timestamp' => forum_time(true, $row_quoted['msgtime']),
1844 1921
 			'body' => $row_quoted['body']
1845 1922
 		);
1846
-	}
1847
-	else
1923
+	} else
1848 1924
 	{
1849 1925
 		$context['quoted_message'] = false;
1850 1926
 		$form_subject = '';
@@ -1863,11 +1939,12 @@  discard block
 block discarded – undo
1863 1939
 		if ($_REQUEST['u'] == 'all' && isset($row_quoted))
1864 1940
 		{
1865 1941
 			// Firstly, to reply to all we clearly already have $row_quoted - so have the original member from.
1866
-			if ($row_quoted['id_member'] != $user_info['id'])
1867
-				$context['recipients']['to'][] = array(
1942
+			if ($row_quoted['id_member'] != $user_info['id']) {
1943
+							$context['recipients']['to'][] = array(
1868 1944
 					'id' => $row_quoted['id_member'],
1869 1945
 					'name' => $smcFunc['htmlspecialchars']($row_quoted['real_name']),
1870 1946
 				);
1947
+			}
1871 1948
 
1872 1949
 			// Now to get the others.
1873 1950
 			$request = $smcFunc['db_query']('', '
@@ -1883,18 +1960,19 @@  discard block
 block discarded – undo
1883 1960
 					'not_bcc' => 0,
1884 1961
 				)
1885 1962
 			);
1886
-			while ($row = $smcFunc['db_fetch_assoc']($request))
1887
-				$context['recipients']['to'][] = array(
1963
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
1964
+							$context['recipients']['to'][] = array(
1888 1965
 					'id' => $row['id_member'],
1889 1966
 					'name' => $row['real_name'],
1890 1967
 				);
1968
+			}
1891 1969
 			$smcFunc['db_free_result']($request);
1892
-		}
1893
-		else
1970
+		} else
1894 1971
 		{
1895 1972
 			$_REQUEST['u'] = explode(',', $_REQUEST['u']);
1896
-			foreach ($_REQUEST['u'] as $key => $uID)
1897
-				$_REQUEST['u'][$key] = (int) $uID;
1973
+			foreach ($_REQUEST['u'] as $key => $uID) {
1974
+							$_REQUEST['u'][$key] = (int) $uID;
1975
+			}
1898 1976
 
1899 1977
 			$_REQUEST['u'] = array_unique($_REQUEST['u']);
1900 1978
 
@@ -1908,22 +1986,24 @@  discard block
 block discarded – undo
1908 1986
 					'limit' => count($_REQUEST['u']),
1909 1987
 				)
1910 1988
 			);
1911
-			while ($row = $smcFunc['db_fetch_assoc']($request))
1912
-				$context['recipients']['to'][] = array(
1989
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
1990
+							$context['recipients']['to'][] = array(
1913 1991
 					'id' => $row['id_member'],
1914 1992
 					'name' => $row['real_name'],
1915 1993
 				);
1994
+			}
1916 1995
 			$smcFunc['db_free_result']($request);
1917 1996
 		}
1918 1997
 
1919 1998
 		// Get a literal name list in case the user has JavaScript disabled.
1920 1999
 		$names = array();
1921
-		foreach ($context['recipients']['to'] as $to)
1922
-			$names[] = $to['name'];
2000
+		foreach ($context['recipients']['to'] as $to) {
2001
+					$names[] = $to['name'];
2002
+		}
1923 2003
 		$context['to_value'] = empty($names) ? '' : '&quot;' . implode('&quot;, &quot;', $names) . '&quot;';
2004
+	} else {
2005
+			$context['to_value'] = '';
1924 2006
 	}
1925
-	else
1926
-		$context['to_value'] = '';
1927 2007
 
1928 2008
 	// Set the defaults...
1929 2009
 	$context['subject'] = $form_subject;
@@ -1993,8 +2073,9 @@  discard block
 block discarded – undo
1993 2073
 
1994 2074
 	// validate with loadMemberData()
1995 2075
 	$memberResult = loadMemberData($user_info['id'], false);
1996
-	if (!$memberResult)
1997
-		fatal_lang_error('not_a_user', false);
2076
+	if (!$memberResult) {
2077
+			fatal_lang_error('not_a_user', false);
2078
+	}
1998 2079
 	list ($memID) = $memberResult;
1999 2080
 
2000 2081
 	// drafts is where the functions reside
@@ -2020,9 +2101,9 @@  discard block
 block discarded – undo
2020 2101
 		$context['sub_template'] = 'send';
2021 2102
 		loadJavaScriptFile('PersonalMessage.js', array('defer' => false, 'minimize' => true), 'smf_pms');
2022 2103
 		loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest');
2104
+	} else {
2105
+			$context['sub_template'] = 'pm';
2023 2106
 	}
2024
-	else
2025
-		$context['sub_template'] = 'pm';
2026 2107
 
2027 2108
 	$context['page_title'] = $txt['send_message'];
2028 2109
 
@@ -2083,10 +2164,11 @@  discard block
 block discarded – undo
2083 2164
 		);
2084 2165
 		if ($smcFunc['db_num_rows']($request) == 0)
2085 2166
 		{
2086
-			if (!isset($_REQUEST['xml']))
2087
-				fatal_lang_error('pm_not_yours', false);
2088
-			else
2089
-				$error_types[] = 'pm_not_yours';
2167
+			if (!isset($_REQUEST['xml'])) {
2168
+							fatal_lang_error('pm_not_yours', false);
2169
+			} else {
2170
+							$error_types[] = 'pm_not_yours';
2171
+			}
2090 2172
 		}
2091 2173
 		$row_quoted = $smcFunc['db_fetch_assoc']($request);
2092 2174
 		$smcFunc['db_free_result']($request);
@@ -2133,14 +2215,16 @@  discard block
 block discarded – undo
2133 2215
 		$context['post_error'][$error_type] = true;
2134 2216
 		if (isset($txt['error_' . $error_type]))
2135 2217
 		{
2136
-			if ($error_type == 'long_message')
2137
-				$txt['error_' . $error_type] = sprintf($txt['error_' . $error_type], $modSettings['max_messageLength']);
2218
+			if ($error_type == 'long_message') {
2219
+							$txt['error_' . $error_type] = sprintf($txt['error_' . $error_type], $modSettings['max_messageLength']);
2220
+			}
2138 2221
 			$context['post_error']['messages'][] = $txt['error_' . $error_type];
2139 2222
 		}
2140 2223
 
2141 2224
 		// If it's not a minor error flag it as such.
2142
-		if (!in_array($error_type, array('new_reply', 'not_approved', 'new_replies', 'old_topic', 'need_qr_verification', 'no_subject')))
2143
-			$context['error_type'] = 'serious';
2225
+		if (!in_array($error_type, array('new_reply', 'not_approved', 'new_replies', 'old_topic', 'need_qr_verification', 'no_subject'))) {
2226
+					$context['error_type'] = 'serious';
2227
+		}
2144 2228
 	}
2145 2229
 
2146 2230
 	// We need to load the editor once more.
@@ -2198,8 +2282,9 @@  discard block
 block discarded – undo
2198 2282
 	require_once($sourcedir . '/Subs-Auth.php');
2199 2283
 
2200 2284
 	// PM Drafts enabled and needed?
2201
-	if ($context['drafts_pm_save'] && (isset($_POST['save_draft']) || isset($_POST['id_pm_draft'])))
2202
-		require_once($sourcedir . '/Drafts.php');
2285
+	if ($context['drafts_pm_save'] && (isset($_POST['save_draft']) || isset($_POST['id_pm_draft']))) {
2286
+			require_once($sourcedir . '/Drafts.php');
2287
+	}
2203 2288
 
2204 2289
 	loadLanguage('PersonalMessage', '', false);
2205 2290
 
@@ -2229,24 +2314,27 @@  discard block
 block discarded – undo
2229 2314
 
2230 2315
 		if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour'])
2231 2316
 		{
2232
-			if (!isset($_REQUEST['xml']))
2233
-				fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour']));
2234
-			else
2235
-				$post_errors[] = 'pm_too_many_per_hour';
2317
+			if (!isset($_REQUEST['xml'])) {
2318
+							fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour']));
2319
+			} else {
2320
+							$post_errors[] = 'pm_too_many_per_hour';
2321
+			}
2236 2322
 		}
2237 2323
 	}
2238 2324
 
2239 2325
 	// If your session timed out, show an error, but do allow to re-submit.
2240
-	if (!isset($_REQUEST['xml']) && checkSession('post', '', false) != '')
2241
-		$post_errors[] = 'session_timeout';
2326
+	if (!isset($_REQUEST['xml']) && checkSession('post', '', false) != '') {
2327
+			$post_errors[] = 'session_timeout';
2328
+	}
2242 2329
 
2243 2330
 	$_REQUEST['subject'] = isset($_REQUEST['subject']) ? trim($_REQUEST['subject']) : '';
2244 2331
 	$_REQUEST['to'] = empty($_POST['to']) ? (empty($_GET['to']) ? '' : $_GET['to']) : $_POST['to'];
2245 2332
 	$_REQUEST['bcc'] = empty($_POST['bcc']) ? (empty($_GET['bcc']) ? '' : $_GET['bcc']) : $_POST['bcc'];
2246 2333
 
2247 2334
 	// Route the input from the 'u' parameter to the 'to'-list.
2248
-	if (!empty($_POST['u']))
2249
-		$_POST['recipient_to'] = explode(',', $_POST['u']);
2335
+	if (!empty($_POST['u'])) {
2336
+			$_POST['recipient_to'] = explode(',', $_POST['u']);
2337
+	}
2250 2338
 
2251 2339
 	// Construct the list of recipients.
2252 2340
 	$recipientList = array();
@@ -2258,8 +2346,9 @@  discard block
 block discarded – undo
2258 2346
 		$recipientList[$recipientType] = array();
2259 2347
 		if (!empty($_POST['recipient_' . $recipientType]) && is_array($_POST['recipient_' . $recipientType]))
2260 2348
 		{
2261
-			foreach ($_POST['recipient_' . $recipientType] as $recipient)
2262
-				$recipientList[$recipientType][] = (int) $recipient;
2349
+			foreach ($_POST['recipient_' . $recipientType] as $recipient) {
2350
+							$recipientList[$recipientType][] = (int) $recipient;
2351
+			}
2263 2352
 		}
2264 2353
 
2265 2354
 		// Are there also literal names set?
@@ -2273,10 +2362,11 @@  discard block
 block discarded – undo
2273 2362
 
2274 2363
 			foreach ($namedRecipientList[$recipientType] as $index => $recipient)
2275 2364
 			{
2276
-				if (strlen(trim($recipient)) > 0)
2277
-					$namedRecipientList[$recipientType][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($recipient)));
2278
-				else
2279
-					unset($namedRecipientList[$recipientType][$index]);
2365
+				if (strlen(trim($recipient)) > 0) {
2366
+									$namedRecipientList[$recipientType][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($recipient)));
2367
+				} else {
2368
+									unset($namedRecipientList[$recipientType][$index]);
2369
+				}
2280 2370
 			}
2281 2371
 
2282 2372
 			if (!empty($namedRecipientList[$recipientType]))
@@ -2306,8 +2396,9 @@  discard block
 block discarded – undo
2306 2396
 		}
2307 2397
 
2308 2398
 		// Selected a recipient to be deleted? Remove them now.
2309
-		if (!empty($_POST['delete_recipient']))
2310
-			$recipientList[$recipientType] = array_diff($recipientList[$recipientType], array((int) $_POST['delete_recipient']));
2399
+		if (!empty($_POST['delete_recipient'])) {
2400
+					$recipientList[$recipientType] = array_diff($recipientList[$recipientType], array((int) $_POST['delete_recipient']));
2401
+		}
2311 2402
 
2312 2403
 		// Make sure we don't include the same name twice
2313 2404
 		$recipientList[$recipientType] = array_unique($recipientList[$recipientType]);
@@ -2317,8 +2408,9 @@  discard block
 block discarded – undo
2317 2408
 	$is_recipient_change = !empty($_POST['delete_recipient']) || !empty($_POST['to_submit']) || !empty($_POST['bcc_submit']);
2318 2409
 
2319 2410
 	// Check if there's at least one recipient.
2320
-	if (empty($recipientList['to']) && empty($recipientList['bcc']))
2321
-		$post_errors[] = 'no_to';
2411
+	if (empty($recipientList['to']) && empty($recipientList['bcc'])) {
2412
+			$post_errors[] = 'no_to';
2413
+	}
2322 2414
 
2323 2415
 	// Make sure that we remove the members who did get it from the screen.
2324 2416
 	if (!$is_recipient_change)
@@ -2332,28 +2424,31 @@  discard block
 block discarded – undo
2332 2424
 				// Since we already have a post error, remove the previous one.
2333 2425
 				$post_errors = array_diff($post_errors, array('no_to'));
2334 2426
 
2335
-				foreach ($namesNotFound[$recipientType] as $name)
2336
-					$context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name);
2427
+				foreach ($namesNotFound[$recipientType] as $name) {
2428
+									$context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name);
2429
+				}
2337 2430
 			}
2338 2431
 		}
2339 2432
 	}
2340 2433
 
2341 2434
 	// Did they make any mistakes?
2342
-	if ($_REQUEST['subject'] == '')
2343
-		$post_errors[] = 'no_subject';
2344
-	if (!isset($_REQUEST['message']) || $_REQUEST['message'] == '')
2345
-		$post_errors[] = 'no_message';
2346
-	elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_REQUEST['message']) > $modSettings['max_messageLength'])
2347
-		$post_errors[] = 'long_message';
2348
-	else
2435
+	if ($_REQUEST['subject'] == '') {
2436
+			$post_errors[] = 'no_subject';
2437
+	}
2438
+	if (!isset($_REQUEST['message']) || $_REQUEST['message'] == '') {
2439
+			$post_errors[] = 'no_message';
2440
+	} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_REQUEST['message']) > $modSettings['max_messageLength']) {
2441
+			$post_errors[] = 'long_message';
2442
+	} else
2349 2443
 	{
2350 2444
 		// Preparse the message.
2351 2445
 		$message = $_REQUEST['message'];
2352 2446
 		preparsecode($message);
2353 2447
 
2354 2448
 		// Make sure there's still some content left without the tags.
2355
-		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($smcFunc['htmlspecialchars']($message, ENT_QUOTES), false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($message, '[html]') === false))
2356
-			$post_errors[] = 'no_message';
2449
+		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($smcFunc['htmlspecialchars']($message, ENT_QUOTES), false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($message, '[html]') === false)) {
2450
+					$post_errors[] = 'no_message';
2451
+		}
2357 2452
 	}
2358 2453
 
2359 2454
 	// Wrong verification code?
@@ -2365,13 +2460,15 @@  discard block
 block discarded – undo
2365 2460
 		);
2366 2461
 		$context['require_verification'] = create_control_verification($verificationOptions, true);
2367 2462
 
2368
-		if (is_array($context['require_verification']))
2369
-			$post_errors = array_merge($post_errors, $context['require_verification']);
2463
+		if (is_array($context['require_verification'])) {
2464
+					$post_errors = array_merge($post_errors, $context['require_verification']);
2465
+		}
2370 2466
 	}
2371 2467
 
2372 2468
 	// If they did, give a chance to make ammends.
2373
-	if (!empty($post_errors) && !$is_recipient_change && !isset($_REQUEST['preview']) && !isset($_REQUEST['xml']))
2374
-		return messagePostError($post_errors, $namedRecipientList, $recipientList);
2469
+	if (!empty($post_errors) && !$is_recipient_change && !isset($_REQUEST['preview']) && !isset($_REQUEST['xml'])) {
2470
+			return messagePostError($post_errors, $namedRecipientList, $recipientList);
2471
+	}
2375 2472
 
2376 2473
 	// Want to take a second glance before you send?
2377 2474
 	if (isset($_REQUEST['preview']))
@@ -2402,8 +2499,9 @@  discard block
 block discarded – undo
2402 2499
 		foreach ($namesNotFound as $recipientType => $names)
2403 2500
 		{
2404 2501
 			$post_errors[] = 'bad_' . $recipientType;
2405
-			foreach ($names as $name)
2406
-				$context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name);
2502
+			foreach ($names as $name) {
2503
+							$context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name);
2504
+			}
2407 2505
 		}
2408 2506
 
2409 2507
 		return messagePostError(array(), $namedRecipientList, $recipientList);
@@ -2433,13 +2531,14 @@  discard block
 block discarded – undo
2433 2531
 	checkSubmitOnce('check');
2434 2532
 
2435 2533
 	// Do the actual sending of the PM.
2436
-	if (!empty($recipientList['to']) || !empty($recipientList['bcc']))
2437
-		$context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], true, null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0);
2438
-	else
2439
-		$context['send_log'] = array(
2534
+	if (!empty($recipientList['to']) || !empty($recipientList['bcc'])) {
2535
+			$context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], true, null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0);
2536
+	} else {
2537
+			$context['send_log'] = array(
2440 2538
 			'sent' => array(),
2441 2539
 			'failed' => array()
2442 2540
 		);
2541
+	}
2443 2542
 
2444 2543
 	// Mark the message as "replied to".
2445 2544
 	if (!empty($context['send_log']['sent']) && !empty($_REQUEST['replied_to']) && isset($_REQUEST['f']) && $_REQUEST['f'] == 'inbox')
@@ -2457,11 +2556,12 @@  discard block
 block discarded – undo
2457 2556
 	}
2458 2557
 
2459 2558
 	// If one or more of the recipient were invalid, go back to the post screen with the failed usernames.
2460
-	if (!empty($context['send_log']['failed']))
2461
-		return messagePostError($post_errors, $namesNotFound, array(
2559
+	if (!empty($context['send_log']['failed'])) {
2560
+			return messagePostError($post_errors, $namesNotFound, array(
2462 2561
 			'to' => array_intersect($recipientList['to'], $context['send_log']['failed']),
2463 2562
 			'bcc' => array_intersect($recipientList['bcc'], $context['send_log']['failed'])
2464 2563
 		));
2564
+	}
2465 2565
 
2466 2566
 	// Message sent successfully?
2467 2567
 	if (!empty($context['send_log']) && empty($context['send_log']['failed']))
@@ -2469,8 +2569,9 @@  discard block
 block discarded – undo
2469 2569
 		$context['current_label_redirect'] = $context['current_label_redirect'] . ';done=sent';
2470 2570
 
2471 2571
 		// If we had a PM draft for this one, then its time to remove it since it was just sent
2472
-		if ($context['drafts_pm_save'] && !empty($_POST['id_pm_draft']))
2473
-			DeleteDraft($_POST['id_pm_draft']);
2572
+		if ($context['drafts_pm_save'] && !empty($_POST['id_pm_draft'])) {
2573
+					DeleteDraft($_POST['id_pm_draft']);
2574
+		}
2474 2575
 	}
2475 2576
 
2476 2577
 	// Go back to the where they sent from, if possible...
@@ -2485,24 +2586,28 @@  discard block
 block discarded – undo
2485 2586
 
2486 2587
 	checkSession('request');
2487 2588
 
2488
-	if (isset($_REQUEST['del_selected']))
2489
-		$_REQUEST['pm_action'] = 'delete';
2589
+	if (isset($_REQUEST['del_selected'])) {
2590
+			$_REQUEST['pm_action'] = 'delete';
2591
+	}
2490 2592
 
2491 2593
 	if (isset($_REQUEST['pm_action']) && $_REQUEST['pm_action'] != '' && !empty($_REQUEST['pms']) && is_array($_REQUEST['pms']))
2492 2594
 	{
2493
-		foreach ($_REQUEST['pms'] as $pm)
2494
-			$_REQUEST['pm_actions'][(int) $pm] = $_REQUEST['pm_action'];
2595
+		foreach ($_REQUEST['pms'] as $pm) {
2596
+					$_REQUEST['pm_actions'][(int) $pm] = $_REQUEST['pm_action'];
2597
+		}
2495 2598
 	}
2496 2599
 
2497
-	if (empty($_REQUEST['pm_actions']))
2498
-		redirectexit($context['current_label_redirect']);
2600
+	if (empty($_REQUEST['pm_actions'])) {
2601
+			redirectexit($context['current_label_redirect']);
2602
+	}
2499 2603
 
2500 2604
 	// If we are in conversation, we may need to apply this to every message in the conversation.
2501 2605
 	if ($context['display_mode'] == 2 && isset($_REQUEST['conversation']))
2502 2606
 	{
2503 2607
 		$id_pms = array();
2504
-		foreach ($_REQUEST['pm_actions'] as $pm => $dummy)
2505
-			$id_pms[] = (int) $pm;
2608
+		foreach ($_REQUEST['pm_actions'] as $pm => $dummy) {
2609
+					$id_pms[] = (int) $pm;
2610
+		}
2506 2611
 
2507 2612
 		$request = $smcFunc['db_query']('', '
2508 2613
 			SELECT id_pm_head, id_pm
@@ -2513,8 +2618,9 @@  discard block
 block discarded – undo
2513 2618
 			)
2514 2619
 		);
2515 2620
 		$pm_heads = array();
2516
-		while ($row = $smcFunc['db_fetch_assoc']($request))
2517
-			$pm_heads[$row['id_pm_head']] = $row['id_pm'];
2621
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
2622
+					$pm_heads[$row['id_pm_head']] = $row['id_pm'];
2623
+		}
2518 2624
 		$smcFunc['db_free_result']($request);
2519 2625
 
2520 2626
 		$request = $smcFunc['db_query']('', '
@@ -2528,8 +2634,9 @@  discard block
 block discarded – undo
2528 2634
 		// Copy the action from the single to PM to the others.
2529 2635
 		while ($row = $smcFunc['db_fetch_assoc']($request))
2530 2636
 		{
2531
-			if (isset($pm_heads[$row['id_pm_head']]) && isset($_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]]))
2532
-				$_REQUEST['pm_actions'][$row['id_pm']] = $_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]];
2637
+			if (isset($pm_heads[$row['id_pm_head']]) && isset($_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]])) {
2638
+							$_REQUEST['pm_actions'][$row['id_pm']] = $_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]];
2639
+			}
2533 2640
 		}
2534 2641
 		$smcFunc['db_free_result']($request);
2535 2642
 	}
@@ -2540,22 +2647,21 @@  discard block
 block discarded – undo
2540 2647
 	$labels = array();
2541 2648
 	foreach ($_REQUEST['pm_actions'] as $pm => $action)
2542 2649
 	{
2543
-		if ($action === 'delete')
2544
-			$to_delete[] = (int) $pm;
2545
-		else
2650
+		if ($action === 'delete') {
2651
+					$to_delete[] = (int) $pm;
2652
+		} else
2546 2653
 		{
2547 2654
 			if (substr($action, 0, 4) == 'add_')
2548 2655
 			{
2549 2656
 				$type = 'add';
2550 2657
 				$action = substr($action, 4);
2551
-			}
2552
-			elseif (substr($action, 0, 4) == 'rem_')
2658
+			} elseif (substr($action, 0, 4) == 'rem_')
2553 2659
 			{
2554 2660
 				$type = 'rem';
2555 2661
 				$action = substr($action, 4);
2662
+			} else {
2663
+							$type = 'unk';
2556 2664
 			}
2557
-			else
2558
-				$type = 'unk';
2559 2665
 
2560 2666
 			if ($action == '-1' || (int) $action > 0)
2561 2667
 			{
@@ -2566,8 +2672,9 @@  discard block
 block discarded – undo
2566 2672
 	}
2567 2673
 
2568 2674
 	// Deleting, it looks like?
2569
-	if (!empty($to_delete))
2570
-		deleteMessages($to_delete, $context['display_mode'] == 2 ? null : $context['folder']);
2675
+	if (!empty($to_delete)) {
2676
+			deleteMessages($to_delete, $context['display_mode'] == 2 ? null : $context['folder']);
2677
+	}
2571 2678
 
2572 2679
 	// Are we labeling anything?
2573 2680
 	if (!empty($to_label) && $context['folder'] == 'inbox')
@@ -2633,8 +2740,7 @@  discard block
 block discarded – undo
2633 2740
 				}
2634 2741
 
2635 2742
 				$smcFunc['db_free_result']($request2);
2636
-			}
2637
-			elseif ($type == 'rem')
2743
+			} elseif ($type == 'rem')
2638 2744
 			{
2639 2745
 				// If we're removing from the inbox, see if we have at least one other label.
2640 2746
 				// This query is faster than the one above
@@ -2666,21 +2772,25 @@  discard block
 block discarded – undo
2666 2772
 			if ($to_label[$row['id_pm']] != '-1')
2667 2773
 			{
2668 2774
 				// If this label is in the list and we're not adding it, remove it
2669
-				if (array_key_exists($to_label[$row['id_pm']], $labels) && $type !== 'add')
2670
-					unset($labels[$to_label[$row['id_pm']]]);
2671
-				else if ($type !== 'rem')
2672
-					$labels[$to_label[$row['id_pm']]] = $to_label[$row['id_pm']];
2775
+				if (array_key_exists($to_label[$row['id_pm']], $labels) && $type !== 'add') {
2776
+									unset($labels[$to_label[$row['id_pm']]]);
2777
+				} else if ($type !== 'rem') {
2778
+									$labels[$to_label[$row['id_pm']]] = $to_label[$row['id_pm']];
2779
+				}
2673 2780
 			}
2674 2781
 
2675 2782
 			// Removing all labels or just removing the inbox label
2676
-			if ($type == 'rem' && empty($labels))
2677
-				$in_inbox = (empty($context['can_remove_inbox']) ? 1 : 0);
2783
+			if ($type == 'rem' && empty($labels)) {
2784
+							$in_inbox = (empty($context['can_remove_inbox']) ? 1 : 0);
2785
+			}
2678 2786
 			// Adding new labels, but removing inbox and applying new ones
2679
-			elseif ($type == 'add' && !empty($options['pm_remove_inbox_label']) && !empty($labels))
2680
-				$in_inbox = 0;
2787
+			elseif ($type == 'add' && !empty($options['pm_remove_inbox_label']) && !empty($labels)) {
2788
+							$in_inbox = 0;
2789
+			}
2681 2790
 			// Just adding it to the inbox
2682
-			else
2683
-				$in_inbox = 1;
2791
+			else {
2792
+							$in_inbox = 1;
2793
+			}
2684 2794
 
2685 2795
 			// Are we adding it to or removing it from the inbox?
2686 2796
 			if ($in_inbox != $row['in_inbox'])
@@ -2722,8 +2832,9 @@  discard block
 block discarded – undo
2722 2832
 			if (!empty($labels_to_apply))
2723 2833
 			{
2724 2834
 				$inserts = array();
2725
-				foreach ($labels_to_apply as $label)
2726
-					$inserts[] = array($row['id_pm'], $label);
2835
+				foreach ($labels_to_apply as $label) {
2836
+									$inserts[] = array($row['id_pm'], $label);
2837
+				}
2727 2838
 
2728 2839
 				$smcFunc['db_insert']('',
2729 2840
 					'{db_prefix}pm_labeled_messages',
@@ -2767,11 +2878,13 @@  discard block
 block discarded – undo
2767 2878
 	checkSession('get');
2768 2879
 
2769 2880
 	// If all then delete all messages the user has.
2770
-	if ($_REQUEST['f'] == 'all')
2771
-		deleteMessages(null, null);
2881
+	if ($_REQUEST['f'] == 'all') {
2882
+			deleteMessages(null, null);
2883
+	}
2772 2884
 	// Otherwise just the selected folder.
2773
-	else
2774
-		deleteMessages(null, $_REQUEST['f'] != 'sent' ? 'inbox' : 'sent');
2885
+	else {
2886
+			deleteMessages(null, $_REQUEST['f'] != 'sent' ? 'inbox' : 'sent');
2887
+	}
2775 2888
 
2776 2889
 	// Done... all gone.
2777 2890
 	redirectexit($context['current_label_redirect']);
@@ -2808,8 +2921,9 @@  discard block
 block discarded – undo
2808 2921
 				'msgtime' => $deleteTime,
2809 2922
 			)
2810 2923
 		);
2811
-		while ($row = $smcFunc['db_fetch_row']($request))
2812
-			$toDelete[] = $row[0];
2924
+		while ($row = $smcFunc['db_fetch_row']($request)) {
2925
+					$toDelete[] = $row[0];
2926
+		}
2813 2927
 		$smcFunc['db_free_result']($request);
2814 2928
 
2815 2929
 		// Select all messages in their inbox older than $deleteTime.
@@ -2826,8 +2940,9 @@  discard block
 block discarded – undo
2826 2940
 				'msgtime' => $deleteTime,
2827 2941
 			)
2828 2942
 		);
2829
-		while ($row = $smcFunc['db_fetch_assoc']($request))
2830
-			$toDelete[] = $row['id_pm'];
2943
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
2944
+					$toDelete[] = $row['id_pm'];
2945
+		}
2831 2946
 		$smcFunc['db_free_result']($request);
2832 2947
 
2833 2948
 		// Delete the actual messages.
@@ -2858,26 +2973,29 @@  discard block
 block discarded – undo
2858 2973
 {
2859 2974
 	global $user_info, $smcFunc;
2860 2975
 
2861
-	if ($owner === null)
2862
-		$owner = array($user_info['id']);
2863
-	elseif (empty($owner))
2864
-		return;
2865
-	elseif (!is_array($owner))
2866
-		$owner = array($owner);
2976
+	if ($owner === null) {
2977
+			$owner = array($user_info['id']);
2978
+	} elseif (empty($owner)) {
2979
+			return;
2980
+	} elseif (!is_array($owner)) {
2981
+			$owner = array($owner);
2982
+	}
2867 2983
 
2868 2984
 	if ($personal_messages !== null)
2869 2985
 	{
2870
-		if (empty($personal_messages) || !is_array($personal_messages))
2871
-			return;
2986
+		if (empty($personal_messages) || !is_array($personal_messages)) {
2987
+					return;
2988
+		}
2872 2989
 
2873
-		foreach ($personal_messages as $index => $delete_id)
2874
-			$personal_messages[$index] = (int) $delete_id;
2990
+		foreach ($personal_messages as $index => $delete_id) {
2991
+					$personal_messages[$index] = (int) $delete_id;
2992
+		}
2875 2993
 
2876 2994
 		$where = '
2877 2995
 				AND id_pm IN ({array_int:pm_list})';
2996
+	} else {
2997
+			$where = '';
2878 2998
 	}
2879
-	else
2880
-		$where = '';
2881 2999
 
2882 3000
 	if ($folder == 'sent' || $folder === null)
2883 3001
 	{
@@ -2912,17 +3030,19 @@  discard block
 block discarded – undo
2912 3030
 		// ...And update the statistics accordingly - now including unread messages!.
2913 3031
 		while ($row = $smcFunc['db_fetch_assoc']($request))
2914 3032
 		{
2915
-			if ($row['is_read'])
2916
-				updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages']));
2917
-			else
2918
-				updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'], 'unread_messages' => $where == '' ? 0 : 'unread_messages - ' . $row['num_deleted_messages']));
3033
+			if ($row['is_read']) {
3034
+							updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages']));
3035
+			} else {
3036
+							updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'], 'unread_messages' => $where == '' ? 0 : 'unread_messages - ' . $row['num_deleted_messages']));
3037
+			}
2919 3038
 
2920 3039
 			// If this is the current member we need to make their message count correct.
2921 3040
 			if ($user_info['id'] == $row['id_member'])
2922 3041
 			{
2923 3042
 				$user_info['messages'] -= $row['num_deleted_messages'];
2924
-				if (!($row['is_read']))
2925
-					$user_info['unread_messages'] -= $row['num_deleted_messages'];
3043
+				if (!($row['is_read'])) {
3044
+									$user_info['unread_messages'] -= $row['num_deleted_messages'];
3045
+				}
2926 3046
 			}
2927 3047
 		}
2928 3048
 		$smcFunc['db_free_result']($request);
@@ -2990,8 +3110,9 @@  discard block
 block discarded – undo
2990 3110
 		)
2991 3111
 	);
2992 3112
 	$remove_pms = array();
2993
-	while ($row = $smcFunc['db_fetch_assoc']($request))
2994
-		$remove_pms[] = $row['sender'];
3113
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
3114
+			$remove_pms[] = $row['sender'];
3115
+	}
2995 3116
 	$smcFunc['db_free_result']($request);
2996 3117
 
2997 3118
 	if (!empty($remove_pms))
@@ -3036,8 +3157,9 @@  discard block
 block discarded – undo
3036 3157
 {
3037 3158
 	global $user_info, $context, $smcFunc;
3038 3159
 
3039
-	if ($owner === null)
3040
-		$owner = $user_info['id'];
3160
+	if ($owner === null) {
3161
+			$owner = $user_info['id'];
3162
+	}
3041 3163
 
3042 3164
 	$in_inbox = '';
3043 3165
 
@@ -3061,8 +3183,7 @@  discard block
 block discarded – undo
3061 3183
 		}
3062 3184
 
3063 3185
 		$smcFunc['db_free_result']($get_messages);
3064
-	}
3065
-	elseif ($label = '-1')
3186
+	} elseif ($label = '-1')
3066 3187
 	{
3067 3188
 		// Marking all PMs in your inbox read
3068 3189
 		$in_inbox = '
@@ -3087,8 +3208,9 @@  discard block
 block discarded – undo
3087 3208
 	{
3088 3209
 		if ($owner == $user_info['id'])
3089 3210
 		{
3090
-			foreach ($context['labels'] as $label)
3091
-				$context['labels'][(int) $label['id']]['unread_messages'] = 0;
3211
+			foreach ($context['labels'] as $label) {
3212
+							$context['labels'][(int) $label['id']]['unread_messages'] = 0;
3213
+			}
3092 3214
 		}
3093 3215
 
3094 3216
 		$result = $smcFunc['db_query']('', '
@@ -3108,8 +3230,9 @@  discard block
 block discarded – undo
3108 3230
 		{
3109 3231
 			$total_unread += $row['num'];
3110 3232
 
3111
-			if ($owner != $user_info['id'] || empty($row['id_pm']))
3112
-				continue;
3233
+			if ($owner != $user_info['id'] || empty($row['id_pm'])) {
3234
+							continue;
3235
+			}
3113 3236
 
3114 3237
 			$this_labels = array();
3115 3238
 
@@ -3133,11 +3256,13 @@  discard block
 block discarded – undo
3133 3256
 
3134 3257
 			$smcFunc['db_free_result']($result2);
3135 3258
 
3136
-			foreach ($this_labels as $this_label)
3137
-				$context['labels'][$this_label]['unread_messages'] += $row['num'];
3259
+			foreach ($this_labels as $this_label) {
3260
+							$context['labels'][$this_label]['unread_messages'] += $row['num'];
3261
+			}
3138 3262
 
3139
-			if ($row['in_inbox'] == 1)
3140
-				$context['labels'][-1]['unread_messages'] += $row['num'];
3263
+			if ($row['in_inbox'] == 1) {
3264
+							$context['labels'][-1]['unread_messages'] += $row['num'];
3265
+			}
3141 3266
 		}
3142 3267
 		$smcFunc['db_free_result']($result);
3143 3268
 
@@ -3146,8 +3271,9 @@  discard block
 block discarded – undo
3146 3271
 		updateMemberData($owner, array('unread_messages' => $total_unread));
3147 3272
 
3148 3273
 		// If it was for the current member, reflect this in the $user_info array too.
3149
-		if ($owner == $user_info['id'])
3150
-			$user_info['unread_messages'] = $total_unread;
3274
+		if ($owner == $user_info['id']) {
3275
+					$user_info['unread_messages'] = $total_unread;
3276
+		}
3151 3277
 	}
3152 3278
 }
3153 3279
 
@@ -3175,8 +3301,9 @@  discard block
 block discarded – undo
3175 3301
 	// Add all existing labels to the array to save, slashing them as necessary...
3176 3302
 	foreach ($context['labels'] as $label)
3177 3303
 	{
3178
-		if ($label['id'] != -1)
3179
-			$the_labels[$label['id']] = $label['name'];
3304
+		if ($label['id'] != -1) {
3305
+					$the_labels[$label['id']] = $label['name'];
3306
+		}
3180 3307
 	}
3181 3308
 
3182 3309
 	if (isset($_POST[$context['session_var']]))
@@ -3195,8 +3322,9 @@  discard block
 block discarded – undo
3195 3322
 		{
3196 3323
 			$_POST['label'] = strtr($smcFunc['htmlspecialchars'](trim($_POST['label'])), array(',' => '&#044;'));
3197 3324
 
3198
-			if ($smcFunc['strlen']($_POST['label']) > 30)
3199
-				$_POST['label'] = $smcFunc['substr']($_POST['label'], 0, 30);
3325
+			if ($smcFunc['strlen']($_POST['label']) > 30) {
3326
+							$_POST['label'] = $smcFunc['substr']($_POST['label'], 0, 30);
3327
+			}
3200 3328
 			if ($_POST['label'] != '')
3201 3329
 			{
3202 3330
 				$the_labels[] = $_POST['label'];
@@ -3217,24 +3345,25 @@  discard block
 block discarded – undo
3217 3345
 		{
3218 3346
 			foreach ($the_labels as $id => $name)
3219 3347
 			{
3220
-				if ($id == -1)
3221
-					continue;
3222
-				elseif (isset($_POST['label_name'][$id]))
3348
+				if ($id == -1) {
3349
+									continue;
3350
+				} elseif (isset($_POST['label_name'][$id]))
3223 3351
 				{
3224 3352
 					$_POST['label_name'][$id] = trim(strtr($smcFunc['htmlspecialchars']($_POST['label_name'][$id]), array(',' => '&#044;')));
3225 3353
 
3226
-					if ($smcFunc['strlen']($_POST['label_name'][$id]) > 30)
3227
-						$_POST['label_name'][$id] = $smcFunc['substr']($_POST['label_name'][$id], 0, 30);
3354
+					if ($smcFunc['strlen']($_POST['label_name'][$id]) > 30) {
3355
+											$_POST['label_name'][$id] = $smcFunc['substr']($_POST['label_name'][$id], 0, 30);
3356
+					}
3228 3357
 					if ($_POST['label_name'][$id] != '')
3229 3358
 					{
3230 3359
 						// Changing the name of this label?
3231
-						if ($the_labels[$id] != $_POST['label_name'][$id])
3232
-							$label_updates[$id] = $_POST['label_name'][$id];
3360
+						if ($the_labels[$id] != $_POST['label_name'][$id]) {
3361
+													$label_updates[$id] = $_POST['label_name'][$id];
3362
+						}
3233 3363
 
3234 3364
 						$the_labels[(int) $id] = $_POST['label_name'][$id];
3235 3365
 
3236
-					}
3237
-					else
3366
+					} else
3238 3367
 					{
3239 3368
 						unset($the_labels[(int) $id]);
3240 3369
 						$labels_to_remove[] = $id;
@@ -3248,8 +3377,9 @@  discard block
 block discarded – undo
3248 3377
 		if (!empty($labels_to_add))
3249 3378
 		{
3250 3379
 			$inserts = array();
3251
-			foreach ($labels_to_add AS $label)
3252
-				$inserts[] = array($user_info['id'], $label);
3380
+			foreach ($labels_to_add AS $label) {
3381
+							$inserts[] = array($user_info['id'], $label);
3382
+			}
3253 3383
 
3254 3384
 			$smcFunc['db_insert']('', '{db_prefix}pm_labels', array('id_member' => 'int', 'name' => 'string-30'), $inserts, array());
3255 3385
 		}
@@ -3339,8 +3469,9 @@  discard block
 block discarded – undo
3339 3469
 				// Each action...
3340 3470
 				foreach ($rule['actions'] as $k2 => $action)
3341 3471
 				{
3342
-					if ($action['t'] != 'lab' || !in_array($action['v'], $labels_to_remove))
3343
-						continue;
3472
+					if ($action['t'] != 'lab' || !in_array($action['v'], $labels_to_remove)) {
3473
+											continue;
3474
+					}
3344 3475
 
3345 3476
 					$rule_changes[] = $rule['id'];
3346 3477
 
@@ -3355,8 +3486,8 @@  discard block
 block discarded – undo
3355 3486
 		{
3356 3487
 			$rule_changes = array_unique($rule_changes);
3357 3488
 			// Update/delete as appropriate.
3358
-			foreach ($rule_changes as $k => $id)
3359
-				if (!empty($context['rules'][$id]['actions']))
3489
+			foreach ($rule_changes as $k => $id) {
3490
+							if (!empty($context['rules'][$id]['actions']))
3360 3491
 				{
3361 3492
 					$smcFunc['db_query']('', '
3362 3493
 						UPDATE {db_prefix}pm_rules
@@ -3369,12 +3500,13 @@  discard block
 block discarded – undo
3369 3500
 							'actions' => $smcFunc['json_encode']($context['rules'][$id]['actions']),
3370 3501
 						)
3371 3502
 					);
3503
+			}
3372 3504
 					unset($rule_changes[$k]);
3373 3505
 				}
3374 3506
 
3375 3507
 			// Anything left here means it's lost all actions...
3376
-			if (!empty($rule_changes))
3377
-				$smcFunc['db_query']('', '
3508
+			if (!empty($rule_changes)) {
3509
+							$smcFunc['db_query']('', '
3378 3510
 					DELETE FROM {db_prefix}pm_rules
3379 3511
 					WHERE id_rule IN ({array_int:rule_list})
3380 3512
 							AND id_member = {int:current_member}',
@@ -3383,6 +3515,7 @@  discard block
 block discarded – undo
3383 3515
 						'rule_list' => $rule_changes,
3384 3516
 					)
3385 3517
 				);
3518
+			}
3386 3519
 		}
3387 3520
 
3388 3521
 		// Make sure we're not caching this!
@@ -3452,8 +3585,9 @@  discard block
 block discarded – undo
3452 3585
 		// Save the fields.
3453 3586
 		saveProfileFields();
3454 3587
 
3455
-		if (!empty($profile_vars))
3456
-			updateMemberData($user_info['id'], $profile_vars);
3588
+		if (!empty($profile_vars)) {
3589
+					updateMemberData($user_info['id'], $profile_vars);
3590
+		}
3457 3591
 	}
3458 3592
 
3459 3593
 	setupProfileContext(
@@ -3478,13 +3612,15 @@  discard block
 block discarded – undo
3478 3612
 	global $user_info, $language, $modSettings, $smcFunc;
3479 3613
 
3480 3614
 	// Check that this feature is even enabled!
3481
-	if (empty($modSettings['enableReportPM']) || empty($_REQUEST['pmsg']))
3482
-		fatal_lang_error('no_access', false);
3615
+	if (empty($modSettings['enableReportPM']) || empty($_REQUEST['pmsg'])) {
3616
+			fatal_lang_error('no_access', false);
3617
+	}
3483 3618
 
3484 3619
 	$pmsg = (int) $_REQUEST['pmsg'];
3485 3620
 
3486
-	if (!isAccessiblePM($pmsg, 'inbox'))
3487
-		fatal_lang_error('no_access', false);
3621
+	if (!isAccessiblePM($pmsg, 'inbox')) {
3622
+			fatal_lang_error('no_access', false);
3623
+	}
3488 3624
 
3489 3625
 	$context['pm_id'] = $pmsg;
3490 3626
 	$context['page_title'] = $txt['pm_report_title'];
@@ -3506,8 +3642,9 @@  discard block
 block discarded – undo
3506 3642
 			)
3507 3643
 		);
3508 3644
 		$context['admins'] = array();
3509
-		while ($row = $smcFunc['db_fetch_assoc']($request))
3510
-			$context['admins'][$row['id_member']] = $row['real_name'];
3645
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
3646
+					$context['admins'][$row['id_member']] = $row['real_name'];
3647
+		}
3511 3648
 		$smcFunc['db_free_result']($request);
3512 3649
 
3513 3650
 		// How many admins in total?
@@ -3536,8 +3673,9 @@  discard block
 block discarded – undo
3536 3673
 			)
3537 3674
 		);
3538 3675
 		// Can only be a hacker here!
3539
-		if ($smcFunc['db_num_rows']($request) == 0)
3540
-			fatal_lang_error('no_access', false);
3676
+		if ($smcFunc['db_num_rows']($request) == 0) {
3677
+					fatal_lang_error('no_access', false);
3678
+		}
3541 3679
 		list ($subject, $body, $time, $memberFromID, $memberFromName) = $smcFunc['db_fetch_row']($request);
3542 3680
 		$smcFunc['db_free_result']($request);
3543 3681
 
@@ -3561,15 +3699,17 @@  discard block
 block discarded – undo
3561 3699
 		while ($row = $smcFunc['db_fetch_assoc']($request))
3562 3700
 		{
3563 3701
 			// If it's hidden still don't reveal their names - privacy after all ;)
3564
-			if ($row['bcc'])
3565
-				$hidden_recipients++;
3566
-			else
3567
-				$recipients[] = '[url=' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . ']' . $row['to_name'] . '[/url]';
3702
+			if ($row['bcc']) {
3703
+							$hidden_recipients++;
3704
+			} else {
3705
+							$recipients[] = '[url=' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . ']' . $row['to_name'] . '[/url]';
3706
+			}
3568 3707
 		}
3569 3708
 		$smcFunc['db_free_result']($request);
3570 3709
 
3571
-		if ($hidden_recipients)
3572
-			$recipients[] = sprintf($txt['pm_report_pm_hidden'], $hidden_recipients);
3710
+		if ($hidden_recipients) {
3711
+					$recipients[] = sprintf($txt['pm_report_pm_hidden'], $hidden_recipients);
3712
+		}
3573 3713
 
3574 3714
 		// Now let's get out and loop through the admins.
3575 3715
 		$request = $smcFunc['db_query']('', '
@@ -3585,8 +3725,9 @@  discard block
 block discarded – undo
3585 3725
 		);
3586 3726
 
3587 3727
 		// Maybe we shouldn't advertise this?
3588
-		if ($smcFunc['db_num_rows']($request) == 0)
3589
-			fatal_lang_error('no_access', false);
3728
+		if ($smcFunc['db_num_rows']($request) == 0) {
3729
+					fatal_lang_error('no_access', false);
3730
+		}
3590 3731
 
3591 3732
 		$memberFromName = un_htmlspecialchars($memberFromName);
3592 3733
 
@@ -3605,8 +3746,9 @@  discard block
 block discarded – undo
3605 3746
 				// Make the body.
3606 3747
 				$report_body = str_replace(array('{REPORTER}', '{SENDER}'), array(un_htmlspecialchars($user_info['name']), $memberFromName), $txt['pm_report_pm_user_sent']);
3607 3748
 				$report_body .= "\n" . '[b]' . $_POST['reason'] . '[/b]' . "\n\n";
3608
-				if (!empty($recipients))
3609
-					$report_body .= $txt['pm_report_pm_other_recipients'] . ' ' . implode(', ', $recipients) . "\n\n";
3749
+				if (!empty($recipients)) {
3750
+									$report_body .= $txt['pm_report_pm_other_recipients'] . ' ' . implode(', ', $recipients) . "\n\n";
3751
+				}
3610 3752
 				$report_body .= $txt['pm_report_pm_unedited_below'] . "\n" . '[quote author=' . (empty($memberFromID) ? '&quot;' . $memberFromName . '&quot;' : $memberFromName . ' link=action=profile;u=' . $memberFromID . ' date=' . $time) . ']' . "\n" . un_htmlspecialchars($body) . '[/quote]';
3611 3753
 
3612 3754
 				// Plonk it in the array ;)
@@ -3626,12 +3768,14 @@  discard block
 block discarded – undo
3626 3768
 		$smcFunc['db_free_result']($request);
3627 3769
 
3628 3770
 		// Send a different email for each language.
3629
-		foreach ($messagesToSend as $lang => $message)
3630
-			sendpm($message['recipients'], $message['subject'], $message['body']);
3771
+		foreach ($messagesToSend as $lang => $message) {
3772
+					sendpm($message['recipients'], $message['subject'], $message['body']);
3773
+		}
3631 3774
 
3632 3775
 		// Give the user their own language back!
3633
-		if (!empty($modSettings['userLanguage']))
3634
-			loadLanguage('PersonalMessage', '', false);
3776
+		if (!empty($modSettings['userLanguage'])) {
3777
+					loadLanguage('PersonalMessage', '', false);
3778
+		}
3635 3779
 
3636 3780
 		// Leave them with a template.
3637 3781
 		$context['sub_template'] = 'report_message_complete';
@@ -3677,8 +3821,9 @@  discard block
 block discarded – undo
3677 3821
 	while ($row = $smcFunc['db_fetch_assoc']($request))
3678 3822
 	{
3679 3823
 		// Hide hidden groups!
3680
-		if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups'))
3681
-			continue;
3824
+		if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups')) {
3825
+					continue;
3826
+		}
3682 3827
 
3683 3828
 		$context['groups'][$row['id_group']] = $row['group_name'];
3684 3829
 	}
@@ -3704,9 +3849,10 @@  discard block
 block discarded – undo
3704 3849
 			$context['rule'] = $context['rules'][$context['rid']];
3705 3850
 			$members = array();
3706 3851
 			// Need to get member names!
3707
-			foreach ($context['rule']['criteria'] as $k => $criteria)
3708
-				if ($criteria['t'] == 'mid' && !empty($criteria['v']))
3852
+			foreach ($context['rule']['criteria'] as $k => $criteria) {
3853
+							if ($criteria['t'] == 'mid' && !empty($criteria['v']))
3709 3854
 					$members[(int) $criteria['v']] = $k;
3855
+			}
3710 3856
 
3711 3857
 			if (!empty($members))
3712 3858
 			{
@@ -3718,19 +3864,20 @@  discard block
 block discarded – undo
3718 3864
 						'member_list' => array_keys($members),
3719 3865
 					)
3720 3866
 				);
3721
-				while ($row = $smcFunc['db_fetch_assoc']($request))
3722
-					$context['rule']['criteria'][$members[$row['id_member']]]['v'] = $row['member_name'];
3867
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
3868
+									$context['rule']['criteria'][$members[$row['id_member']]]['v'] = $row['member_name'];
3869
+				}
3723 3870
 				$smcFunc['db_free_result']($request);
3724 3871
 			}
3725
-		}
3726
-		else
3727
-			$context['rule'] = array(
3872
+		} else {
3873
+					$context['rule'] = array(
3728 3874
 				'id' => '',
3729 3875
 				'name' => '',
3730 3876
 				'criteria' => array(),
3731 3877
 				'actions' => array(),
3732 3878
 				'logic' => 'and',
3733 3879
 			);
3880
+		}
3734 3881
 	}
3735 3882
 	// Saving?
3736 3883
 	elseif (isset($_GET['save']))
@@ -3740,22 +3887,25 @@  discard block
 block discarded – undo
3740 3887
 
3741 3888
 		// Name is easy!
3742 3889
 		$ruleName = $smcFunc['htmlspecialchars'](trim($_POST['rule_name']));
3743
-		if (empty($ruleName))
3744
-			fatal_lang_error('pm_rule_no_name', false);
3890
+		if (empty($ruleName)) {
3891
+					fatal_lang_error('pm_rule_no_name', false);
3892
+		}
3745 3893
 
3746 3894
 		// Sanity check...
3747
-		if (empty($_POST['ruletype']) || empty($_POST['acttype']))
3748
-			fatal_lang_error('pm_rule_no_criteria', false);
3895
+		if (empty($_POST['ruletype']) || empty($_POST['acttype'])) {
3896
+					fatal_lang_error('pm_rule_no_criteria', false);
3897
+		}
3749 3898
 
3750 3899
 		// Let's do the criteria first - it's also hardest!
3751 3900
 		$criteria = array();
3752 3901
 		foreach ($_POST['ruletype'] as $ind => $type)
3753 3902
 		{
3754 3903
 			// Check everything is here...
3755
-			if ($type == 'gid' && (!isset($_POST['ruledefgroup'][$ind]) || !isset($context['groups'][$_POST['ruledefgroup'][$ind]])))
3756
-				continue;
3757
-			elseif ($type != 'bud' && !isset($_POST['ruledef'][$ind]))
3758
-				continue;
3904
+			if ($type == 'gid' && (!isset($_POST['ruledefgroup'][$ind]) || !isset($context['groups'][$_POST['ruledefgroup'][$ind]]))) {
3905
+							continue;
3906
+			} elseif ($type != 'bud' && !isset($_POST['ruledef'][$ind])) {
3907
+							continue;
3908
+			}
3759 3909
 
3760 3910
 			// Members need to be found.
3761 3911
 			if ($type == 'mid')
@@ -3779,13 +3929,13 @@  discard block
 block discarded – undo
3779 3929
 				$smcFunc['db_free_result']($request);
3780 3930
 
3781 3931
 				$criteria[] = array('t' => 'mid', 'v' => $memID);
3932
+			} elseif ($type == 'bud') {
3933
+							$criteria[] = array('t' => 'bud', 'v' => 1);
3934
+			} elseif ($type == 'gid') {
3935
+							$criteria[] = array('t' => 'gid', 'v' => (int) $_POST['ruledefgroup'][$ind]);
3936
+			} elseif (in_array($type, array('sub', 'msg')) && trim($_POST['ruledef'][$ind]) != '') {
3937
+							$criteria[] = array('t' => $type, 'v' => $smcFunc['htmlspecialchars'](trim($_POST['ruledef'][$ind])));
3782 3938
 			}
3783
-			elseif ($type == 'bud')
3784
-				$criteria[] = array('t' => 'bud', 'v' => 1);
3785
-			elseif ($type == 'gid')
3786
-				$criteria[] = array('t' => 'gid', 'v' => (int) $_POST['ruledefgroup'][$ind]);
3787
-			elseif (in_array($type, array('sub', 'msg')) && trim($_POST['ruledef'][$ind]) != '')
3788
-				$criteria[] = array('t' => $type, 'v' => $smcFunc['htmlspecialchars'](trim($_POST['ruledef'][$ind])));
3789 3939
 		}
3790 3940
 
3791 3941
 		// Also do the actions!
@@ -3795,26 +3945,29 @@  discard block
 block discarded – undo
3795 3945
 		foreach ($_POST['acttype'] as $ind => $type)
3796 3946
 		{
3797 3947
 			// Picking a valid label?
3798
-			if ($type == 'lab' && (!isset($_POST['labdef'][$ind]) || !isset($context['labels'][$_POST['labdef'][$ind]])))
3799
-				continue;
3948
+			if ($type == 'lab' && (!isset($_POST['labdef'][$ind]) || !isset($context['labels'][$_POST['labdef'][$ind]]))) {
3949
+							continue;
3950
+			}
3800 3951
 
3801 3952
 			// Record what we're doing.
3802
-			if ($type == 'del')
3803
-				$doDelete = 1;
3804
-			elseif ($type == 'lab')
3805
-				$actions[] = array('t' => 'lab', 'v' => (int) $_POST['labdef'][$ind]);
3953
+			if ($type == 'del') {
3954
+							$doDelete = 1;
3955
+			} elseif ($type == 'lab') {
3956
+							$actions[] = array('t' => 'lab', 'v' => (int) $_POST['labdef'][$ind]);
3957
+			}
3806 3958
 		}
3807 3959
 
3808
-		if (empty($criteria) || (empty($actions) && !$doDelete))
3809
-			fatal_lang_error('pm_rule_no_criteria', false);
3960
+		if (empty($criteria) || (empty($actions) && !$doDelete)) {
3961
+					fatal_lang_error('pm_rule_no_criteria', false);
3962
+		}
3810 3963
 
3811 3964
 		// What are we storing?
3812 3965
 		$criteria = $smcFunc['json_encode']($criteria);
3813 3966
 		$actions = $smcFunc['json_encode']($actions);
3814 3967
 
3815 3968
 		// Create the rule?
3816
-		if (empty($context['rid']))
3817
-			$smcFunc['db_insert']('',
3969
+		if (empty($context['rid'])) {
3970
+					$smcFunc['db_insert']('',
3818 3971
 				'{db_prefix}pm_rules',
3819 3972
 				array(
3820 3973
 					'id_member' => 'int', 'rule_name' => 'string', 'criteria' => 'string', 'actions' => 'string',
@@ -3825,8 +3978,8 @@  discard block
 block discarded – undo
3825 3978
 				),
3826 3979
 				array('id_rule')
3827 3980
 			);
3828
-		else
3829
-			$smcFunc['db_query']('', '
3981
+		} else {
3982
+					$smcFunc['db_query']('', '
3830 3983
 				UPDATE {db_prefix}pm_rules
3831 3984
 				SET rule_name = {string:rule_name}, criteria = {string:criteria}, actions = {string:actions},
3832 3985
 					delete_pm = {int:delete_pm}, is_or = {int:is_or}
@@ -3842,6 +3995,7 @@  discard block
 block discarded – undo
3842 3995
 					'actions' => $actions,
3843 3996
 				)
3844 3997
 			);
3998
+		}
3845 3999
 
3846 4000
 		redirectexit('action=pm;sa=manrules');
3847 4001
 	}
@@ -3850,11 +4004,12 @@  discard block
 block discarded – undo
3850 4004
 	{
3851 4005
 		checkSession();
3852 4006
 		$toDelete = array();
3853
-		foreach ($_POST['delrule'] as $k => $v)
3854
-			$toDelete[] = (int) $k;
4007
+		foreach ($_POST['delrule'] as $k => $v) {
4008
+					$toDelete[] = (int) $k;
4009
+		}
3855 4010
 
3856
-		if (!empty($toDelete))
3857
-			$smcFunc['db_query']('', '
4011
+		if (!empty($toDelete)) {
4012
+					$smcFunc['db_query']('', '
3858 4013
 				DELETE FROM {db_prefix}pm_rules
3859 4014
 				WHERE id_rule IN ({array_int:delete_list})
3860 4015
 					AND id_member = {int:current_member}',
@@ -3863,6 +4018,7 @@  discard block
 block discarded – undo
3863 4018
 					'delete_list' => $toDelete,
3864 4019
 				)
3865 4020
 			);
4021
+		}
3866 4022
 
3867 4023
 		redirectexit('action=pm;sa=manrules');
3868 4024
 	}
@@ -3881,8 +4037,9 @@  discard block
 block discarded – undo
3881 4037
 	loadRules();
3882 4038
 
3883 4039
 	// No rules?
3884
-	if (empty($context['rules']))
3885
-		return;
4040
+	if (empty($context['rules'])) {
4041
+			return;
4042
+	}
3886 4043
 
3887 4044
 	// Just unread ones?
3888 4045
 	$ruleQuery = $all_messages ? '' : ' AND pmr.is_new = 1';
@@ -3912,8 +4069,9 @@  discard block
 block discarded – undo
3912 4069
 			// Loop through all the criteria hoping to make a match.
3913 4070
 			foreach ($rule['criteria'] as $criterium)
3914 4071
 			{
3915
-				if (($criterium['t'] == 'mid' && $criterium['v'] == $row['id_member_from']) || ($criterium['t'] == 'gid' && $criterium['v'] == $row['id_group']) || ($criterium['t'] == 'sub' && strpos($row['subject'], $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($row['body'], $criterium['v']) !== false))
3916
-					$match = true;
4072
+				if (($criterium['t'] == 'mid' && $criterium['v'] == $row['id_member_from']) || ($criterium['t'] == 'gid' && $criterium['v'] == $row['id_group']) || ($criterium['t'] == 'sub' && strpos($row['subject'], $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($row['body'], $criterium['v']) !== false)) {
4073
+									$match = true;
4074
+				}
3917 4075
 				// If we're adding and one criteria don't match then we stop!
3918 4076
 				elseif ($rule['logic'] == 'and')
3919 4077
 				{
@@ -3925,17 +4083,18 @@  discard block
 block discarded – undo
3925 4083
 			// If we have a match the rule must be true - act!
3926 4084
 			if ($match)
3927 4085
 			{
3928
-				if ($rule['delete'])
3929
-					$actions['deletes'][] = $row['id_pm'];
3930
-				else
4086
+				if ($rule['delete']) {
4087
+									$actions['deletes'][] = $row['id_pm'];
4088
+				} else
3931 4089
 				{
3932 4090
 					foreach ($rule['actions'] as $ruleAction)
3933 4091
 					{
3934 4092
 						if ($ruleAction['t'] == 'lab')
3935 4093
 						{
3936 4094
 							// Get a basic pot started!
3937
-							if (!isset($actions['labels'][$row['id_pm']]))
3938
-								$actions['labels'][$row['id_pm']] = array();
4095
+							if (!isset($actions['labels'][$row['id_pm']])) {
4096
+															$actions['labels'][$row['id_pm']] = array();
4097
+							}
3939 4098
 							$actions['labels'][$row['id_pm']][] = $ruleAction['v'];
3940 4099
 						}
3941 4100
 					}
@@ -3946,8 +4105,9 @@  discard block
 block discarded – undo
3946 4105
 	$smcFunc['db_free_result']($request);
3947 4106
 
3948 4107
 	// Deletes are easy!
3949
-	if (!empty($actions['deletes']))
3950
-		deleteMessages($actions['deletes']);
4108
+	if (!empty($actions['deletes'])) {
4109
+			deleteMessages($actions['deletes']);
4110
+	}
3951 4111
 
3952 4112
 	// Relabel?
3953 4113
 	if (!empty($actions['labels']))
@@ -3974,8 +4134,7 @@  discard block
 block discarded – undo
3974 4134
 								'current_member' => $user_info['id'],
3975 4135
 							)
3976 4136
 						);
3977
-					}
3978
-					else
4137
+					} else
3979 4138
 					{
3980 4139
 						$realLabels[] = $label['id'];
3981 4140
 					}
@@ -3984,8 +4143,9 @@  discard block
 block discarded – undo
3984 4143
 
3985 4144
 			$inserts = array();
3986 4145
 			// Now we insert the label info
3987
-			foreach ($realLabels as $a_label)
3988
-				$inserts[] = array($pm, $a_label);
4146
+			foreach ($realLabels as $a_label) {
4147
+							$inserts[] = array($pm, $a_label);
4148
+			}
3989 4149
 
3990 4150
 			$smcFunc['db_insert']('ignore',
3991 4151
 				'{db_prefix}pm_labeled_messages',
@@ -4006,8 +4166,9 @@  discard block
 block discarded – undo
4006 4166
 {
4007 4167
 	global $user_info, $context, $smcFunc;
4008 4168
 
4009
-	if (isset($context['rules']) && !$reload)
4010
-		return;
4169
+	if (isset($context['rules']) && !$reload) {
4170
+			return;
4171
+	}
4011 4172
 
4012 4173
 	$request = $smcFunc['db_query']('', '
4013 4174
 		SELECT
@@ -4031,8 +4192,9 @@  discard block
 block discarded – undo
4031 4192
 			'logic' => $row['is_or'] ? 'or' : 'and',
4032 4193
 		);
4033 4194
 
4034
-		if ($row['delete_pm'])
4035
-			$context['rules'][$row['id_rule']]['actions'][] = array('t' => 'del', 'v' => 1);
4195
+		if ($row['delete_pm']) {
4196
+					$context['rules'][$row['id_rule']]['actions'][] = array('t' => 'del', 'v' => 1);
4197
+		}
4036 4198
 	}
4037 4199
 	$smcFunc['db_free_result']($request);
4038 4200
 }
Please login to merge, or discard this patch.
Sources/Display.php 1 patch
Braces   +292 added lines, -214 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * The central part of the board - topic display.
@@ -34,8 +35,9 @@  discard block
 block discarded – undo
34 35
 	global $messages_request, $language, $smcFunc;
35 36
 
36 37
 	// What are you gonna display if these are empty?!
37
-	if (empty($topic))
38
-		fatal_lang_error('no_board', false);
38
+	if (empty($topic)) {
39
+			fatal_lang_error('no_board', false);
40
+	}
39 41
 
40 42
 	// Load the proper template.
41 43
 	loadTemplate('Display');
@@ -52,15 +54,17 @@  discard block
 block discarded – undo
52 54
 	$context['messages_per_page'] = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages'];
53 55
 
54 56
 	// Let's do some work on what to search index.
55
-	if (count($_GET) > 2)
56
-		foreach ($_GET as $k => $v)
57
+	if (count($_GET) > 2) {
58
+			foreach ($_GET as $k => $v)
57 59
 		{
58 60
 			if (!in_array($k, array('topic', 'board', 'start', session_name())))
59 61
 				$context['robot_no_index'] = true;
62
+	}
60 63
 		}
61 64
 
62
-	if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0))
63
-		$context['robot_no_index'] = true;
65
+	if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) {
66
+			$context['robot_no_index'] = true;
67
+	}
64 68
 
65 69
 	// Find the previous or next topic.  Make a fuss if there are no more.
66 70
 	if (isset($_REQUEST['prev_next']) && ($_REQUEST['prev_next'] == 'prev' || $_REQUEST['prev_next'] == 'next'))
@@ -172,8 +176,9 @@  discard block
 block discarded – undo
172 176
 			$topic_parameters
173 177
 	);
174 178
 
175
-	if ($smcFunc['db_num_rows']($request) == 0)
176
-		fatal_lang_error('not_a_topic', false, 404);
179
+	if ($smcFunc['db_num_rows']($request) == 0) {
180
+			fatal_lang_error('not_a_topic', false, 404);
181
+	}
177 182
 	$context['topicinfo'] = $smcFunc['db_fetch_assoc']($request);
178 183
 	$smcFunc['db_free_result']($request);
179 184
 
@@ -210,8 +215,9 @@  discard block
 block discarded – undo
210 215
 	$context['topic_unwatched'] = isset($context['topicinfo']['unwatched']) ? $context['topicinfo']['unwatched'] : 0;
211 216
 
212 217
 	// Add up unapproved replies to get real number of replies...
213
-	if ($modSettings['postmod_active'] && $approve_posts)
214
-		$context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1);
218
+	if ($modSettings['postmod_active'] && $approve_posts) {
219
+			$context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1);
220
+	}
215 221
 
216 222
 	// If this topic has unapproved posts, we need to work out how many posts the user can see, for page indexing.
217 223
 	if ($modSettings['postmod_active'] && $context['topicinfo']['unapproved_posts'] && !$user_info['is_guest'] && !$approve_posts)
@@ -231,11 +237,11 @@  discard block
 block discarded – undo
231 237
 		$smcFunc['db_free_result']($request);
232 238
 
233 239
 		$context['total_visible_posts'] = $context['num_replies'] + $myUnapprovedPosts + ($context['topicinfo']['approved'] ? 1 : 0);
240
+	} elseif ($user_info['is_guest']) {
241
+			$context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0);
242
+	} else {
243
+			$context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0);
234 244
 	}
235
-	elseif ($user_info['is_guest'])
236
-		$context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0);
237
-	else
238
-		$context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0);
239 245
 
240 246
 	// The start isn't a number; it's information about what to do, where to go.
241 247
 	if (!is_numeric($_REQUEST['start']))
@@ -248,8 +254,7 @@  discard block
 block discarded – undo
248 254
 			{
249 255
 				$context['start_from'] = $context['total_visible_posts'] - 1;
250 256
 				$_REQUEST['start'] = empty($options['view_newest_first']) ? $context['start_from'] : 0;
251
-			}
252
-			else
257
+			} else
253 258
 			{
254 259
 				// Find the earliest unread message in the topic. (the use of topics here is just for both tables.)
255 260
 				$request = $smcFunc['db_query']('', '
@@ -277,9 +282,9 @@  discard block
 block discarded – undo
277 282
 		if (substr($_REQUEST['start'], 0, 4) == 'from')
278 283
 		{
279 284
 			$timestamp = (int) substr($_REQUEST['start'], 4);
280
-			if ($timestamp === 0)
281
-				$_REQUEST['start'] = 0;
282
-			else
285
+			if ($timestamp === 0) {
286
+							$_REQUEST['start'] = 0;
287
+			} else
283 288
 			{
284 289
 				// Find the number of messages posted before said time...
285 290
 				$request = $smcFunc['db_query']('', '
@@ -307,11 +312,11 @@  discard block
 block discarded – undo
307 312
 		elseif (substr($_REQUEST['start'], 0, 3) == 'msg')
308 313
 		{
309 314
 			$virtual_msg = (int) substr($_REQUEST['start'], 3);
310
-			if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg'])
311
-				$context['start_from'] = $context['total_visible_posts'] - 1;
312
-			elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg'])
313
-				$context['start_from'] = 0;
314
-			else
315
+			if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg']) {
316
+							$context['start_from'] = $context['total_visible_posts'] - 1;
317
+			} elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg']) {
318
+							$context['start_from'] = 0;
319
+			} else
315 320
 			{
316 321
 				// Find the start value for that message......
317 322
 				$request = $smcFunc['db_query']('', '
@@ -394,21 +399,25 @@  discard block
 block discarded – undo
394 399
 		);
395 400
 		while ($row = $smcFunc['db_fetch_assoc']($request))
396 401
 		{
397
-			if (empty($row['id_member']))
398
-				continue;
402
+			if (empty($row['id_member'])) {
403
+							continue;
404
+			}
399 405
 
400
-			if (!empty($row['online_color']))
401
-				$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>';
402
-			else
403
-				$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>';
406
+			if (!empty($row['online_color'])) {
407
+							$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>';
408
+			} else {
409
+							$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>';
410
+			}
404 411
 
405 412
 			$is_buddy = in_array($row['id_member'], $user_info['buddies']);
406
-			if ($is_buddy)
407
-				$link = '<strong>' . $link . '</strong>';
413
+			if ($is_buddy) {
414
+							$link = '<strong>' . $link . '</strong>';
415
+			}
408 416
 
409 417
 			// Add them both to the list and to the more detailed list.
410
-			if (!empty($row['show_online']) || allowedTo('moderate_forum'))
411
-				$context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link;
418
+			if (!empty($row['show_online']) || allowedTo('moderate_forum')) {
419
+							$context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link;
420
+			}
412 421
 			$context['view_members'][$row['log_time'] . $row['member_name']] = array(
413 422
 				'id' => $row['id_member'],
414 423
 				'username' => $row['member_name'],
@@ -420,8 +429,9 @@  discard block
 block discarded – undo
420 429
 				'hidden' => empty($row['show_online']),
421 430
 			);
422 431
 
423
-			if (empty($row['show_online']))
424
-				$context['view_num_hidden']++;
432
+			if (empty($row['show_online'])) {
433
+							$context['view_num_hidden']++;
434
+			}
425 435
 		}
426 436
 
427 437
 		// The number of guests is equal to the rows minus the ones we actually used ;).
@@ -435,11 +445,13 @@  discard block
 block discarded – undo
435 445
 
436 446
 	// If all is set, but not allowed... just unset it.
437 447
 	$can_show_all = !empty($modSettings['enableAllMessages']) && $context['total_visible_posts'] > $context['messages_per_page'] && $context['total_visible_posts'] < $modSettings['enableAllMessages'];
438
-	if (isset($_REQUEST['all']) && !$can_show_all)
439
-		unset($_REQUEST['all']);
448
+	if (isset($_REQUEST['all']) && !$can_show_all) {
449
+			unset($_REQUEST['all']);
450
+	}
440 451
 	// Otherwise, it must be allowed... so pretend start was -1.
441
-	elseif (isset($_REQUEST['all']))
442
-		$_REQUEST['start'] = -1;
452
+	elseif (isset($_REQUEST['all'])) {
453
+			$_REQUEST['start'] = -1;
454
+	}
443 455
 
444 456
 	// Construct the page index, allowing for the .START method...
445 457
 	$context['page_index'] = constructPageIndex($scripturl . '?topic=' . $topic . '.%1$d', $_REQUEST['start'], $context['total_visible_posts'], $context['messages_per_page'], true);
@@ -476,8 +488,9 @@  discard block
 block discarded – undo
476 488
 			$_REQUEST['start'] = 0;
477 489
 		}
478 490
 		// They aren't using it, but the *option* is there, at least.
479
-		else
480
-			$context['page_index'] .= '&nbsp;<a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> ';
491
+		else {
492
+					$context['page_index'] .= '&nbsp;<a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> ';
493
+		}
481 494
 	}
482 495
 
483 496
 	// Build the link tree.
@@ -493,14 +506,16 @@  discard block
 block discarded – undo
493 506
 	if (!empty($board_info['moderators']))
494 507
 	{
495 508
 		// Add a link for each moderator...
496
-		foreach ($board_info['moderators'] as $mod)
497
-			$context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>';
509
+		foreach ($board_info['moderators'] as $mod) {
510
+					$context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>';
511
+		}
498 512
 	}
499 513
 	if (!empty($board_info['moderator_groups']))
500 514
 	{
501 515
 		// Add a link for each moderator group as well...
502
-		foreach ($board_info['moderator_groups'] as $mod_group)
503
-			$context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>';
516
+		foreach ($board_info['moderator_groups'] as $mod_group) {
517
+					$context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>';
518
+		}
504 519
 	}
505 520
 
506 521
 	if (!empty($context['link_moderators']))
@@ -531,9 +546,9 @@  discard block
 block discarded – undo
531 546
 	// For quick reply we need a response prefix in the default forum language.
532 547
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix', 600)))
533 548
 	{
534
-		if ($language === $user_info['language'])
535
-			$context['response_prefix'] = $txt['response_prefix'];
536
-		else
549
+		if ($language === $user_info['language']) {
550
+					$context['response_prefix'] = $txt['response_prefix'];
551
+		} else
537 552
 		{
538 553
 			loadLanguage('index', $language, false);
539 554
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -565,8 +580,9 @@  discard block
 block discarded – undo
565 580
 			list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row);
566 581
 
567 582
 			// Sanity check
568
-			if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count']))
569
-				continue;
583
+			if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) {
584
+							continue;
585
+			}
570 586
 
571 587
 			$linked_calendar_event = array(
572 588
 				'id' => $row['id_event'],
@@ -615,8 +631,9 @@  discard block
 block discarded – undo
615 631
 		}
616 632
 		$smcFunc['db_free_result']($request);
617 633
 
618
-		if (!empty($context['linked_calendar_events']))
619
-			$context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true;
634
+		if (!empty($context['linked_calendar_events'])) {
635
+					$context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true;
636
+		}
620 637
 	}
621 638
 
622 639
 	// Create the poll info if it exists.
@@ -679,8 +696,9 @@  discard block
 block discarded – undo
679 696
 		$smcFunc['db_free_result']($request);
680 697
 
681 698
 		// Got we multi choice?
682
-		if ($pollinfo['max_votes'] > 1)
683
-			$realtotal = $pollinfo['total'];
699
+		if ($pollinfo['max_votes'] > 1) {
700
+					$realtotal = $pollinfo['total'];
701
+		}
684 702
 
685 703
 		// If this is a guest we need to do our best to work out if they have voted, and what they voted for.
686 704
 		if ($user_info['is_guest'] && $pollinfo['guest_vote'] && allowedTo('poll_vote'))
@@ -693,20 +711,21 @@  discard block
 block discarded – undo
693 711
 				foreach ($guestinfo as $i => $guestvoted)
694 712
 				{
695 713
 					$guestvoted = explode(',', $guestvoted);
696
-					if ($guestvoted[0] == $context['topicinfo']['id_poll'])
697
-						break;
714
+					if ($guestvoted[0] == $context['topicinfo']['id_poll']) {
715
+											break;
716
+					}
698 717
 				}
699 718
 				// Has the poll been reset since guest voted?
700 719
 				if ($pollinfo['reset_poll'] > $guestvoted[1])
701 720
 				{
702 721
 					// Remove the poll info from the cookie to allow guest to vote again
703 722
 					unset($guestinfo[$i]);
704
-					if (!empty($guestinfo))
705
-						$_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo);
706
-					else
707
-						unset($_COOKIE['guest_poll_vote']);
708
-				}
709
-				else
723
+					if (!empty($guestinfo)) {
724
+											$_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo);
725
+					} else {
726
+											unset($_COOKIE['guest_poll_vote']);
727
+					}
728
+				} else
710 729
 				{
711 730
 					// What did they vote for?
712 731
 					unset($guestvoted[0], $guestvoted[1]);
@@ -820,23 +839,29 @@  discard block
 block discarded – undo
820 839
 		// Build the poll moderation button array.
821 840
 		$context['poll_buttons'] = array();
822 841
 
823
-		if ($context['allow_return_vote'])
824
-			$context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']);
842
+		if ($context['allow_return_vote']) {
843
+					$context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']);
844
+		}
825 845
 
826
-		if ($context['show_view_results_button'])
827
-			$context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults');
846
+		if ($context['show_view_results_button']) {
847
+					$context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults');
848
+		}
828 849
 
829
-		if ($context['allow_change_vote'])
830
-			$context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']);
850
+		if ($context['allow_change_vote']) {
851
+					$context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']);
852
+		}
831 853
 
832
-		if ($context['allow_lock_poll'])
833
-			$context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
854
+		if ($context['allow_lock_poll']) {
855
+					$context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
856
+		}
834 857
 
835
-		if ($context['allow_edit_poll'])
836
-			$context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']);
858
+		if ($context['allow_edit_poll']) {
859
+					$context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']);
860
+		}
837 861
 
838
-		if ($context['can_remove_poll'])
839
-			$context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
862
+		if ($context['can_remove_poll']) {
863
+					$context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
864
+		}
840 865
 
841 866
 		// Allow mods to add additional buttons here
842 867
 		call_integration_hook('integrate_poll_buttons');
@@ -872,9 +897,9 @@  discard block
 block discarded – undo
872 897
 	{
873 898
 		$start_char = 'C';
874 899
 		$page_id = $ascending ? $context['topicinfo']['id_first_msg'] : $context['topicinfo']['id_last_msg'];
900
+	} else {
901
+			$start_char = null;
875 902
 	}
876
-	else
877
-		$start_char = null;
878 903
 
879 904
 	$limit = $context['messages_per_page'];
880 905
 
@@ -888,17 +913,17 @@  discard block
 block discarded – undo
888 913
 		{
889 914
 			$ascending_seek = true;
890 915
 			$page_operator = $ascending ? '>=' : '<=';
891
-		}
892
-		else
916
+		} else
893 917
 		{
894 918
 			$ascending_seek = false;
895 919
 			$page_operator = $ascending ? '<=' : '>=';
896 920
 		}
897 921
 
898
-		if ($start_char === 'C')
899
-			$limit_seek = $limit;
900
-		else
901
-			$limit_seek  = $limit + 1;
922
+		if ($start_char === 'C') {
923
+					$limit_seek = $limit;
924
+		} else {
925
+					$limit_seek  = $limit + 1;
926
+		}
902 927
 
903 928
 		$request = $smcFunc['db_query']('', '
904 929
 			SELECT id_msg, id_member, approved
@@ -921,21 +946,23 @@  discard block
 block discarded – undo
921 946
 		$found_msg = false;
922 947
 
923 948
 		// Fallback
924
-		if ($smcFunc['db_num_rows']($request) < 1)
925
-			unset($start_char);
926
-		else
949
+		if ($smcFunc['db_num_rows']($request) < 1) {
950
+					unset($start_char);
951
+		} else
927 952
 		{
928 953
 			while ($row = $smcFunc['db_fetch_assoc']($request))
929 954
 			{
930 955
 				// Check if the start msg is in our result
931
-				if ($row['id_msg'] == $page_id)
932
-					$found_msg = true;
956
+				if ($row['id_msg'] == $page_id) {
957
+									$found_msg = true;
958
+				}
933 959
 
934 960
 				// Skip the the start msg if we not in mode C
935 961
 				if ($start_char === 'C' || $row['id_msg'] != $page_id)
936 962
 				{
937
-					if (!empty($row['id_member']))
938
-						$all_posters[$row['id_msg']] = $row['id_member'];
963
+					if (!empty($row['id_member'])) {
964
+											$all_posters[$row['id_msg']] = $row['id_member'];
965
+					}
939 966
 
940 967
 					$messages[] = $row['id_msg'];
941 968
 				}
@@ -951,8 +978,9 @@  discard block
 block discarded – undo
951 978
 		}
952 979
 
953 980
 		// Before Page bring in the right order
954
-		if (!empty($start_char) && $start_char === 'L')
955
-			krsort($messages);
981
+		if (!empty($start_char) && $start_char === 'L') {
982
+					krsort($messages);
983
+		}
956 984
 	}
957 985
 
958 986
 	// Jump to page
@@ -987,14 +1015,16 @@  discard block
 block discarded – undo
987 1015
 
988 1016
 		while ($row = $smcFunc['db_fetch_assoc']($request))
989 1017
 		{
990
-			if (!empty($row['id_member']))
991
-				$all_posters[$row['id_msg']] = $row['id_member'];
1018
+			if (!empty($row['id_member'])) {
1019
+							$all_posters[$row['id_msg']] = $row['id_member'];
1020
+			}
992 1021
 			$messages[] = $row['id_msg'];
993 1022
 		}
994 1023
 
995 1024
 		// Sort the messages into the correct display order
996
-		if (!$ascending)
997
-			sort($messages);
1025
+		if (!$ascending) {
1026
+					sort($messages);
1027
+		}
998 1028
 	}
999 1029
 
1000 1030
 	// Remember the paging data for next time
@@ -1014,8 +1044,9 @@  discard block
 block discarded – undo
1014 1044
 	if (!$user_info['is_guest'] && !empty($messages))
1015 1045
 	{
1016 1046
 		$mark_at_msg = max($messages);
1017
-		if ($mark_at_msg >= $context['topicinfo']['id_last_msg'])
1018
-			$mark_at_msg = $modSettings['maxMsgID'];
1047
+		if ($mark_at_msg >= $context['topicinfo']['id_last_msg']) {
1048
+					$mark_at_msg = $modSettings['maxMsgID'];
1049
+		}
1019 1050
 		if ($mark_at_msg >= $context['topicinfo']['new_from'])
1020 1051
 		{
1021 1052
 			$smcFunc['db_insert']($context['topicinfo']['new_from'] == 0 ? 'ignore' : 'replace',
@@ -1047,8 +1078,9 @@  discard block
 block discarded – undo
1047 1078
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1048 1079
 		{
1049 1080
 			// Find if this topic is marked for notification...
1050
-			if (!empty($row['id_topic']))
1051
-				$context['is_marked_notify'] = true;
1081
+			if (!empty($row['id_topic'])) {
1082
+							$context['is_marked_notify'] = true;
1083
+			}
1052 1084
 
1053 1085
 			// Only do this once, but mark the notifications as "not sent yet" for next time.
1054 1086
 			if (!empty($row['sent']) && $do_once)
@@ -1070,8 +1102,9 @@  discard block
 block discarded – undo
1070 1102
 		}
1071 1103
 
1072 1104
 		// Have we recently cached the number of new topics in this board, and it's still a lot?
1073
-		if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5)
1074
-			$_SESSION['topicseen_cache'][$board]--;
1105
+		if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5) {
1106
+					$_SESSION['topicseen_cache'][$board]--;
1107
+		}
1075 1108
 		// Mark board as seen if this is the only new topic.
1076 1109
 		elseif (isset($_REQUEST['topicseen']))
1077 1110
 		{
@@ -1095,14 +1128,16 @@  discard block
 block discarded – undo
1095 1128
 			$smcFunc['db_free_result']($request);
1096 1129
 
1097 1130
 			// If there're no real new topics in this board, mark the board as seen.
1098
-			if (empty($numNewTopics))
1099
-				$_REQUEST['boardseen'] = true;
1100
-			else
1101
-				$_SESSION['topicseen_cache'][$board] = $numNewTopics;
1131
+			if (empty($numNewTopics)) {
1132
+							$_REQUEST['boardseen'] = true;
1133
+			} else {
1134
+							$_SESSION['topicseen_cache'][$board] = $numNewTopics;
1135
+			}
1102 1136
 		}
1103 1137
 		// Probably one less topic - maybe not, but even if we decrease this too fast it will only make us look more often.
1104
-		elseif (isset($_SESSION['topicseen_cache'][$board]))
1105
-			$_SESSION['topicseen_cache'][$board]--;
1138
+		elseif (isset($_SESSION['topicseen_cache'][$board])) {
1139
+					$_SESSION['topicseen_cache'][$board]--;
1140
+		}
1106 1141
 
1107 1142
 		// Mark board as seen if we came using last post link from BoardIndex. (or other places...)
1108 1143
 		if (isset($_REQUEST['boardseen']))
@@ -1159,23 +1194,26 @@  discard block
 block discarded – undo
1159 1194
 			$temp = array();
1160 1195
 			while ($row = $smcFunc['db_fetch_assoc']($request))
1161 1196
 			{
1162
-				if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id']))
1163
-					continue;
1197
+				if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id'])) {
1198
+									continue;
1199
+				}
1164 1200
 
1165 1201
 				$temp[$row['id_attach']] = $row;
1166 1202
 				$temp[$row['id_attach']]['topic'] = $topic;
1167 1203
 				$temp[$row['id_attach']]['board'] = $board;
1168 1204
 
1169
-				if (!isset($context['loaded_attachments'][$row['id_msg']]))
1170
-					$context['loaded_attachments'][$row['id_msg']] = array();
1205
+				if (!isset($context['loaded_attachments'][$row['id_msg']])) {
1206
+									$context['loaded_attachments'][$row['id_msg']] = array();
1207
+				}
1171 1208
 			}
1172 1209
 			$smcFunc['db_free_result']($request);
1173 1210
 
1174 1211
 			// This is better than sorting it with the query...
1175 1212
 			ksort($temp);
1176 1213
 
1177
-			foreach ($temp as $row)
1178
-				$context['loaded_attachments'][$row['id_msg']][] = $row;
1214
+			foreach ($temp as $row) {
1215
+							$context['loaded_attachments'][$row['id_msg']][] = $row;
1216
+			}
1179 1217
 		}
1180 1218
 
1181 1219
 		$msg_parameters = array(
@@ -1202,21 +1240,23 @@  discard block
 block discarded – undo
1202 1240
 		);
1203 1241
 
1204 1242
 		// And the likes
1205
-		if (!empty($modSettings['enable_likes']))
1206
-			$context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic);
1243
+		if (!empty($modSettings['enable_likes'])) {
1244
+					$context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic);
1245
+		}
1207 1246
 
1208 1247
 		// Go to the last message if the given time is beyond the time of the last message.
1209
-		if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies'])
1210
-			$context['start_from'] = $context['topicinfo']['num_replies'];
1248
+		if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies']) {
1249
+					$context['start_from'] = $context['topicinfo']['num_replies'];
1250
+		}
1211 1251
 
1212 1252
 		// Since the anchor information is needed on the top of the page we load these variables beforehand.
1213 1253
 		$context['first_message'] = isset($messages[$firstIndex]) ? $messages[$firstIndex] : $messages[0];
1214
-		if (empty($options['view_newest_first']))
1215
-			$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from'];
1216
-		else
1217
-			$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from'];
1218
-	}
1219
-	else
1254
+		if (empty($options['view_newest_first'])) {
1255
+					$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from'];
1256
+		} else {
1257
+					$context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from'];
1258
+		}
1259
+	} else
1220 1260
 	{
1221 1261
 		$messages_request = false;
1222 1262
 		$context['first_message'] = 0;
@@ -1251,8 +1291,9 @@  discard block
 block discarded – undo
1251 1291
 		'can_restore_msg' => 'move_any',
1252 1292
 		'can_like' => 'likes_like',
1253 1293
 	);
1254
-	foreach ($common_permissions as $contextual => $perm)
1255
-		$context[$contextual] = allowedTo($perm);
1294
+	foreach ($common_permissions as $contextual => $perm) {
1295
+			$context[$contextual] = allowedTo($perm);
1296
+	}
1256 1297
 
1257 1298
 	// Permissions with _any/_own versions.  $context[YYY] => ZZZ_any/_own.
1258 1299
 	$anyown_permissions = array(
@@ -1265,8 +1306,9 @@  discard block
 block discarded – undo
1265 1306
 		'can_reply_unapproved' => 'post_unapproved_replies',
1266 1307
 		'can_view_warning' => 'profile_warning',
1267 1308
 	);
1268
-	foreach ($anyown_permissions as $contextual => $perm)
1269
-		$context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own'));
1309
+	foreach ($anyown_permissions as $contextual => $perm) {
1310
+			$context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own'));
1311
+	}
1270 1312
 
1271 1313
 	if (!$user_info['is_admin'] && $context['can_move'] && !$modSettings['topic_move_any'])
1272 1314
 	{
@@ -1312,8 +1354,9 @@  discard block
 block discarded – undo
1312 1354
 	// Check if the draft functions are enabled and that they have permission to use them (for quick reply.)
1313 1355
 	$context['drafts_save'] = !empty($modSettings['drafts_post_enabled']) && allowedTo('post_draft') && $context['can_reply'];
1314 1356
 	$context['drafts_autosave'] = !empty($context['drafts_save']) && !empty($modSettings['drafts_autosave_enabled']);
1315
-	if (!empty($context['drafts_save']))
1316
-		loadLanguage('Drafts');
1357
+	if (!empty($context['drafts_save'])) {
1358
+			loadLanguage('Drafts');
1359
+	}
1317 1360
 
1318 1361
 	// When was the last time this topic was replied to?  Should we warn them about it?
1319 1362
 	if (!empty($modSettings['oldTopicDays']) && ($context['can_reply'] || $context['can_reply_unapproved']) && empty($context['topicinfo']['is_sticky']))
@@ -1374,26 +1417,31 @@  discard block
 block discarded – undo
1374 1417
 	// Message icons - customized icons are off?
1375 1418
 	$context['icons'] = getMessageIcons($board);
1376 1419
 
1377
-	if (!empty($context['icons']))
1378
-		$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1420
+	if (!empty($context['icons'])) {
1421
+			$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1422
+	}
1379 1423
 
1380 1424
 	// Build the normal button array.
1381 1425
 	$context['normal_buttons'] = array();
1382 1426
 
1383
-	if ($context['can_reply'])
1384
-		$context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true);
1427
+	if ($context['can_reply']) {
1428
+			$context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true);
1429
+	}
1385 1430
 
1386
-	if ($context['can_add_poll'])
1387
-		$context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']);
1431
+	if ($context['can_add_poll']) {
1432
+			$context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']);
1433
+	}
1388 1434
 
1389
-	if ($context['can_mark_unread'])
1390
-		$context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1435
+	if ($context['can_mark_unread']) {
1436
+			$context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1437
+	}
1391 1438
 
1392
-	if ($context['can_print'])
1393
-		$context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0');
1439
+	if ($context['can_print']) {
1440
+			$context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0');
1441
+	}
1394 1442
 
1395
-	if ($context['can_set_notify'])
1396
-		$context['normal_buttons']['notify'] = array(
1443
+	if ($context['can_set_notify']) {
1444
+			$context['normal_buttons']['notify'] = array(
1397 1445
 			'text' => 'notify_topic_' . $context['topic_notification_mode'],
1398 1446
 			'sub_buttons' => array(
1399 1447
 				array(
@@ -1415,38 +1463,47 @@  discard block
 block discarded – undo
1415 1463
 				),
1416 1464
 			),
1417 1465
 		);
1466
+	}
1418 1467
 
1419 1468
 	// Build the mod button array
1420 1469
 	$context['mod_buttons'] = array();
1421 1470
 
1422
-	if ($context['can_move'])
1423
-		$context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0');
1471
+	if ($context['can_move']) {
1472
+			$context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0');
1473
+	}
1424 1474
 
1425
-	if ($context['can_delete'])
1426
-		$context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']);
1475
+	if ($context['can_delete']) {
1476
+			$context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']);
1477
+	}
1427 1478
 
1428
-	if ($context['can_lock'])
1429
-		$context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1479
+	if ($context['can_lock']) {
1480
+			$context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1481
+	}
1430 1482
 
1431
-	if ($context['can_sticky'])
1432
-		$context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1483
+	if ($context['can_sticky']) {
1484
+			$context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1485
+	}
1433 1486
 
1434
-	if ($context['can_merge'])
1435
-		$context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']);
1487
+	if ($context['can_merge']) {
1488
+			$context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']);
1489
+	}
1436 1490
 
1437
-	if ($context['calendar_post'])
1438
-		$context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0');
1491
+	if ($context['calendar_post']) {
1492
+			$context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0');
1493
+	}
1439 1494
 
1440 1495
 	// Restore topic. eh?  No monkey business.
1441
-	if ($context['can_restore_topic'])
1442
-		$context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1496
+	if ($context['can_restore_topic']) {
1497
+			$context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']);
1498
+	}
1443 1499
 
1444 1500
 	// Show a message in case a recently posted message became unapproved.
1445 1501
 	$context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false;
1446 1502
 
1447 1503
 	// Don't want to show this forever...
1448
-	if ($context['becomesUnapproved'])
1449
-		unset($_SESSION['becomesUnapproved']);
1504
+	if ($context['becomesUnapproved']) {
1505
+			unset($_SESSION['becomesUnapproved']);
1506
+	}
1450 1507
 
1451 1508
 	// Allow adding new mod buttons easily.
1452 1509
 	// Note: $context['normal_buttons'] and $context['mod_buttons'] are added for backward compatibility with 2.0, but are deprecated and should not be used
@@ -1455,12 +1512,14 @@  discard block
 block discarded – undo
1455 1512
 	call_integration_hook('integrate_mod_buttons', array(&$context['mod_buttons']));
1456 1513
 
1457 1514
 	// Load the drafts js file
1458
-	if ($context['drafts_autosave'])
1459
-		loadJavaScriptFile('drafts.js', array('defer' => false, 'minimize' => true), 'smf_drafts');
1515
+	if ($context['drafts_autosave']) {
1516
+			loadJavaScriptFile('drafts.js', array('defer' => false, 'minimize' => true), 'smf_drafts');
1517
+	}
1460 1518
 
1461 1519
 	// Spellcheck
1462
-	if ($context['show_spellchecking'])
1463
-		loadJavaScriptFile('spellcheck.js', array('defer' => false, 'minimize' => true), 'smf_spellcheck');
1520
+	if ($context['show_spellchecking']) {
1521
+			loadJavaScriptFile('spellcheck.js', array('defer' => false, 'minimize' => true), 'smf_spellcheck');
1522
+	}
1464 1523
 
1465 1524
 	// topic.js
1466 1525
 	loadJavaScriptFile('topic.js', array('defer' => false, 'minimize' => true), 'smf_topic');
@@ -1494,16 +1553,19 @@  discard block
 block discarded – undo
1494 1553
 	static $counter = null;
1495 1554
 
1496 1555
 	// If the query returned false, bail.
1497
-	if ($messages_request == false)
1498
-		return false;
1556
+	if ($messages_request == false) {
1557
+			return false;
1558
+	}
1499 1559
 
1500 1560
 	// Remember which message this is.  (ie. reply #83)
1501
-	if ($counter === null || $reset)
1502
-		$counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start'];
1561
+	if ($counter === null || $reset) {
1562
+			$counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start'];
1563
+	}
1503 1564
 
1504 1565
 	// Start from the beginning...
1505
-	if ($reset)
1506
-		return @$smcFunc['db_data_seek']($messages_request, 0);
1566
+	if ($reset) {
1567
+			return @$smcFunc['db_data_seek']($messages_request, 0);
1568
+	}
1507 1569
 
1508 1570
 	// Attempt to get the next message.
1509 1571
 	$message = $smcFunc['db_fetch_assoc']($messages_request);
@@ -1517,19 +1579,21 @@  discard block
 block discarded – undo
1517 1579
 	if (empty($context['icon_sources']))
1518 1580
 	{
1519 1581
 		$context['icon_sources'] = array();
1520
-		foreach ($context['stable_icons'] as $icon)
1521
-			$context['icon_sources'][$icon] = 'images_url';
1582
+		foreach ($context['stable_icons'] as $icon) {
1583
+					$context['icon_sources'][$icon] = 'images_url';
1584
+		}
1522 1585
 	}
1523 1586
 
1524 1587
 	// Message Icon Management... check the images exist.
1525 1588
 	if (empty($modSettings['messageIconChecks_disable']))
1526 1589
 	{
1527 1590
 		// If the current icon isn't known, then we need to do something...
1528
-		if (!isset($context['icon_sources'][$message['icon']]))
1529
-			$context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url';
1591
+		if (!isset($context['icon_sources'][$message['icon']])) {
1592
+					$context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url';
1593
+		}
1594
+	} elseif (!isset($context['icon_sources'][$message['icon']])) {
1595
+			$context['icon_sources'][$message['icon']] = 'images_url';
1530 1596
 	}
1531
-	elseif (!isset($context['icon_sources'][$message['icon']]))
1532
-		$context['icon_sources'][$message['icon']] = 'images_url';
1533 1597
 
1534 1598
 	// If you're a lazy bum, you probably didn't give a subject...
1535 1599
 	$message['subject'] = $message['subject'] != '' ? $message['subject'] : $txt['no_subject'];
@@ -1554,8 +1618,7 @@  discard block
 block discarded – undo
1554 1618
 		$memberContext[$message['id_member']]['email'] = $message['poster_email'];
1555 1619
 		$memberContext[$message['id_member']]['show_email'] = allowedTo('moderate_forum');
1556 1620
 		$memberContext[$message['id_member']]['is_guest'] = true;
1557
-	}
1558
-	else
1621
+	} else
1559 1622
 	{
1560 1623
 		// Define this here to make things a bit more readable
1561 1624
 		$can_view_warning = $context['user']['can_mod'] || allowedTo('view_warning_any') || ($message['id_member'] == $user_info['id'] && allowedTo('view_warning_own'));
@@ -1578,8 +1641,9 @@  discard block
 block discarded – undo
1578 1641
 	$message['body'] = parse_bbc($message['body'], $message['smileys_enabled'], $message['id_msg']);
1579 1642
 
1580 1643
 	// If it's in the recycle bin we need to override whatever icon we did have.
1581
-	if (!empty($board_info['recycle']))
1582
-		$message['icon'] = 'recycled';
1644
+	if (!empty($board_info['recycle'])) {
1645
+			$message['icon'] = 'recycled';
1646
+	}
1583 1647
 
1584 1648
 	require_once($sourcedir . '/Subs-Attachments.php');
1585 1649
 
@@ -1623,32 +1687,36 @@  discard block
 block discarded – undo
1623 1687
 	}
1624 1688
 
1625 1689
 	// Are likes enable?
1626
-	if (!empty($modSettings['enable_likes']))
1627
-		$output['likes'] = array(
1690
+	if (!empty($modSettings['enable_likes'])) {
1691
+			$output['likes'] = array(
1628 1692
 			'count' => $message['likes'],
1629 1693
 			'you' => in_array($message['id_msg'], $context['my_likes']),
1630 1694
 			'can_like' => !$context['user']['is_guest'] && $message['id_member'] != $context['user']['id'] && !empty($context['can_like']),
1631 1695
 		);
1696
+	}
1632 1697
 
1633 1698
 	// Is this user the message author?
1634 1699
 	$output['is_message_author'] = $message['id_member'] == $user_info['id'];
1635
-	if (!empty($output['modified']['name']))
1636
-		$output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']);
1700
+	if (!empty($output['modified']['name'])) {
1701
+			$output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']);
1702
+	}
1637 1703
 
1638 1704
 	// Did they give a reason for editing?
1639
-	if (!empty($output['modified']['name']) && !empty($output['modified']['reason']))
1640
-		$output['modified']['last_edit_text'] .= '&nbsp;' . sprintf($txt['last_edit_reason'], $output['modified']['reason']);
1705
+	if (!empty($output['modified']['name']) && !empty($output['modified']['reason'])) {
1706
+			$output['modified']['last_edit_text'] .= '&nbsp;' . sprintf($txt['last_edit_reason'], $output['modified']['reason']);
1707
+	}
1641 1708
 
1642 1709
 	// Any custom profile fields?
1643
-	if (!empty($memberContext[$message['id_member']]['custom_fields']))
1644
-		foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom)
1710
+	if (!empty($memberContext[$message['id_member']]['custom_fields'])) {
1711
+			foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom)
1645 1712
 			$output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom;
1713
+	}
1646 1714
 
1647
-	if (empty($options['view_newest_first']))
1648
-		$counter++;
1649
-
1650
-	else
1651
-		$counter--;
1715
+	if (empty($options['view_newest_first'])) {
1716
+			$counter++;
1717
+	} else {
1718
+			$counter--;
1719
+	}
1652 1720
 
1653 1721
 	call_integration_hook('integrate_prepare_display_context', array(&$output, &$message, $counter));
1654 1722
 
@@ -1674,8 +1742,9 @@  discard block
 block discarded – undo
1674 1742
  */
1675 1743
 function approved_attach_sort($a, $b)
1676 1744
 {
1677
-	if ($a['is_approved'] == $b['is_approved'])
1678
-		return 0;
1745
+	if ($a['is_approved'] == $b['is_approved']) {
1746
+			return 0;
1747
+	}
1679 1748
 
1680 1749
 	return $a['is_approved'] > $b['is_approved'] ? -1 : 1;
1681 1750
 }
@@ -1692,16 +1761,19 @@  discard block
 block discarded – undo
1692 1761
 
1693 1762
 	require_once($sourcedir . '/RemoveTopic.php');
1694 1763
 
1695
-	if (empty($_REQUEST['msgs']))
1696
-		redirectexit('topic=' . $topic . '.' . $_REQUEST['start']);
1764
+	if (empty($_REQUEST['msgs'])) {
1765
+			redirectexit('topic=' . $topic . '.' . $_REQUEST['start']);
1766
+	}
1697 1767
 
1698 1768
 	$messages = array();
1699
-	foreach ($_REQUEST['msgs'] as $dummy)
1700
-		$messages[] = (int) $dummy;
1769
+	foreach ($_REQUEST['msgs'] as $dummy) {
1770
+			$messages[] = (int) $dummy;
1771
+	}
1701 1772
 
1702 1773
 	// We are restoring messages. We handle this in another place.
1703
-	if (isset($_REQUEST['restore_selected']))
1704
-		redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']);
1774
+	if (isset($_REQUEST['restore_selected'])) {
1775
+			redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']);
1776
+	}
1705 1777
 	if (isset($_REQUEST['split_selection']))
1706 1778
 	{
1707 1779
 		$request = $smcFunc['db_query']('', '
@@ -1720,8 +1792,9 @@  discard block
 block discarded – undo
1720 1792
 	}
1721 1793
 
1722 1794
 	// Allowed to delete any message?
1723
-	if (allowedTo('delete_any'))
1724
-		$allowed_all = true;
1795
+	if (allowedTo('delete_any')) {
1796
+			$allowed_all = true;
1797
+	}
1725 1798
 	// Allowed to delete replies to their messages?
1726 1799
 	elseif (allowedTo('delete_replies'))
1727 1800
 	{
@@ -1738,13 +1811,14 @@  discard block
 block discarded – undo
1738 1811
 		$smcFunc['db_free_result']($request);
1739 1812
 
1740 1813
 		$allowed_all = $starter == $user_info['id'];
1814
+	} else {
1815
+			$allowed_all = false;
1741 1816
 	}
1742
-	else
1743
-		$allowed_all = false;
1744 1817
 
1745 1818
 	// Make sure they're allowed to delete their own messages, if not any.
1746
-	if (!$allowed_all)
1747
-		isAllowedTo('delete_own');
1819
+	if (!$allowed_all) {
1820
+			isAllowedTo('delete_own');
1821
+	}
1748 1822
 
1749 1823
 	// Allowed to remove which messages?
1750 1824
 	$request = $smcFunc['db_query']('', '
@@ -1764,8 +1838,9 @@  discard block
 block discarded – undo
1764 1838
 	$messages = array();
1765 1839
 	while ($row = $smcFunc['db_fetch_assoc']($request))
1766 1840
 	{
1767
-		if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time())
1768
-			continue;
1841
+		if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time()) {
1842
+					continue;
1843
+		}
1769 1844
 
1770 1845
 		$messages[$row['id_msg']] = array($row['subject'], $row['id_member']);
1771 1846
 	}
@@ -1788,17 +1863,20 @@  discard block
 block discarded – undo
1788 1863
 	foreach ($messages as $message => $info)
1789 1864
 	{
1790 1865
 		// Just skip the first message - if it's not the last.
1791
-		if ($message == $first_message && $message != $last_message)
1792
-			continue;
1866
+		if ($message == $first_message && $message != $last_message) {
1867
+					continue;
1868
+		}
1793 1869
 		// If the first message is going then don't bother going back to the topic as we're effectively deleting it.
1794
-		elseif ($message == $first_message)
1795
-			$topicGone = true;
1870
+		elseif ($message == $first_message) {
1871
+					$topicGone = true;
1872
+		}
1796 1873
 
1797 1874
 		removeMessage($message);
1798 1875
 
1799 1876
 		// Log this moderation action ;).
1800
-		if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id']))
1801
-			logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board));
1877
+		if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) {
1878
+					logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board));
1879
+		}
1802 1880
 	}
1803 1881
 
1804 1882
 	redirectexit(!empty($topicGone) ? 'board=' . $board : 'topic=' . $topic . '.' . $_REQUEST['start']);
Please login to merge, or discard this patch.
Sources/Groups.php 1 patch
Braces   +80 added lines, -59 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Entry point function, permission checks, admin bars, etc.
@@ -99,27 +100,27 @@  discard block
 block discarded – undo
99 100
 					'function' => function($rowData) use ($scripturl)
100 101
 					{
101 102
 						// Since the moderator group has no explicit members, no link is needed.
102
-						if ($rowData['id_group'] == 3)
103
-							$group_name = $rowData['group_name'];
104
-						else
103
+						if ($rowData['id_group'] == 3) {
104
+													$group_name = $rowData['group_name'];
105
+						} else
105 106
 						{
106 107
 							$color_style = empty($rowData['online_color']) ? '' : sprintf(' style="color: %1$s;"', $rowData['online_color']);
107 108
 
108 109
 							if (allowedTo('manage_membergroups'))
109 110
 							{
110 111
 								$group_name = sprintf('<a href="%1$s?action=admin;area=membergroups;sa=members;group=%2$d"%3$s>%4$s</a>', $scripturl, $rowData['id_group'], $color_style, $rowData['group_name']);
111
-							}
112
-							else
112
+							} else
113 113
 							{
114 114
 								$group_name = sprintf('<a href="%1$s?action=groups;sa=members;group=%2$d"%3$s>%4$s</a>', $scripturl, $rowData['id_group'], $color_style, $rowData['group_name']);
115 115
 							}
116 116
 						}
117 117
 
118 118
 						// Add a help option for moderator and administrator.
119
-						if ($rowData['id_group'] == 1)
120
-							$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
121
-						elseif ($rowData['id_group'] == 3)
122
-							$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
119
+						if ($rowData['id_group'] == 1) {
120
+													$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
121
+						} elseif ($rowData['id_group'] == 3) {
122
+													$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
123
+						}
123 124
 
124 125
 						return $group_name;
125 126
 					},
@@ -198,8 +199,9 @@  discard block
 block discarded – undo
198 199
 	$_REQUEST['group'] = isset($_REQUEST['group']) ? (int) $_REQUEST['group'] : 0;
199 200
 
200 201
 	// No browsing of guests, membergroup 0 or moderators.
201
-	if (in_array($_REQUEST['group'], array(-1, 0, 3)))
202
-		fatal_lang_error('membergroup_does_not_exist', false);
202
+	if (in_array($_REQUEST['group'], array(-1, 0, 3))) {
203
+			fatal_lang_error('membergroup_does_not_exist', false);
204
+	}
203 205
 
204 206
 	// Load up the group details.
205 207
 	$request = $smcFunc['db_query']('', '
@@ -214,8 +216,9 @@  discard block
 block discarded – undo
214 216
 		)
215 217
 	);
216 218
 	// Doesn't exist?
217
-	if ($smcFunc['db_num_rows']($request) == 0)
218
-		fatal_lang_error('membergroup_does_not_exist', false);
219
+	if ($smcFunc['db_num_rows']($request) == 0) {
220
+			fatal_lang_error('membergroup_does_not_exist', false);
221
+	}
219 222
 	$context['group'] = $smcFunc['db_fetch_assoc']($request);
220 223
 	$smcFunc['db_free_result']($request);
221 224
 
@@ -248,21 +251,25 @@  discard block
 block discarded – undo
248 251
 			'name' => $row['real_name']
249 252
 		);
250 253
 
251
-		if ($user_info['id'] == $row['id_member'] && $context['group']['group_type'] != 1)
252
-			$context['group']['can_moderate'] = true;
254
+		if ($user_info['id'] == $row['id_member'] && $context['group']['group_type'] != 1) {
255
+					$context['group']['can_moderate'] = true;
256
+		}
253 257
 	}
254 258
 	$smcFunc['db_free_result']($request);
255 259
 
256 260
 	// If this group is hidden then it can only "exists" if the user can moderate it!
257
-	if ($context['group']['hidden'] && !$context['group']['can_moderate'])
258
-		fatal_lang_error('membergroup_does_not_exist', false);
261
+	if ($context['group']['hidden'] && !$context['group']['can_moderate']) {
262
+			fatal_lang_error('membergroup_does_not_exist', false);
263
+	}
259 264
 
260 265
 	// You can only assign membership if you are the moderator and/or can manage groups!
261
-	if (!$context['group']['can_moderate'])
262
-		$context['group']['assignable'] = 0;
266
+	if (!$context['group']['can_moderate']) {
267
+			$context['group']['assignable'] = 0;
268
+	}
263 269
 	// Non-admins cannot assign admins.
264
-	elseif ($context['group']['id'] == 1 && !allowedTo('admin_forum'))
265
-		$context['group']['assignable'] = 0;
270
+	elseif ($context['group']['id'] == 1 && !allowedTo('admin_forum')) {
271
+			$context['group']['assignable'] = 0;
272
+	}
266 273
 
267 274
 	// Removing member from group?
268 275
 	if (isset($_POST['remove']) && !empty($_REQUEST['rem']) && is_array($_REQUEST['rem']) && $context['group']['assignable'])
@@ -271,8 +278,9 @@  discard block
 block discarded – undo
271 278
 		validateToken('mod-mgm');
272 279
 
273 280
 		// Make sure we're dealing with integers only.
274
-		foreach ($_REQUEST['rem'] as $key => $group)
275
-			$_REQUEST['rem'][$key] = (int) $group;
281
+		foreach ($_REQUEST['rem'] as $key => $group) {
282
+					$_REQUEST['rem'][$key] = (int) $group;
283
+		}
276 284
 
277 285
 		require_once($sourcedir . '/Subs-Membergroups.php');
278 286
 		removeMembersFromGroups($_REQUEST['rem'], $_REQUEST['group'], true);
@@ -295,16 +303,18 @@  discard block
 block discarded – undo
295 303
 		{
296 304
 			$member_names[$index] = trim($smcFunc['strtolower']($member_names[$index]));
297 305
 
298
-			if (strlen($member_names[$index]) == 0)
299
-				unset($member_names[$index]);
306
+			if (strlen($member_names[$index]) == 0) {
307
+							unset($member_names[$index]);
308
+			}
300 309
 		}
301 310
 
302 311
 		// Any passed by ID?
303 312
 		$member_ids = array();
304
-		if (!empty($_REQUEST['member_add']))
305
-			foreach ($_REQUEST['member_add'] as $id)
313
+		if (!empty($_REQUEST['member_add'])) {
314
+					foreach ($_REQUEST['member_add'] as $id)
306 315
 				if ($id > 0)
307 316
 					$member_ids[] = (int) $id;
317
+		}
308 318
 
309 319
 		// Construct the query pelements.
310 320
 		if (!empty($member_ids))
@@ -332,8 +342,9 @@  discard block
 block discarded – undo
332 342
 					'id_group' => $_REQUEST['group'],
333 343
 				))
334 344
 			);
335
-			while ($row = $smcFunc['db_fetch_assoc']($request))
336
-				$members[] = $row['id_member'];
345
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
346
+							$members[] = $row['id_member'];
347
+			}
337 348
 			$smcFunc['db_free_result']($request);
338 349
 		}
339 350
 
@@ -372,10 +383,11 @@  discard block
 block discarded – undo
372 383
 	$context['sort_direction'] = isset($_REQUEST['desc']) ? 'down' : 'up';
373 384
 
374 385
 	// The where on the query is interesting. Non-moderators should only see people who are in this group as primary.
375
-	if ($context['group']['can_moderate'])
376
-		$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group} OR FIND_IN_SET({int:group}, additional_groups) != 0';
377
-	else
378
-		$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group}';
386
+	if ($context['group']['can_moderate']) {
387
+			$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group} OR FIND_IN_SET({int:group}, additional_groups) != 0';
388
+	} else {
389
+			$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group}';
390
+	}
379 391
 
380 392
 	// Count members of the group.
381 393
 	$request = $smcFunc['db_query']('', '
@@ -416,8 +428,9 @@  discard block
 block discarded – undo
416 428
 		$last_online = empty($row['last_login']) ? $txt['never'] : timeformat($row['last_login']);
417 429
 
418 430
 		// Italicize the online note if they aren't activated.
419
-		if ($row['is_activated'] % 10 != 1)
420
-			$last_online = '<em title="' . $txt['not_activated'] . '">' . $last_online . '</em>';
431
+		if ($row['is_activated'] % 10 != 1) {
432
+					$last_online = '<em title="' . $txt['not_activated'] . '">' . $last_online . '</em>';
433
+		}
421 434
 
422 435
 		$context['members'][] = array(
423 436
 			'id' => $row['id_member'],
@@ -437,9 +450,10 @@  discard block
 block discarded – undo
437 450
 	$context['page_title'] = $txt['membergroups_members_title'] . ': ' . $context['group']['name'];
438 451
 	createToken('mod-mgm');
439 452
 
440
-	if ($context['group']['assignable'])
441
-		loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest');
442
-}
453
+	if ($context['group']['assignable']) {
454
+			loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest');
455
+	}
456
+	}
443 457
 
444 458
 /**
445 459
  * Show and manage all group requests.
@@ -453,16 +467,18 @@  discard block
 block discarded – undo
453 467
 	$context['sub_template'] = 'show_list';
454 468
 
455 469
 	// Verify we can be here.
456
-	if ($user_info['mod_cache']['gq'] == '0=1')
457
-		isAllowedTo('manage_membergroups');
470
+	if ($user_info['mod_cache']['gq'] == '0=1') {
471
+			isAllowedTo('manage_membergroups');
472
+	}
458 473
 
459 474
 	// Normally, we act normally...
460 475
 	$where = ($user_info['mod_cache']['gq'] == '1=1' || $user_info['mod_cache']['gq'] == '0=1' ? $user_info['mod_cache']['gq'] : 'lgr.' . $user_info['mod_cache']['gq']);
461 476
 
462
-	if (isset($_GET['closed']))
463
-		$where .= ' AND lgr.status != {int:status_open}';
464
-	else
465
-		$where .= ' AND lgr.status = {int:status_open}';
477
+	if (isset($_GET['closed'])) {
478
+			$where .= ' AND lgr.status != {int:status_open}';
479
+	} else {
480
+			$where .= ' AND lgr.status = {int:status_open}';
481
+	}
466 482
 
467 483
 	$where_parameters = array(
468 484
 		'status_open' => 0,
@@ -475,8 +491,9 @@  discard block
 block discarded – undo
475 491
 		validateToken('mod-gr');
476 492
 
477 493
 		// Clean the values.
478
-		foreach ($_POST['groupr'] as $k => $request)
479
-			$_POST['groupr'][$k] = (int) $request;
494
+		foreach ($_POST['groupr'] as $k => $request) {
495
+					$_POST['groupr'][$k] = (int) $request;
496
+		}
480 497
 
481 498
 		$log_changes = array();
482 499
 
@@ -513,8 +530,8 @@  discard block
 block discarded – undo
513 530
 			$request_list = array();
514 531
 			while ($row = $smcFunc['db_fetch_assoc']($request))
515 532
 			{
516
-				if (!isset($log_changes[$row['id_request']]))
517
-					$log_changes[$row['id_request']] = array(
533
+				if (!isset($log_changes[$row['id_request']])) {
534
+									$log_changes[$row['id_request']] = array(
518 535
 						'id_request' => $row['id_request'],
519 536
 						'status' => $_POST['req_action'] == 'approve' ? 1 : 2, // 1 = approved, 2 = rejected
520 537
 						'id_member_acted' => $user_info['id'],
@@ -522,6 +539,7 @@  discard block
 block discarded – undo
522 539
 						'time_acted' => time(),
523 540
 						'act_reason' => $_POST['req_action'] != 'approve' && !empty($_POST['groupreason']) && !empty($_POST['groupreason'][$row['id_request']]) ? $smcFunc['htmlspecialchars']($_POST['groupreason'][$row['id_request']], ENT_QUOTES) : '',
524 541
 					);
542
+				}
525 543
 				$request_list[] = $row['id_request'];
526 544
 			}
527 545
 			$smcFunc['db_free_result']($request);
@@ -744,21 +762,24 @@  discard block
 block discarded – undo
744 762
 	$group_requests = array();
745 763
 	while ($row = $smcFunc['db_fetch_assoc']($request))
746 764
 	{
747
-		if (empty($row['reason']))
748
-			$reason = '<em>(' . $txt['mc_groupr_no_reason'] . ')</em>';
749
-		else
750
-			$reason = censorText($row['reason']);
765
+		if (empty($row['reason'])) {
766
+					$reason = '<em>(' . $txt['mc_groupr_no_reason'] . ')</em>';
767
+		} else {
768
+					$reason = censorText($row['reason']);
769
+		}
751 770
 
752 771
 		if (isset($_GET['closed']))
753 772
 		{
754
-			if ($row['status'] == 1)
755
-				$reason .= '<br><br><strong>' . $txt['mc_groupr_approved'] . '</strong>';
756
-			elseif ($row['status'] == 2)
757
-				$reason .= '<br><br><strong>' . $txt['mc_groupr_rejected'] . '</strong>';
773
+			if ($row['status'] == 1) {
774
+							$reason .= '<br><br><strong>' . $txt['mc_groupr_approved'] . '</strong>';
775
+			} elseif ($row['status'] == 2) {
776
+							$reason .= '<br><br><strong>' . $txt['mc_groupr_rejected'] . '</strong>';
777
+			}
758 778
 
759 779
 				$reason .= ' (' . timeformat($row['time_acted']) . ')';
760
-			if (!empty($row['act_reason']))
761
-				$reason .= '<br><br>' . censorText($row['act_reason']);
780
+			if (!empty($row['act_reason'])) {
781
+							$reason .= '<br><br>' . censorText($row['act_reason']);
782
+			}
762 783
 		}
763 784
 
764 785
 		$group_requests[] = array(
Please login to merge, or discard this patch.
Sources/Load.php 1 patch
Braces   +795 added lines, -601 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Load the $modSettings array.
@@ -25,13 +26,14 @@  discard block
 block discarded – undo
25 26
 	global $cache_enable, $sourcedir, $context;
26 27
 
27 28
 	// Most database systems have not set UTF-8 as their default input charset.
28
-	if (!empty($db_character_set))
29
-		$smcFunc['db_query']('', '
29
+	if (!empty($db_character_set)) {
30
+			$smcFunc['db_query']('', '
30 31
 			SET NAMES {string:db_character_set}',
31 32
 			array(
32 33
 				'db_character_set' => $db_character_set,
33 34
 			)
34 35
 		);
36
+	}
35 37
 
36 38
 	// We need some caching support, maybe.
37 39
 	loadCacheAccelerator();
@@ -46,28 +48,36 @@  discard block
 block discarded – undo
46 48
 			)
47 49
 		);
48 50
 		$modSettings = array();
49
-		if (!$request)
50
-			display_db_error();
51
-		while ($row = $smcFunc['db_fetch_row']($request))
52
-			$modSettings[$row[0]] = $row[1];
51
+		if (!$request) {
52
+					display_db_error();
53
+		}
54
+		while ($row = $smcFunc['db_fetch_row']($request)) {
55
+					$modSettings[$row[0]] = $row[1];
56
+		}
53 57
 		$smcFunc['db_free_result']($request);
54 58
 
55 59
 		// Do a few things to protect against missing settings or settings with invalid values...
56
-		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999)
57
-			$modSettings['defaultMaxTopics'] = 20;
58
-		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999)
59
-			$modSettings['defaultMaxMessages'] = 15;
60
-		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999)
61
-			$modSettings['defaultMaxMembers'] = 30;
62
-		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999)
63
-			$modSettings['defaultMaxListItems'] = 15;
60
+		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) {
61
+					$modSettings['defaultMaxTopics'] = 20;
62
+		}
63
+		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) {
64
+					$modSettings['defaultMaxMessages'] = 15;
65
+		}
66
+		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) {
67
+					$modSettings['defaultMaxMembers'] = 30;
68
+		}
69
+		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) {
70
+					$modSettings['defaultMaxListItems'] = 15;
71
+		}
64 72
 
65 73
 		// We excpiclity do not use $smcFunc['json_decode'] here yet, as $smcFunc is not fully loaded.
66
-		if (!is_array($modSettings['attachmentUploadDir']))
67
-			$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
74
+		if (!is_array($modSettings['attachmentUploadDir'])) {
75
+					$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
76
+		}
68 77
 
69
-		if (!empty($cache_enable))
70
-			cache_put_data('modSettings', $modSettings, 90);
78
+		if (!empty($cache_enable)) {
79
+					cache_put_data('modSettings', $modSettings, 90);
80
+		}
71 81
 	}
72 82
 
73 83
 	$modSettings['cache_enable'] = $cache_enable;
@@ -87,8 +97,9 @@  discard block
 block discarded – undo
87 97
 		};
88 98
 	$fix_utf8mb4 = function($string) use ($utf8, $smcFunc)
89 99
 	{
90
-		if (!$utf8 || $smcFunc['db_mb4'])
91
-			return $string;
100
+		if (!$utf8 || $smcFunc['db_mb4']) {
101
+					return $string;
102
+		}
92 103
 
93 104
 		$i = 0;
94 105
 		$len = strlen($string);
@@ -100,18 +111,15 @@  discard block
 block discarded – undo
100 111
 			{
101 112
 				$new_string .= $string[$i];
102 113
 				$i++;
103
-			}
104
-			elseif ($ord < 224)
114
+			} elseif ($ord < 224)
105 115
 			{
106 116
 				$new_string .= $string[$i] . $string[$i + 1];
107 117
 				$i += 2;
108
-			}
109
-			elseif ($ord < 240)
118
+			} elseif ($ord < 240)
110 119
 			{
111 120
 				$new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2];
112 121
 				$i += 3;
113
-			}
114
-			elseif ($ord < 248)
122
+			} elseif ($ord < 248)
115 123
 			{
116 124
 				// Magic happens.
117 125
 				$val = (ord($string[$i]) & 0x07) << 18;
@@ -155,8 +163,7 @@  discard block
 block discarded – undo
155 163
 			{
156 164
 				$result = array_search($needle, array_slice($haystack_arr, $offset));
157 165
 				return is_int($result) ? $result + $offset : false;
158
-			}
159
-			else
166
+			} else
160 167
 			{
161 168
 				$needle_arr = preg_split('~(' . $ent_list . '|.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
162 169
 				$needle_size = count($needle_arr);
@@ -165,8 +172,9 @@  discard block
 block discarded – undo
165 172
 				while ((int) $result === $result)
166 173
 				{
167 174
 					$offset += $result;
168
-					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr)
169
-						return $offset;
175
+					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) {
176
+											return $offset;
177
+					}
170 178
 					$result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset));
171 179
 				}
172 180
 				return false;
@@ -204,8 +212,9 @@  discard block
 block discarded – undo
204 212
 			$string = $ent_check($string);
205 213
 			preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches);
206 214
 			$string = $matches[0];
207
-			while (strlen($string) > $length)
208
-				$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
215
+			while (strlen($string) > $length) {
216
+							$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
217
+			}
209 218
 			return $string;
210 219
 		},
211 220
 		'ucfirst' => $utf8 ? function($string) use (&$smcFunc)
@@ -215,8 +224,9 @@  discard block
 block discarded – undo
215 224
 		'ucwords' => $utf8 ? function($string) use (&$smcFunc)
216 225
 		{
217 226
 			$words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE);
218
-			for ($i = 0, $n = count($words); $i < $n; $i += 2)
219
-				$words[$i] = $smcFunc['ucfirst']($words[$i]);
227
+			for ($i = 0, $n = count($words); $i < $n; $i += 2) {
228
+							$words[$i] = $smcFunc['ucfirst']($words[$i]);
229
+			}
220 230
 			return implode('', $words);
221 231
 		} : 'ucwords',
222 232
 		'json_decode' => 'smf_json_decode',
@@ -224,16 +234,17 @@  discard block
 block discarded – undo
224 234
 	);
225 235
 
226 236
 	// Setting the timezone is a requirement for some functions.
227
-	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list()))
228
-		date_default_timezone_set($modSettings['default_timezone']);
229
-	else
237
+	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) {
238
+			date_default_timezone_set($modSettings['default_timezone']);
239
+	} else
230 240
 	{
231 241
 		// Get PHP's default timezone, if set
232 242
 		$ini_tz = ini_get('date.timezone');
233
-		if (!empty($ini_tz))
234
-			$modSettings['default_timezone'] = $ini_tz;
235
-		else
236
-			$modSettings['default_timezone'] = '';
243
+		if (!empty($ini_tz)) {
244
+					$modSettings['default_timezone'] = $ini_tz;
245
+		} else {
246
+					$modSettings['default_timezone'] = '';
247
+		}
237 248
 
238 249
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
239 250
 		if (!in_array($modSettings['default_timezone'], timezone_identifiers_list()))
@@ -251,22 +262,26 @@  discard block
 block discarded – undo
251 262
 		if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null)
252 263
 		{
253 264
 			$modSettings['load_average'] = @file_get_contents('/proc/loadavg');
254
-			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0)
255
-				$modSettings['load_average'] = (float) $matches[1];
256
-			elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0)
257
-				$modSettings['load_average'] = (float) $matches[1];
258
-			else
259
-				unset($modSettings['load_average']);
265
+			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) {
266
+							$modSettings['load_average'] = (float) $matches[1];
267
+			} elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) {
268
+							$modSettings['load_average'] = (float) $matches[1];
269
+			} else {
270
+							unset($modSettings['load_average']);
271
+			}
260 272
 
261
-			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
262
-				cache_put_data('loadavg', $modSettings['load_average'], 90);
273
+			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
274
+							cache_put_data('loadavg', $modSettings['load_average'], 90);
275
+			}
263 276
 		}
264 277
 
265
-		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
266
-			call_integration_hook('integrate_load_average', array($modSettings['load_average']));
278
+		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
279
+					call_integration_hook('integrate_load_average', array($modSettings['load_average']));
280
+		}
267 281
 
268
-		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum'])
269
-			display_loadavg_error();
282
+		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) {
283
+					display_loadavg_error();
284
+		}
270 285
 	}
271 286
 
272 287
 	// Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is.
@@ -287,8 +302,9 @@  discard block
 block discarded – undo
287 302
 	if (defined('SMF_INTEGRATION_SETTINGS'))
288 303
 	{
289 304
 		$integration_settings = $smcFunc['json_decode'](SMF_INTEGRATION_SETTINGS, true);
290
-		foreach ($integration_settings as $hook => $function)
291
-			add_integration_function($hook, $function, '', false);
305
+		foreach ($integration_settings as $hook => $function) {
306
+					add_integration_function($hook, $function, '', false);
307
+		}
292 308
 	}
293 309
 
294 310
 	// Any files to pre include?
@@ -298,8 +314,9 @@  discard block
 block discarded – undo
298 314
 		foreach ($pre_includes as $include)
299 315
 		{
300 316
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
301
-			if (file_exists($include))
302
-				require_once($include);
317
+			if (file_exists($include)) {
318
+							require_once($include);
319
+			}
303 320
 		}
304 321
 	}
305 322
 
@@ -392,9 +409,9 @@  discard block
 block discarded – undo
392 409
 				break;
393 410
 			}
394 411
 		}
412
+	} else {
413
+			$id_member = 0;
395 414
 	}
396
-	else
397
-		$id_member = 0;
398 415
 
399 416
 	if (empty($id_member) && isset($_COOKIE[$cookiename]))
400 417
 	{
@@ -402,8 +419,9 @@  discard block
 block discarded – undo
402 419
 		$cookie_data = $smcFunc['json_decode']($_COOKIE[$cookiename], true, false);
403 420
 
404 421
 		// Legacy format (for recent 2.0 --> 2.1 upgrades)
405
-		if (empty($cookie_data))
406
-			$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
422
+		if (empty($cookie_data)) {
423
+					$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
424
+		}
407 425
 
408 426
 		list($id_member, $password, $login_span, $cookie_domain, $cookie_path) = array_pad((array) $cookie_data, 5, '');
409 427
 
@@ -411,16 +429,17 @@  discard block
 block discarded – undo
411 429
 
412 430
 		// Make sure the cookie is set to the correct domain and path
413 431
 		require_once($sourcedir . '/Subs-Auth.php');
414
-		if (array($cookie_domain, $cookie_path) !== url_parts(!empty($modSettings['localCookies']), !empty($modSettings['globalCookies'])))
415
-			setLoginCookie((int) $login_span - time(), $id_member);
416
-	}
417
-	elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
432
+		if (array($cookie_domain, $cookie_path) !== url_parts(!empty($modSettings['localCookies']), !empty($modSettings['globalCookies']))) {
433
+					setLoginCookie((int) $login_span - time(), $id_member);
434
+		}
435
+	} elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
418 436
 	{
419 437
 		// @todo Perhaps we can do some more checking on this, such as on the first octet of the IP?
420 438
 		$cookie_data = $smcFunc['json_decode']($_SESSION['login_' . $cookiename], true);
421 439
 
422
-		if (empty($cookie_data))
423
-			$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
440
+		if (empty($cookie_data)) {
441
+					$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
442
+		}
424 443
 
425 444
 		list($id_member, $password, $login_span) = array_pad((array) $cookie_data, 3, '');
426 445
 		$id_member = !empty($id_member) && strlen($password) == 128 && (int) $login_span > time() ? (int) $id_member : 0;
@@ -445,30 +464,34 @@  discard block
 block discarded – undo
445 464
 			$user_settings = $smcFunc['db_fetch_assoc']($request);
446 465
 			$smcFunc['db_free_result']($request);
447 466
 
448
-			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false && empty($user_info['possibly_robot']))
449
-				$user_settings['avatar'] = get_proxied_url($user_settings['avatar']);
467
+			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false && empty($user_info['possibly_robot'])) {
468
+							$user_settings['avatar'] = get_proxied_url($user_settings['avatar']);
469
+			}
450 470
 
451
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
452
-				cache_put_data('user_settings-' . $id_member, $user_settings, 60);
471
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
472
+							cache_put_data('user_settings-' . $id_member, $user_settings, 60);
473
+			}
453 474
 		}
454 475
 
455 476
 		// Did we find 'im?  If not, junk it.
456 477
 		if (!empty($user_settings))
457 478
 		{
458 479
 			// As much as the password should be right, we can assume the integration set things up.
459
-			if (!empty($already_verified) && $already_verified === true)
460
-				$check = true;
480
+			if (!empty($already_verified) && $already_verified === true) {
481
+							$check = true;
482
+			}
461 483
 			// SHA-512 hash should be 128 characters long.
462
-			elseif (strlen($password) == 128)
463
-				$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
464
-			else
465
-				$check = false;
484
+			elseif (strlen($password) == 128) {
485
+							$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
486
+			} else {
487
+							$check = false;
488
+			}
466 489
 
467 490
 			// Wrong password or not activated - either way, you're going nowhere.
468 491
 			$id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0;
492
+		} else {
493
+					$id_member = 0;
469 494
 		}
470
-		else
471
-			$id_member = 0;
472 495
 
473 496
 		// If we no longer have the member maybe they're being all hackey, stop brute force!
474 497
 		if (!$id_member)
@@ -497,8 +520,9 @@  discard block
 block discarded – undo
497 520
 
498 521
 					list ($tfamember, $tfasecret) = array_pad((array) $tfa_data, 2, '');
499 522
 
500
-					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member)
501
-						$tfasecret = null;
523
+					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) {
524
+											$tfasecret = null;
525
+					}
502 526
 				}
503 527
 
504 528
 				// They didn't finish logging in before coming here? Then they're no one to us.
@@ -520,10 +544,12 @@  discard block
 block discarded – undo
520 544
 		// Are we forcing 2FA? Need to check if the user groups actually require 2FA
521 545
 		elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret']))
522 546
 		{
523
-			if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups
547
+			if ($modSettings['tfa_mode'] == 2) {
548
+				//only do this if we are just forcing SOME membergroups
524 549
 			{
525 550
 				//Build an array of ALL user membergroups.
526 551
 				$full_groups = array($user_settings['id_group']);
552
+			}
527 553
 				if (!empty($user_settings['additional_groups']))
528 554
 				{
529 555
 					$full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups']));
@@ -543,15 +569,17 @@  discard block
 block discarded – undo
543 569
 				);
544 570
 				$row = $smcFunc['db_fetch_assoc']($request);
545 571
 				$smcFunc['db_free_result']($request);
572
+			} else {
573
+							$row['total'] = 1;
546 574
 			}
547
-			else
548
-				$row['total'] = 1; //simplifies logics in the next "if"
575
+			//simplifies logics in the next "if"
549 576
 
550 577
 			$area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : '';
551 578
 			$action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : '';
552 579
 
553
-			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup'))
554
-				redirectexit('action=profile;area=tfasetup;forced');
580
+			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) {
581
+							redirectexit('action=profile;area=tfasetup;forced');
582
+			}
555 583
 		}
556 584
 	}
557 585
 
@@ -588,33 +616,37 @@  discard block
 block discarded – undo
588 616
 				updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP']));
589 617
 				$user_settings['last_login'] = time();
590 618
 
591
-				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
592
-					cache_put_data('user_settings-' . $id_member, $user_settings, 60);
619
+				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
620
+									cache_put_data('user_settings-' . $id_member, $user_settings, 60);
621
+				}
593 622
 
594
-				if (!empty($modSettings['cache_enable']))
595
-					cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
623
+				if (!empty($modSettings['cache_enable'])) {
624
+									cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
625
+				}
596 626
 			}
627
+		} elseif (empty($_SESSION['id_msg_last_visit'])) {
628
+					$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
597 629
 		}
598
-		elseif (empty($_SESSION['id_msg_last_visit']))
599
-			$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
600 630
 
601 631
 		$username = $user_settings['member_name'];
602 632
 
603
-		if (empty($user_settings['additional_groups']))
604
-			$user_info = array(
633
+		if (empty($user_settings['additional_groups'])) {
634
+					$user_info = array(
605 635
 				'groups' => array($user_settings['id_group'], $user_settings['id_post_group'])
606 636
 			);
607
-		else
608
-			$user_info = array(
637
+		} else {
638
+					$user_info = array(
609 639
 				'groups' => array_merge(
610 640
 					array($user_settings['id_group'], $user_settings['id_post_group']),
611 641
 					explode(',', $user_settings['additional_groups'])
612 642
 				)
613 643
 			);
644
+		}
614 645
 
615 646
 		// Because history has proven that it is possible for groups to go bad - clean up in case.
616
-		foreach ($user_info['groups'] as $k => $v)
617
-			$user_info['groups'][$k] = (int) $v;
647
+		foreach ($user_info['groups'] as $k => $v) {
648
+					$user_info['groups'][$k] = (int) $v;
649
+		}
618 650
 
619 651
 		// This is a logged in user, so definitely not a spider.
620 652
 		$user_info['possibly_robot'] = false;
@@ -628,8 +660,7 @@  discard block
 block discarded – undo
628 660
 			$time_system = new DateTime('now', $tz_system);
629 661
 			$time_user = new DateTime('now', $tz_user);
630 662
 			$user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600;
631
-		}
632
-		else
663
+		} else
633 664
 		{
634 665
 			// !!! Compatibility.
635 666
 			$user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset'];
@@ -643,8 +674,9 @@  discard block
 block discarded – undo
643 674
 		$user_info = array('groups' => array(-1));
644 675
 		$user_settings = array();
645 676
 
646
-		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member']))
647
-			$_COOKIE[$cookiename] = '';
677
+		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) {
678
+					$_COOKIE[$cookiename] = '';
679
+		}
648 680
 
649 681
 		// Expire the 2FA cookie
650 682
 		if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member']))
@@ -661,19 +693,20 @@  discard block
 block discarded – undo
661 693
 		}
662 694
 
663 695
 		// Create a login token if it doesn't exist yet.
664
-		if (!isset($_SESSION['token']['post-login']))
665
-			createToken('login');
666
-		else
667
-			list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
696
+		if (!isset($_SESSION['token']['post-login'])) {
697
+					createToken('login');
698
+		} else {
699
+					list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
700
+		}
668 701
 
669 702
 		// Do we perhaps think this is a search robot? Check every five minutes just in case...
670 703
 		if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300))
671 704
 		{
672 705
 			require_once($sourcedir . '/ManageSearchEngines.php');
673 706
 			$user_info['possibly_robot'] = SpiderCheck();
707
+		} elseif (!empty($modSettings['spider_mode'])) {
708
+					$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
674 709
 		}
675
-		elseif (!empty($modSettings['spider_mode']))
676
-			$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
677 710
 		// If we haven't turned on proper spider hunts then have a guess!
678 711
 		else
679 712
 		{
@@ -721,8 +754,9 @@  discard block
 block discarded – undo
721 754
 	$user_info['groups'] = array_unique($user_info['groups']);
722 755
 
723 756
 	// Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems.
724
-	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1]))
725
-		unset($user_info['ignoreboards'][$tmp]);
757
+	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) {
758
+			unset($user_info['ignoreboards'][$tmp]);
759
+	}
726 760
 
727 761
 	// Allow the user to change their language.
728 762
 	if (!empty($modSettings['userLanguage']))
@@ -735,13 +769,14 @@  discard block
 block discarded – undo
735 769
 			$user_info['language'] = strtr($_GET['language'], './\\:', '____');
736 770
 
737 771
 			// Make it permanent for members.
738
-			if (!empty($user_info['id']))
739
-				updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
740
-			else
741
-				$_SESSION['language'] = $user_info['language'];
772
+			if (!empty($user_info['id'])) {
773
+							updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
774
+			} else {
775
+							$_SESSION['language'] = $user_info['language'];
776
+			}
777
+		} elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) {
778
+					$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
742 779
 		}
743
-		elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')]))
744
-			$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
745 780
 	}
746 781
 
747 782
 	$temp = build_query_board($user_info['id']);
@@ -804,9 +839,9 @@  discard block
 block discarded – undo
804 839
 		}
805 840
 
806 841
 		// Remember redirection is the key to avoiding fallout from your bosses.
807
-		if (!empty($topic))
808
-			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
809
-		else
842
+		if (!empty($topic)) {
843
+					redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
844
+		} else
810 845
 		{
811 846
 			loadPermissions();
812 847
 			loadTheme();
@@ -824,10 +859,11 @@  discard block
 block discarded – undo
824 859
 	if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
825 860
 	{
826 861
 		// @todo SLOW?
827
-		if (!empty($topic))
828
-			$temp = cache_get_data('topic_board-' . $topic, 120);
829
-		else
830
-			$temp = cache_get_data('board-' . $board, 120);
862
+		if (!empty($topic)) {
863
+					$temp = cache_get_data('topic_board-' . $topic, 120);
864
+		} else {
865
+					$temp = cache_get_data('board-' . $board, 120);
866
+		}
831 867
 
832 868
 		if (!empty($temp))
833 869
 		{
@@ -865,8 +901,9 @@  discard block
 block discarded – undo
865 901
 			$row = $smcFunc['db_fetch_assoc']($request);
866 902
 
867 903
 			// Set the current board.
868
-			if (!empty($row['id_board']))
869
-				$board = $row['id_board'];
904
+			if (!empty($row['id_board'])) {
905
+							$board = $row['id_board'];
906
+			}
870 907
 
871 908
 			// Basic operating information. (globals... :/)
872 909
 			$board_info = array(
@@ -902,21 +939,23 @@  discard block
 block discarded – undo
902 939
 
903 940
 			do
904 941
 			{
905
-				if (!empty($row['id_moderator']))
906
-					$board_info['moderators'][$row['id_moderator']] = array(
942
+				if (!empty($row['id_moderator'])) {
943
+									$board_info['moderators'][$row['id_moderator']] = array(
907 944
 						'id' => $row['id_moderator'],
908 945
 						'name' => $row['real_name'],
909 946
 						'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
910 947
 						'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
911 948
 					);
949
+				}
912 950
 
913
-				if (!empty($row['id_moderator_group']))
914
-					$board_info['moderator_groups'][$row['id_moderator_group']] = array(
951
+				if (!empty($row['id_moderator_group'])) {
952
+									$board_info['moderator_groups'][$row['id_moderator_group']] = array(
915 953
 						'id' => $row['id_moderator_group'],
916 954
 						'name' => $row['group_name'],
917 955
 						'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
918 956
 						'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
919 957
 					);
958
+				}
920 959
 			}
921 960
 			while ($row = $smcFunc['db_fetch_assoc']($request));
922 961
 
@@ -948,12 +987,12 @@  discard block
 block discarded – undo
948 987
 			if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
949 988
 			{
950 989
 				// @todo SLOW?
951
-				if (!empty($topic))
952
-					cache_put_data('topic_board-' . $topic, $board_info, 120);
990
+				if (!empty($topic)) {
991
+									cache_put_data('topic_board-' . $topic, $board_info, 120);
992
+				}
953 993
 				cache_put_data('board-' . $board, $board_info, 120);
954 994
 			}
955
-		}
956
-		else
995
+		} else
957 996
 		{
958 997
 			// Otherwise the topic is invalid, there are no moderators, etc.
959 998
 			$board_info = array(
@@ -967,8 +1006,9 @@  discard block
 block discarded – undo
967 1006
 		$smcFunc['db_free_result']($request);
968 1007
 	}
969 1008
 
970
-	if (!empty($topic))
971
-		$_GET['board'] = (int) $board;
1009
+	if (!empty($topic)) {
1010
+			$_GET['board'] = (int) $board;
1011
+	}
972 1012
 
973 1013
 	if (!empty($board))
974 1014
 	{
@@ -978,10 +1018,12 @@  discard block
 block discarded – undo
978 1018
 		// Now check if the user is a moderator.
979 1019
 		$user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0;
980 1020
 
981
-		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin'])
982
-			$board_info['error'] = 'access';
983
-		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin'])
984
-			$board_info['error'] = 'access';
1021
+		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) {
1022
+					$board_info['error'] = 'access';
1023
+		}
1024
+		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) {
1025
+					$board_info['error'] = 'access';
1026
+		}
985 1027
 
986 1028
 		// Build up the linktree.
987 1029
 		$context['linktree'] = array_merge(
@@ -1004,8 +1046,9 @@  discard block
 block discarded – undo
1004 1046
 	$context['current_board'] = $board;
1005 1047
 
1006 1048
 	// No posting in redirection boards!
1007
-	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect']))
1008
-		$board_info['error'] == 'post_in_redirect';
1049
+	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) {
1050
+			$board_info['error'] == 'post_in_redirect';
1051
+	}
1009 1052
 
1010 1053
 	// Hacker... you can't see this topic, I'll tell you that. (but moderators can!)
1011 1054
 	if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod']))
@@ -1031,24 +1074,23 @@  discard block
 block discarded – undo
1031 1074
 			ob_end_clean();
1032 1075
 			header('HTTP/1.1 403 Forbidden');
1033 1076
 			die;
1034
-		}
1035
-		elseif ($board_info['error'] == 'post_in_redirect')
1077
+		} elseif ($board_info['error'] == 'post_in_redirect')
1036 1078
 		{
1037 1079
 			// Slightly different error message here...
1038 1080
 			fatal_lang_error('cannot_post_redirect', false);
1039
-		}
1040
-		elseif ($user_info['is_guest'])
1081
+		} elseif ($user_info['is_guest'])
1041 1082
 		{
1042 1083
 			loadLanguage('Errors');
1043 1084
 			is_not_guest($txt['topic_gone']);
1085
+		} else {
1086
+					fatal_lang_error('topic_gone', false);
1044 1087
 		}
1045
-		else
1046
-			fatal_lang_error('topic_gone', false);
1047 1088
 	}
1048 1089
 
1049
-	if ($user_info['is_mod'])
1050
-		$user_info['groups'][] = 3;
1051
-}
1090
+	if ($user_info['is_mod']) {
1091
+			$user_info['groups'][] = 3;
1092
+	}
1093
+	}
1052 1094
 
1053 1095
 /**
1054 1096
  * Load this user's permissions.
@@ -1069,8 +1111,9 @@  discard block
 block discarded – undo
1069 1111
 		asort($cache_groups);
1070 1112
 		$cache_groups = implode(',', $cache_groups);
1071 1113
 		// If it's a spider then cache it different.
1072
-		if ($user_info['possibly_robot'])
1073
-			$cache_groups .= '-spider';
1114
+		if ($user_info['possibly_robot']) {
1115
+					$cache_groups .= '-spider';
1116
+		}
1074 1117
 
1075 1118
 		if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1076 1119
 		{
@@ -1078,9 +1121,9 @@  discard block
 block discarded – undo
1078 1121
 			banPermissions();
1079 1122
 
1080 1123
 			return;
1124
+		} elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) {
1125
+					list ($user_info['permissions'], $removals) = $temp;
1081 1126
 		}
1082
-		elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1083
-			list ($user_info['permissions'], $removals) = $temp;
1084 1127
 	}
1085 1128
 
1086 1129
 	// If it is detected as a robot, and we are restricting permissions as a special group - then implement this.
@@ -1102,23 +1145,26 @@  discard block
 block discarded – undo
1102 1145
 		$removals = array();
1103 1146
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1104 1147
 		{
1105
-			if (empty($row['add_deny']))
1106
-				$removals[] = $row['permission'];
1107
-			else
1108
-				$user_info['permissions'][] = $row['permission'];
1148
+			if (empty($row['add_deny'])) {
1149
+							$removals[] = $row['permission'];
1150
+			} else {
1151
+							$user_info['permissions'][] = $row['permission'];
1152
+			}
1109 1153
 		}
1110 1154
 		$smcFunc['db_free_result']($request);
1111 1155
 
1112
-		if (isset($cache_groups))
1113
-			cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1156
+		if (isset($cache_groups)) {
1157
+					cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1158
+		}
1114 1159
 	}
1115 1160
 
1116 1161
 	// Get the board permissions.
1117 1162
 	if (!empty($board))
1118 1163
 	{
1119 1164
 		// Make sure the board (if any) has been loaded by loadBoard().
1120
-		if (!isset($board_info['profile']))
1121
-			fatal_lang_error('no_board');
1165
+		if (!isset($board_info['profile'])) {
1166
+					fatal_lang_error('no_board');
1167
+		}
1122 1168
 
1123 1169
 		$request = $smcFunc['db_query']('', '
1124 1170
 			SELECT permission, add_deny
@@ -1134,20 +1180,23 @@  discard block
 block discarded – undo
1134 1180
 		);
1135 1181
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1136 1182
 		{
1137
-			if (empty($row['add_deny']))
1138
-				$removals[] = $row['permission'];
1139
-			else
1140
-				$user_info['permissions'][] = $row['permission'];
1183
+			if (empty($row['add_deny'])) {
1184
+							$removals[] = $row['permission'];
1185
+			} else {
1186
+							$user_info['permissions'][] = $row['permission'];
1187
+			}
1141 1188
 		}
1142 1189
 		$smcFunc['db_free_result']($request);
1143 1190
 	}
1144 1191
 
1145 1192
 	// Remove all the permissions they shouldn't have ;).
1146
-	if (!empty($modSettings['permission_enable_deny']))
1147
-		$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1193
+	if (!empty($modSettings['permission_enable_deny'])) {
1194
+			$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1195
+	}
1148 1196
 
1149
-	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2)
1150
-		cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1197
+	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) {
1198
+			cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1199
+	}
1151 1200
 
1152 1201
 	// Banned?  Watch, don't touch..
1153 1202
 	banPermissions();
@@ -1159,17 +1208,18 @@  discard block
 block discarded – undo
1159 1208
 		{
1160 1209
 			require_once($sourcedir . '/Subs-Auth.php');
1161 1210
 			rebuildModCache();
1211
+		} else {
1212
+					$user_info['mod_cache'] = $_SESSION['mc'];
1162 1213
 		}
1163
-		else
1164
-			$user_info['mod_cache'] = $_SESSION['mc'];
1165 1214
 
1166 1215
 		// This is a useful phantom permission added to the current user, and only the current user while they are logged in.
1167 1216
 		// For example this drastically simplifies certain changes to the profile area.
1168 1217
 		$user_info['permissions'][] = 'is_not_guest';
1169 1218
 		// And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions.
1170 1219
 		$user_info['permissions'][] = 'profile_view_own';
1171
-		if (in_array('profile_view', $user_info['permissions']))
1172
-			$user_info['permissions'][] = 'profile_view_any';
1220
+		if (in_array('profile_view', $user_info['permissions'])) {
1221
+					$user_info['permissions'][] = 'profile_view_any';
1222
+		}
1173 1223
 	}
1174 1224
 }
1175 1225
 
@@ -1187,8 +1237,9 @@  discard block
 block discarded – undo
1187 1237
 	global $image_proxy_enabled, $boardurl, $user_info;
1188 1238
 
1189 1239
 	// Can't just look for no users :P.
1190
-	if (empty($users))
1191
-		return array();
1240
+	if (empty($users)) {
1241
+			return array();
1242
+	}
1192 1243
 
1193 1244
 	// Pass the set value
1194 1245
 	$context['loadMemberContext_set'] = $set;
@@ -1203,8 +1254,9 @@  discard block
 block discarded – undo
1203 1254
 		for ($i = 0, $n = count($users); $i < $n; $i++)
1204 1255
 		{
1205 1256
 			$data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240);
1206
-			if ($data == null)
1207
-				continue;
1257
+			if ($data == null) {
1258
+							continue;
1259
+			}
1208 1260
 
1209 1261
 			$loaded_ids[] = $data['id_member'];
1210 1262
 			$user_profile[$data['id_member']] = $data;
@@ -1271,16 +1323,19 @@  discard block
 block discarded – undo
1271 1323
 			$row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : '';
1272 1324
 
1273 1325
 			// Take care of proxying avatar if required, do this here for maximum reach
1274
-			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false && empty($user_info['possibly_robot']))
1275
-				$row['avatar'] = get_proxied_url($row['avatar']);
1326
+			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false && empty($user_info['possibly_robot'])) {
1327
+							$row['avatar'] = get_proxied_url($row['avatar']);
1328
+			}
1276 1329
 
1277 1330
 			// Keep track of the member's normal member group
1278 1331
 			$row['primary_group'] = $row['member_group'];
1279 1332
 
1280
-			if (isset($row['member_ip']))
1281
-				$row['member_ip'] = inet_dtop($row['member_ip']);
1282
-			if (isset($row['member_ip2']))
1283
-				$row['member_ip2'] = inet_dtop($row['member_ip2']);
1333
+			if (isset($row['member_ip'])) {
1334
+							$row['member_ip'] = inet_dtop($row['member_ip']);
1335
+			}
1336
+			if (isset($row['member_ip2'])) {
1337
+							$row['member_ip2'] = inet_dtop($row['member_ip2']);
1338
+			}
1284 1339
 			$new_loaded_ids[] = $row['id_member'];
1285 1340
 			$loaded_ids[] = $row['id_member'];
1286 1341
 			$row['options'] = array();
@@ -1299,8 +1354,9 @@  discard block
 block discarded – undo
1299 1354
 				'loaded_ids' => $new_loaded_ids,
1300 1355
 			)
1301 1356
 		);
1302
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1303
-			$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1357
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1358
+					$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1359
+		}
1304 1360
 		$smcFunc['db_free_result']($request);
1305 1361
 	}
1306 1362
 
@@ -1311,10 +1367,11 @@  discard block
 block discarded – undo
1311 1367
 	{
1312 1368
 		foreach ($loaded_ids as $a_member)
1313 1369
 		{
1314
-			if (!empty($user_profile[$a_member]['additional_groups']))
1315
-				$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1316
-			else
1317
-				$groups = array($user_profile[$a_member]['id_group']);
1370
+			if (!empty($user_profile[$a_member]['additional_groups'])) {
1371
+							$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1372
+			} else {
1373
+							$groups = array($user_profile[$a_member]['id_group']);
1374
+			}
1318 1375
 
1319 1376
 			$temp = array_intersect($groups, array_keys($board_info['moderator_groups']));
1320 1377
 
@@ -1327,8 +1384,9 @@  discard block
 block discarded – undo
1327 1384
 
1328 1385
 	if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3)
1329 1386
 	{
1330
-		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++)
1331
-			cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1387
+		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) {
1388
+					cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1389
+		}
1332 1390
 	}
1333 1391
 
1334 1392
 	// Are we loading any moderators?  If so, fix their group data...
@@ -1354,14 +1412,17 @@  discard block
 block discarded – undo
1354 1412
 		foreach ($temp_mods as $id)
1355 1413
 		{
1356 1414
 			// By popular demand, don't show admins or global moderators as moderators.
1357
-			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2)
1358
-				$user_profile[$id]['member_group'] = $row['member_group'];
1415
+			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) {
1416
+							$user_profile[$id]['member_group'] = $row['member_group'];
1417
+			}
1359 1418
 
1360 1419
 			// If the Moderator group has no color or icons, but their group does... don't overwrite.
1361
-			if (!empty($row['icons']))
1362
-				$user_profile[$id]['icons'] = $row['icons'];
1363
-			if (!empty($row['member_group_color']))
1364
-				$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1420
+			if (!empty($row['icons'])) {
1421
+							$user_profile[$id]['icons'] = $row['icons'];
1422
+			}
1423
+			if (!empty($row['member_group_color'])) {
1424
+							$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1425
+			}
1365 1426
 		}
1366 1427
 	}
1367 1428
 
@@ -1383,12 +1444,14 @@  discard block
 block discarded – undo
1383 1444
 	static $loadedLanguages = array();
1384 1445
 
1385 1446
 	// If this person's data is already loaded, skip it.
1386
-	if (isset($dataLoaded[$user]))
1387
-		return true;
1447
+	if (isset($dataLoaded[$user])) {
1448
+			return true;
1449
+	}
1388 1450
 
1389 1451
 	// We can't load guests or members not loaded by loadMemberData()!
1390
-	if ($user == 0)
1391
-		return false;
1452
+	if ($user == 0) {
1453
+			return false;
1454
+	}
1392 1455
 	if (!isset($user_profile[$user]))
1393 1456
 	{
1394 1457
 		trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING);
@@ -1414,12 +1477,16 @@  discard block
 block discarded – undo
1414 1477
 	$buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array();
1415 1478
 
1416 1479
 	//We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme
1417
-	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists
1480
+	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) {
1481
+		//icon is set and exists
1418 1482
 		$group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1];
1419
-	elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default
1483
+	} elseif (isset($profile['icons'][1])) {
1484
+		//icon is set and doesn't exist, fallback to default
1420 1485
 		$group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1];
1421
-	else //not set, bye bye
1486
+	} else {
1487
+		//not set, bye bye
1422 1488
 		$group_icon_url = '';
1489
+	}
1423 1490
 
1424 1491
 	// These minimal values are always loaded
1425 1492
 	$memberContext[$user] = array(
@@ -1438,8 +1505,9 @@  discard block
 block discarded – undo
1438 1505
 	if ($context['loadMemberContext_set'] != 'minimal')
1439 1506
 	{
1440 1507
 		// Go the extra mile and load the user's native language name.
1441
-		if (empty($loadedLanguages))
1442
-			$loadedLanguages = getLanguages();
1508
+		if (empty($loadedLanguages)) {
1509
+					$loadedLanguages = getLanguages();
1510
+		}
1443 1511
 
1444 1512
 		$memberContext[$user] += array(
1445 1513
 			'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>',
@@ -1494,31 +1562,33 @@  discard block
 block discarded – undo
1494 1562
 	{
1495 1563
 		if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://')))
1496 1564
 		{
1497
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11)
1498
-				$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1499
-			else
1500
-				$image = get_gravatar_url($profile['email_address']);
1501
-		}
1502
-		else
1565
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) {
1566
+							$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1567
+			} else {
1568
+							$image = get_gravatar_url($profile['email_address']);
1569
+			}
1570
+		} else
1503 1571
 		{
1504 1572
 			// So it's stored in the member table?
1505 1573
 			if (!empty($profile['avatar']))
1506 1574
 			{
1507 1575
 				$image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar'];
1576
+			} elseif (!empty($profile['filename'])) {
1577
+							$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1508 1578
 			}
1509
-			elseif (!empty($profile['filename']))
1510
-				$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1511 1579
 			// Right... no avatar...use the default one
1512
-			else
1513
-				$image = $modSettings['avatar_url'] . '/default.png';
1580
+			else {
1581
+							$image = $modSettings['avatar_url'] . '/default.png';
1582
+			}
1514 1583
 		}
1515
-		if (!empty($image))
1516
-			$memberContext[$user]['avatar'] = array(
1584
+		if (!empty($image)) {
1585
+					$memberContext[$user]['avatar'] = array(
1517 1586
 				'name' => $profile['avatar'],
1518 1587
 				'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">',
1519 1588
 				'href' => $image,
1520 1589
 				'url' => $image,
1521 1590
 			);
1591
+		}
1522 1592
 	}
1523 1593
 
1524 1594
 	// Are we also loading the members custom fields into context?
@@ -1526,13 +1596,15 @@  discard block
 block discarded – undo
1526 1596
 	{
1527 1597
 		$memberContext[$user]['custom_fields'] = array();
1528 1598
 
1529
-		if (!isset($context['display_fields']))
1530
-			$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1599
+		if (!isset($context['display_fields'])) {
1600
+					$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1601
+		}
1531 1602
 
1532 1603
 		foreach ($context['display_fields'] as $custom)
1533 1604
 		{
1534
-			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']]))
1535
-				continue;
1605
+			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) {
1606
+							continue;
1607
+			}
1536 1608
 
1537 1609
 			$value = $profile['options'][$custom['col_name']];
1538 1610
 
@@ -1540,31 +1612,36 @@  discard block
 block discarded – undo
1540 1612
 			$currentKey = 0;
1541 1613
 
1542 1614
 			// Create a key => value array for multiple options fields
1543
-			if (!empty($custom['options']))
1544
-				foreach ($custom['options'] as $k => $v)
1615
+			if (!empty($custom['options'])) {
1616
+							foreach ($custom['options'] as $k => $v)
1545 1617
 				{
1546 1618
 					$fieldOptions[] = $v;
1547
-					if (empty($currentKey))
1548
-						$currentKey = $v == $value ? $k : 0;
1619
+			}
1620
+					if (empty($currentKey)) {
1621
+											$currentKey = $v == $value ? $k : 0;
1622
+					}
1549 1623
 				}
1550 1624
 
1551 1625
 			// BBC?
1552
-			if ($custom['bbc'])
1553
-				$value = parse_bbc($value);
1626
+			if ($custom['bbc']) {
1627
+							$value = parse_bbc($value);
1628
+			}
1554 1629
 
1555 1630
 			// ... or checkbox?
1556
-			elseif (isset($custom['type']) && $custom['type'] == 'check')
1557
-				$value = $value ? $txt['yes'] : $txt['no'];
1631
+			elseif (isset($custom['type']) && $custom['type'] == 'check') {
1632
+							$value = $value ? $txt['yes'] : $txt['no'];
1633
+			}
1558 1634
 
1559 1635
 			// Enclosing the user input within some other text?
1560
-			if (!empty($custom['enclose']))
1561
-				$value = strtr($custom['enclose'], array(
1636
+			if (!empty($custom['enclose'])) {
1637
+							$value = strtr($custom['enclose'], array(
1562 1638
 					'{SCRIPTURL}' => $scripturl,
1563 1639
 					'{IMAGES_URL}' => $settings['images_url'],
1564 1640
 					'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1565 1641
 					'{INPUT}' => $value,
1566 1642
 					'{KEY}' => $currentKey,
1567 1643
 				));
1644
+			}
1568 1645
 
1569 1646
 			$memberContext[$user]['custom_fields'][] = array(
1570 1647
 				'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'],
@@ -1591,8 +1668,9 @@  discard block
 block discarded – undo
1591 1668
 	global $smcFunc, $txt, $scripturl, $settings;
1592 1669
 
1593 1670
 	// Do not waste my time...
1594
-	if (empty($users) || empty($params))
1595
-		return false;
1671
+	if (empty($users) || empty($params)) {
1672
+			return false;
1673
+	}
1596 1674
 
1597 1675
 	// Make sure it's an array.
1598 1676
 	$users = !is_array($users) ? array($users) : array_unique($users);
@@ -1619,41 +1697,48 @@  discard block
 block discarded – undo
1619 1697
 		$currentKey = 0;
1620 1698
 
1621 1699
 		// Create a key => value array for multiple options fields
1622
-		if (!empty($row['field_options']))
1623
-			foreach (explode(',', $row['field_options']) as $k => $v)
1700
+		if (!empty($row['field_options'])) {
1701
+					foreach (explode(',', $row['field_options']) as $k => $v)
1624 1702
 			{
1625 1703
 				$fieldOptions[] = $v;
1626
-				if (empty($currentKey))
1627
-					$currentKey = $v == $row['value'] ? $k : 0;
1704
+		}
1705
+				if (empty($currentKey)) {
1706
+									$currentKey = $v == $row['value'] ? $k : 0;
1707
+				}
1628 1708
 			}
1629 1709
 
1630 1710
 		// BBC?
1631
-		if (!empty($row['bbc']))
1632
-			$row['value'] = parse_bbc($row['value']);
1711
+		if (!empty($row['bbc'])) {
1712
+					$row['value'] = parse_bbc($row['value']);
1713
+		}
1633 1714
 
1634 1715
 		// ... or checkbox?
1635
-		elseif (isset($row['type']) && $row['type'] == 'check')
1636
-			$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1716
+		elseif (isset($row['type']) && $row['type'] == 'check') {
1717
+					$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1718
+		}
1637 1719
 
1638 1720
 		// Enclosing the user input within some other text?
1639
-		if (!empty($row['enclose']))
1640
-			$row['value'] = strtr($row['enclose'], array(
1721
+		if (!empty($row['enclose'])) {
1722
+					$row['value'] = strtr($row['enclose'], array(
1641 1723
 				'{SCRIPTURL}' => $scripturl,
1642 1724
 				'{IMAGES_URL}' => $settings['images_url'],
1643 1725
 				'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1644 1726
 				'{INPUT}' => un_htmlspecialchars($row['value']),
1645 1727
 				'{KEY}' => $currentKey,
1646 1728
 			));
1729
+		}
1647 1730
 
1648 1731
 		// Send a simple array if there is just 1 param
1649
-		if (count($params) == 1)
1650
-			$return[$row['id_member']] = $row;
1732
+		if (count($params) == 1) {
1733
+					$return[$row['id_member']] = $row;
1734
+		}
1651 1735
 
1652 1736
 		// More than 1? knock yourself out...
1653 1737
 		else
1654 1738
 		{
1655
-			if (!isset($return[$row['id_member']]))
1656
-				$return[$row['id_member']] = array();
1739
+			if (!isset($return[$row['id_member']])) {
1740
+							$return[$row['id_member']] = array();
1741
+			}
1657 1742
 
1658 1743
 			$return[$row['id_member']][$row['variable']] = $row;
1659 1744
 		}
@@ -1687,8 +1772,9 @@  discard block
 block discarded – undo
1687 1772
 	global $context;
1688 1773
 
1689 1774
 	// Don't know any browser!
1690
-	if (empty($context['browser']))
1691
-		detectBrowser();
1775
+	if (empty($context['browser'])) {
1776
+			detectBrowser();
1777
+	}
1692 1778
 
1693 1779
 	return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false;
1694 1780
 }
@@ -1706,8 +1792,9 @@  discard block
 block discarded – undo
1706 1792
 	global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled;
1707 1793
 
1708 1794
 	// The theme was specified by parameter.
1709
-	if (!empty($id_theme))
1710
-		$id_theme = (int) $id_theme;
1795
+	if (!empty($id_theme)) {
1796
+			$id_theme = (int) $id_theme;
1797
+	}
1711 1798
 	// The theme was specified by REQUEST.
1712 1799
 	elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1713 1800
 	{
@@ -1715,54 +1802,61 @@  discard block
 block discarded – undo
1715 1802
 		$_SESSION['id_theme'] = $id_theme;
1716 1803
 	}
1717 1804
 	// The theme was specified by REQUEST... previously.
1718
-	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1719
-		$id_theme = (int) $_SESSION['id_theme'];
1805
+	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) {
1806
+			$id_theme = (int) $_SESSION['id_theme'];
1807
+	}
1720 1808
 	// The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.)
1721
-	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme']))
1722
-		$id_theme = $user_info['theme'];
1809
+	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) {
1810
+			$id_theme = $user_info['theme'];
1811
+	}
1723 1812
 	// The theme was specified by the board.
1724
-	elseif (!empty($board_info['theme']))
1725
-		$id_theme = $board_info['theme'];
1813
+	elseif (!empty($board_info['theme'])) {
1814
+			$id_theme = $board_info['theme'];
1815
+	}
1726 1816
 	// The theme is the forum's default.
1727
-	else
1728
-		$id_theme = $modSettings['theme_guests'];
1817
+	else {
1818
+			$id_theme = $modSettings['theme_guests'];
1819
+	}
1729 1820
 
1730 1821
 	// We already load the basic stuff?
1731 1822
 	if (empty($settings['theme_id']) || $settings['theme_id'] != $id_theme )
1732 1823
 	{
1733 1824
 		// Verify the id_theme... no foul play.
1734 1825
 		// Always allow the board specific theme, if they are overriding.
1735
-		if (!empty($board_info['theme']) && $board_info['override_theme'])
1736
-			$id_theme = $board_info['theme'];
1826
+		if (!empty($board_info['theme']) && $board_info['override_theme']) {
1827
+					$id_theme = $board_info['theme'];
1828
+		}
1737 1829
 		// If they have specified a particular theme to use with SSI allow it to be used.
1738
-		elseif (!empty($ssi_theme) && $id_theme == $ssi_theme)
1739
-			$id_theme = (int) $id_theme;
1740
-		elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1830
+		elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) {
1831
+					$id_theme = (int) $id_theme;
1832
+		} elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1741 1833
 		{
1742 1834
 			$themes = explode(',', $modSettings['enableThemes']);
1743
-			if (!in_array($id_theme, $themes))
1744
-				$id_theme = $modSettings['theme_guests'];
1745
-			else
1746
-				$id_theme = (int) $id_theme;
1835
+			if (!in_array($id_theme, $themes)) {
1836
+							$id_theme = $modSettings['theme_guests'];
1837
+			} else {
1838
+							$id_theme = (int) $id_theme;
1839
+			}
1840
+		} else {
1841
+					$id_theme = (int) $id_theme;
1747 1842
 		}
1748
-		else
1749
-			$id_theme = (int) $id_theme;
1750 1843
 
1751 1844
 		$member = empty($user_info['id']) ? -1 : $user_info['id'];
1752 1845
 
1753 1846
 		// Disable image proxy if we don't have SSL enabled
1754
-		if (empty($modSettings['force_ssl']))
1755
-			$image_proxy_enabled = false;
1847
+		if (empty($modSettings['force_ssl'])) {
1848
+					$image_proxy_enabled = false;
1849
+		}
1756 1850
 
1757 1851
 		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated'])
1758 1852
 		{
1759 1853
 			$themeData = $temp;
1760 1854
 			$flag = true;
1855
+		} elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) {
1856
+					$themeData = $temp + array($member => array());
1857
+		} else {
1858
+					$themeData = array(-1 => array(), 0 => array(), $member => array());
1761 1859
 		}
1762
-		elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated'])
1763
-			$themeData = $temp + array($member => array());
1764
-		else
1765
-			$themeData = array(-1 => array(), 0 => array(), $member => array());
1766 1860
 
1767 1861
 		if (empty($flag))
1768 1862
 		{
@@ -1781,31 +1875,37 @@  discard block
 block discarded – undo
1781 1875
 			while ($row = $smcFunc['db_fetch_assoc']($result))
1782 1876
 			{
1783 1877
 				// There are just things we shouldn't be able to change as members.
1784
-				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url')))
1785
-					continue;
1878
+				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) {
1879
+									continue;
1880
+				}
1786 1881
 
1787 1882
 				// If this is the theme_dir of the default theme, store it.
1788
-				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member']))
1789
-					$themeData[0]['default_' . $row['variable']] = $row['value'];
1883
+				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) {
1884
+									$themeData[0]['default_' . $row['variable']] = $row['value'];
1885
+				}
1790 1886
 
1791 1887
 				// If this isn't set yet, is a theme option, or is not the default theme..
1792
-				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1')
1793
-					$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1888
+				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') {
1889
+									$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1890
+				}
1794 1891
 			}
1795 1892
 			$smcFunc['db_free_result']($result);
1796 1893
 
1797
-			if (!empty($themeData[-1]))
1798
-				foreach ($themeData[-1] as $k => $v)
1894
+			if (!empty($themeData[-1])) {
1895
+							foreach ($themeData[-1] as $k => $v)
1799 1896
 				{
1800 1897
 					if (!isset($themeData[$member][$k]))
1801 1898
 						$themeData[$member][$k] = $v;
1899
+			}
1802 1900
 				}
1803 1901
 
1804
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
1805
-				cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1902
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
1903
+							cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1904
+			}
1806 1905
 			// Only if we didn't already load that part of the cache...
1807
-			elseif (!isset($temp))
1808
-				cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1906
+			elseif (!isset($temp)) {
1907
+							cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1908
+			}
1809 1909
 		}
1810 1910
 
1811 1911
 		$settings = $themeData[0];
@@ -1822,17 +1922,20 @@  discard block
 block discarded – undo
1822 1922
 		$settings['template_dirs'][] = $settings['theme_dir'];
1823 1923
 
1824 1924
 		// Based on theme (if there is one).
1825
-		if (!empty($settings['base_theme_dir']))
1826
-			$settings['template_dirs'][] = $settings['base_theme_dir'];
1925
+		if (!empty($settings['base_theme_dir'])) {
1926
+					$settings['template_dirs'][] = $settings['base_theme_dir'];
1927
+		}
1827 1928
 
1828 1929
 		// Lastly the default theme.
1829
-		if ($settings['theme_dir'] != $settings['default_theme_dir'])
1830
-			$settings['template_dirs'][] = $settings['default_theme_dir'];
1930
+		if ($settings['theme_dir'] != $settings['default_theme_dir']) {
1931
+					$settings['template_dirs'][] = $settings['default_theme_dir'];
1932
+		}
1831 1933
 	}
1832 1934
 
1833 1935
 
1834
-	if (!$initialize)
1835
-		return;
1936
+	if (!$initialize) {
1937
+			return;
1938
+	}
1836 1939
 
1837 1940
 	// Check to see if we're forcing SSL
1838 1941
 	if (!empty($modSettings['force_ssl']) && empty($maintenance) &&
@@ -1853,8 +1956,9 @@  discard block
 block discarded – undo
1853 1956
 		$detected_url = httpsOn() ? 'https://' : 'http://';
1854 1957
 		$detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST'];
1855 1958
 		$temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/'));
1856
-		if ($temp != '/')
1857
-			$detected_url .= $temp;
1959
+		if ($temp != '/') {
1960
+					$detected_url .= $temp;
1961
+		}
1858 1962
 	}
1859 1963
 	if (isset($detected_url) && $detected_url != $boardurl)
1860 1964
 	{
@@ -1866,8 +1970,9 @@  discard block
 block discarded – undo
1866 1970
 			foreach ($aliases as $alias)
1867 1971
 			{
1868 1972
 				// Rip off all the boring parts, spaces, etc.
1869
-				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias))
1870
-					$do_fix = true;
1973
+				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) {
1974
+									$do_fix = true;
1975
+				}
1871 1976
 			}
1872 1977
 		}
1873 1978
 
@@ -1875,21 +1980,23 @@  discard block
 block discarded – undo
1875 1980
 		if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI')
1876 1981
 		{
1877 1982
 			// Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;).
1878
-			if (empty($_GET))
1879
-				redirectexit('wwwRedirect');
1880
-			else
1983
+			if (empty($_GET)) {
1984
+							redirectexit('wwwRedirect');
1985
+			} else
1881 1986
 			{
1882 1987
 				$k = key($_GET);
1883 1988
 				$v = current($_GET);
1884 1989
 
1885
-				if ($k != 'wwwRedirect')
1886
-					redirectexit('wwwRedirect;' . $k . '=' . $v);
1990
+				if ($k != 'wwwRedirect') {
1991
+									redirectexit('wwwRedirect;' . $k . '=' . $v);
1992
+				}
1887 1993
 			}
1888 1994
 		}
1889 1995
 
1890 1996
 		// #3 is just a check for SSL...
1891
-		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl)
1892
-			$do_fix = true;
1997
+		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) {
1998
+					$do_fix = true;
1999
+		}
1893 2000
 
1894 2001
 		// Okay, #4 - perhaps it's an IP address?  We're gonna want to use that one, then. (assuming it's the IP or something...)
1895 2002
 		if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1)
@@ -1924,8 +2031,9 @@  discard block
 block discarded – undo
1924 2031
 					$board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl));
1925 2032
 				}
1926 2033
 			}
1927
-			foreach ($context['linktree'] as $k => $dummy)
1928
-				$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2034
+			foreach ($context['linktree'] as $k => $dummy) {
2035
+							$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2036
+			}
1929 2037
 		}
1930 2038
 	}
1931 2039
 	// Set up the contextual user array.
@@ -1944,16 +2052,16 @@  discard block
 block discarded – undo
1944 2052
 			'email' => $user_info['email'],
1945 2053
 			'ignoreusers' => $user_info['ignoreusers'],
1946 2054
 		);
1947
-		if (!$context['user']['is_guest'])
1948
-			$context['user']['name'] = $user_info['name'];
1949
-		elseif ($context['user']['is_guest'] && !empty($txt['guest_title']))
1950
-			$context['user']['name'] = $txt['guest_title'];
2055
+		if (!$context['user']['is_guest']) {
2056
+					$context['user']['name'] = $user_info['name'];
2057
+		} elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) {
2058
+					$context['user']['name'] = $txt['guest_title'];
2059
+		}
1951 2060
 
1952 2061
 		// Determine the current smiley set.
1953 2062
 		$user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set'];
1954 2063
 		$context['user']['smiley_set'] = $user_info['smiley_set'];
1955
-	}
1956
-	else
2064
+	} else
1957 2065
 	{
1958 2066
 		// What to do when there is no $user_info (e.g., an error very early in the login process)
1959 2067
 		$context['user'] = array(
@@ -1987,18 +2095,24 @@  discard block
 block discarded – undo
1987 2095
 	}
1988 2096
 
1989 2097
 	// Some basic information...
1990
-	if (!isset($context['html_headers']))
1991
-		$context['html_headers'] = '';
1992
-	if (!isset($context['javascript_files']))
1993
-		$context['javascript_files'] = array();
1994
-	if (!isset($context['css_files']))
1995
-		$context['css_files'] = array();
1996
-	if (!isset($context['css_header']))
1997
-		$context['css_header'] = array();
1998
-	if (!isset($context['javascript_inline']))
1999
-		$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2000
-	if (!isset($context['javascript_vars']))
2001
-		$context['javascript_vars'] = array();
2098
+	if (!isset($context['html_headers'])) {
2099
+			$context['html_headers'] = '';
2100
+	}
2101
+	if (!isset($context['javascript_files'])) {
2102
+			$context['javascript_files'] = array();
2103
+	}
2104
+	if (!isset($context['css_files'])) {
2105
+			$context['css_files'] = array();
2106
+	}
2107
+	if (!isset($context['css_header'])) {
2108
+			$context['css_header'] = array();
2109
+	}
2110
+	if (!isset($context['javascript_inline'])) {
2111
+			$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2112
+	}
2113
+	if (!isset($context['javascript_vars'])) {
2114
+			$context['javascript_vars'] = array();
2115
+	}
2002 2116
 
2003 2117
 	$context['login_url'] =  $scripturl . '?action=login2';
2004 2118
 	$context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | ';
@@ -2010,16 +2124,18 @@  discard block
 block discarded – undo
2010 2124
 	$context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null;
2011 2125
 	$context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null;
2012 2126
 	$context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3;
2013
-	if (isset($modSettings['load_average']))
2014
-		$context['load_average'] = $modSettings['load_average'];
2127
+	if (isset($modSettings['load_average'])) {
2128
+			$context['load_average'] = $modSettings['load_average'];
2129
+	}
2015 2130
 
2016 2131
 	// Detect the browser. This is separated out because it's also used in attachment downloads
2017 2132
 	detectBrowser();
2018 2133
 
2019 2134
 	// Set the top level linktree up.
2020 2135
 	// Note that if we're dealing with certain very early errors (e.g., login) the linktree might not be set yet...
2021
-	if (empty($context['linktree']))
2022
-		$context['linktree'] = array();
2136
+	if (empty($context['linktree'])) {
2137
+			$context['linktree'] = array();
2138
+	}
2023 2139
 	array_unshift($context['linktree'], array(
2024 2140
 		'url' => $scripturl,
2025 2141
 		'name' => $context['forum_name_html_safe']
@@ -2028,8 +2144,9 @@  discard block
 block discarded – undo
2028 2144
 	// This allows sticking some HTML on the page output - useful for controls.
2029 2145
 	$context['insert_after_template'] = '';
2030 2146
 
2031
-	if (!isset($txt))
2032
-		$txt = array();
2147
+	if (!isset($txt)) {
2148
+			$txt = array();
2149
+	}
2033 2150
 
2034 2151
 	$simpleActions = array(
2035 2152
 		'findmember',
@@ -2075,9 +2192,10 @@  discard block
 block discarded – undo
2075 2192
 
2076 2193
 	// See if theres any extra param to check.
2077 2194
 	$requiresXML = false;
2078
-	foreach ($extraParams as $key => $extra)
2079
-		if (isset($_REQUEST[$extra]))
2195
+	foreach ($extraParams as $key => $extra) {
2196
+			if (isset($_REQUEST[$extra]))
2080 2197
 			$requiresXML = true;
2198
+	}
2081 2199
 
2082 2200
 	// Output is fully XML, so no need for the index template.
2083 2201
 	if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML))
@@ -2092,37 +2210,39 @@  discard block
 block discarded – undo
2092 2210
 	{
2093 2211
 		loadLanguage('index+Modifications');
2094 2212
 		$context['template_layers'] = array();
2095
-	}
2096
-
2097
-	else
2213
+	} else
2098 2214
 	{
2099 2215
 		// Custom templates to load, or just default?
2100
-		if (isset($settings['theme_templates']))
2101
-			$templates = explode(',', $settings['theme_templates']);
2102
-		else
2103
-			$templates = array('index');
2216
+		if (isset($settings['theme_templates'])) {
2217
+					$templates = explode(',', $settings['theme_templates']);
2218
+		} else {
2219
+					$templates = array('index');
2220
+		}
2104 2221
 
2105 2222
 		// Load each template...
2106
-		foreach ($templates as $template)
2107
-			loadTemplate($template);
2223
+		foreach ($templates as $template) {
2224
+					loadTemplate($template);
2225
+		}
2108 2226
 
2109 2227
 		// ...and attempt to load their associated language files.
2110 2228
 		$required_files = implode('+', array_merge($templates, array('Modifications')));
2111 2229
 		loadLanguage($required_files, '', false);
2112 2230
 
2113 2231
 		// Custom template layers?
2114
-		if (isset($settings['theme_layers']))
2115
-			$context['template_layers'] = explode(',', $settings['theme_layers']);
2116
-		else
2117
-			$context['template_layers'] = array('html', 'body');
2232
+		if (isset($settings['theme_layers'])) {
2233
+					$context['template_layers'] = explode(',', $settings['theme_layers']);
2234
+		} else {
2235
+					$context['template_layers'] = array('html', 'body');
2236
+		}
2118 2237
 	}
2119 2238
 
2120 2239
 	// Initialize the theme.
2121 2240
 	loadSubTemplate('init', 'ignore');
2122 2241
 
2123 2242
 	// Allow overriding the board wide time/number formats.
2124
-	if (empty($user_settings['time_format']) && !empty($txt['time_format']))
2125
-		$user_info['time_format'] = $txt['time_format'];
2243
+	if (empty($user_settings['time_format']) && !empty($txt['time_format'])) {
2244
+			$user_info['time_format'] = $txt['time_format'];
2245
+	}
2126 2246
 
2127 2247
 	// Set the character set from the template.
2128 2248
 	$context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set'];
@@ -2130,12 +2250,14 @@  discard block
 block discarded – undo
2130 2250
 	$context['right_to_left'] = !empty($txt['lang_rtl']);
2131 2251
 
2132 2252
 	// Guests may still need a name.
2133
-	if ($context['user']['is_guest'] && empty($context['user']['name']))
2134
-		$context['user']['name'] = $txt['guest_title'];
2253
+	if ($context['user']['is_guest'] && empty($context['user']['name'])) {
2254
+			$context['user']['name'] = $txt['guest_title'];
2255
+	}
2135 2256
 
2136 2257
 	// Any theme-related strings that need to be loaded?
2137
-	if (!empty($settings['require_theme_strings']))
2138
-		loadLanguage('ThemeStrings', '', false);
2258
+	if (!empty($settings['require_theme_strings'])) {
2259
+			loadLanguage('ThemeStrings', '', false);
2260
+	}
2139 2261
 
2140 2262
 	// Make a special URL for the language.
2141 2263
 	$settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']);
@@ -2146,8 +2268,9 @@  discard block
 block discarded – undo
2146 2268
 	// Here is my luvly Responsive CSS
2147 2269
 	loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true, 'order_pos' => 9000), 'smf_responsive');
2148 2270
 
2149
-	if ($context['right_to_left'])
2150
-		loadCSSFile('rtl.css', array('order_pos' => 200), 'smf_rtl');
2271
+	if ($context['right_to_left']) {
2272
+			loadCSSFile('rtl.css', array('order_pos' => 200), 'smf_rtl');
2273
+	}
2151 2274
 
2152 2275
 	// We allow theme variants, because we're cool.
2153 2276
 	$context['theme_variant'] = '';
@@ -2155,14 +2278,17 @@  discard block
 block discarded – undo
2155 2278
 	if (!empty($settings['theme_variants']))
2156 2279
 	{
2157 2280
 		// Overriding - for previews and that ilk.
2158
-		if (!empty($_REQUEST['variant']))
2159
-			$_SESSION['id_variant'] = $_REQUEST['variant'];
2281
+		if (!empty($_REQUEST['variant'])) {
2282
+					$_SESSION['id_variant'] = $_REQUEST['variant'];
2283
+		}
2160 2284
 		// User selection?
2161
-		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum'))
2162
-			$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2285
+		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) {
2286
+					$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2287
+		}
2163 2288
 		// If not a user variant, select the default.
2164
-		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants']))
2165
-			$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2289
+		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) {
2290
+					$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2291
+		}
2166 2292
 
2167 2293
 		// Do this to keep things easier in the templates.
2168 2294
 		$context['theme_variant'] = '_' . $context['theme_variant'];
@@ -2171,20 +2297,23 @@  discard block
 block discarded – undo
2171 2297
 		if (!empty($context['theme_variant']))
2172 2298
 		{
2173 2299
 			loadCSSFile('index' . $context['theme_variant'] . '.css', array('order_pos' => 300), 'smf_index' . $context['theme_variant']);
2174
-			if ($context['right_to_left'])
2175
-				loadCSSFile('rtl' . $context['theme_variant'] . '.css', array('order_pos' => 400), 'smf_rtl' . $context['theme_variant']);
2300
+			if ($context['right_to_left']) {
2301
+							loadCSSFile('rtl' . $context['theme_variant'] . '.css', array('order_pos' => 400), 'smf_rtl' . $context['theme_variant']);
2302
+			}
2176 2303
 		}
2177 2304
 	}
2178 2305
 
2179 2306
 	// Let's be compatible with old themes!
2180
-	if (!function_exists('template_html_above') && in_array('html', $context['template_layers']))
2181
-		$context['template_layers'] = array('main');
2307
+	if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) {
2308
+			$context['template_layers'] = array('main');
2309
+	}
2182 2310
 
2183 2311
 	$context['tabindex'] = 1;
2184 2312
 
2185 2313
 	// Compatibility.
2186
-	if (!isset($settings['theme_version']))
2187
-		$modSettings['memberCount'] = $modSettings['totalMembers'];
2314
+	if (!isset($settings['theme_version'])) {
2315
+			$modSettings['memberCount'] = $modSettings['totalMembers'];
2316
+	}
2188 2317
 
2189 2318
 	// Default JS variables for use in every theme
2190 2319
 	$context['javascript_vars'] = array(
@@ -2203,18 +2332,18 @@  discard block
 block discarded – undo
2203 2332
 	);
2204 2333
 
2205 2334
 	// Add the JQuery library to the list of files to load.
2206
-	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn')
2207
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2208
-
2209
-	elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local')
2210
-		loadJavaScriptFile('jquery-3.2.1.min.js', array('seed' => false), 'smf_jquery');
2211
-
2212
-	elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom')
2213
-		loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2335
+	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') {
2336
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2337
+	} elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') {
2338
+			loadJavaScriptFile('jquery-3.2.1.min.js', array('seed' => false), 'smf_jquery');
2339
+	} elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') {
2340
+			loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2341
+	}
2214 2342
 
2215 2343
 	// Auto loading? template_javascript() will take care of the local half of this.
2216
-	else
2217
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2344
+	else {
2345
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array('external' => true), 'smf_jquery');
2346
+	}
2218 2347
 
2219 2348
 	// Queue our JQuery plugins!
2220 2349
 	loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins');
@@ -2237,12 +2366,12 @@  discard block
 block discarded – undo
2237 2366
 			require_once($sourcedir . '/ScheduledTasks.php');
2238 2367
 
2239 2368
 			// What to do, what to do?!
2240
-			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time())
2241
-				AutoTask();
2242
-			else
2243
-				ReduceMailQueue();
2244
-		}
2245
-		else
2369
+			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) {
2370
+							AutoTask();
2371
+			} else {
2372
+							ReduceMailQueue();
2373
+			}
2374
+		} else
2246 2375
 		{
2247 2376
 			$type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq';
2248 2377
 			$ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time'];
@@ -2293,8 +2422,9 @@  discard block
 block discarded – undo
2293 2422
 		foreach ($theme_includes as $include)
2294 2423
 		{
2295 2424
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
2296
-			if (file_exists($include))
2297
-				require_once($include);
2425
+			if (file_exists($include)) {
2426
+							require_once($include);
2427
+			}
2298 2428
 		}
2299 2429
 	}
2300 2430
 
@@ -2324,16 +2454,19 @@  discard block
 block discarded – undo
2324 2454
 	// Do any style sheets first, cause we're easy with those.
2325 2455
 	if (!empty($style_sheets))
2326 2456
 	{
2327
-		if (!is_array($style_sheets))
2328
-			$style_sheets = array($style_sheets);
2457
+		if (!is_array($style_sheets)) {
2458
+					$style_sheets = array($style_sheets);
2459
+		}
2329 2460
 
2330
-		foreach ($style_sheets as $sheet)
2331
-			loadCSSFile($sheet . '.css', array(), $sheet);
2461
+		foreach ($style_sheets as $sheet) {
2462
+					loadCSSFile($sheet . '.css', array(), $sheet);
2463
+		}
2332 2464
 	}
2333 2465
 
2334 2466
 	// No template to load?
2335
-	if ($template_name === false)
2336
-		return true;
2467
+	if ($template_name === false) {
2468
+			return true;
2469
+	}
2337 2470
 
2338 2471
 	$loaded = false;
2339 2472
 	foreach ($settings['template_dirs'] as $template_dir)
@@ -2348,12 +2481,14 @@  discard block
 block discarded – undo
2348 2481
 
2349 2482
 	if ($loaded)
2350 2483
 	{
2351
-		if ($db_show_debug === true)
2352
-			$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2484
+		if ($db_show_debug === true) {
2485
+					$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2486
+		}
2353 2487
 
2354 2488
 		// If they have specified an initialization function for this template, go ahead and call it now.
2355
-		if (function_exists('template_' . $template_name . '_init'))
2356
-			call_user_func('template_' . $template_name . '_init');
2489
+		if (function_exists('template_' . $template_name . '_init')) {
2490
+					call_user_func('template_' . $template_name . '_init');
2491
+		}
2357 2492
 	}
2358 2493
 	// Hmmm... doesn't exist?!  I don't suppose the directory is wrong, is it?
2359 2494
 	elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default'))
@@ -2373,13 +2508,14 @@  discard block
 block discarded – undo
2373 2508
 		loadTemplate($template_name);
2374 2509
 	}
2375 2510
 	// Cause an error otherwise.
2376
-	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal)
2377
-		fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2378
-	elseif ($fatal)
2379
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2380
-	else
2381
-		return false;
2382
-}
2511
+	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) {
2512
+			fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2513
+	} elseif ($fatal) {
2514
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2515
+	} else {
2516
+			return false;
2517
+	}
2518
+	}
2383 2519
 
2384 2520
 /**
2385 2521
  * Load a sub-template.
@@ -2397,17 +2533,19 @@  discard block
 block discarded – undo
2397 2533
 {
2398 2534
 	global $context, $txt, $db_show_debug;
2399 2535
 
2400
-	if ($db_show_debug === true)
2401
-		$context['debug']['sub_templates'][] = $sub_template_name;
2536
+	if ($db_show_debug === true) {
2537
+			$context['debug']['sub_templates'][] = $sub_template_name;
2538
+	}
2402 2539
 
2403 2540
 	// Figure out what the template function is named.
2404 2541
 	$theme_function = 'template_' . $sub_template_name;
2405
-	if (function_exists($theme_function))
2406
-		$theme_function();
2407
-	elseif ($fatal === false)
2408
-		fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2409
-	elseif ($fatal !== 'ignore')
2410
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2542
+	if (function_exists($theme_function)) {
2543
+			$theme_function();
2544
+	} elseif ($fatal === false) {
2545
+			fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2546
+	} elseif ($fatal !== 'ignore') {
2547
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2548
+	}
2411 2549
 
2412 2550
 	// Are we showing debugging for templates?  Just make sure not to do it before the doctype...
2413 2551
 	if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml']))
@@ -2437,8 +2575,9 @@  discard block
 block discarded – undo
2437 2575
 {
2438 2576
 	global $settings, $context, $modSettings;
2439 2577
 
2440
-	if (empty($context['css_files_order']))
2441
-		$context['css_files_order'] = array();
2578
+	if (empty($context['css_files_order'])) {
2579
+			$context['css_files_order'] = array();
2580
+	}
2442 2581
 
2443 2582
 	$params['seed'] = (!array_key_exists('seed', $params) || (array_key_exists('seed', $params) && $params['seed'] === true)) ? (array_key_exists('browser_cache', $modSettings) ? $modSettings['browser_cache'] : '') : (is_string($params['seed']) ? ($params['seed'] = $params['seed'][0] === '?' ? $params['seed'] : '?' . $params['seed']) : '');
2444 2583
 	$params['force_current'] = isset($params['force_current']) ? $params['force_current'] : false;
@@ -2449,8 +2588,9 @@  discard block
 block discarded – undo
2449 2588
 	$params['order_pos'] = isset($params['order_pos']) ? (int) $params['order_pos'] : 3000;
2450 2589
 
2451 2590
 	// If this is an external file, automatically set this to false.
2452
-	if (!empty($params['external']))
2453
-		$params['minimize'] = false;
2591
+	if (!empty($params['external'])) {
2592
+			$params['minimize'] = false;
2593
+	}
2454 2594
 
2455 2595
 	// Account for shorthand like admin.css?alp21 filenames
2456 2596
 	$has_seed = strpos($fileName, '.css?');
@@ -2467,16 +2607,12 @@  discard block
 block discarded – undo
2467 2607
 			{
2468 2608
 				$fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2469 2609
 				$filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2470
-			}
2471
-
2472
-			else
2610
+			} else
2473 2611
 			{
2474 2612
 				$fileUrl = false;
2475 2613
 				$filePath = false;
2476 2614
 			}
2477
-		}
2478
-
2479
-		else
2615
+		} else
2480 2616
 		{
2481 2617
 			$fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2482 2618
 			$filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2494,16 +2630,18 @@  discard block
 block discarded – undo
2494 2630
 	if (!empty($fileName))
2495 2631
 	{
2496 2632
 		// find a free number/position
2497
-		while (isset($context['css_files_order'][$params['order_pos']]))
2498
-			$params['order_pos']++;
2633
+		while (isset($context['css_files_order'][$params['order_pos']])) {
2634
+					$params['order_pos']++;
2635
+		}
2499 2636
 		$context['css_files_order'][$params['order_pos']] = $id;
2500 2637
 
2501 2638
 		$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2502 2639
 	}
2503 2640
 
2504
-	if (!empty($context['right_to_left']) && !empty($params['rtl']))
2505
-		loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2506
-}
2641
+	if (!empty($context['right_to_left']) && !empty($params['rtl'])) {
2642
+			loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2643
+	}
2644
+	}
2507 2645
 
2508 2646
 /**
2509 2647
  * Add a block of inline css code to be executed later
@@ -2520,8 +2658,9 @@  discard block
 block discarded – undo
2520 2658
 	global $context;
2521 2659
 
2522 2660
 	// Gotta add something...
2523
-	if (empty($css))
2524
-		return false;
2661
+	if (empty($css)) {
2662
+			return false;
2663
+	}
2525 2664
 
2526 2665
 	$context['css_header'][] = $css;
2527 2666
 }
@@ -2557,8 +2696,9 @@  discard block
 block discarded – undo
2557 2696
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2558 2697
 
2559 2698
 	// If this is an external file, automatically set this to false.
2560
-	if (!empty($params['external']))
2561
-		$params['minimize'] = false;
2699
+	if (!empty($params['external'])) {
2700
+			$params['minimize'] = false;
2701
+	}
2562 2702
 
2563 2703
 	// Account for shorthand like admin.js?alp21 filenames
2564 2704
 	$has_seed = strpos($fileName, '.js?');
@@ -2575,16 +2715,12 @@  discard block
 block discarded – undo
2575 2715
 			{
2576 2716
 				$fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2577 2717
 				$filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2578
-			}
2579
-
2580
-			else
2718
+			} else
2581 2719
 			{
2582 2720
 				$fileUrl = false;
2583 2721
 				$filePath = false;
2584 2722
 			}
2585
-		}
2586
-
2587
-		else
2723
+		} else
2588 2724
 		{
2589 2725
 			$fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2590 2726
 			$filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2599,9 +2735,10 @@  discard block
 block discarded – undo
2599 2735
 	}
2600 2736
 
2601 2737
 	// Add it to the array for use in the template
2602
-	if (!empty($fileName))
2603
-		$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2604
-}
2738
+	if (!empty($fileName)) {
2739
+			$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2740
+	}
2741
+	}
2605 2742
 
2606 2743
 /**
2607 2744
  * Add a Javascript variable for output later (for feeding text strings and similar to JS)
@@ -2615,9 +2752,10 @@  discard block
 block discarded – undo
2615 2752
 {
2616 2753
 	global $context;
2617 2754
 
2618
-	if (!empty($key) && (!empty($value) || $value === '0'))
2619
-		$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2620
-}
2755
+	if (!empty($key) && (!empty($value) || $value === '0')) {
2756
+			$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2757
+	}
2758
+	}
2621 2759
 
2622 2760
 /**
2623 2761
  * Add a block of inline Javascript code to be executed later
@@ -2634,8 +2772,9 @@  discard block
 block discarded – undo
2634 2772
 {
2635 2773
 	global $context;
2636 2774
 
2637
-	if (empty($javascript))
2638
-		return false;
2775
+	if (empty($javascript)) {
2776
+			return false;
2777
+	}
2639 2778
 
2640 2779
 	$context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript;
2641 2780
 }
@@ -2656,15 +2795,18 @@  discard block
 block discarded – undo
2656 2795
 	static $already_loaded = array();
2657 2796
 
2658 2797
 	// Default to the user's language.
2659
-	if ($lang == '')
2660
-		$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2798
+	if ($lang == '') {
2799
+			$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2800
+	}
2661 2801
 
2662 2802
 	// Do we want the English version of language file as fallback?
2663
-	if (empty($modSettings['disable_language_fallback']) && $lang != 'english')
2664
-		loadLanguage($template_name, 'english', false);
2803
+	if (empty($modSettings['disable_language_fallback']) && $lang != 'english') {
2804
+			loadLanguage($template_name, 'english', false);
2805
+	}
2665 2806
 
2666
-	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang)
2667
-		return $lang;
2807
+	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) {
2808
+			return $lang;
2809
+	}
2668 2810
 
2669 2811
 	// Make sure we have $settings - if not we're in trouble and need to find it!
2670 2812
 	if (empty($settings['default_theme_dir']))
@@ -2675,8 +2817,9 @@  discard block
 block discarded – undo
2675 2817
 
2676 2818
 	// What theme are we in?
2677 2819
 	$theme_name = basename($settings['theme_url']);
2678
-	if (empty($theme_name))
2679
-		$theme_name = 'unknown';
2820
+	if (empty($theme_name)) {
2821
+			$theme_name = 'unknown';
2822
+	}
2680 2823
 
2681 2824
 	// For each file open it up and write it out!
2682 2825
 	foreach (explode('+', $template_name) as $template)
@@ -2718,8 +2861,9 @@  discard block
 block discarded – undo
2718 2861
 				$found = true;
2719 2862
 
2720 2863
 				// setlocale is required for basename() & pathinfo() to work properly on the selected language
2721
-				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set']))
2722
-					setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2864
+				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) {
2865
+									setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2866
+				}
2723 2867
 
2724 2868
 				break;
2725 2869
 			}
@@ -2759,8 +2903,9 @@  discard block
 block discarded – undo
2759 2903
 	}
2760 2904
 
2761 2905
 	// Keep track of what we're up to soldier.
2762
-	if ($db_show_debug === true)
2763
-		$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2906
+	if ($db_show_debug === true) {
2907
+			$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2908
+	}
2764 2909
 
2765 2910
 	// Remember what we have loaded, and in which language.
2766 2911
 	$already_loaded[$template_name] = $lang;
@@ -2806,8 +2951,9 @@  discard block
 block discarded – undo
2806 2951
 				)
2807 2952
 			);
2808 2953
 			// In the EXTREMELY unlikely event this happens, give an error message.
2809
-			if ($smcFunc['db_num_rows']($result) == 0)
2810
-				fatal_lang_error('parent_not_found', 'critical');
2954
+			if ($smcFunc['db_num_rows']($result) == 0) {
2955
+							fatal_lang_error('parent_not_found', 'critical');
2956
+			}
2811 2957
 			while ($row = $smcFunc['db_fetch_assoc']($result))
2812 2958
 			{
2813 2959
 				if (!isset($boards[$row['id_board']]))
@@ -2824,8 +2970,8 @@  discard block
 block discarded – undo
2824 2970
 					);
2825 2971
 				}
2826 2972
 				// If a moderator exists for this board, add that moderator for all children too.
2827
-				if (!empty($row['id_moderator']))
2828
-					foreach ($boards as $id => $dummy)
2973
+				if (!empty($row['id_moderator'])) {
2974
+									foreach ($boards as $id => $dummy)
2829 2975
 					{
2830 2976
 						$boards[$id]['moderators'][$row['id_moderator']] = array(
2831 2977
 							'id' => $row['id_moderator'],
@@ -2833,11 +2979,12 @@  discard block
 block discarded – undo
2833 2979
 							'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
2834 2980
 							'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
2835 2981
 						);
2982
+				}
2836 2983
 					}
2837 2984
 
2838 2985
 				// If a moderator group exists for this board, add that moderator group for all children too
2839
-				if (!empty($row['id_moderator_group']))
2840
-					foreach ($boards as $id => $dummy)
2986
+				if (!empty($row['id_moderator_group'])) {
2987
+									foreach ($boards as $id => $dummy)
2841 2988
 					{
2842 2989
 						$boards[$id]['moderator_groups'][$row['id_moderator_group']] = array(
2843 2990
 							'id' => $row['id_moderator_group'],
@@ -2845,6 +2992,7 @@  discard block
 block discarded – undo
2845 2992
 							'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
2846 2993
 							'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
2847 2994
 						);
2995
+				}
2848 2996
 					}
2849 2997
 			}
2850 2998
 			$smcFunc['db_free_result']($result);
@@ -2871,23 +3019,27 @@  discard block
 block discarded – undo
2871 3019
 	if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null)
2872 3020
 	{
2873 3021
 		// If we don't have our ucwords function defined yet, let's load the settings data.
2874
-		if (empty($smcFunc['ucwords']))
2875
-			reloadSettings();
3022
+		if (empty($smcFunc['ucwords'])) {
3023
+					reloadSettings();
3024
+		}
2876 3025
 
2877 3026
 		// If we don't have our theme information yet, let's get it.
2878
-		if (empty($settings['default_theme_dir']))
2879
-			loadTheme(0, false);
3027
+		if (empty($settings['default_theme_dir'])) {
3028
+					loadTheme(0, false);
3029
+		}
2880 3030
 
2881 3031
 		// Default language directories to try.
2882 3032
 		$language_directories = array(
2883 3033
 			$settings['default_theme_dir'] . '/languages',
2884 3034
 		);
2885
-		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir'])
2886
-			$language_directories[] = $settings['actual_theme_dir'] . '/languages';
3035
+		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) {
3036
+					$language_directories[] = $settings['actual_theme_dir'] . '/languages';
3037
+		}
2887 3038
 
2888 3039
 		// We possibly have a base theme directory.
2889
-		if (!empty($settings['base_theme_dir']))
2890
-			$language_directories[] = $settings['base_theme_dir'] . '/languages';
3040
+		if (!empty($settings['base_theme_dir'])) {
3041
+					$language_directories[] = $settings['base_theme_dir'] . '/languages';
3042
+		}
2891 3043
 
2892 3044
 		// Remove any duplicates.
2893 3045
 		$language_directories = array_unique($language_directories);
@@ -2901,20 +3053,21 @@  discard block
 block discarded – undo
2901 3053
 		foreach ($language_directories as $language_dir)
2902 3054
 		{
2903 3055
 			// Can't look in here... doesn't exist!
2904
-			if (!file_exists($language_dir))
2905
-				continue;
3056
+			if (!file_exists($language_dir)) {
3057
+							continue;
3058
+			}
2906 3059
 
2907 3060
 			$dir = dir($language_dir);
2908 3061
 			while ($entry = $dir->read())
2909 3062
 			{
2910 3063
 				// Look for the index language file... For good measure skip any "index.language-utf8.php" files
2911
-				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches))
2912
-					continue;
2913
-
2914
-				if (!empty($langList) && !empty($langList[$matches[1]]))
2915
-					$langName = $langList[$matches[1]];
3064
+				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) {
3065
+									continue;
3066
+				}
2916 3067
 
2917
-				else
3068
+				if (!empty($langList) && !empty($langList[$matches[1]])) {
3069
+									$langName = $langList[$matches[1]];
3070
+				} else
2918 3071
 				{
2919 3072
 					$langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' ')));
2920 3073
 
@@ -2955,12 +3108,14 @@  discard block
 block discarded – undo
2955 3108
 		}
2956 3109
 
2957 3110
 		// Do we need to store the lang list?
2958
-		if (empty($langList))
2959
-			updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3111
+		if (empty($langList)) {
3112
+					updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3113
+		}
2960 3114
 
2961 3115
 		// Let's cash in on this deal.
2962
-		if (!empty($modSettings['cache_enable']))
2963
-			cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3116
+		if (!empty($modSettings['cache_enable'])) {
3117
+					cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3118
+		}
2964 3119
 	}
2965 3120
 
2966 3121
 	return $context['languages'];
@@ -2983,8 +3138,9 @@  discard block
 block discarded – undo
2983 3138
 	global $modSettings, $options, $txt;
2984 3139
 	static $censor_vulgar = null, $censor_proper;
2985 3140
 
2986
-	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '')
2987
-		return $text;
3141
+	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') {
3142
+			return $text;
3143
+	}
2988 3144
 
2989 3145
 	// If they haven't yet been loaded, load them.
2990 3146
 	if ($censor_vulgar == null)
@@ -3015,9 +3171,9 @@  discard block
 block discarded – undo
3015 3171
 	{
3016 3172
 		$func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace';
3017 3173
 		$text = $func($censor_vulgar, $censor_proper, $text);
3174
+	} else {
3175
+			$text = preg_replace($censor_vulgar, $censor_proper, $text);
3018 3176
 	}
3019
-	else
3020
-		$text = preg_replace($censor_vulgar, $censor_proper, $text);
3021 3177
 
3022 3178
 	return $text;
3023 3179
 }
@@ -3043,38 +3199,42 @@  discard block
 block discarded – undo
3043 3199
 	@ini_set('track_errors', '1');
3044 3200
 
3045 3201
 	// Don't include the file more than once, if $once is true.
3046
-	if ($once && in_array($filename, $templates))
3047
-		return;
3202
+	if ($once && in_array($filename, $templates)) {
3203
+			return;
3204
+	}
3048 3205
 	// Add this file to the include list, whether $once is true or not.
3049
-	else
3050
-		$templates[] = $filename;
3206
+	else {
3207
+			$templates[] = $filename;
3208
+	}
3051 3209
 
3052 3210
 	// Are we going to use eval?
3053 3211
 	if (empty($modSettings['disableTemplateEval']))
3054 3212
 	{
3055 3213
 		$file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false;
3056 3214
 		$settings['current_include_filename'] = $filename;
3057
-	}
3058
-	else
3215
+	} else
3059 3216
 	{
3060 3217
 		$file_found = file_exists($filename);
3061 3218
 
3062
-		if ($once && $file_found)
3063
-			require_once($filename);
3064
-		elseif ($file_found)
3065
-			require($filename);
3219
+		if ($once && $file_found) {
3220
+					require_once($filename);
3221
+		} elseif ($file_found) {
3222
+					require($filename);
3223
+		}
3066 3224
 	}
3067 3225
 
3068 3226
 	if ($file_found !== true)
3069 3227
 	{
3070 3228
 		ob_end_clean();
3071
-		if (!empty($modSettings['enableCompressedOutput']))
3072
-			@ob_start('ob_gzhandler');
3073
-		else
3074
-			ob_start();
3229
+		if (!empty($modSettings['enableCompressedOutput'])) {
3230
+					@ob_start('ob_gzhandler');
3231
+		} else {
3232
+					ob_start();
3233
+		}
3075 3234
 
3076
-		if (isset($_GET['debug']))
3077
-			header('content-type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3235
+		if (isset($_GET['debug'])) {
3236
+					header('content-type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3237
+		}
3078 3238
 
3079 3239
 		// Don't cache error pages!!
3080 3240
 		header('expires: Mon, 26 Jul 1997 05:00:00 GMT');
@@ -3093,12 +3253,13 @@  discard block
 block discarded – undo
3093 3253
 		echo '<!DOCTYPE html>
3094 3254
 <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '>
3095 3255
 	<head>';
3096
-		if (isset($context['character_set']))
3097
-			echo '
3256
+		if (isset($context['character_set'])) {
3257
+					echo '
3098 3258
 		<meta charset="', $context['character_set'], '">';
3259
+		}
3099 3260
 
3100
-		if (!empty($maintenance) && !allowedTo('admin_forum'))
3101
-			echo '
3261
+		if (!empty($maintenance) && !allowedTo('admin_forum')) {
3262
+					echo '
3102 3263
 		<title>', $mtitle, '</title>
3103 3264
 	</head>
3104 3265
 	<body>
@@ -3106,8 +3267,8 @@  discard block
 block discarded – undo
3106 3267
 		', $mmessage, '
3107 3268
 	</body>
3108 3269
 </html>';
3109
-		elseif (!allowedTo('admin_forum'))
3110
-			echo '
3270
+		} elseif (!allowedTo('admin_forum')) {
3271
+					echo '
3111 3272
 		<title>', $txt['template_parse_error'], '</title>
3112 3273
 	</head>
3113 3274
 	<body>
@@ -3115,14 +3276,16 @@  discard block
 block discarded – undo
3115 3276
 		', $txt['template_parse_error_message'], '
3116 3277
 	</body>
3117 3278
 </html>';
3118
-		else
3279
+		} else
3119 3280
 		{
3120 3281
 			$error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3121 3282
 			$error_array = error_get_last();
3122
-			if (empty($error) && ini_get('track_errors') && !empty($error_array))
3123
-				$error = $error_array['message'];
3124
-			if (empty($error))
3125
-				$error = $txt['template_parse_errmsg'];
3283
+			if (empty($error) && ini_get('track_errors') && !empty($error_array)) {
3284
+							$error = $error_array['message'];
3285
+			}
3286
+			if (empty($error)) {
3287
+							$error = $txt['template_parse_errmsg'];
3288
+			}
3126 3289
 
3127 3290
 			$error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>'));
3128 3291
 
@@ -3133,11 +3296,12 @@  discard block
 block discarded – undo
3133 3296
 		<h3>', $txt['template_parse_error'], '</h3>
3134 3297
 		', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3135 3298
 
3136
-			if (!empty($error))
3137
-				echo '
3299
+			if (!empty($error)) {
3300
+							echo '
3138 3301
 		<hr>
3139 3302
 
3140 3303
 		<div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>';
3304
+			}
3141 3305
 
3142 3306
 			// I know, I know... this is VERY COMPLICATED.  Still, it's good.
3143 3307
 			if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0)
@@ -3147,10 +3311,11 @@  discard block
 block discarded – undo
3147 3311
 				$data2 = preg_split('~\<br( /)?\>~', $data2);
3148 3312
 
3149 3313
 				// Fix the PHP code stuff...
3150
-				if (!isBrowser('gecko'))
3151
-					$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3152
-				else
3153
-					$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3314
+				if (!isBrowser('gecko')) {
3315
+									$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3316
+				} else {
3317
+									$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3318
+				}
3154 3319
 
3155 3320
 				// Now we get to work around a bug in PHP where it doesn't escape <br>s!
3156 3321
 				$j = -1;
@@ -3158,8 +3323,9 @@  discard block
 block discarded – undo
3158 3323
 				{
3159 3324
 					$j++;
3160 3325
 
3161
-					if (substr_count($line, '<br>') == 0)
3162
-						continue;
3326
+					if (substr_count($line, '<br>') == 0) {
3327
+											continue;
3328
+					}
3163 3329
 
3164 3330
 					$n = substr_count($line, '<br>');
3165 3331
 					for ($i = 0; $i < $n; $i++)
@@ -3178,38 +3344,42 @@  discard block
 block discarded – undo
3178 3344
 				// Figure out what the color coding was before...
3179 3345
 				$line = max($match[1] - 9, 1);
3180 3346
 				$last_line = '';
3181
-				for ($line2 = $line - 1; $line2 > 1; $line2--)
3182
-					if (strpos($data2[$line2], '<') !== false)
3347
+				for ($line2 = $line - 1; $line2 > 1; $line2--) {
3348
+									if (strpos($data2[$line2], '<') !== false)
3183 3349
 					{
3184 3350
 						if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0)
3185 3351
 							$last_line = $color_match[1];
3352
+				}
3186 3353
 						break;
3187 3354
 					}
3188 3355
 
3189 3356
 				// Show the relevant lines...
3190 3357
 				for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++)
3191 3358
 				{
3192
-					if ($line == $match[1])
3193
-						echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3359
+					if ($line == $match[1]) {
3360
+											echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3361
+					}
3194 3362
 
3195 3363
 					echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> ';
3196
-					if (isset($data2[$line]) && $data2[$line] != '')
3197
-						echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3364
+					if (isset($data2[$line]) && $data2[$line] != '') {
3365
+											echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3366
+					}
3198 3367
 
3199 3368
 					if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0)
3200 3369
 					{
3201 3370
 						$last_line = $color_match[1];
3202 3371
 						echo '</', substr($last_line, 1, 4), '>';
3372
+					} elseif ($last_line != '' && strpos($data2[$line], '<') !== false) {
3373
+											$last_line = '';
3374
+					} elseif ($last_line != '' && $data2[$line] != '') {
3375
+											echo '</', substr($last_line, 1, 4), '>';
3203 3376
 					}
3204
-					elseif ($last_line != '' && strpos($data2[$line], '<') !== false)
3205
-						$last_line = '';
3206
-					elseif ($last_line != '' && $data2[$line] != '')
3207
-						echo '</', substr($last_line, 1, 4), '>';
3208 3377
 
3209
-					if ($line == $match[1])
3210
-						echo '</pre></div><pre style="margin: 0;">';
3211
-					else
3212
-						echo "\n";
3378
+					if ($line == $match[1]) {
3379
+											echo '</pre></div><pre style="margin: 0;">';
3380
+					} else {
3381
+											echo "\n";
3382
+					}
3213 3383
 				}
3214 3384
 
3215 3385
 				echo '</pre></div>';
@@ -3233,8 +3403,9 @@  discard block
 block discarded – undo
3233 3403
 	global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port;
3234 3404
 
3235 3405
 	// Figure out what type of database we are using.
3236
-	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
3237
-		$db_type = 'mysql';
3406
+	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) {
3407
+			$db_type = 'mysql';
3408
+	}
3238 3409
 
3239 3410
 	// Load the file for the database.
3240 3411
 	require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
@@ -3242,8 +3413,9 @@  discard block
 block discarded – undo
3242 3413
 	$db_options = array();
3243 3414
 
3244 3415
 	// Add in the port if needed
3245
-	if (!empty($db_port))
3246
-		$db_options['port'] = $db_port;
3416
+	if (!empty($db_port)) {
3417
+			$db_options['port'] = $db_port;
3418
+	}
3247 3419
 
3248 3420
 	// If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use.
3249 3421
 	if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd))
@@ -3262,13 +3434,15 @@  discard block
 block discarded – undo
3262 3434
 	}
3263 3435
 
3264 3436
 	// Safe guard here, if there isn't a valid connection lets put a stop to it.
3265
-	if (!$db_connection)
3266
-		display_db_error();
3437
+	if (!$db_connection) {
3438
+			display_db_error();
3439
+	}
3267 3440
 
3268 3441
 	// If in SSI mode fix up the prefix.
3269
-	if (SMF == 'SSI')
3270
-		db_fix_prefix($db_prefix, $db_name);
3271
-}
3442
+	if (SMF == 'SSI') {
3443
+			db_fix_prefix($db_prefix, $db_name);
3444
+	}
3445
+	}
3272 3446
 
3273 3447
 /**
3274 3448
  * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it.
@@ -3282,10 +3456,11 @@  discard block
 block discarded – undo
3282 3456
 	global $sourcedir, $cacheAPI, $cache_accelerator;
3283 3457
 
3284 3458
 	// Not overriding this and we have a cacheAPI, send it back.
3285
-	if (empty($overrideCache) && is_object($cacheAPI))
3286
-		return $cacheAPI;
3287
-	elseif (is_null($cacheAPI))
3288
-		$cacheAPI = false;
3459
+	if (empty($overrideCache) && is_object($cacheAPI)) {
3460
+			return $cacheAPI;
3461
+	} elseif (is_null($cacheAPI)) {
3462
+			$cacheAPI = false;
3463
+	}
3289 3464
 
3290 3465
 	// Make sure our class is in session.
3291 3466
 	require_once($sourcedir . '/Class-CacheAPI.php');
@@ -3306,8 +3481,9 @@  discard block
 block discarded – undo
3306 3481
 		if (!$testAPI->isSupported())
3307 3482
 		{
3308 3483
 			// Can we save ourselves?
3309
-			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf')
3310
-				return loadCacheAccelerator(null, false);
3484
+			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') {
3485
+							return loadCacheAccelerator(null, false);
3486
+			}
3311 3487
 			return false;
3312 3488
 		}
3313 3489
 
@@ -3319,9 +3495,9 @@  discard block
 block discarded – undo
3319 3495
 		{
3320 3496
 			$cacheAPI = $testAPI;
3321 3497
 			return $cacheAPI;
3498
+		} else {
3499
+					return $testAPI;
3322 3500
 		}
3323
-		else
3324
-			return $testAPI;
3325 3501
 	}
3326 3502
 }
3327 3503
 
@@ -3341,8 +3517,9 @@  discard block
 block discarded – undo
3341 3517
 
3342 3518
 	// @todo Why are we doing this if caching is disabled?
3343 3519
 
3344
-	if (function_exists('call_integration_hook'))
3345
-		call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3520
+	if (function_exists('call_integration_hook')) {
3521
+			call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3522
+	}
3346 3523
 
3347 3524
 	/* Refresh the cache if either:
3348 3525
 		1. Caching is disabled.
@@ -3356,16 +3533,19 @@  discard block
 block discarded – undo
3356 3533
 		require_once($sourcedir . '/' . $file);
3357 3534
 		$cache_block = call_user_func_array($function, $params);
3358 3535
 
3359
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level)
3360
-			cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3536
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) {
3537
+					cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3538
+		}
3361 3539
 	}
3362 3540
 
3363 3541
 	// Some cached data may need a freshening up after retrieval.
3364
-	if (!empty($cache_block['post_retri_eval']))
3365
-		eval($cache_block['post_retri_eval']);
3542
+	if (!empty($cache_block['post_retri_eval'])) {
3543
+			eval($cache_block['post_retri_eval']);
3544
+	}
3366 3545
 
3367
-	if (function_exists('call_integration_hook'))
3368
-		call_integration_hook('post_cache_quick_get', array(&$cache_block));
3546
+	if (function_exists('call_integration_hook')) {
3547
+			call_integration_hook('post_cache_quick_get', array(&$cache_block));
3548
+	}
3369 3549
 
3370 3550
 	return $cache_block['data'];
3371 3551
 }
@@ -3392,8 +3572,9 @@  discard block
 block discarded – undo
3392 3572
 	global $smcFunc, $cache_enable, $cacheAPI;
3393 3573
 	global $cache_hits, $cache_count, $db_show_debug;
3394 3574
 
3395
-	if (empty($cache_enable) || empty($cacheAPI))
3396
-		return;
3575
+	if (empty($cache_enable) || empty($cacheAPI)) {
3576
+			return;
3577
+	}
3397 3578
 
3398 3579
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3399 3580
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3406,12 +3587,14 @@  discard block
 block discarded – undo
3406 3587
 	$value = $value === null ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_encode']($value) : json_encode($value));
3407 3588
 	$cacheAPI->putData($key, $value, $ttl);
3408 3589
 
3409
-	if (function_exists('call_integration_hook'))
3410
-		call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3590
+	if (function_exists('call_integration_hook')) {
3591
+			call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3592
+	}
3411 3593
 
3412
-	if (isset($db_show_debug) && $db_show_debug === true)
3413
-		$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3414
-}
3594
+	if (isset($db_show_debug) && $db_show_debug === true) {
3595
+			$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3596
+	}
3597
+	}
3415 3598
 
3416 3599
 /**
3417 3600
  * Gets the value from the cache specified by key, so long as it is not older than ttl seconds.
@@ -3427,8 +3610,9 @@  discard block
 block discarded – undo
3427 3610
 	global $smcFunc, $cache_enable, $cacheAPI;
3428 3611
 	global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug;
3429 3612
 
3430
-	if (empty($cache_enable) || empty($cacheAPI))
3431
-		return;
3613
+	if (empty($cache_enable) || empty($cacheAPI)) {
3614
+			return;
3615
+	}
3432 3616
 
3433 3617
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3434 3618
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3448,16 +3632,18 @@  discard block
 block discarded – undo
3448 3632
 
3449 3633
 		if (empty($value))
3450 3634
 		{
3451
-			if (!is_array($cache_misses))
3452
-				$cache_misses = array();
3635
+			if (!is_array($cache_misses)) {
3636
+							$cache_misses = array();
3637
+			}
3453 3638
 
3454 3639
 			$cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1;
3455 3640
 			$cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get');
3456 3641
 		}
3457 3642
 	}
3458 3643
 
3459
-	if (function_exists('call_integration_hook') && isset($value))
3460
-		call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3644
+	if (function_exists('call_integration_hook') && isset($value)) {
3645
+			call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3646
+	}
3461 3647
 
3462 3648
 	return empty($value) ? null : (isset($smcFunc['json_decode']) ? $smcFunc['json_decode']($value, true) : smf_json_decode($value, true));
3463 3649
 }
@@ -3479,8 +3665,9 @@  discard block
 block discarded – undo
3479 3665
 	global $cacheAPI;
3480 3666
 
3481 3667
 	// If we can't get to the API, can't do this.
3482
-	if (empty($cacheAPI))
3483
-		return;
3668
+	if (empty($cacheAPI)) {
3669
+			return;
3670
+	}
3484 3671
 
3485 3672
 	// Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure.
3486 3673
 	$cacheAPI->cleanCache($type);
@@ -3505,8 +3692,9 @@  discard block
 block discarded – undo
3505 3692
 	global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $user_info;
3506 3693
 
3507 3694
 	// Come on!
3508
-	if (empty($data))
3509
-		return array();
3695
+	if (empty($data)) {
3696
+			return array();
3697
+	}
3510 3698
 
3511 3699
 	// Set a nice default var.
3512 3700
 	$image = '';
@@ -3514,11 +3702,11 @@  discard block
 block discarded – undo
3514 3702
 	// Gravatar has been set as mandatory!
3515 3703
 	if (!empty($modSettings['gravatarOverride']))
3516 3704
 	{
3517
-		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://'))
3518
-			$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3519
-
3520
-		else if (!empty($data['email']))
3521
-			$image = get_gravatar_url($data['email']);
3705
+		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) {
3706
+					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3707
+		} else if (!empty($data['email'])) {
3708
+					$image = get_gravatar_url($data['email']);
3709
+		}
3522 3710
 	}
3523 3711
 
3524 3712
 	// Look if the user has a gravatar field or has set an external url as avatar.
@@ -3530,54 +3718,60 @@  discard block
 block discarded – undo
3530 3718
 			// Gravatar.
3531 3719
 			if (stristr($data['avatar'], 'gravatar://'))
3532 3720
 			{
3533
-				if ($data['avatar'] == 'gravatar://')
3534
-					$image = get_gravatar_url($data['email']);
3535
-
3536
-				elseif (!empty($modSettings['gravatarAllowExtraEmail']))
3537
-					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3721
+				if ($data['avatar'] == 'gravatar://') {
3722
+									$image = get_gravatar_url($data['email']);
3723
+				} elseif (!empty($modSettings['gravatarAllowExtraEmail'])) {
3724
+									$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3725
+				}
3538 3726
 			}
3539 3727
 
3540 3728
 			// External url.
3541 3729
 			else
3542 3730
 			{
3543 3731
 				// Using ssl?
3544
-				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false && empty($user_info['possibly_robot']))
3545
-					$image = get_proxied_url($data['avatar']);
3732
+				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false && empty($user_info['possibly_robot'])) {
3733
+									$image = get_proxied_url($data['avatar']);
3734
+				}
3546 3735
 
3547 3736
 				// Just a plain external url.
3548
-				else
3549
-					$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3737
+				else {
3738
+									$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3739
+				}
3550 3740
 			}
3551 3741
 		}
3552 3742
 
3553 3743
 		// Perhaps this user has an attachment as avatar...
3554
-		else if (!empty($data['filename']))
3555
-			$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3744
+		else if (!empty($data['filename'])) {
3745
+					$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3746
+		}
3556 3747
 
3557 3748
 		// Right... no avatar... use our default image.
3558
-		else
3559
-			$image = $modSettings['avatar_url'] . '/default.png';
3749
+		else {
3750
+					$image = $modSettings['avatar_url'] . '/default.png';
3751
+		}
3560 3752
 	}
3561 3753
 
3562 3754
 	call_integration_hook('integrate_set_avatar_data', array(&$image, &$data));
3563 3755
 
3564 3756
 	// At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed.
3565
-	if (!empty($image))
3566
-		return array(
3757
+	if (!empty($image)) {
3758
+			return array(
3567 3759
 			'name' => !empty($data['avatar']) ? $data['avatar'] : '',
3568 3760
 			'image' => '<img class="avatar" src="' . $image . '" />',
3569 3761
 			'href' => $image,
3570 3762
 			'url' => $image,
3571 3763
 		);
3764
+	}
3572 3765
 
3573 3766
 	// Fallback to make life easier for everyone...
3574
-	else
3575
-		return array(
3767
+	else {
3768
+			return array(
3576 3769
 			'name' => '',
3577 3770
 			'image' => '',
3578 3771
 			'href' => '',
3579 3772
 			'url' => '',
3580 3773
 		);
3581
-}
3774
+	}
3775
+	}
3582 3776
 
3583 3777
 ?>
3584 3778
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/ManageBoards.php 1 patch
Braces   +147 added lines, -114 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * The main dispatcher; doesn't do anything, just delegates.
@@ -92,18 +93,19 @@  discard block
 block discarded – undo
92 93
 		checkSession('get');
93 94
 		validateToken('admin-bm-' . (int) $_REQUEST['src_board'], 'request');
94 95
 
95
-		if ($_REQUEST['move_to'] === 'top')
96
-			$boardOptions = array(
96
+		if ($_REQUEST['move_to'] === 'top') {
97
+					$boardOptions = array(
97 98
 				'move_to' => $_REQUEST['move_to'],
98 99
 				'target_category' => (int) $_REQUEST['target_cat'],
99 100
 				'move_first_child' => true,
100 101
 			);
101
-		else
102
-			$boardOptions = array(
102
+		} else {
103
+					$boardOptions = array(
103 104
 				'move_to' => $_REQUEST['move_to'],
104 105
 				'target_board' => (int) $_REQUEST['target_board'],
105 106
 				'move_first_child' => true,
106 107
 			);
108
+		}
107 109
 		modifyBoard((int) $_REQUEST['src_board'], $boardOptions);
108 110
 	}
109 111
 
@@ -148,15 +150,16 @@  discard block
 block discarded – undo
148 150
 			$security = $context['session_var'] . '=' . $context['session_id'] . ';' . $context['admin-bm-' . $context['move_board'] . '_token_var'] . '=' . $context['admin-bm-' . $context['move_board'] . '_token'];
149 151
 			foreach ($boardList[$catid] as $boardid)
150 152
 			{
151
-				if (!isset($context['categories'][$catid]['move_link']))
152
-					$context['categories'][$catid]['move_link'] = array(
153
+				if (!isset($context['categories'][$catid]['move_link'])) {
154
+									$context['categories'][$catid]['move_link'] = array(
153 155
 						'child_level' => 0,
154 156
 						'label' => $txt['mboards_order_before'] . ' \'' . $smcFunc['htmlspecialchars']($boards[$boardid]['name']) . '\'',
155 157
 						'href' => $scripturl . '?action=admin;area=manageboards;sa=move;src_board=' . $context['move_board'] . ';target_board=' . $boardid . ';move_to=before;' . $security,
156 158
 					);
159
+				}
157 160
 
158
-				if (!$context['categories'][$catid]['boards'][$boardid]['move'])
159
-				$context['categories'][$catid]['boards'][$boardid]['move_links'] = array(
161
+				if (!$context['categories'][$catid]['boards'][$boardid]['move']) {
162
+								$context['categories'][$catid]['boards'][$boardid]['move_links'] = array(
160 163
 					array(
161 164
 						'child_level' => $boards[$boardid]['level'],
162 165
 						'label' => $txt['mboards_order_after'] . '\'' . $smcFunc['htmlspecialchars']($boards[$boardid]['name']) . '\'',
@@ -170,34 +173,39 @@  discard block
 block discarded – undo
170 173
 						'class' => 'here',
171 174
 					),
172 175
 				);
176
+				}
173 177
 
174 178
 				$difference = $boards[$boardid]['level'] - $prev_child_level;
175
-				if ($difference == 1)
176
-					array_push($stack, !empty($context['categories'][$catid]['boards'][$prev_board]['move_links']) ? array_shift($context['categories'][$catid]['boards'][$prev_board]['move_links']) : null);
177
-				elseif ($difference < 0)
179
+				if ($difference == 1) {
180
+									array_push($stack, !empty($context['categories'][$catid]['boards'][$prev_board]['move_links']) ? array_shift($context['categories'][$catid]['boards'][$prev_board]['move_links']) : null);
181
+				} elseif ($difference < 0)
178 182
 				{
179
-					if (empty($context['categories'][$catid]['boards'][$prev_board]['move_links']))
180
-						$context['categories'][$catid]['boards'][$prev_board]['move_links'] = array();
181
-					for ($i = 0; $i < -$difference; $i++)
182
-						if (($temp = array_pop($stack)) != null)
183
+					if (empty($context['categories'][$catid]['boards'][$prev_board]['move_links'])) {
184
+											$context['categories'][$catid]['boards'][$prev_board]['move_links'] = array();
185
+					}
186
+					for ($i = 0; $i < -$difference; $i++) {
187
+											if (($temp = array_pop($stack)) != null)
183 188
 							array_unshift($context['categories'][$catid]['boards'][$prev_board]['move_links'], $temp);
189
+					}
184 190
 				}
185 191
 
186 192
 				$prev_board = $boardid;
187 193
 				$prev_child_level = $boards[$boardid]['level'];
188 194
 
189 195
 			}
190
-			if (!empty($stack) && !empty($context['categories'][$catid]['boards'][$prev_board]['move_links']))
191
-				$context['categories'][$catid]['boards'][$prev_board]['move_links'] = array_merge($stack, $context['categories'][$catid]['boards'][$prev_board]['move_links']);
192
-			elseif (!empty($stack))
193
-				$context['categories'][$catid]['boards'][$prev_board]['move_links'] = $stack;
196
+			if (!empty($stack) && !empty($context['categories'][$catid]['boards'][$prev_board]['move_links'])) {
197
+							$context['categories'][$catid]['boards'][$prev_board]['move_links'] = array_merge($stack, $context['categories'][$catid]['boards'][$prev_board]['move_links']);
198
+			} elseif (!empty($stack)) {
199
+							$context['categories'][$catid]['boards'][$prev_board]['move_links'] = $stack;
200
+			}
194 201
 
195
-			if (empty($boardList[$catid]))
196
-				$context['categories'][$catid]['move_link'] = array(
202
+			if (empty($boardList[$catid])) {
203
+							$context['categories'][$catid]['move_link'] = array(
197 204
 					'child_level' => 0,
198 205
 					'label' => $txt['mboards_order_before'] . ' \'' . $smcFunc['htmlspecialchars']($tree['node']['name']) . '\'',
199 206
 					'href' => $scripturl . '?action=admin;area=manageboards;sa=move;src_board=' . $context['move_board'] . ';target_cat=' . $catid . ';move_to=top;' . $security,
200 207
 				);
208
+			}
201 209
 		}
202 210
 	}
203 211
 
@@ -253,9 +261,9 @@  discard block
 block discarded – undo
253 261
 		);
254 262
 	}
255 263
 	// Category doesn't exist, man... sorry.
256
-	elseif (!isset($cat_tree[$_REQUEST['cat']]))
257
-		redirectexit('action=admin;area=manageboards');
258
-	else
264
+	elseif (!isset($cat_tree[$_REQUEST['cat']])) {
265
+			redirectexit('action=admin;area=manageboards');
266
+	} else
259 267
 	{
260 268
 		$context['category'] = array(
261 269
 			'id' => $_REQUEST['cat'],
@@ -267,30 +275,31 @@  discard block
 block discarded – undo
267 275
 			'is_empty' => empty($cat_tree[$_REQUEST['cat']]['children'])
268 276
 		);
269 277
 
270
-		foreach ($boardList[$_REQUEST['cat']] as $child_board)
271
-			$context['category']['children'][] = str_repeat('-', $boards[$child_board]['level']) . ' ' . $boards[$child_board]['name'];
278
+		foreach ($boardList[$_REQUEST['cat']] as $child_board) {
279
+					$context['category']['children'][] = str_repeat('-', $boards[$child_board]['level']) . ' ' . $boards[$child_board]['name'];
280
+		}
272 281
 	}
273 282
 
274 283
 	$prevCat = 0;
275 284
 	foreach ($cat_tree as $catid => $tree)
276 285
 	{
277
-		if ($catid == $_REQUEST['cat'] && $prevCat > 0)
278
-			$context['category_order'][$prevCat]['selected'] = true;
279
-		elseif ($catid != $_REQUEST['cat'])
280
-			$context['category_order'][$catid] = array(
286
+		if ($catid == $_REQUEST['cat'] && $prevCat > 0) {
287
+					$context['category_order'][$prevCat]['selected'] = true;
288
+		} elseif ($catid != $_REQUEST['cat']) {
289
+					$context['category_order'][$catid] = array(
281 290
 				'id' => $catid,
282 291
 				'name' => $txt['mboards_order_after'] . $tree['node']['name'],
283 292
 				'selected' => false,
284 293
 				'true_name' => $tree['node']['name']
285 294
 			);
295
+		}
286 296
 		$prevCat = $catid;
287 297
 	}
288 298
 	if (!isset($_REQUEST['delete']))
289 299
 	{
290 300
 		$context['sub_template'] = 'modify_category';
291 301
 		$context['page_title'] = $_REQUEST['sa'] == 'newcat' ? $txt['mboards_new_cat_name'] : $txt['catEdit'];
292
-	}
293
-	else
302
+	} else
294 303
 	{
295 304
 		$context['sub_template'] = 'confirm_category_delete';
296 305
 		$context['page_title'] = $txt['mboards_delete_cat'];
@@ -327,8 +336,9 @@  discard block
 block discarded – undo
327 336
 	{
328 337
 		$catOptions = array();
329 338
 
330
-		if (isset($_POST['cat_order']))
331
-			$catOptions['move_after'] = (int) $_POST['cat_order'];
339
+		if (isset($_POST['cat_order'])) {
340
+					$catOptions['move_after'] = (int) $_POST['cat_order'];
341
+		}
332 342
 
333 343
 		// Change "This & That" to "This &amp; That" but don't change "&cent" to "&amp;cent;"...
334 344
 		$catOptions['cat_name'] = parse_bbc($smcFunc['htmlspecialchars']($_POST['cat_name']), false, '', $context['description_allowed_tags']);
@@ -336,10 +346,11 @@  discard block
 block discarded – undo
336 346
 
337 347
 		$catOptions['is_collapsible'] = isset($_POST['collapse']);
338 348
 
339
-		if (isset($_POST['add']))
340
-			createCategory($catOptions);
341
-		else
342
-			modifyCategory($_POST['cat'], $catOptions);
349
+		if (isset($_POST['add'])) {
350
+					createCategory($catOptions);
351
+		} else {
352
+					modifyCategory($_POST['cat'], $catOptions);
353
+		}
343 354
 	}
344 355
 	// If they want to delete - first give them confirmation.
345 356
 	elseif (isset($_POST['delete']) && !isset($_POST['confirmation']) && !isset($_POST['empty']))
@@ -353,13 +364,14 @@  discard block
 block discarded – undo
353 364
 		// First off - check if we are moving all the current boards first - before we start deleting!
354 365
 		if (isset($_POST['delete_action']) && $_POST['delete_action'] == 1)
355 366
 		{
356
-			if (empty($_POST['cat_to']))
357
-				fatal_lang_error('mboards_delete_error');
367
+			if (empty($_POST['cat_to'])) {
368
+							fatal_lang_error('mboards_delete_error');
369
+			}
358 370
 
359 371
 			deleteCategories(array($_POST['cat']), (int) $_POST['cat_to']);
372
+		} else {
373
+					deleteCategories(array($_POST['cat']));
360 374
 		}
361
-		else
362
-			deleteCategories(array($_POST['cat']));
363 375
 	}
364 376
 
365 377
 	redirectexit('action=admin;area=manageboards');
@@ -404,8 +416,9 @@  discard block
 block discarded – undo
404 416
 	if ($_REQUEST['sa'] == 'newboard')
405 417
 	{
406 418
 		// Category doesn't exist, man... sorry.
407
-		if (empty($_REQUEST['cat']))
408
-			redirectexit('action=admin;area=manageboards');
419
+		if (empty($_REQUEST['cat'])) {
420
+					redirectexit('action=admin;area=manageboards');
421
+		}
409 422
 
410 423
 		// Some things that need to be setup for a new board.
411 424
 		$curBoard = array(
@@ -429,8 +442,7 @@  discard block
 block discarded – undo
429 442
 			'category' => (int) $_REQUEST['cat'],
430 443
 			'no_children' => true,
431 444
 		);
432
-	}
433
-	else
445
+	} else
434 446
 	{
435 447
 		// Just some easy shortcuts.
436 448
 		$curBoard = &$boards[$_REQUEST['boardid']];
@@ -478,8 +490,9 @@  discard block
 block discarded – undo
478 490
 	);
479 491
 	while ($row = $smcFunc['db_fetch_assoc']($request))
480 492
 	{
481
-		if ($_REQUEST['sa'] == 'newboard' && $row['min_posts'] == -1)
482
-			$curBoard['member_groups'][] = $row['id_group'];
493
+		if ($_REQUEST['sa'] == 'newboard' && $row['min_posts'] == -1) {
494
+					$curBoard['member_groups'][] = $row['id_group'];
495
+		}
483 496
 
484 497
 		$context['groups'][(int) $row['id_group']] = array(
485 498
 			'id' => $row['id_group'],
@@ -492,8 +505,9 @@  discard block
 block discarded – undo
492 505
 	$smcFunc['db_free_result']($request);
493 506
 
494 507
 	// Category doesn't exist, man... sorry.
495
-	if (!isset($boardList[$curBoard['category']]))
496
-		redirectexit('action=admin;area=manageboards');
508
+	if (!isset($boardList[$curBoard['category']])) {
509
+			redirectexit('action=admin;area=manageboards');
510
+	}
497 511
 
498 512
 	foreach ($boardList[$curBoard['category']] as $boardid)
499 513
 	{
@@ -507,8 +521,7 @@  discard block
 block discarded – undo
507 521
 				'is_child' => false,
508 522
 				'selected' => true
509 523
 			);
510
-		}
511
-		else
524
+		} else
512 525
 		{
513 526
 			$context['board_order'][] = array(
514 527
 				'id' => $boardid,
@@ -525,19 +538,21 @@  discard block
 block discarded – undo
525 538
 		$context['can_move_children'] = false;
526 539
 		$context['children'] = $boards[$_REQUEST['boardid']]['tree']['children'];
527 540
 
528
-		foreach ($context['board_order'] as $lBoard)
529
-			if ($lBoard['is_child'] == false && $lBoard['selected'] == false)
541
+		foreach ($context['board_order'] as $lBoard) {
542
+					if ($lBoard['is_child'] == false && $lBoard['selected'] == false)
530 543
 				$context['can_move_children'] = true;
544
+		}
531 545
 	}
532 546
 
533 547
 	// Get other available categories.
534 548
 	$context['categories'] = array();
535
-	foreach ($cat_tree as $catID => $tree)
536
-		$context['categories'][] = array(
549
+	foreach ($cat_tree as $catID => $tree) {
550
+			$context['categories'][] = array(
537 551
 			'id' => $catID == $curBoard['category'] ? 0 : $catID,
538 552
 			'name' => $tree['node']['name'],
539 553
 			'selected' => $catID == $curBoard['category']
540 554
 		);
555
+	}
541 556
 
542 557
 	$request = $smcFunc['db_query']('', '
543 558
 		SELECT mem.id_member, mem.real_name
@@ -549,14 +564,16 @@  discard block
 block discarded – undo
549 564
 		)
550 565
 	);
551 566
 	$context['board']['moderators'] = array();
552
-	while ($row = $smcFunc['db_fetch_assoc']($request))
553
-		$context['board']['moderators'][$row['id_member']] = $row['real_name'];
567
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
568
+			$context['board']['moderators'][$row['id_member']] = $row['real_name'];
569
+	}
554 570
 	$smcFunc['db_free_result']($request);
555 571
 
556 572
 	$context['board']['moderator_list'] = empty($context['board']['moderators']) ? '' : '&quot;' . implode('&quot;, &quot;', $context['board']['moderators']) . '&quot;';
557 573
 
558
-	if (!empty($context['board']['moderators']))
559
-		list ($context['board']['last_moderator_id']) = array_slice(array_keys($context['board']['moderators']), -1);
574
+	if (!empty($context['board']['moderators'])) {
575
+			list ($context['board']['last_moderator_id']) = array_slice(array_keys($context['board']['moderators']), -1);
576
+	}
560 577
 
561 578
 	// Get all the groups assigned as moderators
562 579
 	$request = $smcFunc['db_query']('', '
@@ -568,14 +585,16 @@  discard block
 block discarded – undo
568 585
 		)
569 586
 	);
570 587
 	$context['board']['moderator_groups'] = array();
571
-	while ($row = $smcFunc['db_fetch_assoc']($request))
572
-		$context['board']['moderator_groups'][$row['id_group']] = $context['groups'][$row['id_group']]['name'];
588
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
589
+			$context['board']['moderator_groups'][$row['id_group']] = $context['groups'][$row['id_group']]['name'];
590
+	}
573 591
 	$smcFunc['db_free_result']($request);
574 592
 
575 593
 	$context['board']['moderator_groups_list'] = empty($context['board']['moderator_groups']) ? '' : '&quot;' . implode('&quot;, &qout;', $context['board']['moderator_groups']) . '&quot;';
576 594
 
577
-	if (!empty($context['board']['moderator_groups']))
578
-		list ($context['board']['last_moderator_group_id']) = array_slice(array_keys($context['board']['moderator_groups']), -1);
595
+	if (!empty($context['board']['moderator_groups'])) {
596
+			list ($context['board']['last_moderator_group_id']) = array_slice(array_keys($context['board']['moderator_groups']), -1);
597
+	}
579 598
 
580 599
 	// Get all the themes...
581 600
 	$request = $smcFunc['db_query']('', '
@@ -587,8 +606,9 @@  discard block
 block discarded – undo
587 606
 		)
588 607
 	);
589 608
 	$context['themes'] = array();
590
-	while ($row = $smcFunc['db_fetch_assoc']($request))
591
-		$context['themes'][] = $row;
609
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
610
+			$context['themes'][] = $row;
611
+	}
592 612
 	$smcFunc['db_free_result']($request);
593 613
 
594 614
 	if (!isset($_REQUEST['delete']))
@@ -596,8 +616,7 @@  discard block
 block discarded – undo
596 616
 		$context['sub_template'] = 'modify_board';
597 617
 		$context['page_title'] = $txt['boardsEdit'];
598 618
 		loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest');
599
-	}
600
-	else
619
+	} else
601 620
 	{
602 621
 		$context['sub_template'] = 'confirm_board_delete';
603 622
 		$context['page_title'] = $txt['mboards_delete_board'];
@@ -641,8 +660,9 @@  discard block
 block discarded – undo
641 660
 		// Change the boardorder of this board?
642 661
 		elseif (!empty($_POST['placement']) && !empty($_POST['board_order']))
643 662
 		{
644
-			if (!in_array($_POST['placement'], array('before', 'after', 'child')))
645
-				fatal_lang_error('mangled_post', false);
663
+			if (!in_array($_POST['placement'], array('before', 'after', 'child'))) {
664
+							fatal_lang_error('mangled_post', false);
665
+			}
646 666
 
647 667
 			$boardOptions['move_to'] = $_POST['placement'];
648 668
 			$boardOptions['target_board'] = (int) $_POST['board_order'];
@@ -655,13 +675,14 @@  discard block
 block discarded – undo
655 675
 		$boardOptions['access_groups'] = array();
656 676
 		$boardOptions['deny_groups'] = array();
657 677
 
658
-		if (!empty($_POST['groups']))
659
-			foreach ($_POST['groups'] as $group => $action)
678
+		if (!empty($_POST['groups'])) {
679
+					foreach ($_POST['groups'] as $group => $action)
660 680
 			{
661 681
 				if ($action == 'allow')
662 682
 					$boardOptions['access_groups'][] = (int) $group;
663
-				elseif ($action == 'deny')
664
-					$boardOptions['deny_groups'][] = (int) $group;
683
+		} elseif ($action == 'deny') {
684
+									$boardOptions['deny_groups'][] = (int) $group;
685
+				}
665 686
 			}
666 687
 
667 688
 		// People with manage-boards are special.
@@ -673,8 +694,9 @@  discard block
 block discarded – undo
673 694
 		// Secondly, make sure those with super cow powers (like apt-get, or in this case manage boards) are upgraded.
674 695
 		$boardOptions['access_groups'] = array_unique(array_merge($boardOptions['access_groups'], $board_managers));
675 696
 
676
-		if (strlen(implode(',', $boardOptions['access_groups'])) > 255 || strlen(implode(',', $boardOptions['deny_groups'])) > 255)
677
-			fatal_lang_error('too_many_groups', false);
697
+		if (strlen(implode(',', $boardOptions['access_groups'])) > 255 || strlen(implode(',', $boardOptions['deny_groups'])) > 255) {
698
+					fatal_lang_error('too_many_groups', false);
699
+		}
678 700
 
679 701
 		// Do not allow HTML tags. Parse the string.
680 702
 		$boardOptions['board_name'] = parse_bbc($smcFunc['htmlspecialchars']($_POST['board_name']), false, '', $context['description_allowed_tags']);
@@ -685,8 +707,9 @@  discard block
 block discarded – undo
685 707
 		if (isset($_POST['moderator_list']) && is_array($_POST['moderator_list']))
686 708
 		{
687 709
 			$moderators = array();
688
-			foreach ($_POST['moderator_list'] as $moderator)
689
-				$moderators[(int) $moderator] = (int) $moderator;
710
+			foreach ($_POST['moderator_list'] as $moderator) {
711
+							$moderators[(int) $moderator] = (int) $moderator;
712
+			}
690 713
 			$boardOptions['moderators'] = $moderators;
691 714
 		}
692 715
 
@@ -695,8 +718,9 @@  discard block
 block discarded – undo
695 718
 		if (isset($_POST['moderator_group_list']) && is_array($_POST['moderator_group_list']))
696 719
 		{
697 720
 			$moderator_groups = array();
698
-			foreach ($_POST['moderator_group_list'] as $moderator_group)
699
-				$moderator_groups[(int) $moderator_group] = (int) $moderator_group;
721
+			foreach ($_POST['moderator_group_list'] as $moderator_group) {
722
+							$moderator_groups[(int) $moderator_group] = (int) $moderator_group;
723
+			}
700 724
 			$boardOptions['moderator_groups'] = $moderator_groups;
701 725
 		}
702 726
 
@@ -722,56 +746,62 @@  discard block
 block discarded – undo
722 746
 			$smcFunc['db_free_result']($request);
723 747
 
724 748
 			// If we're turning redirection on check the board doesn't have posts in it - if it does don't make it a redirection board.
725
-			if ($boardOptions['redirect'] && empty($oldRedirect) && $numPosts)
726
-				unset($boardOptions['redirect']);
749
+			if ($boardOptions['redirect'] && empty($oldRedirect) && $numPosts) {
750
+							unset($boardOptions['redirect']);
751
+			}
727 752
 			// Reset the redirection count when switching on/off.
728
-			elseif (empty($boardOptions['redirect']) != empty($oldRedirect))
729
-				$boardOptions['num_posts'] = 0;
753
+			elseif (empty($boardOptions['redirect']) != empty($oldRedirect)) {
754
+							$boardOptions['num_posts'] = 0;
755
+			}
730 756
 			// Resetting the count?
731
-			elseif ($boardOptions['redirect'] && !empty($_POST['reset_redirect']))
732
-				$boardOptions['num_posts'] = 0;
757
+			elseif ($boardOptions['redirect'] && !empty($_POST['reset_redirect'])) {
758
+							$boardOptions['num_posts'] = 0;
759
+			}
733 760
 		}
734 761
 
735 762
 		// Create a new board...
736 763
 		if (isset($_POST['add']))
737 764
 		{
738 765
 			// New boards by default go to the bottom of the category.
739
-			if (empty($_POST['new_cat']))
740
-				$boardOptions['target_category'] = (int) $_POST['cur_cat'];
741
-			if (!isset($boardOptions['move_to']))
742
-				$boardOptions['move_to'] = 'bottom';
766
+			if (empty($_POST['new_cat'])) {
767
+							$boardOptions['target_category'] = (int) $_POST['cur_cat'];
768
+			}
769
+			if (!isset($boardOptions['move_to'])) {
770
+							$boardOptions['move_to'] = 'bottom';
771
+			}
743 772
 
744 773
 			createBoard($boardOptions);
745 774
 		}
746 775
 
747 776
 		// ...or update an existing board.
748
-		else
749
-			modifyBoard($_POST['boardid'], $boardOptions);
750
-	}
751
-	elseif (isset($_POST['delete']) && !isset($_POST['confirmation']) && !isset($_POST['no_children']))
777
+		else {
778
+					modifyBoard($_POST['boardid'], $boardOptions);
779
+		}
780
+	} elseif (isset($_POST['delete']) && !isset($_POST['confirmation']) && !isset($_POST['no_children']))
752 781
 	{
753 782
 		EditBoard();
754 783
 		return;
755
-	}
756
-	elseif (isset($_POST['delete']))
784
+	} elseif (isset($_POST['delete']))
757 785
 	{
758 786
 		// First off - check if we are moving all the current child boards first - before we start deleting!
759 787
 		if (isset($_POST['delete_action']) && $_POST['delete_action'] == 1)
760 788
 		{
761
-			if (empty($_POST['board_to']))
762
-				fatal_lang_error('mboards_delete_board_error');
789
+			if (empty($_POST['board_to'])) {
790
+							fatal_lang_error('mboards_delete_board_error');
791
+			}
763 792
 
764 793
 			deleteBoards(array($_POST['boardid']), (int) $_POST['board_to']);
794
+		} else {
795
+					deleteBoards(array($_POST['boardid']), 0);
765 796
 		}
766
-		else
767
-			deleteBoards(array($_POST['boardid']), 0);
768 797
 	}
769 798
 
770
-	if (isset($_REQUEST['rid']) && $_REQUEST['rid'] == 'permissions')
771
-		redirectexit('action=admin;area=permissions;sa=board;' . $context['session_var'] . '=' . $context['session_id']);
772
-	else
773
-		redirectexit('action=admin;area=manageboards');
774
-}
799
+	if (isset($_REQUEST['rid']) && $_REQUEST['rid'] == 'permissions') {
800
+			redirectexit('action=admin;area=permissions;sa=board;' . $context['session_var'] . '=' . $context['session_id']);
801
+	} else {
802
+			redirectexit('action=admin;area=manageboards');
803
+	}
804
+	}
775 805
 
776 806
 /**
777 807
  * Used to retrieve data for modifying a board category
@@ -808,8 +838,9 @@  discard block
 block discarded – undo
808 838
 	$smcFunc['db_free_result']($request);
809 839
 
810 840
 	// This would probably never happen, but just to be sure.
811
-	if ($cat .= $allowed_sa[1])
812
-		die(str_replace(',', ' to', $cat));
841
+	if ($cat .= $allowed_sa[1]) {
842
+			die(str_replace(',', ' to', $cat));
843
+	}
813 844
 
814 845
 	redirectexit();
815 846
 }
@@ -835,8 +866,9 @@  discard block
 block discarded – undo
835 866
 			'empty_string' => '',
836 867
 		)
837 868
 	);
838
-	while ($row = $smcFunc['db_fetch_assoc']($request))
839
-		$recycle_boards[$row['id_board']] = $row['cat_name'] . ' - ' . $row['board_name'];
869
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
870
+			$recycle_boards[$row['id_board']] = $row['cat_name'] . ' - ' . $row['board_name'];
871
+	}
840 872
 	$smcFunc['db_free_result']($request);
841 873
 
842 874
 	if (!empty($recycle_boards))
@@ -844,9 +876,9 @@  discard block
 block discarded – undo
844 876
 		require_once($sourcedir . '/Subs-Boards.php');
845 877
 		sortBoards($recycle_boards);
846 878
 		$recycle_boards = array('') + $recycle_boards;
879
+	} else {
880
+			$recycle_boards = array('');
847 881
 	}
848
-	else
849
-		$recycle_boards = array('');
850 882
 
851 883
 	// Here and the board settings...
852 884
 	$config_vars = array(
@@ -864,8 +896,9 @@  discard block
 block discarded – undo
864 896
 
865 897
 	call_integration_hook('integrate_modify_board_settings', array(&$config_vars));
866 898
 
867
-	if ($return_config)
868
-		return $config_vars;
899
+	if ($return_config) {
900
+			return $config_vars;
901
+	}
869 902
 
870 903
 	// Needed for the settings template.
871 904
 	require_once($sourcedir . '/ManageServer.php');
Please login to merge, or discard this patch.