SimpleMachines / SMF2.1

Themes/default/images/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/images/icons/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/images/bbc/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/scripts/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/fonts/sound/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/fonts/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/css/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Themes/default/index.php

Braces +3 added lines, -2 removed lines

@@ -1,9 +1,10 @@
 <?php
 
 // Try to handle it with the upper level index.php. (it should know what to do.)
-if (file_exists(dirname(dirname(__FILE__)) . '/index.php'))
+if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) {
 	include (dirname(dirname(__FILE__)) . '/index.php');
-else
+} else {
 	exit;
+}
 
 ?>
\ No newline at end of file

Sources/SplitTopics.php

Braces +260 added lines, -186 removed lines

@@ -15,8 +15,9 @@ 
  * Original module by Mach8 - We'll never forget you.
  */
 
-if (!defined('SMF'))
+if (!defined('SMF')) {
 	die('No direct access...');
+}
 
 /**
  * splits a topic into two topics.
@@ -30,15 +31,17 @@ 
 	global $topic, $sourcedir;
 
 	// And... which topic were you splitting, again?
-	if (empty($topic))
-		fatal_lang_error('numbers_one_to_nine', false);
+	if (empty($topic)) {
+			fatal_lang_error('numbers_one_to_nine', false);
+	}
 
 	// Are you allowed to split topics?
 	isAllowedTo('split_any');
 
 	// Load up the "dependencies" - the template, getMsgMemberID(), and sendNotifications().
-	if (!isset($_REQUEST['xml']))
-		loadTemplate('SplitTopics');
+	if (!isset($_REQUEST['xml'])) {
+			loadTemplate('SplitTopics');
+	}
 	require_once($sourcedir . '/Subs-Boards.php');
 	require_once($sourcedir . '/Subs-Post.php');
 
@@ -50,12 +53,12 @@ 
 	);
 
 	// ?action=splittopics;sa=LETSBREAKIT won't work, sorry.
-	if (empty($_REQUEST['sa']) || !isset($subActions[$_REQUEST['sa']]))
-		SplitIndex();
-
-	else
-		call_helper($subActions[$_REQUEST['sa']]);
-}
+	if (empty($_REQUEST['sa']) || !isset($subActions[$_REQUEST['sa']])) {
+			SplitIndex();
+	} else {
+			call_helper($subActions[$_REQUEST['sa']]);
+	}
+	}
 
 /**
  * screen shown before the actual split.
@@ -71,8 +74,9 @@ 
 	global $txt, $topic, $context, $smcFunc, $modSettings;
 
 	// Validate "at".
-	if (empty($_GET['at']))
-		fatal_lang_error('numbers_one_to_nine', false);
+	if (empty($_GET['at'])) {
+			fatal_lang_error('numbers_one_to_nine', false);
+	}
 	$_GET['at'] = (int) $_GET['at'];
 
 	// Retrieve the subject and stuff of the specific topic/message.
@@ -89,26 +93,31 @@ 
 			'split_at' => $_GET['at'],
 		)
 	);
-	if ($smcFunc['db_num_rows']($request) == 0)
-		fatal_lang_error('cant_find_messages');
+	if ($smcFunc['db_num_rows']($request) == 0) {
+			fatal_lang_error('cant_find_messages');
+	}
 	list ($_REQUEST['subname'], $num_replies, $unapproved_posts, $id_first_msg, $approved) = $smcFunc['db_fetch_row']($request);
 	$smcFunc['db_free_result']($request);
 
 	// If not approved validate they can see it.
-	if ($modSettings['postmod_active'] && !$approved)
-		isAllowedTo('approve_posts');
+	if ($modSettings['postmod_active'] && !$approved) {
+			isAllowedTo('approve_posts');
+	}
 
 	// If this topic has unapproved posts, we need to count them too...
-	if ($modSettings['postmod_active'] && allowedTo('approve_posts'))
-		$num_replies += $unapproved_posts - ($approved ? 0 : 1);
+	if ($modSettings['postmod_active'] && allowedTo('approve_posts')) {
+			$num_replies += $unapproved_posts - ($approved ? 0 : 1);
+	}
 
 	// Check if there is more than one message in the topic.  (there should be.)
-	if ($num_replies < 1)
-		fatal_lang_error('topic_one_post', false);
+	if ($num_replies < 1) {
+			fatal_lang_error('topic_one_post', false);
+	}
 
 	// Check if this is the first message in the topic (if so, the first and second option won't be available)
-	if ($id_first_msg == $_GET['at'])
-		return SplitSelectTopics();
+	if ($id_first_msg == $_GET['at']) {
+			return SplitSelectTopics();
+	}
 
 	// Basic template information....
 	$context['message'] = array(
@@ -137,8 +146,9 @@ 
 	checkSession();
 
 	// Clean up the subject.
-	if (!isset($_POST['subname']) || $_POST['subname'] == '')
-		$_POST['subname'] = $txt['new_topic'];
+	if (!isset($_POST['subname']) || $_POST['subname'] == '') {
+			$_POST['subname'] = $txt['new_topic'];
+	}
 
 	// Redirect to the selector if they chose selective.
 	if ($_POST['step2'] == 'selective')
@@ -163,16 +173,19 @@ 
 				'split_at' => $_POST['at'],
 			)
 		);
-		while ($row = $smcFunc['db_fetch_assoc']($request))
-			$messagesToBeSplit[] = $row['id_msg'];
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
+					$messagesToBeSplit[] = $row['id_msg'];
+		}
 		$smcFunc['db_free_result']($request);
 	}
 	// Only the selected message has to be split. That should be easy.
-	elseif ($_POST['step2'] == 'onlythis')
-		$messagesToBeSplit[] = $_POST['at'];
+	elseif ($_POST['step2'] == 'onlythis') {
+			$messagesToBeSplit[] = $_POST['at'];
+	}
 	// There's another action?!
-	else
-		fatal_lang_error('no_access', false);
+	else {
+			fatal_lang_error('no_access', false);
+	}
 
 	$context['old_topic'] = $topic;
 	$context['new_topic'] = splitTopic($topic, $messagesToBeSplit, $_POST['subname']);
@@ -199,8 +212,9 @@ 
 	$_SESSION['split_selection'][$topic] = empty($_SESSION['split_selection'][$topic]) ? array() : $_SESSION['split_selection'][$topic];
 
 	// This is a special case for split topics from quick-moderation checkboxes
-	if (isset($_REQUEST['subname_enc']))
-		$_REQUEST['subname'] = urldecode($_REQUEST['subname_enc']);
+	if (isset($_REQUEST['subname_enc'])) {
+			$_REQUEST['subname'] = urldecode($_REQUEST['subname_enc']);
+	}
 
 	$context['not_selected'] = array(
 		'num_messages' => 0,
@@ -252,10 +266,12 @@ 
 			)
 		);
 		// You can't split the last message off.
-		if (empty($context['not_selected']['start']) && $smcFunc['db_num_rows']($request) <= 1 && $_REQUEST['move'] == 'down')
-			$_REQUEST['move'] = '';
-		while ($row = $smcFunc['db_fetch_assoc']($request))
-			$original_msgs['not_selected'][] = $row['id_msg'];
+		if (empty($context['not_selected']['start']) && $smcFunc['db_num_rows']($request) <= 1 && $_REQUEST['move'] == 'down') {
+					$_REQUEST['move'] = '';
+		}
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
+					$original_msgs['not_selected'][] = $row['id_msg'];
+		}
 		$smcFunc['db_free_result']($request);
 		if (!empty($_SESSION['split_selection'][$topic]))
 		{
@@ -275,8 +291,9 @@ 
 					'messages_per_page' => $context['messages_per_page'],
 				)
 			);
-			while ($row = $smcFunc['db_fetch_assoc']($request))
-				$original_msgs['selected'][] = $row['id_msg'];
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
+							$original_msgs['selected'][] = $row['id_msg'];
+			}
 			$smcFunc['db_free_result']($request);
 		}
 	}
@@ -286,12 +303,13 @@ 
 	{
 		$_REQUEST['msg'] = (int) $_REQUEST['msg'];
 
-		if ($_REQUEST['move'] == 'reset')
-			$_SESSION['split_selection'][$topic] = array();
-		elseif ($_REQUEST['move'] == 'up')
-			$_SESSION['split_selection'][$topic] = array_diff($_SESSION['split_selection'][$topic], array($_REQUEST['msg']));
-		else
-			$_SESSION['split_selection'][$topic][] = $_REQUEST['msg'];
+		if ($_REQUEST['move'] == 'reset') {
+					$_SESSION['split_selection'][$topic] = array();
+		} elseif ($_REQUEST['move'] == 'up') {
+					$_SESSION['split_selection'][$topic] = array_diff($_SESSION['split_selection'][$topic], array($_REQUEST['msg']));
+		} else {
+					$_SESSION['split_selection'][$topic][] = $_REQUEST['msg'];
+		}
 	}
 
 	// Make sure the selection is still accurate.
@@ -310,8 +328,9 @@ 
 			)
 		);
 		$_SESSION['split_selection'][$topic] = array();
-		while ($row = $smcFunc['db_fetch_assoc']($request))
-			$_SESSION['split_selection'][$topic][] = $row['id_msg'];
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
+					$_SESSION['split_selection'][$topic][] = $row['id_msg'];
+		}
 		$smcFunc['db_free_result']($request);
 	}
 
@@ -328,13 +347,15 @@ 
 			'is_approved' => 1,
 		)
 	);
-	while ($row = $smcFunc['db_fetch_assoc']($request))
-		$context[empty($row['is_selected']) || $row['is_selected'] == 'f' ? 'not_selected' : 'selected']['num_messages'] = $row['num_messages'];
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
+			$context[empty($row['is_selected']) || $row['is_selected'] == 'f' ? 'not_selected' : 'selected']['num_messages'] = $row['num_messages'];
+	}
 	$smcFunc['db_free_result']($request);
 
 	// Fix an oversized starting page (to make sure both pageindexes are properly set).
-	if ($context['selected']['start'] >= $context['selected']['num_messages'])
-		$context['selected']['start'] = $context['selected']['num_messages'] <= $context['messages_per_page'] ? 0 : ($context['selected']['num_messages'] - (($context['selected']['num_messages'] % $context['messages_per_page']) == 0 ? $context['messages_per_page'] : ($context['selected']['num_messages'] % $context['messages_per_page'])));
+	if ($context['selected']['start'] >= $context['selected']['num_messages']) {
+			$context['selected']['start'] = $context['selected']['num_messages'] <= $context['messages_per_page'] ? 0 : ($context['selected']['num_messages'] - (($context['selected']['num_messages'] % $context['messages_per_page']) == 0 ? $context['messages_per_page'] : ($context['selected']['num_messages'] % $context['messages_per_page'])));
+	}
 
 	// Build a page list of the not-selected topics...
 	$context['not_selected']['page_index'] = constructPageIndex($scripturl . '?action=splittopics;sa=selectTopics;subname=' . strtr(urlencode($_REQUEST['subname']), array('%' => '%%')) . ';topic=' . $topic . '.%1$d;start2=' . $context['selected']['start'], $context['not_selected']['start'], $context['not_selected']['num_messages'], $context['messages_per_page'], true);
@@ -434,11 +455,12 @@ 
 		);
 
 		$context['changes'] = array();
-		foreach ($changes as $change_type => $change_array)
-			foreach ($change_array as $section => $msg_array)
+		foreach ($changes as $change_type => $change_array) {
+					foreach ($change_array as $section => $msg_array)
 			{
 				if (empty($msg_array))
 					continue;
+		}
 
 				foreach ($msg_array as $id_msg)
 				{
@@ -447,8 +469,9 @@ 
 						'type' => $change_type,
 						'section' => $section,
 					);
-					if ($change_type == 'insert')
-						$context['changes']['insert' . $id_msg]['insert_value'] = $context[$section]['messages'][$id_msg];
+					if ($change_type == 'insert') {
+											$context['changes']['insert' . $id_msg]['insert_value'] = $context[$section]['messages'][$id_msg];
+					}
 				}
 			}
 	}
@@ -468,12 +491,14 @@ 
 	checkSession();
 
 	// Default the subject in case it's blank.
-	if (!isset($_POST['subname']) || $_POST['subname'] == '')
-		$_POST['subname'] = $txt['new_topic'];
+	if (!isset($_POST['subname']) || $_POST['subname'] == '') {
+			$_POST['subname'] = $txt['new_topic'];
+	}
 
 	// You must've selected some messages!  Can't split out none!
-	if (empty($_SESSION['split_selection'][$topic]))
-		fatal_lang_error('no_posts_selected', false);
+	if (empty($_SESSION['split_selection'][$topic])) {
+			fatal_lang_error('no_posts_selected', false);
+	}
 
 	$context['old_topic'] = $topic;
 	$context['new_topic'] = splitTopic($topic, $_SESSION['split_selection'][$topic], $_POST['subname']);
@@ -499,8 +524,9 @@ 
 	global $smcFunc, $txt, $sourcedir;
 
 	// Nothing to split?
-	if (empty($splitMessages))
-		fatal_lang_error('no_posts_selected', false);
+	if (empty($splitMessages)) {
+			fatal_lang_error('no_posts_selected', false);
+	}
 
 	// Get some board info.
 	$request = $smcFunc['db_query']('', '
@@ -532,8 +558,9 @@ 
 		)
 	);
 	// You can't select ALL the messages!
-	if ($smcFunc['db_num_rows']($request) == 0)
-		fatal_lang_error('selected_all_posts', false);
+	if ($smcFunc['db_num_rows']($request) == 0) {
+			fatal_lang_error('selected_all_posts', false);
+	}
 
 	$split1_first_msg = null;
 	$split1_last_msg = null;
@@ -541,24 +568,27 @@ 
 	while ($row = $smcFunc['db_fetch_assoc']($request))
 	{
 		// Get the right first and last message dependant on approved state...
-		if (empty($split1_first_msg) || $row['myid_first_msg'] < $split1_first_msg)
-			$split1_first_msg = $row['myid_first_msg'];
-		if (empty($split1_last_msg) || $row['approved'])
-			$split1_last_msg = $row['myid_last_msg'];
+		if (empty($split1_first_msg) || $row['myid_first_msg'] < $split1_first_msg) {
+					$split1_first_msg = $row['myid_first_msg'];
+		}
+		if (empty($split1_last_msg) || $row['approved']) {
+					$split1_last_msg = $row['myid_last_msg'];
+		}
 
 		// Get the counts correct...
 		if ($row['approved'])
 		{
 			$split1_replies = $row['message_count'] - 1;
 			$split1_unapprovedposts = 0;
-		}
-		else
+		} else
 		{
-			if (!isset($split1_replies))
-				$split1_replies = 0;
+			if (!isset($split1_replies)) {
+							$split1_replies = 0;
+			}
 			// If the topic isn't approved then num replies must go up by one... as first post wouldn't be counted.
-			elseif (!$split1_approved)
-				$split1_replies++;
+			elseif (!$split1_approved) {
+							$split1_replies++;
+			}
 
 			$split1_unapprovedposts = $row['message_count'];
 		}
@@ -584,10 +614,12 @@ 
 	while ($row = $smcFunc['db_fetch_assoc']($request))
 	{
 		// As before get the right first and last message dependant on approved state...
-		if (empty($split2_first_msg) || $row['myid_first_msg'] < $split2_first_msg)
-			$split2_first_msg = $row['myid_first_msg'];
-		if (empty($split2_last_msg) || $row['approved'])
-			$split2_last_msg = $row['myid_last_msg'];
+		if (empty($split2_first_msg) || $row['myid_first_msg'] < $split2_first_msg) {
+					$split2_first_msg = $row['myid_first_msg'];
+		}
+		if (empty($split2_last_msg) || $row['approved']) {
+					$split2_last_msg = $row['myid_last_msg'];
+		}
 
 		// Then do the counts again...
 		if ($row['approved'])
@@ -595,18 +627,20 @@ 
 			$split2_approved = true;
 			$split2_replies = $row['message_count'] - 1;
 			$split2_unapprovedposts = 0;
-		}
-		else
+		} else
 		{
 			// Should this one be approved??
-			if ($split2_first_msg == $row['myid_first_msg'])
-				$split2_approved = false;
+			if ($split2_first_msg == $row['myid_first_msg']) {
+							$split2_approved = false;
+			}
 
-			if (!isset($split2_replies))
-				$split2_replies = 0;
+			if (!isset($split2_replies)) {
+							$split2_replies = 0;
+			}
 			// As before, fix number of replies.
-			elseif (!$split2_approved)
-				$split2_replies++;
+			elseif (!$split2_approved) {
+							$split2_replies++;
+			}
 
 			$split2_unapprovedposts = $row['message_count'];
 		}
@@ -616,12 +650,14 @@ 
 	$split2_lastMem = getMsgMemberID($split2_last_msg);
 
 	// No database changes yet, so let's double check to see if everything makes at least a little sense.
-	if ($split1_first_msg <= 0 || $split1_last_msg <= 0 || $split2_first_msg <= 0 || $split2_last_msg <= 0 || $split1_replies < 0 || $split2_replies < 0 || $split1_unapprovedposts < 0 || $split2_unapprovedposts < 0 || !isset($split1_approved) || !isset($split2_approved))
-		fatal_lang_error('cant_find_messages');
+	if ($split1_first_msg <= 0 || $split1_last_msg <= 0 || $split2_first_msg <= 0 || $split2_last_msg <= 0 || $split1_replies < 0 || $split2_replies < 0 || $split1_unapprovedposts < 0 || $split2_unapprovedposts < 0 || !isset($split1_approved) || !isset($split2_approved)) {
+			fatal_lang_error('cant_find_messages');
+	}
 
 	// You cannot split off the first message of a topic.
-	if ($split1_first_msg > $split2_first_msg)
-		fatal_lang_error('split_first_post', false);
+	if ($split1_first_msg > $split2_first_msg) {
+			fatal_lang_error('split_first_post', false);
+	}
 
 	// We're off to insert the new topic!  Use 0 for now to avoid UNIQUE errors.
 	$split2_ID_TOPIC = $smcFunc['db_insert']('',
@@ -644,14 +680,16 @@ 
 			array('id_topic'),
 			1
 		);
-	if ($split2_ID_TOPIC <= 0)
-		fatal_lang_error('cant_insert_topic');
+	if ($split2_ID_TOPIC <= 0) {
+			fatal_lang_error('cant_insert_topic');
+	}
 
 	// Move the messages over to the other topic.
 	$new_subject = strtr($smcFunc['htmltrim']($smcFunc['htmlspecialchars']($new_subject)), array("\r" => '', "\n" => '', "\t" => ''));
 	// Check the subject length.
-	if ($smcFunc['strlen']($new_subject) > 100)
-		$new_subject = $smcFunc['substr']($new_subject, 0, 100);
+	if ($smcFunc['strlen']($new_subject) > 100) {
+			$new_subject = $smcFunc['substr']($new_subject, 0, 100);
+	}
 	// Valid subject?
 	if ($new_subject != '')
 	{
@@ -722,8 +760,8 @@ 
 	);
 
 	// If the new topic isn't approved ensure the first message flags this just in case.
-	if (!$split2_approved)
-		$smcFunc['db_query']('', '
+	if (!$split2_approved) {
+			$smcFunc['db_query']('', '
 			UPDATE {db_prefix}messages
 			SET approved = {int:approved}
 			WHERE id_msg = {int:id_msg}
@@ -734,6 +772,7 @@ 
 				'id_topic' => $split2_ID_TOPIC,
 			)
 		);
+	}
 
 	// The board has more topics now (Or more unapproved ones!).
 	$smcFunc['db_query']('', '
@@ -760,8 +799,9 @@ 
 	if ($smcFunc['db_num_rows']($request) > 0)
 	{
 		$replaceEntries = array();
-		while ($row = $smcFunc['db_fetch_assoc']($request))
-			$replaceEntries[] = array($row['id_member'], $split2_ID_TOPIC, $row['id_msg'], $row['unwatched']);
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
+					$replaceEntries[] = array($row['id_member'], $split2_ID_TOPIC, $row['id_msg'], $row['unwatched']);
+		}
 
 		$smcFunc['db_insert']('ignore',
 			'{db_prefix}log_topics',
@@ -785,8 +825,9 @@ 
 	// If there's a search index that needs updating, update it...
 	require_once($sourcedir . '/Search.php');
 	$searchAPI = findSearchAPI();
-	if (is_callable(array($searchAPI, 'topicSplit')))
-		$searchAPI->topicSplit($split2_ID_TOPIC, $splitMessages);
+	if (is_callable(array($searchAPI, 'topicSplit'))) {
+			$searchAPI->topicSplit($split2_ID_TOPIC, $splitMessages);
+	}
 
 	// Maybe we want to let an external CMS know about this split
 	$split1 = array(
@@ -833,12 +874,12 @@ 
 	);
 
 	// ?action=mergetopics;sa=LETSBREAKIT won't work, sorry.
-	if (empty($_REQUEST['sa']) || !isset($subActions[$_REQUEST['sa']]))
-		MergeIndex();
-
-	else
-		call_helper($subActions[$_REQUEST['sa']]);
-}
+	if (empty($_REQUEST['sa']) || !isset($subActions[$_REQUEST['sa']])) {
+			MergeIndex();
+	} else {
+			call_helper($subActions[$_REQUEST['sa']]);
+	}
+	}
 
 /**
  * allows to pick a topic to merge the current topic with.
@@ -852,8 +893,9 @@ 
 	global $txt, $board, $context, $smcFunc, $sourcedir;
 	global $scripturl, $modSettings;
 
-	if (!isset($_GET['from']))
-		fatal_lang_error('no_access', false);
+	if (!isset($_GET['from'])) {
+			fatal_lang_error('no_access', false);
+	}
 	$_GET['from'] = (int) $_GET['from'];
 
 	$_REQUEST['targetboard'] = isset($_REQUEST['targetboard']) ? (int) $_REQUEST['targetboard'] : $board;
@@ -864,9 +906,9 @@ 
 	{
 		$can_approve_boards = boardsAllowedTo('approve_posts');
 		$onlyApproved = $can_approve_boards !== array(0) && !in_array($_REQUEST['targetboard'], $can_approve_boards);
+	} else {
+			$onlyApproved = false;
 	}
-	else
-		$onlyApproved = false;
 
 	// How many topics are on this board?  (used for paging.)
 	$request = $smcFunc['db_query']('', '
@@ -900,8 +942,9 @@ 
 			'is_approved' => 1,
 		)
 	);
-	if ($smcFunc['db_num_rows']($request) == 0)
-		fatal_lang_error('no_board');
+	if ($smcFunc['db_num_rows']($request) == 0) {
+			fatal_lang_error('no_board');
+	}
 	list ($subject) = $smcFunc['db_fetch_row']($request);
 	$smcFunc['db_free_result']($request);
 
@@ -914,8 +957,9 @@ 
 	// Check which boards you have merge permissions on.
 	$merge_boards = boardsAllowedTo('merge_any');
 
-	if (empty($merge_boards))
-		fatal_lang_error('cannot_merge_any', 'user');
+	if (empty($merge_boards)) {
+			fatal_lang_error('cannot_merge_any', 'user');
+	}
 
 	// No sense in loading this if you can only merge on this board
 	if (count($merge_boards) > 1 || in_array(0, $merge_boards))
@@ -929,8 +973,9 @@ 
 		);
 
 		// Only include these boards in the list (0 means you're an admin')
-		if (!in_array(0, $merge_boards))
-			$options['included_boards'] = $merge_boards;
+		if (!in_array(0, $merge_boards)) {
+					$options['included_boards'] = $merge_boards;
+		}
 
 		$context['merge_categories'] = getBoardList($options);
 	}
@@ -976,8 +1021,9 @@ 
 	}
 	$smcFunc['db_free_result']($request);
 
-	if (empty($context['topics']) && count($merge_boards) <= 1 && !in_array(0, $merge_boards))
-		fatal_lang_error('merge_need_more_topics');
+	if (empty($context['topics']) && count($merge_boards) <= 1 && !in_array(0, $merge_boards)) {
+			fatal_lang_error('merge_need_more_topics');
+	}
 
 	$context['sub_template'] = 'merge';
 }
@@ -1007,24 +1053,29 @@ 
 	checkSession('request');
 
 	// Handle URLs from MergeIndex.
-	if (!empty($_GET['from']) && !empty($_GET['to']))
-		$topics = array((int) $_GET['from'], (int) $_GET['to']);
+	if (!empty($_GET['from']) && !empty($_GET['to'])) {
+			$topics = array((int) $_GET['from'], (int) $_GET['to']);
+	}
 
 	// If we came from a form, the topic IDs came by post.
-	if (!empty($_POST['topics']) && is_array($_POST['topics']))
-		$topics = $_POST['topics'];
+	if (!empty($_POST['topics']) && is_array($_POST['topics'])) {
+			$topics = $_POST['topics'];
+	}
 
 	// There's nothing to merge with just one topic...
-	if (empty($topics) || !is_array($topics) || count($topics) == 1)
-		fatal_lang_error('merge_need_more_topics');
+	if (empty($topics) || !is_array($topics) || count($topics) == 1) {
+			fatal_lang_error('merge_need_more_topics');
+	}
 
 	// Make sure every topic is numeric, or some nasty things could be done with the DB.
-	foreach ($topics as $id => $topic)
-		$topics[$id] = (int) $topic;
+	foreach ($topics as $id => $topic) {
+			$topics[$id] = (int) $topic;
+	}
 
 	// Joy of all joys, make sure they're not messing about with unapproved topics they can't see :P
-	if ($modSettings['postmod_active'])
-		$can_approve_boards = boardsAllowedTo('approve_posts');
+	if ($modSettings['postmod_active']) {
+			$can_approve_boards = boardsAllowedTo('approve_posts');
+	}
 
 	// Get info about the topics and polls that will be merged.
 	$request = $smcFunc['db_query']('', '
@@ -1045,8 +1096,9 @@ 
 			'limit' => count($topics),
 		)
 	);
-	if ($smcFunc['db_num_rows']($request) < 2)
-		fatal_lang_error('no_topic_id');
+	if ($smcFunc['db_num_rows']($request) < 2) {
+			fatal_lang_error('no_topic_id');
+	}
 	$num_views = 0;
 	$is_sticky = 0;
 	$boardTotals = array();
@@ -1059,34 +1111,38 @@ 
 	while ($row = $smcFunc['db_fetch_assoc']($request))
 	{
 		// Sorry, redirection topics can't be merged
-		if (!empty($row['id_redirect_topic']))
-			fatal_lang_error('cannot_merge_redirect', false);
+		if (!empty($row['id_redirect_topic'])) {
+					fatal_lang_error('cannot_merge_redirect', false);
+		}
 
 		// Make a note for the board counts...
-		if (!isset($boardTotals[$row['id_board']]))
-			$boardTotals[$row['id_board']] = array(
+		if (!isset($boardTotals[$row['id_board']])) {
+					$boardTotals[$row['id_board']] = array(
 				'posts' => 0,
 				'topics' => 0,
 				'unapproved_posts' => 0,
 				'unapproved_topics' => 0
 			);
+		}
 
 		// We can't see unapproved topics here?
 		if ($modSettings['postmod_active'] && !$row['approved'] && $can_approve_boards != array(0) && in_array($row['id_board'], $can_approve_boards))
 		{
 			unset($topics[$row['id_topic']]); // If we can't see it, we should not merge it and not adjust counts! Instead skip it.
 			continue;
-		}elseif (!$row['approved'])
-			$boardTotals[$row['id_board']]['unapproved_topics']++;
-		else
-			$boardTotals[$row['id_board']]['topics']++;
+		} elseif (!$row['approved']) {
+					$boardTotals[$row['id_board']]['unapproved_topics']++;
+		} else {
+					$boardTotals[$row['id_board']]['topics']++;
+		}
 
 		$boardTotals[$row['id_board']]['unapproved_posts'] += $row['unapproved_posts'];
 		$boardTotals[$row['id_board']]['posts'] += $row['num_replies'] + ($row['approved'] ? 1 : 0);
 
 		// In the case of making a redirect, the topic count goes up by one due to the redirect topic.
-		if (isset($_POST['postRedirect']))
-			$boardTotals[$row['id_board']]['topics']--;
+		if (isset($_POST['postRedirect'])) {
+					$boardTotals[$row['id_board']]['topics']--;
+		}
 
 		$topic_data[$row['id_topic']] = array(
 			'id' => $row['id_topic'],
@@ -1112,11 +1168,13 @@ 
 		$boards[] = $row['id_board'];
 
 		// If there's no poll, id_poll == 0...
-		if ($row['id_poll'] > 0)
-			$polls[] = $row['id_poll'];
+		if ($row['id_poll'] > 0) {
+					$polls[] = $row['id_poll'];
+		}
 		// Store the id_topic with the lowest id_first_msg.
-		if (empty($firstTopic))
-			$firstTopic = $row['id_topic'];
+		if (empty($firstTopic)) {
+					$firstTopic = $row['id_topic'];
+		}
 
 		// Lowest topic id gets selected as surviving topic id. We need to store this board so we can adjust the topic count (This one will not have a redirect topic)
 		if ($row['id_topic'] < $lowestTopicId || empty($lowestTopicId))
@@ -1130,11 +1188,13 @@ 
 	$smcFunc['db_free_result']($request);
 
 	// If we didn't get any topics then they've been messing with unapproved stuff.
-	if (empty($topic_data))
-		fatal_lang_error('no_topic_id');
+	if (empty($topic_data)) {
+			fatal_lang_error('no_topic_id');
+	}
 
-	if (isset($_POST['postRedirect']) && !empty($lowestTopicBoard))
-		$boardTotals[$lowestTopicBoard]['topics']++;
+	if (isset($_POST['postRedirect']) && !empty($lowestTopicBoard)) {
+			$boardTotals[$lowestTopicBoard]['topics']++;
+	}
 
 	// Will this be approved?
 	$context['is_approved'] = $topic_data[$firstTopic]['approved'];
@@ -1150,8 +1210,9 @@ 
 
 	// Get the boards a user is allowed to merge in.
 	$merge_boards = boardsAllowedTo('merge_any');
-	if (empty($merge_boards))
-		fatal_lang_error('cannot_merge_any', 'user');
+	if (empty($merge_boards)) {
+			fatal_lang_error('cannot_merge_any', 'user');
+	}
 
 	// Make sure they can see all boards....
 	$request = $smcFunc['db_query']('', '
@@ -1168,8 +1229,9 @@ 
 		)
 	);
 	// If the number of boards that's in the output isn't exactly the same as we've put in there, you're in trouble.
-	if ($smcFunc['db_num_rows']($request) != count($boards))
-		fatal_lang_error('no_board');
+	if ($smcFunc['db_num_rows']($request) != count($boards)) {
+			fatal_lang_error('no_board');
+	}
 	$smcFunc['db_free_result']($request);
 
 	if (empty($_REQUEST['sa']) || $_REQUEST['sa'] == 'options')
@@ -1188,8 +1250,8 @@ 
 					'limit' => count($polls),
 				)
 			);
-			while ($row = $smcFunc['db_fetch_assoc']($request))
-				$context['polls'][] = array(
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
+							$context['polls'][] = array(
 					'id' => $row['id_poll'],
 					'topic' => array(
 						'id' => $row['id_topic'],
@@ -1198,6 +1260,7 @@ 
 					'question' => $row['question'],
 					'selected' => $row['id_topic'] == $firstTopic
 				);
+			}
 			$smcFunc['db_free_result']($request);
 		}
 		if (count($boards) > 1)
@@ -1213,18 +1276,20 @@ 
 					'limit' => count($boards),
 				)
 			);
-			while ($row = $smcFunc['db_fetch_assoc']($request))
-				$context['boards'][] = array(
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
+							$context['boards'][] = array(
 					'id' => $row['id_board'],
 					'name' => $row['name'],
 					'selected' => $row['id_board'] == $topic_data[$firstTopic]['board']
 				);
+			}
 			$smcFunc['db_free_result']($request);
 		}
 
 		$context['topics'] = $topic_data;
-		foreach ($topic_data as $id => $topic)
-			$context['topics'][$id]['selected'] = $topic['id'] == $firstTopic;
+		foreach ($topic_data as $id => $topic) {
+					$context['topics'][$id]['selected'] = $topic['id'] == $firstTopic;
+		}
 
 		$context['page_title'] = $txt['merge'];
 		$context['sub_template'] = 'merge_extra_options';
@@ -1233,13 +1298,15 @@ 
 
 	// Determine target board.
 	$target_board = count($boards) > 1 ? (int) $_REQUEST['board'] : $boards[0];
-	if (!in_array($target_board, $boards))
-		fatal_lang_error('no_board');
+	if (!in_array($target_board, $boards)) {
+			fatal_lang_error('no_board');
+	}
 
 	// Determine which poll will survive and which polls won't.
 	$target_poll = count($polls) > 1 ? (int) $_POST['poll'] : (count($polls) == 1 ? $polls[0] : 0);
-	if ($target_poll > 0 && !in_array($target_poll, $polls))
-		fatal_lang_error('no_access', false);
+	if ($target_poll > 0 && !in_array($target_poll, $polls)) {
+			fatal_lang_error('no_access', false);
+	}
 	$deleted_polls = empty($target_poll) ? $polls : array_diff($polls, array($target_poll));
 
 	// Determine the subject of the newly merged topic - was a custom subject specified?
@@ -1247,19 +1314,23 @@ 
 	{
 		$target_subject = strtr($smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['custom_subject'])), array("\r" => '', "\n" => '', "\t" => ''));
 		// Keep checking the length.
-		if ($smcFunc['strlen']($target_subject) > 100)
-			$target_subject = $smcFunc['substr']($target_subject, 0, 100);
+		if ($smcFunc['strlen']($target_subject) > 100) {
+					$target_subject = $smcFunc['substr']($target_subject, 0, 100);
+		}
 
 		// Nothing left - odd but pick the first topics subject.
-		if ($target_subject == '')
-			$target_subject = $topic_data[$firstTopic]['subject'];
+		if ($target_subject == '') {
+					$target_subject = $topic_data[$firstTopic]['subject'];
+		}
 	}
 	// A subject was selected from the list.
-	elseif (!empty($topic_data[(int) $_POST['subject']]['subject']))
-		$target_subject = $topic_data[(int) $_POST['subject']]['subject'];
+	elseif (!empty($topic_data[(int) $_POST['subject']]['subject'])) {
+			$target_subject = $topic_data[(int) $_POST['subject']]['subject'];
+	}
 	// Nothing worked? Just take the subject of the first message.
-	else
-		$target_subject = $topic_data[$firstTopic]['subject'];
+	else {
+			$target_subject = $topic_data[$firstTopic]['subject'];
+	}
 
 	// Get the first and last message and the number of messages....
 	$request = $smcFunc['db_query']('', '
@@ -1285,15 +1356,13 @@ 
 			{
 				$num_replies = $row['message_count'] - 1;
 				$num_unapproved = 0;
-			}
-			else
+			} else
 			{
 				$topic_approved = 0;
 				$num_replies = 0;
 				$num_unapproved = $row['message_count'];
 			}
-		}
-		else
+		} else
 		{
 			// If this has a lower first_msg then the first post is not approved and hence the number of replies was wrong!
 			if ($first_msg > $row['first_msg'])
@@ -1339,8 +1408,9 @@ 
 	list ($member_started) = $smcFunc['db_fetch_row']($request);
 	list ($member_updated) = $smcFunc['db_fetch_row']($request);
 	// First and last message are the same, so only row was returned.
-	if ($member_updated === NULL)
-		$member_updated = $member_started;
+	if ($member_updated === NULL) {
+			$member_updated = $member_started;
+	}
 
 	$smcFunc['db_free_result']($request);
 
@@ -1353,8 +1423,9 @@ 
 		array(
 			'topic_list' => $topics,
 	));
-	while ($row = $smcFunc['db_fetch_row']($request))
-		$affected_msgs[] = $row[0];
+	while ($row = $smcFunc['db_fetch_row']($request)) {
+			$affected_msgs[] = $row[0];
+	}
 	$smcFunc['db_free_result']($request);
 
 	// Assign the first topic ID to be the merged topic.
@@ -1432,9 +1503,9 @@ 
 	// Grab the response prefix (like 'Re: ') in the default forum language.
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
 	{
-		if ($language === $user_info['language'])
-			$context['response_prefix'] = $txt['response_prefix'];
-		else
+		if ($language === $user_info['language']) {
+					$context['response_prefix'] = $txt['response_prefix'];
+		} else
 		{
 			loadLanguage('index', $language, false);
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -1514,8 +1585,9 @@ 
 	if ($smcFunc['db_num_rows']($request) > 0)
 	{
 		$replaceEntries = array();
-		while ($row = $smcFunc['db_fetch_assoc']($request))
-			$replaceEntries[] = array($row['id_member'], $id_topic, $row['new_id_msg'], $row['unwatched']);
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
+					$replaceEntries[] = array($row['id_member'], $id_topic, $row['new_id_msg'], $row['unwatched']);
+		}
 
 		$smcFunc['db_insert']('replace',
 			'{db_prefix}log_topics',
@@ -1552,8 +1624,9 @@ 
 		if ($smcFunc['db_num_rows']($request) > 0)
 		{
 			$replaceEntries = array();
-			while ($row = $smcFunc['db_fetch_assoc']($request))
-				$replaceEntries[] = array($row['id_member'], $id_topic, 0, $row['sent']);
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
+							$replaceEntries[] = array($row['id_member'], $id_topic, 0, $row['sent']);
+			}
 
 			$smcFunc['db_insert']('replace',
 					'{db_prefix}log_notify',
@@ -1728,8 +1801,9 @@ 
 	// If there's a search index that needs updating, update it...
 	require_once($sourcedir . '/Search.php');
 	$searchAPI = findSearchAPI();
-	if (is_callable(array($searchAPI, 'topicMerge')))
-		$searchAPI->topicMerge($id_topic, $topics, $affected_msgs, empty($_POST['enforce_subject']) ? null : array($context['response_prefix'], $target_subject));
+	if (is_callable(array($searchAPI, 'topicMerge'))) {
+			$searchAPI->topicMerge($id_topic, $topics, $affected_msgs, empty($_POST['enforce_subject']) ? null : array($context['response_prefix'], $target_subject));
+	}
 
 	// Merging is the sort of thing an external CMS might want to know about
 	$merged_topic = array(