Completed
Pull Request — release-2.1 (#3761)
by Rick
07:11
created
other/upgrade-helper.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 /**
142 142
  * Make files writable. First try to use regular chmod, but if that fails, try to use FTP.
143 143
  *
144
- * @param $files
144
+ * @param string[] $files
145 145
  * @return bool
146 146
  */
147 147
 function makeFilesWritable(&$files)
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 /**
382 382
  * Prints an error to stderr.
383 383
  *
384
- * @param $message
384
+ * @param string $message
385 385
  * @param bool $fatal
386 386
  */
387 387
 function print_error($message, $fatal = false)
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
 /**
401 401
  * Throws a graphical error message.
402 402
  *
403
- * @param $message
403
+ * @param string $message
404 404
  * @return bool
405 405
  */
406 406
 function throw_error($message)
Please login to merge, or discard this patch.
other/upgrade.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -390,6 +390,9 @@  discard block
 block discarded – undo
390 390
 }
391 391
 
392 392
 // Used to direct the user to another location.
393
+/**
394
+ * @param string $location
395
+ */
393 396
 function redirectLocation($location, $addForm = true)
394 397
 {
395 398
 	global $upgradeurl, $upcontext, $command_line;
@@ -1719,6 +1722,9 @@  discard block
 block discarded – undo
1719 1722
 	return addslashes(preg_replace(array('~^\.([/\\\]|$)~', '~[/]+~', '~[\\\]+~', '~[/\\\]$~'), array($install_path . '$1', '/', '\\', ''), $path));
1720 1723
 }
1721 1724
 
1725
+/**
1726
+ * @param string $filename
1727
+ */
1722 1728
 function parse_sql($filename)
1723 1729
 {
1724 1730
 	global $db_prefix, $db_collation, $boarddir, $boardurl, $command_line, $file_steps, $step_progress, $custom_warning;
@@ -2005,6 +2011,9 @@  discard block
 block discarded – undo
2005 2011
 	return true;
2006 2012
 }
2007 2013
 
2014
+/**
2015
+ * @param string $string
2016
+ */
2008 2017
 function upgrade_query($string, $unbuffered = false)
2009 2018
 {
2010 2019
 	global $db_connection, $db_server, $db_user, $db_passwd, $db_type, $command_line, $upcontext, $upgradeurl, $modSettings;
@@ -4675,7 +4684,7 @@  discard block
 block discarded – undo
4675 4684
  * @param int $setSize The amount of entries after which to update the database.
4676 4685
  *
4677 4686
  * newCol needs to be a varbinary(16) null able field
4678
- * @return bool
4687
+ * @return boolean|null
4679 4688
  */
4680 4689
 function MySQLConvertOldIp($targetTable, $oldCol, $newCol, $limit = 50000, $setSize = 100)
4681 4690
 {
Please login to merge, or discard this patch.