Completed
Push — release-2.1 ( 5f73de...e7eefc )
by Colin
07:52
created
Sources/Admin.php 1 patch
Braces   +75 added lines, -52 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * The main admin handling function.<br>
@@ -444,8 +445,9 @@  discard block
 block discarded – undo
444 445
 		foreach ($admin_includes as $include)
445 446
 		{
446 447
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
447
-			if (file_exists($include))
448
-				require_once($include);
448
+			if (file_exists($include)) {
449
+							require_once($include);
450
+			}
449 451
 		}
450 452
 	}
451 453
 
@@ -457,24 +459,27 @@  discard block
 block discarded – undo
457 459
 	unset($admin_areas);
458 460
 
459 461
 	// Nothing valid?
460
-	if ($admin_include_data == false)
461
-		fatal_lang_error('no_access', false);
462
+	if ($admin_include_data == false) {
463
+			fatal_lang_error('no_access', false);
464
+	}
462 465
 
463 466
 	// Build the link tree.
464 467
 	$context['linktree'][] = array(
465 468
 		'url' => $scripturl . '?action=admin',
466 469
 		'name' => $txt['admin_center'],
467 470
 	);
468
-	if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index')
469
-		$context['linktree'][] = array(
471
+	if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index') {
472
+			$context['linktree'][] = array(
470 473
 			'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';' . $context['session_var'] . '=' . $context['session_id'],
471 474
 			'name' => $admin_include_data['label'],
472 475
 		);
473
-	if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label'])
474
-		$context['linktree'][] = array(
476
+	}
477
+	if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label']) {
478
+			$context['linktree'][] = array(
475 479
 			'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';sa=' . $admin_include_data['current_subsection'] . ';' . $context['session_var'] . '=' . $context['session_id'],
476 480
 			'name' => $admin_include_data['subsections'][$admin_include_data['current_subsection']][0],
477 481
 		);
482
+	}
478 483
 
479 484
 	// Make a note of the Unique ID for this menu.
480 485
 	$context['admin_menu_id'] = $context['max_menu_id'];
@@ -484,16 +489,18 @@  discard block
 block discarded – undo
484 489
 	$context['admin_area'] = $admin_include_data['current_area'];
485 490
 
486 491
 	// Now - finally - call the right place!
487
-	if (isset($admin_include_data['file']))
488
-		require_once($sourcedir . '/' . $admin_include_data['file']);
492
+	if (isset($admin_include_data['file'])) {
493
+			require_once($sourcedir . '/' . $admin_include_data['file']);
494
+	}
489 495
 
490 496
 	// Get the right callable.
491 497
 	$call = call_helper($admin_include_data['function'], true);
492 498
 
493 499
 	// Is it valid?
494
-	if (!empty($call))
495
-		call_user_func($call);
496
-}
500
+	if (!empty($call)) {
501
+			call_user_func($call);
502
+	}
503
+	}
497 504
 
498 505
 /**
499 506
  * The main administration section.
@@ -547,13 +554,14 @@  discard block
 block discarded – undo
547 554
 
548 555
 	$context['sub_template'] = $context['admin_area'] == 'credits' ? 'credits' : 'admin';
549 556
 	$context['page_title'] = $context['admin_area'] == 'credits' ? $txt['support_credits_title'] : $txt['admin_center'];
550
-	if ($context['admin_area'] != 'credits')
551
-		$context[$context['admin_menu_name']]['tab_data'] = array(
557
+	if ($context['admin_area'] != 'credits') {
558
+			$context[$context['admin_menu_name']]['tab_data'] = array(
552 559
 			'title' => $txt['admin_center'],
553 560
 			'help' => '',
554 561
 			'description' => '<strong>' . $txt['hello_guest'] . ' ' . $context['user']['name'] . '!</strong>
555 562
 						' . sprintf($txt['admin_main_welcome'], $txt['admin_center'], $txt['help'], $txt['help']),
556 563
 		);
564
+	}
557 565
 
558 566
 	// Lastly, fill in the blanks in the support resources paragraphs.
559 567
 	$txt['support_resources_p1'] = sprintf($txt['support_resources_p1'],
@@ -571,9 +579,10 @@  discard block
 block discarded – undo
571 579
 		'https://www.simplemachines.org/redirect/customize_support'
572 580
 	);
573 581
 
574
-	if ($context['admin_area'] == 'admin')
575
-		loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin');
576
-}
582
+	if ($context['admin_area'] == 'admin') {
583
+			loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin');
584
+	}
585
+	}
577 586
 
578 587
 /**
579 588
  * Get one of the admin information files from Simple Machines.
@@ -584,8 +593,9 @@  discard block
 block discarded – undo
584 593
 
585 594
 	setMemoryLimit('32M');
586 595
 
587
-	if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename']))
588
-		fatal_lang_error('no_access', false);
596
+	if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename'])) {
597
+			fatal_lang_error('no_access', false);
598
+	}
589 599
 
590 600
 	// Strip off the forum cache part or we won't find it...
591 601
 	$_REQUEST['filename'] = str_replace($modSettings['browser_cache'], '', $_REQUEST['filename']);
@@ -600,27 +610,30 @@  discard block
 block discarded – undo
600 610
 		)
601 611
 	);
602 612
 
603
-	if ($smcFunc['db_num_rows']($request) == 0)
604
-		fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404);
613
+	if ($smcFunc['db_num_rows']($request) == 0) {
614
+			fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404);
615
+	}
605 616
 
606 617
 	list ($file_data, $filetype) = $smcFunc['db_fetch_row']($request);
607 618
 	$smcFunc['db_free_result']($request);
608 619
 
609 620
 	// @todo Temp
610 621
 	// Figure out if sesc is still being used.
611
-	if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript')
612
-		$file_data = '
622
+	if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript') {
623
+			$file_data = '
613 624
 if (!(\'smfForum_sessionvar\' in window))
614 625
 	window.smfForum_sessionvar = \'sesc\';
615 626
 ' . strtr($file_data, array(';sesc=' => ';\' + window.smfForum_sessionvar + \'='));
627
+	}
616 628
 
617 629
 	$context['template_layers'] = array();
618 630
 	// Lets make sure we aren't going to output anything nasty.
619 631
 	@ob_end_clean();
620
-	if (!empty($modSettings['enableCompressedOutput']))
621
-		@ob_start('ob_gzhandler');
622
-	else
623
-		@ob_start();
632
+	if (!empty($modSettings['enableCompressedOutput'])) {
633
+			@ob_start('ob_gzhandler');
634
+	} else {
635
+			@ob_start();
636
+	}
624 637
 
625 638
 	// Make sure they know what type of file we are.
626 639
 	header('Content-Type: ' . $filetype);
@@ -660,11 +673,12 @@  discard block
 block discarded – undo
660 673
 		updateAdminPreferences();
661 674
 	}
662 675
 
663
-	if (trim($context['search_term']) == '')
664
-		$context['search_results'] = array();
665
-	else
666
-		call_helper($subActions[$context['search_type']]);
667
-}
676
+	if (trim($context['search_term']) == '') {
677
+			$context['search_results'] = array();
678
+	} else {
679
+			call_helper($subActions[$context['search_type']]);
680
+	}
681
+	}
668 682
 
669 683
 /**
670 684
  * A complicated but relatively quick internal search.
@@ -728,8 +742,9 @@  discard block
 block discarded – undo
728 742
 
729 743
 	loadLanguage(implode('+', $language_files));
730 744
 
731
-	foreach ($include_files as $file)
732
-		require_once($sourcedir . '/' . $file . '.php');
745
+	foreach ($include_files as $file) {
746
+			require_once($sourcedir . '/' . $file . '.php');
747
+	}
733 748
 
734 749
 	/* This is the huge array that defines everything... it's a huge array of items formatted as follows:
735 750
 		0 = Language index (Can be array of indexes) to search through for this setting.
@@ -753,11 +768,12 @@  discard block
 block discarded – undo
753 768
 		foreach ($section['areas'] as $menu_key => $menu_item)
754 769
 		{
755 770
 			$search_data['sections'][] = array($menu_item['label'], 'area=' . $menu_key);
756
-			if (!empty($menu_item['subsections']))
757
-				foreach ($menu_item['subsections'] as $key => $sublabel)
771
+			if (!empty($menu_item['subsections'])) {
772
+							foreach ($menu_item['subsections'] as $key => $sublabel)
758 773
 				{
759 774
 					if (isset($sublabel['label']))
760 775
 						$search_data['sections'][] = array($sublabel['label'], 'area=' . $menu_key . ';sa=' . $key);
776
+			}
761 777
 				}
762 778
 		}
763 779
 	}
@@ -767,9 +783,10 @@  discard block
 block discarded – undo
767 783
 		// Get a list of their variables.
768 784
 		$config_vars = $setting_area[0](true);
769 785
 
770
-		foreach ($config_vars as $var)
771
-			if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc')))
786
+		foreach ($config_vars as $var) {
787
+					if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc')))
772 788
 				$search_data['settings'][] = array($var[(isset($var[2]) && in_array($var[2], array('file', 'db'))) ? 0 : 1], $setting_area[1], 'alttxt' => (isset($var[2]) && in_array($var[2], array('file', 'db'))) || isset($var[3]) ? (in_array($var[2], array('file', 'db')) ? $var[1] : $var[3]) : '');
789
+		}
773 790
 	}
774 791
 
775 792
 	$context['page_title'] = $txt['admin_search_results'];
@@ -782,8 +799,9 @@  discard block
 block discarded – undo
782 799
 		foreach ($data as $item)
783 800
 		{
784 801
 			$found = false;
785
-			if (!is_array($item[0]))
786
-				$item[0] = array($item[0]);
802
+			if (!is_array($item[0])) {
803
+							$item[0] = array($item[0]);
804
+			}
787 805
 			foreach ($item[0] as $term)
788 806
 			{
789 807
 				if (stripos($term, $search_term) !== false || (isset($txt[$term]) && stripos($txt[$term], $search_term) !== false) || (isset($txt['setting_' . $term]) && stripos($txt['setting_' . $term], $search_term) !== false))
@@ -841,8 +859,9 @@  discard block
 block discarded – undo
841 859
 	$postVars = explode(' ', $context['search_term']);
842 860
 
843 861
 	// Encode the search data.
844
-	foreach ($postVars as $k => $v)
845
-		$postVars[$k] = urlencode($v);
862
+	foreach ($postVars as $k => $v) {
863
+			$postVars[$k] = urlencode($v);
864
+	}
846 865
 
847 866
 	// This is what we will send.
848 867
 	$postVars = implode('+', $postVars);
@@ -854,8 +873,9 @@  discard block
 block discarded – undo
854 873
 	$search_results = fetch_web_data($context['doc_apiurl'] . '?action=query&list=search&srprop=timestamp|snippet&format=xml&srwhat=text&srsearch=' . $postVars);
855 874
 
856 875
 	// If we didn't get any xml back we are in trouble - perhaps the doc site is overloaded?
857
-	if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true)
858
-		fatal_lang_error('cannot_connect_doc_site');
876
+	if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true) {
877
+			fatal_lang_error('cannot_connect_doc_site');
878
+	}
859 879
 
860 880
 	$search_results = $matches[1];
861 881
 
@@ -867,8 +887,9 @@  discard block
 block discarded – undo
867 887
 	$results = new xmlArray($search_results, false);
868 888
 
869 889
 	// Move through the api layer.
870
-	if (!$results->exists('api'))
871
-		fatal_lang_error('cannot_connect_doc_site');
890
+	if (!$results->exists('api')) {
891
+			fatal_lang_error('cannot_connect_doc_site');
892
+	}
872 893
 
873 894
 	// Are there actually some results?
874 895
 	if ($results->exists('api/query/search/p'))
@@ -904,8 +925,9 @@  discard block
 block discarded – undo
904 925
 	);
905 926
 
906 927
 	// If it's not got a sa set it must have come here for first time, pretend error log should be reversed.
907
-	if (!isset($_REQUEST['sa']))
908
-		$_REQUEST['desc'] = true;
928
+	if (!isset($_REQUEST['sa'])) {
929
+			$_REQUEST['desc'] = true;
930
+	}
909 931
 
910 932
 	// Setup some tab stuff.
911 933
 	$context[$context['admin_menu_name']]['tab_data'] = array(
@@ -955,9 +977,10 @@  discard block
 block discarded – undo
955 977
 	unset($_SESSION['admin_time']);
956 978
 
957 979
 	// Clean any admin tokens as well.
958
-	foreach ($_SESSION['token'] as $key => $token)
959
-		if (strpos($key, '-admin') !== false)
980
+	foreach ($_SESSION['token'] as $key => $token) {
981
+			if (strpos($key, '-admin') !== false)
960 982
 			unset($_SESSION['token'][$key]);
983
+	}
961 984
 
962 985
 	redirectexit();
963 986
 }
Please login to merge, or discard this patch.
other/install.php 1 patch
Braces   +452 added lines, -336 removed lines patch added patch discarded remove patch
@@ -20,8 +20,9 @@  discard block
 block discarded – undo
20 20
 // ><html dir="ltr"><head><title>Error!</title></head><body>Sorry, this installer requires PHP!<div style="display: none;">
21 21
 
22 22
 // Let's pull in useful classes
23
-if (!defined('SMF'))
23
+if (!defined('SMF')) {
24 24
 	define('SMF', 1);
25
+}
25 26
 
26 27
 require_once('Sources/Class-Package.php');
27 28
 
@@ -63,10 +64,11 @@  discard block
 block discarded – undo
63 64
 
64 65
 			list ($charcode) = pg_fetch_row($request);
65 66
 
66
-			if ($charcode == 'UTF8')
67
-				return true;
68
-			else
69
-				return false;
67
+			if ($charcode == 'UTF8') {
68
+							return true;
69
+			} else {
70
+							return false;
71
+			}
70 72
 		},
71 73
 		'utf8_version' => '8.0',
72 74
 		'utf8_version_check' => '$request = pg_query(\'SELECT version()\'); list ($version) = pg_fetch_row($request); list($pgl, $version) = explode(" ", $version); return $version;',
@@ -76,12 +78,14 @@  discard block
 block discarded – undo
76 78
 			$value = preg_replace('~[^A-Za-z0-9_\$]~', '', $value);
77 79
 
78 80
 			// Is it reserved?
79
-			if ($value == 'pg_')
80
-				return $txt['error_db_prefix_reserved'];
81
+			if ($value == 'pg_') {
82
+							return $txt['error_db_prefix_reserved'];
83
+			}
81 84
 
82 85
 			// Is the prefix numeric?
83
-			if (preg_match('~^\d~', $value))
84
-				return $txt['error_db_prefix_numeric'];
86
+			if (preg_match('~^\d~', $value)) {
87
+							return $txt['error_db_prefix_numeric'];
88
+			}
85 89
 
86 90
 			return true;
87 91
 		},
@@ -128,10 +132,11 @@  discard block
 block discarded – undo
128 132
 		$incontext['skip'] = false;
129 133
 
130 134
 		// Call the step and if it returns false that means pause!
131
-		if (function_exists($step[2]) && $step[2]() === false)
132
-			break;
133
-		elseif (function_exists($step[2]))
134
-			$incontext['current_step']++;
135
+		if (function_exists($step[2]) && $step[2]() === false) {
136
+					break;
137
+		} elseif (function_exists($step[2])) {
138
+					$incontext['current_step']++;
139
+		}
135 140
 
136 141
 		// No warnings pass on.
137 142
 		$incontext['warning'] = '';
@@ -147,8 +152,9 @@  discard block
 block discarded – undo
147 152
 	global $databases;
148 153
 
149 154
 	// Just so people using older versions of PHP aren't left in the cold.
150
-	if (!isset($_SERVER['PHP_SELF']))
151
-		$_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php';
155
+	if (!isset($_SERVER['PHP_SELF'])) {
156
+			$_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php';
157
+	}
152 158
 
153 159
 	// Enable error reporting for fatal errors.
154 160
 	error_reporting(E_ERROR | E_PARSE);
@@ -164,21 +170,23 @@  discard block
 block discarded – undo
164 170
 	{
165 171
 		ob_start();
166 172
 
167
-		if (ini_get('session.save_handler') == 'user')
168
-			@ini_set('session.save_handler', 'files');
169
-		if (function_exists('session_start'))
170
-			@session_start();
171
-	}
172
-	else
173
+		if (ini_get('session.save_handler') == 'user') {
174
+					@ini_set('session.save_handler', 'files');
175
+		}
176
+		if (function_exists('session_start')) {
177
+					@session_start();
178
+		}
179
+	} else
173 180
 	{
174 181
 		ob_start('ob_gzhandler');
175 182
 
176
-		if (ini_get('session.save_handler') == 'user')
177
-			@ini_set('session.save_handler', 'files');
183
+		if (ini_get('session.save_handler') == 'user') {
184
+					@ini_set('session.save_handler', 'files');
185
+		}
178 186
 		session_start();
179 187
 
180
-		if (!headers_sent())
181
-			echo '<!DOCTYPE html>
188
+		if (!headers_sent()) {
189
+					echo '<!DOCTYPE html>
182 190
 <html>
183 191
 	<head>
184 192
 		<title>', htmlspecialchars($_GET['pass_string']), '</title>
@@ -187,14 +195,16 @@  discard block
 block discarded – undo
187 195
 		<strong>', htmlspecialchars($_GET['pass_string']), '</strong>
188 196
 	</body>
189 197
 </html>';
198
+		}
190 199
 		exit;
191 200
 	}
192 201
 
193 202
 	// Add slashes, as long as they aren't already being added.
194
-	if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0)
195
-		foreach ($_POST as $k => $v)
203
+	if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) {
204
+			foreach ($_POST as $k => $v)
196 205
 			if (strpos($k, 'password') === false && strpos($k, 'db_passwd') === false)
197 206
 				$_POST[$k] = addslashes($v);
207
+	}
198 208
 
199 209
 	// This is really quite simple; if ?delete is on the URL, delete the installer...
200 210
 	if (isset($_GET['delete']))
@@ -215,8 +225,7 @@  discard block
 block discarded – undo
215 225
 			$ftp->close();
216 226
 
217 227
 			unset($_SESSION['installer_temp_ftp']);
218
-		}
219
-		else
228
+		} else
220 229
 		{
221 230
 			@unlink(__FILE__);
222 231
 
@@ -237,10 +246,11 @@  discard block
 block discarded – undo
237 246
 	{
238 247
 		// Get PHP's default timezone, if set
239 248
 		$ini_tz = ini_get('date.timezone');
240
-		if (!empty($ini_tz))
241
-			$timezone_id = $ini_tz;
242
-		else
243
-			$timezone_id = '';
249
+		if (!empty($ini_tz)) {
250
+					$timezone_id = $ini_tz;
251
+		} else {
252
+					$timezone_id = '';
253
+		}
244 254
 
245 255
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
246 256
 		if (!in_array($timezone_id, timezone_identifiers_list()))
@@ -270,8 +280,9 @@  discard block
 block discarded – undo
270 280
 		$dir = dir(dirname(__FILE__) . '/Themes/default/languages');
271 281
 		while ($entry = $dir->read())
272 282
 		{
273
-			if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php')
274
-				$incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12));
283
+			if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') {
284
+							$incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12));
285
+			}
275 286
 		}
276 287
 		$dir->close();
277 288
 	}
@@ -306,10 +317,11 @@  discard block
 block discarded – undo
306 317
 	}
307 318
 
308 319
 	// Override the language file?
309
-	if (isset($_GET['lang_file']))
310
-		$_SESSION['installer_temp_lang'] = $_GET['lang_file'];
311
-	elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file']))
312
-		$_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file'];
320
+	if (isset($_GET['lang_file'])) {
321
+			$_SESSION['installer_temp_lang'] = $_GET['lang_file'];
322
+	} elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) {
323
+			$_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file'];
324
+	}
313 325
 
314 326
 	// Make sure it exists, if it doesn't reset it.
315 327
 	if (!isset($_SESSION['installer_temp_lang']) || preg_match('~[^\\w_\\-.]~', $_SESSION['installer_temp_lang']) === 1 || !file_exists(dirname(__FILE__) . '/Themes/default/languages/' . $_SESSION['installer_temp_lang']))
@@ -318,8 +330,9 @@  discard block
 block discarded – undo
318 330
 		list ($_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
319 331
 
320 332
 		// If we have english and some other language, use the other language.  We Americans hate english :P.
321
-		if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1)
322
-			list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
333
+		if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) {
334
+					list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
335
+		}
323 336
 	}
324 337
 
325 338
 	// And now include the actual language file itself.
@@ -332,15 +345,18 @@  discard block
 block discarded – undo
332 345
 	global $db_prefix, $db_connection, $sourcedir, $smcFunc, $modSettings;
333 346
 	global $db_server, $db_passwd, $db_type, $db_name, $db_user, $db_persist;
334 347
 
335
-	if (empty($sourcedir))
336
-		$sourcedir = dirname(__FILE__) . '/Sources';
348
+	if (empty($sourcedir)) {
349
+			$sourcedir = dirname(__FILE__) . '/Sources';
350
+	}
337 351
 
338 352
 	// Need this to check whether we need the database password.
339 353
 	require(dirname(__FILE__) . '/Settings.php');
340
-	if (!defined('SMF'))
341
-		define('SMF', 1);
342
-	if (empty($smcFunc))
343
-		$smcFunc = array();
354
+	if (!defined('SMF')) {
355
+			define('SMF', 1);
356
+	}
357
+	if (empty($smcFunc)) {
358
+			$smcFunc = array();
359
+	}
344 360
 
345 361
 	$modSettings['disableQueryCheck'] = true;
346 362
 
@@ -348,8 +364,9 @@  discard block
 block discarded – undo
348 364
 	if (!$db_connection)
349 365
 	{
350 366
 		require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
351
-		if (version_compare(PHP_VERSION, '5', '<'))
352
-			require_once($sourcedir . '/Subs-Compat.php');
367
+		if (version_compare(PHP_VERSION, '5', '<')) {
368
+					require_once($sourcedir . '/Subs-Compat.php');
369
+		}
353 370
 
354 371
 		$db_options = array('persist' => $db_persist);
355 372
 		$port = '';
@@ -360,19 +377,20 @@  discard block
 block discarded – undo
360 377
 			if ($db_type == 'mysql')
361 378
 			{
362 379
 				$port = ((int) $_POST['db_port'] == ini_get($db_type . 'default_port')) ? '' : (int) $_POST['db_port'];
363
-			}
364
-			elseif ($db_type == 'postgresql')
380
+			} elseif ($db_type == 'postgresql')
365 381
 			{
366 382
 				// PostgreSQL doesn't have a default port setting in php.ini, so just check against the default
367 383
 				$port = ((int) $_POST['db_port'] == 5432) ? '' : (int) $_POST['db_port'];
368 384
 			}
369 385
 		}
370 386
 
371
-		if (!empty($port))
372
-			$db_options['port'] = $port;
387
+		if (!empty($port)) {
388
+					$db_options['port'] = $port;
389
+		}
373 390
 
374
-		if (!$db_connection)
375
-			$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options);
391
+		if (!$db_connection) {
392
+					$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options);
393
+		}
376 394
 	}
377 395
 }
378 396
 
@@ -400,8 +418,9 @@  discard block
 block discarded – undo
400 418
 		// @todo REMOVE THIS!!
401 419
 		else
402 420
 		{
403
-			if (function_exists('doStep' . $_GET['step']))
404
-				call_user_func('doStep' . $_GET['step']);
421
+			if (function_exists('doStep' . $_GET['step'])) {
422
+							call_user_func('doStep' . $_GET['step']);
423
+			}
405 424
 		}
406 425
 		// Show the footer.
407 426
 		template_install_below();
@@ -419,8 +438,9 @@  discard block
 block discarded – undo
419 438
 	$incontext['sub_template'] = 'welcome_message';
420 439
 
421 440
 	// Done the submission?
422
-	if (isset($_POST['contbutt']))
423
-		return true;
441
+	if (isset($_POST['contbutt'])) {
442
+			return true;
443
+	}
424 444
 
425 445
 	// See if we think they have already installed it?
426 446
 	if (is_readable(dirname(__FILE__) . '/Settings.php'))
@@ -428,14 +448,17 @@  discard block
 block discarded – undo
428 448
 		$probably_installed = 0;
429 449
 		foreach (file(dirname(__FILE__) . '/Settings.php') as $line)
430 450
 		{
431
-			if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line))
432
-				$probably_installed++;
433
-			if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line))
434
-				$probably_installed++;
451
+			if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) {
452
+							$probably_installed++;
453
+			}
454
+			if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) {
455
+							$probably_installed++;
456
+			}
435 457
 		}
436 458
 
437
-		if ($probably_installed == 2)
438
-			$incontext['warning'] = $txt['error_already_installed'];
459
+		if ($probably_installed == 2) {
460
+					$incontext['warning'] = $txt['error_already_installed'];
461
+		}
439 462
 	}
440 463
 
441 464
 	// Is some database support even compiled in?
@@ -450,45 +473,54 @@  discard block
 block discarded – undo
450 473
 				$databases[$key]['supported'] = false;
451 474
 				$notFoundSQLFile = true;
452 475
 				$txt['error_db_script_missing'] = sprintf($txt['error_db_script_missing'], 'install_' . $GLOBALS['db_script_version'] . '_' . $type . '.sql');
476
+			} else {
477
+							$incontext['supported_databases'][] = $db;
453 478
 			}
454
-			else
455
-				$incontext['supported_databases'][] = $db;
456 479
 		}
457 480
 	}
458 481
 
459 482
 	// Check the PHP version.
460
-	if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>=')))
461
-		$error = 'error_php_too_low';
483
+	if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) {
484
+			$error = 'error_php_too_low';
485
+	}
462 486
 	// Make sure we have a supported database
463
-	elseif (empty($incontext['supported_databases']))
464
-		$error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing';
487
+	elseif (empty($incontext['supported_databases'])) {
488
+			$error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing';
489
+	}
465 490
 	// How about session support?  Some crazy sysadmin remove it?
466
-	elseif (!function_exists('session_start'))
467
-		$error = 'error_session_missing';
491
+	elseif (!function_exists('session_start')) {
492
+			$error = 'error_session_missing';
493
+	}
468 494
 	// Make sure they uploaded all the files.
469
-	elseif (!file_exists(dirname(__FILE__) . '/index.php'))
470
-		$error = 'error_missing_files';
495
+	elseif (!file_exists(dirname(__FILE__) . '/index.php')) {
496
+			$error = 'error_missing_files';
497
+	}
471 498
 	// Very simple check on the session.save_path for Windows.
472 499
 	// @todo Move this down later if they don't use database-driven sessions?
473
-	elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\')
474
-		$error = 'error_session_save_path';
500
+	elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') {
501
+			$error = 'error_session_save_path';
502
+	}
475 503
 
476 504
 	// Since each of the three messages would look the same, anyway...
477
-	if (isset($error))
478
-		$incontext['error'] = $txt[$error];
505
+	if (isset($error)) {
506
+			$incontext['error'] = $txt[$error];
507
+	}
479 508
 
480 509
 	// Mod_security blocks everything that smells funny. Let SMF handle security.
481
-	if (!fixModSecurity() && !isset($_GET['overmodsecurity']))
482
-		$incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again'];
510
+	if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) {
511
+			$incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again'];
512
+	}
483 513
 
484 514
 	// Confirm mbstring is loaded...
485
-	if (!extension_loaded('mbstring'))
486
-		$incontext['error'] = $txt['install_no_mbstring'];
515
+	if (!extension_loaded('mbstring')) {
516
+			$incontext['error'] = $txt['install_no_mbstring'];
517
+	}
487 518
 
488 519
 	// Check for https stream support.
489 520
 	$supported_streams = stream_get_wrappers();
490
-	if (!in_array('https', $supported_streams))
491
-		$incontext['warning'] = $txt['install_no_https'];
521
+	if (!in_array('https', $supported_streams)) {
522
+			$incontext['warning'] = $txt['install_no_https'];
523
+	}
492 524
 
493 525
 	return false;
494 526
 }
@@ -514,12 +546,14 @@  discard block
 block discarded – undo
514 546
 		'db_last_error.php',
515 547
 	);
516 548
 
517
-	foreach ($incontext['detected_languages'] as $lang => $temp)
518
-		$extra_files[] = 'Themes/default/languages/' . $lang;
549
+	foreach ($incontext['detected_languages'] as $lang => $temp) {
550
+			$extra_files[] = 'Themes/default/languages/' . $lang;
551
+	}
519 552
 
520 553
 	// With mod_security installed, we could attempt to fix it with .htaccess.
521
-	if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules()))
522
-		$writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.';
554
+	if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) {
555
+			$writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.';
556
+	}
523 557
 
524 558
 	$failed_files = array();
525 559
 
@@ -531,20 +565,23 @@  discard block
 block discarded – undo
531 565
 		foreach ($writable_files as $file)
532 566
 		{
533 567
 			// Some files won't exist, try to address up front
534
-			if (!file_exists(dirname(__FILE__) . '/' . $file))
535
-				@touch(dirname(__FILE__) . '/' . $file);
568
+			if (!file_exists(dirname(__FILE__) . '/' . $file)) {
569
+							@touch(dirname(__FILE__) . '/' . $file);
570
+			}
536 571
 			// NOW do the writable check...
537 572
 			if (!is_writable(dirname(__FILE__) . '/' . $file))
538 573
 			{
539 574
 				@chmod(dirname(__FILE__) . '/' . $file, 0755);
540 575
 
541 576
 				// Well, 755 hopefully worked... if not, try 777.
542
-				if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777))
543
-					$failed_files[] = $file;
577
+				if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) {
578
+									$failed_files[] = $file;
579
+				}
544 580
 			}
545 581
 		}
546
-		foreach ($extra_files as $file)
547
-			@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
582
+		foreach ($extra_files as $file) {
583
+					@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
584
+		}
548 585
 	}
549 586
 	// Windows is trickier.  Let's try opening for r+...
550 587
 	else
@@ -554,30 +591,35 @@  discard block
 block discarded – undo
554 591
 		foreach ($writable_files as $file)
555 592
 		{
556 593
 			// Folders can't be opened for write... but the index.php in them can ;)
557
-			if (is_dir(dirname(__FILE__) . '/' . $file))
558
-				$file .= '/index.php';
594
+			if (is_dir(dirname(__FILE__) . '/' . $file)) {
595
+							$file .= '/index.php';
596
+			}
559 597
 
560 598
 			// Funny enough, chmod actually does do something on windows - it removes the read only attribute.
561 599
 			@chmod(dirname(__FILE__) . '/' . $file, 0777);
562 600
 			$fp = @fopen(dirname(__FILE__) . '/' . $file, 'r+');
563 601
 
564 602
 			// Hmm, okay, try just for write in that case...
565
-			if (!is_resource($fp))
566
-				$fp = @fopen(dirname(__FILE__) . '/' . $file, 'w');
603
+			if (!is_resource($fp)) {
604
+							$fp = @fopen(dirname(__FILE__) . '/' . $file, 'w');
605
+			}
567 606
 
568
-			if (!is_resource($fp))
569
-				$failed_files[] = $file;
607
+			if (!is_resource($fp)) {
608
+							$failed_files[] = $file;
609
+			}
570 610
 
571 611
 			@fclose($fp);
572 612
 		}
573
-		foreach ($extra_files as $file)
574
-			@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
613
+		foreach ($extra_files as $file) {
614
+					@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
615
+		}
575 616
 	}
576 617
 
577 618
 	$failure = count($failed_files) >= 1;
578 619
 
579
-	if (!isset($_SERVER))
580
-		return !$failure;
620
+	if (!isset($_SERVER)) {
621
+			return !$failure;
622
+	}
581 623
 
582 624
 	// Put the list into context.
583 625
 	$incontext['failed_files'] = $failed_files;
@@ -625,19 +667,23 @@  discard block
 block discarded – undo
625 667
 
626 668
 		if (!isset($ftp) || $ftp->error !== false)
627 669
 		{
628
-			if (!isset($ftp))
629
-				$ftp = new ftp_connection(null);
670
+			if (!isset($ftp)) {
671
+							$ftp = new ftp_connection(null);
672
+			}
630 673
 			// Save the error so we can mess with listing...
631
-			elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message))
632
-				$incontext['ftp_errors'][] = $ftp->last_message;
674
+			elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) {
675
+							$incontext['ftp_errors'][] = $ftp->last_message;
676
+			}
633 677
 
634 678
 			list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__));
635 679
 
636
-			if (empty($_POST['ftp_path']) && $found_path)
637
-				$_POST['ftp_path'] = $detect_path;
680
+			if (empty($_POST['ftp_path']) && $found_path) {
681
+							$_POST['ftp_path'] = $detect_path;
682
+			}
638 683
 
639
-			if (!isset($_POST['ftp_username']))
640
-				$_POST['ftp_username'] = $username;
684
+			if (!isset($_POST['ftp_username'])) {
685
+							$_POST['ftp_username'] = $username;
686
+			}
641 687
 
642 688
 			// Set the username etc, into context.
643 689
 			$incontext['ftp'] = array(
@@ -649,8 +695,7 @@  discard block
 block discarded – undo
649 695
 			);
650 696
 
651 697
 			return false;
652
-		}
653
-		else
698
+		} else
654 699
 		{
655 700
 			$_SESSION['installer_temp_ftp'] = array(
656 701
 				'server' => $_POST['ftp_server'],
@@ -664,10 +709,12 @@  discard block
 block discarded – undo
664 709
 
665 710
 			foreach ($failed_files as $file)
666 711
 			{
667
-				if (!is_writable(dirname(__FILE__) . '/' . $file))
668
-					$ftp->chmod($file, 0755);
669
-				if (!is_writable(dirname(__FILE__) . '/' . $file))
670
-					$ftp->chmod($file, 0777);
712
+				if (!is_writable(dirname(__FILE__) . '/' . $file)) {
713
+									$ftp->chmod($file, 0755);
714
+				}
715
+				if (!is_writable(dirname(__FILE__) . '/' . $file)) {
716
+									$ftp->chmod($file, 0777);
717
+				}
671 718
 				if (!is_writable(dirname(__FILE__) . '/' . $file))
672 719
 				{
673 720
 					$failed_files_updated[] = $file;
@@ -723,15 +770,17 @@  discard block
 block discarded – undo
723 770
 
724 771
 			if (!$foundOne)
725 772
 			{
726
-				if (isset($db['default_host']))
727
-					$incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost';
773
+				if (isset($db['default_host'])) {
774
+									$incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost';
775
+				}
728 776
 				if (isset($db['default_user']))
729 777
 				{
730 778
 					$incontext['db']['user'] = ini_get($db['default_user']);
731 779
 					$incontext['db']['name'] = ini_get($db['default_user']);
732 780
 				}
733
-				if (isset($db['default_password']))
734
-					$incontext['db']['pass'] = ini_get($db['default_password']);
781
+				if (isset($db['default_password'])) {
782
+									$incontext['db']['pass'] = ini_get($db['default_password']);
783
+				}
735 784
 
736 785
 				// For simplicity and less confusion, leave the port blank by default
737 786
 				$incontext['db']['port'] = '';
@@ -750,10 +799,10 @@  discard block
 block discarded – undo
750 799
 		$incontext['db']['server'] = $_POST['db_server'];
751 800
 		$incontext['db']['prefix'] = $_POST['db_prefix'];
752 801
 
753
-		if (!empty($_POST['db_port']))
754
-			$incontext['db']['port'] = $_POST['db_port'];
755
-	}
756
-	else
802
+		if (!empty($_POST['db_port'])) {
803
+					$incontext['db']['port'] = $_POST['db_port'];
804
+		}
805
+	} else
757 806
 	{
758 807
 		$incontext['db']['prefix'] = 'smf_';
759 808
 	}
@@ -789,10 +838,11 @@  discard block
 block discarded – undo
789 838
 		if (!empty($_POST['db_port']))
790 839
 		{
791 840
 			// For MySQL, we can get the "default port" from PHP. PostgreSQL has no such option though.
792
-			if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port'))
793
-				$vars['db_port'] = (int) $_POST['db_port'];
794
-			elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432)
795
-				$vars['db_port'] = (int) $_POST['db_port'];
841
+			if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) {
842
+							$vars['db_port'] = (int) $_POST['db_port'];
843
+			} elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) {
844
+							$vars['db_port'] = (int) $_POST['db_port'];
845
+			}
796 846
 		}
797 847
 
798 848
 		// God I hope it saved!
@@ -805,8 +855,9 @@  discard block
 block discarded – undo
805 855
 		// Make sure it works.
806 856
 		require(dirname(__FILE__) . '/Settings.php');
807 857
 
808
-		if (empty($sourcedir))
809
-			$sourcedir = dirname(__FILE__) . '/Sources';
858
+		if (empty($sourcedir)) {
859
+					$sourcedir = dirname(__FILE__) . '/Sources';
860
+		}
810 861
 
811 862
 		// Better find the database file!
812 863
 		if (!file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
@@ -816,18 +867,21 @@  discard block
 block discarded – undo
816 867
 		}
817 868
 
818 869
 		// Now include it for database functions!
819
-		if (!defined('SMF'))
820
-			define('SMF', 1);
870
+		if (!defined('SMF')) {
871
+					define('SMF', 1);
872
+		}
821 873
 
822 874
 		$modSettings['disableQueryCheck'] = true;
823
-		if (empty($smcFunc))
824
-			$smcFunc = array();
875
+		if (empty($smcFunc)) {
876
+					$smcFunc = array();
877
+		}
825 878
 
826 879
 			require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
827 880
 
828 881
 		// What - running PHP4? The shame!
829
-		if (version_compare(PHP_VERSION, '5', '<'))
830
-			require_once($sourcedir . '/Subs-Compat.php');
882
+		if (version_compare(PHP_VERSION, '5', '<')) {
883
+					require_once($sourcedir . '/Subs-Compat.php');
884
+		}
831 885
 
832 886
 		// Attempt a connection.
833 887
 		$needsDB = !empty($databases[$db_type]['always_has_db']);
@@ -915,12 +969,14 @@  discard block
 block discarded – undo
915 969
 	$incontext['page_title'] = $txt['install_settings'];
916 970
 
917 971
 	// Let's see if we got the database type correct.
918
-	if (isset($_POST['db_type'], $databases[$_POST['db_type']]))
919
-		$db_type = $_POST['db_type'];
972
+	if (isset($_POST['db_type'], $databases[$_POST['db_type']])) {
973
+			$db_type = $_POST['db_type'];
974
+	}
920 975
 
921 976
 	// Else we'd better be able to get the connection.
922
-	else
923
-		load_database();
977
+	else {
978
+			load_database();
979
+	}
924 980
 
925 981
 	$db_type = isset($_POST['db_type']) ? $_POST['db_type'] : $db_type;
926 982
 
@@ -957,18 +1013,21 @@  discard block
 block discarded – undo
957 1013
 	// Submitting?
958 1014
 	if (isset($_POST['boardurl']))
959 1015
 	{
960
-		if (substr($_POST['boardurl'], -10) == '/index.php')
961
-			$_POST['boardurl'] = substr($_POST['boardurl'], 0, -10);
962
-		elseif (substr($_POST['boardurl'], -1) == '/')
963
-			$_POST['boardurl'] = substr($_POST['boardurl'], 0, -1);
964
-		if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://')
965
-			$_POST['boardurl'] = 'http://' . $_POST['boardurl'];
1016
+		if (substr($_POST['boardurl'], -10) == '/index.php') {
1017
+					$_POST['boardurl'] = substr($_POST['boardurl'], 0, -10);
1018
+		} elseif (substr($_POST['boardurl'], -1) == '/') {
1019
+					$_POST['boardurl'] = substr($_POST['boardurl'], 0, -1);
1020
+		}
1021
+		if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') {
1022
+					$_POST['boardurl'] = 'http://' . $_POST['boardurl'];
1023
+		}
966 1024
 
967 1025
 		//Make sure boardurl is aligned with ssl setting
968
-		if (empty($_POST['force_ssl']))
969
-			$_POST['boardurl'] = strtr($_POST['boardurl'], array('https://' => 'http://'));
970
-		else
971
-			$_POST['boardurl'] = strtr($_POST['boardurl'], array('http://' => 'https://'));		
1026
+		if (empty($_POST['force_ssl'])) {
1027
+					$_POST['boardurl'] = strtr($_POST['boardurl'], array('https://' => 'http://'));
1028
+		} else {
1029
+					$_POST['boardurl'] = strtr($_POST['boardurl'], array('http://' => 'https://'));
1030
+		}
972 1031
 
973 1032
 		// Save these variables.
974 1033
 		$vars = array(
@@ -1007,10 +1066,10 @@  discard block
 block discarded – undo
1007 1066
 			{
1008 1067
 				$incontext['error'] = sprintf($txt['error_utf8_version'], $databases[$db_type]['utf8_version']);
1009 1068
 				return false;
1010
-			}
1011
-			else
1012
-				// Set the character set here.
1069
+			} else {
1070
+							// Set the character set here.
1013 1071
 				updateSettingsFile(array('db_character_set' => 'utf8'));
1072
+			}
1014 1073
 		}
1015 1074
 
1016 1075
 		// Good, skip on.
@@ -1030,8 +1089,9 @@  discard block
 block discarded – undo
1030 1089
 	$incontext['continue'] = 1;
1031 1090
 
1032 1091
 	// Already done?
1033
-	if (isset($_POST['pop_done']))
1034
-		return true;
1092
+	if (isset($_POST['pop_done'])) {
1093
+			return true;
1094
+	}
1035 1095
 
1036 1096
 	// Reload settings.
1037 1097
 	require(dirname(__FILE__) . '/Settings.php');
@@ -1049,8 +1109,9 @@  discard block
 block discarded – undo
1049 1109
 	$modSettings = array();
1050 1110
 	if ($result !== false)
1051 1111
 	{
1052
-		while ($row = $smcFunc['db_fetch_assoc']($result))
1053
-			$modSettings[$row['variable']] = $row['value'];
1112
+		while ($row = $smcFunc['db_fetch_assoc']($result)) {
1113
+					$modSettings[$row['variable']] = $row['value'];
1114
+		}
1054 1115
 		$smcFunc['db_free_result']($result);
1055 1116
 
1056 1117
 		// Do they match?  If so, this is just a refresh so charge on!
@@ -1063,20 +1124,22 @@  discard block
 block discarded – undo
1063 1124
 	$modSettings['disableQueryCheck'] = true;
1064 1125
 
1065 1126
 	// If doing UTF8, select it. PostgreSQL requires passing it as a string...
1066
-	if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support']))
1067
-		$smcFunc['db_query']('', '
1127
+	if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) {
1128
+			$smcFunc['db_query']('', '
1068 1129
 			SET NAMES {string:utf8}',
1069 1130
 			array(
1070 1131
 				'db_error_skip' => true,
1071 1132
 				'utf8' => 'utf8',
1072 1133
 			)
1073 1134
 		);
1135
+	}
1074 1136
 
1075 1137
 	// Windows likes to leave the trailing slash, which yields to C:\path\to\SMF\/attachments...
1076
-	if (substr(__DIR__, -1) == '\\')
1077
-		$attachdir = __DIR__ . 'attachments';
1078
-	else
1079
-		$attachdir = __DIR__ . '/attachments';
1138
+	if (substr(__DIR__, -1) == '\\') {
1139
+			$attachdir = __DIR__ . 'attachments';
1140
+	} else {
1141
+			$attachdir = __DIR__ . '/attachments';
1142
+	}
1080 1143
 
1081 1144
 	$replaces = array(
1082 1145
 		'{$db_prefix}' => $db_prefix,
@@ -1093,8 +1156,9 @@  discard block
 block discarded – undo
1093 1156
 
1094 1157
 	foreach ($txt as $key => $value)
1095 1158
 	{
1096
-		if (substr($key, 0, 8) == 'default_')
1097
-			$replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value);
1159
+		if (substr($key, 0, 8) == 'default_') {
1160
+					$replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value);
1161
+		}
1098 1162
 	}
1099 1163
 	$replaces['{$default_reserved_names}'] = strtr($replaces['{$default_reserved_names}'], array('\\\\n' => '\\n'));
1100 1164
 
@@ -1109,8 +1173,9 @@  discard block
 block discarded – undo
1109 1173
 
1110 1174
 		while ($row = $smcFunc['db_fetch_assoc']($get_engines))
1111 1175
 		{
1112
-			if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT')
1113
-				$engines[] = $row['Engine'];
1176
+			if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') {
1177
+							$engines[] = $row['Engine'];
1178
+			}
1114 1179
 		}
1115 1180
 
1116 1181
 		// Done with this now
@@ -1134,8 +1199,7 @@  discard block
 block discarded – undo
1134 1199
 			$replaces['START TRANSACTION;'] = '';
1135 1200
 			$replaces['COMMIT;'] = '';
1136 1201
 		}
1137
-	}
1138
-	else
1202
+	} else
1139 1203
 	{
1140 1204
 		$has_innodb = false;
1141 1205
 	}
@@ -1157,21 +1221,24 @@  discard block
 block discarded – undo
1157 1221
 	foreach ($sql_lines as $count => $line)
1158 1222
 	{
1159 1223
 		// No comments allowed!
1160
-		if (substr(trim($line), 0, 1) != '#')
1161
-			$current_statement .= "\n" . rtrim($line);
1224
+		if (substr(trim($line), 0, 1) != '#') {
1225
+					$current_statement .= "\n" . rtrim($line);
1226
+		}
1162 1227
 
1163 1228
 		// Is this the end of the query string?
1164
-		if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines)))
1165
-			continue;
1229
+		if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) {
1230
+					continue;
1231
+		}
1166 1232
 
1167 1233
 		// Does this table already exist?  If so, don't insert more data into it!
1168 1234
 		if (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) != 0 && in_array($match[1], $exists))
1169 1235
 		{
1170 1236
 			preg_match_all('~\)[,;]~', $current_statement, $matches);
1171
-			if (!empty($matches[0]))
1172
-				$incontext['sql_results']['insert_dups'] += count($matches[0]);
1173
-			else
1174
-				$incontext['sql_results']['insert_dups']++;
1237
+			if (!empty($matches[0])) {
1238
+							$incontext['sql_results']['insert_dups'] += count($matches[0]);
1239
+			} else {
1240
+							$incontext['sql_results']['insert_dups']++;
1241
+			}
1175 1242
 
1176 1243
 			$current_statement = '';
1177 1244
 			continue;
@@ -1180,8 +1247,9 @@  discard block
 block discarded – undo
1180 1247
 		if ($smcFunc['db_query']('', $current_statement, array('security_override' => true, 'db_error_skip' => true), $db_connection) === false)
1181 1248
 		{
1182 1249
 			// Use the appropriate function based on the DB type
1183
-			if ($db_type == 'mysql' || $db_type == 'mysqli')
1184
-				$db_errorno = $db_type . '_errno';
1250
+			if ($db_type == 'mysql' || $db_type == 'mysqli') {
1251
+							$db_errorno = $db_type . '_errno';
1252
+			}
1185 1253
 
1186 1254
 			// Error 1050: Table already exists!
1187 1255
 			// @todo Needs to be made better!
@@ -1196,18 +1264,18 @@  discard block
 block discarded – undo
1196 1264
 				// MySQLi requires a connection object. It's optional with MySQL and Postgres
1197 1265
 				$incontext['failures'][$count] = $smcFunc['db_error']($db_connection);
1198 1266
 			}
1199
-		}
1200
-		else
1267
+		} else
1201 1268
 		{
1202
-			if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1203
-				$incontext['sql_results']['tables']++;
1204
-			elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1269
+			if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) {
1270
+							$incontext['sql_results']['tables']++;
1271
+			} elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1205 1272
 			{
1206 1273
 				preg_match_all('~\)[,;]~', $current_statement, $matches);
1207
-				if (!empty($matches[0]))
1208
-					$incontext['sql_results']['inserts'] += count($matches[0]);
1209
-				else
1210
-					$incontext['sql_results']['inserts']++;
1274
+				if (!empty($matches[0])) {
1275
+									$incontext['sql_results']['inserts'] += count($matches[0]);
1276
+				} else {
1277
+									$incontext['sql_results']['inserts']++;
1278
+				}
1211 1279
 			}
1212 1280
 		}
1213 1281
 
@@ -1220,15 +1288,17 @@  discard block
 block discarded – undo
1220 1288
 	// Sort out the context for the SQL.
1221 1289
 	foreach ($incontext['sql_results'] as $key => $number)
1222 1290
 	{
1223
-		if ($number == 0)
1224
-			unset($incontext['sql_results'][$key]);
1225
-		else
1226
-			$incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number);
1291
+		if ($number == 0) {
1292
+					unset($incontext['sql_results'][$key]);
1293
+		} else {
1294
+					$incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number);
1295
+		}
1227 1296
 	}
1228 1297
 
1229 1298
 	// Make sure UTF will be used globally.
1230
-	if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8'])))
1231
-		$newSettings[] = array('global_character_set', 'UTF-8');
1299
+	if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) {
1300
+			$newSettings[] = array('global_character_set', 'UTF-8');
1301
+	}
1232 1302
 
1233 1303
 	// Auto-detect local & global cookie settings
1234 1304
 	$url_parts = parse_url($boardurl);
@@ -1254,15 +1324,19 @@  discard block
 block discarded – undo
1254 1324
 
1255 1325
 		// Look for subfolder, if found, set localCookie
1256 1326
 		// Checking for len > 1 ensures you don't have just a slash...
1257
-		if (!empty($url_parts['path']) && strlen($url_parts['path']) > 1)
1258
-			$localCookies = '1';
1327
+		if (!empty($url_parts['path']) && strlen($url_parts['path']) > 1) {
1328
+					$localCookies = '1';
1329
+		}
1259 1330
 
1260
-		if (isset($globalCookies))
1261
-			$newSettings[] = array('globalCookies', $globalCookies);
1262
-		if (isset($globalCookiesDomain))
1263
-			$newSettings[] = array('globalCookiesDomain', $globalCookiesDomain);
1264
-		if (isset($localCookies))
1265
-			$newSettings[] = array('localCookies', $localCookies);
1331
+		if (isset($globalCookies)) {
1332
+					$newSettings[] = array('globalCookies', $globalCookies);
1333
+		}
1334
+		if (isset($globalCookiesDomain)) {
1335
+					$newSettings[] = array('globalCookiesDomain', $globalCookiesDomain);
1336
+		}
1337
+		if (isset($localCookies)) {
1338
+					$newSettings[] = array('localCookies', $localCookies);
1339
+		}
1266 1340
 	}
1267 1341
 
1268 1342
 	// Are we allowing stat collection?
@@ -1280,16 +1354,17 @@  discard block
 block discarded – undo
1280 1354
 			fwrite($fp, $out);
1281 1355
 
1282 1356
 			$return_data = '';
1283
-			while (!feof($fp))
1284
-				$return_data .= fgets($fp, 128);
1357
+			while (!feof($fp)) {
1358
+							$return_data .= fgets($fp, 128);
1359
+			}
1285 1360
 
1286 1361
 			fclose($fp);
1287 1362
 
1288 1363
 			// Get the unique site ID.
1289 1364
 			preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID);
1290 1365
 
1291
-			if (!empty($ID[1]))
1292
-				$smcFunc['db_insert']('replace',
1366
+			if (!empty($ID[1])) {
1367
+							$smcFunc['db_insert']('replace',
1293 1368
 					$db_prefix . 'settings',
1294 1369
 					array('variable' => 'string', 'value' => 'string'),
1295 1370
 					array(
@@ -1298,11 +1373,12 @@  discard block
 block discarded – undo
1298 1373
 					),
1299 1374
 					array('variable')
1300 1375
 				);
1376
+			}
1301 1377
 		}
1302 1378
 	}
1303 1379
 	// Don't remove stat collection unless we unchecked the box for real, not from the loop.
1304
-	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats']))
1305
-		$smcFunc['db_query']('', '
1380
+	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) {
1381
+			$smcFunc['db_query']('', '
1306 1382
 			DELETE FROM {db_prefix}settings
1307 1383
 			WHERE variable = {string:enable_sm_stats}',
1308 1384
 			array(
@@ -1310,20 +1386,23 @@  discard block
 block discarded – undo
1310 1386
 				'db_error_skip' => true,
1311 1387
 			)
1312 1388
 		);
1389
+	}
1313 1390
 
1314 1391
 	// Are we enabling SSL?
1315
-	if (!empty($_POST['force_ssl']))
1316
-		$newSettings[] = array('force_ssl', 2);
1392
+	if (!empty($_POST['force_ssl'])) {
1393
+			$newSettings[] = array('force_ssl', 2);
1394
+	}
1317 1395
 
1318 1396
 	// Setting a timezone is required.
1319 1397
 	if (!isset($modSettings['default_timezone']) && function_exists('date_default_timezone_set'))
1320 1398
 	{
1321 1399
 		// Get PHP's default timezone, if set
1322 1400
 		$ini_tz = ini_get('date.timezone');
1323
-		if (!empty($ini_tz))
1324
-			$timezone_id = $ini_tz;
1325
-		else
1326
-			$timezone_id = '';
1401
+		if (!empty($ini_tz)) {
1402
+					$timezone_id = $ini_tz;
1403
+		} else {
1404
+					$timezone_id = '';
1405
+		}
1327 1406
 
1328 1407
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
1329 1408
 		if (!in_array($timezone_id, timezone_identifiers_list()))
@@ -1332,8 +1411,9 @@  discard block
 block discarded – undo
1332 1411
 			$timezone_id = timezone_name_from_abbr('', $server_offset, 0);
1333 1412
 		}
1334 1413
 
1335
-		if (date_default_timezone_set($timezone_id))
1336
-			$newSettings[] = array('default_timezone', $timezone_id);
1414
+		if (date_default_timezone_set($timezone_id)) {
1415
+					$newSettings[] = array('default_timezone', $timezone_id);
1416
+		}
1337 1417
 	}
1338 1418
 
1339 1419
 	if (!empty($newSettings))
@@ -1364,16 +1444,18 @@  discard block
 block discarded – undo
1364 1444
 	}
1365 1445
 
1366 1446
 	// MySQL specific stuff
1367
-	if (substr($db_type, 0, 5) != 'mysql')
1368
-		return false;
1447
+	if (substr($db_type, 0, 5) != 'mysql') {
1448
+			return false;
1449
+	}
1369 1450
 
1370 1451
 	// Find database user privileges.
1371 1452
 	$privs = array();
1372 1453
 	$get_privs = $smcFunc['db_query']('', 'SHOW PRIVILEGES', array());
1373 1454
 	while ($row = $smcFunc['db_fetch_assoc']($get_privs))
1374 1455
 	{
1375
-		if ($row['Privilege'] == 'Alter')
1376
-			$privs[] = $row['Privilege'];
1456
+		if ($row['Privilege'] == 'Alter') {
1457
+					$privs[] = $row['Privilege'];
1458
+		}
1377 1459
 	}
1378 1460
 	$smcFunc['db_free_result']($get_privs);
1379 1461
 
@@ -1403,8 +1485,9 @@  discard block
 block discarded – undo
1403 1485
 	$incontext['continue'] = 1;
1404 1486
 
1405 1487
 	// Skipping?
1406
-	if (!empty($_POST['skip']))
1407
-		return true;
1488
+	if (!empty($_POST['skip'])) {
1489
+			return true;
1490
+	}
1408 1491
 
1409 1492
 	// Need this to check whether we need the database password.
1410 1493
 	require(dirname(__FILE__) . '/Settings.php');
@@ -1421,18 +1504,22 @@  discard block
 block discarded – undo
1421 1504
 	// We need this to properly hash the password for Admin
1422 1505
 	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) {
1423 1506
 			global $sourcedir;
1424
-			if (function_exists('mb_strtolower'))
1425
-				return mb_strtolower($string, 'UTF-8');
1507
+			if (function_exists('mb_strtolower')) {
1508
+							return mb_strtolower($string, 'UTF-8');
1509
+			}
1426 1510
 			require_once($sourcedir . '/Subs-Charset.php');
1427 1511
 			return utf8_strtolower($string);
1428 1512
 		};
1429 1513
 
1430
-	if (!isset($_POST['username']))
1431
-		$_POST['username'] = '';
1432
-	if (!isset($_POST['email']))
1433
-		$_POST['email'] = '';
1434
-	if (!isset($_POST['server_email']))
1435
-		$_POST['server_email'] = '';
1514
+	if (!isset($_POST['username'])) {
1515
+			$_POST['username'] = '';
1516
+	}
1517
+	if (!isset($_POST['email'])) {
1518
+			$_POST['email'] = '';
1519
+	}
1520
+	if (!isset($_POST['server_email'])) {
1521
+			$_POST['server_email'] = '';
1522
+	}
1436 1523
 
1437 1524
 	$incontext['username'] = htmlspecialchars(stripslashes($_POST['username']));
1438 1525
 	$incontext['email'] = htmlspecialchars(stripslashes($_POST['email']));
@@ -1451,8 +1538,9 @@  discard block
 block discarded – undo
1451 1538
 			'admin_group' => 1,
1452 1539
 		)
1453 1540
 	);
1454
-	if ($smcFunc['db_num_rows']($request) != 0)
1455
-		$incontext['skip'] = 1;
1541
+	if ($smcFunc['db_num_rows']($request) != 0) {
1542
+			$incontext['skip'] = 1;
1543
+	}
1456 1544
 	$smcFunc['db_free_result']($request);
1457 1545
 
1458 1546
 	// Trying to create an account?
@@ -1483,8 +1571,9 @@  discard block
 block discarded – undo
1483 1571
 		}
1484 1572
 
1485 1573
 		// Update the webmaster's email?
1486
-		if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]'))
1487
-			updateSettingsFile(array('webmaster_email' => $_POST['server_email']));
1574
+		if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) {
1575
+					updateSettingsFile(array('webmaster_email' => $_POST['server_email']));
1576
+		}
1488 1577
 
1489 1578
 		// Work out whether we're going to have dodgy characters and remove them.
1490 1579
 		$invalid_characters = preg_match('~[<>&"\'=\\\]~', $_POST['username']) != 0;
@@ -1507,32 +1596,27 @@  discard block
 block discarded – undo
1507 1596
 			$smcFunc['db_free_result']($result);
1508 1597
 
1509 1598
 			$incontext['account_existed'] = $txt['error_user_settings_taken'];
1510
-		}
1511
-		elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25)
1599
+		} elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25)
1512 1600
 		{
1513 1601
 			// Try the previous step again.
1514 1602
 			$incontext['error'] = $_POST['username'] == '' ? $txt['error_username_left_empty'] : $txt['error_username_too_long'];
1515 1603
 			return false;
1516
-		}
1517
-		elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false)
1604
+		} elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false)
1518 1605
 		{
1519 1606
 			// Try the previous step again.
1520 1607
 			$incontext['error'] = $txt['error_invalid_characters_username'];
1521 1608
 			return false;
1522
-		}
1523
-		elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255)
1609
+		} elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255)
1524 1610
 		{
1525 1611
 			// One step back, this time fill out a proper admin email address.
1526 1612
 			$incontext['error'] = sprintf($txt['error_valid_admin_email_needed'], $_POST['username']);
1527 1613
 			return false;
1528
-		}
1529
-		elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255)
1614
+		} elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255)
1530 1615
 		{
1531 1616
 			// One step back, this time fill out a proper admin email address.
1532 1617
 			$incontext['error'] = $txt['error_valid_server_email_needed'];
1533 1618
 			return false;
1534
-		}
1535
-		elseif ($_POST['username'] != '')
1619
+		} elseif ($_POST['username'] != '')
1536 1620
 		{
1537 1621
 			$incontext['member_salt'] = substr(md5(mt_rand()), 0, 4);
1538 1622
 
@@ -1600,17 +1684,19 @@  discard block
 block discarded – undo
1600 1684
 	reloadSettings();
1601 1685
 
1602 1686
 	// Bring a warning over.
1603
-	if (!empty($incontext['account_existed']))
1604
-		$incontext['warning'] = $incontext['account_existed'];
1687
+	if (!empty($incontext['account_existed'])) {
1688
+			$incontext['warning'] = $incontext['account_existed'];
1689
+	}
1605 1690
 
1606
-	if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support']))
1607
-		$smcFunc['db_query']('', '
1691
+	if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) {
1692
+			$smcFunc['db_query']('', '
1608 1693
 			SET NAMES {string:db_character_set}',
1609 1694
 			array(
1610 1695
 				'db_character_set' => $db_character_set,
1611 1696
 				'db_error_skip' => true,
1612 1697
 			)
1613 1698
 		);
1699
+	}
1614 1700
 
1615 1701
 	// As track stats is by default enabled let's add some activity.
1616 1702
 	$smcFunc['db_insert']('ignore',
@@ -1631,14 +1717,16 @@  discard block
 block discarded – undo
1631 1717
 	// Only proceed if we can load the data.
1632 1718
 	if ($request)
1633 1719
 	{
1634
-		while ($row = $smcFunc['db_fetch_row']($request))
1635
-			$modSettings[$row[0]] = $row[1];
1720
+		while ($row = $smcFunc['db_fetch_row']($request)) {
1721
+					$modSettings[$row[0]] = $row[1];
1722
+		}
1636 1723
 		$smcFunc['db_free_result']($request);
1637 1724
 	}
1638 1725
 
1639 1726
 	// Automatically log them in ;)
1640
-	if (isset($incontext['member_id']) && isset($incontext['member_salt']))
1641
-		setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt']));
1727
+	if (isset($incontext['member_id']) && isset($incontext['member_salt'])) {
1728
+			setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt']));
1729
+	}
1642 1730
 
1643 1731
 	$result = $smcFunc['db_query']('', '
1644 1732
 		SELECT value
@@ -1649,13 +1737,14 @@  discard block
 block discarded – undo
1649 1737
 			'db_error_skip' => true,
1650 1738
 		)
1651 1739
 	);
1652
-	if ($smcFunc['db_num_rows']($result) != 0)
1653
-		list ($db_sessions) = $smcFunc['db_fetch_row']($result);
1740
+	if ($smcFunc['db_num_rows']($result) != 0) {
1741
+			list ($db_sessions) = $smcFunc['db_fetch_row']($result);
1742
+	}
1654 1743
 	$smcFunc['db_free_result']($result);
1655 1744
 
1656
-	if (empty($db_sessions))
1657
-		$_SESSION['admin_time'] = time();
1658
-	else
1745
+	if (empty($db_sessions)) {
1746
+			$_SESSION['admin_time'] = time();
1747
+	} else
1659 1748
 	{
1660 1749
 		$_SERVER['HTTP_USER_AGENT'] = substr($_SERVER['HTTP_USER_AGENT'], 0, 211);
1661 1750
 
@@ -1679,8 +1768,9 @@  discard block
 block discarded – undo
1679 1768
 	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' :
1680 1769
 		function($string){
1681 1770
 			global $sourcedir;
1682
-			if (function_exists('mb_strtolower'))
1683
-				return mb_strtolower($string, 'UTF-8');
1771
+			if (function_exists('mb_strtolower')) {
1772
+							return mb_strtolower($string, 'UTF-8');
1773
+			}
1684 1774
 			require_once($sourcedir . '/Subs-Charset.php');
1685 1775
 			return utf8_strtolower($string);
1686 1776
 		};
@@ -1696,8 +1786,9 @@  discard block
 block discarded – undo
1696 1786
 		)
1697 1787
 	);
1698 1788
 	$context['utf8'] = $db_character_set === 'utf8' || $txt['lang_character_set'] === 'UTF-8';
1699
-	if ($smcFunc['db_num_rows']($request) > 0)
1700
-		updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject']));
1789
+	if ($smcFunc['db_num_rows']($request) > 0) {
1790
+			updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject']));
1791
+	}
1701 1792
 	$smcFunc['db_free_result']($request);
1702 1793
 
1703 1794
 	// Now is the perfect time to fetch the SM files.
@@ -1716,8 +1807,9 @@  discard block
 block discarded – undo
1716 1807
 
1717 1808
 	// Check if we need some stupid MySQL fix.
1718 1809
 	$server_version = $smcFunc['db_server_info']();
1719
-	if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51')))
1720
-		updateSettings(array('db_mysql_group_by_fix' => '1'));
1810
+	if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) {
1811
+			updateSettings(array('db_mysql_group_by_fix' => '1'));
1812
+	}
1721 1813
 
1722 1814
 	// Some final context for the template.
1723 1815
 	$incontext['dir_still_writable'] = is_writable(dirname(__FILE__)) && substr(__FILE__, 1, 2) != ':\\';
@@ -1737,8 +1829,9 @@  discard block
 block discarded – undo
1737 1829
 	$settingsArray = file(dirname(__FILE__) . '/Settings.php');
1738 1830
 
1739 1831
 	// @todo Do we just want to read the file in clean, and split it this way always?
1740
-	if (count($settingsArray) == 1)
1741
-		$settingsArray = preg_split('~[\r\n]~', $settingsArray[0]);
1832
+	if (count($settingsArray) == 1) {
1833
+			$settingsArray = preg_split('~[\r\n]~', $settingsArray[0]);
1834
+	}
1742 1835
 
1743 1836
 	for ($i = 0, $n = count($settingsArray); $i < $n; $i++)
1744 1837
 	{
@@ -1753,19 +1846,22 @@  discard block
 block discarded – undo
1753 1846
 			continue;
1754 1847
 		}
1755 1848
 
1756
-		if (trim($settingsArray[$i]) == '?' . '>')
1757
-			$settingsArray[$i] = '';
1849
+		if (trim($settingsArray[$i]) == '?' . '>') {
1850
+					$settingsArray[$i] = '';
1851
+		}
1758 1852
 
1759 1853
 		// Don't trim or bother with it if it's not a variable.
1760
-		if (substr($settingsArray[$i], 0, 1) != '$')
1761
-			continue;
1854
+		if (substr($settingsArray[$i], 0, 1) != '$') {
1855
+					continue;
1856
+		}
1762 1857
 
1763 1858
 		$settingsArray[$i] = rtrim($settingsArray[$i]) . "\n";
1764 1859
 
1765
-		foreach ($vars as $var => $val)
1766
-			if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0)
1860
+		foreach ($vars as $var => $val) {
1861
+					if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0)
1767 1862
 			{
1768 1863
 				$comment = strstr($settingsArray[$i], '#');
1864
+		}
1769 1865
 				$settingsArray[$i] = '$' . $var . ' = \'' . $val . '\';' . ($comment != '' ? "\t\t" . $comment : "\n");
1770 1866
 				unset($vars[$var]);
1771 1867
 			}
@@ -1775,36 +1871,41 @@  discard block
 block discarded – undo
1775 1871
 	if (!empty($vars))
1776 1872
 	{
1777 1873
 		$settingsArray[$i++] = '';
1778
-		foreach ($vars as $var => $val)
1779
-			$settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n";
1874
+		foreach ($vars as $var => $val) {
1875
+					$settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n";
1876
+		}
1780 1877
 	}
1781 1878
 
1782 1879
 	// Blank out the file - done to fix a oddity with some servers.
1783 1880
 	$fp = @fopen(dirname(__FILE__) . '/Settings.php', 'w');
1784
-	if (!$fp)
1785
-		return false;
1881
+	if (!$fp) {
1882
+			return false;
1883
+	}
1786 1884
 	fclose($fp);
1787 1885
 
1788 1886
 	$fp = fopen(dirname(__FILE__) . '/Settings.php', 'r+');
1789 1887
 
1790 1888
 	// Gotta have one of these ;)
1791
-	if (trim($settingsArray[0]) != '<?php')
1792
-		fwrite($fp, "<?php\n");
1889
+	if (trim($settingsArray[0]) != '<?php') {
1890
+			fwrite($fp, "<?php\n");
1891
+	}
1793 1892
 
1794 1893
 	$lines = count($settingsArray);
1795 1894
 	for ($i = 0; $i < $lines - 1; $i++)
1796 1895
 	{
1797 1896
 		// Don't just write a bunch of blank lines.
1798
-		if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '')
1799
-			fwrite($fp, strtr($settingsArray[$i], "\r", ''));
1897
+		if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') {
1898
+					fwrite($fp, strtr($settingsArray[$i], "\r", ''));
1899
+		}
1800 1900
 	}
1801 1901
 	fwrite($fp, $settingsArray[$i] . '?' . '>');
1802 1902
 	fclose($fp);
1803 1903
 
1804 1904
 	// Even though on normal installations the filemtime should prevent this being used by the installer incorrectly
1805 1905
 	// it seems that there are times it might not. So let's MAKE it dump the cache.
1806
-	if (function_exists('opcache_invalidate'))
1807
-		opcache_invalidate(dirname(__FILE__) . '/Settings.php', true);
1906
+	if (function_exists('opcache_invalidate')) {
1907
+			opcache_invalidate(dirname(__FILE__) . '/Settings.php', true);
1908
+	}
1808 1909
 
1809 1910
 	return true;
1810 1911
 }
@@ -1829,9 +1930,9 @@  discard block
 block discarded – undo
1829 1930
 	SecFilterScanPOST Off
1830 1931
 </IfModule>';
1831 1932
 
1832
-	if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules()))
1833
-		return true;
1834
-	elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess'))
1933
+	if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) {
1934
+			return true;
1935
+	} elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess'))
1835 1936
 	{
1836 1937
 		$current_htaccess = implode('', file(dirname(__FILE__) . '/.htaccess'));
1837 1938
 
@@ -1843,29 +1944,28 @@  discard block
 block discarded – undo
1843 1944
 				fwrite($ht_handle, $htaccess_addition);
1844 1945
 				fclose($ht_handle);
1845 1946
 				return true;
1947
+			} else {
1948
+							return false;
1846 1949
 			}
1847
-			else
1848
-				return false;
1950
+		} else {
1951
+					return true;
1849 1952
 		}
1850
-		else
1851
-			return true;
1852
-	}
1853
-	elseif (file_exists(dirname(__FILE__) . '/.htaccess'))
1854
-		return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false;
1855
-	elseif (is_writable(dirname(__FILE__)))
1953
+	} elseif (file_exists(dirname(__FILE__) . '/.htaccess')) {
1954
+			return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false;
1955
+	} elseif (is_writable(dirname(__FILE__)))
1856 1956
 	{
1857 1957
 		if ($ht_handle = fopen(dirname(__FILE__) . '/.htaccess', 'w'))
1858 1958
 		{
1859 1959
 			fwrite($ht_handle, $htaccess_addition);
1860 1960
 			fclose($ht_handle);
1861 1961
 			return true;
1962
+		} else {
1963
+					return false;
1862 1964
 		}
1863
-		else
1965
+	} else {
1864 1966
 			return false;
1865 1967
 	}
1866
-	else
1867
-		return false;
1868
-}
1968
+	}
1869 1969
 
1870 1970
 function template_install_above()
1871 1971
 {
@@ -1903,9 +2003,10 @@  discard block
 block discarded – undo
1903 2003
 								<label for="installer_language">', $txt['installer_language'], ':</label>
1904 2004
 								<select id="installer_language" name="lang_file" onchange="location.href = \'', $installurl, '?lang_file=\' + this.options[this.selectedIndex].value;">';
1905 2005
 
1906
-		foreach ($incontext['detected_languages'] as $lang => $name)
1907
-			echo '
2006
+		foreach ($incontext['detected_languages'] as $lang => $name) {
2007
+					echo '
1908 2008
 									<option', isset($_SESSION['installer_temp_lang']) && $_SESSION['installer_temp_lang'] == $lang ? ' selected' : '', ' value="', $lang, '">', $name, '</option>';
2009
+		}
1909 2010
 
1910 2011
 		echo '
1911 2012
 								</select>
@@ -1925,9 +2026,10 @@  discard block
 block discarded – undo
1925 2026
 						<h2>', $txt['upgrade_progress'], '</h2>
1926 2027
 						<ul>';
1927 2028
 
1928
-	foreach ($incontext['steps'] as $num => $step)
1929
-		echo '
2029
+	foreach ($incontext['steps'] as $num => $step) {
2030
+			echo '
1930 2031
 							<li class="', $num < $incontext['current_step'] ? 'stepdone' : ($num == $incontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>';
2032
+	}
1931 2033
 
1932 2034
 	echo '
1933 2035
 						</ul>
@@ -1952,20 +2054,23 @@  discard block
 block discarded – undo
1952 2054
 		echo '
1953 2055
 								<div class="floatright">';
1954 2056
 
1955
-		if (!empty($incontext['continue']))
1956
-			echo '
2057
+		if (!empty($incontext['continue'])) {
2058
+					echo '
1957 2059
 									<input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '" onclick="return submitThisOnce(this);" class="button" />';
1958
-		if (!empty($incontext['skip']))
1959
-			echo '
2060
+		}
2061
+		if (!empty($incontext['skip'])) {
2062
+					echo '
1960 2063
 									<input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="return submitThisOnce(this);" class="button" />';
2064
+		}
1961 2065
 		echo '
1962 2066
 								</div>';
1963 2067
 	}
1964 2068
 
1965 2069
 	// Show the closing form tag and other data only if not in the last step
1966
-	if (count($incontext['steps']) - 1 !== (int) $incontext['current_step'])
1967
-		echo '
2070
+	if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) {
2071
+			echo '
1968 2072
 							</form>';
2073
+	}
1969 2074
 
1970 2075
 	echo '
1971 2076
 						</div>
@@ -2000,13 +2105,15 @@  discard block
 block discarded – undo
2000 2105
 		</div>';
2001 2106
 
2002 2107
 	// Show the warnings, or not.
2003
-	if (template_warning_divs())
2004
-		echo '
2108
+	if (template_warning_divs()) {
2109
+			echo '
2005 2110
 		<h3>', $txt['install_all_lovely'], '</h3>';
2111
+	}
2006 2112
 
2007 2113
 	// Say we want the continue button!
2008
-	if (empty($incontext['error']))
2009
-		$incontext['continue'] = 1;
2114
+	if (empty($incontext['error'])) {
2115
+			$incontext['continue'] = 1;
2116
+	}
2010 2117
 
2011 2118
 	// For the latest version stuff.
2012 2119
 	echo '
@@ -2040,8 +2147,8 @@  discard block
 block discarded – undo
2040 2147
 	global $txt, $incontext;
2041 2148
 
2042 2149
 	// Errors are very serious..
2043
-	if (!empty($incontext['error']))
2044
-		echo '
2150
+	if (!empty($incontext['error'])) {
2151
+			echo '
2045 2152
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
2046 2153
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
2047 2154
 			<strong style="text-decoration: underline;">', $txt['upgrade_critical_error'], '</strong><br>
@@ -2049,9 +2156,10 @@  discard block
 block discarded – undo
2049 2156
 				', $incontext['error'], '
2050 2157
 			</div>
2051 2158
 		</div>';
2159
+	}
2052 2160
 	// A warning message?
2053
-	elseif (!empty($incontext['warning']))
2054
-		echo '
2161
+	elseif (!empty($incontext['warning'])) {
2162
+			echo '
2055 2163
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
2056 2164
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
2057 2165
 			<strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br>
@@ -2059,6 +2167,7 @@  discard block
 block discarded – undo
2059 2167
 				', $incontext['warning'], '
2060 2168
 			</div>
2061 2169
 		</div>';
2170
+	}
2062 2171
 
2063 2172
 	return empty($incontext['error']) && empty($incontext['warning']);
2064 2173
 }
@@ -2074,27 +2183,30 @@  discard block
 block discarded – undo
2074 2183
 			<li>', $incontext['failed_files']), '</li>
2075 2184
 		</ul>';
2076 2185
 
2077
-	if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux')
2078
-		echo '
2186
+	if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') {
2187
+			echo '
2079 2188
 		<hr>
2080 2189
 		<p>', $txt['chmod_linux_info'], '</p>
2081 2190
 		<tt># chmod a+w ', implode(' ' . $incontext['detected_path'] . '/', $incontext['failed_files']), '</tt>';
2191
+	}
2082 2192
 
2083 2193
 	// This is serious!
2084
-	if (!template_warning_divs())
2085
-		return;
2194
+	if (!template_warning_divs()) {
2195
+			return;
2196
+	}
2086 2197
 
2087 2198
 	echo '
2088 2199
 		<hr>
2089 2200
 		<p>', $txt['ftp_setup_info'], '</p>';
2090 2201
 
2091
-	if (!empty($incontext['ftp_errors']))
2092
-		echo '
2202
+	if (!empty($incontext['ftp_errors'])) {
2203
+			echo '
2093 2204
 		<div class="error_message">
2094 2205
 			', $txt['error_ftp_no_connect'], '<br><br>
2095 2206
 			<code>', implode('<br>', $incontext['ftp_errors']), '</code>
2096 2207
 		</div>
2097 2208
 		<br>';
2209
+	}
2098 2210
 
2099 2211
 	echo '
2100 2212
 		<form action="', $incontext['form_url'], '" method="post">
@@ -2154,17 +2266,17 @@  discard block
 block discarded – undo
2154 2266
 				<td>
2155 2267
 					<select name="db_type" id="db_type_input" onchange="toggleDBInput();">';
2156 2268
 
2157
-	foreach ($incontext['supported_databases'] as $key => $db)
2158
-			echo '
2269
+	foreach ($incontext['supported_databases'] as $key => $db) {
2270
+				echo '
2159 2271
 						<option value="', $key, '"', isset($_POST['db_type']) && $_POST['db_type'] == $key ? ' selected' : '', '>', $db['name'], '</option>';
2272
+	}
2160 2273
 
2161 2274
 	echo '
2162 2275
 					</select>
2163 2276
 					<div class="smalltext block">', $txt['db_settings_type_info'], '</div>
2164 2277
 				</td>
2165 2278
 			</tr>';
2166
-	}
2167
-	else
2279
+	} else
2168 2280
 	{
2169 2281
 		echo '
2170 2282
 			<tr style="display: none;">
@@ -2357,9 +2469,10 @@  discard block
 block discarded – undo
2357 2469
 				<div style="color: red;">', $txt['error_db_queries'], '</div>
2358 2470
 				<ul>';
2359 2471
 
2360
-		foreach ($incontext['failures'] as $line => $fail)
2361
-			echo '
2472
+		foreach ($incontext['failures'] as $line => $fail) {
2473
+					echo '
2362 2474
 						<li><strong>', $txt['error_db_queries_line'], $line + 1, ':</strong> ', nl2br(htmlspecialchars($fail)), '</li>';
2475
+		}
2363 2476
 
2364 2477
 		echo '
2365 2478
 				</ul>';
@@ -2420,15 +2533,16 @@  discard block
 block discarded – undo
2420 2533
 			</tr>
2421 2534
 		</table>';
2422 2535
 
2423
-	if ($incontext['require_db_confirm'])
2424
-		echo '
2536
+	if ($incontext['require_db_confirm']) {
2537
+			echo '
2425 2538
 		<h2>', $txt['user_settings_database'], '</h2>
2426 2539
 		<p>', $txt['user_settings_database_info'], '</p>
2427 2540
 
2428 2541
 		<div style="margin-bottom: 2ex; padding-', $txt['lang_rtl'] == false ? 'left' : 'right', ': 50px;">
2429 2542
 			<input type="password" name="password3" size="30" />
2430 2543
 		</div>';
2431
-}
2544
+	}
2545
+	}
2432 2546
 
2433 2547
 // Tell them it's done, and to delete.
2434 2548
 function template_delete_install()
@@ -2441,14 +2555,15 @@  discard block
 block discarded – undo
2441 2555
 	template_warning_divs();
2442 2556
 
2443 2557
 	// Install directory still writable?
2444
-	if ($incontext['dir_still_writable'])
2445
-		echo '
2558
+	if ($incontext['dir_still_writable']) {
2559
+			echo '
2446 2560
 		<em>', $txt['still_writable'], '</em><br>
2447 2561
 		<br>';
2562
+	}
2448 2563
 
2449 2564
 	// Don't show the box if it's like 99% sure it won't work :P.
2450
-	if ($incontext['probably_delete_install'])
2451
-		echo '
2565
+	if ($incontext['probably_delete_install']) {
2566
+			echo '
2452 2567
 		<div style="margin: 1ex; font-weight: bold;">
2453 2568
 			<label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete();" /> ', $txt['delete_installer'], !isset($_SESSION['installer_temp_ftp']) ? ' ' . $txt['delete_installer_maybe'] : '', '</label>
2454 2569
 		</div>
@@ -2464,6 +2579,7 @@  discard block
 block discarded – undo
2464 2579
 			}
2465 2580
 		</script>
2466 2581
 		<br>';
2582
+	}
2467 2583
 
2468 2584
 	echo '
2469 2585
 		', sprintf($txt['go_to_your_forum'], $boardurl . '/index.php'), '<br>
Please login to merge, or discard this patch.
Themes/default/ManageAttachments.template.php 1 patch
Braces   +20 added lines, -14 removed lines patch added patch discarded remove patch
@@ -122,9 +122,10 @@  discard block
 block discarded – undo
122 122
 		<h3 class="catbg">', $txt['attachment_transfer'], '</h3>
123 123
 	</div>';
124 124
 
125
-	if (!empty($context['results']))
126
-		echo '
125
+	if (!empty($context['results'])) {
126
+			echo '
127 127
 	<div class="noticebox">', $context['results'], '</div>';
128
+	}
128 129
 
129 130
 	echo '
130 131
 	<div class="windowbg2 noup">
@@ -136,9 +137,10 @@  discard block
 block discarded – undo
136 137
 					<select name="from">
137 138
 						<option value="0">', $txt['attachment_transfer_select'], '</option>';
138 139
 
139
-	foreach ($context['attach_dirs'] as $id => $dir)
140
-		echo '
140
+	foreach ($context['attach_dirs'] as $id => $dir) {
141
+			echo '
141 142
 						<option value="', $id, '">', $dir, '</option>';
143
+	}
142 144
 
143 145
 	echo '
144 146
 					</select>
@@ -149,13 +151,14 @@  discard block
 block discarded – undo
149 151
 						<option value="0">', $txt['attachment_transfer_auto_select'], '</option>
150 152
 						<option value="-1">', $txt['attachment_transfer_forum_root'], '</option>';
151 153
 
152
-	if (!empty($context['base_dirs']))
153
-		foreach ($context['base_dirs'] as $id => $dir)
154
+	if (!empty($context['base_dirs'])) {
155
+			foreach ($context['base_dirs'] as $id => $dir)
154 156
 			echo '
155 157
 						<option value="', $id, '">', $dir, '</option>';
156
-	else
157
-			echo '
158
+	} else {
159
+				echo '
158 160
 						<option value="0" disabled>', $txt['attachment_transfer_no_base'], '</option>';
161
+	}
159 162
 
160 163
 	echo '
161 164
 					</select>
@@ -165,18 +168,20 @@  discard block
 block discarded – undo
165 168
 					<select name="to">
166 169
 						<option value="0">', $txt['attachment_transfer_select'], '</option>';
167 170
 
168
-	foreach ($context['attach_dirs'] as $id => $dir)
169
-		echo '
171
+	foreach ($context['attach_dirs'] as $id => $dir) {
172
+			echo '
170 173
 						<option value="', $id, '">', $dir, '</option>';
174
+	}
171 175
 
172 176
 	echo '
173 177
 					</select>
174 178
 				</dd>';
175 179
 
176
-	if (!empty($modSettings['attachmentDirFileLimit']))
177
-		echo '
180
+	if (!empty($modSettings['attachmentDirFileLimit'])) {
181
+			echo '
178 182
 				<dt>', $txt['attachment_transfer_empty'], '</dt>
179 183
 				<dd><input type="checkbox" name="empty_it"', $context['checked'] ? ' checked' : '', '></dd>';
184
+	}
180 185
 
181 186
 	echo '
182 187
 			</dl>
@@ -253,10 +258,11 @@  discard block
 block discarded – undo
253 258
 		// Loop through each error reporting the status
254 259
 		foreach ($context['repair_errors'] as $error => $number)
255 260
 		{
256
-			if (!empty($number))
257
-				echo '
261
+			if (!empty($number)) {
262
+							echo '
258 263
 				<input type="checkbox" name="to_fix[]" id="', $error, '" value="', $error, '">
259 264
 				<label for="', $error, '">', sprintf($txt['attach_repair_' . $error], $number), '</label><br>';
265
+			}
260 266
 		}
261 267
 
262 268
 		echo '
Please login to merge, or discard this patch.
Themes/default/ManagePaid.template.php 1 patch
Braces   +61 added lines, -44 removed lines patch added patch discarded remove patch
@@ -24,11 +24,12 @@  discard block
 block discarded – undo
24 24
 				<h3 class="catbg">', $txt['paid_' . $context['action_type'] . '_subscription'], '</h3>
25 25
 			</div>';
26 26
 
27
-	if (!empty($context['disable_groups']))
28
-		echo '
27
+	if (!empty($context['disable_groups'])) {
28
+			echo '
29 29
 			<div class="information">
30 30
 				<span class="alert">', $txt['paid_mod_edit_note'], '</span>
31 31
 			</div>';
32
+	}
32 33
 
33 34
 	echo '
34 35
 			<div class="windowbg2">
@@ -69,9 +70,10 @@  discard block
 block discarded – undo
69 70
 							<option value="0"', $context['sub']['prim_group'] == 0 ? ' selected' : '', '>', $txt['paid_mod_no_group'], '</option>';
70 71
 
71 72
 	// Put each group into the box.
72
-	foreach ($context['groups'] as $id => $name)
73
-		echo '
73
+	foreach ($context['groups'] as $id => $name) {
74
+			echo '
74 75
 							<option value="', $id, '"', $context['sub']['prim_group'] == $id ? ' selected' : '', '>', $name, '</option>';
76
+	}
75 77
 
76 78
 	echo '
77 79
 						</select>
@@ -83,11 +85,12 @@  discard block
 block discarded – undo
83 85
 					<dd>';
84 86
 
85 87
 	// Put a checkbox in for each group
86
-	foreach ($context['groups'] as $id => $name)
87
-		echo '
88
+	foreach ($context['groups'] as $id => $name) {
89
+			echo '
88 90
 						<label for="addgroup_', $id, '">
89 91
 							<input type="checkbox" id="addgroup_', $id, '" name="addgroup[', $id, ']"', in_array($id, $context['sub']['add_groups']) ? ' checked' : '', !empty($context['disable_groups']) ? ' disabled' : '', '>&nbsp;<span class="smalltext">', $name, '</span>
90 92
 						</label><br>';
93
+	}
91 94
 
92 95
 	echo '
93 96
 					</dd>
@@ -141,8 +144,8 @@  discard block
 block discarded – undo
141 144
 					<fieldset>';
142 145
 
143 146
 	//!! Removed until implemented
144
-	if (!empty($sdflsdhglsdjgs))
145
-		echo '
147
+	if (!empty($sdflsdhglsdjgs)) {
148
+			echo '
146 149
 						<dl class="settings">
147 150
 							<dt>
148 151
 								<label for="allow_partial_check">', $txt['paid_mod_allow_partial'], '</label>:<br><span class="smalltext">', $txt['paid_mod_allow_partial_desc'], '</span>
@@ -151,6 +154,7 @@  discard block
 block discarded – undo
151 154
 								<input type="checkbox" name="allow_partial" id="allow_partial_check"', empty($context['sub']['allow_partial']) ? '' : ' checked', '>
152 155
 							</dd>
153 156
 						</dl>';
157
+	}
154 158
 
155 159
 	echo '
156 160
 						<div class="information">
@@ -251,8 +255,8 @@  discard block
 block discarded – undo
251 255
 				<dl class="settings">';
252 256
 
253 257
 	// Do we need a username?
254
-	if ($context['action_type'] == 'add')
255
-		echo '
258
+	if ($context['action_type'] == 'add') {
259
+			echo '
256 260
 					<dt>
257 261
 						<strong>', $txt['paid_username'], ':</strong><br>
258 262
 						<span class="smalltext">', $txt['one_username'], '</span>
@@ -260,6 +264,7 @@  discard block
 block discarded – undo
260 264
 					<dd>
261 265
 						<input type="text" name="name" id="name_control" value="', $context['sub']['username'], '" size="30">
262 266
 					</dd>';
267
+	}
263 268
 
264 269
 	echo '
265 270
 					<dt>
@@ -277,9 +282,10 @@  discard block
 block discarded – undo
277 282
 					<select name="year" id="year" onchange="generateDays();">';
278 283
 
279 284
 	// Show a list of all the years we allow...
280
-	for ($year = 2005; $year <= 2030; $year++)
281
-		echo '
285
+	for ($year = 2005; $year <= 2030; $year++) {
286
+			echo '
282 287
 						<option value="', $year, '"', $year == $context['sub']['start']['year'] ? ' selected' : '', '>', $year, '</option>';
288
+	}
283 289
 
284 290
 	echo '
285 291
 					</select>&nbsp;
@@ -287,9 +293,10 @@  discard block
 block discarded – undo
287 293
 					<select name="month" id="month" onchange="generateDays();">';
288 294
 
289 295
 	// There are 12 months per year - ensure that they all get listed.
290
-	for ($month = 1; $month <= 12; $month++)
291
-		echo '
296
+	for ($month = 1; $month <= 12; $month++) {
297
+			echo '
292 298
 						<option value="', $month, '"', $month == $context['sub']['start']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>';
299
+	}
293 300
 
294 301
 	echo '
295 302
 					</select>&nbsp;
@@ -297,9 +304,10 @@  discard block
 block discarded – undo
297 304
 					<select name="day" id="day">';
298 305
 
299 306
 	// This prints out all the days in the current month - this changes dynamically as we switch months.
300
-	for ($day = 1; $day <= $context['sub']['start']['last_day']; $day++)
301
-		echo '
307
+	for ($day = 1; $day <= $context['sub']['start']['last_day']; $day++) {
308
+			echo '
302 309
 						<option value="', $day, '"', $day == $context['sub']['start']['day'] ? ' selected' : '', '>', $day, '</option>';
310
+	}
303 311
 
304 312
 	echo '
305 313
 					</select>
@@ -311,9 +319,10 @@  discard block
 block discarded – undo
311 319
 					<select name="yearend" id="yearend" onchange="generateDays(\'end\');">';
312 320
 
313 321
 	// Show a list of all the years we allow...
314
-	for ($year = 2005; $year <= 2030; $year++)
315
-		echo '
322
+	for ($year = 2005; $year <= 2030; $year++) {
323
+			echo '
316 324
 						<option value="', $year, '"', $year == $context['sub']['end']['year'] ? ' selected' : '', '>', $year, '</option>';
325
+	}
317 326
 
318 327
 	echo '
319 328
 					</select>&nbsp;
@@ -321,9 +330,10 @@  discard block
 block discarded – undo
321 330
 					<select name="monthend" id="monthend" onchange="generateDays(\'end\');">';
322 331
 
323 332
 	// There are 12 months per year - ensure that they all get listed.
324
-	for ($month = 1; $month <= 12; $month++)
325
-		echo '
333
+	for ($month = 1; $month <= 12; $month++) {
334
+			echo '
326 335
 						<option value="', $month, '"', $month == $context['sub']['end']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>';
336
+	}
327 337
 
328 338
 	echo '
329 339
 					</select>&nbsp;
@@ -331,9 +341,10 @@  discard block
 block discarded – undo
331 341
 					<select name="dayend" id="dayend">';
332 342
 
333 343
 	// This prints out all the days in the current month - this changes dynamically as we switch months.
334
-	for ($day = 1; $day <= $context['sub']['end']['last_day']; $day++)
335
-		echo '
344
+	for ($day = 1; $day <= $context['sub']['end']['last_day']; $day++) {
345
+			echo '
336 346
 						<option value="', $day, '"', $day == $context['sub']['end']['day'] ? ' selected' : '', '>', $day, '</option>';
347
+	}
337 348
 
338 349
 	echo '
339 350
 					</select>
@@ -415,8 +426,7 @@  discard block
 block discarded – undo
415 426
 			<div class="information">
416 427
 				', $txt['paid_subs_none'], '
417 428
 			</div>';
418
-	}
419
-	else
429
+	} else
420 430
 	{
421 431
 		echo '
422 432
 			<div class="information">
@@ -428,8 +438,9 @@  discard block
 block discarded – undo
428 438
 		{
429 439
 
430 440
 			// Ignore the inactive ones...
431
-			if (empty($subscription['active']))
432
-				continue;
441
+			if (empty($subscription['active'])) {
442
+							continue;
443
+			}
433 444
 
434 445
 			echo '
435 446
 			<div class="cat_bar">
@@ -439,9 +450,10 @@  discard block
 block discarded – undo
439 450
 				<p><strong>', $subscription['name'], '</strong></p>
440 451
 				<p class="smalltext">', $subscription['desc'], '</p>';
441 452
 
442
-			if (!$subscription['flexible'])
443
-				echo '
453
+			if (!$subscription['flexible']) {
454
+							echo '
444 455
 				<div><strong>', $txt['paid_duration'], ':</strong> ', $subscription['length'], '</div>';
456
+			}
445 457
 
446 458
 			if ($context['user']['is_owner'])
447 459
 			{
@@ -454,24 +466,25 @@  discard block
 block discarded – undo
454 466
 				<select name="cur[', $subscription['id'], ']">';
455 467
 
456 468
 					// Print out the costs for this one.
457
-					foreach ($subscription['costs'] as $duration => $value)
458
-						echo '
469
+					foreach ($subscription['costs'] as $duration => $value) {
470
+											echo '
459 471
 					<option value="', $duration, '">', sprintf($modSettings['paid_currency_symbol'], $value), '/', $txt[$duration], '</option>';
472
+					}
460 473
 
461 474
 					echo '
462 475
 				</select>';
463
-				}
464
-				else
465
-					echo '
476
+				} else {
477
+									echo '
466 478
 				', sprintf($modSettings['paid_currency_symbol'], $subscription['costs']['fixed']);
479
+				}
467 480
 
468 481
 				echo '
469 482
 				<hr>
470 483
 				<input type="submit" name="sub_id[', $subscription['id'], ']" value="', $txt['paid_order'], '" class="button">';
471
-			}
472
-			else
473
-				echo '
484
+			} else {
485
+							echo '
474 486
 				<a href="', $scripturl, '?action=admin;area=paidsubscribe;sa=modifyuser;sid=', $subscription['id'], ';uid=', $context['member']['id'], (empty($context['current'][$subscription['id']]) ? '' : ';lid=' . $context['current'][$subscription['id']]['id']), '">', empty($context['current'][$subscription['id']]) ? $txt['paid_admin_add'] : $txt['paid_edit_subscription'], '</a>';
487
+			}
475 488
 
476 489
 			echo '
477 490
 			</div><!-- .windowbg -->';
@@ -498,19 +511,20 @@  discard block
 block discarded – undo
498 511
 			</thead>
499 512
 			<tbody>';
500 513
 
501
-	if (empty($context['current']))
502
-		echo '
514
+	if (empty($context['current'])) {
515
+			echo '
503 516
 				<tr class="windowbg">
504 517
 					<td colspan="4">
505 518
 						', $txt['paid_none_yet'], '
506 519
 					</td>
507 520
 				</tr>';
521
+	}
508 522
 
509 523
 	foreach ($context['current'] as $sub)
510 524
 	{
511 525
 
512
-		if (!$sub['hide'])
513
-			echo '
526
+		if (!$sub['hide']) {
527
+					echo '
514 528
 				<tr class="windowbg">
515 529
 					<td>
516 530
 						', (allowedTo('admin_forum') ? '<a href="' . $scripturl . '?action=admin;area=paidsubscribe;sa=modifyuser;lid=' . $sub['id'] . '">' . $sub['name'] . '</a>' : $sub['name']), '
@@ -521,6 +535,7 @@  discard block
 block discarded – undo
521 535
 					<td>', $sub['start'], '</td>
522 536
 					<td>', $sub['end'], '</td>
523 537
 				</tr>';
538
+		}
524 539
 	}
525 540
 	echo '
526 541
 			</tbody>
@@ -571,15 +586,17 @@  discard block
 block discarded – undo
571 586
 			', $gateway['desc'], '<br>
572 587
 			<form action="', $gateway['form'], '" method="post">';
573 588
 
574
-		if (!empty($gateway['javascript']))
575
-			echo '
589
+		if (!empty($gateway['javascript'])) {
590
+					echo '
576 591
 				<script>
577 592
 					', $gateway['javascript'], '
578 593
 				</script>';
594
+		}
579 595
 
580
-		foreach ($gateway['hidden'] as $name => $value)
581
-			echo '
596
+		foreach ($gateway['hidden'] as $name => $value) {
597
+					echo '
582 598
 				<input type="hidden" id="', $gateway['id'], '_', $name, '" name="', $name, '" value="', $value, '">';
599
+		}
583 600
 
584 601
 		echo '
585 602
 				<br>
Please login to merge, or discard this patch.
Themes/default/ManageNews.template.php 1 patch
Braces   +21 added lines, -14 removed lines patch added patch discarded remove patch
@@ -18,9 +18,10 @@  discard block
 block discarded – undo
18 18
 	global $context, $txt, $scripturl;
19 19
 
20 20
 	// Are we done sending the newsletter?
21
-	if (!empty($context['newsletter_sent']))
22
-		echo '
21
+	if (!empty($context['newsletter_sent'])) {
22
+			echo '
23 23
 	<div class="infobox">', $txt['admin_news_newsletter_' . $context['newsletter_sent']], '</div>';
24
+	}
24 25
 
25 26
 	echo '
26 27
 	<div id="admincenter">
@@ -39,9 +40,10 @@  discard block
 block discarded – undo
39 40
 					</dt>
40 41
 					<dd>';
41 42
 
42
-	foreach ($context['groups'] as $group)
43
-		echo '
43
+	foreach ($context['groups'] as $group) {
44
+			echo '
44 45
 						<label for="groups_', $group['id'], '"><input type="checkbox" name="groups[', $group['id'], ']" id="groups_', $group['id'], '" value="', $group['id'], '" checked> ', $group['name'], '</label> <em>(', $group['member_count'], ')</em><br>';
46
+	}
45 47
 
46 48
 	echo '
47 49
 						<br>
@@ -82,9 +84,10 @@  discard block
 block discarded – undo
82 84
 						</dt>
83 85
 						<dd>';
84 86
 
85
-	foreach ($context['groups'] as $group)
86
-		echo '
87
+	foreach ($context['groups'] as $group) {
88
+			echo '
87 89
 							<label for="exclude_groups_', $group['id'], '"><input type="checkbox" name="exclude_groups[', $group['id'], ']" id="exclude_groups_', $group['id'], '" value="', $group['id'], '"> ', $group['name'], '</label> <em>(', $group['member_count'], ')</em><br>';
90
+	}
88 91
 
89 92
 	echo '
90 93
 							<br>
@@ -230,9 +233,10 @@  discard block
 block discarded – undo
230 233
 				<div id="bbcBox_message"></div>';
231 234
 
232 235
 	// What about smileys?
233
-	if (!empty($context['smileys']['postform']) || !empty($context['smileys']['popup']))
234
-		echo '
236
+	if (!empty($context['smileys']['postform']) || !empty($context['smileys']['popup'])) {
237
+			echo '
235 238
 				<div id="smileyBox_message"></div>';
239
+	}
236 240
 
237 241
 	// Show BBC buttons, smileys and textbox.
238 242
 	echo '
@@ -253,9 +257,10 @@  discard block
 block discarded – undo
253 257
 			<input type="hidden" name="email_force" value="', $context['email_force'], '">
254 258
 			<input type="hidden" name="total_emails" value="', $context['total_emails'], '">';
255 259
 
256
-	foreach ($context['recipients'] as $key => $values)
257
-		echo '
260
+	foreach ($context['recipients'] as $key => $values) {
261
+			echo '
258 262
 			<input type="hidden" name="', $key, '" value="', implode(($key == 'emails' ? ';' : ','), $values), '">';
263
+	}
259 264
 
260 265
 	echo '
261 266
 			<script>';
@@ -411,9 +416,10 @@  discard block
 block discarded – undo
411 416
 				<input type="hidden" name="parse_html" value="', $context['parse_html'], '">';
412 417
 
413 418
 	// All the things we must remember!
414
-	foreach ($context['recipients'] as $key => $values)
415
-		echo '
419
+	foreach ($context['recipients'] as $key => $values) {
420
+			echo '
416 421
 				<input type="hidden" name="', $key, '" value="', implode(($key == 'emails' ? ';' : ','), $values), '">';
422
+	}
417 423
 
418 424
 	echo '
419 425
 			</div><!-- .windowbg -->
@@ -446,9 +452,10 @@  discard block
 block discarded – undo
446 452
 {
447 453
 	global $context, $txt;
448 454
 
449
-	if (!empty($context['saved_successful']))
450
-		echo '
455
+	if (!empty($context['saved_successful'])) {
456
+			echo '
451 457
 			<div class="infobox">', $txt['settings_saved'], '</div>';
458
+	}
452 459
 
453 460
 	template_show_list('news_lists');
454 461
 }
Please login to merge, or discard this patch.
Themes/default/Stats.template.php 1 patch
Braces   +26 added lines, -18 removed lines patch added patch discarded remove patch
@@ -44,10 +44,11 @@  discard block
 block discarded – undo
44 44
 				<dt>', $txt['users_online_today'], ':</dt>
45 45
 				<dd>', $context['online_today'], '</dd>';
46 46
 
47
-	if (!empty($modSettings['hitStats']))
48
-		echo '
47
+	if (!empty($modSettings['hitStats'])) {
48
+			echo '
49 49
 				<dt>', $txt['num_hits'], ':</dt>
50 50
 				<dd>', $context['num_hits'], '</dd>';
51
+	}
51 52
 
52 53
 	echo '
53 54
 			</dl>
@@ -71,17 +72,19 @@  discard block
 block discarded – undo
71 72
 				<dt>', $txt['gender_stats'], ':</dt>
72 73
 				<dd>';
73 74
 
74
-		foreach ($context['gender'] as $g => $n)
75
-			echo $g, ': ', $n, '<br>';
75
+		foreach ($context['gender'] as $g => $n) {
76
+					echo $g, ': ', $n, '<br>';
77
+		}
76 78
 
77 79
 		echo '
78 80
 				</dd>';
79 81
 	}
80 82
 
81
-	if (!empty($modSettings['hitStats']))
82
-		echo '
83
+	if (!empty($modSettings['hitStats'])) {
84
+			echo '
83 85
 				<dt>', $txt['average_hits'], ':</dt>
84 86
 				<dd>', $context['average_hits'], '</dd>';
87
+	}
85 88
 
86 89
 	echo '
87 90
 			</dl>';
@@ -105,14 +108,15 @@  discard block
 block discarded – undo
105 108
 					</dt>
106 109
 					<dd class="statsbar">';
107 110
 
108
-			if (!empty($item['percent']))
109
-				echo '
111
+			if (!empty($item['percent'])) {
112
+							echo '
110 113
 						<div class="bar" style="width: ', $item['percent'], '%;">
111 114
 							<span class="righttext">', $item['num'], '</span>
112 115
 						</div>';
113
-			else
114
-				echo '
116
+			} else {
117
+							echo '
115 118
 						<div class="bar empty"><span class="righttext">', $item['num'], '</span></div>';
119
+			}
116 120
 
117 121
 			echo '
118 122
 					</dd>';
@@ -144,9 +148,10 @@  discard block
 block discarded – undo
144 148
 					<th>', $txt['stats_new_members'], '</th>
145 149
 					<th>', $txt['most_online'], '</th>';
146 150
 
147
-		if (!empty($modSettings['hitStats']))
148
-			echo '
151
+		if (!empty($modSettings['hitStats'])) {
152
+					echo '
149 153
 					<th>', $txt['page_views'], '</th>';
154
+		}
150 155
 
151 156
 		echo '
152 157
 				</tr>
@@ -165,9 +170,10 @@  discard block
 block discarded – undo
165 170
 					<th>', $year['new_members'], '</th>
166 171
 					<th>', $year['most_members_online'], '</th>';
167 172
 
168
-			if (!empty($modSettings['hitStats']))
169
-				echo '
173
+			if (!empty($modSettings['hitStats'])) {
174
+							echo '
170 175
 					<th>', $year['hits'], '</th>';
176
+			}
171 177
 
172 178
 			echo '
173 179
 				</tr>';
@@ -184,9 +190,10 @@  discard block
 block discarded – undo
184 190
 					<th>', $month['new_members'], '</th>
185 191
 					<th>', $month['most_members_online'], '</th>';
186 192
 
187
-				if (!empty($modSettings['hitStats']))
188
-					echo '
193
+				if (!empty($modSettings['hitStats'])) {
194
+									echo '
189 195
 					<th>', $month['hits'], '</th>';
196
+				}
190 197
 
191 198
 				echo '
192 199
 				</tr>';
@@ -203,9 +210,10 @@  discard block
 block discarded – undo
203 210
 					<td>', $day['new_members'], '</td>
204 211
 					<td>', $day['most_members_online'], '</td>';
205 212
 
206
-						if (!empty($modSettings['hitStats']))
207
-							echo '
213
+						if (!empty($modSettings['hitStats'])) {
214
+													echo '
208 215
 					<td>', $day['hits'], '</td>';
216
+						}
209 217
 
210 218
 						echo '
211 219
 				</tr>';
Please login to merge, or discard this patch.
Themes/default/ModerationCenter.template.php 1 patch
Braces   +56 added lines, -39 removed lines patch added patch discarded remove patch
@@ -55,18 +55,20 @@  discard block
 block discarded – undo
55 55
 			<div class="modbox">
56 56
 				<ul>';
57 57
 
58
-		foreach ($context['group_requests'] as $request)
59
-			echo '
58
+		foreach ($context['group_requests'] as $request) {
59
+					echo '
60 60
 					<li class="smalltext">
61 61
 						<a href="', $request['request_href'], '">', $request['group']['name'], '</a> ', $txt['mc_groupr_by'], ' ', $request['member']['link'], '
62 62
 					</li>';
63
+		}
63 64
 
64 65
 		// Don't have any watched users right now?
65
-		if (empty($context['group_requests']))
66
-			echo '
66
+		if (empty($context['group_requests'])) {
67
+					echo '
67 68
 					<li>
68 69
 						<strong class="smalltext">', $txt['mc_group_requests_none'], '</strong>
69 70
 					</li>';
71
+		}
70 72
 
71 73
 		echo '
72 74
 				</ul>
@@ -124,18 +126,20 @@  discard block
 block discarded – undo
124 126
 			<div class="modbox">
125 127
 				<ul>';
126 128
 
127
-		foreach ($context['watched_users'] as $user)
128
-			echo '
129
+		foreach ($context['watched_users'] as $user) {
130
+					echo '
129 131
 					<li>
130 132
 						<span class="smalltext">', sprintf(!empty($user['last_login']) ? $txt['mc_seen'] : $txt['mc_seen_never'], $user['link'], $user['last_login']), '</span>
131 133
 					</li>';
134
+		}
132 135
 
133 136
 		// Don't have any watched users right now?
134
-		if (empty($context['watched_users']))
135
-			echo '
137
+		if (empty($context['watched_users'])) {
138
+					echo '
136 139
 					<li>
137 140
 						<strong class="smalltext">', $txt['mc_watched_users_none'], '</strong>
138 141
 					</li>';
142
+		}
139 143
 
140 144
 		echo '
141 145
 				</ul>
@@ -193,18 +197,20 @@  discard block
 block discarded – undo
193 197
 			<div class="modbox">
194 198
 				<ul>';
195 199
 
196
-		foreach ($context['reported_posts'] as $post)
197
-			echo '
200
+		foreach ($context['reported_posts'] as $post) {
201
+					echo '
198 202
 					<li>
199 203
 						<span class="smalltext">', sprintf($txt['mc_post_report'], $post['report_link'], $post['author']['link']), '</span>
200 204
 					</li>';
205
+		}
201 206
 
202 207
 		// Don't have any watched users right now?
203
-		if (empty($context['reported_posts']))
204
-			echo '
208
+		if (empty($context['reported_posts'])) {
209
+					echo '
205 210
 					<li>
206 211
 						<strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong>
207 212
 					</li>';
213
+		}
208 214
 
209 215
 		echo '
210 216
 				</ul>
@@ -262,18 +268,20 @@  discard block
 block discarded – undo
262 268
 			<div class="modbox">
263 269
 				<ul>';
264 270
 
265
-		foreach ($context['reported_users'] as $user)
266
-			echo '
271
+		foreach ($context['reported_users'] as $user) {
272
+					echo '
267 273
 					<li>
268 274
 						<span class="smalltext">', $user['user']['link'], '</span>
269 275
 					</li>';
276
+		}
270 277
 
271 278
 		// Don't have any watched users right now?
272
-		if (empty($context['reported_users']))
273
-			echo '
279
+		if (empty($context['reported_users'])) {
280
+					echo '
274 281
 					<li>
275 282
 						<strong class="smalltext">', $txt['mc_reported_users_none'], '</strong>
276 283
 					</li>';
284
+		}
277 285
 
278 286
 		echo '
279 287
 				</ul>
@@ -344,11 +352,12 @@  discard block
 block discarded – undo
344 352
 						<ul class="moderation_notes">';
345 353
 
346 354
 		// Cycle through the notes.
347
-		foreach ($context['notes'] as $note)
348
-			echo '
355
+		foreach ($context['notes'] as $note) {
356
+					echo '
349 357
 							<li class="smalltext">
350 358
 								', ($note['can_delete'] ? '<a href="' . $note['delete_href'] . ';' . $context['mod-modnote-del_token_var'] . '=' . $context['mod-modnote-del_token'] . '" data-confirm="' . $txt['mc_reportedp_delete_confirm'] . '" class="you_sure"><span class="generic_icons delete"></span></a>' : ''), $note['time'], ' <strong>', $note['author']['link'], ':</strong> ', $note['text'], '
351 359
 							</li>';
360
+		}
352 361
 
353 362
 		echo '
354 363
 						</ul>
@@ -390,18 +399,19 @@  discard block
 block discarded – undo
390 399
 	$remove_button = create_button('delete', 'remove_message', 'remove');
391 400
 
392 401
 	// No posts?
393
-	if (empty($context['unapproved_items']))
394
-		echo '
402
+	if (empty($context['unapproved_items'])) {
403
+			echo '
395 404
 			<div class="windowbg2">
396 405
 				<p class="centertext">
397 406
 					', $txt['mc_unapproved_' . $context['current_view'] . '_none_found'], '
398 407
 				</p>
399 408
 			</div>';
400
-	else
401
-		echo '
409
+	} else {
410
+			echo '
402 411
 			<div class="pagesection floatleft">
403 412
 				', $context['page_index'], '
404 413
 			</div>';
414
+	}
405 415
 
406 416
 	foreach ($context['unapproved_items'] as $item)
407 417
 	{
@@ -420,14 +430,16 @@  discard block
 block discarded – undo
420 430
 				<span class="floatright">
421 431
 					<a href="', $scripturl, '?action=moderate;area=postmod;sa=', $context['current_view'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';approve=', $item['id'], '">', $approve_button, '</a>';
422 432
 
423
-		if ($item['can_delete'])
424
-			echo '
433
+		if ($item['can_delete']) {
434
+					echo '
425 435
 					', $context['menu_separator'], '
426 436
 					<a href="', $scripturl, '?action=moderate;area=postmod;sa=', $context['current_view'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';delete=', $item['id'], '">', $remove_button, '</a>';
437
+		}
427 438
 
428
-		if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1)
429
-			echo '
439
+		if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) {
440
+					echo '
430 441
 					<input type="checkbox" name="item[]" value="', $item['id'], '" checked> ';
442
+		}
431 443
 
432 444
 		echo '
433 445
 				</span>
@@ -437,8 +449,8 @@  discard block
 block discarded – undo
437 449
 	echo '
438 450
 			<div class="pagesection">';
439 451
 
440
-	if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1)
441
-		echo '
452
+	if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) {
453
+			echo '
442 454
 				<div class="floatright">
443 455
 					<select name="do" onchange="if (this.value != 0 &amp;&amp; confirm(\'', $txt['mc_unapproved_sure'], '\')) submit();">
444 456
 						<option value="0">', $txt['with_selected'], ':</option>
@@ -450,12 +462,14 @@  discard block
 block discarded – undo
450 462
 						<input type="submit" name="mc_go" value="', $txt['go'], '" class="button">
451 463
 					</noscript>
452 464
 				</div>';
465
+	}
453 466
 
454
-	if (!empty($context['unapproved_items']))
455
-		echo '
467
+	if (!empty($context['unapproved_items'])) {
468
+			echo '
456 469
 				<div class="floatleft">
457 470
 					<div class="pagelinks">', $context['page_index'], '</div>
458 471
 				</div>';
472
+	}
459 473
 
460 474
 	echo '
461 475
 			</div><!-- .pagesection -->
@@ -475,8 +489,9 @@  discard block
 block discarded – undo
475 489
 	global $scripturl, $context, $txt, $delete_button;
476 490
 
477 491
 	// We'll have a delete please bob.
478
-	if (empty($delete_button))
479
-		$delete_button = create_button('delete', 'remove_message', 'remove', 'class="centericon"');
492
+	if (empty($delete_button)) {
493
+			$delete_button = create_button('delete', 'remove_message', 'remove', 'class="centericon"');
494
+	}
480 495
 
481 496
 	$output_html = '
482 497
 					<div>
@@ -485,10 +500,11 @@  discard block
 block discarded – undo
485 500
 						</div>
486 501
 						<div class="floatright">';
487 502
 
488
-	if ($post['can_delete'])
489
-		$output_html .= '
503
+	if ($post['can_delete']) {
504
+			$output_html .= '
490 505
 							<a href="' . $scripturl . '?action=moderate;area=userwatch;sa=post;delete=' . $post['id'] . ';start=' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" data-confirm="' . $txt['mc_watched_users_delete_post'] . '" class="you_sure">' . $delete_button . '</a>
491 506
 							<input type="checkbox" name="delete[]" value="' . $post['id'] . '">';
507
+	}
492 508
 
493 509
 	$output_html .= '
494 510
 						</div>
@@ -531,12 +547,12 @@  discard block
 block discarded – undo
531 547
 				<input type="submit" name="save" value="', $txt['save'], '" class="button">
532 548
 			</div>
533 549
 		</form>';
534
-	}
535
-	else
536
-		echo '
550
+	} else {
551
+			echo '
537 552
 		<div class="windowbg">
538 553
 			<div class="centertext">', $txt['mc_no_settings'], '</div>
539 554
 		</div>';
555
+	}
540 556
 
541 557
 	echo '
542 558
 	</div><!-- #modcenter -->';
@@ -632,13 +648,14 @@  discard block
 block discarded – undo
632 648
 					</dd>
633 649
 				</dl>';
634 650
 
635
-	if ($context['template_data']['can_edit_personal'])
636
-		echo '
651
+	if ($context['template_data']['can_edit_personal']) {
652
+			echo '
637 653
 				<input type="checkbox" name="make_personal" id="make_personal"', $context['template_data']['personal'] ? ' checked' : '', '>
638 654
 					<label for="make_personal">
639 655
 						<strong>', $txt['mc_warning_template_personal'], '</strong>
640 656
 					</label><br>
641 657
 					<span class="smalltext">', $txt['mc_warning_template_personal_desc'], '</span><br>';
658
+	}
642 659
 
643 660
 	echo '
644 661
 				<hr>
Please login to merge, or discard this patch.
Themes/default/ManageCalendar.template.php 1 patch
Braces   +14 added lines, -10 removed lines patch added patch discarded remove patch
@@ -40,9 +40,10 @@  discard block
 block discarded – undo
40 40
 							<option value="0000"', $context['holiday']['year'] == '0000' ? ' selected' : '', '>', $txt['every_year'], '</option>';
41 41
 
42 42
 	// Show a list of all the years we allow...
43
-	for ($year = $modSettings['cal_minyear']; $year <= $modSettings['cal_maxyear']; $year++)
44
-		echo '
43
+	for ($year = $modSettings['cal_minyear']; $year <= $modSettings['cal_maxyear']; $year++) {
44
+			echo '
45 45
 							<option value="', $year, '"', $year == $context['holiday']['year'] ? ' selected' : '', '>', $year, '</option>';
46
+	}
46 47
 
47 48
 	echo '
48 49
 						</select>&nbsp;
@@ -50,9 +51,10 @@  discard block
 block discarded – undo
50 51
 						<select name="month" id="month" onchange="generateDays();">';
51 52
 
52 53
 	// There are 12 months per year - ensure that they all get listed.
53
-	for ($month = 1; $month <= 12; $month++)
54
-		echo '
54
+	for ($month = 1; $month <= 12; $month++) {
55
+			echo '
55 56
 							<option value="', $month, '"', $month == $context['holiday']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>';
57
+	}
56 58
 
57 59
 	echo '
58 60
 						</select>&nbsp;
@@ -60,23 +62,25 @@  discard block
 block discarded – undo
60 62
 						<select name="day" id="day" onchange="generateDays();">';
61 63
 
62 64
 	// This prints out all the days in the current month - this changes dynamically as we switch months.
63
-	for ($day = 1; $day <= $context['holiday']['last_day']; $day++)
64
-		echo '
65
+	for ($day = 1; $day <= $context['holiday']['last_day']; $day++) {
66
+			echo '
65 67
 							<option value="', $day, '"', $day == $context['holiday']['day'] ? ' selected' : '', '>', $day, '</option>';
68
+	}
66 69
 
67 70
 	echo '
68 71
 						</select>
69 72
 					</dd>
70 73
 				</dl>';
71 74
 
72
-	if ($context['is_new'])
73
-		echo '
75
+	if ($context['is_new']) {
76
+			echo '
74 77
 				<input type="submit" value="', $txt['holidays_button_add'], '" class="button">';
75
-	else
76
-		echo '
78
+	} else {
79
+			echo '
77 80
 				<input type="submit" name="edit" value="', $txt['holidays_button_edit'], '" class="button">
78 81
 				<input type="submit" name="delete" value="', $txt['holidays_button_remove'], '" class="button">
79 82
 				<input type="hidden" name="holiday" value="', $context['holiday']['id'], '">';
83
+	}
80 84
 	echo '
81 85
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
82 86
 			</div><!-- .windowbg2 -->
Please login to merge, or discard this patch.
Themes/default/ReportedContent.template.php 1 patch
Braces   +54 added lines, -36 removed lines patch added patch discarded remove patch
@@ -55,8 +55,9 @@  discard block
 block discarded – undo
55 55
 		// Prepare the comments...
56 56
 		$comments = array();
57 57
 
58
-		foreach ($report['comments'] as $comment)
59
-			$comments[$comment['member']['id']] = $comment['member']['link'];
58
+		foreach ($report['comments'] as $comment) {
59
+					$comments[$comment['member']['id']] = $comment['member']['link'];
60
+		}
60 61
 
61 62
 		echo '
62 63
 				', $txt['mc_reportedp_reported_by'], ': ', implode(', ', $comments), '
@@ -72,18 +73,21 @@  discard block
 block discarded – undo
72 73
 				<li><a href="', $scripturl, '?action=moderate;area=reportedposts;sa=handle;closed=', (int) !$report['closed'], ';rid=', $report['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';', $context['mod-report-closed_token_var'], '=', $context['mod-report-closed_token'], '">', $close_button, '</a></li>';
73 74
 
74 75
 		// Delete message button.
75
-		if (!$report['closed'] && (is_array($context['report_remove_any_boards']) && in_array($report['topic']['id_board'], $context['report_remove_any_boards'])))
76
-			echo '
76
+		if (!$report['closed'] && (is_array($context['report_remove_any_boards']) && in_array($report['topic']['id_board'], $context['report_remove_any_boards']))) {
77
+					echo '
77 78
 				<li><a href="', $scripturl, '?action=deletemsg;topic=', $report['topic']['id'], '.0;msg=', $report['topic']['id_msg'], ';modcenter;', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['mc_reportedp_delete_confirm'], '" class="you_sure">', $delete_button, '</a></li>';
79
+		}
78 80
 
79 81
 		// Ban this user button.
80
-		if (!$report['closed'] && !empty($context['report_manage_bans']))
81
-			echo '
82
+		if (!$report['closed'] && !empty($context['report_manage_bans'])) {
83
+					echo '
82 84
 				<li><a href="', $scripturl, '?action=admin;area=ban;sa=add', (!empty($report['author']['id']) ? ';u=' . $report['author']['id'] : ';msg=' . $report['topic']['id_msg']), ';', $context['session_var'], '=', $context['session_id'], '">', $ban_button, '</a></li>';
85
+		}
83 86
 
84
-		if (!$context['view_closed'])
85
-			echo '
87
+		if (!$context['view_closed']) {
88
+					echo '
86 89
 				<li><input type="checkbox" name="close[]" value="' . $report['id'] . '"></li>';
90
+		}
87 91
 
88 92
 			echo '
89 93
 			</ul>
@@ -91,18 +95,20 @@  discard block
 block discarded – undo
91 95
 	}
92 96
 
93 97
 	// Were none found?
94
-	if (empty($context['reports']))
95
-		echo '
98
+	if (empty($context['reports'])) {
99
+			echo '
96 100
 		<div class="windowbg2">
97 101
 			<p class="centertext">', $txt['mc_reportedp_none_found'], '</p>
98 102
 		</div>';
103
+	}
99 104
 
100 105
 	echo '
101 106
 		<div class="pagesection">';
102 107
 	
103
-	if (!empty($context['total_reports']) && $context['total_reports'] >= $context['reports_how_many'])
104
-		echo '
108
+	if (!empty($context['total_reports']) && $context['total_reports'] >= $context['reports_how_many']) {
109
+			echo '
105 110
 			<div class="pagelinks floatleft">' . $context['page_index'] . '</div>';
111
+	}
106 112
 
107 113
 	echo '
108 114
 			<div class="floatright">', !$context['view_closed'] ? '
@@ -133,18 +139,20 @@  discard block
 block discarded – undo
133 139
 			<div class="modbox">
134 140
 				<ul>';
135 141
 
136
-	foreach ($context['reported_posts'] as $report)
137
-		echo '
142
+	foreach ($context['reported_posts'] as $report) {
143
+			echo '
138 144
 					<li class="smalltext">
139 145
 						<a href="', $report['report_href'], '">', $report['subject'], '</a> ', $txt['mc_reportedp_by'], ' ', $report['author']['link'], '
140 146
 					</li>';
147
+	}
141 148
 
142 149
 	// Don't have any watched users right now?
143
-	if (empty($context['reported_posts']))
144
-		echo '
150
+	if (empty($context['reported_posts'])) {
151
+			echo '
145 152
 					<li>
146 153
 						<strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong>
147 154
 					</li>';
155
+	}
148 156
 
149 157
 	echo '
150 158
 				</ul>
@@ -234,14 +242,15 @@  discard block
 block discarded – undo
234 242
 				<h3 class="catbg">', $txt['mc_modreport_whoreported_title'], '</h3>
235 243
 			</div>';
236 244
 
237
-	foreach ($context['report']['comments'] as $comment)
238
-		echo '
245
+	foreach ($context['report']['comments'] as $comment) {
246
+			echo '
239 247
 			<div class="windowbg">
240 248
 				<p class="smalltext">
241 249
 					', sprintf($txt['mc_modreport_whoreported_data'], $comment['member']['link'] . (empty($comment['member']['id']) && !empty($comment['member']['ip']) ? ' (' . $comment['member']['ip'] . ')' : ''), $comment['time']), '
242 250
 				</p>
243 251
 				<p>', $comment['message'], '</p>
244 252
 			</div>';
253
+	}
245 254
 
246 255
 	echo '
247 256
 			<br>
@@ -250,11 +259,12 @@  discard block
 block discarded – undo
250 259
 			</div>
251 260
 			<div>';
252 261
 
253
-	if (empty($context['report']['mod_comments']))
254
-		echo '
262
+	if (empty($context['report']['mod_comments'])) {
263
+			echo '
255 264
 				<div class="information">
256 265
 					<p class="centertext">', $txt['mc_modreport_no_mod_comment'], '</p>
257 266
 				</div>';
267
+	}
258 268
 
259 269
 	foreach ($context['report']['mod_comments'] as $comment)
260 270
 	{
@@ -346,18 +356,20 @@  discard block
 block discarded – undo
346 356
 			<div class="modbox">
347 357
 				<ul>';
348 358
 
349
-	foreach ($context['reported_members'] as $report)
350
-		echo '
359
+	foreach ($context['reported_members'] as $report) {
360
+			echo '
351 361
 					<li class="smalltext">
352 362
 						<a href="', $report['report_href'], '">', $report['user_name'], '</a>
353 363
 					</li>';
364
+	}
354 365
 
355 366
 	// Don't have any reported members right now?
356
-	if (empty($context['reported_members']))
357
-		echo '
367
+	if (empty($context['reported_members'])) {
368
+			echo '
358 369
 					<li>
359 370
 						<strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong>
360 371
 					</li>';
372
+	}
361 373
 
362 374
 	echo '
363 375
 				</ul>
@@ -443,8 +455,9 @@  discard block
 block discarded – undo
443 455
 
444 456
 		// Prepare the comments...
445 457
 		$comments = array();
446
-		foreach ($report['comments'] as $comment)
447
-			$comments[$comment['member']['id']] = $comment['member']['link'];
458
+		foreach ($report['comments'] as $comment) {
459
+					$comments[$comment['member']['id']] = $comment['member']['link'];
460
+		}
448 461
 
449 462
 		echo '
450 463
 				', $txt['mc_reportedp_reported_by'], ': ', implode(', ', $comments), '
@@ -456,13 +469,15 @@  discard block
 block discarded – undo
456 469
 				<li><a href="', $scripturl, '?action=moderate;area=reportedmembers;sa=handle;closed=', (int) !$report['closed'], ';rid=', $report['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';', $context['mod-report-closed_token_var'], '=', $context['mod-report-closed_token'], '">', $close_button, '</a></li>';
457 470
 
458 471
 		// Ban this user button.
459
-		if (!$report['closed'] && !empty($context['report_manage_bans']) && !empty($report['user']['id']))
460
-			echo '
472
+		if (!$report['closed'] && !empty($context['report_manage_bans']) && !empty($report['user']['id'])) {
473
+					echo '
461 474
 				<li><a href="', $scripturl, '?action=admin;area=ban;sa=add;u=', $report['user']['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $ban_button, '</a></li>';
475
+		}
462 476
 
463
-		if (!$context['view_closed'])
464
-			echo '
477
+		if (!$context['view_closed']) {
478
+					echo '
465 479
 				<li><input type="checkbox" name="close[]" value="' . $report['id'] . '"></li>';
480
+		}
466 481
 
467 482
 			echo '
468 483
 			</ul>
@@ -470,11 +485,12 @@  discard block
 block discarded – undo
470 485
 	}
471 486
 
472 487
 	// Were none found?
473
-	if (empty($context['reports']))
474
-		echo '
488
+	if (empty($context['reports'])) {
489
+			echo '
475 490
 		<div class="windowbg2">
476 491
 			<p class="centertext">', $txt['mc_reportedp_none_found'], '</p>
477 492
 		</div>';
493
+	}
478 494
 
479 495
 	echo '
480 496
 		<div class="pagesection">
@@ -534,14 +550,15 @@  discard block
 block discarded – undo
534 550
 				<h3 class="catbg">', $txt['mc_memberreport_whoreported_title'], '</h3>
535 551
 			</div>';
536 552
 
537
-	foreach ($context['report']['comments'] as $comment)
538
-		echo '
553
+	foreach ($context['report']['comments'] as $comment) {
554
+			echo '
539 555
 			<div class="windowbg">
540 556
 				<p class="smalltext">
541 557
 					', sprintf($txt['mc_modreport_whoreported_data'], $comment['member']['link'] . (empty($comment['member']['id']) && !empty($comment['member']['ip']) ? ' (' . $comment['member']['ip'] . ')' : ''), $comment['time']), '
542 558
 				</p>
543 559
 				<p>', $comment['message'], '</p>
544 560
 			</div>';
561
+	}
545 562
 
546 563
 	echo '
547 564
 			<br>
@@ -550,11 +567,12 @@  discard block
 block discarded – undo
550 567
 			</div>
551 568
 			<div>';
552 569
 
553
-	if (empty($context['report']['mod_comments']))
554
-		echo '
570
+	if (empty($context['report']['mod_comments'])) {
571
+			echo '
555 572
 				<div class="information">
556 573
 					<p class="centertext">', $txt['mc_modreport_no_mod_comment'], '</p>
557 574
 				</div>';
575
+	}
558 576
 
559 577
 	foreach ($context['report']['mod_comments'] as $comment)
560 578
 	{
Please login to merge, or discard this patch.