Completed
Push — release-2.1 ( a1f315...adc3c7 )
by
unknown
12s
created
Sources/Post.php 1 patch
Braces   +674 added lines, -521 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Handles showing the post screen, loading the post to be modified, and loading any post quoted.
@@ -35,12 +36,14 @@  discard block
 block discarded – undo
35 36
 	global $sourcedir, $smcFunc, $language;
36 37
 
37 38
 	loadLanguage('Post');
38
-	if (!empty($modSettings['drafts_post_enabled']))
39
-		loadLanguage('Drafts');
39
+	if (!empty($modSettings['drafts_post_enabled'])) {
40
+			loadLanguage('Drafts');
41
+	}
40 42
 
41 43
 	// You can't reply with a poll... hacker.
42
-	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg']))
43
-		unset($_REQUEST['poll']);
44
+	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg'])) {
45
+			unset($_REQUEST['poll']);
46
+	}
44 47
 
45 48
 	// Posting an event?
46 49
 	$context['make_event'] = isset($_REQUEST['calendar']);
@@ -58,12 +61,14 @@  discard block
 block discarded – undo
58 61
 	{
59 62
 		// Get ids of all the boards they can post in.
60 63
 		$post_permissions = array('post_new');
61
-		if ($modSettings['postmod_active'])
62
-			$post_permissions[] = 'post_unapproved_topics';
64
+		if ($modSettings['postmod_active']) {
65
+					$post_permissions[] = 'post_unapproved_topics';
66
+		}
63 67
 
64 68
 		$boards = boardsAllowedTo($post_permissions);
65
-		if (empty($boards))
66
-			fatal_lang_error('cannot_post_new', false);
69
+		if (empty($boards)) {
70
+					fatal_lang_error('cannot_post_new', false);
71
+		}
67 72
 
68 73
 		// Get a list of boards for the select menu
69 74
 		require_once($sourcedir . '/Subs-MessageIndex.php');
@@ -76,8 +81,9 @@  discard block
 block discarded – undo
76 81
 		$board_list = getBoardList($boardListOptions);
77 82
 	}
78 83
 	// Let's keep things simple for ourselves below
79
-	else
80
-		$boards = array($board);
84
+	else {
85
+			$boards = array($board);
86
+	}
81 87
 
82 88
 	require_once($sourcedir . '/Subs-Post.php');
83 89
 
@@ -100,10 +106,11 @@  discard block
 block discarded – undo
100 106
 			array(
101 107
 				'msg' => (int) $_REQUEST['msg'],
102 108
 		));
103
-		if ($smcFunc['db_num_rows']($request) != 1)
104
-			unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
105
-		else
106
-			list ($topic) = $smcFunc['db_fetch_row']($request);
109
+		if ($smcFunc['db_num_rows']($request) != 1) {
110
+					unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
111
+		} else {
112
+					list ($topic) = $smcFunc['db_fetch_row']($request);
113
+		}
107 114
 		$smcFunc['db_free_result']($request);
108 115
 	}
109 116
 
@@ -130,33 +137,36 @@  discard block
 block discarded – undo
130 137
 		$smcFunc['db_free_result']($request);
131 138
 
132 139
 		// If this topic already has a poll, they sure can't add another.
133
-		if (isset($_REQUEST['poll']) && $pollID > 0)
134
-			unset($_REQUEST['poll']);
140
+		if (isset($_REQUEST['poll']) && $pollID > 0) {
141
+					unset($_REQUEST['poll']);
142
+		}
135 143
 
136 144
 		if (empty($_REQUEST['msg']))
137 145
 		{
138
-			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any')))
139
-				is_not_guest();
146
+			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any'))) {
147
+							is_not_guest();
148
+			}
140 149
 
141 150
 			// By default the reply will be approved...
142 151
 			$context['becomes_approved'] = true;
143 152
 			if ($id_member_poster != $user_info['id'] || $user_info['is_guest'])
144 153
 			{
145
-				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
146
-					$context['becomes_approved'] = false;
147
-				else
148
-					isAllowedTo('post_reply_any');
149
-			}
150
-			elseif (!allowedTo('post_reply_any'))
154
+				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
155
+									$context['becomes_approved'] = false;
156
+				} else {
157
+									isAllowedTo('post_reply_any');
158
+				}
159
+			} elseif (!allowedTo('post_reply_any'))
151 160
 			{
152
-				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any')))
153
-					$context['becomes_approved'] = false;
154
-				else
155
-					isAllowedTo('post_reply_own');
161
+				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any'))) {
162
+									$context['becomes_approved'] = false;
163
+				} else {
164
+									isAllowedTo('post_reply_own');
165
+				}
156 166
 			}
167
+		} else {
168
+					$context['becomes_approved'] = true;
157 169
 		}
158
-		else
159
-			$context['becomes_approved'] = true;
160 170
 
161 171
 		$context['can_lock'] = allowedTo('lock_any') || ($user_info['id'] == $id_member_poster && allowedTo('lock_own'));
162 172
 		$context['can_sticky'] = allowedTo('make_sticky');
@@ -171,17 +181,18 @@  discard block
 block discarded – undo
171 181
 		$context['sticky'] = isset($_REQUEST['sticky']) ? !empty($_REQUEST['sticky']) : $sticky;
172 182
 
173 183
 		// Check whether this is a really old post being bumped...
174
-		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject']))
175
-			$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
176
-	}
177
-	else
184
+		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject'])) {
185
+					$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
186
+		}
187
+	} else
178 188
 	{
179 189
 		// @todo Should use JavaScript to hide and show the warning based on the selection in the board select menu
180 190
 		$context['becomes_approved'] = true;
181
-		if ($modSettings['postmod_active'] && !allowedTo('post_new', $boards, true) && allowedTo('post_unapproved_topics', $boards, true))
182
-			$context['becomes_approved'] = false;
183
-		else
184
-			isAllowedTo('post_new', $boards, true);
191
+		if ($modSettings['postmod_active'] && !allowedTo('post_new', $boards, true) && allowedTo('post_unapproved_topics', $boards, true)) {
192
+					$context['becomes_approved'] = false;
193
+		} else {
194
+					isAllowedTo('post_new', $boards, true);
195
+		}
185 196
 
186 197
 		$locked = 0;
187 198
 		$context['already_locked'] = 0;
@@ -211,27 +222,32 @@  discard block
 block discarded – undo
211 222
 	if (empty($_REQUEST['message']) && empty($_REQUEST['preview']) && !empty($_SESSION['already_attached']))
212 223
 	{
213 224
 		require_once($sourcedir . '/ManageAttachments.php');
214
-		foreach ($_SESSION['already_attached'] as $attachID => $attachment)
215
-			removeAttachments(array('id_attach' => $attachID));
225
+		foreach ($_SESSION['already_attached'] as $attachID => $attachment) {
226
+					removeAttachments(array('id_attach' => $attachID));
227
+		}
216 228
 
217 229
 		unset($_SESSION['already_attached']);
218 230
 	}
219 231
 
220 232
 	// Don't allow a post if it's locked and you aren't all powerful.
221
-	if ($locked && !allowedTo('moderate_board'))
222
-		fatal_lang_error('topic_locked', false);
233
+	if ($locked && !allowedTo('moderate_board')) {
234
+			fatal_lang_error('topic_locked', false);
235
+	}
223 236
 	// Check the users permissions - is the user allowed to add or post a poll?
224 237
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
225 238
 	{
226 239
 		// New topic, new poll.
227
-		if (empty($topic))
228
-			isAllowedTo('poll_post');
240
+		if (empty($topic)) {
241
+					isAllowedTo('poll_post');
242
+		}
229 243
 		// This is an old topic - but it is yours!  Can you add to it?
230
-		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any'))
231
-			isAllowedTo('poll_add_own');
244
+		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any')) {
245
+					isAllowedTo('poll_add_own');
246
+		}
232 247
 		// If you're not the owner, can you add to any poll?
233
-		else
234
-			isAllowedTo('poll_add_any');
248
+		else {
249
+					isAllowedTo('poll_add_any');
250
+		}
235 251
 
236 252
 		if (!empty($board))
237 253
 		{
@@ -240,8 +256,9 @@  discard block
 block discarded – undo
240 256
 			$guest_vote_enabled = in_array(-1, $allowedVoteGroups['allowed']);
241 257
 		}
242 258
 		// No board, so we'll have to check this again in Post2
243
-		else
244
-			$guest_vote_enabled = true;
259
+		else {
260
+					$guest_vote_enabled = true;
261
+		}
245 262
 
246 263
 		// Set up the poll options.
247 264
 		$context['poll_options'] = array(
@@ -267,8 +284,9 @@  discard block
 block discarded – undo
267 284
 	if ($context['make_event'])
268 285
 	{
269 286
 		// They might want to pick a board.
270
-		if (!isset($context['current_board']))
271
-			$context['current_board'] = 0;
287
+		if (!isset($context['current_board'])) {
288
+					$context['current_board'] = 0;
289
+		}
272 290
 
273 291
 		// Start loading up the event info.
274 292
 		$context['event'] = array();
@@ -282,10 +300,11 @@  discard block
 block discarded – undo
282 300
 		isAllowedTo('calendar_post');
283 301
 
284 302
 		// We want a fairly compact version of the time, but as close as possible to the user's settings.
285
-		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
286
-			$time_string = '%k:%M';
287
-		else
288
-			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
303
+		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
304
+					$time_string = '%k:%M';
305
+		} else {
306
+					$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
307
+		}
289 308
 
290 309
 		$js_time_string = str_replace(
291 310
 			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
@@ -307,8 +326,7 @@  discard block
 block discarded – undo
307 326
 			require_once($sourcedir . '/Subs-Calendar.php');
308 327
 			$eventProperties = getEventProperties($context['event']['id']);
309 328
 			$context['event'] = array_merge($context['event'], $eventProperties);
310
-		}
311
-		else
329
+		} else
312 330
 		{
313 331
 			// Get the current event information.
314 332
 			require_once($sourcedir . '/Subs-Calendar.php');
@@ -316,10 +334,12 @@  discard block
 block discarded – undo
316 334
 			$context['event'] = array_merge($context['event'], $eventProperties);
317 335
 
318 336
 			// Make sure the year and month are in the valid range.
319
-			if ($context['event']['month'] < 1 || $context['event']['month'] > 12)
320
-				fatal_lang_error('invalid_month', false);
321
-			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear'])
322
-				fatal_lang_error('invalid_year', false);
337
+			if ($context['event']['month'] < 1 || $context['event']['month'] > 12) {
338
+							fatal_lang_error('invalid_month', false);
339
+			}
340
+			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear']) {
341
+							fatal_lang_error('invalid_year', false);
342
+			}
323 343
 
324 344
 			$context['event']['categories'] = $board_list;
325 345
 		}
@@ -430,10 +450,11 @@  discard block
 block discarded – undo
430 450
 
431 451
 			if (!empty($context['new_replies']))
432 452
 			{
433
-				if ($context['new_replies'] == 1)
434
-					$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
435
-				else
436
-					$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
453
+				if ($context['new_replies'] == 1) {
454
+									$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
455
+				} else {
456
+									$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
457
+				}
437 458
 
438 459
 				$post_errors[] = 'new_replies';
439 460
 
@@ -445,9 +466,9 @@  discard block
 block discarded – undo
445 466
 	// Get a response prefix (like 'Re:') in the default forum language.
446 467
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
447 468
 	{
448
-		if ($language === $user_info['language'])
449
-			$context['response_prefix'] = $txt['response_prefix'];
450
-		else
469
+		if ($language === $user_info['language']) {
470
+					$context['response_prefix'] = $txt['response_prefix'];
471
+		} else
451 472
 		{
452 473
 			loadLanguage('index', $language, false);
453 474
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -460,23 +481,26 @@  discard block
 block discarded – undo
460 481
 	// Do we have a body, but an error happened.
461 482
 	if (isset($_REQUEST['message']) || isset($_REQUEST['quickReply']) || !empty($context['post_error']))
462 483
 	{
463
-		if (isset($_REQUEST['quickReply']))
464
-			$_REQUEST['message'] = $_REQUEST['quickReply'];
484
+		if (isset($_REQUEST['quickReply'])) {
485
+					$_REQUEST['message'] = $_REQUEST['quickReply'];
486
+		}
465 487
 
466 488
 		// Validate inputs.
467 489
 		if (empty($context['post_error']))
468 490
 		{
469 491
 			// This means they didn't click Post and get an error.
470 492
 			$really_previewing = true;
471
-		}
472
-		else
493
+		} else
473 494
 		{
474
-			if (!isset($_REQUEST['subject']))
475
-				$_REQUEST['subject'] = '';
476
-			if (!isset($_REQUEST['message']))
477
-				$_REQUEST['message'] = '';
478
-			if (!isset($_REQUEST['icon']))
479
-				$_REQUEST['icon'] = 'xx';
495
+			if (!isset($_REQUEST['subject'])) {
496
+							$_REQUEST['subject'] = '';
497
+			}
498
+			if (!isset($_REQUEST['message'])) {
499
+							$_REQUEST['message'] = '';
500
+			}
501
+			if (!isset($_REQUEST['icon'])) {
502
+							$_REQUEST['icon'] = 'xx';
503
+			}
480 504
 
481 505
 			// They are previewing if they asked to preview (i.e. came from quick reply).
482 506
 			$really_previewing = !empty($_POST['preview']);
@@ -492,8 +516,9 @@  discard block
 block discarded – undo
492 516
 		$form_message = $smcFunc['htmlspecialchars']($_REQUEST['message'], ENT_QUOTES);
493 517
 
494 518
 		// Make sure the subject isn't too long - taking into account special characters.
495
-		if ($smcFunc['strlen']($form_subject) > 100)
496
-			$form_subject = $smcFunc['substr']($form_subject, 0, 100);
519
+		if ($smcFunc['strlen']($form_subject) > 100) {
520
+					$form_subject = $smcFunc['substr']($form_subject, 0, 100);
521
+		}
497 522
 
498 523
 		if (isset($_REQUEST['poll']))
499 524
 		{
@@ -505,8 +530,9 @@  discard block
 block discarded – undo
505 530
 			$_POST['options'] = empty($_POST['options']) ? array() : htmlspecialchars__recursive($_POST['options']);
506 531
 			foreach ($_POST['options'] as $option)
507 532
 			{
508
-				if (trim($option) == '')
509
-					continue;
533
+				if (trim($option) == '') {
534
+									continue;
535
+				}
510 536
 
511 537
 				$context['choices'][] = array(
512 538
 					'id' => $choice_id++,
@@ -568,13 +594,14 @@  discard block
 block discarded – undo
568 594
 				$context['preview_subject'] = $form_subject;
569 595
 
570 596
 				censorText($context['preview_subject']);
597
+			} else {
598
+							$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
571 599
 			}
572
-			else
573
-				$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
574 600
 
575 601
 			// Protect any CDATA blocks.
576
-			if (isset($_REQUEST['xml']))
577
-				$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
602
+			if (isset($_REQUEST['xml'])) {
603
+							$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
604
+			}
578 605
 		}
579 606
 
580 607
 		// Set up the checkboxes.
@@ -613,29 +640,32 @@  discard block
 block discarded – undo
613 640
 			);
614 641
 			// The message they were trying to edit was most likely deleted.
615 642
 			// @todo Change this error message?
616
-			if ($smcFunc['db_num_rows']($request) == 0)
617
-				fatal_lang_error('no_board', false);
643
+			if ($smcFunc['db_num_rows']($request) == 0) {
644
+							fatal_lang_error('no_board', false);
645
+			}
618 646
 			$row = $smcFunc['db_fetch_assoc']($request);
619 647
 
620 648
 			$attachment_stuff = array($row);
621
-			while ($row2 = $smcFunc['db_fetch_assoc']($request))
622
-				$attachment_stuff[] = $row2;
649
+			while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
650
+							$attachment_stuff[] = $row2;
651
+			}
623 652
 			$smcFunc['db_free_result']($request);
624 653
 
625 654
 			if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
626 655
 			{
627 656
 				// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
628
-				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
629
-					fatal_lang_error('modify_post_time_passed', false);
630
-				elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
631
-					isAllowedTo('modify_replies');
632
-				else
633
-					isAllowedTo('modify_own');
657
+				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
658
+									fatal_lang_error('modify_post_time_passed', false);
659
+				} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
660
+									isAllowedTo('modify_replies');
661
+				} else {
662
+									isAllowedTo('modify_own');
663
+				}
664
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
665
+							isAllowedTo('modify_replies');
666
+			} else {
667
+							isAllowedTo('modify_any');
634 668
 			}
635
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
636
-				isAllowedTo('modify_replies');
637
-			else
638
-				isAllowedTo('modify_any');
639 669
 
640 670
 			if ($context['can_announce'] && !empty($row['id_action']))
641 671
 			{
@@ -659,8 +689,9 @@  discard block
 block discarded – undo
659 689
 
660 690
 				while ($row = $smcFunc['db_fetch_assoc']($request))
661 691
 				{
662
-					if ($row['filesize'] <= 0)
663
-						continue;
692
+					if ($row['filesize'] <= 0) {
693
+											continue;
694
+					}
664 695
 					$context['current_attachments'][$row['id_attach']] = array(
665 696
 						'name' => $smcFunc['htmlspecialchars']($row['filename']),
666 697
 						'size' => $row['filesize'],
@@ -730,29 +761,32 @@  discard block
 block discarded – undo
730 761
 			)
731 762
 		);
732 763
 		// The message they were trying to edit was most likely deleted.
733
-		if ($smcFunc['db_num_rows']($request) == 0)
734
-			fatal_lang_error('no_message', false);
764
+		if ($smcFunc['db_num_rows']($request) == 0) {
765
+					fatal_lang_error('no_message', false);
766
+		}
735 767
 		$row = $smcFunc['db_fetch_assoc']($request);
736 768
 
737 769
 		$attachment_stuff = array($row);
738
-		while ($row2 = $smcFunc['db_fetch_assoc']($request))
739
-			$attachment_stuff[] = $row2;
770
+		while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
771
+					$attachment_stuff[] = $row2;
772
+		}
740 773
 		$smcFunc['db_free_result']($request);
741 774
 
742 775
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
743 776
 		{
744 777
 			// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
745
-			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
746
-				fatal_lang_error('modify_post_time_passed', false);
747
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
748
-				isAllowedTo('modify_replies');
749
-			else
750
-				isAllowedTo('modify_own');
778
+			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
779
+							fatal_lang_error('modify_post_time_passed', false);
780
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
781
+							isAllowedTo('modify_replies');
782
+			} else {
783
+							isAllowedTo('modify_own');
784
+			}
785
+		} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
786
+					isAllowedTo('modify_replies');
787
+		} else {
788
+					isAllowedTo('modify_any');
751 789
 		}
752
-		elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
753
-			isAllowedTo('modify_replies');
754
-		else
755
-			isAllowedTo('modify_any');
756 790
 
757 791
 		if ($context['can_announce'] && !empty($row['id_action']))
758 792
 		{
@@ -779,15 +813,17 @@  discard block
 block discarded – undo
779 813
 		$context['icon'] = $row['icon'];
780 814
 
781 815
 		// Show an "approve" box if the user can approve it, and the message isn't approved.
782
-		if (!$row['approved'] && !$context['show_approval'])
783
-			$context['show_approval'] = allowedTo('approve_posts');
816
+		if (!$row['approved'] && !$context['show_approval']) {
817
+					$context['show_approval'] = allowedTo('approve_posts');
818
+		}
784 819
 
785 820
 		// Sort the attachments so they are in the order saved
786 821
 		$temp = array();
787 822
 		foreach ($attachment_stuff as $attachment)
788 823
 		{
789
-			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable']))
790
-				$temp[$attachment['id_attach']] = $attachment;
824
+			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable'])) {
825
+							$temp[$attachment['id_attach']] = $attachment;
826
+			}
791 827
 		}
792 828
 		ksort($temp);
793 829
 
@@ -848,14 +884,16 @@  discard block
 block discarded – undo
848 884
 					'is_approved' => 1,
849 885
 				)
850 886
 			);
851
-			if ($smcFunc['db_num_rows']($request) == 0)
852
-				fatal_lang_error('quoted_post_deleted', false);
887
+			if ($smcFunc['db_num_rows']($request) == 0) {
888
+							fatal_lang_error('quoted_post_deleted', false);
889
+			}
853 890
 			list ($form_subject, $mname, $mdate, $form_message) = $smcFunc['db_fetch_row']($request);
854 891
 			$smcFunc['db_free_result']($request);
855 892
 
856 893
 			// Add 'Re: ' to the front of the quoted subject.
857
-			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
858
-				$form_subject = $context['response_prefix'] . $form_subject;
894
+			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
895
+							$form_subject = $context['response_prefix'] . $form_subject;
896
+			}
859 897
 
860 898
 			// Censor the message and subject.
861 899
 			censorText($form_message);
@@ -868,10 +906,11 @@  discard block
 block discarded – undo
868 906
 				for ($i = 0, $n = count($parts); $i < $n; $i++)
869 907
 				{
870 908
 					// It goes 0 = outside, 1 = begin tag, 2 = inside, 3 = close tag, repeat.
871
-					if ($i % 4 == 0)
872
-						$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
909
+					if ($i % 4 == 0) {
910
+											$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
873 911
 						{
874 912
 							return '[html]' . preg_replace('~<br\s?/?' . '>~i', '&lt;br /&gt;<br>', "$m[1]") . '[/html]';
913
+					}
875 914
 						}, $parts[$i]);
876 915
 				}
877 916
 				$form_message = implode('', $parts);
@@ -880,8 +919,9 @@  discard block
 block discarded – undo
880 919
 			$form_message = preg_replace('~<br ?/?' . '>~i', "\n", $form_message);
881 920
 
882 921
 			// Remove any nested quotes, if necessary.
883
-			if (!empty($modSettings['removeNestedQuotes']))
884
-				$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
922
+			if (!empty($modSettings['removeNestedQuotes'])) {
923
+							$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
924
+			}
885 925
 
886 926
 			// Add a quote string on the front and end.
887 927
 			$form_message = '[quote author=' . $mname . ' link=msg=' . (int) $_REQUEST['quote'] . ' date=' . $mdate . ']' . "\n" . rtrim($form_message) . "\n" . '[/quote]';
@@ -893,15 +933,15 @@  discard block
 block discarded – undo
893 933
 			$form_subject = $first_subject;
894 934
 
895 935
 			// Add 'Re: ' to the front of the subject.
896
-			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
897
-				$form_subject = $context['response_prefix'] . $form_subject;
936
+			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
937
+							$form_subject = $context['response_prefix'] . $form_subject;
938
+			}
898 939
 
899 940
 			// Censor the subject.
900 941
 			censorText($form_subject);
901 942
 
902 943
 			$form_message = '';
903
-		}
904
-		else
944
+		} else
905 945
 		{
906 946
 			$form_subject = isset($_GET['subject']) ? $_GET['subject'] : '';
907 947
 			$form_message = '';
@@ -920,13 +960,15 @@  discard block
 block discarded – undo
920 960
 		if (isset($_REQUEST['msg']))
921 961
 		{
922 962
 			$context['attachments']['quantity'] = count($context['current_attachments']);
923
-			foreach ($context['current_attachments'] as $attachment)
924
-				$context['attachments']['total_size'] += $attachment['size'];
963
+			foreach ($context['current_attachments'] as $attachment) {
964
+							$context['attachments']['total_size'] += $attachment['size'];
965
+			}
925 966
 		}
926 967
 
927 968
 		// A bit of house keeping first.
928
-		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1)
929
-			unset($_SESSION['temp_attachments']);
969
+		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1) {
970
+					unset($_SESSION['temp_attachments']);
971
+		}
930 972
 
931 973
 		if (!empty($_SESSION['temp_attachments']))
932 974
 		{
@@ -935,9 +977,10 @@  discard block
 block discarded – undo
935 977
 			{
936 978
 				foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
937 979
 				{
938
-					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
939
-						if (file_exists($attachment['tmp_name']))
980
+					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) {
981
+											if (file_exists($attachment['tmp_name']))
940 982
 							unlink($attachment['tmp_name']);
983
+					}
941 984
 				}
942 985
 				$post_errors[] = 'temp_attachments_gone';
943 986
 				$_SESSION['temp_attachments'] = array();
@@ -951,8 +994,9 @@  discard block
 block discarded – undo
951 994
 					// See if any files still exist before showing the warning message and the files attached.
952 995
 					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
953 996
 					{
954
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
955
-							continue;
997
+						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
998
+													continue;
999
+						}
956 1000
 
957 1001
 						if (file_exists($attachment['tmp_name']))
958 1002
 						{
@@ -962,20 +1006,21 @@  discard block
 block discarded – undo
962 1006
 							break;
963 1007
 						}
964 1008
 					}
965
-				}
966
-				else
1009
+				} else
967 1010
 				{
968 1011
 					// Since, they don't belong here. Let's inform the user that they exist..
969
-					if (!empty($topic))
970
-						$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
971
-					else
972
-						$delete_url = $scripturl . '?action=post' . (!empty($board) ? ';board=' . $board : '') . ';delete_temp';
1012
+					if (!empty($topic)) {
1013
+											$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
1014
+					} else {
1015
+											$delete_url = $scripturl . '?action=post' . (!empty($board) ? ';board=' . $board : '') . ';delete_temp';
1016
+					}
973 1017
 
974 1018
 					// Compile a list of the files to show the user.
975 1019
 					$file_list = array();
976
-					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
977
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
1020
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) {
1021
+											if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
978 1022
 							$file_list[] = $attachment['name'];
1023
+					}
979 1024
 
980 1025
 					$_SESSION['temp_attachments']['post']['files'] = $file_list;
981 1026
 					$file_list = '<div class="attachments">' . implode('<br>', $file_list) . '</div>';
@@ -987,8 +1032,7 @@  discard block
 block discarded – undo
987 1032
 
988 1033
 						$post_errors[] = array('temp_attachments_found', array($delete_url, $goback_url, $file_list));
989 1034
 						$context['ignore_temp_attachments'] = true;
990
-					}
991
-					else
1035
+					} else
992 1036
 					{
993 1037
 						$post_errors[] = array('temp_attachments_lost', array($delete_url, $file_list));
994 1038
 						$context['ignore_temp_attachments'] = true;
@@ -996,16 +1040,19 @@  discard block
 block discarded – undo
996 1040
 				}
997 1041
 			}
998 1042
 
999
-			if (!empty($context['we_are_history']))
1000
-				$post_errors[] = $context['we_are_history'];
1043
+			if (!empty($context['we_are_history'])) {
1044
+							$post_errors[] = $context['we_are_history'];
1045
+			}
1001 1046
 
1002 1047
 			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1003 1048
 			{
1004
-				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files']))
1005
-					break;
1049
+				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files'])) {
1050
+									break;
1051
+				}
1006 1052
 
1007
-				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1008
-					continue;
1053
+				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
1054
+									continue;
1055
+				}
1009 1056
 
1010 1057
 				if ($attachID == 'initial_error')
1011 1058
 				{
@@ -1020,15 +1067,17 @@  discard block
 block discarded – undo
1020 1067
 				{
1021 1068
 					$txt['error_attach_errors'] = empty($txt['error_attach_errors']) ? '<br>' : '';
1022 1069
 					$txt['error_attach_errors'] .= vsprintf($txt['attach_warning'], $attachment['name']) . '<div style="padding: 0 1em;">';
1023
-					foreach ($attachment['errors'] as $error)
1024
-						$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1070
+					foreach ($attachment['errors'] as $error) {
1071
+											$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1072
+					}
1025 1073
 					$txt['error_attach_errors'] .= '</div>';
1026 1074
 					$post_errors[] = 'attach_errors';
1027 1075
 
1028 1076
 					// Take out the trash.
1029 1077
 					unset($_SESSION['temp_attachments'][$attachID]);
1030
-					if (file_exists($attachment['tmp_name']))
1031
-						unlink($attachment['tmp_name']);
1078
+					if (file_exists($attachment['tmp_name'])) {
1079
+											unlink($attachment['tmp_name']);
1080
+					}
1032 1081
 					continue;
1033 1082
 				}
1034 1083
 
@@ -1041,8 +1090,9 @@  discard block
 block discarded – undo
1041 1090
 
1042 1091
 				$context['attachments']['quantity']++;
1043 1092
 				$context['attachments']['total_size'] += $attachment['size'];
1044
-				if (!isset($context['files_in_session_warning']))
1045
-					$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1093
+				if (!isset($context['files_in_session_warning'])) {
1094
+									$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1095
+				}
1046 1096
 
1047 1097
 				$context['current_attachments'][$attachID] = array(
1048 1098
 					'name' => '<u>' . $smcFunc['htmlspecialchars']($attachment['name']) . '</u>',
@@ -1070,8 +1120,9 @@  discard block
 block discarded – undo
1070 1120
 	}
1071 1121
 
1072 1122
 	// If they came from quick reply, and have to enter verification details, give them some notice.
1073
-	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification']))
1074
-		$post_errors[] = 'need_qr_verification';
1123
+	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification'])) {
1124
+			$post_errors[] = 'need_qr_verification';
1125
+	}
1075 1126
 
1076 1127
 	/*
1077 1128
 	 * There are two error types: serious and minor. Serious errors
@@ -1088,52 +1139,56 @@  discard block
 block discarded – undo
1088 1139
 	{
1089 1140
 		loadLanguage('Errors');
1090 1141
 		$context['error_type'] = 'minor';
1091
-		foreach ($post_errors as $post_error)
1092
-			if (is_array($post_error))
1142
+		foreach ($post_errors as $post_error) {
1143
+					if (is_array($post_error))
1093 1144
 			{
1094 1145
 				$post_error_id = $post_error[0];
1146
+		}
1095 1147
 				$context['post_error'][$post_error_id] = vsprintf($txt['error_' . $post_error_id], $post_error[1]);
1096 1148
 
1097 1149
 				// If it's not a minor error flag it as such.
1098
-				if (!in_array($post_error_id, $minor_errors))
1099
-					$context['error_type'] = 'serious';
1100
-			}
1101
-			else
1150
+				if (!in_array($post_error_id, $minor_errors)) {
1151
+									$context['error_type'] = 'serious';
1152
+				}
1153
+			} else
1102 1154
 			{
1103 1155
 				$context['post_error'][$post_error] = $txt['error_' . $post_error];
1104 1156
 
1105 1157
 				// If it's not a minor error flag it as such.
1106
-				if (!in_array($post_error, $minor_errors))
1107
-					$context['error_type'] = 'serious';
1158
+				if (!in_array($post_error, $minor_errors)) {
1159
+									$context['error_type'] = 'serious';
1160
+				}
1108 1161
 			}
1109 1162
 	}
1110 1163
 
1111 1164
 	// What are you doing? Posting a poll, modifying, previewing, new post, or reply...
1112
-	if (isset($_REQUEST['poll']))
1113
-		$context['page_title'] = $txt['new_poll'];
1114
-	elseif ($context['make_event'])
1115
-		$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1116
-	elseif (isset($_REQUEST['msg']))
1117
-		$context['page_title'] = $txt['modify_msg'];
1118
-	elseif (isset($_REQUEST['subject'], $context['preview_subject']))
1119
-		$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1120
-	elseif (empty($topic))
1121
-		$context['page_title'] = $txt['start_new_topic'];
1122
-	else
1123
-		$context['page_title'] = $txt['post_reply'];
1165
+	if (isset($_REQUEST['poll'])) {
1166
+			$context['page_title'] = $txt['new_poll'];
1167
+	} elseif ($context['make_event']) {
1168
+			$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1169
+	} elseif (isset($_REQUEST['msg'])) {
1170
+			$context['page_title'] = $txt['modify_msg'];
1171
+	} elseif (isset($_REQUEST['subject'], $context['preview_subject'])) {
1172
+			$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1173
+	} elseif (empty($topic)) {
1174
+			$context['page_title'] = $txt['start_new_topic'];
1175
+	} else {
1176
+			$context['page_title'] = $txt['post_reply'];
1177
+	}
1124 1178
 
1125 1179
 	// Build the link tree.
1126
-	if (empty($topic))
1127
-		$context['linktree'][] = array(
1180
+	if (empty($topic)) {
1181
+			$context['linktree'][] = array(
1128 1182
 			'name' => '<em>' . $txt['start_new_topic'] . '</em>'
1129 1183
 		);
1130
-	else
1131
-		$context['linktree'][] = array(
1184
+	} else {
1185
+			$context['linktree'][] = array(
1132 1186
 			'url' => $scripturl . '?topic=' . $topic . '.' . $_REQUEST['start'],
1133 1187
 			'name' => $form_subject,
1134 1188
 			'extra_before' => '<span><strong class="nav">' . $context['page_title'] . ' (</strong></span>',
1135 1189
 			'extra_after' => '<span><strong class="nav">)</strong></span>'
1136 1190
 		);
1191
+	}
1137 1192
 
1138 1193
 	$context['subject'] = addcslashes($form_subject, '"');
1139 1194
 	$context['message'] = str_replace(array('"', '<', '>', '&nbsp;'), array('&quot;', '&lt;', '&gt;', ' '), $form_message);
@@ -1177,8 +1232,9 @@  discard block
 block discarded – undo
1177 1232
 	// Message icons - customized icons are off?
1178 1233
 	$context['icons'] = getMessageIcons(!empty($board) ? $board : 0);
1179 1234
 
1180
-	if (!empty($context['icons']))
1181
-		$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1235
+	if (!empty($context['icons'])) {
1236
+			$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1237
+	}
1182 1238
 
1183 1239
 	// Are we starting a poll? if set the poll icon as selected if its available
1184 1240
 	if (isset($_REQUEST['poll']))
@@ -1198,8 +1254,9 @@  discard block
 block discarded – undo
1198 1254
 	for ($i = 0, $n = count($context['icons']); $i < $n; $i++)
1199 1255
 	{
1200 1256
 		$context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value'];
1201
-		if ($context['icons'][$i]['selected'])
1202
-			$context['icon_url'] = $context['icons'][$i]['url'];
1257
+		if ($context['icons'][$i]['selected']) {
1258
+					$context['icon_url'] = $context['icons'][$i]['url'];
1259
+		}
1203 1260
 	}
1204 1261
 	if (empty($context['icon_url']))
1205 1262
 	{
@@ -1213,8 +1270,9 @@  discard block
 block discarded – undo
1213 1270
 		));
1214 1271
 	}
1215 1272
 
1216
-	if (!empty($topic) && !empty($modSettings['topicSummaryPosts']))
1217
-		getTopic();
1273
+	if (!empty($topic) && !empty($modSettings['topicSummaryPosts'])) {
1274
+			getTopic();
1275
+	}
1218 1276
 
1219 1277
 	// If the user can post attachments prepare the warning labels.
1220 1278
 	if ($context['can_post_attachment'])
@@ -1225,12 +1283,13 @@  discard block
 block discarded – undo
1225 1283
 		$context['attachment_restrictions'] = array();
1226 1284
 		$context['allowed_extensions'] = strtr(strtolower($modSettings['attachmentExtensions']), array(',' => ', '));
1227 1285
 		$attachmentRestrictionTypes = array('attachmentNumPerPostLimit', 'attachmentPostLimit', 'attachmentSizeLimit');
1228
-		foreach ($attachmentRestrictionTypes as $type)
1229
-			if (!empty($modSettings[$type]))
1286
+		foreach ($attachmentRestrictionTypes as $type) {
1287
+					if (!empty($modSettings[$type]))
1230 1288
 			{
1231 1289
 				// Show the max number of attachments if not 0.
1232 1290
 				if ($type == 'attachmentNumPerPostLimit')
1233 1291
 					$context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']);
1292
+		}
1234 1293
 			}
1235 1294
 	}
1236 1295
 
@@ -1264,8 +1323,8 @@  discard block
 block discarded – undo
1264 1323
 
1265 1324
 	if (!empty($context['current_attachments']))
1266 1325
 	{
1267
-		foreach ($context['current_attachments'] as $key => $mock)
1268
-			addInlineJavaScript('
1326
+		foreach ($context['current_attachments'] as $key => $mock) {
1327
+					addInlineJavaScript('
1269 1328
 	current_attachments.push({
1270 1329
 		name: '. JavaScriptEscape($mock['name']) . ',
1271 1330
 		size: '. $mock['size'] . ',
@@ -1274,6 +1333,7 @@  discard block
 block discarded – undo
1274 1333
 		type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') . ',
1275 1334
 		thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) . '
1276 1335
 	});');
1336
+		}
1277 1337
 	}
1278 1338
 
1279 1339
 	// File Upload.
@@ -1348,9 +1408,10 @@  discard block
 block discarded – undo
1348 1408
 			$context['posting_fields']['board']['dd'] .= '
1349 1409
 							<optgroup label="' . $category['name'] . '">';
1350 1410
 
1351
-			foreach ($category['boards'] as $brd)
1352
-				$context['posting_fields']['board']['dd'] .= '
1411
+			foreach ($category['boards'] as $brd) {
1412
+							$context['posting_fields']['board']['dd'] .= '
1353 1413
 								<option value="' . $brd['id'] . '"' . ($brd['selected'] ? ' selected' : '') . '>' . ($brd['child_level'] > 0 ? str_repeat('==', $brd['child_level'] - 1) . '=&gt;' : '') . ' ' . $brd['name'] . '</option>';
1414
+			}
1354 1415
 
1355 1416
 			$context['posting_fields']['board']['dd'] .= '
1356 1417
 							</optgroup>';
@@ -1381,8 +1442,9 @@  discard block
 block discarded – undo
1381 1442
 
1382 1443
 
1383 1444
 	// Finally, load the template.
1384
-	if (!isset($_REQUEST['xml']))
1385
-		loadTemplate('Post');
1445
+	if (!isset($_REQUEST['xml'])) {
1446
+			loadTemplate('Post');
1447
+	}
1386 1448
 
1387 1449
 	call_integration_hook('integrate_post_end');
1388 1450
 }
@@ -1403,13 +1465,14 @@  discard block
 block discarded – undo
1403 1465
 	// Sneaking off, are we?
1404 1466
 	if (empty($_POST) && empty($topic))
1405 1467
 	{
1406
-		if (empty($_SERVER['CONTENT_LENGTH']))
1407
-			redirectexit('action=post;board=' . $board . '.0');
1408
-		else
1409
-			fatal_lang_error('post_upload_error', false);
1468
+		if (empty($_SERVER['CONTENT_LENGTH'])) {
1469
+					redirectexit('action=post;board=' . $board . '.0');
1470
+		} else {
1471
+					fatal_lang_error('post_upload_error', false);
1472
+		}
1473
+	} elseif (empty($_POST) && !empty($topic)) {
1474
+			redirectexit('action=post;topic=' . $topic . '.0');
1410 1475
 	}
1411
-	elseif (empty($_POST) && !empty($topic))
1412
-		redirectexit('action=post;topic=' . $topic . '.0');
1413 1476
 
1414 1477
 	// No need!
1415 1478
 	$context['robot_no_index'] = true;
@@ -1421,8 +1484,9 @@  discard block
 block discarded – undo
1421 1484
 	$post_errors = array();
1422 1485
 
1423 1486
 	// If the session has timed out, let the user re-submit their form.
1424
-	if (checkSession('post', '', false) != '')
1425
-		$post_errors[] = 'session_timeout';
1487
+	if (checkSession('post', '', false) != '') {
1488
+			$post_errors[] = 'session_timeout';
1489
+	}
1426 1490
 
1427 1491
 	// Wrong verification code?
1428 1492
 	if (!$user_info['is_admin'] && !$user_info['is_mod'] && !empty($modSettings['posts_require_captcha']) && ($user_info['posts'] < $modSettings['posts_require_captcha'] || ($user_info['is_guest'] && $modSettings['posts_require_captcha'] == -1)))
@@ -1432,33 +1496,38 @@  discard block
 block discarded – undo
1432 1496
 			'id' => 'post',
1433 1497
 		);
1434 1498
 		$context['require_verification'] = create_control_verification($verificationOptions, true);
1435
-		if (is_array($context['require_verification']))
1436
-			$post_errors = array_merge($post_errors, $context['require_verification']);
1499
+		if (is_array($context['require_verification'])) {
1500
+					$post_errors = array_merge($post_errors, $context['require_verification']);
1501
+		}
1437 1502
 	}
1438 1503
 
1439 1504
 	require_once($sourcedir . '/Subs-Post.php');
1440 1505
 	loadLanguage('Post');
1441 1506
 
1442 1507
 	// Drafts enabled and needed?
1443
-	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft'])))
1444
-		require_once($sourcedir . '/Drafts.php');
1508
+	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft']))) {
1509
+			require_once($sourcedir . '/Drafts.php');
1510
+	}
1445 1511
 
1446 1512
 	// First check to see if they are trying to delete any current attachments.
1447 1513
 	if (isset($_POST['attach_del']))
1448 1514
 	{
1449 1515
 		$keep_temp = array();
1450 1516
 		$keep_ids = array();
1451
-		foreach ($_POST['attach_del'] as $dummy)
1452
-			if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1517
+		foreach ($_POST['attach_del'] as $dummy) {
1518
+					if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1453 1519
 				$keep_temp[] = $dummy;
1454
-			else
1455
-				$keep_ids[] = (int) $dummy;
1520
+		}
1521
+			else {
1522
+							$keep_ids[] = (int) $dummy;
1523
+			}
1456 1524
 
1457
-		if (isset($_SESSION['temp_attachments']))
1458
-			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1525
+		if (isset($_SESSION['temp_attachments'])) {
1526
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1459 1527
 			{
1460 1528
 				if ((isset($_SESSION['temp_attachments']['post']['files'], $attachment['name']) && in_array($attachment['name'], $_SESSION['temp_attachments']['post']['files'])) || in_array($attachID, $keep_temp) || strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1461 1529
 					continue;
1530
+		}
1462 1531
 
1463 1532
 				unset($_SESSION['temp_attachments'][$attachID]);
1464 1533
 				unlink($attachment['tmp_name']);
@@ -1490,8 +1559,9 @@  discard block
 block discarded – undo
1490 1559
 	{
1491 1560
 		require_once($sourcedir . '/ManageAttachments.php');
1492 1561
 
1493
-		foreach ($_SESSION['already_attached'] as $attachID => $attachment)
1494
-			removeAttachments(array('id_attach' => $attachID));
1562
+		foreach ($_SESSION['already_attached'] as $attachID => $attachment) {
1563
+					removeAttachments(array('id_attach' => $attachID));
1564
+		}
1495 1565
 
1496 1566
 		unset($_SESSION['already_attached']);
1497 1567
 
@@ -1514,12 +1584,14 @@  discard block
 block discarded – undo
1514 1584
 		$smcFunc['db_free_result']($request);
1515 1585
 
1516 1586
 		// Though the topic should be there, it might have vanished.
1517
-		if (!is_array($topic_info))
1518
-			fatal_lang_error('topic_doesnt_exist', 404);
1587
+		if (!is_array($topic_info)) {
1588
+					fatal_lang_error('topic_doesnt_exist', 404);
1589
+		}
1519 1590
 
1520 1591
 		// Did this topic suddenly move? Just checking...
1521
-		if ($topic_info['id_board'] != $board)
1522
-			fatal_lang_error('not_a_topic');
1592
+		if ($topic_info['id_board'] != $board) {
1593
+					fatal_lang_error('not_a_topic');
1594
+		}
1523 1595
 
1524 1596
 		// Do the permissions and approval stuff...
1525 1597
 		$becomesApproved = true;
@@ -1542,49 +1614,50 @@  discard block
 block discarded – undo
1542 1614
 	if (!empty($topic) && !isset($_REQUEST['msg']))
1543 1615
 	{
1544 1616
 		// Don't allow a post if it's locked.
1545
-		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board'))
1546
-			fatal_lang_error('topic_locked', false);
1617
+		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board')) {
1618
+					fatal_lang_error('topic_locked', false);
1619
+		}
1547 1620
 
1548 1621
 		// Sorry, multiple polls aren't allowed... yet.  You should stop giving me ideas :P.
1549
-		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0)
1550
-			unset($_REQUEST['poll']);
1551
-
1552
-		elseif ($topic_info['id_member_started'] != $user_info['id'])
1553
-		{
1554
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
1555
-				$becomesApproved = false;
1556
-
1557
-			else
1558
-				isAllowedTo('post_reply_any');
1559
-		}
1560
-		elseif (!allowedTo('post_reply_any'))
1622
+		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0) {
1623
+					unset($_REQUEST['poll']);
1624
+		} elseif ($topic_info['id_member_started'] != $user_info['id'])
1625
+		{
1626
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
1627
+							$becomesApproved = false;
1628
+			} else {
1629
+							isAllowedTo('post_reply_any');
1630
+			}
1631
+		} elseif (!allowedTo('post_reply_any'))
1561 1632
 		{
1562
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own'))
1563
-				$becomesApproved = false;
1564
-
1565
-			else
1566
-				isAllowedTo('post_reply_own');
1633
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) {
1634
+							$becomesApproved = false;
1635
+			} else {
1636
+							isAllowedTo('post_reply_own');
1637
+			}
1567 1638
 		}
1568 1639
 
1569 1640
 		if (isset($_POST['lock']))
1570 1641
 		{
1571 1642
 			// Nothing is changed to the lock.
1572
-			if (empty($topic_info['locked']) == empty($_POST['lock']))
1573
-				unset($_POST['lock']);
1643
+			if (empty($topic_info['locked']) == empty($_POST['lock'])) {
1644
+							unset($_POST['lock']);
1645
+			}
1574 1646
 
1575 1647
 			// You're have no permission to lock this topic.
1576
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1577
-				unset($_POST['lock']);
1648
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1649
+							unset($_POST['lock']);
1650
+			}
1578 1651
 
1579 1652
 			// You are allowed to (un)lock your own topic only.
1580 1653
 			elseif (!allowedTo('lock_any'))
1581 1654
 			{
1582 1655
 				// You cannot override a moderator lock.
1583
-				if ($topic_info['locked'] == 1)
1584
-					unset($_POST['lock']);
1585
-
1586
-				else
1587
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1656
+				if ($topic_info['locked'] == 1) {
1657
+									unset($_POST['lock']);
1658
+				} else {
1659
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1660
+				}
1588 1661
 			}
1589 1662
 			// Hail mighty moderator, (un)lock this topic immediately.
1590 1663
 			else
@@ -1592,19 +1665,21 @@  discard block
 block discarded – undo
1592 1665
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1593 1666
 
1594 1667
 				// Did someone (un)lock this while you were posting?
1595
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1596
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1668
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1669
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1670
+				}
1597 1671
 			}
1598 1672
 		}
1599 1673
 
1600 1674
 		// So you wanna (un)sticky this...let's see.
1601
-		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky')))
1602
-			unset($_POST['sticky']);
1603
-		elseif (isset($_POST['sticky']))
1675
+		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky'))) {
1676
+					unset($_POST['sticky']);
1677
+		} elseif (isset($_POST['sticky']))
1604 1678
 		{
1605 1679
 			// Did someone (un)sticky this while you were posting?
1606
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1607
-				$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1680
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1681
+							$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1682
+			}
1608 1683
 		}
1609 1684
 
1610 1685
 		// If drafts are enabled, then pass this off
@@ -1631,26 +1706,31 @@  discard block
 block discarded – undo
1631 1706
 
1632 1707
 		// Do like, the permissions, for safety and stuff...
1633 1708
 		$becomesApproved = true;
1634
-		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics'))
1635
-			$becomesApproved = false;
1636
-		else
1637
-			isAllowedTo('post_new');
1709
+		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) {
1710
+					$becomesApproved = false;
1711
+		} else {
1712
+					isAllowedTo('post_new');
1713
+		}
1638 1714
 
1639 1715
 		if (isset($_POST['lock']))
1640 1716
 		{
1641 1717
 			// New topics are by default not locked.
1642
-			if (empty($_POST['lock']))
1643
-				unset($_POST['lock']);
1718
+			if (empty($_POST['lock'])) {
1719
+							unset($_POST['lock']);
1720
+			}
1644 1721
 			// Besides, you need permission.
1645
-			elseif (!allowedTo(array('lock_any', 'lock_own')))
1646
-				unset($_POST['lock']);
1722
+			elseif (!allowedTo(array('lock_any', 'lock_own'))) {
1723
+							unset($_POST['lock']);
1724
+			}
1647 1725
 			// A moderator-lock (1) can override a user-lock (2).
1648
-			else
1649
-				$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1726
+			else {
1727
+							$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1728
+			}
1650 1729
 		}
1651 1730
 
1652
-		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky')))
1653
-			unset($_POST['sticky']);
1731
+		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky'))) {
1732
+					unset($_POST['sticky']);
1733
+		}
1654 1734
 
1655 1735
 		// Saving your new topic as a draft first?
1656 1736
 		if (!empty($modSettings['drafts_post_enabled']) && isset($_POST['save_draft']))
@@ -1675,31 +1755,37 @@  discard block
 block discarded – undo
1675 1755
 				'id_msg' => $_REQUEST['msg'],
1676 1756
 			)
1677 1757
 		);
1678
-		if ($smcFunc['db_num_rows']($request) == 0)
1679
-			fatal_lang_error('cant_find_messages', false);
1758
+		if ($smcFunc['db_num_rows']($request) == 0) {
1759
+					fatal_lang_error('cant_find_messages', false);
1760
+		}
1680 1761
 		$row = $smcFunc['db_fetch_assoc']($request);
1681 1762
 		$smcFunc['db_free_result']($request);
1682 1763
 
1683
-		if (!empty($topic_info['locked']) && !allowedTo('moderate_board'))
1684
-			fatal_lang_error('topic_locked', false);
1764
+		if (!empty($topic_info['locked']) && !allowedTo('moderate_board')) {
1765
+					fatal_lang_error('topic_locked', false);
1766
+		}
1685 1767
 
1686 1768
 		if (isset($_POST['lock']))
1687 1769
 		{
1688 1770
 			// Nothing changes to the lock status.
1689
-			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked'])))
1690
-				unset($_POST['lock']);
1771
+			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) {
1772
+							unset($_POST['lock']);
1773
+			}
1691 1774
 			// You're simply not allowed to (un)lock this.
1692
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1693
-				unset($_POST['lock']);
1775
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1776
+							unset($_POST['lock']);
1777
+			}
1694 1778
 			// You're only allowed to lock your own topics.
1695 1779
 			elseif (!allowedTo('lock_any'))
1696 1780
 			{
1697 1781
 				// You're not allowed to break a moderator's lock.
1698
-				if ($topic_info['locked'] == 1)
1699
-					unset($_POST['lock']);
1782
+				if ($topic_info['locked'] == 1) {
1783
+									unset($_POST['lock']);
1784
+				}
1700 1785
 				// Lock it with a soft lock or unlock it.
1701
-				else
1702
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1786
+				else {
1787
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1788
+				}
1703 1789
 			}
1704 1790
 			// You must be the moderator.
1705 1791
 			else
@@ -1707,44 +1793,46 @@  discard block
 block discarded – undo
1707 1793
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1708 1794
 
1709 1795
 				// Did someone (un)lock this while you were posting?
1710
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1711
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1796
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1797
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1798
+				}
1712 1799
 			}
1713 1800
 		}
1714 1801
 
1715 1802
 		// Change the sticky status of this topic?
1716
-		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky']))
1717
-			unset($_POST['sticky']);
1718
-		elseif (isset($_POST['sticky']))
1803
+		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky'])) {
1804
+					unset($_POST['sticky']);
1805
+		} elseif (isset($_POST['sticky']))
1719 1806
 		{
1720 1807
 			// Did someone (un)sticky this while you were posting?
1721
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1722
-				$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1808
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1809
+							$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1810
+			}
1723 1811
 		}
1724 1812
 
1725 1813
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
1726 1814
 		{
1727
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
1728
-				fatal_lang_error('modify_post_time_passed', false);
1729
-			elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
1730
-				isAllowedTo('modify_replies');
1731
-			else
1732
-				isAllowedTo('modify_own');
1733
-		}
1734
-		elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1815
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
1816
+							fatal_lang_error('modify_post_time_passed', false);
1817
+			} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
1818
+							isAllowedTo('modify_replies');
1819
+			} else {
1820
+							isAllowedTo('modify_own');
1821
+			}
1822
+		} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1735 1823
 		{
1736 1824
 			isAllowedTo('modify_replies');
1737 1825
 
1738 1826
 			// If you're modifying a reply, I say it better be logged...
1739 1827
 			$moderationAction = true;
1740
-		}
1741
-		else
1828
+		} else
1742 1829
 		{
1743 1830
 			isAllowedTo('modify_any');
1744 1831
 
1745 1832
 			// Log it, assuming you're not modifying your own post.
1746
-			if ($row['id_member'] != $user_info['id'])
1747
-				$moderationAction = true;
1833
+			if ($row['id_member'] != $user_info['id']) {
1834
+							$moderationAction = true;
1835
+			}
1748 1836
 		}
1749 1837
 
1750 1838
 		// If drafts are enabled, then lets send this off to save
@@ -1783,20 +1871,24 @@  discard block
 block discarded – undo
1783 1871
 		$_POST['guestname'] = !isset($_POST['guestname']) ? '' : trim($_POST['guestname']);
1784 1872
 		$_POST['email'] = !isset($_POST['email']) ? '' : trim($_POST['email']);
1785 1873
 
1786
-		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_')
1787
-			$post_errors[] = 'no_name';
1788
-		if ($smcFunc['strlen']($_POST['guestname']) > 25)
1789
-			$post_errors[] = 'long_name';
1874
+		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_') {
1875
+					$post_errors[] = 'no_name';
1876
+		}
1877
+		if ($smcFunc['strlen']($_POST['guestname']) > 25) {
1878
+					$post_errors[] = 'long_name';
1879
+		}
1790 1880
 
1791 1881
 		if (empty($modSettings['guest_post_no_email']))
1792 1882
 		{
1793 1883
 			// Only check if they changed it!
1794 1884
 			if (!isset($row) || $row['poster_email'] != $_POST['email'])
1795 1885
 			{
1796
-				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == ''))
1797
-					$post_errors[] = 'no_email';
1798
-				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL))
1799
-					$post_errors[] = 'bad_email';
1886
+				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == '')) {
1887
+									$post_errors[] = 'no_email';
1888
+				}
1889
+				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) {
1890
+									$post_errors[] = 'bad_email';
1891
+				}
1800 1892
 			}
1801 1893
 
1802 1894
 			// Now make sure this email address is not banned from posting.
@@ -1812,81 +1904,95 @@  discard block
 block discarded – undo
1812 1904
 	}
1813 1905
 
1814 1906
 	// Coming from the quickReply?
1815
-	if (isset($_POST['quickReply']))
1816
-		$_POST['message'] = $_POST['quickReply'];
1907
+	if (isset($_POST['quickReply'])) {
1908
+			$_POST['message'] = $_POST['quickReply'];
1909
+	}
1817 1910
 
1818 1911
 	// Check the subject and message.
1819
-	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '')
1820
-		$post_errors[] = 'no_subject';
1821
-	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '')
1822
-		$post_errors[] = 'no_message';
1823
-	elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
1824
-		$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1825
-	else
1912
+	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '') {
1913
+			$post_errors[] = 'no_subject';
1914
+	}
1915
+	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '') {
1916
+			$post_errors[] = 'no_message';
1917
+	} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) {
1918
+			$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1919
+	} else
1826 1920
 	{
1827 1921
 		// Prepare the message a bit for some additional testing.
1828 1922
 		$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
1829 1923
 
1830 1924
 		// Preparse code. (Zef)
1831
-		if ($user_info['is_guest'])
1832
-			$user_info['name'] = $_POST['guestname'];
1925
+		if ($user_info['is_guest']) {
1926
+					$user_info['name'] = $_POST['guestname'];
1927
+		}
1833 1928
 		preparsecode($_POST['message']);
1834 1929
 
1835 1930
 		// Youtube BBC would be stripped out in the next check without this
1836 1931
 		$context['allowed_html_tags'][] = '<iframe>';
1837 1932
 
1838 1933
 		// Let's see if there's still some content left without the tags.
1839
-		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false))
1840
-			$post_errors[] = 'no_message';
1934
+		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false)) {
1935
+					$post_errors[] = 'no_message';
1936
+		}
1841 1937
 
1842 1938
 		// Remove iframe from the list
1843 1939
 		array_pop($context['allowed_html_tags']);
1844 1940
 	}
1845
-	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '')
1846
-		$post_errors[] = 'no_event';
1941
+	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '') {
1942
+			$post_errors[] = 'no_event';
1943
+	}
1847 1944
 	// You are not!
1848
-	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin'])
1849
-		fatal_error('Knave! Masquerader! Charlatan!', false);
1945
+	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin']) {
1946
+			fatal_error('Knave! Masquerader! Charlatan!', false);
1947
+	}
1850 1948
 
1851 1949
 	// Validate the poll...
1852 1950
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
1853 1951
 	{
1854
-		if (!empty($topic) && !isset($_REQUEST['msg']))
1855
-			fatal_lang_error('no_access', false);
1952
+		if (!empty($topic) && !isset($_REQUEST['msg'])) {
1953
+					fatal_lang_error('no_access', false);
1954
+		}
1856 1955
 
1857 1956
 		// This is a new topic... so it's a new poll.
1858
-		if (empty($topic))
1859
-			isAllowedTo('poll_post');
1957
+		if (empty($topic)) {
1958
+					isAllowedTo('poll_post');
1959
+		}
1860 1960
 		// Can you add to your own topics?
1861
-		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any'))
1862
-			isAllowedTo('poll_add_own');
1961
+		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any')) {
1962
+					isAllowedTo('poll_add_own');
1963
+		}
1863 1964
 		// Can you add polls to any topic, then?
1864
-		else
1865
-			isAllowedTo('poll_add_any');
1965
+		else {
1966
+					isAllowedTo('poll_add_any');
1967
+		}
1866 1968
 
1867
-		if (!isset($_POST['question']) || trim($_POST['question']) == '')
1868
-			$post_errors[] = 'no_question';
1969
+		if (!isset($_POST['question']) || trim($_POST['question']) == '') {
1970
+					$post_errors[] = 'no_question';
1971
+		}
1869 1972
 
1870 1973
 		$_POST['options'] = empty($_POST['options']) ? array() : htmltrim__recursive($_POST['options']);
1871 1974
 
1872 1975
 		// Get rid of empty ones.
1873
-		foreach ($_POST['options'] as $k => $option)
1874
-			if ($option == '')
1976
+		foreach ($_POST['options'] as $k => $option) {
1977
+					if ($option == '')
1875 1978
 				unset($_POST['options'][$k], $_POST['options'][$k]);
1979
+		}
1876 1980
 
1877 1981
 		// What are you going to vote between with one choice?!?
1878
-		if (count($_POST['options']) < 2)
1879
-			$post_errors[] = 'poll_few';
1880
-		elseif (count($_POST['options']) > 256)
1881
-			$post_errors[] = 'poll_many';
1982
+		if (count($_POST['options']) < 2) {
1983
+					$post_errors[] = 'poll_few';
1984
+		} elseif (count($_POST['options']) > 256) {
1985
+					$post_errors[] = 'poll_many';
1986
+		}
1882 1987
 	}
1883 1988
 
1884 1989
 	if ($posterIsGuest)
1885 1990
 	{
1886 1991
 		// If user is a guest, make sure the chosen name isn't taken.
1887 1992
 		require_once($sourcedir . '/Subs-Members.php');
1888
-		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name']))
1889
-			$post_errors[] = 'bad_name';
1993
+		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name'])) {
1994
+					$post_errors[] = 'bad_name';
1995
+		}
1890 1996
 	}
1891 1997
 	// If the user isn't a guest, get his or her name and email.
1892 1998
 	elseif (!isset($_REQUEST['msg']))
@@ -1917,8 +2023,9 @@  discard block
 block discarded – undo
1917 2023
 	}
1918 2024
 
1919 2025
 	// Make sure the user isn't spamming the board.
1920
-	if (!isset($_REQUEST['msg']))
1921
-		spamProtection('post');
2026
+	if (!isset($_REQUEST['msg'])) {
2027
+			spamProtection('post');
2028
+	}
1922 2029
 
1923 2030
 	// At about this point, we're posting and that's that.
1924 2031
 	ignore_user_abort(true);
@@ -1931,32 +2038,36 @@  discard block
 block discarded – undo
1931 2038
 	$_POST['modify_reason'] = empty($_POST['modify_reason']) ? '' : strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
1932 2039
 
1933 2040
 	// At this point, we want to make sure the subject isn't too long.
1934
-	if ($smcFunc['strlen']($_POST['subject']) > 100)
1935
-		$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2041
+	if ($smcFunc['strlen']($_POST['subject']) > 100) {
2042
+			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2043
+	}
1936 2044
 
1937 2045
 	// Same with the "why did you edit this" text.
1938
-	if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
1939
-		$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2046
+	if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
2047
+			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2048
+	}
1940 2049
 
1941 2050
 	// Make the poll...
1942 2051
 	if (isset($_REQUEST['poll']))
1943 2052
 	{
1944 2053
 		// Make sure that the user has not entered a ridiculous number of options..
1945
-		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0)
1946
-			$_POST['poll_max_votes'] = 1;
1947
-		elseif ($_POST['poll_max_votes'] > count($_POST['options']))
1948
-			$_POST['poll_max_votes'] = count($_POST['options']);
1949
-		else
1950
-			$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
2054
+		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0) {
2055
+					$_POST['poll_max_votes'] = 1;
2056
+		} elseif ($_POST['poll_max_votes'] > count($_POST['options'])) {
2057
+					$_POST['poll_max_votes'] = count($_POST['options']);
2058
+		} else {
2059
+					$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
2060
+		}
1951 2061
 
1952 2062
 		$_POST['poll_expire'] = (int) $_POST['poll_expire'];
1953 2063
 		$_POST['poll_expire'] = $_POST['poll_expire'] > 9999 ? 9999 : ($_POST['poll_expire'] < 0 ? 0 : $_POST['poll_expire']);
1954 2064
 
1955 2065
 		// Just set it to zero if it's not there..
1956
-		if (!isset($_POST['poll_hide']))
1957
-			$_POST['poll_hide'] = 0;
1958
-		else
1959
-			$_POST['poll_hide'] = (int) $_POST['poll_hide'];
2066
+		if (!isset($_POST['poll_hide'])) {
2067
+					$_POST['poll_hide'] = 0;
2068
+		} else {
2069
+					$_POST['poll_hide'] = (int) $_POST['poll_hide'];
2070
+		}
1960 2071
 		$_POST['poll_change_vote'] = isset($_POST['poll_change_vote']) ? 1 : 0;
1961 2072
 
1962 2073
 		$_POST['poll_guest_vote'] = isset($_POST['poll_guest_vote']) ? 1 : 0;
@@ -1965,16 +2076,19 @@  discard block
 block discarded – undo
1965 2076
 		{
1966 2077
 			require_once($sourcedir . '/Subs-Members.php');
1967 2078
 			$allowedVoteGroups = groupsAllowedTo('poll_vote', $board);
1968
-			if (!in_array(-1, $allowedVoteGroups['allowed']))
1969
-				$_POST['poll_guest_vote'] = 0;
2079
+			if (!in_array(-1, $allowedVoteGroups['allowed'])) {
2080
+							$_POST['poll_guest_vote'] = 0;
2081
+			}
1970 2082
 		}
1971 2083
 
1972 2084
 		// If the user tries to set the poll too far in advance, don't let them.
1973
-		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1)
1974
-			fatal_lang_error('poll_range_error', false);
2085
+		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1) {
2086
+					fatal_lang_error('poll_range_error', false);
2087
+		}
1975 2088
 		// Don't allow them to select option 2 for hidden results if it's not time limited.
1976
-		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2)
1977
-			$_POST['poll_hide'] = 1;
2089
+		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2) {
2090
+					$_POST['poll_hide'] = 1;
2091
+		}
1978 2092
 
1979 2093
 		// Clean up the question and answers.
1980 2094
 		$_POST['question'] = $smcFunc['htmlspecialchars']($_POST['question']);
@@ -1988,13 +2102,15 @@  discard block
 block discarded – undo
1988 2102
 	{
1989 2103
 		$attachIDs = array();
1990 2104
 		$attach_errors = array();
1991
-		if (!empty($context['we_are_history']))
1992
-			$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2105
+		if (!empty($context['we_are_history'])) {
2106
+					$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2107
+		}
1993 2108
 
1994 2109
 		foreach ($_SESSION['temp_attachments'] as  $attachID => $attachment)
1995 2110
 		{
1996
-			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1997
-				continue;
2111
+			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
2112
+							continue;
2113
+			}
1998 2114
 
1999 2115
 			// If there was an initial error just show that message.
2000 2116
 			if ($attachID == 'initial_error')
@@ -2023,12 +2139,13 @@  discard block
 block discarded – undo
2023 2139
 				if (createAttachment($attachmentOptions))
2024 2140
 				{
2025 2141
 					$attachIDs[] = $attachmentOptions['id'];
2026
-					if (!empty($attachmentOptions['thumb']))
2027
-						$attachIDs[] = $attachmentOptions['thumb'];
2142
+					if (!empty($attachmentOptions['thumb'])) {
2143
+											$attachIDs[] = $attachmentOptions['thumb'];
2144
+					}
2028 2145
 				}
2146
+			} else {
2147
+							$attach_errors[] = '<dt>&nbsp;</dt>';
2029 2148
 			}
2030
-			else
2031
-				$attach_errors[] = '<dt>&nbsp;</dt>';
2032 2149
 
2033 2150
 			if (!empty($attachmentOptions['errors']))
2034 2151
 			{
@@ -2040,14 +2157,16 @@  discard block
 block discarded – undo
2040 2157
 					if (!is_array($error))
2041 2158
 					{
2042 2159
 						$attach_errors[] = '<dd>' . $txt[$error] . '</dd>';
2043
-						if (in_array($error, $log_these))
2044
-							log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2160
+						if (in_array($error, $log_these)) {
2161
+													log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2162
+						}
2163
+					} else {
2164
+											$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
2045 2165
 					}
2046
-					else
2047
-						$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
2048 2166
 				}
2049
-				if (file_exists($attachment['tmp_name']))
2050
-					unlink($attachment['tmp_name']);
2167
+				if (file_exists($attachment['tmp_name'])) {
2168
+									unlink($attachment['tmp_name']);
2169
+				}
2051 2170
 			}
2052 2171
 		}
2053 2172
 		unset($_SESSION['temp_attachments']);
@@ -2088,24 +2207,24 @@  discard block
 block discarded – undo
2088 2207
 		);
2089 2208
 
2090 2209
 		call_integration_hook('integrate_poll_add_edit', array($id_poll, false));
2210
+	} else {
2211
+			$id_poll = 0;
2091 2212
 	}
2092
-	else
2093
-		$id_poll = 0;
2094 2213
 
2095 2214
 	// Creating a new topic?
2096 2215
 	$newTopic = empty($_REQUEST['msg']) && empty($topic);
2097 2216
 
2098 2217
 	// Check the icon.
2099
-	if (!isset($_POST['icon']))
2100
-		$_POST['icon'] = 'xx';
2101
-
2102
-	else
2218
+	if (!isset($_POST['icon'])) {
2219
+			$_POST['icon'] = 'xx';
2220
+	} else
2103 2221
 	{
2104 2222
 		$_POST['icon'] = $smcFunc['htmlspecialchars']($_POST['icon']);
2105 2223
 
2106 2224
 		// Need to figure it out if this is a valid icon name.
2107
-		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')))
2108
-			$_POST['icon'] = 'xx';
2225
+		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png'))) {
2226
+					$_POST['icon'] = 'xx';
2227
+		}
2109 2228
 	}
2110 2229
 
2111 2230
 	// Collect all parameters for the creation or modification of a post.
@@ -2146,8 +2265,9 @@  discard block
 block discarded – undo
2146 2265
 		}
2147 2266
 
2148 2267
 		// This will save some time...
2149
-		if (empty($approve_has_changed))
2150
-			unset($msgOptions['approved']);
2268
+		if (empty($approve_has_changed)) {
2269
+					unset($msgOptions['approved']);
2270
+		}
2151 2271
 
2152 2272
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2153 2273
 	}
@@ -2156,8 +2276,9 @@  discard block
 block discarded – undo
2156 2276
 	{
2157 2277
 		createPost($msgOptions, $topicOptions, $posterOptions);
2158 2278
 
2159
-		if (isset($topicOptions['id']))
2160
-			$topic = $topicOptions['id'];
2279
+		if (isset($topicOptions['id'])) {
2280
+					$topic = $topicOptions['id'];
2281
+		}
2161 2282
 	}
2162 2283
 
2163 2284
 	// Are there attachments already uploaded and waiting to be assigned?
@@ -2169,8 +2290,9 @@  discard block
 block discarded – undo
2169 2290
 	}
2170 2291
 
2171 2292
 	// If we had a draft for this, its time to remove it since it was just posted
2172
-	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft']))
2173
-		DeleteDraft($_POST['id_draft']);
2293
+	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft'])) {
2294
+			DeleteDraft($_POST['id_draft']);
2295
+	}
2174 2296
 
2175 2297
 	// Editing or posting an event?
2176 2298
 	if (isset($_POST['calendar']) && (!isset($_REQUEST['eventid']) || $_REQUEST['eventid'] == -1))
@@ -2189,8 +2311,7 @@  discard block
 block discarded – undo
2189 2311
 			'member' => $user_info['id'],
2190 2312
 		);
2191 2313
 		insertEvent($eventOptions);
2192
-	}
2193
-	elseif (isset($_POST['calendar']))
2314
+	} elseif (isset($_POST['calendar']))
2194 2315
 	{
2195 2316
 		$_REQUEST['eventid'] = (int) $_REQUEST['eventid'];
2196 2317
 
@@ -2218,14 +2339,15 @@  discard block
 block discarded – undo
2218 2339
 		}
2219 2340
 
2220 2341
 		// Delete it?
2221
-		if (isset($_REQUEST['deleteevent']))
2222
-			$smcFunc['db_query']('', '
2342
+		if (isset($_REQUEST['deleteevent'])) {
2343
+					$smcFunc['db_query']('', '
2223 2344
 				DELETE FROM {db_prefix}calendar
2224 2345
 				WHERE id_event = {int:id_event}',
2225 2346
 				array(
2226 2347
 					'id_event' => $_REQUEST['eventid'],
2227 2348
 				)
2228 2349
 			);
2350
+		}
2229 2351
 		// ... or just update it?
2230 2352
 		else
2231 2353
 		{
@@ -2267,9 +2389,8 @@  discard block
 block discarded – undo
2267 2389
 			array($user_info['id'], $topic, 0),
2268 2390
 			array('id_member', 'id_topic', 'id_board')
2269 2391
 		);
2270
-	}
2271
-	elseif (!$newTopic)
2272
-		$smcFunc['db_query']('', '
2392
+	} elseif (!$newTopic) {
2393
+			$smcFunc['db_query']('', '
2273 2394
 			DELETE FROM {db_prefix}log_notify
2274 2395
 			WHERE id_member = {int:current_member}
2275 2396
 				AND id_topic = {int:current_topic}',
@@ -2278,16 +2399,20 @@  discard block
 block discarded – undo
2278 2399
 				'current_topic' => $topic,
2279 2400
 			)
2280 2401
 		);
2402
+	}
2281 2403
 
2282 2404
 	// Log an act of moderation - modifying.
2283
-	if (!empty($moderationAction))
2284
-		logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2405
+	if (!empty($moderationAction)) {
2406
+			logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2407
+	}
2285 2408
 
2286
-	if (isset($_POST['lock']) && $_POST['lock'] != 2)
2287
-		logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2409
+	if (isset($_POST['lock']) && $_POST['lock'] != 2) {
2410
+			logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2411
+	}
2288 2412
 
2289
-	if (isset($_POST['sticky']))
2290
-		logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2413
+	if (isset($_POST['sticky'])) {
2414
+			logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2415
+	}
2291 2416
 
2292 2417
 	// Returning to the topic?
2293 2418
 	if (!empty($_REQUEST['goback']))
@@ -2306,26 +2431,31 @@  discard block
 block discarded – undo
2306 2431
 		);
2307 2432
 	}
2308 2433
 
2309
-	if ($board_info['num_topics'] == 0)
2310
-		cache_put_data('board-' . $board, null, 120);
2434
+	if ($board_info['num_topics'] == 0) {
2435
+			cache_put_data('board-' . $board, null, 120);
2436
+	}
2311 2437
 
2312 2438
 	call_integration_hook('integrate_post2_end');
2313 2439
 
2314
-	if (!empty($_POST['announce_topic']) && allowedTo('announce_topic'))
2315
-		redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2440
+	if (!empty($_POST['announce_topic']) && allowedTo('announce_topic')) {
2441
+			redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2442
+	}
2316 2443
 
2317
-	if (!empty($_POST['move']) && allowedTo('move_any'))
2318
-		redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2444
+	if (!empty($_POST['move']) && allowedTo('move_any')) {
2445
+			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2446
+	}
2319 2447
 
2320 2448
 	// Return to post if the mod is on.
2321
-	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback']))
2322
-		redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2323
-	elseif (!empty($_REQUEST['goback']))
2324
-		redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2449
+	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback'])) {
2450
+			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2451
+	} elseif (!empty($_REQUEST['goback'])) {
2452
+			redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2453
+	}
2325 2454
 	// Dut-dut-duh-duh-DUH-duh-dut-duh-duh!  *dances to the Final Fantasy Fanfare...*
2326
-	else
2327
-		redirectexit('board=' . $board . '.0');
2328
-}
2455
+	else {
2456
+			redirectexit('board=' . $board . '.0');
2457
+	}
2458
+	}
2329 2459
 
2330 2460
 /**
2331 2461
  * Handle the announce topic function (action=announce).
@@ -2343,8 +2473,9 @@  discard block
 block discarded – undo
2343 2473
 
2344 2474
 	validateSession();
2345 2475
 
2346
-	if (empty($topic))
2347
-		fatal_lang_error('topic_gone', false);
2476
+	if (empty($topic)) {
2477
+			fatal_lang_error('topic_gone', false);
2478
+	}
2348 2479
 
2349 2480
 	loadLanguage('Post');
2350 2481
 	loadTemplate('Post');
@@ -2371,8 +2502,9 @@  discard block
 block discarded – undo
2371 2502
 	global $txt, $context, $topic, $board_info, $smcFunc;
2372 2503
 
2373 2504
 	$groups = array_merge($board_info['groups'], array(1));
2374
-	foreach ($groups as $id => $group)
2375
-		$groups[$id] = (int) $group;
2505
+	foreach ($groups as $id => $group) {
2506
+			$groups[$id] = (int) $group;
2507
+	}
2376 2508
 
2377 2509
 	$context['groups'] = array();
2378 2510
 	if (in_array(0, $groups))
@@ -2415,8 +2547,9 @@  discard block
 block discarded – undo
2415 2547
 			'group_list' => $groups,
2416 2548
 		)
2417 2549
 	);
2418
-	while ($row = $smcFunc['db_fetch_assoc']($request))
2419
-		$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2550
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2551
+			$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2552
+	}
2420 2553
 	$smcFunc['db_free_result']($request);
2421 2554
 
2422 2555
 	// Get the subject of the topic we're about to announce.
@@ -2458,16 +2591,19 @@  discard block
 block discarded – undo
2458 2591
 	$context['start'] = empty($_REQUEST['start']) ? 0 : (int) $_REQUEST['start'];
2459 2592
 	$groups = array_merge($board_info['groups'], array(1));
2460 2593
 
2461
-	if (isset($_POST['membergroups']))
2462
-		$_POST['who'] = explode(',', $_POST['membergroups']);
2594
+	if (isset($_POST['membergroups'])) {
2595
+			$_POST['who'] = explode(',', $_POST['membergroups']);
2596
+	}
2463 2597
 
2464 2598
 	// Check whether at least one membergroup was selected.
2465
-	if (empty($_POST['who']))
2466
-		fatal_lang_error('no_membergroup_selected');
2599
+	if (empty($_POST['who'])) {
2600
+			fatal_lang_error('no_membergroup_selected');
2601
+	}
2467 2602
 
2468 2603
 	// Make sure all membergroups are integers and can access the board of the announcement.
2469
-	foreach ($_POST['who'] as $id => $mg)
2470
-		$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2604
+	foreach ($_POST['who'] as $id => $mg) {
2605
+			$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2606
+	}
2471 2607
 
2472 2608
 	// Get the topic subject and censor it.
2473 2609
 	$request = $smcFunc['db_query']('', '
@@ -2513,12 +2649,13 @@  discard block
 block discarded – undo
2513 2649
 	if ($smcFunc['db_num_rows']($request) == 0)
2514 2650
 	{
2515 2651
 		logAction('announce_topic', array('topic' => $topic), 'user');
2516
-		if (!empty($_REQUEST['move']) && allowedTo('move_any'))
2517
-			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2518
-		elseif (!empty($_REQUEST['goback']))
2519
-			redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2520
-		else
2521
-			redirectexit('board=' . $board . '.0');
2652
+		if (!empty($_REQUEST['move']) && allowedTo('move_any')) {
2653
+					redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2654
+		} elseif (!empty($_REQUEST['goback'])) {
2655
+					redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2656
+		} else {
2657
+					redirectexit('board=' . $board . '.0');
2658
+		}
2522 2659
 	}
2523 2660
 
2524 2661
 	$announcements = array();
@@ -2537,8 +2674,9 @@  discard block
 block discarded – undo
2537 2674
 	foreach ($rows as $row)
2538 2675
 	{
2539 2676
 		// Force them to have it?
2540
-		if (empty($prefs[$row['id_member']]['announcements']))
2541
-			continue;
2677
+		if (empty($prefs[$row['id_member']]['announcements'])) {
2678
+					continue;
2679
+		}
2542 2680
 
2543 2681
 		$cur_language = empty($row['lngfile']) || empty($modSettings['userLanguage']) ? $language : $row['lngfile'];
2544 2682
 
@@ -2566,8 +2704,9 @@  discard block
 block discarded – undo
2566 2704
 	}
2567 2705
 
2568 2706
 	// For each language send a different mail - low priority...
2569
-	foreach ($announcements as $lang => $mail)
2570
-		sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2707
+	foreach ($announcements as $lang => $mail) {
2708
+			sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2709
+	}
2571 2710
 
2572 2711
 	$context['percentage_done'] = round(100 * $context['start'] / $modSettings['latestMember'], 1);
2573 2712
 
@@ -2577,9 +2716,10 @@  discard block
 block discarded – undo
2577 2716
 	$context['sub_template'] = 'announcement_send';
2578 2717
 
2579 2718
 	// Go back to the correct language for the user ;).
2580
-	if (!empty($modSettings['userLanguage']))
2581
-		loadLanguage('Post');
2582
-}
2719
+	if (!empty($modSettings['userLanguage'])) {
2720
+			loadLanguage('Post');
2721
+	}
2722
+	}
2583 2723
 
2584 2724
 /**
2585 2725
  * Get the topic for display purposes.
@@ -2592,12 +2732,13 @@  discard block
 block discarded – undo
2592 2732
 {
2593 2733
 	global $topic, $modSettings, $context, $smcFunc, $counter, $options;
2594 2734
 
2595
-	if (isset($_REQUEST['xml']))
2596
-		$limit = '
2735
+	if (isset($_REQUEST['xml'])) {
2736
+			$limit = '
2597 2737
 		LIMIT ' . (empty($context['new_replies']) ? '0' : $context['new_replies']);
2598
-	else
2599
-		$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2738
+	} else {
2739
+			$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2600 2740
 		LIMIT ' . (int) $modSettings['topicSummaryPosts'];
2741
+	}
2601 2742
 
2602 2743
 	// If you're modifying, get only those posts before the current one. (otherwise get all.)
2603 2744
 	$request = $smcFunc['db_query']('', '
@@ -2635,8 +2776,9 @@  discard block
 block discarded – undo
2635 2776
 			'is_ignored' => !empty($modSettings['enable_buddylist']) && !empty($options['posts_apply_ignore_list']) && in_array($row['id_member'], $context['user']['ignoreusers']),
2636 2777
 		);
2637 2778
 
2638
-		if (!empty($context['new_replies']))
2639
-			$context['new_replies']--;
2779
+		if (!empty($context['new_replies'])) {
2780
+					$context['new_replies']--;
2781
+		}
2640 2782
 	}
2641 2783
 	$smcFunc['db_free_result']($request);
2642 2784
 }
@@ -2653,8 +2795,9 @@  discard block
 block discarded – undo
2653 2795
 	global $sourcedir, $smcFunc;
2654 2796
 
2655 2797
 	loadLanguage('Post');
2656
-	if (!isset($_REQUEST['xml']))
2657
-		loadTemplate('Post');
2798
+	if (!isset($_REQUEST['xml'])) {
2799
+			loadTemplate('Post');
2800
+	}
2658 2801
 
2659 2802
 	include_once($sourcedir . '/Subs-Post.php');
2660 2803
 
@@ -2685,8 +2828,9 @@  discard block
 block discarded – undo
2685 2828
 	$smcFunc['db_free_result']($request);
2686 2829
 
2687 2830
 	$context['sub_template'] = 'quotefast';
2688
-	if (!empty($row))
2689
-		$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2831
+	if (!empty($row)) {
2832
+			$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2833
+	}
2690 2834
 
2691 2835
 	if (!empty($can_view_post))
2692 2836
 	{
@@ -2719,8 +2863,9 @@  discard block
 block discarded – undo
2719 2863
 		}
2720 2864
 
2721 2865
 		// Remove any nested quotes.
2722
-		if (!empty($modSettings['removeNestedQuotes']))
2723
-			$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2866
+		if (!empty($modSettings['removeNestedQuotes'])) {
2867
+					$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2868
+		}
2724 2869
 
2725 2870
 		$lb = "\n";
2726 2871
 
@@ -2746,14 +2891,14 @@  discard block
 block discarded – undo
2746 2891
 				'time' => '',
2747 2892
 			),
2748 2893
 		);
2749
-	}
2750
-	else
2751
-		$context['quote'] = array(
2894
+	} else {
2895
+			$context['quote'] = array(
2752 2896
 			'xml' => '',
2753 2897
 			'mozilla' => '',
2754 2898
 			'text' => '',
2755 2899
 		);
2756
-}
2900
+	}
2901
+	}
2757 2902
 
2758 2903
 /**
2759 2904
  * Used to edit the body or subject of a message inline
@@ -2765,8 +2910,9 @@  discard block
 block discarded – undo
2765 2910
 	global $user_info, $context, $smcFunc, $language, $board_info;
2766 2911
 
2767 2912
 	// We have to have a topic!
2768
-	if (empty($topic))
2769
-		obExit(false);
2913
+	if (empty($topic)) {
2914
+			obExit(false);
2915
+	}
2770 2916
 
2771 2917
 	checkSession('get');
2772 2918
 	require_once($sourcedir . '/Subs-Post.php');
@@ -2792,31 +2938,35 @@  discard block
 block discarded – undo
2792 2938
 			'guest_id' => 0,
2793 2939
 		)
2794 2940
 	);
2795
-	if ($smcFunc['db_num_rows']($request) == 0)
2796
-		fatal_lang_error('no_board', false);
2941
+	if ($smcFunc['db_num_rows']($request) == 0) {
2942
+			fatal_lang_error('no_board', false);
2943
+	}
2797 2944
 	$row = $smcFunc['db_fetch_assoc']($request);
2798 2945
 	$smcFunc['db_free_result']($request);
2799 2946
 
2800 2947
 	// Change either body or subject requires permissions to modify messages.
2801 2948
 	if (isset($_POST['message']) || isset($_POST['subject']) || isset($_REQUEST['icon']))
2802 2949
 	{
2803
-		if (!empty($row['locked']))
2804
-			isAllowedTo('moderate_board');
2950
+		if (!empty($row['locked'])) {
2951
+					isAllowedTo('moderate_board');
2952
+		}
2805 2953
 
2806 2954
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
2807 2955
 		{
2808
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
2809
-				fatal_lang_error('modify_post_time_passed', false);
2810
-			elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
2811
-				isAllowedTo('modify_replies');
2812
-			else
2813
-				isAllowedTo('modify_own');
2956
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
2957
+							fatal_lang_error('modify_post_time_passed', false);
2958
+			} elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
2959
+							isAllowedTo('modify_replies');
2960
+			} else {
2961
+							isAllowedTo('modify_own');
2962
+			}
2814 2963
 		}
2815 2964
 		// Otherwise, they're locked out; someone who can modify the replies is needed.
2816
-		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
2817
-			isAllowedTo('modify_replies');
2818
-		else
2819
-			isAllowedTo('modify_any');
2965
+		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) {
2966
+					isAllowedTo('modify_replies');
2967
+		} else {
2968
+					isAllowedTo('modify_any');
2969
+		}
2820 2970
 
2821 2971
 		// Only log this action if it wasn't your message.
2822 2972
 		$moderationAction = $row['id_member'] != $user_info['id'];
@@ -2828,10 +2978,10 @@  discard block
 block discarded – undo
2828 2978
 		$_POST['subject'] = strtr($smcFunc['htmlspecialchars']($_POST['subject']), array("\r" => '', "\n" => '', "\t" => ''));
2829 2979
 
2830 2980
 		// Maximum number of characters.
2831
-		if ($smcFunc['strlen']($_POST['subject']) > 100)
2832
-			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2833
-	}
2834
-	elseif (isset($_POST['subject']))
2981
+		if ($smcFunc['strlen']($_POST['subject']) > 100) {
2982
+					$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2983
+		}
2984
+	} elseif (isset($_POST['subject']))
2835 2985
 	{
2836 2986
 		$post_errors[] = 'no_subject';
2837 2987
 		unset($_POST['subject']);
@@ -2843,13 +2993,11 @@  discard block
 block discarded – undo
2843 2993
 		{
2844 2994
 			$post_errors[] = 'no_message';
2845 2995
 			unset($_POST['message']);
2846
-		}
2847
-		elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2996
+		} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2848 2997
 		{
2849 2998
 			$post_errors[] = 'long_message';
2850 2999
 			unset($_POST['message']);
2851
-		}
2852
-		else
3000
+		} else
2853 3001
 		{
2854 3002
 			$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
2855 3003
 
@@ -2865,31 +3013,34 @@  discard block
 block discarded – undo
2865 3013
 
2866 3014
 	if (isset($_POST['lock']))
2867 3015
 	{
2868
-		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member']))
2869
-			unset($_POST['lock']);
2870
-		elseif (!allowedTo('lock_any'))
3016
+		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member'])) {
3017
+					unset($_POST['lock']);
3018
+		} elseif (!allowedTo('lock_any'))
2871 3019
 		{
2872
-			if ($row['locked'] == 1)
2873
-				unset($_POST['lock']);
2874
-			else
2875
-				$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
3020
+			if ($row['locked'] == 1) {
3021
+							unset($_POST['lock']);
3022
+			} else {
3023
+							$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
3024
+			}
3025
+		} elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked']) {
3026
+					unset($_POST['lock']);
3027
+		} else {
3028
+					$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2876 3029
 		}
2877
-		elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked'])
2878
-			unset($_POST['lock']);
2879
-		else
2880
-			$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2881 3030
 	}
2882 3031
 
2883
-	if (isset($_POST['sticky']) && !allowedTo('make_sticky'))
2884
-		unset($_POST['sticky']);
3032
+	if (isset($_POST['sticky']) && !allowedTo('make_sticky')) {
3033
+			unset($_POST['sticky']);
3034
+	}
2885 3035
 
2886 3036
 	if (isset($_POST['modify_reason']))
2887 3037
 	{
2888 3038
 		$_POST['modify_reason'] = strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
2889 3039
 
2890 3040
 		// Maximum number of characters.
2891
-		if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
2892
-			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
3041
+		if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
3042
+					$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
3043
+		}
2893 3044
 	}
2894 3045
 
2895 3046
 	if (empty($post_errors))
@@ -2926,8 +3077,9 @@  discard block
 block discarded – undo
2926 3077
 			}
2927 3078
 		}
2928 3079
 		// If nothing was changed there's no need to add an entry to the moderation log.
2929
-		else
2930
-			$moderationAction = false;
3080
+		else {
3081
+					$moderationAction = false;
3082
+		}
2931 3083
 
2932 3084
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2933 3085
 
@@ -2945,9 +3097,9 @@  discard block
 block discarded – undo
2945 3097
 			// Get the proper (default language) response prefix first.
2946 3098
 			if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
2947 3099
 			{
2948
-				if ($language === $user_info['language'])
2949
-					$context['response_prefix'] = $txt['response_prefix'];
2950
-				else
3100
+				if ($language === $user_info['language']) {
3101
+									$context['response_prefix'] = $txt['response_prefix'];
3102
+				} else
2951 3103
 				{
2952 3104
 					loadLanguage('index', $language, false);
2953 3105
 					$context['response_prefix'] = $txt['response_prefix'];
@@ -2969,8 +3121,9 @@  discard block
 block discarded – undo
2969 3121
 			);
2970 3122
 		}
2971 3123
 
2972
-		if (!empty($moderationAction))
2973
-			logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3124
+		if (!empty($moderationAction)) {
3125
+					logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3126
+		}
2974 3127
 	}
2975 3128
 
2976 3129
 	if (isset($_REQUEST['xml']))
@@ -3011,8 +3164,7 @@  discard block
 block discarded – undo
3011 3164
 			);
3012 3165
 
3013 3166
 			censorText($context['message']['subject']);
3014
-		}
3015
-		else
3167
+		} else
3016 3168
 		{
3017 3169
 			$context['message'] = array(
3018 3170
 				'id' => $row['id_msg'],
@@ -3024,15 +3176,16 @@  discard block
 block discarded – undo
3024 3176
 			loadLanguage('Errors');
3025 3177
 			foreach ($post_errors as $post_error)
3026 3178
 			{
3027
-				if ($post_error == 'long_message')
3028
-					$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
3029
-				else
3030
-					$context['message']['errors'][] = $txt['error_' . $post_error];
3179
+				if ($post_error == 'long_message') {
3180
+									$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
3181
+				} else {
3182
+									$context['message']['errors'][] = $txt['error_' . $post_error];
3183
+				}
3031 3184
 			}
3032 3185
 		}
3186
+	} else {
3187
+			obExit(false);
3188
+	}
3033 3189
 	}
3034
-	else
3035
-		obExit(false);
3036
-}
3037 3190
 
3038 3191
 ?>
3039 3192
\ No newline at end of file
Please login to merge, or discard this patch.