@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -18,7 +18,7 @@ discard block |
||
18 | 18 | class CreatePost_Notify_Background extends SMF_BackgroundTask |
19 | 19 | { |
20 | 20 | /** |
21 | - * This handles notifications when a new post is created - new topic, reply, quotes and mentions. |
|
21 | + * This handles notifications when a new post is created - new topic, reply, quotes and mentions. |
|
22 | 22 | * @return bool Always returns true |
23 | 23 | */ |
24 | 24 | public function execute() |
@@ -106,7 +106,7 @@ discard block |
||
106 | 106 | |
107 | 107 | // Don't send a notification if the watching member ignored the member who made the action. |
108 | 108 | if (!empty($data['pm_ignore_list']) && in_array($data['id_member_updated'], explode(',', $data['pm_ignore_list']))) |
109 | - continue; |
|
109 | + continue; |
|
110 | 110 | if (!in_array($type, array('reply', 'topic')) && $notify_types == 2 && $member != $data['id_member_started']) |
111 | 111 | continue; |
112 | 112 | elseif (in_array($type, array('reply', 'topic')) && $member == $posterOptions['id']) |
@@ -73,8 +73,9 @@ discard block |
||
73 | 73 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
74 | 74 | { |
75 | 75 | $groups = array_merge(array($row['id_group'], $row['id_post_group']), (empty($row['additional_groups']) ? array() : explode(',', $row['additional_groups']))); |
76 | - if (!in_array(1, $groups) && count(array_intersect($groups, explode(',', $row['member_groups']))) == 0) |
|
77 | - continue; |
|
76 | + if (!in_array(1, $groups) && count(array_intersect($groups, explode(',', $row['member_groups']))) == 0) { |
|
77 | + continue; |
|
78 | + } |
|
78 | 79 | |
79 | 80 | $members[] = $row['id_member']; |
80 | 81 | $watched[$row['id_member']] = $row; |
@@ -82,8 +83,9 @@ discard block |
||
82 | 83 | |
83 | 84 | $smcFunc['db_free_result']($request); |
84 | 85 | |
85 | - if (empty($members)) |
|
86 | - return true; |
|
86 | + if (empty($members)) { |
|
87 | + return true; |
|
88 | + } |
|
87 | 89 | |
88 | 90 | $members = array_unique($members); |
89 | 91 | $prefs = getNotifyPrefs($members, '', true); |
@@ -105,20 +107,23 @@ discard block |
||
105 | 107 | $notify_types = !empty($prefs[$member]['msg_notify_type']) ? $prefs[$member]['msg_notify_type'] : 1; |
106 | 108 | |
107 | 109 | // Don't send a notification if the watching member ignored the member who made the action. |
108 | - if (!empty($data['pm_ignore_list']) && in_array($data['id_member_updated'], explode(',', $data['pm_ignore_list']))) |
|
109 | - continue; |
|
110 | - if (!in_array($type, array('reply', 'topic')) && $notify_types == 2 && $member != $data['id_member_started']) |
|
111 | - continue; |
|
112 | - elseif (in_array($type, array('reply', 'topic')) && $member == $posterOptions['id']) |
|
113 | - continue; |
|
114 | - elseif (!in_array($type, array('reply', 'topic')) && $notify_types == 3) |
|
115 | - continue; |
|
116 | - elseif ($notify_types == 4) |
|
117 | - continue; |
|
110 | + if (!empty($data['pm_ignore_list']) && in_array($data['id_member_updated'], explode(',', $data['pm_ignore_list']))) { |
|
111 | + continue; |
|
112 | + } |
|
113 | + if (!in_array($type, array('reply', 'topic')) && $notify_types == 2 && $member != $data['id_member_started']) { |
|
114 | + continue; |
|
115 | + } elseif (in_array($type, array('reply', 'topic')) && $member == $posterOptions['id']) { |
|
116 | + continue; |
|
117 | + } elseif (!in_array($type, array('reply', 'topic')) && $notify_types == 3) { |
|
118 | + continue; |
|
119 | + } elseif ($notify_types == 4) { |
|
120 | + continue; |
|
121 | + } |
|
118 | 122 | |
119 | 123 | if ($frequency > 2 || (!empty($frequency) && $data['sent']) || in_array($member, $done_members) |
120 | - || (!empty($this->_details['members_only']) && !in_array($member, $this->_details['members_only']))) |
|
121 | - continue; |
|
124 | + || (!empty($this->_details['members_only']) && !in_array($member, $this->_details['members_only']))) { |
|
125 | + continue; |
|
126 | + } |
|
122 | 127 | |
123 | 128 | // Watched topic? |
124 | 129 | if (!empty($data['id_topic']) && $type != 'topic' && !empty($prefs[$member])) |
@@ -128,10 +133,12 @@ discard block |
||
128 | 133 | |
129 | 134 | if ($type == 'reply') |
130 | 135 | { |
131 | - if (!empty($prefs[$member]['msg_receive_body'])) |
|
132 | - $message_type .= '_body'; |
|
133 | - if (!empty($frequency)) |
|
134 | - $message_type .= '_once'; |
|
136 | + if (!empty($prefs[$member]['msg_receive_body'])) { |
|
137 | + $message_type .= '_body'; |
|
138 | + } |
|
139 | + if (!empty($frequency)) { |
|
140 | + $message_type .= '_once'; |
|
141 | + } |
|
135 | 142 | } |
136 | 143 | |
137 | 144 | $content_type = 'topic'; |
@@ -144,12 +151,14 @@ discard block |
||
144 | 151 | $content_type = 'board'; |
145 | 152 | |
146 | 153 | $message_type = !empty($frequency) ? 'notify_boards_once' : 'notify_boards'; |
147 | - if (!empty($prefs[$member]['msg_receive_body'])) |
|
148 | - $message_type .= '_body'; |
|
154 | + if (!empty($prefs[$member]['msg_receive_body'])) { |
|
155 | + $message_type .= '_body'; |
|
156 | + } |
|
149 | 157 | } |
150 | 158 | // If neither of the above, this might be a redundent row due to the OR clause in our SQL query, skip |
151 | - else |
|
152 | - continue; |
|
159 | + else { |
|
160 | + continue; |
|
161 | + } |
|
153 | 162 | |
154 | 163 | if ($pref & 0x02) |
155 | 164 | { |
@@ -212,14 +221,15 @@ discard block |
||
212 | 221 | ); |
213 | 222 | |
214 | 223 | // Insert the alerts if any |
215 | - if (!empty($alert_rows)) |
|
216 | - $smcFunc['db_insert']('', |
|
224 | + if (!empty($alert_rows)) { |
|
225 | + $smcFunc['db_insert']('', |
|
217 | 226 | '{db_prefix}user_alerts', |
218 | 227 | array('alert_time' => 'int', 'id_member' => 'int', 'id_member_started' => 'int', 'member_name' => 'string', |
219 | 228 | 'content_type' => 'string', 'content_id' => 'int', 'content_action' => 'string', 'is_read' => 'int', 'extra' => 'string'), |
220 | 229 | $alert_rows, |
221 | 230 | array() |
222 | 231 | ); |
232 | + } |
|
223 | 233 | |
224 | 234 | return true; |
225 | 235 | } |
@@ -230,8 +240,9 @@ discard block |
||
230 | 240 | |
231 | 241 | foreach ($quotedMembers as $id => $member) |
232 | 242 | { |
233 | - if (!isset($prefs[$id]) || $id == $posterOptions['id'] || empty($prefs[$id]['msg_quote'])) |
|
234 | - continue; |
|
243 | + if (!isset($prefs[$id]) || $id == $posterOptions['id'] || empty($prefs[$id]['msg_quote'])) { |
|
244 | + continue; |
|
245 | + } |
|
235 | 246 | |
236 | 247 | $done_members[] = $id; |
237 | 248 | |
@@ -283,32 +294,35 @@ discard block |
||
283 | 294 | { |
284 | 295 | if (preg_match('/\[quote(.*)?\]/i', $block, $matches)) |
285 | 296 | { |
286 | - if ($quote_level == 0) |
|
287 | - $message .= '[quote' . $matches[1] . ']'; |
|
297 | + if ($quote_level == 0) { |
|
298 | + $message .= '[quote' . $matches[1] . ']'; |
|
299 | + } |
|
288 | 300 | $quote_level++; |
289 | - } |
|
290 | - elseif (preg_match('/\[\/quote\]/i', $block)) |
|
301 | + } elseif (preg_match('/\[\/quote\]/i', $block)) |
|
291 | 302 | { |
292 | - if ($quote_level <= 1) |
|
293 | - $message .= '[/quote]'; |
|
303 | + if ($quote_level <= 1) { |
|
304 | + $message .= '[/quote]'; |
|
305 | + } |
|
294 | 306 | if ($quote_level >= 1) |
295 | 307 | { |
296 | 308 | $quote_level--; |
297 | 309 | $message .= "\n"; |
298 | 310 | } |
311 | + } elseif ($quote_level <= 1) { |
|
312 | + $message .= $block; |
|
299 | 313 | } |
300 | - elseif ($quote_level <= 1) |
|
301 | - $message .= $block; |
|
302 | 314 | } |
303 | 315 | |
304 | 316 | preg_match_all('/\[quote.*?link=msg=([0-9]+).*?\]/i', $message, $matches); |
305 | 317 | |
306 | 318 | $id_msgs = $matches[1]; |
307 | - foreach ($id_msgs as $k => $id_msg) |
|
308 | - $id_msgs[$k] = (int) $id_msg; |
|
319 | + foreach ($id_msgs as $k => $id_msg) { |
|
320 | + $id_msgs[$k] = (int) $id_msg; |
|
321 | + } |
|
309 | 322 | |
310 | - if (empty($id_msgs)) |
|
311 | - return array(); |
|
323 | + if (empty($id_msgs)) { |
|
324 | + return array(); |
|
325 | + } |
|
312 | 326 | |
313 | 327 | // Get the messages |
314 | 328 | $request = $smcFunc['db_query']('', ' |
@@ -326,8 +340,9 @@ discard block |
||
326 | 340 | $members = array(); |
327 | 341 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
328 | 342 | { |
329 | - if ($posterOptions['id'] == $row['id_member']) |
|
330 | - continue; |
|
343 | + if ($posterOptions['id'] == $row['id_member']) { |
|
344 | + continue; |
|
345 | + } |
|
331 | 346 | |
332 | 347 | $members[$row['id_member']] = $row; |
333 | 348 | } |
@@ -341,10 +356,11 @@ discard block |
||
341 | 356 | |
342 | 357 | foreach ($members as $id => $member) |
343 | 358 | { |
344 | - if (!empty($prefs[$id]['msg_mention'])) |
|
345 | - $done_members[] = $id; |
|
346 | - else |
|
347 | - continue; |
|
359 | + if (!empty($prefs[$id]['msg_mention'])) { |
|
360 | + $done_members[] = $id; |
|
361 | + } else { |
|
362 | + continue; |
|
363 | + } |
|
348 | 364 | |
349 | 365 | // Alerts' emails are always instant |
350 | 366 | if ($prefs[$id]['msg_mention'] & 0x02) |
@@ -51,30 +51,33 @@ discard block |
||
51 | 51 | $ignored_members = explode(',', $row['pm_ignore_list']); |
52 | 52 | |
53 | 53 | // If the user is in group 1 anywhere, they can see everything anyway. |
54 | - if (in_array(1, $groups) || count(array_intersect($allowed, $groups)) != 0) |
|
55 | - $author = $row['id_member']; |
|
54 | + if (in_array(1, $groups) || count(array_intersect($allowed, $groups)) != 0) { |
|
55 | + $author = $row['id_member']; |
|
56 | + } |
|
56 | 57 | } |
57 | 58 | $smcFunc['db_free_result']($request); |
58 | - } |
|
59 | - else |
|
59 | + } else |
|
60 | 60 | { |
61 | 61 | // This isn't something we know natively how to support. Call the hooks, if they're dealing with it, return false, otherwise return the user id. |
62 | 62 | $hook_results = call_integration_hook('integrate_find_like_author', array($this->_details['content_type'], $this->_details['content_id'])); |
63 | - foreach ($hook_results as $result) |
|
64 | - if (!empty($result)) |
|
63 | + foreach ($hook_results as $result) { |
|
64 | + if (!empty($result)) |
|
65 | 65 | { |
66 | 66 | $author = $result; |
67 | + } |
|
67 | 68 | break; |
68 | 69 | } |
69 | 70 | } |
70 | 71 | |
71 | 72 | // If we didn't have a member... leave. |
72 | - if (empty($author)) |
|
73 | - return true; |
|
73 | + if (empty($author)) { |
|
74 | + return true; |
|
75 | + } |
|
74 | 76 | |
75 | 77 | // If the person who sent the notification is the person whose content it is, do nothing. |
76 | - if ($author == $this->_details['sender_id']) |
|
77 | - return true; |
|
78 | + if ($author == $this->_details['sender_id']) { |
|
79 | + return true; |
|
80 | + } |
|
78 | 81 | |
79 | 82 | // If the person who sent the notification is on this person's ignore list, do nothing. |
80 | 83 | if (!empty($ignored_members) && in_array($this->_details['sender_id'], $ignored_members)) { |
@@ -88,8 +91,9 @@ discard block |
||
88 | 91 | // As a result, the value should really just be non empty. |
89 | 92 | |
90 | 93 | // Check the value. If no value or it's empty, they didn't want alerts, oh well. |
91 | - if (empty($prefs[$author][$this->_details['content_type'] . '_like'])) |
|
92 | - return true; |
|
94 | + if (empty($prefs[$author][$this->_details['content_type'] . '_like'])) { |
|
95 | + return true; |
|
96 | + } |
|
93 | 97 | |
94 | 98 | // Don't spam the alerts: if there is an existing unread alert of the |
95 | 99 | // requested type for the target user from the sender, don't make a new one. |
@@ -109,8 +113,9 @@ discard block |
||
109 | 113 | ) |
110 | 114 | ); |
111 | 115 | |
112 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
113 | - return true; |
|
116 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
117 | + return true; |
|
118 | + } |
|
114 | 119 | $smcFunc['db_free_result']($request); |
115 | 120 | |
116 | 121 | // Issue, update, move on. |
@@ -670,7 +670,7 @@ |
||
670 | 670 | // Show "<< Last Edit: Time by Person >>" if this post was edited. But we need the div even if it wasn't modified! |
671 | 671 | // Because we insert into it through AJAX and we don't want to stop themers moving it around if they so wish so they can put it where they want it. |
672 | 672 | echo ' |
673 | - <span class="smalltext modified floatright', !empty($modSettings['show_modify']) && !empty($message['modified']['name']) ? ' mvisible' : '','" id="modified_', $message['id'], '">'; |
|
673 | + <span class="smalltext modified floatright', !empty($modSettings['show_modify']) && !empty($message['modified']['name']) ? ' mvisible' : '', '" id="modified_', $message['id'], '">'; |
|
674 | 674 | |
675 | 675 | if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) |
676 | 676 | echo |
@@ -18,18 +18,20 @@ discard block |
||
18 | 18 | global $context, $settings, $options, $txt, $scripturl, $modSettings; |
19 | 19 | |
20 | 20 | // Let them know, if their report was a success! |
21 | - if ($context['report_sent']) |
|
22 | - echo ' |
|
21 | + if ($context['report_sent']) { |
|
22 | + echo ' |
|
23 | 23 | <div class="infobox"> |
24 | 24 | ', $txt['report_sent'], ' |
25 | 25 | </div>'; |
26 | + } |
|
26 | 27 | |
27 | 28 | // Let them know why their message became unapproved. |
28 | - if ($context['becomesUnapproved']) |
|
29 | - echo ' |
|
29 | + if ($context['becomesUnapproved']) { |
|
30 | + echo ' |
|
30 | 31 | <div class="noticebox"> |
31 | 32 | ', $txt['post_becomesUnapproved'], ' |
32 | 33 | </div>'; |
34 | + } |
|
33 | 35 | |
34 | 36 | // Show new topic info here? |
35 | 37 | echo ' |
@@ -49,11 +51,13 @@ discard block |
||
49 | 51 | <p>'; |
50 | 52 | |
51 | 53 | // Show just numbers...? |
52 | - if ($settings['display_who_viewing'] == 1) |
|
53 | - echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members']; |
|
54 | + if ($settings['display_who_viewing'] == 1) { |
|
55 | + echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members']; |
|
56 | + } |
|
54 | 57 | // Or show the actual people viewing the topic? |
55 | - else |
|
56 | - echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
58 | + else { |
|
59 | + echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
60 | + } |
|
57 | 61 | |
58 | 62 | // Now show how many guests are here too. |
59 | 63 | echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_topic'], ' |
@@ -91,10 +95,11 @@ discard block |
||
91 | 95 | <dt class="', $option['voted_this'] ? ' voted' : '', '">', $option['option'], '</dt> |
92 | 96 | <dd class="statsbar', $option['voted_this'] ? ' voted' : '', '">'; |
93 | 97 | |
94 | - if ($context['allow_results_view']) |
|
95 | - echo ' |
|
98 | + if ($context['allow_results_view']) { |
|
99 | + echo ' |
|
96 | 100 | ', $option['bar_ndt'], ' |
97 | 101 | <span class="percentage">', $option['votes'], ' (', $option['percent'], '%)</span>'; |
102 | + } |
|
98 | 103 | |
99 | 104 | echo ' |
100 | 105 | </dd>'; |
@@ -103,9 +108,10 @@ discard block |
||
103 | 108 | echo ' |
104 | 109 | </dl>'; |
105 | 110 | |
106 | - if ($context['allow_results_view']) |
|
107 | - echo ' |
|
111 | + if ($context['allow_results_view']) { |
|
112 | + echo ' |
|
108 | 113 | <p><strong>', $txt['poll_total_voters'], ':</strong> ', $context['poll']['total_votes'], '</p>'; |
114 | + } |
|
109 | 115 | } |
110 | 116 | // They are allowed to vote! Go to it! |
111 | 117 | else |
@@ -114,17 +120,19 @@ discard block |
||
114 | 120 | <form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '">'; |
115 | 121 | |
116 | 122 | // Show a warning if they are allowed more than one option. |
117 | - if ($context['poll']['allowed_warning']) |
|
118 | - echo ' |
|
123 | + if ($context['poll']['allowed_warning']) { |
|
124 | + echo ' |
|
119 | 125 | <p class="smallpadding">', $context['poll']['allowed_warning'], '</p>'; |
126 | + } |
|
120 | 127 | |
121 | 128 | echo ' |
122 | 129 | <ul class="options">'; |
123 | 130 | |
124 | 131 | // Show each option with its button - a radio likely. |
125 | - foreach ($context['poll']['options'] as $option) |
|
126 | - echo ' |
|
132 | + foreach ($context['poll']['options'] as $option) { |
|
133 | + echo ' |
|
127 | 134 | <li>', $option['vote_button'], ' <label for="', $option['id'], '">', $option['option'], '</label></li>'; |
135 | + } |
|
128 | 136 | |
129 | 137 | echo ' |
130 | 138 | </ul> |
@@ -136,9 +144,10 @@ discard block |
||
136 | 144 | } |
137 | 145 | |
138 | 146 | // Is the clock ticking? |
139 | - if (!empty($context['poll']['expire_time'])) |
|
140 | - echo ' |
|
147 | + if (!empty($context['poll']['expire_time'])) { |
|
148 | + echo ' |
|
141 | 149 | <p><strong>', ($context['poll']['is_expired'] ? $txt['poll_expired_on'] : $txt['poll_expires_on']), ':</strong> ', $context['poll']['expire_time'], '</p>'; |
150 | + } |
|
142 | 151 | |
143 | 152 | echo ' |
144 | 153 | </div><!-- #poll_options --> |
@@ -168,11 +177,13 @@ discard block |
||
168 | 177 | <li> |
169 | 178 | <strong class="event_title"><a href="', $scripturl, '?action=calendar;event=', $event['id'], '">', $event['title'], '</a></strong>'; |
170 | 179 | |
171 | - if ($event['can_edit']) |
|
172 | - echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
180 | + if ($event['can_edit']) { |
|
181 | + echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
182 | + } |
|
173 | 183 | |
174 | - if ($event['can_export']) |
|
175 | - echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
184 | + if ($event['can_export']) { |
|
185 | + echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
186 | + } |
|
176 | 187 | |
177 | 188 | echo ' |
178 | 189 | <br>'; |
@@ -180,14 +191,14 @@ discard block |
||
180 | 191 | if (!empty($event['allday'])) |
181 | 192 | { |
182 | 193 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), '</time>', ($event['start_date'] != $event['end_date']) ? ' – <time datetime="' . $event['end_iso_gmdate'] . '">' . trim($event['end_date_local']) . '</time>' : ''; |
183 | - } |
|
184 | - else |
|
194 | + } else |
|
185 | 195 | { |
186 | 196 | // Display event info relative to user's local timezone |
187 | 197 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), ', ', trim($event['start_time_local']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
188 | 198 | |
189 | - if ($event['start_date_local'] != $event['end_date_local']) |
|
190 | - echo trim($event['end_date_local']) . ', '; |
|
199 | + if ($event['start_date_local'] != $event['end_date_local']) { |
|
200 | + echo trim($event['end_date_local']) . ', '; |
|
201 | + } |
|
191 | 202 | |
192 | 203 | echo trim($event['end_time_local']); |
193 | 204 | |
@@ -196,24 +207,28 @@ discard block |
||
196 | 207 | { |
197 | 208 | echo '</time> (<time datetime="' . $event['start_iso_gmdate'] . '">'; |
198 | 209 | |
199 | - if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) |
|
200 | - echo trim($event['start_date_orig']), ', '; |
|
210 | + if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) { |
|
211 | + echo trim($event['start_date_orig']), ', '; |
|
212 | + } |
|
201 | 213 | |
202 | 214 | echo trim($event['start_time_orig']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
203 | 215 | |
204 | - if ($event['start_date_orig'] != $event['end_date_orig']) |
|
205 | - echo trim($event['end_date_orig']) . ', '; |
|
216 | + if ($event['start_date_orig'] != $event['end_date_orig']) { |
|
217 | + echo trim($event['end_date_orig']) . ', '; |
|
218 | + } |
|
206 | 219 | |
207 | 220 | echo trim($event['end_time_orig']), ' ', $event['tz_abbrev'], '</time>)'; |
208 | 221 | } |
209 | 222 | // Event is scheduled in the user's own timezone? Let 'em know, just to avoid confusion |
210 | - else |
|
211 | - echo ' ', $event['tz_abbrev'], '</time>'; |
|
223 | + else { |
|
224 | + echo ' ', $event['tz_abbrev'], '</time>'; |
|
225 | + } |
|
212 | 226 | } |
213 | 227 | |
214 | - if (!empty($event['location'])) |
|
215 | - echo ' |
|
228 | + if (!empty($event['location'])) { |
|
229 | + echo ' |
|
216 | 230 | <br>', $event['location']; |
231 | + } |
|
217 | 232 | |
218 | 233 | echo ' |
219 | 234 | </li>'; |
@@ -250,8 +265,9 @@ discard block |
||
250 | 265 | $context['removableMessageIDs'] = array(); |
251 | 266 | |
252 | 267 | // Get all the messages... |
253 | - while ($message = $context['get_message']()) |
|
254 | - template_single_post($message); |
|
268 | + while ($message = $context['get_message']()) { |
|
269 | + template_single_post($message); |
|
270 | + } |
|
255 | 271 | |
256 | 272 | echo ' |
257 | 273 | </form> |
@@ -289,8 +305,9 @@ discard block |
||
289 | 305 | <div id="display_jump_to"></div>'; |
290 | 306 | |
291 | 307 | // Show quickreply |
292 | - if ($context['can_reply']) |
|
293 | - template_quickreply(); |
|
308 | + if ($context['can_reply']) { |
|
309 | + template_quickreply(); |
|
310 | + } |
|
294 | 311 | |
295 | 312 | // User action pop on mobile screen (or actually small screen), this uses responsive css does not check mobile device. |
296 | 313 | echo ' |
@@ -305,8 +322,8 @@ discard block |
||
305 | 322 | </div>'; |
306 | 323 | |
307 | 324 | // Show the moderation button & pop only if user can moderate |
308 | - if ($context['can_moderate_forum'] || $context['user']['is_mod']) |
|
309 | - echo ' |
|
325 | + if ($context['can_moderate_forum'] || $context['user']['is_mod']) { |
|
326 | + echo ' |
|
310 | 327 | <div id="mobile_moderation" class="popup_container"> |
311 | 328 | <div class="popup_window description"> |
312 | 329 | <div class="popup_heading"> |
@@ -318,6 +335,7 @@ discard block |
||
318 | 335 | </div> |
319 | 336 | </div> |
320 | 337 | </div>'; |
338 | + } |
|
321 | 339 | |
322 | 340 | echo ' |
323 | 341 | <script>'; |
@@ -441,9 +459,10 @@ discard block |
||
441 | 459 | }); |
442 | 460 | }'; |
443 | 461 | |
444 | - if (!empty($context['ignoredMsgs'])) |
|
445 | - echo ' |
|
462 | + if (!empty($context['ignoredMsgs'])) { |
|
463 | + echo ' |
|
446 | 464 | ignore_toggles([', implode(', ', $context['ignoredMsgs']), '], ', JavaScriptEscape($txt['show_ignore_user_post']), ');'; |
465 | + } |
|
447 | 466 | |
448 | 467 | echo ' |
449 | 468 | </script>'; |
@@ -460,8 +479,9 @@ discard block |
||
460 | 479 | |
461 | 480 | $ignoring = false; |
462 | 481 | |
463 | - if ($message['can_remove']) |
|
464 | - $context['removableMessageIDs'][] = $message['id']; |
|
482 | + if ($message['can_remove']) { |
|
483 | + $context['removableMessageIDs'][] = $message['id']; |
|
484 | + } |
|
465 | 485 | |
466 | 486 | // Are we ignoring this message? |
467 | 487 | if (!empty($message['is_ignored'])) |
@@ -488,9 +508,10 @@ discard block |
||
488 | 508 | <div class="custom_fields_above_member"> |
489 | 509 | <ul class="nolist">'; |
490 | 510 | |
491 | - foreach ($message['custom_fields']['above_member'] as $custom) |
|
492 | - echo ' |
|
511 | + foreach ($message['custom_fields']['above_member'] as $custom) { |
|
512 | + echo ' |
|
493 | 513 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
514 | + } |
|
494 | 515 | |
495 | 516 | echo ' |
496 | 517 | </ul> |
@@ -501,25 +522,28 @@ discard block |
||
501 | 522 | <h4>'; |
502 | 523 | |
503 | 524 | // Show online and offline buttons? |
504 | - if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) |
|
505 | - echo ' |
|
525 | + if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) { |
|
526 | + echo ' |
|
506 | 527 | ', $context['can_send_pm'] ? '<a href="' . $message['member']['online']['href'] . '" title="' . $message['member']['online']['label'] . '">' : '', '<span class="' . ($message['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $message['member']['online']['text'] . '"></span>', $context['can_send_pm'] ? '</a>' : ''; |
528 | + } |
|
507 | 529 | |
508 | 530 | // Custom fields BEFORE the username? |
509 | - if (!empty($message['custom_fields']['before_member'])) |
|
510 | - foreach ($message['custom_fields']['before_member'] as $custom) |
|
531 | + if (!empty($message['custom_fields']['before_member'])) { |
|
532 | + foreach ($message['custom_fields']['before_member'] as $custom) |
|
511 | 533 | echo ' |
512 | 534 | <span class="custom ', $custom['col_name'], '">', $custom['value'], '</span>'; |
535 | + } |
|
513 | 536 | |
514 | 537 | // Show a link to the member's profile. |
515 | 538 | echo ' |
516 | 539 | ', $message['member']['link']; |
517 | 540 | |
518 | 541 | // Custom fields AFTER the username? |
519 | - if (!empty($message['custom_fields']['after_member'])) |
|
520 | - foreach ($message['custom_fields']['after_member'] as $custom) |
|
542 | + if (!empty($message['custom_fields']['after_member'])) { |
|
543 | + foreach ($message['custom_fields']['after_member'] as $custom) |
|
521 | 544 | echo ' |
522 | 545 | <span class="custom ', $custom['col_name'], '">', $custom['value'], '</span>'; |
546 | + } |
|
523 | 547 | |
524 | 548 | // Begin display of user info |
525 | 549 | echo ' |
@@ -527,51 +551,59 @@ discard block |
||
527 | 551 | <ul class="user_info">'; |
528 | 552 | |
529 | 553 | // Show the user's avatar. |
530 | - if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) |
|
531 | - echo ' |
|
554 | + if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) { |
|
555 | + echo ' |
|
532 | 556 | <li class="avatar"> |
533 | 557 | <a href="', $message['member']['href'], '">', $message['member']['avatar']['image'], '</a> |
534 | 558 | </li>'; |
559 | + } |
|
535 | 560 | |
536 | 561 | // Are there any custom fields below the avatar? |
537 | - if (!empty($message['custom_fields']['below_avatar'])) |
|
538 | - foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
562 | + if (!empty($message['custom_fields']['below_avatar'])) { |
|
563 | + foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
539 | 564 | echo ' |
540 | 565 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
566 | + } |
|
541 | 567 | |
542 | 568 | // Show the post group icons, but not for guests. |
543 | - if (!$message['member']['is_guest']) |
|
544 | - echo ' |
|
569 | + if (!$message['member']['is_guest']) { |
|
570 | + echo ' |
|
545 | 571 | <li class="icons">', $message['member']['group_icons'], '</li>'; |
572 | + } |
|
546 | 573 | |
547 | 574 | // Show the member's primary group (like 'Administrator') if they have one. |
548 | - if (!empty($message['member']['group'])) |
|
549 | - echo ' |
|
575 | + if (!empty($message['member']['group'])) { |
|
576 | + echo ' |
|
550 | 577 | <li class="membergroup">', $message['member']['group'], '</li>'; |
578 | + } |
|
551 | 579 | |
552 | 580 | // Show the member's custom title, if they have one. |
553 | - if (!empty($message['member']['title'])) |
|
554 | - echo ' |
|
581 | + if (!empty($message['member']['title'])) { |
|
582 | + echo ' |
|
555 | 583 | <li class="title">', $message['member']['title'], '</li>'; |
584 | + } |
|
556 | 585 | |
557 | 586 | // Don't show these things for guests. |
558 | 587 | if (!$message['member']['is_guest']) |
559 | 588 | { |
560 | 589 | |
561 | 590 | // Show the post group if and only if they have no other group or the option is on, and they are in a post group. |
562 | - if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) |
|
563 | - echo ' |
|
591 | + if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) { |
|
592 | + echo ' |
|
564 | 593 | <li class="postgroup">', $message['member']['post_group'], '</li>'; |
594 | + } |
|
565 | 595 | |
566 | 596 | // Show how many posts they have made. |
567 | - if (!isset($context['disabled_fields']['posts'])) |
|
568 | - echo ' |
|
597 | + if (!isset($context['disabled_fields']['posts'])) { |
|
598 | + echo ' |
|
569 | 599 | <li class="postcount">', $txt['member_postcount'], ': ', $message['member']['posts'], '</li>'; |
600 | + } |
|
570 | 601 | |
571 | 602 | // Show their personal text? |
572 | - if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) |
|
573 | - echo ' |
|
603 | + if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) { |
|
604 | + echo ' |
|
574 | 605 | <li class="blurb">', $message['member']['blurb'], '</li>'; |
606 | + } |
|
575 | 607 | |
576 | 608 | // Any custom fields to show as icons? |
577 | 609 | if (!empty($message['custom_fields']['icons'])) |
@@ -580,9 +612,10 @@ discard block |
||
580 | 612 | <li class="im_icons"> |
581 | 613 | <ol>'; |
582 | 614 | |
583 | - foreach ($message['custom_fields']['icons'] as $custom) |
|
584 | - echo ' |
|
615 | + foreach ($message['custom_fields']['icons'] as $custom) { |
|
616 | + echo ' |
|
585 | 617 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
618 | + } |
|
586 | 619 | |
587 | 620 | echo ' |
588 | 621 | </ol> |
@@ -597,19 +630,22 @@ discard block |
||
597 | 630 | <ol class="profile_icons">'; |
598 | 631 | |
599 | 632 | // Don't show an icon if they haven't specified a website. |
600 | - if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) |
|
601 | - echo ' |
|
633 | + if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) { |
|
634 | + echo ' |
|
602 | 635 | <li><a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank" rel="noopener">', ($settings['use_image_buttons'] ? '<span class="generic_icons www centericon" title="' . $message['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
636 | + } |
|
603 | 637 | |
604 | 638 | // Since we know this person isn't a guest, you *can* message them. |
605 | - if ($context['can_send_pm']) |
|
606 | - echo ' |
|
639 | + if ($context['can_send_pm']) { |
|
640 | + echo ' |
|
607 | 641 | <li><a href="', $scripturl, '?action=pm;sa=send;u=', $message['member']['id'], '" title="', $message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline'], '">', $settings['use_image_buttons'] ? '<span class="generic_icons im_' . ($message['member']['online']['is_online'] ? 'on' : 'off') . ' centericon" title="' . ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']) . '"></span> ' : ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']), '</a></li>'; |
642 | + } |
|
608 | 643 | |
609 | 644 | // Show the email if necessary |
610 | - if (!empty($message['member']['email']) && $message['member']['show_email']) |
|
611 | - echo ' |
|
645 | + if (!empty($message['member']['email']) && $message['member']['show_email']) { |
|
646 | + echo ' |
|
612 | 647 | <li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>'; |
648 | + } |
|
613 | 649 | |
614 | 650 | echo ' |
615 | 651 | </ol> |
@@ -617,58 +653,66 @@ discard block |
||
617 | 653 | } |
618 | 654 | |
619 | 655 | // Any custom fields for standard placement? |
620 | - if (!empty($message['custom_fields']['standard'])) |
|
621 | - foreach ($message['custom_fields']['standard'] as $custom) |
|
656 | + if (!empty($message['custom_fields']['standard'])) { |
|
657 | + foreach ($message['custom_fields']['standard'] as $custom) |
|
622 | 658 | echo ' |
623 | 659 | <li class="custom ', $custom['col_name'], '">', $custom['title'], ': ', $custom['value'], '</li>'; |
660 | + } |
|
624 | 661 | |
625 | 662 | } |
626 | 663 | // Otherwise, show the guest's email. |
627 | - elseif (!empty($message['member']['email']) && $message['member']['show_email']) |
|
628 | - echo ' |
|
664 | + elseif (!empty($message['member']['email']) && $message['member']['show_email']) { |
|
665 | + echo ' |
|
629 | 666 | <li class="email"> |
630 | 667 | <a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a> |
631 | 668 | </li>'; |
669 | + } |
|
632 | 670 | |
633 | 671 | // Show the IP to this user for this post - because you can moderate? |
634 | - if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) |
|
635 | - echo ' |
|
672 | + if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) { |
|
673 | + echo ' |
|
636 | 674 | <li class="poster_ip"> |
637 | 675 | <a href="', $scripturl, '?action=', !empty($message['member']['is_guest']) ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $message['member']['id'], ';searchip=', $message['member']['ip'], '">', $message['member']['ip'], '</a> <a href="', $scripturl, '?action=helpadmin;help=see_admin_ip" onclick="return reqOverlayDiv(this.href);" class="help">(?)</a> |
638 | 676 | </li>'; |
677 | + } |
|
639 | 678 | |
640 | 679 | // Or, should we show it because this is you? |
641 | - elseif ($message['can_see_ip']) |
|
642 | - echo ' |
|
680 | + elseif ($message['can_see_ip']) { |
|
681 | + echo ' |
|
643 | 682 | <li class="poster_ip"> |
644 | 683 | <a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $message['member']['ip'], '</a> |
645 | 684 | </li>'; |
685 | + } |
|
646 | 686 | |
647 | 687 | // Okay, are you at least logged in? Then we can show something about why IPs are logged... |
648 | - elseif (!$context['user']['is_guest']) |
|
649 | - echo ' |
|
688 | + elseif (!$context['user']['is_guest']) { |
|
689 | + echo ' |
|
650 | 690 | <li class="poster_ip"> |
651 | 691 | <a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $txt['logged'], '</a> |
652 | 692 | </li>'; |
693 | + } |
|
653 | 694 | |
654 | 695 | // Otherwise, you see NOTHING! |
655 | - else |
|
656 | - echo ' |
|
696 | + else { |
|
697 | + echo ' |
|
657 | 698 | <li class="poster_ip">', $txt['logged'], '</li>'; |
699 | + } |
|
658 | 700 | |
659 | 701 | // Are we showing the warning status? |
660 | 702 | // Don't show these things for guests. |
661 | - if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) |
|
662 | - echo ' |
|
703 | + if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) { |
|
704 | + echo ' |
|
663 | 705 | <li class="warning"> |
664 | 706 | ', $context['can_issue_warning'] ? '<a href="' . $scripturl . '?action=profile;area=issuewarning;u=' . $message['member']['id'] . '">' : '', '<span class="generic_icons warning_', $message['member']['warning_status'], '"></span> ', $context['can_issue_warning'] ? '</a>' : '', '<span class="warn_', $message['member']['warning_status'], '">', $txt['warn_' . $message['member']['warning_status']], '</span> |
665 | 707 | </li>'; |
708 | + } |
|
666 | 709 | |
667 | 710 | // Are there any custom fields to show at the bottom of the poster info? |
668 | - if (!empty($message['custom_fields']['bottom_poster'])) |
|
669 | - foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
711 | + if (!empty($message['custom_fields']['bottom_poster'])) { |
|
712 | + foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
670 | 713 | echo ' |
671 | 714 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
715 | + } |
|
672 | 716 | |
673 | 717 | // Poster info ends. |
674 | 718 | echo ' |
@@ -698,9 +742,10 @@ discard block |
||
698 | 742 | echo ' |
699 | 743 | <span class="smalltext modified floatright', !empty($modSettings['show_modify']) && !empty($message['modified']['name']) ? ' mvisible' : '','" id="modified_', $message['id'], '">'; |
700 | 744 | |
701 | - if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) |
|
702 | - echo |
|
745 | + if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) { |
|
746 | + echo |
|
703 | 747 | $message['modified']['last_edit_text']; |
748 | + } |
|
704 | 749 | |
705 | 750 | echo ' |
706 | 751 | </span> |
@@ -709,22 +754,24 @@ discard block |
||
709 | 754 | </div><!-- .keyinfo -->'; |
710 | 755 | |
711 | 756 | // Ignoring this user? Hide the post. |
712 | - if ($ignoring) |
|
713 | - echo ' |
|
757 | + if ($ignoring) { |
|
758 | + echo ' |
|
714 | 759 | <div id="msg_', $message['id'], '_ignored_prompt"> |
715 | 760 | ', $txt['ignoring_user'], ' |
716 | 761 | <a href="#" id="msg_', $message['id'], '_ignored_link" style="display: none;">', $txt['show_ignore_user_post'], '</a> |
717 | 762 | </div>'; |
763 | + } |
|
718 | 764 | |
719 | 765 | // Show the post itself, finally! |
720 | 766 | echo ' |
721 | 767 | <div class="post">'; |
722 | 768 | |
723 | - if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) |
|
724 | - echo ' |
|
769 | + if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) { |
|
770 | + echo ' |
|
725 | 771 | <div class="approve_post"> |
726 | 772 | ', $txt['post_awaiting_approval'], ' |
727 | 773 | </div>'; |
774 | + } |
|
728 | 775 | echo ' |
729 | 776 | <div class="inner" data-msgid="', $message['id'], '" id="msg_', $message['id'], '"', $ignoring ? ' style="display:none;"' : '', '> |
730 | 777 | ', $message['body'], ' |
@@ -743,9 +790,9 @@ discard block |
||
743 | 790 | foreach ($message['attachment'] as $attachment) |
744 | 791 | { |
745 | 792 | // Do we want this attachment to not be showed here? |
746 | - if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) |
|
747 | - continue; |
|
748 | - elseif (!$div_output) |
|
793 | + if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) { |
|
794 | + continue; |
|
795 | + } elseif (!$div_output) |
|
749 | 796 | { |
750 | 797 | $div_output = true; |
751 | 798 | |
@@ -762,9 +809,10 @@ discard block |
||
762 | 809 | <legend> |
763 | 810 | ', $txt['attach_awaiting_approve']; |
764 | 811 | |
765 | - if ($context['can_approve']) |
|
766 | - echo ' |
|
812 | + if ($context['can_approve']) { |
|
813 | + echo ' |
|
767 | 814 | [<a href="', $scripturl, '?action=attachapprove;sa=all;mid=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve_all'], '</a>]'; |
815 | + } |
|
768 | 816 | |
769 | 817 | echo ' |
770 | 818 | </legend>'; |
@@ -778,12 +826,13 @@ discard block |
||
778 | 826 | echo ' |
779 | 827 | <div class="attachments_top">'; |
780 | 828 | |
781 | - if ($attachment['thumbnail']['has_thumb']) |
|
782 | - echo ' |
|
829 | + if ($attachment['thumbnail']['has_thumb']) { |
|
830 | + echo ' |
|
783 | 831 | <a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" class="atc_img"></a>'; |
784 | - else |
|
785 | - echo ' |
|
832 | + } else { |
|
833 | + echo ' |
|
786 | 834 | <img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" class="atc_img">'; |
835 | + } |
|
787 | 836 | |
788 | 837 | echo ' |
789 | 838 | </div><!-- .attachments_top -->'; |
@@ -793,9 +842,10 @@ discard block |
||
793 | 842 | <div class="attachments_bot"> |
794 | 843 | <a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.png" class="centericon" alt="*"> ' . $attachment['name'] . '</a> '; |
795 | 844 | |
796 | - if (!$attachment['is_approved'] && $context['can_approve']) |
|
797 | - echo ' |
|
845 | + if (!$attachment['is_approved'] && $context['can_approve']) { |
|
846 | + echo ' |
|
798 | 847 | [<a href="', $scripturl, '?action=attachapprove;sa=approve;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve'], '</a>] [<a href="', $scripturl, '?action=attachapprove;sa=reject;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['delete'], '</a>] '; |
848 | + } |
|
799 | 849 | echo ' |
800 | 850 | <br>', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . '<br>' . sprintf($txt['attach_viewed'], $attachment['downloads']) : '<br>' . sprintf($txt['attach_downloaded'], $attachment['downloads'])), ' |
801 | 851 | </div><!-- .attachments_bot -->'; |
@@ -804,35 +854,40 @@ discard block |
||
804 | 854 | </div><!-- .attached -->'; |
805 | 855 | |
806 | 856 | // Next attachment line ? |
807 | - if (++$i % $attachments_per_line === 0) |
|
808 | - echo ' |
|
857 | + if (++$i % $attachments_per_line === 0) { |
|
858 | + echo ' |
|
809 | 859 | <br>'; |
860 | + } |
|
810 | 861 | } |
811 | 862 | |
812 | 863 | // If we had unapproved attachments clean up. |
813 | - if ($last_approved_state == 0) |
|
814 | - echo ' |
|
864 | + if ($last_approved_state == 0) { |
|
865 | + echo ' |
|
815 | 866 | </fieldset>'; |
867 | + } |
|
816 | 868 | |
817 | 869 | // Only do this if we output a div above - otherwise it'll break things |
818 | - if ($div_output) |
|
819 | - echo ' |
|
870 | + if ($div_output) { |
|
871 | + echo ' |
|
820 | 872 | </div><!-- #msg_[id]_footer -->'; |
873 | + } |
|
821 | 874 | } |
822 | 875 | |
823 | 876 | // And stuff below the attachments. |
824 | - if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) |
|
825 | - echo ' |
|
877 | + if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) { |
|
878 | + echo ' |
|
826 | 879 | <div class="under_message">'; |
880 | + } |
|
827 | 881 | |
828 | 882 | // Maybe they want to report this post to the moderator(s)? |
829 | - if ($context['can_report_moderator']) |
|
830 | - echo ' |
|
883 | + if ($context['can_report_moderator']) { |
|
884 | + echo ' |
|
831 | 885 | <ul class="floatright smalltext"> |
832 | 886 | <li class="report_link"> |
833 | 887 | <a href="', $scripturl, '?action=reporttm;topic=', $context['current_topic'], '.', $message['counter'], ';msg=', $message['id'], '">', $txt['report_to_mod'], '</a> |
834 | 888 | </li> |
835 | 889 | </ul>'; |
890 | + } |
|
836 | 891 | |
837 | 892 | // What about likes? |
838 | 893 | if (!empty($modSettings['enable_likes'])) |
@@ -879,83 +934,95 @@ discard block |
||
879 | 934 | <ul class="quickbuttons">'; |
880 | 935 | |
881 | 936 | // Can they quote? if so they can select and quote as well! |
882 | - if ($context['can_quote']) |
|
883 | - echo ' |
|
937 | + if ($context['can_quote']) { |
|
938 | + echo ' |
|
884 | 939 | <li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';last_msg=', $context['topic_last_message'], '" onclick="return oQuickReply.quote(', $message['id'], ');"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li> |
885 | 940 | <li style="display:none;" id="quoteSelected_', $message['id'], '"> |
886 | 941 | <a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a> |
887 | 942 | </li>'; |
943 | + } |
|
888 | 944 | |
889 | 945 | // Can the user modify the contents of this post? Show the modify inline image. |
890 | - if ($message['can_modify']) |
|
891 | - echo ' |
|
946 | + if ($message['can_modify']) { |
|
947 | + echo ' |
|
892 | 948 | <li class="quick_edit"> |
893 | 949 | <a title="', $txt['modify_msg'], '" class="modifybutton" id="modify_button_', $message['id'], '" onclick="oQuickModify.modifyMsg(\'', $message['id'], '\', \'', !empty($modSettings['toggle_subject']), '\')"><span class="generic_icons quick_edit_button"></span>', $txt['quick_edit'], '</a> |
894 | 950 | </li>'; |
951 | + } |
|
895 | 952 | |
896 | - if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) |
|
897 | - echo ' |
|
953 | + if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) { |
|
954 | + echo ' |
|
898 | 955 | <li class="post_options">', $txt['post_options']; |
956 | + } |
|
899 | 957 | |
900 | 958 | echo ' |
901 | 959 | <ul>'; |
902 | 960 | |
903 | 961 | // Can the user modify the contents of this post? |
904 | - if ($message['can_modify']) |
|
905 | - echo ' |
|
962 | + if ($message['can_modify']) { |
|
963 | + echo ' |
|
906 | 964 | <li><a href="', $scripturl, '?action=post;msg=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], '"><span class="generic_icons modify_button"></span>', $txt['modify'], '</a></li>'; |
965 | + } |
|
907 | 966 | |
908 | 967 | // How about... even... remove it entirely?! |
909 | - if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) |
|
910 | - echo ' |
|
968 | + if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) { |
|
969 | + echo ' |
|
911 | 970 | <li><a href="', $scripturl, '?action=removetopic2;topic=', $context['current_topic'], '.', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['are_sure_remove_topic'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove_topic'], '</a></li>'; |
912 | - |
|
913 | - elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) |
|
914 | - echo ' |
|
971 | + } elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) { |
|
972 | + echo ' |
|
915 | 973 | <li><a href="', $scripturl, '?action=deletemsg;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message_question'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
974 | + } |
|
916 | 975 | |
917 | 976 | // What about splitting it off the rest of the topic? |
918 | - if ($context['can_split'] && !empty($context['real_num_replies'])) |
|
919 | - echo ' |
|
977 | + if ($context['can_split'] && !empty($context['real_num_replies'])) { |
|
978 | + echo ' |
|
920 | 979 | <li><a href="', $scripturl, '?action=splittopics;topic=', $context['current_topic'], '.0;at=', $message['id'], '"><span class="generic_icons split_button"></span>', $txt['split'], '</a></li>'; |
980 | + } |
|
921 | 981 | |
922 | 982 | // Can we issue a warning because of this post? Remember, we can't give guests warnings. |
923 | - if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) |
|
924 | - echo ' |
|
983 | + if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) { |
|
984 | + echo ' |
|
925 | 985 | <li><a href="', $scripturl, '?action=profile;area=issuewarning;u=', $message['member']['id'], ';msg=', $message['id'], '"><span class="generic_icons warn_button"></span>', $txt['issue_warning'], '</a></li>'; |
986 | + } |
|
926 | 987 | |
927 | 988 | // Can we restore topics? |
928 | - if ($context['can_restore_msg']) |
|
929 | - echo ' |
|
989 | + if ($context['can_restore_msg']) { |
|
990 | + echo ' |
|
930 | 991 | <li><a href="', $scripturl, '?action=restoretopic;msgs=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons restore_button"></span>', $txt['restore_message'], '</a></li>'; |
992 | + } |
|
931 | 993 | |
932 | 994 | // Maybe we can approve it, maybe we should? |
933 | - if ($message['can_approve']) |
|
934 | - echo ' |
|
995 | + if ($message['can_approve']) { |
|
996 | + echo ' |
|
935 | 997 | <li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons approve_button"></span>', $txt['approve'], '</a></li>'; |
998 | + } |
|
936 | 999 | |
937 | 1000 | // Maybe we can unapprove it? |
938 | - if ($message['can_unapprove']) |
|
939 | - echo ' |
|
1001 | + if ($message['can_unapprove']) { |
|
1002 | + echo ' |
|
940 | 1003 | <li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons unapprove_button"></span>', $txt['unapprove'], '</a></li>'; |
1004 | + } |
|
941 | 1005 | |
942 | 1006 | echo ' |
943 | 1007 | </ul> |
944 | 1008 | </li>'; |
945 | 1009 | |
946 | 1010 | // Show a checkbox for quick moderation? |
947 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) |
|
948 | - echo ' |
|
1011 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) { |
|
1012 | + echo ' |
|
949 | 1013 | <li style="display: none;" id="in_topic_mod_check_', $message['id'], '"></li>'; |
1014 | + } |
|
950 | 1015 | |
951 | - if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) |
|
952 | - echo ' |
|
1016 | + if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) { |
|
1017 | + echo ' |
|
953 | 1018 | </ul><!-- .quickbuttons -->'; |
1019 | + } |
|
954 | 1020 | } |
955 | 1021 | |
956 | - if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) |
|
957 | - echo ' |
|
1022 | + if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) { |
|
1023 | + echo ' |
|
958 | 1024 | </div><!-- .under_message -->'; |
1025 | + } |
|
959 | 1026 | |
960 | 1027 | echo ' |
961 | 1028 | </div><!-- .postarea --> |
@@ -968,9 +1035,10 @@ discard block |
||
968 | 1035 | <div class="custom_fields_above_signature"> |
969 | 1036 | <ul class="nolist">'; |
970 | 1037 | |
971 | - foreach ($message['custom_fields']['above_signature'] as $custom) |
|
972 | - echo ' |
|
1038 | + foreach ($message['custom_fields']['above_signature'] as $custom) { |
|
1039 | + echo ' |
|
973 | 1040 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
1041 | + } |
|
974 | 1042 | |
975 | 1043 | echo ' |
976 | 1044 | </ul> |
@@ -978,11 +1046,12 @@ discard block |
||
978 | 1046 | } |
979 | 1047 | |
980 | 1048 | // Show the member's signature? |
981 | - if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) |
|
982 | - echo ' |
|
1049 | + if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) { |
|
1050 | + echo ' |
|
983 | 1051 | <div class="signature" id="msg_', $message['id'], '_signature"', $ignoring ? ' style="display:none;"' : '', '> |
984 | 1052 | ', $message['member']['signature'], ' |
985 | 1053 | </div>'; |
1054 | + } |
|
986 | 1055 | |
987 | 1056 | |
988 | 1057 | // Are there any custom profile fields for below the signature? |
@@ -992,9 +1061,10 @@ discard block |
||
992 | 1061 | <div class="custom_fields_below_signature"> |
993 | 1062 | <ul class="nolist">'; |
994 | 1063 | |
995 | - foreach ($message['custom_fields']['below_signature'] as $custom) |
|
996 | - echo ' |
|
1064 | + foreach ($message['custom_fields']['below_signature'] as $custom) { |
|
1065 | + echo ' |
|
997 | 1066 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
1067 | + } |
|
998 | 1068 | |
999 | 1069 | echo ' |
1000 | 1070 | </ul> |
@@ -1044,8 +1114,8 @@ discard block |
||
1044 | 1114 | <input type="hidden" name="seqnum" value="', $context['form_sequence_number'], '">'; |
1045 | 1115 | |
1046 | 1116 | // Guests just need more. |
1047 | - if ($context['user']['is_guest']) |
|
1048 | - echo ' |
|
1117 | + if ($context['user']['is_guest']) { |
|
1118 | + echo ' |
|
1049 | 1119 | <dl id="post_header"> |
1050 | 1120 | <dt> |
1051 | 1121 | ', $txt['name'], ': |
@@ -1060,6 +1130,7 @@ discard block |
||
1060 | 1130 | <input type="email" name="email" size="25" value="', $context['email'], '" tabindex="', $context['tabindex']++, '" required> |
1061 | 1131 | </dd> |
1062 | 1132 | </dl>'; |
1133 | + } |
|
1063 | 1134 | |
1064 | 1135 | echo ' |
1065 | 1136 | ', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message'), ' |
@@ -1084,12 +1155,13 @@ discard block |
||
1084 | 1155 | </script>'; |
1085 | 1156 | |
1086 | 1157 | // Is visual verification enabled? |
1087 | - if ($context['require_verification']) |
|
1088 | - echo ' |
|
1158 | + if ($context['require_verification']) { |
|
1159 | + echo ' |
|
1089 | 1160 | <div class="post_verification"> |
1090 | 1161 | <strong>', $txt['verification'], ':</strong> |
1091 | 1162 | ', template_control_verification($context['visual_verification_id'], 'all'), ' |
1092 | 1163 | </div>'; |
1164 | + } |
|
1093 | 1165 | |
1094 | 1166 | // Finally, the submit buttons. |
1095 | 1167 | echo ' |
@@ -1105,8 +1177,8 @@ discard block |
||
1105 | 1177 | <br class="clear">'; |
1106 | 1178 | |
1107 | 1179 | // Draft autosave available and the user has it enabled? |
1108 | - if (!empty($context['drafts_autosave'])) |
|
1109 | - echo ' |
|
1180 | + if (!empty($context['drafts_autosave'])) { |
|
1181 | + echo ' |
|
1110 | 1182 | <script> |
1111 | 1183 | var oDraftAutoSave = new smf_DraftAutoSave({ |
1112 | 1184 | sSelf: \'oDraftAutoSave\', |
@@ -1118,12 +1190,14 @@ discard block |
||
1118 | 1190 | iFreq: ', (empty($modSettings['masterAutoSaveDraftsDelay']) ? 60000 : $modSettings['masterAutoSaveDraftsDelay'] * 1000), ' |
1119 | 1191 | }); |
1120 | 1192 | </script>'; |
1193 | + } |
|
1121 | 1194 | |
1122 | - if ($context['show_spellchecking']) |
|
1123 | - echo ' |
|
1195 | + if ($context['show_spellchecking']) { |
|
1196 | + echo ' |
|
1124 | 1197 | <form action="', $scripturl, '?action=spellcheck" method="post" accept-charset="', $context['character_set'], '" name="spell_form" id="spell_form" target="spellWindow"> |
1125 | 1198 | <input type="hidden" name="spellstring" value=""> |
1126 | 1199 | </form>'; |
1200 | + } |
|
1127 | 1201 | |
1128 | 1202 | echo ' |
1129 | 1203 | <script> |
@@ -118,7 +118,7 @@ |
||
118 | 118 | |
119 | 119 | // Right, image not cached? Simply redirect, then. |
120 | 120 | if (!$response) |
121 | - redirectexit($request); |
|
121 | + redirectexit($request); |
|
122 | 122 | |
123 | 123 | // Make sure we're serving an image |
124 | 124 | $contentParts = explode('/', !empty($cached['content_type']) ? $cached['content_type'] : ''); |
@@ -63,26 +63,31 @@ discard block |
||
63 | 63 | */ |
64 | 64 | public function checkRequest() |
65 | 65 | { |
66 | - if (!$this->enabled) |
|
67 | - return false; |
|
66 | + if (!$this->enabled) { |
|
67 | + return false; |
|
68 | + } |
|
68 | 69 | |
69 | 70 | // Try to create the image cache directory if it doesn't exist |
70 | - if (!file_exists($this->cache)) |
|
71 | - if (!mkdir($this->cache) || !copy(dirname($this->cache) . '/index.php', $this->cache . '/index.php')) |
|
71 | + if (!file_exists($this->cache)) { |
|
72 | + if (!mkdir($this->cache) || !copy(dirname($this->cache) . '/index.php', $this->cache . '/index.php')) |
|
72 | 73 | return false; |
74 | + } |
|
73 | 75 | |
74 | - if (empty($_GET['hash']) || empty($_GET['request'])) |
|
75 | - return false; |
|
76 | + if (empty($_GET['hash']) || empty($_GET['request'])) { |
|
77 | + return false; |
|
78 | + } |
|
76 | 79 | |
77 | 80 | $hash = $_GET['hash']; |
78 | 81 | $request = $_GET['request']; |
79 | 82 | |
80 | - if (md5($request . $this->secret) != $hash) |
|
81 | - return false; |
|
83 | + if (md5($request . $this->secret) != $hash) { |
|
84 | + return false; |
|
85 | + } |
|
82 | 86 | |
83 | 87 | // Attempt to cache the request if it doesn't exist |
84 | - if (!$this->isCached($request)) |
|
85 | - return $this->cacheImage($request); |
|
88 | + if (!$this->isCached($request)) { |
|
89 | + return $this->cacheImage($request); |
|
90 | + } |
|
86 | 91 | |
87 | 92 | return true; |
88 | 93 | } |
@@ -111,19 +116,22 @@ discard block |
||
111 | 116 | if (!$cached || time() - $cached['time'] > (5 * 86400)) |
112 | 117 | { |
113 | 118 | @unlink($cached_file); |
114 | - if ($this->checkRequest()) |
|
115 | - $this->serve(); |
|
119 | + if ($this->checkRequest()) { |
|
120 | + $this->serve(); |
|
121 | + } |
|
116 | 122 | redirectexit($request); |
117 | 123 | } |
118 | 124 | |
119 | 125 | // Right, image not cached? Simply redirect, then. |
120 | - if (!$response) |
|
121 | - redirectexit($request); |
|
126 | + if (!$response) { |
|
127 | + redirectexit($request); |
|
128 | + } |
|
122 | 129 | |
123 | 130 | // Make sure we're serving an image |
124 | 131 | $contentParts = explode('/', !empty($cached['content_type']) ? $cached['content_type'] : ''); |
125 | - if ($contentParts[0] != 'image') |
|
126 | - exit; |
|
132 | + if ($contentParts[0] != 'image') { |
|
133 | + exit; |
|
134 | + } |
|
127 | 135 | |
128 | 136 | header('Content-type: ' . $cached['content_type']); |
129 | 137 | header('Content-length: ' . $cached['size']); |
@@ -170,8 +178,9 @@ discard block |
||
170 | 178 | $responseCode = $request->result('code'); |
171 | 179 | $response = $request->result(); |
172 | 180 | |
173 | - if (empty($response)) |
|
174 | - return false; |
|
181 | + if (empty($response)) { |
|
182 | + return false; |
|
183 | + } |
|
175 | 184 | |
176 | 185 | if ($responseCode != 200) { |
177 | 186 | return false; |
@@ -181,12 +190,14 @@ discard block |
||
181 | 190 | |
182 | 191 | // Make sure the url is returning an image |
183 | 192 | $contentParts = explode('/', !empty($headers['content-type']) ? $headers['content-type'] : ''); |
184 | - if ($contentParts[0] != 'image') |
|
185 | - return false; |
|
193 | + if ($contentParts[0] != 'image') { |
|
194 | + return false; |
|
195 | + } |
|
186 | 196 | |
187 | 197 | // Validate the filesize |
188 | - if ($response['size'] > ($this->maxSize * 1024)) |
|
189 | - return false; |
|
198 | + if ($response['size'] > ($this->maxSize * 1024)) { |
|
199 | + return false; |
|
200 | + } |
|
190 | 201 | |
191 | 202 | return file_put_contents($dest, json_encode(array( |
192 | 203 | 'content_type' => $headers['content-type'], |
@@ -28,7 +28,7 @@ discard block |
||
28 | 28 | * @param bool $single_file If true returns the contents of the file specified by destination if it exists |
29 | 29 | * @param bool $overwrite Whether to overwrite existing files |
30 | 30 | * @param null|array $files_to_extract Specific files to extract |
31 | - * @return array|false An array of information about extracted files or false on failure |
|
31 | + * @return string An array of information about extracted files or false on failure |
|
32 | 32 | */ |
33 | 33 | function read_tgz_file($gzfilename, $destination, $single_file = false, $overwrite = false, $files_to_extract = null) |
34 | 34 | { |
@@ -59,7 +59,7 @@ discard block |
||
59 | 59 | * @param bool $single_file Whether to only extract a single file |
60 | 60 | * @param bool $overwrite Whether to overwrite existing data |
61 | 61 | * @param null|array $files_to_extract If set, only extracts the specified files |
62 | - * @return array|false An array of information about the extracted files or false on failure |
|
62 | + * @return string An array of information about the extracted files or false on failure |
|
63 | 63 | */ |
64 | 64 | function read_tgz_data($gzfilename, $destination, $single_file = false, $overwrite = false, $files_to_extract = null) |
65 | 65 | { |
@@ -3255,7 +3255,7 @@ discard block |
||
3255 | 3255 | * https://php.net/crc32#79567 |
3256 | 3256 | * |
3257 | 3257 | * @param string $number |
3258 | - * @return string The crc32 |
|
3258 | + * @return integer The crc32 |
|
3259 | 3259 | */ |
3260 | 3260 | function smf_crc32($number) |
3261 | 3261 | { |
@@ -16,8 +16,9 @@ discard block |
||
16 | 16 | * @version 2.1 Beta 4 |
17 | 17 | */ |
18 | 18 | |
19 | -if (!defined('SMF')) |
|
19 | +if (!defined('SMF')) { |
|
20 | 20 | die('No direct access...'); |
21 | +} |
|
21 | 22 | |
22 | 23 | /** |
23 | 24 | * Reads a .tar.gz file, filename, in and extracts file(s) from it. |
@@ -67,47 +68,53 @@ discard block |
||
67 | 68 | loadLanguage('Packages'); |
68 | 69 | |
69 | 70 | // This function sorta needs gzinflate! |
70 | - if (!function_exists('gzinflate')) |
|
71 | - fatal_lang_error('package_no_zlib', 'critical'); |
|
71 | + if (!function_exists('gzinflate')) { |
|
72 | + fatal_lang_error('package_no_zlib', 'critical'); |
|
73 | + } |
|
72 | 74 | |
73 | 75 | if (substr($gzfilename, 0, 7) == 'http://' || substr($gzfilename, 0, 8) == 'https://') |
74 | 76 | { |
75 | 77 | $data = fetch_web_data($gzfilename); |
76 | 78 | |
77 | - if ($data === false) |
|
78 | - return false; |
|
79 | - } |
|
80 | - else |
|
79 | + if ($data === false) { |
|
80 | + return false; |
|
81 | + } |
|
82 | + } else |
|
81 | 83 | { |
82 | 84 | $data = @file_get_contents($gzfilename); |
83 | 85 | |
84 | - if ($data === false) |
|
85 | - return false; |
|
86 | + if ($data === false) { |
|
87 | + return false; |
|
88 | + } |
|
86 | 89 | } |
87 | 90 | |
88 | 91 | umask(0); |
89 | - if (!$single_file && $destination !== null && !file_exists($destination)) |
|
90 | - mktree($destination, 0777); |
|
92 | + if (!$single_file && $destination !== null && !file_exists($destination)) { |
|
93 | + mktree($destination, 0777); |
|
94 | + } |
|
91 | 95 | |
92 | 96 | // No signature? |
93 | - if (strlen($data) < 2) |
|
94 | - return false; |
|
97 | + if (strlen($data) < 2) { |
|
98 | + return false; |
|
99 | + } |
|
95 | 100 | |
96 | 101 | $id = unpack('H2a/H2b', substr($data, 0, 2)); |
97 | 102 | if (strtolower($id['a'] . $id['b']) != '1f8b') |
98 | 103 | { |
99 | 104 | // Okay, this ain't no tar.gz, but maybe it's a zip file. |
100 | - if (substr($data, 0, 2) == 'PK') |
|
101 | - return read_zip_file($gzfilename, $destination, $single_file, $overwrite, $files_to_extract); |
|
102 | - else |
|
103 | - return false; |
|
105 | + if (substr($data, 0, 2) == 'PK') { |
|
106 | + return read_zip_file($gzfilename, $destination, $single_file, $overwrite, $files_to_extract); |
|
107 | + } else { |
|
108 | + return false; |
|
109 | + } |
|
104 | 110 | } |
105 | 111 | |
106 | 112 | $flags = unpack('Ct/Cf', substr($data, 2, 2)); |
107 | 113 | |
108 | 114 | // Not deflate! |
109 | - if ($flags['t'] != 8) |
|
110 | - return false; |
|
115 | + if ($flags['t'] != 8) { |
|
116 | + return false; |
|
117 | + } |
|
111 | 118 | $flags = $flags['f']; |
112 | 119 | |
113 | 120 | $offset = 10; |
@@ -117,18 +124,21 @@ discard block |
||
117 | 124 | // @todo Might be mussed. |
118 | 125 | if ($flags & 12) |
119 | 126 | { |
120 | - while ($flags & 8 && $data{$offset++} != "\0") |
|
121 | - continue; |
|
122 | - while ($flags & 4 && $data{$offset++} != "\0") |
|
123 | - continue; |
|
127 | + while ($flags & 8 && $data{$offset++} != "\0") { |
|
128 | + continue; |
|
129 | + } |
|
130 | + while ($flags & 4 && $data{$offset++} != "\0") { |
|
131 | + continue; |
|
132 | + } |
|
124 | 133 | } |
125 | 134 | |
126 | 135 | $crc = unpack('Vcrc32/Visize', substr($data, strlen($data) - 8, 8)); |
127 | 136 | $data = @gzinflate(substr($data, $offset, strlen($data) - 8 - $offset)); |
128 | 137 | |
129 | 138 | // smf_crc32 and crc32 may not return the same results, so we accept either. |
130 | - if ($crc['crc32'] != smf_crc32($data) && $crc['crc32'] != crc32($data)) |
|
131 | - return false; |
|
139 | + if ($crc['crc32'] != smf_crc32($data) && $crc['crc32'] != crc32($data)) { |
|
140 | + return false; |
|
141 | + } |
|
132 | 142 | |
133 | 143 | $blocks = strlen($data) / 512 - 1; |
134 | 144 | $offset = 0; |
@@ -149,83 +159,98 @@ discard block |
||
149 | 159 | |
150 | 160 | foreach ($current as $k => $v) |
151 | 161 | { |
152 | - if (in_array($k, $octdec)) |
|
153 | - $current[$k] = octdec(trim($v)); |
|
154 | - else |
|
155 | - $current[$k] = trim($v); |
|
162 | + if (in_array($k, $octdec)) { |
|
163 | + $current[$k] = octdec(trim($v)); |
|
164 | + } else { |
|
165 | + $current[$k] = trim($v); |
|
166 | + } |
|
156 | 167 | } |
157 | 168 | |
158 | - if ($current['type'] == 5 && substr($current['filename'], -1) != '/') |
|
159 | - $current['filename'] .= '/'; |
|
169 | + if ($current['type'] == 5 && substr($current['filename'], -1) != '/') { |
|
170 | + $current['filename'] .= '/'; |
|
171 | + } |
|
160 | 172 | |
161 | 173 | $checksum = 256; |
162 | - for ($i = 0; $i < 148; $i++) |
|
163 | - $checksum += ord($header{$i}); |
|
164 | - for ($i = 156; $i < 512; $i++) |
|
165 | - $checksum += ord($header{$i}); |
|
174 | + for ($i = 0; $i < 148; $i++) { |
|
175 | + $checksum += ord($header{$i}); |
|
176 | + } |
|
177 | + for ($i = 156; $i < 512; $i++) { |
|
178 | + $checksum += ord($header{$i}); |
|
179 | + } |
|
166 | 180 | |
167 | - if ($current['checksum'] != $checksum) |
|
168 | - break; |
|
181 | + if ($current['checksum'] != $checksum) { |
|
182 | + break; |
|
183 | + } |
|
169 | 184 | |
170 | 185 | $size = ceil($current['size'] / 512); |
171 | 186 | $current['data'] = substr($data, ++$offset << 9, $current['size']); |
172 | 187 | $offset += $size; |
173 | 188 | |
174 | 189 | // Not a directory and doesn't exist already... |
175 | - if (substr($current['filename'], -1, 1) != '/' && !file_exists($destination . '/' . $current['filename'])) |
|
176 | - $write_this = true; |
|
190 | + if (substr($current['filename'], -1, 1) != '/' && !file_exists($destination . '/' . $current['filename'])) { |
|
191 | + $write_this = true; |
|
192 | + } |
|
177 | 193 | // File exists... check if it is newer. |
178 | - elseif (substr($current['filename'], -1, 1) != '/') |
|
179 | - $write_this = $overwrite || filemtime($destination . '/' . $current['filename']) < $current['mtime']; |
|
194 | + elseif (substr($current['filename'], -1, 1) != '/') { |
|
195 | + $write_this = $overwrite || filemtime($destination . '/' . $current['filename']) < $current['mtime']; |
|
196 | + } |
|
180 | 197 | // Folder... create. |
181 | 198 | elseif ($destination !== null && !$single_file) |
182 | 199 | { |
183 | 200 | // Protect from accidental parent directory writing... |
184 | 201 | $current['filename'] = strtr($current['filename'], array('../' => '', '/..' => '')); |
185 | 202 | |
186 | - if (!file_exists($destination . '/' . $current['filename'])) |
|
187 | - mktree($destination . '/' . $current['filename'], 0777); |
|
203 | + if (!file_exists($destination . '/' . $current['filename'])) { |
|
204 | + mktree($destination . '/' . $current['filename'], 0777); |
|
205 | + } |
|
188 | 206 | $write_this = false; |
207 | + } else { |
|
208 | + $write_this = false; |
|
189 | 209 | } |
190 | - else |
|
191 | - $write_this = false; |
|
192 | 210 | |
193 | 211 | if ($write_this && $destination !== null) |
194 | 212 | { |
195 | - if (strpos($current['filename'], '/') !== false && !$single_file) |
|
196 | - mktree($destination . '/' . dirname($current['filename']), 0777); |
|
213 | + if (strpos($current['filename'], '/') !== false && !$single_file) { |
|
214 | + mktree($destination . '/' . dirname($current['filename']), 0777); |
|
215 | + } |
|
197 | 216 | |
198 | 217 | // Is this the file we're looking for? |
199 | - if ($single_file && ($destination == $current['filename'] || $destination == '*/' . basename($current['filename']))) |
|
200 | - return $current['data']; |
|
218 | + if ($single_file && ($destination == $current['filename'] || $destination == '*/' . basename($current['filename']))) { |
|
219 | + return $current['data']; |
|
220 | + } |
|
201 | 221 | // If we're looking for another file, keep going. |
202 | - elseif ($single_file) |
|
203 | - continue; |
|
222 | + elseif ($single_file) { |
|
223 | + continue; |
|
224 | + } |
|
204 | 225 | // Looking for restricted files? |
205 | - elseif ($files_to_extract !== null && !in_array($current['filename'], $files_to_extract)) |
|
206 | - continue; |
|
226 | + elseif ($files_to_extract !== null && !in_array($current['filename'], $files_to_extract)) { |
|
227 | + continue; |
|
228 | + } |
|
207 | 229 | |
208 | 230 | package_put_contents($destination . '/' . $current['filename'], $current['data']); |
209 | 231 | } |
210 | 232 | |
211 | - if (substr($current['filename'], -1, 1) != '/') |
|
212 | - $return[] = array( |
|
233 | + if (substr($current['filename'], -1, 1) != '/') { |
|
234 | + $return[] = array( |
|
213 | 235 | 'filename' => $current['filename'], |
214 | 236 | 'md5' => md5($current['data']), |
215 | 237 | 'preview' => substr($current['data'], 0, 100), |
216 | 238 | 'size' => $current['size'], |
217 | 239 | 'skipped' => false |
218 | 240 | ); |
241 | + } |
|
219 | 242 | } |
220 | 243 | |
221 | - if ($destination !== null && !$single_file) |
|
222 | - package_flush_cache(); |
|
244 | + if ($destination !== null && !$single_file) { |
|
245 | + package_flush_cache(); |
|
246 | + } |
|
223 | 247 | |
224 | - if ($single_file) |
|
225 | - return false; |
|
226 | - else |
|
227 | - return $return; |
|
228 | -} |
|
248 | + if ($single_file) { |
|
249 | + return false; |
|
250 | + } else { |
|
251 | + return $return; |
|
252 | + } |
|
253 | + } |
|
229 | 254 | |
230 | 255 | /** |
231 | 256 | * Extract zip data. A functional copy of {@list read_zip_data()}. |
@@ -254,65 +279,74 @@ discard block |
||
254 | 279 | { |
255 | 280 | $i = $iterator->getSubPathname(); |
256 | 281 | // If this is a file, and it doesn't exist.... happy days! |
257 | - if (substr($i, -1) != '/' && !file_exists($destination . '/' . $i)) |
|
258 | - $write_this = true; |
|
282 | + if (substr($i, -1) != '/' && !file_exists($destination . '/' . $i)) { |
|
283 | + $write_this = true; |
|
284 | + } |
|
259 | 285 | // If the file exists, we may not want to overwrite it. |
260 | - elseif (substr($i, -1) != '/') |
|
261 | - $write_this = $overwrite; |
|
262 | - else |
|
263 | - $write_this = false; |
|
286 | + elseif (substr($i, -1) != '/') { |
|
287 | + $write_this = $overwrite; |
|
288 | + } else { |
|
289 | + $write_this = false; |
|
290 | + } |
|
264 | 291 | |
265 | 292 | // Get the actual compressed data. |
266 | - if (!$file_info->isDir()) |
|
267 | - $file_data = file_get_contents($file_info); |
|
268 | - elseif ($destination !== null && !$single_file) |
|
293 | + if (!$file_info->isDir()) { |
|
294 | + $file_data = file_get_contents($file_info); |
|
295 | + } elseif ($destination !== null && !$single_file) |
|
269 | 296 | { |
270 | 297 | // Folder... create. |
271 | - if (!file_exists($destination . '/' . $i)) |
|
272 | - mktree($destination . '/' . $i, 0777); |
|
298 | + if (!file_exists($destination . '/' . $i)) { |
|
299 | + mktree($destination . '/' . $i, 0777); |
|
300 | + } |
|
273 | 301 | $file_data = null; |
302 | + } else { |
|
303 | + $file_data = null; |
|
274 | 304 | } |
275 | - else |
|
276 | - $file_data = null; |
|
277 | 305 | |
278 | 306 | // Okay! We can write this file, looks good from here... |
279 | 307 | if ($write_this && $destination !== null) |
280 | 308 | { |
281 | - if (!$single_file && !is_dir($destination . '/' . dirname($i))) |
|
282 | - mktree($destination . '/' . dirname($i), 0777); |
|
309 | + if (!$single_file && !is_dir($destination . '/' . dirname($i))) { |
|
310 | + mktree($destination . '/' . dirname($i), 0777); |
|
311 | + } |
|
283 | 312 | |
284 | 313 | // If we're looking for a specific file, and this is it... ka-bam, baby. |
285 | - if ($single_file && ($destination == $i || $destination == '*/' . basename($i))) |
|
286 | - return $file_data; |
|
314 | + if ($single_file && ($destination == $i || $destination == '*/' . basename($i))) { |
|
315 | + return $file_data; |
|
316 | + } |
|
287 | 317 | // Oh? Another file. Fine. You don't like this file, do you? I know how it is. Yeah... just go away. No, don't apologize. I know this file's just not *good enough* for you. |
288 | - elseif ($single_file) |
|
289 | - continue; |
|
318 | + elseif ($single_file) { |
|
319 | + continue; |
|
320 | + } |
|
290 | 321 | // Don't really want this? |
291 | - elseif ($files_to_extract !== null && !in_array($i, $files_to_extract)) |
|
292 | - continue; |
|
322 | + elseif ($files_to_extract !== null && !in_array($i, $files_to_extract)) { |
|
323 | + continue; |
|
324 | + } |
|
293 | 325 | |
294 | 326 | package_put_contents($destination . '/' . $i, $file_data); |
295 | 327 | } |
296 | 328 | |
297 | - if (substr($i, -1, 1) != '/') |
|
298 | - $return[] = array( |
|
329 | + if (substr($i, -1, 1) != '/') { |
|
330 | + $return[] = array( |
|
299 | 331 | 'filename' => $i, |
300 | 332 | 'md5' => md5($file_data), |
301 | 333 | 'preview' => substr($file_data, 0, 100), |
302 | 334 | 'size' => strlen($file_data), |
303 | 335 | 'skipped' => false |
304 | 336 | ); |
337 | + } |
|
305 | 338 | } |
306 | 339 | |
307 | - if ($destination !== null && !$single_file) |
|
308 | - package_flush_cache(); |
|
340 | + if ($destination !== null && !$single_file) { |
|
341 | + package_flush_cache(); |
|
342 | + } |
|
309 | 343 | |
310 | - if ($single_file) |
|
311 | - return false; |
|
312 | - else |
|
313 | - return $return; |
|
314 | - } |
|
315 | - catch (Exception $e) |
|
344 | + if ($single_file) { |
|
345 | + return false; |
|
346 | + } else { |
|
347 | + return $return; |
|
348 | + } |
|
349 | + } catch (Exception $e) |
|
316 | 350 | { |
317 | 351 | return false; |
318 | 352 | } |
@@ -334,13 +368,15 @@ discard block |
||
334 | 368 | function read_zip_data($data, $destination, $single_file = false, $overwrite = false, $files_to_extract = null) |
335 | 369 | { |
336 | 370 | umask(0); |
337 | - if ($destination !== null && !file_exists($destination) && !$single_file) |
|
338 | - mktree($destination, 0777); |
|
371 | + if ($destination !== null && !file_exists($destination) && !$single_file) { |
|
372 | + mktree($destination, 0777); |
|
373 | + } |
|
339 | 374 | |
340 | 375 | // Look for the end of directory signature 0x06054b50 |
341 | 376 | $data_ecr = explode("\x50\x4b\x05\x06", $data); |
342 | - if (!isset($data_ecr[1])) |
|
343 | - return false; |
|
377 | + if (!isset($data_ecr[1])) { |
|
378 | + return false; |
|
379 | + } |
|
344 | 380 | |
345 | 381 | $return = array(); |
346 | 382 | |
@@ -355,8 +391,9 @@ discard block |
||
355 | 391 | array_shift($file_sections); |
356 | 392 | |
357 | 393 | // sections and count from the signature must match or the zip file is bad |
358 | - if (count($file_sections) != $zip_info['files']) |
|
359 | - return false; |
|
394 | + if (count($file_sections) != $zip_info['files']) { |
|
395 | + return false; |
|
396 | + } |
|
360 | 397 | |
361 | 398 | // go though each file in the archive |
362 | 399 | foreach ($file_sections as $data) |
@@ -378,68 +415,79 @@ discard block |
||
378 | 415 | } |
379 | 416 | |
380 | 417 | // If this is a file, and it doesn't exist.... happy days! |
381 | - if (substr($file_info['filename'], -1) != '/' && !file_exists($destination . '/' . $file_info['filename'])) |
|
382 | - $write_this = true; |
|
418 | + if (substr($file_info['filename'], -1) != '/' && !file_exists($destination . '/' . $file_info['filename'])) { |
|
419 | + $write_this = true; |
|
420 | + } |
|
383 | 421 | // If the file exists, we may not want to overwrite it. |
384 | - elseif (substr($file_info['filename'], -1) != '/') |
|
385 | - $write_this = $overwrite; |
|
422 | + elseif (substr($file_info['filename'], -1) != '/') { |
|
423 | + $write_this = $overwrite; |
|
424 | + } |
|
386 | 425 | // This is a directory, so we're gonna want to create it. (probably...) |
387 | 426 | elseif ($destination !== null && !$single_file) |
388 | 427 | { |
389 | 428 | // Just a little accident prevention, don't mind me. |
390 | 429 | $file_info['filename'] = strtr($file_info['filename'], array('../' => '', '/..' => '')); |
391 | 430 | |
392 | - if (!file_exists($destination . '/' . $file_info['filename'])) |
|
393 | - mktree($destination . '/' . $file_info['filename'], 0777); |
|
431 | + if (!file_exists($destination . '/' . $file_info['filename'])) { |
|
432 | + mktree($destination . '/' . $file_info['filename'], 0777); |
|
433 | + } |
|
394 | 434 | $write_this = false; |
435 | + } else { |
|
436 | + $write_this = false; |
|
395 | 437 | } |
396 | - else |
|
397 | - $write_this = false; |
|
398 | 438 | |
399 | 439 | // Get the actual compressed data. |
400 | 440 | $file_info['data'] = substr($data, 26 + $file_info['filename_length'] + $file_info['extrafield_length']); |
401 | 441 | |
402 | 442 | // Only inflate it if we need to ;) |
403 | - if (!empty($file_info['compress_method']) || ($file_info['compressed_size'] != $file_info['size'])) |
|
404 | - $file_info['data'] = gzinflate($file_info['data']); |
|
443 | + if (!empty($file_info['compress_method']) || ($file_info['compressed_size'] != $file_info['size'])) { |
|
444 | + $file_info['data'] = gzinflate($file_info['data']); |
|
445 | + } |
|
405 | 446 | |
406 | 447 | // Okay! We can write this file, looks good from here... |
407 | 448 | if ($write_this && $destination !== null) |
408 | 449 | { |
409 | - if ((strpos($file_info['filename'], '/') !== false && !$single_file) || (!$single_file && !is_dir($file_info['dir']))) |
|
410 | - mktree($file_info['dir'], 0777); |
|
450 | + if ((strpos($file_info['filename'], '/') !== false && !$single_file) || (!$single_file && !is_dir($file_info['dir']))) { |
|
451 | + mktree($file_info['dir'], 0777); |
|
452 | + } |
|
411 | 453 | |
412 | 454 | // If we're looking for a specific file, and this is it... ka-bam, baby. |
413 | - if ($single_file && ($destination == $file_info['filename'] || $destination == '*/' . basename($file_info['filename']))) |
|
414 | - return $file_info['data']; |
|
455 | + if ($single_file && ($destination == $file_info['filename'] || $destination == '*/' . basename($file_info['filename']))) { |
|
456 | + return $file_info['data']; |
|
457 | + } |
|
415 | 458 | // Oh? Another file. Fine. You don't like this file, do you? I know how it is. Yeah... just go away. No, don't apologize. I know this file's just not *good enough* for you. |
416 | - elseif ($single_file) |
|
417 | - continue; |
|
459 | + elseif ($single_file) { |
|
460 | + continue; |
|
461 | + } |
|
418 | 462 | // Don't really want this? |
419 | - elseif ($files_to_extract !== null && !in_array($file_info['filename'], $files_to_extract)) |
|
420 | - continue; |
|
463 | + elseif ($files_to_extract !== null && !in_array($file_info['filename'], $files_to_extract)) { |
|
464 | + continue; |
|
465 | + } |
|
421 | 466 | |
422 | 467 | package_put_contents($destination . '/' . $file_info['filename'], $file_info['data']); |
423 | 468 | } |
424 | 469 | |
425 | - if (substr($file_info['filename'], -1, 1) != '/') |
|
426 | - $return[] = array( |
|
470 | + if (substr($file_info['filename'], -1, 1) != '/') { |
|
471 | + $return[] = array( |
|
427 | 472 | 'filename' => $file_info['filename'], |
428 | 473 | 'md5' => md5($file_info['data']), |
429 | 474 | 'preview' => substr($file_info['data'], 0, 100), |
430 | 475 | 'size' => $file_info['size'], |
431 | 476 | 'skipped' => false |
432 | 477 | ); |
478 | + } |
|
433 | 479 | } |
434 | 480 | |
435 | - if ($destination !== null && !$single_file) |
|
436 | - package_flush_cache(); |
|
481 | + if ($destination !== null && !$single_file) { |
|
482 | + package_flush_cache(); |
|
483 | + } |
|
437 | 484 | |
438 | - if ($single_file) |
|
439 | - return false; |
|
440 | - else |
|
441 | - return $return; |
|
442 | -} |
|
485 | + if ($single_file) { |
|
486 | + return false; |
|
487 | + } else { |
|
488 | + return $return; |
|
489 | + } |
|
490 | + } |
|
443 | 491 | |
444 | 492 | /** |
445 | 493 | * Checks the existence of a remote file since file_exists() does not do remote. |
@@ -451,14 +499,16 @@ discard block |
||
451 | 499 | { |
452 | 500 | $a_url = parse_url($url); |
453 | 501 | |
454 | - if (!isset($a_url['scheme'])) |
|
455 | - return false; |
|
502 | + if (!isset($a_url['scheme'])) { |
|
503 | + return false; |
|
504 | + } |
|
456 | 505 | |
457 | 506 | // Attempt to connect... |
458 | 507 | $temp = ''; |
459 | 508 | $fid = fsockopen($a_url['host'], !isset($a_url['port']) ? 80 : $a_url['port'], $temp, $temp, 8); |
460 | - if (!$fid) |
|
461 | - return false; |
|
509 | + if (!$fid) { |
|
510 | + return false; |
|
511 | + } |
|
462 | 512 | |
463 | 513 | fputs($fid, 'HEAD ' . $a_url['path'] . ' HTTP/1.0' . "\r\n" . 'Host: ' . $a_url['host'] . "\r\n\r\n"); |
464 | 514 | $head = fread($fid, 1024); |
@@ -493,8 +543,9 @@ discard block |
||
493 | 543 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
494 | 544 | { |
495 | 545 | // Already found this? If so don't add it twice! |
496 | - if (in_array($row['package_id'], $found)) |
|
497 | - continue; |
|
546 | + if (in_array($row['package_id'], $found)) { |
|
547 | + continue; |
|
548 | + } |
|
498 | 549 | |
499 | 550 | $found[] = $row['package_id']; |
500 | 551 | |
@@ -529,19 +580,21 @@ discard block |
||
529 | 580 | global $sourcedir, $packagesdir; |
530 | 581 | |
531 | 582 | // Extract package-info.xml from downloaded file. (*/ is used because it could be in any directory.) |
532 | - if (strpos($gzfilename, 'http://') !== false || strpos($gzfilename, 'https://') !== false) |
|
533 | - $packageInfo = read_tgz_data($gzfilename, 'package-info.xml', true); |
|
534 | - else |
|
583 | + if (strpos($gzfilename, 'http://') !== false || strpos($gzfilename, 'https://') !== false) { |
|
584 | + $packageInfo = read_tgz_data($gzfilename, 'package-info.xml', true); |
|
585 | + } else |
|
535 | 586 | { |
536 | - if (!file_exists($packagesdir . '/' . $gzfilename)) |
|
537 | - return 'package_get_error_not_found'; |
|
587 | + if (!file_exists($packagesdir . '/' . $gzfilename)) { |
|
588 | + return 'package_get_error_not_found'; |
|
589 | + } |
|
538 | 590 | |
539 | - if (is_file($packagesdir . '/' . $gzfilename)) |
|
540 | - $packageInfo = read_tgz_file($packagesdir . '/' . $gzfilename, '*/package-info.xml', true); |
|
541 | - elseif (file_exists($packagesdir . '/' . $gzfilename . '/package-info.xml')) |
|
542 | - $packageInfo = file_get_contents($packagesdir . '/' . $gzfilename . '/package-info.xml'); |
|
543 | - else |
|
544 | - return 'package_get_error_missing_xml'; |
|
591 | + if (is_file($packagesdir . '/' . $gzfilename)) { |
|
592 | + $packageInfo = read_tgz_file($packagesdir . '/' . $gzfilename, '*/package-info.xml', true); |
|
593 | + } elseif (file_exists($packagesdir . '/' . $gzfilename . '/package-info.xml')) { |
|
594 | + $packageInfo = file_get_contents($packagesdir . '/' . $gzfilename . '/package-info.xml'); |
|
595 | + } else { |
|
596 | + return 'package_get_error_missing_xml'; |
|
597 | + } |
|
545 | 598 | } |
546 | 599 | |
547 | 600 | // Nothing? |
@@ -549,10 +602,11 @@ discard block |
||
549 | 602 | { |
550 | 603 | // Perhaps they are trying to install a theme, lets tell them nicely this is the wrong function |
551 | 604 | $packageInfo = read_tgz_file($packagesdir . '/' . $gzfilename, '*/theme_info.xml', true); |
552 | - if (!empty($packageInfo)) |
|
553 | - return 'package_get_error_is_theme'; |
|
554 | - else |
|
555 | - return 'package_get_error_is_zero'; |
|
605 | + if (!empty($packageInfo)) { |
|
606 | + return 'package_get_error_is_theme'; |
|
607 | + } else { |
|
608 | + return 'package_get_error_is_zero'; |
|
609 | + } |
|
556 | 610 | } |
557 | 611 | |
558 | 612 | // Parse package-info.xml into an xmlArray. |
@@ -560,8 +614,9 @@ discard block |
||
560 | 614 | $packageInfo = new xmlArray($packageInfo); |
561 | 615 | |
562 | 616 | // @todo Error message of some sort? |
563 | - if (!$packageInfo->exists('package-info[0]')) |
|
564 | - return 'package_get_error_packageinfo_corrupt'; |
|
617 | + if (!$packageInfo->exists('package-info[0]')) { |
|
618 | + return 'package_get_error_packageinfo_corrupt'; |
|
619 | + } |
|
565 | 620 | |
566 | 621 | $packageInfo = $packageInfo->path('package-info[0]'); |
567 | 622 | |
@@ -580,8 +635,9 @@ discard block |
||
580 | 635 | } |
581 | 636 | } |
582 | 637 | |
583 | - if (!isset($package['type'])) |
|
584 | - $package['type'] = 'modification'; |
|
638 | + if (!isset($package['type'])) { |
|
639 | + $package['type'] = 'modification'; |
|
640 | + } |
|
585 | 641 | |
586 | 642 | return $package; |
587 | 643 | } |
@@ -634,15 +690,14 @@ discard block |
||
634 | 690 | { |
635 | 691 | $ftp_file = strtr($file, array($_SESSION['pack_ftp']['root'] => '')); |
636 | 692 | $package_ftp->chmod($ftp_file, $perms); |
693 | + } else { |
|
694 | + smf_chmod($file, $perms); |
|
637 | 695 | } |
638 | - else |
|
639 | - smf_chmod($file, $perms); |
|
640 | 696 | |
641 | 697 | $new_permissions = @fileperms($file); |
642 | 698 | $result = $new_permissions == $perms ? 'success' : 'failure'; |
643 | 699 | unset($_SESSION['pack_ftp']['original_perms'][$file]); |
644 | - } |
|
645 | - elseif ($do_change) |
|
700 | + } elseif ($do_change) |
|
646 | 701 | { |
647 | 702 | $new_permissions = ''; |
648 | 703 | $result = 'skipped'; |
@@ -758,8 +813,7 @@ discard block |
||
758 | 813 | |
759 | 814 | $context['sub_template'] = 'show_list'; |
760 | 815 | $context['default_list'] = 'restore_file_permissions'; |
761 | - } |
|
762 | - else |
|
816 | + } else |
|
763 | 817 | { |
764 | 818 | unset($listOptions['columns']['result']); |
765 | 819 | } |
@@ -769,12 +823,14 @@ discard block |
||
769 | 823 | createList($listOptions); |
770 | 824 | |
771 | 825 | // If we just restored permissions then whereever we are, we are now done and dusted. |
772 | - if (!empty($_POST['restore_perms'])) |
|
773 | - obExit(); |
|
826 | + if (!empty($_POST['restore_perms'])) { |
|
827 | + obExit(); |
|
828 | + } |
|
774 | 829 | } |
775 | 830 | // Otherwise, it's entirely irrelevant? |
776 | - elseif ($restore_write_status) |
|
777 | - return true; |
|
831 | + elseif ($restore_write_status) { |
|
832 | + return true; |
|
833 | + } |
|
778 | 834 | |
779 | 835 | // This is where we report what we got up to. |
780 | 836 | $return_data = array( |
@@ -812,11 +868,12 @@ discard block |
||
812 | 868 | if (!in_array($_POST['ftp_path'], array('', '/'))) |
813 | 869 | { |
814 | 870 | $ftp_root = strtr($boarddir, array($_POST['ftp_path'] => '')); |
815 | - if (substr($ftp_root, -1) == '/' && ($_POST['ftp_path'] == '' || substr($_POST['ftp_path'], 0, 1) == '/')) |
|
816 | - $ftp_root = substr($ftp_root, 0, -1); |
|
871 | + if (substr($ftp_root, -1) == '/' && ($_POST['ftp_path'] == '' || substr($_POST['ftp_path'], 0, 1) == '/')) { |
|
872 | + $ftp_root = substr($ftp_root, 0, -1); |
|
873 | + } |
|
874 | + } else { |
|
875 | + $ftp_root = $boarddir; |
|
817 | 876 | } |
818 | - else |
|
819 | - $ftp_root = $boarddir; |
|
820 | 877 | |
821 | 878 | $_SESSION['pack_ftp'] = array( |
822 | 879 | 'server' => $_POST['ftp_server'], |
@@ -828,8 +885,9 @@ discard block |
||
828 | 885 | 'connected' => true, |
829 | 886 | ); |
830 | 887 | |
831 | - if (!isset($modSettings['package_path']) || $modSettings['package_path'] != $_POST['ftp_path']) |
|
832 | - updateSettings(array('package_path' => $_POST['ftp_path'])); |
|
888 | + if (!isset($modSettings['package_path']) || $modSettings['package_path'] != $_POST['ftp_path']) { |
|
889 | + updateSettings(array('package_path' => $_POST['ftp_path'])); |
|
890 | + } |
|
833 | 891 | |
834 | 892 | // This is now the primary connection. |
835 | 893 | $package_ftp = $ftp; |
@@ -842,12 +900,13 @@ discard block |
||
842 | 900 | foreach ($chmodFiles as $k => $file) |
843 | 901 | { |
844 | 902 | // Sometimes this can somehow happen maybe? |
845 | - if (empty($file)) |
|
846 | - unset($chmodFiles[$k]); |
|
903 | + if (empty($file)) { |
|
904 | + unset($chmodFiles[$k]); |
|
905 | + } |
|
847 | 906 | // Already writable? |
848 | - elseif (@is_writable($file)) |
|
849 | - $return_data['files']['writable'][] = $file; |
|
850 | - else |
|
907 | + elseif (@is_writable($file)) { |
|
908 | + $return_data['files']['writable'][] = $file; |
|
909 | + } else |
|
851 | 910 | { |
852 | 911 | // Now try to change that. |
853 | 912 | $return_data['files'][package_chmod($file, 'writable', true) ? 'writable' : 'notwritable'][] = $file; |
@@ -864,19 +923,21 @@ discard block |
||
864 | 923 | { |
865 | 924 | require_once($sourcedir . '/Class-Package.php'); |
866 | 925 | $ftp = new ftp_connection(null); |
926 | + } elseif ($ftp->error !== false && !isset($ftp_error)) { |
|
927 | + $ftp_error = $ftp->last_message === null ? '' : $ftp->last_message; |
|
867 | 928 | } |
868 | - elseif ($ftp->error !== false && !isset($ftp_error)) |
|
869 | - $ftp_error = $ftp->last_message === null ? '' : $ftp->last_message; |
|
870 | 929 | |
871 | 930 | list ($username, $detect_path, $found_path) = $ftp->detect_path($boarddir); |
872 | 931 | |
873 | - if ($found_path) |
|
874 | - $_POST['ftp_path'] = $detect_path; |
|
875 | - elseif (!isset($_POST['ftp_path'])) |
|
876 | - $_POST['ftp_path'] = isset($modSettings['package_path']) ? $modSettings['package_path'] : $detect_path; |
|
932 | + if ($found_path) { |
|
933 | + $_POST['ftp_path'] = $detect_path; |
|
934 | + } elseif (!isset($_POST['ftp_path'])) { |
|
935 | + $_POST['ftp_path'] = isset($modSettings['package_path']) ? $modSettings['package_path'] : $detect_path; |
|
936 | + } |
|
877 | 937 | |
878 | - if (!isset($_POST['ftp_username'])) |
|
879 | - $_POST['ftp_username'] = $username; |
|
938 | + if (!isset($_POST['ftp_username'])) { |
|
939 | + $_POST['ftp_username'] = $username; |
|
940 | + } |
|
880 | 941 | } |
881 | 942 | |
882 | 943 | $context['package_ftp'] = array( |
@@ -889,8 +950,9 @@ discard block |
||
889 | 950 | ); |
890 | 951 | |
891 | 952 | // Which files failed? |
892 | - if (!isset($context['notwritable_files'])) |
|
893 | - $context['notwritable_files'] = array(); |
|
953 | + if (!isset($context['notwritable_files'])) { |
|
954 | + $context['notwritable_files'] = array(); |
|
955 | + } |
|
894 | 956 | $context['notwritable_files'] = array_merge($context['notwritable_files'], $return_data['files']['notwritable']); |
895 | 957 | |
896 | 958 | // Sent here to die? |
@@ -923,40 +985,48 @@ discard block |
||
923 | 985 | foreach ($files as $k => $file) |
924 | 986 | { |
925 | 987 | // If this file doesn't exist, then we actually want to look at the directory, no? |
926 | - if (!file_exists($file)) |
|
927 | - $file = dirname($file); |
|
988 | + if (!file_exists($file)) { |
|
989 | + $file = dirname($file); |
|
990 | + } |
|
928 | 991 | |
929 | 992 | // This looks odd, but it's an attempt to work around PHP suExec. |
930 | - if (!@is_writable($file)) |
|
931 | - smf_chmod($file, 0755); |
|
932 | - if (!@is_writable($file)) |
|
933 | - smf_chmod($file, 0777); |
|
934 | - if (!@is_writable(dirname($file))) |
|
935 | - smf_chmod($file, 0755); |
|
936 | - if (!@is_writable(dirname($file))) |
|
937 | - smf_chmod($file, 0777); |
|
993 | + if (!@is_writable($file)) { |
|
994 | + smf_chmod($file, 0755); |
|
995 | + } |
|
996 | + if (!@is_writable($file)) { |
|
997 | + smf_chmod($file, 0777); |
|
998 | + } |
|
999 | + if (!@is_writable(dirname($file))) { |
|
1000 | + smf_chmod($file, 0755); |
|
1001 | + } |
|
1002 | + if (!@is_writable(dirname($file))) { |
|
1003 | + smf_chmod($file, 0777); |
|
1004 | + } |
|
938 | 1005 | |
939 | 1006 | $fp = is_dir($file) ? @opendir($file) : @fopen($file, 'rb'); |
940 | 1007 | if (@is_writable($file) && $fp) |
941 | 1008 | { |
942 | 1009 | unset($files[$k]); |
943 | - if (!is_dir($file)) |
|
944 | - fclose($fp); |
|
945 | - else |
|
946 | - closedir($fp); |
|
1010 | + if (!is_dir($file)) { |
|
1011 | + fclose($fp); |
|
1012 | + } else { |
|
1013 | + closedir($fp); |
|
1014 | + } |
|
947 | 1015 | } |
948 | 1016 | } |
949 | 1017 | |
950 | 1018 | // No FTP required! |
951 | - if (empty($files)) |
|
952 | - return array(); |
|
1019 | + if (empty($files)) { |
|
1020 | + return array(); |
|
1021 | + } |
|
953 | 1022 | } |
954 | 1023 | |
955 | 1024 | // They've opted to not use FTP, and try anyway. |
956 | 1025 | if (isset($_SESSION['pack_ftp']) && $_SESSION['pack_ftp'] == false) |
957 | 1026 | { |
958 | - if ($files === null) |
|
959 | - return array(); |
|
1027 | + if ($files === null) { |
|
1028 | + return array(); |
|
1029 | + } |
|
960 | 1030 | |
961 | 1031 | foreach ($files as $k => $file) |
962 | 1032 | { |
@@ -968,26 +1038,29 @@ discard block |
||
968 | 1038 | smf_chmod($file, 0755); |
969 | 1039 | } |
970 | 1040 | |
971 | - if (!@is_writable($file)) |
|
972 | - smf_chmod($file, 0777); |
|
973 | - if (!@is_writable(dirname($file))) |
|
974 | - smf_chmod(dirname($file), 0777); |
|
1041 | + if (!@is_writable($file)) { |
|
1042 | + smf_chmod($file, 0777); |
|
1043 | + } |
|
1044 | + if (!@is_writable(dirname($file))) { |
|
1045 | + smf_chmod(dirname($file), 0777); |
|
1046 | + } |
|
975 | 1047 | |
976 | - if (@is_writable($file)) |
|
977 | - unset($files[$k]); |
|
1048 | + if (@is_writable($file)) { |
|
1049 | + unset($files[$k]); |
|
1050 | + } |
|
978 | 1051 | } |
979 | 1052 | |
980 | 1053 | return $files; |
981 | - } |
|
982 | - elseif (isset($_SESSION['pack_ftp'])) |
|
1054 | + } elseif (isset($_SESSION['pack_ftp'])) |
|
983 | 1055 | { |
984 | 1056 | // Load the file containing the ftp_connection class. |
985 | 1057 | require_once($sourcedir . '/Class-Package.php'); |
986 | 1058 | |
987 | 1059 | $package_ftp = new ftp_connection($_SESSION['pack_ftp']['server'], $_SESSION['pack_ftp']['port'], $_SESSION['pack_ftp']['username'], package_crypt($_SESSION['pack_ftp']['password'])); |
988 | 1060 | |
989 | - if ($files === null) |
|
990 | - return array(); |
|
1061 | + if ($files === null) { |
|
1062 | + return array(); |
|
1063 | + } |
|
991 | 1064 | |
992 | 1065 | foreach ($files as $k => $file) |
993 | 1066 | { |
@@ -1001,13 +1074,16 @@ discard block |
||
1001 | 1074 | $package_ftp->chmod($ftp_file, 0755); |
1002 | 1075 | } |
1003 | 1076 | |
1004 | - if (!@is_writable($file)) |
|
1005 | - $package_ftp->chmod($ftp_file, 0777); |
|
1006 | - if (!@is_writable(dirname($file))) |
|
1007 | - $package_ftp->chmod(dirname($ftp_file), 0777); |
|
1077 | + if (!@is_writable($file)) { |
|
1078 | + $package_ftp->chmod($ftp_file, 0777); |
|
1079 | + } |
|
1080 | + if (!@is_writable(dirname($file))) { |
|
1081 | + $package_ftp->chmod(dirname($ftp_file), 0777); |
|
1082 | + } |
|
1008 | 1083 | |
1009 | - if (@is_writable($file)) |
|
1010 | - unset($files[$k]); |
|
1084 | + if (@is_writable($file)) { |
|
1085 | + unset($files[$k]); |
|
1086 | + } |
|
1011 | 1087 | } |
1012 | 1088 | |
1013 | 1089 | return $files; |
@@ -1019,8 +1095,7 @@ discard block |
||
1019 | 1095 | |
1020 | 1096 | $files = packageRequireFTP($destination_url, $files, $return); |
1021 | 1097 | return $files; |
1022 | - } |
|
1023 | - elseif (isset($_POST['ftp_username'])) |
|
1098 | + } elseif (isset($_POST['ftp_username'])) |
|
1024 | 1099 | { |
1025 | 1100 | require_once($sourcedir . '/Class-Package.php'); |
1026 | 1101 | $ftp = new ftp_connection($_POST['ftp_server'], $_POST['ftp_port'], $_POST['ftp_username'], $_POST['ftp_password']); |
@@ -1042,19 +1117,21 @@ discard block |
||
1042 | 1117 | { |
1043 | 1118 | require_once($sourcedir . '/Class-Package.php'); |
1044 | 1119 | $ftp = new ftp_connection(null); |
1120 | + } elseif ($ftp->error !== false && !isset($ftp_error)) { |
|
1121 | + $ftp_error = $ftp->last_message === null ? '' : $ftp->last_message; |
|
1045 | 1122 | } |
1046 | - elseif ($ftp->error !== false && !isset($ftp_error)) |
|
1047 | - $ftp_error = $ftp->last_message === null ? '' : $ftp->last_message; |
|
1048 | 1123 | |
1049 | 1124 | list ($username, $detect_path, $found_path) = $ftp->detect_path($boarddir); |
1050 | 1125 | |
1051 | - if ($found_path) |
|
1052 | - $_POST['ftp_path'] = $detect_path; |
|
1053 | - elseif (!isset($_POST['ftp_path'])) |
|
1054 | - $_POST['ftp_path'] = isset($modSettings['package_path']) ? $modSettings['package_path'] : $detect_path; |
|
1126 | + if ($found_path) { |
|
1127 | + $_POST['ftp_path'] = $detect_path; |
|
1128 | + } elseif (!isset($_POST['ftp_path'])) { |
|
1129 | + $_POST['ftp_path'] = isset($modSettings['package_path']) ? $modSettings['package_path'] : $detect_path; |
|
1130 | + } |
|
1055 | 1131 | |
1056 | - if (!isset($_POST['ftp_username'])) |
|
1057 | - $_POST['ftp_username'] = $username; |
|
1132 | + if (!isset($_POST['ftp_username'])) { |
|
1133 | + $_POST['ftp_username'] = $username; |
|
1134 | + } |
|
1058 | 1135 | |
1059 | 1136 | $context['package_ftp'] = array( |
1060 | 1137 | 'server' => isset($_POST['ftp_server']) ? $_POST['ftp_server'] : (isset($modSettings['package_server']) ? $modSettings['package_server'] : 'localhost'), |
@@ -1066,23 +1143,24 @@ discard block |
||
1066 | 1143 | ); |
1067 | 1144 | |
1068 | 1145 | // If we're returning dump out here. |
1069 | - if ($return) |
|
1070 | - return $files; |
|
1146 | + if ($return) { |
|
1147 | + return $files; |
|
1148 | + } |
|
1071 | 1149 | |
1072 | 1150 | $context['page_title'] = $txt['package_ftp_necessary']; |
1073 | 1151 | $context['sub_template'] = 'ftp_required'; |
1074 | 1152 | obExit(); |
1075 | - } |
|
1076 | - else |
|
1153 | + } else |
|
1077 | 1154 | { |
1078 | 1155 | if (!in_array($_POST['ftp_path'], array('', '/'))) |
1079 | 1156 | { |
1080 | 1157 | $ftp_root = strtr($boarddir, array($_POST['ftp_path'] => '')); |
1081 | - if (substr($ftp_root, -1) == '/' && ($_POST['ftp_path'] == '' || $_POST['ftp_path'][0] == '/')) |
|
1082 | - $ftp_root = substr($ftp_root, 0, -1); |
|
1158 | + if (substr($ftp_root, -1) == '/' && ($_POST['ftp_path'] == '' || $_POST['ftp_path'][0] == '/')) { |
|
1159 | + $ftp_root = substr($ftp_root, 0, -1); |
|
1160 | + } |
|
1161 | + } else { |
|
1162 | + $ftp_root = $boarddir; |
|
1083 | 1163 | } |
1084 | - else |
|
1085 | - $ftp_root = $boarddir; |
|
1086 | 1164 | |
1087 | 1165 | $_SESSION['pack_ftp'] = array( |
1088 | 1166 | 'server' => $_POST['ftp_server'], |
@@ -1093,8 +1171,9 @@ discard block |
||
1093 | 1171 | 'root' => $ftp_root, |
1094 | 1172 | ); |
1095 | 1173 | |
1096 | - if (!isset($modSettings['package_path']) || $modSettings['package_path'] != $_POST['ftp_path']) |
|
1097 | - updateSettings(array('package_path' => $_POST['ftp_path'])); |
|
1174 | + if (!isset($modSettings['package_path']) || $modSettings['package_path'] != $_POST['ftp_path']) { |
|
1175 | + updateSettings(array('package_path' => $_POST['ftp_path'])); |
|
1176 | + } |
|
1098 | 1177 | |
1099 | 1178 | $files = packageRequireFTP($destination_url, $files, $return); |
1100 | 1179 | } |
@@ -1122,16 +1201,18 @@ discard block |
||
1122 | 1201 | global $packagesdir, $forum_version, $context, $temp_path, $language, $smcFunc; |
1123 | 1202 | |
1124 | 1203 | // Mayday! That action doesn't exist!! |
1125 | - if (empty($packageXML) || !$packageXML->exists($method)) |
|
1126 | - return array(); |
|
1204 | + if (empty($packageXML) || !$packageXML->exists($method)) { |
|
1205 | + return array(); |
|
1206 | + } |
|
1127 | 1207 | |
1128 | 1208 | // We haven't found the package script yet... |
1129 | 1209 | $script = false; |
1130 | 1210 | $the_version = strtr($forum_version, array('SMF ' => '')); |
1131 | 1211 | |
1132 | 1212 | // Emulation support... |
1133 | - if (!empty($_SESSION['version_emulate'])) |
|
1134 | - $the_version = $_SESSION['version_emulate']; |
|
1213 | + if (!empty($_SESSION['version_emulate'])) { |
|
1214 | + $the_version = $_SESSION['version_emulate']; |
|
1215 | + } |
|
1135 | 1216 | |
1136 | 1217 | // Single package emulation |
1137 | 1218 | if (!empty($_REQUEST['ve']) && !empty($_REQUEST['package'])) |
@@ -1139,8 +1220,9 @@ discard block |
||
1139 | 1220 | $the_version = $_REQUEST['ve']; |
1140 | 1221 | $_SESSION['single_version_emulate'][$_REQUEST['package']] = $the_version; |
1141 | 1222 | } |
1142 | - if (!empty($_REQUEST['package']) && (!empty($_SESSION['single_version_emulate'][$_REQUEST['package']]))) |
|
1143 | - $the_version = $_SESSION['single_version_emulate'][$_REQUEST['package']]; |
|
1223 | + if (!empty($_REQUEST['package']) && (!empty($_SESSION['single_version_emulate'][$_REQUEST['package']]))) { |
|
1224 | + $the_version = $_SESSION['single_version_emulate'][$_REQUEST['package']]; |
|
1225 | + } |
|
1144 | 1226 | |
1145 | 1227 | // Get all the versions of this method and find the right one. |
1146 | 1228 | $these_methods = $packageXML->set($method); |
@@ -1150,16 +1232,18 @@ discard block |
||
1150 | 1232 | if ($this_method->exists('@for')) |
1151 | 1233 | { |
1152 | 1234 | // Don't keep going if this won't work for this version of SMF. |
1153 | - if (!matchPackageVersion($the_version, $this_method->fetch('@for'))) |
|
1154 | - continue; |
|
1235 | + if (!matchPackageVersion($the_version, $this_method->fetch('@for'))) { |
|
1236 | + continue; |
|
1237 | + } |
|
1155 | 1238 | } |
1156 | 1239 | |
1157 | 1240 | // Upgrades may go from a certain old version of the mod. |
1158 | 1241 | if ($method == 'upgrade' && $this_method->exists('@from')) |
1159 | 1242 | { |
1160 | 1243 | // Well, this is for the wrong old version... |
1161 | - if (!matchPackageVersion($previous_version, $this_method->fetch('@from'))) |
|
1162 | - continue; |
|
1244 | + if (!matchPackageVersion($previous_version, $this_method->fetch('@from'))) { |
|
1245 | + continue; |
|
1246 | + } |
|
1163 | 1247 | } |
1164 | 1248 | |
1165 | 1249 | // We've found it! |
@@ -1168,8 +1252,9 @@ discard block |
||
1168 | 1252 | } |
1169 | 1253 | |
1170 | 1254 | // Bad news, a matching script wasn't found! |
1171 | - if (!($script instanceof xmlArray)) |
|
1172 | - return array(); |
|
1255 | + if (!($script instanceof xmlArray)) { |
|
1256 | + return array(); |
|
1257 | + } |
|
1173 | 1258 | |
1174 | 1259 | // Find all the actions in this method - in theory, these should only be allowed actions. (* means all.) |
1175 | 1260 | $actions = $script->set('*'); |
@@ -1198,12 +1283,12 @@ discard block |
||
1198 | 1283 | if ((isset($_REQUEST['readme']) && $action->fetch('@lang') == $_REQUEST['readme']) || (isset($_REQUEST['license']) && $action->fetch('@lang') == $_REQUEST['license']) || (!isset($_REQUEST['readme']) && $action->fetch('@lang') == $language) || (!isset($_REQUEST['license']) && $action->fetch('@lang') == $language)) |
1199 | 1284 | { |
1200 | 1285 | // In case the user put the blocks in the wrong order. |
1201 | - if (isset($context[$type]['selected']) && $context[$type]['selected'] == 'default') |
|
1202 | - $context[$type][] = 'default'; |
|
1286 | + if (isset($context[$type]['selected']) && $context[$type]['selected'] == 'default') { |
|
1287 | + $context[$type][] = 'default'; |
|
1288 | + } |
|
1203 | 1289 | |
1204 | 1290 | $context[$type]['selected'] = $smcFunc['htmlspecialchars']($action->fetch('@lang')); |
1205 | - } |
|
1206 | - else |
|
1291 | + } else |
|
1207 | 1292 | { |
1208 | 1293 | // We don't want this now, but we'll allow the user to select to read it. |
1209 | 1294 | $context[$type][] = $smcFunc['htmlspecialchars']($action->fetch('@lang')); |
@@ -1218,9 +1303,9 @@ discard block |
||
1218 | 1303 | { |
1219 | 1304 | $context[$type][] = 'default'; |
1220 | 1305 | continue; |
1306 | + } else { |
|
1307 | + $context[$type]['selected'] = 'default'; |
|
1221 | 1308 | } |
1222 | - else |
|
1223 | - $context[$type]['selected'] = 'default'; |
|
1224 | 1309 | } |
1225 | 1310 | } |
1226 | 1311 | |
@@ -1230,9 +1315,9 @@ discard block |
||
1230 | 1315 | $filename = $temp_path . '$auto_' . $temp_auto++ . (in_array($actionType, array('readme', 'redirect', 'license')) ? '.txt' : ($actionType == 'code' || $actionType == 'database' ? '.php' : '.mod')); |
1231 | 1316 | package_put_contents($filename, $action->fetch('.')); |
1232 | 1317 | $filename = strtr($filename, array($temp_path => '')); |
1318 | + } else { |
|
1319 | + $filename = $action->fetch('.'); |
|
1233 | 1320 | } |
1234 | - else |
|
1235 | - $filename = $action->fetch('.'); |
|
1236 | 1321 | |
1237 | 1322 | $return[] = array( |
1238 | 1323 | 'type' => $actionType, |
@@ -1247,8 +1332,7 @@ discard block |
||
1247 | 1332 | ); |
1248 | 1333 | |
1249 | 1334 | continue; |
1250 | - } |
|
1251 | - elseif ($actionType == 'hook') |
|
1335 | + } elseif ($actionType == 'hook') |
|
1252 | 1336 | { |
1253 | 1337 | $return[] = array( |
1254 | 1338 | 'type' => $actionType, |
@@ -1260,16 +1344,16 @@ discard block |
||
1260 | 1344 | 'description' => '', |
1261 | 1345 | ); |
1262 | 1346 | continue; |
1263 | - } |
|
1264 | - elseif ($actionType == 'credits') |
|
1347 | + } elseif ($actionType == 'credits') |
|
1265 | 1348 | { |
1266 | 1349 | // quick check of any supplied url |
1267 | 1350 | $url = $action->exists('@url') ? $action->fetch('@url') : ''; |
1268 | 1351 | if (strlen(trim($url)) > 0 && substr($url, 0, 7) !== 'http://' && substr($url, 0, 8) !== 'https://') |
1269 | 1352 | { |
1270 | 1353 | $url = 'http://' . $url; |
1271 | - if (strlen($url) < 8 || (substr($url, 0, 7) !== 'http://' && substr($url, 0, 8) !== 'https://')) |
|
1272 | - $url = ''; |
|
1354 | + if (strlen($url) < 8 || (substr($url, 0, 7) !== 'http://' && substr($url, 0, 8) !== 'https://')) { |
|
1355 | + $url = ''; |
|
1356 | + } |
|
1273 | 1357 | } |
1274 | 1358 | |
1275 | 1359 | $return[] = array( |
@@ -1281,8 +1365,7 @@ discard block |
||
1281 | 1365 | 'title' => $action->fetch('.'), |
1282 | 1366 | ); |
1283 | 1367 | continue; |
1284 | - } |
|
1285 | - elseif ($actionType == 'requires') |
|
1368 | + } elseif ($actionType == 'requires') |
|
1286 | 1369 | { |
1287 | 1370 | $return[] = array( |
1288 | 1371 | 'type' => $actionType, |
@@ -1291,14 +1374,12 @@ discard block |
||
1291 | 1374 | 'description' => '', |
1292 | 1375 | ); |
1293 | 1376 | continue; |
1294 | - } |
|
1295 | - elseif ($actionType == 'error') |
|
1377 | + } elseif ($actionType == 'error') |
|
1296 | 1378 | { |
1297 | 1379 | $return[] = array( |
1298 | 1380 | 'type' => 'error', |
1299 | 1381 | ); |
1300 | - } |
|
1301 | - elseif (in_array($actionType, array('require-file', 'remove-file', 'require-dir', 'remove-dir', 'move-file', 'move-dir', 'create-file', 'create-dir'))) |
|
1382 | + } elseif (in_array($actionType, array('require-file', 'remove-file', 'require-dir', 'remove-dir', 'move-file', 'move-dir', 'create-file', 'create-dir'))) |
|
1302 | 1383 | { |
1303 | 1384 | $this_action = &$return[]; |
1304 | 1385 | $this_action = array( |
@@ -1312,8 +1393,7 @@ discard block |
||
1312 | 1393 | { |
1313 | 1394 | $this_action['unparsed_destination'] = $action->fetch('@destination'); |
1314 | 1395 | $this_action['destination'] = parse_path($action->fetch('@destination')) . '/' . basename($this_action['filename']); |
1315 | - } |
|
1316 | - else |
|
1396 | + } else |
|
1317 | 1397 | { |
1318 | 1398 | $this_action['unparsed_filename'] = $this_action['filename']; |
1319 | 1399 | $this_action['filename'] = parse_path($this_action['filename']); |
@@ -1322,10 +1402,11 @@ discard block |
||
1322 | 1402 | // If we're moving or requiring (copying) a file. |
1323 | 1403 | if (substr($actionType, 0, 4) == 'move' || substr($actionType, 0, 7) == 'require') |
1324 | 1404 | { |
1325 | - if ($action->exists('@from')) |
|
1326 | - $this_action['source'] = parse_path($action->fetch('@from')); |
|
1327 | - else |
|
1328 | - $this_action['source'] = $temp_path . $this_action['filename']; |
|
1405 | + if ($action->exists('@from')) { |
|
1406 | + $this_action['source'] = parse_path($action->fetch('@from')); |
|
1407 | + } else { |
|
1408 | + $this_action['source'] = $temp_path . $this_action['filename']; |
|
1409 | + } |
|
1329 | 1410 | } |
1330 | 1411 | |
1331 | 1412 | // Check if these things can be done. (chmod's etc.) |
@@ -1334,22 +1415,23 @@ discard block |
||
1334 | 1415 | if (!mktree($this_action['destination'], false)) |
1335 | 1416 | { |
1336 | 1417 | $temp = $this_action['destination']; |
1337 | - while (!file_exists($temp) && strlen($temp) > 1) |
|
1338 | - $temp = dirname($temp); |
|
1418 | + while (!file_exists($temp) && strlen($temp) > 1) { |
|
1419 | + $temp = dirname($temp); |
|
1420 | + } |
|
1339 | 1421 | |
1340 | 1422 | $return[] = array( |
1341 | 1423 | 'type' => 'chmod', |
1342 | 1424 | 'filename' => $temp |
1343 | 1425 | ); |
1344 | 1426 | } |
1345 | - } |
|
1346 | - elseif ($actionType == 'create-file') |
|
1427 | + } elseif ($actionType == 'create-file') |
|
1347 | 1428 | { |
1348 | 1429 | if (!mktree(dirname($this_action['destination']), false)) |
1349 | 1430 | { |
1350 | 1431 | $temp = dirname($this_action['destination']); |
1351 | - while (!file_exists($temp) && strlen($temp) > 1) |
|
1352 | - $temp = dirname($temp); |
|
1432 | + while (!file_exists($temp) && strlen($temp) > 1) { |
|
1433 | + $temp = dirname($temp); |
|
1434 | + } |
|
1353 | 1435 | |
1354 | 1436 | $return[] = array( |
1355 | 1437 | 'type' => 'chmod', |
@@ -1357,36 +1439,38 @@ discard block |
||
1357 | 1439 | ); |
1358 | 1440 | } |
1359 | 1441 | |
1360 | - if (!is_writable($this_action['destination']) && (file_exists($this_action['destination']) || !is_writable(dirname($this_action['destination'])))) |
|
1361 | - $return[] = array( |
|
1442 | + if (!is_writable($this_action['destination']) && (file_exists($this_action['destination']) || !is_writable(dirname($this_action['destination'])))) { |
|
1443 | + $return[] = array( |
|
1362 | 1444 | 'type' => 'chmod', |
1363 | 1445 | 'filename' => $this_action['destination'] |
1364 | 1446 | ); |
1365 | - } |
|
1366 | - elseif ($actionType == 'require-dir') |
|
1447 | + } |
|
1448 | + } elseif ($actionType == 'require-dir') |
|
1367 | 1449 | { |
1368 | 1450 | if (!mktree($this_action['destination'], false)) |
1369 | 1451 | { |
1370 | 1452 | $temp = $this_action['destination']; |
1371 | - while (!file_exists($temp) && strlen($temp) > 1) |
|
1372 | - $temp = dirname($temp); |
|
1453 | + while (!file_exists($temp) && strlen($temp) > 1) { |
|
1454 | + $temp = dirname($temp); |
|
1455 | + } |
|
1373 | 1456 | |
1374 | 1457 | $return[] = array( |
1375 | 1458 | 'type' => 'chmod', |
1376 | 1459 | 'filename' => $temp |
1377 | 1460 | ); |
1378 | 1461 | } |
1379 | - } |
|
1380 | - elseif ($actionType == 'require-file') |
|
1462 | + } elseif ($actionType == 'require-file') |
|
1381 | 1463 | { |
1382 | - if ($action->exists('@theme')) |
|
1383 | - $this_action['theme_action'] = $action->fetch('@theme'); |
|
1464 | + if ($action->exists('@theme')) { |
|
1465 | + $this_action['theme_action'] = $action->fetch('@theme'); |
|
1466 | + } |
|
1384 | 1467 | |
1385 | 1468 | if (!mktree(dirname($this_action['destination']), false)) |
1386 | 1469 | { |
1387 | 1470 | $temp = dirname($this_action['destination']); |
1388 | - while (!file_exists($temp) && strlen($temp) > 1) |
|
1389 | - $temp = dirname($temp); |
|
1471 | + while (!file_exists($temp) && strlen($temp) > 1) { |
|
1472 | + $temp = dirname($temp); |
|
1473 | + } |
|
1390 | 1474 | |
1391 | 1475 | $return[] = array( |
1392 | 1476 | 'type' => 'chmod', |
@@ -1394,19 +1478,20 @@ discard block |
||
1394 | 1478 | ); |
1395 | 1479 | } |
1396 | 1480 | |
1397 | - if (!is_writable($this_action['destination']) && (file_exists($this_action['destination']) || !is_writable(dirname($this_action['destination'])))) |
|
1398 | - $return[] = array( |
|
1481 | + if (!is_writable($this_action['destination']) && (file_exists($this_action['destination']) || !is_writable(dirname($this_action['destination'])))) { |
|
1482 | + $return[] = array( |
|
1399 | 1483 | 'type' => 'chmod', |
1400 | 1484 | 'filename' => $this_action['destination'] |
1401 | 1485 | ); |
1402 | - } |
|
1403 | - elseif ($actionType == 'move-dir' || $actionType == 'move-file') |
|
1486 | + } |
|
1487 | + } elseif ($actionType == 'move-dir' || $actionType == 'move-file') |
|
1404 | 1488 | { |
1405 | 1489 | if (!mktree(dirname($this_action['destination']), false)) |
1406 | 1490 | { |
1407 | 1491 | $temp = dirname($this_action['destination']); |
1408 | - while (!file_exists($temp) && strlen($temp) > 1) |
|
1409 | - $temp = dirname($temp); |
|
1492 | + while (!file_exists($temp) && strlen($temp) > 1) { |
|
1493 | + $temp = dirname($temp); |
|
1494 | + } |
|
1410 | 1495 | |
1411 | 1496 | $return[] = array( |
1412 | 1497 | 'type' => 'chmod', |
@@ -1414,30 +1499,30 @@ discard block |
||
1414 | 1499 | ); |
1415 | 1500 | } |
1416 | 1501 | |
1417 | - if (!is_writable($this_action['destination']) && (file_exists($this_action['destination']) || !is_writable(dirname($this_action['destination'])))) |
|
1418 | - $return[] = array( |
|
1502 | + if (!is_writable($this_action['destination']) && (file_exists($this_action['destination']) || !is_writable(dirname($this_action['destination'])))) { |
|
1503 | + $return[] = array( |
|
1419 | 1504 | 'type' => 'chmod', |
1420 | 1505 | 'filename' => $this_action['destination'] |
1421 | 1506 | ); |
1422 | - } |
|
1423 | - elseif ($actionType == 'remove-dir') |
|
1507 | + } |
|
1508 | + } elseif ($actionType == 'remove-dir') |
|
1424 | 1509 | { |
1425 | - if (!is_writable($this_action['filename']) && file_exists($this_action['filename'])) |
|
1426 | - $return[] = array( |
|
1510 | + if (!is_writable($this_action['filename']) && file_exists($this_action['filename'])) { |
|
1511 | + $return[] = array( |
|
1427 | 1512 | 'type' => 'chmod', |
1428 | 1513 | 'filename' => $this_action['filename'] |
1429 | 1514 | ); |
1430 | - } |
|
1431 | - elseif ($actionType == 'remove-file') |
|
1515 | + } |
|
1516 | + } elseif ($actionType == 'remove-file') |
|
1432 | 1517 | { |
1433 | - if (!is_writable($this_action['filename']) && file_exists($this_action['filename'])) |
|
1434 | - $return[] = array( |
|
1518 | + if (!is_writable($this_action['filename']) && file_exists($this_action['filename'])) { |
|
1519 | + $return[] = array( |
|
1435 | 1520 | 'type' => 'chmod', |
1436 | 1521 | 'filename' => $this_action['filename'] |
1437 | 1522 | ); |
1523 | + } |
|
1438 | 1524 | } |
1439 | - } |
|
1440 | - else |
|
1525 | + } else |
|
1441 | 1526 | { |
1442 | 1527 | $return[] = array( |
1443 | 1528 | 'type' => 'error', |
@@ -1448,8 +1533,9 @@ discard block |
||
1448 | 1533 | } |
1449 | 1534 | |
1450 | 1535 | // Only testing - just return a list of things to be done. |
1451 | - if ($testing_only) |
|
1452 | - return $return; |
|
1536 | + if ($testing_only) { |
|
1537 | + return $return; |
|
1538 | + } |
|
1453 | 1539 | |
1454 | 1540 | umask(0); |
1455 | 1541 | |
@@ -1457,78 +1543,81 @@ discard block |
||
1457 | 1543 | $not_done = array(array('type' => '!')); |
1458 | 1544 | foreach ($return as $action) |
1459 | 1545 | { |
1460 | - if (in_array($action['type'], array('modification', 'code', 'database', 'redirect', 'hook', 'credits'))) |
|
1461 | - $not_done[] = $action; |
|
1546 | + if (in_array($action['type'], array('modification', 'code', 'database', 'redirect', 'hook', 'credits'))) { |
|
1547 | + $not_done[] = $action; |
|
1548 | + } |
|
1462 | 1549 | |
1463 | 1550 | if ($action['type'] == 'create-dir') |
1464 | 1551 | { |
1465 | - if (!mktree($action['destination'], 0755) || !is_writable($action['destination'])) |
|
1466 | - $failure |= !mktree($action['destination'], 0777); |
|
1467 | - } |
|
1468 | - elseif ($action['type'] == 'create-file') |
|
1552 | + if (!mktree($action['destination'], 0755) || !is_writable($action['destination'])) { |
|
1553 | + $failure |= !mktree($action['destination'], 0777); |
|
1554 | + } |
|
1555 | + } elseif ($action['type'] == 'create-file') |
|
1469 | 1556 | { |
1470 | - if (!mktree(dirname($action['destination']), 0755) || !is_writable(dirname($action['destination']))) |
|
1471 | - $failure |= !mktree(dirname($action['destination']), 0777); |
|
1557 | + if (!mktree(dirname($action['destination']), 0755) || !is_writable(dirname($action['destination']))) { |
|
1558 | + $failure |= !mktree(dirname($action['destination']), 0777); |
|
1559 | + } |
|
1472 | 1560 | |
1473 | 1561 | // Create an empty file. |
1474 | 1562 | package_put_contents($action['destination'], package_get_contents($action['source']), $testing_only); |
1475 | 1563 | |
1476 | - if (!file_exists($action['destination'])) |
|
1477 | - $failure = true; |
|
1478 | - } |
|
1479 | - elseif ($action['type'] == 'require-dir') |
|
1564 | + if (!file_exists($action['destination'])) { |
|
1565 | + $failure = true; |
|
1566 | + } |
|
1567 | + } elseif ($action['type'] == 'require-dir') |
|
1480 | 1568 | { |
1481 | 1569 | copytree($action['source'], $action['destination']); |
1482 | 1570 | // Any other theme folders? |
1483 | - if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['destination']])) |
|
1484 | - foreach ($context['theme_copies'][$action['type']][$action['destination']] as $theme_destination) |
|
1571 | + if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['destination']])) { |
|
1572 | + foreach ($context['theme_copies'][$action['type']][$action['destination']] as $theme_destination) |
|
1485 | 1573 | copytree($action['source'], $theme_destination); |
1486 | - } |
|
1487 | - elseif ($action['type'] == 'require-file') |
|
1574 | + } |
|
1575 | + } elseif ($action['type'] == 'require-file') |
|
1488 | 1576 | { |
1489 | - if (!mktree(dirname($action['destination']), 0755) || !is_writable(dirname($action['destination']))) |
|
1490 | - $failure |= !mktree(dirname($action['destination']), 0777); |
|
1577 | + if (!mktree(dirname($action['destination']), 0755) || !is_writable(dirname($action['destination']))) { |
|
1578 | + $failure |= !mktree(dirname($action['destination']), 0777); |
|
1579 | + } |
|
1491 | 1580 | |
1492 | 1581 | package_put_contents($action['destination'], package_get_contents($action['source']), $testing_only); |
1493 | 1582 | |
1494 | 1583 | $failure |= !copy($action['source'], $action['destination']); |
1495 | 1584 | |
1496 | 1585 | // Any other theme files? |
1497 | - if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['destination']])) |
|
1498 | - foreach ($context['theme_copies'][$action['type']][$action['destination']] as $theme_destination) |
|
1586 | + if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['destination']])) { |
|
1587 | + foreach ($context['theme_copies'][$action['type']][$action['destination']] as $theme_destination) |
|
1499 | 1588 | { |
1500 | 1589 | if (!mktree(dirname($theme_destination), 0755) || !is_writable(dirname($theme_destination))) |
1501 | 1590 | $failure |= !mktree(dirname($theme_destination), 0777); |
1591 | + } |
|
1502 | 1592 | |
1503 | 1593 | package_put_contents($theme_destination, package_get_contents($action['source']), $testing_only); |
1504 | 1594 | |
1505 | 1595 | $failure |= !copy($action['source'], $theme_destination); |
1506 | 1596 | } |
1507 | - } |
|
1508 | - elseif ($action['type'] == 'move-file') |
|
1597 | + } elseif ($action['type'] == 'move-file') |
|
1509 | 1598 | { |
1510 | - if (!mktree(dirname($action['destination']), 0755) || !is_writable(dirname($action['destination']))) |
|
1511 | - $failure |= !mktree(dirname($action['destination']), 0777); |
|
1599 | + if (!mktree(dirname($action['destination']), 0755) || !is_writable(dirname($action['destination']))) { |
|
1600 | + $failure |= !mktree(dirname($action['destination']), 0777); |
|
1601 | + } |
|
1512 | 1602 | |
1513 | 1603 | $failure |= !rename($action['source'], $action['destination']); |
1514 | - } |
|
1515 | - elseif ($action['type'] == 'move-dir') |
|
1604 | + } elseif ($action['type'] == 'move-dir') |
|
1516 | 1605 | { |
1517 | - if (!mktree($action['destination'], 0755) || !is_writable($action['destination'])) |
|
1518 | - $failure |= !mktree($action['destination'], 0777); |
|
1606 | + if (!mktree($action['destination'], 0755) || !is_writable($action['destination'])) { |
|
1607 | + $failure |= !mktree($action['destination'], 0777); |
|
1608 | + } |
|
1519 | 1609 | |
1520 | 1610 | $failure |= !rename($action['source'], $action['destination']); |
1521 | - } |
|
1522 | - elseif ($action['type'] == 'remove-dir') |
|
1611 | + } elseif ($action['type'] == 'remove-dir') |
|
1523 | 1612 | { |
1524 | 1613 | deltree($action['filename']); |
1525 | 1614 | |
1526 | 1615 | // Any other theme folders? |
1527 | - if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['filename']])) |
|
1528 | - foreach ($context['theme_copies'][$action['type']][$action['filename']] as $theme_destination) |
|
1616 | + if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['filename']])) { |
|
1617 | + foreach ($context['theme_copies'][$action['type']][$action['filename']] as $theme_destination) |
|
1529 | 1618 | deltree($theme_destination); |
1530 | - } |
|
1531 | - elseif ($action['type'] == 'remove-file') |
|
1619 | + } |
|
1620 | + } elseif ($action['type'] == 'remove-file') |
|
1532 | 1621 | { |
1533 | 1622 | // Make sure the file exists before deleting it. |
1534 | 1623 | if (file_exists($action['filename'])) |
@@ -1537,16 +1626,18 @@ discard block |
||
1537 | 1626 | $failure |= !unlink($action['filename']); |
1538 | 1627 | } |
1539 | 1628 | // The file that was supposed to be deleted couldn't be found. |
1540 | - else |
|
1541 | - $failure = true; |
|
1629 | + else { |
|
1630 | + $failure = true; |
|
1631 | + } |
|
1542 | 1632 | |
1543 | 1633 | // Any other theme folders? |
1544 | - if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['filename']])) |
|
1545 | - foreach ($context['theme_copies'][$action['type']][$action['filename']] as $theme_destination) |
|
1634 | + if (!empty($context['theme_copies']) && !empty($context['theme_copies'][$action['type']][$action['filename']])) { |
|
1635 | + foreach ($context['theme_copies'][$action['type']][$action['filename']] as $theme_destination) |
|
1546 | 1636 | if (file_exists($theme_destination)) |
1547 | 1637 | $failure |= !unlink($theme_destination); |
1548 | - else |
|
1549 | - $failure = true; |
|
1638 | + } else { |
|
1639 | + $failure = true; |
|
1640 | + } |
|
1550 | 1641 | } |
1551 | 1642 | } |
1552 | 1643 | |
@@ -1568,8 +1659,9 @@ discard block |
||
1568 | 1659 | { |
1569 | 1660 | static $near_version = 0; |
1570 | 1661 | |
1571 | - if ($reset) |
|
1572 | - $near_version = 0; |
|
1662 | + if ($reset) { |
|
1663 | + $near_version = 0; |
|
1664 | + } |
|
1573 | 1665 | |
1574 | 1666 | // Normalize the $versions while we remove our previous Doh! |
1575 | 1667 | $versions = explode(',', str_replace(array(' ', '2.0rc1-1'), array('', '2.0rc1.1'), strtolower($versions))); |
@@ -1578,16 +1670,19 @@ discard block |
||
1578 | 1670 | foreach ($versions as $for) |
1579 | 1671 | { |
1580 | 1672 | // Adjust for those wild cards |
1581 | - if (strpos($for, '*') !== false) |
|
1582 | - $for = str_replace('*', '0dev0', $for) . '-' . str_replace('*', '999', $for); |
|
1673 | + if (strpos($for, '*') !== false) { |
|
1674 | + $for = str_replace('*', '0dev0', $for) . '-' . str_replace('*', '999', $for); |
|
1675 | + } |
|
1583 | 1676 | |
1584 | 1677 | // If we have a range, grab the lower value, done this way so it looks normal-er to the user e.g. 2.0 vs 2.0.99 |
1585 | - if (strpos($for, '-') !== false) |
|
1586 | - list ($for, $higher) = explode('-', $for); |
|
1678 | + if (strpos($for, '-') !== false) { |
|
1679 | + list ($for, $higher) = explode('-', $for); |
|
1680 | + } |
|
1587 | 1681 | |
1588 | 1682 | // Do the compare, if the for is greater, than what we have but not greater than what we are running ..... |
1589 | - if (compareVersions($near_version, $for) === -1 && compareVersions($for, $the_version) !== 1) |
|
1590 | - $near_version = $for; |
|
1683 | + if (compareVersions($near_version, $for) === -1 && compareVersions($for, $the_version) !== 1) { |
|
1684 | + $near_version = $for; |
|
1685 | + } |
|
1591 | 1686 | } |
1592 | 1687 | |
1593 | 1688 | return !empty($near_version) ? $near_version : false; |
@@ -1610,15 +1705,17 @@ discard block |
||
1610 | 1705 | $versions = explode(',', str_replace(array(' ', '2.0rc1-1'), array('', '2.0rc1.1'), strtolower($versions))); |
1611 | 1706 | |
1612 | 1707 | // Perhaps we do accept anything? |
1613 | - if (in_array('all', $versions)) |
|
1614 | - return true; |
|
1708 | + if (in_array('all', $versions)) { |
|
1709 | + return true; |
|
1710 | + } |
|
1615 | 1711 | |
1616 | 1712 | // Loop through each version. |
1617 | 1713 | foreach ($versions as $for) |
1618 | 1714 | { |
1619 | 1715 | // Wild card spotted? |
1620 | - if (strpos($for, '*') !== false) |
|
1621 | - $for = str_replace('*', '0dev0', $for) . '-' . str_replace('*', '999', $for); |
|
1716 | + if (strpos($for, '*') !== false) { |
|
1717 | + $for = str_replace('*', '0dev0', $for) . '-' . str_replace('*', '999', $for); |
|
1718 | + } |
|
1622 | 1719 | |
1623 | 1720 | // Do we have a range? |
1624 | 1721 | if (strpos($for, '-') !== false) |
@@ -1626,12 +1723,14 @@ discard block |
||
1626 | 1723 | list ($lower, $upper) = explode('-', $for); |
1627 | 1724 | |
1628 | 1725 | // Compare the version against lower and upper bounds. |
1629 | - if (compareVersions($version, $lower) > -1 && compareVersions($version, $upper) < 1) |
|
1630 | - return true; |
|
1726 | + if (compareVersions($version, $lower) > -1 && compareVersions($version, $upper) < 1) { |
|
1727 | + return true; |
|
1728 | + } |
|
1631 | 1729 | } |
1632 | 1730 | // Otherwise check if they are equal... |
1633 | - elseif (compareVersions($version, $for) === 0) |
|
1634 | - return true; |
|
1731 | + elseif (compareVersions($version, $for) === 0) { |
|
1732 | + return true; |
|
1733 | + } |
|
1635 | 1734 | } |
1636 | 1735 | |
1637 | 1736 | return false; |
@@ -1671,12 +1770,14 @@ discard block |
||
1671 | 1770 | } |
1672 | 1771 | |
1673 | 1772 | // Are they the same, perhaps? |
1674 | - if ($versions[1] === $versions[2]) |
|
1675 | - return 0; |
|
1773 | + if ($versions[1] === $versions[2]) { |
|
1774 | + return 0; |
|
1775 | + } |
|
1676 | 1776 | |
1677 | 1777 | // Get version numbering categories... |
1678 | - if (!isset($categories)) |
|
1679 | - $categories = array_keys($versions[1]); |
|
1778 | + if (!isset($categories)) { |
|
1779 | + $categories = array_keys($versions[1]); |
|
1780 | + } |
|
1680 | 1781 | |
1681 | 1782 | // Loop through each category. |
1682 | 1783 | foreach ($categories as $category) |
@@ -1686,13 +1787,15 @@ discard block |
||
1686 | 1787 | { |
1687 | 1788 | // Dev builds are a problematic exception. |
1688 | 1789 | // (stable) dev < (stable) but (unstable) dev = (unstable) |
1689 | - if ($category == 'type') |
|
1690 | - return $versions[1][$category] > $versions[2][$category] ? ($versions[1]['dev'] ? -1 : 1) : ($versions[2]['dev'] ? 1 : -1); |
|
1691 | - elseif ($category == 'dev') |
|
1692 | - return $versions[1]['dev'] ? ($versions[2]['type'] == 'stable' ? -1 : 0) : ($versions[1]['type'] == 'stable' ? 1 : 0); |
|
1790 | + if ($category == 'type') { |
|
1791 | + return $versions[1][$category] > $versions[2][$category] ? ($versions[1]['dev'] ? -1 : 1) : ($versions[2]['dev'] ? 1 : -1); |
|
1792 | + } elseif ($category == 'dev') { |
|
1793 | + return $versions[1]['dev'] ? ($versions[2]['type'] == 'stable' ? -1 : 0) : ($versions[1]['type'] == 'stable' ? 1 : 0); |
|
1794 | + } |
|
1693 | 1795 | // Otherwise a simple comparison. |
1694 | - else |
|
1695 | - return $versions[1][$category] > $versions[2][$category] ? 1 : -1; |
|
1796 | + else { |
|
1797 | + return $versions[1][$category] > $versions[2][$category] ? 1 : -1; |
|
1798 | + } |
|
1696 | 1799 | } |
1697 | 1800 | } |
1698 | 1801 | |
@@ -1726,11 +1829,13 @@ discard block |
||
1726 | 1829 | ); |
1727 | 1830 | |
1728 | 1831 | // do we parse in a package directory? |
1729 | - if (!empty($temp_path)) |
|
1730 | - $dirs['$package'] = $temp_path; |
|
1832 | + if (!empty($temp_path)) { |
|
1833 | + $dirs['$package'] = $temp_path; |
|
1834 | + } |
|
1731 | 1835 | |
1732 | - if (strlen($path) == 0) |
|
1733 | - trigger_error('parse_path(): There should never be an empty filename', E_USER_ERROR); |
|
1836 | + if (strlen($path) == 0) { |
|
1837 | + trigger_error('parse_path(): There should never be an empty filename', E_USER_ERROR); |
|
1838 | + } |
|
1734 | 1839 | |
1735 | 1840 | return strtr($path, $dirs); |
1736 | 1841 | } |
@@ -1747,8 +1852,9 @@ discard block |
||
1747 | 1852 | /** @var ftp_connection $package_ftp */ |
1748 | 1853 | global $package_ftp; |
1749 | 1854 | |
1750 | - if (!file_exists($dir)) |
|
1751 | - return; |
|
1855 | + if (!file_exists($dir)) { |
|
1856 | + return; |
|
1857 | + } |
|
1752 | 1858 | |
1753 | 1859 | $current_dir = @opendir($dir); |
1754 | 1860 | if ($current_dir == false) |
@@ -1756,8 +1862,9 @@ discard block |
||
1756 | 1862 | if ($delete_dir && isset($package_ftp)) |
1757 | 1863 | { |
1758 | 1864 | $ftp_file = strtr($dir, array($_SESSION['pack_ftp']['root'] => '')); |
1759 | - if (!is_dir($dir)) |
|
1760 | - $package_ftp->chmod($ftp_file, 0777); |
|
1865 | + if (!is_dir($dir)) { |
|
1866 | + $package_ftp->chmod($ftp_file, 0777); |
|
1867 | + } |
|
1761 | 1868 | $package_ftp->unlink($ftp_file); |
1762 | 1869 | } |
1763 | 1870 | |
@@ -1766,26 +1873,28 @@ discard block |
||
1766 | 1873 | |
1767 | 1874 | while ($entryname = readdir($current_dir)) |
1768 | 1875 | { |
1769 | - if (in_array($entryname, array('.', '..'))) |
|
1770 | - continue; |
|
1876 | + if (in_array($entryname, array('.', '..'))) { |
|
1877 | + continue; |
|
1878 | + } |
|
1771 | 1879 | |
1772 | - if (is_dir($dir . '/' . $entryname)) |
|
1773 | - deltree($dir . '/' . $entryname); |
|
1774 | - else |
|
1880 | + if (is_dir($dir . '/' . $entryname)) { |
|
1881 | + deltree($dir . '/' . $entryname); |
|
1882 | + } else |
|
1775 | 1883 | { |
1776 | 1884 | // Here, 755 doesn't really matter since we're deleting it anyway. |
1777 | 1885 | if (isset($package_ftp)) |
1778 | 1886 | { |
1779 | 1887 | $ftp_file = strtr($dir . '/' . $entryname, array($_SESSION['pack_ftp']['root'] => '')); |
1780 | 1888 | |
1781 | - if (!is_writable($dir . '/' . $entryname)) |
|
1782 | - $package_ftp->chmod($ftp_file, 0777); |
|
1889 | + if (!is_writable($dir . '/' . $entryname)) { |
|
1890 | + $package_ftp->chmod($ftp_file, 0777); |
|
1891 | + } |
|
1783 | 1892 | $package_ftp->unlink($ftp_file); |
1784 | - } |
|
1785 | - else |
|
1893 | + } else |
|
1786 | 1894 | { |
1787 | - if (!is_writable($dir . '/' . $entryname)) |
|
1788 | - smf_chmod($dir . '/' . $entryname, 0777); |
|
1895 | + if (!is_writable($dir . '/' . $entryname)) { |
|
1896 | + smf_chmod($dir . '/' . $entryname, 0777); |
|
1897 | + } |
|
1789 | 1898 | unlink($dir . '/' . $entryname); |
1790 | 1899 | } |
1791 | 1900 | } |
@@ -1798,14 +1907,15 @@ discard block |
||
1798 | 1907 | if (isset($package_ftp)) |
1799 | 1908 | { |
1800 | 1909 | $ftp_file = strtr($dir, array($_SESSION['pack_ftp']['root'] => '')); |
1801 | - if (!is_writable($dir . '/' . $entryname)) |
|
1802 | - $package_ftp->chmod($ftp_file, 0777); |
|
1910 | + if (!is_writable($dir . '/' . $entryname)) { |
|
1911 | + $package_ftp->chmod($ftp_file, 0777); |
|
1912 | + } |
|
1803 | 1913 | $package_ftp->unlink($ftp_file); |
1804 | - } |
|
1805 | - else |
|
1914 | + } else |
|
1806 | 1915 | { |
1807 | - if (!is_writable($dir)) |
|
1808 | - smf_chmod($dir, 0777); |
|
1916 | + if (!is_writable($dir)) { |
|
1917 | + smf_chmod($dir, 0777); |
|
1918 | + } |
|
1809 | 1919 | @rmdir($dir); |
1810 | 1920 | } |
1811 | 1921 | } |
@@ -1828,10 +1938,11 @@ discard block |
||
1828 | 1938 | { |
1829 | 1939 | if (!is_writable($strPath) && $mode !== false) |
1830 | 1940 | { |
1831 | - if (isset($package_ftp)) |
|
1832 | - $package_ftp->chmod(strtr($strPath, array($_SESSION['pack_ftp']['root'] => '')), $mode); |
|
1833 | - else |
|
1834 | - smf_chmod($strPath, $mode); |
|
1941 | + if (isset($package_ftp)) { |
|
1942 | + $package_ftp->chmod(strtr($strPath, array($_SESSION['pack_ftp']['root'] => '')), $mode); |
|
1943 | + } else { |
|
1944 | + smf_chmod($strPath, $mode); |
|
1945 | + } |
|
1835 | 1946 | } |
1836 | 1947 | |
1837 | 1948 | $test = @opendir($strPath); |
@@ -1839,36 +1950,37 @@ discard block |
||
1839 | 1950 | { |
1840 | 1951 | closedir($test); |
1841 | 1952 | return is_writable($strPath); |
1953 | + } else { |
|
1954 | + return false; |
|
1842 | 1955 | } |
1843 | - else |
|
1844 | - return false; |
|
1845 | 1956 | } |
1846 | 1957 | // Is this an invalid path and/or we can't make the directory? |
1847 | - if ($strPath == dirname($strPath) || !mktree(dirname($strPath), $mode)) |
|
1848 | - return false; |
|
1958 | + if ($strPath == dirname($strPath) || !mktree(dirname($strPath), $mode)) { |
|
1959 | + return false; |
|
1960 | + } |
|
1849 | 1961 | |
1850 | 1962 | if (!is_writable(dirname($strPath)) && $mode !== false) |
1851 | 1963 | { |
1852 | - if (isset($package_ftp)) |
|
1853 | - $package_ftp->chmod(dirname(strtr($strPath, array($_SESSION['pack_ftp']['root'] => ''))), $mode); |
|
1854 | - else |
|
1855 | - smf_chmod(dirname($strPath), $mode); |
|
1964 | + if (isset($package_ftp)) { |
|
1965 | + $package_ftp->chmod(dirname(strtr($strPath, array($_SESSION['pack_ftp']['root'] => ''))), $mode); |
|
1966 | + } else { |
|
1967 | + smf_chmod(dirname($strPath), $mode); |
|
1968 | + } |
|
1856 | 1969 | } |
1857 | 1970 | |
1858 | - if ($mode !== false && isset($package_ftp)) |
|
1859 | - return $package_ftp->create_dir(strtr($strPath, array($_SESSION['pack_ftp']['root'] => ''))); |
|
1860 | - elseif ($mode === false) |
|
1971 | + if ($mode !== false && isset($package_ftp)) { |
|
1972 | + return $package_ftp->create_dir(strtr($strPath, array($_SESSION['pack_ftp']['root'] => ''))); |
|
1973 | + } elseif ($mode === false) |
|
1861 | 1974 | { |
1862 | 1975 | $test = @opendir(dirname($strPath)); |
1863 | 1976 | if ($test) |
1864 | 1977 | { |
1865 | 1978 | closedir($test); |
1866 | 1979 | return true; |
1980 | + } else { |
|
1981 | + return false; |
|
1867 | 1982 | } |
1868 | - else |
|
1869 | - return false; |
|
1870 | - } |
|
1871 | - else |
|
1983 | + } else |
|
1872 | 1984 | { |
1873 | 1985 | @mkdir($strPath, $mode); |
1874 | 1986 | $test = @opendir($strPath); |
@@ -1876,9 +1988,9 @@ discard block |
||
1876 | 1988 | { |
1877 | 1989 | closedir($test); |
1878 | 1990 | return true; |
1991 | + } else { |
|
1992 | + return false; |
|
1879 | 1993 | } |
1880 | - else |
|
1881 | - return false; |
|
1882 | 1994 | } |
1883 | 1995 | } |
1884 | 1996 | |
@@ -1894,39 +2006,46 @@ discard block |
||
1894 | 2006 | /** @var ftp_connection $package_ftp */ |
1895 | 2007 | global $package_ftp; |
1896 | 2008 | |
1897 | - if (!file_exists($destination) || !is_writable($destination)) |
|
1898 | - mktree($destination, 0755); |
|
1899 | - if (!is_writable($destination)) |
|
1900 | - mktree($destination, 0777); |
|
2009 | + if (!file_exists($destination) || !is_writable($destination)) { |
|
2010 | + mktree($destination, 0755); |
|
2011 | + } |
|
2012 | + if (!is_writable($destination)) { |
|
2013 | + mktree($destination, 0777); |
|
2014 | + } |
|
1901 | 2015 | |
1902 | 2016 | $current_dir = opendir($source); |
1903 | - if ($current_dir == false) |
|
1904 | - return; |
|
2017 | + if ($current_dir == false) { |
|
2018 | + return; |
|
2019 | + } |
|
1905 | 2020 | |
1906 | 2021 | while ($entryname = readdir($current_dir)) |
1907 | 2022 | { |
1908 | - if (in_array($entryname, array('.', '..'))) |
|
1909 | - continue; |
|
2023 | + if (in_array($entryname, array('.', '..'))) { |
|
2024 | + continue; |
|
2025 | + } |
|
1910 | 2026 | |
1911 | - if (isset($package_ftp)) |
|
1912 | - $ftp_file = strtr($destination . '/' . $entryname, array($_SESSION['pack_ftp']['root'] => '')); |
|
2027 | + if (isset($package_ftp)) { |
|
2028 | + $ftp_file = strtr($destination . '/' . $entryname, array($_SESSION['pack_ftp']['root'] => '')); |
|
2029 | + } |
|
1913 | 2030 | |
1914 | 2031 | if (is_file($source . '/' . $entryname)) |
1915 | 2032 | { |
1916 | - if (isset($package_ftp) && !file_exists($destination . '/' . $entryname)) |
|
1917 | - $package_ftp->create_file($ftp_file); |
|
1918 | - elseif (!file_exists($destination . '/' . $entryname)) |
|
1919 | - @touch($destination . '/' . $entryname); |
|
2033 | + if (isset($package_ftp) && !file_exists($destination . '/' . $entryname)) { |
|
2034 | + $package_ftp->create_file($ftp_file); |
|
2035 | + } elseif (!file_exists($destination . '/' . $entryname)) { |
|
2036 | + @touch($destination . '/' . $entryname); |
|
2037 | + } |
|
1920 | 2038 | } |
1921 | 2039 | |
1922 | 2040 | package_chmod($destination . '/' . $entryname); |
1923 | 2041 | |
1924 | - if (is_dir($source . '/' . $entryname)) |
|
1925 | - copytree($source . '/' . $entryname, $destination . '/' . $entryname); |
|
1926 | - elseif (file_exists($destination . '/' . $entryname)) |
|
1927 | - package_put_contents($destination . '/' . $entryname, package_get_contents($source . '/' . $entryname)); |
|
1928 | - else |
|
1929 | - copy($source . '/' . $entryname, $destination . '/' . $entryname); |
|
2042 | + if (is_dir($source . '/' . $entryname)) { |
|
2043 | + copytree($source . '/' . $entryname, $destination . '/' . $entryname); |
|
2044 | + } elseif (file_exists($destination . '/' . $entryname)) { |
|
2045 | + package_put_contents($destination . '/' . $entryname, package_get_contents($source . '/' . $entryname)); |
|
2046 | + } else { |
|
2047 | + copy($source . '/' . $entryname, $destination . '/' . $entryname); |
|
2048 | + } |
|
1930 | 2049 | } |
1931 | 2050 | |
1932 | 2051 | closedir($current_dir); |
@@ -1944,21 +2063,24 @@ discard block |
||
1944 | 2063 | $data = array(); |
1945 | 2064 | |
1946 | 2065 | $dir = @dir($path . $sub_path); |
1947 | - if (!$dir) |
|
1948 | - return array(); |
|
2066 | + if (!$dir) { |
|
2067 | + return array(); |
|
2068 | + } |
|
1949 | 2069 | while ($entry = $dir->read()) |
1950 | 2070 | { |
1951 | - if ($entry == '.' || $entry == '..') |
|
1952 | - continue; |
|
2071 | + if ($entry == '.' || $entry == '..') { |
|
2072 | + continue; |
|
2073 | + } |
|
1953 | 2074 | |
1954 | - if (is_dir($path . $sub_path . '/' . $entry)) |
|
1955 | - $data = array_merge($data, listtree($path, $sub_path . '/' . $entry)); |
|
1956 | - else |
|
1957 | - $data[] = array( |
|
2075 | + if (is_dir($path . $sub_path . '/' . $entry)) { |
|
2076 | + $data = array_merge($data, listtree($path, $sub_path . '/' . $entry)); |
|
2077 | + } else { |
|
2078 | + $data[] = array( |
|
1958 | 2079 | 'filename' => $sub_path == '' ? $entry : $sub_path . '/' . $entry, |
1959 | 2080 | 'size' => filesize($path . $sub_path . '/' . $entry), |
1960 | 2081 | 'skipped' => false, |
1961 | 2082 | ); |
2083 | + } |
|
1962 | 2084 | } |
1963 | 2085 | $dir->close(); |
1964 | 2086 | |
@@ -2013,8 +2135,9 @@ discard block |
||
2013 | 2135 | { |
2014 | 2136 | // If this filename is relative, if so take a guess at what it should be. |
2015 | 2137 | $real_filename = $filename; |
2016 | - if (strpos($filename, 'Themes') === 0) |
|
2017 | - $real_filename = $boarddir . '/' . $filename; |
|
2138 | + if (strpos($filename, 'Themes') === 0) { |
|
2139 | + $real_filename = $boarddir . '/' . $filename; |
|
2140 | + } |
|
2018 | 2141 | |
2019 | 2142 | if (strpos($real_filename, $theme['theme_dir']) === 0) |
2020 | 2143 | { |
@@ -2033,8 +2156,9 @@ discard block |
||
2033 | 2156 | foreach ($theme_paths as $id => $theme) |
2034 | 2157 | { |
2035 | 2158 | // Default is getting done anyway, so no need for involvement here. |
2036 | - if ($id == 1) |
|
2037 | - continue; |
|
2159 | + if ($id == 1) { |
|
2160 | + continue; |
|
2161 | + } |
|
2038 | 2162 | |
2039 | 2163 | // For every template, do we want it? Yea, no, maybe? |
2040 | 2164 | foreach ($template_changes[1] as $index => $template_file) |
@@ -2057,8 +2181,9 @@ discard block |
||
2057 | 2181 | ); |
2058 | 2182 | |
2059 | 2183 | // Sometimes though, we have some additional files for other themes, if we have add them to the mix. |
2060 | - if (isset($custom_themes_add[$files_to_change[1]])) |
|
2061 | - $files_to_change += $custom_themes_add[$files_to_change[1]]; |
|
2184 | + if (isset($custom_themes_add[$files_to_change[1]])) { |
|
2185 | + $files_to_change += $custom_themes_add[$files_to_change[1]]; |
|
2186 | + } |
|
2062 | 2187 | |
2063 | 2188 | // Now, loop through all the files we're changing, and, well, change them ;) |
2064 | 2189 | foreach ($files_to_change as $theme => $working_file) |
@@ -2092,11 +2217,13 @@ discard block |
||
2092 | 2217 | continue; |
2093 | 2218 | } |
2094 | 2219 | // Okay, we're creating this file then...? |
2095 | - elseif (!file_exists($working_file)) |
|
2096 | - $working_data = ''; |
|
2220 | + elseif (!file_exists($working_file)) { |
|
2221 | + $working_data = ''; |
|
2222 | + } |
|
2097 | 2223 | // Phew, it exists! Load 'er up! |
2098 | - else |
|
2099 | - $working_data = str_replace("\r", '', package_get_contents($working_file)); |
|
2224 | + else { |
|
2225 | + $working_data = str_replace("\r", '', package_get_contents($working_file)); |
|
2226 | + } |
|
2100 | 2227 | |
2101 | 2228 | $actions[] = array( |
2102 | 2229 | 'type' => 'opened', |
@@ -2117,8 +2244,8 @@ discard block |
||
2117 | 2244 | |
2118 | 2245 | // Grab all search items of this operation (in most cases just 1). |
2119 | 2246 | $searches = $operation->set('search'); |
2120 | - foreach ($searches as $i => $search) |
|
2121 | - $actual_operation['searches'][] = array( |
|
2247 | + foreach ($searches as $i => $search) { |
|
2248 | + $actual_operation['searches'][] = array( |
|
2122 | 2249 | 'position' => $search->exists('@position') && in_array(trim($search->fetch('@position')), array('before', 'after', 'replace', 'end')) ? trim($search->fetch('@position')) : 'replace', |
2123 | 2250 | 'is_reg_exp' => $search->exists('@regexp') && trim($search->fetch('@regexp')) === 'true', |
2124 | 2251 | 'loose_whitespace' => $search->exists('@whitespace') && trim($search->fetch('@whitespace')) === 'loose', |
@@ -2127,6 +2254,7 @@ discard block |
||
2127 | 2254 | 'preg_search' => '', |
2128 | 2255 | 'preg_replace' => '', |
2129 | 2256 | ); |
2257 | + } |
|
2130 | 2258 | |
2131 | 2259 | // At least one search should be defined. |
2132 | 2260 | if (empty($actual_operation['searches'])) |
@@ -2151,30 +2279,32 @@ discard block |
||
2151 | 2279 | // Reverse modification of regular expressions are not allowed. |
2152 | 2280 | if ($search['is_reg_exp']) |
2153 | 2281 | { |
2154 | - if ($actual_operation['error'] === 'fatal') |
|
2155 | - $actions[] = array( |
|
2282 | + if ($actual_operation['error'] === 'fatal') { |
|
2283 | + $actions[] = array( |
|
2156 | 2284 | 'type' => 'failure', |
2157 | 2285 | 'filename' => $working_file, |
2158 | 2286 | 'search' => $search['search'], |
2159 | 2287 | 'is_custom' => $theme > 1 ? $theme : 0, |
2160 | 2288 | ); |
2289 | + } |
|
2161 | 2290 | |
2162 | 2291 | // Continue to the next operation. |
2163 | 2292 | continue 2; |
2164 | 2293 | } |
2165 | 2294 | |
2166 | 2295 | // The replacement is now the search subject... |
2167 | - if ($search['position'] === 'replace' || $search['position'] === 'end') |
|
2168 | - $actual_operation['searches'][$i]['search'] = $search['add']; |
|
2169 | - else |
|
2296 | + if ($search['position'] === 'replace' || $search['position'] === 'end') { |
|
2297 | + $actual_operation['searches'][$i]['search'] = $search['add']; |
|
2298 | + } else |
|
2170 | 2299 | { |
2171 | 2300 | // Reversing a before/after modification becomes a replacement. |
2172 | 2301 | $actual_operation['searches'][$i]['position'] = 'replace'; |
2173 | 2302 | |
2174 | - if ($search['position'] === 'before') |
|
2175 | - $actual_operation['searches'][$i]['search'] .= $search['add']; |
|
2176 | - elseif ($search['position'] === 'after') |
|
2177 | - $actual_operation['searches'][$i]['search'] = $search['add'] . $search['search']; |
|
2303 | + if ($search['position'] === 'before') { |
|
2304 | + $actual_operation['searches'][$i]['search'] .= $search['add']; |
|
2305 | + } elseif ($search['position'] === 'after') { |
|
2306 | + $actual_operation['searches'][$i]['search'] = $search['add'] . $search['search']; |
|
2307 | + } |
|
2178 | 2308 | } |
2179 | 2309 | |
2180 | 2310 | // ...and the search subject is now the replacement. |
@@ -2202,16 +2332,17 @@ discard block |
||
2202 | 2332 | foreach ($actual_operation['searches'] as $i => $search) |
2203 | 2333 | { |
2204 | 2334 | // Not much needed if the search subject is already a regexp. |
2205 | - if ($search['is_reg_exp']) |
|
2206 | - $actual_operation['searches'][$i]['preg_search'] = $search['search']; |
|
2207 | - else |
|
2335 | + if ($search['is_reg_exp']) { |
|
2336 | + $actual_operation['searches'][$i]['preg_search'] = $search['search']; |
|
2337 | + } else |
|
2208 | 2338 | { |
2209 | 2339 | // Make the search subject fit into a regular expression. |
2210 | 2340 | $actual_operation['searches'][$i]['preg_search'] = preg_quote($search['search'], '~'); |
2211 | 2341 | |
2212 | 2342 | // Using 'loose', a random amount of tabs and spaces may be used. |
2213 | - if ($search['loose_whitespace']) |
|
2214 | - $actual_operation['searches'][$i]['preg_search'] = preg_replace('~[ \t]+~', '[ \t]+', $actual_operation['searches'][$i]['preg_search']); |
|
2343 | + if ($search['loose_whitespace']) { |
|
2344 | + $actual_operation['searches'][$i]['preg_search'] = preg_replace('~[ \t]+~', '[ \t]+', $actual_operation['searches'][$i]['preg_search']); |
|
2345 | + } |
|
2215 | 2346 | } |
2216 | 2347 | |
2217 | 2348 | // Shuzzup. This is done so we can safely use a regular expression. ($0 is bad!!) |
@@ -2237,8 +2368,7 @@ discard block |
||
2237 | 2368 | if ($undo) |
2238 | 2369 | { |
2239 | 2370 | $actual_operation['searches'][$i]['preg_replace'] = ''; |
2240 | - } |
|
2241 | - else |
|
2371 | + } else |
|
2242 | 2372 | { |
2243 | 2373 | $actual_operation['searches'][$i]['preg_search'] = '(\\n\\?\\>)?$'; |
2244 | 2374 | $actual_operation['searches'][$i]['preg_replace'] .= '$1'; |
@@ -2285,8 +2415,9 @@ discard block |
||
2285 | 2415 | } |
2286 | 2416 | |
2287 | 2417 | // Replace it into nothing? That's not an option...unless it's an undoing end. |
2288 | - if ($search['add'] === '' && ($search['position'] !== 'end' || !$undo)) |
|
2289 | - continue; |
|
2418 | + if ($search['add'] === '' && ($search['position'] !== 'end' || !$undo)) { |
|
2419 | + continue; |
|
2420 | + } |
|
2290 | 2421 | |
2291 | 2422 | // Finally, we're doing some replacements. |
2292 | 2423 | $working_data = preg_replace('~' . $actual_operation['searches'][$i]['preg_search'] . '~s', $actual_operation['searches'][$i]['preg_replace'], $working_data, 1); |
@@ -2311,22 +2442,25 @@ discard block |
||
2311 | 2442 | |
2312 | 2443 | package_chmod($working_file); |
2313 | 2444 | |
2314 | - if ((file_exists($working_file) && !is_writable($working_file)) || (!file_exists($working_file) && !is_writable(dirname($working_file)))) |
|
2315 | - $actions[] = array( |
|
2445 | + if ((file_exists($working_file) && !is_writable($working_file)) || (!file_exists($working_file) && !is_writable(dirname($working_file)))) { |
|
2446 | + $actions[] = array( |
|
2316 | 2447 | 'type' => 'chmod', |
2317 | 2448 | 'filename' => $working_file |
2318 | 2449 | ); |
2450 | + } |
|
2319 | 2451 | |
2320 | - if (basename($working_file) == 'Settings_bak.php') |
|
2321 | - continue; |
|
2452 | + if (basename($working_file) == 'Settings_bak.php') { |
|
2453 | + continue; |
|
2454 | + } |
|
2322 | 2455 | |
2323 | 2456 | if (!$testing && !empty($modSettings['package_make_backups']) && file_exists($working_file)) |
2324 | 2457 | { |
2325 | 2458 | // No, no, not Settings.php! |
2326 | - if (basename($working_file) == 'Settings.php') |
|
2327 | - @copy($working_file, dirname($working_file) . '/Settings_bak.php'); |
|
2328 | - else |
|
2329 | - @copy($working_file, $working_file . '~'); |
|
2459 | + if (basename($working_file) == 'Settings.php') { |
|
2460 | + @copy($working_file, dirname($working_file) . '/Settings_bak.php'); |
|
2461 | + } else { |
|
2462 | + @copy($working_file, $working_file . '~'); |
|
2463 | + } |
|
2330 | 2464 | } |
2331 | 2465 | |
2332 | 2466 | // Always call this, even if in testing, because it won't really be written in testing mode. |
@@ -2393,8 +2527,9 @@ discard block |
||
2393 | 2527 | if ($code_match[1] != 'edit file' && $code_match[1] != 'file') |
2394 | 2528 | { |
2395 | 2529 | // It's a step, let's add that to the current steps. |
2396 | - if (isset($temp_changes[$step_counter])) |
|
2397 | - $temp_changes[$step_counter]['changes'][] = $code_match[0]; |
|
2530 | + if (isset($temp_changes[$step_counter])) { |
|
2531 | + $temp_changes[$step_counter]['changes'][] = $code_match[0]; |
|
2532 | + } |
|
2398 | 2533 | continue; |
2399 | 2534 | } |
2400 | 2535 | |
@@ -2411,11 +2546,13 @@ discard block |
||
2411 | 2546 | foreach ($theme_paths as $id => $theme) |
2412 | 2547 | { |
2413 | 2548 | // If this filename is relative, if so take a guess at what it should be. |
2414 | - if (strpos($filename, 'Themes') === 0) |
|
2415 | - $filename = $boarddir . '/' . $filename; |
|
2549 | + if (strpos($filename, 'Themes') === 0) { |
|
2550 | + $filename = $boarddir . '/' . $filename; |
|
2551 | + } |
|
2416 | 2552 | |
2417 | - if (strpos($filename, $theme['theme_dir']) === 0) |
|
2418 | - $template_changes[$id][$counter] = substr($filename, strlen($theme['theme_dir']) + 1); |
|
2553 | + if (strpos($filename, $theme['theme_dir']) === 0) { |
|
2554 | + $template_changes[$id][$counter] = substr($filename, strlen($theme['theme_dir']) + 1); |
|
2555 | + } |
|
2419 | 2556 | } |
2420 | 2557 | } |
2421 | 2558 | |
@@ -2428,8 +2565,9 @@ discard block |
||
2428 | 2565 | foreach ($theme_paths as $id => $theme) |
2429 | 2566 | { |
2430 | 2567 | // Don't do default, it means nothing to me. |
2431 | - if ($id == 1) |
|
2432 | - continue; |
|
2568 | + if ($id == 1) { |
|
2569 | + continue; |
|
2570 | + } |
|
2433 | 2571 | |
2434 | 2572 | // Now, for each file do we need to edit it? |
2435 | 2573 | foreach ($template_changes[1] as $pos => $template_file) |
@@ -2465,32 +2603,36 @@ discard block |
||
2465 | 2603 | package_chmod($working_file); |
2466 | 2604 | |
2467 | 2605 | // Don't even dare. |
2468 | - if (basename($working_file) == 'Settings_bak.php') |
|
2469 | - continue; |
|
2606 | + if (basename($working_file) == 'Settings_bak.php') { |
|
2607 | + continue; |
|
2608 | + } |
|
2470 | 2609 | |
2471 | - if (!is_writable($working_file)) |
|
2472 | - $actions[] = array( |
|
2610 | + if (!is_writable($working_file)) { |
|
2611 | + $actions[] = array( |
|
2473 | 2612 | 'type' => 'chmod', |
2474 | 2613 | 'filename' => $working_file |
2475 | 2614 | ); |
2615 | + } |
|
2476 | 2616 | |
2477 | 2617 | if (!$testing && !empty($modSettings['package_make_backups']) && file_exists($working_file)) |
2478 | 2618 | { |
2479 | - if (basename($working_file) == 'Settings.php') |
|
2480 | - @copy($working_file, dirname($working_file) . '/Settings_bak.php'); |
|
2481 | - else |
|
2482 | - @copy($working_file, $working_file . '~'); |
|
2619 | + if (basename($working_file) == 'Settings.php') { |
|
2620 | + @copy($working_file, dirname($working_file) . '/Settings_bak.php'); |
|
2621 | + } else { |
|
2622 | + @copy($working_file, $working_file . '~'); |
|
2623 | + } |
|
2483 | 2624 | } |
2484 | 2625 | |
2485 | 2626 | package_put_contents($working_file, $working_data, $testing); |
2486 | 2627 | } |
2487 | 2628 | |
2488 | - if ($working_file !== null) |
|
2489 | - $actions[] = array( |
|
2629 | + if ($working_file !== null) { |
|
2630 | + $actions[] = array( |
|
2490 | 2631 | 'type' => 'saved', |
2491 | 2632 | 'filename' => $working_file, |
2492 | 2633 | 'is_custom' => $is_custom, |
2493 | 2634 | ); |
2635 | + } |
|
2494 | 2636 | |
2495 | 2637 | // Is this "now working on" file a theme specific one? |
2496 | 2638 | $is_custom = isset($theme_id_ref[$counter - 1]) ? $theme_id_ref[$counter - 1] : 0; |
@@ -2509,10 +2651,11 @@ discard block |
||
2509 | 2651 | { |
2510 | 2652 | $places_to_check = array($boarddir, $sourcedir, $settings['default_theme_dir'], $settings['default_theme_dir'] . '/languages'); |
2511 | 2653 | |
2512 | - foreach ($places_to_check as $place) |
|
2513 | - if (file_exists($place . '/' . $working_file)) |
|
2654 | + foreach ($places_to_check as $place) { |
|
2655 | + if (file_exists($place . '/' . $working_file)) |
|
2514 | 2656 | { |
2515 | 2657 | $working_file = $place . '/' . $working_file; |
2658 | + } |
|
2516 | 2659 | break; |
2517 | 2660 | } |
2518 | 2661 | } |
@@ -2526,8 +2669,7 @@ discard block |
||
2526 | 2669 | 'type' => 'opened', |
2527 | 2670 | 'filename' => $working_file |
2528 | 2671 | ); |
2529 | - } |
|
2530 | - else |
|
2672 | + } else |
|
2531 | 2673 | { |
2532 | 2674 | $actions[] = array( |
2533 | 2675 | 'type' => 'missing', |
@@ -2563,11 +2705,13 @@ discard block |
||
2563 | 2705 | $replace_with = $code_match[2]; |
2564 | 2706 | |
2565 | 2707 | // Add this afterward... |
2566 | - if ($code_match[1] == 'add' || $code_match[1] == 'add after') |
|
2567 | - $replace_with = $working_search . "\n" . $replace_with; |
|
2708 | + if ($code_match[1] == 'add' || $code_match[1] == 'add after') { |
|
2709 | + $replace_with = $working_search . "\n" . $replace_with; |
|
2710 | + } |
|
2568 | 2711 | // Add this beforehand. |
2569 | - elseif ($code_match[1] == 'before' || $code_match[1] == 'add before' || $code_match[1] == 'above' || $code_match[1] == 'add above') |
|
2570 | - $replace_with .= "\n" . $working_search; |
|
2712 | + elseif ($code_match[1] == 'before' || $code_match[1] == 'add before' || $code_match[1] == 'above' || $code_match[1] == 'add above') { |
|
2713 | + $replace_with .= "\n" . $working_search; |
|
2714 | + } |
|
2571 | 2715 | // Otherwise.. replace with $replace_with ;). |
2572 | 2716 | } |
2573 | 2717 | |
@@ -2630,29 +2774,32 @@ discard block |
||
2630 | 2774 | { |
2631 | 2775 | package_chmod($working_file); |
2632 | 2776 | |
2633 | - if (!is_writable($working_file)) |
|
2634 | - $actions[] = array( |
|
2777 | + if (!is_writable($working_file)) { |
|
2778 | + $actions[] = array( |
|
2635 | 2779 | 'type' => 'chmod', |
2636 | 2780 | 'filename' => $working_file |
2637 | 2781 | ); |
2782 | + } |
|
2638 | 2783 | |
2639 | 2784 | if (!$testing && !empty($modSettings['package_make_backups']) && file_exists($working_file)) |
2640 | 2785 | { |
2641 | - if (basename($working_file) == 'Settings.php') |
|
2642 | - @copy($working_file, dirname($working_file) . '/Settings_bak.php'); |
|
2643 | - else |
|
2644 | - @copy($working_file, $working_file . '~'); |
|
2786 | + if (basename($working_file) == 'Settings.php') { |
|
2787 | + @copy($working_file, dirname($working_file) . '/Settings_bak.php'); |
|
2788 | + } else { |
|
2789 | + @copy($working_file, $working_file . '~'); |
|
2790 | + } |
|
2645 | 2791 | } |
2646 | 2792 | |
2647 | 2793 | package_put_contents($working_file, $working_data, $testing); |
2648 | 2794 | } |
2649 | 2795 | |
2650 | - if ($working_file !== null) |
|
2651 | - $actions[] = array( |
|
2796 | + if ($working_file !== null) { |
|
2797 | + $actions[] = array( |
|
2652 | 2798 | 'type' => 'saved', |
2653 | 2799 | 'filename' => $working_file, |
2654 | 2800 | 'is_custom' => $is_custom, |
2655 | 2801 | ); |
2802 | + } |
|
2656 | 2803 | |
2657 | 2804 | $actions[] = array( |
2658 | 2805 | 'type' => 'result', |
@@ -2678,17 +2825,19 @@ discard block |
||
2678 | 2825 | $mem_check = setMemoryLimit('128M'); |
2679 | 2826 | |
2680 | 2827 | // Windows doesn't seem to care about the memory_limit. |
2681 | - if (!empty($modSettings['package_disable_cache']) || $mem_check || stripos(PHP_OS, 'win') !== false) |
|
2682 | - $package_cache = array(); |
|
2683 | - else |
|
2684 | - $package_cache = false; |
|
2828 | + if (!empty($modSettings['package_disable_cache']) || $mem_check || stripos(PHP_OS, 'win') !== false) { |
|
2829 | + $package_cache = array(); |
|
2830 | + } else { |
|
2831 | + $package_cache = false; |
|
2832 | + } |
|
2685 | 2833 | } |
2686 | 2834 | |
2687 | - if (strpos($filename, 'Packages/') !== false || $package_cache === false || !isset($package_cache[$filename])) |
|
2688 | - return file_get_contents($filename); |
|
2689 | - else |
|
2690 | - return $package_cache[$filename]; |
|
2691 | -} |
|
2835 | + if (strpos($filename, 'Packages/') !== false || $package_cache === false || !isset($package_cache[$filename])) { |
|
2836 | + return file_get_contents($filename); |
|
2837 | + } else { |
|
2838 | + return $package_cache[$filename]; |
|
2839 | + } |
|
2840 | + } |
|
2692 | 2841 | |
2693 | 2842 | /** |
2694 | 2843 | * Writes data to a file, almost exactly like the file_put_contents() function. |
@@ -2712,19 +2861,22 @@ discard block |
||
2712 | 2861 | // Try to increase the memory limit - we don't want to run out of ram! |
2713 | 2862 | $mem_check = setMemoryLimit('128M'); |
2714 | 2863 | |
2715 | - if (!empty($modSettings['package_disable_cache']) || $mem_check || stripos(PHP_OS, 'win') !== false) |
|
2716 | - $package_cache = array(); |
|
2717 | - else |
|
2718 | - $package_cache = false; |
|
2864 | + if (!empty($modSettings['package_disable_cache']) || $mem_check || stripos(PHP_OS, 'win') !== false) { |
|
2865 | + $package_cache = array(); |
|
2866 | + } else { |
|
2867 | + $package_cache = false; |
|
2868 | + } |
|
2719 | 2869 | } |
2720 | 2870 | |
2721 | - if (isset($package_ftp)) |
|
2722 | - $ftp_file = strtr($filename, array($_SESSION['pack_ftp']['root'] => '')); |
|
2871 | + if (isset($package_ftp)) { |
|
2872 | + $ftp_file = strtr($filename, array($_SESSION['pack_ftp']['root'] => '')); |
|
2873 | + } |
|
2723 | 2874 | |
2724 | - if (!file_exists($filename) && isset($package_ftp)) |
|
2725 | - $package_ftp->create_file($ftp_file); |
|
2726 | - elseif (!file_exists($filename)) |
|
2727 | - @touch($filename); |
|
2875 | + if (!file_exists($filename) && isset($package_ftp)) { |
|
2876 | + $package_ftp->create_file($ftp_file); |
|
2877 | + } elseif (!file_exists($filename)) { |
|
2878 | + @touch($filename); |
|
2879 | + } |
|
2728 | 2880 | |
2729 | 2881 | package_chmod($filename); |
2730 | 2882 | |
@@ -2733,22 +2885,23 @@ discard block |
||
2733 | 2885 | $fp = @fopen($filename, in_array(substr($filename, -3), $text_filetypes) ? 'w' : 'wb'); |
2734 | 2886 | |
2735 | 2887 | // We should show an error message or attempt a rollback, no? |
2736 | - if (!$fp) |
|
2737 | - return false; |
|
2888 | + if (!$fp) { |
|
2889 | + return false; |
|
2890 | + } |
|
2738 | 2891 | |
2739 | 2892 | fwrite($fp, $data); |
2740 | 2893 | fclose($fp); |
2741 | - } |
|
2742 | - elseif (strpos($filename, 'Packages/') !== false || $package_cache === false) |
|
2743 | - return strlen($data); |
|
2744 | - else |
|
2894 | + } elseif (strpos($filename, 'Packages/') !== false || $package_cache === false) { |
|
2895 | + return strlen($data); |
|
2896 | + } else |
|
2745 | 2897 | { |
2746 | 2898 | $package_cache[$filename] = $data; |
2747 | 2899 | |
2748 | 2900 | // Permission denied, eh? |
2749 | 2901 | $fp = @fopen($filename, 'r+'); |
2750 | - if (!$fp) |
|
2751 | - return false; |
|
2902 | + if (!$fp) { |
|
2903 | + return false; |
|
2904 | + } |
|
2752 | 2905 | fclose($fp); |
2753 | 2906 | } |
2754 | 2907 | |
@@ -2766,19 +2919,22 @@ discard block |
||
2766 | 2919 | global $package_ftp, $package_cache; |
2767 | 2920 | static $text_filetypes = array('php', 'txt', '.js', 'css', 'vbs', 'tml', 'htm'); |
2768 | 2921 | |
2769 | - if (empty($package_cache)) |
|
2770 | - return; |
|
2922 | + if (empty($package_cache)) { |
|
2923 | + return; |
|
2924 | + } |
|
2771 | 2925 | |
2772 | 2926 | // First, let's check permissions! |
2773 | 2927 | foreach ($package_cache as $filename => $data) |
2774 | 2928 | { |
2775 | - if (isset($package_ftp)) |
|
2776 | - $ftp_file = strtr($filename, array($_SESSION['pack_ftp']['root'] => '')); |
|
2929 | + if (isset($package_ftp)) { |
|
2930 | + $ftp_file = strtr($filename, array($_SESSION['pack_ftp']['root'] => '')); |
|
2931 | + } |
|
2777 | 2932 | |
2778 | - if (!file_exists($filename) && isset($package_ftp)) |
|
2779 | - $package_ftp->create_file($ftp_file); |
|
2780 | - elseif (!file_exists($filename)) |
|
2781 | - @touch($filename); |
|
2933 | + if (!file_exists($filename) && isset($package_ftp)) { |
|
2934 | + $package_ftp->create_file($ftp_file); |
|
2935 | + } elseif (!file_exists($filename)) { |
|
2936 | + @touch($filename); |
|
2937 | + } |
|
2782 | 2938 | |
2783 | 2939 | $result = package_chmod($filename); |
2784 | 2940 | |
@@ -2832,8 +2988,9 @@ discard block |
||
2832 | 2988 | /** @var ftp_connection $package_ftp */ |
2833 | 2989 | global $package_ftp; |
2834 | 2990 | |
2835 | - if (file_exists($filename) && is_writable($filename) && $perm_state == 'writable') |
|
2836 | - return true; |
|
2991 | + if (file_exists($filename) && is_writable($filename) && $perm_state == 'writable') { |
|
2992 | + return true; |
|
2993 | + } |
|
2837 | 2994 | |
2838 | 2995 | // Start off checking without FTP. |
2839 | 2996 | if (!isset($package_ftp) || $package_ftp === false) |
@@ -2855,8 +3012,7 @@ discard block |
||
2855 | 3012 | |
2856 | 3013 | // Keep track of the writable status here. |
2857 | 3014 | $file_permissions = @fileperms($chmod_file); |
2858 | - } |
|
2859 | - else |
|
3015 | + } else |
|
2860 | 3016 | { |
2861 | 3017 | // This looks odd, but it's an attempt to work around PHP suExec. |
2862 | 3018 | if (!file_exists($chmod_file) && $perm_state == 'writable') |
@@ -2866,24 +3022,28 @@ discard block |
||
2866 | 3022 | mktree(dirname($chmod_file), 0755); |
2867 | 3023 | @touch($chmod_file); |
2868 | 3024 | smf_chmod($chmod_file, 0755); |
3025 | + } else { |
|
3026 | + $file_permissions = @fileperms($chmod_file); |
|
2869 | 3027 | } |
2870 | - else |
|
2871 | - $file_permissions = @fileperms($chmod_file); |
|
2872 | 3028 | } |
2873 | 3029 | |
2874 | 3030 | // This looks odd, but it's another attempt to work around PHP suExec. |
2875 | - if ($perm_state != 'writable') |
|
2876 | - smf_chmod($chmod_file, $perm_state == 'execute' ? 0755 : 0644); |
|
2877 | - else |
|
3031 | + if ($perm_state != 'writable') { |
|
3032 | + smf_chmod($chmod_file, $perm_state == 'execute' ? 0755 : 0644); |
|
3033 | + } else |
|
2878 | 3034 | { |
2879 | - if (!@is_writable($chmod_file)) |
|
2880 | - smf_chmod($chmod_file, 0755); |
|
2881 | - if (!@is_writable($chmod_file)) |
|
2882 | - smf_chmod($chmod_file, 0777); |
|
2883 | - if (!@is_writable(dirname($chmod_file))) |
|
2884 | - smf_chmod($chmod_file, 0755); |
|
2885 | - if (!@is_writable(dirname($chmod_file))) |
|
2886 | - smf_chmod($chmod_file, 0777); |
|
3035 | + if (!@is_writable($chmod_file)) { |
|
3036 | + smf_chmod($chmod_file, 0755); |
|
3037 | + } |
|
3038 | + if (!@is_writable($chmod_file)) { |
|
3039 | + smf_chmod($chmod_file, 0777); |
|
3040 | + } |
|
3041 | + if (!@is_writable(dirname($chmod_file))) { |
|
3042 | + smf_chmod($chmod_file, 0755); |
|
3043 | + } |
|
3044 | + if (!@is_writable(dirname($chmod_file))) { |
|
3045 | + smf_chmod($chmod_file, 0777); |
|
3046 | + } |
|
2887 | 3047 | } |
2888 | 3048 | |
2889 | 3049 | // The ultimate writable test. |
@@ -2892,20 +3052,22 @@ discard block |
||
2892 | 3052 | $fp = is_dir($chmod_file) ? @opendir($chmod_file) : @fopen($chmod_file, 'rb'); |
2893 | 3053 | if (@is_writable($chmod_file) && $fp) |
2894 | 3054 | { |
2895 | - if (!is_dir($chmod_file)) |
|
2896 | - fclose($fp); |
|
2897 | - else |
|
2898 | - closedir($fp); |
|
3055 | + if (!is_dir($chmod_file)) { |
|
3056 | + fclose($fp); |
|
3057 | + } else { |
|
3058 | + closedir($fp); |
|
3059 | + } |
|
2899 | 3060 | |
2900 | 3061 | // It worked! |
2901 | - if ($track_change) |
|
2902 | - $_SESSION['pack_ftp']['original_perms'][$chmod_file] = $file_permissions; |
|
3062 | + if ($track_change) { |
|
3063 | + $_SESSION['pack_ftp']['original_perms'][$chmod_file] = $file_permissions; |
|
3064 | + } |
|
2903 | 3065 | |
2904 | 3066 | return true; |
2905 | 3067 | } |
3068 | + } elseif ($perm_state != 'writable' && isset($_SESSION['pack_ftp']['original_perms'][$chmod_file])) { |
|
3069 | + unset($_SESSION['pack_ftp']['original_perms'][$chmod_file]); |
|
2906 | 3070 | } |
2907 | - elseif ($perm_state != 'writable' && isset($_SESSION['pack_ftp']['original_perms'][$chmod_file])) |
|
2908 | - unset($_SESSION['pack_ftp']['original_perms'][$chmod_file]); |
|
2909 | 3071 | } |
2910 | 3072 | |
2911 | 3073 | // If we're here we're a failure. |
@@ -2924,31 +3086,33 @@ discard block |
||
2924 | 3086 | mktree(dirname($filename), 0755); |
2925 | 3087 | $package_ftp->create_file($ftp_file); |
2926 | 3088 | $package_ftp->chmod($ftp_file, 0755); |
3089 | + } else { |
|
3090 | + $file_permissions = @fileperms($filename); |
|
2927 | 3091 | } |
2928 | - else |
|
2929 | - $file_permissions = @fileperms($filename); |
|
2930 | 3092 | |
2931 | 3093 | if ($perm_state != 'writable') |
2932 | 3094 | { |
2933 | 3095 | $package_ftp->chmod($ftp_file, $perm_state == 'execute' ? 0755 : 0644); |
2934 | - } |
|
2935 | - else |
|
3096 | + } else |
|
2936 | 3097 | { |
2937 | - if (!@is_writable($filename)) |
|
2938 | - $package_ftp->chmod($ftp_file, 0777); |
|
2939 | - if (!@is_writable(dirname($filename))) |
|
2940 | - $package_ftp->chmod(dirname($ftp_file), 0777); |
|
3098 | + if (!@is_writable($filename)) { |
|
3099 | + $package_ftp->chmod($ftp_file, 0777); |
|
3100 | + } |
|
3101 | + if (!@is_writable(dirname($filename))) { |
|
3102 | + $package_ftp->chmod(dirname($ftp_file), 0777); |
|
3103 | + } |
|
2941 | 3104 | } |
2942 | 3105 | |
2943 | 3106 | if (@is_writable($filename)) |
2944 | 3107 | { |
2945 | - if ($track_change) |
|
2946 | - $_SESSION['pack_ftp']['original_perms'][$filename] = $file_permissions; |
|
3108 | + if ($track_change) { |
|
3109 | + $_SESSION['pack_ftp']['original_perms'][$filename] = $file_permissions; |
|
3110 | + } |
|
2947 | 3111 | |
2948 | 3112 | return true; |
3113 | + } elseif ($perm_state != 'writable' && isset($_SESSION['pack_ftp']['original_perms'][$filename])) { |
|
3114 | + unset($_SESSION['pack_ftp']['original_perms'][$filename]); |
|
2949 | 3115 | } |
2950 | - elseif ($perm_state != 'writable' && isset($_SESSION['pack_ftp']['original_perms'][$filename])) |
|
2951 | - unset($_SESSION['pack_ftp']['original_perms'][$filename]); |
|
2952 | 3116 | } |
2953 | 3117 | |
2954 | 3118 | // Oh dear, we failed if we get here. |
@@ -2966,11 +3130,13 @@ discard block |
||
2966 | 3130 | $n = strlen($pass); |
2967 | 3131 | |
2968 | 3132 | $salt = session_id(); |
2969 | - while (strlen($salt) < $n) |
|
2970 | - $salt .= session_id(); |
|
3133 | + while (strlen($salt) < $n) { |
|
3134 | + $salt .= session_id(); |
|
3135 | + } |
|
2971 | 3136 | |
2972 | - for ($i = 0; $i < $n; $i++) |
|
2973 | - $pass{$i} = chr(ord($pass{$i}) ^ (ord($salt{$i}) - 32)); |
|
3137 | + for ($i = 0; $i < $n; $i++) { |
|
3138 | + $pass{$i} = chr(ord($pass{$i}) ^ (ord($salt{$i}) - 32)); |
|
3139 | + } |
|
2974 | 3140 | |
2975 | 3141 | return $pass; |
2976 | 3142 | } |
@@ -2989,8 +3155,9 @@ discard block |
||
2989 | 3155 | $base_files = array('index.php', 'SSI.php', 'agreement.txt', 'cron.php', 'ssi_examples.php', 'ssi_examples.shtml', 'subscriptions.php'); |
2990 | 3156 | foreach ($base_files as $file) |
2991 | 3157 | { |
2992 | - if (file_exists($boarddir . '/' . $file)) |
|
2993 | - $files[empty($_REQUEST['use_full_paths']) ? $file : $boarddir . '/' . $file] = $boarddir . '/' . $file; |
|
3158 | + if (file_exists($boarddir . '/' . $file)) { |
|
3159 | + $files[empty($_REQUEST['use_full_paths']) ? $file : $boarddir . '/' . $file] = $boarddir . '/' . $file; |
|
3160 | + } |
|
2994 | 3161 | } |
2995 | 3162 | |
2996 | 3163 | $dirs = array( |
@@ -3007,8 +3174,9 @@ discard block |
||
3007 | 3174 | 'theme_dir' => 'theme_dir', |
3008 | 3175 | ) |
3009 | 3176 | ); |
3010 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3011 | - $dirs[$row['value']] = empty($_REQUEST['use_full_paths']) ? 'Themes/' . basename($row['value']) . '/' : strtr($row['value'] . '/', '\\', '/'); |
|
3177 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3178 | + $dirs[$row['value']] = empty($_REQUEST['use_full_paths']) ? 'Themes/' . basename($row['value']) . '/' : strtr($row['value'] . '/', '\\', '/'); |
|
3179 | + } |
|
3012 | 3180 | $smcFunc['db_free_result']($request); |
3013 | 3181 | |
3014 | 3182 | try |
@@ -3023,11 +3191,13 @@ discard block |
||
3023 | 3191 | |
3024 | 3192 | foreach ($iter as $entry => $dir) |
3025 | 3193 | { |
3026 | - if ($dir->isDir()) |
|
3027 | - continue; |
|
3194 | + if ($dir->isDir()) { |
|
3195 | + continue; |
|
3196 | + } |
|
3028 | 3197 | |
3029 | - if (preg_match('~^(\.{1,2}|CVS|backup.*|help|images|.*\~)$~', $entry) != 0) |
|
3030 | - continue; |
|
3198 | + if (preg_match('~^(\.{1,2}|CVS|backup.*|help|images|.*\~)$~', $entry) != 0) { |
|
3199 | + continue; |
|
3200 | + } |
|
3031 | 3201 | |
3032 | 3202 | $files[empty($_REQUEST['use_full_paths']) ? str_replace(realpath($boarddir), '', $entry) : $entry] = $entry; |
3033 | 3203 | } |
@@ -3035,10 +3205,12 @@ discard block |
||
3035 | 3205 | $obj = new ArrayObject($files); |
3036 | 3206 | $iterator = $obj->getIterator(); |
3037 | 3207 | |
3038 | - if (!file_exists($packagesdir . '/backups')) |
|
3039 | - mktree($packagesdir . '/backups', 0777); |
|
3040 | - if (!is_writable($packagesdir . '/backups')) |
|
3041 | - package_chmod($packagesdir . '/backups'); |
|
3208 | + if (!file_exists($packagesdir . '/backups')) { |
|
3209 | + mktree($packagesdir . '/backups', 0777); |
|
3210 | + } |
|
3211 | + if (!is_writable($packagesdir . '/backups')) { |
|
3212 | + package_chmod($packagesdir . '/backups'); |
|
3213 | + } |
|
3042 | 3214 | $output_file = $packagesdir . '/backups/' . strftime('%Y-%m-%d_') . preg_replace('~[$\\\\/:<>|?*"\']~', '', $id); |
3043 | 3215 | $output_ext = '.tar'; |
3044 | 3216 | $output_ext_target = '.tar.gz'; |
@@ -3046,16 +3218,18 @@ discard block |
||
3046 | 3218 | if (file_exists($output_file . $output_ext_target)) |
3047 | 3219 | { |
3048 | 3220 | $i = 2; |
3049 | - while (file_exists($output_file . '_' . $i . $output_ext_target)) |
|
3050 | - $i++; |
|
3221 | + while (file_exists($output_file . '_' . $i . $output_ext_target)) { |
|
3222 | + $i++; |
|
3223 | + } |
|
3051 | 3224 | $output_file = $output_file . '_' . $i . $output_ext; |
3225 | + } else { |
|
3226 | + $output_file .= $output_ext; |
|
3052 | 3227 | } |
3053 | - else |
|
3054 | - $output_file .= $output_ext; |
|
3055 | 3228 | |
3056 | 3229 | @set_time_limit(300); |
3057 | - if (function_exists('apache_reset_timeout')) |
|
3058 | - @apache_reset_timeout(); |
|
3230 | + if (function_exists('apache_reset_timeout')) { |
|
3231 | + @apache_reset_timeout(); |
|
3232 | + } |
|
3059 | 3233 | |
3060 | 3234 | $a = new PharData($output_file); |
3061 | 3235 | $a->buildFromIterator($iterator); |
@@ -3067,8 +3241,7 @@ discard block |
||
3067 | 3241 | */ |
3068 | 3242 | unset($a); |
3069 | 3243 | unlink($output_file); |
3070 | - } |
|
3071 | - catch (Exception $e) |
|
3244 | + } catch (Exception $e) |
|
3072 | 3245 | { |
3073 | 3246 | log_error($e->getMessage(), 'backup'); |
3074 | 3247 | |
@@ -3100,32 +3273,35 @@ discard block |
||
3100 | 3273 | preg_match('~^(http|ftp)(s)?://([^/:]+)(:(\d+))?(.+)$~', $url, $match); |
3101 | 3274 | |
3102 | 3275 | // An FTP url. We should try connecting and RETRieving it... |
3103 | - if (empty($match[1])) |
|
3104 | - return false; |
|
3105 | - elseif ($match[1] == 'ftp') |
|
3276 | + if (empty($match[1])) { |
|
3277 | + return false; |
|
3278 | + } elseif ($match[1] == 'ftp') |
|
3106 | 3279 | { |
3107 | 3280 | // Include the file containing the ftp_connection class. |
3108 | 3281 | require_once($sourcedir . '/Class-Package.php'); |
3109 | 3282 | |
3110 | 3283 | // Establish a connection and attempt to enable passive mode. |
3111 | 3284 | $ftp = new ftp_connection(($match[2] ? 'ssl://' : '') . $match[3], empty($match[5]) ? 21 : $match[5], 'anonymous', $webmaster_email); |
3112 | - if ($ftp->error !== false || !$ftp->passive()) |
|
3113 | - return false; |
|
3285 | + if ($ftp->error !== false || !$ftp->passive()) { |
|
3286 | + return false; |
|
3287 | + } |
|
3114 | 3288 | |
3115 | 3289 | // I want that one *points*! |
3116 | 3290 | fwrite($ftp->connection, 'RETR ' . $match[6] . "\r\n"); |
3117 | 3291 | |
3118 | 3292 | // Since passive mode worked (or we would have returned already!) open the connection. |
3119 | 3293 | $fp = @fsockopen($ftp->pasv['ip'], $ftp->pasv['port'], $err, $err, 5); |
3120 | - if (!$fp) |
|
3121 | - return false; |
|
3294 | + if (!$fp) { |
|
3295 | + return false; |
|
3296 | + } |
|
3122 | 3297 | |
3123 | 3298 | // The server should now say something in acknowledgement. |
3124 | 3299 | $ftp->check_response(150); |
3125 | 3300 | |
3126 | 3301 | $data = ''; |
3127 | - while (!feof($fp)) |
|
3128 | - $data .= fread($fp, 4096); |
|
3302 | + while (!feof($fp)) { |
|
3303 | + $data .= fread($fp, 4096); |
|
3304 | + } |
|
3129 | 3305 | fclose($fp); |
3130 | 3306 | |
3131 | 3307 | // All done, right? Good. |
@@ -3142,22 +3318,25 @@ discard block |
||
3142 | 3318 | $fetch_data->get_url_data($url, $post_data); |
3143 | 3319 | |
3144 | 3320 | // no errors and a 200 result, then we have a good dataset, well we at least have data ;) |
3145 | - if ($fetch_data->result('code') == 200 && !$fetch_data->result('error')) |
|
3146 | - $data = $fetch_data->result('body'); |
|
3147 | - else |
|
3148 | - return false; |
|
3321 | + if ($fetch_data->result('code') == 200 && !$fetch_data->result('error')) { |
|
3322 | + $data = $fetch_data->result('body'); |
|
3323 | + } else { |
|
3324 | + return false; |
|
3325 | + } |
|
3149 | 3326 | } |
3150 | 3327 | // This is more likely; a standard HTTP URL. |
3151 | 3328 | elseif (isset($match[1]) && $match[1] == 'http') |
3152 | 3329 | { |
3153 | - if ($keep_alive && $match[3] == $keep_alive_dom) |
|
3154 | - $fp = $keep_alive_fp; |
|
3330 | + if ($keep_alive && $match[3] == $keep_alive_dom) { |
|
3331 | + $fp = $keep_alive_fp; |
|
3332 | + } |
|
3155 | 3333 | if (empty($fp)) |
3156 | 3334 | { |
3157 | 3335 | // Open the socket on the port we want... |
3158 | 3336 | $fp = @fsockopen(($match[2] ? 'ssl://' : '') . $match[3], empty($match[5]) ? ($match[2] ? 443 : 80) : $match[5], $err, $err, 5); |
3159 | - if (!$fp) |
|
3160 | - return false; |
|
3337 | + if (!$fp) { |
|
3338 | + return false; |
|
3339 | + } |
|
3161 | 3340 | } |
3162 | 3341 | |
3163 | 3342 | if ($keep_alive) |
@@ -3172,20 +3351,21 @@ discard block |
||
3172 | 3351 | fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n"); |
3173 | 3352 | fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n"); |
3174 | 3353 | fwrite($fp, 'User-Agent: PHP/SMF' . "\r\n"); |
3175 | - if ($keep_alive) |
|
3176 | - fwrite($fp, 'Connection: Keep-Alive' . "\r\n\r\n"); |
|
3177 | - else |
|
3178 | - fwrite($fp, 'Connection: close' . "\r\n\r\n"); |
|
3179 | - } |
|
3180 | - else |
|
3354 | + if ($keep_alive) { |
|
3355 | + fwrite($fp, 'Connection: Keep-Alive' . "\r\n\r\n"); |
|
3356 | + } else { |
|
3357 | + fwrite($fp, 'Connection: close' . "\r\n\r\n"); |
|
3358 | + } |
|
3359 | + } else |
|
3181 | 3360 | { |
3182 | 3361 | fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n"); |
3183 | 3362 | fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n"); |
3184 | 3363 | fwrite($fp, 'User-Agent: PHP/SMF' . "\r\n"); |
3185 | - if ($keep_alive) |
|
3186 | - fwrite($fp, 'Connection: Keep-Alive' . "\r\n"); |
|
3187 | - else |
|
3188 | - fwrite($fp, 'Connection: close' . "\r\n"); |
|
3364 | + if ($keep_alive) { |
|
3365 | + fwrite($fp, 'Connection: Keep-Alive' . "\r\n"); |
|
3366 | + } else { |
|
3367 | + fwrite($fp, 'Connection: close' . "\r\n"); |
|
3368 | + } |
|
3189 | 3369 | fwrite($fp, 'Content-Type: application/x-www-form-urlencoded' . "\r\n"); |
3190 | 3370 | fwrite($fp, 'Content-Length: ' . strlen($post_data) . "\r\n\r\n"); |
3191 | 3371 | fwrite($fp, $post_data); |
@@ -3198,30 +3378,33 @@ discard block |
||
3198 | 3378 | { |
3199 | 3379 | $header = ''; |
3200 | 3380 | $location = ''; |
3201 | - while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') |
|
3202 | - if (strpos($header, 'Location:') !== false) |
|
3381 | + while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') { |
|
3382 | + if (strpos($header, 'Location:') !== false) |
|
3203 | 3383 | $location = trim(substr($header, strpos($header, ':') + 1)); |
3384 | + } |
|
3204 | 3385 | |
3205 | - if (empty($location)) |
|
3206 | - return false; |
|
3207 | - else |
|
3386 | + if (empty($location)) { |
|
3387 | + return false; |
|
3388 | + } else |
|
3208 | 3389 | { |
3209 | - if (!$keep_alive) |
|
3210 | - fclose($fp); |
|
3390 | + if (!$keep_alive) { |
|
3391 | + fclose($fp); |
|
3392 | + } |
|
3211 | 3393 | return fetch_web_data($location, $post_data, $keep_alive, $redirection_level + 1); |
3212 | 3394 | } |
3213 | 3395 | } |
3214 | 3396 | |
3215 | 3397 | // Make sure we get a 200 OK. |
3216 | - elseif (preg_match('~^HTTP/\S+\s+20[01]~i', $response) === 0) |
|
3217 | - return false; |
|
3398 | + elseif (preg_match('~^HTTP/\S+\s+20[01]~i', $response) === 0) { |
|
3399 | + return false; |
|
3400 | + } |
|
3218 | 3401 | |
3219 | 3402 | // Skip the headers... |
3220 | 3403 | while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') |
3221 | 3404 | { |
3222 | - if (preg_match('~content-length:\s*(\d+)~i', $header, $match) != 0) |
|
3223 | - $content_length = $match[1]; |
|
3224 | - elseif (preg_match('~connection:\s*close~i', $header) != 0) |
|
3405 | + if (preg_match('~content-length:\s*(\d+)~i', $header, $match) != 0) { |
|
3406 | + $content_length = $match[1]; |
|
3407 | + } elseif (preg_match('~connection:\s*close~i', $header) != 0) |
|
3225 | 3408 | { |
3226 | 3409 | $keep_alive_dom = null; |
3227 | 3410 | $keep_alive = false; |
@@ -3233,19 +3416,20 @@ discard block |
||
3233 | 3416 | $data = ''; |
3234 | 3417 | if (isset($content_length)) |
3235 | 3418 | { |
3236 | - while (!feof($fp) && strlen($data) < $content_length) |
|
3237 | - $data .= fread($fp, $content_length - strlen($data)); |
|
3238 | - } |
|
3239 | - else |
|
3419 | + while (!feof($fp) && strlen($data) < $content_length) { |
|
3420 | + $data .= fread($fp, $content_length - strlen($data)); |
|
3421 | + } |
|
3422 | + } else |
|
3240 | 3423 | { |
3241 | - while (!feof($fp)) |
|
3242 | - $data .= fread($fp, 4096); |
|
3424 | + while (!feof($fp)) { |
|
3425 | + $data .= fread($fp, 4096); |
|
3426 | + } |
|
3243 | 3427 | } |
3244 | 3428 | |
3245 | - if (!$keep_alive) |
|
3246 | - fclose($fp); |
|
3247 | - } |
|
3248 | - else |
|
3429 | + if (!$keep_alive) { |
|
3430 | + fclose($fp); |
|
3431 | + } |
|
3432 | + } else |
|
3249 | 3433 | { |
3250 | 3434 | // Umm, this shouldn't happen? |
3251 | 3435 | trigger_error('fetch_web_data(): Bad URL', E_USER_NOTICE); |
@@ -239,7 +239,7 @@ |
||
239 | 239 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
240 | 240 | $fts_language[$row['cfgname']] = $row['cfgname']; |
241 | 241 | |
242 | - $config_vars = array_merge ($config_vars, array( |
|
242 | + $config_vars = array_merge($config_vars, array( |
|
243 | 243 | '', |
244 | 244 | array('search_language', $txt['search_language'], 'db', 'select', $fts_language, 'pgFulltextSearch') |
245 | 245 | ) |
@@ -59,8 +59,9 @@ discard block |
||
59 | 59 | * @version 2.1 Beta 4 |
60 | 60 | */ |
61 | 61 | |
62 | -if (!defined('SMF')) |
|
62 | +if (!defined('SMF')) { |
|
63 | 63 | die('No direct access...'); |
64 | +} |
|
64 | 65 | |
65 | 66 | /** |
66 | 67 | * This is the main dispatcher. Sets up all the available sub-actions, all the tabs and selects |
@@ -111,10 +112,11 @@ discard block |
||
111 | 112 | $settings_not_writable = !is_writable($boarddir . '/Settings.php'); |
112 | 113 | $settings_backup_fail = !@is_writable($boarddir . '/Settings_bak.php') || !@copy($boarddir . '/Settings.php', $boarddir . '/Settings_bak.php'); |
113 | 114 | |
114 | - if ($settings_not_writable) |
|
115 | - $context['settings_message'] = '<div class="centertext"><strong>' . $txt['settings_not_writable'] . '</strong></div><br>'; |
|
116 | - elseif ($settings_backup_fail) |
|
117 | - $context['settings_message'] = '<div class="centertext"><strong>' . $txt['admin_backup_fail'] . '</strong></div><br>'; |
|
115 | + if ($settings_not_writable) { |
|
116 | + $context['settings_message'] = '<div class="centertext"><strong>' . $txt['settings_not_writable'] . '</strong></div><br>'; |
|
117 | + } elseif ($settings_backup_fail) { |
|
118 | + $context['settings_message'] = '<div class="centertext"><strong>' . $txt['admin_backup_fail'] . '</strong></div><br>'; |
|
119 | + } |
|
118 | 120 | |
119 | 121 | $context['settings_not_writable'] = $settings_not_writable; |
120 | 122 | |
@@ -142,10 +144,11 @@ discard block |
||
142 | 144 | |
143 | 145 | // If no cert, force_ssl must remain 0 |
144 | 146 | require_once($sourcedir . '/Subs.php'); |
145 | - if (!ssl_cert_found($boardurl) && empty($modSettings['force_ssl'])) |
|
146 | - $disable_force_ssl = true; |
|
147 | - else |
|
148 | - $disable_force_ssl = false; |
|
147 | + if (!ssl_cert_found($boardurl) && empty($modSettings['force_ssl'])) { |
|
148 | + $disable_force_ssl = true; |
|
149 | + } else { |
|
150 | + $disable_force_ssl = false; |
|
151 | + } |
|
149 | 152 | |
150 | 153 | /* If you're writing a mod, it's a bad idea to add things here.... |
151 | 154 | For each option: |
@@ -175,8 +178,9 @@ discard block |
||
175 | 178 | |
176 | 179 | call_integration_hook('integrate_general_settings', array(&$config_vars)); |
177 | 180 | |
178 | - if ($return_config) |
|
179 | - return $config_vars; |
|
181 | + if ($return_config) { |
|
182 | + return $config_vars; |
|
183 | + } |
|
180 | 184 | |
181 | 185 | // Setup the template stuff. |
182 | 186 | $context['post_url'] = $scripturl . '?action=admin;area=serversettings;sa=general;save'; |
@@ -193,16 +197,18 @@ discard block |
||
193 | 197 | $registerSMStats = registerSMStats(); |
194 | 198 | |
195 | 199 | // Failed to register, disable it again. |
196 | - if (empty($registerSMStats)) |
|
197 | - $_POST['enable_sm_stats'] = 0; |
|
200 | + if (empty($registerSMStats)) { |
|
201 | + $_POST['enable_sm_stats'] = 0; |
|
202 | + } |
|
198 | 203 | } |
199 | 204 | |
200 | 205 | // Ensure all URLs are aligned with the new force_ssl setting |
201 | 206 | // Treat unset like 0 |
202 | - if (isset($_POST['force_ssl'])) |
|
203 | - AlignURLsWithSSLSetting($_POST['force_ssl']); |
|
204 | - else |
|
205 | - AlignURLsWithSSLSetting(0); |
|
207 | + if (isset($_POST['force_ssl'])) { |
|
208 | + AlignURLsWithSSLSetting($_POST['force_ssl']); |
|
209 | + } else { |
|
210 | + AlignURLsWithSSLSetting(0); |
|
211 | + } |
|
206 | 212 | |
207 | 213 | saveSettings($config_vars); |
208 | 214 | $_SESSION['adm-save'] = true; |
@@ -255,10 +261,11 @@ discard block |
||
255 | 261 | require_once($sourcedir . '/Subs-Admin.php'); |
256 | 262 | |
257 | 263 | // Check $boardurl |
258 | - if ($new_force_ssl == 2) |
|
259 | - $newval = strtr($boardurl, array('http://' => 'https://')); |
|
260 | - else |
|
261 | - $newval = strtr($boardurl, array('https://' => 'http://')); |
|
264 | + if ($new_force_ssl == 2) { |
|
265 | + $newval = strtr($boardurl, array('http://' => 'https://')); |
|
266 | + } else { |
|
267 | + $newval = strtr($boardurl, array('https://' => 'http://')); |
|
268 | + } |
|
262 | 269 | updateSettingsFile(array('boardurl' => '\'' . addslashes($newval) . '\'')); |
263 | 270 | |
264 | 271 | $new_settings = array(); |
@@ -266,20 +273,22 @@ discard block |
||
266 | 273 | // Check $smileys_url, but only if it points to a subfolder of $boardurl |
267 | 274 | if (BoardurlMatch($modSettings['smileys_url'])) |
268 | 275 | { |
269 | - if ($new_force_ssl == 2) |
|
270 | - $newval = strtr($modSettings['smileys_url'], array('http://' => 'https://')); |
|
271 | - else |
|
272 | - $newval = strtr($modSettings['smileys_url'], array('https://' => 'http://')); |
|
276 | + if ($new_force_ssl == 2) { |
|
277 | + $newval = strtr($modSettings['smileys_url'], array('http://' => 'https://')); |
|
278 | + } else { |
|
279 | + $newval = strtr($modSettings['smileys_url'], array('https://' => 'http://')); |
|
280 | + } |
|
273 | 281 | $new_settings['smileys_url'] = $newval; |
274 | 282 | } |
275 | 283 | |
276 | 284 | // Check $avatar_url, but only if it points to a subfolder of $boardurl |
277 | 285 | if (BoardurlMatch($modSettings['avatar_url'])) |
278 | 286 | { |
279 | - if ($new_force_ssl == 2) |
|
280 | - $newval = strtr($modSettings['avatar_url'], array('http://' => 'https://')); |
|
281 | - else |
|
282 | - $newval = strtr($modSettings['avatar_url'], array('https://' => 'http://')); |
|
287 | + if ($new_force_ssl == 2) { |
|
288 | + $newval = strtr($modSettings['avatar_url'], array('http://' => 'https://')); |
|
289 | + } else { |
|
290 | + $newval = strtr($modSettings['avatar_url'], array('https://' => 'http://')); |
|
291 | + } |
|
283 | 292 | $new_settings['avatar_url'] = $newval; |
284 | 293 | } |
285 | 294 | |
@@ -287,16 +296,18 @@ discard block |
||
287 | 296 | // This one had been optional in the past, make sure it is set first |
288 | 297 | if (isset($modSettings['custom_avatar_url']) && BoardurlMatch($modSettings['custom_avatar_url'])) |
289 | 298 | { |
290 | - if ($new_force_ssl == 2) |
|
291 | - $newval = strtr($modSettings['custom_avatar_url'], array('http://' => 'https://')); |
|
292 | - else |
|
293 | - $newval = strtr($modSettings['custom_avatar_url'], array('https://' => 'http://')); |
|
299 | + if ($new_force_ssl == 2) { |
|
300 | + $newval = strtr($modSettings['custom_avatar_url'], array('http://' => 'https://')); |
|
301 | + } else { |
|
302 | + $newval = strtr($modSettings['custom_avatar_url'], array('https://' => 'http://')); |
|
303 | + } |
|
294 | 304 | $new_settings['custom_avatar_url'] = $newval; |
295 | 305 | } |
296 | 306 | |
297 | 307 | // Save updates to the settings table |
298 | - if (!empty($new_settings)) |
|
299 | - updateSettings($new_settings, true); |
|
308 | + if (!empty($new_settings)) { |
|
309 | + updateSettings($new_settings, true); |
|
310 | + } |
|
300 | 311 | |
301 | 312 | // Now we move onto the themes. |
302 | 313 | // First, get a list of theme URLs... |
@@ -317,10 +328,11 @@ discard block |
||
317 | 328 | // First check to see if it points to a subfolder of $boardurl |
318 | 329 | if (BoardurlMatch($row['value'])) |
319 | 330 | { |
320 | - if ($new_force_ssl == 2) |
|
321 | - $newval = strtr($row['value'], array('http://' => 'https://')); |
|
322 | - else |
|
323 | - $newval = strtr($row['value'], array('https://' => 'http://')); |
|
331 | + if ($new_force_ssl == 2) { |
|
332 | + $newval = strtr($row['value'], array('http://' => 'https://')); |
|
333 | + } else { |
|
334 | + $newval = strtr($row['value'], array('https://' => 'http://')); |
|
335 | + } |
|
324 | 336 | $smcFunc['db_query']('', ' |
325 | 337 | UPDATE {db_prefix}themes |
326 | 338 | SET value = {string:theme_val} |
@@ -360,11 +372,12 @@ discard block |
||
360 | 372 | |
361 | 373 | // If leftmost portion of path matches boardurl, return true |
362 | 374 | $result = strpos($urlpath, $boardurlpath); |
363 | - if ($result === false || $result != 0) |
|
364 | - return false; |
|
365 | - else |
|
366 | - return true; |
|
367 | -} |
|
375 | + if ($result === false || $result != 0) { |
|
376 | + return false; |
|
377 | + } else { |
|
378 | + return true; |
|
379 | + } |
|
380 | + } |
|
368 | 381 | |
369 | 382 | /** |
370 | 383 | * Basic database and paths settings - database name, host, etc. |
@@ -402,8 +415,9 @@ discard block |
||
402 | 415 | $request = $smcFunc['db_query']('', 'SELECT cfgname FROM pg_ts_config', array()); |
403 | 416 | $fts_language = array(); |
404 | 417 | |
405 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
406 | - $fts_language[$row['cfgname']] = $row['cfgname']; |
|
418 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
419 | + $fts_language[$row['cfgname']] = $row['cfgname']; |
|
420 | + } |
|
407 | 421 | |
408 | 422 | $config_vars = array_merge ($config_vars, array( |
409 | 423 | '', |
@@ -415,8 +429,9 @@ discard block |
||
415 | 429 | |
416 | 430 | call_integration_hook('integrate_database_settings', array(&$config_vars)); |
417 | 431 | |
418 | - if ($return_config) |
|
419 | - return $config_vars; |
|
432 | + if ($return_config) { |
|
433 | + return $config_vars; |
|
434 | + } |
|
420 | 435 | |
421 | 436 | // Setup the template stuff. |
422 | 437 | $context['post_url'] = $scripturl . '?action=admin;area=serversettings;sa=database;save'; |
@@ -491,13 +506,15 @@ discard block |
||
491 | 506 | hideGlobalCookies(); |
492 | 507 | });', true); |
493 | 508 | |
494 | - if (empty($user_settings['tfa_secret'])) |
|
495 | - addInlineJavaScript(''); |
|
509 | + if (empty($user_settings['tfa_secret'])) { |
|
510 | + addInlineJavaScript(''); |
|
511 | + } |
|
496 | 512 | |
497 | 513 | call_integration_hook('integrate_cookie_settings', array(&$config_vars)); |
498 | 514 | |
499 | - if ($return_config) |
|
500 | - return $config_vars; |
|
515 | + if ($return_config) { |
|
516 | + return $config_vars; |
|
517 | + } |
|
501 | 518 | |
502 | 519 | $context['post_url'] = $scripturl . '?action=admin;area=serversettings;sa=cookie;save'; |
503 | 520 | $context['settings_title'] = $txt['cookies_sessions_settings']; |
@@ -508,11 +525,13 @@ discard block |
||
508 | 525 | call_integration_hook('integrate_save_cookie_settings'); |
509 | 526 | |
510 | 527 | // Local and global do not play nicely together. |
511 | - if (!empty($_POST['localCookies']) && empty($_POST['globalCookies'])) |
|
512 | - unset ($_POST['globalCookies']); |
|
528 | + if (!empty($_POST['localCookies']) && empty($_POST['globalCookies'])) { |
|
529 | + unset ($_POST['globalCookies']); |
|
530 | + } |
|
513 | 531 | |
514 | - if (!empty($_POST['globalCookiesDomain']) && strpos($boardurl, $_POST['globalCookiesDomain']) === false) |
|
515 | - fatal_lang_error('invalid_cookie_domain', false); |
|
532 | + if (!empty($_POST['globalCookiesDomain']) && strpos($boardurl, $_POST['globalCookiesDomain']) === false) { |
|
533 | + fatal_lang_error('invalid_cookie_domain', false); |
|
534 | + } |
|
516 | 535 | |
517 | 536 | saveSettings($config_vars); |
518 | 537 | |
@@ -595,8 +614,9 @@ discard block |
||
595 | 614 | |
596 | 615 | call_integration_hook('integrate_general_security_settings', array(&$config_vars)); |
597 | 616 | |
598 | - if ($return_config) |
|
599 | - return $config_vars; |
|
617 | + if ($return_config) { |
|
618 | + return $config_vars; |
|
619 | + } |
|
600 | 620 | |
601 | 621 | // Saving? |
602 | 622 | if (isset($_GET['save'])) |
@@ -635,8 +655,7 @@ discard block |
||
635 | 655 | $txt['cache_settings_message'] = $txt['detected_no_caching']; |
636 | 656 | $cache_level = array($txt['cache_off']); |
637 | 657 | $detected['none'] = $txt['cache_off']; |
638 | - } |
|
639 | - else |
|
658 | + } else |
|
640 | 659 | { |
641 | 660 | $txt['cache_settings_message'] = sprintf($txt['detected_accelerators'], implode(', ', $detected)); |
642 | 661 | $cache_level = array($txt['cache_off'], $txt['cache_level1'], $txt['cache_level2'], $txt['cache_level3']); |
@@ -673,8 +692,9 @@ discard block |
||
673 | 692 | } |
674 | 693 | } |
675 | 694 | } |
676 | - if ($return_config) |
|
677 | - return $config_vars; |
|
695 | + if ($return_config) { |
|
696 | + return $config_vars; |
|
697 | + } |
|
678 | 698 | |
679 | 699 | // Saving again? |
680 | 700 | if (isset($_GET['save'])) |
@@ -702,8 +722,9 @@ discard block |
||
702 | 722 | $context['save_disabled'] = $context['settings_not_writable']; |
703 | 723 | |
704 | 724 | // Decide what message to show. |
705 | - if (!$context['save_disabled']) |
|
706 | - $context['settings_message'] = $txt['caching_information']; |
|
725 | + if (!$context['save_disabled']) { |
|
726 | + $context['settings_message'] = $txt['caching_information']; |
|
727 | + } |
|
707 | 728 | |
708 | 729 | // Prepare the template. |
709 | 730 | prepareServerSettingsContext($config_vars); |
@@ -726,24 +747,25 @@ discard block |
||
726 | 747 | if (stripos(PHP_OS, 'win') === 0) |
727 | 748 | { |
728 | 749 | $context['settings_message'] = $txt['loadavg_disabled_windows']; |
729 | - if (isset($_GET['save'])) |
|
730 | - $_SESSION['adm-save'] = $txt['loadavg_disabled_windows']; |
|
731 | - } |
|
732 | - elseif (stripos(PHP_OS, 'darwin') === 0) |
|
750 | + if (isset($_GET['save'])) { |
|
751 | + $_SESSION['adm-save'] = $txt['loadavg_disabled_windows']; |
|
752 | + } |
|
753 | + } elseif (stripos(PHP_OS, 'darwin') === 0) |
|
733 | 754 | { |
734 | 755 | $context['settings_message'] = $txt['loadavg_disabled_osx']; |
735 | - if (isset($_GET['save'])) |
|
736 | - $_SESSION['adm-save'] = $txt['loadavg_disabled_osx']; |
|
737 | - } |
|
738 | - else |
|
756 | + if (isset($_GET['save'])) { |
|
757 | + $_SESSION['adm-save'] = $txt['loadavg_disabled_osx']; |
|
758 | + } |
|
759 | + } else |
|
739 | 760 | { |
740 | 761 | $modSettings['load_average'] = @file_get_contents('/proc/loadavg'); |
741 | - if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) !== 0) |
|
742 | - $modSettings['load_average'] = (float) $matches[1]; |
|
743 | - elseif (($modSettings['load_average'] = @`uptime`) !== null && preg_match('~load averages?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) !== 0) |
|
744 | - $modSettings['load_average'] = (float) $matches[1]; |
|
745 | - else |
|
746 | - unset($modSettings['load_average']); |
|
762 | + if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) !== 0) { |
|
763 | + $modSettings['load_average'] = (float) $matches[1]; |
|
764 | + } elseif (($modSettings['load_average'] = @`uptime`) !== null && preg_match('~load averages?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) !== 0) { |
|
765 | + $modSettings['load_average'] = (float) $matches[1]; |
|
766 | + } else { |
|
767 | + unset($modSettings['load_average']); |
|
768 | + } |
|
747 | 769 | |
748 | 770 | if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
749 | 771 | { |
@@ -779,8 +801,9 @@ discard block |
||
779 | 801 | |
780 | 802 | call_integration_hook('integrate_loadavg_settings', array(&$config_vars)); |
781 | 803 | |
782 | - if ($return_config) |
|
783 | - return $config_vars; |
|
804 | + if ($return_config) { |
|
805 | + return $config_vars; |
|
806 | + } |
|
784 | 807 | |
785 | 808 | $context['post_url'] = $scripturl . '?action=admin;area=serversettings;sa=loads;save'; |
786 | 809 | $context['settings_title'] = $txt['load_balancing_settings']; |
@@ -791,24 +814,27 @@ discard block |
||
791 | 814 | // Stupidity is not allowed. |
792 | 815 | foreach ($_POST as $key => $value) |
793 | 816 | { |
794 | - if (strpos($key, 'loadavg') === 0 || $key === 'loadavg_enable' || !in_array($key, array_keys($default_values))) |
|
795 | - continue; |
|
796 | - else |
|
797 | - $_POST[$key] = (float) $value; |
|
798 | - |
|
799 | - if ($key == 'loadavg_auto_opt' && $value <= 1) |
|
800 | - $_POST['loadavg_auto_opt'] = 1.0; |
|
801 | - elseif ($key == 'loadavg_forum' && $value < 10) |
|
802 | - $_POST['loadavg_forum'] = 10.0; |
|
803 | - elseif ($value < 2) |
|
804 | - $_POST[$key] = 2.0; |
|
817 | + if (strpos($key, 'loadavg') === 0 || $key === 'loadavg_enable' || !in_array($key, array_keys($default_values))) { |
|
818 | + continue; |
|
819 | + } else { |
|
820 | + $_POST[$key] = (float) $value; |
|
821 | + } |
|
822 | + |
|
823 | + if ($key == 'loadavg_auto_opt' && $value <= 1) { |
|
824 | + $_POST['loadavg_auto_opt'] = 1.0; |
|
825 | + } elseif ($key == 'loadavg_forum' && $value < 10) { |
|
826 | + $_POST['loadavg_forum'] = 10.0; |
|
827 | + } elseif ($value < 2) { |
|
828 | + $_POST[$key] = 2.0; |
|
829 | + } |
|
805 | 830 | } |
806 | 831 | |
807 | 832 | call_integration_hook('integrate_save_loadavg_settings'); |
808 | 833 | |
809 | 834 | saveDBSettings($config_vars); |
810 | - if (!isset($_SESSION['adm-save'])) |
|
811 | - $_SESSION['adm-save'] = true; |
|
835 | + if (!isset($_SESSION['adm-save'])) { |
|
836 | + $_SESSION['adm-save'] = true; |
|
837 | + } |
|
812 | 838 | redirectexit('action=admin;area=serversettings;sa=loads;' . $context['session_var'] . '=' . $context['session_id']); |
813 | 839 | } |
814 | 840 | |
@@ -844,10 +870,11 @@ discard block |
||
844 | 870 | |
845 | 871 | if (isset($_SESSION['adm-save'])) |
846 | 872 | { |
847 | - if ($_SESSION['adm-save'] === true) |
|
848 | - $context['saved_successful'] = true; |
|
849 | - else |
|
850 | - $context['saved_failed'] = $_SESSION['adm-save']; |
|
873 | + if ($_SESSION['adm-save'] === true) { |
|
874 | + $context['saved_successful'] = true; |
|
875 | + } else { |
|
876 | + $context['saved_failed'] = $_SESSION['adm-save']; |
|
877 | + } |
|
851 | 878 | |
852 | 879 | unset($_SESSION['adm-save']); |
853 | 880 | } |
@@ -855,9 +882,9 @@ discard block |
||
855 | 882 | $context['config_vars'] = array(); |
856 | 883 | foreach ($config_vars as $identifier => $config_var) |
857 | 884 | { |
858 | - if (!is_array($config_var) || !isset($config_var[1])) |
|
859 | - $context['config_vars'][] = $config_var; |
|
860 | - else |
|
885 | + if (!is_array($config_var) || !isset($config_var[1])) { |
|
886 | + $context['config_vars'][] = $config_var; |
|
887 | + } else |
|
861 | 888 | { |
862 | 889 | $varname = $config_var[0]; |
863 | 890 | global $$varname; |
@@ -892,16 +919,19 @@ discard block |
||
892 | 919 | if ($config_var[3] == 'int' || $config_var[3] == 'float') |
893 | 920 | { |
894 | 921 | // Default to a min of 0 if one isn't set |
895 | - if (isset($config_var['min'])) |
|
896 | - $context['config_vars'][$config_var[0]]['min'] = $config_var['min']; |
|
897 | - else |
|
898 | - $context['config_vars'][$config_var[0]]['min'] = 0; |
|
922 | + if (isset($config_var['min'])) { |
|
923 | + $context['config_vars'][$config_var[0]]['min'] = $config_var['min']; |
|
924 | + } else { |
|
925 | + $context['config_vars'][$config_var[0]]['min'] = 0; |
|
926 | + } |
|
899 | 927 | |
900 | - if (isset($config_var['max'])) |
|
901 | - $context['config_vars'][$config_var[0]]['max'] = $config_var['max']; |
|
928 | + if (isset($config_var['max'])) { |
|
929 | + $context['config_vars'][$config_var[0]]['max'] = $config_var['max']; |
|
930 | + } |
|
902 | 931 | |
903 | - if (isset($config_var['step'])) |
|
904 | - $context['config_vars'][$config_var[0]]['step'] = $config_var['step']; |
|
932 | + if (isset($config_var['step'])) { |
|
933 | + $context['config_vars'][$config_var[0]]['step'] = $config_var['step']; |
|
934 | + } |
|
905 | 935 | } |
906 | 936 | |
907 | 937 | // If this is a select box handle any data. |
@@ -909,12 +939,13 @@ discard block |
||
909 | 939 | { |
910 | 940 | // If it's associative |
911 | 941 | $config_values = array_values($config_var[4]); |
912 | - if (isset($config_values[0]) && is_array($config_values[0])) |
|
913 | - $context['config_vars'][$config_var[0]]['data'] = $config_var[4]; |
|
914 | - else |
|
942 | + if (isset($config_values[0]) && is_array($config_values[0])) { |
|
943 | + $context['config_vars'][$config_var[0]]['data'] = $config_var[4]; |
|
944 | + } else |
|
915 | 945 | { |
916 | - foreach ($config_var[4] as $key => $item) |
|
917 | - $context['config_vars'][$config_var[0]]['data'][] = array($key, $item); |
|
946 | + foreach ($config_var[4] as $key => $item) { |
|
947 | + $context['config_vars'][$config_var[0]]['data'][] = array($key, $item); |
|
948 | + } |
|
918 | 949 | } |
919 | 950 | } |
920 | 951 | } |
@@ -939,10 +970,11 @@ discard block |
||
939 | 970 | |
940 | 971 | if (isset($_SESSION['adm-save'])) |
941 | 972 | { |
942 | - if ($_SESSION['adm-save'] === true) |
|
943 | - $context['saved_successful'] = true; |
|
944 | - else |
|
945 | - $context['saved_failed'] = $_SESSION['adm-save']; |
|
973 | + if ($_SESSION['adm-save'] === true) { |
|
974 | + $context['saved_successful'] = true; |
|
975 | + } else { |
|
976 | + $context['saved_failed'] = $_SESSION['adm-save']; |
|
977 | + } |
|
946 | 978 | |
947 | 979 | unset($_SESSION['adm-save']); |
948 | 980 | } |
@@ -954,26 +986,30 @@ discard block |
||
954 | 986 | foreach ($config_vars as $config_var) |
955 | 987 | { |
956 | 988 | // HR? |
957 | - if (!is_array($config_var)) |
|
958 | - $context['config_vars'][] = $config_var; |
|
959 | - else |
|
989 | + if (!is_array($config_var)) { |
|
990 | + $context['config_vars'][] = $config_var; |
|
991 | + } else |
|
960 | 992 | { |
961 | 993 | // If it has no name it doesn't have any purpose! |
962 | - if (empty($config_var[1])) |
|
963 | - continue; |
|
994 | + if (empty($config_var[1])) { |
|
995 | + continue; |
|
996 | + } |
|
964 | 997 | |
965 | 998 | // Special case for inline permissions |
966 | - if ($config_var[0] == 'permissions' && allowedTo('manage_permissions')) |
|
967 | - $inlinePermissions[] = $config_var[1]; |
|
968 | - elseif ($config_var[0] == 'permissions') |
|
969 | - continue; |
|
999 | + if ($config_var[0] == 'permissions' && allowedTo('manage_permissions')) { |
|
1000 | + $inlinePermissions[] = $config_var[1]; |
|
1001 | + } elseif ($config_var[0] == 'permissions') { |
|
1002 | + continue; |
|
1003 | + } |
|
970 | 1004 | |
971 | - if ($config_var[0] == 'boards') |
|
972 | - $board_list = true; |
|
1005 | + if ($config_var[0] == 'boards') { |
|
1006 | + $board_list = true; |
|
1007 | + } |
|
973 | 1008 | |
974 | 1009 | // Are we showing the BBC selection box? |
975 | - if ($config_var[0] == 'bbc') |
|
976 | - $bbcChoice[] = $config_var[1]; |
|
1010 | + if ($config_var[0] == 'bbc') { |
|
1011 | + $bbcChoice[] = $config_var[1]; |
|
1012 | + } |
|
977 | 1013 | |
978 | 1014 | // We need to do some parsing of the value before we pass it in. |
979 | 1015 | if (isset($modSettings[$config_var[1]])) |
@@ -992,8 +1028,7 @@ discard block |
||
992 | 1028 | default: |
993 | 1029 | $value = $smcFunc['htmlspecialchars']($modSettings[$config_var[1]]); |
994 | 1030 | } |
995 | - } |
|
996 | - else |
|
1031 | + } else |
|
997 | 1032 | { |
998 | 1033 | // Darn, it's empty. What type is expected? |
999 | 1034 | switch ($config_var[0]) |
@@ -1033,16 +1068,19 @@ discard block |
||
1033 | 1068 | if ($config_var[0] == 'int' || $config_var[0] == 'float') |
1034 | 1069 | { |
1035 | 1070 | // Default to a min of 0 if one isn't set |
1036 | - if (isset($config_var['min'])) |
|
1037 | - $context['config_vars'][$config_var[1]]['min'] = $config_var['min']; |
|
1038 | - else |
|
1039 | - $context['config_vars'][$config_var[1]]['min'] = 0; |
|
1071 | + if (isset($config_var['min'])) { |
|
1072 | + $context['config_vars'][$config_var[1]]['min'] = $config_var['min']; |
|
1073 | + } else { |
|
1074 | + $context['config_vars'][$config_var[1]]['min'] = 0; |
|
1075 | + } |
|
1040 | 1076 | |
1041 | - if (isset($config_var['max'])) |
|
1042 | - $context['config_vars'][$config_var[1]]['max'] = $config_var['max']; |
|
1077 | + if (isset($config_var['max'])) { |
|
1078 | + $context['config_vars'][$config_var[1]]['max'] = $config_var['max']; |
|
1079 | + } |
|
1043 | 1080 | |
1044 | - if (isset($config_var['step'])) |
|
1045 | - $context['config_vars'][$config_var[1]]['step'] = $config_var['step']; |
|
1081 | + if (isset($config_var['step'])) { |
|
1082 | + $context['config_vars'][$config_var[1]]['step'] = $config_var['step']; |
|
1083 | + } |
|
1046 | 1084 | } |
1047 | 1085 | |
1048 | 1086 | // If this is a select box handle any data. |
@@ -1056,12 +1094,13 @@ discard block |
||
1056 | 1094 | } |
1057 | 1095 | |
1058 | 1096 | // If it's associative |
1059 | - if (isset($config_var[2][0]) && is_array($config_var[2][0])) |
|
1060 | - $context['config_vars'][$config_var[1]]['data'] = $config_var[2]; |
|
1061 | - else |
|
1097 | + if (isset($config_var[2][0]) && is_array($config_var[2][0])) { |
|
1098 | + $context['config_vars'][$config_var[1]]['data'] = $config_var[2]; |
|
1099 | + } else |
|
1062 | 1100 | { |
1063 | - foreach ($config_var[2] as $key => $item) |
|
1064 | - $context['config_vars'][$config_var[1]]['data'][] = array($key, $item); |
|
1101 | + foreach ($config_var[2] as $key => $item) { |
|
1102 | + $context['config_vars'][$config_var[1]]['data'][] = array($key, $item); |
|
1103 | + } |
|
1065 | 1104 | } |
1066 | 1105 | } |
1067 | 1106 | |
@@ -1070,17 +1109,19 @@ discard block |
||
1070 | 1109 | { |
1071 | 1110 | if (!is_numeric($k)) |
1072 | 1111 | { |
1073 | - if (substr($k, 0, 2) == 'on') |
|
1074 | - $context['config_vars'][$config_var[1]]['javascript'] .= ' ' . $k . '="' . $v . '"'; |
|
1075 | - else |
|
1076 | - $context['config_vars'][$config_var[1]][$k] = $v; |
|
1112 | + if (substr($k, 0, 2) == 'on') { |
|
1113 | + $context['config_vars'][$config_var[1]]['javascript'] .= ' ' . $k . '="' . $v . '"'; |
|
1114 | + } else { |
|
1115 | + $context['config_vars'][$config_var[1]][$k] = $v; |
|
1116 | + } |
|
1077 | 1117 | } |
1078 | 1118 | |
1079 | 1119 | // See if there are any other labels that might fit? |
1080 | - if (isset($txt['setting_' . $config_var[1]])) |
|
1081 | - $context['config_vars'][$config_var[1]]['label'] = $txt['setting_' . $config_var[1]]; |
|
1082 | - elseif (isset($txt['groups_' . $config_var[1]])) |
|
1083 | - $context['config_vars'][$config_var[1]]['label'] = $txt['groups_' . $config_var[1]]; |
|
1120 | + if (isset($txt['setting_' . $config_var[1]])) { |
|
1121 | + $context['config_vars'][$config_var[1]]['label'] = $txt['setting_' . $config_var[1]]; |
|
1122 | + } elseif (isset($txt['groups_' . $config_var[1]])) { |
|
1123 | + $context['config_vars'][$config_var[1]]['label'] = $txt['groups_' . $config_var[1]]; |
|
1124 | + } |
|
1084 | 1125 | } |
1085 | 1126 | |
1086 | 1127 | // Set the subtext in case it's part of the label. |
@@ -1113,8 +1154,9 @@ discard block |
||
1113 | 1154 | // What are the options, eh? |
1114 | 1155 | $temp = parse_bbc(false); |
1115 | 1156 | $bbcTags = array(); |
1116 | - foreach ($temp as $tag) |
|
1117 | - $bbcTags[] = $tag['tag']; |
|
1157 | + foreach ($temp as $tag) { |
|
1158 | + $bbcTags[] = $tag['tag']; |
|
1159 | + } |
|
1118 | 1160 | |
1119 | 1161 | $bbcTags = array_unique($bbcTags); |
1120 | 1162 | $totalTags = count($bbcTags); |
@@ -1129,8 +1171,9 @@ discard block |
||
1129 | 1171 | $col = 0; $i = 0; |
1130 | 1172 | foreach ($bbcTags as $tag) |
1131 | 1173 | { |
1132 | - if ($i % $tagsPerColumn == 0 && $i != 0) |
|
1133 | - $col++; |
|
1174 | + if ($i % $tagsPerColumn == 0 && $i != 0) { |
|
1175 | + $col++; |
|
1176 | + } |
|
1134 | 1177 | |
1135 | 1178 | $context['bbc_columns'][$col][] = array( |
1136 | 1179 | 'tag' => $tag, |
@@ -1173,18 +1216,21 @@ discard block |
||
1173 | 1216 | validateToken('admin-ssc'); |
1174 | 1217 | |
1175 | 1218 | // Fix the darn stupid cookiename! (more may not be allowed, but these for sure!) |
1176 | - if (isset($_POST['cookiename'])) |
|
1177 | - $_POST['cookiename'] = preg_replace('~[,;\s\.$]+~' . ($context['utf8'] ? 'u' : ''), '', $_POST['cookiename']); |
|
1219 | + if (isset($_POST['cookiename'])) { |
|
1220 | + $_POST['cookiename'] = preg_replace('~[,;\s\.$]+~' . ($context['utf8'] ? 'u' : ''), '', $_POST['cookiename']); |
|
1221 | + } |
|
1178 | 1222 | |
1179 | 1223 | // Fix the forum's URL if necessary. |
1180 | 1224 | if (isset($_POST['boardurl'])) |
1181 | 1225 | { |
1182 | - if (substr($_POST['boardurl'], -10) == '/index.php') |
|
1183 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
1184 | - elseif (substr($_POST['boardurl'], -1) == '/') |
|
1185 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
1186 | - if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') |
|
1187 | - $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
1226 | + if (substr($_POST['boardurl'], -10) == '/index.php') { |
|
1227 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
1228 | + } elseif (substr($_POST['boardurl'], -1) == '/') { |
|
1229 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
1230 | + } |
|
1231 | + if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') { |
|
1232 | + $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
1233 | + } |
|
1188 | 1234 | } |
1189 | 1235 | |
1190 | 1236 | // Any passwords? |
@@ -1219,21 +1265,21 @@ discard block |
||
1219 | 1265 | // Figure out which config vars we're saving here... |
1220 | 1266 | foreach ($config_vars as $var) |
1221 | 1267 | { |
1222 | - if (!is_array($var) || $var[2] != 'file' || (!in_array($var[0], $config_bools) && !isset($_POST[$var[0]]))) |
|
1223 | - continue; |
|
1268 | + if (!is_array($var) || $var[2] != 'file' || (!in_array($var[0], $config_bools) && !isset($_POST[$var[0]]))) { |
|
1269 | + continue; |
|
1270 | + } |
|
1224 | 1271 | |
1225 | 1272 | $config_var = $var[0]; |
1226 | 1273 | |
1227 | 1274 | if (in_array($config_var, $config_passwords)) |
1228 | 1275 | { |
1229 | - if (isset($_POST[$config_var][1]) && $_POST[$config_var][0] == $_POST[$config_var][1]) |
|
1230 | - $new_settings[$config_var] = '\'' . addcslashes($_POST[$config_var][0], '\'\\') . '\''; |
|
1231 | - } |
|
1232 | - elseif (in_array($config_var, $config_strs)) |
|
1276 | + if (isset($_POST[$config_var][1]) && $_POST[$config_var][0] == $_POST[$config_var][1]) { |
|
1277 | + $new_settings[$config_var] = '\'' . addcslashes($_POST[$config_var][0], '\'\\') . '\''; |
|
1278 | + } |
|
1279 | + } elseif (in_array($config_var, $config_strs)) |
|
1233 | 1280 | { |
1234 | 1281 | $new_settings[$config_var] = '\'' . addcslashes($_POST[$config_var], '\'\\') . '\''; |
1235 | - } |
|
1236 | - elseif (in_array($config_var, $config_ints)) |
|
1282 | + } elseif (in_array($config_var, $config_ints)) |
|
1237 | 1283 | { |
1238 | 1284 | $new_settings[$config_var] = (int) $_POST[$config_var]; |
1239 | 1285 | |
@@ -1242,17 +1288,17 @@ discard block |
||
1242 | 1288 | $new_settings[$config_var] = max($min, $new_settings[$config_var]); |
1243 | 1289 | |
1244 | 1290 | // Is there a max value for this as well? |
1245 | - if (isset($var['max'])) |
|
1246 | - $new_settings[$config_var] = min($var['max'], $new_settings[$config_var]); |
|
1247 | - } |
|
1248 | - elseif (in_array($config_var, $config_bools)) |
|
1291 | + if (isset($var['max'])) { |
|
1292 | + $new_settings[$config_var] = min($var['max'], $new_settings[$config_var]); |
|
1293 | + } |
|
1294 | + } elseif (in_array($config_var, $config_bools)) |
|
1249 | 1295 | { |
1250 | - if (!empty($_POST[$config_var])) |
|
1251 | - $new_settings[$config_var] = '1'; |
|
1252 | - else |
|
1253 | - $new_settings[$config_var] = '0'; |
|
1254 | - } |
|
1255 | - else |
|
1296 | + if (!empty($_POST[$config_var])) { |
|
1297 | + $new_settings[$config_var] = '1'; |
|
1298 | + } else { |
|
1299 | + $new_settings[$config_var] = '0'; |
|
1300 | + } |
|
1301 | + } else |
|
1256 | 1302 | { |
1257 | 1303 | // This shouldn't happen, but it might... |
1258 | 1304 | fatal_error('Unknown config_var \'' . $config_var . '\''); |
@@ -1268,30 +1314,35 @@ discard block |
||
1268 | 1314 | foreach ($config_vars as $config_var) |
1269 | 1315 | { |
1270 | 1316 | // We just saved the file-based settings, so skip their definitions. |
1271 | - if (!is_array($config_var) || $config_var[2] == 'file') |
|
1272 | - continue; |
|
1317 | + if (!is_array($config_var) || $config_var[2] == 'file') { |
|
1318 | + continue; |
|
1319 | + } |
|
1273 | 1320 | |
1274 | 1321 | $new_setting = array($config_var[3], $config_var[0]); |
1275 | 1322 | |
1276 | 1323 | // Select options need carried over, too. |
1277 | - if (isset($config_var[4])) |
|
1278 | - $new_setting[] = $config_var[4]; |
|
1324 | + if (isset($config_var[4])) { |
|
1325 | + $new_setting[] = $config_var[4]; |
|
1326 | + } |
|
1279 | 1327 | |
1280 | 1328 | // Include min and max if necessary |
1281 | - if (isset($config_var['min'])) |
|
1282 | - $new_setting['min'] = $config_var['min']; |
|
1329 | + if (isset($config_var['min'])) { |
|
1330 | + $new_setting['min'] = $config_var['min']; |
|
1331 | + } |
|
1283 | 1332 | |
1284 | - if (isset($config_var['max'])) |
|
1285 | - $new_setting['max'] = $config_var['max']; |
|
1333 | + if (isset($config_var['max'])) { |
|
1334 | + $new_setting['max'] = $config_var['max']; |
|
1335 | + } |
|
1286 | 1336 | |
1287 | 1337 | // Rewrite the definition a bit. |
1288 | 1338 | $new_settings[] = $new_setting; |
1289 | 1339 | } |
1290 | 1340 | |
1291 | 1341 | // Save the new database-based settings, if any. |
1292 | - if (!empty($new_settings)) |
|
1293 | - saveDBSettings($new_settings); |
|
1294 | -} |
|
1342 | + if (!empty($new_settings)) { |
|
1343 | + saveDBSettings($new_settings); |
|
1344 | + } |
|
1345 | + } |
|
1295 | 1346 | |
1296 | 1347 | /** |
1297 | 1348 | * Helper function for saving database settings. |
@@ -1309,22 +1360,25 @@ discard block |
||
1309 | 1360 | $inlinePermissions = array(); |
1310 | 1361 | foreach ($config_vars as $var) |
1311 | 1362 | { |
1312 | - if (!isset($var[1]) || (!isset($_POST[$var[1]]) && $var[0] != 'check' && $var[0] != 'permissions' && $var[0] != 'boards' && ($var[0] != 'bbc' || !isset($_POST[$var[1] . '_enabledTags'])))) |
|
1313 | - continue; |
|
1363 | + if (!isset($var[1]) || (!isset($_POST[$var[1]]) && $var[0] != 'check' && $var[0] != 'permissions' && $var[0] != 'boards' && ($var[0] != 'bbc' || !isset($_POST[$var[1] . '_enabledTags'])))) { |
|
1364 | + continue; |
|
1365 | + } |
|
1314 | 1366 | |
1315 | 1367 | // Checkboxes! |
1316 | - elseif ($var[0] == 'check') |
|
1317 | - $setArray[$var[1]] = !empty($_POST[$var[1]]) ? '1' : '0'; |
|
1368 | + elseif ($var[0] == 'check') { |
|
1369 | + $setArray[$var[1]] = !empty($_POST[$var[1]]) ? '1' : '0'; |
|
1370 | + } |
|
1318 | 1371 | // Select boxes! |
1319 | - elseif ($var[0] == 'select' && in_array($_POST[$var[1]], array_keys($var[2]))) |
|
1320 | - $setArray[$var[1]] = $_POST[$var[1]]; |
|
1321 | - elseif ($var[0] == 'select' && !empty($var['multiple']) && array_intersect($_POST[$var[1]], array_keys($var[2])) != array()) |
|
1372 | + elseif ($var[0] == 'select' && in_array($_POST[$var[1]], array_keys($var[2]))) { |
|
1373 | + $setArray[$var[1]] = $_POST[$var[1]]; |
|
1374 | + } elseif ($var[0] == 'select' && !empty($var['multiple']) && array_intersect($_POST[$var[1]], array_keys($var[2])) != array()) |
|
1322 | 1375 | { |
1323 | 1376 | // For security purposes we validate this line by line. |
1324 | 1377 | $lOptions = array(); |
1325 | - foreach ($_POST[$var[1]] as $invar) |
|
1326 | - if (in_array($invar, array_keys($var[2]))) |
|
1378 | + foreach ($_POST[$var[1]] as $invar) { |
|
1379 | + if (in_array($invar, array_keys($var[2]))) |
|
1327 | 1380 | $lOptions[] = $invar; |
1381 | + } |
|
1328 | 1382 | |
1329 | 1383 | $setArray[$var[1]] = $smcFunc['json_encode']($lOptions); |
1330 | 1384 | } |
@@ -1338,18 +1392,20 @@ discard block |
||
1338 | 1392 | $request = $smcFunc['db_query']('', ' |
1339 | 1393 | SELECT id_board |
1340 | 1394 | FROM {db_prefix}boards'); |
1341 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
1342 | - $board_list[$row[0]] = true; |
|
1395 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
1396 | + $board_list[$row[0]] = true; |
|
1397 | + } |
|
1343 | 1398 | |
1344 | 1399 | $smcFunc['db_free_result']($request); |
1345 | 1400 | } |
1346 | 1401 | |
1347 | 1402 | $lOptions = array(); |
1348 | 1403 | |
1349 | - if (!empty($_POST[$var[1]])) |
|
1350 | - foreach ($_POST[$var[1]] as $invar => $dummy) |
|
1404 | + if (!empty($_POST[$var[1]])) { |
|
1405 | + foreach ($_POST[$var[1]] as $invar => $dummy) |
|
1351 | 1406 | if (isset($board_list[$invar])) |
1352 | 1407 | $lOptions[] = $invar; |
1408 | + } |
|
1353 | 1409 | |
1354 | 1410 | $setArray[$var[1]] = !empty($lOptions) ? implode(',', $lOptions) : ''; |
1355 | 1411 | } |
@@ -1363,8 +1419,9 @@ discard block |
||
1363 | 1419 | $setArray[$var[1]] = max($min, $setArray[$var[1]]); |
1364 | 1420 | |
1365 | 1421 | // Do we have a max value for this as well? |
1366 | - if (isset($var['max'])) |
|
1367 | - $setArray[$var[1]] = min($var['max'], $setArray[$var[1]]); |
|
1422 | + if (isset($var['max'])) { |
|
1423 | + $setArray[$var[1]] = min($var['max'], $setArray[$var[1]]); |
|
1424 | + } |
|
1368 | 1425 | } |
1369 | 1426 | // Floating point! |
1370 | 1427 | elseif ($var[0] == 'float') |
@@ -1376,40 +1433,47 @@ discard block |
||
1376 | 1433 | $setArray[$var[1]] = max($min, $setArray[$var[1]]); |
1377 | 1434 | |
1378 | 1435 | // Do we have a max value for this as well? |
1379 | - if (isset($var['max'])) |
|
1380 | - $setArray[$var[1]] = min($var['max'], $setArray[$var[1]]); |
|
1436 | + if (isset($var['max'])) { |
|
1437 | + $setArray[$var[1]] = min($var['max'], $setArray[$var[1]]); |
|
1438 | + } |
|
1381 | 1439 | } |
1382 | 1440 | // Text! |
1383 | - elseif (in_array($var[0], array('text', 'large_text', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'time'))) |
|
1384 | - $setArray[$var[1]] = $_POST[$var[1]]; |
|
1441 | + elseif (in_array($var[0], array('text', 'large_text', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'time'))) { |
|
1442 | + $setArray[$var[1]] = $_POST[$var[1]]; |
|
1443 | + } |
|
1385 | 1444 | // Passwords! |
1386 | 1445 | elseif ($var[0] == 'password') |
1387 | 1446 | { |
1388 | - if (isset($_POST[$var[1]][1]) && $_POST[$var[1]][0] == $_POST[$var[1]][1]) |
|
1389 | - $setArray[$var[1]] = $_POST[$var[1]][0]; |
|
1447 | + if (isset($_POST[$var[1]][1]) && $_POST[$var[1]][0] == $_POST[$var[1]][1]) { |
|
1448 | + $setArray[$var[1]] = $_POST[$var[1]][0]; |
|
1449 | + } |
|
1390 | 1450 | } |
1391 | 1451 | // BBC. |
1392 | 1452 | elseif ($var[0] == 'bbc') |
1393 | 1453 | { |
1394 | 1454 | |
1395 | 1455 | $bbcTags = array(); |
1396 | - foreach (parse_bbc(false) as $tag) |
|
1397 | - $bbcTags[] = $tag['tag']; |
|
1456 | + foreach (parse_bbc(false) as $tag) { |
|
1457 | + $bbcTags[] = $tag['tag']; |
|
1458 | + } |
|
1398 | 1459 | |
1399 | - if (!isset($_POST[$var[1] . '_enabledTags'])) |
|
1400 | - $_POST[$var[1] . '_enabledTags'] = array(); |
|
1401 | - elseif (!is_array($_POST[$var[1] . '_enabledTags'])) |
|
1402 | - $_POST[$var[1] . '_enabledTags'] = array($_POST[$var[1] . '_enabledTags']); |
|
1460 | + if (!isset($_POST[$var[1] . '_enabledTags'])) { |
|
1461 | + $_POST[$var[1] . '_enabledTags'] = array(); |
|
1462 | + } elseif (!is_array($_POST[$var[1] . '_enabledTags'])) { |
|
1463 | + $_POST[$var[1] . '_enabledTags'] = array($_POST[$var[1] . '_enabledTags']); |
|
1464 | + } |
|
1403 | 1465 | |
1404 | 1466 | $setArray[$var[1]] = implode(',', array_diff($bbcTags, $_POST[$var[1] . '_enabledTags'])); |
1405 | 1467 | } |
1406 | 1468 | // Permissions? |
1407 | - elseif ($var[0] == 'permissions') |
|
1408 | - $inlinePermissions[] = $var[1]; |
|
1469 | + elseif ($var[0] == 'permissions') { |
|
1470 | + $inlinePermissions[] = $var[1]; |
|
1471 | + } |
|
1409 | 1472 | } |
1410 | 1473 | |
1411 | - if (!empty($setArray)) |
|
1412 | - updateSettings($setArray); |
|
1474 | + if (!empty($setArray)) { |
|
1475 | + updateSettings($setArray); |
|
1476 | + } |
|
1413 | 1477 | |
1414 | 1478 | // If we have inline permissions we need to save them. |
1415 | 1479 | if (!empty($inlinePermissions) && allowedTo('manage_permissions')) |
@@ -1446,18 +1510,21 @@ discard block |
||
1446 | 1510 | // put all of it into an array |
1447 | 1511 | foreach ($info_lines as $line) |
1448 | 1512 | { |
1449 | - if (preg_match('~(' . $remove . ')~', $line)) |
|
1450 | - continue; |
|
1513 | + if (preg_match('~(' . $remove . ')~', $line)) { |
|
1514 | + continue; |
|
1515 | + } |
|
1451 | 1516 | |
1452 | 1517 | // new category? |
1453 | - if (strpos($line, '<h2>') !== false) |
|
1454 | - $category = preg_match('~<h2>(.*)</h2>~', $line, $title) ? $category = $title[1] : $category; |
|
1518 | + if (strpos($line, '<h2>') !== false) { |
|
1519 | + $category = preg_match('~<h2>(.*)</h2>~', $line, $title) ? $category = $title[1] : $category; |
|
1520 | + } |
|
1455 | 1521 | |
1456 | 1522 | // load it as setting => value or the old setting local master |
1457 | - if (preg_match('~<tr><td[^>]+>([^<]*)</td><td[^>]+>([^<]*)</td></tr>~', $line, $val)) |
|
1458 | - $pinfo[$category][$val[1]] = $val[2]; |
|
1459 | - elseif (preg_match('~<tr><td[^>]+>([^<]*)</td><td[^>]+>([^<]*)</td><td[^>]+>([^<]*)</td></tr>~', $line, $val)) |
|
1460 | - $pinfo[$category][$val[1]] = array($txt['phpinfo_localsettings'] => $val[2], $txt['phpinfo_defaultsettings'] => $val[3]); |
|
1523 | + if (preg_match('~<tr><td[^>]+>([^<]*)</td><td[^>]+>([^<]*)</td></tr>~', $line, $val)) { |
|
1524 | + $pinfo[$category][$val[1]] = $val[2]; |
|
1525 | + } elseif (preg_match('~<tr><td[^>]+>([^<]*)</td><td[^>]+>([^<]*)</td><td[^>]+>([^<]*)</td></tr>~', $line, $val)) { |
|
1526 | + $pinfo[$category][$val[1]] = array($txt['phpinfo_localsettings'] => $val[2], $txt['phpinfo_defaultsettings'] => $val[3]); |
|
1527 | + } |
|
1461 | 1528 | } |
1462 | 1529 | |
1463 | 1530 | // load it in to context and display it |
@@ -1492,8 +1559,9 @@ discard block |
||
1492 | 1559 | $testAPI = new $cache_class_name(); |
1493 | 1560 | |
1494 | 1561 | // No Support? NEXT! |
1495 | - if (!$testAPI->isSupported(true)) |
|
1496 | - continue; |
|
1562 | + if (!$testAPI->isSupported(true)) { |
|
1563 | + continue; |
|
1564 | + } |
|
1497 | 1565 | |
1498 | 1566 | $apis[$tryCache] = isset($txt[$tryCache . '_cache']) ? $txt[$tryCache . '_cache'] : $tryCache; |
1499 | 1567 | } |
@@ -1518,8 +1586,9 @@ discard block |
||
1518 | 1586 | global $modSettings, $boardurl, $smcFunc; |
1519 | 1587 | |
1520 | 1588 | // Already have a key? Can't register again. |
1521 | - if (!empty($modSettings['sm_stats_key'])) |
|
1522 | - return true; |
|
1589 | + if (!empty($modSettings['sm_stats_key'])) { |
|
1590 | + return true; |
|
1591 | + } |
|
1523 | 1592 | |
1524 | 1593 | $fp = @fsockopen('www.simplemachines.org', 80, $errno, $errstr); |
1525 | 1594 | if ($fp) |
@@ -1530,8 +1599,9 @@ discard block |
||
1530 | 1599 | fwrite($fp, $out); |
1531 | 1600 | |
1532 | 1601 | $return_data = ''; |
1533 | - while (!feof($fp)) |
|
1534 | - $return_data .= fgets($fp, 128); |
|
1602 | + while (!feof($fp)) { |
|
1603 | + $return_data .= fgets($fp, 128); |
|
1604 | + } |
|
1535 | 1605 | |
1536 | 1606 | fclose($fp); |
1537 | 1607 |
@@ -38,12 +38,12 @@ discard block |
||
38 | 38 | $version = $smcFunc['db_get_version'](); |
39 | 39 | // if we got a Beta Version |
40 | 40 | if (stripos($version, 'beta') !== false) |
41 | - $version = substr($version, 0, stripos($version, 'beta')).'.0'; |
|
41 | + $version = substr($version, 0, stripos($version, 'beta')) . '.0'; |
|
42 | 42 | // or RC |
43 | 43 | if (stripos($version, 'rc') !== false) |
44 | - $version = substr($version, 0, stripos($version, 'rc')).'.0'; |
|
44 | + $version = substr($version, 0, stripos($version, 'rc')) . '.0'; |
|
45 | 45 | |
46 | - if (version_compare($version,'9.5.0','>=')) |
|
46 | + if (version_compare($version, '9.5.0', '>=')) |
|
47 | 47 | $smcFunc['db_support_ignore'] = true; |
48 | 48 | } |
49 | 49 | |
@@ -55,7 +55,7 @@ discard block |
||
55 | 55 | */ |
56 | 56 | function smf_db_search_support($search_type) |
57 | 57 | { |
58 | - $supported_types = array('custom','fulltext'); |
|
58 | + $supported_types = array('custom', 'fulltext'); |
|
59 | 59 | |
60 | 60 | return in_array($search_type, $supported_types); |
61 | 61 | } |
@@ -109,9 +109,9 @@ discard block |
||
109 | 109 | if (preg_match('~^\s*INSERT\sIGNORE~i', $db_string) != 0) |
110 | 110 | { |
111 | 111 | $db_string = preg_replace('~^\s*INSERT\sIGNORE~i', 'INSERT', $db_string); |
112 | - if ($smcFunc['db_support_ignore']){ |
|
112 | + if ($smcFunc['db_support_ignore']) { |
|
113 | 113 | //pg style "INSERT INTO.... ON CONFLICT DO NOTHING" |
114 | - $db_string = $db_string.' ON CONFLICT DO NOTHING'; |
|
114 | + $db_string = $db_string . ' ON CONFLICT DO NOTHING'; |
|
115 | 115 | } |
116 | 116 | else |
117 | 117 | { |
@@ -168,7 +168,7 @@ discard block |
||
168 | 168 | $language_ftx = $modSettings['search_language']; |
169 | 169 | else |
170 | 170 | { |
171 | - $request = $smcFunc['db_query']('',' |
|
171 | + $request = $smcFunc['db_query']('', ' |
|
172 | 172 | SELECT cfgname FROM pg_ts_config WHERE oid = current_setting({string:default_language})::regconfig', |
173 | 173 | array( |
174 | 174 | 'default_language' => 'default_text_search_config' |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Add the file functions to the $smcFunc array. |
@@ -23,29 +24,33 @@ discard block |
||
23 | 24 | { |
24 | 25 | global $smcFunc; |
25 | 26 | |
26 | - if (!isset($smcFunc['db_search_query']) || $smcFunc['db_search_query'] != 'smf_db_search_query') |
|
27 | - $smcFunc += array( |
|
27 | + if (!isset($smcFunc['db_search_query']) || $smcFunc['db_search_query'] != 'smf_db_search_query') { |
|
28 | + $smcFunc += array( |
|
28 | 29 | 'db_search_query' => 'smf_db_search_query', |
29 | 30 | 'db_search_support' => 'smf_db_search_support', |
30 | 31 | 'db_create_word_search' => 'smf_db_create_word_search', |
31 | 32 | 'db_support_ignore' => false, |
32 | 33 | 'db_search_language' => 'smf_db_search_language', |
33 | 34 | ); |
35 | + } |
|
34 | 36 | |
35 | 37 | db_extend(); |
36 | 38 | |
37 | 39 | //pg 9.5 got ignore support |
38 | 40 | $version = $smcFunc['db_get_version'](); |
39 | 41 | // if we got a Beta Version |
40 | - if (stripos($version, 'beta') !== false) |
|
41 | - $version = substr($version, 0, stripos($version, 'beta')).'.0'; |
|
42 | + if (stripos($version, 'beta') !== false) { |
|
43 | + $version = substr($version, 0, stripos($version, 'beta')).'.0'; |
|
44 | + } |
|
42 | 45 | // or RC |
43 | - if (stripos($version, 'rc') !== false) |
|
44 | - $version = substr($version, 0, stripos($version, 'rc')).'.0'; |
|
46 | + if (stripos($version, 'rc') !== false) { |
|
47 | + $version = substr($version, 0, stripos($version, 'rc')).'.0'; |
|
48 | + } |
|
45 | 49 | |
46 | - if (version_compare($version,'9.5.0','>=')) |
|
47 | - $smcFunc['db_support_ignore'] = true; |
|
48 | -} |
|
50 | + if (version_compare($version,'9.5.0','>=')) { |
|
51 | + $smcFunc['db_support_ignore'] = true; |
|
52 | + } |
|
53 | + } |
|
49 | 54 | |
50 | 55 | /** |
51 | 56 | * This function will tell you whether this database type supports this search type. |
@@ -104,16 +109,16 @@ discard block |
||
104 | 109 | ), |
105 | 110 | ); |
106 | 111 | |
107 | - if (isset($replacements[$identifier])) |
|
108 | - $db_string = preg_replace(array_keys($replacements[$identifier]), array_values($replacements[$identifier]), $db_string); |
|
112 | + if (isset($replacements[$identifier])) { |
|
113 | + $db_string = preg_replace(array_keys($replacements[$identifier]), array_values($replacements[$identifier]), $db_string); |
|
114 | + } |
|
109 | 115 | if (preg_match('~^\s*INSERT\sIGNORE~i', $db_string) != 0) |
110 | 116 | { |
111 | 117 | $db_string = preg_replace('~^\s*INSERT\sIGNORE~i', 'INSERT', $db_string); |
112 | 118 | if ($smcFunc['db_support_ignore']){ |
113 | 119 | //pg style "INSERT INTO.... ON CONFLICT DO NOTHING" |
114 | 120 | $db_string = $db_string.' ON CONFLICT DO NOTHING'; |
115 | - } |
|
116 | - else |
|
121 | + } else |
|
117 | 122 | { |
118 | 123 | // Don't error on multi-insert. |
119 | 124 | $db_values['db_error_skip'] = true; |
@@ -121,8 +126,9 @@ discard block |
||
121 | 126 | } |
122 | 127 | |
123 | 128 | //fix double quotes |
124 | - if ($identifier == 'insert_into_log_messages_fulltext') |
|
125 | - $db_values = str_replace('"', "'", $db_values); |
|
129 | + if ($identifier == 'insert_into_log_messages_fulltext') { |
|
130 | + $db_values = str_replace('"', "'", $db_values); |
|
131 | + } |
|
126 | 132 | |
127 | 133 | $return = $smcFunc['db_query']('', $db_string, |
128 | 134 | $db_values, $connection |
@@ -164,9 +170,9 @@ discard block |
||
164 | 170 | |
165 | 171 | $language_ftx = 'english'; |
166 | 172 | |
167 | - if (!empty($modSettings['search_language'])) |
|
168 | - $language_ftx = $modSettings['search_language']; |
|
169 | - else |
|
173 | + if (!empty($modSettings['search_language'])) { |
|
174 | + $language_ftx = $modSettings['search_language']; |
|
175 | + } else |
|
170 | 176 | { |
171 | 177 | $request = $smcFunc['db_query']('',' |
172 | 178 | SELECT cfgname FROM pg_ts_config WHERE oid = current_setting({string:default_language})::regconfig', |
@@ -676,7 +676,7 @@ discard block |
||
676 | 676 | * - caches the formatting data from the setting for optimization. |
677 | 677 | * |
678 | 678 | * @param float $number A number |
679 | - * @param bool|int $override_decimal_count If set, will use the specified number of decimal places. Otherwise it's automatically determined |
|
679 | + * @param integer $override_decimal_count If set, will use the specified number of decimal places. Otherwise it's automatically determined |
|
680 | 680 | * @return string A formatted number |
681 | 681 | */ |
682 | 682 | function comma_format($number, $override_decimal_count = false) |
@@ -5530,7 +5530,7 @@ discard block |
||
5530 | 5530 | * It assumes the data is already a string. |
5531 | 5531 | * @param string $data The data to print |
5532 | 5532 | * @param string $type The content type. Defaults to Json. |
5533 | - * @return void |
|
5533 | + * @return false|null |
|
5534 | 5534 | */ |
5535 | 5535 | function smf_serverResponse($data = '', $type = 'Content-Type: application/json') |
5536 | 5536 | { |
@@ -5495,7 +5495,6 @@ discard block |
||
5495 | 5495 | |
5496 | 5496 | /** |
5497 | 5497 | * Tries different modes to make file/dirs writable. Wrapper function for chmod() |
5498 | - |
|
5499 | 5498 | * @param string $file The file/dir full path. |
5500 | 5499 | * @param int $value Not needed, added for legacy reasons. |
5501 | 5500 | * @return boolean true if the file/dir is already writable or the function was able to make it writable, false if the function couldn't make the file/dir writable. |
@@ -5535,7 +5534,6 @@ discard block |
||
5535 | 5534 | |
5536 | 5535 | /** |
5537 | 5536 | * Wrapper function for json_decode() with error handling. |
5538 | - |
|
5539 | 5537 | * @param string $json The string to decode. |
5540 | 5538 | * @param bool $returnAsArray To return the decoded string as an array or an object, SMF only uses Arrays but to keep on compatibility with json_decode its set to false as default. |
5541 | 5539 | * @param bool $logIt To specify if the error will be logged if theres any. |
@@ -6029,7 +6027,7 @@ discard block |
||
6029 | 6027 | $params = stream_context_get_params($stream); |
6030 | 6028 | $result = isset($params["options"]["ssl"]["peer_certificate"]) ? true : false; |
6031 | 6029 | } |
6032 | - return $result; |
|
6030 | + return $result; |
|
6033 | 6031 | } |
6034 | 6032 | |
6035 | 6033 | /** |
@@ -386,7 +386,7 @@ discard block |
||
386 | 386 | { |
387 | 387 | $val = 'CASE '; |
388 | 388 | foreach ($members as $k => $v) |
389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
389 | + $val .= 'WHEN id_member = ' . $v . ' THEN ' . count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
390 | 390 | $val = $val . ' END'; |
391 | 391 | $type = 'raw'; |
392 | 392 | } |
@@ -817,7 +817,7 @@ discard block |
||
817 | 817 | $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
818 | 818 | if (empty($unsupportedFormats)) |
819 | 819 | { |
820 | - foreach($strftimeFormatSubstitutions as $format => $substitution) |
|
820 | + foreach ($strftimeFormatSubstitutions as $format => $substitution) |
|
821 | 821 | { |
822 | 822 | $value = @strftime('%' . $format); |
823 | 823 | |
@@ -1182,7 +1182,7 @@ discard block |
||
1182 | 1182 | 'height' => array('optional' => true, 'match' => '(\d+)'), |
1183 | 1183 | ), |
1184 | 1184 | 'content' => '$1', |
1185 | - 'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt) |
|
1185 | + 'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt) |
|
1186 | 1186 | { |
1187 | 1187 | $returnContext = ''; |
1188 | 1188 | |
@@ -1217,7 +1217,7 @@ discard block |
||
1217 | 1217 | } |
1218 | 1218 | |
1219 | 1219 | if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
1220 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1220 | + $returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>'; |
|
1221 | 1221 | else |
1222 | 1222 | $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
1223 | 1223 | } |
@@ -1246,7 +1246,7 @@ discard block |
||
1246 | 1246 | 'type' => 'unparsed_content', |
1247 | 1247 | 'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>', |
1248 | 1248 | // @todo Maybe this can be simplified? |
1249 | - 'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context) |
|
1249 | + 'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context) |
|
1250 | 1250 | { |
1251 | 1251 | if (!isset($disabled['code'])) |
1252 | 1252 | { |
@@ -1283,7 +1283,7 @@ discard block |
||
1283 | 1283 | 'type' => 'unparsed_equals_content', |
1284 | 1284 | 'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>', |
1285 | 1285 | // @todo Maybe this can be simplified? |
1286 | - 'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context) |
|
1286 | + 'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context) |
|
1287 | 1287 | { |
1288 | 1288 | if (!isset($disabled['code'])) |
1289 | 1289 | { |
@@ -1327,7 +1327,7 @@ discard block |
||
1327 | 1327 | 'type' => 'unparsed_content', |
1328 | 1328 | 'content' => '<a href="mailto:$1" class="bbc_email">$1</a>', |
1329 | 1329 | // @todo Should this respect guest_hideContacts? |
1330 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1330 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1331 | 1331 | { |
1332 | 1332 | $data = strtr($data, array('<br>' => '')); |
1333 | 1333 | }, |
@@ -1346,7 +1346,7 @@ discard block |
||
1346 | 1346 | 'type' => 'unparsed_commas_content', |
1347 | 1347 | 'test' => '\d+,\d+\]', |
1348 | 1348 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1349 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1349 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1350 | 1350 | { |
1351 | 1351 | if (isset($disabled['url'])) |
1352 | 1352 | $tag['content'] = '$1'; |
@@ -1362,7 +1362,7 @@ discard block |
||
1362 | 1362 | 'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]', |
1363 | 1363 | 'before' => '<div $1>', |
1364 | 1364 | 'after' => '</div>', |
1365 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1365 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1366 | 1366 | { |
1367 | 1367 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1368 | 1368 | |
@@ -1411,7 +1411,7 @@ discard block |
||
1411 | 1411 | 'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'), |
1412 | 1412 | ), |
1413 | 1413 | 'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">', |
1414 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1414 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1415 | 1415 | { |
1416 | 1416 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
1417 | 1417 | |
@@ -1434,7 +1434,7 @@ discard block |
||
1434 | 1434 | 'tag' => 'img', |
1435 | 1435 | 'type' => 'unparsed_content', |
1436 | 1436 | 'content' => '<img src="$1" alt="" class="bbc_img">', |
1437 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1437 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1438 | 1438 | { |
1439 | 1439 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
1440 | 1440 | |
@@ -1457,7 +1457,7 @@ discard block |
||
1457 | 1457 | 'tag' => 'iurl', |
1458 | 1458 | 'type' => 'unparsed_content', |
1459 | 1459 | 'content' => '<a href="$1" class="bbc_link">$1</a>', |
1460 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1460 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1461 | 1461 | { |
1462 | 1462 | $data = strtr($data, array('<br>' => '')); |
1463 | 1463 | $scheme = parse_url($data, PHP_URL_SCHEME); |
@@ -1471,7 +1471,7 @@ discard block |
||
1471 | 1471 | 'quoted' => 'optional', |
1472 | 1472 | 'before' => '<a href="$1" class="bbc_link">', |
1473 | 1473 | 'after' => '</a>', |
1474 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1474 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1475 | 1475 | { |
1476 | 1476 | if (substr($data, 0, 1) == '#') |
1477 | 1477 | $data = '#post_' . substr($data, 1); |
@@ -1551,7 +1551,7 @@ discard block |
||
1551 | 1551 | 'tag' => 'php', |
1552 | 1552 | 'type' => 'unparsed_content', |
1553 | 1553 | 'content' => '<span class="phpcode">$1</span>', |
1554 | - 'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled) |
|
1554 | + 'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled) |
|
1555 | 1555 | { |
1556 | 1556 | if (!isset($disabled['php'])) |
1557 | 1557 | { |
@@ -1649,7 +1649,7 @@ discard block |
||
1649 | 1649 | 'test' => '[1-7]\]', |
1650 | 1650 | 'before' => '<span style="font-size: $1;" class="bbc_size">', |
1651 | 1651 | 'after' => '</span>', |
1652 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1652 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1653 | 1653 | { |
1654 | 1654 | $sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95); |
1655 | 1655 | $data = $sizes[$data] . 'em'; |
@@ -1687,7 +1687,7 @@ discard block |
||
1687 | 1687 | 'tag' => 'time', |
1688 | 1688 | 'type' => 'unparsed_content', |
1689 | 1689 | 'content' => '$1', |
1690 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1690 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1691 | 1691 | { |
1692 | 1692 | if (is_numeric($data)) |
1693 | 1693 | $data = timeformat($data); |
@@ -1715,7 +1715,7 @@ discard block |
||
1715 | 1715 | 'tag' => 'url', |
1716 | 1716 | 'type' => 'unparsed_content', |
1717 | 1717 | 'content' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">$1</a>', |
1718 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1718 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1719 | 1719 | { |
1720 | 1720 | $data = strtr($data, array('<br>' => '')); |
1721 | 1721 | $scheme = parse_url($data, PHP_URL_SCHEME); |
@@ -1729,7 +1729,7 @@ discard block |
||
1729 | 1729 | 'quoted' => 'optional', |
1730 | 1730 | 'before' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">', |
1731 | 1731 | 'after' => '</a>', |
1732 | - 'validate' => function (&$tag, &$data, $disabled) |
|
1732 | + 'validate' => function(&$tag, &$data, $disabled) |
|
1733 | 1733 | { |
1734 | 1734 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1735 | 1735 | if (empty($scheme)) |
@@ -1755,7 +1755,7 @@ discard block |
||
1755 | 1755 | { |
1756 | 1756 | if (isset($temp_bbc)) |
1757 | 1757 | $bbc_codes = $temp_bbc; |
1758 | - usort($codes, function ($a, $b) { |
|
1758 | + usort($codes, function($a, $b) { |
|
1759 | 1759 | return strcmp($a['tag'], $b['tag']); |
1760 | 1760 | }); |
1761 | 1761 | return $codes; |
@@ -1992,7 +1992,7 @@ discard block |
||
1992 | 1992 | # a run of Unicode domain name characters and a dot |
1993 | 1993 | [\p{L}\p{M}\p{N}\-.:@]+\. |
1994 | 1994 | # and then a TLD valid in the DNS or the reserved "local" TLD |
1995 | - (?:'. $modSettings['tld_regex'] .'|local) |
|
1995 | + (?:'. $modSettings['tld_regex'] . '|local) |
|
1996 | 1996 | ) |
1997 | 1997 | # followed by a non-domain character or end of line |
1998 | 1998 | (?=[^\p{L}\p{N}\-.]|$) |
@@ -2060,7 +2060,7 @@ discard block |
||
2060 | 2060 | )? |
2061 | 2061 | '; |
2062 | 2062 | |
2063 | - $data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) { |
|
2063 | + $data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) { |
|
2064 | 2064 | $url = array_shift($matches); |
2065 | 2065 | |
2066 | 2066 | $scheme = parse_url($url, PHP_URL_SCHEME); |
@@ -2800,7 +2800,7 @@ discard block |
||
2800 | 2800 | for ($i = 0, $n = count($smileysfrom); $i < $n; $i++) |
2801 | 2801 | { |
2802 | 2802 | $specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES); |
2803 | - $smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" class="smiley">'; |
|
2803 | + $smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => ':', '(' => '(', ')' => ')', '$' => '$', '[' => '[')) . '" class="smiley">'; |
|
2804 | 2804 | |
2805 | 2805 | $smileyPregReplacements[$smileysfrom[$i]] = $smileyCode; |
2806 | 2806 | |
@@ -2817,7 +2817,7 @@ discard block |
||
2817 | 2817 | |
2818 | 2818 | // Replace away! |
2819 | 2819 | $message = preg_replace_callback($smileyPregSearch, |
2820 | - function ($matches) use ($smileyPregReplacements) |
|
2820 | + function($matches) use ($smileyPregReplacements) |
|
2821 | 2821 | { |
2822 | 2822 | return $smileyPregReplacements[$matches[1]]; |
2823 | 2823 | }, $message); |
@@ -2883,13 +2883,13 @@ discard block |
||
2883 | 2883 | { |
2884 | 2884 | if (defined('SID') && SID != '') |
2885 | 2885 | $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
2886 | - function ($m) use ($scripturl) |
|
2886 | + function($m) use ($scripturl) |
|
2887 | 2887 | { |
2888 | - return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
|
2888 | + return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : ""); |
|
2889 | 2889 | }, $setLocation); |
2890 | 2890 | else |
2891 | 2891 | $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
2892 | - function ($m) use ($scripturl) |
|
2892 | + function($m) use ($scripturl) |
|
2893 | 2893 | { |
2894 | 2894 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
2895 | 2895 | }, $setLocation); |
@@ -3212,7 +3212,7 @@ discard block |
||
3212 | 3212 | |
3213 | 3213 | // Add a generic "Are you sure?" confirmation message. |
3214 | 3214 | addInlineJavaScript(' |
3215 | - var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
|
3215 | + var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';'); |
|
3216 | 3216 | |
3217 | 3217 | // Now add the capping code for avatars. |
3218 | 3218 | if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
@@ -3573,7 +3573,7 @@ discard block |
||
3573 | 3573 | |
3574 | 3574 | else |
3575 | 3575 | echo ' |
3576 | - <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
|
3576 | + <script src="', $settings['theme_url'], '/scripts/minified', ($do_deferred ? '_deferred' : ''), '.js', $minSeed, '"></script>'; |
|
3577 | 3577 | } |
3578 | 3578 | |
3579 | 3579 | // Inline JavaScript - Actually useful some times! |
@@ -3651,14 +3651,14 @@ discard block |
||
3651 | 3651 | |
3652 | 3652 | else |
3653 | 3653 | echo ' |
3654 | - <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
|
3654 | + <link rel="stylesheet" href="', $settings['theme_url'], '/css/minified.css', $minSeed, '">'; |
|
3655 | 3655 | } |
3656 | 3656 | |
3657 | 3657 | // Print the rest after the minified files. |
3658 | 3658 | if (!empty($normal)) |
3659 | 3659 | foreach ($normal as $nf) |
3660 | 3660 | echo ' |
3661 | - <link rel="stylesheet" href="', $nf ,'">'; |
|
3661 | + <link rel="stylesheet" href="', $nf, '">'; |
|
3662 | 3662 | |
3663 | 3663 | if ($db_show_debug === true) |
3664 | 3664 | { |
@@ -3674,7 +3674,7 @@ discard block |
||
3674 | 3674 | <style>'; |
3675 | 3675 | |
3676 | 3676 | foreach ($context['css_header'] as $css) |
3677 | - echo $css .' |
|
3677 | + echo $css . ' |
|
3678 | 3678 | '; |
3679 | 3679 | |
3680 | 3680 | echo' |
@@ -3703,27 +3703,27 @@ discard block |
||
3703 | 3703 | return false; |
3704 | 3704 | |
3705 | 3705 | // Did we already did this? |
3706 | - $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
|
3706 | + $toCache = cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type, 86400); |
|
3707 | 3707 | |
3708 | 3708 | // Already done? |
3709 | 3709 | if (!empty($toCache)) |
3710 | 3710 | return true; |
3711 | 3711 | |
3712 | 3712 | // No namespaces, sorry! |
3713 | - $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
|
3713 | + $classType = 'MatthiasMullie\\Minify\\' . strtoupper($type); |
|
3714 | 3714 | |
3715 | 3715 | // Temp path. |
3716 | - $cTempPath = $settings['theme_dir'] .'/'. ($type == 'css' ? 'css' : 'scripts') .'/'; |
|
3716 | + $cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/'; |
|
3717 | 3717 | |
3718 | 3718 | // What kind of file are we going to create? |
3719 | - $toCreate = $cTempPath .'minified'. ($do_deferred ? '_deferred' : '') .'.'. $type; |
|
3719 | + $toCreate = $cTempPath . 'minified' . ($do_deferred ? '_deferred' : '') . '.' . $type; |
|
3720 | 3720 | |
3721 | 3721 | // File has to exists, if it isn't try to create it. |
3722 | 3722 | if ((!file_exists($toCreate) && @fopen($toCreate, 'w') === false) || !smf_chmod($toCreate)) |
3723 | 3723 | { |
3724 | 3724 | loadLanguage('Errors'); |
3725 | 3725 | log_error(sprintf($txt['file_not_created'], $toCreate), 'general'); |
3726 | - cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null); |
|
3726 | + cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null); |
|
3727 | 3727 | |
3728 | 3728 | // The process failed so roll back to print each individual file. |
3729 | 3729 | return $data; |
@@ -3758,14 +3758,14 @@ discard block |
||
3758 | 3758 | { |
3759 | 3759 | loadLanguage('Errors'); |
3760 | 3760 | log_error(sprintf($txt['file_not_created'], $toCreate), 'general'); |
3761 | - cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null); |
|
3761 | + cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null); |
|
3762 | 3762 | |
3763 | 3763 | // The process failed so roll back to print each individual file. |
3764 | 3764 | return $data; |
3765 | 3765 | } |
3766 | 3766 | |
3767 | 3767 | // And create a long lived cache entry. |
3768 | - cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, $toCreate, 86400); |
|
3768 | + cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, $toCreate, 86400); |
|
3769 | 3769 | |
3770 | 3770 | return true; |
3771 | 3771 | } |
@@ -3825,7 +3825,7 @@ discard block |
||
3825 | 3825 | else |
3826 | 3826 | $path = $modSettings['attachmentUploadDir']; |
3827 | 3827 | |
3828 | - return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
|
3828 | + return $path . '/' . $attachment_id . '_' . $file_hash . '.dat'; |
|
3829 | 3829 | } |
3830 | 3830 | |
3831 | 3831 | /** |
@@ -3869,10 +3869,10 @@ discard block |
||
3869 | 3869 | $valid_low = isValidIP($ip_parts[0]); |
3870 | 3870 | $valid_high = isValidIP($ip_parts[1]); |
3871 | 3871 | $count = 0; |
3872 | - $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
|
3872 | + $mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.'); |
|
3873 | 3873 | $max = ($mode == ':' ? 'ffff' : '255'); |
3874 | 3874 | $min = 0; |
3875 | - if(!$valid_low) |
|
3875 | + if (!$valid_low) |
|
3876 | 3876 | { |
3877 | 3877 | $ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]); |
3878 | 3878 | $valid_low = isValidIP($ip_parts[0]); |
@@ -3886,7 +3886,7 @@ discard block |
||
3886 | 3886 | } |
3887 | 3887 | |
3888 | 3888 | $count = 0; |
3889 | - if(!$valid_high) |
|
3889 | + if (!$valid_high) |
|
3890 | 3890 | { |
3891 | 3891 | $ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]); |
3892 | 3892 | $valid_high = isValidIP($ip_parts[1]); |
@@ -3899,7 +3899,7 @@ discard block |
||
3899 | 3899 | } |
3900 | 3900 | } |
3901 | 3901 | |
3902 | - if($valid_high && $valid_low) |
|
3902 | + if ($valid_high && $valid_low) |
|
3903 | 3903 | { |
3904 | 3904 | $ip_array['low'] = $ip_parts[0]; |
3905 | 3905 | $ip_array['high'] = $ip_parts[1]; |
@@ -4081,7 +4081,7 @@ discard block |
||
4081 | 4081 | addInlineJavaScript(' |
4082 | 4082 | var user_menus = new smc_PopupMenu(); |
4083 | 4083 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4084 | - user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
|
4084 | + user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true); |
|
4085 | 4085 | if ($context['allow_pm']) |
4086 | 4086 | addInlineJavaScript(' |
4087 | 4087 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
@@ -4701,7 +4701,7 @@ discard block |
||
4701 | 4701 | // No? try a fallback to $sourcedir |
4702 | 4702 | else |
4703 | 4703 | { |
4704 | - $absPath = $sourcedir .'/'. $file; |
|
4704 | + $absPath = $sourcedir . '/' . $file; |
|
4705 | 4705 | |
4706 | 4706 | if (file_exists($absPath)) |
4707 | 4707 | require_once($absPath); |
@@ -4782,15 +4782,15 @@ discard block |
||
4782 | 4782 | |
4783 | 4783 | // UTF-8 occurences of MS special characters |
4784 | 4784 | $findchars_utf8 = array( |
4785 | - "\xe2\x80\x9a", // single low-9 quotation mark |
|
4786 | - "\xe2\x80\x9e", // double low-9 quotation mark |
|
4787 | - "\xe2\x80\xa6", // horizontal ellipsis |
|
4788 | - "\xe2\x80\x98", // left single curly quote |
|
4789 | - "\xe2\x80\x99", // right single curly quote |
|
4790 | - "\xe2\x80\x9c", // left double curly quote |
|
4791 | - "\xe2\x80\x9d", // right double curly quote |
|
4792 | - "\xe2\x80\x93", // en dash |
|
4793 | - "\xe2\x80\x94", // em dash |
|
4785 | + "\xe2\x80\x9a", // single low-9 quotation mark |
|
4786 | + "\xe2\x80\x9e", // double low-9 quotation mark |
|
4787 | + "\xe2\x80\xa6", // horizontal ellipsis |
|
4788 | + "\xe2\x80\x98", // left single curly quote |
|
4789 | + "\xe2\x80\x99", // right single curly quote |
|
4790 | + "\xe2\x80\x9c", // left double curly quote |
|
4791 | + "\xe2\x80\x9d", // right double curly quote |
|
4792 | + "\xe2\x80\x93", // en dash |
|
4793 | + "\xe2\x80\x94", // em dash |
|
4794 | 4794 | ); |
4795 | 4795 | |
4796 | 4796 | // windows 1252 / iso equivalents |
@@ -4808,15 +4808,15 @@ discard block |
||
4808 | 4808 | |
4809 | 4809 | // safe replacements |
4810 | 4810 | $replacechars = array( |
4811 | - ',', // ‚ |
|
4812 | - ',,', // „ |
|
4813 | - '...', // … |
|
4814 | - "'", // ‘ |
|
4815 | - "'", // ’ |
|
4816 | - '"', // “ |
|
4817 | - '"', // ” |
|
4818 | - '-', // – |
|
4819 | - '--', // — |
|
4811 | + ',', // ‚ |
|
4812 | + ',,', // „ |
|
4813 | + '...', // … |
|
4814 | + "'", // ‘ |
|
4815 | + "'", // ’ |
|
4816 | + '"', // “ |
|
4817 | + '"', // ” |
|
4818 | + '-', // – |
|
4819 | + '--', // — |
|
4820 | 4820 | ); |
4821 | 4821 | |
4822 | 4822 | if ($context['utf8']) |
@@ -5234,7 +5234,7 @@ discard block |
||
5234 | 5234 | */ |
5235 | 5235 | function inet_dtop($bin) |
5236 | 5236 | { |
5237 | - if(empty($bin)) |
|
5237 | + if (empty($bin)) |
|
5238 | 5238 | return ''; |
5239 | 5239 | |
5240 | 5240 | global $db_type; |
@@ -5265,28 +5265,28 @@ discard block |
||
5265 | 5265 | */ |
5266 | 5266 | function _safe_serialize($value) |
5267 | 5267 | { |
5268 | - if(is_null($value)) |
|
5268 | + if (is_null($value)) |
|
5269 | 5269 | return 'N;'; |
5270 | 5270 | |
5271 | - if(is_bool($value)) |
|
5272 | - return 'b:'. (int) $value .';'; |
|
5271 | + if (is_bool($value)) |
|
5272 | + return 'b:' . (int) $value . ';'; |
|
5273 | 5273 | |
5274 | - if(is_int($value)) |
|
5275 | - return 'i:'. $value .';'; |
|
5274 | + if (is_int($value)) |
|
5275 | + return 'i:' . $value . ';'; |
|
5276 | 5276 | |
5277 | - if(is_float($value)) |
|
5278 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5277 | + if (is_float($value)) |
|
5278 | + return 'd:' . str_replace(',', '.', $value) . ';'; |
|
5279 | 5279 | |
5280 | - if(is_string($value)) |
|
5281 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5280 | + if (is_string($value)) |
|
5281 | + return 's:' . strlen($value) . ':"' . $value . '";'; |
|
5282 | 5282 | |
5283 | - if(is_array($value)) |
|
5283 | + if (is_array($value)) |
|
5284 | 5284 | { |
5285 | 5285 | $out = ''; |
5286 | - foreach($value as $k => $v) |
|
5286 | + foreach ($value as $k => $v) |
|
5287 | 5287 | $out .= _safe_serialize($k) . _safe_serialize($v); |
5288 | 5288 | |
5289 | - return 'a:'. count($value) .':{'. $out .'}'; |
|
5289 | + return 'a:' . count($value) . ':{' . $out . '}'; |
|
5290 | 5290 | } |
5291 | 5291 | |
5292 | 5292 | // safe_serialize cannot serialize resources or objects. |
@@ -5328,7 +5328,7 @@ discard block |
||
5328 | 5328 | function _safe_unserialize($str) |
5329 | 5329 | { |
5330 | 5330 | // Input is not a string. |
5331 | - if(empty($str) || !is_string($str)) |
|
5331 | + if (empty($str) || !is_string($str)) |
|
5332 | 5332 | return false; |
5333 | 5333 | |
5334 | 5334 | $stack = array(); |
@@ -5342,40 +5342,40 @@ discard block |
||
5342 | 5342 | * 3 - in array, expecting value or another array |
5343 | 5343 | */ |
5344 | 5344 | $state = 0; |
5345 | - while($state != 1) |
|
5345 | + while ($state != 1) |
|
5346 | 5346 | { |
5347 | 5347 | $type = isset($str[0]) ? $str[0] : ''; |
5348 | - if($type == '}') |
|
5348 | + if ($type == '}') |
|
5349 | 5349 | $str = substr($str, 1); |
5350 | 5350 | |
5351 | - else if($type == 'N' && $str[1] == ';') |
|
5351 | + else if ($type == 'N' && $str[1] == ';') |
|
5352 | 5352 | { |
5353 | 5353 | $value = null; |
5354 | 5354 | $str = substr($str, 2); |
5355 | 5355 | } |
5356 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5356 | + else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5357 | 5357 | { |
5358 | 5358 | $value = $matches[1] == '1' ? true : false; |
5359 | 5359 | $str = substr($str, 4); |
5360 | 5360 | } |
5361 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5361 | + else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5362 | 5362 | { |
5363 | - $value = (int)$matches[1]; |
|
5363 | + $value = (int) $matches[1]; |
|
5364 | 5364 | $str = $matches[2]; |
5365 | 5365 | } |
5366 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5366 | + else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5367 | 5367 | { |
5368 | - $value = (float)$matches[1]; |
|
5368 | + $value = (float) $matches[1]; |
|
5369 | 5369 | $str = $matches[3]; |
5370 | 5370 | } |
5371 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5371 | + else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";') |
|
5372 | 5372 | { |
5373 | - $value = substr($matches[2], 0, (int)$matches[1]); |
|
5374 | - $str = substr($matches[2], (int)$matches[1] + 2); |
|
5373 | + $value = substr($matches[2], 0, (int) $matches[1]); |
|
5374 | + $str = substr($matches[2], (int) $matches[1] + 2); |
|
5375 | 5375 | } |
5376 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5376 | + else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5377 | 5377 | { |
5378 | - $expectedLength = (int)$matches[1]; |
|
5378 | + $expectedLength = (int) $matches[1]; |
|
5379 | 5379 | $str = $matches[2]; |
5380 | 5380 | } |
5381 | 5381 | |
@@ -5383,10 +5383,10 @@ discard block |
||
5383 | 5383 | else |
5384 | 5384 | return false; |
5385 | 5385 | |
5386 | - switch($state) |
|
5386 | + switch ($state) |
|
5387 | 5387 | { |
5388 | 5388 | case 3: // In array, expecting value or another array. |
5389 | - if($type == 'a') |
|
5389 | + if ($type == 'a') |
|
5390 | 5390 | { |
5391 | 5391 | $stack[] = &$list; |
5392 | 5392 | $list[$key] = array(); |
@@ -5395,7 +5395,7 @@ discard block |
||
5395 | 5395 | $state = 2; |
5396 | 5396 | break; |
5397 | 5397 | } |
5398 | - if($type != '}') |
|
5398 | + if ($type != '}') |
|
5399 | 5399 | { |
5400 | 5400 | $list[$key] = $value; |
5401 | 5401 | $state = 2; |
@@ -5406,29 +5406,29 @@ discard block |
||
5406 | 5406 | return false; |
5407 | 5407 | |
5408 | 5408 | case 2: // in array, expecting end of array or a key |
5409 | - if($type == '}') |
|
5409 | + if ($type == '}') |
|
5410 | 5410 | { |
5411 | 5411 | // Array size is less than expected. |
5412 | - if(count($list) < end($expected)) |
|
5412 | + if (count($list) < end($expected)) |
|
5413 | 5413 | return false; |
5414 | 5414 | |
5415 | 5415 | unset($list); |
5416 | - $list = &$stack[count($stack)-1]; |
|
5416 | + $list = &$stack[count($stack) - 1]; |
|
5417 | 5417 | array_pop($stack); |
5418 | 5418 | |
5419 | 5419 | // Go to terminal state if we're at the end of the root array. |
5420 | 5420 | array_pop($expected); |
5421 | 5421 | |
5422 | - if(count($expected) == 0) |
|
5422 | + if (count($expected) == 0) |
|
5423 | 5423 | $state = 1; |
5424 | 5424 | |
5425 | 5425 | break; |
5426 | 5426 | } |
5427 | 5427 | |
5428 | - if($type == 'i' || $type == 's') |
|
5428 | + if ($type == 'i' || $type == 's') |
|
5429 | 5429 | { |
5430 | 5430 | // Array size exceeds expected length. |
5431 | - if(count($list) >= end($expected)) |
|
5431 | + if (count($list) >= end($expected)) |
|
5432 | 5432 | return false; |
5433 | 5433 | |
5434 | 5434 | $key = $value; |
@@ -5441,7 +5441,7 @@ discard block |
||
5441 | 5441 | |
5442 | 5442 | // Expecting array or value. |
5443 | 5443 | case 0: |
5444 | - if($type == 'a') |
|
5444 | + if ($type == 'a') |
|
5445 | 5445 | { |
5446 | 5446 | $data = array(); |
5447 | 5447 | $list = &$data; |
@@ -5450,7 +5450,7 @@ discard block |
||
5450 | 5450 | break; |
5451 | 5451 | } |
5452 | 5452 | |
5453 | - if($type != '}') |
|
5453 | + if ($type != '}') |
|
5454 | 5454 | { |
5455 | 5455 | $data = $value; |
5456 | 5456 | $state = 1; |
@@ -5463,7 +5463,7 @@ discard block |
||
5463 | 5463 | } |
5464 | 5464 | |
5465 | 5465 | // Trailing data in input. |
5466 | - if(!empty($str)) |
|
5466 | + if (!empty($str)) |
|
5467 | 5467 | return false; |
5468 | 5468 | |
5469 | 5469 | return $data; |
@@ -5517,7 +5517,7 @@ discard block |
||
5517 | 5517 | // Set different modes. |
5518 | 5518 | $chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666); |
5519 | 5519 | |
5520 | - foreach($chmodValues as $val) |
|
5520 | + foreach ($chmodValues as $val) |
|
5521 | 5521 | { |
5522 | 5522 | // If it's writable, break out of the loop. |
5523 | 5523 | if (is_writable($file)) |
@@ -5552,13 +5552,13 @@ discard block |
||
5552 | 5552 | $returnArray = @json_decode($json, $returnAsArray); |
5553 | 5553 | |
5554 | 5554 | // PHP 5.3 so no json_last_error_msg() |
5555 | - switch(json_last_error()) |
|
5555 | + switch (json_last_error()) |
|
5556 | 5556 | { |
5557 | 5557 | case JSON_ERROR_NONE: |
5558 | 5558 | $jsonError = false; |
5559 | 5559 | break; |
5560 | 5560 | case JSON_ERROR_DEPTH: |
5561 | - $jsonError = 'JSON_ERROR_DEPTH'; |
|
5561 | + $jsonError = 'JSON_ERROR_DEPTH'; |
|
5562 | 5562 | break; |
5563 | 5563 | case JSON_ERROR_STATE_MISMATCH: |
5564 | 5564 | $jsonError = 'JSON_ERROR_STATE_MISMATCH'; |
@@ -5586,10 +5586,10 @@ discard block |
||
5586 | 5586 | loadLanguage('Errors'); |
5587 | 5587 | |
5588 | 5588 | if (!empty($jsonDebug)) |
5589 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5589 | + log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5590 | 5590 | |
5591 | 5591 | else |
5592 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5592 | + log_error($txt['json_' . $jsonError], 'critical'); |
|
5593 | 5593 | |
5594 | 5594 | // Everyone expects an array. |
5595 | 5595 | return array(); |
@@ -5701,7 +5701,7 @@ discard block |
||
5701 | 5701 | }); |
5702 | 5702 | |
5703 | 5703 | // Convert Punycode to Unicode |
5704 | - $tlds = array_map(function ($input) { |
|
5704 | + $tlds = array_map(function($input) { |
|
5705 | 5705 | $prefix = 'xn--'; |
5706 | 5706 | $safe_char = 0xFFFC; |
5707 | 5707 | $base = 36; |
@@ -5717,7 +5717,7 @@ discard block |
||
5717 | 5717 | |
5718 | 5718 | foreach ($enco_parts as $encoded) |
5719 | 5719 | { |
5720 | - if (strpos($encoded,$prefix) !== 0 || strlen(trim(str_replace($prefix,'',$encoded))) == 0) |
|
5720 | + if (strpos($encoded, $prefix) !== 0 || strlen(trim(str_replace($prefix, '', $encoded))) == 0) |
|
5721 | 5721 | { |
5722 | 5722 | $output_parts[] = $encoded; |
5723 | 5723 | continue; |
@@ -5728,7 +5728,7 @@ discard block |
||
5728 | 5728 | $idx = 0; |
5729 | 5729 | $char = 0x80; |
5730 | 5730 | $decoded = array(); |
5731 | - $output=''; |
|
5731 | + $output = ''; |
|
5732 | 5732 | $delim_pos = strrpos($encoded, '-'); |
5733 | 5733 | |
5734 | 5734 | if ($delim_pos > strlen($prefix)) |
@@ -5744,7 +5744,7 @@ discard block |
||
5744 | 5744 | |
5745 | 5745 | for ($enco_idx = $delim_pos ? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len) |
5746 | 5746 | { |
5747 | - for ($old_idx = $idx, $w = 1, $k = $base; 1 ; $k += $base) |
|
5747 | + for ($old_idx = $idx, $w = 1, $k = $base; 1; $k += $base) |
|
5748 | 5748 | { |
5749 | 5749 | $cp = ord($encoded{$enco_idx++}); |
5750 | 5750 | $digit = ($cp - 48 < 10) ? $cp - 22 : (($cp - 65 < 26) ? $cp - 65 : (($cp - 97 < 26) ? $cp - 97 : $base)); |
@@ -5785,15 +5785,15 @@ discard block |
||
5785 | 5785 | |
5786 | 5786 | // 2 bytes |
5787 | 5787 | elseif ($v < (1 << 11)) |
5788 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
5788 | + $output .= chr(192 + ($v >> 6)) . chr(128 + ($v & 63)); |
|
5789 | 5789 | |
5790 | 5790 | // 3 bytes |
5791 | 5791 | elseif ($v < (1 << 16)) |
5792 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
5792 | + $output .= chr(224 + ($v >> 12)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63)); |
|
5793 | 5793 | |
5794 | 5794 | // 4 bytes |
5795 | 5795 | elseif ($v < (1 << 21)) |
5796 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
5796 | + $output .= chr(240 + ($v >> 18)) . chr(128 + (($v >> 12) & 63)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63)); |
|
5797 | 5797 | |
5798 | 5798 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5799 | 5799 | else |
@@ -5898,7 +5898,7 @@ discard block |
||
5898 | 5898 | } |
5899 | 5899 | |
5900 | 5900 | // This recursive function creates the index array from the strings |
5901 | - $add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index) |
|
5901 | + $add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index) |
|
5902 | 5902 | { |
5903 | 5903 | static $depth = 0; |
5904 | 5904 | $depth++; |
@@ -5925,7 +5925,7 @@ discard block |
||
5925 | 5925 | }; |
5926 | 5926 | |
5927 | 5927 | // This recursive function turns the index array into a regular expression |
5928 | - $index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex) |
|
5928 | + $index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex) |
|
5929 | 5929 | { |
5930 | 5930 | static $depth = 0; |
5931 | 5931 | $depth++; |
@@ -5949,11 +5949,11 @@ discard block |
||
5949 | 5949 | |
5950 | 5950 | if (count(array_keys($value)) == 1) |
5951 | 5951 | { |
5952 | - $new_key_array = explode('(?'.'>', $sub_regex); |
|
5952 | + $new_key_array = explode('(?' . '>', $sub_regex); |
|
5953 | 5953 | $new_key .= $new_key_array[0]; |
5954 | 5954 | } |
5955 | 5955 | else |
5956 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5956 | + $sub_regex = '(?' . '>' . $sub_regex . ')'; |
|
5957 | 5957 | } |
5958 | 5958 | |
5959 | 5959 | if ($depth > 1) |
@@ -5996,10 +5996,10 @@ discard block |
||
5996 | 5996 | { |
5997 | 5997 | $regex = array(); |
5998 | 5998 | while (!empty($index)) |
5999 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
5999 | + $regex[] = '(?' . '>' . $index_to_regex($index, $delim) . ')'; |
|
6000 | 6000 | } |
6001 | 6001 | else |
6002 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6002 | + $regex = '(?' . '>' . $index_to_regex($index, $delim) . ')'; |
|
6003 | 6003 | |
6004 | 6004 | // Restore PHP's internal character encoding to whatever it was originally |
6005 | 6005 | if (!empty($current_encoding)) |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
122 | 123 | $smcFunc['db_free_result']($result); |
123 | 124 | |
124 | 125 | // Add this to the number of unapproved members |
125 | - if (!empty($changes['unapprovedMembers'])) |
|
126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
127 | - else |
|
128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
126 | + if (!empty($changes['unapprovedMembers'])) { |
|
127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
128 | + } else { |
|
129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
130 | + } |
|
129 | 131 | } |
130 | 132 | } |
131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
133 | 135 | break; |
134 | 136 | |
135 | 137 | case 'message': |
136 | - if ($parameter1 === true && $parameter2 !== null) |
|
137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
138 | - else |
|
138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
140 | + } else |
|
139 | 141 | { |
140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
175 | 177 | $parameter2 = text2words($parameter2); |
176 | 178 | |
177 | 179 | $inserts = array(); |
178 | - foreach ($parameter2 as $word) |
|
179 | - $inserts[] = array($word, $parameter1); |
|
180 | + foreach ($parameter2 as $word) { |
|
181 | + $inserts[] = array($word, $parameter1); |
|
182 | + } |
|
180 | 183 | |
181 | - if (!empty($inserts)) |
|
182 | - $smcFunc['db_insert']('ignore', |
|
184 | + if (!empty($inserts)) { |
|
185 | + $smcFunc['db_insert']('ignore', |
|
183 | 186 | '{db_prefix}log_search_subjects', |
184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
185 | 188 | $inserts, |
186 | 189 | array('word', 'id_topic') |
187 | 190 | ); |
191 | + } |
|
188 | 192 | } |
189 | 193 | break; |
190 | 194 | |
191 | 195 | case 'topic': |
192 | - if ($parameter1 === true) |
|
193 | - updateSettings(array('totalTopics' => true), true); |
|
194 | - else |
|
196 | + if ($parameter1 === true) { |
|
197 | + updateSettings(array('totalTopics' => true), true); |
|
198 | + } else |
|
195 | 199 | { |
196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
212 | 216 | |
213 | 217 | case 'postgroups': |
214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
216 | - return; |
|
219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
220 | + return; |
|
221 | + } |
|
217 | 222 | |
218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
228 | 233 | ) |
229 | 234 | ); |
230 | 235 | $postgroups = array(); |
231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
238 | + } |
|
233 | 239 | $smcFunc['db_free_result']($request); |
234 | 240 | |
235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
239 | 245 | } |
240 | 246 | |
241 | 247 | // Oh great, they've screwed their post groups. |
242 | - if (empty($postgroups)) |
|
243 | - return; |
|
248 | + if (empty($postgroups)) { |
|
249 | + return; |
|
250 | + } |
|
244 | 251 | |
245 | 252 | // Set all membergroups from most posts to least posts. |
246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
298 | 305 | { |
299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
300 | 307 | $parameters['members'] = $members; |
301 | - } |
|
302 | - elseif ($members === null) |
|
303 | - $condition = '1=1'; |
|
304 | - else |
|
308 | + } elseif ($members === null) { |
|
309 | + $condition = '1=1'; |
|
310 | + } else |
|
305 | 311 | { |
306 | 312 | $condition = 'id_member = {int:member}'; |
307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
341 | 347 | if (count($vars_to_integrate) != 0) |
342 | 348 | { |
343 | 349 | // Fetch a list of member_names if necessary |
344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
345 | - $member_names = array($user_info['username']); |
|
346 | - else |
|
350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
351 | + $member_names = array($user_info['username']); |
|
352 | + } else |
|
347 | 353 | { |
348 | 354 | $member_names = array(); |
349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
352 | 358 | WHERE ' . $condition, |
353 | 359 | $parameters |
354 | 360 | ); |
355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
356 | - $member_names[] = $row['member_name']; |
|
361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
362 | + $member_names[] = $row['member_name']; |
|
363 | + } |
|
357 | 364 | $smcFunc['db_free_result']($request); |
358 | 365 | } |
359 | 366 | |
360 | - if (!empty($member_names)) |
|
361 | - foreach ($vars_to_integrate as $var) |
|
367 | + if (!empty($member_names)) { |
|
368 | + foreach ($vars_to_integrate as $var) |
|
362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
370 | + } |
|
363 | 371 | } |
364 | 372 | } |
365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
367 | 375 | foreach ($data as $var => $val) |
368 | 376 | { |
369 | 377 | $type = 'string'; |
370 | - if (in_array($var, $knownInts)) |
|
371 | - $type = 'int'; |
|
372 | - elseif (in_array($var, $knownFloats)) |
|
373 | - $type = 'float'; |
|
374 | - elseif ($var == 'birthdate') |
|
375 | - $type = 'date'; |
|
376 | - elseif ($var == 'member_ip') |
|
377 | - $type = 'inet'; |
|
378 | - elseif ($var == 'member_ip2') |
|
379 | - $type = 'inet'; |
|
378 | + if (in_array($var, $knownInts)) { |
|
379 | + $type = 'int'; |
|
380 | + } elseif (in_array($var, $knownFloats)) { |
|
381 | + $type = 'float'; |
|
382 | + } elseif ($var == 'birthdate') { |
|
383 | + $type = 'date'; |
|
384 | + } elseif ($var == 'member_ip') { |
|
385 | + $type = 'inet'; |
|
386 | + } elseif ($var == 'member_ip2') { |
|
387 | + $type = 'inet'; |
|
388 | + } |
|
380 | 389 | |
381 | 390 | // Doing an increment? |
382 | 391 | if ($var == 'alerts' && ($val === '+' || $val === '-')) |
@@ -385,18 +394,17 @@ discard block |
||
385 | 394 | if (is_array($members)) |
386 | 395 | { |
387 | 396 | $val = 'CASE '; |
388 | - foreach ($members as $k => $v) |
|
389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
397 | + foreach ($members as $k => $v) { |
|
398 | + $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
399 | + } |
|
390 | 400 | $val = $val . ' END'; |
391 | 401 | $type = 'raw'; |
392 | - } |
|
393 | - else |
|
402 | + } else |
|
394 | 403 | { |
395 | 404 | $blub = fetch_alerts($members, false, 0, array(), false); |
396 | 405 | $val = count($blub); |
397 | 406 | } |
398 | - } |
|
399 | - else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
407 | + } else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
400 | 408 | { |
401 | 409 | $val = $var . ' ' . $val . ' 1'; |
402 | 410 | $type = 'raw'; |
@@ -407,8 +415,9 @@ discard block |
||
407 | 415 | { |
408 | 416 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
409 | 417 | { |
410 | - if ($match[1] != '+ ') |
|
411 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
418 | + if ($match[1] != '+ ') { |
|
419 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
420 | + } |
|
412 | 421 | $type = 'raw'; |
413 | 422 | } |
414 | 423 | } |
@@ -429,8 +438,9 @@ discard block |
||
429 | 438 | // Clear any caching? |
430 | 439 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
431 | 440 | { |
432 | - if (!is_array($members)) |
|
433 | - $members = array($members); |
|
441 | + if (!is_array($members)) { |
|
442 | + $members = array($members); |
|
443 | + } |
|
434 | 444 | |
435 | 445 | foreach ($members as $member) |
436 | 446 | { |
@@ -463,29 +473,32 @@ discard block |
||
463 | 473 | { |
464 | 474 | global $modSettings, $smcFunc; |
465 | 475 | |
466 | - if (empty($changeArray) || !is_array($changeArray)) |
|
467 | - return; |
|
476 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
477 | + return; |
|
478 | + } |
|
468 | 479 | |
469 | 480 | $toRemove = array(); |
470 | 481 | |
471 | 482 | // Go check if there is any setting to be removed. |
472 | - foreach ($changeArray as $k => $v) |
|
473 | - if ($v === null) |
|
483 | + foreach ($changeArray as $k => $v) { |
|
484 | + if ($v === null) |
|
474 | 485 | { |
475 | 486 | // Found some, remove them from the original array and add them to ours. |
476 | 487 | unset($changeArray[$k]); |
488 | + } |
|
477 | 489 | $toRemove[] = $k; |
478 | 490 | } |
479 | 491 | |
480 | 492 | // Proceed with the deletion. |
481 | - if (!empty($toRemove)) |
|
482 | - $smcFunc['db_query']('', ' |
|
493 | + if (!empty($toRemove)) { |
|
494 | + $smcFunc['db_query']('', ' |
|
483 | 495 | DELETE FROM {db_prefix}settings |
484 | 496 | WHERE variable IN ({array_string:remove})', |
485 | 497 | array( |
486 | 498 | 'remove' => $toRemove, |
487 | 499 | ) |
488 | 500 | ); |
501 | + } |
|
489 | 502 | |
490 | 503 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
491 | 504 | if ($update) |
@@ -514,19 +527,22 @@ discard block |
||
514 | 527 | foreach ($changeArray as $variable => $value) |
515 | 528 | { |
516 | 529 | // Don't bother if it's already like that ;). |
517 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
518 | - continue; |
|
530 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
531 | + continue; |
|
532 | + } |
|
519 | 533 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
520 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
521 | - continue; |
|
534 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
535 | + continue; |
|
536 | + } |
|
522 | 537 | |
523 | 538 | $replaceArray[] = array($variable, $value); |
524 | 539 | |
525 | 540 | $modSettings[$variable] = $value; |
526 | 541 | } |
527 | 542 | |
528 | - if (empty($replaceArray)) |
|
529 | - return; |
|
543 | + if (empty($replaceArray)) { |
|
544 | + return; |
|
545 | + } |
|
530 | 546 | |
531 | 547 | $smcFunc['db_insert']('replace', |
532 | 548 | '{db_prefix}settings', |
@@ -572,14 +588,17 @@ discard block |
||
572 | 588 | $start_invalid = $start < 0; |
573 | 589 | |
574 | 590 | // Make sure $start is a proper variable - not less than 0. |
575 | - if ($start_invalid) |
|
576 | - $start = 0; |
|
591 | + if ($start_invalid) { |
|
592 | + $start = 0; |
|
593 | + } |
|
577 | 594 | // Not greater than the upper bound. |
578 | - elseif ($start >= $max_value) |
|
579 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
595 | + elseif ($start >= $max_value) { |
|
596 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
597 | + } |
|
580 | 598 | // And it has to be a multiple of $num_per_page! |
581 | - else |
|
582 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
599 | + else { |
|
600 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
601 | + } |
|
583 | 602 | |
584 | 603 | $context['current_page'] = $start / $num_per_page; |
585 | 604 | |
@@ -609,77 +628,87 @@ discard block |
||
609 | 628 | |
610 | 629 | // Show all the pages. |
611 | 630 | $display_page = 1; |
612 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
613 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
631 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
632 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
633 | + } |
|
614 | 634 | |
615 | 635 | // Show the right arrow. |
616 | 636 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
617 | - if ($start != $counter - $max_value && !$start_invalid) |
|
618 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
619 | - } |
|
620 | - else |
|
637 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
638 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
639 | + } |
|
640 | + } else |
|
621 | 641 | { |
622 | 642 | // If they didn't enter an odd value, pretend they did. |
623 | 643 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
624 | 644 | |
625 | 645 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
626 | - if (!empty($start) && $show_prevnext) |
|
627 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
628 | - else |
|
629 | - $pageindex .= ''; |
|
646 | + if (!empty($start) && $show_prevnext) { |
|
647 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
648 | + } else { |
|
649 | + $pageindex .= ''; |
|
650 | + } |
|
630 | 651 | |
631 | 652 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
632 | - if ($start > $num_per_page * $PageContiguous) |
|
633 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
653 | + if ($start > $num_per_page * $PageContiguous) { |
|
654 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
655 | + } |
|
634 | 656 | |
635 | 657 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
636 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
637 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
658 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
659 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
638 | 660 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
639 | 661 | '{FIRST_PAGE}' => $num_per_page, |
640 | 662 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
641 | 663 | '{PER_PAGE}' => $num_per_page, |
642 | 664 | )); |
665 | + } |
|
643 | 666 | |
644 | 667 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
645 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
646 | - if ($start >= $num_per_page * $nCont) |
|
668 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
669 | + if ($start >= $num_per_page * $nCont) |
|
647 | 670 | { |
648 | 671 | $tmpStart = $start - $num_per_page * $nCont; |
672 | + } |
|
649 | 673 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
650 | 674 | } |
651 | 675 | |
652 | 676 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
653 | - if (!$start_invalid) |
|
654 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
655 | - else |
|
656 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
677 | + if (!$start_invalid) { |
|
678 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
679 | + } else { |
|
680 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
681 | + } |
|
657 | 682 | |
658 | 683 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
659 | 684 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
660 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
661 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
685 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
686 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
662 | 687 | { |
663 | 688 | $tmpStart = $start + $num_per_page * $nCont; |
689 | + } |
|
664 | 690 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
665 | 691 | } |
666 | 692 | |
667 | 693 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
668 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
669 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
694 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
695 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
670 | 696 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
671 | 697 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
672 | 698 | '{LAST_PAGE}' => $tmpMaxPages, |
673 | 699 | '{PER_PAGE}' => $num_per_page, |
674 | 700 | )); |
701 | + } |
|
675 | 702 | |
676 | 703 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
677 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
678 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
704 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
705 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
706 | + } |
|
679 | 707 | |
680 | 708 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
681 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
682 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
709 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
710 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
711 | + } |
|
683 | 712 | } |
684 | 713 | $pageindex .= $settings['page_index']['extra_after']; |
685 | 714 | |
@@ -705,8 +734,9 @@ discard block |
||
705 | 734 | if ($decimal_separator === null) |
706 | 735 | { |
707 | 736 | // Not set for whatever reason? |
708 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
709 | - return $number; |
|
737 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
738 | + return $number; |
|
739 | + } |
|
710 | 740 | |
711 | 741 | // Cache these each load... |
712 | 742 | $thousands_separator = $matches[1]; |
@@ -740,17 +770,20 @@ discard block |
||
740 | 770 | static $unsupportedFormats, $finalizedFormats; |
741 | 771 | |
742 | 772 | // Offset the time. |
743 | - if (!$offset_type) |
|
744 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
773 | + if (!$offset_type) { |
|
774 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
775 | + } |
|
745 | 776 | // Just the forum offset? |
746 | - elseif ($offset_type == 'forum') |
|
747 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
748 | - else |
|
749 | - $time = $log_time; |
|
777 | + elseif ($offset_type == 'forum') { |
|
778 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
779 | + } else { |
|
780 | + $time = $log_time; |
|
781 | + } |
|
750 | 782 | |
751 | 783 | // We can't have a negative date (on Windows, at least.) |
752 | - if ($log_time < 0) |
|
753 | - $log_time = 0; |
|
784 | + if ($log_time < 0) { |
|
785 | + $log_time = 0; |
|
786 | + } |
|
754 | 787 | |
755 | 788 | // Today and Yesterday? |
756 | 789 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -767,24 +800,27 @@ discard block |
||
767 | 800 | { |
768 | 801 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
769 | 802 | $today_fmt = $h . ':%M' . $s . ' %p'; |
803 | + } else { |
|
804 | + $today_fmt = '%H:%M' . $s; |
|
770 | 805 | } |
771 | - else |
|
772 | - $today_fmt = '%H:%M' . $s; |
|
773 | 806 | |
774 | 807 | // Same day of the year, same year.... Today! |
775 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
776 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
808 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
809 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
810 | + } |
|
777 | 811 | |
778 | 812 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
779 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
780 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
813 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
814 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
815 | + } |
|
781 | 816 | } |
782 | 817 | |
783 | 818 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
784 | 819 | |
785 | 820 | // Use the cached formats if available |
786 | - if (is_null($finalizedFormats)) |
|
787 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
821 | + if (is_null($finalizedFormats)) { |
|
822 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
823 | + } |
|
788 | 824 | |
789 | 825 | // Make a supported version for this format if we don't already have one |
790 | 826 | if (empty($finalizedFormats[$str])) |
@@ -813,8 +849,9 @@ discard block |
||
813 | 849 | ); |
814 | 850 | |
815 | 851 | // No need to do this part again if we already did it once |
816 | - if (is_null($unsupportedFormats)) |
|
817 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
852 | + if (is_null($unsupportedFormats)) { |
|
853 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
854 | + } |
|
818 | 855 | if (empty($unsupportedFormats)) |
819 | 856 | { |
820 | 857 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -823,20 +860,23 @@ discard block |
||
823 | 860 | |
824 | 861 | // Windows will return false for unsupported formats |
825 | 862 | // Other operating systems return the format string as a literal |
826 | - if ($value === false || $value === $format) |
|
827 | - $unsupportedFormats[] = $format; |
|
863 | + if ($value === false || $value === $format) { |
|
864 | + $unsupportedFormats[] = $format; |
|
865 | + } |
|
828 | 866 | } |
829 | 867 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
830 | 868 | } |
831 | 869 | |
832 | 870 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
833 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
834 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
871 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
872 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
873 | + } |
|
835 | 874 | |
836 | 875 | // Substitute unsupported formats with supported ones |
837 | - if (!empty($unsupportedFormats)) |
|
838 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
876 | + if (!empty($unsupportedFormats)) { |
|
877 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
839 | 878 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
879 | + } |
|
840 | 880 | |
841 | 881 | // Remember this so we don't need to do it again |
842 | 882 | $finalizedFormats[$str] = $timeformat; |
@@ -845,33 +885,39 @@ discard block |
||
845 | 885 | |
846 | 886 | $str = $finalizedFormats[$str]; |
847 | 887 | |
848 | - if (!isset($locale_cache)) |
|
849 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
888 | + if (!isset($locale_cache)) { |
|
889 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
890 | + } |
|
850 | 891 | |
851 | 892 | if ($locale_cache !== false) |
852 | 893 | { |
853 | 894 | // Check if another process changed the locale |
854 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
855 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
895 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
896 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
897 | + } |
|
856 | 898 | |
857 | - if (!isset($non_twelve_hour)) |
|
858 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
859 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
860 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
899 | + if (!isset($non_twelve_hour)) { |
|
900 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
901 | + } |
|
902 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
903 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
904 | + } |
|
861 | 905 | |
862 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
863 | - if (strpos($str, $token) !== false) |
|
906 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
907 | + if (strpos($str, $token) !== false) |
|
864 | 908 | $str = str_replace($token, strftime($token, $time), $str); |
865 | - } |
|
866 | - else |
|
909 | + } |
|
910 | + } else |
|
867 | 911 | { |
868 | 912 | // Do-it-yourself time localization. Fun. |
869 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
870 | - if (strpos($str, $token) !== false) |
|
913 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
914 | + if (strpos($str, $token) !== false) |
|
871 | 915 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
916 | + } |
|
872 | 917 | |
873 | - if (strpos($str, '%p') !== false) |
|
874 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
918 | + if (strpos($str, '%p') !== false) { |
|
919 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
920 | + } |
|
875 | 921 | } |
876 | 922 | |
877 | 923 | // Format the time and then restore any literal percent characters |
@@ -894,16 +940,19 @@ discard block |
||
894 | 940 | static $translation = array(); |
895 | 941 | |
896 | 942 | // Determine the character set... Default to UTF-8 |
897 | - if (empty($context['character_set'])) |
|
898 | - $charset = 'UTF-8'; |
|
943 | + if (empty($context['character_set'])) { |
|
944 | + $charset = 'UTF-8'; |
|
945 | + } |
|
899 | 946 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
900 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
901 | - $charset = 'ISO-8859-1'; |
|
902 | - else |
|
903 | - $charset = $context['character_set']; |
|
947 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
948 | + $charset = 'ISO-8859-1'; |
|
949 | + } else { |
|
950 | + $charset = $context['character_set']; |
|
951 | + } |
|
904 | 952 | |
905 | - if (empty($translation)) |
|
906 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
953 | + if (empty($translation)) { |
|
954 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
955 | + } |
|
907 | 956 | |
908 | 957 | return strtr($string, $translation); |
909 | 958 | } |
@@ -925,8 +974,9 @@ discard block |
||
925 | 974 | global $smcFunc; |
926 | 975 | |
927 | 976 | // It was already short enough! |
928 | - if ($smcFunc['strlen']($subject) <= $len) |
|
929 | - return $subject; |
|
977 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
978 | + return $subject; |
|
979 | + } |
|
930 | 980 | |
931 | 981 | // Shorten it by the length it was too long, and strip off junk from the end. |
932 | 982 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -945,10 +995,11 @@ discard block |
||
945 | 995 | { |
946 | 996 | global $user_info, $modSettings; |
947 | 997 | |
948 | - if ($timestamp === null) |
|
949 | - $timestamp = time(); |
|
950 | - elseif ($timestamp == 0) |
|
951 | - return 0; |
|
998 | + if ($timestamp === null) { |
|
999 | + $timestamp = time(); |
|
1000 | + } elseif ($timestamp == 0) { |
|
1001 | + return 0; |
|
1002 | + } |
|
952 | 1003 | |
953 | 1004 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
954 | 1005 | } |
@@ -977,8 +1028,9 @@ discard block |
||
977 | 1028 | $array[$i] = $array[$j]; |
978 | 1029 | $array[$j] = $temp; |
979 | 1030 | |
980 | - for ($i = 1; $p[$i] == 0; $i++) |
|
981 | - $p[$i] = 1; |
|
1031 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
1032 | + $p[$i] = 1; |
|
1033 | + } |
|
982 | 1034 | |
983 | 1035 | $orders[] = $array; |
984 | 1036 | } |
@@ -1010,12 +1062,14 @@ discard block |
||
1010 | 1062 | static $disabled; |
1011 | 1063 | |
1012 | 1064 | // Don't waste cycles |
1013 | - if ($message === '') |
|
1014 | - return ''; |
|
1065 | + if ($message === '') { |
|
1066 | + return ''; |
|
1067 | + } |
|
1015 | 1068 | |
1016 | 1069 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
1017 | - if (!isset($context['utf8'])) |
|
1018 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1070 | + if (!isset($context['utf8'])) { |
|
1071 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1072 | + } |
|
1019 | 1073 | |
1020 | 1074 | // Clean up any cut/paste issues we may have |
1021 | 1075 | $message = sanitizeMSCutPaste($message); |
@@ -1027,13 +1081,15 @@ discard block |
||
1027 | 1081 | return $message; |
1028 | 1082 | } |
1029 | 1083 | |
1030 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
1031 | - $smileys = (bool) $smileys; |
|
1084 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
1085 | + $smileys = (bool) $smileys; |
|
1086 | + } |
|
1032 | 1087 | |
1033 | 1088 | if (empty($modSettings['enableBBC']) && $message !== false) |
1034 | 1089 | { |
1035 | - if ($smileys === true) |
|
1036 | - parsesmileys($message); |
|
1090 | + if ($smileys === true) { |
|
1091 | + parsesmileys($message); |
|
1092 | + } |
|
1037 | 1093 | |
1038 | 1094 | return $message; |
1039 | 1095 | } |
@@ -1046,8 +1102,9 @@ discard block |
||
1046 | 1102 | } |
1047 | 1103 | |
1048 | 1104 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
1049 | - if (!empty($modSettings['autoLinkUrls'])) |
|
1050 | - set_tld_regex(); |
|
1105 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
1106 | + set_tld_regex(); |
|
1107 | + } |
|
1051 | 1108 | |
1052 | 1109 | // Allow mods access before entering the main parse_bbc loop |
1053 | 1110 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1061,12 +1118,14 @@ discard block |
||
1061 | 1118 | |
1062 | 1119 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
1063 | 1120 | |
1064 | - foreach ($temp as $tag) |
|
1065 | - $disabled[trim($tag)] = true; |
|
1121 | + foreach ($temp as $tag) { |
|
1122 | + $disabled[trim($tag)] = true; |
|
1123 | + } |
|
1066 | 1124 | } |
1067 | 1125 | |
1068 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1069 | - $disabled['flash'] = true; |
|
1126 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1127 | + $disabled['flash'] = true; |
|
1128 | + } |
|
1070 | 1129 | |
1071 | 1130 | /* The following bbc are formatted as an array, with keys as follows: |
1072 | 1131 | |
@@ -1187,8 +1246,9 @@ discard block |
||
1187 | 1246 | $returnContext = ''; |
1188 | 1247 | |
1189 | 1248 | // BBC or the entire attachments feature is disabled |
1190 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
1191 | - return $data; |
|
1249 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
1250 | + return $data; |
|
1251 | + } |
|
1192 | 1252 | |
1193 | 1253 | // Save the attach ID. |
1194 | 1254 | $attachID = $data; |
@@ -1199,8 +1259,9 @@ discard block |
||
1199 | 1259 | $currentAttachment = parseAttachBBC($attachID); |
1200 | 1260 | |
1201 | 1261 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
1202 | - if (is_string($currentAttachment)) |
|
1203 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1262 | + if (is_string($currentAttachment)) { |
|
1263 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1264 | + } |
|
1204 | 1265 | |
1205 | 1266 | if (!empty($currentAttachment['is_image'])) |
1206 | 1267 | { |
@@ -1216,15 +1277,17 @@ discard block |
||
1216 | 1277 | $height = ' height="' . $currentAttachment['height'] . '"'; |
1217 | 1278 | } |
1218 | 1279 | |
1219 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
1220 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1221 | - else |
|
1222 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1280 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
1281 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1282 | + } else { |
|
1283 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1284 | + } |
|
1223 | 1285 | } |
1224 | 1286 | |
1225 | 1287 | // No image. Show a link. |
1226 | - else |
|
1227 | - $returnContext .= $currentAttachment['link']; |
|
1288 | + else { |
|
1289 | + $returnContext .= $currentAttachment['link']; |
|
1290 | + } |
|
1228 | 1291 | |
1229 | 1292 | // Gotta append what we just did. |
1230 | 1293 | $data = $returnContext; |
@@ -1255,8 +1318,9 @@ discard block |
||
1255 | 1318 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1256 | 1319 | { |
1257 | 1320 | // Do PHP code coloring? |
1258 | - if ($php_parts[$php_i] != '<?php') |
|
1259 | - continue; |
|
1321 | + if ($php_parts[$php_i] != '<?php') { |
|
1322 | + continue; |
|
1323 | + } |
|
1260 | 1324 | |
1261 | 1325 | $php_string = ''; |
1262 | 1326 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1272,8 +1336,9 @@ discard block |
||
1272 | 1336 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
1273 | 1337 | |
1274 | 1338 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1275 | - if ($context['browser']['is_opera']) |
|
1276 | - $data .= ' '; |
|
1339 | + if ($context['browser']['is_opera']) { |
|
1340 | + $data .= ' '; |
|
1341 | + } |
|
1277 | 1342 | } |
1278 | 1343 | }, |
1279 | 1344 | 'block_level' => true, |
@@ -1292,8 +1357,9 @@ discard block |
||
1292 | 1357 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1293 | 1358 | { |
1294 | 1359 | // Do PHP code coloring? |
1295 | - if ($php_parts[$php_i] != '<?php') |
|
1296 | - continue; |
|
1360 | + if ($php_parts[$php_i] != '<?php') { |
|
1361 | + continue; |
|
1362 | + } |
|
1297 | 1363 | |
1298 | 1364 | $php_string = ''; |
1299 | 1365 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1309,8 +1375,9 @@ discard block |
||
1309 | 1375 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
1310 | 1376 | |
1311 | 1377 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1312 | - if ($context['browser']['is_opera']) |
|
1313 | - $data[0] .= ' '; |
|
1378 | + if ($context['browser']['is_opera']) { |
|
1379 | + $data[0] .= ' '; |
|
1380 | + } |
|
1314 | 1381 | } |
1315 | 1382 | }, |
1316 | 1383 | 'block_level' => true, |
@@ -1348,11 +1415,13 @@ discard block |
||
1348 | 1415 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1349 | 1416 | 'validate' => function (&$tag, &$data, $disabled) |
1350 | 1417 | { |
1351 | - if (isset($disabled['url'])) |
|
1352 | - $tag['content'] = '$1'; |
|
1418 | + if (isset($disabled['url'])) { |
|
1419 | + $tag['content'] = '$1'; |
|
1420 | + } |
|
1353 | 1421 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
1354 | - if (empty($scheme)) |
|
1355 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
1422 | + if (empty($scheme)) { |
|
1423 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
1424 | + } |
|
1356 | 1425 | }, |
1357 | 1426 | 'disabled_content' => '<a href="$1" target="_blank" rel="noopener">$1</a>', |
1358 | 1427 | ), |
@@ -1366,10 +1435,11 @@ discard block |
||
1366 | 1435 | { |
1367 | 1436 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1368 | 1437 | |
1369 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
1370 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1371 | - else |
|
1372 | - $css = ''; |
|
1438 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
1439 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1440 | + } else { |
|
1441 | + $css = ''; |
|
1442 | + } |
|
1373 | 1443 | |
1374 | 1444 | $data = $class . $css; |
1375 | 1445 | }, |
@@ -1419,14 +1489,16 @@ discard block |
||
1419 | 1489 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1420 | 1490 | if ($image_proxy_enabled) |
1421 | 1491 | { |
1422 | - if (empty($scheme)) |
|
1423 | - $data = 'http://' . ltrim($data, ':/'); |
|
1492 | + if (empty($scheme)) { |
|
1493 | + $data = 'http://' . ltrim($data, ':/'); |
|
1494 | + } |
|
1424 | 1495 | |
1425 | - if ($scheme != 'https') |
|
1426 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1496 | + if ($scheme != 'https') { |
|
1497 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1498 | + } |
|
1499 | + } elseif (empty($scheme)) { |
|
1500 | + $data = '//' . ltrim($data, ':/'); |
|
1427 | 1501 | } |
1428 | - elseif (empty($scheme)) |
|
1429 | - $data = '//' . ltrim($data, ':/'); |
|
1430 | 1502 | }, |
1431 | 1503 | 'disabled_content' => '($1)', |
1432 | 1504 | ), |
@@ -1442,14 +1514,16 @@ discard block |
||
1442 | 1514 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1443 | 1515 | if ($image_proxy_enabled) |
1444 | 1516 | { |
1445 | - if (empty($scheme)) |
|
1446 | - $data = 'http://' . ltrim($data, ':/'); |
|
1517 | + if (empty($scheme)) { |
|
1518 | + $data = 'http://' . ltrim($data, ':/'); |
|
1519 | + } |
|
1447 | 1520 | |
1448 | - if ($scheme != 'https') |
|
1449 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1521 | + if ($scheme != 'https') { |
|
1522 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1523 | + } |
|
1524 | + } elseif (empty($scheme)) { |
|
1525 | + $data = '//' . ltrim($data, ':/'); |
|
1450 | 1526 | } |
1451 | - elseif (empty($scheme)) |
|
1452 | - $data = '//' . ltrim($data, ':/'); |
|
1453 | 1527 | }, |
1454 | 1528 | 'disabled_content' => '($1)', |
1455 | 1529 | ), |
@@ -1461,8 +1535,9 @@ discard block |
||
1461 | 1535 | { |
1462 | 1536 | $data = strtr($data, array('<br>' => '')); |
1463 | 1537 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1464 | - if (empty($scheme)) |
|
1465 | - $data = '//' . ltrim($data, ':/'); |
|
1538 | + if (empty($scheme)) { |
|
1539 | + $data = '//' . ltrim($data, ':/'); |
|
1540 | + } |
|
1466 | 1541 | }, |
1467 | 1542 | ), |
1468 | 1543 | array( |
@@ -1473,13 +1548,14 @@ discard block |
||
1473 | 1548 | 'after' => '</a>', |
1474 | 1549 | 'validate' => function (&$tag, &$data, $disabled) |
1475 | 1550 | { |
1476 | - if (substr($data, 0, 1) == '#') |
|
1477 | - $data = '#post_' . substr($data, 1); |
|
1478 | - else |
|
1551 | + if (substr($data, 0, 1) == '#') { |
|
1552 | + $data = '#post_' . substr($data, 1); |
|
1553 | + } else |
|
1479 | 1554 | { |
1480 | 1555 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1481 | - if (empty($scheme)) |
|
1482 | - $data = '//' . ltrim($data, ':/'); |
|
1556 | + if (empty($scheme)) { |
|
1557 | + $data = '//' . ltrim($data, ':/'); |
|
1558 | + } |
|
1483 | 1559 | } |
1484 | 1560 | }, |
1485 | 1561 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1557,8 +1633,9 @@ discard block |
||
1557 | 1633 | { |
1558 | 1634 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
1559 | 1635 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
1560 | - if ($add_begin) |
|
1561 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1636 | + if ($add_begin) { |
|
1637 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1638 | + } |
|
1562 | 1639 | } |
1563 | 1640 | }, |
1564 | 1641 | 'block_level' => false, |
@@ -1689,10 +1766,11 @@ discard block |
||
1689 | 1766 | 'content' => '$1', |
1690 | 1767 | 'validate' => function (&$tag, &$data, $disabled) |
1691 | 1768 | { |
1692 | - if (is_numeric($data)) |
|
1693 | - $data = timeformat($data); |
|
1694 | - else |
|
1695 | - $tag['content'] = '[time]$1[/time]'; |
|
1769 | + if (is_numeric($data)) { |
|
1770 | + $data = timeformat($data); |
|
1771 | + } else { |
|
1772 | + $tag['content'] = '[time]$1[/time]'; |
|
1773 | + } |
|
1696 | 1774 | }, |
1697 | 1775 | ), |
1698 | 1776 | array( |
@@ -1719,8 +1797,9 @@ discard block |
||
1719 | 1797 | { |
1720 | 1798 | $data = strtr($data, array('<br>' => '')); |
1721 | 1799 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1722 | - if (empty($scheme)) |
|
1723 | - $data = '//' . ltrim($data, ':/'); |
|
1800 | + if (empty($scheme)) { |
|
1801 | + $data = '//' . ltrim($data, ':/'); |
|
1802 | + } |
|
1724 | 1803 | }, |
1725 | 1804 | ), |
1726 | 1805 | array( |
@@ -1732,8 +1811,9 @@ discard block |
||
1732 | 1811 | 'validate' => function (&$tag, &$data, $disabled) |
1733 | 1812 | { |
1734 | 1813 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1735 | - if (empty($scheme)) |
|
1736 | - $data = '//' . ltrim($data, ':/'); |
|
1814 | + if (empty($scheme)) { |
|
1815 | + $data = '//' . ltrim($data, ':/'); |
|
1816 | + } |
|
1737 | 1817 | }, |
1738 | 1818 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
1739 | 1819 | 'disabled_after' => ' ($1)', |
@@ -1753,8 +1833,9 @@ discard block |
||
1753 | 1833 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
1754 | 1834 | if ($message === false) |
1755 | 1835 | { |
1756 | - if (isset($temp_bbc)) |
|
1757 | - $bbc_codes = $temp_bbc; |
|
1836 | + if (isset($temp_bbc)) { |
|
1837 | + $bbc_codes = $temp_bbc; |
|
1838 | + } |
|
1758 | 1839 | usort($codes, function ($a, $b) { |
1759 | 1840 | return strcmp($a['tag'], $b['tag']); |
1760 | 1841 | }); |
@@ -1774,8 +1855,9 @@ discard block |
||
1774 | 1855 | ); |
1775 | 1856 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
1776 | 1857 | { |
1777 | - foreach ($itemcodes as $c => $dummy) |
|
1778 | - $bbc_codes[$c] = array(); |
|
1858 | + foreach ($itemcodes as $c => $dummy) { |
|
1859 | + $bbc_codes[$c] = array(); |
|
1860 | + } |
|
1779 | 1861 | } |
1780 | 1862 | |
1781 | 1863 | // Shhhh! |
@@ -1796,12 +1878,14 @@ discard block |
||
1796 | 1878 | foreach ($codes as $code) |
1797 | 1879 | { |
1798 | 1880 | // Make it easier to process parameters later |
1799 | - if (!empty($code['parameters'])) |
|
1800 | - ksort($code['parameters'], SORT_STRING); |
|
1881 | + if (!empty($code['parameters'])) { |
|
1882 | + ksort($code['parameters'], SORT_STRING); |
|
1883 | + } |
|
1801 | 1884 | |
1802 | 1885 | // If we are not doing every tag only do ones we are interested in. |
1803 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
1804 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1886 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
1887 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1888 | + } |
|
1805 | 1889 | } |
1806 | 1890 | $codes = null; |
1807 | 1891 | } |
@@ -1812,8 +1896,9 @@ discard block |
||
1812 | 1896 | // It's likely this will change if the message is modified. |
1813 | 1897 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
1814 | 1898 | |
1815 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
1816 | - return $temp; |
|
1899 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
1900 | + return $temp; |
|
1901 | + } |
|
1817 | 1902 | |
1818 | 1903 | $cache_t = microtime(); |
1819 | 1904 | } |
@@ -1845,8 +1930,9 @@ discard block |
||
1845 | 1930 | $disabled['flash'] = true; |
1846 | 1931 | |
1847 | 1932 | // @todo Change maybe? |
1848 | - if (!isset($_GET['images'])) |
|
1849 | - $disabled['img'] = true; |
|
1933 | + if (!isset($_GET['images'])) { |
|
1934 | + $disabled['img'] = true; |
|
1935 | + } |
|
1850 | 1936 | |
1851 | 1937 | // @todo Interface/setting to add more? |
1852 | 1938 | } |
@@ -1870,8 +1956,9 @@ discard block |
||
1870 | 1956 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
1871 | 1957 | |
1872 | 1958 | // Failsafe. |
1873 | - if ($pos === false || $last_pos > $pos) |
|
1874 | - $pos = strlen($message) + 1; |
|
1959 | + if ($pos === false || $last_pos > $pos) { |
|
1960 | + $pos = strlen($message) + 1; |
|
1961 | + } |
|
1875 | 1962 | |
1876 | 1963 | // Can't have a one letter smiley, URL, or email! (sorry.) |
1877 | 1964 | if ($last_pos < $pos - 1) |
@@ -1889,8 +1976,9 @@ discard block |
||
1889 | 1976 | |
1890 | 1977 | // <br> should be empty. |
1891 | 1978 | $empty_tags = array('br', 'hr'); |
1892 | - foreach ($empty_tags as $tag) |
|
1893 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1979 | + foreach ($empty_tags as $tag) { |
|
1980 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1981 | + } |
|
1894 | 1982 | |
1895 | 1983 | // b, u, i, s, pre... basic tags. |
1896 | 1984 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1899,8 +1987,9 @@ discard block |
||
1899 | 1987 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
1900 | 1988 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
1901 | 1989 | |
1902 | - if ($diff > 0) |
|
1903 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1990 | + if ($diff > 0) { |
|
1991 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1992 | + } |
|
1904 | 1993 | } |
1905 | 1994 | |
1906 | 1995 | // Do <img ...> - with security... action= -> action-. |
@@ -1913,8 +2002,9 @@ discard block |
||
1913 | 2002 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
1914 | 2003 | |
1915 | 2004 | // Remove action= from the URL - no funny business, now. |
1916 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
1917 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2005 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
2006 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2007 | + } |
|
1918 | 2008 | |
1919 | 2009 | // Check if the image is larger than allowed. |
1920 | 2010 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1935,9 +2025,9 @@ discard block |
||
1935 | 2025 | |
1936 | 2026 | // Set the new image tag. |
1937 | 2027 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
2028 | + } else { |
|
2029 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1938 | 2030 | } |
1939 | - else |
|
1940 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1941 | 2031 | } |
1942 | 2032 | |
1943 | 2033 | $data = strtr($data, $replaces); |
@@ -1950,16 +2040,18 @@ discard block |
||
1950 | 2040 | $no_autolink_area = false; |
1951 | 2041 | if (!empty($open_tags)) |
1952 | 2042 | { |
1953 | - foreach ($open_tags as $open_tag) |
|
1954 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
2043 | + foreach ($open_tags as $open_tag) { |
|
2044 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
1955 | 2045 | $no_autolink_area = true; |
2046 | + } |
|
1956 | 2047 | } |
1957 | 2048 | |
1958 | 2049 | // Don't go backwards. |
1959 | 2050 | // @todo Don't think is the real solution.... |
1960 | 2051 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
1961 | - if ($pos < $lastAutoPos) |
|
1962 | - $no_autolink_area = true; |
|
2052 | + if ($pos < $lastAutoPos) { |
|
2053 | + $no_autolink_area = true; |
|
2054 | + } |
|
1963 | 2055 | $lastAutoPos = $pos; |
1964 | 2056 | |
1965 | 2057 | if (!$no_autolink_area) |
@@ -2068,17 +2160,19 @@ discard block |
||
2068 | 2160 | if ($scheme == 'mailto') |
2069 | 2161 | { |
2070 | 2162 | $email_address = str_replace('mailto:', '', $url); |
2071 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
2072 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2073 | - else |
|
2074 | - return $url; |
|
2163 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
2164 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2165 | + } else { |
|
2166 | + return $url; |
|
2167 | + } |
|
2075 | 2168 | } |
2076 | 2169 | |
2077 | 2170 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
2078 | - if (empty($scheme)) |
|
2079 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
2080 | - else |
|
2081 | - $fullUrl = $url; |
|
2171 | + if (empty($scheme)) { |
|
2172 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
2173 | + } else { |
|
2174 | + $fullUrl = $url; |
|
2175 | + } |
|
2082 | 2176 | |
2083 | 2177 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
2084 | 2178 | }, $data); |
@@ -2127,16 +2221,18 @@ discard block |
||
2127 | 2221 | } |
2128 | 2222 | |
2129 | 2223 | // Are we there yet? Are we there yet? |
2130 | - if ($pos >= strlen($message) - 1) |
|
2131 | - break; |
|
2224 | + if ($pos >= strlen($message) - 1) { |
|
2225 | + break; |
|
2226 | + } |
|
2132 | 2227 | |
2133 | 2228 | $tags = strtolower($message[$pos + 1]); |
2134 | 2229 | |
2135 | 2230 | if ($tags == '/' && !empty($open_tags)) |
2136 | 2231 | { |
2137 | 2232 | $pos2 = strpos($message, ']', $pos + 1); |
2138 | - if ($pos2 == $pos + 2) |
|
2139 | - continue; |
|
2233 | + if ($pos2 == $pos + 2) { |
|
2234 | + continue; |
|
2235 | + } |
|
2140 | 2236 | |
2141 | 2237 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
2142 | 2238 | |
@@ -2146,8 +2242,9 @@ discard block |
||
2146 | 2242 | do |
2147 | 2243 | { |
2148 | 2244 | $tag = array_pop($open_tags); |
2149 | - if (!$tag) |
|
2150 | - break; |
|
2245 | + if (!$tag) { |
|
2246 | + break; |
|
2247 | + } |
|
2151 | 2248 | |
2152 | 2249 | if (!empty($tag['block_level'])) |
2153 | 2250 | { |
@@ -2161,10 +2258,11 @@ discard block |
||
2161 | 2258 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
2162 | 2259 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
2163 | 2260 | { |
2164 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2165 | - if ($temp['tag'] == $look_for) |
|
2261 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2262 | + if ($temp['tag'] == $look_for) |
|
2166 | 2263 | { |
2167 | 2264 | $block_level = !empty($temp['block_level']); |
2265 | + } |
|
2168 | 2266 | break; |
2169 | 2267 | } |
2170 | 2268 | } |
@@ -2186,15 +2284,15 @@ discard block |
||
2186 | 2284 | { |
2187 | 2285 | $open_tags = $to_close; |
2188 | 2286 | continue; |
2189 | - } |
|
2190 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2287 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2191 | 2288 | { |
2192 | 2289 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
2193 | 2290 | { |
2194 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2195 | - if ($temp['tag'] == $look_for) |
|
2291 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2292 | + if ($temp['tag'] == $look_for) |
|
2196 | 2293 | { |
2197 | 2294 | $block_level = !empty($temp['block_level']); |
2295 | + } |
|
2198 | 2296 | break; |
2199 | 2297 | } |
2200 | 2298 | } |
@@ -2202,8 +2300,9 @@ discard block |
||
2202 | 2300 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
2203 | 2301 | if (!$block_level) |
2204 | 2302 | { |
2205 | - foreach ($to_close as $tag) |
|
2206 | - array_push($open_tags, $tag); |
|
2303 | + foreach ($to_close as $tag) { |
|
2304 | + array_push($open_tags, $tag); |
|
2305 | + } |
|
2207 | 2306 | continue; |
2208 | 2307 | } |
2209 | 2308 | } |
@@ -2216,14 +2315,17 @@ discard block |
||
2216 | 2315 | |
2217 | 2316 | // See the comment at the end of the big loop - just eating whitespace ;). |
2218 | 2317 | $whitespace_regex = ''; |
2219 | - if (!empty($tag['block_level'])) |
|
2220 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2318 | + if (!empty($tag['block_level'])) { |
|
2319 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2320 | + } |
|
2221 | 2321 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
2222 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2223 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2322 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2323 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2324 | + } |
|
2224 | 2325 | |
2225 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2226 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2326 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2327 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2328 | + } |
|
2227 | 2329 | } |
2228 | 2330 | |
2229 | 2331 | if (!empty($to_close)) |
@@ -2236,8 +2338,9 @@ discard block |
||
2236 | 2338 | } |
2237 | 2339 | |
2238 | 2340 | // No tags for this character, so just keep going (fastest possible course.) |
2239 | - if (!isset($bbc_codes[$tags])) |
|
2240 | - continue; |
|
2341 | + if (!isset($bbc_codes[$tags])) { |
|
2342 | + continue; |
|
2343 | + } |
|
2241 | 2344 | |
2242 | 2345 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
2243 | 2346 | $tag = null; |
@@ -2246,44 +2349,52 @@ discard block |
||
2246 | 2349 | $pt_strlen = strlen($possible['tag']); |
2247 | 2350 | |
2248 | 2351 | // Not a match? |
2249 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
2250 | - continue; |
|
2352 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
2353 | + continue; |
|
2354 | + } |
|
2251 | 2355 | |
2252 | 2356 | $next_c = $message[$pos + 1 + $pt_strlen]; |
2253 | 2357 | |
2254 | 2358 | // A test validation? |
2255 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
2256 | - continue; |
|
2359 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
2360 | + continue; |
|
2361 | + } |
|
2257 | 2362 | // Do we want parameters? |
2258 | 2363 | elseif (!empty($possible['parameters'])) |
2259 | 2364 | { |
2260 | - if ($next_c != ' ') |
|
2261 | - continue; |
|
2262 | - } |
|
2263 | - elseif (isset($possible['type'])) |
|
2365 | + if ($next_c != ' ') { |
|
2366 | + continue; |
|
2367 | + } |
|
2368 | + } elseif (isset($possible['type'])) |
|
2264 | 2369 | { |
2265 | 2370 | // Do we need an equal sign? |
2266 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
2267 | - continue; |
|
2371 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
2372 | + continue; |
|
2373 | + } |
|
2268 | 2374 | // Maybe we just want a /... |
2269 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
2270 | - continue; |
|
2375 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
2376 | + continue; |
|
2377 | + } |
|
2271 | 2378 | // An immediate ]? |
2272 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
2273 | - continue; |
|
2379 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
2380 | + continue; |
|
2381 | + } |
|
2274 | 2382 | } |
2275 | 2383 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
2276 | - elseif ($next_c != ']') |
|
2277 | - continue; |
|
2384 | + elseif ($next_c != ']') { |
|
2385 | + continue; |
|
2386 | + } |
|
2278 | 2387 | |
2279 | 2388 | // Check allowed tree? |
2280 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
2281 | - continue; |
|
2282 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
2283 | - continue; |
|
2389 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
2390 | + continue; |
|
2391 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
2392 | + continue; |
|
2393 | + } |
|
2284 | 2394 | // If this is in the list of disallowed child tags, don't parse it. |
2285 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
2286 | - continue; |
|
2395 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
2396 | + continue; |
|
2397 | + } |
|
2287 | 2398 | |
2288 | 2399 | $pos1 = $pos + 1 + $pt_strlen + 1; |
2289 | 2400 | |
@@ -2295,8 +2406,9 @@ discard block |
||
2295 | 2406 | foreach ($open_tags as $open_quote) |
2296 | 2407 | { |
2297 | 2408 | // Every parent quote this quote has flips the styling |
2298 | - if ($open_quote['tag'] == 'quote') |
|
2299 | - $quote_alt = !$quote_alt; |
|
2409 | + if ($open_quote['tag'] == 'quote') { |
|
2410 | + $quote_alt = !$quote_alt; |
|
2411 | + } |
|
2300 | 2412 | } |
2301 | 2413 | // Add a class to the quote to style alternating blockquotes |
2302 | 2414 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2307,8 +2419,9 @@ discard block |
||
2307 | 2419 | { |
2308 | 2420 | // Build a regular expression for each parameter for the current tag. |
2309 | 2421 | $preg = array(); |
2310 | - foreach ($possible['parameters'] as $p => $info) |
|
2311 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2422 | + foreach ($possible['parameters'] as $p => $info) { |
|
2423 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2424 | + } |
|
2312 | 2425 | |
2313 | 2426 | // Extract the string that potentially holds our parameters. |
2314 | 2427 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2328,24 +2441,27 @@ discard block |
||
2328 | 2441 | |
2329 | 2442 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
2330 | 2443 | |
2331 | - if ($match) |
|
2332 | - $blob_counter = count($blobs) + 1; |
|
2444 | + if ($match) { |
|
2445 | + $blob_counter = count($blobs) + 1; |
|
2446 | + } |
|
2333 | 2447 | } |
2334 | 2448 | |
2335 | 2449 | // Didn't match our parameter list, try the next possible. |
2336 | - if (!$match) |
|
2337 | - continue; |
|
2450 | + if (!$match) { |
|
2451 | + continue; |
|
2452 | + } |
|
2338 | 2453 | |
2339 | 2454 | $params = array(); |
2340 | 2455 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
2341 | 2456 | { |
2342 | 2457 | $key = strtok(ltrim($matches[$i]), '='); |
2343 | - if (isset($possible['parameters'][$key]['value'])) |
|
2344 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2345 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
2346 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2347 | - else |
|
2348 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2458 | + if (isset($possible['parameters'][$key]['value'])) { |
|
2459 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2460 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
2461 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2462 | + } else { |
|
2463 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2464 | + } |
|
2349 | 2465 | |
2350 | 2466 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
2351 | 2467 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2353,23 +2469,26 @@ discard block |
||
2353 | 2469 | |
2354 | 2470 | foreach ($possible['parameters'] as $p => $info) |
2355 | 2471 | { |
2356 | - if (!isset($params['{' . $p . '}'])) |
|
2357 | - $params['{' . $p . '}'] = ''; |
|
2472 | + if (!isset($params['{' . $p . '}'])) { |
|
2473 | + $params['{' . $p . '}'] = ''; |
|
2474 | + } |
|
2358 | 2475 | } |
2359 | 2476 | |
2360 | 2477 | $tag = $possible; |
2361 | 2478 | |
2362 | 2479 | // Put the parameters into the string. |
2363 | - if (isset($tag['before'])) |
|
2364 | - $tag['before'] = strtr($tag['before'], $params); |
|
2365 | - if (isset($tag['after'])) |
|
2366 | - $tag['after'] = strtr($tag['after'], $params); |
|
2367 | - if (isset($tag['content'])) |
|
2368 | - $tag['content'] = strtr($tag['content'], $params); |
|
2480 | + if (isset($tag['before'])) { |
|
2481 | + $tag['before'] = strtr($tag['before'], $params); |
|
2482 | + } |
|
2483 | + if (isset($tag['after'])) { |
|
2484 | + $tag['after'] = strtr($tag['after'], $params); |
|
2485 | + } |
|
2486 | + if (isset($tag['content'])) { |
|
2487 | + $tag['content'] = strtr($tag['content'], $params); |
|
2488 | + } |
|
2369 | 2489 | |
2370 | 2490 | $pos1 += strlen($given_param_string); |
2371 | - } |
|
2372 | - else |
|
2491 | + } else |
|
2373 | 2492 | { |
2374 | 2493 | $tag = $possible; |
2375 | 2494 | $params = array(); |
@@ -2380,8 +2499,9 @@ discard block |
||
2380 | 2499 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
2381 | 2500 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
2382 | 2501 | { |
2383 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
2384 | - continue; |
|
2502 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
2503 | + continue; |
|
2504 | + } |
|
2385 | 2505 | |
2386 | 2506 | $tag = $itemcodes[$message[$pos + 1]]; |
2387 | 2507 | |
@@ -2402,9 +2522,9 @@ discard block |
||
2402 | 2522 | { |
2403 | 2523 | array_pop($open_tags); |
2404 | 2524 | $code = '</li>'; |
2525 | + } else { |
|
2526 | + $code = ''; |
|
2405 | 2527 | } |
2406 | - else |
|
2407 | - $code = ''; |
|
2408 | 2528 | |
2409 | 2529 | // Now we open a new tag. |
2410 | 2530 | $open_tags[] = array( |
@@ -2451,12 +2571,14 @@ discard block |
||
2451 | 2571 | } |
2452 | 2572 | |
2453 | 2573 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
2454 | - if ($tag === null) |
|
2455 | - continue; |
|
2574 | + if ($tag === null) { |
|
2575 | + continue; |
|
2576 | + } |
|
2456 | 2577 | |
2457 | 2578 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
2458 | - if (isset($inside['disallow_children'])) |
|
2459 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2579 | + if (isset($inside['disallow_children'])) { |
|
2580 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2581 | + } |
|
2460 | 2582 | |
2461 | 2583 | // Is this tag disabled? |
2462 | 2584 | if (isset($disabled[$tag['tag']])) |
@@ -2466,14 +2588,13 @@ discard block |
||
2466 | 2588 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
2467 | 2589 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
2468 | 2590 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
2469 | - } |
|
2470 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2591 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2471 | 2592 | { |
2472 | 2593 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
2473 | 2594 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
2595 | + } else { |
|
2596 | + $tag['content'] = $tag['disabled_content']; |
|
2474 | 2597 | } |
2475 | - else |
|
2476 | - $tag['content'] = $tag['disabled_content']; |
|
2477 | 2598 | } |
2478 | 2599 | |
2479 | 2600 | // we use this a lot |
@@ -2483,8 +2604,9 @@ discard block |
||
2483 | 2604 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
2484 | 2605 | { |
2485 | 2606 | $n = count($open_tags) - 1; |
2486 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
2487 | - $n--; |
|
2607 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
2608 | + $n--; |
|
2609 | + } |
|
2488 | 2610 | |
2489 | 2611 | // Close all the non block level tags so this tag isn't surrounded by them. |
2490 | 2612 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2496,12 +2618,15 @@ discard block |
||
2496 | 2618 | |
2497 | 2619 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
2498 | 2620 | $whitespace_regex = ''; |
2499 | - if (!empty($tag['block_level'])) |
|
2500 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2501 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2502 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2503 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2504 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2621 | + if (!empty($tag['block_level'])) { |
|
2622 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2623 | + } |
|
2624 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2625 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2626 | + } |
|
2627 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2628 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2629 | + } |
|
2505 | 2630 | |
2506 | 2631 | array_pop($open_tags); |
2507 | 2632 | } |
@@ -2522,16 +2647,19 @@ discard block |
||
2522 | 2647 | elseif ($tag['type'] == 'unparsed_content') |
2523 | 2648 | { |
2524 | 2649 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
2525 | - if ($pos2 === false) |
|
2526 | - continue; |
|
2650 | + if ($pos2 === false) { |
|
2651 | + continue; |
|
2652 | + } |
|
2527 | 2653 | |
2528 | 2654 | $data = substr($message, $pos1, $pos2 - $pos1); |
2529 | 2655 | |
2530 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
2531 | - $data = substr($data, 4); |
|
2656 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
2657 | + $data = substr($data, 4); |
|
2658 | + } |
|
2532 | 2659 | |
2533 | - if (isset($tag['validate'])) |
|
2534 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2660 | + if (isset($tag['validate'])) { |
|
2661 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2662 | + } |
|
2535 | 2663 | |
2536 | 2664 | $code = strtr($tag['content'], array('$1' => $data)); |
2537 | 2665 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2547,34 +2675,40 @@ discard block |
||
2547 | 2675 | if (isset($tag['quoted'])) |
2548 | 2676 | { |
2549 | 2677 | $quoted = substr($message, $pos1, 6) == '"'; |
2550 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2551 | - continue; |
|
2678 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2679 | + continue; |
|
2680 | + } |
|
2552 | 2681 | |
2553 | - if ($quoted) |
|
2554 | - $pos1 += 6; |
|
2682 | + if ($quoted) { |
|
2683 | + $pos1 += 6; |
|
2684 | + } |
|
2685 | + } else { |
|
2686 | + $quoted = false; |
|
2555 | 2687 | } |
2556 | - else |
|
2557 | - $quoted = false; |
|
2558 | 2688 | |
2559 | 2689 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2560 | - if ($pos2 === false) |
|
2561 | - continue; |
|
2690 | + if ($pos2 === false) { |
|
2691 | + continue; |
|
2692 | + } |
|
2562 | 2693 | |
2563 | 2694 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2564 | - if ($pos3 === false) |
|
2565 | - continue; |
|
2695 | + if ($pos3 === false) { |
|
2696 | + continue; |
|
2697 | + } |
|
2566 | 2698 | |
2567 | 2699 | $data = array( |
2568 | 2700 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
2569 | 2701 | substr($message, $pos1, $pos2 - $pos1) |
2570 | 2702 | ); |
2571 | 2703 | |
2572 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
2573 | - $data[0] = substr($data[0], 4); |
|
2704 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
2705 | + $data[0] = substr($data[0], 4); |
|
2706 | + } |
|
2574 | 2707 | |
2575 | 2708 | // Validation for my parking, please! |
2576 | - if (isset($tag['validate'])) |
|
2577 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2709 | + if (isset($tag['validate'])) { |
|
2710 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2711 | + } |
|
2578 | 2712 | |
2579 | 2713 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
2580 | 2714 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2591,23 +2725,27 @@ discard block |
||
2591 | 2725 | elseif ($tag['type'] == 'unparsed_commas_content') |
2592 | 2726 | { |
2593 | 2727 | $pos2 = strpos($message, ']', $pos1); |
2594 | - if ($pos2 === false) |
|
2595 | - continue; |
|
2728 | + if ($pos2 === false) { |
|
2729 | + continue; |
|
2730 | + } |
|
2596 | 2731 | |
2597 | 2732 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2598 | - if ($pos3 === false) |
|
2599 | - continue; |
|
2733 | + if ($pos3 === false) { |
|
2734 | + continue; |
|
2735 | + } |
|
2600 | 2736 | |
2601 | 2737 | // We want $1 to be the content, and the rest to be csv. |
2602 | 2738 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
2603 | 2739 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
2604 | 2740 | |
2605 | - if (isset($tag['validate'])) |
|
2606 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2741 | + if (isset($tag['validate'])) { |
|
2742 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2743 | + } |
|
2607 | 2744 | |
2608 | 2745 | $code = $tag['content']; |
2609 | - foreach ($data as $k => $d) |
|
2610 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2746 | + foreach ($data as $k => $d) { |
|
2747 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2748 | + } |
|
2611 | 2749 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
2612 | 2750 | $pos += strlen($code) - 1 + 2; |
2613 | 2751 | } |
@@ -2615,24 +2753,28 @@ discard block |
||
2615 | 2753 | elseif ($tag['type'] == 'unparsed_commas') |
2616 | 2754 | { |
2617 | 2755 | $pos2 = strpos($message, ']', $pos1); |
2618 | - if ($pos2 === false) |
|
2619 | - continue; |
|
2756 | + if ($pos2 === false) { |
|
2757 | + continue; |
|
2758 | + } |
|
2620 | 2759 | |
2621 | 2760 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
2622 | 2761 | |
2623 | - if (isset($tag['validate'])) |
|
2624 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2762 | + if (isset($tag['validate'])) { |
|
2763 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2764 | + } |
|
2625 | 2765 | |
2626 | 2766 | // Fix after, for disabled code mainly. |
2627 | - foreach ($data as $k => $d) |
|
2628 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2767 | + foreach ($data as $k => $d) { |
|
2768 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2769 | + } |
|
2629 | 2770 | |
2630 | 2771 | $open_tags[] = $tag; |
2631 | 2772 | |
2632 | 2773 | // Replace them out, $1, $2, $3, $4, etc. |
2633 | 2774 | $code = $tag['before']; |
2634 | - foreach ($data as $k => $d) |
|
2635 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2775 | + foreach ($data as $k => $d) { |
|
2776 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2777 | + } |
|
2636 | 2778 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
2637 | 2779 | $pos += strlen($code) - 1 + 2; |
2638 | 2780 | } |
@@ -2643,28 +2785,33 @@ discard block |
||
2643 | 2785 | if (isset($tag['quoted'])) |
2644 | 2786 | { |
2645 | 2787 | $quoted = substr($message, $pos1, 6) == '"'; |
2646 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2647 | - continue; |
|
2788 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2789 | + continue; |
|
2790 | + } |
|
2648 | 2791 | |
2649 | - if ($quoted) |
|
2650 | - $pos1 += 6; |
|
2792 | + if ($quoted) { |
|
2793 | + $pos1 += 6; |
|
2794 | + } |
|
2795 | + } else { |
|
2796 | + $quoted = false; |
|
2651 | 2797 | } |
2652 | - else |
|
2653 | - $quoted = false; |
|
2654 | 2798 | |
2655 | 2799 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2656 | - if ($pos2 === false) |
|
2657 | - continue; |
|
2800 | + if ($pos2 === false) { |
|
2801 | + continue; |
|
2802 | + } |
|
2658 | 2803 | |
2659 | 2804 | $data = substr($message, $pos1, $pos2 - $pos1); |
2660 | 2805 | |
2661 | 2806 | // Validation for my parking, please! |
2662 | - if (isset($tag['validate'])) |
|
2663 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2807 | + if (isset($tag['validate'])) { |
|
2808 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2809 | + } |
|
2664 | 2810 | |
2665 | 2811 | // For parsed content, we must recurse to avoid security problems. |
2666 | - if ($tag['type'] != 'unparsed_equals') |
|
2667 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2812 | + if ($tag['type'] != 'unparsed_equals') { |
|
2813 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2814 | + } |
|
2668 | 2815 | |
2669 | 2816 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
2670 | 2817 | |
@@ -2676,34 +2823,40 @@ discard block |
||
2676 | 2823 | } |
2677 | 2824 | |
2678 | 2825 | // If this is block level, eat any breaks after it. |
2679 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
2680 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2826 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
2827 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2828 | + } |
|
2681 | 2829 | |
2682 | 2830 | // Are we trimming outside this tag? |
2683 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
2684 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2831 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
2832 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2833 | + } |
|
2685 | 2834 | } |
2686 | 2835 | |
2687 | 2836 | // Close any remaining tags. |
2688 | - while ($tag = array_pop($open_tags)) |
|
2689 | - $message .= "\n" . $tag['after'] . "\n"; |
|
2837 | + while ($tag = array_pop($open_tags)) { |
|
2838 | + $message .= "\n" . $tag['after'] . "\n"; |
|
2839 | + } |
|
2690 | 2840 | |
2691 | 2841 | // Parse the smileys within the parts where it can be done safely. |
2692 | 2842 | if ($smileys === true) |
2693 | 2843 | { |
2694 | 2844 | $message_parts = explode("\n", $message); |
2695 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
2696 | - parsesmileys($message_parts[$i]); |
|
2845 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
2846 | + parsesmileys($message_parts[$i]); |
|
2847 | + } |
|
2697 | 2848 | |
2698 | 2849 | $message = implode('', $message_parts); |
2699 | 2850 | } |
2700 | 2851 | |
2701 | 2852 | // No smileys, just get rid of the markers. |
2702 | - else |
|
2703 | - $message = strtr($message, array("\n" => '')); |
|
2853 | + else { |
|
2854 | + $message = strtr($message, array("\n" => '')); |
|
2855 | + } |
|
2704 | 2856 | |
2705 | - if ($message !== '' && $message[0] === ' ') |
|
2706 | - $message = ' ' . substr($message, 1); |
|
2857 | + if ($message !== '' && $message[0] === ' ') { |
|
2858 | + $message = ' ' . substr($message, 1); |
|
2859 | + } |
|
2707 | 2860 | |
2708 | 2861 | // Cleanup whitespace. |
2709 | 2862 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2712,15 +2865,16 @@ discard block |
||
2712 | 2865 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
2713 | 2866 | |
2714 | 2867 | // Cache the output if it took some time... |
2715 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
2716 | - cache_put_data($cache_key, $message, 240); |
|
2868 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
2869 | + cache_put_data($cache_key, $message, 240); |
|
2870 | + } |
|
2717 | 2871 | |
2718 | 2872 | // If this was a force parse revert if needed. |
2719 | 2873 | if (!empty($parse_tags)) |
2720 | 2874 | { |
2721 | - if (empty($temp_bbc)) |
|
2722 | - $bbc_codes = array(); |
|
2723 | - else |
|
2875 | + if (empty($temp_bbc)) { |
|
2876 | + $bbc_codes = array(); |
|
2877 | + } else |
|
2724 | 2878 | { |
2725 | 2879 | $bbc_codes = $temp_bbc; |
2726 | 2880 | unset($temp_bbc); |
@@ -2747,8 +2901,9 @@ discard block |
||
2747 | 2901 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
2748 | 2902 | |
2749 | 2903 | // No smiley set at all?! |
2750 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
2751 | - return; |
|
2904 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
2905 | + return; |
|
2906 | + } |
|
2752 | 2907 | |
2753 | 2908 | // If smileyPregSearch hasn't been set, do it now. |
2754 | 2909 | if (empty($smileyPregSearch)) |
@@ -2759,8 +2914,7 @@ discard block |
||
2759 | 2914 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
2760 | 2915 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
2761 | 2916 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
2762 | - } |
|
2763 | - else |
|
2917 | + } else |
|
2764 | 2918 | { |
2765 | 2919 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
2766 | 2920 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2784,9 +2938,9 @@ discard block |
||
2784 | 2938 | $smcFunc['db_free_result']($result); |
2785 | 2939 | |
2786 | 2940 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
2941 | + } else { |
|
2942 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2787 | 2943 | } |
2788 | - else |
|
2789 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2790 | 2944 | } |
2791 | 2945 | |
2792 | 2946 | // The non-breaking-space is a complex thing... |
@@ -2863,35 +3017,41 @@ discard block |
||
2863 | 3017 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
2864 | 3018 | |
2865 | 3019 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
2866 | - if (!empty($context['flush_mail'])) |
|
2867 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3020 | + if (!empty($context['flush_mail'])) { |
|
3021 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2868 | 3022 | AddMailQueue(true); |
3023 | + } |
|
2869 | 3024 | |
2870 | 3025 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
2871 | 3026 | |
2872 | - if ($add) |
|
2873 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3027 | + if ($add) { |
|
3028 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3029 | + } |
|
2874 | 3030 | |
2875 | 3031 | // Put the session ID in. |
2876 | - if (defined('SID') && SID != '') |
|
2877 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3032 | + if (defined('SID') && SID != '') { |
|
3033 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3034 | + } |
|
2878 | 3035 | // Keep that debug in their for template debugging! |
2879 | - elseif (isset($_GET['debug'])) |
|
2880 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3036 | + elseif (isset($_GET['debug'])) { |
|
3037 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3038 | + } |
|
2881 | 3039 | |
2882 | 3040 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
2883 | 3041 | { |
2884 | - if (defined('SID') && SID != '') |
|
2885 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
3042 | + if (defined('SID') && SID != '') { |
|
3043 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
2886 | 3044 | function ($m) use ($scripturl) |
2887 | 3045 | { |
2888 | 3046 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
3047 | + } |
|
2889 | 3048 | }, $setLocation); |
2890 | - else |
|
2891 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
3049 | + else { |
|
3050 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
2892 | 3051 | function ($m) use ($scripturl) |
2893 | 3052 | { |
2894 | 3053 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
3054 | + } |
|
2895 | 3055 | }, $setLocation); |
2896 | 3056 | } |
2897 | 3057 | |
@@ -2902,8 +3062,9 @@ discard block |
||
2902 | 3062 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
2903 | 3063 | |
2904 | 3064 | // Debugging. |
2905 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
2906 | - $_SESSION['debug_redirect'] = $db_cache; |
|
3065 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3066 | + $_SESSION['debug_redirect'] = $db_cache; |
|
3067 | + } |
|
2907 | 3068 | |
2908 | 3069 | obExit(false); |
2909 | 3070 | } |
@@ -2922,51 +3083,60 @@ discard block |
||
2922 | 3083 | |
2923 | 3084 | // Attempt to prevent a recursive loop. |
2924 | 3085 | ++$level; |
2925 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
2926 | - exit; |
|
2927 | - if ($from_fatal_error) |
|
2928 | - $has_fatal_error = true; |
|
3086 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
3087 | + exit; |
|
3088 | + } |
|
3089 | + if ($from_fatal_error) { |
|
3090 | + $has_fatal_error = true; |
|
3091 | + } |
|
2929 | 3092 | |
2930 | 3093 | // Clear out the stat cache. |
2931 | 3094 | trackStats(); |
2932 | 3095 | |
2933 | 3096 | // If we have mail to send, send it. |
2934 | - if (!empty($context['flush_mail'])) |
|
2935 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3097 | + if (!empty($context['flush_mail'])) { |
|
3098 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2936 | 3099 | AddMailQueue(true); |
3100 | + } |
|
2937 | 3101 | |
2938 | 3102 | $do_header = $header === null ? !$header_done : $header; |
2939 | - if ($do_footer === null) |
|
2940 | - $do_footer = $do_header; |
|
3103 | + if ($do_footer === null) { |
|
3104 | + $do_footer = $do_header; |
|
3105 | + } |
|
2941 | 3106 | |
2942 | 3107 | // Has the template/header been done yet? |
2943 | 3108 | if ($do_header) |
2944 | 3109 | { |
2945 | 3110 | // Was the page title set last minute? Also update the HTML safe one. |
2946 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
2947 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3111 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
3112 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3113 | + } |
|
2948 | 3114 | |
2949 | 3115 | // Start up the session URL fixer. |
2950 | 3116 | ob_start('ob_sessrewrite'); |
2951 | 3117 | |
2952 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
2953 | - $buffers = explode(',', $settings['output_buffers']); |
|
2954 | - elseif (!empty($settings['output_buffers'])) |
|
2955 | - $buffers = $settings['output_buffers']; |
|
2956 | - else |
|
2957 | - $buffers = array(); |
|
3118 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
3119 | + $buffers = explode(',', $settings['output_buffers']); |
|
3120 | + } elseif (!empty($settings['output_buffers'])) { |
|
3121 | + $buffers = $settings['output_buffers']; |
|
3122 | + } else { |
|
3123 | + $buffers = array(); |
|
3124 | + } |
|
2958 | 3125 | |
2959 | - if (isset($modSettings['integrate_buffer'])) |
|
2960 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3126 | + if (isset($modSettings['integrate_buffer'])) { |
|
3127 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3128 | + } |
|
2961 | 3129 | |
2962 | - if (!empty($buffers)) |
|
2963 | - foreach ($buffers as $function) |
|
3130 | + if (!empty($buffers)) { |
|
3131 | + foreach ($buffers as $function) |
|
2964 | 3132 | { |
2965 | 3133 | $call = call_helper($function, true); |
3134 | + } |
|
2966 | 3135 | |
2967 | 3136 | // Is it valid? |
2968 | - if (!empty($call)) |
|
2969 | - ob_start($call); |
|
3137 | + if (!empty($call)) { |
|
3138 | + ob_start($call); |
|
3139 | + } |
|
2970 | 3140 | } |
2971 | 3141 | |
2972 | 3142 | // Display the screen in the logical order. |
@@ -2978,8 +3148,9 @@ discard block |
||
2978 | 3148 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
2979 | 3149 | |
2980 | 3150 | // Anything special to put out? |
2981 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
2982 | - echo $context['insert_after_template']; |
|
3151 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
3152 | + echo $context['insert_after_template']; |
|
3153 | + } |
|
2983 | 3154 | |
2984 | 3155 | // Just so we don't get caught in an endless loop of errors from the footer... |
2985 | 3156 | if (!$footer_done) |
@@ -2988,14 +3159,16 @@ discard block |
||
2988 | 3159 | template_footer(); |
2989 | 3160 | |
2990 | 3161 | // (since this is just debugging... it's okay that it's after </html>.) |
2991 | - if (!isset($_REQUEST['xml'])) |
|
2992 | - displayDebug(); |
|
3162 | + if (!isset($_REQUEST['xml'])) { |
|
3163 | + displayDebug(); |
|
3164 | + } |
|
2993 | 3165 | } |
2994 | 3166 | } |
2995 | 3167 | |
2996 | 3168 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
2997 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
2998 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3169 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
3170 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3171 | + } |
|
2999 | 3172 | |
3000 | 3173 | // For session check verification.... don't switch browsers... |
3001 | 3174 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -3004,9 +3177,10 @@ discard block |
||
3004 | 3177 | call_integration_hook('integrate_exit', array($do_footer)); |
3005 | 3178 | |
3006 | 3179 | // Don't exit if we're coming from index.php; that will pass through normally. |
3007 | - if (!$from_index) |
|
3008 | - exit; |
|
3009 | -} |
|
3180 | + if (!$from_index) { |
|
3181 | + exit; |
|
3182 | + } |
|
3183 | + } |
|
3010 | 3184 | |
3011 | 3185 | /** |
3012 | 3186 | * Get the size of a specified image with better error handling. |
@@ -3025,8 +3199,9 @@ discard block |
||
3025 | 3199 | $url = str_replace(' ', '%20', $url); |
3026 | 3200 | |
3027 | 3201 | // Can we pull this from the cache... please please? |
3028 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
3029 | - return $temp; |
|
3202 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
3203 | + return $temp; |
|
3204 | + } |
|
3030 | 3205 | $t = microtime(); |
3031 | 3206 | |
3032 | 3207 | // Get the host to pester... |
@@ -3036,12 +3211,10 @@ discard block |
||
3036 | 3211 | if ($url == '' || $url == 'http://' || $url == 'https://') |
3037 | 3212 | { |
3038 | 3213 | return false; |
3039 | - } |
|
3040 | - elseif (!isset($match[1])) |
|
3214 | + } elseif (!isset($match[1])) |
|
3041 | 3215 | { |
3042 | 3216 | $size = @getimagesize($url); |
3043 | - } |
|
3044 | - else |
|
3217 | + } else |
|
3045 | 3218 | { |
3046 | 3219 | // Try to connect to the server... give it half a second. |
3047 | 3220 | $temp = 0; |
@@ -3080,12 +3253,14 @@ discard block |
||
3080 | 3253 | } |
3081 | 3254 | |
3082 | 3255 | // If we didn't get it, we failed. |
3083 | - if (!isset($size)) |
|
3084 | - $size = false; |
|
3256 | + if (!isset($size)) { |
|
3257 | + $size = false; |
|
3258 | + } |
|
3085 | 3259 | |
3086 | 3260 | // If this took a long time, we may never have to do it again, but then again we might... |
3087 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
3088 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3261 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
3262 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3263 | + } |
|
3089 | 3264 | |
3090 | 3265 | // Didn't work. |
3091 | 3266 | return $size; |
@@ -3103,8 +3278,9 @@ discard block |
||
3103 | 3278 | |
3104 | 3279 | // Under SSI this function can be called more then once. That can cause some problems. |
3105 | 3280 | // So only run the function once unless we are forced to run it again. |
3106 | - if ($loaded && !$forceload) |
|
3107 | - return; |
|
3281 | + if ($loaded && !$forceload) { |
|
3282 | + return; |
|
3283 | + } |
|
3108 | 3284 | |
3109 | 3285 | $loaded = true; |
3110 | 3286 | |
@@ -3116,14 +3292,16 @@ discard block |
||
3116 | 3292 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
3117 | 3293 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
3118 | 3294 | { |
3119 | - if (trim($context['news_lines'][$i]) == '') |
|
3120 | - continue; |
|
3295 | + if (trim($context['news_lines'][$i]) == '') { |
|
3296 | + continue; |
|
3297 | + } |
|
3121 | 3298 | |
3122 | 3299 | // Clean it up for presentation ;). |
3123 | 3300 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
3124 | 3301 | } |
3125 | - if (!empty($context['news_lines'])) |
|
3126 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3302 | + if (!empty($context['news_lines'])) { |
|
3303 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3304 | + } |
|
3127 | 3305 | |
3128 | 3306 | if (!$user_info['is_guest']) |
3129 | 3307 | { |
@@ -3132,40 +3310,48 @@ discard block |
||
3132 | 3310 | $context['user']['alerts'] = &$user_info['alerts']; |
3133 | 3311 | |
3134 | 3312 | // Personal message popup... |
3135 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
3136 | - $context['user']['popup_messages'] = true; |
|
3137 | - else |
|
3138 | - $context['user']['popup_messages'] = false; |
|
3313 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
3314 | + $context['user']['popup_messages'] = true; |
|
3315 | + } else { |
|
3316 | + $context['user']['popup_messages'] = false; |
|
3317 | + } |
|
3139 | 3318 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
3140 | 3319 | |
3141 | - if (allowedTo('moderate_forum')) |
|
3142 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3320 | + if (allowedTo('moderate_forum')) { |
|
3321 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3322 | + } |
|
3143 | 3323 | |
3144 | 3324 | $context['user']['avatar'] = array(); |
3145 | 3325 | |
3146 | 3326 | // Check for gravatar first since we might be forcing them... |
3147 | 3327 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
3148 | 3328 | { |
3149 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
3150 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3151 | - else |
|
3152 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3329 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
3330 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3331 | + } else { |
|
3332 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3333 | + } |
|
3153 | 3334 | } |
3154 | 3335 | // Uploaded? |
3155 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
3156 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3336 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
3337 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3338 | + } |
|
3157 | 3339 | // Full URL? |
3158 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
3159 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3340 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
3341 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3342 | + } |
|
3160 | 3343 | // Otherwise we assume it's server stored. |
3161 | - elseif ($user_info['avatar']['url'] != '') |
|
3162 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3344 | + elseif ($user_info['avatar']['url'] != '') { |
|
3345 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3346 | + } |
|
3163 | 3347 | // No avatar at all? Fine, we have a big fat default avatar ;) |
3164 | - else |
|
3165 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3348 | + else { |
|
3349 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3350 | + } |
|
3166 | 3351 | |
3167 | - if (!empty($context['user']['avatar'])) |
|
3168 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3352 | + if (!empty($context['user']['avatar'])) { |
|
3353 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3354 | + } |
|
3169 | 3355 | |
3170 | 3356 | // Figure out how long they've been logged in. |
3171 | 3357 | $context['user']['total_time_logged_in'] = array( |
@@ -3173,8 +3359,7 @@ discard block |
||
3173 | 3359 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
3174 | 3360 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
3175 | 3361 | ); |
3176 | - } |
|
3177 | - else |
|
3362 | + } else |
|
3178 | 3363 | { |
3179 | 3364 | $context['user']['messages'] = 0; |
3180 | 3365 | $context['user']['unread_messages'] = 0; |
@@ -3182,12 +3367,14 @@ discard block |
||
3182 | 3367 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
3183 | 3368 | $context['user']['popup_messages'] = false; |
3184 | 3369 | |
3185 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
3186 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3370 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
3371 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3372 | + } |
|
3187 | 3373 | |
3188 | 3374 | // If we've upgraded recently, go easy on the passwords. |
3189 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
3190 | - $context['disable_login_hashing'] = true; |
|
3375 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
3376 | + $context['disable_login_hashing'] = true; |
|
3377 | + } |
|
3191 | 3378 | } |
3192 | 3379 | |
3193 | 3380 | // Setup the main menu items. |
@@ -3200,8 +3387,8 @@ discard block |
||
3200 | 3387 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
3201 | 3388 | |
3202 | 3389 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
3203 | - if ($context['show_pm_popup']) |
|
3204 | - addInlineJavaScript(' |
|
3390 | + if ($context['show_pm_popup']) { |
|
3391 | + addInlineJavaScript(' |
|
3205 | 3392 | jQuery(document).ready(function($) { |
3206 | 3393 | new smc_Popup({ |
3207 | 3394 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3209,15 +3396,17 @@ discard block |
||
3209 | 3396 | icon_class: \'generic_icons mail_new\' |
3210 | 3397 | }); |
3211 | 3398 | });'); |
3399 | + } |
|
3212 | 3400 | |
3213 | 3401 | // Add a generic "Are you sure?" confirmation message. |
3214 | 3402 | addInlineJavaScript(' |
3215 | 3403 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
3216 | 3404 | |
3217 | 3405 | // Now add the capping code for avatars. |
3218 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
3219 | - addInlineCss(' |
|
3406 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
3407 | + addInlineCss(' |
|
3220 | 3408 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
3409 | + } |
|
3221 | 3410 | |
3222 | 3411 | // This looks weird, but it's because BoardIndex.php references the variable. |
3223 | 3412 | $context['common_stats']['latest_member'] = array( |
@@ -3234,11 +3423,13 @@ discard block |
||
3234 | 3423 | ); |
3235 | 3424 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
3236 | 3425 | |
3237 | - if (empty($settings['theme_version'])) |
|
3238 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
3426 | + if (empty($settings['theme_version'])) { |
|
3427 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
3428 | + } |
|
3239 | 3429 | |
3240 | - if (!isset($context['page_title'])) |
|
3241 | - $context['page_title'] = ''; |
|
3430 | + if (!isset($context['page_title'])) { |
|
3431 | + $context['page_title'] = ''; |
|
3432 | + } |
|
3242 | 3433 | |
3243 | 3434 | // Set some specific vars. |
3244 | 3435 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3248,21 +3439,23 @@ discard block |
||
3248 | 3439 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
3249 | 3440 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
3250 | 3441 | |
3251 | - if (!empty($context['meta_keywords'])) |
|
3252 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3442 | + if (!empty($context['meta_keywords'])) { |
|
3443 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3444 | + } |
|
3253 | 3445 | |
3254 | - if (!empty($context['canonical_url'])) |
|
3255 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3446 | + if (!empty($context['canonical_url'])) { |
|
3447 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3448 | + } |
|
3256 | 3449 | |
3257 | - if (!empty($settings['og_image'])) |
|
3258 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3450 | + if (!empty($settings['og_image'])) { |
|
3451 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3452 | + } |
|
3259 | 3453 | |
3260 | 3454 | if (!empty($context['meta_description'])) |
3261 | 3455 | { |
3262 | 3456 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
3263 | 3457 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
3264 | - } |
|
3265 | - else |
|
3458 | + } else |
|
3266 | 3459 | { |
3267 | 3460 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
3268 | 3461 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3287,8 +3480,9 @@ discard block |
||
3287 | 3480 | $memory_needed = memoryReturnBytes($needed); |
3288 | 3481 | |
3289 | 3482 | // should we account for how much is currently being used? |
3290 | - if ($in_use) |
|
3291 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3483 | + if ($in_use) { |
|
3484 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3485 | + } |
|
3292 | 3486 | |
3293 | 3487 | // if more is needed, request it |
3294 | 3488 | if ($memory_current < $memory_needed) |
@@ -3311,8 +3505,9 @@ discard block |
||
3311 | 3505 | */ |
3312 | 3506 | function memoryReturnBytes($val) |
3313 | 3507 | { |
3314 | - if (is_integer($val)) |
|
3315 | - return $val; |
|
3508 | + if (is_integer($val)) { |
|
3509 | + return $val; |
|
3510 | + } |
|
3316 | 3511 | |
3317 | 3512 | // Separate the number from the designator |
3318 | 3513 | $val = trim($val); |
@@ -3348,10 +3543,11 @@ discard block |
||
3348 | 3543 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
3349 | 3544 | |
3350 | 3545 | // Are we debugging the template/html content? |
3351 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
3352 | - header('Content-Type: application/xhtml+xml'); |
|
3353 | - elseif (!isset($_REQUEST['xml'])) |
|
3354 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3546 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
3547 | + header('Content-Type: application/xhtml+xml'); |
|
3548 | + } elseif (!isset($_REQUEST['xml'])) { |
|
3549 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3550 | + } |
|
3355 | 3551 | } |
3356 | 3552 | |
3357 | 3553 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3360,8 +3556,9 @@ discard block |
||
3360 | 3556 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
3361 | 3557 | { |
3362 | 3558 | $position = array_search('body', $context['template_layers']); |
3363 | - if ($position === false) |
|
3364 | - $position = array_search('main', $context['template_layers']); |
|
3559 | + if ($position === false) { |
|
3560 | + $position = array_search('main', $context['template_layers']); |
|
3561 | + } |
|
3365 | 3562 | |
3366 | 3563 | if ($position !== false) |
3367 | 3564 | { |
@@ -3389,23 +3586,25 @@ discard block |
||
3389 | 3586 | |
3390 | 3587 | foreach ($securityFiles as $i => $securityFile) |
3391 | 3588 | { |
3392 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
3393 | - unset($securityFiles[$i]); |
|
3589 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
3590 | + unset($securityFiles[$i]); |
|
3591 | + } |
|
3394 | 3592 | } |
3395 | 3593 | |
3396 | 3594 | // We are already checking so many files...just few more doesn't make any difference! :P |
3397 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
3398 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3399 | - |
|
3400 | - else |
|
3401 | - $path = $modSettings['attachmentUploadDir']; |
|
3595 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
3596 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3597 | + } else { |
|
3598 | + $path = $modSettings['attachmentUploadDir']; |
|
3599 | + } |
|
3402 | 3600 | |
3403 | 3601 | secureDirectory($path, true); |
3404 | 3602 | secureDirectory($cachedir); |
3405 | 3603 | |
3406 | 3604 | // If agreement is enabled, at least the english version shall exists |
3407 | - if ($modSettings['requireAgreement']) |
|
3408 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3605 | + if ($modSettings['requireAgreement']) { |
|
3606 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3607 | + } |
|
3409 | 3608 | |
3410 | 3609 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
3411 | 3610 | { |
@@ -3420,18 +3619,21 @@ discard block |
||
3420 | 3619 | echo ' |
3421 | 3620 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
3422 | 3621 | |
3423 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
3424 | - echo ' |
|
3622 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
3623 | + echo ' |
|
3425 | 3624 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
3625 | + } |
|
3426 | 3626 | } |
3427 | 3627 | |
3428 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
3429 | - echo ' |
|
3628 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
3629 | + echo ' |
|
3430 | 3630 | <strong>', $txt['cache_writable'], '</strong><br>'; |
3631 | + } |
|
3431 | 3632 | |
3432 | - if (!empty($agreement)) |
|
3433 | - echo ' |
|
3633 | + if (!empty($agreement)) { |
|
3634 | + echo ' |
|
3434 | 3635 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
3636 | + } |
|
3435 | 3637 | |
3436 | 3638 | echo ' |
3437 | 3639 | </p> |
@@ -3446,16 +3648,18 @@ discard block |
||
3446 | 3648 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
3447 | 3649 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
3448 | 3650 | |
3449 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
3450 | - echo ' |
|
3651 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
3652 | + echo ' |
|
3451 | 3653 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
3654 | + } |
|
3452 | 3655 | |
3453 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
3454 | - echo ' |
|
3656 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
3657 | + echo ' |
|
3455 | 3658 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
3456 | - else |
|
3457 | - echo ' |
|
3659 | + } else { |
|
3660 | + echo ' |
|
3458 | 3661 | <div>', $txt['your_ban_expires_never'], '</div>'; |
3662 | + } |
|
3459 | 3663 | |
3460 | 3664 | echo ' |
3461 | 3665 | </div>'; |
@@ -3471,8 +3675,9 @@ discard block |
||
3471 | 3675 | global $forum_copyright, $software_year, $forum_version; |
3472 | 3676 | |
3473 | 3677 | // Don't display copyright for things like SSI. |
3474 | - if (!isset($forum_version) || !isset($software_year)) |
|
3475 | - return; |
|
3678 | + if (!isset($forum_version) || !isset($software_year)) { |
|
3679 | + return; |
|
3680 | + } |
|
3476 | 3681 | |
3477 | 3682 | // Put in the version... |
3478 | 3683 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3490,9 +3695,10 @@ discard block |
||
3490 | 3695 | $context['load_time'] = round(microtime(true) - $time_start, 3); |
3491 | 3696 | $context['load_queries'] = $db_count; |
3492 | 3697 | |
3493 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
3494 | - loadSubTemplate($layer . '_below', true); |
|
3495 | -} |
|
3698 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
3699 | + loadSubTemplate($layer . '_below', true); |
|
3700 | + } |
|
3701 | + } |
|
3496 | 3702 | |
3497 | 3703 | /** |
3498 | 3704 | * Output the Javascript files |
@@ -3523,8 +3729,7 @@ discard block |
||
3523 | 3729 | { |
3524 | 3730 | echo ' |
3525 | 3731 | var ', $key, ';'; |
3526 | - } |
|
3527 | - else |
|
3732 | + } else |
|
3528 | 3733 | { |
3529 | 3734 | echo ' |
3530 | 3735 | var ', $key, ' = ', $value, ';'; |
@@ -3539,26 +3744,27 @@ discard block |
||
3539 | 3744 | foreach ($context['javascript_files'] as $id => $js_file) |
3540 | 3745 | { |
3541 | 3746 | // Last minute call! allow theme authors to disable single files. |
3542 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3543 | - continue; |
|
3747 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3748 | + continue; |
|
3749 | + } |
|
3544 | 3750 | |
3545 | 3751 | // By default all files don't get minimized unless the file explicitly says so! |
3546 | 3752 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
3547 | 3753 | { |
3548 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
3549 | - $toMinifyDefer[] = $js_file; |
|
3550 | - |
|
3551 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
3552 | - $toMinify[] = $js_file; |
|
3754 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
3755 | + $toMinifyDefer[] = $js_file; |
|
3756 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
3757 | + $toMinify[] = $js_file; |
|
3758 | + } |
|
3553 | 3759 | |
3554 | 3760 | // Grab a random seed. |
3555 | - if (!isset($minSeed)) |
|
3556 | - $minSeed = $js_file['options']['seed']; |
|
3557 | - } |
|
3558 | - |
|
3559 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
3560 | - echo ' |
|
3761 | + if (!isset($minSeed)) { |
|
3762 | + $minSeed = $js_file['options']['seed']; |
|
3763 | + } |
|
3764 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
3765 | + echo ' |
|
3561 | 3766 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
3767 | + } |
|
3562 | 3768 | } |
3563 | 3769 | |
3564 | 3770 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3566,14 +3772,14 @@ discard block |
||
3566 | 3772 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
3567 | 3773 | |
3568 | 3774 | // Minify process couldn't work, print each individual files. |
3569 | - if (!empty($result) && is_array($result)) |
|
3570 | - foreach ($result as $minFailedFile) |
|
3775 | + if (!empty($result) && is_array($result)) { |
|
3776 | + foreach ($result as $minFailedFile) |
|
3571 | 3777 | echo ' |
3572 | 3778 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
3573 | - |
|
3574 | - else |
|
3575 | - echo ' |
|
3779 | + } else { |
|
3780 | + echo ' |
|
3576 | 3781 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
3782 | + } |
|
3577 | 3783 | } |
3578 | 3784 | |
3579 | 3785 | // Inline JavaScript - Actually useful some times! |
@@ -3584,8 +3790,9 @@ discard block |
||
3584 | 3790 | echo ' |
3585 | 3791 | <script>'; |
3586 | 3792 | |
3587 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
3588 | - echo $js_code; |
|
3793 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
3794 | + echo $js_code; |
|
3795 | + } |
|
3589 | 3796 | |
3590 | 3797 | echo ' |
3591 | 3798 | </script>'; |
@@ -3596,8 +3803,9 @@ discard block |
||
3596 | 3803 | echo ' |
3597 | 3804 | <script>'; |
3598 | 3805 | |
3599 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
3600 | - echo $js_code; |
|
3806 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
3807 | + echo $js_code; |
|
3808 | + } |
|
3601 | 3809 | |
3602 | 3810 | echo ' |
3603 | 3811 | </script>'; |
@@ -3622,8 +3830,9 @@ discard block |
||
3622 | 3830 | foreach ($context['css_files'] as $id => $file) |
3623 | 3831 | { |
3624 | 3832 | // Last minute call! allow theme authors to disable single files. |
3625 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3626 | - continue; |
|
3833 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3834 | + continue; |
|
3835 | + } |
|
3627 | 3836 | |
3628 | 3837 | // By default all files don't get minimized unless the file explicitly says so! |
3629 | 3838 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3631,12 +3840,12 @@ discard block |
||
3631 | 3840 | $toMinify[] = $file; |
3632 | 3841 | |
3633 | 3842 | // Grab a random seed. |
3634 | - if (!isset($minSeed)) |
|
3635 | - $minSeed = $file['options']['seed']; |
|
3843 | + if (!isset($minSeed)) { |
|
3844 | + $minSeed = $file['options']['seed']; |
|
3845 | + } |
|
3846 | + } else { |
|
3847 | + $normal[] = $file['fileUrl']; |
|
3636 | 3848 | } |
3637 | - |
|
3638 | - else |
|
3639 | - $normal[] = $file['fileUrl']; |
|
3640 | 3849 | } |
3641 | 3850 | |
3642 | 3851 | if (!empty($toMinify)) |
@@ -3644,28 +3853,30 @@ discard block |
||
3644 | 3853 | $result = custMinify($toMinify, 'css'); |
3645 | 3854 | |
3646 | 3855 | // Minify process couldn't work, print each individual files. |
3647 | - if (!empty($result) && is_array($result)) |
|
3648 | - foreach ($result as $minFailedFile) |
|
3856 | + if (!empty($result) && is_array($result)) { |
|
3857 | + foreach ($result as $minFailedFile) |
|
3649 | 3858 | echo ' |
3650 | 3859 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
3651 | - |
|
3652 | - else |
|
3653 | - echo ' |
|
3860 | + } else { |
|
3861 | + echo ' |
|
3654 | 3862 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
3863 | + } |
|
3655 | 3864 | } |
3656 | 3865 | |
3657 | 3866 | // Print the rest after the minified files. |
3658 | - if (!empty($normal)) |
|
3659 | - foreach ($normal as $nf) |
|
3867 | + if (!empty($normal)) { |
|
3868 | + foreach ($normal as $nf) |
|
3660 | 3869 | echo ' |
3661 | 3870 | <link rel="stylesheet" href="', $nf ,'">'; |
3871 | + } |
|
3662 | 3872 | |
3663 | 3873 | if ($db_show_debug === true) |
3664 | 3874 | { |
3665 | 3875 | // Try to keep only what's useful. |
3666 | 3876 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
3667 | - foreach ($context['css_files'] as $file) |
|
3668 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3877 | + foreach ($context['css_files'] as $file) { |
|
3878 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3879 | + } |
|
3669 | 3880 | } |
3670 | 3881 | |
3671 | 3882 | if (!empty($context['css_header'])) |
@@ -3673,9 +3884,10 @@ discard block |
||
3673 | 3884 | echo ' |
3674 | 3885 | <style>'; |
3675 | 3886 | |
3676 | - foreach ($context['css_header'] as $css) |
|
3677 | - echo $css .' |
|
3887 | + foreach ($context['css_header'] as $css) { |
|
3888 | + echo $css .' |
|
3678 | 3889 | '; |
3890 | + } |
|
3679 | 3891 | |
3680 | 3892 | echo' |
3681 | 3893 | </style>'; |
@@ -3699,15 +3911,17 @@ discard block |
||
3699 | 3911 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
3700 | 3912 | $data = !empty($data) ? $data : false; |
3701 | 3913 | |
3702 | - if (empty($type) || empty($data)) |
|
3703 | - return false; |
|
3914 | + if (empty($type) || empty($data)) { |
|
3915 | + return false; |
|
3916 | + } |
|
3704 | 3917 | |
3705 | 3918 | // Did we already did this? |
3706 | 3919 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
3707 | 3920 | |
3708 | 3921 | // Already done? |
3709 | - if (!empty($toCache)) |
|
3710 | - return true; |
|
3922 | + if (!empty($toCache)) { |
|
3923 | + return true; |
|
3924 | + } |
|
3711 | 3925 | |
3712 | 3926 | // No namespaces, sorry! |
3713 | 3927 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3789,8 +4003,9 @@ discard block |
||
3789 | 4003 | global $modSettings, $smcFunc; |
3790 | 4004 | |
3791 | 4005 | // Just make up a nice hash... |
3792 | - if ($new) |
|
3793 | - return sha1(md5($filename . time()) . mt_rand()); |
|
4006 | + if ($new) { |
|
4007 | + return sha1(md5($filename . time()) . mt_rand()); |
|
4008 | + } |
|
3794 | 4009 | |
3795 | 4010 | // Just make sure that attachment id is only a int |
3796 | 4011 | $attachment_id = (int) $attachment_id; |
@@ -3807,23 +4022,25 @@ discard block |
||
3807 | 4022 | 'id_attach' => $attachment_id, |
3808 | 4023 | )); |
3809 | 4024 | |
3810 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
3811 | - return false; |
|
4025 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
4026 | + return false; |
|
4027 | + } |
|
3812 | 4028 | |
3813 | 4029 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
3814 | 4030 | $smcFunc['db_free_result']($request); |
3815 | 4031 | } |
3816 | 4032 | |
3817 | 4033 | // Still no hash? mmm... |
3818 | - if (empty($file_hash)) |
|
3819 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4034 | + if (empty($file_hash)) { |
|
4035 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4036 | + } |
|
3820 | 4037 | |
3821 | 4038 | // Are we using multiple directories? |
3822 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
3823 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
3824 | - |
|
3825 | - else |
|
3826 | - $path = $modSettings['attachmentUploadDir']; |
|
4039 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
4040 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
4041 | + } else { |
|
4042 | + $path = $modSettings['attachmentUploadDir']; |
|
4043 | + } |
|
3827 | 4044 | |
3828 | 4045 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
3829 | 4046 | } |
@@ -3838,8 +4055,9 @@ discard block |
||
3838 | 4055 | function ip2range($fullip) |
3839 | 4056 | { |
3840 | 4057 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
3841 | - if ($fullip == 'unknown') |
|
3842 | - $fullip = '255.255.255.255'; |
|
4058 | + if ($fullip == 'unknown') { |
|
4059 | + $fullip = '255.255.255.255'; |
|
4060 | + } |
|
3843 | 4061 | |
3844 | 4062 | $ip_parts = explode('-', $fullip); |
3845 | 4063 | $ip_array = array(); |
@@ -3863,10 +4081,11 @@ discard block |
||
3863 | 4081 | $ip_array['low'] = $ip_parts[0]; |
3864 | 4082 | $ip_array['high'] = $ip_parts[1]; |
3865 | 4083 | return $ip_array; |
3866 | - } |
|
3867 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
4084 | + } elseif (count($ip_parts) == 2) { |
|
4085 | + // if ip 22.22.*-22.22.* |
|
3868 | 4086 | { |
3869 | 4087 | $valid_low = isValidIP($ip_parts[0]); |
4088 | + } |
|
3870 | 4089 | $valid_high = isValidIP($ip_parts[1]); |
3871 | 4090 | $count = 0; |
3872 | 4091 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3881,7 +4100,9 @@ discard block |
||
3881 | 4100 | $ip_parts[0] .= $mode . $min; |
3882 | 4101 | $valid_low = isValidIP($ip_parts[0]); |
3883 | 4102 | $count++; |
3884 | - if ($count > 9) break; |
|
4103 | + if ($count > 9) { |
|
4104 | + break; |
|
4105 | + } |
|
3885 | 4106 | } |
3886 | 4107 | } |
3887 | 4108 | |
@@ -3895,7 +4116,9 @@ discard block |
||
3895 | 4116 | $ip_parts[1] .= $mode . $max; |
3896 | 4117 | $valid_high = isValidIP($ip_parts[1]); |
3897 | 4118 | $count++; |
3898 | - if ($count > 9) break; |
|
4119 | + if ($count > 9) { |
|
4120 | + break; |
|
4121 | + } |
|
3899 | 4122 | } |
3900 | 4123 | } |
3901 | 4124 | |
@@ -3920,46 +4143,54 @@ discard block |
||
3920 | 4143 | { |
3921 | 4144 | global $modSettings; |
3922 | 4145 | |
3923 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
3924 | - return $host; |
|
4146 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
4147 | + return $host; |
|
4148 | + } |
|
3925 | 4149 | $t = microtime(); |
3926 | 4150 | |
3927 | 4151 | // Try the Linux host command, perhaps? |
3928 | 4152 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
3929 | 4153 | { |
3930 | - if (!isset($modSettings['host_to_dis'])) |
|
3931 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
3932 | - else |
|
3933 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4154 | + if (!isset($modSettings['host_to_dis'])) { |
|
4155 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
4156 | + } else { |
|
4157 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4158 | + } |
|
3934 | 4159 | |
3935 | 4160 | // Did host say it didn't find anything? |
3936 | - if (strpos($test, 'not found') !== false) |
|
3937 | - $host = ''; |
|
4161 | + if (strpos($test, 'not found') !== false) { |
|
4162 | + $host = ''; |
|
4163 | + } |
|
3938 | 4164 | // Invalid server option? |
3939 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
3940 | - updateSettings(array('host_to_dis' => 1)); |
|
4165 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
4166 | + updateSettings(array('host_to_dis' => 1)); |
|
4167 | + } |
|
3941 | 4168 | // Maybe it found something, after all? |
3942 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
3943 | - $host = $match[1]; |
|
4169 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
4170 | + $host = $match[1]; |
|
4171 | + } |
|
3944 | 4172 | } |
3945 | 4173 | |
3946 | 4174 | // This is nslookup; usually only Windows, but possibly some Unix? |
3947 | 4175 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
3948 | 4176 | { |
3949 | 4177 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
3950 | - if (strpos($test, 'Non-existent domain') !== false) |
|
3951 | - $host = ''; |
|
3952 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
3953 | - $host = $match[1]; |
|
4178 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
4179 | + $host = ''; |
|
4180 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
4181 | + $host = $match[1]; |
|
4182 | + } |
|
3954 | 4183 | } |
3955 | 4184 | |
3956 | 4185 | // This is the last try :/. |
3957 | - if (!isset($host) || $host === false) |
|
3958 | - $host = @gethostbyaddr($ip); |
|
4186 | + if (!isset($host) || $host === false) { |
|
4187 | + $host = @gethostbyaddr($ip); |
|
4188 | + } |
|
3959 | 4189 | |
3960 | 4190 | // It took a long time, so let's cache it! |
3961 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
3962 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4191 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
4192 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4193 | + } |
|
3963 | 4194 | |
3964 | 4195 | return $host; |
3965 | 4196 | } |
@@ -3995,20 +4226,21 @@ discard block |
||
3995 | 4226 | { |
3996 | 4227 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
3997 | 4228 | $total = 0; |
3998 | - for ($i = 0; $i < $max_chars; $i++) |
|
3999 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4229 | + for ($i = 0; $i < $max_chars; $i++) { |
|
4230 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4231 | + } |
|
4000 | 4232 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
4001 | 4233 | } |
4002 | 4234 | } |
4003 | 4235 | return array_unique($returned_ints); |
4004 | - } |
|
4005 | - else |
|
4236 | + } else |
|
4006 | 4237 | { |
4007 | 4238 | // Trim characters before and after and add slashes for database insertion. |
4008 | 4239 | $returned_words = array(); |
4009 | - foreach ($words as $word) |
|
4010 | - if (($word = trim($word, '-_\'')) !== '') |
|
4240 | + foreach ($words as $word) { |
|
4241 | + if (($word = trim($word, '-_\'')) !== '') |
|
4011 | 4242 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
4243 | + } |
|
4012 | 4244 | |
4013 | 4245 | // Filter out all words that occur more than once. |
4014 | 4246 | return array_unique($returned_words); |
@@ -4030,16 +4262,18 @@ discard block |
||
4030 | 4262 | global $settings, $txt; |
4031 | 4263 | |
4032 | 4264 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
4033 | - if (function_exists('template_create_button') && !$force_use) |
|
4034 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4265 | + if (function_exists('template_create_button') && !$force_use) { |
|
4266 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4267 | + } |
|
4035 | 4268 | |
4036 | - if (!$settings['use_image_buttons']) |
|
4037 | - return $txt[$alt]; |
|
4038 | - elseif (!empty($settings['use_buttons'])) |
|
4039 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4040 | - else |
|
4041 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4042 | -} |
|
4269 | + if (!$settings['use_image_buttons']) { |
|
4270 | + return $txt[$alt]; |
|
4271 | + } elseif (!empty($settings['use_buttons'])) { |
|
4272 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4273 | + } else { |
|
4274 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4275 | + } |
|
4276 | + } |
|
4043 | 4277 | |
4044 | 4278 | /** |
4045 | 4279 | * Sets up all of the top menu buttons |
@@ -4082,9 +4316,10 @@ discard block |
||
4082 | 4316 | var user_menus = new smc_PopupMenu(); |
4083 | 4317 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4084 | 4318 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
4085 | - if ($context['allow_pm']) |
|
4086 | - addInlineJavaScript(' |
|
4319 | + if ($context['allow_pm']) { |
|
4320 | + addInlineJavaScript(' |
|
4087 | 4321 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
4322 | + } |
|
4088 | 4323 | |
4089 | 4324 | if (!empty($modSettings['enable_ajax_alerts'])) |
4090 | 4325 | { |
@@ -4244,88 +4479,96 @@ discard block |
||
4244 | 4479 | |
4245 | 4480 | // Now we put the buttons in the context so the theme can use them. |
4246 | 4481 | $menu_buttons = array(); |
4247 | - foreach ($buttons as $act => $button) |
|
4248 | - if (!empty($button['show'])) |
|
4482 | + foreach ($buttons as $act => $button) { |
|
4483 | + if (!empty($button['show'])) |
|
4249 | 4484 | { |
4250 | 4485 | $button['active_button'] = false; |
4486 | + } |
|
4251 | 4487 | |
4252 | 4488 | // This button needs some action. |
4253 | - if (isset($button['action_hook'])) |
|
4254 | - $needs_action_hook = true; |
|
4489 | + if (isset($button['action_hook'])) { |
|
4490 | + $needs_action_hook = true; |
|
4491 | + } |
|
4255 | 4492 | |
4256 | 4493 | // Make sure the last button truly is the last button. |
4257 | 4494 | if (!empty($button['is_last'])) |
4258 | 4495 | { |
4259 | - if (isset($last_button)) |
|
4260 | - unset($menu_buttons[$last_button]['is_last']); |
|
4496 | + if (isset($last_button)) { |
|
4497 | + unset($menu_buttons[$last_button]['is_last']); |
|
4498 | + } |
|
4261 | 4499 | $last_button = $act; |
4262 | 4500 | } |
4263 | 4501 | |
4264 | 4502 | // Go through the sub buttons if there are any. |
4265 | - if (!empty($button['sub_buttons'])) |
|
4266 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4503 | + if (!empty($button['sub_buttons'])) { |
|
4504 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4267 | 4505 | { |
4268 | 4506 | if (empty($subbutton['show'])) |
4269 | 4507 | unset($button['sub_buttons'][$key]); |
4508 | + } |
|
4270 | 4509 | |
4271 | 4510 | // 2nd level sub buttons next... |
4272 | 4511 | if (!empty($subbutton['sub_buttons'])) |
4273 | 4512 | { |
4274 | 4513 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
4275 | 4514 | { |
4276 | - if (empty($sub_button2['show'])) |
|
4277 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4515 | + if (empty($sub_button2['show'])) { |
|
4516 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4517 | + } |
|
4278 | 4518 | } |
4279 | 4519 | } |
4280 | 4520 | } |
4281 | 4521 | |
4282 | 4522 | // Does this button have its own icon? |
4283 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
4284 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4285 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
4286 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4287 | - elseif (isset($button['icon'])) |
|
4288 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4289 | - else |
|
4290 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4523 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
4524 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4525 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
4526 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4527 | + } elseif (isset($button['icon'])) { |
|
4528 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4529 | + } else { |
|
4530 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4531 | + } |
|
4291 | 4532 | |
4292 | 4533 | $menu_buttons[$act] = $button; |
4293 | 4534 | } |
4294 | 4535 | |
4295 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
4296 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4536 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
4537 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4538 | + } |
|
4297 | 4539 | } |
4298 | 4540 | |
4299 | 4541 | $context['menu_buttons'] = $menu_buttons; |
4300 | 4542 | |
4301 | 4543 | // Logging out requires the session id in the url. |
4302 | - if (isset($context['menu_buttons']['logout'])) |
|
4303 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4544 | + if (isset($context['menu_buttons']['logout'])) { |
|
4545 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4546 | + } |
|
4304 | 4547 | |
4305 | 4548 | // Figure out which action we are doing so we can set the active tab. |
4306 | 4549 | // Default to home. |
4307 | 4550 | $current_action = 'home'; |
4308 | 4551 | |
4309 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
4310 | - $current_action = $context['current_action']; |
|
4311 | - elseif ($context['current_action'] == 'search2') |
|
4312 | - $current_action = 'search'; |
|
4313 | - elseif ($context['current_action'] == 'theme') |
|
4314 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4315 | - elseif ($context['current_action'] == 'register2') |
|
4316 | - $current_action = 'register'; |
|
4317 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
4318 | - $current_action = 'login'; |
|
4319 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
4320 | - $current_action = 'moderate'; |
|
4552 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
4553 | + $current_action = $context['current_action']; |
|
4554 | + } elseif ($context['current_action'] == 'search2') { |
|
4555 | + $current_action = 'search'; |
|
4556 | + } elseif ($context['current_action'] == 'theme') { |
|
4557 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4558 | + } elseif ($context['current_action'] == 'register2') { |
|
4559 | + $current_action = 'register'; |
|
4560 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
4561 | + $current_action = 'login'; |
|
4562 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
4563 | + $current_action = 'moderate'; |
|
4564 | + } |
|
4321 | 4565 | |
4322 | 4566 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
4323 | 4567 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
4324 | 4568 | { |
4325 | 4569 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
4326 | 4570 | $context[$current_action] = true; |
4327 | - } |
|
4328 | - elseif ($context['current_action'] == 'pm') |
|
4571 | + } elseif ($context['current_action'] == 'pm') |
|
4329 | 4572 | { |
4330 | 4573 | $current_action = 'self_pm'; |
4331 | 4574 | $context['self_pm'] = true; |
@@ -4366,12 +4609,14 @@ discard block |
||
4366 | 4609 | } |
4367 | 4610 | |
4368 | 4611 | // Not all actions are simple. |
4369 | - if (!empty($needs_action_hook)) |
|
4370 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4612 | + if (!empty($needs_action_hook)) { |
|
4613 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4614 | + } |
|
4371 | 4615 | |
4372 | - if (isset($context['menu_buttons'][$current_action])) |
|
4373 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4374 | -} |
|
4616 | + if (isset($context['menu_buttons'][$current_action])) { |
|
4617 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4618 | + } |
|
4619 | + } |
|
4375 | 4620 | |
4376 | 4621 | /** |
4377 | 4622 | * Generate a random seed and ensure it's stored in settings. |
@@ -4395,30 +4640,35 @@ discard block |
||
4395 | 4640 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
4396 | 4641 | global $context, $txt; |
4397 | 4642 | |
4398 | - if ($db_show_debug === true) |
|
4399 | - $context['debug']['hooks'][] = $hook; |
|
4643 | + if ($db_show_debug === true) { |
|
4644 | + $context['debug']['hooks'][] = $hook; |
|
4645 | + } |
|
4400 | 4646 | |
4401 | 4647 | // Need to have some control. |
4402 | - if (!isset($context['instances'])) |
|
4403 | - $context['instances'] = array(); |
|
4648 | + if (!isset($context['instances'])) { |
|
4649 | + $context['instances'] = array(); |
|
4650 | + } |
|
4404 | 4651 | |
4405 | 4652 | $results = array(); |
4406 | - if (empty($modSettings[$hook])) |
|
4407 | - return $results; |
|
4653 | + if (empty($modSettings[$hook])) { |
|
4654 | + return $results; |
|
4655 | + } |
|
4408 | 4656 | |
4409 | 4657 | $functions = explode(',', $modSettings[$hook]); |
4410 | 4658 | // Loop through each function. |
4411 | 4659 | foreach ($functions as $function) |
4412 | 4660 | { |
4413 | 4661 | // Hook has been marked as "disabled". Skip it! |
4414 | - if (strpos($function, '!') !== false) |
|
4415 | - continue; |
|
4662 | + if (strpos($function, '!') !== false) { |
|
4663 | + continue; |
|
4664 | + } |
|
4416 | 4665 | |
4417 | 4666 | $call = call_helper($function, true); |
4418 | 4667 | |
4419 | 4668 | // Is it valid? |
4420 | - if (!empty($call)) |
|
4421 | - $results[$function] = call_user_func_array($call, $parameters); |
|
4669 | + if (!empty($call)) { |
|
4670 | + $results[$function] = call_user_func_array($call, $parameters); |
|
4671 | + } |
|
4422 | 4672 | |
4423 | 4673 | // Whatever it was suppose to call, it failed :( |
4424 | 4674 | elseif (!empty($function)) |
@@ -4434,8 +4684,9 @@ discard block |
||
4434 | 4684 | } |
4435 | 4685 | |
4436 | 4686 | // "Assume" the file resides on $boarddir somewhere... |
4437 | - else |
|
4438 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4687 | + else { |
|
4688 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4689 | + } |
|
4439 | 4690 | } |
4440 | 4691 | } |
4441 | 4692 | |
@@ -4457,12 +4708,14 @@ discard block |
||
4457 | 4708 | global $smcFunc, $modSettings; |
4458 | 4709 | |
4459 | 4710 | // Any objects? |
4460 | - if ($object) |
|
4461 | - $function = $function . '#'; |
|
4711 | + if ($object) { |
|
4712 | + $function = $function . '#'; |
|
4713 | + } |
|
4462 | 4714 | |
4463 | 4715 | // Any files to load? |
4464 | - if (!empty($file) && is_string($file)) |
|
4465 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4716 | + if (!empty($file) && is_string($file)) { |
|
4717 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4718 | + } |
|
4466 | 4719 | |
4467 | 4720 | // Get the correct string. |
4468 | 4721 | $integration_call = $function; |
@@ -4484,13 +4737,14 @@ discard block |
||
4484 | 4737 | if (!empty($current_functions)) |
4485 | 4738 | { |
4486 | 4739 | $current_functions = explode(',', $current_functions); |
4487 | - if (in_array($integration_call, $current_functions)) |
|
4488 | - return; |
|
4740 | + if (in_array($integration_call, $current_functions)) { |
|
4741 | + return; |
|
4742 | + } |
|
4489 | 4743 | |
4490 | 4744 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
4745 | + } else { |
|
4746 | + $permanent_functions = array($integration_call); |
|
4491 | 4747 | } |
4492 | - else |
|
4493 | - $permanent_functions = array($integration_call); |
|
4494 | 4748 | |
4495 | 4749 | updateSettings(array($hook => implode(',', $permanent_functions))); |
4496 | 4750 | } |
@@ -4499,8 +4753,9 @@ discard block |
||
4499 | 4753 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4500 | 4754 | |
4501 | 4755 | // Do nothing, if it's already there. |
4502 | - if (in_array($integration_call, $functions)) |
|
4503 | - return; |
|
4756 | + if (in_array($integration_call, $functions)) { |
|
4757 | + return; |
|
4758 | + } |
|
4504 | 4759 | |
4505 | 4760 | $functions[] = $integration_call; |
4506 | 4761 | $modSettings[$hook] = implode(',', $functions); |
@@ -4523,12 +4778,14 @@ discard block |
||
4523 | 4778 | global $smcFunc, $modSettings; |
4524 | 4779 | |
4525 | 4780 | // Any objects? |
4526 | - if ($object) |
|
4527 | - $function = $function . '#'; |
|
4781 | + if ($object) { |
|
4782 | + $function = $function . '#'; |
|
4783 | + } |
|
4528 | 4784 | |
4529 | 4785 | // Any files to load? |
4530 | - if (!empty($file) && is_string($file)) |
|
4531 | - $function = $file . '|' . $function; |
|
4786 | + if (!empty($file) && is_string($file)) { |
|
4787 | + $function = $file . '|' . $function; |
|
4788 | + } |
|
4532 | 4789 | |
4533 | 4790 | // Get the correct string. |
4534 | 4791 | $integration_call = $function; |
@@ -4549,16 +4806,18 @@ discard block |
||
4549 | 4806 | { |
4550 | 4807 | $current_functions = explode(',', $current_functions); |
4551 | 4808 | |
4552 | - if (in_array($integration_call, $current_functions)) |
|
4553 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4809 | + if (in_array($integration_call, $current_functions)) { |
|
4810 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4811 | + } |
|
4554 | 4812 | } |
4555 | 4813 | |
4556 | 4814 | // Turn the function list into something usable. |
4557 | 4815 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4558 | 4816 | |
4559 | 4817 | // You can only remove it if it's available. |
4560 | - if (!in_array($integration_call, $functions)) |
|
4561 | - return; |
|
4818 | + if (!in_array($integration_call, $functions)) { |
|
4819 | + return; |
|
4820 | + } |
|
4562 | 4821 | |
4563 | 4822 | $functions = array_diff($functions, array($integration_call)); |
4564 | 4823 | $modSettings[$hook] = implode(',', $functions); |
@@ -4579,17 +4838,20 @@ discard block |
||
4579 | 4838 | global $context, $smcFunc, $txt, $db_show_debug; |
4580 | 4839 | |
4581 | 4840 | // Really? |
4582 | - if (empty($string)) |
|
4583 | - return false; |
|
4841 | + if (empty($string)) { |
|
4842 | + return false; |
|
4843 | + } |
|
4584 | 4844 | |
4585 | 4845 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
4586 | 4846 | // A closure? should be a callable one. |
4587 | - if (is_array($string) || $string instanceof Closure) |
|
4588 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4847 | + if (is_array($string) || $string instanceof Closure) { |
|
4848 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4849 | + } |
|
4589 | 4850 | |
4590 | 4851 | // No full objects, sorry! pass a method or a property instead! |
4591 | - if (is_object($string)) |
|
4592 | - return false; |
|
4852 | + if (is_object($string)) { |
|
4853 | + return false; |
|
4854 | + } |
|
4593 | 4855 | |
4594 | 4856 | // Stay vitaminized my friends... |
4595 | 4857 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4598,8 +4860,9 @@ discard block |
||
4598 | 4860 | $string = load_file($string); |
4599 | 4861 | |
4600 | 4862 | // Loaded file failed |
4601 | - if (empty($string)) |
|
4602 | - return false; |
|
4863 | + if (empty($string)) { |
|
4864 | + return false; |
|
4865 | + } |
|
4603 | 4866 | |
4604 | 4867 | // Found a method. |
4605 | 4868 | if (strpos($string, '::') !== false) |
@@ -4620,8 +4883,9 @@ discard block |
||
4620 | 4883 | // Add another one to the list. |
4621 | 4884 | if ($db_show_debug === true) |
4622 | 4885 | { |
4623 | - if (!isset($context['debug']['instances'])) |
|
4624 | - $context['debug']['instances'] = array(); |
|
4886 | + if (!isset($context['debug']['instances'])) { |
|
4887 | + $context['debug']['instances'] = array(); |
|
4888 | + } |
|
4625 | 4889 | |
4626 | 4890 | $context['debug']['instances'][$class] = $class; |
4627 | 4891 | } |
@@ -4631,13 +4895,15 @@ discard block |
||
4631 | 4895 | } |
4632 | 4896 | |
4633 | 4897 | // Right then. This is a call to a static method. |
4634 | - else |
|
4635 | - $func = array($class, $method); |
|
4898 | + else { |
|
4899 | + $func = array($class, $method); |
|
4900 | + } |
|
4636 | 4901 | } |
4637 | 4902 | |
4638 | 4903 | // Nope! just a plain regular function. |
4639 | - else |
|
4640 | - $func = $string; |
|
4904 | + else { |
|
4905 | + $func = $string; |
|
4906 | + } |
|
4641 | 4907 | |
4642 | 4908 | // Right, we got what we need, time to do some checks. |
4643 | 4909 | if (!is_callable($func, false, $callable_name)) |
@@ -4653,17 +4919,18 @@ discard block |
||
4653 | 4919 | else |
4654 | 4920 | { |
4655 | 4921 | // What are we gonna do about it? |
4656 | - if ($return) |
|
4657 | - return $func; |
|
4922 | + if ($return) { |
|
4923 | + return $func; |
|
4924 | + } |
|
4658 | 4925 | |
4659 | 4926 | // If this is a plain function, avoid the heat of calling call_user_func(). |
4660 | 4927 | else |
4661 | 4928 | { |
4662 | - if (is_array($func)) |
|
4663 | - call_user_func($func); |
|
4664 | - |
|
4665 | - else |
|
4666 | - $func(); |
|
4929 | + if (is_array($func)) { |
|
4930 | + call_user_func($func); |
|
4931 | + } else { |
|
4932 | + $func(); |
|
4933 | + } |
|
4667 | 4934 | } |
4668 | 4935 | } |
4669 | 4936 | } |
@@ -4680,31 +4947,34 @@ discard block |
||
4680 | 4947 | { |
4681 | 4948 | global $sourcedir, $txt, $boarddir, $settings; |
4682 | 4949 | |
4683 | - if (empty($string)) |
|
4684 | - return false; |
|
4950 | + if (empty($string)) { |
|
4951 | + return false; |
|
4952 | + } |
|
4685 | 4953 | |
4686 | 4954 | if (strpos($string, '|') !== false) |
4687 | 4955 | { |
4688 | 4956 | list ($file, $string) = explode('|', $string); |
4689 | 4957 | |
4690 | 4958 | // Match the wildcards to their regular vars. |
4691 | - if (empty($settings['theme_dir'])) |
|
4692 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4693 | - |
|
4694 | - else |
|
4695 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4959 | + if (empty($settings['theme_dir'])) { |
|
4960 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4961 | + } else { |
|
4962 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4963 | + } |
|
4696 | 4964 | |
4697 | 4965 | // Load the file if it can be loaded. |
4698 | - if (file_exists($absPath)) |
|
4699 | - require_once($absPath); |
|
4966 | + if (file_exists($absPath)) { |
|
4967 | + require_once($absPath); |
|
4968 | + } |
|
4700 | 4969 | |
4701 | 4970 | // No? try a fallback to $sourcedir |
4702 | 4971 | else |
4703 | 4972 | { |
4704 | 4973 | $absPath = $sourcedir .'/'. $file; |
4705 | 4974 | |
4706 | - if (file_exists($absPath)) |
|
4707 | - require_once($absPath); |
|
4975 | + if (file_exists($absPath)) { |
|
4976 | + require_once($absPath); |
|
4977 | + } |
|
4708 | 4978 | |
4709 | 4979 | // Sorry, can't do much for you at this point. |
4710 | 4980 | else |
@@ -4731,8 +5001,9 @@ discard block |
||
4731 | 5001 | global $user_info, $smcFunc; |
4732 | 5002 | |
4733 | 5003 | // Make sure we have something to work with. |
4734 | - if (empty($topic)) |
|
4735 | - return array(); |
|
5004 | + if (empty($topic)) { |
|
5005 | + return array(); |
|
5006 | + } |
|
4736 | 5007 | |
4737 | 5008 | |
4738 | 5009 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4755,8 +5026,9 @@ discard block |
||
4755 | 5026 | 'topic' => $topic, |
4756 | 5027 | ) |
4757 | 5028 | ); |
4758 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
4759 | - $temp[] = (int) $row['content_id']; |
|
5029 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
5030 | + $temp[] = (int) $row['content_id']; |
|
5031 | + } |
|
4760 | 5032 | |
4761 | 5033 | cache_put_data($cache_key, $temp, $ttl); |
4762 | 5034 | } |
@@ -4777,8 +5049,9 @@ discard block |
||
4777 | 5049 | { |
4778 | 5050 | global $context; |
4779 | 5051 | |
4780 | - if (empty($string)) |
|
4781 | - return $string; |
|
5052 | + if (empty($string)) { |
|
5053 | + return $string; |
|
5054 | + } |
|
4782 | 5055 | |
4783 | 5056 | // UTF-8 occurences of MS special characters |
4784 | 5057 | $findchars_utf8 = array( |
@@ -4819,10 +5092,11 @@ discard block |
||
4819 | 5092 | '--', // — |
4820 | 5093 | ); |
4821 | 5094 | |
4822 | - if ($context['utf8']) |
|
4823 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
4824 | - else |
|
4825 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
5095 | + if ($context['utf8']) { |
|
5096 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
5097 | + } else { |
|
5098 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
5099 | + } |
|
4826 | 5100 | |
4827 | 5101 | return $string; |
4828 | 5102 | } |
@@ -4841,49 +5115,59 @@ discard block |
||
4841 | 5115 | { |
4842 | 5116 | global $context; |
4843 | 5117 | |
4844 | - if (!isset($matches[2])) |
|
4845 | - return ''; |
|
5118 | + if (!isset($matches[2])) { |
|
5119 | + return ''; |
|
5120 | + } |
|
4846 | 5121 | |
4847 | 5122 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4848 | 5123 | |
4849 | 5124 | // remove left to right / right to left overrides |
4850 | - if ($num === 0x202D || $num === 0x202E) |
|
4851 | - return ''; |
|
5125 | + if ($num === 0x202D || $num === 0x202E) { |
|
5126 | + return ''; |
|
5127 | + } |
|
4852 | 5128 | |
4853 | 5129 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
4854 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
4855 | - return '&#' . $num . ';'; |
|
5130 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
5131 | + return '&#' . $num . ';'; |
|
5132 | + } |
|
4856 | 5133 | |
4857 | 5134 | if (empty($context['utf8'])) |
4858 | 5135 | { |
4859 | 5136 | // no control characters |
4860 | - if ($num < 0x20) |
|
4861 | - return ''; |
|
5137 | + if ($num < 0x20) { |
|
5138 | + return ''; |
|
5139 | + } |
|
4862 | 5140 | // text is text |
4863 | - elseif ($num < 0x80) |
|
4864 | - return chr($num); |
|
5141 | + elseif ($num < 0x80) { |
|
5142 | + return chr($num); |
|
5143 | + } |
|
4865 | 5144 | // all others get html-ised |
4866 | - else |
|
4867 | - return '&#' . $matches[2] . ';'; |
|
4868 | - } |
|
4869 | - else |
|
5145 | + else { |
|
5146 | + return '&#' . $matches[2] . ';'; |
|
5147 | + } |
|
5148 | + } else |
|
4870 | 5149 | { |
4871 | 5150 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
4872 | 5151 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
4873 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
4874 | - return ''; |
|
5152 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
5153 | + return ''; |
|
5154 | + } |
|
4875 | 5155 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4876 | - elseif ($num < 0x80) |
|
4877 | - return chr($num); |
|
5156 | + elseif ($num < 0x80) { |
|
5157 | + return chr($num); |
|
5158 | + } |
|
4878 | 5159 | // <0x800 (2048) |
4879 | - elseif ($num < 0x800) |
|
4880 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5160 | + elseif ($num < 0x800) { |
|
5161 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5162 | + } |
|
4881 | 5163 | // < 0x10000 (65536) |
4882 | - elseif ($num < 0x10000) |
|
4883 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5164 | + elseif ($num < 0x10000) { |
|
5165 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5166 | + } |
|
4884 | 5167 | // <= 0x10FFFF (1114111) |
4885 | - else |
|
4886 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5168 | + else { |
|
5169 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5170 | + } |
|
4887 | 5171 | } |
4888 | 5172 | } |
4889 | 5173 | |
@@ -4899,28 +5183,34 @@ discard block |
||
4899 | 5183 | */ |
4900 | 5184 | function fixchar__callback($matches) |
4901 | 5185 | { |
4902 | - if (!isset($matches[1])) |
|
4903 | - return ''; |
|
5186 | + if (!isset($matches[1])) { |
|
5187 | + return ''; |
|
5188 | + } |
|
4904 | 5189 | |
4905 | 5190 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
4906 | 5191 | |
4907 | 5192 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
4908 | 5193 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
4909 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
4910 | - return ''; |
|
5194 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
5195 | + return ''; |
|
5196 | + } |
|
4911 | 5197 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4912 | - elseif ($num < 0x80) |
|
4913 | - return chr($num); |
|
5198 | + elseif ($num < 0x80) { |
|
5199 | + return chr($num); |
|
5200 | + } |
|
4914 | 5201 | // <0x800 (2048) |
4915 | - elseif ($num < 0x800) |
|
4916 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5202 | + elseif ($num < 0x800) { |
|
5203 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5204 | + } |
|
4917 | 5205 | // < 0x10000 (65536) |
4918 | - elseif ($num < 0x10000) |
|
4919 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5206 | + elseif ($num < 0x10000) { |
|
5207 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5208 | + } |
|
4920 | 5209 | // <= 0x10FFFF (1114111) |
4921 | - else |
|
4922 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
4923 | -} |
|
5210 | + else { |
|
5211 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5212 | + } |
|
5213 | + } |
|
4924 | 5214 | |
4925 | 5215 | /** |
4926 | 5216 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4933,17 +5223,19 @@ discard block |
||
4933 | 5223 | */ |
4934 | 5224 | function entity_fix__callback($matches) |
4935 | 5225 | { |
4936 | - if (!isset($matches[2])) |
|
4937 | - return ''; |
|
5226 | + if (!isset($matches[2])) { |
|
5227 | + return ''; |
|
5228 | + } |
|
4938 | 5229 | |
4939 | 5230 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4940 | 5231 | |
4941 | 5232 | // we don't allow control characters, characters out of range, byte markers, etc |
4942 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
4943 | - return ''; |
|
4944 | - else |
|
4945 | - return '&#' . $num . ';'; |
|
4946 | -} |
|
5233 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
5234 | + return ''; |
|
5235 | + } else { |
|
5236 | + return '&#' . $num . ';'; |
|
5237 | + } |
|
5238 | + } |
|
4947 | 5239 | |
4948 | 5240 | /** |
4949 | 5241 | * Return a Gravatar URL based on |
@@ -4967,18 +5259,23 @@ discard block |
||
4967 | 5259 | $ratings = array('G', 'PG', 'R', 'X'); |
4968 | 5260 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
4969 | 5261 | $url_params = array(); |
4970 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
4971 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
4972 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
4973 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
4974 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
4975 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
4976 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
4977 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
5262 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
5263 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
5264 | + } |
|
5265 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
5266 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
5267 | + } |
|
5268 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
5269 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
5270 | + } |
|
5271 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
5272 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
4978 | 5273 | $size_string = $modSettings['avatar_max_height_external']; |
5274 | + } |
|
4979 | 5275 | |
4980 | - if (!empty($size_string)) |
|
4981 | - $url_params[] = 's=' . $size_string; |
|
5276 | + if (!empty($size_string)) { |
|
5277 | + $url_params[] = 's=' . $size_string; |
|
5278 | + } |
|
4982 | 5279 | } |
4983 | 5280 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
4984 | 5281 | |
@@ -4997,22 +5294,26 @@ discard block |
||
4997 | 5294 | static $timezones = null, $lastwhen = null; |
4998 | 5295 | |
4999 | 5296 | // No point doing this over if we already did it once |
5000 | - if (!empty($timezones) && $when == $lastwhen) |
|
5001 | - return $timezones; |
|
5002 | - else |
|
5003 | - $lastwhen = $when; |
|
5297 | + if (!empty($timezones) && $when == $lastwhen) { |
|
5298 | + return $timezones; |
|
5299 | + } else { |
|
5300 | + $lastwhen = $when; |
|
5301 | + } |
|
5004 | 5302 | |
5005 | 5303 | // Parseable datetime string? |
5006 | - if (is_int($timestamp = strtotime($when))) |
|
5007 | - $when = $timestamp; |
|
5304 | + if (is_int($timestamp = strtotime($when))) { |
|
5305 | + $when = $timestamp; |
|
5306 | + } |
|
5008 | 5307 | |
5009 | 5308 | // A Unix timestamp? |
5010 | - elseif (is_numeric($when)) |
|
5011 | - $when = intval($when); |
|
5309 | + elseif (is_numeric($when)) { |
|
5310 | + $when = intval($when); |
|
5311 | + } |
|
5012 | 5312 | |
5013 | 5313 | // Invalid value? Just get current Unix timestamp. |
5014 | - else |
|
5015 | - $when = time(); |
|
5314 | + else { |
|
5315 | + $when = time(); |
|
5316 | + } |
|
5016 | 5317 | |
5017 | 5318 | // We'll need these too |
5018 | 5319 | $date_when = date_create('@' . $when); |
@@ -5076,8 +5377,9 @@ discard block |
||
5076 | 5377 | foreach ($priority_countries as $country) |
5077 | 5378 | { |
5078 | 5379 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
5079 | - if (!empty($country_tzids)) |
|
5080 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5380 | + if (!empty($country_tzids)) { |
|
5381 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5382 | + } |
|
5081 | 5383 | } |
5082 | 5384 | |
5083 | 5385 | // Process the preferred timezones first, then the rest. |
@@ -5087,8 +5389,9 @@ discard block |
||
5087 | 5389 | foreach ($tzids as $tzid) |
5088 | 5390 | { |
5089 | 5391 | // We don't want UTC right now |
5090 | - if ($tzid == 'UTC') |
|
5091 | - continue; |
|
5392 | + if ($tzid == 'UTC') { |
|
5393 | + continue; |
|
5394 | + } |
|
5092 | 5395 | |
5093 | 5396 | $tz = timezone_open($tzid); |
5094 | 5397 | |
@@ -5109,8 +5412,9 @@ discard block |
||
5109 | 5412 | } |
5110 | 5413 | |
5111 | 5414 | // A time zone from a prioritized country? |
5112 | - if (in_array($tzid, $priority_tzids)) |
|
5113 | - $priority_zones[$tzkey] = true; |
|
5415 | + if (in_array($tzid, $priority_tzids)) { |
|
5416 | + $priority_zones[$tzkey] = true; |
|
5417 | + } |
|
5114 | 5418 | |
5115 | 5419 | // Keep track of the location and offset for this tzid |
5116 | 5420 | $tzid_parts = explode('/', $tzid); |
@@ -5129,15 +5433,17 @@ discard block |
||
5129 | 5433 | { |
5130 | 5434 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
5131 | 5435 | |
5132 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
5133 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5134 | - else |
|
5135 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5436 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
5437 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5438 | + } else { |
|
5439 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5440 | + } |
|
5136 | 5441 | |
5137 | - if (isset($priority_zones[$tzkey])) |
|
5138 | - $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5139 | - else |
|
5140 | - $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5442 | + if (isset($priority_zones[$tzkey])) { |
|
5443 | + $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5444 | + } else { |
|
5445 | + $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5446 | + } |
|
5141 | 5447 | } |
5142 | 5448 | |
5143 | 5449 | $timezones = array_merge( |
@@ -5191,9 +5497,9 @@ discard block |
||
5191 | 5497 | 'Indian/Kerguelen' => 'TFT', |
5192 | 5498 | ); |
5193 | 5499 | |
5194 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
5195 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5196 | - else |
|
5500 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
5501 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5502 | + } else |
|
5197 | 5503 | { |
5198 | 5504 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
5199 | 5505 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5221,8 +5527,9 @@ discard block |
||
5221 | 5527 | */ |
5222 | 5528 | function inet_ptod($ip_address) |
5223 | 5529 | { |
5224 | - if (!isValidIP($ip_address)) |
|
5225 | - return $ip_address; |
|
5530 | + if (!isValidIP($ip_address)) { |
|
5531 | + return $ip_address; |
|
5532 | + } |
|
5226 | 5533 | |
5227 | 5534 | $bin = inet_pton($ip_address); |
5228 | 5535 | return $bin; |
@@ -5234,13 +5541,15 @@ discard block |
||
5234 | 5541 | */ |
5235 | 5542 | function inet_dtop($bin) |
5236 | 5543 | { |
5237 | - if(empty($bin)) |
|
5238 | - return ''; |
|
5544 | + if(empty($bin)) { |
|
5545 | + return ''; |
|
5546 | + } |
|
5239 | 5547 | |
5240 | 5548 | global $db_type; |
5241 | 5549 | |
5242 | - if ($db_type == 'postgresql') |
|
5243 | - return $bin; |
|
5550 | + if ($db_type == 'postgresql') { |
|
5551 | + return $bin; |
|
5552 | + } |
|
5244 | 5553 | |
5245 | 5554 | $ip_address = inet_ntop($bin); |
5246 | 5555 | |
@@ -5265,26 +5574,32 @@ discard block |
||
5265 | 5574 | */ |
5266 | 5575 | function _safe_serialize($value) |
5267 | 5576 | { |
5268 | - if(is_null($value)) |
|
5269 | - return 'N;'; |
|
5577 | + if(is_null($value)) { |
|
5578 | + return 'N;'; |
|
5579 | + } |
|
5270 | 5580 | |
5271 | - if(is_bool($value)) |
|
5272 | - return 'b:'. (int) $value .';'; |
|
5581 | + if(is_bool($value)) { |
|
5582 | + return 'b:'. (int) $value .';'; |
|
5583 | + } |
|
5273 | 5584 | |
5274 | - if(is_int($value)) |
|
5275 | - return 'i:'. $value .';'; |
|
5585 | + if(is_int($value)) { |
|
5586 | + return 'i:'. $value .';'; |
|
5587 | + } |
|
5276 | 5588 | |
5277 | - if(is_float($value)) |
|
5278 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5589 | + if(is_float($value)) { |
|
5590 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
5591 | + } |
|
5279 | 5592 | |
5280 | - if(is_string($value)) |
|
5281 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5593 | + if(is_string($value)) { |
|
5594 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
5595 | + } |
|
5282 | 5596 | |
5283 | 5597 | if(is_array($value)) |
5284 | 5598 | { |
5285 | 5599 | $out = ''; |
5286 | - foreach($value as $k => $v) |
|
5287 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5600 | + foreach($value as $k => $v) { |
|
5601 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5602 | + } |
|
5288 | 5603 | |
5289 | 5604 | return 'a:'. count($value) .':{'. $out .'}'; |
5290 | 5605 | } |
@@ -5310,8 +5625,9 @@ discard block |
||
5310 | 5625 | |
5311 | 5626 | $out = _safe_serialize($value); |
5312 | 5627 | |
5313 | - if (isset($mbIntEnc)) |
|
5314 | - mb_internal_encoding($mbIntEnc); |
|
5628 | + if (isset($mbIntEnc)) { |
|
5629 | + mb_internal_encoding($mbIntEnc); |
|
5630 | + } |
|
5315 | 5631 | |
5316 | 5632 | return $out; |
5317 | 5633 | } |
@@ -5328,8 +5644,9 @@ discard block |
||
5328 | 5644 | function _safe_unserialize($str) |
5329 | 5645 | { |
5330 | 5646 | // Input is not a string. |
5331 | - if(empty($str) || !is_string($str)) |
|
5332 | - return false; |
|
5647 | + if(empty($str) || !is_string($str)) { |
|
5648 | + return false; |
|
5649 | + } |
|
5333 | 5650 | |
5334 | 5651 | $stack = array(); |
5335 | 5652 | $expected = array(); |
@@ -5345,43 +5662,38 @@ discard block |
||
5345 | 5662 | while($state != 1) |
5346 | 5663 | { |
5347 | 5664 | $type = isset($str[0]) ? $str[0] : ''; |
5348 | - if($type == '}') |
|
5349 | - $str = substr($str, 1); |
|
5350 | - |
|
5351 | - else if($type == 'N' && $str[1] == ';') |
|
5665 | + if($type == '}') { |
|
5666 | + $str = substr($str, 1); |
|
5667 | + } else if($type == 'N' && $str[1] == ';') |
|
5352 | 5668 | { |
5353 | 5669 | $value = null; |
5354 | 5670 | $str = substr($str, 2); |
5355 | - } |
|
5356 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5671 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5357 | 5672 | { |
5358 | 5673 | $value = $matches[1] == '1' ? true : false; |
5359 | 5674 | $str = substr($str, 4); |
5360 | - } |
|
5361 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5675 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5362 | 5676 | { |
5363 | 5677 | $value = (int)$matches[1]; |
5364 | 5678 | $str = $matches[2]; |
5365 | - } |
|
5366 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5679 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5367 | 5680 | { |
5368 | 5681 | $value = (float)$matches[1]; |
5369 | 5682 | $str = $matches[3]; |
5370 | - } |
|
5371 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5683 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5372 | 5684 | { |
5373 | 5685 | $value = substr($matches[2], 0, (int)$matches[1]); |
5374 | 5686 | $str = substr($matches[2], (int)$matches[1] + 2); |
5375 | - } |
|
5376 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5687 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5377 | 5688 | { |
5378 | 5689 | $expectedLength = (int)$matches[1]; |
5379 | 5690 | $str = $matches[2]; |
5380 | 5691 | } |
5381 | 5692 | |
5382 | 5693 | // Object or unknown/malformed type. |
5383 | - else |
|
5384 | - return false; |
|
5694 | + else { |
|
5695 | + return false; |
|
5696 | + } |
|
5385 | 5697 | |
5386 | 5698 | switch($state) |
5387 | 5699 | { |
@@ -5409,8 +5721,9 @@ discard block |
||
5409 | 5721 | if($type == '}') |
5410 | 5722 | { |
5411 | 5723 | // Array size is less than expected. |
5412 | - if(count($list) < end($expected)) |
|
5413 | - return false; |
|
5724 | + if(count($list) < end($expected)) { |
|
5725 | + return false; |
|
5726 | + } |
|
5414 | 5727 | |
5415 | 5728 | unset($list); |
5416 | 5729 | $list = &$stack[count($stack)-1]; |
@@ -5419,8 +5732,9 @@ discard block |
||
5419 | 5732 | // Go to terminal state if we're at the end of the root array. |
5420 | 5733 | array_pop($expected); |
5421 | 5734 | |
5422 | - if(count($expected) == 0) |
|
5423 | - $state = 1; |
|
5735 | + if(count($expected) == 0) { |
|
5736 | + $state = 1; |
|
5737 | + } |
|
5424 | 5738 | |
5425 | 5739 | break; |
5426 | 5740 | } |
@@ -5428,8 +5742,9 @@ discard block |
||
5428 | 5742 | if($type == 'i' || $type == 's') |
5429 | 5743 | { |
5430 | 5744 | // Array size exceeds expected length. |
5431 | - if(count($list) >= end($expected)) |
|
5432 | - return false; |
|
5745 | + if(count($list) >= end($expected)) { |
|
5746 | + return false; |
|
5747 | + } |
|
5433 | 5748 | |
5434 | 5749 | $key = $value; |
5435 | 5750 | $state = 3; |
@@ -5463,8 +5778,9 @@ discard block |
||
5463 | 5778 | } |
5464 | 5779 | |
5465 | 5780 | // Trailing data in input. |
5466 | - if(!empty($str)) |
|
5467 | - return false; |
|
5781 | + if(!empty($str)) { |
|
5782 | + return false; |
|
5783 | + } |
|
5468 | 5784 | |
5469 | 5785 | return $data; |
5470 | 5786 | } |
@@ -5487,8 +5803,9 @@ discard block |
||
5487 | 5803 | |
5488 | 5804 | $out = _safe_unserialize($str); |
5489 | 5805 | |
5490 | - if (isset($mbIntEnc)) |
|
5491 | - mb_internal_encoding($mbIntEnc); |
|
5806 | + if (isset($mbIntEnc)) { |
|
5807 | + mb_internal_encoding($mbIntEnc); |
|
5808 | + } |
|
5492 | 5809 | |
5493 | 5810 | return $out; |
5494 | 5811 | } |
@@ -5503,12 +5820,14 @@ discard block |
||
5503 | 5820 | function smf_chmod($file, $value = 0) |
5504 | 5821 | { |
5505 | 5822 | // No file? no checks! |
5506 | - if (empty($file)) |
|
5507 | - return false; |
|
5823 | + if (empty($file)) { |
|
5824 | + return false; |
|
5825 | + } |
|
5508 | 5826 | |
5509 | 5827 | // Already writable? |
5510 | - if (is_writable($file)) |
|
5511 | - return true; |
|
5828 | + if (is_writable($file)) { |
|
5829 | + return true; |
|
5830 | + } |
|
5512 | 5831 | |
5513 | 5832 | // Do we have a file or a dir? |
5514 | 5833 | $isDir = is_dir($file); |
@@ -5524,10 +5843,9 @@ discard block |
||
5524 | 5843 | { |
5525 | 5844 | $isWritable = true; |
5526 | 5845 | break; |
5846 | + } else { |
|
5847 | + @chmod($file, $val); |
|
5527 | 5848 | } |
5528 | - |
|
5529 | - else |
|
5530 | - @chmod($file, $val); |
|
5531 | 5849 | } |
5532 | 5850 | |
5533 | 5851 | return $isWritable; |
@@ -5546,8 +5864,9 @@ discard block |
||
5546 | 5864 | global $txt; |
5547 | 5865 | |
5548 | 5866 | // Come on... |
5549 | - if (empty($json) || !is_string($json)) |
|
5550 | - return array(); |
|
5867 | + if (empty($json) || !is_string($json)) { |
|
5868 | + return array(); |
|
5869 | + } |
|
5551 | 5870 | |
5552 | 5871 | $returnArray = @json_decode($json, $returnAsArray); |
5553 | 5872 | |
@@ -5585,11 +5904,11 @@ discard block |
||
5585 | 5904 | $jsonDebug = $jsonDebug[0]; |
5586 | 5905 | loadLanguage('Errors'); |
5587 | 5906 | |
5588 | - if (!empty($jsonDebug)) |
|
5589 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5590 | - |
|
5591 | - else |
|
5592 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5907 | + if (!empty($jsonDebug)) { |
|
5908 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5909 | + } else { |
|
5910 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
5911 | + } |
|
5593 | 5912 | |
5594 | 5913 | // Everyone expects an array. |
5595 | 5914 | return array(); |
@@ -5623,8 +5942,9 @@ discard block |
||
5623 | 5942 | global $db_show_debug, $modSettings; |
5624 | 5943 | |
5625 | 5944 | // Defensive programming anyone? |
5626 | - if (empty($data)) |
|
5627 | - return false; |
|
5945 | + if (empty($data)) { |
|
5946 | + return false; |
|
5947 | + } |
|
5628 | 5948 | |
5629 | 5949 | // Don't need extra stuff... |
5630 | 5950 | $db_show_debug = false; |
@@ -5632,11 +5952,11 @@ discard block |
||
5632 | 5952 | // Kill anything else. |
5633 | 5953 | ob_end_clean(); |
5634 | 5954 | |
5635 | - if (!empty($modSettings['CompressedOutput'])) |
|
5636 | - @ob_start('ob_gzhandler'); |
|
5637 | - |
|
5638 | - else |
|
5639 | - ob_start(); |
|
5955 | + if (!empty($modSettings['CompressedOutput'])) { |
|
5956 | + @ob_start('ob_gzhandler'); |
|
5957 | + } else { |
|
5958 | + ob_start(); |
|
5959 | + } |
|
5640 | 5960 | |
5641 | 5961 | // Set the header. |
5642 | 5962 | header($type); |
@@ -5668,8 +5988,9 @@ discard block |
||
5668 | 5988 | static $done = false; |
5669 | 5989 | |
5670 | 5990 | // If we don't need to do anything, don't |
5671 | - if (!$update && $done) |
|
5672 | - return; |
|
5991 | + if (!$update && $done) { |
|
5992 | + return; |
|
5993 | + } |
|
5673 | 5994 | |
5674 | 5995 | // Should we get a new copy of the official list of TLDs? |
5675 | 5996 | if ($update) |
@@ -5678,8 +5999,9 @@ discard block |
||
5678 | 5999 | $tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt'); |
5679 | 6000 | |
5680 | 6001 | // If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored. |
5681 | - if ($tlds === false) |
|
5682 | - $postapocalypticNightmare = true; |
|
6002 | + if ($tlds === false) { |
|
6003 | + $postapocalypticNightmare = true; |
|
6004 | + } |
|
5683 | 6005 | } |
5684 | 6006 | // If we aren't updating and the regex is valid, we're done |
5685 | 6007 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5694,10 +6016,11 @@ discard block |
||
5694 | 6016 | // Clean $tlds and convert it to an array |
5695 | 6017 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
5696 | 6018 | $line = trim($line); |
5697 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
5698 | - return false; |
|
5699 | - else |
|
5700 | - return true; |
|
6019 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
6020 | + return false; |
|
6021 | + } else { |
|
6022 | + return true; |
|
6023 | + } |
|
5701 | 6024 | }); |
5702 | 6025 | |
5703 | 6026 | // Convert Punycode to Unicode |
@@ -5751,8 +6074,9 @@ discard block |
||
5751 | 6074 | $idx += $digit * $w; |
5752 | 6075 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
5753 | 6076 | |
5754 | - if ($digit < $t) |
|
5755 | - break; |
|
6077 | + if ($digit < $t) { |
|
6078 | + break; |
|
6079 | + } |
|
5756 | 6080 | |
5757 | 6081 | $w = (int) ($w * ($base - $t)); |
5758 | 6082 | } |
@@ -5761,8 +6085,9 @@ discard block |
||
5761 | 6085 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
5762 | 6086 | $delta += intval($delta / ($deco_len + 1)); |
5763 | 6087 | |
5764 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
5765 | - $delta = intval($delta / ($base - $tmin)); |
|
6088 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
6089 | + $delta = intval($delta / ($base - $tmin)); |
|
6090 | + } |
|
5766 | 6091 | |
5767 | 6092 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
5768 | 6093 | $is_first = false; |
@@ -5771,8 +6096,9 @@ discard block |
||
5771 | 6096 | |
5772 | 6097 | if ($deco_len > 0) |
5773 | 6098 | { |
5774 | - for ($i = $deco_len; $i > $idx; $i--) |
|
5775 | - $decoded[$i] = $decoded[($i - 1)]; |
|
6099 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
6100 | + $decoded[$i] = $decoded[($i - 1)]; |
|
6101 | + } |
|
5776 | 6102 | } |
5777 | 6103 | $decoded[$idx++] = $char; |
5778 | 6104 | } |
@@ -5780,24 +6106,29 @@ discard block |
||
5780 | 6106 | foreach ($decoded as $k => $v) |
5781 | 6107 | { |
5782 | 6108 | // 7bit are transferred literally |
5783 | - if ($v < 128) |
|
5784 | - $output .= chr($v); |
|
6109 | + if ($v < 128) { |
|
6110 | + $output .= chr($v); |
|
6111 | + } |
|
5785 | 6112 | |
5786 | 6113 | // 2 bytes |
5787 | - elseif ($v < (1 << 11)) |
|
5788 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6114 | + elseif ($v < (1 << 11)) { |
|
6115 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6116 | + } |
|
5789 | 6117 | |
5790 | 6118 | // 3 bytes |
5791 | - elseif ($v < (1 << 16)) |
|
5792 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6119 | + elseif ($v < (1 << 16)) { |
|
6120 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6121 | + } |
|
5793 | 6122 | |
5794 | 6123 | // 4 bytes |
5795 | - elseif ($v < (1 << 21)) |
|
5796 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6124 | + elseif ($v < (1 << 21)) { |
|
6125 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6126 | + } |
|
5797 | 6127 | |
5798 | 6128 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5799 | - else |
|
5800 | - $output .= $safe_char; |
|
6129 | + else { |
|
6130 | + $output .= $safe_char; |
|
6131 | + } |
|
5801 | 6132 | } |
5802 | 6133 | |
5803 | 6134 | $output_parts[] = $output; |
@@ -5890,8 +6221,7 @@ discard block |
||
5890 | 6221 | |
5891 | 6222 | $strlen = 'mb_strlen'; |
5892 | 6223 | $substr = 'mb_substr'; |
5893 | - } |
|
5894 | - else |
|
6224 | + } else |
|
5895 | 6225 | { |
5896 | 6226 | $strlen = $smcFunc['strlen']; |
5897 | 6227 | $substr = $smcFunc['substr']; |
@@ -5905,20 +6235,21 @@ discard block |
||
5905 | 6235 | |
5906 | 6236 | $first = $substr($string, 0, 1); |
5907 | 6237 | |
5908 | - if (empty($index[$first])) |
|
5909 | - $index[$first] = array(); |
|
6238 | + if (empty($index[$first])) { |
|
6239 | + $index[$first] = array(); |
|
6240 | + } |
|
5910 | 6241 | |
5911 | 6242 | if ($strlen($string) > 1) |
5912 | 6243 | { |
5913 | 6244 | // Sanity check on recursion |
5914 | - if ($depth > 99) |
|
5915 | - $index[$first][$substr($string, 1)] = ''; |
|
5916 | - |
|
5917 | - else |
|
5918 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6245 | + if ($depth > 99) { |
|
6246 | + $index[$first][$substr($string, 1)] = ''; |
|
6247 | + } else { |
|
6248 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6249 | + } |
|
6250 | + } else { |
|
6251 | + $index[$first][''] = ''; |
|
5919 | 6252 | } |
5920 | - else |
|
5921 | - $index[$first][''] = ''; |
|
5922 | 6253 | |
5923 | 6254 | $depth--; |
5924 | 6255 | return $index; |
@@ -5941,9 +6272,9 @@ discard block |
||
5941 | 6272 | $key_regex = preg_quote($key, $delim); |
5942 | 6273 | $new_key = $key; |
5943 | 6274 | |
5944 | - if (empty($value)) |
|
5945 | - $sub_regex = ''; |
|
5946 | - else |
|
6275 | + if (empty($value)) { |
|
6276 | + $sub_regex = ''; |
|
6277 | + } else |
|
5947 | 6278 | { |
5948 | 6279 | $sub_regex = $index_to_regex($value, $delim); |
5949 | 6280 | |
@@ -5951,22 +6282,22 @@ discard block |
||
5951 | 6282 | { |
5952 | 6283 | $new_key_array = explode('(?'.'>', $sub_regex); |
5953 | 6284 | $new_key .= $new_key_array[0]; |
6285 | + } else { |
|
6286 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5954 | 6287 | } |
5955 | - else |
|
5956 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5957 | 6288 | } |
5958 | 6289 | |
5959 | - if ($depth > 1) |
|
5960 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
5961 | - else |
|
6290 | + if ($depth > 1) { |
|
6291 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
6292 | + } else |
|
5962 | 6293 | { |
5963 | 6294 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
5964 | 6295 | { |
5965 | 6296 | $regex[$new_key] = $key_regex . $sub_regex; |
5966 | 6297 | unset($index[$key]); |
6298 | + } else { |
|
6299 | + break; |
|
5967 | 6300 | } |
5968 | - else |
|
5969 | - break; |
|
5970 | 6301 | } |
5971 | 6302 | } |
5972 | 6303 | |
@@ -5975,10 +6306,11 @@ discard block |
||
5975 | 6306 | $l1 = $strlen($k1); |
5976 | 6307 | $l2 = $strlen($k2); |
5977 | 6308 | |
5978 | - if ($l1 == $l2) |
|
5979 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
5980 | - else |
|
5981 | - return $l1 > $l2 ? -1 : 1; |
|
6309 | + if ($l1 == $l2) { |
|
6310 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
6311 | + } else { |
|
6312 | + return $l1 > $l2 ? -1 : 1; |
|
6313 | + } |
|
5982 | 6314 | }); |
5983 | 6315 | |
5984 | 6316 | $depth--; |
@@ -5989,21 +6321,24 @@ discard block |
||
5989 | 6321 | $index = array(); |
5990 | 6322 | $regex = ''; |
5991 | 6323 | |
5992 | - foreach ($strings as $string) |
|
5993 | - $index = $add_string_to_index($string, $index); |
|
6324 | + foreach ($strings as $string) { |
|
6325 | + $index = $add_string_to_index($string, $index); |
|
6326 | + } |
|
5994 | 6327 | |
5995 | 6328 | if ($returnArray === true) |
5996 | 6329 | { |
5997 | 6330 | $regex = array(); |
5998 | - while (!empty($index)) |
|
5999 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6331 | + while (!empty($index)) { |
|
6332 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6333 | + } |
|
6334 | + } else { |
|
6335 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6000 | 6336 | } |
6001 | - else |
|
6002 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6003 | 6337 | |
6004 | 6338 | // Restore PHP's internal character encoding to whatever it was originally |
6005 | - if (!empty($current_encoding)) |
|
6006 | - mb_internal_encoding($current_encoding); |
|
6339 | + if (!empty($current_encoding)) { |
|
6340 | + mb_internal_encoding($current_encoding); |
|
6341 | + } |
|
6007 | 6342 | |
6008 | 6343 | return $regex; |
6009 | 6344 | } |
@@ -6046,13 +6381,15 @@ discard block |
||
6046 | 6381 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
6047 | 6382 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
6048 | 6383 | $headers = @get_headers($url); |
6049 | - if ($headers === false) |
|
6050 | - return false; |
|
6384 | + if ($headers === false) { |
|
6385 | + return false; |
|
6386 | + } |
|
6051 | 6387 | |
6052 | 6388 | // Now to see if it came back https... |
6053 | 6389 | // First check for a redirect status code in first row (301, 302, 307) |
6054 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
6055 | - return false; |
|
6390 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
6391 | + return false; |
|
6392 | + } |
|
6056 | 6393 | |
6057 | 6394 | // Search for the location entry to confirm https |
6058 | 6395 | $result = false; |
@@ -6088,8 +6425,7 @@ discard block |
||
6088 | 6425 | $is_admin = $user_info['is_admin']; |
6089 | 6426 | $mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null; |
6090 | 6427 | $ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null; |
6091 | - } |
|
6092 | - else |
|
6428 | + } else |
|
6093 | 6429 | { |
6094 | 6430 | $request = $smcFunc['db_query']('', ' |
6095 | 6431 | SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group |
@@ -6103,17 +6439,19 @@ discard block |
||
6103 | 6439 | |
6104 | 6440 | $row = $smcFunc['db_fetch_assoc']($request); |
6105 | 6441 | |
6106 | - if (empty($row['additional_groups'])) |
|
6107 | - $groups = array($row['id_group'], $row['id_post_group']); |
|
6108 | - else |
|
6109 | - $groups = array_merge( |
|
6442 | + if (empty($row['additional_groups'])) { |
|
6443 | + $groups = array($row['id_group'], $row['id_post_group']); |
|
6444 | + } else { |
|
6445 | + $groups = array_merge( |
|
6110 | 6446 | array($row['id_group'], $row['id_post_group']), |
6111 | 6447 | explode(',', $row['additional_groups']) |
6112 | 6448 | ); |
6449 | + } |
|
6113 | 6450 | |
6114 | 6451 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
6115 | - foreach ($groups as $k => $v) |
|
6116 | - $groups[$k] = (int) $v; |
|
6452 | + foreach ($groups as $k => $v) { |
|
6453 | + $groups[$k] = (int) $v; |
|
6454 | + } |
|
6117 | 6455 | |
6118 | 6456 | $is_admin = in_array(1, $groups); |
6119 | 6457 | |
@@ -6130,8 +6468,9 @@ discard block |
||
6130 | 6468 | 'current_member' => $userid, |
6131 | 6469 | ) |
6132 | 6470 | ); |
6133 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6134 | - $boards_mod[] = $row['id_board']; |
|
6471 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6472 | + $boards_mod[] = $row['id_board']; |
|
6473 | + } |
|
6135 | 6474 | $smcFunc['db_free_result']($request); |
6136 | 6475 | |
6137 | 6476 | // Can any of the groups they're in moderate any of the boards? |
@@ -6143,8 +6482,9 @@ discard block |
||
6143 | 6482 | 'groups' => $groups, |
6144 | 6483 | ) |
6145 | 6484 | ); |
6146 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6147 | - $boards_mod[] = $row['id_board']; |
|
6485 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6486 | + $boards_mod[] = $row['id_board']; |
|
6487 | + } |
|
6148 | 6488 | $smcFunc['db_free_result']($request); |
6149 | 6489 | |
6150 | 6490 | // Just in case we've got duplicates here... |
@@ -6154,21 +6494,25 @@ discard block |
||
6154 | 6494 | } |
6155 | 6495 | |
6156 | 6496 | // Just build this here, it makes it easier to change/use - administrators can see all boards. |
6157 | - if ($is_admin) |
|
6158 | - $query_part['query_see_board'] = '1=1'; |
|
6497 | + if ($is_admin) { |
|
6498 | + $query_part['query_see_board'] = '1=1'; |
|
6499 | + } |
|
6159 | 6500 | // Otherwise just the groups in $user_info['groups']. |
6160 | - else |
|
6161 | - $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6501 | + else { |
|
6502 | + $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6503 | + } |
|
6162 | 6504 | |
6163 | 6505 | // Build the list of boards they WANT to see. |
6164 | 6506 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
6165 | 6507 | |
6166 | 6508 | // If they aren't ignoring any boards then they want to see all the boards they can see |
6167 | - if (empty($ignoreboards)) |
|
6168 | - $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6509 | + if (empty($ignoreboards)) { |
|
6510 | + $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6511 | + } |
|
6169 | 6512 | // Ok I guess they don't want to see all the boards |
6170 | - else |
|
6171 | - $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6513 | + else { |
|
6514 | + $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6515 | + } |
|
6172 | 6516 | |
6173 | 6517 | return $query_part; |
6174 | 6518 | } |
@@ -6182,10 +6526,11 @@ discard block |
||
6182 | 6526 | { |
6183 | 6527 | $secure = false; |
6184 | 6528 | |
6185 | - if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') |
|
6186 | - $secure = true; |
|
6187 | - elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') |
|
6188 | - $secure = true; |
|
6529 | + if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') { |
|
6530 | + $secure = true; |
|
6531 | + } elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') { |
|
6532 | + $secure = true; |
|
6533 | + } |
|
6189 | 6534 | |
6190 | 6535 | return $secure; |
6191 | 6536 | } |