SimpleMachines / SMF2.1

Sources/SplitTopics.php

Braces +2 added lines, -1 removed lines

@@ -1076,7 +1076,8 @@
 		{
 			unset($topics[$row['id_topic']]); // If we can't see it, we should not merge it and not adjust counts! Instead skip it.
 			continue;
-		}elseif (!$row['approved'])
+		}
+		elseif (!$row['approved'])
 			$boardTotals[$row['id_board']]['unapproved_topics']++;
 		else
 			$boardTotals[$row['id_board']]['topics']++;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1339,7 +1339,7 @@
 	list ($member_started) = $smcFunc['db_fetch_row']($request);
 	list ($member_updated) = $smcFunc['db_fetch_row']($request);
 	// First and last message are the same, so only row was returned.
-	if ($member_updated === NULL)
+	if ($member_updated === null)
 		$member_updated = $member_started;
 
 	$smcFunc['db_free_result']($request);

Sources/ManageSearch.php

Braces +4 added lines, -2 removed lines

@@ -223,7 +223,8 @@ 
 		checkSession('get');
 		validateToken('admin-msm', 'get');
 
-		if ($db_type == 'postgresql') {
+		if ($db_type == 'postgresql')
+		{
 			$smcFunc['db_query']('', '
 				DROP INDEX IF EXISTS {db_prefix}messages_ftx',
 				array(
@@ -787,7 +788,8 @@ 
 	// We need this for db_get_version
 	db_extend();
 
-	if ($smcFunc['db_title'] == 'PostgreSQL') {
+	if ($smcFunc['db_title'] == 'PostgreSQL')
+	{
 		$request = $smcFunc['db_query']('', '
 			SELECT
 				indexname

Sources/Class-TOTP.php

Braces +24 added lines, -12 removed lines

@@ -64,7 +64,8 @@ 
 	{
 		$this->buildLookup();
 
-		if ($initKey !== null) {
+		if ($initKey !== null)
+		{
 			$this->setInitKey($initKey);
 		}
 	}
@@ -98,7 +99,8 @@ 
 	 */
 	public function setRange($range)
 	{
-		if (!is_numeric($range)) {
+		if (!is_numeric($range))
+		{
 			throw new \InvalidArgumentException('Invalid window range');
 		}
 		$this->range = $range;
@@ -114,7 +116,8 @@ 
 	 */
 	public function setInitKey($key)
 	{
-		if (preg_match('/^[' . implode('', array_keys($this->getLookup())) . ']+$/', $key) == false) {
+		if (preg_match('/^[' . implode('', array_keys($this->getLookup())) . ']+$/', $key) == false)
+		{
 			throw new \InvalidArgumentException('Invalid base32 hash!');
 		}
 		$this->initKey = $key;
@@ -140,7 +143,8 @@ 
 	 */
 	public function setLookup($lookup)
 	{
-		if (!is_array($lookup)) {
+		if (!is_array($lookup))
+		{
 			throw new \InvalidArgumentException('Lookup value must be an array');
 		}
 		$this->lookup = $lookup;
@@ -176,7 +180,8 @@ 
 	 */
 	public function setRefresh($seconds)
 	{
-		if (!is_numeric($seconds)) {
+		if (!is_numeric($seconds))
+		{
 			throw new \InvalidArgumentException('Seconds must be numeric');
 		}
 		$this->refreshSeconds = $seconds;
@@ -217,7 +222,8 @@ 
 	 */
 	public function validateCode($code, $initKey = null, $timestamp = null, $range = null)
 	{
-		if (strlen($code) !== $this->getCodeLength()) {
+		if (strlen($code) !== $this->getCodeLength())
+		{
 			throw new \InvalidArgumentException('Incorrect code length');
 		}
 
@@ -227,8 +233,10 @@ 
 
 		$binary = $this->base32_decode($initKey);
 
-		for ($time = ($timestamp - $range); $time <= ($timestamp + $range); $time++) {
-			if ($this->generateOneTime($binary, $time) == $code) {
+		for ($time = ($timestamp - $range); $time <= ($timestamp + $range); $time++)
+		{
+			if ($this->generateOneTime($binary, $time) == $code)
+			{
 				return true;
 			}
 		}
@@ -269,7 +277,8 @@ 
 		$lookup = implode('', array_keys($this->getLookup()));
 		$code = '';
 
-		for ($i = 0; $i < $length; $i++) {
+		for ($i = 0; $i < $length; $i++)
+		{
 			$code .= $lookup[mt_rand(0, strlen($lookup) - 1)];
 		}
 
@@ -315,7 +324,8 @@ 
 	{
 		$lookup = $this->getLookup();
 
-		if (preg_match('/^[' . implode('', array_keys($lookup)) . ']+$/', $hash) == false) {
+		if (preg_match('/^[' . implode('', array_keys($lookup)) . ']+$/', $hash) == false)
+		{
 			throw new \InvalidArgumentException('Invalid base32 hash!');
 		}
 
@@ -324,12 +334,14 @@ 
 		$length = 0;
 		$binary = '';
 
-		for ($i = 0; $i < strlen($hash); $i++) {
+		for ($i = 0; $i < strlen($hash); $i++)
+		{
 			$buffer = $buffer << 5;
 			$buffer += $lookup[$hash[$i]];
 			$length += 5;
 
-			if ($length >= 8) {
+			if ($length >= 8)
+			{
 				$length -= 8;
 				$binary .= chr(($buffer & (0xFF << $length)) >> $length);
 			}

Sources/Likes.php

Braces -1 removed lines

@@ -222,7 +222,6 @@
 
 			$this->_validLikes['can_like'] = ($this->_user['id'] == $topicOwner ? 'cannot_like_content' : (allowedTo('likes_like') ? true : 'cannot_like_content'));
 		}
-
 		else
 		{
 			// Modders: This will give you whatever the user offers up in terms of liking, e.g. $this->_type=msg, $this->_content=1

Sources/Subs-MembersOnline.php

Braces -1 removed lines

@@ -93,7 +93,6 @@
 
 			continue;
 		}
-
 		elseif (empty($row['show_online']) && empty($membersOnlineOptions['show_hidden']))
 		{
 			// Just increase the stats and don't add this hidden user to any list.

Sources/PersonalMessage.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -3219,7 +3219,7 @@ 
 		// Deleting an existing label?
 		elseif (isset($_POST['delete'], $_POST['delete_label']))
 		{
-			foreach ($_POST['delete_label'] AS $label => $dummy)
+			foreach ($_POST['delete_label'] as $label => $dummy)
 			{
 				unset($the_labels[$label]);
 				$labels_to_remove[] = $label;
@@ -3260,7 +3260,7 @@ 
 		if (!empty($labels_to_add))
 		{
 			$inserts = array();
-			foreach ($labels_to_add AS $label)
+			foreach ($labels_to_add as $label)
 				$inserts[] = array($user_info['id'], $label);
 
 			$smcFunc['db_insert']('', '{db_prefix}pm_labels', array('id_member' => 'int', 'name' => 'string-30'), $inserts, array());
@@ -3269,7 +3269,7 @@ 
 		// Update existing labels as needed
 		if (!empty($label_upates))
 		{
-			foreach ($label_updates AS $id => $name)
+			foreach ($label_updates as $id => $name)
 			{
 				$smcFunc['db_query']('', '
 					UPDATE {db_prefix}labels

Sources/Register.php

Braces -1 removed lines

@@ -849,7 +849,6 @@
 			die("\x47\x49\x46\x38\x39\x61\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\x00\x00\x00\x21\xF9\x04\x01\x00\x00\x00\x00\x2C\x00\x00\x00\x00\x01\x00\x01\x00\x00\x02\x02\x44\x01\x00\x3B");
 		}
 	}
-
 	elseif ($_REQUEST['format'] === '.wav')
 	{
 		require_once($sourcedir . '/Subs-Sound.php');

Sources/Subs-Membergroups.php

Braces -1 removed lines

@@ -756,7 +756,6 @@
 				$groups[$row['id_group']]['num_members'] += $row['num_members'];
 			$smcFunc['db_free_result']($query);
 		}
-
 		else
 		{
 			$query = $smcFunc['db_query']('', '

Sources/Subs-Package.php

Braces +4 added lines, -3 removed lines

@@ -253,9 +253,10 @@ 
 
 		// Phar doesn't handle open_basedir restrictions very well and throws a PHP Warning. Ignore that.
 		set_error_handler(function($errno, $errstr, $errfile, $errline)
-			{
+		{
 				// error was suppressed with the @-operator
-				if (0 === error_reporting()) {
+				if (0 === error_reporting())
+				{
 					return false;
 				}
 				if (strpos($errstr, 'PharData::__construct(): open_basedir') === false)
@@ -269,7 +270,7 @@ 
 
 		// go though each file in the archive
 		foreach ($iterator as $file_info)
-			{
+		{
 				$i = $iterator->getSubPathname();
 				// If this is a file, and it doesn't exist.... happy days!
 				if (substr($i, -1) != '/' && !file_exists($destination . '/' . $i))