Completed
Push — release-2.1 ( 341df6...a9a826 )
by Michael
25:03 queued 14:41
created
Sources/Post.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -256,8 +256,8 @@  discard block
 block discarded – undo
256 256
 			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
257 257
 
258 258
 		$js_time_string = str_replace(
259
-			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
260
-			array('H',  'G',  'h',  'g',  'i',  'A',  'a',  'h:i:s A', 'H:i', 's',  'H:i:s', 'H:i:s'),
259
+			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'),
260
+			array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'),
261 261
 			$time_string
262 262
 		);
263 263
 
@@ -1305,14 +1305,14 @@  discard block
 block discarded – undo
1305 1305
 	if (isset($context['name']) && isset($context['email']))
1306 1306
 	{
1307 1307
 		$context['posting_fields']['guestname'] = array(
1308
-			'dt' => '<span id="caption_guestname"' .  (isset($context['post_error']['long_name']) || isset($context['post_error']['no_name']) || isset($context['post_error']['bad_name']) ? ' class="error"' : '') . '>' . $txt['name'] . '</span>',
1308
+			'dt' => '<span id="caption_guestname"' . (isset($context['post_error']['long_name']) || isset($context['post_error']['no_name']) || isset($context['post_error']['bad_name']) ? ' class="error"' : '') . '>' . $txt['name'] . '</span>',
1309 1309
 			'dd' => '<input type="text" name="guestname" size="25" value="' . $context['name'] . '" required>',
1310 1310
 		);
1311 1311
 
1312 1312
 		if (empty($modSettings['guest_post_no_email']))
1313 1313
 		{
1314 1314
 			$context['posting_fields']['email'] = array(
1315
-				'dt' => '<span id="caption_email"' .  (isset($context['post_error']['no_email']) || isset($context['post_error']['bad_email']) ? ' class="error"' : '') . '>' . $txt['email'] . '</span>',
1315
+				'dt' => '<span id="caption_email"' . (isset($context['post_error']['no_email']) || isset($context['post_error']['bad_email']) ? ' class="error"' : '') . '>' . $txt['email'] . '</span>',
1316 1316
 				'dd' => '<input type="email" name="email" size="25" value="' . $context['email'] . '" required>',
1317 1317
 			);
1318 1318
 		}
Please login to merge, or discard this patch.
Sources/ManageSmileys.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
 					'class' => 'centercol',
394 394
 				),
395 395
 				'data' => array(
396
-					'function' => function ($rowData)
396
+					'function' => function($rowData)
397 397
 					{
398 398
 						return $rowData['selected'] ? '<span class="generic_icons valid"></span>' : '';
399 399
 					},
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
 					'class' => 'centercol',
454 454
 				),
455 455
 				'data' => array(
456
-					'function' => function ($rowData)
456
+					'function' => function($rowData)
457 457
 					{
458 458
 						return $rowData['selected'] ? '' : sprintf('<input type="checkbox" name="smiley_set[%1$d]">', $rowData['id']);
459 459
 					},
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
 						'value' => $txt['smileys_location'],
998 998
 					),
999 999
 					'data' => array(
1000
-						'function' => function ($rowData) use ($txt)
1000
+						'function' => function($rowData) use ($txt)
1001 1001
 						{
1002 1002
 							if (empty($rowData['hidden']))
1003 1003
 								return $txt['smileys_location_form'];
@@ -1017,7 +1017,7 @@  discard block
 block discarded – undo
1017 1017
 						'value' => $txt['smileys_description'],
1018 1018
 					),
1019 1019
 					'data' => array(
1020
-						'function' => function ($rowData) use ($context, $txt, $modSettings, $smcFunc)
1020
+						'function' => function($rowData) use ($context, $txt, $modSettings, $smcFunc)
1021 1021
 						{
1022 1022
 							if (empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir']))
1023 1023
 								return $smcFunc['htmlspecialchars']($rowData['description']);
@@ -1554,7 +1554,7 @@  discard block
 block discarded – undo
1554 1554
 				'action' => $smcFunc['htmlspecialchars'](strtr($action['destination'], array($boarddir => '.')))
1555 1555
 			);
1556 1556
 
1557
-			$file =  $packagesdir . '/temp/' . $base_path . $action['filename'];
1557
+			$file = $packagesdir . '/temp/' . $base_path . $action['filename'];
1558 1558
 			if (isset($action['filename']) && (!file_exists($file) || !is_writable(dirname($action['destination']))))
1559 1559
 			{
1560 1560
 				$context['has_failure'] = true;
@@ -1599,7 +1599,7 @@  discard block
 block discarded – undo
1599 1599
 		{
1600 1600
 			updateSettings(array(
1601 1601
 				'smiley_sets_known' => $modSettings['smiley_sets_known'] . ',' . basename($action['action']),
1602
-				'smiley_sets_names' => $modSettings['smiley_sets_names'] . "\n" . $smileyInfo['name'] . (count($context['actions']) > 1 ? ' ' .  (!empty($action['description']) ? $smcFunc['htmlspecialchars']($action['description']) : basename($action['action'])) : ''),
1602
+				'smiley_sets_names' => $modSettings['smiley_sets_names'] . "\n" . $smileyInfo['name'] . (count($context['actions']) > 1 ? ' ' . (!empty($action['description']) ? $smcFunc['htmlspecialchars']($action['description']) : basename($action['action'])) : ''),
1603 1603
 			));
1604 1604
 		}
1605 1605
 
@@ -1611,7 +1611,7 @@  discard block
 block discarded – undo
1611 1611
 			'{db_prefix}log_packages',
1612 1612
 			array(
1613 1613
 				'filename' => 'string', 'name' => 'string', 'package_id' => 'string', 'version' => 'string',
1614
-				'id_member_installed' => 'int', 'member_installed' => 'string','time_installed' => 'int',
1614
+				'id_member_installed' => 'int', 'member_installed' => 'string', 'time_installed' => 'int',
1615 1615
 				'install_state' => 'int', 'failed_steps' => 'string', 'themes_installed' => 'string',
1616 1616
 				'member_removed' => 'int', 'db_changes' => 'string', 'credits' => 'string',
1617 1617
 			),
@@ -1860,7 +1860,7 @@  discard block
 block discarded – undo
1860 1860
 		'columns' => array(
1861 1861
 			'icon' => array(
1862 1862
 				'data' => array(
1863
-					'function' => function ($rowData) use ($settings, $smcFunc)
1863
+					'function' => function($rowData) use ($settings, $smcFunc)
1864 1864
 					{
1865 1865
 						$images_url = $settings[file_exists(sprintf('%1$s/images/post/%2$s.png', $settings['theme_dir'], $rowData['filename'])) ? 'actual_images_url' : 'default_images_url'];
1866 1866
 						return sprintf('<img src="%1$s/post/%2$s.png" alt="%3$s">', $images_url, $rowData['filename'], $smcFunc['htmlspecialchars']($rowData['title']));
@@ -1894,7 +1894,7 @@  discard block
 block discarded – undo
1894 1894
 					'value' => $txt['icons_board'],
1895 1895
 				),
1896 1896
 				'data' => array(
1897
-					'function' => function ($rowData) use ($txt)
1897
+					'function' => function($rowData) use ($txt)
1898 1898
 					{
1899 1899
 						return empty($rowData['board_name']) ? $txt['icons_edit_icons_all_boards'] : $rowData['board_name'];
1900 1900
 					},
Please login to merge, or discard this patch.
Sources/Profile.php 1 patch
Braces   +155 added lines, -118 removed lines patch added patch discarded remove patch
@@ -15,8 +15,9 @@  discard block
 block discarded – undo
15 15
  * @version 2.1 Beta 4
16 16
  */
17 17
 
18
-if (!defined('SMF'))
18
+if (!defined('SMF')) {
19 19
 	die('No direct access...');
20
+}
20 21
 
21 22
 /**
22 23
  * The main designating function for modifying profiles. Loads up info, determins what to do, etc.
@@ -29,18 +30,21 @@  discard block
 block discarded – undo
29 30
 	global $modSettings, $memberContext, $profile_vars, $post_errors, $smcFunc;
30 31
 
31 32
 	// Don't reload this as we may have processed error strings.
32
-	if (empty($post_errors))
33
-		loadLanguage('Profile+Drafts');
33
+	if (empty($post_errors)) {
34
+			loadLanguage('Profile+Drafts');
35
+	}
34 36
 	loadTemplate('Profile');
35 37
 
36 38
 	require_once($sourcedir . '/Subs-Menu.php');
37 39
 
38 40
 	// Did we get the user by name...
39
-	if (isset($_REQUEST['user']))
40
-		$memberResult = loadMemberData($_REQUEST['user'], true, 'profile');
41
+	if (isset($_REQUEST['user'])) {
42
+			$memberResult = loadMemberData($_REQUEST['user'], true, 'profile');
43
+	}
41 44
 	// ... or by id_member?
42
-	elseif (!empty($_REQUEST['u']))
43
-		$memberResult = loadMemberData((int) $_REQUEST['u'], false, 'profile');
45
+	elseif (!empty($_REQUEST['u'])) {
46
+			$memberResult = loadMemberData((int) $_REQUEST['u'], false, 'profile');
47
+	}
44 48
 	// If it was just ?action=profile, edit your own profile, but only if you're not a guest.
45 49
 	else
46 50
 	{
@@ -50,8 +54,9 @@  discard block
 block discarded – undo
50 54
 	}
51 55
 
52 56
 	// Check if loadMemberData() has returned a valid result.
53
-	if (!$memberResult)
54
-		fatal_lang_error('not_a_user', false, 404);
57
+	if (!$memberResult) {
58
+			fatal_lang_error('not_a_user', false, 404);
59
+	}
55 60
 
56 61
 	// If all went well, we have a valid member ID!
57 62
 	list ($memID) = $memberResult;
@@ -67,8 +72,9 @@  discard block
 block discarded – undo
67 72
 
68 73
 	// Group management isn't actually a permission. But we need it to be for this, so we need a phantom permission.
69 74
 	// And we care about what the current user can do, not what the user whose profile it is.
70
-	if ($user_info['mod_cache']['gq'] != '0=1')
71
-		$user_info['permissions'][] = 'approve_group_requests';
75
+	if ($user_info['mod_cache']['gq'] != '0=1') {
76
+			$user_info['permissions'][] = 'approve_group_requests';
77
+	}
72 78
 
73 79
 	// If paid subscriptions are enabled, make sure we actually have at least one subscription available...
74 80
 	$context['subs_available'] = false;
@@ -436,21 +442,25 @@  discard block
 block discarded – undo
436 442
 		foreach ($section['areas'] as $area_id => $area)
437 443
 		{
438 444
 			// If it said no permissions that meant it wasn't valid!
439
-			if (empty($area['permission'][$context['user']['is_owner'] ? 'own' : 'any']))
440
-				$profile_areas[$section_id]['areas'][$area_id]['enabled'] = false;
445
+			if (empty($area['permission'][$context['user']['is_owner'] ? 'own' : 'any'])) {
446
+							$profile_areas[$section_id]['areas'][$area_id]['enabled'] = false;
447
+			}
441 448
 			// Otherwise pick the right set.
442
-			else
443
-				$profile_areas[$section_id]['areas'][$area_id]['permission'] = $area['permission'][$context['user']['is_owner'] ? 'own' : 'any'];
449
+			else {
450
+							$profile_areas[$section_id]['areas'][$area_id]['permission'] = $area['permission'][$context['user']['is_owner'] ? 'own' : 'any'];
451
+			}
444 452
 
445 453
 			// Password required in most cases
446
-			if (!empty($area['password']))
447
-				$context['password_areas'][] = $area_id;
454
+			if (!empty($area['password'])) {
455
+							$context['password_areas'][] = $area_id;
456
+			}
448 457
 		}
449 458
 	}
450 459
 
451 460
 	// Is there an updated message to show?
452
-	if (isset($_GET['updated']))
453
-		$context['profile_updated'] = $txt['profile_updated_own'];
461
+	if (isset($_GET['updated'])) {
462
+			$context['profile_updated'] = $txt['profile_updated_own'];
463
+	}
454 464
 
455 465
 	// Set a few options for the menu.
456 466
 	$menuOptions = array(
@@ -465,8 +475,9 @@  discard block
 block discarded – undo
465 475
 	$profile_include_data = createMenu($profile_areas, $menuOptions);
466 476
 
467 477
 	// No menu means no access.
468
-	if (!$profile_include_data && (!$user_info['is_guest'] || validateSession()))
469
-		fatal_lang_error('no_access', false);
478
+	if (!$profile_include_data && (!$user_info['is_guest'] || validateSession())) {
479
+			fatal_lang_error('no_access', false);
480
+	}
470 481
 
471 482
 	// Make a note of the Unique ID for this menu.
472 483
 	$context['profile_menu_id'] = $context['max_menu_id'];
@@ -492,8 +503,9 @@  discard block
 block discarded – undo
492 503
 			if ($current_area == $area_id)
493 504
 			{
494 505
 				// This can't happen - but is a security check.
495
-				if ((isset($section['enabled']) && $section['enabled'] == false) || (isset($area['enabled']) && $area['enabled'] == false))
496
-					fatal_lang_error('no_access', false);
506
+				if ((isset($section['enabled']) && $section['enabled'] == false) || (isset($area['enabled']) && $area['enabled'] == false)) {
507
+									fatal_lang_error('no_access', false);
508
+				}
497 509
 
498 510
 				// Are we saving data in a valid area?
499 511
 				if (isset($area['sc']) && (isset($_REQUEST['save']) || $context['do_preview']))
@@ -512,12 +524,14 @@  discard block
 block discarded – undo
512 524
 				}
513 525
 
514 526
 				// Does this require session validating?
515
-				if (!empty($area['validate']) || (isset($_REQUEST['save']) && !$context['user']['is_owner']))
516
-					$security_checks['validate'] = true;
527
+				if (!empty($area['validate']) || (isset($_REQUEST['save']) && !$context['user']['is_owner'])) {
528
+									$security_checks['validate'] = true;
529
+				}
517 530
 
518 531
 				// Permissions for good measure.
519
-				if (!empty($profile_include_data['permission']))
520
-					$security_checks['permission'] = $profile_include_data['permission'];
532
+				if (!empty($profile_include_data['permission'])) {
533
+									$security_checks['permission'] = $profile_include_data['permission'];
534
+				}
521 535
 
522 536
 				// Either way got something.
523 537
 				$found_area = true;
@@ -526,21 +540,26 @@  discard block
 block discarded – undo
526 540
 	}
527 541
 
528 542
 	// Oh dear, some serious security lapse is going on here... we'll put a stop to that!
529
-	if (!$found_area)
530
-		fatal_lang_error('no_access', false);
543
+	if (!$found_area) {
544
+			fatal_lang_error('no_access', false);
545
+	}
531 546
 
532 547
 	// Release this now.
533 548
 	unset($profile_areas);
534 549
 
535 550
 	// Now the context is setup have we got any security checks to carry out additional to that above?
536
-	if (isset($security_checks['session']))
537
-		checkSession($security_checks['session']);
538
-	if (isset($security_checks['validate']))
539
-		validateSession();
540
-	if (isset($security_checks['validateToken']))
541
-		validateToken($token_name, $token_type);
542
-	if (isset($security_checks['permission']))
543
-		isAllowedTo($security_checks['permission']);
551
+	if (isset($security_checks['session'])) {
552
+			checkSession($security_checks['session']);
553
+	}
554
+	if (isset($security_checks['validate'])) {
555
+			validateSession();
556
+	}
557
+	if (isset($security_checks['validateToken'])) {
558
+			validateToken($token_name, $token_type);
559
+	}
560
+	if (isset($security_checks['permission'])) {
561
+			isAllowedTo($security_checks['permission']);
562
+	}
544 563
 
545 564
 	// Create a token if needed.
546 565
 	if (isset($security_checks['needsToken']) || isset($security_checks['validateToken']))
@@ -550,8 +569,9 @@  discard block
 block discarded – undo
550 569
 	}
551 570
 
552 571
 	// File to include?
553
-	if (isset($profile_include_data['file']))
554
-		require_once($sourcedir . '/' . $profile_include_data['file']);
572
+	if (isset($profile_include_data['file'])) {
573
+			require_once($sourcedir . '/' . $profile_include_data['file']);
574
+	}
555 575
 
556 576
 	// Build the link tree.
557 577
 	$context['linktree'][] = array(
@@ -559,17 +579,19 @@  discard block
 block discarded – undo
559 579
 		'name' => sprintf($txt['profile_of_username'], $context['member']['name']),
560 580
 	);
561 581
 
562
-	if (!empty($profile_include_data['label']))
563
-		$context['linktree'][] = array(
582
+	if (!empty($profile_include_data['label'])) {
583
+			$context['linktree'][] = array(
564 584
 			'url' => $scripturl . '?action=profile' . ($memID != $user_info['id'] ? ';u=' . $memID : '') . ';area=' . $profile_include_data['current_area'],
565 585
 			'name' => $profile_include_data['label'],
566 586
 		);
587
+	}
567 588
 
568
-	if (!empty($profile_include_data['current_subsection']) && $profile_include_data['subsections'][$profile_include_data['current_subsection']][0] != $profile_include_data['label'])
569
-		$context['linktree'][] = array(
589
+	if (!empty($profile_include_data['current_subsection']) && $profile_include_data['subsections'][$profile_include_data['current_subsection']][0] != $profile_include_data['label']) {
590
+			$context['linktree'][] = array(
570 591
 			'url' => $scripturl . '?action=profile' . ($memID != $user_info['id'] ? ';u=' . $memID : '') . ';area=' . $profile_include_data['current_area'] . ';sa=' . $profile_include_data['current_subsection'],
571 592
 			'name' => $profile_include_data['subsections'][$profile_include_data['current_subsection']][0],
572 593
 		);
594
+	}
573 595
 
574 596
 	// Set the template for this area and add the profile layer.
575 597
 	$context['sub_template'] = $profile_include_data['function'];
@@ -595,12 +617,14 @@  discard block
 block discarded – undo
595 617
 		if ($check_password)
596 618
 		{
597 619
 			// Check to ensure we're forcing SSL for authentication
598
-			if (!empty($modSettings['force_ssl']) && empty($maintenance) && (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != 'on'))
599
-				fatal_lang_error('login_ssl_required');
620
+			if (!empty($modSettings['force_ssl']) && empty($maintenance) && (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != 'on')) {
621
+							fatal_lang_error('login_ssl_required');
622
+			}
600 623
 
601 624
 			// You didn't even enter a password!
602
-			if (trim($_POST['oldpasswrd']) == '')
603
-				$post_errors[] = 'no_password';
625
+			if (trim($_POST['oldpasswrd']) == '') {
626
+							$post_errors[] = 'no_password';
627
+			}
604 628
 
605 629
 			// Since the password got modified due to all the $_POST cleaning, lets undo it so we can get the correct password
606 630
 			$_POST['oldpasswrd'] = un_htmlspecialchars($_POST['oldpasswrd']);
@@ -609,33 +633,35 @@  discard block
 block discarded – undo
609 633
 			$good_password = in_array(true, call_integration_hook('integrate_verify_password', array($cur_profile['member_name'], $_POST['oldpasswrd'], false)), true);
610 634
 
611 635
 			// Bad password!!!
612
-			if (!$good_password && !hash_verify_password($user_profile[$memID]['member_name'], un_htmlspecialchars(stripslashes($_POST['oldpasswrd'])), $user_info['passwd']))
613
-				$post_errors[] = 'bad_password';
636
+			if (!$good_password && !hash_verify_password($user_profile[$memID]['member_name'], un_htmlspecialchars(stripslashes($_POST['oldpasswrd'])), $user_info['passwd'])) {
637
+							$post_errors[] = 'bad_password';
638
+			}
614 639
 
615 640
 			// Warn other elements not to jump the gun and do custom changes!
616
-			if (in_array('bad_password', $post_errors))
617
-				$context['password_auth_failed'] = true;
641
+			if (in_array('bad_password', $post_errors)) {
642
+							$context['password_auth_failed'] = true;
643
+			}
618 644
 		}
619 645
 
620 646
 		// Change the IP address in the database.
621
-		if ($context['user']['is_owner'])
622
-			$profile_vars['member_ip'] = $user_info['ip'];
647
+		if ($context['user']['is_owner']) {
648
+					$profile_vars['member_ip'] = $user_info['ip'];
649
+		}
623 650
 
624 651
 		// Now call the sub-action function...
625 652
 		if ($current_area == 'activateaccount')
626 653
 		{
627
-			if (empty($post_errors))
628
-				activateAccount($memID);
629
-		}
630
-		elseif ($current_area == 'deleteaccount')
654
+			if (empty($post_errors)) {
655
+							activateAccount($memID);
656
+			}
657
+		} elseif ($current_area == 'deleteaccount')
631 658
 		{
632 659
 			if (empty($post_errors))
633 660
 			{
634 661
 				deleteAccount2($memID);
635 662
 				redirectexit();
636 663
 			}
637
-		}
638
-		elseif ($current_area == 'groupmembership' && empty($post_errors))
664
+		} elseif ($current_area == 'groupmembership' && empty($post_errors))
639 665
 		{
640 666
 			$msg = groupMembership2($profile_vars, $post_errors, $memID);
641 667
 
@@ -646,10 +672,9 @@  discard block
 block discarded – undo
646 672
 		elseif ($current_area == 'authentication')
647 673
 		{
648 674
 			authentication($memID, true);
649
-		}
650
-		elseif (in_array($current_area, array('account', 'forumprofile', 'theme')))
651
-			saveProfileFields();
652
-		else
675
+		} elseif (in_array($current_area, array('account', 'forumprofile', 'theme'))) {
676
+					saveProfileFields();
677
+		} else
653 678
 		{
654 679
 			$force_redirect = true;
655 680
 			// Ensure we include this.
@@ -665,34 +690,36 @@  discard block
 block discarded – undo
665 690
 			// Load the language file so we can give a nice explanation of the errors.
666 691
 			loadLanguage('Errors');
667 692
 			$context['post_errors'] = $post_errors;
668
-		}
669
-		elseif (!empty($profile_vars))
693
+		} elseif (!empty($profile_vars))
670 694
 		{
671 695
 			// If we've changed the password, notify any integration that may be listening in.
672
-			if (isset($profile_vars['passwd']))
673
-				call_integration_hook('integrate_reset_pass', array($cur_profile['member_name'], $cur_profile['member_name'], $_POST['passwrd2']));
696
+			if (isset($profile_vars['passwd'])) {
697
+							call_integration_hook('integrate_reset_pass', array($cur_profile['member_name'], $cur_profile['member_name'], $_POST['passwrd2']));
698
+			}
674 699
 
675 700
 			updateMemberData($memID, $profile_vars);
676 701
 
677 702
 			// What if this is the newest member?
678
-			if ($modSettings['latestMember'] == $memID)
679
-				updateStats('member');
680
-			elseif (isset($profile_vars['real_name']))
681
-				updateSettings(array('memberlist_updated' => time()));
703
+			if ($modSettings['latestMember'] == $memID) {
704
+							updateStats('member');
705
+			} elseif (isset($profile_vars['real_name'])) {
706
+							updateSettings(array('memberlist_updated' => time()));
707
+			}
682 708
 
683 709
 			// If the member changed his/her birthdate, update calendar statistics.
684
-			if (isset($profile_vars['birthdate']) || isset($profile_vars['real_name']))
685
-				updateSettings(array(
710
+			if (isset($profile_vars['birthdate']) || isset($profile_vars['real_name'])) {
711
+							updateSettings(array(
686 712
 					'calendar_updated' => time(),
687 713
 				));
714
+			}
688 715
 
689 716
 			// Anything worth logging?
690 717
 			if (!empty($context['log_changes']) && !empty($modSettings['modlog_enabled']))
691 718
 			{
692 719
 				$log_changes = array();
693 720
 				require_once($sourcedir . '/Logging.php');
694
-				foreach ($context['log_changes'] as $k => $v)
695
-					$log_changes[] = array(
721
+				foreach ($context['log_changes'] as $k => $v) {
722
+									$log_changes[] = array(
696 723
 						'action' => $k,
697 724
 						'log_type' => 'user',
698 725
 						'extra' => array_merge($v, array(
@@ -700,14 +727,16 @@  discard block
 block discarded – undo
700 727
 							'member_affected' => $memID,
701 728
 						)),
702 729
 					);
730
+				}
703 731
 
704 732
 				logActions($log_changes);
705 733
 			}
706 734
 
707 735
 			// Have we got any post save functions to execute?
708
-			if (!empty($context['profile_execute_on_save']))
709
-				foreach ($context['profile_execute_on_save'] as $saveFunc)
736
+			if (!empty($context['profile_execute_on_save'])) {
737
+							foreach ($context['profile_execute_on_save'] as $saveFunc)
710 738
 					$saveFunc();
739
+			}
711 740
 
712 741
 			// Let them know it worked!
713 742
 			$context['profile_updated'] = $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $cur_profile['member_name']);
@@ -721,27 +750,31 @@  discard block
 block discarded – undo
721 750
 	if (!empty($post_errors))
722 751
 	{
723 752
 		// Set all the errors so the template knows what went wrong.
724
-		foreach ($post_errors as $error_type)
725
-			$context['modify_error'][$error_type] = true;
753
+		foreach ($post_errors as $error_type) {
754
+					$context['modify_error'][$error_type] = true;
755
+		}
726 756
 	}
727 757
 	// If it's you then we should redirect upon save.
728
-	elseif (!empty($profile_vars) && $context['user']['is_owner'] && !$context['do_preview'])
729
-		redirectexit('action=profile;area=' . $current_area . (!empty($current_sa) ? ';sa=' . $current_sa : '') . ';updated');
730
-	elseif (!empty($force_redirect))
731
-		redirectexit('action=profile' . ($context['user']['is_owner'] ? '' : ';u=' . $memID) . ';area=' . $current_area);
758
+	elseif (!empty($profile_vars) && $context['user']['is_owner'] && !$context['do_preview']) {
759
+			redirectexit('action=profile;area=' . $current_area . (!empty($current_sa) ? ';sa=' . $current_sa : '') . ';updated');
760
+	} elseif (!empty($force_redirect)) {
761
+			redirectexit('action=profile' . ($context['user']['is_owner'] ? '' : ';u=' . $memID) . ';area=' . $current_area);
762
+	}
732 763
 
733 764
 
734 765
 	// Get the right callable.
735 766
 	$call = call_helper($profile_include_data['function'], true);
736 767
 
737 768
 	// Is it valid?
738
-	if (!empty($call))
739
-		call_user_func($call, $memID);
769
+	if (!empty($call)) {
770
+			call_user_func($call, $memID);
771
+	}
740 772
 
741 773
 	// Set the page title if it's not already set...
742
-	if (!isset($context['page_title']))
743
-		$context['page_title'] = $txt['profile'] . (isset($txt[$current_area]) ? ' - ' . $txt[$current_area] : '');
744
-}
774
+	if (!isset($context['page_title'])) {
775
+			$context['page_title'] = $txt['profile'] . (isset($txt[$current_area]) ? ' - ' . $txt[$current_area] : '');
776
+	}
777
+	}
745 778
 
746 779
 /**
747 780
  * Set up the requirements for the profile popup - the area that is shown as the popup menu for the current user.
@@ -864,16 +897,18 @@  discard block
 block discarded – undo
864 897
 	if (!allowedTo('admin_forum') && $area != 'register')
865 898
 	{
866 899
 		// If it's the owner they can see two types of private fields, regardless.
867
-		if ($memID == $user_info['id'])
868
-			$where .= $area == 'summary' ? ' AND private < 3' : ' AND (private = 0 OR private = 2)';
869
-		else
870
-			$where .= $area == 'summary' ? ' AND private < 2' : ' AND private = 0';
900
+		if ($memID == $user_info['id']) {
901
+					$where .= $area == 'summary' ? ' AND private < 3' : ' AND (private = 0 OR private = 2)';
902
+		} else {
903
+					$where .= $area == 'summary' ? ' AND private < 2' : ' AND private = 0';
904
+		}
871 905
 	}
872 906
 
873
-	if ($area == 'register')
874
-		$where .= ' AND show_reg != 0';
875
-	elseif ($area != 'summary')
876
-		$where .= ' AND show_profile = {string:area}';
907
+	if ($area == 'register') {
908
+			$where .= ' AND show_reg != 0';
909
+	} elseif ($area != 'summary') {
910
+			$where .= ' AND show_profile = {string:area}';
911
+	}
877 912
 
878 913
 	// Load all the relevant fields - and data.
879 914
 	$request = $smcFunc['db_query']('', '
@@ -899,13 +934,15 @@  discard block
 block discarded – undo
899 934
 		if (isset($_POST['customfield']) && isset($_POST['customfield'][$row['col_name']]))
900 935
 		{
901 936
 			$value = $smcFunc['htmlspecialchars']($_POST['customfield'][$row['col_name']]);
902
-			if (in_array($row['field_type'], array('select', 'radio')))
903
-					$value = ($options = explode(',', $row['field_options'])) && isset($options[$value]) ? $options[$value] : '';
937
+			if (in_array($row['field_type'], array('select', 'radio'))) {
938
+								$value = ($options = explode(',', $row['field_options'])) && isset($options[$value]) ? $options[$value] : '';
939
+			}
904 940
 		}
905 941
 
906 942
 		// Don't show the "disabled" option for the "gender" field if we are on the "summary" area.
907
-		if ($area == 'summary' && $row['col_name'] == 'cust_gender' && $value == 'Disabled')
908
-			continue;
943
+		if ($area == 'summary' && $row['col_name'] == 'cust_gender' && $value == 'Disabled') {
944
+					continue;
945
+		}
909 946
 
910 947
 		// HTML for the input form.
911 948
 		$output_html = $value;
@@ -914,8 +951,7 @@  discard block
 block discarded – undo
914 951
 			$true = (!$exists && $row['default_value']) || $value;
915 952
 			$input_html = '<input type="checkbox" name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"' . ($true ? ' checked' : '') . '>';
916 953
 			$output_html = $true ? $txt['yes'] : $txt['no'];
917
-		}
918
-		elseif ($row['field_type'] == 'select')
954
+		} elseif ($row['field_type'] == 'select')
919 955
 		{
920 956
 			$input_html = '<select name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"><option value="-1"></option>';
921 957
 			$options = explode(',', $row['field_options']);
@@ -923,13 +959,13 @@  discard block
 block discarded – undo
923 959
 			{
924 960
 				$true = (!$exists && $row['default_value'] == $v) || $value == $v;
925 961
 				$input_html .= '<option value="' . $k . '"' . ($true ? ' selected' : '') . '>' . $v . '</option>';
926
-				if ($true)
927
-					$output_html = $v;
962
+				if ($true) {
963
+									$output_html = $v;
964
+				}
928 965
 			}
929 966
 
930 967
 			$input_html .= '</select>';
931
-		}
932
-		elseif ($row['field_type'] == 'radio')
968
+		} elseif ($row['field_type'] == 'radio')
933 969
 		{
934 970
 			$input_html = '<fieldset>';
935 971
 			$options = explode(',', $row['field_options']);
@@ -937,36 +973,37 @@  discard block
 block discarded – undo
937 973
 			{
938 974
 				$true = (!$exists && $row['default_value'] == $v) || $value == $v;
939 975
 				$input_html .= '<label for="customfield_' . $row['col_name'] . '_' . $k . '"><input type="radio" name="customfield[' . $row['col_name'] . ']" id="customfield_' . $row['col_name'] . '_' . $k . '" value="' . $k . '"' . ($true ? ' checked' : '') . '>' . $v . '</label><br>';
940
-				if ($true)
941
-					$output_html = $v;
976
+				if ($true) {
977
+									$output_html = $v;
978
+				}
942 979
 			}
943 980
 			$input_html .= '</fieldset>';
944
-		}
945
-		elseif ($row['field_type'] == 'text')
981
+		} elseif ($row['field_type'] == 'text')
946 982
 		{
947 983
 			$input_html = '<input type="text" name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"' . ($row['field_length'] != 0 ? ' maxlength="' . $row['field_length'] . '"' : '') . ' size="' . ($row['field_length'] == 0 || $row['field_length'] >= 50 ? 50 : ($row['field_length'] > 30 ? 30 : ($row['field_length'] > 10 ? 20 : 10))) . '" value="' . un_htmlspecialchars($value) . '"' . ($row['show_reg'] == 2 ? ' required' : '') . '>';
948
-		}
949
-		else
984
+		} else
950 985
 		{
951 986
 			@list ($rows, $cols) = @explode(',', $row['default_value']);
952 987
 			$input_html = '<textarea name="customfield[' . $row['col_name'] . ']" id="customfield[' . $row['col_name'] . ']"' . (!empty($rows) ? ' rows="' . $rows . '"' : '') . (!empty($cols) ? ' cols="' . $cols . '"' : '') . ($row['show_reg'] == 2 ? ' required' : '') . '>' . un_htmlspecialchars($value) . '</textarea>';
953 988
 		}
954 989
 
955 990
 		// Parse BBCode
956
-		if ($row['bbc'])
957
-			$output_html = parse_bbc($output_html);
958
-		elseif ($row['field_type'] == 'textarea')
959
-			// Allow for newlines at least
991
+		if ($row['bbc']) {
992
+					$output_html = parse_bbc($output_html);
993
+		} elseif ($row['field_type'] == 'textarea') {
994
+					// Allow for newlines at least
960 995
 			$output_html = strtr($output_html, array("\n" => '<br>'));
996
+		}
961 997
 
962 998
 		// Enclosing the user input within some other text?
963
-		if (!empty($row['enclose']) && !empty($output_html))
964
-			$output_html = strtr($row['enclose'], array(
999
+		if (!empty($row['enclose']) && !empty($output_html)) {
1000
+					$output_html = strtr($row['enclose'], array(
965 1001
 				'{SCRIPTURL}' => $scripturl,
966 1002
 				'{IMAGES_URL}' => $settings['images_url'],
967 1003
 				'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
968 1004
 				'{INPUT}' => un_htmlspecialchars($output_html),
969 1005
 			));
1006
+		}
970 1007
 
971 1008
 		$context['custom_fields'][] = array(
972 1009
 			'name' => $row['field_name'],
Please login to merge, or discard this patch.
Sources/Modlog.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
 					'class' => 'centercol',
257 257
 				),
258 258
 				'data' => array(
259
-					'function' => function ($entry)
259
+					'function' => function($entry)
260 260
 					{
261 261
 						return '<input type="checkbox" name="delete[]" value="' . $entry['id'] . '"' . ($entry['editable'] ? '' : ' disabled') . '>';
262 262
 					},
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 		if (empty($entries[$k]['action_text']))
639 639
 			$entries[$k]['action_text'] = isset($txt['modlog_ac_' . $entry['action']]) ? $txt['modlog_ac_' . $entry['action']] : $entry['action'];
640 640
 		$entries[$k]['action_text'] = preg_replace_callback('~\{([A-Za-z\d_]+)\}~i',
641
-			function ($matches) use ($entries, $k)
641
+			function($matches) use ($entries, $k)
642 642
 			{
643 643
 				return isset($entries[$k]['extra'][$matches[1]]) ? $entries[$k]['extra'][$matches[1]] : '';
644 644
 			}, $entries[$k]['action_text']);
Please login to merge, or discard this patch.
Sources/Subscriptions-PayPal.php 1 patch
Braces   +83 added lines, -61 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
 // This won't be dedicated without this - this must exist in each gateway!
15 15
 // SMF Payment Gateway: paypal
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Class for returning available form data for this gateway
@@ -118,8 +119,7 @@  discard block
 block discarded – undo
118 119
 		{
119 120
 			$return_data['hidden']['p3'] = 1;
120 121
 			$return_data['hidden']['t3'] = strtoupper(substr($period, 0, 1));
121
-		}
122
-		else
122
+		} else
123 123
 		{
124 124
 			preg_match('~(\d*)(\w)~', $sub_data['real_length'], $match);
125 125
 			$unit = $match[1];
@@ -130,14 +130,15 @@  discard block
 block discarded – undo
130 130
 		}
131 131
 
132 132
 		// If it's repeatable do some javascript to respect this idea.
133
-		if (!empty($sub_data['repeatable']))
134
-			$return_data['javascript'] = '
133
+		if (!empty($sub_data['repeatable'])) {
134
+					$return_data['javascript'] = '
135 135
 				document.write(\'<label for="do_paypal_recur"><input type="checkbox" name="do_paypal_recur" id="do_paypal_recur" checked onclick="switchPaypalRecur();">' . $txt['paid_make_recurring'] . '</label><br>\');
136 136
 
137 137
 				function switchPaypalRecur()
138 138
 				{
139 139
 					document.getElementById("paypal_cmd").value = document.getElementById("do_paypal_recur").checked ? "_xclick-subscriptions" : "_xclick";
140 140
 				}';
141
+		}
141 142
 
142 143
 		return $return_data;
143 144
 	}
@@ -160,20 +161,24 @@  discard block
 block discarded – undo
160 161
 		global $modSettings;
161 162
 
162 163
 		// Has the user set up an email address?
163
-		if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email'])))
164
-			return false;
164
+		if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) {
165
+					return false;
166
+		}
165 167
 		// Check the correct transaction types are even here.
166
-		if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email'])))
167
-			return false;
168
+		if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) {
169
+					return false;
170
+		}
168 171
 		// Correct email address?
169
-		if (!isset($_POST['business']))
170
-			$_POST['business'] = $_POST['receiver_email'];
172
+		if (!isset($_POST['business'])) {
173
+					$_POST['business'] = $_POST['receiver_email'];
174
+		}
171 175
 
172 176
 		// Are we testing?
173
-		if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails'])))))
174
-			return false;
175
-		elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails']))))
176
-			return false;
177
+		if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) {
178
+					return false;
179
+		} elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) {
180
+					return false;
181
+		}
177 182
 		return true;
178 183
 	}
179 184
 
@@ -192,15 +197,17 @@  discard block
 block discarded – undo
192 197
 		global $modSettings, $txt;
193 198
 
194 199
 		// Put this to some default value.
195
-		if (!isset($_POST['txn_type']))
196
-			$_POST['txn_type'] = '';
200
+		if (!isset($_POST['txn_type'])) {
201
+					$_POST['txn_type'] = '';
202
+		}
197 203
 
198 204
 		// Build the request string - starting with the minimum requirement.
199 205
 		$requestString = 'cmd=_notify-validate';
200 206
 
201 207
 		// Now my dear, add all the posted bits in the order we got them
202
-		foreach ($_POST as $k => $v)
203
-			$requestString .= '&' . $k . '=' . urlencode($v);
208
+		foreach ($_POST as $k => $v) {
209
+					$requestString .= '&' . $k . '=' . urlencode($v);
210
+		}
204 211
 
205 212
 		// Can we use curl?
206 213
 		if (function_exists('curl_init') && $curl = curl_init((!empty($modSettings['paidsubs_test']) ? 'https://www.sandbox.' : 'https://www.') . 'paypal.com/cgi-bin/webscr'))
@@ -240,14 +247,16 @@  discard block
 block discarded – undo
240 247
 			$header .= 'Connection: close' . "\r\n\r\n";
241 248
 
242 249
 			// Open the connection.
243
-			if (!empty($modSettings['paidsubs_test']))
244
-				$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
245
-			else
246
-				$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
250
+			if (!empty($modSettings['paidsubs_test'])) {
251
+							$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
252
+			} else {
253
+							$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
254
+			}
247 255
 
248 256
 			// Did it work?
249
-			if (!$fp)
250
-				generateSubscriptionError($txt['paypal_could_not_connect']);
257
+			if (!$fp) {
258
+							generateSubscriptionError($txt['paypal_could_not_connect']);
259
+			}
251 260
 
252 261
 			// Put the data to the port.
253 262
 			fputs($fp, $header . $requestString);
@@ -256,8 +265,9 @@  discard block
 block discarded – undo
256 265
 			while (!feof($fp))
257 266
 			{
258 267
 				$this->return_data = fgets($fp, 1024);
259
-				if (strcmp(trim($this->return_data), 'VERIFIED') === 0)
260
-					break;
268
+				if (strcmp(trim($this->return_data), 'VERIFIED') === 0) {
269
+									break;
270
+				}
261 271
 			}
262 272
 
263 273
 			// Clean up.
@@ -265,28 +275,34 @@  discard block
 block discarded – undo
265 275
 		}
266 276
 
267 277
 		// If this isn't verified then give up...
268
-		if (strcmp(trim($this->return_data), 'VERIFIED') !== 0)
269
-			exit;
278
+		if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) {
279
+					exit;
280
+		}
270 281
 
271 282
 		// Check that this is intended for us.
272
-		if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails'])))))
273
-			exit;
283
+		if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) {
284
+					exit;
285
+		}
274 286
 
275 287
 		// Is this a subscription - and if so is it a secondary payment that we need to process?
276 288
 		// If so, make sure we get it in the expected format. Seems PayPal sometimes sends it without urlencoding.
277
-		if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false)
278
-			$_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']);
279
-		if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false))
280
-			// Calculate the subscription it relates to!
289
+		if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) {
290
+					$_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']);
291
+		}
292
+		if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) {
293
+					// Calculate the subscription it relates to!
281 294
 			$this->_findSubscription();
295
+		}
282 296
 
283 297
 		// Verify the currency!
284
-		if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code']))
285
-			exit;
298
+		if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) {
299
+					exit;
300
+		}
286 301
 
287 302
 		// Can't exist if it doesn't contain anything.
288
-		if (empty($_POST['item_number']))
289
-			exit;
303
+		if (empty($_POST['item_number'])) {
304
+					exit;
305
+		}
290 306
 
291 307
 		// Return the id_sub and id_member
292 308
 		return explode('+', $_POST['item_number']);
@@ -299,10 +315,11 @@  discard block
 block discarded – undo
299 315
 	 */
300 316
 	public function isRefund()
301 317
 	{
302
-		if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed'))
303
-			return true;
304
-		else
305
-			return false;
318
+		if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) {
319
+					return true;
320
+		} else {
321
+					return false;
322
+		}
306 323
 	}
307 324
 
308 325
 	/**
@@ -312,10 +329,11 @@  discard block
 block discarded – undo
312 329
 	 */
313 330
 	public function isSubscription()
314 331
 	{
315
-		if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed')
316
-			return true;
317
-		else
318
-			return false;
332
+		if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') {
333
+					return true;
334
+		} else {
335
+					return false;
336
+		}
319 337
 	}
320 338
 
321 339
 	/**
@@ -325,10 +343,11 @@  discard block
 block discarded – undo
325 343
 	 */
326 344
 	public function isPayment()
327 345
 	{
328
-		if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept')
329
-			return true;
330
-		else
331
-			return false;
346
+		if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') {
347
+					return true;
348
+		} else {
349
+					return false;
350
+		}
332 351
 	}
333 352
 
334 353
 	/**
@@ -341,10 +360,11 @@  discard block
 block discarded – undo
341 360
 		// subscr_cancel is sent when the user cancels, subscr_eot is sent when the subscription reaches final payment
342 361
 		// Neither require us to *do* anything as per performCancel().
343 362
 		// subscr_eot, if sent, indicates an end of payments term.
344
-		if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot')
345
-			return true;
346
-		else
347
-			return false;
363
+		if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') {
364
+					return true;
365
+		} else {
366
+					return false;
367
+		}
348 368
 	}
349 369
 
350 370
 	/**
@@ -408,8 +428,9 @@  discard block
 block discarded – undo
408 428
 		global $smcFunc;
409 429
 
410 430
 		// Assume we have this?
411
-		if (empty($_POST['subscr_id']))
412
-			return false;
431
+		if (empty($_POST['subscr_id'])) {
432
+					return false;
433
+		}
413 434
 
414 435
 		// Do we have this in the database?
415 436
 		$request = $smcFunc['db_query']('', '
@@ -438,11 +459,12 @@  discard block
 block discarded – undo
438 459
 						'payer_email' => $_POST['payer_email'],
439 460
 					)
440 461
 				);
441
-				if ($smcFunc['db_num_rows']($request) === 0)
442
-					return false;
462
+				if ($smcFunc['db_num_rows']($request) === 0) {
463
+									return false;
464
+				}
465
+			} else {
466
+							return false;
443 467
 			}
444
-			else
445
-				return false;
446 468
 		}
447 469
 		list ($member_id, $subscription_id) = $smcFunc['db_fetch_row']($request);
448 470
 		$_POST['item_number'] = $member_id . '+' . $subscription_id;
Please login to merge, or discard this patch.
other/install.php 1 patch
Braces   +447 added lines, -332 removed lines patch added patch discarded remove patch
@@ -20,8 +20,9 @@  discard block
 block discarded – undo
20 20
 // ><html dir="ltr"><head><title>Error!</title></head><body>Sorry, this installer requires PHP!<div style="display: none;">
21 21
 
22 22
 // Let's pull in useful classes
23
-if (!defined('SMF'))
23
+if (!defined('SMF')) {
24 24
 	define('SMF', 1);
25
+}
25 26
 
26 27
 require_once('Sources/Class-Package.php');
27 28
 
@@ -63,10 +64,11 @@  discard block
 block discarded – undo
63 64
 
64 65
 			list ($charcode) = pg_fetch_row($request);
65 66
 
66
-			if ($charcode == 'UTF8')
67
-				return true;
68
-			else
69
-				return false;
67
+			if ($charcode == 'UTF8') {
68
+							return true;
69
+			} else {
70
+							return false;
71
+			}
70 72
 		},
71 73
 		'utf8_version' => '8.0',
72 74
 		'utf8_version_check' => '$request = pg_query(\'SELECT version()\'); list ($version) = pg_fetch_row($request); list($pgl, $version) = explode(" ", $version); return $version;',
@@ -76,12 +78,14 @@  discard block
 block discarded – undo
76 78
 			$value = preg_replace('~[^A-Za-z0-9_\$]~', '', $value);
77 79
 
78 80
 			// Is it reserved?
79
-			if ($value == 'pg_')
80
-				return $txt['error_db_prefix_reserved'];
81
+			if ($value == 'pg_') {
82
+							return $txt['error_db_prefix_reserved'];
83
+			}
81 84
 
82 85
 			// Is the prefix numeric?
83
-			if (preg_match('~^\d~', $value))
84
-				return $txt['error_db_prefix_numeric'];
86
+			if (preg_match('~^\d~', $value)) {
87
+							return $txt['error_db_prefix_numeric'];
88
+			}
85 89
 
86 90
 			return true;
87 91
 		},
@@ -128,10 +132,11 @@  discard block
 block discarded – undo
128 132
 		$incontext['skip'] = false;
129 133
 
130 134
 		// Call the step and if it returns false that means pause!
131
-		if (function_exists($step[2]) && $step[2]() === false)
132
-			break;
133
-		elseif (function_exists($step[2]))
134
-			$incontext['current_step']++;
135
+		if (function_exists($step[2]) && $step[2]() === false) {
136
+					break;
137
+		} elseif (function_exists($step[2])) {
138
+					$incontext['current_step']++;
139
+		}
135 140
 
136 141
 		// No warnings pass on.
137 142
 		$incontext['warning'] = '';
@@ -147,8 +152,9 @@  discard block
 block discarded – undo
147 152
 	global $databases;
148 153
 
149 154
 	// Just so people using older versions of PHP aren't left in the cold.
150
-	if (!isset($_SERVER['PHP_SELF']))
151
-		$_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php';
155
+	if (!isset($_SERVER['PHP_SELF'])) {
156
+			$_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php';
157
+	}
152 158
 
153 159
 	// Enable error reporting.
154 160
 	error_reporting(E_ALL);
@@ -164,21 +170,23 @@  discard block
 block discarded – undo
164 170
 	{
165 171
 		ob_start();
166 172
 
167
-		if (ini_get('session.save_handler') == 'user')
168
-			@ini_set('session.save_handler', 'files');
169
-		if (function_exists('session_start'))
170
-			@session_start();
171
-	}
172
-	else
173
+		if (ini_get('session.save_handler') == 'user') {
174
+					@ini_set('session.save_handler', 'files');
175
+		}
176
+		if (function_exists('session_start')) {
177
+					@session_start();
178
+		}
179
+	} else
173 180
 	{
174 181
 		ob_start('ob_gzhandler');
175 182
 
176
-		if (ini_get('session.save_handler') == 'user')
177
-			@ini_set('session.save_handler', 'files');
183
+		if (ini_get('session.save_handler') == 'user') {
184
+					@ini_set('session.save_handler', 'files');
185
+		}
178 186
 		session_start();
179 187
 
180
-		if (!headers_sent())
181
-			echo '<!DOCTYPE html>
188
+		if (!headers_sent()) {
189
+					echo '<!DOCTYPE html>
182 190
 <html>
183 191
 	<head>
184 192
 		<title>', htmlspecialchars($_GET['pass_string']), '</title>
@@ -187,14 +195,16 @@  discard block
 block discarded – undo
187 195
 		<strong>', htmlspecialchars($_GET['pass_string']), '</strong>
188 196
 	</body>
189 197
 </html>';
198
+		}
190 199
 		exit;
191 200
 	}
192 201
 
193 202
 	// Add slashes, as long as they aren't already being added.
194
-	if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0)
195
-		foreach ($_POST as $k => $v)
203
+	if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) {
204
+			foreach ($_POST as $k => $v)
196 205
 			if (strpos($k, 'password') === false && strpos($k, 'db_passwd') === false)
197 206
 				$_POST[$k] = addslashes($v);
207
+	}
198 208
 
199 209
 	// This is really quite simple; if ?delete is on the URL, delete the installer...
200 210
 	if (isset($_GET['delete']))
@@ -215,8 +225,7 @@  discard block
 block discarded – undo
215 225
 			$ftp->close();
216 226
 
217 227
 			unset($_SESSION['installer_temp_ftp']);
218
-		}
219
-		else
228
+		} else
220 229
 		{
221 230
 			@unlink(__FILE__);
222 231
 
@@ -237,10 +246,11 @@  discard block
 block discarded – undo
237 246
 	{
238 247
 		// Get PHP's default timezone, if set
239 248
 		$ini_tz = ini_get('date.timezone');
240
-		if (!empty($ini_tz))
241
-			$timezone_id = $ini_tz;
242
-		else
243
-			$timezone_id = '';
249
+		if (!empty($ini_tz)) {
250
+					$timezone_id = $ini_tz;
251
+		} else {
252
+					$timezone_id = '';
253
+		}
244 254
 
245 255
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
246 256
 		if (!in_array($timezone_id, timezone_identifiers_list()))
@@ -270,8 +280,9 @@  discard block
 block discarded – undo
270 280
 		$dir = dir(dirname(__FILE__) . '/Themes/default/languages');
271 281
 		while ($entry = $dir->read())
272 282
 		{
273
-			if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php')
274
-				$incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12));
283
+			if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') {
284
+							$incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12));
285
+			}
275 286
 		}
276 287
 		$dir->close();
277 288
 	}
@@ -306,10 +317,11 @@  discard block
 block discarded – undo
306 317
 	}
307 318
 
308 319
 	// Override the language file?
309
-	if (isset($_GET['lang_file']))
310
-		$_SESSION['installer_temp_lang'] = $_GET['lang_file'];
311
-	elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file']))
312
-		$_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file'];
320
+	if (isset($_GET['lang_file'])) {
321
+			$_SESSION['installer_temp_lang'] = $_GET['lang_file'];
322
+	} elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) {
323
+			$_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file'];
324
+	}
313 325
 
314 326
 	// Make sure it exists, if it doesn't reset it.
315 327
 	if (!isset($_SESSION['installer_temp_lang']) || preg_match('~[^\\w_\\-.]~', $_SESSION['installer_temp_lang']) === 1 || !file_exists(dirname(__FILE__) . '/Themes/default/languages/' . $_SESSION['installer_temp_lang']))
@@ -318,8 +330,9 @@  discard block
 block discarded – undo
318 330
 		list ($_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
319 331
 
320 332
 		// If we have english and some other language, use the other language.  We Americans hate english :P.
321
-		if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1)
322
-			list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
333
+		if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) {
334
+					list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']);
335
+		}
323 336
 	}
324 337
 
325 338
 	// And now include the actual language file itself.
@@ -332,15 +345,18 @@  discard block
 block discarded – undo
332 345
 	global $db_prefix, $db_connection, $sourcedir, $smcFunc, $modSettings;
333 346
 	global $db_server, $db_passwd, $db_type, $db_name, $db_user, $db_persist;
334 347
 
335
-	if (empty($sourcedir))
336
-		$sourcedir = dirname(__FILE__) . '/Sources';
348
+	if (empty($sourcedir)) {
349
+			$sourcedir = dirname(__FILE__) . '/Sources';
350
+	}
337 351
 
338 352
 	// Need this to check whether we need the database password.
339 353
 	require(dirname(__FILE__) . '/Settings.php');
340
-	if (!defined('SMF'))
341
-		define('SMF', 1);
342
-	if (empty($smcFunc))
343
-		$smcFunc = array();
354
+	if (!defined('SMF')) {
355
+			define('SMF', 1);
356
+	}
357
+	if (empty($smcFunc)) {
358
+			$smcFunc = array();
359
+	}
344 360
 
345 361
 	$modSettings['disableQueryCheck'] = true;
346 362
 
@@ -348,8 +364,9 @@  discard block
 block discarded – undo
348 364
 	if (!$db_connection)
349 365
 	{
350 366
 		require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
351
-		if (version_compare(PHP_VERSION, '5', '<'))
352
-			require_once($sourcedir . '/Subs-Compat.php');
367
+		if (version_compare(PHP_VERSION, '5', '<')) {
368
+					require_once($sourcedir . '/Subs-Compat.php');
369
+		}
353 370
 
354 371
 		$db_options = array('persist' => $db_persist);
355 372
 		$port = '';
@@ -360,19 +377,20 @@  discard block
 block discarded – undo
360 377
 			if ($db_type == 'mysql')
361 378
 			{
362 379
 				$port = ((int) $_POST['db_port'] == ini_get($db_type . 'default_port')) ? '' : (int) $_POST['db_port'];
363
-			}
364
-			elseif ($db_type == 'postgresql')
380
+			} elseif ($db_type == 'postgresql')
365 381
 			{
366 382
 				// PostgreSQL doesn't have a default port setting in php.ini, so just check against the default
367 383
 				$port = ((int) $_POST['db_port'] == 5432) ? '' : (int) $_POST['db_port'];
368 384
 			}
369 385
 		}
370 386
 
371
-		if (!empty($port))
372
-			$db_options['port'] = $port;
387
+		if (!empty($port)) {
388
+					$db_options['port'] = $port;
389
+		}
373 390
 
374
-		if (!$db_connection)
375
-			$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options);
391
+		if (!$db_connection) {
392
+					$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options);
393
+		}
376 394
 	}
377 395
 }
378 396
 
@@ -400,8 +418,9 @@  discard block
 block discarded – undo
400 418
 		// @todo REMOVE THIS!!
401 419
 		else
402 420
 		{
403
-			if (function_exists('doStep' . $_GET['step']))
404
-				call_user_func('doStep' . $_GET['step']);
421
+			if (function_exists('doStep' . $_GET['step'])) {
422
+							call_user_func('doStep' . $_GET['step']);
423
+			}
405 424
 		}
406 425
 		// Show the footer.
407 426
 		template_install_below();
@@ -419,8 +438,9 @@  discard block
 block discarded – undo
419 438
 	$incontext['sub_template'] = 'welcome_message';
420 439
 
421 440
 	// Done the submission?
422
-	if (isset($_POST['contbutt']))
423
-		return true;
441
+	if (isset($_POST['contbutt'])) {
442
+			return true;
443
+	}
424 444
 
425 445
 	// See if we think they have already installed it?
426 446
 	if (is_readable(dirname(__FILE__) . '/Settings.php'))
@@ -428,14 +448,17 @@  discard block
 block discarded – undo
428 448
 		$probably_installed = 0;
429 449
 		foreach (file(dirname(__FILE__) . '/Settings.php') as $line)
430 450
 		{
431
-			if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line))
432
-				$probably_installed++;
433
-			if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line))
434
-				$probably_installed++;
451
+			if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) {
452
+							$probably_installed++;
453
+			}
454
+			if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) {
455
+							$probably_installed++;
456
+			}
435 457
 		}
436 458
 
437
-		if ($probably_installed == 2)
438
-			$incontext['warning'] = $txt['error_already_installed'];
459
+		if ($probably_installed == 2) {
460
+					$incontext['warning'] = $txt['error_already_installed'];
461
+		}
439 462
 	}
440 463
 
441 464
 	// Is some database support even compiled in?
@@ -450,45 +473,54 @@  discard block
 block discarded – undo
450 473
 				$databases[$key]['supported'] = false;
451 474
 				$notFoundSQLFile = true;
452 475
 				$txt['error_db_script_missing'] = sprintf($txt['error_db_script_missing'], 'install_' . $GLOBALS['db_script_version'] . '_' . $type . '.sql');
476
+			} else {
477
+							$incontext['supported_databases'][] = $db;
453 478
 			}
454
-			else
455
-				$incontext['supported_databases'][] = $db;
456 479
 		}
457 480
 	}
458 481
 
459 482
 	// Check the PHP version.
460
-	if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>=')))
461
-		$error = 'error_php_too_low';
483
+	if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>='))) {
484
+			$error = 'error_php_too_low';
485
+	}
462 486
 	// Make sure we have a supported database
463
-	elseif (empty($incontext['supported_databases']))
464
-		$error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing';
487
+	elseif (empty($incontext['supported_databases'])) {
488
+			$error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing';
489
+	}
465 490
 	// How about session support?  Some crazy sysadmin remove it?
466
-	elseif (!function_exists('session_start'))
467
-		$error = 'error_session_missing';
491
+	elseif (!function_exists('session_start')) {
492
+			$error = 'error_session_missing';
493
+	}
468 494
 	// Make sure they uploaded all the files.
469
-	elseif (!file_exists(dirname(__FILE__) . '/index.php'))
470
-		$error = 'error_missing_files';
495
+	elseif (!file_exists(dirname(__FILE__) . '/index.php')) {
496
+			$error = 'error_missing_files';
497
+	}
471 498
 	// Very simple check on the session.save_path for Windows.
472 499
 	// @todo Move this down later if they don't use database-driven sessions?
473
-	elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\')
474
-		$error = 'error_session_save_path';
500
+	elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') {
501
+			$error = 'error_session_save_path';
502
+	}
475 503
 
476 504
 	// Since each of the three messages would look the same, anyway...
477
-	if (isset($error))
478
-		$incontext['error'] = $txt[$error];
505
+	if (isset($error)) {
506
+			$incontext['error'] = $txt[$error];
507
+	}
479 508
 
480 509
 	// Mod_security blocks everything that smells funny. Let SMF handle security.
481
-	if (!fixModSecurity() && !isset($_GET['overmodsecurity']))
482
-		$incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again'];
510
+	if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) {
511
+			$incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again'];
512
+	}
483 513
 
484 514
 	// Confirm mbstring is loaded...
485
-	if (!extension_loaded('mbstring'))
486
-		$incontext['error'] = $txt['install_no_mbstring'];
515
+	if (!extension_loaded('mbstring')) {
516
+			$incontext['error'] = $txt['install_no_mbstring'];
517
+	}
487 518
 
488 519
 	// Check for https stream support.
489 520
 	$supported_streams = stream_get_wrappers();
490
-	if (!in_array('https', $supported_streams))
491
-		$incontext['warning'] = $txt['install_no_https'];
521
+	if (!in_array('https', $supported_streams)) {
522
+			$incontext['warning'] = $txt['install_no_https'];
523
+	}
492 524
 
493 525
 	return false;
494 526
 }
@@ -514,12 +546,14 @@  discard block
 block discarded – undo
514 546
 		'db_last_error.php',
515 547
 	);
516 548
 
517
-	foreach ($incontext['detected_languages'] as $lang => $temp)
518
-		$extra_files[] = 'Themes/default/languages/' . $lang;
549
+	foreach ($incontext['detected_languages'] as $lang => $temp) {
550
+			$extra_files[] = 'Themes/default/languages/' . $lang;
551
+	}
519 552
 
520 553
 	// With mod_security installed, we could attempt to fix it with .htaccess.
521
-	if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules()))
522
-		$writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.';
554
+	if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) {
555
+			$writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.';
556
+	}
523 557
 
524 558
 	$failed_files = array();
525 559
 
@@ -531,20 +565,23 @@  discard block
 block discarded – undo
531 565
 		foreach ($writable_files as $file)
532 566
 		{
533 567
 			// Some files won't exist, try to address up front
534
-			if (!file_exists(dirname(__FILE__) . '/' . $file))
535
-				@touch(dirname(__FILE__) . '/' . $file);
568
+			if (!file_exists(dirname(__FILE__) . '/' . $file)) {
569
+							@touch(dirname(__FILE__) . '/' . $file);
570
+			}
536 571
 			// NOW do the writable check...
537 572
 			if (!is_writable(dirname(__FILE__) . '/' . $file))
538 573
 			{
539 574
 				@chmod(dirname(__FILE__) . '/' . $file, 0755);
540 575
 
541 576
 				// Well, 755 hopefully worked... if not, try 777.
542
-				if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777))
543
-					$failed_files[] = $file;
577
+				if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) {
578
+									$failed_files[] = $file;
579
+				}
544 580
 			}
545 581
 		}
546
-		foreach ($extra_files as $file)
547
-			@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
582
+		foreach ($extra_files as $file) {
583
+					@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
584
+		}
548 585
 	}
549 586
 	// Windows is trickier.  Let's try opening for r+...
550 587
 	else
@@ -554,30 +591,35 @@  discard block
 block discarded – undo
554 591
 		foreach ($writable_files as $file)
555 592
 		{
556 593
 			// Folders can't be opened for write... but the index.php in them can ;)
557
-			if (is_dir(dirname(__FILE__) . '/' . $file))
558
-				$file .= '/index.php';
594
+			if (is_dir(dirname(__FILE__) . '/' . $file)) {
595
+							$file .= '/index.php';
596
+			}
559 597
 
560 598
 			// Funny enough, chmod actually does do something on windows - it removes the read only attribute.
561 599
 			@chmod(dirname(__FILE__) . '/' . $file, 0777);
562 600
 			$fp = @fopen(dirname(__FILE__) . '/' . $file, 'r+');
563 601
 
564 602
 			// Hmm, okay, try just for write in that case...
565
-			if (!is_resource($fp))
566
-				$fp = @fopen(dirname(__FILE__) . '/' . $file, 'w');
603
+			if (!is_resource($fp)) {
604
+							$fp = @fopen(dirname(__FILE__) . '/' . $file, 'w');
605
+			}
567 606
 
568
-			if (!is_resource($fp))
569
-				$failed_files[] = $file;
607
+			if (!is_resource($fp)) {
608
+							$failed_files[] = $file;
609
+			}
570 610
 
571 611
 			@fclose($fp);
572 612
 		}
573
-		foreach ($extra_files as $file)
574
-			@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
613
+		foreach ($extra_files as $file) {
614
+					@chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777);
615
+		}
575 616
 	}
576 617
 
577 618
 	$failure = count($failed_files) >= 1;
578 619
 
579
-	if (!isset($_SERVER))
580
-		return !$failure;
620
+	if (!isset($_SERVER)) {
621
+			return !$failure;
622
+	}
581 623
 
582 624
 	// Put the list into context.
583 625
 	$incontext['failed_files'] = $failed_files;
@@ -625,19 +667,23 @@  discard block
 block discarded – undo
625 667
 
626 668
 		if (!isset($ftp) || $ftp->error !== false)
627 669
 		{
628
-			if (!isset($ftp))
629
-				$ftp = new ftp_connection(null);
670
+			if (!isset($ftp)) {
671
+							$ftp = new ftp_connection(null);
672
+			}
630 673
 			// Save the error so we can mess with listing...
631
-			elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message))
632
-				$incontext['ftp_errors'][] = $ftp->last_message;
674
+			elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) {
675
+							$incontext['ftp_errors'][] = $ftp->last_message;
676
+			}
633 677
 
634 678
 			list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__));
635 679
 
636
-			if (empty($_POST['ftp_path']) && $found_path)
637
-				$_POST['ftp_path'] = $detect_path;
680
+			if (empty($_POST['ftp_path']) && $found_path) {
681
+							$_POST['ftp_path'] = $detect_path;
682
+			}
638 683
 
639
-			if (!isset($_POST['ftp_username']))
640
-				$_POST['ftp_username'] = $username;
684
+			if (!isset($_POST['ftp_username'])) {
685
+							$_POST['ftp_username'] = $username;
686
+			}
641 687
 
642 688
 			// Set the username etc, into context.
643 689
 			$incontext['ftp'] = array(
@@ -649,8 +695,7 @@  discard block
 block discarded – undo
649 695
 			);
650 696
 
651 697
 			return false;
652
-		}
653
-		else
698
+		} else
654 699
 		{
655 700
 			$_SESSION['installer_temp_ftp'] = array(
656 701
 				'server' => $_POST['ftp_server'],
@@ -664,10 +709,12 @@  discard block
 block discarded – undo
664 709
 
665 710
 			foreach ($failed_files as $file)
666 711
 			{
667
-				if (!is_writable(dirname(__FILE__) . '/' . $file))
668
-					$ftp->chmod($file, 0755);
669
-				if (!is_writable(dirname(__FILE__) . '/' . $file))
670
-					$ftp->chmod($file, 0777);
712
+				if (!is_writable(dirname(__FILE__) . '/' . $file)) {
713
+									$ftp->chmod($file, 0755);
714
+				}
715
+				if (!is_writable(dirname(__FILE__) . '/' . $file)) {
716
+									$ftp->chmod($file, 0777);
717
+				}
671 718
 				if (!is_writable(dirname(__FILE__) . '/' . $file))
672 719
 				{
673 720
 					$failed_files_updated[] = $file;
@@ -723,15 +770,17 @@  discard block
 block discarded – undo
723 770
 
724 771
 			if (!$foundOne)
725 772
 			{
726
-				if (isset($db['default_host']))
727
-					$incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost';
773
+				if (isset($db['default_host'])) {
774
+									$incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost';
775
+				}
728 776
 				if (isset($db['default_user']))
729 777
 				{
730 778
 					$incontext['db']['user'] = ini_get($db['default_user']);
731 779
 					$incontext['db']['name'] = ini_get($db['default_user']);
732 780
 				}
733
-				if (isset($db['default_password']))
734
-					$incontext['db']['pass'] = ini_get($db['default_password']);
781
+				if (isset($db['default_password'])) {
782
+									$incontext['db']['pass'] = ini_get($db['default_password']);
783
+				}
735 784
 
736 785
 				// For simplicity and less confusion, leave the port blank by default
737 786
 				$incontext['db']['port'] = '';
@@ -750,10 +799,10 @@  discard block
 block discarded – undo
750 799
 		$incontext['db']['server'] = $_POST['db_server'];
751 800
 		$incontext['db']['prefix'] = $_POST['db_prefix'];
752 801
 
753
-		if (!empty($_POST['db_port']))
754
-			$incontext['db']['port'] = $_POST['db_port'];
755
-	}
756
-	else
802
+		if (!empty($_POST['db_port'])) {
803
+					$incontext['db']['port'] = $_POST['db_port'];
804
+		}
805
+	} else
757 806
 	{
758 807
 		$incontext['db']['prefix'] = 'smf_';
759 808
 	}
@@ -789,10 +838,11 @@  discard block
 block discarded – undo
789 838
 		if (!empty($_POST['db_port']))
790 839
 		{
791 840
 			// For MySQL, we can get the "default port" from PHP. PostgreSQL has no such option though.
792
-			if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port'))
793
-				$vars['db_port'] = (int) $_POST['db_port'];
794
-			elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432)
795
-				$vars['db_port'] = (int) $_POST['db_port'];
841
+			if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) {
842
+							$vars['db_port'] = (int) $_POST['db_port'];
843
+			} elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) {
844
+							$vars['db_port'] = (int) $_POST['db_port'];
845
+			}
796 846
 		}
797 847
 
798 848
 		// God I hope it saved!
@@ -805,8 +855,9 @@  discard block
 block discarded – undo
805 855
 		// Make sure it works.
806 856
 		require(dirname(__FILE__) . '/Settings.php');
807 857
 
808
-		if (empty($sourcedir))
809
-			$sourcedir = dirname(__FILE__) . '/Sources';
858
+		if (empty($sourcedir)) {
859
+					$sourcedir = dirname(__FILE__) . '/Sources';
860
+		}
810 861
 
811 862
 		// Better find the database file!
812 863
 		if (!file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
@@ -816,18 +867,21 @@  discard block
 block discarded – undo
816 867
 		}
817 868
 
818 869
 		// Now include it for database functions!
819
-		if (!defined('SMF'))
820
-			define('SMF', 1);
870
+		if (!defined('SMF')) {
871
+					define('SMF', 1);
872
+		}
821 873
 
822 874
 		$modSettings['disableQueryCheck'] = true;
823
-		if (empty($smcFunc))
824
-			$smcFunc = array();
875
+		if (empty($smcFunc)) {
876
+					$smcFunc = array();
877
+		}
825 878
 
826 879
 			require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
827 880
 
828 881
 		// What - running PHP4? The shame!
829
-		if (version_compare(PHP_VERSION, '5', '<'))
830
-			require_once($sourcedir . '/Subs-Compat.php');
882
+		if (version_compare(PHP_VERSION, '5', '<')) {
883
+					require_once($sourcedir . '/Subs-Compat.php');
884
+		}
831 885
 
832 886
 		// Attempt a connection.
833 887
 		$needsDB = !empty($databases[$db_type]['always_has_db']);
@@ -915,12 +969,14 @@  discard block
 block discarded – undo
915 969
 	$incontext['page_title'] = $txt['install_settings'];
916 970
 
917 971
 	// Let's see if we got the database type correct.
918
-	if (isset($_POST['db_type'], $databases[$_POST['db_type']]))
919
-		$db_type = $_POST['db_type'];
972
+	if (isset($_POST['db_type'], $databases[$_POST['db_type']])) {
973
+			$db_type = $_POST['db_type'];
974
+	}
920 975
 
921 976
 	// Else we'd better be able to get the connection.
922
-	else
923
-		load_database();
977
+	else {
978
+			load_database();
979
+	}
924 980
 
925 981
 	$db_type = isset($_POST['db_type']) ? $_POST['db_type'] : $db_type;
926 982
 
@@ -940,12 +996,14 @@  discard block
 block discarded – undo
940 996
 	// Submitting?
941 997
 	if (isset($_POST['boardurl']))
942 998
 	{
943
-		if (substr($_POST['boardurl'], -10) == '/index.php')
944
-			$_POST['boardurl'] = substr($_POST['boardurl'], 0, -10);
945
-		elseif (substr($_POST['boardurl'], -1) == '/')
946
-			$_POST['boardurl'] = substr($_POST['boardurl'], 0, -1);
947
-		if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://')
948
-			$_POST['boardurl'] = 'http://' . $_POST['boardurl'];
999
+		if (substr($_POST['boardurl'], -10) == '/index.php') {
1000
+					$_POST['boardurl'] = substr($_POST['boardurl'], 0, -10);
1001
+		} elseif (substr($_POST['boardurl'], -1) == '/') {
1002
+					$_POST['boardurl'] = substr($_POST['boardurl'], 0, -1);
1003
+		}
1004
+		if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') {
1005
+					$_POST['boardurl'] = 'http://' . $_POST['boardurl'];
1006
+		}
949 1007
 
950 1008
 		// Save these variables.
951 1009
 		$vars = array(
@@ -984,10 +1042,10 @@  discard block
 block discarded – undo
984 1042
 			{
985 1043
 				$incontext['error'] = sprintf($txt['error_utf8_version'], $databases[$db_type]['utf8_version']);
986 1044
 				return false;
987
-			}
988
-			else
989
-				// Set the character set here.
1045
+			} else {
1046
+							// Set the character set here.
990 1047
 				updateSettingsFile(array('db_character_set' => 'utf8'));
1048
+			}
991 1049
 		}
992 1050
 
993 1051
 		// Good, skip on.
@@ -1007,8 +1065,9 @@  discard block
 block discarded – undo
1007 1065
 	$incontext['continue'] = 1;
1008 1066
 
1009 1067
 	// Already done?
1010
-	if (isset($_POST['pop_done']))
1011
-		return true;
1068
+	if (isset($_POST['pop_done'])) {
1069
+			return true;
1070
+	}
1012 1071
 
1013 1072
 	// Reload settings.
1014 1073
 	require(dirname(__FILE__) . '/Settings.php');
@@ -1026,8 +1085,9 @@  discard block
 block discarded – undo
1026 1085
 	$modSettings = array();
1027 1086
 	if ($result !== false)
1028 1087
 	{
1029
-		while ($row = $smcFunc['db_fetch_assoc']($result))
1030
-			$modSettings[$row['variable']] = $row['value'];
1088
+		while ($row = $smcFunc['db_fetch_assoc']($result)) {
1089
+					$modSettings[$row['variable']] = $row['value'];
1090
+		}
1031 1091
 		$smcFunc['db_free_result']($result);
1032 1092
 
1033 1093
 		// Do they match?  If so, this is just a refresh so charge on!
@@ -1040,20 +1100,22 @@  discard block
 block discarded – undo
1040 1100
 	$modSettings['disableQueryCheck'] = true;
1041 1101
 
1042 1102
 	// If doing UTF8, select it. PostgreSQL requires passing it as a string...
1043
-	if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support']))
1044
-		$smcFunc['db_query']('', '
1103
+	if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) {
1104
+			$smcFunc['db_query']('', '
1045 1105
 			SET NAMES {string:utf8}',
1046 1106
 			array(
1047 1107
 				'db_error_skip' => true,
1048 1108
 				'utf8' => 'utf8',
1049 1109
 			)
1050 1110
 		);
1111
+	}
1051 1112
 
1052 1113
 	// Windows likes to leave the trailing slash, which yields to C:\path\to\SMF\/attachments...
1053
-	if (substr(__DIR__, -1) == '\\')
1054
-		$attachdir = __DIR__ . 'attachments';
1055
-	else
1056
-		$attachdir = __DIR__ . '/attachments';
1114
+	if (substr(__DIR__, -1) == '\\') {
1115
+			$attachdir = __DIR__ . 'attachments';
1116
+	} else {
1117
+			$attachdir = __DIR__ . '/attachments';
1118
+	}
1057 1119
 
1058 1120
 	$replaces = array(
1059 1121
 		'{$db_prefix}' => $db_prefix,
@@ -1070,8 +1132,9 @@  discard block
 block discarded – undo
1070 1132
 
1071 1133
 	foreach ($txt as $key => $value)
1072 1134
 	{
1073
-		if (substr($key, 0, 8) == 'default_')
1074
-			$replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value);
1135
+		if (substr($key, 0, 8) == 'default_') {
1136
+					$replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value);
1137
+		}
1075 1138
 	}
1076 1139
 	$replaces['{$default_reserved_names}'] = strtr($replaces['{$default_reserved_names}'], array('\\\\n' => '\\n'));
1077 1140
 
@@ -1086,8 +1149,9 @@  discard block
 block discarded – undo
1086 1149
 
1087 1150
 		while ($row = $smcFunc['db_fetch_assoc']($get_engines))
1088 1151
 		{
1089
-			if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT')
1090
-				$engines[] = $row['Engine'];
1152
+			if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') {
1153
+							$engines[] = $row['Engine'];
1154
+			}
1091 1155
 		}
1092 1156
 
1093 1157
 		// Done with this now
@@ -1111,8 +1175,7 @@  discard block
 block discarded – undo
1111 1175
 			$replaces['START TRANSACTION;'] = '';
1112 1176
 			$replaces['COMMIT;'] = '';
1113 1177
 		}
1114
-	}
1115
-	else
1178
+	} else
1116 1179
 	{
1117 1180
 		$has_innodb = false;
1118 1181
 	}
@@ -1134,21 +1197,24 @@  discard block
 block discarded – undo
1134 1197
 	foreach ($sql_lines as $count => $line)
1135 1198
 	{
1136 1199
 		// No comments allowed!
1137
-		if (substr(trim($line), 0, 1) != '#')
1138
-			$current_statement .= "\n" . rtrim($line);
1200
+		if (substr(trim($line), 0, 1) != '#') {
1201
+					$current_statement .= "\n" . rtrim($line);
1202
+		}
1139 1203
 
1140 1204
 		// Is this the end of the query string?
1141
-		if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines)))
1142
-			continue;
1205
+		if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) {
1206
+					continue;
1207
+		}
1143 1208
 
1144 1209
 		// Does this table already exist?  If so, don't insert more data into it!
1145 1210
 		if (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) != 0 && in_array($match[1], $exists))
1146 1211
 		{
1147 1212
 			preg_match_all('~\)[,;]~', $current_statement, $matches);
1148
-			if (!empty($matches[0]))
1149
-				$incontext['sql_results']['insert_dups'] += count($matches[0]);
1150
-			else
1151
-				$incontext['sql_results']['insert_dups']++;
1213
+			if (!empty($matches[0])) {
1214
+							$incontext['sql_results']['insert_dups'] += count($matches[0]);
1215
+			} else {
1216
+							$incontext['sql_results']['insert_dups']++;
1217
+			}
1152 1218
 
1153 1219
 			$current_statement = '';
1154 1220
 			continue;
@@ -1157,8 +1223,9 @@  discard block
 block discarded – undo
1157 1223
 		if ($smcFunc['db_query']('', $current_statement, array('security_override' => true, 'db_error_skip' => true), $db_connection) === false)
1158 1224
 		{
1159 1225
 			// Use the appropriate function based on the DB type
1160
-			if ($db_type == 'mysql' || $db_type == 'mysqli')
1161
-				$db_errorno = $db_type . '_errno';
1226
+			if ($db_type == 'mysql' || $db_type == 'mysqli') {
1227
+							$db_errorno = $db_type . '_errno';
1228
+			}
1162 1229
 
1163 1230
 			// Error 1050: Table already exists!
1164 1231
 			// @todo Needs to be made better!
@@ -1173,18 +1240,18 @@  discard block
 block discarded – undo
1173 1240
 				// MySQLi requires a connection object. It's optional with MySQL and Postgres
1174 1241
 				$incontext['failures'][$count] = $smcFunc['db_error']($db_connection);
1175 1242
 			}
1176
-		}
1177
-		else
1243
+		} else
1178 1244
 		{
1179
-			if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1180
-				$incontext['sql_results']['tables']++;
1181
-			elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1245
+			if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) {
1246
+							$incontext['sql_results']['tables']++;
1247
+			} elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1)
1182 1248
 			{
1183 1249
 				preg_match_all('~\)[,;]~', $current_statement, $matches);
1184
-				if (!empty($matches[0]))
1185
-					$incontext['sql_results']['inserts'] += count($matches[0]);
1186
-				else
1187
-					$incontext['sql_results']['inserts']++;
1250
+				if (!empty($matches[0])) {
1251
+									$incontext['sql_results']['inserts'] += count($matches[0]);
1252
+				} else {
1253
+									$incontext['sql_results']['inserts']++;
1254
+				}
1188 1255
 			}
1189 1256
 		}
1190 1257
 
@@ -1197,15 +1264,17 @@  discard block
 block discarded – undo
1197 1264
 	// Sort out the context for the SQL.
1198 1265
 	foreach ($incontext['sql_results'] as $key => $number)
1199 1266
 	{
1200
-		if ($number == 0)
1201
-			unset($incontext['sql_results'][$key]);
1202
-		else
1203
-			$incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number);
1267
+		if ($number == 0) {
1268
+					unset($incontext['sql_results'][$key]);
1269
+		} else {
1270
+					$incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number);
1271
+		}
1204 1272
 	}
1205 1273
 
1206 1274
 	// Make sure UTF will be used globally.
1207
-	if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8'])))
1208
-		$newSettings[] = array('global_character_set', 'UTF-8');
1275
+	if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) {
1276
+			$newSettings[] = array('global_character_set', 'UTF-8');
1277
+	}
1209 1278
 
1210 1279
 	// Maybe we can auto-detect better cookie settings?
1211 1280
 	preg_match('~^http[s]?://([^\.]+?)([^/]*?)(/.*)?$~', $boardurl, $matches);
@@ -1216,16 +1285,20 @@  discard block
 block discarded – undo
1216 1285
 		$globalCookies = false;
1217 1286
 
1218 1287
 		// Okay... let's see.  Using a subdomain other than www.? (not a perfect check.)
1219
-		if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www'))))
1220
-			$globalCookies = true;
1288
+		if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www')))) {
1289
+					$globalCookies = true;
1290
+		}
1221 1291
 		// If there's a / in the middle of the path, or it starts with ~... we want local.
1222
-		if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false))
1223
-			$localCookies = true;
1292
+		if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false)) {
1293
+					$localCookies = true;
1294
+		}
1224 1295
 
1225
-		if ($globalCookies)
1226
-			$newSettings[] = array('globalCookies', '1');
1227
-		if ($localCookies)
1228
-			$newSettings[] = array('localCookies', '1');
1296
+		if ($globalCookies) {
1297
+					$newSettings[] = array('globalCookies', '1');
1298
+		}
1299
+		if ($localCookies) {
1300
+					$newSettings[] = array('localCookies', '1');
1301
+		}
1229 1302
 	}
1230 1303
 
1231 1304
 	// Are we allowing stat collection?
@@ -1243,16 +1316,17 @@  discard block
 block discarded – undo
1243 1316
 			fwrite($fp, $out);
1244 1317
 
1245 1318
 			$return_data = '';
1246
-			while (!feof($fp))
1247
-				$return_data .= fgets($fp, 128);
1319
+			while (!feof($fp)) {
1320
+							$return_data .= fgets($fp, 128);
1321
+			}
1248 1322
 
1249 1323
 			fclose($fp);
1250 1324
 
1251 1325
 			// Get the unique site ID.
1252 1326
 			preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID);
1253 1327
 
1254
-			if (!empty($ID[1]))
1255
-				$smcFunc['db_insert']('replace',
1328
+			if (!empty($ID[1])) {
1329
+							$smcFunc['db_insert']('replace',
1256 1330
 					$db_prefix . 'settings',
1257 1331
 					array('variable' => 'string', 'value' => 'string'),
1258 1332
 					array(
@@ -1261,11 +1335,12 @@  discard block
 block discarded – undo
1261 1335
 					),
1262 1336
 					array('variable')
1263 1337
 				);
1338
+			}
1264 1339
 		}
1265 1340
 	}
1266 1341
 	// Don't remove stat collection unless we unchecked the box for real, not from the loop.
1267
-	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats']))
1268
-		$smcFunc['db_query']('', '
1342
+	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) {
1343
+			$smcFunc['db_query']('', '
1269 1344
 			DELETE FROM {db_prefix}settings
1270 1345
 			WHERE variable = {string:enable_sm_stats}',
1271 1346
 			array(
@@ -1273,20 +1348,23 @@  discard block
 block discarded – undo
1273 1348
 				'db_error_skip' => true,
1274 1349
 			)
1275 1350
 		);
1351
+	}
1276 1352
 
1277 1353
 	// Are we enabling SSL?
1278
-	if (!empty($_POST['force_ssl']))
1279
-		$newSettings[] = array('force_ssl', 2);
1354
+	if (!empty($_POST['force_ssl'])) {
1355
+			$newSettings[] = array('force_ssl', 2);
1356
+	}
1280 1357
 
1281 1358
 	// Setting a timezone is required.
1282 1359
 	if (!isset($modSettings['default_timezone']) && function_exists('date_default_timezone_set'))
1283 1360
 	{
1284 1361
 		// Get PHP's default timezone, if set
1285 1362
 		$ini_tz = ini_get('date.timezone');
1286
-		if (!empty($ini_tz))
1287
-			$timezone_id = $ini_tz;
1288
-		else
1289
-			$timezone_id = '';
1363
+		if (!empty($ini_tz)) {
1364
+					$timezone_id = $ini_tz;
1365
+		} else {
1366
+					$timezone_id = '';
1367
+		}
1290 1368
 
1291 1369
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
1292 1370
 		if (!in_array($timezone_id, timezone_identifiers_list()))
@@ -1295,8 +1373,9 @@  discard block
 block discarded – undo
1295 1373
 			$timezone_id = timezone_name_from_abbr('', $server_offset, 0);
1296 1374
 		}
1297 1375
 
1298
-		if (date_default_timezone_set($timezone_id))
1299
-			$newSettings[] = array('default_timezone', $timezone_id);
1376
+		if (date_default_timezone_set($timezone_id)) {
1377
+					$newSettings[] = array('default_timezone', $timezone_id);
1378
+		}
1300 1379
 	}
1301 1380
 
1302 1381
 	if (!empty($newSettings))
@@ -1327,16 +1406,18 @@  discard block
 block discarded – undo
1327 1406
 	}
1328 1407
 
1329 1408
 	// MySQL specific stuff
1330
-	if (substr($db_type, 0, 5) != 'mysql')
1331
-		return false;
1409
+	if (substr($db_type, 0, 5) != 'mysql') {
1410
+			return false;
1411
+	}
1332 1412
 
1333 1413
 	// Find database user privileges.
1334 1414
 	$privs = array();
1335 1415
 	$get_privs = $smcFunc['db_query']('', 'SHOW PRIVILEGES', array());
1336 1416
 	while ($row = $smcFunc['db_fetch_assoc']($get_privs))
1337 1417
 	{
1338
-		if ($row['Privilege'] == 'Alter')
1339
-			$privs[] = $row['Privilege'];
1418
+		if ($row['Privilege'] == 'Alter') {
1419
+					$privs[] = $row['Privilege'];
1420
+		}
1340 1421
 	}
1341 1422
 	$smcFunc['db_free_result']($get_privs);
1342 1423
 
@@ -1366,8 +1447,9 @@  discard block
 block discarded – undo
1366 1447
 	$incontext['continue'] = 1;
1367 1448
 
1368 1449
 	// Skipping?
1369
-	if (!empty($_POST['skip']))
1370
-		return true;
1450
+	if (!empty($_POST['skip'])) {
1451
+			return true;
1452
+	}
1371 1453
 
1372 1454
 	// Need this to check whether we need the database password.
1373 1455
 	require(dirname(__FILE__) . '/Settings.php');
@@ -1384,18 +1466,22 @@  discard block
 block discarded – undo
1384 1466
 	// We need this to properly hash the password for Admin
1385 1467
 	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) {
1386 1468
 			global $sourcedir;
1387
-			if (function_exists('mb_strtolower'))
1388
-				return mb_strtolower($string, 'UTF-8');
1469
+			if (function_exists('mb_strtolower')) {
1470
+							return mb_strtolower($string, 'UTF-8');
1471
+			}
1389 1472
 			require_once($sourcedir . '/Subs-Charset.php');
1390 1473
 			return utf8_strtolower($string);
1391 1474
 		};
1392 1475
 
1393
-	if (!isset($_POST['username']))
1394
-		$_POST['username'] = '';
1395
-	if (!isset($_POST['email']))
1396
-		$_POST['email'] = '';
1397
-	if (!isset($_POST['server_email']))
1398
-		$_POST['server_email'] = '';
1476
+	if (!isset($_POST['username'])) {
1477
+			$_POST['username'] = '';
1478
+	}
1479
+	if (!isset($_POST['email'])) {
1480
+			$_POST['email'] = '';
1481
+	}
1482
+	if (!isset($_POST['server_email'])) {
1483
+			$_POST['server_email'] = '';
1484
+	}
1399 1485
 
1400 1486
 	$incontext['username'] = htmlspecialchars(stripslashes($_POST['username']));
1401 1487
 	$incontext['email'] = htmlspecialchars(stripslashes($_POST['email']));
@@ -1414,8 +1500,9 @@  discard block
 block discarded – undo
1414 1500
 			'admin_group' => 1,
1415 1501
 		)
1416 1502
 	);
1417
-	if ($smcFunc['db_num_rows']($request) != 0)
1418
-		$incontext['skip'] = 1;
1503
+	if ($smcFunc['db_num_rows']($request) != 0) {
1504
+			$incontext['skip'] = 1;
1505
+	}
1419 1506
 	$smcFunc['db_free_result']($request);
1420 1507
 
1421 1508
 	// Trying to create an account?
@@ -1446,8 +1533,9 @@  discard block
 block discarded – undo
1446 1533
 		}
1447 1534
 
1448 1535
 		// Update the webmaster's email?
1449
-		if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]'))
1450
-			updateSettingsFile(array('webmaster_email' => $_POST['server_email']));
1536
+		if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) {
1537
+					updateSettingsFile(array('webmaster_email' => $_POST['server_email']));
1538
+		}
1451 1539
 
1452 1540
 		// Work out whether we're going to have dodgy characters and remove them.
1453 1541
 		$invalid_characters = preg_match('~[<>&"\'=\\\]~', $_POST['username']) != 0;
@@ -1470,32 +1558,27 @@  discard block
 block discarded – undo
1470 1558
 			$smcFunc['db_free_result']($result);
1471 1559
 
1472 1560
 			$incontext['account_existed'] = $txt['error_user_settings_taken'];
1473
-		}
1474
-		elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25)
1561
+		} elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25)
1475 1562
 		{
1476 1563
 			// Try the previous step again.
1477 1564
 			$incontext['error'] = $_POST['username'] == '' ? $txt['error_username_left_empty'] : $txt['error_username_too_long'];
1478 1565
 			return false;
1479
-		}
1480
-		elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false)
1566
+		} elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false)
1481 1567
 		{
1482 1568
 			// Try the previous step again.
1483 1569
 			$incontext['error'] = $txt['error_invalid_characters_username'];
1484 1570
 			return false;
1485
-		}
1486
-		elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255)
1571
+		} elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255)
1487 1572
 		{
1488 1573
 			// One step back, this time fill out a proper admin email address.
1489 1574
 			$incontext['error'] = sprintf($txt['error_valid_admin_email_needed'], $_POST['username']);
1490 1575
 			return false;
1491
-		}
1492
-		elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255)
1576
+		} elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255)
1493 1577
 		{
1494 1578
 			// One step back, this time fill out a proper admin email address.
1495 1579
 			$incontext['error'] = $txt['error_valid_server_email_needed'];
1496 1580
 			return false;
1497
-		}
1498
-		elseif ($_POST['username'] != '')
1581
+		} elseif ($_POST['username'] != '')
1499 1582
 		{
1500 1583
 			$incontext['member_salt'] = substr(md5(mt_rand()), 0, 4);
1501 1584
 
@@ -1563,17 +1646,19 @@  discard block
 block discarded – undo
1563 1646
 	reloadSettings();
1564 1647
 
1565 1648
 	// Bring a warning over.
1566
-	if (!empty($incontext['account_existed']))
1567
-		$incontext['warning'] = $incontext['account_existed'];
1649
+	if (!empty($incontext['account_existed'])) {
1650
+			$incontext['warning'] = $incontext['account_existed'];
1651
+	}
1568 1652
 
1569
-	if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support']))
1570
-		$smcFunc['db_query']('', '
1653
+	if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) {
1654
+			$smcFunc['db_query']('', '
1571 1655
 			SET NAMES {string:db_character_set}',
1572 1656
 			array(
1573 1657
 				'db_character_set' => $db_character_set,
1574 1658
 				'db_error_skip' => true,
1575 1659
 			)
1576 1660
 		);
1661
+	}
1577 1662
 
1578 1663
 	// As track stats is by default enabled let's add some activity.
1579 1664
 	$smcFunc['db_insert']('ignore',
@@ -1594,14 +1679,16 @@  discard block
 block discarded – undo
1594 1679
 	// Only proceed if we can load the data.
1595 1680
 	if ($request)
1596 1681
 	{
1597
-		while ($row = $smcFunc['db_fetch_row']($request))
1598
-			$modSettings[$row[0]] = $row[1];
1682
+		while ($row = $smcFunc['db_fetch_row']($request)) {
1683
+					$modSettings[$row[0]] = $row[1];
1684
+		}
1599 1685
 		$smcFunc['db_free_result']($request);
1600 1686
 	}
1601 1687
 
1602 1688
 	// Automatically log them in ;)
1603
-	if (isset($incontext['member_id']) && isset($incontext['member_salt']))
1604
-		setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt']));
1689
+	if (isset($incontext['member_id']) && isset($incontext['member_salt'])) {
1690
+			setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt']));
1691
+	}
1605 1692
 
1606 1693
 	$result = $smcFunc['db_query']('', '
1607 1694
 		SELECT value
@@ -1612,13 +1699,14 @@  discard block
 block discarded – undo
1612 1699
 			'db_error_skip' => true,
1613 1700
 		)
1614 1701
 	);
1615
-	if ($smcFunc['db_num_rows']($result) != 0)
1616
-		list ($db_sessions) = $smcFunc['db_fetch_row']($result);
1702
+	if ($smcFunc['db_num_rows']($result) != 0) {
1703
+			list ($db_sessions) = $smcFunc['db_fetch_row']($result);
1704
+	}
1617 1705
 	$smcFunc['db_free_result']($result);
1618 1706
 
1619
-	if (empty($db_sessions))
1620
-		$_SESSION['admin_time'] = time();
1621
-	else
1707
+	if (empty($db_sessions)) {
1708
+			$_SESSION['admin_time'] = time();
1709
+	} else
1622 1710
 	{
1623 1711
 		$_SERVER['HTTP_USER_AGENT'] = substr($_SERVER['HTTP_USER_AGENT'], 0, 211);
1624 1712
 
@@ -1642,8 +1730,9 @@  discard block
 block discarded – undo
1642 1730
 	$smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' :
1643 1731
 		function($string){
1644 1732
 			global $sourcedir;
1645
-			if (function_exists('mb_strtolower'))
1646
-				return mb_strtolower($string, 'UTF-8');
1733
+			if (function_exists('mb_strtolower')) {
1734
+							return mb_strtolower($string, 'UTF-8');
1735
+			}
1647 1736
 			require_once($sourcedir . '/Subs-Charset.php');
1648 1737
 			return utf8_strtolower($string);
1649 1738
 		};
@@ -1659,8 +1748,9 @@  discard block
 block discarded – undo
1659 1748
 		)
1660 1749
 	);
1661 1750
 	$context['utf8'] = $db_character_set === 'utf8' || $txt['lang_character_set'] === 'UTF-8';
1662
-	if ($smcFunc['db_num_rows']($request) > 0)
1663
-		updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject']));
1751
+	if ($smcFunc['db_num_rows']($request) > 0) {
1752
+			updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject']));
1753
+	}
1664 1754
 	$smcFunc['db_free_result']($request);
1665 1755
 
1666 1756
 	// Now is the perfect time to fetch the SM files.
@@ -1679,8 +1769,9 @@  discard block
 block discarded – undo
1679 1769
 
1680 1770
 	// Check if we need some stupid MySQL fix.
1681 1771
 	$server_version = $smcFunc['db_server_info']();
1682
-	if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51')))
1683
-		updateSettings(array('db_mysql_group_by_fix' => '1'));
1772
+	if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) {
1773
+			updateSettings(array('db_mysql_group_by_fix' => '1'));
1774
+	}
1684 1775
 
1685 1776
 	// Some final context for the template.
1686 1777
 	$incontext['dir_still_writable'] = is_writable(dirname(__FILE__)) && substr(__FILE__, 1, 2) != ':\\';
@@ -1700,8 +1791,9 @@  discard block
 block discarded – undo
1700 1791
 	$settingsArray = file(dirname(__FILE__) . '/Settings.php');
1701 1792
 
1702 1793
 	// @todo Do we just want to read the file in clean, and split it this way always?
1703
-	if (count($settingsArray) == 1)
1704
-		$settingsArray = preg_split('~[\r\n]~', $settingsArray[0]);
1794
+	if (count($settingsArray) == 1) {
1795
+			$settingsArray = preg_split('~[\r\n]~', $settingsArray[0]);
1796
+	}
1705 1797
 
1706 1798
 	for ($i = 0, $n = count($settingsArray); $i < $n; $i++)
1707 1799
 	{
@@ -1716,19 +1808,22 @@  discard block
 block discarded – undo
1716 1808
 			continue;
1717 1809
 		}
1718 1810
 
1719
-		if (trim($settingsArray[$i]) == '?' . '>')
1720
-			$settingsArray[$i] = '';
1811
+		if (trim($settingsArray[$i]) == '?' . '>') {
1812
+					$settingsArray[$i] = '';
1813
+		}
1721 1814
 
1722 1815
 		// Don't trim or bother with it if it's not a variable.
1723
-		if (substr($settingsArray[$i], 0, 1) != '$')
1724
-			continue;
1816
+		if (substr($settingsArray[$i], 0, 1) != '$') {
1817
+					continue;
1818
+		}
1725 1819
 
1726 1820
 		$settingsArray[$i] = rtrim($settingsArray[$i]) . "\n";
1727 1821
 
1728
-		foreach ($vars as $var => $val)
1729
-			if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0)
1822
+		foreach ($vars as $var => $val) {
1823
+					if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0)
1730 1824
 			{
1731 1825
 				$comment = strstr($settingsArray[$i], '#');
1826
+		}
1732 1827
 				$settingsArray[$i] = '$' . $var . ' = \'' . $val . '\';' . ($comment != '' ? "\t\t" . $comment : "\n");
1733 1828
 				unset($vars[$var]);
1734 1829
 			}
@@ -1738,36 +1833,41 @@  discard block
 block discarded – undo
1738 1833
 	if (!empty($vars))
1739 1834
 	{
1740 1835
 		$settingsArray[$i++] = '';
1741
-		foreach ($vars as $var => $val)
1742
-			$settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n";
1836
+		foreach ($vars as $var => $val) {
1837
+					$settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n";
1838
+		}
1743 1839
 	}
1744 1840
 
1745 1841
 	// Blank out the file - done to fix a oddity with some servers.
1746 1842
 	$fp = @fopen(dirname(__FILE__) . '/Settings.php', 'w');
1747
-	if (!$fp)
1748
-		return false;
1843
+	if (!$fp) {
1844
+			return false;
1845
+	}
1749 1846
 	fclose($fp);
1750 1847
 
1751 1848
 	$fp = fopen(dirname(__FILE__) . '/Settings.php', 'r+');
1752 1849
 
1753 1850
 	// Gotta have one of these ;)
1754
-	if (trim($settingsArray[0]) != '<?php')
1755
-		fwrite($fp, "<?php\n");
1851
+	if (trim($settingsArray[0]) != '<?php') {
1852
+			fwrite($fp, "<?php\n");
1853
+	}
1756 1854
 
1757 1855
 	$lines = count($settingsArray);
1758 1856
 	for ($i = 0; $i < $lines - 1; $i++)
1759 1857
 	{
1760 1858
 		// Don't just write a bunch of blank lines.
1761
-		if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '')
1762
-			fwrite($fp, strtr($settingsArray[$i], "\r", ''));
1859
+		if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') {
1860
+					fwrite($fp, strtr($settingsArray[$i], "\r", ''));
1861
+		}
1763 1862
 	}
1764 1863
 	fwrite($fp, $settingsArray[$i] . '?' . '>');
1765 1864
 	fclose($fp);
1766 1865
 
1767 1866
 	// Even though on normal installations the filemtime should prevent this being used by the installer incorrectly
1768 1867
 	// it seems that there are times it might not. So let's MAKE it dump the cache.
1769
-	if (function_exists('opcache_invalidate'))
1770
-		opcache_invalidate(dirname(__FILE__) . '/Settings.php', true);
1868
+	if (function_exists('opcache_invalidate')) {
1869
+			opcache_invalidate(dirname(__FILE__) . '/Settings.php', true);
1870
+	}
1771 1871
 
1772 1872
 	return true;
1773 1873
 }
@@ -1792,9 +1892,9 @@  discard block
 block discarded – undo
1792 1892
 	SecFilterScanPOST Off
1793 1893
 </IfModule>';
1794 1894
 
1795
-	if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules()))
1796
-		return true;
1797
-	elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess'))
1895
+	if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) {
1896
+			return true;
1897
+	} elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess'))
1798 1898
 	{
1799 1899
 		$current_htaccess = implode('', file(dirname(__FILE__) . '/.htaccess'));
1800 1900
 
@@ -1806,29 +1906,28 @@  discard block
 block discarded – undo
1806 1906
 				fwrite($ht_handle, $htaccess_addition);
1807 1907
 				fclose($ht_handle);
1808 1908
 				return true;
1909
+			} else {
1910
+							return false;
1809 1911
 			}
1810
-			else
1811
-				return false;
1912
+		} else {
1913
+					return true;
1812 1914
 		}
1813
-		else
1814
-			return true;
1815
-	}
1816
-	elseif (file_exists(dirname(__FILE__) . '/.htaccess'))
1817
-		return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false;
1818
-	elseif (is_writable(dirname(__FILE__)))
1915
+	} elseif (file_exists(dirname(__FILE__) . '/.htaccess')) {
1916
+			return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false;
1917
+	} elseif (is_writable(dirname(__FILE__)))
1819 1918
 	{
1820 1919
 		if ($ht_handle = fopen(dirname(__FILE__) . '/.htaccess', 'w'))
1821 1920
 		{
1822 1921
 			fwrite($ht_handle, $htaccess_addition);
1823 1922
 			fclose($ht_handle);
1824 1923
 			return true;
1924
+		} else {
1925
+					return false;
1825 1926
 		}
1826
-		else
1927
+	} else {
1827 1928
 			return false;
1828 1929
 	}
1829
-	else
1830
-		return false;
1831
-}
1930
+	}
1832 1931
 
1833 1932
 function template_install_above()
1834 1933
 {
@@ -1866,9 +1965,10 @@  discard block
 block discarded – undo
1866 1965
 								<label for="installer_language">', $txt['installer_language'], ':</label>
1867 1966
 								<select id="installer_language" name="lang_file" onchange="location.href = \'', $installurl, '?lang_file=\' + this.options[this.selectedIndex].value;">';
1868 1967
 
1869
-		foreach ($incontext['detected_languages'] as $lang => $name)
1870
-			echo '
1968
+		foreach ($incontext['detected_languages'] as $lang => $name) {
1969
+					echo '
1871 1970
 									<option', isset($_SESSION['installer_temp_lang']) && $_SESSION['installer_temp_lang'] == $lang ? ' selected' : '', ' value="', $lang, '">', $name, '</option>';
1971
+		}
1872 1972
 
1873 1973
 		echo '
1874 1974
 								</select>
@@ -1888,9 +1988,10 @@  discard block
 block discarded – undo
1888 1988
 						<h2>', $txt['upgrade_progress'], '</h2>
1889 1989
 						<ul>';
1890 1990
 
1891
-	foreach ($incontext['steps'] as $num => $step)
1892
-		echo '
1991
+	foreach ($incontext['steps'] as $num => $step) {
1992
+			echo '
1893 1993
 							<li class="', $num < $incontext['current_step'] ? 'stepdone' : ($num == $incontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>';
1994
+	}
1894 1995
 
1895 1996
 	echo '
1896 1997
 						</ul>
@@ -1915,20 +2016,23 @@  discard block
 block discarded – undo
1915 2016
 		echo '
1916 2017
 								<div>';
1917 2018
 
1918
-		if (!empty($incontext['continue']))
1919
-			echo '
2019
+		if (!empty($incontext['continue'])) {
2020
+					echo '
1920 2021
 									<input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '" onclick="return submitThisOnce(this);" class="button_submit" />';
1921
-		if (!empty($incontext['skip']))
1922
-			echo '
2022
+		}
2023
+		if (!empty($incontext['skip'])) {
2024
+					echo '
1923 2025
 									<input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="return submitThisOnce(this);" class="button_submit" />';
2026
+		}
1924 2027
 		echo '
1925 2028
 								</div>';
1926 2029
 	}
1927 2030
 
1928 2031
 	// Show the closing form tag and other data only if not in the last step
1929
-	if (count($incontext['steps']) - 1 !== (int) $incontext['current_step'])
1930
-		echo '
2032
+	if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) {
2033
+			echo '
1931 2034
 							</form>';
2035
+	}
1932 2036
 
1933 2037
 	echo '
1934 2038
 						</div>
@@ -1963,13 +2067,15 @@  discard block
 block discarded – undo
1963 2067
 		</div>';
1964 2068
 
1965 2069
 	// Show the warnings, or not.
1966
-	if (template_warning_divs())
1967
-		echo '
2070
+	if (template_warning_divs()) {
2071
+			echo '
1968 2072
 		<h3>', $txt['install_all_lovely'], '</h3>';
2073
+	}
1969 2074
 
1970 2075
 	// Say we want the continue button!
1971
-	if (empty($incontext['error']))
1972
-		$incontext['continue'] = 1;
2076
+	if (empty($incontext['error'])) {
2077
+			$incontext['continue'] = 1;
2078
+	}
1973 2079
 
1974 2080
 	// For the latest version stuff.
1975 2081
 	echo '
@@ -2003,8 +2109,8 @@  discard block
 block discarded – undo
2003 2109
 	global $txt, $incontext;
2004 2110
 
2005 2111
 	// Errors are very serious..
2006
-	if (!empty($incontext['error']))
2007
-		echo '
2112
+	if (!empty($incontext['error'])) {
2113
+			echo '
2008 2114
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
2009 2115
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
2010 2116
 			<strong style="text-decoration: underline;">', $txt['upgrade_critical_error'], '</strong><br>
@@ -2012,9 +2118,10 @@  discard block
 block discarded – undo
2012 2118
 				', $incontext['error'], '
2013 2119
 			</div>
2014 2120
 		</div>';
2121
+	}
2015 2122
 	// A warning message?
2016
-	elseif (!empty($incontext['warning']))
2017
-		echo '
2123
+	elseif (!empty($incontext['warning'])) {
2124
+			echo '
2018 2125
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
2019 2126
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
2020 2127
 			<strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br>
@@ -2022,6 +2129,7 @@  discard block
 block discarded – undo
2022 2129
 				', $incontext['warning'], '
2023 2130
 			</div>
2024 2131
 		</div>';
2132
+	}
2025 2133
 
2026 2134
 	return empty($incontext['error']) && empty($incontext['warning']);
2027 2135
 }
@@ -2037,27 +2145,30 @@  discard block
 block discarded – undo
2037 2145
 			<li>', $incontext['failed_files']), '</li>
2038 2146
 		</ul>';
2039 2147
 
2040
-	if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux')
2041
-		echo '
2148
+	if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') {
2149
+			echo '
2042 2150
 		<hr>
2043 2151
 		<p>', $txt['chmod_linux_info'], '</p>
2044 2152
 		<tt># chmod a+w ', implode(' ' . $incontext['detected_path'] . '/', $incontext['failed_files']), '</tt>';
2153
+	}
2045 2154
 
2046 2155
 	// This is serious!
2047
-	if (!template_warning_divs())
2048
-		return;
2156
+	if (!template_warning_divs()) {
2157
+			return;
2158
+	}
2049 2159
 
2050 2160
 	echo '
2051 2161
 		<hr>
2052 2162
 		<p>', $txt['ftp_setup_info'], '</p>';
2053 2163
 
2054
-	if (!empty($incontext['ftp_errors']))
2055
-		echo '
2164
+	if (!empty($incontext['ftp_errors'])) {
2165
+			echo '
2056 2166
 		<div class="error_message">
2057 2167
 			', $txt['error_ftp_no_connect'], '<br><br>
2058 2168
 			<code>', implode('<br>', $incontext['ftp_errors']), '</code>
2059 2169
 		</div>
2060 2170
 		<br>';
2171
+	}
2061 2172
 
2062 2173
 	echo '
2063 2174
 		<form action="', $incontext['form_url'], '" method="post">
@@ -2117,17 +2228,17 @@  discard block
 block discarded – undo
2117 2228
 				<td>
2118 2229
 					<select name="db_type" id="db_type_input" onchange="toggleDBInput();">';
2119 2230
 
2120
-	foreach ($incontext['supported_databases'] as $key => $db)
2121
-			echo '
2231
+	foreach ($incontext['supported_databases'] as $key => $db) {
2232
+				echo '
2122 2233
 						<option value="', $key, '"', isset($_POST['db_type']) && $_POST['db_type'] == $key ? ' selected' : '', '>', $db['name'], '</option>';
2234
+	}
2123 2235
 
2124 2236
 	echo '
2125 2237
 					</select>
2126 2238
 					<div class="smalltext block">', $txt['db_settings_type_info'], '</div>
2127 2239
 				</td>
2128 2240
 			</tr>';
2129
-	}
2130
-	else
2241
+	} else
2131 2242
 	{
2132 2243
 		echo '
2133 2244
 			<tr style="display: none;">
@@ -2319,9 +2430,10 @@  discard block
 block discarded – undo
2319 2430
 				<div style="color: red;">', $txt['error_db_queries'], '</div>
2320 2431
 				<ul>';
2321 2432
 
2322
-		foreach ($incontext['failures'] as $line => $fail)
2323
-			echo '
2433
+		foreach ($incontext['failures'] as $line => $fail) {
2434
+					echo '
2324 2435
 						<li><strong>', $txt['error_db_queries_line'], $line + 1, ':</strong> ', nl2br(htmlspecialchars($fail)), '</li>';
2436
+		}
2325 2437
 
2326 2438
 		echo '
2327 2439
 				</ul>';
@@ -2382,15 +2494,16 @@  discard block
 block discarded – undo
2382 2494
 			</tr>
2383 2495
 		</table>';
2384 2496
 
2385
-	if ($incontext['require_db_confirm'])
2386
-		echo '
2497
+	if ($incontext['require_db_confirm']) {
2498
+			echo '
2387 2499
 		<h2>', $txt['user_settings_database'], '</h2>
2388 2500
 		<p>', $txt['user_settings_database_info'], '</p>
2389 2501
 
2390 2502
 		<div style="margin-bottom: 2ex; padding-', $txt['lang_rtl'] == false ? 'left' : 'right', ': 50px;">
2391 2503
 			<input type="password" name="password3" size="30" />
2392 2504
 		</div>';
2393
-}
2505
+	}
2506
+	}
2394 2507
 
2395 2508
 // Tell them it's done, and to delete.
2396 2509
 function template_delete_install()
@@ -2403,14 +2516,15 @@  discard block
 block discarded – undo
2403 2516
 	template_warning_divs();
2404 2517
 
2405 2518
 	// Install directory still writable?
2406
-	if ($incontext['dir_still_writable'])
2407
-		echo '
2519
+	if ($incontext['dir_still_writable']) {
2520
+			echo '
2408 2521
 		<em>', $txt['still_writable'], '</em><br>
2409 2522
 		<br>';
2523
+	}
2410 2524
 
2411 2525
 	// Don't show the box if it's like 99% sure it won't work :P.
2412
-	if ($incontext['probably_delete_install'])
2413
-		echo '
2526
+	if ($incontext['probably_delete_install']) {
2527
+			echo '
2414 2528
 		<div style="margin: 1ex; font-weight: bold;">
2415 2529
 			<label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete();" /> ', $txt['delete_installer'], !isset($_SESSION['installer_temp_ftp']) ? ' ' . $txt['delete_installer_maybe'] : '', '</label>
2416 2530
 		</div>
@@ -2426,6 +2540,7 @@  discard block
 block discarded – undo
2426 2540
 			}
2427 2541
 		</script>
2428 2542
 		<br>';
2543
+	}
2429 2544
 
2430 2545
 	echo '
2431 2546
 		', sprintf($txt['go_to_your_forum'], $boardurl . '/index.php'), '<br>
Please login to merge, or discard this patch.
other/upgrade.php 1 patch
Braces   +884 added lines, -649 removed lines patch added patch discarded remove patch
@@ -75,8 +75,9 @@  discard block
 block discarded – undo
75 75
 $upcontext['inactive_timeout'] = 10;
76 76
 
77 77
 // The helper is crucial. Include it first thing.
78
-if (!file_exists($upgrade_path . '/upgrade-helper.php'))
78
+if (!file_exists($upgrade_path . '/upgrade-helper.php')) {
79 79
     die('upgrade-helper.php not found where it was expected: ' . $upgrade_path . '/upgrade-helper.php! Make sure you have uploaded ALL files from the upgrade package. The upgrader cannot continue.');
80
+}
80 81
 
81 82
 require_once($upgrade_path . '/upgrade-helper.php');
82 83
 
@@ -100,11 +101,14 @@  discard block
 block discarded – undo
100 101
 	ini_set('default_socket_timeout', 900);
101 102
 }
102 103
 // Clean the upgrade path if this is from the client.
103
-if (!empty($_SERVER['argv']) && php_sapi_name() == 'cli' && empty($_SERVER['REMOTE_ADDR']))
104
-	for ($i = 1; $i < $_SERVER['argc']; $i++)
104
+if (!empty($_SERVER['argv']) && php_sapi_name() == 'cli' && empty($_SERVER['REMOTE_ADDR'])) {
105
+	for ($i = 1;
106
+}
107
+$i < $_SERVER['argc']; $i++)
105 108
 	{
106
-		if (preg_match('~^--path=(.+)$~', $_SERVER['argv'][$i], $match) != 0)
107
-			$upgrade_path = substr($match[1], -1) == '/' ? substr($match[1], 0, -1) : $match[1];
109
+		if (preg_match('~^--path=(.+)$~', $_SERVER['argv'][$i], $match) != 0) {
110
+					$upgrade_path = substr($match[1], -1) == '/' ? substr($match[1], 0, -1) : $match[1];
111
+		}
108 112
 	}
109 113
 
110 114
 // Are we from the client?
@@ -112,16 +116,17 @@  discard block
 block discarded – undo
112 116
 {
113 117
 	$command_line = true;
114 118
 	$disable_security = true;
115
-}
116
-else
119
+} else {
117 120
 	$command_line = false;
121
+}
118 122
 
119 123
 // Load this now just because we can.
120 124
 require_once($upgrade_path . '/Settings.php');
121 125
 
122 126
 // We don't use "-utf8" anymore...  Tweak the entry that may have been loaded by Settings.php
123
-if (isset($language))
127
+if (isset($language)) {
124 128
 	$language = str_ireplace('-utf8', '', $language);
129
+}
125 130
 
126 131
 // Are we logged in?
127 132
 if (isset($upgradeData))
@@ -129,10 +134,12 @@  discard block
 block discarded – undo
129 134
 	$upcontext['user'] = json_decode(base64_decode($upgradeData), true);
130 135
 
131 136
 	// Check for sensible values.
132
-	if (empty($upcontext['user']['started']) || $upcontext['user']['started'] < time() - 86400)
133
-		$upcontext['user']['started'] = time();
134
-	if (empty($upcontext['user']['updated']) || $upcontext['user']['updated'] < time() - 86400)
135
-		$upcontext['user']['updated'] = 0;
137
+	if (empty($upcontext['user']['started']) || $upcontext['user']['started'] < time() - 86400) {
138
+			$upcontext['user']['started'] = time();
139
+	}
140
+	if (empty($upcontext['user']['updated']) || $upcontext['user']['updated'] < time() - 86400) {
141
+			$upcontext['user']['updated'] = 0;
142
+	}
136 143
 
137 144
 	$upcontext['started'] = $upcontext['user']['started'];
138 145
 	$upcontext['updated'] = $upcontext['user']['updated'];
@@ -197,8 +204,9 @@  discard block
 block discarded – undo
197 204
 			'db_error_skip' => true,
198 205
 		)
199 206
 	);
200
-	while ($row = $smcFunc['db_fetch_assoc']($request))
201
-		$modSettings[$row['variable']] = $row['value'];
207
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
208
+			$modSettings[$row['variable']] = $row['value'];
209
+	}
202 210
 	$smcFunc['db_free_result']($request);
203 211
 }
204 212
 
@@ -208,10 +216,12 @@  discard block
 block discarded – undo
208 216
 	$modSettings['theme_url'] = 'Themes/default';
209 217
 	$modSettings['images_url'] = 'Themes/default/images';
210 218
 }
211
-if (!isset($settings['default_theme_url']))
219
+if (!isset($settings['default_theme_url'])) {
212 220
 	$settings['default_theme_url'] = $modSettings['theme_url'];
213
-if (!isset($settings['default_theme_dir']))
221
+}
222
+if (!isset($settings['default_theme_dir'])) {
214 223
 	$settings['default_theme_dir'] = $modSettings['theme_dir'];
224
+}
215 225
 
216 226
 $upcontext['is_large_forum'] = (empty($modSettings['smfVersion']) || $modSettings['smfVersion'] <= '1.1 RC1') && !empty($modSettings['totalMessages']) && $modSettings['totalMessages'] > 75000;
217 227
 // Default title...
@@ -229,13 +239,15 @@  discard block
 block discarded – undo
229 239
 	$support_js = $upcontext['upgrade_status']['js'];
230 240
 
231 241
 	// Only set this if the upgrader status says so.
232
-	if (empty($is_debug))
233
-		$is_debug = $upcontext['upgrade_status']['debug'];
242
+	if (empty($is_debug)) {
243
+			$is_debug = $upcontext['upgrade_status']['debug'];
244
+	}
234 245
 
235 246
 	// Load the language.
236
-	if (file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'))
237
-		require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php');
238
-}
247
+	if (file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) {
248
+			require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php');
249
+	}
250
+	}
239 251
 // Set the defaults.
240 252
 else
241 253
 {
@@ -253,15 +265,18 @@  discard block
 block discarded – undo
253 265
 }
254 266
 
255 267
 // If this isn't the first stage see whether they are logging in and resuming.
256
-if ($upcontext['current_step'] != 0 || !empty($upcontext['user']['step']))
268
+if ($upcontext['current_step'] != 0 || !empty($upcontext['user']['step'])) {
257 269
 	checkLogin();
270
+}
258 271
 
259
-if ($command_line)
272
+if ($command_line) {
260 273
 	cmdStep0();
274
+}
261 275
 
262 276
 // Don't error if we're using xml.
263
-if (isset($_GET['xml']))
277
+if (isset($_GET['xml'])) {
264 278
 	$upcontext['return_error'] = true;
279
+}
265 280
 
266 281
 // Loop through all the steps doing each one as required.
267 282
 $upcontext['overall_percent'] = 0;
@@ -282,9 +297,9 @@  discard block
 block discarded – undo
282 297
 		}
283 298
 
284 299
 		// Call the step and if it returns false that means pause!
285
-		if (function_exists($step[2]) && $step[2]() === false)
286
-			break;
287
-		elseif (function_exists($step[2])) {
300
+		if (function_exists($step[2]) && $step[2]() === false) {
301
+					break;
302
+		} elseif (function_exists($step[2])) {
288 303
 			//Start each new step with this unset, so the 'normal' template is called first
289 304
 			unset($_GET['xml']);
290 305
 			//Clear out warnings at the start of each step
@@ -330,17 +345,18 @@  discard block
 block discarded – undo
330 345
 		// This should not happen my dear... HELP ME DEVELOPERS!!
331 346
 		if (!empty($command_line))
332 347
 		{
333
-			if (function_exists('debug_print_backtrace'))
334
-				debug_print_backtrace();
348
+			if (function_exists('debug_print_backtrace')) {
349
+							debug_print_backtrace();
350
+			}
335 351
 
336 352
 			echo "\n" . 'Error: Unexpected call to use the ' . (isset($upcontext['sub_template']) ? $upcontext['sub_template'] : '') . ' template. Please copy and paste all the text above and visit the SMF support forum to tell the Developers that they\'ve made a boo boo; they\'ll get you up and running again.';
337 353
 			flush();
338 354
 			die();
339 355
 		}
340 356
 
341
-		if (!isset($_GET['xml']))
342
-			template_upgrade_above();
343
-		else
357
+		if (!isset($_GET['xml'])) {
358
+					template_upgrade_above();
359
+		} else
344 360
 		{
345 361
 			header('Content-Type: text/xml; charset=UTF-8');
346 362
 			// Sadly we need to retain the $_GET data thanks to the old upgrade scripts.
@@ -362,25 +378,29 @@  discard block
 block discarded – undo
362 378
 			$upcontext['form_url'] = $upgradeurl . '?step=' . $upcontext['current_step'] . '&amp;substep=' . $_GET['substep'] . '&amp;data=' . base64_encode(json_encode($upcontext['upgrade_status']));
363 379
 
364 380
 			// Custom stuff to pass back?
365
-			if (!empty($upcontext['query_string']))
366
-				$upcontext['form_url'] .= $upcontext['query_string'];
381
+			if (!empty($upcontext['query_string'])) {
382
+							$upcontext['form_url'] .= $upcontext['query_string'];
383
+			}
367 384
 
368 385
 			// Call the appropriate subtemplate
369
-			if (is_callable('template_' . $upcontext['sub_template']))
370
-				call_user_func('template_' . $upcontext['sub_template']);
371
-			else
372
-				die('Upgrade aborted!  Invalid template: template_' . $upcontext['sub_template']);
386
+			if (is_callable('template_' . $upcontext['sub_template'])) {
387
+							call_user_func('template_' . $upcontext['sub_template']);
388
+			} else {
389
+							die('Upgrade aborted!  Invalid template: template_' . $upcontext['sub_template']);
390
+			}
373 391
 		}
374 392
 
375 393
 		// Was there an error?
376
-		if (!empty($upcontext['forced_error_message']))
377
-			echo $upcontext['forced_error_message'];
394
+		if (!empty($upcontext['forced_error_message'])) {
395
+					echo $upcontext['forced_error_message'];
396
+		}
378 397
 
379 398
 		// Show the footer.
380
-		if (!isset($_GET['xml']))
381
-			template_upgrade_below();
382
-		else
383
-			template_xml_below();
399
+		if (!isset($_GET['xml'])) {
400
+					template_upgrade_below();
401
+		} else {
402
+					template_xml_below();
403
+		}
384 404
 	}
385 405
 
386 406
 
@@ -392,15 +412,19 @@  discard block
 block discarded – undo
392 412
 		$seconds = intval($active % 60);
393 413
 
394 414
 		$totalTime = '';
395
-		if ($hours > 0)
396
-			$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
397
-		if ($minutes > 0)
398
-			$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
399
-		if ($seconds > 0)
400
-			$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
415
+		if ($hours > 0) {
416
+					$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
417
+		}
418
+		if ($minutes > 0) {
419
+					$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
420
+		}
421
+		if ($seconds > 0) {
422
+					$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
423
+		}
401 424
 
402
-		if (!empty($totalTime))
403
-			echo "\n" . 'Upgrade completed in ' . $totalTime . "\n";
425
+		if (!empty($totalTime)) {
426
+					echo "\n" . 'Upgrade completed in ' . $totalTime . "\n";
427
+		}
404 428
 	}
405 429
 
406 430
 	// Bang - gone!
@@ -413,8 +437,9 @@  discard block
 block discarded – undo
413 437
 	global $upgradeurl, $upcontext, $command_line;
414 438
 
415 439
 	// Command line users can't be redirected.
416
-	if ($command_line)
417
-		upgradeExit(true);
440
+	if ($command_line) {
441
+			upgradeExit(true);
442
+	}
418 443
 
419 444
 	// Are we providing the core info?
420 445
 	if ($addForm)
@@ -440,12 +465,14 @@  discard block
 block discarded – undo
440 465
 	define('SMF', 1);
441 466
 
442 467
 	// Start the session.
443
-	if (@ini_get('session.save_handler') == 'user')
444
-		@ini_set('session.save_handler', 'files');
468
+	if (@ini_get('session.save_handler') == 'user') {
469
+			@ini_set('session.save_handler', 'files');
470
+	}
445 471
 	@session_start();
446 472
 
447
-	if (empty($smcFunc))
448
-		$smcFunc = array();
473
+	if (empty($smcFunc)) {
474
+			$smcFunc = array();
475
+	}
449 476
 
450 477
 	// We need this for authentication and some upgrade code
451 478
 	require_once($sourcedir . '/Subs-Auth.php');
@@ -472,24 +499,27 @@  discard block
 block discarded – undo
472 499
 		require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
473 500
 
474 501
 		// Make the connection...
475
-		if (empty($db_connection))
476
-			$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, array('non_fatal' => true));
477
-		else
478
-			// If we've returned here, ping/reconnect to be safe
502
+		if (empty($db_connection)) {
503
+					$db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, array('non_fatal' => true));
504
+		} else {
505
+					// If we've returned here, ping/reconnect to be safe
479 506
 			$smcFunc['db_ping']($db_connection);
507
+		}
480 508
 
481 509
 		// Oh dear god!!
482
-		if ($db_connection === null)
483
-			die('Unable to connect to database - please check username and password are correct in Settings.php');
510
+		if ($db_connection === null) {
511
+					die('Unable to connect to database - please check username and password are correct in Settings.php');
512
+		}
484 513
 
485
-		if ($db_type == 'mysql' && isset($db_character_set) && preg_match('~^\w+$~', $db_character_set) === 1)
486
-			$smcFunc['db_query']('', '
514
+		if ($db_type == 'mysql' && isset($db_character_set) && preg_match('~^\w+$~', $db_character_set) === 1) {
515
+					$smcFunc['db_query']('', '
487 516
 			SET NAMES {string:db_character_set}',
488 517
 			array(
489 518
 				'db_error_skip' => true,
490 519
 				'db_character_set' => $db_character_set,
491 520
 			)
492 521
 		);
522
+		}
493 523
 
494 524
 		// Load the modSettings data...
495 525
 		$request = $smcFunc['db_query']('', '
@@ -500,11 +530,11 @@  discard block
 block discarded – undo
500 530
 			)
501 531
 		);
502 532
 		$modSettings = array();
503
-		while ($row = $smcFunc['db_fetch_assoc']($request))
504
-			$modSettings[$row['variable']] = $row['value'];
533
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
534
+					$modSettings[$row['variable']] = $row['value'];
535
+		}
505 536
 		$smcFunc['db_free_result']($request);
506
-	}
507
-	else
537
+	} else
508 538
 	{
509 539
 		return throw_error('Cannot find ' . $sourcedir . '/Subs-Db-' . $db_type . '.php' . '. Please check you have uploaded all source files and have the correct paths set.');
510 540
 	}
@@ -518,9 +548,10 @@  discard block
 block discarded – undo
518 548
 		cleanRequest();
519 549
 	}
520 550
 
521
-	if (!isset($_GET['substep']))
522
-		$_GET['substep'] = 0;
523
-}
551
+	if (!isset($_GET['substep'])) {
552
+			$_GET['substep'] = 0;
553
+	}
554
+	}
524 555
 
525 556
 function initialize_inputs()
526 557
 {
@@ -550,8 +581,9 @@  discard block
 block discarded – undo
550 581
 		$dh = opendir(dirname(__FILE__));
551 582
 		while ($file = readdir($dh))
552 583
 		{
553
-			if (preg_match('~upgrade_\d-\d_([A-Za-z])+\.sql~i', $file, $matches) && isset($matches[1]))
554
-				@unlink(dirname(__FILE__) . '/' . $file);
584
+			if (preg_match('~upgrade_\d-\d_([A-Za-z])+\.sql~i', $file, $matches) && isset($matches[1])) {
585
+							@unlink(dirname(__FILE__) . '/' . $file);
586
+			}
555 587
 		}
556 588
 		closedir($dh);
557 589
 
@@ -580,8 +612,9 @@  discard block
 block discarded – undo
580 612
 	$temp = 'upgrade_php?step';
581 613
 	while (strlen($temp) > 4)
582 614
 	{
583
-		if (isset($_GET[$temp]))
584
-			unset($_GET[$temp]);
615
+		if (isset($_GET[$temp])) {
616
+					unset($_GET[$temp]);
617
+		}
585 618
 		$temp = substr($temp, 1);
586 619
 	}
587 620
 
@@ -608,32 +641,39 @@  discard block
 block discarded – undo
608 641
 		&& @file_exists(dirname(__FILE__) . '/upgrade_2-1_' . $db_type . '.sql');
609 642
 
610 643
 	// Need legacy scripts?
611
-	if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.1)
612
-		$check &= @file_exists(dirname(__FILE__) . '/upgrade_2-0_' . $db_type . '.sql');
613
-	if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.0)
614
-		$check &= @file_exists(dirname(__FILE__) . '/upgrade_1-1.sql');
615
-	if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 1.1)
616
-		$check &= @file_exists(dirname(__FILE__) . '/upgrade_1-0.sql');
644
+	if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.1) {
645
+			$check &= @file_exists(dirname(__FILE__) . '/upgrade_2-0_' . $db_type . '.sql');
646
+	}
647
+	if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.0) {
648
+			$check &= @file_exists(dirname(__FILE__) . '/upgrade_1-1.sql');
649
+	}
650
+	if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 1.1) {
651
+			$check &= @file_exists(dirname(__FILE__) . '/upgrade_1-0.sql');
652
+	}
617 653
 
618 654
 	// We don't need "-utf8" files anymore...
619 655
 	$upcontext['language'] = str_ireplace('-utf8', '', $upcontext['language']);
620 656
 
621 657
 	// This needs to exist!
622
-	if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'))
623
-		return throw_error('The upgrader could not find the &quot;Install&quot; language file for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded all the files included in the package, even the theme and language files for the default theme.<br>&nbsp;&nbsp;&nbsp;[<a href="' . $upgradeurl . '?lang=english">Try English</a>]');
624
-	else
625
-		require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php');
658
+	if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) {
659
+			return throw_error('The upgrader could not find the &quot;Install&quot; language file for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded all the files included in the package, even the theme and language files for the default theme.<br>&nbsp;&nbsp;&nbsp;[<a href="' . $upgradeurl . '?lang=english">Try English</a>]');
660
+	} else {
661
+			require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php');
662
+	}
626 663
 
627
-	if (!$check)
628
-		// Don't tell them what files exactly because it's a spot check - just like teachers don't tell which problems they are spot checking, that's dumb.
664
+	if (!$check) {
665
+			// Don't tell them what files exactly because it's a spot check - just like teachers don't tell which problems they are spot checking, that's dumb.
629 666
 		return throw_error('The upgrader was unable to find some crucial files.<br><br>Please make sure you uploaded all of the files included in the package, including the Themes, Sources, and other directories.');
667
+	}
630 668
 
631 669
 	// Do they meet the install requirements?
632
-	if (!php_version_check())
633
-		return throw_error('Warning!  You do not appear to have a version of PHP installed on your webserver that meets SMF\'s minimum installations requirements.<br><br>Please ask your host to upgrade.');
670
+	if (!php_version_check()) {
671
+			return throw_error('Warning!  You do not appear to have a version of PHP installed on your webserver that meets SMF\'s minimum installations requirements.<br><br>Please ask your host to upgrade.');
672
+	}
634 673
 
635
-	if (!db_version_check())
636
-		return throw_error('Your ' . $databases[$db_type]['name'] . ' version does not meet the minimum requirements of SMF.<br><br>Please ask your host to upgrade.');
674
+	if (!db_version_check()) {
675
+			return throw_error('Your ' . $databases[$db_type]['name'] . ' version does not meet the minimum requirements of SMF.<br><br>Please ask your host to upgrade.');
676
+	}
637 677
 
638 678
 	// Do some checks to make sure they have proper privileges
639 679
 	db_extend('packages');
@@ -648,14 +688,16 @@  discard block
 block discarded – undo
648 688
 	$drop = $smcFunc['db_drop_table']('{db_prefix}priv_check');
649 689
 
650 690
 	// Sorry... we need CREATE, ALTER and DROP
651
-	if (!$create || !$alter || !$drop)
652
-		return throw_error('The ' . $databases[$db_type]['name'] . ' user you have set in Settings.php does not have proper privileges.<br><br>Please ask your host to give this user the ALTER, CREATE, and DROP privileges.');
691
+	if (!$create || !$alter || !$drop) {
692
+			return throw_error('The ' . $databases[$db_type]['name'] . ' user you have set in Settings.php does not have proper privileges.<br><br>Please ask your host to give this user the ALTER, CREATE, and DROP privileges.');
693
+	}
653 694
 
654 695
 	// Do a quick version spot check.
655 696
 	$temp = substr(@implode('', @file($boarddir . '/index.php')), 0, 4096);
656 697
 	preg_match('~\*\s@version\s+(.+)[\s]{2}~i', $temp, $match);
657
-	if (empty($match[1]) || (trim($match[1]) != SMF_VERSION))
658
-		return throw_error('The upgrader found some old or outdated files.<br><br>Please make certain you uploaded the new versions of all the files included in the package.');
698
+	if (empty($match[1]) || (trim($match[1]) != SMF_VERSION)) {
699
+			return throw_error('The upgrader found some old or outdated files.<br><br>Please make certain you uploaded the new versions of all the files included in the package.');
700
+	}
659 701
 
660 702
 	// What absolutely needs to be writable?
661 703
 	$writable_files = array(
@@ -677,12 +719,13 @@  discard block
 block discarded – undo
677 719
 	quickFileWritable($custom_av_dir);
678 720
 
679 721
 	// Are we good now?
680
-	if (!is_writable($custom_av_dir))
681
-		return throw_error(sprintf('The directory: %1$s has to be writable to continue the upgrade. Please make sure permissions are correctly set to allow this.', $custom_av_dir));
682
-	elseif ($need_settings_update)
722
+	if (!is_writable($custom_av_dir)) {
723
+			return throw_error(sprintf('The directory: %1$s has to be writable to continue the upgrade. Please make sure permissions are correctly set to allow this.', $custom_av_dir));
724
+	} elseif ($need_settings_update)
683 725
 	{
684
-		if (!function_exists('cache_put_data'))
685
-			require_once($sourcedir . '/Load.php');
726
+		if (!function_exists('cache_put_data')) {
727
+					require_once($sourcedir . '/Load.php');
728
+		}
686 729
 		updateSettings(array('custom_avatar_dir' => $custom_av_dir));
687 730
 		updateSettings(array('custom_avatar_url' => $custom_av_url));
688 731
 	}
@@ -691,28 +734,33 @@  discard block
 block discarded – undo
691 734
 
692 735
 	// Check the cache directory.
693 736
 	$cachedir_temp = empty($cachedir) ? $boarddir . '/cache' : $cachedir;
694
-	if (!file_exists($cachedir_temp))
695
-		@mkdir($cachedir_temp);
696
-	if (!file_exists($cachedir_temp))
697
-		return throw_error('The cache directory could not be found.<br><br>Please make sure you have a directory called &quot;cache&quot; in your forum directory before continuing.');
698
-
699
-	if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang']))
700
-		return throw_error('The upgrader was unable to find language files for the language specified in Settings.php.<br>SMF will not work without the primary language files installed.<br><br>Please either install them, or <a href="' . $upgradeurl . '?step=0;lang=english">use english instead</a>.');
701
-	elseif (!isset($_GET['skiplang']))
737
+	if (!file_exists($cachedir_temp)) {
738
+			@mkdir($cachedir_temp);
739
+	}
740
+	if (!file_exists($cachedir_temp)) {
741
+			return throw_error('The cache directory could not be found.<br><br>Please make sure you have a directory called &quot;cache&quot; in your forum directory before continuing.');
742
+	}
743
+
744
+	if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang'])) {
745
+			return throw_error('The upgrader was unable to find language files for the language specified in Settings.php.<br>SMF will not work without the primary language files installed.<br><br>Please either install them, or <a href="' . $upgradeurl . '?step=0;lang=english">use english instead</a>.');
746
+	} elseif (!isset($_GET['skiplang']))
702 747
 	{
703 748
 		$temp = substr(@implode('', @file($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php')), 0, 4096);
704 749
 		preg_match('~(?://|/\*)\s*Version:\s+(.+?);\s*index(?:[\s]{2}|\*/)~i', $temp, $match);
705 750
 
706
-		if (empty($match[1]) || $match[1] != SMF_LANG_VERSION)
707
-			return throw_error('The upgrader found some old or outdated language files, for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded the new versions of all the files included in the package, even the theme and language files for the default theme.<br>&nbsp;&nbsp;&nbsp;[<a href="' . $upgradeurl . '?skiplang">SKIP</a>] [<a href="' . $upgradeurl . '?lang=english">Try English</a>]');
751
+		if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) {
752
+					return throw_error('The upgrader found some old or outdated language files, for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded the new versions of all the files included in the package, even the theme and language files for the default theme.<br>&nbsp;&nbsp;&nbsp;[<a href="' . $upgradeurl . '?skiplang">SKIP</a>] [<a href="' . $upgradeurl . '?lang=english">Try English</a>]');
753
+		}
708 754
 	}
709 755
 
710
-	if (!makeFilesWritable($writable_files))
711
-		return false;
756
+	if (!makeFilesWritable($writable_files)) {
757
+			return false;
758
+	}
712 759
 
713 760
 	// Check agreement.txt. (it may not exist, in which case $boarddir must be writable.)
714
-	if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt'))
715
-		return throw_error('The upgrader was unable to obtain write access to agreement.txt.<br><br>If you are using a linux or unix based server, please ensure that the file is chmod\'d to 777, or if it does not exist that the directory this upgrader is in is 777.<br>If your server is running Windows, please ensure that the internet guest account has the proper permissions on it or its folder.');
761
+	if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt')) {
762
+			return throw_error('The upgrader was unable to obtain write access to agreement.txt.<br><br>If you are using a linux or unix based server, please ensure that the file is chmod\'d to 777, or if it does not exist that the directory this upgrader is in is 777.<br>If your server is running Windows, please ensure that the internet guest account has the proper permissions on it or its folder.');
763
+	}
716 764
 
717 765
 	// Upgrade the agreement.
718 766
 	elseif (isset($modSettings['agreement']))
@@ -723,8 +771,8 @@  discard block
 block discarded – undo
723 771
 	}
724 772
 
725 773
 	// We're going to check that their board dir setting is right in case they've been moving stuff around.
726
-	if (strtr($boarddir, array('/' => '', '\\' => '')) != strtr(dirname(__FILE__), array('/' => '', '\\' => '')))
727
-		$upcontext['warning'] = '
774
+	if (strtr($boarddir, array('/' => '', '\\' => '')) != strtr(dirname(__FILE__), array('/' => '', '\\' => ''))) {
775
+			$upcontext['warning'] = '
728 776
 			It looks as if your board directory settings <em>might</em> be incorrect. Your board directory is currently set to &quot;' . $boarddir . '&quot; but should probably be &quot;' . dirname(__FILE__) . '&quot;. Settings.php currently lists your paths as:<br>
729 777
 			<ul>
730 778
 				<li>Board Directory: ' . $boarddir . '</li>
@@ -732,19 +780,23 @@  discard block
 block discarded – undo
732 780
 				<li>Cache Directory: ' . $cachedir_temp . '</li>
733 781
 			</ul>
734 782
 			If these seem incorrect please open Settings.php in a text editor before proceeding with this upgrade. If they are incorrect due to you moving your forum to a new location please download and execute the <a href="https://download.simplemachines.org/?tools">Repair Settings</a> tool from the Simple Machines website before continuing.';
783
+	}
735 784
 
736 785
 	// Confirm mbstring is loaded...
737
-	if (!extension_loaded('mbstring'))
738
-		return throw_error($txt['install_no_mbstring']);
786
+	if (!extension_loaded('mbstring')) {
787
+			return throw_error($txt['install_no_mbstring']);
788
+	}
739 789
 
740 790
 	// Check for https stream support.
741 791
 	$supported_streams = stream_get_wrappers();
742
-	if (!in_array('https', $supported_streams))
743
-		$upcontext['custom_warning'] = $txt['install_no_https'];
792
+	if (!in_array('https', $supported_streams)) {
793
+			$upcontext['custom_warning'] = $txt['install_no_https'];
794
+	}
744 795
 
745 796
 	// Either we're logged in or we're going to present the login.
746
-	if (checkLogin())
747
-		return true;
797
+	if (checkLogin()) {
798
+			return true;
799
+	}
748 800
 
749 801
 	$upcontext += createToken('login');
750 802
 
@@ -758,15 +810,17 @@  discard block
 block discarded – undo
758 810
 	global $smcFunc, $db_type, $support_js;
759 811
 
760 812
 	// Don't bother if the security is disabled.
761
-	if ($disable_security)
762
-		return true;
813
+	if ($disable_security) {
814
+			return true;
815
+	}
763 816
 
764 817
 	// Are we trying to login?
765 818
 	if (isset($_POST['contbutt']) && (!empty($_POST['user'])))
766 819
 	{
767 820
 		// If we've disabled security pick a suitable name!
768
-		if (empty($_POST['user']))
769
-			$_POST['user'] = 'Administrator';
821
+		if (empty($_POST['user'])) {
822
+					$_POST['user'] = 'Administrator';
823
+		}
770 824
 
771 825
 		// Before 2.0 these column names were different!
772 826
 		$oldDB = false;
@@ -781,16 +835,17 @@  discard block
 block discarded – undo
781 835
 					'db_error_skip' => true,
782 836
 				)
783 837
 			);
784
-			if ($smcFunc['db_num_rows']($request) != 0)
785
-				$oldDB = true;
838
+			if ($smcFunc['db_num_rows']($request) != 0) {
839
+							$oldDB = true;
840
+			}
786 841
 			$smcFunc['db_free_result']($request);
787 842
 		}
788 843
 
789 844
 		// Get what we believe to be their details.
790 845
 		if (!$disable_security)
791 846
 		{
792
-			if ($oldDB)
793
-				$request = $smcFunc['db_query']('', '
847
+			if ($oldDB) {
848
+							$request = $smcFunc['db_query']('', '
794 849
 					SELECT id_member, memberName AS member_name, passwd, id_group,
795 850
 					additionalGroups AS additional_groups, lngfile
796 851
 					FROM {db_prefix}members
@@ -800,8 +855,8 @@  discard block
 block discarded – undo
800 855
 						'db_error_skip' => true,
801 856
 					)
802 857
 				);
803
-			else
804
-				$request = $smcFunc['db_query']('', '
858
+			} else {
859
+							$request = $smcFunc['db_query']('', '
805 860
 					SELECT id_member, member_name, passwd, id_group, additional_groups, lngfile
806 861
 					FROM {db_prefix}members
807 862
 					WHERE member_name = {string:member_name}',
@@ -810,6 +865,7 @@  discard block
 block discarded – undo
810 865
 						'db_error_skip' => true,
811 866
 					)
812 867
 				);
868
+			}
813 869
 			if ($smcFunc['db_num_rows']($request) != 0)
814 870
 			{
815 871
 				list ($id_member, $name, $password, $id_group, $addGroups, $user_language) = $smcFunc['db_fetch_row']($request);
@@ -817,16 +873,17 @@  discard block
 block discarded – undo
817 873
 				$groups = explode(',', $addGroups);
818 874
 				$groups[] = $id_group;
819 875
 
820
-				foreach ($groups as $k => $v)
821
-					$groups[$k] = (int) $v;
876
+				foreach ($groups as $k => $v) {
877
+									$groups[$k] = (int) $v;
878
+				}
822 879
 
823 880
 				$sha_passwd = sha1(strtolower($name) . un_htmlspecialchars($_REQUEST['passwrd']));
824 881
 
825 882
 				// We don't use "-utf8" anymore...
826 883
 				$user_language = str_ireplace('-utf8', '', $user_language);
884
+			} else {
885
+							$upcontext['username_incorrect'] = true;
827 886
 			}
828
-			else
829
-				$upcontext['username_incorrect'] = true;
830 887
 			$smcFunc['db_free_result']($request);
831 888
 		}
832 889
 		$upcontext['username'] = $_POST['user'];
@@ -836,13 +893,14 @@  discard block
 block discarded – undo
836 893
 		{
837 894
 			$upcontext['upgrade_status']['js'] = 1;
838 895
 			$support_js = 1;
896
+		} else {
897
+					$support_js = 0;
839 898
 		}
840
-		else
841
-			$support_js = 0;
842 899
 
843 900
 		// Note down the version we are coming from.
844
-		if (!empty($modSettings['smfVersion']) && empty($upcontext['user']['version']))
845
-			$upcontext['user']['version'] = $modSettings['smfVersion'];
901
+		if (!empty($modSettings['smfVersion']) && empty($upcontext['user']['version'])) {
902
+					$upcontext['user']['version'] = $modSettings['smfVersion'];
903
+		}
846 904
 
847 905
 		// Didn't get anywhere?
848 906
 		if (!$disable_security && (empty($sha_passwd) || (!empty($password) ? $password : '') != $sha_passwd) && !hash_verify_password((!empty($name) ? $name : ''), $_REQUEST['passwrd'], (!empty($password) ? $password : '')) && empty($upcontext['username_incorrect']))
@@ -876,15 +934,15 @@  discard block
 block discarded – undo
876 934
 							'db_error_skip' => true,
877 935
 						)
878 936
 					);
879
-					if ($smcFunc['db_num_rows']($request) == 0)
880
-						return throw_error('You need to be an admin to perform an upgrade!');
937
+					if ($smcFunc['db_num_rows']($request) == 0) {
938
+											return throw_error('You need to be an admin to perform an upgrade!');
939
+					}
881 940
 					$smcFunc['db_free_result']($request);
882 941
 				}
883 942
 
884 943
 				$upcontext['user']['id'] = $id_member;
885 944
 				$upcontext['user']['name'] = $name;
886
-			}
887
-			else
945
+			} else
888 946
 			{
889 947
 				$upcontext['user']['id'] = 1;
890 948
 				$upcontext['user']['name'] = 'Administrator';
@@ -900,11 +958,11 @@  discard block
 block discarded – undo
900 958
 				$temp = substr(@implode('', @file($modSettings['theme_dir'] . '/languages/index.' . $user_language . '.php')), 0, 4096);
901 959
 				preg_match('~(?://|/\*)\s*Version:\s+(.+?);\s*index(?:[\s]{2}|\*/)~i', $temp, $match);
902 960
 
903
-				if (empty($match[1]) || $match[1] != SMF_LANG_VERSION)
904
-					$upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been updated to the latest version. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.';
905
-				elseif (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . basename($user_language, '.lng') . '.php'))
906
-					$upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been uploaded/updated as the &quot;Install&quot; language file is missing. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.';
907
-				else
961
+				if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) {
962
+									$upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been updated to the latest version. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.';
963
+				} elseif (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . basename($user_language, '.lng') . '.php')) {
964
+									$upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been uploaded/updated as the &quot;Install&quot; language file is missing. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.';
965
+				} else
908 966
 				{
909 967
 					// Set this as the new language.
910 968
 					$upcontext['language'] = $user_language;
@@ -948,8 +1006,9 @@  discard block
 block discarded – undo
948 1006
 	unset($member_columns);
949 1007
 
950 1008
 	// If we've not submitted then we're done.
951
-	if (empty($_POST['upcont']))
952
-		return false;
1009
+	if (empty($_POST['upcont'])) {
1010
+			return false;
1011
+	}
953 1012
 
954 1013
 	// Firstly, if they're enabling SM stat collection just do it.
955 1014
 	if (!empty($_POST['stats']) && substr($boardurl, 0, 16) != 'http://localhost' && empty($modSettings['allow_sm_stats']) && empty($modSettings['enable_sm_stats']))
@@ -969,16 +1028,17 @@  discard block
 block discarded – undo
969 1028
 				fwrite($fp, $out);
970 1029
 
971 1030
 				$return_data = '';
972
-				while (!feof($fp))
973
-					$return_data .= fgets($fp, 128);
1031
+				while (!feof($fp)) {
1032
+									$return_data .= fgets($fp, 128);
1033
+				}
974 1034
 
975 1035
 				fclose($fp);
976 1036
 
977 1037
 				// Get the unique site ID.
978 1038
 				preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID);
979 1039
 
980
-				if (!empty($ID[1]))
981
-					$smcFunc['db_insert']('replace',
1040
+				if (!empty($ID[1])) {
1041
+									$smcFunc['db_insert']('replace',
982 1042
 						$db_prefix . 'settings',
983 1043
 						array('variable' => 'string', 'value' => 'string'),
984 1044
 						array(
@@ -987,9 +1047,9 @@  discard block
 block discarded – undo
987 1047
 						),
988 1048
 						array('variable')
989 1049
 					);
1050
+				}
990 1051
 			}
991
-		}
992
-		else
1052
+		} else
993 1053
 		{
994 1054
 			$smcFunc['db_insert']('replace',
995 1055
 				$db_prefix . 'settings',
@@ -1000,8 +1060,8 @@  discard block
 block discarded – undo
1000 1060
 		}
1001 1061
 	}
1002 1062
 	// Don't remove stat collection unless we unchecked the box for real, not from the loop.
1003
-	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats']))
1004
-		$smcFunc['db_query']('', '
1063
+	elseif (empty($_POST['stats']) && empty($upcontext['allow_sm_stats'])) {
1064
+			$smcFunc['db_query']('', '
1005 1065
 			DELETE FROM {db_prefix}settings
1006 1066
 			WHERE variable = {string:enable_sm_stats}',
1007 1067
 			array(
@@ -1009,6 +1069,7 @@  discard block
 block discarded – undo
1009 1069
 				'db_error_skip' => true,
1010 1070
 			)
1011 1071
 		);
1072
+	}
1012 1073
 
1013 1074
 	// Deleting old karma stuff?
1014 1075
 	if (!empty($_POST['delete_karma']))
@@ -1023,20 +1084,22 @@  discard block
 block discarded – undo
1023 1084
 		);
1024 1085
 
1025 1086
 		// Cleaning up old karma member settings.
1026
-		if ($upcontext['karma_installed']['good'])
1027
-			$smcFunc['db_query']('', '
1087
+		if ($upcontext['karma_installed']['good']) {
1088
+					$smcFunc['db_query']('', '
1028 1089
 				ALTER TABLE {db_prefix}members
1029 1090
 				DROP karma_good',
1030 1091
 				array()
1031 1092
 			);
1093
+		}
1032 1094
 
1033 1095
 		// Does karma bad was enable?
1034
-		if ($upcontext['karma_installed']['bad'])
1035
-			$smcFunc['db_query']('', '
1096
+		if ($upcontext['karma_installed']['bad']) {
1097
+					$smcFunc['db_query']('', '
1036 1098
 				ALTER TABLE {db_prefix}members
1037 1099
 				DROP karma_bad',
1038 1100
 				array()
1039 1101
 			);
1102
+		}
1040 1103
 
1041 1104
 		// Cleaning up old karma permissions.
1042 1105
 		$smcFunc['db_query']('', '
@@ -1049,32 +1112,37 @@  discard block
 block discarded – undo
1049 1112
 	}
1050 1113
 
1051 1114
 	// Emptying the error log?
1052
-	if (!empty($_POST['empty_error']))
1053
-		$smcFunc['db_query']('truncate_table', '
1115
+	if (!empty($_POST['empty_error'])) {
1116
+			$smcFunc['db_query']('truncate_table', '
1054 1117
 			TRUNCATE {db_prefix}log_errors',
1055 1118
 			array(
1056 1119
 			)
1057 1120
 		);
1121
+	}
1058 1122
 
1059 1123
 	$changes = array();
1060 1124
 
1061 1125
 	// Add proxy settings.
1062
-	if (!isset($GLOBALS['image_proxy_maxsize']))
1063
-		$changes += array(
1126
+	if (!isset($GLOBALS['image_proxy_maxsize'])) {
1127
+			$changes += array(
1064 1128
 			'image_proxy_secret' => '\'' . substr(sha1(mt_rand()), 0, 20) . '\'',
1065 1129
 			'image_proxy_maxsize' => 5190,
1066 1130
 			'image_proxy_enabled' => 0,
1067 1131
 		);
1132
+	}
1068 1133
 
1069 1134
 	// If $boardurl reflects https, set force_ssl
1070
-	if (!function_exists('cache_put_data'))
1071
-		require_once($sourcedir . '/Load.php');
1072
-	if (stripos($boardurl, 'https://') !== false)
1073
-		updateSettings(array('force_ssl' => '2'));
1135
+	if (!function_exists('cache_put_data')) {
1136
+			require_once($sourcedir . '/Load.php');
1137
+	}
1138
+	if (stripos($boardurl, 'https://') !== false) {
1139
+			updateSettings(array('force_ssl' => '2'));
1140
+	}
1074 1141
 
1075 1142
 	// If we're overriding the language follow it through.
1076
-	if (isset($_GET['lang']) && file_exists($modSettings['theme_dir'] . '/languages/index.' . $_GET['lang'] . '.php'))
1077
-		$changes['language'] = '\'' . $_GET['lang'] . '\'';
1143
+	if (isset($_GET['lang']) && file_exists($modSettings['theme_dir'] . '/languages/index.' . $_GET['lang'] . '.php')) {
1144
+			$changes['language'] = '\'' . $_GET['lang'] . '\'';
1145
+	}
1078 1146
 
1079 1147
 	if (!empty($_POST['maint']))
1080 1148
 	{
@@ -1086,26 +1154,29 @@  discard block
 block discarded – undo
1086 1154
 		{
1087 1155
 			$changes['mtitle'] = '\'' . addslashes($_POST['maintitle']) . '\'';
1088 1156
 			$changes['mmessage'] = '\'' . addslashes($_POST['mainmessage']) . '\'';
1089
-		}
1090
-		else
1157
+		} else
1091 1158
 		{
1092 1159
 			$changes['mtitle'] = '\'Upgrading the forum...\'';
1093 1160
 			$changes['mmessage'] = '\'Don\\\'t worry, we will be back shortly with an updated forum.  It will only be a minute ;).\'';
1094 1161
 		}
1095 1162
 	}
1096 1163
 
1097
-	if ($command_line)
1098
-		echo ' * Updating Settings.php...';
1164
+	if ($command_line) {
1165
+			echo ' * Updating Settings.php...';
1166
+	}
1099 1167
 
1100 1168
 	// Fix some old paths.
1101
-	if (substr($boarddir, 0, 1) == '.')
1102
-		$changes['boarddir'] = '\'' . fixRelativePath($boarddir) . '\'';
1169
+	if (substr($boarddir, 0, 1) == '.') {
1170
+			$changes['boarddir'] = '\'' . fixRelativePath($boarddir) . '\'';
1171
+	}
1103 1172
 
1104
-	if (substr($sourcedir, 0, 1) == '.')
1105
-		$changes['sourcedir'] = '\'' . fixRelativePath($sourcedir) . '\'';
1173
+	if (substr($sourcedir, 0, 1) == '.') {
1174
+			$changes['sourcedir'] = '\'' . fixRelativePath($sourcedir) . '\'';
1175
+	}
1106 1176
 
1107
-	if (empty($cachedir) || substr($cachedir, 0, 1) == '.')
1108
-		$changes['cachedir'] = '\'' . fixRelativePath($boarddir) . '/cache\'';
1177
+	if (empty($cachedir) || substr($cachedir, 0, 1) == '.') {
1178
+			$changes['cachedir'] = '\'' . fixRelativePath($boarddir) . '/cache\'';
1179
+	}
1109 1180
 
1110 1181
 	// If they have a "host:port" setup for the host, split that into separate values
1111 1182
 	// You should never have a : in the hostname if you're not on MySQL, but better safe than sorry
@@ -1116,32 +1187,36 @@  discard block
 block discarded – undo
1116 1187
 		$changes['db_server'] = '\'' . $db_server . '\'';
1117 1188
 
1118 1189
 		// Only set this if we're not using the default port
1119
-		if ($db_port != ini_get('mysqli.default_port'))
1120
-			$changes['db_port'] = (int) $db_port;
1121
-	}
1122
-	elseif (!empty($db_port))
1190
+		if ($db_port != ini_get('mysqli.default_port')) {
1191
+					$changes['db_port'] = (int) $db_port;
1192
+		}
1193
+	} elseif (!empty($db_port))
1123 1194
 	{
1124 1195
 		// If db_port is set and is the same as the default, set it to ''
1125 1196
 		if ($db_type == 'mysql')
1126 1197
 		{
1127
-			if ($db_port == ini_get('mysqli.default_port'))
1128
-				$changes['db_port'] = '\'\'';
1129
-			elseif ($db_type == 'postgresql' && $db_port == 5432)
1130
-				$changes['db_port'] = '\'\'';
1198
+			if ($db_port == ini_get('mysqli.default_port')) {
1199
+							$changes['db_port'] = '\'\'';
1200
+			} elseif ($db_type == 'postgresql' && $db_port == 5432) {
1201
+							$changes['db_port'] = '\'\'';
1202
+			}
1131 1203
 		}
1132 1204
 	}
1133 1205
 
1134 1206
 	// Maybe we haven't had this option yet?
1135
-	if (empty($packagesdir))
1136
-		$changes['packagesdir'] = '\'' . fixRelativePath($boarddir) . '/Packages\'';
1207
+	if (empty($packagesdir)) {
1208
+			$changes['packagesdir'] = '\'' . fixRelativePath($boarddir) . '/Packages\'';
1209
+	}
1137 1210
 
1138 1211
 	// Add support for $tasksdir var.
1139
-	if (empty($tasksdir))
1140
-		$changes['tasksdir'] = '\'' . fixRelativePath($sourcedir) . '/tasks\'';
1212
+	if (empty($tasksdir)) {
1213
+			$changes['tasksdir'] = '\'' . fixRelativePath($sourcedir) . '/tasks\'';
1214
+	}
1141 1215
 
1142 1216
 	// Make sure we fix the language as well.
1143
-	if (stristr($language, '-utf8'))
1144
-		$changes['language'] = '\'' . str_ireplace('-utf8', '', $language) . '\'';
1217
+	if (stristr($language, '-utf8')) {
1218
+			$changes['language'] = '\'' . str_ireplace('-utf8', '', $language) . '\'';
1219
+	}
1145 1220
 
1146 1221
 	// @todo Maybe change the cookie name if going to 1.1, too?
1147 1222
 
@@ -1149,8 +1224,9 @@  discard block
 block discarded – undo
1149 1224
 	require_once($sourcedir . '/Subs-Admin.php');
1150 1225
 	updateSettingsFile($changes);
1151 1226
 
1152
-	if ($command_line)
1153
-		echo ' Successful.' . "\n";
1227
+	if ($command_line) {
1228
+			echo ' Successful.' . "\n";
1229
+	}
1154 1230
 
1155 1231
 	// Are we doing debug?
1156 1232
 	if (isset($_POST['debug']))
@@ -1160,8 +1236,9 @@  discard block
 block discarded – undo
1160 1236
 	}
1161 1237
 
1162 1238
 	// If we're not backing up then jump one.
1163
-	if (empty($_POST['backup']))
1164
-		$upcontext['current_step']++;
1239
+	if (empty($_POST['backup'])) {
1240
+			$upcontext['current_step']++;
1241
+	}
1165 1242
 
1166 1243
 	// If we've got here then let's proceed to the next step!
1167 1244
 	return true;
@@ -1176,8 +1253,9 @@  discard block
 block discarded – undo
1176 1253
 	$upcontext['page_title'] = 'Backup Database';
1177 1254
 
1178 1255
 	// Done it already - js wise?
1179
-	if (!empty($_POST['backup_done']))
1180
-		return true;
1256
+	if (!empty($_POST['backup_done'])) {
1257
+			return true;
1258
+	}
1181 1259
 
1182 1260
 	// Some useful stuff here.
1183 1261
 	db_extend();
@@ -1191,9 +1269,10 @@  discard block
 block discarded – undo
1191 1269
 	$tables = $smcFunc['db_list_tables']($db, $filter);
1192 1270
 
1193 1271
 	$table_names = array();
1194
-	foreach ($tables as $table)
1195
-		if (substr($table, 0, 7) !== 'backup_')
1272
+	foreach ($tables as $table) {
1273
+			if (substr($table, 0, 7) !== 'backup_')
1196 1274
 			$table_names[] = $table;
1275
+	}
1197 1276
 
1198 1277
 	$upcontext['table_count'] = count($table_names);
1199 1278
 	$upcontext['cur_table_num'] = $_GET['substep'];
@@ -1203,12 +1282,14 @@  discard block
 block discarded – undo
1203 1282
 	$file_steps = $upcontext['table_count'];
1204 1283
 
1205 1284
 	// What ones have we already done?
1206
-	foreach ($table_names as $id => $table)
1207
-		if ($id < $_GET['substep'])
1285
+	foreach ($table_names as $id => $table) {
1286
+			if ($id < $_GET['substep'])
1208 1287
 			$upcontext['previous_tables'][] = $table;
1288
+	}
1209 1289
 
1210
-	if ($command_line)
1211
-		echo 'Backing Up Tables.';
1290
+	if ($command_line) {
1291
+			echo 'Backing Up Tables.';
1292
+	}
1212 1293
 
1213 1294
 	// If we don't support javascript we backup here.
1214 1295
 	if (!$support_js || isset($_GET['xml']))
@@ -1227,8 +1308,9 @@  discard block
 block discarded – undo
1227 1308
 			backupTable($table_names[$substep]);
1228 1309
 
1229 1310
 			// If this is XML to keep it nice for the user do one table at a time anyway!
1230
-			if (isset($_GET['xml']))
1231
-				return upgradeExit();
1311
+			if (isset($_GET['xml'])) {
1312
+							return upgradeExit();
1313
+			}
1232 1314
 		}
1233 1315
 
1234 1316
 		if ($command_line)
@@ -1261,9 +1343,10 @@  discard block
 block discarded – undo
1261 1343
 
1262 1344
 	$smcFunc['db_backup_table']($table, 'backup_' . $table);
1263 1345
 
1264
-	if ($command_line)
1265
-		echo ' done.';
1266
-}
1346
+	if ($command_line) {
1347
+			echo ' done.';
1348
+	}
1349
+	}
1267 1350
 
1268 1351
 // Step 2: Everything.
1269 1352
 function DatabaseChanges()
@@ -1272,8 +1355,9 @@  discard block
 block discarded – undo
1272 1355
 	global $upcontext, $support_js, $db_type;
1273 1356
 
1274 1357
 	// Have we just completed this?
1275
-	if (!empty($_POST['database_done']))
1276
-		return true;
1358
+	if (!empty($_POST['database_done'])) {
1359
+			return true;
1360
+	}
1277 1361
 
1278 1362
 	$upcontext['sub_template'] = isset($_GET['xml']) ? 'database_xml' : 'database_changes';
1279 1363
 	$upcontext['page_title'] = 'Database Changes';
@@ -1288,15 +1372,16 @@  discard block
 block discarded – undo
1288 1372
 	);
1289 1373
 
1290 1374
 	// How many files are there in total?
1291
-	if (isset($_GET['filecount']))
1292
-		$upcontext['file_count'] = (int) $_GET['filecount'];
1293
-	else
1375
+	if (isset($_GET['filecount'])) {
1376
+			$upcontext['file_count'] = (int) $_GET['filecount'];
1377
+	} else
1294 1378
 	{
1295 1379
 		$upcontext['file_count'] = 0;
1296 1380
 		foreach ($files as $file)
1297 1381
 		{
1298
-			if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < $file[1])
1299
-				$upcontext['file_count']++;
1382
+			if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < $file[1]) {
1383
+							$upcontext['file_count']++;
1384
+			}
1300 1385
 		}
1301 1386
 	}
1302 1387
 
@@ -1306,9 +1391,9 @@  discard block
 block discarded – undo
1306 1391
 	$upcontext['cur_file_num'] = 0;
1307 1392
 	foreach ($files as $file)
1308 1393
 	{
1309
-		if ($did_not_do)
1310
-			$did_not_do--;
1311
-		else
1394
+		if ($did_not_do) {
1395
+					$did_not_do--;
1396
+		} else
1312 1397
 		{
1313 1398
 			$upcontext['cur_file_num']++;
1314 1399
 			$upcontext['cur_file_name'] = $file[0];
@@ -1335,12 +1420,13 @@  discard block
 block discarded – undo
1335 1420
 					// Flag to move on to the next.
1336 1421
 					$upcontext['completed_step'] = true;
1337 1422
 					// Did we complete the whole file?
1338
-					if ($nextFile)
1339
-						$upcontext['current_debug_item_num'] = -1;
1423
+					if ($nextFile) {
1424
+											$upcontext['current_debug_item_num'] = -1;
1425
+					}
1340 1426
 					return upgradeExit();
1427
+				} elseif ($support_js) {
1428
+									break;
1341 1429
 				}
1342
-				elseif ($support_js)
1343
-					break;
1344 1430
 			}
1345 1431
 			// Set the progress bar to be right as if we had - even if we hadn't...
1346 1432
 			$upcontext['step_progress'] = ($upcontext['cur_file_num'] / $upcontext['file_count']) * 100;
@@ -1365,8 +1451,9 @@  discard block
 block discarded – undo
1365 1451
 	global $command_line, $language, $upcontext, $sourcedir, $forum_version, $user_info, $maintenance, $smcFunc, $db_type;
1366 1452
 
1367 1453
 	// Now it's nice to have some of the basic SMF source files.
1368
-	if (!isset($_GET['ssi']) && !$command_line)
1369
-		redirectLocation('&ssi=1');
1454
+	if (!isset($_GET['ssi']) && !$command_line) {
1455
+			redirectLocation('&ssi=1');
1456
+	}
1370 1457
 
1371 1458
 	$upcontext['sub_template'] = 'upgrade_complete';
1372 1459
 	$upcontext['page_title'] = 'Upgrade Complete';
@@ -1382,14 +1469,16 @@  discard block
 block discarded – undo
1382 1469
 	// Are we in maintenance mode?
1383 1470
 	if (isset($upcontext['user']['main']))
1384 1471
 	{
1385
-		if ($command_line)
1386
-			echo ' * ';
1472
+		if ($command_line) {
1473
+					echo ' * ';
1474
+		}
1387 1475
 		$upcontext['removed_maintenance'] = true;
1388 1476
 		$changes['maintenance'] = $upcontext['user']['main'];
1389 1477
 	}
1390 1478
 	// Otherwise if somehow we are in 2 let's go to 1.
1391
-	elseif (!empty($maintenance) && $maintenance == 2)
1392
-		$changes['maintenance'] = 1;
1479
+	elseif (!empty($maintenance) && $maintenance == 2) {
1480
+			$changes['maintenance'] = 1;
1481
+	}
1393 1482
 
1394 1483
 	// Wipe this out...
1395 1484
 	$upcontext['user'] = array();
@@ -1404,9 +1493,9 @@  discard block
 block discarded – undo
1404 1493
 	$upcontext['can_delete_script'] = is_writable(dirname(__FILE__)) || is_writable(__FILE__);
1405 1494
 
1406 1495
 	// Now is the perfect time to fetch the SM files.
1407
-	if ($command_line)
1408
-		cli_scheduled_fetchSMfiles();
1409
-	else
1496
+	if ($command_line) {
1497
+			cli_scheduled_fetchSMfiles();
1498
+	} else
1410 1499
 	{
1411 1500
 		require_once($sourcedir . '/ScheduledTasks.php');
1412 1501
 		$forum_version = SMF_VERSION; // The variable is usually defined in index.php so lets just use the constant to do it for us.
@@ -1414,8 +1503,9 @@  discard block
 block discarded – undo
1414 1503
 	}
1415 1504
 
1416 1505
 	// Log what we've done.
1417
-	if (empty($user_info['id']))
1418
-		$user_info['id'] = !empty($upcontext['user']['id']) ? $upcontext['user']['id'] : 0;
1506
+	if (empty($user_info['id'])) {
1507
+			$user_info['id'] = !empty($upcontext['user']['id']) ? $upcontext['user']['id'] : 0;
1508
+	}
1419 1509
 
1420 1510
 	// Log the action manually, so CLI still works.
1421 1511
 	$smcFunc['db_insert']('',
@@ -1434,8 +1524,9 @@  discard block
 block discarded – undo
1434 1524
 
1435 1525
 	// Save the current database version.
1436 1526
 	$server_version = $smcFunc['db_server_info']();
1437
-	if ($db_type == 'mysql' && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51')))
1438
-		updateSettings(array('db_mysql_group_by_fix' => '1'));
1527
+	if ($db_type == 'mysql' && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) {
1528
+			updateSettings(array('db_mysql_group_by_fix' => '1'));
1529
+	}
1439 1530
 
1440 1531
 	if ($command_line)
1441 1532
 	{
@@ -1447,8 +1538,9 @@  discard block
 block discarded – undo
1447 1538
 
1448 1539
 	// Make sure it says we're done.
1449 1540
 	$upcontext['overall_percent'] = 100;
1450
-	if (isset($upcontext['step_progress']))
1451
-		unset($upcontext['step_progress']);
1541
+	if (isset($upcontext['step_progress'])) {
1542
+			unset($upcontext['step_progress']);
1543
+	}
1452 1544
 
1453 1545
 	$_GET['substep'] = 0;
1454 1546
 	return false;
@@ -1459,8 +1551,9 @@  discard block
 block discarded – undo
1459 1551
 {
1460 1552
 	global $sourcedir, $language, $forum_version, $modSettings, $smcFunc;
1461 1553
 
1462
-	if (empty($modSettings['time_format']))
1463
-		$modSettings['time_format'] = '%B %d, %Y, %I:%M:%S %p';
1554
+	if (empty($modSettings['time_format'])) {
1555
+			$modSettings['time_format'] = '%B %d, %Y, %I:%M:%S %p';
1556
+	}
1464 1557
 
1465 1558
 	// What files do we want to get
1466 1559
 	$request = $smcFunc['db_query']('', '
@@ -1494,8 +1587,9 @@  discard block
 block discarded – undo
1494 1587
 		$file_data = fetch_web_data($url);
1495 1588
 
1496 1589
 		// If we got an error - give up - the site might be down.
1497
-		if ($file_data === false)
1498
-			return throw_error(sprintf('Could not retrieve the file %1$s.', $url));
1590
+		if ($file_data === false) {
1591
+					return throw_error(sprintf('Could not retrieve the file %1$s.', $url));
1592
+		}
1499 1593
 
1500 1594
 		// Save the file to the database.
1501 1595
 		$smcFunc['db_query']('substring', '
@@ -1537,8 +1631,9 @@  discard block
 block discarded – undo
1537 1631
 	$themeData = array();
1538 1632
 	foreach ($values as $variable => $value)
1539 1633
 	{
1540
-		if (!isset($value) || $value === null)
1541
-			$value = 0;
1634
+		if (!isset($value) || $value === null) {
1635
+					$value = 0;
1636
+		}
1542 1637
 
1543 1638
 		$themeData[] = array(0, 1, $variable, $value);
1544 1639
 	}
@@ -1567,8 +1662,9 @@  discard block
 block discarded – undo
1567 1662
 
1568 1663
 	foreach ($values as $variable => $value)
1569 1664
 	{
1570
-		if (empty($modSettings[$value[0]]))
1571
-			continue;
1665
+		if (empty($modSettings[$value[0]])) {
1666
+					continue;
1667
+		}
1572 1668
 
1573 1669
 		$smcFunc['db_query']('', '
1574 1670
 			INSERT IGNORE INTO {db_prefix}themes
@@ -1654,19 +1750,21 @@  discard block
 block discarded – undo
1654 1750
 	set_error_handler(
1655 1751
 		function ($errno, $errstr, $errfile, $errline) use ($support_js)
1656 1752
 		{
1657
-			if ($support_js)
1658
-				return true;
1659
-			else
1660
-				echo 'Error: ' . $errstr . ' File: ' . $errfile . ' Line: ' . $errline;
1753
+			if ($support_js) {
1754
+							return true;
1755
+			} else {
1756
+							echo 'Error: ' . $errstr . ' File: ' . $errfile . ' Line: ' . $errline;
1757
+			}
1661 1758
 		}
1662 1759
 	);
1663 1760
 
1664 1761
 	// If we're on MySQL, set {db_collation}; this approach is used throughout upgrade_2-0_mysql.php to set new tables to utf8
1665 1762
 	// Note it is expected to be in the format: ENGINE=MyISAM{$db_collation};
1666
-	if ($db_type == 'mysql')
1667
-		$db_collation = ' DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci';
1668
-	else
1669
-		$db_collation = '';
1763
+	if ($db_type == 'mysql') {
1764
+			$db_collation = ' DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci';
1765
+	} else {
1766
+			$db_collation = '';
1767
+	}
1670 1768
 
1671 1769
 	$endl = $command_line ? "\n" : '<br>' . "\n";
1672 1770
 
@@ -1678,8 +1776,9 @@  discard block
 block discarded – undo
1678 1776
 	$last_step = '';
1679 1777
 
1680 1778
 	// Make sure all newly created tables will have the proper characters set; this approach is used throughout upgrade_2-1_mysql.php
1681
-	if (isset($db_character_set) && $db_character_set === 'utf8')
1682
-		$lines = str_replace(') ENGINE=MyISAM;', ') ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci;', $lines);
1779
+	if (isset($db_character_set) && $db_character_set === 'utf8') {
1780
+			$lines = str_replace(') ENGINE=MyISAM;', ') ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci;', $lines);
1781
+	}
1683 1782
 
1684 1783
 	// Count the total number of steps within this file - for progress.
1685 1784
 	$file_steps = substr_count(implode('', $lines), '---#');
@@ -1699,15 +1798,18 @@  discard block
 block discarded – undo
1699 1798
 		$do_current = $substep >= $_GET['substep'];
1700 1799
 
1701 1800
 		// Get rid of any comments in the beginning of the line...
1702
-		if (substr(trim($line), 0, 2) === '/*')
1703
-			$line = preg_replace('~/\*.+?\*/~', '', $line);
1801
+		if (substr(trim($line), 0, 2) === '/*') {
1802
+					$line = preg_replace('~/\*.+?\*/~', '', $line);
1803
+		}
1704 1804
 
1705 1805
 		// Always flush.  Flush, flush, flush.  Flush, flush, flush, flush!  FLUSH!
1706
-		if ($is_debug && !$support_js && $command_line)
1707
-			flush();
1806
+		if ($is_debug && !$support_js && $command_line) {
1807
+					flush();
1808
+		}
1708 1809
 
1709
-		if (trim($line) === '')
1710
-			continue;
1810
+		if (trim($line) === '') {
1811
+					continue;
1812
+		}
1711 1813
 
1712 1814
 		if (trim(substr($line, 0, 3)) === '---')
1713 1815
 		{
@@ -1717,8 +1819,9 @@  discard block
 block discarded – undo
1717 1819
 			if (trim($current_data) != '' && $type !== '}')
1718 1820
 			{
1719 1821
 				$upcontext['error_message'] = 'Error in upgrade script - line ' . $line_number . '!' . $endl;
1720
-				if ($command_line)
1721
-					echo $upcontext['error_message'];
1822
+				if ($command_line) {
1823
+									echo $upcontext['error_message'];
1824
+				}
1722 1825
 			}
1723 1826
 
1724 1827
 			if ($type == ' ')
@@ -1736,17 +1839,18 @@  discard block
 block discarded – undo
1736 1839
 				if ($do_current)
1737 1840
 				{
1738 1841
 					$upcontext['actioned_items'][] = $last_step;
1739
-					if ($command_line)
1740
-						echo ' * ';
1842
+					if ($command_line) {
1843
+											echo ' * ';
1844
+					}
1741 1845
 				}
1742
-			}
1743
-			elseif ($type == '#')
1846
+			} elseif ($type == '#')
1744 1847
 			{
1745 1848
 				$upcontext['step_progress'] += (100 / $upcontext['file_count']) / $file_steps;
1746 1849
 
1747 1850
 				$upcontext['current_debug_item_num']++;
1748
-				if (trim($line) != '---#')
1749
-					$upcontext['current_debug_item_name'] = htmlspecialchars(rtrim(substr($line, 4)));
1851
+				if (trim($line) != '---#') {
1852
+									$upcontext['current_debug_item_name'] = htmlspecialchars(rtrim(substr($line, 4)));
1853
+				}
1750 1854
 
1751 1855
 				// Have we already done something?
1752 1856
 				if (isset($_GET['xml']) && $done_something)
@@ -1757,34 +1861,36 @@  discard block
 block discarded – undo
1757 1861
 
1758 1862
 				if ($do_current)
1759 1863
 				{
1760
-					if (trim($line) == '---#' && $command_line)
1761
-						echo ' done.', $endl;
1762
-					elseif ($command_line)
1763
-						echo ' +++ ', rtrim(substr($line, 4));
1764
-					elseif (trim($line) != '---#')
1864
+					if (trim($line) == '---#' && $command_line) {
1865
+											echo ' done.', $endl;
1866
+					} elseif ($command_line) {
1867
+											echo ' +++ ', rtrim(substr($line, 4));
1868
+					} elseif (trim($line) != '---#')
1765 1869
 					{
1766
-						if ($is_debug)
1767
-							$upcontext['actioned_items'][] = htmlspecialchars(rtrim(substr($line, 4)));
1870
+						if ($is_debug) {
1871
+													$upcontext['actioned_items'][] = htmlspecialchars(rtrim(substr($line, 4)));
1872
+						}
1768 1873
 					}
1769 1874
 				}
1770 1875
 
1771 1876
 				if ($substep < $_GET['substep'] && $substep + 1 >= $_GET['substep'])
1772 1877
 				{
1773
-					if ($command_line)
1774
-						echo ' * ';
1775
-					else
1776
-						$upcontext['actioned_items'][] = $last_step;
1878
+					if ($command_line) {
1879
+											echo ' * ';
1880
+					} else {
1881
+											$upcontext['actioned_items'][] = $last_step;
1882
+					}
1777 1883
 				}
1778 1884
 
1779 1885
 				// Small step - only if we're actually doing stuff.
1780
-				if ($do_current)
1781
-					nextSubstep(++$substep);
1782
-				else
1783
-					$substep++;
1784
-			}
1785
-			elseif ($type == '{')
1786
-				$current_type = 'code';
1787
-			elseif ($type == '}')
1886
+				if ($do_current) {
1887
+									nextSubstep(++$substep);
1888
+				} else {
1889
+									$substep++;
1890
+				}
1891
+			} elseif ($type == '{') {
1892
+							$current_type = 'code';
1893
+			} elseif ($type == '}')
1788 1894
 			{
1789 1895
 				$current_type = 'sql';
1790 1896
 
@@ -1797,8 +1903,9 @@  discard block
 block discarded – undo
1797 1903
 				if (eval('global $db_prefix, $modSettings, $smcFunc; ' . $current_data) === false)
1798 1904
 				{
1799 1905
 					$upcontext['error_message'] = 'Error in upgrade script ' . basename($filename) . ' on line ' . $line_number . '!' . $endl;
1800
-					if ($command_line)
1801
-						echo $upcontext['error_message'];
1906
+					if ($command_line) {
1907
+											echo $upcontext['error_message'];
1908
+					}
1802 1909
 				}
1803 1910
 
1804 1911
 				// Done with code!
@@ -1878,8 +1985,9 @@  discard block
 block discarded – undo
1878 1985
 	$db_unbuffered = false;
1879 1986
 
1880 1987
 	// Failure?!
1881
-	if ($result !== false)
1882
-		return $result;
1988
+	if ($result !== false) {
1989
+			return $result;
1990
+	}
1883 1991
 
1884 1992
 	$db_error_message = $smcFunc['db_error']($db_connection);
1885 1993
 	// If MySQL we do something more clever.
@@ -1907,54 +2015,61 @@  discard block
 block discarded – undo
1907 2015
 			{
1908 2016
 				mysqli_query($db_connection, 'REPAIR TABLE `' . $match[1] . '`');
1909 2017
 				$result = mysqli_query($db_connection, $string);
1910
-				if ($result !== false)
1911
-					return $result;
2018
+				if ($result !== false) {
2019
+									return $result;
2020
+				}
1912 2021
 			}
1913
-		}
1914
-		elseif ($mysqli_errno == 2013)
2022
+		} elseif ($mysqli_errno == 2013)
1915 2023
 		{
1916 2024
 			$db_connection = mysqli_connect($db_server, $db_user, $db_passwd);
1917 2025
 			mysqli_select_db($db_connection, $db_name);
1918 2026
 			if ($db_connection)
1919 2027
 			{
1920 2028
 				$result = mysqli_query($db_connection, $string);
1921
-				if ($result !== false)
1922
-					return $result;
2029
+				if ($result !== false) {
2030
+									return $result;
2031
+				}
1923 2032
 			}
1924 2033
 		}
1925 2034
 		// Duplicate column name... should be okay ;).
1926
-		elseif (in_array($mysqli_errno, array(1060, 1061, 1068, 1091)))
1927
-			return false;
2035
+		elseif (in_array($mysqli_errno, array(1060, 1061, 1068, 1091))) {
2036
+					return false;
2037
+		}
1928 2038
 		// Duplicate insert... make sure it's the proper type of query ;).
1929
-		elseif (in_array($mysqli_errno, array(1054, 1062, 1146)) && $error_query)
1930
-			return false;
2039
+		elseif (in_array($mysqli_errno, array(1054, 1062, 1146)) && $error_query) {
2040
+					return false;
2041
+		}
1931 2042
 		// Creating an index on a non-existent column.
1932
-		elseif ($mysqli_errno == 1072)
1933
-			return false;
1934
-		elseif ($mysqli_errno == 1050 && substr(trim($string), 0, 12) == 'RENAME TABLE')
1935
-			return false;
2043
+		elseif ($mysqli_errno == 1072) {
2044
+					return false;
2045
+		} elseif ($mysqli_errno == 1050 && substr(trim($string), 0, 12) == 'RENAME TABLE') {
2046
+					return false;
2047
+		}
1936 2048
 	}
1937 2049
 	// If a table already exists don't go potty.
1938 2050
 	else
1939 2051
 	{
1940 2052
 		if (in_array(substr(trim($string), 0, 8), array('CREATE T', 'CREATE S', 'DROP TABL', 'ALTER TA', 'CREATE I', 'CREATE U')))
1941 2053
 		{
1942
-			if (strpos($db_error_message, 'exist') !== false)
1943
-				return true;
1944
-		}
1945
-		elseif (strpos(trim($string), 'INSERT ') !== false)
2054
+			if (strpos($db_error_message, 'exist') !== false) {
2055
+							return true;
2056
+			}
2057
+		} elseif (strpos(trim($string), 'INSERT ') !== false)
1946 2058
 		{
1947
-			if (strpos($db_error_message, 'duplicate') !== false)
1948
-				return true;
2059
+			if (strpos($db_error_message, 'duplicate') !== false) {
2060
+							return true;
2061
+			}
1949 2062
 		}
1950 2063
 	}
1951 2064
 
1952 2065
 	// Get the query string so we pass everything.
1953 2066
 	$query_string = '';
1954
-	foreach ($_GET as $k => $v)
1955
-		$query_string .= ';' . $k . '=' . $v;
1956
-	if (strlen($query_string) != 0)
1957
-		$query_string = '?' . substr($query_string, 1);
2067
+	foreach ($_GET as $k => $v) {
2068
+			$query_string .= ';' . $k . '=' . $v;
2069
+	}
2070
+	if (strlen($query_string) != 0) {
2071
+			$query_string = '?' . substr($query_string, 1);
2072
+	}
1958 2073
 
1959 2074
 	if ($command_line)
1960 2075
 	{
@@ -2009,16 +2124,18 @@  discard block
 block discarded – undo
2009 2124
 			{
2010 2125
 				$found |= 1;
2011 2126
 				// Do some checks on the data if we have it set.
2012
-				if (isset($change['col_type']))
2013
-					$found &= $change['col_type'] === $column['type'];
2014
-				if (isset($change['null_allowed']))
2015
-					$found &= $column['null'] == $change['null_allowed'];
2016
-				if (isset($change['default']))
2017
-					$found &= $change['default'] === $column['default'];
2127
+				if (isset($change['col_type'])) {
2128
+									$found &= $change['col_type'] === $column['type'];
2129
+				}
2130
+				if (isset($change['null_allowed'])) {
2131
+									$found &= $column['null'] == $change['null_allowed'];
2132
+				}
2133
+				if (isset($change['default'])) {
2134
+									$found &= $change['default'] === $column['default'];
2135
+				}
2018 2136
 			}
2019 2137
 		}
2020
-	}
2021
-	elseif ($change['type'] === 'index')
2138
+	} elseif ($change['type'] === 'index')
2022 2139
 	{
2023 2140
 		$request = upgrade_query('
2024 2141
 			SHOW INDEX
@@ -2027,9 +2144,10 @@  discard block
 block discarded – undo
2027 2144
 		{
2028 2145
 			$cur_index = array();
2029 2146
 
2030
-			while ($row = $smcFunc['db_fetch_assoc']($request))
2031
-				if ($row['Key_name'] === $change['name'])
2147
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
2148
+							if ($row['Key_name'] === $change['name'])
2032 2149
 					$cur_index[(int) $row['Seq_in_index']] = $row['Column_name'];
2150
+			}
2033 2151
 
2034 2152
 			ksort($cur_index, SORT_NUMERIC);
2035 2153
 			$found = array_values($cur_index) === $change['target_columns'];
@@ -2039,14 +2157,17 @@  discard block
 block discarded – undo
2039 2157
 	}
2040 2158
 
2041 2159
 	// If we're trying to add and it's added, we're done.
2042
-	if ($found && in_array($change['method'], array('add', 'change')))
2043
-		return true;
2160
+	if ($found && in_array($change['method'], array('add', 'change'))) {
2161
+			return true;
2162
+	}
2044 2163
 	// Otherwise if we're removing and it wasn't found we're also done.
2045
-	elseif (!$found && in_array($change['method'], array('remove', 'change_remove')))
2046
-		return true;
2164
+	elseif (!$found && in_array($change['method'], array('remove', 'change_remove'))) {
2165
+			return true;
2166
+	}
2047 2167
 	// Otherwise is it just a test?
2048
-	elseif ($is_test)
2049
-		return false;
2168
+	elseif ($is_test) {
2169
+			return false;
2170
+	}
2050 2171
 
2051 2172
 	// Not found it yet? Bummer! How about we see if we're currently doing it?
2052 2173
 	$running = false;
@@ -2057,8 +2178,9 @@  discard block
 block discarded – undo
2057 2178
 			SHOW FULL PROCESSLIST');
2058 2179
 		while ($row = $smcFunc['db_fetch_assoc']($request))
2059 2180
 		{
2060
-			if (strpos($row['Info'], 'ALTER TABLE ' . $db_prefix . $change['table']) !== false && strpos($row['Info'], $change['text']) !== false)
2061
-				$found = true;
2181
+			if (strpos($row['Info'], 'ALTER TABLE ' . $db_prefix . $change['table']) !== false && strpos($row['Info'], $change['text']) !== false) {
2182
+							$found = true;
2183
+			}
2062 2184
 		}
2063 2185
 
2064 2186
 		// Can't find it? Then we need to run it fools!
@@ -2070,8 +2192,9 @@  discard block
 block discarded – undo
2070 2192
 				ALTER TABLE ' . $db_prefix . $change['table'] . '
2071 2193
 				' . $change['text'], true) !== false;
2072 2194
 
2073
-			if (!$success)
2074
-				return false;
2195
+			if (!$success) {
2196
+							return false;
2197
+			}
2075 2198
 
2076 2199
 			// Return
2077 2200
 			$running = true;
@@ -2113,8 +2236,9 @@  discard block
 block discarded – undo
2113 2236
 			'db_error_skip' => true,
2114 2237
 		)
2115 2238
 	);
2116
-	if ($smcFunc['db_num_rows']($request) === 0)
2117
-		die('Unable to find column ' . $change['column'] . ' inside table ' . $db_prefix . $change['table']);
2239
+	if ($smcFunc['db_num_rows']($request) === 0) {
2240
+			die('Unable to find column ' . $change['column'] . ' inside table ' . $db_prefix . $change['table']);
2241
+	}
2118 2242
 	$table_row = $smcFunc['db_fetch_assoc']($request);
2119 2243
 	$smcFunc['db_free_result']($request);
2120 2244
 
@@ -2136,18 +2260,19 @@  discard block
 block discarded – undo
2136 2260
 			)
2137 2261
 		);
2138 2262
 		// No results? Just forget it all together.
2139
-		if ($smcFunc['db_num_rows']($request) === 0)
2140
-			unset($table_row['Collation']);
2141
-		else
2142
-			$collation_info = $smcFunc['db_fetch_assoc']($request);
2263
+		if ($smcFunc['db_num_rows']($request) === 0) {
2264
+					unset($table_row['Collation']);
2265
+		} else {
2266
+					$collation_info = $smcFunc['db_fetch_assoc']($request);
2267
+		}
2143 2268
 		$smcFunc['db_free_result']($request);
2144 2269
 	}
2145 2270
 
2146 2271
 	if ($column_fix)
2147 2272
 	{
2148 2273
 		// Make sure there are no NULL's left.
2149
-		if ($null_fix)
2150
-			$smcFunc['db_query']('', '
2274
+		if ($null_fix) {
2275
+					$smcFunc['db_query']('', '
2151 2276
 				UPDATE {db_prefix}' . $change['table'] . '
2152 2277
 				SET ' . $change['column'] . ' = {string:default}
2153 2278
 				WHERE ' . $change['column'] . ' IS NULL',
@@ -2156,6 +2281,7 @@  discard block
 block discarded – undo
2156 2281
 					'db_error_skip' => true,
2157 2282
 				)
2158 2283
 			);
2284
+		}
2159 2285
 
2160 2286
 		// Do the actual alteration.
2161 2287
 		$smcFunc['db_query']('', '
@@ -2184,8 +2310,9 @@  discard block
 block discarded – undo
2184 2310
 	}
2185 2311
 
2186 2312
 	// Not a column we need to check on?
2187
-	if (!in_array($change['name'], array('memberGroups', 'passwordSalt')))
2188
-		return;
2313
+	if (!in_array($change['name'], array('memberGroups', 'passwordSalt'))) {
2314
+			return;
2315
+	}
2189 2316
 
2190 2317
 	// Break it up you (six|seven).
2191 2318
 	$temp = explode(' ', str_replace('NOT NULL', 'NOT_NULL', $change['text']));
@@ -2204,13 +2331,13 @@  discard block
 block discarded – undo
2204 2331
 				'new_name' => $temp[2],
2205 2332
 		));
2206 2333
 		// !!! This doesn't technically work because we don't pass request into it, but it hasn't broke anything yet.
2207
-		if ($smcFunc['db_num_rows'] != 1)
2208
-			return;
2334
+		if ($smcFunc['db_num_rows'] != 1) {
2335
+					return;
2336
+		}
2209 2337
 
2210 2338
 		list (, $current_type) = $smcFunc['db_fetch_assoc']($request);
2211 2339
 		$smcFunc['db_free_result']($request);
2212
-	}
2213
-	else
2340
+	} else
2214 2341
 	{
2215 2342
 		// Do this the old fashion, sure method way.
2216 2343
 		$request = $smcFunc['db_query']('', '
@@ -2221,21 +2348,24 @@  discard block
 block discarded – undo
2221 2348
 		));
2222 2349
 		// Mayday!
2223 2350
 		// !!! This doesn't technically work because we don't pass request into it, but it hasn't broke anything yet.
2224
-		if ($smcFunc['db_num_rows'] == 0)
2225
-			return;
2351
+		if ($smcFunc['db_num_rows'] == 0) {
2352
+					return;
2353
+		}
2226 2354
 
2227 2355
 		// Oh where, oh where has my little field gone. Oh where can it be...
2228
-		while ($row = $smcFunc['db_query']($request))
2229
-			if ($row['Field'] == $temp[1] || $row['Field'] == $temp[2])
2356
+		while ($row = $smcFunc['db_query']($request)) {
2357
+					if ($row['Field'] == $temp[1] || $row['Field'] == $temp[2])
2230 2358
 			{
2231 2359
 				$current_type = $row['Type'];
2360
+		}
2232 2361
 				break;
2233 2362
 			}
2234 2363
 	}
2235 2364
 
2236 2365
 	// If this doesn't match, the column may of been altered for a reason.
2237
-	if (trim($current_type) != trim($temp[3]))
2238
-		$temp[3] = $current_type;
2366
+	if (trim($current_type) != trim($temp[3])) {
2367
+			$temp[3] = $current_type;
2368
+	}
2239 2369
 
2240 2370
 	// Piece this back together.
2241 2371
 	$change['text'] = str_replace('NOT_NULL', 'NOT NULL', implode(' ', $temp));
@@ -2247,8 +2377,9 @@  discard block
 block discarded – undo
2247 2377
 	global $start_time, $timeLimitThreshold, $command_line, $custom_warning;
2248 2378
 	global $step_progress, $is_debug, $upcontext;
2249 2379
 
2250
-	if ($_GET['substep'] < $substep)
2251
-		$_GET['substep'] = $substep;
2380
+	if ($_GET['substep'] < $substep) {
2381
+			$_GET['substep'] = $substep;
2382
+	}
2252 2383
 
2253 2384
 	if ($command_line)
2254 2385
 	{
@@ -2261,29 +2392,33 @@  discard block
 block discarded – undo
2261 2392
 	}
2262 2393
 
2263 2394
 	@set_time_limit(300);
2264
-	if (function_exists('apache_reset_timeout'))
2265
-		@apache_reset_timeout();
2395
+	if (function_exists('apache_reset_timeout')) {
2396
+			@apache_reset_timeout();
2397
+	}
2266 2398
 
2267
-	if (time() - $start_time <= $timeLimitThreshold)
2268
-		return;
2399
+	if (time() - $start_time <= $timeLimitThreshold) {
2400
+			return;
2401
+	}
2269 2402
 
2270 2403
 	// Do we have some custom step progress stuff?
2271 2404
 	if (!empty($step_progress))
2272 2405
 	{
2273 2406
 		$upcontext['substep_progress'] = 0;
2274 2407
 		$upcontext['substep_progress_name'] = $step_progress['name'];
2275
-		if ($step_progress['current'] > $step_progress['total'])
2276
-			$upcontext['substep_progress'] = 99.9;
2277
-		else
2278
-			$upcontext['substep_progress'] = ($step_progress['current'] / $step_progress['total']) * 100;
2408
+		if ($step_progress['current'] > $step_progress['total']) {
2409
+					$upcontext['substep_progress'] = 99.9;
2410
+		} else {
2411
+					$upcontext['substep_progress'] = ($step_progress['current'] / $step_progress['total']) * 100;
2412
+		}
2279 2413
 
2280 2414
 		// Make it nicely rounded.
2281 2415
 		$upcontext['substep_progress'] = round($upcontext['substep_progress'], 1);
2282 2416
 	}
2283 2417
 
2284 2418
 	// If this is XML we just exit right away!
2285
-	if (isset($_GET['xml']))
2286
-		return upgradeExit();
2419
+	if (isset($_GET['xml'])) {
2420
+			return upgradeExit();
2421
+	}
2287 2422
 
2288 2423
 	// We're going to pause after this!
2289 2424
 	$upcontext['pause'] = true;
@@ -2291,13 +2426,15 @@  discard block
 block discarded – undo
2291 2426
 	$upcontext['query_string'] = '';
2292 2427
 	foreach ($_GET as $k => $v)
2293 2428
 	{
2294
-		if ($k != 'data' && $k != 'substep' && $k != 'step')
2295
-			$upcontext['query_string'] .= ';' . $k . '=' . $v;
2429
+		if ($k != 'data' && $k != 'substep' && $k != 'step') {
2430
+					$upcontext['query_string'] .= ';' . $k . '=' . $v;
2431
+		}
2296 2432
 	}
2297 2433
 
2298 2434
 	// Custom warning?
2299
-	if (!empty($custom_warning))
2300
-		$upcontext['custom_warning'] = $custom_warning;
2435
+	if (!empty($custom_warning)) {
2436
+			$upcontext['custom_warning'] = $custom_warning;
2437
+	}
2301 2438
 
2302 2439
 	upgradeExit();
2303 2440
 }
@@ -2312,25 +2449,26 @@  discard block
 block discarded – undo
2312 2449
 	ob_implicit_flush(true);
2313 2450
 	@set_time_limit(600);
2314 2451
 
2315
-	if (!isset($_SERVER['argv']))
2316
-		$_SERVER['argv'] = array();
2452
+	if (!isset($_SERVER['argv'])) {
2453
+			$_SERVER['argv'] = array();
2454
+	}
2317 2455
 	$_GET['maint'] = 1;
2318 2456
 
2319 2457
 	foreach ($_SERVER['argv'] as $i => $arg)
2320 2458
 	{
2321
-		if (preg_match('~^--language=(.+)$~', $arg, $match) != 0)
2322
-			$_GET['lang'] = $match[1];
2323
-		elseif (preg_match('~^--path=(.+)$~', $arg) != 0)
2324
-			continue;
2325
-		elseif ($arg == '--no-maintenance')
2326
-			$_GET['maint'] = 0;
2327
-		elseif ($arg == '--debug')
2328
-			$is_debug = true;
2329
-		elseif ($arg == '--backup')
2330
-			$_POST['backup'] = 1;
2331
-		elseif ($arg == '--template' && (file_exists($boarddir . '/template.php') || file_exists($boarddir . '/template.html') && !file_exists($modSettings['theme_dir'] . '/converted')))
2332
-			$_GET['conv'] = 1;
2333
-		elseif ($i != 0)
2459
+		if (preg_match('~^--language=(.+)$~', $arg, $match) != 0) {
2460
+					$_GET['lang'] = $match[1];
2461
+		} elseif (preg_match('~^--path=(.+)$~', $arg) != 0) {
2462
+					continue;
2463
+		} elseif ($arg == '--no-maintenance') {
2464
+					$_GET['maint'] = 0;
2465
+		} elseif ($arg == '--debug') {
2466
+					$is_debug = true;
2467
+		} elseif ($arg == '--backup') {
2468
+					$_POST['backup'] = 1;
2469
+		} elseif ($arg == '--template' && (file_exists($boarddir . '/template.php') || file_exists($boarddir . '/template.html') && !file_exists($modSettings['theme_dir'] . '/converted'))) {
2470
+					$_GET['conv'] = 1;
2471
+		} elseif ($i != 0)
2334 2472
 		{
2335 2473
 			echo 'SMF Command-line Upgrader
2336 2474
 Usage: /path/to/php -f ' . basename(__FILE__) . ' -- [OPTION]...
@@ -2344,10 +2482,12 @@  discard block
 block discarded – undo
2344 2482
 		}
2345 2483
 	}
2346 2484
 
2347
-	if (!php_version_check())
2348
-		print_error('Error: PHP ' . PHP_VERSION . ' does not match version requirements.', true);
2349
-	if (!db_version_check())
2350
-		print_error('Error: ' . $databases[$db_type]['name'] . ' ' . $databases[$db_type]['version'] . ' does not match minimum requirements.', true);
2485
+	if (!php_version_check()) {
2486
+			print_error('Error: PHP ' . PHP_VERSION . ' does not match version requirements.', true);
2487
+	}
2488
+	if (!db_version_check()) {
2489
+			print_error('Error: ' . $databases[$db_type]['name'] . ' ' . $databases[$db_type]['version'] . ' does not match minimum requirements.', true);
2490
+	}
2351 2491
 
2352 2492
 	// Do some checks to make sure they have proper privileges
2353 2493
 	db_extend('packages');
@@ -2362,39 +2502,45 @@  discard block
 block discarded – undo
2362 2502
 	$drop = $smcFunc['db_drop_table']('{db_prefix}priv_check');
2363 2503
 
2364 2504
 	// Sorry... we need CREATE, ALTER and DROP
2365
-	if (!$create || !$alter || !$drop)
2366
-		print_error("The " . $databases[$db_type]['name'] . " user you have set in Settings.php does not have proper privileges.\n\nPlease ask your host to give this user the ALTER, CREATE, and DROP privileges.", true);
2505
+	if (!$create || !$alter || !$drop) {
2506
+			print_error("The " . $databases[$db_type]['name'] . " user you have set in Settings.php does not have proper privileges.\n\nPlease ask your host to give this user the ALTER, CREATE, and DROP privileges.", true);
2507
+	}
2367 2508
 
2368 2509
 	$check = @file_exists($modSettings['theme_dir'] . '/index.template.php')
2369 2510
 		&& @file_exists($sourcedir . '/QueryString.php')
2370 2511
 		&& @file_exists($sourcedir . '/ManageBoards.php');
2371
-	if (!$check && !isset($modSettings['smfVersion']))
2372
-		print_error('Error: Some files are missing or out-of-date.', true);
2512
+	if (!$check && !isset($modSettings['smfVersion'])) {
2513
+			print_error('Error: Some files are missing or out-of-date.', true);
2514
+	}
2373 2515
 
2374 2516
 	// Do a quick version spot check.
2375 2517
 	$temp = substr(@implode('', @file($boarddir . '/index.php')), 0, 4096);
2376 2518
 	preg_match('~\*\s@version\s+(.+)[\s]{2}~i', $temp, $match);
2377
-	if (empty($match[1]) || (trim($match[1]) != SMF_VERSION))
2378
-		print_error('Error: Some files have not yet been updated properly.');
2519
+	if (empty($match[1]) || (trim($match[1]) != SMF_VERSION)) {
2520
+			print_error('Error: Some files have not yet been updated properly.');
2521
+	}
2379 2522
 
2380 2523
 	// Make sure Settings.php is writable.
2381 2524
 	quickFileWritable($boarddir . '/Settings.php');
2382
-	if (!is_writable($boarddir . '/Settings.php'))
2383
-		print_error('Error: Unable to obtain write access to "Settings.php".', true);
2525
+	if (!is_writable($boarddir . '/Settings.php')) {
2526
+			print_error('Error: Unable to obtain write access to "Settings.php".', true);
2527
+	}
2384 2528
 
2385 2529
 	// Make sure Settings_bak.php is writable.
2386 2530
 	quickFileWritable($boarddir . '/Settings_bak.php');
2387
-	if (!is_writable($boarddir . '/Settings_bak.php'))
2388
-		print_error('Error: Unable to obtain write access to "Settings_bak.php".');
2531
+	if (!is_writable($boarddir . '/Settings_bak.php')) {
2532
+			print_error('Error: Unable to obtain write access to "Settings_bak.php".');
2533
+	}
2389 2534
 
2390 2535
 	// Make sure db_last_error.php is writable.
2391 2536
 	quickFileWritable($boarddir . '/db_last_error.php');
2392
-	if (!is_writable($boarddir . '/db_last_error.php'))
2393
-		print_error('Error: Unable to obtain write access to "db_last_error.php".');
2537
+	if (!is_writable($boarddir . '/db_last_error.php')) {
2538
+			print_error('Error: Unable to obtain write access to "db_last_error.php".');
2539
+	}
2394 2540
 
2395
-	if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt'))
2396
-		print_error('Error: Unable to obtain write access to "agreement.txt".');
2397
-	elseif (isset($modSettings['agreement']))
2541
+	if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt')) {
2542
+			print_error('Error: Unable to obtain write access to "agreement.txt".');
2543
+	} elseif (isset($modSettings['agreement']))
2398 2544
 	{
2399 2545
 		$fp = fopen($boarddir . '/agreement.txt', 'w');
2400 2546
 		fwrite($fp, $modSettings['agreement']);
@@ -2404,31 +2550,36 @@  discard block
 block discarded – undo
2404 2550
 	// Make sure Themes is writable.
2405 2551
 	quickFileWritable($modSettings['theme_dir']);
2406 2552
 
2407
-	if (!is_writable($modSettings['theme_dir']) && !isset($modSettings['smfVersion']))
2408
-		print_error('Error: Unable to obtain write access to "Themes".');
2553
+	if (!is_writable($modSettings['theme_dir']) && !isset($modSettings['smfVersion'])) {
2554
+			print_error('Error: Unable to obtain write access to "Themes".');
2555
+	}
2409 2556
 
2410 2557
 	// Make sure cache directory exists and is writable!
2411 2558
 	$cachedir_temp = empty($cachedir) ? $boarddir . '/cache' : $cachedir;
2412
-	if (!file_exists($cachedir_temp))
2413
-		@mkdir($cachedir_temp);
2559
+	if (!file_exists($cachedir_temp)) {
2560
+			@mkdir($cachedir_temp);
2561
+	}
2414 2562
 
2415 2563
 	// Make sure the cache temp dir is writable.
2416 2564
 	quickFileWritable($cachedir_temp);
2417 2565
 
2418
-	if (!is_writable($cachedir_temp))
2419
-		print_error('Error: Unable to obtain write access to "cache".', true);
2566
+	if (!is_writable($cachedir_temp)) {
2567
+			print_error('Error: Unable to obtain write access to "cache".', true);
2568
+	}
2420 2569
 
2421
-	if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang']))
2422
-		print_error('Error: Unable to find language files!', true);
2423
-	else
2570
+	if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang'])) {
2571
+			print_error('Error: Unable to find language files!', true);
2572
+	} else
2424 2573
 	{
2425 2574
 		$temp = substr(@implode('', @file($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php')), 0, 4096);
2426 2575
 		preg_match('~(?://|/\*)\s*Version:\s+(.+?);\s*index(?:[\s]{2}|\*/)~i', $temp, $match);
2427 2576
 
2428
-		if (empty($match[1]) || $match[1] != SMF_LANG_VERSION)
2429
-			print_error('Error: Language files out of date.', true);
2430
-		if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'))
2431
-			print_error('Error: Install language is missing for selected language.', true);
2577
+		if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) {
2578
+					print_error('Error: Language files out of date.', true);
2579
+		}
2580
+		if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) {
2581
+					print_error('Error: Install language is missing for selected language.', true);
2582
+		}
2432 2583
 
2433 2584
 		// Otherwise include it!
2434 2585
 		require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php');
@@ -2447,8 +2598,9 @@  discard block
 block discarded – undo
2447 2598
 	global $upcontext, $db_character_set, $sourcedir, $smcFunc, $modSettings, $language, $db_prefix, $db_type, $command_line, $support_js;
2448 2599
 
2449 2600
 	// Done it already?
2450
-	if (!empty($_POST['utf8_done']))
2451
-		return true;
2601
+	if (!empty($_POST['utf8_done'])) {
2602
+			return true;
2603
+	}
2452 2604
 
2453 2605
 	// First make sure they aren't already on UTF-8 before we go anywhere...
2454 2606
 	if ($db_type == 'postgresql' || ($db_character_set === 'utf8' && !empty($modSettings['global_character_set']) && $modSettings['global_character_set'] === 'UTF-8'))
@@ -2461,8 +2613,7 @@  discard block
 block discarded – undo
2461 2613
 		);
2462 2614
 
2463 2615
 		return true;
2464
-	}
2465
-	else
2616
+	} else
2466 2617
 	{
2467 2618
 		$upcontext['page_title'] = 'Converting to UTF8';
2468 2619
 		$upcontext['sub_template'] = isset($_GET['xml']) ? 'convert_xml' : 'convert_utf8';
@@ -2506,8 +2657,9 @@  discard block
 block discarded – undo
2506 2657
 			)
2507 2658
 		);
2508 2659
 		$db_charsets = array();
2509
-		while ($row = $smcFunc['db_fetch_assoc']($request))
2510
-			$db_charsets[] = $row['Charset'];
2660
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
2661
+					$db_charsets[] = $row['Charset'];
2662
+		}
2511 2663
 
2512 2664
 		$smcFunc['db_free_result']($request);
2513 2665
 
@@ -2543,13 +2695,15 @@  discard block
 block discarded – undo
2543 2695
 		// If there's a fulltext index, we need to drop it first...
2544 2696
 		if ($request !== false || $smcFunc['db_num_rows']($request) != 0)
2545 2697
 		{
2546
-			while ($row = $smcFunc['db_fetch_assoc']($request))
2547
-				if ($row['Column_name'] == 'body' && (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT' || isset($row['Comment']) && $row['Comment'] == 'FULLTEXT'))
2698
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
2699
+							if ($row['Column_name'] == 'body' && (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT' || isset($row['Comment']) && $row['Comment'] == 'FULLTEXT'))
2548 2700
 					$upcontext['fulltext_index'][] = $row['Key_name'];
2701
+			}
2549 2702
 			$smcFunc['db_free_result']($request);
2550 2703
 
2551
-			if (isset($upcontext['fulltext_index']))
2552
-				$upcontext['fulltext_index'] = array_unique($upcontext['fulltext_index']);
2704
+			if (isset($upcontext['fulltext_index'])) {
2705
+							$upcontext['fulltext_index'] = array_unique($upcontext['fulltext_index']);
2706
+			}
2553 2707
 		}
2554 2708
 
2555 2709
 		// Drop it and make a note...
@@ -2739,8 +2893,9 @@  discard block
 block discarded – undo
2739 2893
 			$replace = '%field%';
2740 2894
 
2741 2895
 			// Build a huge REPLACE statement...
2742
-			foreach ($translation_tables[$upcontext['charset_detected']] as $from => $to)
2743
-				$replace = 'REPLACE(' . $replace . ', ' . $from . ', ' . $to . ')';
2896
+			foreach ($translation_tables[$upcontext['charset_detected']] as $from => $to) {
2897
+							$replace = 'REPLACE(' . $replace . ', ' . $from . ', ' . $to . ')';
2898
+			}
2744 2899
 		}
2745 2900
 
2746 2901
 		// Get a list of table names ahead of time... This makes it easier to set our substep and such
@@ -2750,9 +2905,10 @@  discard block
 block discarded – undo
2750 2905
 		$upcontext['table_count'] = count($queryTables);
2751 2906
 
2752 2907
 		// What ones have we already done?
2753
-		foreach ($queryTables as $id => $table)
2754
-			if ($id < $_GET['substep'])
2908
+		foreach ($queryTables as $id => $table) {
2909
+					if ($id < $_GET['substep'])
2755 2910
 				$upcontext['previous_tables'][] = $table;
2911
+		}
2756 2912
 
2757 2913
 		$upcontext['cur_table_num'] = $_GET['substep'];
2758 2914
 		$upcontext['cur_table_name'] = str_replace($db_prefix, '', $queryTables[$_GET['substep']]);
@@ -2789,8 +2945,9 @@  discard block
 block discarded – undo
2789 2945
 			nextSubstep($substep);
2790 2946
 
2791 2947
 			// Just to make sure it doesn't time out.
2792
-			if (function_exists('apache_reset_timeout'))
2793
-				@apache_reset_timeout();
2948
+			if (function_exists('apache_reset_timeout')) {
2949
+							@apache_reset_timeout();
2950
+			}
2794 2951
 
2795 2952
 			$table_charsets = array();
2796 2953
 
@@ -2813,8 +2970,9 @@  discard block
 block discarded – undo
2813 2970
 
2814 2971
 						// Build structure of columns to operate on organized by charset; only operate on columns not yet utf8
2815 2972
 						if ($charset != 'utf8') {
2816
-							if (!isset($table_charsets[$charset]))
2817
-								$table_charsets[$charset] = array();
2973
+							if (!isset($table_charsets[$charset])) {
2974
+															$table_charsets[$charset] = array();
2975
+							}
2818 2976
 
2819 2977
 							$table_charsets[$charset][] = $column_info;
2820 2978
 						}
@@ -2855,10 +3013,11 @@  discard block
 block discarded – undo
2855 3013
 				if (isset($translation_tables[$upcontext['charset_detected']]))
2856 3014
 				{
2857 3015
 					$update = '';
2858
-					foreach ($table_charsets as $charset => $columns)
2859
-						foreach ($columns as $column)
3016
+					foreach ($table_charsets as $charset => $columns) {
3017
+											foreach ($columns as $column)
2860 3018
 							$update .= '
2861 3019
 								' . $column['Field'] . ' = ' . strtr($replace, array('%field%' => $column['Field'])) . ',';
3020
+					}
2862 3021
 
2863 3022
 					$smcFunc['db_query']('', '
2864 3023
 						UPDATE {raw:table_name}
@@ -2883,8 +3042,9 @@  discard block
 block discarded – undo
2883 3042
 			// Now do the actual conversion (if still needed).
2884 3043
 			if ($charsets[$upcontext['charset_detected']] !== 'utf8')
2885 3044
 			{
2886
-				if ($command_line)
2887
-					echo 'Converting table ' . $table_info['Name'] . ' to UTF-8...';
3045
+				if ($command_line) {
3046
+									echo 'Converting table ' . $table_info['Name'] . ' to UTF-8...';
3047
+				}
2888 3048
 
2889 3049
 				$smcFunc['db_query']('', '
2890 3050
 					ALTER TABLE {raw:table_name}
@@ -2894,12 +3054,14 @@  discard block
 block discarded – undo
2894 3054
 					)
2895 3055
 				);
2896 3056
 
2897
-				if ($command_line)
2898
-					echo " done.\n";
3057
+				if ($command_line) {
3058
+									echo " done.\n";
3059
+				}
2899 3060
 			}
2900 3061
 			// If this is XML to keep it nice for the user do one table at a time anyway!
2901
-			if (isset($_GET['xml']) && $upcontext['cur_table_num'] < $upcontext['table_count'])
2902
-				return upgradeExit();
3062
+			if (isset($_GET['xml']) && $upcontext['cur_table_num'] < $upcontext['table_count']) {
3063
+							return upgradeExit();
3064
+			}
2903 3065
 		}
2904 3066
 
2905 3067
 		$prev_charset = empty($translation_tables[$upcontext['charset_detected']]) ? $charsets[$upcontext['charset_detected']] : $translation_tables[$upcontext['charset_detected']];
@@ -2928,8 +3090,8 @@  discard block
 block discarded – undo
2928 3090
 		);
2929 3091
 		while ($row = $smcFunc['db_fetch_assoc']($request))
2930 3092
 		{
2931
-			if (@safe_unserialize($row['extra']) === false && preg_match('~^(a:3:{s:5:"topic";i:\d+;s:7:"subject";s:)(\d+):"(.+)"(;s:6:"member";s:5:"\d+";})$~', $row['extra'], $matches) === 1)
2932
-				$smcFunc['db_query']('', '
3093
+			if (@safe_unserialize($row['extra']) === false && preg_match('~^(a:3:{s:5:"topic";i:\d+;s:7:"subject";s:)(\d+):"(.+)"(;s:6:"member";s:5:"\d+";})$~', $row['extra'], $matches) === 1) {
3094
+							$smcFunc['db_query']('', '
2933 3095
 					UPDATE {db_prefix}log_actions
2934 3096
 					SET extra = {string:extra}
2935 3097
 					WHERE id_action = {int:current_action}',
@@ -2938,6 +3100,7 @@  discard block
 block discarded – undo
2938 3100
 						'extra' => $matches[1] . strlen($matches[3]) . ':"' . $matches[3] . '"' . $matches[4],
2939 3101
 					)
2940 3102
 				);
3103
+			}
2941 3104
 		}
2942 3105
 		$smcFunc['db_free_result']($request);
2943 3106
 
@@ -2959,15 +3122,17 @@  discard block
 block discarded – undo
2959 3122
 	// First thing's first - did we already do this?
2960 3123
 	if (!empty($modSettings['json_done']))
2961 3124
 	{
2962
-		if ($command_line)
2963
-			return DeleteUpgrade();
2964
-		else
2965
-			return true;
3125
+		if ($command_line) {
3126
+					return DeleteUpgrade();
3127
+		} else {
3128
+					return true;
3129
+		}
2966 3130
 	}
2967 3131
 
2968 3132
 	// Done it already - js wise?
2969
-	if (!empty($_POST['json_done']))
2970
-		return true;
3133
+	if (!empty($_POST['json_done'])) {
3134
+			return true;
3135
+	}
2971 3136
 
2972 3137
 	// List of tables affected by this function
2973 3138
 	// name => array('key', col1[,col2|true[,col3]])
@@ -2999,12 +3164,14 @@  discard block
 block discarded – undo
2999 3164
 	$upcontext['cur_table_name'] = isset($keys[$_GET['substep']]) ? $keys[$_GET['substep']] : $keys[0];
3000 3165
 	$upcontext['step_progress'] = (int) (($upcontext['cur_table_num'] / $upcontext['table_count']) * 100);
3001 3166
 
3002
-	foreach ($keys as $id => $table)
3003
-		if ($id < $_GET['substep'])
3167
+	foreach ($keys as $id => $table) {
3168
+			if ($id < $_GET['substep'])
3004 3169
 			$upcontext['previous_tables'][] = $table;
3170
+	}
3005 3171
 
3006
-	if ($command_line)
3007
-		echo 'Converting data from serialize() to json_encode().';
3172
+	if ($command_line) {
3173
+			echo 'Converting data from serialize() to json_encode().';
3174
+	}
3008 3175
 
3009 3176
 	if (!$support_js || isset($_GET['xml']))
3010 3177
 	{
@@ -3044,8 +3211,9 @@  discard block
 block discarded – undo
3044 3211
 
3045 3212
 				// Loop through and fix these...
3046 3213
 				$new_settings = array();
3047
-				if ($command_line)
3048
-					echo "\n" . 'Fixing some settings...';
3214
+				if ($command_line) {
3215
+									echo "\n" . 'Fixing some settings...';
3216
+				}
3049 3217
 
3050 3218
 				foreach ($serialized_settings as $var)
3051 3219
 				{
@@ -3053,22 +3221,24 @@  discard block
 block discarded – undo
3053 3221
 					{
3054 3222
 						// Attempt to unserialize the setting
3055 3223
 						$temp = @safe_unserialize($modSettings[$var]);
3056
-						if (!$temp && $command_line)
3057
-							echo "\n - Failed to unserialize the '" . $var . "' setting. Skipping.";
3058
-						elseif ($temp !== false)
3059
-							$new_settings[$var] = json_encode($temp);
3224
+						if (!$temp && $command_line) {
3225
+													echo "\n - Failed to unserialize the '" . $var . "' setting. Skipping.";
3226
+						} elseif ($temp !== false) {
3227
+													$new_settings[$var] = json_encode($temp);
3228
+						}
3060 3229
 					}
3061 3230
 				}
3062 3231
 
3063 3232
 				// Update everything at once
3064
-				if (!function_exists('cache_put_data'))
3065
-					require_once($sourcedir . '/Load.php');
3233
+				if (!function_exists('cache_put_data')) {
3234
+									require_once($sourcedir . '/Load.php');
3235
+				}
3066 3236
 				updateSettings($new_settings, true);
3067 3237
 
3068
-				if ($command_line)
3069
-					echo ' done.';
3070
-			}
3071
-			elseif ($table == 'themes')
3238
+				if ($command_line) {
3239
+									echo ' done.';
3240
+				}
3241
+			} elseif ($table == 'themes')
3072 3242
 			{
3073 3243
 				// Finally, fix the admin prefs. Unfortunately this is stored per theme, but hopefully they only have one theme installed at this point...
3074 3244
 				$query = $smcFunc['db_query']('', '
@@ -3087,10 +3257,11 @@  discard block
 block discarded – undo
3087 3257
 
3088 3258
 						if ($command_line)
3089 3259
 						{
3090
-							if ($temp === false)
3091
-								echo "\n" . 'Unserialize of admin_preferences for user ' . $row['id_member'] . ' failed. Skipping.';
3092
-							else
3093
-								echo "\n" . 'Fixing admin preferences...';
3260
+							if ($temp === false) {
3261
+															echo "\n" . 'Unserialize of admin_preferences for user ' . $row['id_member'] . ' failed. Skipping.';
3262
+							} else {
3263
+															echo "\n" . 'Fixing admin preferences...';
3264
+							}
3094 3265
 						}
3095 3266
 
3096 3267
 						if ($temp !== false)
@@ -3112,15 +3283,15 @@  discard block
 block discarded – undo
3112 3283
 								)
3113 3284
 							);
3114 3285
 
3115
-							if ($command_line)
3116
-								echo ' done.';
3286
+							if ($command_line) {
3287
+															echo ' done.';
3288
+							}
3117 3289
 						}
3118 3290
 					}
3119 3291
 
3120 3292
 					$smcFunc['db_free_result']($query);
3121 3293
 				}
3122
-			}
3123
-			else
3294
+			} else
3124 3295
 			{
3125 3296
 				// First item is always the key...
3126 3297
 				$key = $info[0];
@@ -3131,8 +3302,7 @@  discard block
 block discarded – undo
3131 3302
 				{
3132 3303
 					$col_select = $info[1];
3133 3304
 					$where = ' WHERE ' . $info[1] . ' != {empty}';
3134
-				}
3135
-				else
3305
+				} else
3136 3306
 				{
3137 3307
 					$col_select = implode(', ', $info);
3138 3308
 				}
@@ -3165,8 +3335,7 @@  discard block
 block discarded – undo
3165 3335
 								if ($temp === false && $command_line)
3166 3336
 								{
3167 3337
 									echo "\nFailed to unserialize " . $row[$col] . "... Skipping\n";
3168
-								}
3169
-								else
3338
+								} else
3170 3339
 								{
3171 3340
 									$row[$col] = json_encode($temp);
3172 3341
 
@@ -3191,16 +3360,18 @@  discard block
 block discarded – undo
3191 3360
 						}
3192 3361
 					}
3193 3362
 
3194
-					if ($command_line)
3195
-						echo ' done.';
3363
+					if ($command_line) {
3364
+											echo ' done.';
3365
+					}
3196 3366
 
3197 3367
 					// Free up some memory...
3198 3368
 					$smcFunc['db_free_result']($query);
3199 3369
 				}
3200 3370
 			}
3201 3371
 			// If this is XML to keep it nice for the user do one table at a time anyway!
3202
-			if (isset($_GET['xml']))
3203
-				return upgradeExit();
3372
+			if (isset($_GET['xml'])) {
3373
+							return upgradeExit();
3374
+			}
3204 3375
 		}
3205 3376
 
3206 3377
 		if ($command_line)
@@ -3215,8 +3386,9 @@  discard block
 block discarded – undo
3215 3386
 
3216 3387
 		$_GET['substep'] = 0;
3217 3388
 		// Make sure we move on!
3218
-		if ($command_line)
3219
-			return DeleteUpgrade();
3389
+		if ($command_line) {
3390
+					return DeleteUpgrade();
3391
+		}
3220 3392
 
3221 3393
 		return true;
3222 3394
 	}
@@ -3236,14 +3408,16 @@  discard block
 block discarded – undo
3236 3408
 	global $upcontext, $txt, $settings;
3237 3409
 
3238 3410
 	// Don't call me twice!
3239
-	if (!empty($upcontext['chmod_called']))
3240
-		return;
3411
+	if (!empty($upcontext['chmod_called'])) {
3412
+			return;
3413
+	}
3241 3414
 
3242 3415
 	$upcontext['chmod_called'] = true;
3243 3416
 
3244 3417
 	// Nothing?
3245
-	if (empty($upcontext['chmod']['files']) && empty($upcontext['chmod']['ftp_error']))
3246
-		return;
3418
+	if (empty($upcontext['chmod']['files']) && empty($upcontext['chmod']['ftp_error'])) {
3419
+			return;
3420
+	}
3247 3421
 
3248 3422
 	// Was it a problem with Windows?
3249 3423
 	if (!empty($upcontext['chmod']['ftp_error']) && $upcontext['chmod']['ftp_error'] == 'total_mess')
@@ -3275,11 +3449,12 @@  discard block
 block discarded – undo
3275 3449
 					content.write(\'<div class="windowbg description">\n\t\t\t<h4>The following files needs to be made writable to continue:</h4>\n\t\t\t\');
3276 3450
 					content.write(\'<p>', implode('<br>\n\t\t\t', $upcontext['chmod']['files']), '</p>\n\t\t\t\');';
3277 3451
 
3278
-	if (isset($upcontext['systemos']) && $upcontext['systemos'] == 'linux')
3279
-		echo '
3452
+	if (isset($upcontext['systemos']) && $upcontext['systemos'] == 'linux') {
3453
+			echo '
3280 3454
 					content.write(\'<hr>\n\t\t\t\');
3281 3455
 					content.write(\'<p>If you have a shell account, the convenient below command can automatically correct permissions on these files</p>\n\t\t\t\');
3282 3456
 					content.write(\'<tt># chmod a+w ', implode(' ', $upcontext['chmod']['files']), '</tt>\n\t\t\t\');';
3457
+	}
3283 3458
 
3284 3459
 	echo '
3285 3460
 					content.write(\'<a href="javascript:self.close();">close</a>\n\t\t</div>\n\t</body>\n</html>\');
@@ -3287,17 +3462,19 @@  discard block
 block discarded – undo
3287 3462
 				}
3288 3463
 			</script>';
3289 3464
 
3290
-	if (!empty($upcontext['chmod']['ftp_error']))
3291
-		echo '
3465
+	if (!empty($upcontext['chmod']['ftp_error'])) {
3466
+			echo '
3292 3467
 			<div class="error_message red">
3293 3468
 				The following error was encountered when trying to connect:<br><br>
3294 3469
 				<code>', $upcontext['chmod']['ftp_error'], '</code>
3295 3470
 			</div>
3296 3471
 			<br>';
3472
+	}
3297 3473
 
3298
-	if (empty($upcontext['chmod_in_form']))
3299
-		echo '
3474
+	if (empty($upcontext['chmod_in_form'])) {
3475
+			echo '
3300 3476
 	<form action="', $upcontext['form_url'], '" method="post">';
3477
+	}
3301 3478
 
3302 3479
 	echo '
3303 3480
 		<table width="520" border="0" align="center" style="margin-bottom: 1ex;">
@@ -3332,10 +3509,11 @@  discard block
 block discarded – undo
3332 3509
 		<div class="righttext" style="margin: 1ex;"><input type="submit" value="', $txt['ftp_connect'], '" class="button_submit"></div>
3333 3510
 	</div>';
3334 3511
 
3335
-	if (empty($upcontext['chmod_in_form']))
3336
-		echo '
3512
+	if (empty($upcontext['chmod_in_form'])) {
3513
+			echo '
3337 3514
 	</form>';
3338
-}
3515
+	}
3516
+	}
3339 3517
 
3340 3518
 function template_upgrade_above()
3341 3519
 {
@@ -3395,9 +3573,10 @@  discard block
 block discarded – undo
3395 3573
 				<h2>', $txt['upgrade_progress'], '</h2>
3396 3574
 				<ul>';
3397 3575
 
3398
-	foreach ($upcontext['steps'] as $num => $step)
3399
-		echo '
3576
+	foreach ($upcontext['steps'] as $num => $step) {
3577
+			echo '
3400 3578
 						<li class="', $num < $upcontext['current_step'] ? 'stepdone' : ($num == $upcontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>';
3579
+	}
3401 3580
 
3402 3581
 	echo '
3403 3582
 					</ul>
@@ -3410,8 +3589,8 @@  discard block
 block discarded – undo
3410 3589
 				</div>
3411 3590
 			</div>';
3412 3591
 
3413
-	if (isset($upcontext['step_progress']))
3414
-		echo '
3592
+	if (isset($upcontext['step_progress'])) {
3593
+			echo '
3415 3594
 				<br>
3416 3595
 				<br>
3417 3596
 				<div id="progress_bar_step">
@@ -3420,6 +3599,7 @@  discard block
 block discarded – undo
3420 3599
 						<span>', $txt['upgrade_step_progress'], '</span>
3421 3600
 					</div>
3422 3601
 				</div>';
3602
+	}
3423 3603
 
3424 3604
 	echo '
3425 3605
 				<div id="substep_bar_div" class="smalltext" style="float: left;width: 50%;margin-top: 0.6em;display: ', isset($upcontext['substep_progress']) ? '' : 'none', ';">', isset($upcontext['substep_progress_name']) ? trim(strtr($upcontext['substep_progress_name'], array('.' => ''))) : '', ':</div>
@@ -3450,32 +3630,36 @@  discard block
 block discarded – undo
3450 3630
 {
3451 3631
 	global $upcontext, $txt;
3452 3632
 
3453
-	if (!empty($upcontext['pause']))
3454
-		echo '
3633
+	if (!empty($upcontext['pause'])) {
3634
+			echo '
3455 3635
 								<em>', $txt['upgrade_incomplete'], '.</em><br>
3456 3636
 
3457 3637
 								<h2 style="margin-top: 2ex;">', $txt['upgrade_not_quite_done'], '</h2>
3458 3638
 								<h3>
3459 3639
 									', $txt['upgrade_paused_overload'], '
3460 3640
 								</h3>';
3641
+	}
3461 3642
 
3462
-	if (!empty($upcontext['custom_warning']))
3463
-		echo '
3643
+	if (!empty($upcontext['custom_warning'])) {
3644
+			echo '
3464 3645
 								<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
3465 3646
 									<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
3466 3647
 									<strong style="text-decoration: underline;">', $txt['upgrade_note'], '</strong><br>
3467 3648
 									<div style="padding-left: 6ex;">', $upcontext['custom_warning'], '</div>
3468 3649
 								</div>';
3650
+	}
3469 3651
 
3470 3652
 	echo '
3471 3653
 								<div class="righttext" style="margin: 1ex;">';
3472 3654
 
3473
-	if (!empty($upcontext['continue']))
3474
-		echo '
3655
+	if (!empty($upcontext['continue'])) {
3656
+			echo '
3475 3657
 									<input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '"', $upcontext['continue'] == 2 ? ' disabled' : '', ' class="button_submit">';
3476
-	if (!empty($upcontext['skip']))
3477
-		echo '
3658
+	}
3659
+	if (!empty($upcontext['skip'])) {
3660
+			echo '
3478 3661
 									<input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="dontSubmit = true; document.getElementById(\'contbutt\').disabled = \'disabled\'; return true;" class="button_submit">';
3662
+	}
3479 3663
 
3480 3664
 	echo '
3481 3665
 								</div>
@@ -3525,11 +3709,12 @@  discard block
 block discarded – undo
3525 3709
 	echo '<', '?xml version="1.0" encoding="UTF-8"?', '>
3526 3710
 	<smf>';
3527 3711
 
3528
-	if (!empty($upcontext['get_data']))
3529
-		foreach ($upcontext['get_data'] as $k => $v)
3712
+	if (!empty($upcontext['get_data'])) {
3713
+			foreach ($upcontext['get_data'] as $k => $v)
3530 3714
 			echo '
3531 3715
 		<get key="', $k, '">', $v, '</get>';
3532
-}
3716
+	}
3717
+	}
3533 3718
 
3534 3719
 function template_xml_below()
3535 3720
 {
@@ -3570,8 +3755,8 @@  discard block
 block discarded – undo
3570 3755
 	template_chmod();
3571 3756
 
3572 3757
 	// For large, pre 1.1 RC2 forums give them a warning about the possible impact of this upgrade!
3573
-	if ($upcontext['is_large_forum'])
3574
-		echo '
3758
+	if ($upcontext['is_large_forum']) {
3759
+			echo '
3575 3760
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
3576 3761
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
3577 3762
 			<strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br>
@@ -3579,10 +3764,11 @@  discard block
 block discarded – undo
3579 3764
 				', $txt['upgrade_warning_lots_data'], '
3580 3765
 			</div>
3581 3766
 		</div>';
3767
+	}
3582 3768
 
3583 3769
 	// A warning message?
3584
-	if (!empty($upcontext['warning']))
3585
-		echo '
3770
+	if (!empty($upcontext['warning'])) {
3771
+			echo '
3586 3772
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
3587 3773
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
3588 3774
 			<strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br>
@@ -3590,6 +3776,7 @@  discard block
 block discarded – undo
3590 3776
 				', $upcontext['warning'], '
3591 3777
 			</div>
3592 3778
 		</div>';
3779
+	}
3593 3780
 
3594 3781
 	// Paths are incorrect?
3595 3782
 	echo '
@@ -3605,20 +3792,22 @@  discard block
 block discarded – undo
3605 3792
 	if (!empty($upcontext['user']['id']) && (time() - $upcontext['started'] < 72600 || time() - $upcontext['updated'] < 3600))
3606 3793
 	{
3607 3794
 		$ago = time() - $upcontext['started'];
3608
-		if ($ago < 60)
3609
-			$ago = $ago . ' seconds';
3610
-		elseif ($ago < 3600)
3611
-			$ago = (int) ($ago / 60) . ' minutes';
3612
-		else
3613
-			$ago = (int) ($ago / 3600) . ' hours';
3795
+		if ($ago < 60) {
3796
+					$ago = $ago . ' seconds';
3797
+		} elseif ($ago < 3600) {
3798
+					$ago = (int) ($ago / 60) . ' minutes';
3799
+		} else {
3800
+					$ago = (int) ($ago / 3600) . ' hours';
3801
+		}
3614 3802
 
3615 3803
 		$active = time() - $upcontext['updated'];
3616
-		if ($active < 60)
3617
-			$updated = $active . ' seconds';
3618
-		elseif ($active < 3600)
3619
-			$updated = (int) ($active / 60) . ' minutes';
3620
-		else
3621
-			$updated = (int) ($active / 3600) . ' hours';
3804
+		if ($active < 60) {
3805
+					$updated = $active . ' seconds';
3806
+		} elseif ($active < 3600) {
3807
+					$updated = (int) ($active / 60) . ' minutes';
3808
+		} else {
3809
+					$updated = (int) ($active / 3600) . ' hours';
3810
+		}
3622 3811
 
3623 3812
 		echo '
3624 3813
 		<div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;">
@@ -3627,16 +3816,18 @@  discard block
 block discarded – undo
3627 3816
 			<div style="padding-left: 6ex;">
3628 3817
 				&quot;', $upcontext['user']['name'], '&quot; has been running the upgrade script for the last ', $ago, ' - and was last active ', $updated, ' ago.';
3629 3818
 
3630
-		if ($active < 600)
3631
-			echo '
3819
+		if ($active < 600) {
3820
+					echo '
3632 3821
 				We recommend that you do not run this script unless you are sure that ', $upcontext['user']['name'], ' has completed their upgrade.';
3822
+		}
3633 3823
 
3634
-		if ($active > $upcontext['inactive_timeout'])
3635
-			echo '
3824
+		if ($active > $upcontext['inactive_timeout']) {
3825
+					echo '
3636 3826
 				<br><br>You can choose to either run the upgrade again from the beginning - or alternatively continue from the last step reached during the last upgrade.';
3637
-		else
3638
-			echo '
3827
+		} else {
3828
+					echo '
3639 3829
 				<br><br>This upgrade script cannot be run until ', $upcontext['user']['name'], ' has been inactive for at least ', ($upcontext['inactive_timeout'] > 120 ? round($upcontext['inactive_timeout'] / 60, 1) . ' minutes!' : $upcontext['inactive_timeout'] . ' seconds!');
3830
+		}
3640 3831
 
3641 3832
 		echo '
3642 3833
 			</div>
@@ -3652,9 +3843,10 @@  discard block
 block discarded – undo
3652 3843
 					<td>
3653 3844
 						<input type="text" name="user" value="', !empty($upcontext['username']) ? $upcontext['username'] : '', '"', $disable_security ? ' disabled' : '', '>';
3654 3845
 
3655
-	if (!empty($upcontext['username_incorrect']))
3656
-		echo '
3846
+	if (!empty($upcontext['username_incorrect'])) {
3847
+			echo '
3657 3848
 						<div class="smalltext" style="color: red;">Username Incorrect</div>';
3849
+	}
3658 3850
 
3659 3851
 	echo '
3660 3852
 					</td>
@@ -3665,9 +3857,10 @@  discard block
 block discarded – undo
3665 3857
 						<input type="password" name="passwrd" value=""', $disable_security ? ' disabled' : '', '>
3666 3858
 						<input type="hidden" name="hash_passwrd" value="">';
3667 3859
 
3668
-	if (!empty($upcontext['password_failed']))
3669
-		echo '
3860
+	if (!empty($upcontext['password_failed'])) {
3861
+			echo '
3670 3862
 						<div class="smalltext" style="color: red;">Password Incorrect</div>';
3863
+	}
3671 3864
 
3672 3865
 	echo '
3673 3866
 					</td>
@@ -3738,8 +3931,8 @@  discard block
 block discarded – undo
3738 3931
 			<form action="', $upcontext['form_url'], '" method="post" name="upform" id="upform">';
3739 3932
 
3740 3933
 	// Warning message?
3741
-	if (!empty($upcontext['upgrade_options_warning']))
3742
-		echo '
3934
+	if (!empty($upcontext['upgrade_options_warning'])) {
3935
+			echo '
3743 3936
 		<div style="margin: 1ex; padding: 1ex; border: 1px dashed #cc3344; color: black; background-color: #ffe4e9;">
3744 3937
 			<div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div>
3745 3938
 			<strong style="text-decoration: underline;">Warning!</strong><br>
@@ -3747,6 +3940,7 @@  discard block
 block discarded – undo
3747 3940
 				', $upcontext['upgrade_options_warning'], '
3748 3941
 			</div>
3749 3942
 		</div>';
3943
+	}
3750 3944
 
3751 3945
 	echo '
3752 3946
 				<table>
@@ -3789,8 +3983,8 @@  discard block
 block discarded – undo
3789 3983
 						</td>
3790 3984
 					</tr>';
3791 3985
 
3792
-	if (!empty($upcontext['karma_installed']['good']) || !empty($upcontext['karma_installed']['bad']))
3793
-		echo '
3986
+	if (!empty($upcontext['karma_installed']['good']) || !empty($upcontext['karma_installed']['bad'])) {
3987
+			echo '
3794 3988
 					<tr valign="top">
3795 3989
 						<td width="2%">
3796 3990
 							<input type="checkbox" name="delete_karma" id="delete_karma" value="1">
@@ -3799,6 +3993,7 @@  discard block
 block discarded – undo
3799 3993
 							<label for="delete_karma">Delete all karma settings and info from the DB</label>
3800 3994
 						</td>
3801 3995
 					</tr>';
3996
+	}
3802 3997
 
3803 3998
 	echo '
3804 3999
 					<tr valign="top">
@@ -3836,10 +4031,11 @@  discard block
 block discarded – undo
3836 4031
 			</div>';
3837 4032
 
3838 4033
 	// Dont any tables so far?
3839
-	if (!empty($upcontext['previous_tables']))
3840
-		foreach ($upcontext['previous_tables'] as $table)
4034
+	if (!empty($upcontext['previous_tables'])) {
4035
+			foreach ($upcontext['previous_tables'] as $table)
3841 4036
 			echo '
3842 4037
 			<br>Completed Table: &quot;', $table, '&quot;.';
4038
+	}
3843 4039
 
3844 4040
 	echo '
3845 4041
 			<h3 id="current_tab_div">Current Table: &quot;<span id="current_table">', $upcontext['cur_table_name'], '</span>&quot;</h3>
@@ -3876,12 +4072,13 @@  discard block
 block discarded – undo
3876 4072
 				updateStepProgress(iTableNum, ', $upcontext['table_count'], ', ', $upcontext['step_weight'] * ((100 - $upcontext['step_progress']) / 100), ');';
3877 4073
 
3878 4074
 		// If debug flood the screen.
3879
-		if ($is_debug)
3880
-			echo '
4075
+		if ($is_debug) {
4076
+					echo '
3881 4077
 				setOuterHTML(document.getElementById(\'debuginfo\'), \'<br>Completed Table: &quot;\' + sCompletedTableName + \'&quot;.<span id="debuginfo"><\' + \'/span>\');
3882 4078
 
3883 4079
 				if (document.getElementById(\'debug_section\').scrollHeight)
3884 4080
 					document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight';
4081
+		}
3885 4082
 
3886 4083
 		echo '
3887 4084
 				// Get the next update...
@@ -3914,8 +4111,9 @@  discard block
 block discarded – undo
3914 4111
 {
3915 4112
 	global $upcontext, $support_js, $is_debug, $timeLimitThreshold;
3916 4113
 
3917
-	if (empty($is_debug) && !empty($upcontext['upgrade_status']['debug']))
3918
-		$is_debug = true;
4114
+	if (empty($is_debug) && !empty($upcontext['upgrade_status']['debug'])) {
4115
+			$is_debug = true;
4116
+	}
3919 4117
 
3920 4118
 	echo '
3921 4119
 		<h3>Executing database changes</h3>
@@ -3930,8 +4128,9 @@  discard block
 block discarded – undo
3930 4128
 	{
3931 4129
 		foreach ($upcontext['actioned_items'] as $num => $item)
3932 4130
 		{
3933
-			if ($num != 0)
3934
-				echo ' Successful!';
4131
+			if ($num != 0) {
4132
+							echo ' Successful!';
4133
+			}
3935 4134
 			echo '<br>' . $item;
3936 4135
 		}
3937 4136
 		if (!empty($upcontext['changes_complete']))
@@ -3944,28 +4143,32 @@  discard block
 block discarded – undo
3944 4143
 				$seconds = intval($active % 60);
3945 4144
 
3946 4145
 				$totalTime = '';
3947
-				if ($hours > 0)
3948
-					$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
3949
-				if ($minutes > 0)
3950
-					$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
3951
-				if ($seconds > 0)
3952
-					$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
4146
+				if ($hours > 0) {
4147
+									$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
4148
+				}
4149
+				if ($minutes > 0) {
4150
+									$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
4151
+				}
4152
+				if ($seconds > 0) {
4153
+									$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
4154
+				}
3953 4155
 			}
3954 4156
 
3955
-			if ($is_debug && !empty($totalTime))
3956
-				echo ' Successful! Completed in ', $totalTime, '<br><br>';
3957
-			else
3958
-				echo ' Successful!<br><br>';
4157
+			if ($is_debug && !empty($totalTime)) {
4158
+							echo ' Successful! Completed in ', $totalTime, '<br><br>';
4159
+			} else {
4160
+							echo ' Successful!<br><br>';
4161
+			}
3959 4162
 
3960 4163
 			echo '<span id="commess" style="font-weight: bold;">1 Database Updates Complete! Click Continue to Proceed.</span><br>';
3961 4164
 		}
3962
-	}
3963
-	else
4165
+	} else
3964 4166
 	{
3965 4167
 		// Tell them how many files we have in total.
3966
-		if ($upcontext['file_count'] > 1)
3967
-			echo '
4168
+		if ($upcontext['file_count'] > 1) {
4169
+					echo '
3968 4170
 		<strong id="info1">Executing upgrade script <span id="file_done">', $upcontext['cur_file_num'], '</span> of ', $upcontext['file_count'], '.</strong>';
4171
+		}
3969 4172
 
3970 4173
 		echo '
3971 4174
 		<h3 id="info2"><strong>Executing:</strong> &quot;<span id="cur_item_name">', $upcontext['current_item_name'], '</span>&quot; (<span id="item_num">', $upcontext['current_item_num'], '</span> of <span id="total_items"><span id="item_count">', $upcontext['total_items'], '</span>', $upcontext['file_count'] > 1 ? ' - of this script' : '', ')</span></h3>
@@ -3981,19 +4184,23 @@  discard block
 block discarded – undo
3981 4184
 				$seconds = intval($active % 60);
3982 4185
 
3983 4186
 				$totalTime = '';
3984
-				if ($hours > 0)
3985
-					$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
3986
-				if ($minutes > 0)
3987
-					$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
3988
-				if ($seconds > 0)
3989
-					$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
4187
+				if ($hours > 0) {
4188
+									$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
4189
+				}
4190
+				if ($minutes > 0) {
4191
+									$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
4192
+				}
4193
+				if ($seconds > 0) {
4194
+									$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
4195
+				}
3990 4196
 			}
3991 4197
 
3992 4198
 			echo '
3993 4199
 			<br><span id="upgradeCompleted">';
3994 4200
 
3995
-			if (!empty($totalTime))
3996
-				echo 'Completed in ', $totalTime, '<br>';
4201
+			if (!empty($totalTime)) {
4202
+							echo 'Completed in ', $totalTime, '<br>';
4203
+			}
3997 4204
 
3998 4205
 			echo '</span>
3999 4206
 			<div id="debug_section" style="height: 59px; overflow: auto;">
@@ -4030,9 +4237,10 @@  discard block
 block discarded – undo
4030 4237
 			var getData = "";
4031 4238
 			var debugItems = ', $upcontext['debug_items'], ';';
4032 4239
 
4033
-		if ($is_debug)
4034
-			echo '
4240
+		if ($is_debug) {
4241
+					echo '
4035 4242
 			var upgradeStartTime = ' . $upcontext['started'] . ';';
4243
+		}
4036 4244
 
4037 4245
 		echo '
4038 4246
 			function getNextItem()
@@ -4072,9 +4280,10 @@  discard block
 block discarded – undo
4072 4280
 						document.getElementById("error_block").style.display = "";
4073 4281
 						setInnerHTML(document.getElementById("error_message"), "Error retrieving information on step: " + (sDebugName == "" ? sLastString : sDebugName));';
4074 4282
 
4075
-	if ($is_debug)
4076
-		echo '
4283
+	if ($is_debug) {
4284
+			echo '
4077 4285
 						setOuterHTML(document.getElementById(\'debuginfo\'), \'<span style="color: red;">failed<\' + \'/span><span id="debuginfo"><\' + \'/span>\');';
4286
+	}
4078 4287
 
4079 4288
 	echo '
4080 4289
 					}
@@ -4095,9 +4304,10 @@  discard block
 block discarded – undo
4095 4304
 						document.getElementById("error_block").style.display = "";
4096 4305
 						setInnerHTML(document.getElementById("error_message"), "Upgrade script appears to be going into a loop - step: " + sDebugName);';
4097 4306
 
4098
-	if ($is_debug)
4099
-		echo '
4307
+	if ($is_debug) {
4308
+			echo '
4100 4309
 						setOuterHTML(document.getElementById(\'debuginfo\'), \'<span style="color: red;">failed<\' + \'/span><span id="debuginfo"><\' + \'/span>\');';
4310
+	}
4101 4311
 
4102 4312
 	echo '
4103 4313
 					}
@@ -4156,8 +4366,8 @@  discard block
 block discarded – undo
4156 4366
 				if (bIsComplete && iDebugNum == -1 && curFile >= ', $upcontext['file_count'], ')
4157 4367
 				{';
4158 4368
 
4159
-		if ($is_debug)
4160
-			echo '
4369
+		if ($is_debug) {
4370
+					echo '
4161 4371
 					document.getElementById(\'debug_section\').style.display = "none";
4162 4372
 
4163 4373
 					var upgradeFinishedTime = parseInt(oXMLDoc.getElementsByTagName("curtime")[0].childNodes[0].nodeValue);
@@ -4175,6 +4385,7 @@  discard block
 block discarded – undo
4175 4385
 						totalTime = totalTime + diffSeconds + " second" + (diffSeconds > 1 ? "s" : "");
4176 4386
 
4177 4387
 					setInnerHTML(document.getElementById("upgradeCompleted"), "Completed in " + totalTime);';
4388
+		}
4178 4389
 
4179 4390
 		echo '
4180 4391
 
@@ -4182,9 +4393,10 @@  discard block
 block discarded – undo
4182 4393
 					document.getElementById(\'contbutt\').disabled = 0;
4183 4394
 					document.getElementById(\'database_done\').value = 1;';
4184 4395
 
4185
-		if ($upcontext['file_count'] > 1)
4186
-			echo '
4396
+		if ($upcontext['file_count'] > 1) {
4397
+					echo '
4187 4398
 					document.getElementById(\'info1\').style.display = "none";';
4399
+		}
4188 4400
 
4189 4401
 		echo '
4190 4402
 					document.getElementById(\'info2\').style.display = "none";
@@ -4197,9 +4409,10 @@  discard block
 block discarded – undo
4197 4409
 					lastItem = 0;
4198 4410
 					prevFile = curFile;';
4199 4411
 
4200
-		if ($is_debug)
4201
-			echo '
4412
+		if ($is_debug) {
4413
+					echo '
4202 4414
 					setOuterHTML(document.getElementById(\'debuginfo\'), \'Moving to next script file...done<br><span id="debuginfo"><\' + \'/span>\');';
4415
+		}
4203 4416
 
4204 4417
 		echo '
4205 4418
 					getNextItem();
@@ -4207,8 +4420,8 @@  discard block
 block discarded – undo
4207 4420
 				}';
4208 4421
 
4209 4422
 		// If debug scroll the screen.
4210
-		if ($is_debug)
4211
-			echo '
4423
+		if ($is_debug) {
4424
+					echo '
4212 4425
 				if (iLastSubStepProgress == -1)
4213 4426
 				{
4214 4427
 					// Give it consistent dots.
@@ -4227,6 +4440,7 @@  discard block
 block discarded – undo
4227 4440
 
4228 4441
 				if (document.getElementById(\'debug_section\').scrollHeight)
4229 4442
 					document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight';
4443
+		}
4230 4444
 
4231 4445
 		echo '
4232 4446
 				// Update the page.
@@ -4287,9 +4501,10 @@  discard block
 block discarded – undo
4287 4501
 			}';
4288 4502
 
4289 4503
 		// Start things off assuming we've not errored.
4290
-		if (empty($upcontext['error_message']))
4291
-			echo '
4504
+		if (empty($upcontext['error_message'])) {
4505
+					echo '
4292 4506
 			getNextItem();';
4507
+		}
4293 4508
 
4294 4509
 		echo '
4295 4510
 		//# sourceURL=dynamicScript-dbch.js
@@ -4307,18 +4522,21 @@  discard block
 block discarded – undo
4307 4522
 	<item num="', $upcontext['current_item_num'], '">', $upcontext['current_item_name'], '</item>
4308 4523
 	<debug num="', $upcontext['current_debug_item_num'], '" percent="', isset($upcontext['substep_progress']) ? $upcontext['substep_progress'] : '-1', '" complete="', empty($upcontext['completed_step']) ? 0 : 1, '">', $upcontext['current_debug_item_name'], '</debug>';
4309 4524
 
4310
-	if (!empty($upcontext['error_message']))
4311
-		echo '
4525
+	if (!empty($upcontext['error_message'])) {
4526
+			echo '
4312 4527
 	<error>', $upcontext['error_message'], '</error>';
4528
+	}
4313 4529
 
4314
-	if (!empty($upcontext['error_string']))
4315
-		echo '
4530
+	if (!empty($upcontext['error_string'])) {
4531
+			echo '
4316 4532
 	<sql>', $upcontext['error_string'], '</sql>';
4533
+	}
4317 4534
 
4318
-	if ($is_debug)
4319
-		echo '
4535
+	if ($is_debug) {
4536
+			echo '
4320 4537
 	<curtime>', time(), '</curtime>';
4321
-}
4538
+	}
4539
+	}
4322 4540
 
4323 4541
 // Template for the UTF-8 conversion step. Basically a copy of the backup stuff with slight modifications....
4324 4542
 function template_convert_utf8()
@@ -4337,18 +4555,20 @@  discard block
 block discarded – undo
4337 4555
 			</div>';
4338 4556
 
4339 4557
 	// Done any tables so far?
4340
-	if (!empty($upcontext['previous_tables']))
4341
-		foreach ($upcontext['previous_tables'] as $table)
4558
+	if (!empty($upcontext['previous_tables'])) {
4559
+			foreach ($upcontext['previous_tables'] as $table)
4342 4560
 			echo '
4343 4561
 			<br>Completed Table: &quot;', $table, '&quot;.';
4562
+	}
4344 4563
 
4345 4564
 	echo '
4346 4565
 			<h3 id="current_tab_div">Current Table: &quot;<span id="current_table">', $upcontext['cur_table_name'], '</span>&quot;</h3>';
4347 4566
 
4348 4567
 	// If we dropped their index, let's let them know
4349
-	if ($upcontext['dropping_index'])
4350
-		echo '
4568
+	if ($upcontext['dropping_index']) {
4569
+			echo '
4351 4570
 				<br><span id="indexmsg" style="font-weight: bold; font-style: italic; display: ', $upcontext['cur_table_num'] == $upcontext['table_count'] ? 'inline' : 'none', ';">Please note that your fulltext index was dropped to facilitate the conversion and will need to be recreated in the admin area after the upgrade is complete.</span>';
4571
+	}
4352 4572
 
4353 4573
 	// Completion notification
4354 4574
 	echo '
@@ -4385,12 +4605,13 @@  discard block
 block discarded – undo
4385 4605
 				updateStepProgress(iTableNum, ', $upcontext['table_count'], ', ', $upcontext['step_weight'] * ((100 - $upcontext['step_progress']) / 100), ');';
4386 4606
 
4387 4607
 		// If debug flood the screen.
4388
-		if ($is_debug)
4389
-			echo '
4608
+		if ($is_debug) {
4609
+					echo '
4390 4610
 				setOuterHTML(document.getElementById(\'debuginfo\'), \'<br>Completed Table: &quot;\' + sCompletedTableName + \'&quot;.<span id="debuginfo"><\' + \'/span>\');
4391 4611
 
4392 4612
 				if (document.getElementById(\'debug_section\').scrollHeight)
4393 4613
 					document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight';
4614
+		}
4394 4615
 
4395 4616
 		echo '
4396 4617
 				// Get the next update...
@@ -4438,19 +4659,21 @@  discard block
 block discarded – undo
4438 4659
 			</div>';
4439 4660
 
4440 4661
 	// Dont any tables so far?
4441
-	if (!empty($upcontext['previous_tables']))
4442
-		foreach ($upcontext['previous_tables'] as $table)
4662
+	if (!empty($upcontext['previous_tables'])) {
4663
+			foreach ($upcontext['previous_tables'] as $table)
4443 4664
 			echo '
4444 4665
 			<br>Completed Table: &quot;', $table, '&quot;.';
4666
+	}
4445 4667
 
4446 4668
 	echo '
4447 4669
 			<h3 id="current_tab_div">Current Table: &quot;<span id="current_table">', $upcontext['cur_table_name'], '</span>&quot;</h3>
4448 4670
 			<br><span id="commess" style="font-weight: bold; display: ', $upcontext['cur_table_num'] == $upcontext['table_count'] ? 'inline' : 'none', ';">Convert to JSON Complete! Click Continue to Proceed.</span>';
4449 4671
 
4450 4672
 	// Try to make sure substep was reset.
4451
-	if ($upcontext['cur_table_num'] == $upcontext['table_count'])
4452
-		echo '
4673
+	if ($upcontext['cur_table_num'] == $upcontext['table_count']) {
4674
+			echo '
4453 4675
 			<input type="hidden" name="substep" id="substep" value="0">';
4676
+	}
4454 4677
 
4455 4678
 	// Continue please!
4456 4679
 	$upcontext['continue'] = $support_js ? 2 : 1;
@@ -4483,12 +4706,13 @@  discard block
 block discarded – undo
4483 4706
 				updateStepProgress(iTableNum, ', $upcontext['table_count'], ', ', $upcontext['step_weight'] * ((100 - $upcontext['step_progress']) / 100), ');';
4484 4707
 
4485 4708
 		// If debug flood the screen.
4486
-		if ($is_debug)
4487
-			echo '
4709
+		if ($is_debug) {
4710
+					echo '
4488 4711
 				setOuterHTML(document.getElementById(\'debuginfo\'), \'<br>Completed Table: &quot;\' + sCompletedTableName + \'&quot;.<span id="debuginfo"><\' + \'/span>\');
4489 4712
 
4490 4713
 				if (document.getElementById(\'debug_section\').scrollHeight)
4491 4714
 					document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight';
4715
+		}
4492 4716
 
4493 4717
 		echo '
4494 4718
 				// Get the next update...
@@ -4524,8 +4748,8 @@  discard block
 block discarded – undo
4524 4748
 	<h3>That wasn\'t so hard, was it?  Now you are ready to use <a href="', $boardurl, '/index.php">your installation of SMF</a>.  Hope you like it!</h3>
4525 4749
 	<form action="', $boardurl, '/index.php">';
4526 4750
 
4527
-	if (!empty($upcontext['can_delete_script']))
4528
-		echo '
4751
+	if (!empty($upcontext['can_delete_script'])) {
4752
+			echo '
4529 4753
 			<label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete(this);"> Delete upgrade.php and its data files now</label> <em>(doesn\'t work on all servers).</em>
4530 4754
 			<script>
4531 4755
 				function doTheDelete(theCheck)
@@ -4537,6 +4761,7 @@  discard block
 block discarded – undo
4537 4761
 				}
4538 4762
 			</script>
4539 4763
 			<img src="', $settings['default_theme_url'], '/images/blank.png" alt="" id="delete_upgrader"><br>';
4764
+	}
4540 4765
 
4541 4766
 	$active = time() - $upcontext['started'];
4542 4767
 	$hours = floor($active / 3600);
@@ -4546,16 +4771,20 @@  discard block
 block discarded – undo
4546 4771
 	if ($is_debug)
4547 4772
 	{
4548 4773
 		$totalTime = '';
4549
-		if ($hours > 0)
4550
-			$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
4551
-		if ($minutes > 0)
4552
-			$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
4553
-		if ($seconds > 0)
4554
-			$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
4774
+		if ($hours > 0) {
4775
+					$totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' ';
4776
+		}
4777
+		if ($minutes > 0) {
4778
+					$totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' ';
4779
+		}
4780
+		if ($seconds > 0) {
4781
+					$totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' ';
4782
+		}
4555 4783
 	}
4556 4784
 
4557
-	if ($is_debug && !empty($totalTime))
4558
-		echo '<br> Upgrade completed in ', $totalTime, '<br><br>';
4785
+	if ($is_debug && !empty($totalTime)) {
4786
+			echo '<br> Upgrade completed in ', $totalTime, '<br><br>';
4787
+	}
4559 4788
 
4560 4789
 	echo '<br>
4561 4790
 			If you had any problems with this upgrade, or have any problems using SMF, please don\'t hesitate to <a href="https://www.simplemachines.org/community/index.php">look to us for assistance</a>.<br>
@@ -4582,8 +4811,9 @@  discard block
 block discarded – undo
4582 4811
 
4583 4812
 	$current_substep = $_GET['substep'];
4584 4813
 
4585
-	if (empty($_GET['a']))
4586
-		$_GET['a'] = 0;
4814
+	if (empty($_GET['a'])) {
4815
+			$_GET['a'] = 0;
4816
+	}
4587 4817
 	$step_progress['name'] = 'Converting ips';
4588 4818
 	$step_progress['current'] = $_GET['a'];
4589 4819
 
@@ -4626,16 +4856,19 @@  discard block
 block discarded – undo
4626 4856
 				'empty' => '',
4627 4857
 				'limit' => $limit,
4628 4858
 		));
4629
-		while ($row = $smcFunc['db_fetch_assoc']($request))
4630
-			$arIp[] = $row[$oldCol];
4859
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
4860
+					$arIp[] = $row[$oldCol];
4861
+		}
4631 4862
 		$smcFunc['db_free_result']($request);
4632 4863
 
4633 4864
 		// Special case, null ip could keep us in a loop.
4634
-		if (is_null($arIp[0]))
4635
-			unset($arIp[0]);
4865
+		if (is_null($arIp[0])) {
4866
+					unset($arIp[0]);
4867
+		}
4636 4868
 
4637
-		if (empty($arIp))
4638
-			$is_done = true;
4869
+		if (empty($arIp)) {
4870
+					$is_done = true;
4871
+		}
4639 4872
 
4640 4873
 		$updates = array();
4641 4874
 		$cases = array();
@@ -4644,16 +4877,18 @@  discard block
 block discarded – undo
4644 4877
 		{
4645 4878
 			$arIp[$i] = trim($arIp[$i]);
4646 4879
 
4647
-			if (empty($arIp[$i]))
4648
-				continue;
4880
+			if (empty($arIp[$i])) {
4881
+							continue;
4882
+			}
4649 4883
 
4650 4884
 			$updates['ip' . $i] = $arIp[$i];
4651 4885
 			$cases[$arIp[$i]] = 'WHEN ' . $oldCol . ' = {string:ip' . $i . '} THEN {inet:ip' . $i . '}';
4652 4886
 
4653 4887
 			if ($setSize > 0 && $i % $setSize === 0)
4654 4888
 			{
4655
-				if (count($updates) == 1)
4656
-					continue;
4889
+				if (count($updates) == 1) {
4890
+									continue;
4891
+				}
4657 4892
 
4658 4893
 				$updates['whereSet'] = array_values($updates);
4659 4894
 				$smcFunc['db_query']('', '
@@ -4687,8 +4922,7 @@  discard block
 block discarded – undo
4687 4922
 							'ip' => $ip
4688 4923
 					));
4689 4924
 				}
4690
-			}
4691
-			else
4925
+			} else
4692 4926
 			{
4693 4927
 				$updates['whereSet'] = array_values($updates);
4694 4928
 				$smcFunc['db_query']('', '
@@ -4702,9 +4936,9 @@  discard block
 block discarded – undo
4702 4936
 					$updates
4703 4937
 				);
4704 4938
 			}
4939
+		} else {
4940
+					$is_done = true;
4705 4941
 		}
4706
-		else
4707
-			$is_done = true;
4708 4942
 
4709 4943
 		$_GET['a'] += $limit;
4710 4944
 		$step_progress['current'] = $_GET['a'];
@@ -4730,10 +4964,11 @@  discard block
 block discarded – undo
4730 4964
 
4731 4965
  	$columns = $smcFunc['db_list_columns']($targetTable, true);
4732 4966
 
4733
-	if (isset($columns[$column]))
4734
-		return $columns[$column];
4735
-	else
4736
-		return null;
4737
-}
4967
+	if (isset($columns[$column])) {
4968
+			return $columns[$column];
4969
+	} else {
4970
+			return null;
4971
+	}
4972
+	}
4738 4973
 
4739 4974
 ?>
4740 4975
\ No newline at end of file
Please login to merge, or discard this patch.