Passed
Pull Request — release-2.1 (#6068)
by Michael
04:06
created
Severity
1
<?php
2
3
/**
4
 * This is a slightly strange file. It is not designed to ever be run directly from within SMF's
5
 * conventional running, but called externally to facilitate background tasks. It can be called
6
 * either directly or via cron, and in either case will completely ignore anything supplied
7
 * via command line, or $_GET, $_POST, $_COOKIE etc. because those things should never affect the
8
 * running of this script.
9
 *
10
 * Because of the way this runs, etc. we do need some of SMF but not everything to try to keep this
11
 * running a little bit faster.
12
 *
13
 * Simple Machines Forum (SMF)
14
 *
15
 * @package SMF
16
 * @author Simple Machines https://www.simplemachines.org
17
 * @copyright 2020 Simple Machines and individual contributors
18
 * @license https://www.simplemachines.org/about/smf/license.php BSD
19
 *
20
 * @version 2.1 RC2
21
 */
22
23
define('SMF', 'BACKGROUND');
24
define('SMF_VERSION', '2.1 RC2');
25
define('SMF_FULL_VERSION', 'SMF ' . SMF_VERSION);
26
define('SMF_SOFTWARE_YEAR', '2020');
27
define('FROM_CLI', empty($_SERVER['REQUEST_METHOD']));
28
29
define('JQUERY_VERSION', '3.4.1');
30
define('POSTGRE_TITLE', 'PostgreSQL');
31
define('MYSQL_TITLE', 'MySQL');
32
define('SMF_USER_AGENT', 'Mozilla/5.0 (' . php_uname('s') . ' ' . php_uname('m') . ') AppleWebKit/605.1.15 (KHTML, like Gecko)  SMF/' . strtr(SMF_VERSION, ' ', '.'));
33
34
// This one setting is worth bearing in mind. If you are running this from proper cron, make sure you
35
// don't run this file any more frequently than indicated here. It might turn ugly if you do.
36
// But on proper cron you can always increase this value provided you don't go beyond max_limit.
37
define('MAX_CRON_TIME', 10);
38
// If a task fails for whatever reason it will still be marked as claimed. This is the threshold
39
// by which if a task has not completed in this time, the task should become available again.
40
define('MAX_CLAIM_THRESHOLD', 300);
41
42
// We're going to want a few globals... these are all set later.
43
global $maintenance, $msubject, $mmessage, $mbname, $language;
44
global $boardurl, $boarddir, $sourcedir, $webmaster_email;
45
global $db_server, $db_name, $db_user, $db_prefix, $db_persist, $db_error_send, $db_last_error;
46
global $db_connection, $modSettings, $context, $sc, $user_info, $txt;
47
global $smcFunc, $ssi_db_user, $scripturl, $db_passwd, $cachedir;
48
49
if (!defined('TIME_START'))
50
	define('TIME_START', microtime(true));
51
52
// Just being safe...
53
foreach (array('db_character_set', 'cachedir') as $variable)
54
	if (isset($GLOBALS[$variable]))
55
		unset($GLOBALS[$variable]);
56
57
// Get the forum's settings for database and file paths.
58
require_once(dirname(__FILE__) . '/Settings.php');
59
60
// Make absolutely sure the cache directory is defined and writable.
61
if (empty($cachedir) || !is_dir($cachedir) || !is_writable($cachedir))
62
{
63
	if (is_dir($boarddir . '/cache') && is_writable($boarddir . '/cache'))
64
		$cachedir = $boarddir . '/cache';
65
	else
66
	{
67
		$cachedir = sys_get_temp_dir() . '/smf_cache_' . md5($boarddir);
68
		@mkdir($cachedir, 0750);
69
	}
70
}
71
72
// Don't do john didley if the forum's been shut down completely.
73
if ($maintenance == 2)
74
	die($mmessage);
75
76
// Fix for using the current directory as a path.
77
if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.')
78
	$sourcedir = dirname(__FILE__) . substr($sourcedir, 1);
79
80
// Have we already turned this off? If so, exist gracefully.
81
if (file_exists($cachedir . '/cron.lock'))
82
	obExit_cron();
83
84
// Before we go any further, if this is not a CLI request, we need to do some checking.
85
if (!FROM_CLI)
86
{
87
	// When using sub-domains with SSI and ssi_themes set, browsers will receive a "Access-Control-Allow-Origin" error.
88
	// * is not ideal but the best method to preventing this from occurring.
89
	header('Access-Control-Allow-Origin: *');
90
91
	// We will clean up $_GET shortly. But we want to this ASAP.
92
	$ts = isset($_GET['ts']) ? (int) $_GET['ts'] : 0;
93
	if ($ts <= 0 || $ts % 15 != 0 || time() - $ts < 0 || time() - $ts > 20)
94
		obExit_cron();
95
}
96
97
// Load the most important includes. In general, a background should be loading its own dependencies.
98
require_once($sourcedir . '/Errors.php');
99
require_once($sourcedir . '/Load.php');
100
require_once($sourcedir . '/Security.php');
101
require_once($sourcedir . '/Subs.php');
102
103
// Create a variable to store some SMF specific functions in.
104
$smcFunc = array();
105
106
// This is our general bootstrap, a la SSI.php but with a few differences.
107
unset ($db_show_debug);
108
loadDatabase();
109
reloadSettings();
110
111
// Just in case there's a problem...
112
set_error_handler('smf_error_handler_cron');
113
$sc = '';
114
$_SERVER['QUERY_STRING'] = '';
115
$_SERVER['REQUEST_URL'] = FROM_CLI ? 'CLI cron.php' : $boardurl . '/cron.php';
116
117
// Now 'clean the request' (or more accurately, ignore everything we're not going to use)
118
cleanRequest_cron();
119
120
// At this point we could reseed the RNG but I don't think we need to risk it being seeded *even more*.
121
// Meanwhile, time we got on with the real business here.
122
while ($task_details = fetch_task())
123
{
124
	$result = perform_task($task_details);
125
	if ($result)
126
	{
127
		$smcFunc['db_query']('', '
128
			DELETE FROM {db_prefix}background_tasks
129
			WHERE id_task = {int:task}',
130
			array(
131
				'task' => $task_details['id_task'],
132
			)
133
		);
134
	}
135
}
136
obExit_cron();
137
exit;
138
139
/**
140
 * The heart of this cron handler...
141
 *
142
 * @return bool|array False if there's nothing to do or an array of info about the task
143
 */
144
function fetch_task()
145
{
146
	global $smcFunc;
147
148
	// Check we haven't run over our time limit.
149
	if (microtime(true) - TIME_START > MAX_CRON_TIME)
150
		return false;
151
152
	// Try to find a task. Specifically, try to find one that hasn't been claimed previously, or failing that,
153
	// a task that was claimed but failed for whatever reason and failed long enough ago. We should not care
154
	// what task it is, merely that it is one in the queue, the order is irrelevant.
155
	$request = $smcFunc['db_query']('', '
156
		SELECT id_task, task_file, task_class, task_data, claimed_time
157
		FROM {db_prefix}background_tasks
158
		WHERE claimed_time < {int:claim_limit}
159
		LIMIT 1',
160
		array(
161
			'claim_limit' => time() - MAX_CLAIM_THRESHOLD,
162
		)
163
	);
164
	if ($row = $smcFunc['db_fetch_assoc']($request))
165
	{
166
		// We found one. Let's try and claim it immediately.
167
		$smcFunc['db_free_result']($request);
168
		$smcFunc['db_query']('', '
169
			UPDATE {db_prefix}background_tasks
170
			SET claimed_time = {int:new_claimed}
171
			WHERE id_task = {int:task}
172
				AND claimed_time = {int:old_claimed}',
173
			array(
174
				'new_claimed' => time(),
175
				'task' => $row['id_task'],
176
				'old_claimed' => $row['claimed_time'],
177
			)
178
		);
179
		// Could we claim it? If so, return it back.
180
		if ($smcFunc['db_affected_rows']() != 0)
181
		{
182
			// Update the time and go back.
183
			$row['claimed_time'] = time();
184
			return $row;
185
		}
186
		else
187
		{
188
			// Uh oh, we just missed it. Try to claim another one, and let it fall through if there aren't any.
189
			return fetch_task();
190
		}
191
	}
192
	else
193
	{
194
		// No dice. Clean up and go home.
195
		$smcFunc['db_free_result']($request);
196
		return false;
197
	}
198
}
199
200
/**
201
 * This actually handles the task
202
 *
203
 * @param array $task_details An array of info about the task
204
 * @return bool|void True if the task is invalid; otherwise calls the function to execute the task
205
 */
206
function perform_task($task_details)
207
{
208
	global $smcFunc, $sourcedir, $boarddir;
209
210
	// This indicates the file to load.
211
	if (!empty($task_details['task_file']))
212
	{
213
		$include = strtr(trim($task_details['task_file']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
214
		if (file_exists($include))
215
			require_once($include);
216
	}
217
218
	if (empty($task_details['task_class']))
219
	{
220
		// This would be nice to translate but the language files aren't loaded for any specific language.
221
		log_error('Invalid background task specified (no class, ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
222
		return true; // So we clear it from the queue.
223
	}
224
225
	// All background tasks need to be classes.
226
	elseif (class_exists($task_details['task_class']) && is_subclass_of($task_details['task_class'], 'SMF_BackgroundTask'))
227
	{
228
		$details = empty($task_details['task_data']) ? array() : $smcFunc['json_decode']($task_details['task_data'], true);
229
		$bgtask = new $task_details['task_class']($details);
230
		return $bgtask->execute();
231
	}
232
	else
233
	{
234
		log_error('Invalid background task specified: (class: ' . $task_details['task_class'] . ', ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
235
		return true; // So we clear it from the queue.
236
	}
237
}
238
239
// These are all our helper functions that resemble their big brother counterparts. These are not so important.
240
/**
241
 * Cleans up the request variables
242
 *
243
 * @return void
244
 */
245
function cleanRequest_cron()
246
{
247
	global $scripturl, $boardurl;
248
249
	$scripturl = $boardurl . '/index.php';
250
251
	// These keys shouldn't be set...ever.
252
	if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS']))
253
		die('Invalid request variable.');
0 ignored issues
show
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
254
255
	// Save some memory.. (since we don't use these anyway.)
256
	unset($GLOBALS['HTTP_POST_VARS'], $GLOBALS['HTTP_POST_VARS']);
257
	unset($GLOBALS['HTTP_POST_FILES'], $GLOBALS['HTTP_POST_FILES']);
258
	unset($GLOBALS['_GET'], $GLOBALS['_POST'], $GLOBALS['_REQUEST'], $GLOBALS['_COOKIE'], $GLOBALS['_FILES']);
259
}
260
261
/**
262
 * The error handling function
263
 *
264
 * @param int $error_level One of the PHP error level constants (see )
265
 * @param string $error_string The error message
266
 * @param string $file The file where the error occurred
267
 * @param int $line What line of the specified file the error occurred on
268
 * @return void
269
 */
270
function smf_error_handler_cron($error_level, $error_string, $file, $line)
271
{
272
	global $modSettings;
273
274
	// Ignore errors that should not be logged.
275
	if (error_reporting() == 0)
276
		return;
277
278
	$error_type = 'cron';
279
280
	log_error($error_level . ': ' . $error_string, $error_type, $file, $line);
281
282
	// If this is an E_ERROR or E_USER_ERROR.... die.  Violently so.
283
	if ($error_level % 255 == E_ERROR)
284
		die('No direct access...');
0 ignored issues
show
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
285
}
286
287
/**
288
 * The exit function
289
 */
290
function obExit_cron()
291
{
292
	if (FROM_CLI)
293
		die(0);
0 ignored issues
show
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
294
	else
295
	{
296
		header('content-type: image/gif');
297
		die("\x47\x49\x46\x38\x39\x61\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\x00\x00\x00\x21\xF9\x04\x01\x00\x00\x00\x00\x2C\x00\x00\x00\x00\x01\x00\x01\x00\x00\x02\x02\x44\x01\x00\x3B");
298
	}
299
}
300
301
// We would like this to be defined, but we don't want to have to load more stuff than necessary.
302
// Thus we declare it here, and any legitimate background task must implement this.
303
/**
304
 * Class SMF_BackgroundTask
305
 */
306
abstract class SMF_BackgroundTask
307
{
308
	/**
309
	 * Constants for notfication types.
310
	*/
311
	const RECEIVE_NOTIFY_EMAIL = 0x02;
312
	const RECEIVE_NOTIFY_ALERT = 0x01;
313
314
	/**
315
	 * @var array Holds the details for the task
316
	 */
317
	protected $_details;
318
319
	/**
320
	 * The constructor.
321
	 *
322
	 * @param array $details The details for the task
323
	 */
324
	public function __construct($details)
325
	{
326
		$this->_details = $details;
327
	}
328
329
	/**
330
	 * The function to actually execute a task
331
	 *
332
	 * @return mixed
333
	 */
334
	abstract public function execute();
335
}
336
337
?>