Completed
Pull Request — release-2.1 (#4985)
by Fran
06:10
created
Themes/default/Likes.template.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
 		<div class="windowbg">
32 32
 			<ul id="likes">';
33 33
 
34
-	foreach ($context['likers'] as $liker => $like_details)
35
-		echo '
34
+	foreach ($context['likers'] as $liker => $like_details) {
35
+			echo '
36 36
 				<li>
37 37
 					', $like_details['profile']['avatar']['image'], '
38 38
 					<span>
@@ -41,6 +41,7 @@  discard block
 block discarded – undo
41 41
 					</span>
42 42
 					<span class="floatright">', $like_details['time'], '</span>
43 43
 				</li>';
44
+	}
44 45
 
45 46
 	echo '
46 47
 			</ul>
@@ -61,11 +62,12 @@  discard block
 block discarded – undo
61 62
 	echo '
62 63
 	<ul class="floatleft">';
63 64
 
64
-	if (!empty($context['data']['can_like']))
65
-		echo '
65
+	if (!empty($context['data']['can_like'])) {
66
+			echo '
66 67
 		<li class="like_button" id="', $context['data']['type'], '_', $context['data']['id_content'], '_likes"', '>
67 68
 			<a href="', $scripturl, '?action=likes;ltype=', $context['data']['type'], ';sa=like;like=', $context['data']['id_content'], ';', $context['session_var'], '=', $context['session_id'], '" class="', $context['data']['type'], '_like"><span class="generic_icons ', $context['data']['already_liked'] ? 'unlike' : 'like', '"></span> ', $context['data']['already_liked'] ? $txt['unlike'] : $txt['like'], '</a>
68 69
 		</li>';
70
+	}
69 71
 
70 72
 	if (!empty($context['data']['count']))
71 73
 	{
Please login to merge, or discard this patch.
Themes/default/ManageScheduledTasks.template.php 1 patch
Braces   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,13 +20,12 @@  discard block
 block discarded – undo
20 20
 	// We completed some tasks?
21 21
 	if (!empty($context['tasks_were_run']))
22 22
 	{
23
-		if (empty($context['scheduled_errors']))
24
-			echo '
23
+		if (empty($context['scheduled_errors'])) {
24
+					echo '
25 25
 	<div class="infobox">
26 26
 		', $txt['scheduled_tasks_were_run'], '
27 27
 	</div>';
28
-
29
-		else
28
+		} else
30 29
 		{
31 30
 			echo '
32 31
 	<div class="errorbox" id="errors">
@@ -35,14 +34,15 @@  discard block
 block discarded – undo
35 34
 				<strong id="error_serious">', $txt['scheduled_tasks_were_run_errors'], '</strong>
36 35
 			</dt>';
37 36
 
38
-			foreach ($context['scheduled_errors'] as $task => $errors)
39
-				echo '
37
+			foreach ($context['scheduled_errors'] as $task => $errors) {
38
+							echo '
40 39
 			<dd class="error">
41 40
 				<strong>', isset($txt['scheduled_task_' . $task]) ? $txt['scheduled_task_' . $task] : $task, '</strong>
42 41
 				<ul>
43 42
 					<li>', implode('</li><li>', $errors), '</li>
44 43
 				</ul>
45 44
 			</dd>';
45
+			}
46 46
 
47 47
 			echo '
48 48
 		</dl>
Please login to merge, or discard this patch.
Themes/default/ReportToMod.template.php 1 patch
Braces   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,16 +62,17 @@
 block discarded – undo
62 62
 				<div id="error_box" class="errorbox">
63 63
 					<ul id="error_list">';
64 64
 
65
-		foreach ($context['post_errors'] as $key => $error)
66
-			echo '
65
+		foreach ($context['post_errors'] as $key => $error) {
66
+					echo '
67 67
 						<li id="error_', $key, '" class="error">', $error, '</li>';
68
+		}
68 69
 
69 70
 		echo '
70 71
 					</ul>';
71
-	}
72
-	else
73
-		echo '
72
+	} else {
73
+			echo '
74 74
 				<div style="display:none" id="error_box" class="errorbox">';
75
+	}
75 76
 
76 77
 	echo '
77 78
 				</div>';
Please login to merge, or discard this patch.
Themes/default/GenericMenu.template.php 1 patch
Braces   +54 added lines, -39 removed lines patch added patch discarded remove patch
@@ -89,16 +89,18 @@  discard block
 block discarded – undo
89 89
 		foreach ($section['areas'] as $i => $area)
90 90
 		{
91 91
 			// Not supposed to be printed?
92
-			if (empty($area['label']))
93
-				continue;
92
+			if (empty($area['label'])) {
93
+							continue;
94
+			}
94 95
 
95 96
 			echo '
96 97
 								<li', !empty($area['subsections']) ? ' class="subsections"' : '', '>
97 98
 									<a class="', $area['icon_class'], !empty($area['selected']) ? ' chosen ' : '', '" href="', (isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $i), $menu_context['extra_parameters'], '">', $area['icon'], $area['label'], '</a>';
98 99
 
99 100
 			// Is this the current area, or just some area?
100
-			if (!empty($area['selected']) && empty($context['tabs']))
101
-					$context['tabs'] = isset($area['subsections']) ? $area['subsections'] : array();
101
+			if (!empty($area['selected']) && empty($context['tabs'])) {
102
+								$context['tabs'] = isset($area['subsections']) ? $area['subsections'] : array();
103
+			}
102 104
 
103 105
 			// Are there any subsections?
104 106
 			if (!empty($area['subsections']))
@@ -108,8 +110,9 @@  discard block
 block discarded – undo
108 110
 
109 111
 				foreach ($area['subsections'] as $sa => $sub)
110 112
 				{
111
-					if (!empty($sub['disabled']))
112
-						continue;
113
+					if (!empty($sub['disabled'])) {
114
+											continue;
115
+					}
113 116
 
114 117
 					$url = isset($sub['url']) ? $sub['url'] : (isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $i) . ';sa=' . $sa;
115 118
 
@@ -156,8 +159,9 @@  discard block
 block discarded – undo
156 159
 							<h3 class="catbg">';
157 160
 
158 161
 		// The function is in Admin.template.php, but since this template is used elsewhere too better check if the function is available
159
-		if (function_exists('template_admin_quick_search'))
160
-			template_admin_quick_search();
162
+		if (function_exists('template_admin_quick_search')) {
163
+					template_admin_quick_search();
164
+		}
161 165
 
162 166
 		// Exactly how many tabs do we have?
163 167
 		if (!empty($context['tabs']))
@@ -172,30 +176,36 @@  discard block
 block discarded – undo
172 176
 				}
173 177
 
174 178
 				// Did this not even exist - or do we not have a label?
175
-				if (!isset($tab_context['tabs'][$id]))
176
-					$tab_context['tabs'][$id] = array('label' => $tab['label']);
177
-				elseif (!isset($tab_context['tabs'][$id]['label']))
178
-					$tab_context['tabs'][$id]['label'] = $tab['label'];
179
+				if (!isset($tab_context['tabs'][$id])) {
180
+									$tab_context['tabs'][$id] = array('label' => $tab['label']);
181
+				} elseif (!isset($tab_context['tabs'][$id]['label'])) {
182
+									$tab_context['tabs'][$id]['label'] = $tab['label'];
183
+				}
179 184
 
180 185
 				// Has a custom URL defined in the main admin structure?
181
-				if (isset($tab['url']) && !isset($tab_context['tabs'][$id]['url']))
182
-					$tab_context['tabs'][$id]['url'] = $tab['url'];
186
+				if (isset($tab['url']) && !isset($tab_context['tabs'][$id]['url'])) {
187
+									$tab_context['tabs'][$id]['url'] = $tab['url'];
188
+				}
183 189
 
184 190
 				// Any additional paramaters for the url?
185
-				if (isset($tab['add_params']) && !isset($tab_context['tabs'][$id]['add_params']))
186
-					$tab_context['tabs'][$id]['add_params'] = $tab['add_params'];
191
+				if (isset($tab['add_params']) && !isset($tab_context['tabs'][$id]['add_params'])) {
192
+									$tab_context['tabs'][$id]['add_params'] = $tab['add_params'];
193
+				}
187 194
 
188 195
 				// Has it been deemed selected?
189
-				if (!empty($tab['is_selected']))
190
-					$tab_context['tabs'][$id]['is_selected'] = true;
196
+				if (!empty($tab['is_selected'])) {
197
+									$tab_context['tabs'][$id]['is_selected'] = true;
198
+				}
191 199
 
192 200
 				// Does it have its own help?
193
-				if (!empty($tab['help']))
194
-					$tab_context['tabs'][$id]['help'] = $tab['help'];
201
+				if (!empty($tab['help'])) {
202
+									$tab_context['tabs'][$id]['help'] = $tab['help'];
203
+				}
195 204
 
196 205
 				// Is this the last one?
197
-				if (!empty($tab['is_last']) && !isset($tab_context['override_last']))
198
-					$tab_context['tabs'][$id]['is_last'] = true;
206
+				if (!empty($tab['is_last']) && !isset($tab_context['override_last'])) {
207
+									$tab_context['tabs'][$id]['is_last'] = true;
208
+				}
199 209
 			}
200 210
 
201 211
 			// Find the selected tab
@@ -212,22 +222,24 @@  discard block
 block discarded – undo
212 222
 		// Show an icon and/or a help item?
213 223
 		if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class']) || !empty($selected_tab['icon']) || !empty($tab_context['icon']) || !empty($selected_tab['help']) || !empty($tab_context['help']))
214 224
 		{
215
-			if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class']))
216
-				echo '
225
+			if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class'])) {
226
+							echo '
217 227
 								<span class="', !empty($selected_tab['icon_class']) ? $selected_tab['icon_class'] : $tab_context['icon_class'], ' icon"></span>';
218
-			elseif (!empty($selected_tab['icon']) || !empty($tab_context['icon']))
219
-				echo '
228
+			} elseif (!empty($selected_tab['icon']) || !empty($tab_context['icon'])) {
229
+							echo '
220 230
 								<img src="', $settings['images_url'], '/icons/', !empty($selected_tab['icon']) ? $selected_tab['icon'] : $tab_context['icon'], '" alt="" class="icon">';
231
+			}
221 232
 
222
-			if (!empty($selected_tab['help']) || !empty($tab_context['help']))
223
-				echo '
233
+			if (!empty($selected_tab['help']) || !empty($tab_context['help'])) {
234
+							echo '
224 235
 								<a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><span class="generic_icons help" title="', $txt['help'], '"></span></a>';
236
+			}
225 237
 
226 238
 			echo $tab_context['title'];
227
-		}
228
-		else
229
-			echo '
239
+		} else {
240
+					echo '
230 241
 								', $tab_context['title'];
242
+		}
231 243
 
232 244
 		echo '
233 245
 							</h3>', (function_exists('template_admin_quick_search') ? '
@@ -236,11 +248,12 @@  discard block
 block discarded – undo
236 248
 	}
237 249
 
238 250
 	// Shall we use the tabs? Yes, it's the only known way!
239
-	if (!empty($selected_tab['description']) || !empty($tab_context['description']))
240
-		echo '
251
+	if (!empty($selected_tab['description']) || !empty($tab_context['description'])) {
252
+			echo '
241 253
 					<p class="information">
242 254
 						', !empty($selected_tab['description']) ? $selected_tab['description'] : $tab_context['description'], '
243 255
 					</p>';
256
+	}
244 257
 
245 258
 	// Print out all the items in this tab (if any).
246 259
 	if (!empty($context['tabs']))
@@ -252,19 +265,21 @@  discard block
 block discarded – undo
252 265
 
253 266
 		foreach ($tab_context['tabs'] as $sa => $tab)
254 267
 		{
255
-			if (!empty($tab['disabled']))
256
-				continue;
268
+			if (!empty($tab['disabled'])) {
269
+							continue;
270
+			}
257 271
 
258
-			if (!empty($tab['is_selected']))
259
-				echo '
272
+			if (!empty($tab['is_selected'])) {
273
+							echo '
260 274
 							<li>
261 275
 								<a class="active" href="', isset($tab['url']) ? $tab['url'] : $menu_context['base_url'] . ';area=' . $menu_context['current_area'] . ';sa=' . $sa, $menu_context['extra_parameters'], isset($tab['add_params']) ? $tab['add_params'] : '', '">', $tab['label'], '</a>
262 276
 							</li>';
263
-			else
264
-				echo '
277
+			} else {
278
+							echo '
265 279
 							<li>
266 280
 								<a href="', isset($tab['url']) ? $tab['url'] : $menu_context['base_url'] . ';area=' . $menu_context['current_area'] . ';sa=' . $sa, $menu_context['extra_parameters'], isset($tab['add_params']) ? $tab['add_params'] : '', '">', $tab['label'], '</a>
267 281
 							</li>';
282
+			}
268 283
 		}
269 284
 
270 285
 		// The end of tabs
Please login to merge, or discard this patch.
Themes/default/Reports.template.php 1 patch
Braces   +32 added lines, -24 removed lines patch added patch discarded remove patch
@@ -29,9 +29,10 @@  discard block
 block discarded – undo
29 29
 	// Go through each type of report they can run.
30 30
 	foreach ($context['report_types'] as $type)
31 31
 	{
32
-		if (isset($type['description']))
33
-			echo '
32
+		if (isset($type['description'])) {
33
+					echo '
34 34
 					<dt>', $type['description'], '</dt>';
35
+		}
35 36
 
36 37
 		echo '
37 38
 					<dd>
@@ -62,8 +63,9 @@  discard block
 block discarded – undo
62 63
 		</div>
63 64
 		<div id="report_buttons">';
64 65
 
65
-	if (!empty($context['report_buttons']))
66
-		template_button_strip($context['report_buttons'], 'right');
66
+	if (!empty($context['report_buttons'])) {
67
+			template_button_strip($context['report_buttons'], 'right');
68
+	}
67 69
 
68 70
 	echo '
69 71
 		</div>';
@@ -74,25 +76,27 @@  discard block
 block discarded – undo
74 76
 		echo '
75 77
 		<table class="table_grid report_results">';
76 78
 
77
-		if (!empty($table['title']))
78
-			echo '
79
+		if (!empty($table['title'])) {
80
+					echo '
79 81
 			<thead>
80 82
 				<tr class="title_bar">
81 83
 					<th scope="col" colspan="', $table['column_count'], '">', $table['title'], '</th>
82 84
 				</tr>
83 85
 			</thead>
84 86
 			<tbody>';
87
+		}
85 88
 
86 89
 		// Now do each row!
87 90
 		$row_number = 0;
88 91
 		foreach ($table['data'] as $row)
89 92
 		{
90
-			if ($row_number == 0 && !empty($table['shading']['top']))
91
-				echo '
93
+			if ($row_number == 0 && !empty($table['shading']['top'])) {
94
+							echo '
92 95
 				<tr class="windowbg table_caption">';
93
-			else
94
-				echo '
96
+			} else {
97
+							echo '
95 98
 				<tr class="', !empty($row[0]['separator']) ? 'title_bar' : 'windowbg', '">';
99
+			}
96 100
 
97 101
 			// Now do each column.
98 102
 			$column_number = 0;
@@ -110,16 +114,17 @@  discard block
 block discarded – undo
110 114
 				}
111 115
 
112 116
 				// Shaded?
113
-				if ($column_number == 0 && !empty($table['shading']['left']))
114
-					echo '
117
+				if ($column_number == 0 && !empty($table['shading']['left'])) {
118
+									echo '
115 119
 					<td class="table_caption ', $table['align']['shaded'], 'text"', $table['width']['shaded'] != 'auto' ? ' width="' . $table['width']['shaded'] . '"' : '', '>
116 120
 						', $data['v'] == $table['default_value'] ? '' : ($data['v'] . (empty($data['v']) ? '' : ':')), '
117 121
 					</td>';
118
-				else
119
-					echo '
122
+				} else {
123
+									echo '
120 124
 					<td class="smalltext centertext" ', $table['width']['normal'] != 'auto' ? ' width="' . $table['width']['normal'] . '"' : '', !empty($data['style']) ? ' style="' . $data['style'] . '"' : '', '>
121 125
 						', $data['v'], '
122 126
 					</td>';
127
+				}
123 128
 
124 129
 				$column_number++;
125 130
 			}
@@ -168,24 +173,26 @@  discard block
 block discarded – undo
168 173
 		<div style="overflow: visible;', $table['max_width'] != 'auto' ? ' width: ' . $table['max_width'] . 'px;' : '', '">
169 174
 			<table class="bordercolor">';
170 175
 
171
-		if (!empty($table['title']))
172
-			echo '
176
+		if (!empty($table['title'])) {
177
+					echo '
173 178
 				<tr class="title_bar">
174 179
 					<td colspan="', $table['column_count'], '">
175 180
 						', $table['title'], '
176 181
 					</td>
177 182
 				</tr>';
183
+		}
178 184
 
179 185
 		// Now do each row!
180 186
 		$row_number = 0;
181 187
 		foreach ($table['data'] as $row)
182 188
 		{
183
-			if ($row_number == 0 && !empty($table['shading']['top']))
184
-				echo '
189
+			if ($row_number == 0 && !empty($table['shading']['top'])) {
190
+							echo '
185 191
 				<tr class="titlebg">';
186
-			else
187
-				echo '
192
+			} else {
193
+							echo '
188 194
 				<tr class="windowbg">';
195
+			}
189 196
 
190 197
 			// Now do each column!!
191 198
 			$column_number = 0;
@@ -202,16 +209,17 @@  discard block
 block discarded – undo
202 209
 				}
203 210
 
204 211
 				// Shaded?
205
-				if ($column_number == 0 && !empty($table['shading']['left']))
206
-					echo '
212
+				if ($column_number == 0 && !empty($table['shading']['left'])) {
213
+									echo '
207 214
 					<td class="titlebg ', $table['align']['shaded'], 'text"', $table['width']['shaded'] != 'auto' ? ' width="' . $table['width']['shaded'] . '"' : '', '>
208 215
 						', $data['v'] == $table['default_value'] ? '' : ($data['v'] . (empty($data['v']) ? '' : ':')), '
209 216
 					</td>';
210
-				else
211
-					echo '
217
+				} else {
218
+									echo '
212 219
 					<td class="centertext" ', $table['width']['normal'] != 'auto' ? ' width="' . $table['width']['normal'] . '"' : '', !empty($data['style']) ? ' style="' . $data['style'] . '"' : '', '>
213 220
 						', $data['v'], '
214 221
 					</td>';
222
+				}
215 223
 
216 224
 				$column_number++;
217 225
 			}
Please login to merge, or discard this patch.
Sources/ManageSearch.php 1 patch
Braces   +109 added lines, -90 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Main entry point for the admin search settings screen.
@@ -107,11 +108,13 @@  discard block
 block discarded – undo
107 108
 	// Perhaps the search method wants to add some settings?
108 109
 	require_once($sourcedir . '/Search.php');
109 110
 	$searchAPI = findSearchAPI();
110
-	if (is_callable(array($searchAPI, 'searchSettings')))
111
-		call_user_func_array(array($searchAPI, 'searchSettings'), array(&$config_vars));
111
+	if (is_callable(array($searchAPI, 'searchSettings'))) {
112
+			call_user_func_array(array($searchAPI, 'searchSettings'), array(&$config_vars));
113
+	}
112 114
 
113
-	if ($return_config)
114
-		return $config_vars;
115
+	if ($return_config) {
116
+			return $config_vars;
117
+	}
115 118
 
116 119
 	$context['page_title'] = $txt['search_settings_title'];
117 120
 	$context['sub_template'] = 'show_settings';
@@ -126,8 +129,9 @@  discard block
 block discarded – undo
126 129
 
127 130
 		call_integration_hook('integrate_save_search_settings');
128 131
 
129
-		if (empty($_POST['search_results_per_page']))
130
-			$_POST['search_results_per_page'] = !empty($modSettings['search_results_per_page']) ? $modSettings['search_results_per_page'] : $modSettings['defaultMaxMessages'];
132
+		if (empty($_POST['search_results_per_page'])) {
133
+					$_POST['search_results_per_page'] = !empty($modSettings['search_results_per_page']) ? $modSettings['search_results_per_page'] : $modSettings['defaultMaxMessages'];
134
+		}
131 135
 		saveDBSettings($config_vars);
132 136
 		$_SESSION['adm-save'] = true;
133 137
 		redirectexit('action=admin;area=managesearch;sa=settings;' . $context['session_var'] . '=' . $context['session_id']);
@@ -177,17 +181,20 @@  discard block
 block discarded – undo
177 181
 		call_integration_hook('integrate_save_search_weights');
178 182
 
179 183
 		$changes = array();
180
-		foreach ($factors as $factor)
181
-			$changes[$factor] = (int) $_POST[$factor];
184
+		foreach ($factors as $factor) {
185
+					$changes[$factor] = (int) $_POST[$factor];
186
+		}
182 187
 		updateSettings($changes);
183 188
 	}
184 189
 
185 190
 	$context['relative_weights'] = array('total' => 0);
186
-	foreach ($factors as $factor)
187
-		$context['relative_weights']['total'] += isset($modSettings[$factor]) ? $modSettings[$factor] : 0;
191
+	foreach ($factors as $factor) {
192
+			$context['relative_weights']['total'] += isset($modSettings[$factor]) ? $modSettings[$factor] : 0;
193
+	}
188 194
 
189
-	foreach ($factors as $factor)
190
-		$context['relative_weights'][$factor] = round(100 * (isset($modSettings[$factor]) ? $modSettings[$factor] : 0) / $context['relative_weights']['total'], 1);
195
+	foreach ($factors as $factor) {
196
+			$context['relative_weights'][$factor] = round(100 * (isset($modSettings[$factor]) ? $modSettings[$factor] : 0) / $context['relative_weights']['total'], 1);
197
+	}
191 198
 
192 199
 	createToken('admin-msw');
193 200
 }
@@ -215,8 +222,9 @@  discard block
 block discarded – undo
215 222
 	$context['search_apis'] = loadSearchAPIs();
216 223
 
217 224
 	// Detect whether a fulltext index is set.
218
-	if ($context['supports_fulltext'])
219
-		detectFulltextIndex();
225
+	if ($context['supports_fulltext']) {
226
+			detectFulltextIndex();
227
+	}
220 228
 
221 229
 	if (!empty($_REQUEST['sa']) && $_REQUEST['sa'] == 'createfulltext')
222 230
 	{
@@ -240,8 +248,7 @@  discard block
 block discarded – undo
240 248
 					'language' => $language_ftx
241 249
 				)
242 250
 			);
243
-		}
244
-		else
251
+		} else
245 252
 		{
246 253
 			// Make sure it's gone before creating it.
247 254
 			$smcFunc['db_query']('', '
@@ -259,8 +266,7 @@  discard block
 block discarded – undo
259 266
 				)
260 267
 			);
261 268
 		}
262
-	}
263
-	elseif (!empty($_REQUEST['sa']) && $_REQUEST['sa'] == 'removefulltext' && !empty($context['fulltext_index']))
269
+	} elseif (!empty($_REQUEST['sa']) && $_REQUEST['sa'] == 'removefulltext' && !empty($context['fulltext_index']))
264 270
 	{
265 271
 		checkSession('get');
266 272
 		validateToken('admin-msm', 'get');
@@ -277,12 +283,12 @@  discard block
 block discarded – undo
277 283
 		$context['fulltext_index'] = array();
278 284
 
279 285
 		// Go back to the default search method.
280
-		if (!empty($modSettings['search_index']) && $modSettings['search_index'] == 'fulltext')
281
-			updateSettings(array(
286
+		if (!empty($modSettings['search_index']) && $modSettings['search_index'] == 'fulltext') {
287
+					updateSettings(array(
282 288
 				'search_index' => '',
283 289
 			));
284
-	}
285
-	elseif (!empty($_REQUEST['sa']) && $_REQUEST['sa'] == 'removecustom')
290
+		}
291
+	} elseif (!empty($_REQUEST['sa']) && $_REQUEST['sa'] == 'removecustom')
286 292
 	{
287 293
 		checkSession('get');
288 294
 		validateToken('admin-msm', 'get');
@@ -304,12 +310,12 @@  discard block
 block discarded – undo
304 310
 		));
305 311
 
306 312
 		// Go back to the default search method.
307
-		if (!empty($modSettings['search_index']) && $modSettings['search_index'] == 'custom')
308
-			updateSettings(array(
313
+		if (!empty($modSettings['search_index']) && $modSettings['search_index'] == 'custom') {
314
+					updateSettings(array(
309 315
 				'search_index' => '',
310 316
 			));
311
-	}
312
-	elseif (isset($_POST['save']))
317
+		}
318
+	} elseif (isset($_POST['save']))
313 319
 	{
314 320
 		checkSession();
315 321
 		validateToken('admin-msmpost');
@@ -331,8 +337,8 @@  discard block
 block discarded – undo
331 337
 	// Get some info about the messages table, to show its size and index size.
332 338
 	if ($db_type == 'mysql')
333 339
 	{
334
-		if (preg_match('~^`(.+?)`\.(.+?)$~', $db_prefix, $match) !== 0)
335
-			$request = $smcFunc['db_query']('', '
340
+		if (preg_match('~^`(.+?)`\.(.+?)$~', $db_prefix, $match) !== 0) {
341
+					$request = $smcFunc['db_query']('', '
336 342
 				SHOW TABLE STATUS
337 343
 				FROM {string:database_name}
338 344
 				LIKE {string:table_name}',
@@ -341,14 +347,15 @@  discard block
 block discarded – undo
341 347
 					'table_name' => str_replace('_', '\_', $match[2]) . 'messages',
342 348
 				)
343 349
 			);
344
-		else
345
-			$request = $smcFunc['db_query']('', '
350
+		} else {
351
+					$request = $smcFunc['db_query']('', '
346 352
 				SHOW TABLE STATUS
347 353
 				LIKE {string:table_name}',
348 354
 				array(
349 355
 					'table_name' => str_replace('_', '\_', $db_prefix) . 'messages',
350 356
 				)
351 357
 			);
358
+		}
352 359
 		if ($request !== false && $smcFunc['db_num_rows']($request) == 1)
353 360
 		{
354 361
 			// Only do this if the user has permission to execute this query.
@@ -360,8 +367,8 @@  discard block
 block discarded – undo
360 367
 		}
361 368
 
362 369
 		// Now check the custom index table, if it exists at all.
363
-		if (preg_match('~^`(.+?)`\.(.+?)$~', $db_prefix, $match) !== 0)
364
-			$request = $smcFunc['db_query']('', '
370
+		if (preg_match('~^`(.+?)`\.(.+?)$~', $db_prefix, $match) !== 0) {
371
+					$request = $smcFunc['db_query']('', '
365 372
 				SHOW TABLE STATUS
366 373
 				FROM {string:database_name}
367 374
 				LIKE {string:table_name}',
@@ -370,14 +377,15 @@  discard block
 block discarded – undo
370 377
 					'table_name' => str_replace('_', '\_', $match[2]) . 'log_search_words',
371 378
 				)
372 379
 			);
373
-		else
374
-			$request = $smcFunc['db_query']('', '
380
+		} else {
381
+					$request = $smcFunc['db_query']('', '
375 382
 				SHOW TABLE STATUS
376 383
 				LIKE {string:table_name}',
377 384
 				array(
378 385
 					'table_name' => str_replace('_', '\_', $db_prefix) . 'log_search_words',
379 386
 				)
380 387
 			);
388
+		}
381 389
 		if ($request !== false && $smcFunc['db_num_rows']($request) == 1)
382 390
 		{
383 391
 			// Only do this if the user has permission to execute this query.
@@ -386,8 +394,7 @@  discard block
 block discarded – undo
386 394
 			$context['table_info']['custom_index_length'] = $row['Data_length'] + $row['Index_length'];
387 395
 			$smcFunc['db_free_result']($request);
388 396
 		}
389
-	}
390
-	elseif ($db_type == 'postgresql')
397
+	} elseif ($db_type == 'postgresql')
391 398
 	{
392 399
 		// In order to report the sizes correctly we need to perform vacuum (optimize) on the tables we will be using.
393 400
 		//db_extend();
@@ -429,38 +436,38 @@  discard block
 block discarded – undo
429 436
 					$context['table_info']['data_length'] = (int) $row['table_size'];
430 437
 					$context['table_info']['index_length'] = (int) $row['index_size'];
431 438
 					$context['table_info']['fulltext_length'] = (int) $row['index_size'];
432
-				}
433
-				elseif ($row['indexname'] == $db_prefix . 'log_search_words')
439
+				} elseif ($row['indexname'] == $db_prefix . 'log_search_words')
434 440
 				{
435 441
 					$context['table_info']['index_length'] = (int) $row['index_size'];
436 442
 					$context['table_info']['custom_index_length'] = (int) $row['index_size'];
437 443
 				}
438 444
 			}
439 445
 			$smcFunc['db_free_result']($request);
440
-		}
441
-		else
442
-			// Didn't work for some reason...
446
+		} else {
447
+					// Didn't work for some reason...
443 448
 			$context['table_info'] = array(
444 449
 				'data_length' => $txt['not_applicable'],
445 450
 				'index_length' => $txt['not_applicable'],
446 451
 				'fulltext_length' => $txt['not_applicable'],
447 452
 				'custom_index_length' => $txt['not_applicable'],
448 453
 			);
449
-	}
450
-	else
451
-		$context['table_info'] = array(
454
+		}
455
+	} else {
456
+			$context['table_info'] = array(
452 457
 			'data_length' => $txt['not_applicable'],
453 458
 			'index_length' => $txt['not_applicable'],
454 459
 			'fulltext_length' => $txt['not_applicable'],
455 460
 			'custom_index_length' => $txt['not_applicable'],
456 461
 		);
462
+	}
457 463
 
458 464
 	// Format the data and index length in kilobytes.
459 465
 	foreach ($context['table_info'] as $type => $size)
460 466
 	{
461 467
 		// If it's not numeric then just break.  This database engine doesn't support size.
462
-		if (!is_numeric($size))
463
-			break;
468
+		if (!is_numeric($size)) {
469
+					break;
470
+		}
464 471
 
465 472
 		$context['table_info'][$type] = comma_format($context['table_info'][$type] / 1024) . ' ' . $txt['search_method_kilobytes'];
466 473
 	}
@@ -489,8 +496,9 @@  discard block
 block discarded – undo
489 496
 
490 497
 	// Scotty, we need more time...
491 498
 	@set_time_limit(600);
492
-	if (function_exists('apache_reset_timeout'))
493
-		@apache_reset_timeout();
499
+	if (function_exists('apache_reset_timeout')) {
500
+			@apache_reset_timeout();
501
+	}
494 502
 
495 503
 	$context[$context['admin_menu_name']]['current_subsection'] = 'method';
496 504
 	$context['page_title'] = $txt['search_index_custom'];
@@ -520,8 +528,7 @@  discard block
 block discarded – undo
520 528
 		$context['start'] = (int) $context['index_settings']['resume_at'];
521 529
 		unset($context['index_settings']['resume_at']);
522 530
 		$context['step'] = 1;
523
-	}
524
-	else
531
+	} else
525 532
 	{
526 533
 		$context['index_settings'] = array(
527 534
 			'bytes_per_word' => isset($_REQUEST['bytes_per_word']) && isset($index_properties[$_REQUEST['bytes_per_word']]) ? (int) $_REQUEST['bytes_per_word'] : 2,
@@ -530,12 +537,14 @@  discard block
 block discarded – undo
530 537
 		$context['step'] = isset($_REQUEST['step']) ? (int) $_REQUEST['step'] : 0;
531 538
 
532 539
 		// admin timeouts are painful when building these long indexes - but only if we actually have such things enabled
533
-		if (empty($modSettings['securityDisable']) && $_SESSION['admin_time'] + 3300 < time() && $context['step'] >= 1)
534
-			$_SESSION['admin_time'] = time();
540
+		if (empty($modSettings['securityDisable']) && $_SESSION['admin_time'] + 3300 < time() && $context['step'] >= 1) {
541
+					$_SESSION['admin_time'] = time();
542
+		}
535 543
 	}
536 544
 
537
-	if ($context['step'] !== 0)
538
-		checkSession('request');
545
+	if ($context['step'] !== 0) {
546
+			checkSession('request');
547
+	}
539 548
 
540 549
 	// Step 0: let the user determine how they like their index.
541 550
 	if ($context['step'] === 0)
@@ -564,12 +573,14 @@  discard block
 block discarded – undo
564 573
 			$smcFunc['db_create_word_search']($index_properties[$context['index_settings']['bytes_per_word']]['column_definition']);
565 574
 
566 575
 			// Temporarily switch back to not using a search index.
567
-			if (!empty($modSettings['search_index']) && $modSettings['search_index'] == 'custom')
568
-				updateSettings(array('search_index' => ''));
576
+			if (!empty($modSettings['search_index']) && $modSettings['search_index'] == 'custom') {
577
+							updateSettings(array('search_index' => ''));
578
+			}
569 579
 
570 580
 			// Don't let simultanious processes be updating the search index.
571
-			if (!empty($modSettings['search_custom_index_config']))
572
-				updateSettings(array('search_custom_index_config' => ''));
581
+			if (!empty($modSettings['search_custom_index_config'])) {
582
+							updateSettings(array('search_custom_index_config' => ''));
583
+			}
573 584
 		}
574 585
 
575 586
 		$num_messages = array(
@@ -585,16 +596,16 @@  discard block
 block discarded – undo
585 596
 				'starting_id' => $context['start'],
586 597
 			)
587 598
 		);
588
-		while ($row = $smcFunc['db_fetch_assoc']($request))
589
-			$num_messages[empty($row['todo']) ? 'done' : 'todo'] = $row['num_messages'];
599
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
600
+					$num_messages[empty($row['todo']) ? 'done' : 'todo'] = $row['num_messages'];
601
+		}
590 602
 
591 603
 		if (empty($num_messages['todo']))
592 604
 		{
593 605
 			$context['step'] = 2;
594 606
 			$context['percentage'] = 80;
595 607
 			$context['start'] = 0;
596
-		}
597
-		else
608
+		} else
598 609
 		{
599 610
 			// Number of seconds before the next step.
600 611
 			$stop = time() + 3;
@@ -635,21 +646,22 @@  discard block
 block discarded – undo
635 646
 
636 647
 				$context['start'] += $forced_break ? $number_processed : $messages_per_batch;
637 648
 
638
-				if (!empty($inserts))
639
-					$smcFunc['db_insert']('ignore',
649
+				if (!empty($inserts)) {
650
+									$smcFunc['db_insert']('ignore',
640 651
 						'{db_prefix}log_search_words',
641 652
 						array('id_word' => 'int', 'id_msg' => 'int'),
642 653
 						$inserts,
643 654
 						array('id_word', 'id_msg')
644 655
 					);
656
+				}
645 657
 				if ($num_messages['todo'] === 0)
646 658
 				{
647 659
 					$context['step'] = 2;
648 660
 					$context['start'] = 0;
649 661
 					break;
662
+				} else {
663
+									updateSettings(array('search_custom_index_resume' => $smcFunc['json_encode'](array_merge($context['index_settings'], array('resume_at' => $context['start'])))));
650 664
 				}
651
-				else
652
-					updateSettings(array('search_custom_index_resume' => $smcFunc['json_encode'](array_merge($context['index_settings'], array('resume_at' => $context['start'])))));
653 665
 			}
654 666
 
655 667
 			// Since there are still two steps to go, 80% is the maximum here.
@@ -660,9 +672,9 @@  discard block
 block discarded – undo
660 672
 	// Step 2: removing the words that occur too often and are of no use.
661 673
 	elseif ($context['step'] === 2)
662 674
 	{
663
-		if ($context['index_settings']['bytes_per_word'] < 4)
664
-			$context['step'] = 3;
665
-		else
675
+		if ($context['index_settings']['bytes_per_word'] < 4) {
676
+					$context['step'] = 3;
677
+		} else
666 678
 		{
667 679
 			$stop_words = $context['start'] === 0 || empty($modSettings['search_stopwords']) ? array() : explode(',', $modSettings['search_stopwords']);
668 680
 			$stop = time() + 3;
@@ -683,20 +695,22 @@  discard block
 block discarded – undo
683 695
 						'minimum_messages' => $max_messages,
684 696
 					)
685 697
 				);
686
-				while ($row = $smcFunc['db_fetch_assoc']($request))
687
-					$stop_words[] = $row['id_word'];
698
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
699
+									$stop_words[] = $row['id_word'];
700
+				}
688 701
 				$smcFunc['db_free_result']($request);
689 702
 
690 703
 				updateSettings(array('search_stopwords' => implode(',', $stop_words)));
691 704
 
692
-				if (!empty($stop_words))
693
-					$smcFunc['db_query']('', '
705
+				if (!empty($stop_words)) {
706
+									$smcFunc['db_query']('', '
694 707
 						DELETE FROM {db_prefix}log_search_words
695 708
 						WHERE id_word in ({array_int:stop_words})',
696 709
 						array(
697 710
 							'stop_words' => $stop_words,
698 711
 						)
699 712
 					);
713
+				}
700 714
 
701 715
 				$context['start'] += $index_properties[$context['index_settings']['bytes_per_word']]['step_size'];
702 716
 				if ($context['start'] > $index_properties[$context['index_settings']['bytes_per_word']]['max_size'])
@@ -757,8 +771,9 @@  discard block
 block discarded – undo
757 771
 					$searchAPI = new $search_class_name();
758 772
 
759 773
 					// No Support?  NEXT!
760
-					if (!$searchAPI->is_supported)
761
-						continue;
774
+					if (!$searchAPI->is_supported) {
775
+											continue;
776
+					}
762 777
 
763 778
 					$apis[$index_name] = array(
764 779
 						'filename' => $file,
@@ -805,10 +820,10 @@  discard block
 block discarded – undo
805 820
 				'messages_ftx' => $db_prefix . 'messages_ftx',
806 821
 			)
807 822
 		);
808
-		while ($row = $smcFunc['db_fetch_assoc']($request))
809
-			$context['fulltext_index'][] = $row['indexname'];
810
-	}
811
-	else
823
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
824
+					$context['fulltext_index'][] = $row['indexname'];
825
+		}
826
+	} else
812 827
 	{
813 828
 		$request = $smcFunc['db_query']('', '
814 829
 			SHOW INDEX
@@ -819,17 +834,19 @@  discard block
 block discarded – undo
819 834
 		$context['fulltext_index'] = array();
820 835
 		if ($request !== false || $smcFunc['db_num_rows']($request) != 0)
821 836
 		{
822
-			while ($row = $smcFunc['db_fetch_assoc']($request))
823
-			if ($row['Column_name'] == 'body' && (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT' || isset($row['Comment']) && $row['Comment'] == 'FULLTEXT'))
837
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
838
+						if ($row['Column_name'] == 'body' && (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT' || isset($row['Comment']) && $row['Comment'] == 'FULLTEXT'))
824 839
 				$context['fulltext_index'][] = $row['Key_name'];
840
+			}
825 841
 			$smcFunc['db_free_result']($request);
826 842
 
827
-			if (is_array($context['fulltext_index']))
828
-				$context['fulltext_index'] = array_unique($context['fulltext_index']);
843
+			if (is_array($context['fulltext_index'])) {
844
+							$context['fulltext_index'] = array_unique($context['fulltext_index']);
845
+			}
829 846
 		}
830 847
 
831
-		if (preg_match('~^`(.+?)`\.(.+?)$~', $db_prefix, $match) !== 0)
832
-			$request = $smcFunc['db_query']('', '
848
+		if (preg_match('~^`(.+?)`\.(.+?)$~', $db_prefix, $match) !== 0) {
849
+					$request = $smcFunc['db_query']('', '
833 850
 			SHOW TABLE STATUS
834 851
 			FROM {string:database_name}
835 852
 			LIKE {string:table_name}',
@@ -838,20 +855,22 @@  discard block
 block discarded – undo
838 855
 				'table_name' => str_replace('_', '\_', $match[2]) . 'messages',
839 856
 			)
840 857
 			);
841
-		else
842
-			$request = $smcFunc['db_query']('', '
858
+		} else {
859
+					$request = $smcFunc['db_query']('', '
843 860
 			SHOW TABLE STATUS
844 861
 			LIKE {string:table_name}',
845 862
 			array(
846 863
 				'table_name' => str_replace('_', '\_', $db_prefix) . 'messages',
847 864
 			)
848 865
 			);
866
+		}
849 867
 
850 868
 		if ($request !== false)
851 869
 		{
852
-			while ($row = $smcFunc['db_fetch_assoc']($request))
853
-			if (isset($row['Engine']) && strtolower($row['Engine']) != 'myisam' && !(strtolower($row['Engine']) == 'innodb' && version_compare($smcFunc['db_get_version'](), '5.6.4', '>=')))
870
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
871
+						if (isset($row['Engine']) && strtolower($row['Engine']) != 'myisam' && !(strtolower($row['Engine']) == 'innodb' && version_compare($smcFunc['db_get_version'](), '5.6.4', '>=')))
854 872
 				$context['cannot_create_fulltext'] = true;
873
+			}
855 874
 			$smcFunc['db_free_result']($request);
856 875
 		}
857 876
 	}
Please login to merge, or discard this patch.
Sources/ManageNews.php 1 patch
Braces   +140 added lines, -102 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * The news dispatcher; doesn't do anything, just delegates.
@@ -67,8 +68,9 @@  discard block
 block discarded – undo
67 68
 	);
68 69
 
69 70
 	// Force the right area...
70
-	if (substr($_REQUEST['sa'], 0, 7) == 'mailing')
71
-		$context[$context['admin_menu_name']]['current_subsection'] = 'mailingmembers';
71
+	if (substr($_REQUEST['sa'], 0, 7) == 'mailing') {
72
+			$context[$context['admin_menu_name']]['current_subsection'] = 'mailingmembers';
73
+	}
72 74
 
73 75
 	call_helper($subActions[$_REQUEST['sa']][0]);
74 76
 }
@@ -99,9 +101,10 @@  discard block
 block discarded – undo
99 101
 		$temp_news = explode("\n", $modSettings['news']);
100 102
 
101 103
 		// Remove the items that were selected.
102
-		foreach ($temp_news as $i => $news)
103
-			if (in_array($i, $_POST['remove']))
104
+		foreach ($temp_news as $i => $news) {
105
+					if (in_array($i, $_POST['remove']))
104 106
 				unset($temp_news[$i]);
107
+		}
105 108
 
106 109
 		// Update the database.
107 110
 		updateSettings(array('news' => implode("\n", $temp_news)));
@@ -117,9 +120,9 @@  discard block
 block discarded – undo
117 120
 
118 121
 		foreach ($_POST['news'] as $i => $news)
119 122
 		{
120
-			if (trim($news) == '')
121
-				unset($_POST['news'][$i]);
122
-			else
123
+			if (trim($news) == '') {
124
+							unset($_POST['news'][$i]);
125
+			} else
123 126
 			{
124 127
 				$_POST['news'][$i] = $smcFunc['htmlspecialchars']($_POST['news'][$i], ENT_QUOTES);
125 128
 				preparsecode($_POST['news'][$i]);
@@ -155,12 +158,13 @@  discard block
 block discarded – undo
155 158
 				'data' => array(
156 159
 					'function' => function($news)
157 160
 					{
158
-						if (is_numeric($news['id']))
159
-							return '
161
+						if (is_numeric($news['id'])) {
162
+													return '
160 163
 								<textarea id="data_' . $news['id'] . '" rows="3" cols="50" name="news[]" class="padding block">' . $news['unparsed'] . '</textarea>
161 164
 								<div class="floatleft" id="preview_' . $news['id'] . '"></div>';
162
-						else
163
-							return $news['unparsed'];
165
+						} else {
166
+													return $news['unparsed'];
167
+						}
164 168
 					},
165 169
 					'class' => 'half_table',
166 170
 				),
@@ -186,10 +190,11 @@  discard block
 block discarded – undo
186 190
 				'data' => array(
187 191
 					'function' => function($news)
188 192
 					{
189
-						if (is_numeric($news['id']))
190
-							return '<input type="checkbox" name="remove[]" value="' . $news['id'] . '">';
191
-						else
192
-							return '';
193
+						if (is_numeric($news['id'])) {
194
+													return '<input type="checkbox" name="remove[]" value="' . $news['id'] . '">';
195
+						} else {
196
+													return '';
197
+						}
193 198
 					},
194 199
 					'class' => 'centercol icon',
195 200
 				),
@@ -283,12 +288,13 @@  discard block
 block discarded – undo
283 288
 
284 289
 	$admin_current_news = array();
285 290
 	// Ready the current news.
286
-	foreach (explode("\n", $modSettings['news']) as $id => $line)
287
-		$admin_current_news[$id] = array(
291
+	foreach (explode("\n", $modSettings['news']) as $id => $line) {
292
+			$admin_current_news[$id] = array(
288 293
 			'id' => $id,
289 294
 			'unparsed' => un_preparsecode($line),
290 295
 			'parsed' => preg_replace('~<([/]?)form[^>]*?[>]*>~i', '<em class="smalltext">&lt;$1form&gt;</em>', parse_bbc($line)),
291 296
 		);
297
+	}
292 298
 
293 299
 	$admin_current_news['last'] = array(
294 300
 		'id' => 'last',
@@ -355,10 +361,11 @@  discard block
 block discarded – undo
355 361
 			'member_count' => 0,
356 362
 		);
357 363
 
358
-		if ($row['min_posts'] == -1)
359
-			$normalGroups[$row['id_group']] = $row['id_group'];
360
-		else
361
-			$postGroups[$row['id_group']] = $row['id_group'];
364
+		if ($row['min_posts'] == -1) {
365
+					$normalGroups[$row['id_group']] = $row['id_group'];
366
+		} else {
367
+					$postGroups[$row['id_group']] = $row['id_group'];
368
+		}
362 369
 	}
363 370
 	$smcFunc['db_free_result']($request);
364 371
 
@@ -374,8 +381,9 @@  discard block
 block discarded – undo
374 381
 				'post_group_list' => $postGroups,
375 382
 			)
376 383
 		);
377
-		while ($row = $smcFunc['db_fetch_assoc']($query))
378
-			$context['groups'][$row['id_group']]['member_count'] += $row['member_count'];
384
+		while ($row = $smcFunc['db_fetch_assoc']($query)) {
385
+					$context['groups'][$row['id_group']]['member_count'] += $row['member_count'];
386
+		}
379 387
 		$smcFunc['db_free_result']($query);
380 388
 	}
381 389
 
@@ -391,8 +399,9 @@  discard block
 block discarded – undo
391 399
 				'normal_group_list' => $normalGroups,
392 400
 			)
393 401
 		);
394
-		while ($row = $smcFunc['db_fetch_assoc']($query))
395
-			$context['groups'][$row['id_group']]['member_count'] += $row['member_count'];
402
+		while ($row = $smcFunc['db_fetch_assoc']($query)) {
403
+					$context['groups'][$row['id_group']]['member_count'] += $row['member_count'];
404
+		}
396 405
 		$smcFunc['db_free_result']($query);
397 406
 
398 407
 		// Also do those who have it as an additional membergroup - this ones more yucky...
@@ -409,8 +418,9 @@  discard block
 block discarded – undo
409 418
 				'blank_string' => '',
410 419
 			)
411 420
 		);
412
-		while ($row = $smcFunc['db_fetch_assoc']($query))
413
-			$context['groups'][$row['id_group']]['member_count'] += $row['member_count'];
421
+		while ($row = $smcFunc['db_fetch_assoc']($query)) {
422
+					$context['groups'][$row['id_group']]['member_count'] += $row['member_count'];
423
+		}
414 424
 		$smcFunc['db_free_result']($query);
415 425
 	}
416 426
 
@@ -461,10 +471,11 @@  discard block
 block discarded – undo
461 471
 	{
462 472
 		$context[$key] = !empty($_REQUEST[$post]) ? $_REQUEST[$post] : '';
463 473
 
464
-		if (empty($context[$key]) && empty($_REQUEST['xml']))
465
-			$context['post_error']['messages'][] = $txt['error_no_' . $post];
466
-		elseif (!empty($_REQUEST['xml']))
467
-			continue;
474
+		if (empty($context[$key]) && empty($_REQUEST['xml'])) {
475
+					$context['post_error']['messages'][] = $txt['error_no_' . $post];
476
+		} elseif (!empty($_REQUEST['xml'])) {
477
+					continue;
478
+		}
468 479
 
469 480
 		preparsecode($context[$key]);
470 481
 		if ($html)
@@ -543,10 +554,12 @@  discard block
 block discarded – undo
543 554
 
544 555
 	// Start by finding any members!
545 556
 	$toClean = array();
546
-	if (!empty($_POST['members']))
547
-		$toClean[] = 'members';
548
-	if (!empty($_POST['exclude_members']))
549
-		$toClean[] = 'exclude_members';
557
+	if (!empty($_POST['members'])) {
558
+			$toClean[] = 'members';
559
+	}
560
+	if (!empty($_POST['exclude_members'])) {
561
+			$toClean[] = 'exclude_members';
562
+	}
550 563
 	if (!empty($toClean))
551 564
 	{
552 565
 		require_once($sourcedir . '/Subs-Auth.php');
@@ -558,11 +571,13 @@  discard block
 block discarded – undo
558 571
 			preg_match_all('~"([^"]+)"~', $_POST[$type], $matches);
559 572
 			$_POST[$type] = array_unique(array_merge($matches[1], explode(',', preg_replace('~"[^"]+"~', '', $_POST[$type]))));
560 573
 
561
-			foreach ($_POST[$type] as $index => $member)
562
-				if (strlen(trim($member)) > 0)
574
+			foreach ($_POST[$type] as $index => $member) {
575
+							if (strlen(trim($member)) > 0)
563 576
 					$_POST[$type][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($member)));
564
-				else
565
-					unset($_POST[$type][$index]);
577
+			}
578
+				else {
579
+									unset($_POST[$type][$index]);
580
+				}
566 581
 
567 582
 			// Find the members
568 583
 			$_POST[$type] = implode(',', array_keys(findMembers($_POST[$type])));
@@ -572,16 +587,18 @@  discard block
 block discarded – undo
572 587
 	if (isset($_POST['member_list']) && is_array($_POST['member_list']))
573 588
 	{
574 589
 		$members = array();
575
-		foreach ($_POST['member_list'] as $member_id)
576
-			$members[] = (int) $member_id;
590
+		foreach ($_POST['member_list'] as $member_id) {
591
+					$members[] = (int) $member_id;
592
+		}
577 593
 		$_POST['members'] = implode(',', $members);
578 594
 	}
579 595
 
580 596
 	if (isset($_POST['exclude_member_list']) && is_array($_POST['exclude_member_list']))
581 597
 	{
582 598
 		$members = array();
583
-		foreach ($_POST['exclude_member_list'] as $member_id)
584
-			$members[] = (int) $member_id;
599
+		foreach ($_POST['exclude_member_list'] as $member_id) {
600
+					$members[] = (int) $member_id;
601
+		}
585 602
 		$_POST['exclude_members'] = implode(',', $members);
586 603
 	}
587 604
 
@@ -605,8 +622,9 @@  discard block
 block discarded – undo
605 622
 			'current_time' => time(),
606 623
 		)
607 624
 	);
608
-	while ($row = $smcFunc['db_fetch_assoc']($request))
609
-		$context['recipients']['exclude_members'][] = $row['id_member'];
625
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
626
+			$context['recipients']['exclude_members'][] = $row['id_member'];
627
+	}
610 628
 	$smcFunc['db_free_result']($request);
611 629
 
612 630
 	$request = $smcFunc['db_query']('', '
@@ -641,8 +659,9 @@  discard block
 block discarded – undo
641 659
 			WHERE email_address IN(' . implode(', ', $condition_array) . ')',
642 660
 			$condition_array_params
643 661
 		);
644
-		while ($row = $smcFunc['db_fetch_assoc']($request))
645
-			$context['recipients']['exclude_members'][] = $row['id_member'];
662
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
663
+					$context['recipients']['exclude_members'][] = $row['id_member'];
664
+		}
646 665
 		$smcFunc['db_free_result']($request);
647 666
 	}
648 667
 
@@ -660,10 +679,11 @@  discard block
 block discarded – undo
660 679
 		);
661 680
 		while ($row = $smcFunc['db_fetch_assoc']($request))
662 681
 		{
663
-			if (in_array(3, $context['recipients']))
664
-				$context['recipients']['exclude_members'][] = $row['identifier'];
665
-			else
666
-				$context['recipients']['members'][] = $row['identifier'];
682
+			if (in_array(3, $context['recipients'])) {
683
+							$context['recipients']['exclude_members'][] = $row['identifier'];
684
+			} else {
685
+							$context['recipients']['members'][] = $row['identifier'];
686
+			}
667 687
 		}
668 688
 		$smcFunc['db_free_result']($request);
669 689
 	}
@@ -710,8 +730,9 @@  discard block
 block discarded – undo
710 730
 	$num_at_once = 1000;
711 731
 
712 732
 	// If by PM's I suggest we half the above number.
713
-	if (!empty($_POST['send_pm']))
714
-		$num_at_once /= 2;
733
+	if (!empty($_POST['send_pm'])) {
734
+			$num_at_once /= 2;
735
+	}
715 736
 
716 737
 	checkSession();
717 738
 
@@ -734,8 +755,7 @@  discard block
 block discarded – undo
734 755
 		);
735 756
 		list ($context['total_members']) = $smcFunc['db_fetch_row']($request);
736 757
 		$smcFunc['db_free_result']($request);
737
-	}
738
-	else
758
+	} else
739 759
 	{
740 760
 		$context['total_members'] = (int) $_REQUEST['total_members'];
741 761
 	}
@@ -753,32 +773,35 @@  discard block
 block discarded – undo
753 773
 	if (!empty($_POST['exclude_members']))
754 774
 	{
755 775
 		$members = explode(',', $_POST['exclude_members']);
756
-		foreach ($members as $member)
757
-			if ($member >= $context['start'])
776
+		foreach ($members as $member) {
777
+					if ($member >= $context['start'])
758 778
 				$context['recipients']['exclude_members'][] = (int) $member;
779
+		}
759 780
 	}
760 781
 
761 782
 	// What about members we *must* do?
762 783
 	if (!empty($_POST['members']))
763 784
 	{
764 785
 		$members = explode(',', $_POST['members']);
765
-		foreach ($members as $member)
766
-			if ($member >= $context['start'])
786
+		foreach ($members as $member) {
787
+					if ($member >= $context['start'])
767 788
 				$context['recipients']['members'][] = (int) $member;
789
+		}
768 790
 	}
769 791
 	// Cleaning groups is simple - although deal with both checkbox and commas.
770 792
 	if (isset($_POST['groups']))
771 793
 	{
772 794
 		if (is_array($_POST['groups']))
773 795
 		{
774
-			foreach ($_POST['groups'] as $group => $dummy)
775
-				$context['recipients']['groups'][] = (int) $group;
776
-		}
777
-		else
796
+			foreach ($_POST['groups'] as $group => $dummy) {
797
+							$context['recipients']['groups'][] = (int) $group;
798
+			}
799
+		} else
778 800
 		{
779 801
 			$groups = explode(',', $_POST['groups']);
780
-			foreach ($groups as $group)
781
-				$context['recipients']['groups'][] = (int) $group;
802
+			foreach ($groups as $group) {
803
+							$context['recipients']['groups'][] = (int) $group;
804
+			}
782 805
 		}
783 806
 	}
784 807
 	// Same for excluded groups
@@ -786,15 +809,17 @@  discard block
 block discarded – undo
786 809
 	{
787 810
 		if (is_array($_POST['exclude_groups']))
788 811
 		{
789
-			foreach ($_POST['exclude_groups'] as $group => $dummy)
790
-				$context['recipients']['exclude_groups'][] = (int) $group;
812
+			foreach ($_POST['exclude_groups'] as $group => $dummy) {
813
+							$context['recipients']['exclude_groups'][] = (int) $group;
814
+			}
791 815
 		}
792 816
 		// Ignore an empty string - we don't want to exclude "Regular Members" unless it's specifically selected
793 817
 		elseif ($_POST['exclude_groups'] != '')
794 818
 		{
795 819
 			$groups = explode(',', $_POST['exclude_groups']);
796
-			foreach ($groups as $group)
797
-				$context['recipients']['exclude_groups'][] = (int) $group;
820
+			foreach ($groups as $group) {
821
+							$context['recipients']['exclude_groups'][] = (int) $group;
822
+			}
798 823
 		}
799 824
 	}
800 825
 	// Finally - emails!
@@ -804,14 +829,16 @@  discard block
 block discarded – undo
804 829
 		foreach ($addressed as $curmem)
805 830
 		{
806 831
 			$curmem = trim($curmem);
807
-			if ($curmem != '' && filter_var($curmem, FILTER_VALIDATE_EMAIL))
808
-				$context['recipients']['emails'][$curmem] = $curmem;
832
+			if ($curmem != '' && filter_var($curmem, FILTER_VALIDATE_EMAIL)) {
833
+							$context['recipients']['emails'][$curmem] = $curmem;
834
+			}
809 835
 		}
810 836
 	}
811 837
 
812 838
 	// If we're only cleaning drop out here.
813
-	if ($clean_only)
814
-		return;
839
+	if ($clean_only) {
840
+			return;
841
+	}
815 842
 
816 843
 	require_once($sourcedir . '/Subs-Post.php');
817 844
 
@@ -827,16 +854,18 @@  discard block
 block discarded – undo
827 854
 	if (!$context['send_pm'] && !empty($_POST['send_html']))
828 855
 	{
829 856
 		// Prepare the message for HTML.
830
-		if (!empty($_POST['parse_html']))
831
-			$_POST['message'] = str_replace(array("\n", '  '), array('<br>' . "\n", '&nbsp; '), $_POST['message']);
857
+		if (!empty($_POST['parse_html'])) {
858
+					$_POST['message'] = str_replace(array("\n", '  '), array('<br>' . "\n", '&nbsp; '), $_POST['message']);
859
+		}
832 860
 
833 861
 		// This is here to prevent spam filters from tagging this as spam.
834 862
 		if (preg_match('~\<html~i', $_POST['message']) == 0)
835 863
 		{
836
-			if (preg_match('~\<body~i', $_POST['message']) == 0)
837
-				$_POST['message'] = '<html><head><title>' . $_POST['subject'] . '</title></head>' . "\n" . '<body>' . $_POST['message'] . '</body></html>';
838
-			else
839
-				$_POST['message'] = '<html>' . $_POST['message'] . '</html>';
864
+			if (preg_match('~\<body~i', $_POST['message']) == 0) {
865
+							$_POST['message'] = '<html><head><title>' . $_POST['subject'] . '</title></head>' . "\n" . '<body>' . $_POST['message'] . '</body></html>';
866
+			} else {
867
+							$_POST['message'] = '<html>' . $_POST['message'] . '</html>';
868
+			}
840 869
 		}
841 870
 	}
842 871
 
@@ -890,15 +919,17 @@  discard block
 block discarded – undo
890 919
 	foreach ($context['recipients']['emails'] as $k => $email)
891 920
 	{
892 921
 		// Done as many as we can?
893
-		if ($i >= $num_at_once)
894
-			break;
922
+		if ($i >= $num_at_once) {
923
+					break;
924
+		}
895 925
 
896 926
 		// Don't sent it twice!
897 927
 		unset($context['recipients']['emails'][$k]);
898 928
 
899 929
 		// Dammit - can't PM emails!
900
-		if ($context['send_pm'])
901
-			continue;
930
+		if ($context['send_pm']) {
931
+					continue;
932
+		}
902 933
 
903 934
 		$to_member = array(
904 935
 			$email,
@@ -932,8 +963,9 @@  discard block
 block discarded – undo
932 963
 					$queryBuild[] = 'mem.id_post_group = {int:group_' . $group . '}';
933 964
 				}
934 965
 			}
935
-			if (!empty($queryBuild))
936
-			$sendQuery .= implode(' OR ', $queryBuild);
966
+			if (!empty($queryBuild)) {
967
+						$sendQuery .= implode(' OR ', $queryBuild);
968
+			}
937 969
 		}
938 970
 		if (!empty($context['recipients']['members']))
939 971
 		{
@@ -952,8 +984,9 @@  discard block
 block discarded – undo
952 984
 		}
953 985
 
954 986
 		// Anything to exclude?
955
-		if (!empty($context['recipients']['exclude_groups']) && in_array(0, $context['recipients']['exclude_groups']))
956
-			$sendQuery .= ' AND mem.id_group != {int:regular_group}';
987
+		if (!empty($context['recipients']['exclude_groups']) && in_array(0, $context['recipients']['exclude_groups'])) {
988
+					$sendQuery .= ' AND mem.id_group != {int:regular_group}';
989
+		}
957 990
 		if (!empty($context['recipients']['exclude_members']))
958 991
 		{
959 992
 			$sendQuery .= ' AND mem.id_member NOT IN ({array_int:exclude_members})';
@@ -989,21 +1022,24 @@  discard block
 block discarded – undo
989 1022
 		foreach ($rows as $row)
990 1023
 		{
991 1024
 			// Force them to have it?
992
-			if (empty($context['email_force']) && empty($prefs[$row['id_member']]['announcements']))
993
-				continue;
1025
+			if (empty($context['email_force']) && empty($prefs[$row['id_member']]['announcements'])) {
1026
+							continue;
1027
+			}
994 1028
 
995 1029
 			// What groups are we looking at here?
996
-			if (empty($row['additional_groups']))
997
-				$groups = array($row['id_group'], $row['id_post_group']);
998
-			else
999
-				$groups = array_merge(
1030
+			if (empty($row['additional_groups'])) {
1031
+							$groups = array($row['id_group'], $row['id_post_group']);
1032
+			} else {
1033
+							$groups = array_merge(
1000 1034
 					array($row['id_group'], $row['id_post_group']),
1001 1035
 					explode(',', $row['additional_groups'])
1002 1036
 				);
1037
+			}
1003 1038
 
1004 1039
 			// Excluded groups?
1005
-			if (array_intersect($groups, $context['recipients']['exclude_groups']))
1006
-				continue;
1040
+			if (array_intersect($groups, $context['recipients']['exclude_groups'])) {
1041
+							continue;
1042
+			}
1007 1043
 
1008 1044
 			// We might need this
1009 1045
 			$cleanMemberName = empty($_POST['send_html']) || $context['send_pm'] ? un_htmlspecialchars($row['real_name']) : $row['real_name'];
@@ -1026,10 +1062,11 @@  discard block
 block discarded – undo
1026 1062
 				), $_POST['subject']);
1027 1063
 
1028 1064
 			// Send the actual email - or a PM!
1029
-			if (!$context['send_pm'])
1030
-				sendmail($row['email_address'], $subject, $message, null, 'news', !empty($_POST['send_html']), 5);
1031
-			else
1032
-				sendpm(array('to' => array($row['id_member']), 'bcc' => array()), $subject, $message);
1065
+			if (!$context['send_pm']) {
1066
+							sendmail($row['email_address'], $subject, $message, null, 'news', !empty($_POST['send_html']), 5);
1067
+			} else {
1068
+							sendpm(array('to' => array($row['id_member']), 'bcc' => array()), $subject, $message);
1069
+			}
1033 1070
 		}
1034 1071
 	}
1035 1072
 
@@ -1079,8 +1116,9 @@  discard block
 block discarded – undo
1079 1116
 
1080 1117
 	call_integration_hook('integrate_modify_news_settings', array(&$config_vars));
1081 1118
 
1082
-	if ($return_config)
1083
-		return $config_vars;
1119
+	if ($return_config) {
1120
+			return $config_vars;
1121
+	}
1084 1122
 
1085 1123
 	$context['page_title'] = $txt['admin_edit_news'] . ' - ' . $txt['settings'];
1086 1124
 	$context['sub_template'] = 'show_settings';
Please login to merge, or discard this patch.
Sources/Subs.php 4 patches
Indentation   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -5495,7 +5495,6 @@  discard block
 block discarded – undo
5495 5495
 
5496 5496
 /**
5497 5497
  * Tries different modes to make file/dirs writable. Wrapper function for chmod()
5498
-
5499 5498
  * @param string $file The file/dir full path.
5500 5499
  * @param int $value Not needed, added for legacy reasons.
5501 5500
  * @return boolean  true if the file/dir is already writable or the function was able to make it writable, false if the function couldn't make the file/dir writable.
@@ -5535,7 +5534,6 @@  discard block
 block discarded – undo
5535 5534
 
5536 5535
 /**
5537 5536
  * Wrapper function for json_decode() with error handling.
5538
-
5539 5537
  * @param string $json The string to decode.
5540 5538
  * @param bool $returnAsArray To return the decoded string as an array or an object, SMF only uses Arrays but to keep on compatibility with json_decode its set to false as default.
5541 5539
  * @param bool $logIt To specify if the error will be logged if theres any.
@@ -6029,7 +6027,7 @@  discard block
 block discarded – undo
6029 6027
 		$params = stream_context_get_params($stream);
6030 6028
 		$result = isset($params["options"]["ssl"]["peer_certificate"]) ? true : false;
6031 6029
 	}
6032
-    return $result;
6030
+	return $result;
6033 6031
 }
6034 6032
 
6035 6033
 /**
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -693,7 +693,7 @@  discard block
 block discarded – undo
693 693
  * - caches the formatting data from the setting for optimization.
694 694
  *
695 695
  * @param float $number A number
696
- * @param bool|int $override_decimal_count If set, will use the specified number of decimal places. Otherwise it's automatically determined
696
+ * @param integer $override_decimal_count If set, will use the specified number of decimal places. Otherwise it's automatically determined
697 697
  * @return string A formatted number
698 698
  */
699 699
 function comma_format($number, $override_decimal_count = false)
@@ -5869,7 +5869,7 @@  discard block
 block discarded – undo
5869 5869
  * It assumes the data is already a string.
5870 5870
  * @param string $data The data to print
5871 5871
  * @param string $type The content type. Defaults to Json.
5872
- * @return void
5872
+ * @return false|null
5873 5873
  */
5874 5874
 function smf_serverResponse($data = '', $type = 'content-type: application/json')
5875 5875
 {
@@ -6351,7 +6351,7 @@  discard block
 block discarded – undo
6351 6351
  *
6352 6352
  * @param string $iri The IRI to test.
6353 6353
  * @param int $flags Optional flags to pass to filter_var()
6354
- * @return string|bool Either the original IRI, or false if the IRI was invalid.
6354
+ * @return string|false Either the original IRI, or false if the IRI was invalid.
6355 6355
  */
6356 6356
 function validate_iri($iri, $flags = null)
6357 6357
 {
Please login to merge, or discard this patch.
Spacing   +111 added lines, -111 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 			{
392 392
 				$val = 'CASE ';
393 393
 				foreach ($members as $k => $v)
394
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' ';
394
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . count(fetch_alerts($v, false, 0, array(), false)) . ' ';
395 395
 				$val = $val . ' END';
396 396
 				$type = 'raw';
397 397
 			}
@@ -744,7 +744,7 @@  discard block
 block discarded – undo
744 744
 	static $non_twelve_hour, $locale_cache;
745 745
 	static $unsupportedFormats, $finalizedFormats;
746 746
 
747
-	$unsupportedFormatsWindows = array('z','Z');
747
+	$unsupportedFormatsWindows = array('z', 'Z');
748 748
 
749 749
 	// Ensure required values are set
750 750
 	$user_info['time_offset'] = !empty($user_info['time_offset']) ? $user_info['time_offset'] : 0;
@@ -829,7 +829,7 @@  discard block
 block discarded – undo
829 829
 			$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
830 830
 		if (empty($unsupportedFormats))
831 831
 		{
832
-			foreach($strftimeFormatSubstitutions as $format => $substitution)
832
+			foreach ($strftimeFormatSubstitutions as $format => $substitution)
833 833
 			{
834 834
 				// Avoid a crashing bug with PHP 7 on certain versions of Windows
835 835
 				if ($context['server']['is_windows'] && in_array($format, $unsupportedFormatsWindows))
@@ -1206,7 +1206,7 @@  discard block
 block discarded – undo
1206 1206
 					'height' => array('optional' => true, 'match' => '(\d+)'),
1207 1207
 				),
1208 1208
 				'content' => '$1',
1209
-				'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1209
+				'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1210 1210
 				{
1211 1211
 					$returnContext = '';
1212 1212
 
@@ -1241,7 +1241,7 @@  discard block
 block discarded – undo
1241 1241
 						}
1242 1242
 
1243 1243
 						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1244
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1244
+							$returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>';
1245 1245
 						else
1246 1246
 							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1247 1247
 					}
@@ -1293,7 +1293,7 @@  discard block
 block discarded – undo
1293 1293
 				'type' => 'unparsed_content',
1294 1294
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1295 1295
 				// @todo Maybe this can be simplified?
1296
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1296
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1297 1297
 				{
1298 1298
 					if (!isset($disabled['code']))
1299 1299
 					{
@@ -1330,7 +1330,7 @@  discard block
 block discarded – undo
1330 1330
 				'type' => 'unparsed_equals_content',
1331 1331
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1332 1332
 				// @todo Maybe this can be simplified?
1333
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1333
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1334 1334
 				{
1335 1335
 					if (!isset($disabled['code']))
1336 1336
 					{
@@ -1374,7 +1374,7 @@  discard block
 block discarded – undo
1374 1374
 				'type' => 'unparsed_content',
1375 1375
 				'content' => '<a href="mailto:$1" class="bbc_email">$1</a>',
1376 1376
 				// @todo Should this respect guest_hideContacts?
1377
-				'validate' => function (&$tag, &$data, $disabled)
1377
+				'validate' => function(&$tag, &$data, $disabled)
1378 1378
 				{
1379 1379
 					$data = strtr($data, array('<br>' => ''));
1380 1380
 				},
@@ -1394,7 +1394,7 @@  discard block
 block discarded – undo
1394 1394
 				'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]',
1395 1395
 				'before' => '<div $1>',
1396 1396
 				'after' => '</div>',
1397
-				'validate' => function (&$tag, &$data, $disabled)
1397
+				'validate' => function(&$tag, &$data, $disabled)
1398 1398
 				{
1399 1399
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1400 1400
 
@@ -1480,7 +1480,7 @@  discard block
 block discarded – undo
1480 1480
 					'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
1481 1481
 				),
1482 1482
 				'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',
1483
-				'validate' => function (&$tag, &$data, $disabled)
1483
+				'validate' => function(&$tag, &$data, $disabled)
1484 1484
 				{
1485 1485
 					global $image_proxy_enabled, $user_info;
1486 1486
 
@@ -1506,7 +1506,7 @@  discard block
 block discarded – undo
1506 1506
 				'tag' => 'img',
1507 1507
 				'type' => 'unparsed_content',
1508 1508
 				'content' => '<img src="$1" alt="" class="bbc_img">',
1509
-				'validate' => function (&$tag, &$data, $disabled)
1509
+				'validate' => function(&$tag, &$data, $disabled)
1510 1510
 				{
1511 1511
 					global $image_proxy_enabled, $user_info;
1512 1512
 
@@ -1532,7 +1532,7 @@  discard block
 block discarded – undo
1532 1532
 				'tag' => 'iurl',
1533 1533
 				'type' => 'unparsed_content',
1534 1534
 				'content' => '<a href="$1" class="bbc_link">$1</a>',
1535
-				'validate' => function (&$tag, &$data, $disabled)
1535
+				'validate' => function(&$tag, &$data, $disabled)
1536 1536
 				{
1537 1537
 					$data = strtr($data, array('<br>' => ''));
1538 1538
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1546,7 +1546,7 @@  discard block
 block discarded – undo
1546 1546
 				'quoted' => 'optional',
1547 1547
 				'before' => '<a href="$1" class="bbc_link">',
1548 1548
 				'after' => '</a>',
1549
-				'validate' => function (&$tag, &$data, $disabled)
1549
+				'validate' => function(&$tag, &$data, $disabled)
1550 1550
 				{
1551 1551
 					if (substr($data, 0, 1) == '#')
1552 1552
 						$data = '#post_' . substr($data, 1);
@@ -1639,7 +1639,7 @@  discard block
 block discarded – undo
1639 1639
 				'tag' => 'php',
1640 1640
 				'type' => 'unparsed_content',
1641 1641
 				'content' => '<span class="phpcode">$1</span>',
1642
-				'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled)
1642
+				'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled)
1643 1643
 				{
1644 1644
 					if (!isset($disabled['php']))
1645 1645
 					{
@@ -1788,7 +1788,7 @@  discard block
 block discarded – undo
1788 1788
 				'test' => '[1-7]\]',
1789 1789
 				'before' => '<span style="font-size: $1;" class="bbc_size">',
1790 1790
 				'after' => '</span>',
1791
-				'validate' => function (&$tag, &$data, $disabled)
1791
+				'validate' => function(&$tag, &$data, $disabled)
1792 1792
 				{
1793 1793
 					$sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95);
1794 1794
 					$data = $sizes[$data] . 'em';
@@ -1826,7 +1826,7 @@  discard block
 block discarded – undo
1826 1826
 				'tag' => 'time',
1827 1827
 				'type' => 'unparsed_content',
1828 1828
 				'content' => '$1',
1829
-				'validate' => function (&$tag, &$data, $disabled)
1829
+				'validate' => function(&$tag, &$data, $disabled)
1830 1830
 				{
1831 1831
 					if (is_numeric($data))
1832 1832
 						$data = timeformat($data);
@@ -1859,7 +1859,7 @@  discard block
 block discarded – undo
1859 1859
 				'tag' => 'url',
1860 1860
 				'type' => 'unparsed_content',
1861 1861
 				'content' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">$1</a>',
1862
-				'validate' => function (&$tag, &$data, $disabled)
1862
+				'validate' => function(&$tag, &$data, $disabled)
1863 1863
 				{
1864 1864
 					$data = strtr($data, array('<br>' => ''));
1865 1865
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1873,7 +1873,7 @@  discard block
 block discarded – undo
1873 1873
 				'quoted' => 'optional',
1874 1874
 				'before' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">',
1875 1875
 				'after' => '</a>',
1876
-				'validate' => function (&$tag, &$data, $disabled)
1876
+				'validate' => function(&$tag, &$data, $disabled)
1877 1877
 				{
1878 1878
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1879 1879
 					if (empty($scheme))
@@ -1912,7 +1912,7 @@  discard block
 block discarded – undo
1912 1912
 		{
1913 1913
 			if (isset($temp_bbc))
1914 1914
 				$bbc_codes = $temp_bbc;
1915
-			usort($codes, function ($a, $b) {
1915
+			usort($codes, function($a, $b) {
1916 1916
 				return strcmp($a['tag'], $b['tag']);
1917 1917
 			});
1918 1918
 			return $codes;
@@ -2128,7 +2128,7 @@  discard block
 block discarded – undo
2128 2128
 										# a run of Unicode domain name characters and a dot
2129 2129
 										[\p{L}\p{M}\p{N}\-.:@]+\.
2130 2130
 										# and then a TLD valid in the DNS or the reserved "local" TLD
2131
-										(?:'. $modSettings['tld_regex'] .'|local)
2131
+										(?:'. $modSettings['tld_regex'] . '|local)
2132 2132
 									)
2133 2133
 									# followed by a non-domain character or end of line
2134 2134
 									(?=[^\p{L}\p{N}\-.]|$)
@@ -2196,7 +2196,7 @@  discard block
 block discarded – undo
2196 2196
 						)?
2197 2197
 						';
2198 2198
 
2199
-						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) {
2199
+						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) {
2200 2200
 							$url = array_shift($matches);
2201 2201
 
2202 2202
 							// If this isn't a clean URL, bail out
@@ -2221,7 +2221,7 @@  discard block
 block discarded – undo
2221 2221
 								$fullUrl = $url;
2222 2222
 
2223 2223
 							// Make sure that $fullUrl really is valid
2224
-							if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false)
2224
+							if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '') . $fullUrl) === false)
2225 2225
 								return $url;
2226 2226
 
2227 2227
 							return '[url=&quot;' . str_replace(array('[', ']'), array('&#91;', '&#93;'), $fullUrl) . '&quot;]' . $url . '[/url]';
@@ -2285,7 +2285,7 @@  discard block
 block discarded – undo
2285 2285
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
2286 2286
 
2287 2287
 			// A closing tag that doesn't match any open tags? Skip it.
2288
-			if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags)))
2288
+			if (!in_array($look_for, array_map(function($code) {return $code['tag']; }, $open_tags)))
2289 2289
 				continue;
2290 2290
 
2291 2291
 			$to_close = array();
@@ -2958,7 +2958,7 @@  discard block
 block discarded – undo
2958 2958
 			{
2959 2959
 				$exts = array('svg', 'png', 'gif', 'jpg');
2960 2960
 				$fname = pathinfo($smileysto[$i], PATHINFO_FILENAME);
2961
-				$alt_images = glob($smileys_dir . $fname .  '.{' . (implode(',', $exts)) . '}', GLOB_BRACE);
2961
+				$alt_images = glob($smileys_dir . $fname . '.{' . (implode(',', $exts)) . '}', GLOB_BRACE);
2962 2962
 				if (!empty($alt_images))
2963 2963
 				{
2964 2964
 					foreach ($exts as $ext)
@@ -2974,7 +2974,7 @@  discard block
 block discarded – undo
2974 2974
 			}
2975 2975
 
2976 2976
 			$specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES);
2977
-			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2977
+			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2978 2978
 
2979 2979
 			$smileyPregReplacements[$smileysfrom[$i]] = $smileyCode;
2980 2980
 
@@ -2991,7 +2991,7 @@  discard block
 block discarded – undo
2991 2991
 
2992 2992
 	// Replace away!
2993 2993
 	$message = preg_replace_callback($smileyPregSearch,
2994
-		function ($matches) use ($smileyPregReplacements)
2994
+		function($matches) use ($smileyPregReplacements)
2995 2995
 		{
2996 2996
 			return $smileyPregReplacements[$matches[1]];
2997 2997
 		}, $message);
@@ -3088,13 +3088,13 @@  discard block
 block discarded – undo
3088 3088
 	{
3089 3089
 		if (defined('SID') && SID != '')
3090 3090
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
3091
-				function ($m) use ($scripturl)
3091
+				function($m) use ($scripturl)
3092 3092
 				{
3093
-					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
3093
+					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : "");
3094 3094
 				}, $setLocation);
3095 3095
 		else
3096 3096
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
3097
-				function ($m) use ($scripturl)
3097
+				function($m) use ($scripturl)
3098 3098
 				{
3099 3099
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
3100 3100
 				}, $setLocation);
@@ -3415,7 +3415,7 @@  discard block
 block discarded – undo
3415 3415
 
3416 3416
 	// Add a generic "Are you sure?" confirmation message.
3417 3417
 	addInlineJavaScript('
3418
-	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3418
+	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';');
3419 3419
 
3420 3420
 	// Now add the capping code for avatars.
3421 3421
 	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
@@ -3881,7 +3881,7 @@  discard block
 block discarded – undo
3881 3881
 	if (!empty($normal))
3882 3882
 		foreach ($normal as $nf)
3883 3883
 			echo '
3884
-	<link rel="stylesheet" href="', $nf ,'">';
3884
+	<link rel="stylesheet" href="', $nf, '">';
3885 3885
 
3886 3886
 	if ($db_show_debug === true)
3887 3887
 	{
@@ -3897,7 +3897,7 @@  discard block
 block discarded – undo
3897 3897
 	<style>';
3898 3898
 
3899 3899
 		foreach ($context['css_header'] as $css)
3900
-			echo $css .'
3900
+			echo $css . '
3901 3901
 	';
3902 3902
 
3903 3903
 		echo'
@@ -3941,7 +3941,7 @@  discard block
 block discarded – undo
3941 3941
 
3942 3942
 
3943 3943
 	// No namespaces, sorry!
3944
-	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
3944
+	$classType = 'MatthiasMullie\\Minify\\' . strtoupper($type);
3945 3945
 
3946 3946
 	// Temp path.
3947 3947
 	$cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/';
@@ -4121,7 +4121,7 @@  discard block
 block discarded – undo
4121 4121
 	else
4122 4122
 		$path = $modSettings['attachmentUploadDir'];
4123 4123
 
4124
-	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
4124
+	return $path . '/' . $attachment_id . '_' . $file_hash . '.dat';
4125 4125
 }
4126 4126
 
4127 4127
 /**
@@ -4165,10 +4165,10 @@  discard block
 block discarded – undo
4165 4165
 		$valid_low = isValidIP($ip_parts[0]);
4166 4166
 		$valid_high = isValidIP($ip_parts[1]);
4167 4167
 		$count = 0;
4168
-		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
4168
+		$mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.');
4169 4169
 		$max = ($mode == ':' ? 'ffff' : '255');
4170 4170
 		$min = 0;
4171
-		if(!$valid_low)
4171
+		if (!$valid_low)
4172 4172
 		{
4173 4173
 			$ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]);
4174 4174
 			$valid_low = isValidIP($ip_parts[0]);
@@ -4182,7 +4182,7 @@  discard block
 block discarded – undo
4182 4182
 		}
4183 4183
 
4184 4184
 		$count = 0;
4185
-		if(!$valid_high)
4185
+		if (!$valid_high)
4186 4186
 		{
4187 4187
 			$ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]);
4188 4188
 			$valid_high = isValidIP($ip_parts[1]);
@@ -4195,7 +4195,7 @@  discard block
 block discarded – undo
4195 4195
 			}
4196 4196
 		}
4197 4197
 
4198
-		if($valid_high && $valid_low)
4198
+		if ($valid_high && $valid_low)
4199 4199
 		{
4200 4200
 			$ip_array['low'] = $ip_parts[0];
4201 4201
 			$ip_array['high'] = $ip_parts[1];
@@ -4376,7 +4376,7 @@  discard block
 block discarded – undo
4376 4376
 		addInlineJavaScript('
4377 4377
 	var user_menus = new smc_PopupMenu();
4378 4378
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
4379
-	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
4379
+	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true);
4380 4380
 		if ($context['allow_pm'])
4381 4381
 			addInlineJavaScript('
4382 4382
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
@@ -5012,7 +5012,7 @@  discard block
 block discarded – undo
5012 5012
 		// No? try a fallback to $sourcedir
5013 5013
 		else
5014 5014
 		{
5015
-			$absPath = $sourcedir .'/'. $file;
5015
+			$absPath = $sourcedir . '/' . $file;
5016 5016
 
5017 5017
 			if (file_exists($absPath))
5018 5018
 				require_once($absPath);
@@ -5279,15 +5279,15 @@  discard block
 block discarded – undo
5279 5279
 
5280 5280
 	// UTF-8 occurences of MS special characters
5281 5281
 	$findchars_utf8 = array(
5282
-		"\xe2\x80\x9a",	// single low-9 quotation mark
5283
-		"\xe2\x80\x9e",	// double low-9 quotation mark
5284
-		"\xe2\x80\xa6",	// horizontal ellipsis
5285
-		"\xe2\x80\x98",	// left single curly quote
5286
-		"\xe2\x80\x99",	// right single curly quote
5287
-		"\xe2\x80\x9c",	// left double curly quote
5288
-		"\xe2\x80\x9d",	// right double curly quote
5289
-		"\xe2\x80\x93",	// en dash
5290
-		"\xe2\x80\x94",	// em dash
5282
+		"\xe2\x80\x9a", // single low-9 quotation mark
5283
+		"\xe2\x80\x9e", // double low-9 quotation mark
5284
+		"\xe2\x80\xa6", // horizontal ellipsis
5285
+		"\xe2\x80\x98", // left single curly quote
5286
+		"\xe2\x80\x99", // right single curly quote
5287
+		"\xe2\x80\x9c", // left double curly quote
5288
+		"\xe2\x80\x9d", // right double curly quote
5289
+		"\xe2\x80\x93", // en dash
5290
+		"\xe2\x80\x94", // em dash
5291 5291
 	);
5292 5292
 
5293 5293
 	// windows 1252 / iso equivalents
@@ -5305,15 +5305,15 @@  discard block
 block discarded – undo
5305 5305
 
5306 5306
 	// safe replacements
5307 5307
 	$replacechars = array(
5308
-		',',	// &sbquo;
5309
-		',,',	// &bdquo;
5310
-		'...',	// &hellip;
5311
-		"'",	// &lsquo;
5312
-		"'",	// &rsquo;
5313
-		'"',	// &ldquo;
5314
-		'"',	// &rdquo;
5315
-		'-',	// &ndash;
5316
-		'--',	// &mdash;
5308
+		',', // &sbquo;
5309
+		',,', // &bdquo;
5310
+		'...', // &hellip;
5311
+		"'", // &lsquo;
5312
+		"'", // &rsquo;
5313
+		'"', // &ldquo;
5314
+		'"', // &rdquo;
5315
+		'-', // &ndash;
5316
+		'--', // &mdash;
5317 5317
 	);
5318 5318
 
5319 5319
 	if ($context['utf8'])
@@ -5633,7 +5633,7 @@  discard block
 block discarded – undo
5633 5633
  */
5634 5634
 function inet_dtop($bin)
5635 5635
 {
5636
-	if(empty($bin))
5636
+	if (empty($bin))
5637 5637
 		return '';
5638 5638
 
5639 5639
 	global $db_type;
@@ -5664,28 +5664,28 @@  discard block
 block discarded – undo
5664 5664
  */
5665 5665
 function _safe_serialize($value)
5666 5666
 {
5667
-	if(is_null($value))
5667
+	if (is_null($value))
5668 5668
 		return 'N;';
5669 5669
 
5670
-	if(is_bool($value))
5671
-		return 'b:'. (int) $value .';';
5670
+	if (is_bool($value))
5671
+		return 'b:' . (int) $value . ';';
5672 5672
 
5673
-	if(is_int($value))
5674
-		return 'i:'. $value .';';
5673
+	if (is_int($value))
5674
+		return 'i:' . $value . ';';
5675 5675
 
5676
-	if(is_float($value))
5677
-		return 'd:'. str_replace(',', '.', $value) .';';
5676
+	if (is_float($value))
5677
+		return 'd:' . str_replace(',', '.', $value) . ';';
5678 5678
 
5679
-	if(is_string($value))
5680
-		return 's:'. strlen($value) .':"'. $value .'";';
5679
+	if (is_string($value))
5680
+		return 's:' . strlen($value) . ':"' . $value . '";';
5681 5681
 
5682
-	if(is_array($value))
5682
+	if (is_array($value))
5683 5683
 	{
5684 5684
 		$out = '';
5685
-		foreach($value as $k => $v)
5685
+		foreach ($value as $k => $v)
5686 5686
 			$out .= _safe_serialize($k) . _safe_serialize($v);
5687 5687
 
5688
-		return 'a:'. count($value) .':{'. $out .'}';
5688
+		return 'a:' . count($value) . ':{' . $out . '}';
5689 5689
 	}
5690 5690
 
5691 5691
 	// safe_serialize cannot serialize resources or objects.
@@ -5727,7 +5727,7 @@  discard block
 block discarded – undo
5727 5727
 function _safe_unserialize($str)
5728 5728
 {
5729 5729
 	// Input  is not a string.
5730
-	if(empty($str) || !is_string($str))
5730
+	if (empty($str) || !is_string($str))
5731 5731
 		return false;
5732 5732
 
5733 5733
 	$stack = array();
@@ -5741,40 +5741,40 @@  discard block
 block discarded – undo
5741 5741
 	 *   3 - in array, expecting value or another array
5742 5742
 	 */
5743 5743
 	$state = 0;
5744
-	while($state != 1)
5744
+	while ($state != 1)
5745 5745
 	{
5746 5746
 		$type = isset($str[0]) ? $str[0] : '';
5747
-		if($type == '}')
5747
+		if ($type == '}')
5748 5748
 			$str = substr($str, 1);
5749 5749
 
5750
-		else if($type == 'N' && $str[1] == ';')
5750
+		else if ($type == 'N' && $str[1] == ';')
5751 5751
 		{
5752 5752
 			$value = null;
5753 5753
 			$str = substr($str, 2);
5754 5754
 		}
5755
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5755
+		else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5756 5756
 		{
5757 5757
 			$value = $matches[1] == '1' ? true : false;
5758 5758
 			$str = substr($str, 4);
5759 5759
 		}
5760
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5760
+		else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5761 5761
 		{
5762
-			$value = (int)$matches[1];
5762
+			$value = (int) $matches[1];
5763 5763
 			$str = $matches[2];
5764 5764
 		}
5765
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5765
+		else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5766 5766
 		{
5767
-			$value = (float)$matches[1];
5767
+			$value = (float) $matches[1];
5768 5768
 			$str = $matches[3];
5769 5769
 		}
5770
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5770
+		else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";')
5771 5771
 		{
5772
-			$value = substr($matches[2], 0, (int)$matches[1]);
5773
-			$str = substr($matches[2], (int)$matches[1] + 2);
5772
+			$value = substr($matches[2], 0, (int) $matches[1]);
5773
+			$str = substr($matches[2], (int) $matches[1] + 2);
5774 5774
 		}
5775
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5775
+		else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5776 5776
 		{
5777
-			$expectedLength = (int)$matches[1];
5777
+			$expectedLength = (int) $matches[1];
5778 5778
 			$str = $matches[2];
5779 5779
 		}
5780 5780
 
@@ -5782,10 +5782,10 @@  discard block
 block discarded – undo
5782 5782
 		else
5783 5783
 			return false;
5784 5784
 
5785
-		switch($state)
5785
+		switch ($state)
5786 5786
 		{
5787 5787
 			case 3: // In array, expecting value or another array.
5788
-				if($type == 'a')
5788
+				if ($type == 'a')
5789 5789
 				{
5790 5790
 					$stack[] = &$list;
5791 5791
 					$list[$key] = array();
@@ -5794,7 +5794,7 @@  discard block
 block discarded – undo
5794 5794
 					$state = 2;
5795 5795
 					break;
5796 5796
 				}
5797
-				if($type != '}')
5797
+				if ($type != '}')
5798 5798
 				{
5799 5799
 					$list[$key] = $value;
5800 5800
 					$state = 2;
@@ -5805,29 +5805,29 @@  discard block
 block discarded – undo
5805 5805
 				return false;
5806 5806
 
5807 5807
 			case 2: // in array, expecting end of array or a key
5808
-				if($type == '}')
5808
+				if ($type == '}')
5809 5809
 				{
5810 5810
 					// Array size is less than expected.
5811
-					if(count($list) < end($expected))
5811
+					if (count($list) < end($expected))
5812 5812
 						return false;
5813 5813
 
5814 5814
 					unset($list);
5815
-					$list = &$stack[count($stack)-1];
5815
+					$list = &$stack[count($stack) - 1];
5816 5816
 					array_pop($stack);
5817 5817
 
5818 5818
 					// Go to terminal state if we're at the end of the root array.
5819 5819
 					array_pop($expected);
5820 5820
 
5821
-					if(count($expected) == 0)
5821
+					if (count($expected) == 0)
5822 5822
 						$state = 1;
5823 5823
 
5824 5824
 					break;
5825 5825
 				}
5826 5826
 
5827
-				if($type == 'i' || $type == 's')
5827
+				if ($type == 'i' || $type == 's')
5828 5828
 				{
5829 5829
 					// Array size exceeds expected length.
5830
-					if(count($list) >= end($expected))
5830
+					if (count($list) >= end($expected))
5831 5831
 						return false;
5832 5832
 
5833 5833
 					$key = $value;
@@ -5840,7 +5840,7 @@  discard block
 block discarded – undo
5840 5840
 
5841 5841
 			// Expecting array or value.
5842 5842
 			case 0:
5843
-				if($type == 'a')
5843
+				if ($type == 'a')
5844 5844
 				{
5845 5845
 					$data = array();
5846 5846
 					$list = &$data;
@@ -5849,7 +5849,7 @@  discard block
 block discarded – undo
5849 5849
 					break;
5850 5850
 				}
5851 5851
 
5852
-				if($type != '}')
5852
+				if ($type != '}')
5853 5853
 				{
5854 5854
 					$data = $value;
5855 5855
 					$state = 1;
@@ -5862,7 +5862,7 @@  discard block
 block discarded – undo
5862 5862
 	}
5863 5863
 
5864 5864
 	// Trailing data in input.
5865
-	if(!empty($str))
5865
+	if (!empty($str))
5866 5866
 		return false;
5867 5867
 
5868 5868
 	return $data;
@@ -5916,7 +5916,7 @@  discard block
 block discarded – undo
5916 5916
 	// Set different modes.
5917 5917
 	$chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666);
5918 5918
 
5919
-	foreach($chmodValues as $val)
5919
+	foreach ($chmodValues as $val)
5920 5920
 	{
5921 5921
 		// If it's writable, break out of the loop.
5922 5922
 		if (is_writable($file))
@@ -5951,13 +5951,13 @@  discard block
 block discarded – undo
5951 5951
 	$returnArray = @json_decode($json, $returnAsArray);
5952 5952
 
5953 5953
 	// PHP 5.3 so no json_last_error_msg()
5954
-	switch(json_last_error())
5954
+	switch (json_last_error())
5955 5955
 	{
5956 5956
 		case JSON_ERROR_NONE:
5957 5957
 			$jsonError = false;
5958 5958
 			break;
5959 5959
 		case JSON_ERROR_DEPTH:
5960
-			$jsonError =  'JSON_ERROR_DEPTH';
5960
+			$jsonError = 'JSON_ERROR_DEPTH';
5961 5961
 			break;
5962 5962
 		case JSON_ERROR_STATE_MISMATCH:
5963 5963
 			$jsonError = 'JSON_ERROR_STATE_MISMATCH';
@@ -5985,10 +5985,10 @@  discard block
 block discarded – undo
5985 5985
 		loadLanguage('Errors');
5986 5986
 
5987 5987
 		if (!empty($jsonDebug))
5988
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5988
+			log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5989 5989
 
5990 5990
 		else
5991
-			log_error($txt['json_'. $jsonError], 'critical');
5991
+			log_error($txt['json_' . $jsonError], 'critical');
5992 5992
 
5993 5993
 		// Everyone expects an array.
5994 5994
 		return array();
@@ -6105,7 +6105,7 @@  discard block
 block discarded – undo
6105 6105
 		// Convert Punycode to Unicode
6106 6106
 		require_once($sourcedir . '/Class-Punycode.php');
6107 6107
 		$Punycode = new Punycode();
6108
-		$tlds = array_map(function ($input) use ($Punycode) { return $Punycode->decode($input); }, $tlds);
6108
+		$tlds = array_map(function($input) use ($Punycode) { return $Punycode->decode($input); }, $tlds);
6109 6109
 	}
6110 6110
 	// Otherwise, use the 2012 list of gTLDs and ccTLDs for now and schedule a background update
6111 6111
 	else
@@ -6199,7 +6199,7 @@  discard block
 block discarded – undo
6199 6199
 	}
6200 6200
 
6201 6201
 	// This recursive function creates the index array from the strings
6202
-	$add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
6202
+	$add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
6203 6203
 	{
6204 6204
 		static $depth = 0;
6205 6205
 		$depth++;
@@ -6226,7 +6226,7 @@  discard block
 block discarded – undo
6226 6226
 	};
6227 6227
 
6228 6228
 	// This recursive function turns the index array into a regular expression
6229
-	$index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex)
6229
+	$index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex)
6230 6230
 	{
6231 6231
 		static $depth = 0;
6232 6232
 		$depth++;
@@ -6250,11 +6250,11 @@  discard block
 block discarded – undo
6250 6250
 
6251 6251
 				if (count(array_keys($value)) == 1)
6252 6252
 				{
6253
-					$new_key_array = explode('(?'.'>', $sub_regex);
6253
+					$new_key_array = explode('(?' . '>', $sub_regex);
6254 6254
 					$new_key .= $new_key_array[0];
6255 6255
 				}
6256 6256
 				else
6257
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
6257
+					$sub_regex = '(?' . '>' . $sub_regex . ')';
6258 6258
 			}
6259 6259
 
6260 6260
 			if ($depth > 1)
@@ -6297,10 +6297,10 @@  discard block
 block discarded – undo
6297 6297
 	{
6298 6298
 		$regex = array();
6299 6299
 		while (!empty($index))
6300
-			$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6300
+			$regex[] = '(?' . '>' . $index_to_regex($index, $delim) . ')';
6301 6301
 	}
6302 6302
 	else
6303
-		$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6303
+		$regex = '(?' . '>' . $index_to_regex($index, $delim) . ')';
6304 6304
 
6305 6305
 	// Restore PHP's internal character encoding to whatever it was originally
6306 6306
 	if (!empty($current_encoding))
@@ -6524,7 +6524,7 @@  discard block
 block discarded – undo
6524 6524
 function sanitize_iri($iri)
6525 6525
 {
6526 6526
 	// Encode any non-ASCII characters (but not space or control characters of any sort)
6527
-	$iri = preg_replace_callback('~[^\x00-\x7F\pZ\pC]~u', function ($matches) {
6527
+	$iri = preg_replace_callback('~[^\x00-\x7F\pZ\pC]~u', function($matches) {
6528 6528
 		return rawurlencode($matches[0]);
6529 6529
 	}, $iri);
6530 6530
 
@@ -6566,7 +6566,7 @@  discard block
 block discarded – undo
6566 6566
 	$unescaped = array(
6567 6567
 		'%21'=>'!', '%23'=>'#', '%24'=>'$', '%26'=>'&',
6568 6568
 		'%27'=>"'", '%28'=>'(', '%29'=>')', '%2A'=>'*',
6569
-		'%2B'=>'+', '%2C'=>',',	'%2F'=>'/', '%3A'=>':',
6569
+		'%2B'=>'+', '%2C'=>',', '%2F'=>'/', '%3A'=>':',
6570 6570
 		'%3B'=>';', '%3D'=>'=', '%3F'=>'?', '%40'=>'@',
6571 6571
 	);
6572 6572
 	$iri = strtr(rawurlencode($iri), $unescaped);
Please login to merge, or discard this patch.
Braces   +1477 added lines, -1105 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Update some basic statistics.
@@ -122,10 +123,11 @@  discard block
 block discarded – undo
122 123
 						$smcFunc['db_free_result']($result);
123 124
 
124 125
 						// Add this to the number of unapproved members
125
-						if (!empty($changes['unapprovedMembers']))
126
-							$changes['unapprovedMembers'] += $coppa_approvals;
127
-						else
128
-							$changes['unapprovedMembers'] = $coppa_approvals;
126
+						if (!empty($changes['unapprovedMembers'])) {
127
+													$changes['unapprovedMembers'] += $coppa_approvals;
128
+						} else {
129
+													$changes['unapprovedMembers'] = $coppa_approvals;
130
+						}
129 131
 					}
130 132
 				}
131 133
 			}
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 			break;
134 136
 
135 137
 		case 'message':
136
-			if ($parameter1 === true && $parameter2 !== null)
137
-				updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
138
-			else
138
+			if ($parameter1 === true && $parameter2 !== null) {
139
+							updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
140
+			} else
139 141
 			{
140 142
 				// SUM and MAX on a smaller table is better for InnoDB tables.
141 143
 				$result = $smcFunc['db_query']('', '
@@ -175,24 +177,25 @@  discard block
 block discarded – undo
175 177
 				$parameter2 = text2words($parameter2);
176 178
 
177 179
 				$inserts = array();
178
-				foreach ($parameter2 as $word)
179
-					$inserts[] = array($word, $parameter1);
180
+				foreach ($parameter2 as $word) {
181
+									$inserts[] = array($word, $parameter1);
182
+				}
180 183
 
181
-				if (!empty($inserts))
182
-					$smcFunc['db_insert']('ignore',
184
+				if (!empty($inserts)) {
185
+									$smcFunc['db_insert']('ignore',
183 186
 						'{db_prefix}log_search_subjects',
184 187
 						array('word' => 'string', 'id_topic' => 'int'),
185 188
 						$inserts,
186 189
 						array('word', 'id_topic')
187 190
 					);
191
+				}
188 192
 			}
189 193
 			break;
190 194
 
191 195
 		case 'topic':
192
-			if ($parameter1 === true)
193
-				updateSettings(array('totalTopics' => true), true);
194
-
195
-			else
196
+			if ($parameter1 === true) {
197
+							updateSettings(array('totalTopics' => true), true);
198
+			} else
196 199
 			{
197 200
 				// Get the number of topics - a SUM is better for InnoDB tables.
198 201
 				// We also ignore the recycle bin here because there will probably be a bunch of one-post topics there.
@@ -213,8 +216,9 @@  discard block
 block discarded – undo
213 216
 
214 217
 		case 'postgroups':
215 218
 			// Parameter two is the updated columns: we should check to see if we base groups off any of these.
216
-			if ($parameter2 !== null && !in_array('posts', $parameter2))
217
-				return;
219
+			if ($parameter2 !== null && !in_array('posts', $parameter2)) {
220
+							return;
221
+			}
218 222
 
219 223
 			$postgroups = cache_get_data('updateStats:postgroups', 360);
220 224
 			if ($postgroups == null || $parameter1 == null)
@@ -229,8 +233,9 @@  discard block
 block discarded – undo
229 233
 					)
230 234
 				);
231 235
 				$postgroups = array();
232
-				while ($row = $smcFunc['db_fetch_assoc']($request))
233
-					$postgroups[$row['id_group']] = $row['min_posts'];
236
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
237
+									$postgroups[$row['id_group']] = $row['min_posts'];
238
+				}
234 239
 
235 240
 				$smcFunc['db_free_result']($request);
236 241
 
@@ -241,8 +246,9 @@  discard block
 block discarded – undo
241 246
 			}
242 247
 
243 248
 			// Oh great, they've screwed their post groups.
244
-			if (empty($postgroups))
245
-				return;
249
+			if (empty($postgroups)) {
250
+							return;
251
+			}
246 252
 
247 253
 			// Set all membergroups from most posts to least posts.
248 254
 			$conditions = '';
@@ -301,12 +307,9 @@  discard block
 block discarded – undo
301 307
 	{
302 308
 		$condition = 'id_member IN ({array_int:members})';
303 309
 		$parameters['members'] = $members;
304
-	}
305
-
306
-	elseif ($members === null)
307
-		$condition = '1=1';
308
-
309
-	else
310
+	} elseif ($members === null) {
311
+			$condition = '1=1';
312
+	} else
310 313
 	{
311 314
 		$condition = 'id_member = {int:member}';
312 315
 		$parameters['member'] = $members;
@@ -346,9 +349,9 @@  discard block
 block discarded – undo
346 349
 		if (count($vars_to_integrate) != 0)
347 350
 		{
348 351
 			// Fetch a list of member_names if necessary
349
-			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members)))
350
-				$member_names = array($user_info['username']);
351
-			else
352
+			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) {
353
+							$member_names = array($user_info['username']);
354
+			} else
352 355
 			{
353 356
 				$member_names = array();
354 357
 				$request = $smcFunc['db_query']('', '
@@ -357,14 +360,16 @@  discard block
 block discarded – undo
357 360
 					WHERE ' . $condition,
358 361
 					$parameters
359 362
 				);
360
-				while ($row = $smcFunc['db_fetch_assoc']($request))
361
-					$member_names[] = $row['member_name'];
363
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
364
+									$member_names[] = $row['member_name'];
365
+				}
362 366
 				$smcFunc['db_free_result']($request);
363 367
 			}
364 368
 
365
-			if (!empty($member_names))
366
-				foreach ($vars_to_integrate as $var)
369
+			if (!empty($member_names)) {
370
+							foreach ($vars_to_integrate as $var)
367 371
 					call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats));
372
+			}
368 373
 		}
369 374
 	}
370 375
 
@@ -372,16 +377,17 @@  discard block
 block discarded – undo
372 377
 	foreach ($data as $var => $val)
373 378
 	{
374 379
 		$type = 'string';
375
-		if (in_array($var, $knownInts))
376
-			$type = 'int';
377
-		elseif (in_array($var, $knownFloats))
378
-			$type = 'float';
379
-		elseif ($var == 'birthdate')
380
-			$type = 'date';
381
-		elseif ($var == 'member_ip')
382
-			$type = 'inet';
383
-		elseif ($var == 'member_ip2')
384
-			$type = 'inet';
380
+		if (in_array($var, $knownInts)) {
381
+					$type = 'int';
382
+		} elseif (in_array($var, $knownFloats)) {
383
+					$type = 'float';
384
+		} elseif ($var == 'birthdate') {
385
+					$type = 'date';
386
+		} elseif ($var == 'member_ip') {
387
+					$type = 'inet';
388
+		} elseif ($var == 'member_ip2') {
389
+					$type = 'inet';
390
+		}
385 391
 
386 392
 		// Doing an increment?
387 393
 		if ($var == 'alerts' && ($val === '+' || $val === '-'))
@@ -390,18 +396,17 @@  discard block
 block discarded – undo
390 396
 			if (is_array($members))
391 397
 			{
392 398
 				$val = 'CASE ';
393
-				foreach ($members as $k => $v)
394
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' ';
399
+				foreach ($members as $k => $v) {
400
+									$val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' ';
401
+				}
395 402
 				$val = $val . ' END';
396 403
 				$type = 'raw';
397
-			}
398
-			else
404
+			} else
399 405
 			{
400 406
 				$blub = fetch_alerts($members, false, 0, array(), false);
401 407
 				$val = count($blub);
402 408
 			}
403
-		}
404
-		else if ($type == 'int' && ($val === '+' || $val === '-'))
409
+		} else if ($type == 'int' && ($val === '+' || $val === '-'))
405 410
 		{
406 411
 			$val = $var . ' ' . $val . ' 1';
407 412
 			$type = 'raw';
@@ -412,8 +417,9 @@  discard block
 block discarded – undo
412 417
 		{
413 418
 			if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match))
414 419
 			{
415
-				if ($match[1] != '+ ')
416
-					$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
420
+				if ($match[1] != '+ ') {
421
+									$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
422
+				}
417 423
 				$type = 'raw';
418 424
 			}
419 425
 		}
@@ -434,8 +440,9 @@  discard block
 block discarded – undo
434 440
 	// Clear any caching?
435 441
 	if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members))
436 442
 	{
437
-		if (!is_array($members))
438
-			$members = array($members);
443
+		if (!is_array($members)) {
444
+					$members = array($members);
445
+		}
439 446
 
440 447
 		foreach ($members as $member)
441 448
 		{
@@ -468,29 +475,32 @@  discard block
 block discarded – undo
468 475
 {
469 476
 	global $modSettings, $smcFunc;
470 477
 
471
-	if (empty($changeArray) || !is_array($changeArray))
472
-		return;
478
+	if (empty($changeArray) || !is_array($changeArray)) {
479
+			return;
480
+	}
473 481
 
474 482
 	$toRemove = array();
475 483
 
476 484
 	// Go check if there is any setting to be removed.
477
-	foreach ($changeArray as $k => $v)
478
-		if ($v === null)
485
+	foreach ($changeArray as $k => $v) {
486
+			if ($v === null)
479 487
 		{
480 488
 			// Found some, remove them from the original array and add them to ours.
481 489
 			unset($changeArray[$k]);
490
+	}
482 491
 			$toRemove[] = $k;
483 492
 		}
484 493
 
485 494
 	// Proceed with the deletion.
486
-	if (!empty($toRemove))
487
-		$smcFunc['db_query']('', '
495
+	if (!empty($toRemove)) {
496
+			$smcFunc['db_query']('', '
488 497
 			DELETE FROM {db_prefix}settings
489 498
 			WHERE variable IN ({array_string:remove})',
490 499
 			array(
491 500
 				'remove' => $toRemove,
492 501
 			)
493 502
 		);
503
+	}
494 504
 
495 505
 	// In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs.
496 506
 	if ($update)
@@ -519,19 +529,22 @@  discard block
 block discarded – undo
519 529
 	foreach ($changeArray as $variable => $value)
520 530
 	{
521 531
 		// Don't bother if it's already like that ;).
522
-		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value)
523
-			continue;
532
+		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) {
533
+					continue;
534
+		}
524 535
 		// If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it.
525
-		elseif (!isset($modSettings[$variable]) && empty($value))
526
-			continue;
536
+		elseif (!isset($modSettings[$variable]) && empty($value)) {
537
+					continue;
538
+		}
527 539
 
528 540
 		$replaceArray[] = array($variable, $value);
529 541
 
530 542
 		$modSettings[$variable] = $value;
531 543
 	}
532 544
 
533
-	if (empty($replaceArray))
534
-		return;
545
+	if (empty($replaceArray)) {
546
+			return;
547
+	}
535 548
 
536 549
 	$smcFunc['db_insert']('replace',
537 550
 		'{db_prefix}settings',
@@ -577,14 +590,17 @@  discard block
 block discarded – undo
577 590
 	$start_invalid = $start < 0;
578 591
 
579 592
 	// Make sure $start is a proper variable - not less than 0.
580
-	if ($start_invalid)
581
-		$start = 0;
593
+	if ($start_invalid) {
594
+			$start = 0;
595
+	}
582 596
 	// Not greater than the upper bound.
583
-	elseif ($start >= $max_value)
584
-		$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
597
+	elseif ($start >= $max_value) {
598
+			$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
599
+	}
585 600
 	// And it has to be a multiple of $num_per_page!
586
-	else
587
-		$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
601
+	else {
602
+			$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
603
+	}
588 604
 
589 605
 	$context['current_page'] = $start / $num_per_page;
590 606
 
@@ -614,77 +630,87 @@  discard block
 block discarded – undo
614 630
 
615 631
 		// Show all the pages.
616 632
 		$display_page = 1;
617
-		for ($counter = 0; $counter < $max_value; $counter += $num_per_page)
618
-			$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
633
+		for ($counter = 0; $counter < $max_value; $counter += $num_per_page) {
634
+					$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
635
+		}
619 636
 
620 637
 		// Show the right arrow.
621 638
 		$display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page);
622
-		if ($start != $counter - $max_value && !$start_invalid)
623
-			$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
624
-	}
625
-	else
639
+		if ($start != $counter - $max_value && !$start_invalid) {
640
+					$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
641
+		}
642
+	} else
626 643
 	{
627 644
 		// If they didn't enter an odd value, pretend they did.
628 645
 		$PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2;
629 646
 
630 647
 		// Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page)
631
-		if (!empty($start) && $show_prevnext)
632
-			$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
633
-		else
634
-			$pageindex .= '';
648
+		if (!empty($start) && $show_prevnext) {
649
+					$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
650
+		} else {
651
+					$pageindex .= '';
652
+		}
635 653
 
636 654
 		// Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15)
637
-		if ($start > $num_per_page * $PageContiguous)
638
-			$pageindex .= sprintf($base_link, 0, '1');
655
+		if ($start > $num_per_page * $PageContiguous) {
656
+					$pageindex .= sprintf($base_link, 0, '1');
657
+		}
639 658
 
640 659
 		// Show the ... after the first page.  (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page)
641
-		if ($start > $num_per_page * ($PageContiguous + 1))
642
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
660
+		if ($start > $num_per_page * ($PageContiguous + 1)) {
661
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
643 662
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
644 663
 				'{FIRST_PAGE}' => $num_per_page,
645 664
 				'{LAST_PAGE}' => $start - $num_per_page * $PageContiguous,
646 665
 				'{PER_PAGE}' => $num_per_page,
647 666
 			));
667
+		}
648 668
 
649 669
 		// Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page)
650
-		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--)
651
-			if ($start >= $num_per_page * $nCont)
670
+		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) {
671
+					if ($start >= $num_per_page * $nCont)
652 672
 			{
653 673
 				$tmpStart = $start - $num_per_page * $nCont;
674
+		}
654 675
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
655 676
 			}
656 677
 
657 678
 		// Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page)
658
-		if (!$start_invalid)
659
-			$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
660
-		else
661
-			$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
679
+		if (!$start_invalid) {
680
+					$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
681
+		} else {
682
+					$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
683
+		}
662 684
 
663 685
 		// Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page)
664 686
 		$tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page;
665
-		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++)
666
-			if ($start + $num_per_page * $nCont <= $tmpMaxPages)
687
+		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) {
688
+					if ($start + $num_per_page * $nCont <= $tmpMaxPages)
667 689
 			{
668 690
 				$tmpStart = $start + $num_per_page * $nCont;
691
+		}
669 692
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
670 693
 			}
671 694
 
672 695
 		// Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page)
673
-		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages)
674
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
696
+		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) {
697
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
675 698
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
676 699
 				'{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1),
677 700
 				'{LAST_PAGE}' => $tmpMaxPages,
678 701
 				'{PER_PAGE}' => $num_per_page,
679 702
 			));
703
+		}
680 704
 
681 705
 		// Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15<  next page)
682
-		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages)
683
-			$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
706
+		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) {
707
+					$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
708
+		}
684 709
 
685 710
 		// Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<)
686
-		if ($start != $tmpMaxPages && $show_prevnext)
687
-			$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
711
+		if ($start != $tmpMaxPages && $show_prevnext) {
712
+					$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
713
+		}
688 714
 	}
689 715
 	$pageindex .= $settings['page_index']['extra_after'];
690 716
 
@@ -710,8 +736,9 @@  discard block
 block discarded – undo
710 736
 	if ($decimal_separator === null)
711 737
 	{
712 738
 		// Not set for whatever reason?
713
-		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1)
714
-			return $number;
739
+		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) {
740
+					return $number;
741
+		}
715 742
 
716 743
 		// Cache these each load...
717 744
 		$thousands_separator = $matches[1];
@@ -752,17 +779,20 @@  discard block
 block discarded – undo
752 779
 	$user_info['time_format'] = !empty($user_info['time_format']) ? $user_info['time_format'] : (!empty($modSettings['time_format']) ? $modSettings['time_format'] : '%F %H:%M');
753 780
 
754 781
 	// Offset the time.
755
-	if (!$offset_type)
756
-		$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
782
+	if (!$offset_type) {
783
+			$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
784
+	}
757 785
 	// Just the forum offset?
758
-	elseif ($offset_type == 'forum')
759
-		$time = $log_time + $modSettings['time_offset'] * 3600;
760
-	else
761
-		$time = $log_time;
786
+	elseif ($offset_type == 'forum') {
787
+			$time = $log_time + $modSettings['time_offset'] * 3600;
788
+	} else {
789
+			$time = $log_time;
790
+	}
762 791
 
763 792
 	// We can't have a negative date (on Windows, at least.)
764
-	if ($log_time < 0)
765
-		$log_time = 0;
793
+	if ($log_time < 0) {
794
+			$log_time = 0;
795
+	}
766 796
 
767 797
 	// Today and Yesterday?
768 798
 	if ($modSettings['todayMod'] >= 1 && $show_today === true)
@@ -779,24 +809,27 @@  discard block
 block discarded – undo
779 809
 		{
780 810
 			$h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l';
781 811
 			$today_fmt = $h . ':%M' . $s . ' %p';
812
+		} else {
813
+					$today_fmt = '%H:%M' . $s;
782 814
 		}
783
-		else
784
-			$today_fmt = '%H:%M' . $s;
785 815
 
786 816
 		// Same day of the year, same year.... Today!
787
-		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year'])
788
-			return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
817
+		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) {
818
+					return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
819
+		}
789 820
 
790 821
 		// Day-of-year is one less and same year, or it's the first of the year and that's the last of the year...
791
-		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31))
792
-			return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
822
+		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) {
823
+					return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
824
+		}
793 825
 	}
794 826
 
795 827
 	$str = !is_bool($show_today) ? $show_today : $user_info['time_format'];
796 828
 
797 829
 	// Use the cached formats if available
798
-	if (is_null($finalizedFormats))
799
-		$finalizedFormats = (array) cache_get_data('timeformatstrings', 86400);
830
+	if (is_null($finalizedFormats)) {
831
+			$finalizedFormats = (array) cache_get_data('timeformatstrings', 86400);
832
+	}
800 833
 
801 834
 	// Make a supported version for this format if we don't already have one
802 835
 	if (empty($finalizedFormats[$str]))
@@ -825,8 +858,9 @@  discard block
 block discarded – undo
825 858
 		);
826 859
 
827 860
 		// No need to do this part again if we already did it once
828
-		if (is_null($unsupportedFormats))
829
-			$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
861
+		if (is_null($unsupportedFormats)) {
862
+					$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
863
+		}
830 864
 		if (empty($unsupportedFormats))
831 865
 		{
832 866
 			foreach($strftimeFormatSubstitutions as $format => $substitution)
@@ -842,20 +876,23 @@  discard block
 block discarded – undo
842 876
 
843 877
 				// Windows will return false for unsupported formats
844 878
 				// Other operating systems return the format string as a literal
845
-				if ($value === false || $value === $format)
846
-					$unsupportedFormats[] = $format;
879
+				if ($value === false || $value === $format) {
880
+									$unsupportedFormats[] = $format;
881
+				}
847 882
 			}
848 883
 			cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400);
849 884
 		}
850 885
 
851 886
 		// Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q'
852
-		if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN')
853
-			$timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '&#37;', $timeformat);
887
+		if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
888
+					$timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '&#37;', $timeformat);
889
+		}
854 890
 
855 891
 		// Substitute unsupported formats with supported ones
856
-		if (!empty($unsupportedFormats))
857
-			while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches))
892
+		if (!empty($unsupportedFormats)) {
893
+					while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches))
858 894
 				$timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat);
895
+		}
859 896
 
860 897
 		// Remember this so we don't need to do it again
861 898
 		$finalizedFormats[$str] = $timeformat;
@@ -864,33 +901,39 @@  discard block
 block discarded – undo
864 901
 
865 902
 	$str = $finalizedFormats[$str];
866 903
 
867
-	if (!isset($locale_cache))
868
-		$locale_cache = setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : '');
904
+	if (!isset($locale_cache)) {
905
+			$locale_cache = setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : '');
906
+	}
869 907
 
870 908
 	if ($locale_cache !== false)
871 909
 	{
872 910
 		// Check if another process changed the locale
873
-		if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache)
874
-			setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : '');
911
+		if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) {
912
+					setlocale(LC_TIME, $txt['lang_locale'] . !empty($modSettings['global_character_set']) ? '.' . $modSettings['global_character_set'] : '');
913
+		}
875 914
 
876
-		if (!isset($non_twelve_hour))
877
-			$non_twelve_hour = trim(strftime('%p')) === '';
878
-		if ($non_twelve_hour && strpos($str, '%p') !== false)
879
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
915
+		if (!isset($non_twelve_hour)) {
916
+					$non_twelve_hour = trim(strftime('%p')) === '';
917
+		}
918
+		if ($non_twelve_hour && strpos($str, '%p') !== false) {
919
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
920
+		}
880 921
 
881
-		foreach (array('%a', '%A', '%b', '%B') as $token)
882
-			if (strpos($str, $token) !== false)
922
+		foreach (array('%a', '%A', '%b', '%B') as $token) {
923
+					if (strpos($str, $token) !== false)
883 924
 				$str = str_replace($token, strftime($token, $time), $str);
884
-	}
885
-	else
925
+		}
926
+	} else
886 927
 	{
887 928
 		// Do-it-yourself time localization.  Fun.
888
-		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label)
889
-			if (strpos($str, $token) !== false)
929
+		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) {
930
+					if (strpos($str, $token) !== false)
890 931
 				$str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str);
932
+		}
891 933
 
892
-		if (strpos($str, '%p') !== false)
893
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
934
+		if (strpos($str, '%p') !== false) {
935
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
936
+		}
894 937
 	}
895 938
 
896 939
 	// Format the time and then restore any literal percent characters
@@ -913,16 +956,19 @@  discard block
 block discarded – undo
913 956
 	static $translation = array();
914 957
 
915 958
 	// Determine the character set... Default to UTF-8
916
-	if (empty($context['character_set']))
917
-		$charset = 'UTF-8';
959
+	if (empty($context['character_set'])) {
960
+			$charset = 'UTF-8';
961
+	}
918 962
 	// Use ISO-8859-1 in place of non-supported ISO-8859 charsets...
919
-	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15')))
920
-		$charset = 'ISO-8859-1';
921
-	else
922
-		$charset = $context['character_set'];
963
+	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) {
964
+			$charset = 'ISO-8859-1';
965
+	} else {
966
+			$charset = $context['character_set'];
967
+	}
923 968
 
924
-	if (empty($translation))
925
-		$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
969
+	if (empty($translation)) {
970
+			$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
971
+	}
926 972
 
927 973
 	return strtr($string, $translation);
928 974
 }
@@ -944,8 +990,9 @@  discard block
 block discarded – undo
944 990
 	global $smcFunc;
945 991
 
946 992
 	// It was already short enough!
947
-	if ($smcFunc['strlen']($subject) <= $len)
948
-		return $subject;
993
+	if ($smcFunc['strlen']($subject) <= $len) {
994
+			return $subject;
995
+	}
949 996
 
950 997
 	// Shorten it by the length it was too long, and strip off junk from the end.
951 998
 	return $smcFunc['substr']($subject, 0, $len) . '...';
@@ -964,10 +1011,11 @@  discard block
 block discarded – undo
964 1011
 {
965 1012
 	global $user_info, $modSettings;
966 1013
 
967
-	if ($timestamp === null)
968
-		$timestamp = time();
969
-	elseif ($timestamp == 0)
970
-		return 0;
1014
+	if ($timestamp === null) {
1015
+			$timestamp = time();
1016
+	} elseif ($timestamp == 0) {
1017
+			return 0;
1018
+	}
971 1019
 
972 1020
 	return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600;
973 1021
 }
@@ -996,8 +1044,9 @@  discard block
 block discarded – undo
996 1044
 		$array[$i] = $array[$j];
997 1045
 		$array[$j] = $temp;
998 1046
 
999
-		for ($i = 1; $p[$i] == 0; $i++)
1000
-			$p[$i] = 1;
1047
+		for ($i = 1; $p[$i] == 0; $i++) {
1048
+					$p[$i] = 1;
1049
+		}
1001 1050
 
1002 1051
 		$orders[] = $array;
1003 1052
 	}
@@ -1029,12 +1078,14 @@  discard block
 block discarded – undo
1029 1078
 	static $disabled;
1030 1079
 
1031 1080
 	// Don't waste cycles
1032
-	if ($message === '')
1033
-		return '';
1081
+	if ($message === '') {
1082
+			return '';
1083
+	}
1034 1084
 
1035 1085
 	// Just in case it wasn't determined yet whether UTF-8 is enabled.
1036
-	if (!isset($context['utf8']))
1037
-		$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
1086
+	if (!isset($context['utf8'])) {
1087
+			$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
1088
+	}
1038 1089
 
1039 1090
 	// Clean up any cut/paste issues we may have
1040 1091
 	$message = sanitizeMSCutPaste($message);
@@ -1046,13 +1097,15 @@  discard block
 block discarded – undo
1046 1097
 		return $message;
1047 1098
 	}
1048 1099
 
1049
-	if ($smileys !== null && ($smileys == '1' || $smileys == '0'))
1050
-		$smileys = (bool) $smileys;
1100
+	if ($smileys !== null && ($smileys == '1' || $smileys == '0')) {
1101
+			$smileys = (bool) $smileys;
1102
+	}
1051 1103
 
1052 1104
 	if (empty($modSettings['enableBBC']) && $message !== false)
1053 1105
 	{
1054
-		if ($smileys === true)
1055
-			parsesmileys($message);
1106
+		if ($smileys === true) {
1107
+					parsesmileys($message);
1108
+		}
1056 1109
 
1057 1110
 		return $message;
1058 1111
 	}
@@ -1065,8 +1118,9 @@  discard block
 block discarded – undo
1065 1118
 	}
1066 1119
 
1067 1120
 	// Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker
1068
-	if (!empty($modSettings['autoLinkUrls']))
1069
-		set_tld_regex();
1121
+	if (!empty($modSettings['autoLinkUrls'])) {
1122
+			set_tld_regex();
1123
+	}
1070 1124
 
1071 1125
 	// Allow mods access before entering the main parse_bbc loop
1072 1126
 	call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
@@ -1080,8 +1134,9 @@  discard block
 block discarded – undo
1080 1134
 
1081 1135
 			$temp = explode(',', strtolower($modSettings['disabledBBC']));
1082 1136
 
1083
-			foreach ($temp as $tag)
1084
-				$disabled[trim($tag)] = true;
1137
+			foreach ($temp as $tag) {
1138
+							$disabled[trim($tag)] = true;
1139
+			}
1085 1140
 		}
1086 1141
 
1087 1142
 		/* The following bbc are formatted as an array, with keys as follows:
@@ -1211,8 +1266,9 @@  discard block
 block discarded – undo
1211 1266
 					$returnContext = '';
1212 1267
 
1213 1268
 					// BBC or the entire attachments feature is disabled
1214
-					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach']))
1215
-						return $data;
1269
+					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) {
1270
+											return $data;
1271
+					}
1216 1272
 
1217 1273
 					// Save the attach ID.
1218 1274
 					$attachID = $data;
@@ -1223,8 +1279,9 @@  discard block
 block discarded – undo
1223 1279
 					$currentAttachment = parseAttachBBC($attachID);
1224 1280
 
1225 1281
 					// parseAttachBBC will return a string ($txt key) rather than dying with a fatal_error. Up to you to decide what to do.
1226
-					if (is_string($currentAttachment))
1227
-						return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1282
+					if (is_string($currentAttachment)) {
1283
+											return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1284
+					}
1228 1285
 
1229 1286
 					if (!empty($currentAttachment['is_image']))
1230 1287
 					{
@@ -1240,15 +1297,17 @@  discard block
 block discarded – undo
1240 1297
 							$height = ' height="' . $currentAttachment['height'] . '"';
1241 1298
 						}
1242 1299
 
1243
-						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1244
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1245
-						else
1246
-							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1300
+						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) {
1301
+													$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1302
+						} else {
1303
+													$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1304
+						}
1247 1305
 					}
1248 1306
 
1249 1307
 					// No image. Show a link.
1250
-					else
1251
-						$returnContext .= $currentAttachment['link'];
1308
+					else {
1309
+											$returnContext .= $currentAttachment['link'];
1310
+					}
1252 1311
 
1253 1312
 					// Gotta append what we just did.
1254 1313
 					$data = $returnContext;
@@ -1302,8 +1361,9 @@  discard block
 block discarded – undo
1302 1361
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1303 1362
 						{
1304 1363
 							// Do PHP code coloring?
1305
-							if ($php_parts[$php_i] != '&lt;?php')
1306
-								continue;
1364
+							if ($php_parts[$php_i] != '&lt;?php') {
1365
+															continue;
1366
+							}
1307 1367
 
1308 1368
 							$php_string = '';
1309 1369
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1319,8 +1379,9 @@  discard block
 block discarded – undo
1319 1379
 						$data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data);
1320 1380
 
1321 1381
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1322
-						if ($context['browser']['is_opera'])
1323
-							$data .= '&nbsp;';
1382
+						if ($context['browser']['is_opera']) {
1383
+													$data .= '&nbsp;';
1384
+						}
1324 1385
 					}
1325 1386
 				},
1326 1387
 				'block_level' => true,
@@ -1339,8 +1400,9 @@  discard block
 block discarded – undo
1339 1400
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1340 1401
 						{
1341 1402
 							// Do PHP code coloring?
1342
-							if ($php_parts[$php_i] != '&lt;?php')
1343
-								continue;
1403
+							if ($php_parts[$php_i] != '&lt;?php') {
1404
+															continue;
1405
+							}
1344 1406
 
1345 1407
 							$php_string = '';
1346 1408
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1356,8 +1418,9 @@  discard block
 block discarded – undo
1356 1418
 						$data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]);
1357 1419
 
1358 1420
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1359
-						if ($context['browser']['is_opera'])
1360
-							$data[0] .= '&nbsp;';
1421
+						if ($context['browser']['is_opera']) {
1422
+													$data[0] .= '&nbsp;';
1423
+						}
1361 1424
 					}
1362 1425
 				},
1363 1426
 				'block_level' => true,
@@ -1398,10 +1461,11 @@  discard block
 block discarded – undo
1398 1461
 				{
1399 1462
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1400 1463
 
1401
-					if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches))
1402
-						$css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"';
1403
-					else
1404
-						$css = '';
1464
+					if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) {
1465
+											$css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"';
1466
+					} else {
1467
+											$css = '';
1468
+					}
1405 1469
 
1406 1470
 					$data = $class . $css;
1407 1471
 				},
@@ -1416,8 +1480,9 @@  discard block
 block discarded – undo
1416 1480
 				{
1417 1481
 					$data = strtr($data, array('<br />' => ''));
1418 1482
 
1419
-					if (strpos($data, 'ftp://') !== 0 && strpos($data, 'ftps://') !== 0)
1420
-						$data = 'ftp://' . $data;
1483
+					if (strpos($data, 'ftp://') !== 0 && strpos($data, 'ftps://') !== 0) {
1484
+											$data = 'ftp://' . $data;
1485
+					}
1421 1486
 				},
1422 1487
 			),
1423 1488
 			array(
@@ -1427,8 +1492,9 @@  discard block
 block discarded – undo
1427 1492
 				'after' => '</a>',
1428 1493
 				'validate' => function(&$tag, &$data, $disabled)
1429 1494
 				{
1430
-					if (strpos($data, 'ftp://') !== 0 && strpos($data, 'ftps://') !== 0)
1431
-						$data = 'ftp://' . $data;
1495
+					if (strpos($data, 'ftp://') !== 0 && strpos($data, 'ftps://') !== 0) {
1496
+											$data = 'ftp://' . $data;
1497
+					}
1432 1498
 				},
1433 1499
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
1434 1500
 				'disabled_after' => ' ($1)',
@@ -1488,17 +1554,20 @@  discard block
 block discarded – undo
1488 1554
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1489 1555
 					if ($image_proxy_enabled)
1490 1556
 					{
1491
-						if (!empty($user_info['possibly_robot']))
1492
-							return;
1557
+						if (!empty($user_info['possibly_robot'])) {
1558
+													return;
1559
+						}
1493 1560
 
1494
-						if (empty($scheme))
1495
-							$data = 'http://' . ltrim($data, ':/');
1561
+						if (empty($scheme)) {
1562
+													$data = 'http://' . ltrim($data, ':/');
1563
+						}
1496 1564
 
1497
-						if ($scheme != 'https')
1498
-							$data = get_proxied_url($data);
1565
+						if ($scheme != 'https') {
1566
+													$data = get_proxied_url($data);
1567
+						}
1568
+					} elseif (empty($scheme)) {
1569
+											$data = '//' . ltrim($data, ':/');
1499 1570
 					}
1500
-					elseif (empty($scheme))
1501
-						$data = '//' . ltrim($data, ':/');
1502 1571
 				},
1503 1572
 				'disabled_content' => '($1)',
1504 1573
 			),
@@ -1514,17 +1583,20 @@  discard block
 block discarded – undo
1514 1583
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1515 1584
 					if ($image_proxy_enabled)
1516 1585
 					{
1517
-						if (!empty($user_info['possibly_robot']))
1518
-							return;
1586
+						if (!empty($user_info['possibly_robot'])) {
1587
+													return;
1588
+						}
1519 1589
 
1520
-						if (empty($scheme))
1521
-							$data = 'http://' . ltrim($data, ':/');
1590
+						if (empty($scheme)) {
1591
+													$data = 'http://' . ltrim($data, ':/');
1592
+						}
1522 1593
 
1523
-						if ($scheme != 'https')
1524
-							$data = get_proxied_url($data);
1594
+						if ($scheme != 'https') {
1595
+													$data = get_proxied_url($data);
1596
+						}
1597
+					} elseif (empty($scheme)) {
1598
+											$data = '//' . ltrim($data, ':/');
1525 1599
 					}
1526
-					elseif (empty($scheme))
1527
-						$data = '//' . ltrim($data, ':/');
1528 1600
 				},
1529 1601
 				'disabled_content' => '($1)',
1530 1602
 			),
@@ -1536,8 +1608,9 @@  discard block
 block discarded – undo
1536 1608
 				{
1537 1609
 					$data = strtr($data, array('<br>' => ''));
1538 1610
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1539
-					if (empty($scheme))
1540
-						$data = '//' . ltrim($data, ':/');
1611
+					if (empty($scheme)) {
1612
+											$data = '//' . ltrim($data, ':/');
1613
+					}
1541 1614
 				},
1542 1615
 			),
1543 1616
 			array(
@@ -1548,13 +1621,14 @@  discard block
 block discarded – undo
1548 1621
 				'after' => '</a>',
1549 1622
 				'validate' => function (&$tag, &$data, $disabled)
1550 1623
 				{
1551
-					if (substr($data, 0, 1) == '#')
1552
-						$data = '#post_' . substr($data, 1);
1553
-					else
1624
+					if (substr($data, 0, 1) == '#') {
1625
+											$data = '#post_' . substr($data, 1);
1626
+					} else
1554 1627
 					{
1555 1628
 						$scheme = parse_url($data, PHP_URL_SCHEME);
1556
-						if (empty($scheme))
1557
-							$data = '//' . ltrim($data, ':/');
1629
+						if (empty($scheme)) {
1630
+													$data = '//' . ltrim($data, ':/');
1631
+						}
1558 1632
 					}
1559 1633
 				},
1560 1634
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
@@ -1645,8 +1719,9 @@  discard block
 block discarded – undo
1645 1719
 					{
1646 1720
 						$add_begin = substr(trim($data), 0, 5) != '&lt;?';
1647 1721
 						$data = highlight_php_code($add_begin ? '&lt;?php ' . $data . '?&gt;' : $data);
1648
-						if ($add_begin)
1649
-							$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1722
+						if ($add_begin) {
1723
+													$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1724
+						}
1650 1725
 					}
1651 1726
 				},
1652 1727
 				'block_level' => false,
@@ -1759,20 +1834,17 @@  discard block
 block discarded – undo
1759 1834
 					: function(&$tag, &$data, $disabled)
1760 1835
 					{
1761 1836
 
1762
-						if ($data[1] == 'top' || (is_numeric($data[1]) && $data[1] < 50))
1763
-							$data[1] = '0 -2px 1px';
1764
-
1765
-						elseif ($data[1] == 'right' || (is_numeric($data[1]) && $data[1] < 100))
1766
-							$data[1] = '2px 0 1px';
1767
-
1768
-						elseif ($data[1] == 'bottom' || (is_numeric($data[1]) && $data[1] < 190))
1769
-							$data[1] = '0 2px 1px';
1770
-
1771
-						elseif ($data[1] == 'left' || (is_numeric($data[1]) && $data[1] < 280))
1772
-							$data[1] = '-2px 0 1px';
1773
-
1774
-						else
1775
-							$data[1] = '1px 1px 1px';
1837
+						if ($data[1] == 'top' || (is_numeric($data[1]) && $data[1] < 50)) {
1838
+													$data[1] = '0 -2px 1px';
1839
+						} elseif ($data[1] == 'right' || (is_numeric($data[1]) && $data[1] < 100)) {
1840
+													$data[1] = '2px 0 1px';
1841
+						} elseif ($data[1] == 'bottom' || (is_numeric($data[1]) && $data[1] < 190)) {
1842
+													$data[1] = '0 2px 1px';
1843
+						} elseif ($data[1] == 'left' || (is_numeric($data[1]) && $data[1] < 280)) {
1844
+													$data[1] = '-2px 0 1px';
1845
+						} else {
1846
+													$data[1] = '1px 1px 1px';
1847
+						}
1776 1848
 					},
1777 1849
 			),
1778 1850
 			array(
@@ -1828,10 +1900,11 @@  discard block
 block discarded – undo
1828 1900
 				'content' => '$1',
1829 1901
 				'validate' => function (&$tag, &$data, $disabled)
1830 1902
 				{
1831
-					if (is_numeric($data))
1832
-						$data = timeformat($data);
1833
-					else
1834
-						$tag['content'] = '[time]$1[/time]';
1903
+					if (is_numeric($data)) {
1904
+											$data = timeformat($data);
1905
+					} else {
1906
+											$tag['content'] = '[time]$1[/time]';
1907
+					}
1835 1908
 				},
1836 1909
 			),
1837 1910
 			array(
@@ -1863,8 +1936,9 @@  discard block
 block discarded – undo
1863 1936
 				{
1864 1937
 					$data = strtr($data, array('<br>' => ''));
1865 1938
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1866
-					if (empty($scheme))
1867
-						$data = '//' . ltrim($data, ':/');
1939
+					if (empty($scheme)) {
1940
+											$data = '//' . ltrim($data, ':/');
1941
+					}
1868 1942
 				},
1869 1943
 			),
1870 1944
 			array(
@@ -1876,8 +1950,9 @@  discard block
 block discarded – undo
1876 1950
 				'validate' => function (&$tag, &$data, $disabled)
1877 1951
 				{
1878 1952
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1879
-					if (empty($scheme))
1880
-						$data = '//' . ltrim($data, ':/');
1953
+					if (empty($scheme)) {
1954
+											$data = '//' . ltrim($data, ':/');
1955
+					}
1881 1956
 				},
1882 1957
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
1883 1958
 				'disabled_after' => ' ($1)',
@@ -1897,12 +1972,13 @@  discard block
 block discarded – undo
1897 1972
 		);
1898 1973
 
1899 1974
 		// Handle legacy bbc codes.
1900
-		foreach ($context['legacy_bbc'] as $bbc)
1901
-			$codes[] = array(
1975
+		foreach ($context['legacy_bbc'] as $bbc) {
1976
+					$codes[] = array(
1902 1977
 				'tag' => $bbc,
1903 1978
 				'before' => '',
1904 1979
 				'after' => '',
1905 1980
 			);
1981
+		}
1906 1982
 
1907 1983
 		// Let mods add new BBC without hassle.
1908 1984
 		call_integration_hook('integrate_bbc_codes', array(&$codes, &$no_autolink_tags));
@@ -1910,8 +1986,9 @@  discard block
 block discarded – undo
1910 1986
 		// This is mainly for the bbc manager, so it's easy to add tags above.  Custom BBC should be added above this line.
1911 1987
 		if ($message === false)
1912 1988
 		{
1913
-			if (isset($temp_bbc))
1914
-				$bbc_codes = $temp_bbc;
1989
+			if (isset($temp_bbc)) {
1990
+							$bbc_codes = $temp_bbc;
1991
+			}
1915 1992
 			usort($codes, function ($a, $b) {
1916 1993
 				return strcmp($a['tag'], $b['tag']);
1917 1994
 			});
@@ -1931,8 +2008,9 @@  discard block
 block discarded – undo
1931 2008
 		);
1932 2009
 		if (!isset($disabled['li']) && !isset($disabled['list']))
1933 2010
 		{
1934
-			foreach ($itemcodes as $c => $dummy)
1935
-				$bbc_codes[$c] = array();
2011
+			foreach ($itemcodes as $c => $dummy) {
2012
+							$bbc_codes[$c] = array();
2013
+			}
1936 2014
 		}
1937 2015
 
1938 2016
 		// Shhhh!
@@ -1953,12 +2031,14 @@  discard block
 block discarded – undo
1953 2031
 		foreach ($codes as $code)
1954 2032
 		{
1955 2033
 			// Make it easier to process parameters later
1956
-			if (!empty($code['parameters']))
1957
-				ksort($code['parameters'], SORT_STRING);
2034
+			if (!empty($code['parameters'])) {
2035
+							ksort($code['parameters'], SORT_STRING);
2036
+			}
1958 2037
 
1959 2038
 			// If we are not doing every tag only do ones we are interested in.
1960
-			if (empty($parse_tags) || in_array($code['tag'], $parse_tags))
1961
-				$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
2039
+			if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) {
2040
+							$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
2041
+			}
1962 2042
 		}
1963 2043
 		$codes = null;
1964 2044
 	}
@@ -1969,8 +2049,9 @@  discard block
 block discarded – undo
1969 2049
 		// It's likely this will change if the message is modified.
1970 2050
 		$cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']);
1971 2051
 
1972
-		if (($temp = cache_get_data($cache_key, 240)) != null)
1973
-			return $temp;
2052
+		if (($temp = cache_get_data($cache_key, 240)) != null) {
2053
+					return $temp;
2054
+		}
1974 2055
 
1975 2056
 		$cache_t = microtime();
1976 2057
 	}
@@ -2002,8 +2083,9 @@  discard block
 block discarded – undo
2002 2083
 		$disabled['flash'] = true;
2003 2084
 
2004 2085
 		// @todo Change maybe?
2005
-		if (!isset($_GET['images']))
2006
-			$disabled['img'] = true;
2086
+		if (!isset($_GET['images'])) {
2087
+					$disabled['img'] = true;
2088
+		}
2007 2089
 
2008 2090
 		// @todo Interface/setting to add more?
2009 2091
 	}
@@ -2014,8 +2096,9 @@  discard block
 block discarded – undo
2014 2096
 	$alltags = array();
2015 2097
 	foreach ($bbc_codes as $section)
2016 2098
 	{
2017
-		foreach ($section as $code)
2018
-			$alltags[] = $code['tag'];
2099
+		foreach ($section as $code) {
2100
+					$alltags[] = $code['tag'];
2101
+		}
2019 2102
 	}
2020 2103
 	$alltags_regex = '\b' . implode("\b|\b", array_unique($alltags)) . '\b';
2021 2104
 
@@ -2027,8 +2110,9 @@  discard block
 block discarded – undo
2027 2110
 		$pos = isset($matches[0][1]) ? $matches[0][1] : false;
2028 2111
 
2029 2112
 		// Failsafe.
2030
-		if ($pos === false || $last_pos > $pos)
2031
-			$pos = strlen($message) + 1;
2113
+		if ($pos === false || $last_pos > $pos) {
2114
+					$pos = strlen($message) + 1;
2115
+		}
2032 2116
 
2033 2117
 		// Can't have a one letter smiley, URL, or email! (sorry.)
2034 2118
 		if ($last_pos < $pos - 1)
@@ -2046,8 +2130,9 @@  discard block
 block discarded – undo
2046 2130
 
2047 2131
 				// <br> should be empty.
2048 2132
 				$empty_tags = array('br', 'hr');
2049
-				foreach ($empty_tags as $tag)
2050
-					$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '<' . $tag . '>', $data);
2133
+				foreach ($empty_tags as $tag) {
2134
+									$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '<' . $tag . '>', $data);
2135
+				}
2051 2136
 
2052 2137
 				// b, u, i, s, pre... basic tags.
2053 2138
 				$closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong');
@@ -2056,8 +2141,9 @@  discard block
 block discarded – undo
2056 2141
 					$diff = substr_count($data, '&lt;' . $tag . '&gt;') - substr_count($data, '&lt;/' . $tag . '&gt;');
2057 2142
 					$data = strtr($data, array('&lt;' . $tag . '&gt;' => '<' . $tag . '>', '&lt;/' . $tag . '&gt;' => '</' . $tag . '>'));
2058 2143
 
2059
-					if ($diff > 0)
2060
-						$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
2144
+					if ($diff > 0) {
2145
+											$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
2146
+					}
2061 2147
 				}
2062 2148
 
2063 2149
 				// Do <img ...> - with security... action= -> action-.
@@ -2070,8 +2156,9 @@  discard block
 block discarded – undo
2070 2156
 						$alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^&quot;|&quot;$~', '', $matches[3][$match]);
2071 2157
 
2072 2158
 						// Remove action= from the URL - no funny business, now.
2073
-						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0)
2074
-							$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
2159
+						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) {
2160
+													$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
2161
+						}
2075 2162
 
2076 2163
 						$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
2077 2164
 					}
@@ -2086,16 +2173,18 @@  discard block
 block discarded – undo
2086 2173
 				$no_autolink_area = false;
2087 2174
 				if (!empty($open_tags))
2088 2175
 				{
2089
-					foreach ($open_tags as $open_tag)
2090
-						if (in_array($open_tag['tag'], $no_autolink_tags))
2176
+					foreach ($open_tags as $open_tag) {
2177
+											if (in_array($open_tag['tag'], $no_autolink_tags))
2091 2178
 							$no_autolink_area = true;
2179
+					}
2092 2180
 				}
2093 2181
 
2094 2182
 				// Don't go backwards.
2095 2183
 				// @todo Don't think is the real solution....
2096 2184
 				$lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0;
2097
-				if ($pos < $lastAutoPos)
2098
-					$no_autolink_area = true;
2185
+				if ($pos < $lastAutoPos) {
2186
+									$no_autolink_area = true;
2187
+				}
2099 2188
 				$lastAutoPos = $pos;
2100 2189
 
2101 2190
 				if (!$no_autolink_area)
@@ -2200,29 +2289,33 @@  discard block
 block discarded – undo
2200 2289
 							$url = array_shift($matches);
2201 2290
 
2202 2291
 							// If this isn't a clean URL, bail out
2203
-							if ($url != sanitize_iri($url))
2204
-								return $url;
2292
+							if ($url != sanitize_iri($url)) {
2293
+															return $url;
2294
+							}
2205 2295
 
2206 2296
 							$scheme = parse_url($url, PHP_URL_SCHEME);
2207 2297
 
2208 2298
 							if ($scheme == 'mailto')
2209 2299
 							{
2210 2300
 								$email_address = str_replace('mailto:', '', $url);
2211
-								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false)
2212
-									return '[email=' . $email_address . ']' . $url . '[/email]';
2213
-								else
2214
-									return $url;
2301
+								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) {
2302
+																	return '[email=' . $email_address . ']' . $url . '[/email]';
2303
+								} else {
2304
+																	return $url;
2305
+								}
2215 2306
 							}
2216 2307
 
2217 2308
 							// Are we linking a schemeless URL or naked domain name (e.g. "example.com")?
2218
-							if (empty($scheme))
2219
-								$fullUrl = '//' . ltrim($url, ':/');
2220
-							else
2221
-								$fullUrl = $url;
2309
+							if (empty($scheme)) {
2310
+															$fullUrl = '//' . ltrim($url, ':/');
2311
+							} else {
2312
+															$fullUrl = $url;
2313
+							}
2222 2314
 
2223 2315
 							// Make sure that $fullUrl really is valid
2224
-							if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false)
2225
-								return $url;
2316
+							if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false) {
2317
+															return $url;
2318
+							}
2226 2319
 
2227 2320
 							return '[url=&quot;' . str_replace(array('[', ']'), array('&#91;', '&#93;'), $fullUrl) . '&quot;]' . $url . '[/url]';
2228 2321
 						}, $data);
@@ -2271,22 +2364,25 @@  discard block
 block discarded – undo
2271 2364
 		}
2272 2365
 
2273 2366
 		// Are we there yet?  Are we there yet?
2274
-		if ($pos >= strlen($message) - 1)
2275
-			break;
2367
+		if ($pos >= strlen($message) - 1) {
2368
+					break;
2369
+		}
2276 2370
 
2277 2371
 		$tags = strtolower($message[$pos + 1]);
2278 2372
 
2279 2373
 		if ($tags == '/' && !empty($open_tags))
2280 2374
 		{
2281 2375
 			$pos2 = strpos($message, ']', $pos + 1);
2282
-			if ($pos2 == $pos + 2)
2283
-				continue;
2376
+			if ($pos2 == $pos + 2) {
2377
+							continue;
2378
+			}
2284 2379
 
2285 2380
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
2286 2381
 
2287 2382
 			// A closing tag that doesn't match any open tags? Skip it.
2288
-			if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags)))
2289
-				continue;
2383
+			if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags))) {
2384
+							continue;
2385
+			}
2290 2386
 
2291 2387
 			$to_close = array();
2292 2388
 			$block_level = null;
@@ -2294,8 +2390,9 @@  discard block
 block discarded – undo
2294 2390
 			do
2295 2391
 			{
2296 2392
 				$tag = array_pop($open_tags);
2297
-				if (!$tag)
2298
-					break;
2393
+				if (!$tag) {
2394
+									break;
2395
+				}
2299 2396
 
2300 2397
 				if (!empty($tag['block_level']))
2301 2398
 				{
@@ -2309,10 +2406,11 @@  discard block
 block discarded – undo
2309 2406
 					// The idea is, if we are LOOKING for a block level tag, we can close them on the way.
2310 2407
 					if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]]))
2311 2408
 					{
2312
-						foreach ($bbc_codes[$look_for[0]] as $temp)
2313
-							if ($temp['tag'] == $look_for)
2409
+						foreach ($bbc_codes[$look_for[0]] as $temp) {
2410
+													if ($temp['tag'] == $look_for)
2314 2411
 							{
2315 2412
 								$block_level = !empty($temp['block_level']);
2413
+						}
2316 2414
 								break;
2317 2415
 							}
2318 2416
 					}
@@ -2334,15 +2432,15 @@  discard block
 block discarded – undo
2334 2432
 			{
2335 2433
 				$open_tags = $to_close;
2336 2434
 				continue;
2337
-			}
2338
-			elseif (!empty($to_close) && $tag['tag'] != $look_for)
2435
+			} elseif (!empty($to_close) && $tag['tag'] != $look_for)
2339 2436
 			{
2340 2437
 				if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]]))
2341 2438
 				{
2342
-					foreach ($bbc_codes[$look_for[0]] as $temp)
2343
-						if ($temp['tag'] == $look_for)
2439
+					foreach ($bbc_codes[$look_for[0]] as $temp) {
2440
+											if ($temp['tag'] == $look_for)
2344 2441
 						{
2345 2442
 							$block_level = !empty($temp['block_level']);
2443
+					}
2346 2444
 							break;
2347 2445
 						}
2348 2446
 				}
@@ -2350,8 +2448,9 @@  discard block
 block discarded – undo
2350 2448
 				// We're not looking for a block level tag (or maybe even a tag that exists...)
2351 2449
 				if (!$block_level)
2352 2450
 				{
2353
-					foreach ($to_close as $tag)
2354
-						array_push($open_tags, $tag);
2451
+					foreach ($to_close as $tag) {
2452
+											array_push($open_tags, $tag);
2453
+					}
2355 2454
 					continue;
2356 2455
 				}
2357 2456
 			}
@@ -2364,14 +2463,17 @@  discard block
 block discarded – undo
2364 2463
 
2365 2464
 				// See the comment at the end of the big loop - just eating whitespace ;).
2366 2465
 				$whitespace_regex = '';
2367
-				if (!empty($tag['block_level']))
2368
-					$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2466
+				if (!empty($tag['block_level'])) {
2467
+									$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2468
+				}
2369 2469
 				// Trim one line of whitespace after unnested tags, but all of it after nested ones
2370
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside')
2371
-					$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2470
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside') {
2471
+									$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2472
+				}
2372 2473
 
2373
-				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0)
2374
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2474
+				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) {
2475
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2476
+				}
2375 2477
 			}
2376 2478
 
2377 2479
 			if (!empty($to_close))
@@ -2384,8 +2486,9 @@  discard block
 block discarded – undo
2384 2486
 		}
2385 2487
 
2386 2488
 		// No tags for this character, so just keep going (fastest possible course.)
2387
-		if (!isset($bbc_codes[$tags]))
2388
-			continue;
2489
+		if (!isset($bbc_codes[$tags])) {
2490
+					continue;
2491
+		}
2389 2492
 
2390 2493
 		$inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1];
2391 2494
 		$tag = null;
@@ -2394,48 +2497,57 @@  discard block
 block discarded – undo
2394 2497
 			$pt_strlen = strlen($possible['tag']);
2395 2498
 
2396 2499
 			// Not a match?
2397
-			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag'])
2398
-				continue;
2500
+			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) {
2501
+							continue;
2502
+			}
2399 2503
 
2400 2504
 			$next_c = isset($message[$pos + 1 + $pt_strlen]) ? $message[$pos + 1 + $pt_strlen] : '';
2401 2505
 
2402 2506
 			// A tag is the last char maybe
2403
-			if ($next_c == '')
2404
-				break;
2507
+			if ($next_c == '') {
2508
+							break;
2509
+			}
2405 2510
 
2406 2511
 			// A test validation?
2407
-			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0)
2408
-				continue;
2512
+			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) {
2513
+							continue;
2514
+			}
2409 2515
 			// Do we want parameters?
2410 2516
 			elseif (!empty($possible['parameters']))
2411 2517
 			{
2412
-				if ($next_c != ' ')
2413
-					continue;
2414
-			}
2415
-			elseif (isset($possible['type']))
2518
+				if ($next_c != ' ') {
2519
+									continue;
2520
+				}
2521
+			} elseif (isset($possible['type']))
2416 2522
 			{
2417 2523
 				// Do we need an equal sign?
2418
-				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=')
2419
-					continue;
2524
+				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') {
2525
+									continue;
2526
+				}
2420 2527
 				// Maybe we just want a /...
2421
-				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]')
2422
-					continue;
2528
+				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') {
2529
+									continue;
2530
+				}
2423 2531
 				// An immediate ]?
2424
-				if ($possible['type'] == 'unparsed_content' && $next_c != ']')
2425
-					continue;
2532
+				if ($possible['type'] == 'unparsed_content' && $next_c != ']') {
2533
+									continue;
2534
+				}
2426 2535
 			}
2427 2536
 			// No type means 'parsed_content', which demands an immediate ] without parameters!
2428
-			elseif ($next_c != ']')
2429
-				continue;
2537
+			elseif ($next_c != ']') {
2538
+							continue;
2539
+			}
2430 2540
 
2431 2541
 			// Check allowed tree?
2432
-			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents'])))
2433
-				continue;
2434
-			elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children']))
2435
-				continue;
2542
+			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) {
2543
+							continue;
2544
+			} elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) {
2545
+							continue;
2546
+			}
2436 2547
 			// If this is in the list of disallowed child tags, don't parse it.
2437
-			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children']))
2438
-				continue;
2548
+			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) {
2549
+							continue;
2550
+			}
2439 2551
 
2440 2552
 			$pos1 = $pos + 1 + $pt_strlen + 1;
2441 2553
 
@@ -2447,8 +2559,9 @@  discard block
 block discarded – undo
2447 2559
 				foreach ($open_tags as $open_quote)
2448 2560
 				{
2449 2561
 					// Every parent quote this quote has flips the styling
2450
-					if ($open_quote['tag'] == 'quote')
2451
-						$quote_alt = !$quote_alt;
2562
+					if ($open_quote['tag'] == 'quote') {
2563
+											$quote_alt = !$quote_alt;
2564
+					}
2452 2565
 				}
2453 2566
 				// Add a class to the quote to style alternating blockquotes
2454 2567
 				$possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">'));
@@ -2459,8 +2572,9 @@  discard block
 block discarded – undo
2459 2572
 			{
2460 2573
 				// Build a regular expression for each parameter for the current tag.
2461 2574
 				$preg = array();
2462
-				foreach ($possible['parameters'] as $p => $info)
2463
-					$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2575
+				foreach ($possible['parameters'] as $p => $info) {
2576
+									$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2577
+				}
2464 2578
 
2465 2579
 				// Extract the string that potentially holds our parameters.
2466 2580
 				$blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos));
@@ -2479,24 +2593,27 @@  discard block
 block discarded – undo
2479 2593
 
2480 2594
 					$match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0;
2481 2595
 
2482
-					if ($match)
2483
-						$blob_counter = count($blobs) + 1;
2596
+					if ($match) {
2597
+											$blob_counter = count($blobs) + 1;
2598
+					}
2484 2599
 				}
2485 2600
 
2486 2601
 				// Didn't match our parameter list, try the next possible.
2487
-				if (!$match)
2488
-					continue;
2602
+				if (!$match) {
2603
+									continue;
2604
+				}
2489 2605
 
2490 2606
 				$params = array();
2491 2607
 				for ($i = 1, $n = count($matches); $i < $n; $i += 2)
2492 2608
 				{
2493 2609
 					$key = strtok(ltrim($matches[$i]), '=');
2494
-					if (isset($possible['parameters'][$key]['value']))
2495
-						$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2496
-					elseif (isset($possible['parameters'][$key]['validate']))
2497
-						$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2498
-					else
2499
-						$params['{' . $key . '}'] = $matches[$i + 1];
2610
+					if (isset($possible['parameters'][$key]['value'])) {
2611
+											$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2612
+					} elseif (isset($possible['parameters'][$key]['validate'])) {
2613
+											$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2614
+					} else {
2615
+											$params['{' . $key . '}'] = $matches[$i + 1];
2616
+					}
2500 2617
 
2501 2618
 					// Just to make sure: replace any $ or { so they can't interpolate wrongly.
2502 2619
 					$params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '&#036;', '{' => '&#123;'));
@@ -2504,23 +2621,26 @@  discard block
 block discarded – undo
2504 2621
 
2505 2622
 				foreach ($possible['parameters'] as $p => $info)
2506 2623
 				{
2507
-					if (!isset($params['{' . $p . '}']))
2508
-						$params['{' . $p . '}'] = '';
2624
+					if (!isset($params['{' . $p . '}'])) {
2625
+											$params['{' . $p . '}'] = '';
2626
+					}
2509 2627
 				}
2510 2628
 
2511 2629
 				$tag = $possible;
2512 2630
 
2513 2631
 				// Put the parameters into the string.
2514
-				if (isset($tag['before']))
2515
-					$tag['before'] = strtr($tag['before'], $params);
2516
-				if (isset($tag['after']))
2517
-					$tag['after'] = strtr($tag['after'], $params);
2518
-				if (isset($tag['content']))
2519
-					$tag['content'] = strtr($tag['content'], $params);
2632
+				if (isset($tag['before'])) {
2633
+									$tag['before'] = strtr($tag['before'], $params);
2634
+				}
2635
+				if (isset($tag['after'])) {
2636
+									$tag['after'] = strtr($tag['after'], $params);
2637
+				}
2638
+				if (isset($tag['content'])) {
2639
+									$tag['content'] = strtr($tag['content'], $params);
2640
+				}
2520 2641
 
2521 2642
 				$pos1 += strlen($given_param_string);
2522
-			}
2523
-			else
2643
+			} else
2524 2644
 			{
2525 2645
 				$tag = $possible;
2526 2646
 				$params = array();
@@ -2531,8 +2651,9 @@  discard block
 block discarded – undo
2531 2651
 		// Item codes are complicated buggers... they are implicit [li]s and can make [list]s!
2532 2652
 		if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li']))
2533 2653
 		{
2534
-			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>')))
2535
-				continue;
2654
+			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) {
2655
+							continue;
2656
+			}
2536 2657
 
2537 2658
 			$tag = $itemcodes[$message[$pos + 1]];
2538 2659
 
@@ -2553,9 +2674,9 @@  discard block
 block discarded – undo
2553 2674
 			{
2554 2675
 				array_pop($open_tags);
2555 2676
 				$code = '</li>';
2677
+			} else {
2678
+							$code = '';
2556 2679
 			}
2557
-			else
2558
-				$code = '';
2559 2680
 
2560 2681
 			// Now we open a new tag.
2561 2682
 			$open_tags[] = array(
@@ -2602,12 +2723,14 @@  discard block
 block discarded – undo
2602 2723
 		}
2603 2724
 
2604 2725
 		// No tag?  Keep looking, then.  Silly people using brackets without actual tags.
2605
-		if ($tag === null)
2606
-			continue;
2726
+		if ($tag === null) {
2727
+					continue;
2728
+		}
2607 2729
 
2608 2730
 		// Propagate the list to the child (so wrapping the disallowed tag won't work either.)
2609
-		if (isset($inside['disallow_children']))
2610
-			$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2731
+		if (isset($inside['disallow_children'])) {
2732
+					$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2733
+		}
2611 2734
 
2612 2735
 		// Is this tag disabled?
2613 2736
 		if (isset($disabled[$tag['tag']]))
@@ -2617,14 +2740,13 @@  discard block
 block discarded – undo
2617 2740
 				$tag['before'] = !empty($tag['block_level']) ? '<div>' : '';
2618 2741
 				$tag['after'] = !empty($tag['block_level']) ? '</div>' : '';
2619 2742
 				$tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1');
2620
-			}
2621
-			elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2743
+			} elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2622 2744
 			{
2623 2745
 				$tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : '');
2624 2746
 				$tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : '');
2747
+			} else {
2748
+							$tag['content'] = $tag['disabled_content'];
2625 2749
 			}
2626
-			else
2627
-				$tag['content'] = $tag['disabled_content'];
2628 2750
 		}
2629 2751
 
2630 2752
 		// we use this a lot
@@ -2634,8 +2756,9 @@  discard block
 block discarded – undo
2634 2756
 		if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level']))
2635 2757
 		{
2636 2758
 			$n = count($open_tags) - 1;
2637
-			while (empty($open_tags[$n]['block_level']) && $n >= 0)
2638
-				$n--;
2759
+			while (empty($open_tags[$n]['block_level']) && $n >= 0) {
2760
+							$n--;
2761
+			}
2639 2762
 
2640 2763
 			// Close all the non block level tags so this tag isn't surrounded by them.
2641 2764
 			for ($i = count($open_tags) - 1; $i > $n; $i--)
@@ -2647,12 +2770,15 @@  discard block
 block discarded – undo
2647 2770
 
2648 2771
 				// Trim or eat trailing stuff... see comment at the end of the big loop.
2649 2772
 				$whitespace_regex = '';
2650
-				if (!empty($tag['block_level']))
2651
-					$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2652
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside')
2653
-					$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2654
-				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0)
2655
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2773
+				if (!empty($tag['block_level'])) {
2774
+									$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2775
+				}
2776
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside') {
2777
+									$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2778
+				}
2779
+				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) {
2780
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2781
+				}
2656 2782
 
2657 2783
 				array_pop($open_tags);
2658 2784
 			}
@@ -2673,16 +2799,19 @@  discard block
 block discarded – undo
2673 2799
 		elseif ($tag['type'] == 'unparsed_content')
2674 2800
 		{
2675 2801
 			$pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1);
2676
-			if ($pos2 === false)
2677
-				continue;
2802
+			if ($pos2 === false) {
2803
+							continue;
2804
+			}
2678 2805
 
2679 2806
 			$data = substr($message, $pos1, $pos2 - $pos1);
2680 2807
 
2681
-			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>')
2682
-				$data = substr($data, 4);
2808
+			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') {
2809
+							$data = substr($data, 4);
2810
+			}
2683 2811
 
2684
-			if (isset($tag['validate']))
2685
-				$tag['validate']($tag, $data, $disabled, $params);
2812
+			if (isset($tag['validate'])) {
2813
+							$tag['validate']($tag, $data, $disabled, $params);
2814
+			}
2686 2815
 
2687 2816
 			$code = strtr($tag['content'], array('$1' => $data));
2688 2817
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen);
@@ -2697,34 +2826,40 @@  discard block
 block discarded – undo
2697 2826
 			if (isset($tag['quoted']))
2698 2827
 			{
2699 2828
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2700
-				if ($tag['quoted'] != 'optional' && !$quoted)
2701
-					continue;
2829
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2830
+									continue;
2831
+				}
2702 2832
 
2703
-				if ($quoted)
2704
-					$pos1 += 6;
2833
+				if ($quoted) {
2834
+									$pos1 += 6;
2835
+				}
2836
+			} else {
2837
+							$quoted = false;
2705 2838
 			}
2706
-			else
2707
-				$quoted = false;
2708 2839
 
2709 2840
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2710
-			if ($pos2 === false)
2711
-				continue;
2841
+			if ($pos2 === false) {
2842
+							continue;
2843
+			}
2712 2844
 
2713 2845
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2714
-			if ($pos3 === false)
2715
-				continue;
2846
+			if ($pos3 === false) {
2847
+							continue;
2848
+			}
2716 2849
 
2717 2850
 			$data = array(
2718 2851
 				substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))),
2719 2852
 				substr($message, $pos1, $pos2 - $pos1)
2720 2853
 			);
2721 2854
 
2722
-			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>')
2723
-				$data[0] = substr($data[0], 4);
2855
+			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') {
2856
+							$data[0] = substr($data[0], 4);
2857
+			}
2724 2858
 
2725 2859
 			// Validation for my parking, please!
2726
-			if (isset($tag['validate']))
2727
-				$tag['validate']($tag, $data, $disabled, $params);
2860
+			if (isset($tag['validate'])) {
2861
+							$tag['validate']($tag, $data, $disabled, $params);
2862
+			}
2728 2863
 
2729 2864
 			$code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1]));
2730 2865
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
@@ -2741,23 +2876,27 @@  discard block
 block discarded – undo
2741 2876
 		elseif ($tag['type'] == 'unparsed_commas_content')
2742 2877
 		{
2743 2878
 			$pos2 = strpos($message, ']', $pos1);
2744
-			if ($pos2 === false)
2745
-				continue;
2879
+			if ($pos2 === false) {
2880
+							continue;
2881
+			}
2746 2882
 
2747 2883
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2748
-			if ($pos3 === false)
2749
-				continue;
2884
+			if ($pos3 === false) {
2885
+							continue;
2886
+			}
2750 2887
 
2751 2888
 			// We want $1 to be the content, and the rest to be csv.
2752 2889
 			$data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1));
2753 2890
 			$data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1);
2754 2891
 
2755
-			if (isset($tag['validate']))
2756
-				$tag['validate']($tag, $data, $disabled, $params);
2892
+			if (isset($tag['validate'])) {
2893
+							$tag['validate']($tag, $data, $disabled, $params);
2894
+			}
2757 2895
 
2758 2896
 			$code = $tag['content'];
2759
-			foreach ($data as $k => $d)
2760
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2897
+			foreach ($data as $k => $d) {
2898
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2899
+			}
2761 2900
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
2762 2901
 			$pos += strlen($code) - 1 + 2;
2763 2902
 		}
@@ -2765,24 +2904,28 @@  discard block
 block discarded – undo
2765 2904
 		elseif ($tag['type'] == 'unparsed_commas')
2766 2905
 		{
2767 2906
 			$pos2 = strpos($message, ']', $pos1);
2768
-			if ($pos2 === false)
2769
-				continue;
2907
+			if ($pos2 === false) {
2908
+							continue;
2909
+			}
2770 2910
 
2771 2911
 			$data = explode(',', substr($message, $pos1, $pos2 - $pos1));
2772 2912
 
2773
-			if (isset($tag['validate']))
2774
-				$tag['validate']($tag, $data, $disabled, $params);
2913
+			if (isset($tag['validate'])) {
2914
+							$tag['validate']($tag, $data, $disabled, $params);
2915
+			}
2775 2916
 
2776 2917
 			// Fix after, for disabled code mainly.
2777
-			foreach ($data as $k => $d)
2778
-				$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2918
+			foreach ($data as $k => $d) {
2919
+							$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2920
+			}
2779 2921
 
2780 2922
 			$open_tags[] = $tag;
2781 2923
 
2782 2924
 			// Replace them out, $1, $2, $3, $4, etc.
2783 2925
 			$code = $tag['before'];
2784
-			foreach ($data as $k => $d)
2785
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2926
+			foreach ($data as $k => $d) {
2927
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2928
+			}
2786 2929
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1);
2787 2930
 			$pos += strlen($code) - 1 + 2;
2788 2931
 		}
@@ -2793,28 +2936,33 @@  discard block
 block discarded – undo
2793 2936
 			if (isset($tag['quoted']))
2794 2937
 			{
2795 2938
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2796
-				if ($tag['quoted'] != 'optional' && !$quoted)
2797
-					continue;
2939
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2940
+									continue;
2941
+				}
2798 2942
 
2799
-				if ($quoted)
2800
-					$pos1 += 6;
2943
+				if ($quoted) {
2944
+									$pos1 += 6;
2945
+				}
2946
+			} else {
2947
+							$quoted = false;
2801 2948
 			}
2802
-			else
2803
-				$quoted = false;
2804 2949
 
2805 2950
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2806
-			if ($pos2 === false)
2807
-				continue;
2951
+			if ($pos2 === false) {
2952
+							continue;
2953
+			}
2808 2954
 
2809 2955
 			$data = substr($message, $pos1, $pos2 - $pos1);
2810 2956
 
2811 2957
 			// Validation for my parking, please!
2812
-			if (isset($tag['validate']))
2813
-				$tag['validate']($tag, $data, $disabled, $params);
2958
+			if (isset($tag['validate'])) {
2959
+							$tag['validate']($tag, $data, $disabled, $params);
2960
+			}
2814 2961
 
2815 2962
 			// For parsed content, we must recurse to avoid security problems.
2816
-			if ($tag['type'] != 'unparsed_equals')
2817
-				$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2963
+			if ($tag['type'] != 'unparsed_equals') {
2964
+							$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2965
+			}
2818 2966
 
2819 2967
 			$tag['after'] = strtr($tag['after'], array('$1' => $data));
2820 2968
 
@@ -2826,34 +2974,40 @@  discard block
 block discarded – undo
2826 2974
 		}
2827 2975
 
2828 2976
 		// If this is block level, eat any breaks after it.
2829
-		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>')
2830
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2977
+		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') {
2978
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2979
+		}
2831 2980
 
2832 2981
 		// Are we trimming outside this tag?
2833
-		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0)
2834
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2982
+		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0) {
2983
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2984
+		}
2835 2985
 	}
2836 2986
 
2837 2987
 	// Close any remaining tags.
2838
-	while ($tag = array_pop($open_tags))
2839
-		$message .= "\n" . $tag['after'] . "\n";
2988
+	while ($tag = array_pop($open_tags)) {
2989
+			$message .= "\n" . $tag['after'] . "\n";
2990
+	}
2840 2991
 
2841 2992
 	// Parse the smileys within the parts where it can be done safely.
2842 2993
 	if ($smileys === true)
2843 2994
 	{
2844 2995
 		$message_parts = explode("\n", $message);
2845
-		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2)
2846
-			parsesmileys($message_parts[$i]);
2996
+		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) {
2997
+					parsesmileys($message_parts[$i]);
2998
+		}
2847 2999
 
2848 3000
 		$message = implode('', $message_parts);
2849 3001
 	}
2850 3002
 
2851 3003
 	// No smileys, just get rid of the markers.
2852
-	else
2853
-		$message = strtr($message, array("\n" => ''));
3004
+	else {
3005
+			$message = strtr($message, array("\n" => ''));
3006
+	}
2854 3007
 
2855
-	if ($message !== '' && $message[0] === ' ')
2856
-		$message = '&nbsp;' . substr($message, 1);
3008
+	if ($message !== '' && $message[0] === ' ') {
3009
+			$message = '&nbsp;' . substr($message, 1);
3010
+	}
2857 3011
 
2858 3012
 	// Cleanup whitespace.
2859 3013
 	$message = strtr($message, array('  ' => ' &nbsp;', "\r" => '', "\n" => '<br>', '<br> ' => '<br>&nbsp;', '&#13;' => "\n"));
@@ -2862,15 +3016,16 @@  discard block
 block discarded – undo
2862 3016
 	call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
2863 3017
 
2864 3018
 	// Cache the output if it took some time...
2865
-	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05)
2866
-		cache_put_data($cache_key, $message, 240);
3019
+	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) {
3020
+			cache_put_data($cache_key, $message, 240);
3021
+	}
2867 3022
 
2868 3023
 	// If this was a force parse revert if needed.
2869 3024
 	if (!empty($parse_tags))
2870 3025
 	{
2871
-		if (empty($temp_bbc))
2872
-			$bbc_codes = array();
2873
-		else
3026
+		if (empty($temp_bbc)) {
3027
+					$bbc_codes = array();
3028
+		} else
2874 3029
 		{
2875 3030
 			$bbc_codes = $temp_bbc;
2876 3031
 			unset($temp_bbc);
@@ -2897,8 +3052,9 @@  discard block
 block discarded – undo
2897 3052
 	static $smileyPregSearch = null, $smileyPregReplacements = array();
2898 3053
 
2899 3054
 	// No smiley set at all?!
2900
-	if ($user_info['smiley_set'] == 'none' || trim($message) == '')
2901
-		return;
3055
+	if ($user_info['smiley_set'] == 'none' || trim($message) == '') {
3056
+			return;
3057
+	}
2902 3058
 
2903 3059
 	// Maybe a mod wants to implement an alternative method (e.g. emojis instead of images)
2904 3060
 	call_integration_hook('integrate_smileys', array(&$smileyPregSearch, &$smileyPregReplacements));
@@ -2912,8 +3068,7 @@  discard block
 block discarded – undo
2912 3068
 			$smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', 'O:-)');
2913 3069
 			$smileysto = array('evil.png', 'cheesy.png', 'rolleyes.png', 'angry.png', 'laugh.png', 'smiley.png', 'wink.png', 'grin.png', 'sad.png', 'shocked.png', 'cool.png', 'tongue.png', 'huh.png', 'embarrassed.png', 'lipsrsealed.png', 'kiss.png', 'cry.png', 'undecided.png', 'azn.png', 'afro.png', 'police.png', 'angel.png');
2914 3070
 			$smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', '');
2915
-		}
2916
-		else
3071
+		} else
2917 3072
 		{
2918 3073
 			// Load the smileys in reverse order by length so they don't get parsed wrong.
2919 3074
 			if (($temp = cache_get_data('parsing_smileys', 480)) == null)
@@ -2937,9 +3092,9 @@  discard block
 block discarded – undo
2937 3092
 				$smcFunc['db_free_result']($result);
2938 3093
 
2939 3094
 				cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480);
3095
+			} else {
3096
+							list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2940 3097
 			}
2941
-			else
2942
-				list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2943 3098
 		}
2944 3099
 
2945 3100
 		// The non-breaking-space is a complex thing...
@@ -2961,16 +3116,18 @@  discard block
 block discarded – undo
2961 3116
 				$alt_images = glob($smileys_dir . $fname .  '.{' . (implode(',', $exts)) . '}', GLOB_BRACE);
2962 3117
 				if (!empty($alt_images))
2963 3118
 				{
2964
-					foreach ($exts as $ext)
2965
-						if (in_array($smileys_dir . $fname . '.' . $ext, $alt_images))
3119
+					foreach ($exts as $ext) {
3120
+											if (in_array($smileys_dir . $fname . '.' . $ext, $alt_images))
2966 3121
 						{
2967 3122
 							$smileysto[$i] = $fname . '.' . $ext;
3123
+					}
2968 3124
 							break;
2969 3125
 						}
2970 3126
 				}
2971 3127
 				// If we have no image, just leave the text version in place
2972
-				else
2973
-					continue;
3128
+				else {
3129
+									continue;
3130
+				}
2974 3131
 			}
2975 3132
 
2976 3133
 			$specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES);
@@ -3046,12 +3203,14 @@  discard block
 block discarded – undo
3046 3203
 	global $boardurl, $image_proxy_enabled, $image_proxy_secret;
3047 3204
 
3048 3205
 	// Only use the proxy if enabled and necessary
3049
-	if (empty($image_proxy_enabled) || parse_url($url, PHP_URL_SCHEME) === 'https')
3050
-		return $url;
3206
+	if (empty($image_proxy_enabled) || parse_url($url, PHP_URL_SCHEME) === 'https') {
3207
+			return $url;
3208
+	}
3051 3209
 
3052 3210
 	// We don't need to proxy our own resources
3053
-	if (strpos(strtr($url, array('http://' => 'https://')), strtr($boardurl, array('http://' => 'https://'))) === 0)
3054
-		return strtr($url, array('http://' => 'https://'));
3211
+	if (strpos(strtr($url, array('http://' => 'https://')), strtr($boardurl, array('http://' => 'https://'))) === 0) {
3212
+			return strtr($url, array('http://' => 'https://'));
3213
+	}
3055 3214
 
3056 3215
 	// By default, use SMF's own image proxy script
3057 3216
 	$proxied_url = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($url) . '&hash=' . md5($url . $image_proxy_secret);
@@ -3076,35 +3235,41 @@  discard block
 block discarded – undo
3076 3235
 	global $scripturl, $context, $modSettings, $db_show_debug, $db_cache;
3077 3236
 
3078 3237
 	// In case we have mail to send, better do that - as obExit doesn't always quite make it...
3079
-	if (!empty($context['flush_mail']))
3080
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3238
+	if (!empty($context['flush_mail'])) {
3239
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3081 3240
 		AddMailQueue(true);
3241
+	}
3082 3242
 
3083 3243
 	$add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:';
3084 3244
 
3085
-	if ($add)
3086
-		$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
3245
+	if ($add) {
3246
+			$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
3247
+	}
3087 3248
 
3088 3249
 	// Put the session ID in.
3089
-	if (defined('SID') && SID != '')
3090
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
3250
+	if (defined('SID') && SID != '') {
3251
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
3252
+	}
3091 3253
 	// Keep that debug in their for template debugging!
3092
-	elseif (isset($_GET['debug']))
3093
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
3254
+	elseif (isset($_GET['debug'])) {
3255
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
3256
+	}
3094 3257
 
3095 3258
 	if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed'])))
3096 3259
 	{
3097
-		if (defined('SID') && SID != '')
3098
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
3260
+		if (defined('SID') && SID != '') {
3261
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
3099 3262
 				function ($m) use ($scripturl)
3100 3263
 				{
3101 3264
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
3265
+		}
3102 3266
 				}, $setLocation);
3103
-		else
3104
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
3267
+		else {
3268
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
3105 3269
 				function ($m) use ($scripturl)
3106 3270
 				{
3107 3271
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
3272
+		}
3108 3273
 				}, $setLocation);
3109 3274
 	}
3110 3275
 
@@ -3115,8 +3280,9 @@  discard block
 block discarded – undo
3115 3280
 	header('location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302);
3116 3281
 
3117 3282
 	// Debugging.
3118
-	if (isset($db_show_debug) && $db_show_debug === true)
3119
-		$_SESSION['debug_redirect'] = $db_cache;
3283
+	if (isset($db_show_debug) && $db_show_debug === true) {
3284
+			$_SESSION['debug_redirect'] = $db_cache;
3285
+	}
3120 3286
 
3121 3287
 	obExit(false);
3122 3288
 }
@@ -3135,51 +3301,60 @@  discard block
 block discarded – undo
3135 3301
 
3136 3302
 	// Attempt to prevent a recursive loop.
3137 3303
 	++$level;
3138
-	if ($level > 1 && !$from_fatal_error && !$has_fatal_error)
3139
-		exit;
3140
-	if ($from_fatal_error)
3141
-		$has_fatal_error = true;
3304
+	if ($level > 1 && !$from_fatal_error && !$has_fatal_error) {
3305
+			exit;
3306
+	}
3307
+	if ($from_fatal_error) {
3308
+			$has_fatal_error = true;
3309
+	}
3142 3310
 
3143 3311
 	// Clear out the stat cache.
3144 3312
 	trackStats();
3145 3313
 
3146 3314
 	// If we have mail to send, send it.
3147
-	if (!empty($context['flush_mail']))
3148
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3315
+	if (!empty($context['flush_mail'])) {
3316
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3149 3317
 		AddMailQueue(true);
3318
+	}
3150 3319
 
3151 3320
 	$do_header = $header === null ? !$header_done : $header;
3152
-	if ($do_footer === null)
3153
-		$do_footer = $do_header;
3321
+	if ($do_footer === null) {
3322
+			$do_footer = $do_header;
3323
+	}
3154 3324
 
3155 3325
 	// Has the template/header been done yet?
3156 3326
 	if ($do_header)
3157 3327
 	{
3158 3328
 		// Was the page title set last minute? Also update the HTML safe one.
3159
-		if (!empty($context['page_title']) && empty($context['page_title_html_safe']))
3160
-			$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
3329
+		if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) {
3330
+					$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
3331
+		}
3161 3332
 
3162 3333
 		// Start up the session URL fixer.
3163 3334
 		ob_start('ob_sessrewrite');
3164 3335
 
3165
-		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers']))
3166
-			$buffers = explode(',', $settings['output_buffers']);
3167
-		elseif (!empty($settings['output_buffers']))
3168
-			$buffers = $settings['output_buffers'];
3169
-		else
3170
-			$buffers = array();
3336
+		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) {
3337
+					$buffers = explode(',', $settings['output_buffers']);
3338
+		} elseif (!empty($settings['output_buffers'])) {
3339
+					$buffers = $settings['output_buffers'];
3340
+		} else {
3341
+					$buffers = array();
3342
+		}
3171 3343
 
3172
-		if (isset($modSettings['integrate_buffer']))
3173
-			$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3344
+		if (isset($modSettings['integrate_buffer'])) {
3345
+					$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3346
+		}
3174 3347
 
3175
-		if (!empty($buffers))
3176
-			foreach ($buffers as $function)
3348
+		if (!empty($buffers)) {
3349
+					foreach ($buffers as $function)
3177 3350
 			{
3178 3351
 				$call = call_helper($function, true);
3352
+		}
3179 3353
 
3180 3354
 				// Is it valid?
3181
-				if (!empty($call))
3182
-					ob_start($call);
3355
+				if (!empty($call)) {
3356
+									ob_start($call);
3357
+				}
3183 3358
 			}
3184 3359
 
3185 3360
 		// Display the screen in the logical order.
@@ -3191,8 +3366,9 @@  discard block
 block discarded – undo
3191 3366
 		loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main');
3192 3367
 
3193 3368
 		// Anything special to put out?
3194
-		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml']))
3195
-			echo $context['insert_after_template'];
3369
+		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) {
3370
+					echo $context['insert_after_template'];
3371
+		}
3196 3372
 
3197 3373
 		// Just so we don't get caught in an endless loop of errors from the footer...
3198 3374
 		if (!$footer_done)
@@ -3201,14 +3377,16 @@  discard block
 block discarded – undo
3201 3377
 			template_footer();
3202 3378
 
3203 3379
 			// (since this is just debugging... it's okay that it's after </html>.)
3204
-			if (!isset($_REQUEST['xml']))
3205
-				displayDebug();
3380
+			if (!isset($_REQUEST['xml'])) {
3381
+							displayDebug();
3382
+			}
3206 3383
 		}
3207 3384
 	}
3208 3385
 
3209 3386
 	// Remember this URL in case someone doesn't like sending HTTP_REFERER.
3210
-	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false)
3211
-		$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3387
+	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) {
3388
+			$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3389
+	}
3212 3390
 
3213 3391
 	// For session check verification.... don't switch browsers...
3214 3392
 	$_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT'];
@@ -3217,9 +3395,10 @@  discard block
 block discarded – undo
3217 3395
 	call_integration_hook('integrate_exit', array($do_footer));
3218 3396
 
3219 3397
 	// Don't exit if we're coming from index.php; that will pass through normally.
3220
-	if (!$from_index)
3221
-		exit;
3222
-}
3398
+	if (!$from_index) {
3399
+			exit;
3400
+	}
3401
+	}
3223 3402
 
3224 3403
 /**
3225 3404
  * Get the size of a specified image with better error handling.
@@ -3238,8 +3417,9 @@  discard block
 block discarded – undo
3238 3417
 	$url = str_replace(' ', '%20', $url);
3239 3418
 
3240 3419
 	// Can we pull this from the cache... please please?
3241
-	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null)
3242
-		return $temp;
3420
+	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) {
3421
+			return $temp;
3422
+	}
3243 3423
 	$t = microtime();
3244 3424
 
3245 3425
 	// Get the host to pester...
@@ -3249,12 +3429,10 @@  discard block
 block discarded – undo
3249 3429
 	if ($url == '' || $url == 'http://' || $url == 'https://')
3250 3430
 	{
3251 3431
 		return false;
3252
-	}
3253
-	elseif (!isset($match[1]))
3432
+	} elseif (!isset($match[1]))
3254 3433
 	{
3255 3434
 		$size = @getimagesize($url);
3256
-	}
3257
-	else
3435
+	} else
3258 3436
 	{
3259 3437
 		// Try to connect to the server... give it half a second.
3260 3438
 		$temp = 0;
@@ -3291,12 +3469,14 @@  discard block
 block discarded – undo
3291 3469
 	}
3292 3470
 
3293 3471
 	// If we didn't get it, we failed.
3294
-	if (!isset($size))
3295
-		$size = false;
3472
+	if (!isset($size)) {
3473
+			$size = false;
3474
+	}
3296 3475
 
3297 3476
 	// If this took a long time, we may never have to do it again, but then again we might...
3298
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8)
3299
-		cache_put_data('url_image_size-' . md5($url), $size, 240);
3477
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) {
3478
+			cache_put_data('url_image_size-' . md5($url), $size, 240);
3479
+	}
3300 3480
 
3301 3481
 	// Didn't work.
3302 3482
 	return $size;
@@ -3314,8 +3494,9 @@  discard block
 block discarded – undo
3314 3494
 
3315 3495
 	// Under SSI this function can be called more then once.  That can cause some problems.
3316 3496
 	//   So only run the function once unless we are forced to run it again.
3317
-	if ($loaded && !$forceload)
3318
-		return;
3497
+	if ($loaded && !$forceload) {
3498
+			return;
3499
+	}
3319 3500
 
3320 3501
 	$loaded = true;
3321 3502
 
@@ -3327,14 +3508,16 @@  discard block
 block discarded – undo
3327 3508
 	$context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news'])))));
3328 3509
 	for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++)
3329 3510
 	{
3330
-		if (trim($context['news_lines'][$i]) == '')
3331
-			continue;
3511
+		if (trim($context['news_lines'][$i]) == '') {
3512
+					continue;
3513
+		}
3332 3514
 
3333 3515
 		// Clean it up for presentation ;).
3334 3516
 		$context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i);
3335 3517
 	}
3336
-	if (!empty($context['news_lines']))
3337
-		$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3518
+	if (!empty($context['news_lines'])) {
3519
+			$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3520
+	}
3338 3521
 
3339 3522
 	if (!$user_info['is_guest'])
3340 3523
 	{
@@ -3343,40 +3526,48 @@  discard block
 block discarded – undo
3343 3526
 		$context['user']['alerts'] = &$user_info['alerts'];
3344 3527
 
3345 3528
 		// Personal message popup...
3346
-		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0))
3347
-			$context['user']['popup_messages'] = true;
3348
-		else
3349
-			$context['user']['popup_messages'] = false;
3529
+		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) {
3530
+					$context['user']['popup_messages'] = true;
3531
+		} else {
3532
+					$context['user']['popup_messages'] = false;
3533
+		}
3350 3534
 		$_SESSION['unread_messages'] = $user_info['unread_messages'];
3351 3535
 
3352
-		if (allowedTo('moderate_forum'))
3353
-			$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3536
+		if (allowedTo('moderate_forum')) {
3537
+					$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3538
+		}
3354 3539
 
3355 3540
 		$context['user']['avatar'] = array();
3356 3541
 
3357 3542
 		// Check for gravatar first since we might be forcing them...
3358 3543
 		if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride']))
3359 3544
 		{
3360
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11)
3361
-				$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3362
-			else
3363
-				$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3545
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) {
3546
+							$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3547
+			} else {
3548
+							$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3549
+			}
3364 3550
 		}
3365 3551
 		// Uploaded?
3366
-		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach']))
3367
-			$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3552
+		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) {
3553
+					$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3554
+		}
3368 3555
 		// Full URL?
3369
-		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0)
3370
-			$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3556
+		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) {
3557
+					$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3558
+		}
3371 3559
 		// Otherwise we assume it's server stored.
3372
-		elseif ($user_info['avatar']['url'] != '')
3373
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3560
+		elseif ($user_info['avatar']['url'] != '') {
3561
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3562
+		}
3374 3563
 		// No avatar at all? Fine, we have a big fat default avatar ;)
3375
-		else
3376
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3564
+		else {
3565
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3566
+		}
3377 3567
 
3378
-		if (!empty($context['user']['avatar']))
3379
-			$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3568
+		if (!empty($context['user']['avatar'])) {
3569
+					$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3570
+		}
3380 3571
 
3381 3572
 		// Figure out how long they've been logged in.
3382 3573
 		$context['user']['total_time_logged_in'] = array(
@@ -3384,8 +3575,7 @@  discard block
 block discarded – undo
3384 3575
 			'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600),
3385 3576
 			'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60)
3386 3577
 		);
3387
-	}
3388
-	else
3578
+	} else
3389 3579
 	{
3390 3580
 		$context['user']['messages'] = 0;
3391 3581
 		$context['user']['unread_messages'] = 0;
@@ -3393,12 +3583,14 @@  discard block
 block discarded – undo
3393 3583
 		$context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0);
3394 3584
 		$context['user']['popup_messages'] = false;
3395 3585
 
3396
-		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1)
3397
-			$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3586
+		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) {
3587
+					$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3588
+		}
3398 3589
 
3399 3590
 		// If we've upgraded recently, go easy on the passwords.
3400
-		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime']))
3401
-			$context['disable_login_hashing'] = true;
3591
+		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) {
3592
+					$context['disable_login_hashing'] = true;
3593
+		}
3402 3594
 	}
3403 3595
 
3404 3596
 	// Setup the main menu items.
@@ -3411,8 +3603,8 @@  discard block
 block discarded – undo
3411 3603
 	$context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm');
3412 3604
 
3413 3605
 	// 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array.
3414
-	if ($context['show_pm_popup'])
3415
-		addInlineJavaScript('
3606
+	if ($context['show_pm_popup']) {
3607
+			addInlineJavaScript('
3416 3608
 		jQuery(document).ready(function($) {
3417 3609
 			new smc_Popup({
3418 3610
 				heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ',
@@ -3420,24 +3612,28 @@  discard block
 block discarded – undo
3420 3612
 				icon_class: \'generic_icons mail_new\'
3421 3613
 			});
3422 3614
 		});');
3615
+	}
3423 3616
 
3424 3617
 	// Add a generic "Are you sure?" confirmation message.
3425 3618
 	addInlineJavaScript('
3426 3619
 	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3427 3620
 
3428 3621
 	// Now add the capping code for avatars.
3429
-	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
3430
-		addInlineCss('
3622
+	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') {
3623
+			addInlineCss('
3431 3624
 	img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }');
3625
+	}
3432 3626
 
3433 3627
 	// Add max image limits
3434
-	if (!empty($modSettings['max_image_width']))
3435
-		addInlineCss('
3628
+	if (!empty($modSettings['max_image_width'])) {
3629
+			addInlineCss('
3436 3630
 	.postarea .bbc_img { max-width: ' . $modSettings['max_image_width'] . 'px; }');
3631
+	}
3437 3632
 
3438
-	if (!empty($modSettings['max_image_height']))
3439
-		addInlineCss('
3633
+	if (!empty($modSettings['max_image_height'])) {
3634
+			addInlineCss('
3440 3635
 	.postarea .bbc_img { max-height: ' . $modSettings['max_image_height'] . 'px; }');
3636
+	}
3441 3637
 
3442 3638
 	// This looks weird, but it's because BoardIndex.php references the variable.
3443 3639
 	$context['common_stats']['latest_member'] = array(
@@ -3454,11 +3650,13 @@  discard block
 block discarded – undo
3454 3650
 	);
3455 3651
 	$context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']);
3456 3652
 
3457
-	if (empty($settings['theme_version']))
3458
-		addJavaScriptVar('smf_scripturl', $scripturl);
3653
+	if (empty($settings['theme_version'])) {
3654
+			addJavaScriptVar('smf_scripturl', $scripturl);
3655
+	}
3459 3656
 
3460
-	if (!isset($context['page_title']))
3461
-		$context['page_title'] = '';
3657
+	if (!isset($context['page_title'])) {
3658
+			$context['page_title'] = '';
3659
+	}
3462 3660
 
3463 3661
 	// Set some specific vars.
3464 3662
 	$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
@@ -3468,21 +3666,23 @@  discard block
 block discarded – undo
3468 3666
 	$context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']);
3469 3667
 	$context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']);
3470 3668
 
3471
-	if (!empty($context['meta_keywords']))
3472
-		$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3669
+	if (!empty($context['meta_keywords'])) {
3670
+			$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3671
+	}
3473 3672
 
3474
-	if (!empty($context['canonical_url']))
3475
-		$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3673
+	if (!empty($context['canonical_url'])) {
3674
+			$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3675
+	}
3476 3676
 
3477
-	if (!empty($settings['og_image']))
3478
-		$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3677
+	if (!empty($settings['og_image'])) {
3678
+			$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3679
+	}
3479 3680
 
3480 3681
 	if (!empty($context['meta_description']))
3481 3682
 	{
3482 3683
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']);
3483 3684
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']);
3484
-	}
3485
-	else
3685
+	} else
3486 3686
 	{
3487 3687
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']);
3488 3688
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']);
@@ -3507,8 +3707,9 @@  discard block
 block discarded – undo
3507 3707
 	$memory_needed = memoryReturnBytes($needed);
3508 3708
 
3509 3709
 	// should we account for how much is currently being used?
3510
-	if ($in_use)
3511
-		$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3710
+	if ($in_use) {
3711
+			$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3712
+	}
3512 3713
 
3513 3714
 	// if more is needed, request it
3514 3715
 	if ($memory_current < $memory_needed)
@@ -3531,8 +3732,9 @@  discard block
 block discarded – undo
3531 3732
  */
3532 3733
 function memoryReturnBytes($val)
3533 3734
 {
3534
-	if (is_integer($val))
3535
-		return $val;
3735
+	if (is_integer($val)) {
3736
+			return $val;
3737
+	}
3536 3738
 
3537 3739
 	// Separate the number from the designator
3538 3740
 	$val = trim($val);
@@ -3568,10 +3770,11 @@  discard block
 block discarded – undo
3568 3770
 		header('last-modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
3569 3771
 
3570 3772
 		// Are we debugging the template/html content?
3571
-		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie'))
3572
-			header('content-type: application/xhtml+xml');
3573
-		elseif (!isset($_REQUEST['xml']))
3574
-			header('content-type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3773
+		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) {
3774
+					header('content-type: application/xhtml+xml');
3775
+		} elseif (!isset($_REQUEST['xml'])) {
3776
+					header('content-type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3777
+		}
3575 3778
 	}
3576 3779
 
3577 3780
 	header('content-type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
@@ -3580,8 +3783,9 @@  discard block
 block discarded – undo
3580 3783
 	if ($context['in_maintenance'] && $context['user']['is_admin'])
3581 3784
 	{
3582 3785
 		$position = array_search('body', $context['template_layers']);
3583
-		if ($position === false)
3584
-			$position = array_search('main', $context['template_layers']);
3786
+		if ($position === false) {
3787
+					$position = array_search('main', $context['template_layers']);
3788
+		}
3585 3789
 
3586 3790
 		if ($position !== false)
3587 3791
 		{
@@ -3609,23 +3813,25 @@  discard block
 block discarded – undo
3609 3813
 
3610 3814
 			foreach ($securityFiles as $i => $securityFile)
3611 3815
 			{
3612
-				if (!file_exists($boarddir . '/' . $securityFile))
3613
-					unset($securityFiles[$i]);
3816
+				if (!file_exists($boarddir . '/' . $securityFile)) {
3817
+									unset($securityFiles[$i]);
3818
+				}
3614 3819
 			}
3615 3820
 
3616 3821
 			// We are already checking so many files...just few more doesn't make any difference! :P
3617
-			if (!empty($modSettings['currentAttachmentUploadDir']))
3618
-				$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3619
-
3620
-			else
3621
-				$path = $modSettings['attachmentUploadDir'];
3822
+			if (!empty($modSettings['currentAttachmentUploadDir'])) {
3823
+							$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3824
+			} else {
3825
+							$path = $modSettings['attachmentUploadDir'];
3826
+			}
3622 3827
 
3623 3828
 			secureDirectory($path, true);
3624 3829
 			secureDirectory($cachedir);
3625 3830
 
3626 3831
 			// If agreement is enabled, at least the english version shall exists
3627
-			if ($modSettings['requireAgreement'])
3628
-				$agreement = !file_exists($boarddir . '/agreement.txt');
3832
+			if ($modSettings['requireAgreement']) {
3833
+							$agreement = !file_exists($boarddir . '/agreement.txt');
3834
+			}
3629 3835
 
3630 3836
 			if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement))
3631 3837
 			{
@@ -3640,18 +3846,21 @@  discard block
 block discarded – undo
3640 3846
 					echo '
3641 3847
 				', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>';
3642 3848
 
3643
-					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~')
3644
-						echo '
3849
+					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') {
3850
+											echo '
3645 3851
 				', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>';
3852
+					}
3646 3853
 				}
3647 3854
 
3648
-				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir))
3649
-					echo '
3855
+				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) {
3856
+									echo '
3650 3857
 				<strong>', $txt['cache_writable'], '</strong><br>';
3858
+				}
3651 3859
 
3652
-				if (!empty($agreement))
3653
-					echo '
3860
+				if (!empty($agreement)) {
3861
+									echo '
3654 3862
 				<strong>', $txt['agreement_missing'], '</strong><br>';
3863
+				}
3655 3864
 
3656 3865
 				echo '
3657 3866
 			</p>
@@ -3666,16 +3875,18 @@  discard block
 block discarded – undo
3666 3875
 				<div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;">
3667 3876
 					', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']);
3668 3877
 
3669
-			if (!empty($_SESSION['ban']['cannot_post']['reason']))
3670
-				echo '
3878
+			if (!empty($_SESSION['ban']['cannot_post']['reason'])) {
3879
+							echo '
3671 3880
 					<div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>';
3881
+			}
3672 3882
 
3673
-			if (!empty($_SESSION['ban']['expire_time']))
3674
-				echo '
3883
+			if (!empty($_SESSION['ban']['expire_time'])) {
3884
+							echo '
3675 3885
 					<div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>';
3676
-			else
3677
-				echo '
3886
+			} else {
3887
+							echo '
3678 3888
 					<div>', $txt['your_ban_expires_never'], '</div>';
3889
+			}
3679 3890
 
3680 3891
 			echo '
3681 3892
 				</div>';
@@ -3691,8 +3902,9 @@  discard block
 block discarded – undo
3691 3902
 	global $forum_copyright, $software_year, $forum_version;
3692 3903
 
3693 3904
 	// Don't display copyright for things like SSI.
3694
-	if (!isset($forum_version) || !isset($software_year))
3695
-		return;
3905
+	if (!isset($forum_version) || !isset($software_year)) {
3906
+			return;
3907
+	}
3696 3908
 
3697 3909
 	// Put in the version...
3698 3910
 	printf($forum_copyright, $forum_version, $software_year);
@@ -3710,9 +3922,10 @@  discard block
 block discarded – undo
3710 3922
 	$context['load_time'] = round(microtime(true) - $time_start, 3);
3711 3923
 	$context['load_queries'] = $db_count;
3712 3924
 
3713
-	foreach (array_reverse($context['template_layers']) as $layer)
3714
-		loadSubTemplate($layer . '_below', true);
3715
-}
3925
+	foreach (array_reverse($context['template_layers']) as $layer) {
3926
+			loadSubTemplate($layer . '_below', true);
3927
+	}
3928
+	}
3716 3929
 
3717 3930
 /**
3718 3931
  * Output the Javascript files
@@ -3746,8 +3959,7 @@  discard block
 block discarded – undo
3746 3959
 			{
3747 3960
 				echo '
3748 3961
 		var ', $key, ';';
3749
-			}
3750
-			else
3962
+			} else
3751 3963
 			{
3752 3964
 				echo '
3753 3965
 		var ', $key, ' = ', $value, ';';
@@ -3766,27 +3978,29 @@  discard block
 block discarded – undo
3766 3978
 		foreach ($context['javascript_files'] as $id => $js_file)
3767 3979
 		{
3768 3980
 			// Last minute call! allow theme authors to disable single files.
3769
-			if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3770
-				continue;
3981
+			if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3982
+							continue;
3983
+			}
3771 3984
 
3772 3985
 			// By default files don't get minimized unless the file explicitly says so!
3773 3986
 			if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files']))
3774 3987
 			{
3775
-				if (!empty($js_file['options']['async']))
3776
-					$toMinify['async'][] = $js_file;
3777
-				elseif (!empty($js_file['options']['defer']))
3778
-					$toMinify['defer'][] = $js_file;
3779
-				else
3780
-					$toMinify['standard'][] = $js_file;
3988
+				if (!empty($js_file['options']['async'])) {
3989
+									$toMinify['async'][] = $js_file;
3990
+				} elseif (!empty($js_file['options']['defer'])) {
3991
+									$toMinify['defer'][] = $js_file;
3992
+				} else {
3993
+									$toMinify['standard'][] = $js_file;
3994
+				}
3781 3995
 
3782 3996
 				// Grab a random seed.
3783
-				if (!isset($minSeed) && isset($js_file['options']['seed']))
3784
-					$minSeed = $js_file['options']['seed'];
3785
-			}
3786
-
3787
-			else
3788
-				echo '
3997
+				if (!isset($minSeed) && isset($js_file['options']['seed'])) {
3998
+									$minSeed = $js_file['options']['seed'];
3999
+				}
4000
+			} else {
4001
+							echo '
3789 4002
 	<script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async' : '', !empty($js_file['options']['defer']) ? ' defer' : '', '></script>';
4003
+			}
3790 4004
 		}
3791 4005
 
3792 4006
 		foreach ($toMinify as $js_files)
@@ -3797,9 +4011,10 @@  discard block
 block discarded – undo
3797 4011
 
3798 4012
 				$minSuccessful = array_keys($result) === array('smf_minified');
3799 4013
 
3800
-				foreach ($result as $minFile)
3801
-					echo '
4014
+				foreach ($result as $minFile) {
4015
+									echo '
3802 4016
 	<script src="', $minFile['fileUrl'], $minSuccessful && isset($minSeed) ? $minSeed : '', '"', !empty($minFile['options']['async']) ? ' async' : '', !empty($minFile['options']['defer']) ? ' defer' : '', '></script>';
4017
+				}
3803 4018
 			}
3804 4019
 		}
3805 4020
 	}
@@ -3813,8 +4028,9 @@  discard block
 block discarded – undo
3813 4028
 <script>
3814 4029
 window.addEventListener("DOMContentLoaded", function() {';
3815 4030
 
3816
-			foreach ($context['javascript_inline']['defer'] as $js_code)
3817
-				echo $js_code;
4031
+			foreach ($context['javascript_inline']['defer'] as $js_code) {
4032
+							echo $js_code;
4033
+			}
3818 4034
 
3819 4035
 			echo '
3820 4036
 });
@@ -3826,8 +4042,9 @@  discard block
 block discarded – undo
3826 4042
 			echo '
3827 4043
 	<script>';
3828 4044
 
3829
-			foreach ($context['javascript_inline']['standard'] as $js_code)
3830
-				echo $js_code;
4045
+			foreach ($context['javascript_inline']['standard'] as $js_code) {
4046
+							echo $js_code;
4047
+			}
3831 4048
 
3832 4049
 			echo '
3833 4050
 	</script>';
@@ -3855,23 +4072,26 @@  discard block
 block discarded – undo
3855 4072
 	foreach ($context['css_files'] as $id => $file)
3856 4073
 	{
3857 4074
 		// Last minute call! allow theme authors to disable single files.
3858
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3859
-			continue;
4075
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
4076
+					continue;
4077
+		}
3860 4078
 
3861 4079
 		// Files are minimized unless they explicitly opt out.
3862
-		if (!isset($file['options']['minimize']))
3863
-			$file['options']['minimize'] = true;
4080
+		if (!isset($file['options']['minimize'])) {
4081
+					$file['options']['minimize'] = true;
4082
+		}
3864 4083
 
3865 4084
 		if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files']))
3866 4085
 		{
3867 4086
 			$toMinify[] = $file;
3868 4087
 
3869 4088
 			// Grab a random seed.
3870
-			if (!isset($minSeed) && isset($file['options']['seed']))
3871
-				$minSeed = $file['options']['seed'];
4089
+			if (!isset($minSeed) && isset($file['options']['seed'])) {
4090
+							$minSeed = $file['options']['seed'];
4091
+			}
4092
+		} else {
4093
+					$normal[] = $file['fileUrl'];
3872 4094
 		}
3873
-		else
3874
-			$normal[] = $file['fileUrl'];
3875 4095
 	}
3876 4096
 
3877 4097
 	if (!empty($toMinify))
@@ -3880,23 +4100,26 @@  discard block
 block discarded – undo
3880 4100
 
3881 4101
 		$minSuccessful = array_keys($result) === array('smf_minified');
3882 4102
 
3883
-		foreach ($result as $minFile)
3884
-			echo '
4103
+		foreach ($result as $minFile) {
4104
+					echo '
3885 4105
 	<link rel="stylesheet" href="', $minFile['fileUrl'], $minSuccessful && isset($minSeed) ? $minSeed : '', '">';
4106
+		}
3886 4107
 	}
3887 4108
 
3888 4109
 	// Print the rest after the minified files.
3889
-	if (!empty($normal))
3890
-		foreach ($normal as $nf)
4110
+	if (!empty($normal)) {
4111
+			foreach ($normal as $nf)
3891 4112
 			echo '
3892 4113
 	<link rel="stylesheet" href="', $nf ,'">';
4114
+	}
3893 4115
 
3894 4116
 	if ($db_show_debug === true)
3895 4117
 	{
3896 4118
 		// Try to keep only what's useful.
3897 4119
 		$repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => '');
3898
-		foreach ($context['css_files'] as $file)
3899
-			$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
4120
+		foreach ($context['css_files'] as $file) {
4121
+					$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
4122
+		}
3900 4123
 	}
3901 4124
 
3902 4125
 	if (!empty($context['css_header']))
@@ -3904,9 +4127,10 @@  discard block
 block discarded – undo
3904 4127
 		echo '
3905 4128
 	<style>';
3906 4129
 
3907
-		foreach ($context['css_header'] as $css)
3908
-			echo $css .'
4130
+		foreach ($context['css_header'] as $css) {
4131
+					echo $css .'
3909 4132
 	';
4133
+		}
3910 4134
 
3911 4135
 		echo'
3912 4136
 	</style>';
@@ -3929,8 +4153,9 @@  discard block
 block discarded – undo
3929 4153
 	$type = !empty($type) && in_array($type, $types) ? $type : false;
3930 4154
 	$data = is_array($data) ? $data : array();
3931 4155
 
3932
-	if (empty($type) || empty($data))
3933
-		return $data;
4156
+	if (empty($type) || empty($data)) {
4157
+			return $data;
4158
+	}
3934 4159
 
3935 4160
 	// Different pages include different files, so we use a hash to label the different combinations
3936 4161
 	$hash = md5(implode(' ', array_map(function($file) { return $file['filePath'] . (int) @filesize($file['filePath']) . (int) @filemtime($file['filePath']); }, $data)));
@@ -3939,13 +4164,14 @@  discard block
 block discarded – undo
3939 4164
 	list($toCache, $async, $defer) = array_pad((array) cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type . '_' . $hash, 86400), 3, null);
3940 4165
 
3941 4166
 	// Already done?
3942
-	if (!empty($toCache))
3943
-		return array('smf_minified' => array(
4167
+	if (!empty($toCache)) {
4168
+			return array('smf_minified' => array(
3944 4169
 			'fileUrl' => $settings['theme_url'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/' . basename($toCache),
3945 4170
 			'filePath' => $toCache,
3946 4171
 			'fileName' => basename($toCache),
3947 4172
 			'options' => array('async' => !empty($async), 'defer' => !empty($defer)),
3948 4173
 		));
4174
+	}
3949 4175
 
3950 4176
 
3951 4177
 	// No namespaces, sorry!
@@ -3975,9 +4201,9 @@  discard block
 block discarded – undo
3975 4201
 
3976 4202
 	foreach ($data as $id => $file)
3977 4203
 	{
3978
-		if (empty($file['filePath']))
3979
-			$toAdd = false;
3980
-		else
4204
+		if (empty($file['filePath'])) {
4205
+					$toAdd = false;
4206
+		} else
3981 4207
 		{
3982 4208
 			$seed = isset($file['options']['seed']) ? $file['options']['seed'] : '';
3983 4209
 			$tempFile = str_replace($seed, '', $file['filePath']);
@@ -3985,12 +4211,14 @@  discard block
 block discarded – undo
3985 4211
 		}
3986 4212
 
3987 4213
 		// A minified script should only be loaded asynchronously if all its components wanted to be.
3988
-		if (empty($file['options']['async']))
3989
-			$async = false;
4214
+		if (empty($file['options']['async'])) {
4215
+					$async = false;
4216
+		}
3990 4217
 
3991 4218
 		// A minified script should only be deferred if all its components wanted to be.
3992
-		if (empty($file['options']['defer']))
3993
-			$defer = false;
4219
+		if (empty($file['options']['defer'])) {
4220
+					$defer = false;
4221
+		}
3994 4222
 
3995 4223
 		// The file couldn't be located so it won't be added. Log this error.
3996 4224
 		if (empty($toAdd))
@@ -4056,12 +4284,14 @@  discard block
 block discarded – undo
4056 4284
 			foreach (glob(rtrim($theme['dir'], '/') . '/' . ($type == 'css' ? 'css' : 'scripts') . '/minified*.' . $type) as $filename)
4057 4285
 			{
4058 4286
 				// Remove the cache entry
4059
-				if (preg_match('~([a-zA-Z0-9]+)\.' . $type . '$~', $filename, $matches))
4060
-					cache_put_data('minimized_' . $theme['id'] . '_' . $type . '_' . $matches[1], null);
4287
+				if (preg_match('~([a-zA-Z0-9]+)\.' . $type . '$~', $filename, $matches)) {
4288
+									cache_put_data('minimized_' . $theme['id'] . '_' . $type . '_' . $matches[1], null);
4289
+				}
4061 4290
 
4062 4291
 				// Try to delete the file. Add it to our error list if it fails.
4063
-				if (!@unlink($filename))
4064
-					$not_deleted[] = $filename;
4292
+				if (!@unlink($filename)) {
4293
+									$not_deleted[] = $filename;
4294
+				}
4065 4295
 			}
4066 4296
 		}
4067 4297
 	}
@@ -4093,8 +4323,9 @@  discard block
 block discarded – undo
4093 4323
 	global $modSettings, $smcFunc;
4094 4324
 
4095 4325
 	// Just make up a nice hash...
4096
-	if ($new)
4097
-		return sha1(md5($filename . time()) . mt_rand());
4326
+	if ($new) {
4327
+			return sha1(md5($filename . time()) . mt_rand());
4328
+	}
4098 4329
 
4099 4330
 	// Just make sure that attachment id is only a int
4100 4331
 	$attachment_id = (int) $attachment_id;
@@ -4111,23 +4342,25 @@  discard block
 block discarded – undo
4111 4342
 				'id_attach' => $attachment_id,
4112 4343
 			));
4113 4344
 
4114
-		if ($smcFunc['db_num_rows']($request) === 0)
4115
-			return false;
4345
+		if ($smcFunc['db_num_rows']($request) === 0) {
4346
+					return false;
4347
+		}
4116 4348
 
4117 4349
 		list ($file_hash) = $smcFunc['db_fetch_row']($request);
4118 4350
 		$smcFunc['db_free_result']($request);
4119 4351
 	}
4120 4352
 
4121 4353
 	// Still no hash? mmm...
4122
-	if (empty($file_hash))
4123
-		$file_hash = sha1(md5($filename . time()) . mt_rand());
4354
+	if (empty($file_hash)) {
4355
+			$file_hash = sha1(md5($filename . time()) . mt_rand());
4356
+	}
4124 4357
 
4125 4358
 	// Are we using multiple directories?
4126
-	if (is_array($modSettings['attachmentUploadDir']))
4127
-		$path = $modSettings['attachmentUploadDir'][$dir];
4128
-
4129
-	else
4130
-		$path = $modSettings['attachmentUploadDir'];
4359
+	if (is_array($modSettings['attachmentUploadDir'])) {
4360
+			$path = $modSettings['attachmentUploadDir'][$dir];
4361
+	} else {
4362
+			$path = $modSettings['attachmentUploadDir'];
4363
+	}
4131 4364
 
4132 4365
 	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
4133 4366
 }
@@ -4142,8 +4375,9 @@  discard block
 block discarded – undo
4142 4375
 function ip2range($fullip)
4143 4376
 {
4144 4377
 	// Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.)
4145
-	if ($fullip == 'unknown')
4146
-		$fullip = '255.255.255.255';
4378
+	if ($fullip == 'unknown') {
4379
+			$fullip = '255.255.255.255';
4380
+	}
4147 4381
 
4148 4382
 	$ip_parts = explode('-', $fullip);
4149 4383
 	$ip_array = array();
@@ -4167,10 +4401,11 @@  discard block
 block discarded – undo
4167 4401
 		$ip_array['low'] = $ip_parts[0];
4168 4402
 		$ip_array['high'] = $ip_parts[1];
4169 4403
 		return $ip_array;
4170
-	}
4171
-	elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.*
4404
+	} elseif (count($ip_parts) == 2) {
4405
+		// if ip 22.22.*-22.22.*
4172 4406
 	{
4173 4407
 		$valid_low = isValidIP($ip_parts[0]);
4408
+	}
4174 4409
 		$valid_high = isValidIP($ip_parts[1]);
4175 4410
 		$count = 0;
4176 4411
 		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
@@ -4185,7 +4420,9 @@  discard block
 block discarded – undo
4185 4420
 				$ip_parts[0] .= $mode . $min;
4186 4421
 				$valid_low = isValidIP($ip_parts[0]);
4187 4422
 				$count++;
4188
-				if ($count > 9) break;
4423
+				if ($count > 9) {
4424
+					break;
4425
+				}
4189 4426
 			}
4190 4427
 		}
4191 4428
 
@@ -4199,7 +4436,9 @@  discard block
 block discarded – undo
4199 4436
 				$ip_parts[1] .= $mode . $max;
4200 4437
 				$valid_high = isValidIP($ip_parts[1]);
4201 4438
 				$count++;
4202
-				if ($count > 9) break;
4439
+				if ($count > 9) {
4440
+					break;
4441
+				}
4203 4442
 			}
4204 4443
 		}
4205 4444
 
@@ -4223,46 +4462,54 @@  discard block
 block discarded – undo
4223 4462
 {
4224 4463
 	global $modSettings;
4225 4464
 
4226
-	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null)
4227
-		return $host;
4465
+	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) {
4466
+			return $host;
4467
+	}
4228 4468
 	$t = microtime();
4229 4469
 
4230 4470
 	// Try the Linux host command, perhaps?
4231 4471
 	if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1)
4232 4472
 	{
4233
-		if (!isset($modSettings['host_to_dis']))
4234
-			$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
4235
-		else
4236
-			$test = @shell_exec('host ' . @escapeshellarg($ip));
4473
+		if (!isset($modSettings['host_to_dis'])) {
4474
+					$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
4475
+		} else {
4476
+					$test = @shell_exec('host ' . @escapeshellarg($ip));
4477
+		}
4237 4478
 
4238 4479
 		// Did host say it didn't find anything?
4239
-		if (strpos($test, 'not found') !== false)
4240
-			$host = '';
4480
+		if (strpos($test, 'not found') !== false) {
4481
+					$host = '';
4482
+		}
4241 4483
 		// Invalid server option?
4242
-		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis']))
4243
-			updateSettings(array('host_to_dis' => 1));
4484
+		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) {
4485
+					updateSettings(array('host_to_dis' => 1));
4486
+		}
4244 4487
 		// Maybe it found something, after all?
4245
-		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1)
4246
-			$host = $match[1];
4488
+		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) {
4489
+					$host = $match[1];
4490
+		}
4247 4491
 	}
4248 4492
 
4249 4493
 	// This is nslookup; usually only Windows, but possibly some Unix?
4250 4494
 	if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1)
4251 4495
 	{
4252 4496
 		$test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip));
4253
-		if (strpos($test, 'Non-existent domain') !== false)
4254
-			$host = '';
4255
-		elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1)
4256
-			$host = $match[1];
4497
+		if (strpos($test, 'Non-existent domain') !== false) {
4498
+					$host = '';
4499
+		} elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) {
4500
+					$host = $match[1];
4501
+		}
4257 4502
 	}
4258 4503
 
4259 4504
 	// This is the last try :/.
4260
-	if (!isset($host) || $host === false)
4261
-		$host = @gethostbyaddr($ip);
4505
+	if (!isset($host) || $host === false) {
4506
+			$host = @gethostbyaddr($ip);
4507
+	}
4262 4508
 
4263 4509
 	// It took a long time, so let's cache it!
4264
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5)
4265
-		cache_put_data('hostlookup-' . $ip, $host, 600);
4510
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) {
4511
+			cache_put_data('hostlookup-' . $ip, $host, 600);
4512
+	}
4266 4513
 
4267 4514
 	return $host;
4268 4515
 }
@@ -4298,20 +4545,21 @@  discard block
 block discarded – undo
4298 4545
 			{
4299 4546
 				$encrypted = substr(crypt($word, 'uk'), 2, $max_chars);
4300 4547
 				$total = 0;
4301
-				for ($i = 0; $i < $max_chars; $i++)
4302
-					$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4548
+				for ($i = 0; $i < $max_chars; $i++) {
4549
+									$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4550
+				}
4303 4551
 				$returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total;
4304 4552
 			}
4305 4553
 		}
4306 4554
 		return array_unique($returned_ints);
4307
-	}
4308
-	else
4555
+	} else
4309 4556
 	{
4310 4557
 		// Trim characters before and after and add slashes for database insertion.
4311 4558
 		$returned_words = array();
4312
-		foreach ($words as $word)
4313
-			if (($word = trim($word, '-_\'')) !== '')
4559
+		foreach ($words as $word) {
4560
+					if (($word = trim($word, '-_\'')) !== '')
4314 4561
 				$returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars);
4562
+		}
4315 4563
 
4316 4564
 		// Filter out all words that occur more than once.
4317 4565
 		return array_unique($returned_words);
@@ -4333,16 +4581,18 @@  discard block
 block discarded – undo
4333 4581
 	global $settings, $txt;
4334 4582
 
4335 4583
 	// Does the current loaded theme have this and we are not forcing the usage of this function?
4336
-	if (function_exists('template_create_button') && !$force_use)
4337
-		return template_create_button($name, $alt, $label = '', $custom = '');
4584
+	if (function_exists('template_create_button') && !$force_use) {
4585
+			return template_create_button($name, $alt, $label = '', $custom = '');
4586
+	}
4338 4587
 
4339
-	if (!$settings['use_image_buttons'])
4340
-		return $txt[$alt];
4341
-	elseif (!empty($settings['use_buttons']))
4342
-		return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
4343
-	else
4344
-		return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
4345
-}
4588
+	if (!$settings['use_image_buttons']) {
4589
+			return $txt[$alt];
4590
+	} elseif (!empty($settings['use_buttons'])) {
4591
+			return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
4592
+	} else {
4593
+			return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
4594
+	}
4595
+	}
4346 4596
 
4347 4597
 /**
4348 4598
  * Sets up all of the top menu buttons
@@ -4385,9 +4635,10 @@  discard block
 block discarded – undo
4385 4635
 	var user_menus = new smc_PopupMenu();
4386 4636
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
4387 4637
 	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
4388
-		if ($context['allow_pm'])
4389
-			addInlineJavaScript('
4638
+		if ($context['allow_pm']) {
4639
+					addInlineJavaScript('
4390 4640
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
4641
+		}
4391 4642
 
4392 4643
 		if (!empty($modSettings['enable_ajax_alerts']))
4393 4644
 		{
@@ -4547,88 +4798,96 @@  discard block
 block discarded – undo
4547 4798
 
4548 4799
 		// Now we put the buttons in the context so the theme can use them.
4549 4800
 		$menu_buttons = array();
4550
-		foreach ($buttons as $act => $button)
4551
-			if (!empty($button['show']))
4801
+		foreach ($buttons as $act => $button) {
4802
+					if (!empty($button['show']))
4552 4803
 			{
4553 4804
 				$button['active_button'] = false;
4805
+		}
4554 4806
 
4555 4807
 				// This button needs some action.
4556
-				if (isset($button['action_hook']))
4557
-					$needs_action_hook = true;
4808
+				if (isset($button['action_hook'])) {
4809
+									$needs_action_hook = true;
4810
+				}
4558 4811
 
4559 4812
 				// Make sure the last button truly is the last button.
4560 4813
 				if (!empty($button['is_last']))
4561 4814
 				{
4562
-					if (isset($last_button))
4563
-						unset($menu_buttons[$last_button]['is_last']);
4815
+					if (isset($last_button)) {
4816
+											unset($menu_buttons[$last_button]['is_last']);
4817
+					}
4564 4818
 					$last_button = $act;
4565 4819
 				}
4566 4820
 
4567 4821
 				// Go through the sub buttons if there are any.
4568
-				if (!empty($button['sub_buttons']))
4569
-					foreach ($button['sub_buttons'] as $key => $subbutton)
4822
+				if (!empty($button['sub_buttons'])) {
4823
+									foreach ($button['sub_buttons'] as $key => $subbutton)
4570 4824
 					{
4571 4825
 						if (empty($subbutton['show']))
4572 4826
 							unset($button['sub_buttons'][$key]);
4827
+				}
4573 4828
 
4574 4829
 						// 2nd level sub buttons next...
4575 4830
 						if (!empty($subbutton['sub_buttons']))
4576 4831
 						{
4577 4832
 							foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2)
4578 4833
 							{
4579
-								if (empty($sub_button2['show']))
4580
-									unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4834
+								if (empty($sub_button2['show'])) {
4835
+																	unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4836
+								}
4581 4837
 							}
4582 4838
 						}
4583 4839
 					}
4584 4840
 
4585 4841
 				// Does this button have its own icon?
4586
-				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon']))
4587
-					$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4588
-				elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon']))
4589
-					$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4590
-				elseif (isset($button['icon']))
4591
-					$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4592
-				else
4593
-					$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4842
+				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) {
4843
+									$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4844
+				} elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) {
4845
+									$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4846
+				} elseif (isset($button['icon'])) {
4847
+									$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4848
+				} else {
4849
+									$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4850
+				}
4594 4851
 
4595 4852
 				$menu_buttons[$act] = $button;
4596 4853
 			}
4597 4854
 
4598
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
4599
-			cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4855
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
4856
+					cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4857
+		}
4600 4858
 	}
4601 4859
 
4602 4860
 	$context['menu_buttons'] = $menu_buttons;
4603 4861
 
4604 4862
 	// Logging out requires the session id in the url.
4605
-	if (isset($context['menu_buttons']['logout']))
4606
-		$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4863
+	if (isset($context['menu_buttons']['logout'])) {
4864
+			$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4865
+	}
4607 4866
 
4608 4867
 	// Figure out which action we are doing so we can set the active tab.
4609 4868
 	// Default to home.
4610 4869
 	$current_action = 'home';
4611 4870
 
4612
-	if (isset($context['menu_buttons'][$context['current_action']]))
4613
-		$current_action = $context['current_action'];
4614
-	elseif ($context['current_action'] == 'search2')
4615
-		$current_action = 'search';
4616
-	elseif ($context['current_action'] == 'theme')
4617
-		$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4618
-	elseif ($context['current_action'] == 'register2')
4619
-		$current_action = 'register';
4620
-	elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder'))
4621
-		$current_action = 'login';
4622
-	elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center'])
4623
-		$current_action = 'moderate';
4871
+	if (isset($context['menu_buttons'][$context['current_action']])) {
4872
+			$current_action = $context['current_action'];
4873
+	} elseif ($context['current_action'] == 'search2') {
4874
+			$current_action = 'search';
4875
+	} elseif ($context['current_action'] == 'theme') {
4876
+			$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4877
+	} elseif ($context['current_action'] == 'register2') {
4878
+			$current_action = 'register';
4879
+	} elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) {
4880
+			$current_action = 'login';
4881
+	} elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) {
4882
+			$current_action = 'moderate';
4883
+	}
4624 4884
 
4625 4885
 	// There are certain exceptions to the above where we don't want anything on the menu highlighted.
4626 4886
 	if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner']))
4627 4887
 	{
4628 4888
 		$current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile';
4629 4889
 		$context[$current_action] = true;
4630
-	}
4631
-	elseif ($context['current_action'] == 'pm')
4890
+	} elseif ($context['current_action'] == 'pm')
4632 4891
 	{
4633 4892
 		$current_action = 'self_pm';
4634 4893
 		$context['self_pm'] = true;
@@ -4685,12 +4944,14 @@  discard block
 block discarded – undo
4685 4944
 	}
4686 4945
 
4687 4946
 	// Not all actions are simple.
4688
-	if (!empty($needs_action_hook))
4689
-		call_integration_hook('integrate_current_action', array(&$current_action));
4947
+	if (!empty($needs_action_hook)) {
4948
+			call_integration_hook('integrate_current_action', array(&$current_action));
4949
+	}
4690 4950
 
4691
-	if (isset($context['menu_buttons'][$current_action]))
4692
-		$context['menu_buttons'][$current_action]['active_button'] = true;
4693
-}
4951
+	if (isset($context['menu_buttons'][$current_action])) {
4952
+			$context['menu_buttons'][$current_action]['active_button'] = true;
4953
+	}
4954
+	}
4694 4955
 
4695 4956
 /**
4696 4957
  * Generate a random seed and ensure it's stored in settings.
@@ -4714,30 +4975,35 @@  discard block
 block discarded – undo
4714 4975
 	global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug;
4715 4976
 	global $context, $txt;
4716 4977
 
4717
-	if ($db_show_debug === true)
4718
-		$context['debug']['hooks'][] = $hook;
4978
+	if ($db_show_debug === true) {
4979
+			$context['debug']['hooks'][] = $hook;
4980
+	}
4719 4981
 
4720 4982
 	// Need to have some control.
4721
-	if (!isset($context['instances']))
4722
-		$context['instances'] = array();
4983
+	if (!isset($context['instances'])) {
4984
+			$context['instances'] = array();
4985
+	}
4723 4986
 
4724 4987
 	$results = array();
4725
-	if (empty($modSettings[$hook]))
4726
-		return $results;
4988
+	if (empty($modSettings[$hook])) {
4989
+			return $results;
4990
+	}
4727 4991
 
4728 4992
 	$functions = explode(',', $modSettings[$hook]);
4729 4993
 	// Loop through each function.
4730 4994
 	foreach ($functions as $function)
4731 4995
 	{
4732 4996
 		// Hook has been marked as "disabled". Skip it!
4733
-		if (strpos($function, '!') !== false)
4734
-			continue;
4997
+		if (strpos($function, '!') !== false) {
4998
+					continue;
4999
+		}
4735 5000
 
4736 5001
 		$call = call_helper($function, true);
4737 5002
 
4738 5003
 		// Is it valid?
4739
-		if (!empty($call))
4740
-			$results[$function] = call_user_func_array($call, $parameters);
5004
+		if (!empty($call)) {
5005
+					$results[$function] = call_user_func_array($call, $parameters);
5006
+		}
4741 5007
 
4742 5008
 		// Whatever it was suppose to call, it failed :(
4743 5009
 		elseif (!empty($function))
@@ -4753,8 +5019,9 @@  discard block
 block discarded – undo
4753 5019
 			}
4754 5020
 
4755 5021
 			// "Assume" the file resides on $boarddir somewhere...
4756
-			else
4757
-				log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
5022
+			else {
5023
+							log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
5024
+			}
4758 5025
 		}
4759 5026
 	}
4760 5027
 
@@ -4776,12 +5043,14 @@  discard block
 block discarded – undo
4776 5043
 	global $smcFunc, $modSettings;
4777 5044
 
4778 5045
 	// Any objects?
4779
-	if ($object)
4780
-		$function = $function . '#';
5046
+	if ($object) {
5047
+			$function = $function . '#';
5048
+	}
4781 5049
 
4782 5050
 	// Any files  to load?
4783
-	if (!empty($file) && is_string($file))
4784
-		$function = $file . (!empty($function) ? '|' . $function : '');
5051
+	if (!empty($file) && is_string($file)) {
5052
+			$function = $file . (!empty($function) ? '|' . $function : '');
5053
+	}
4785 5054
 
4786 5055
 	// Get the correct string.
4787 5056
 	$integration_call = $function;
@@ -4803,13 +5072,14 @@  discard block
 block discarded – undo
4803 5072
 		if (!empty($current_functions))
4804 5073
 		{
4805 5074
 			$current_functions = explode(',', $current_functions);
4806
-			if (in_array($integration_call, $current_functions))
4807
-				return;
5075
+			if (in_array($integration_call, $current_functions)) {
5076
+							return;
5077
+			}
4808 5078
 
4809 5079
 			$permanent_functions = array_merge($current_functions, array($integration_call));
5080
+		} else {
5081
+					$permanent_functions = array($integration_call);
4810 5082
 		}
4811
-		else
4812
-			$permanent_functions = array($integration_call);
4813 5083
 
4814 5084
 		updateSettings(array($hook => implode(',', $permanent_functions)));
4815 5085
 	}
@@ -4818,8 +5088,9 @@  discard block
 block discarded – undo
4818 5088
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4819 5089
 
4820 5090
 	// Do nothing, if it's already there.
4821
-	if (in_array($integration_call, $functions))
4822
-		return;
5091
+	if (in_array($integration_call, $functions)) {
5092
+			return;
5093
+	}
4823 5094
 
4824 5095
 	$functions[] = $integration_call;
4825 5096
 	$modSettings[$hook] = implode(',', $functions);
@@ -4842,12 +5113,14 @@  discard block
 block discarded – undo
4842 5113
 	global $smcFunc, $modSettings;
4843 5114
 
4844 5115
 	// Any objects?
4845
-	if ($object)
4846
-		$function = $function . '#';
5116
+	if ($object) {
5117
+			$function = $function . '#';
5118
+	}
4847 5119
 
4848 5120
 	// Any files  to load?
4849
-	if (!empty($file) && is_string($file))
4850
-		$function = $file . '|' . $function;
5121
+	if (!empty($file) && is_string($file)) {
5122
+			$function = $file . '|' . $function;
5123
+	}
4851 5124
 
4852 5125
 	// Get the correct string.
4853 5126
 	$integration_call = $function;
@@ -4868,16 +5141,18 @@  discard block
 block discarded – undo
4868 5141
 	{
4869 5142
 		$current_functions = explode(',', $current_functions);
4870 5143
 
4871
-		if (in_array($integration_call, $current_functions))
4872
-			updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
5144
+		if (in_array($integration_call, $current_functions)) {
5145
+					updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
5146
+		}
4873 5147
 	}
4874 5148
 
4875 5149
 	// Turn the function list into something usable.
4876 5150
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4877 5151
 
4878 5152
 	// You can only remove it if it's available.
4879
-	if (!in_array($integration_call, $functions))
4880
-		return;
5153
+	if (!in_array($integration_call, $functions)) {
5154
+			return;
5155
+	}
4881 5156
 
4882 5157
 	$functions = array_diff($functions, array($integration_call));
4883 5158
 	$modSettings[$hook] = implode(',', $functions);
@@ -4898,17 +5173,20 @@  discard block
 block discarded – undo
4898 5173
 	global $context, $smcFunc, $txt, $db_show_debug;
4899 5174
 
4900 5175
 	// Really?
4901
-	if (empty($string))
4902
-		return false;
5176
+	if (empty($string)) {
5177
+			return false;
5178
+	}
4903 5179
 
4904 5180
 	// An array? should be a "callable" array IE array(object/class, valid_callable).
4905 5181
 	// A closure? should be a callable one.
4906
-	if (is_array($string) || $string instanceof Closure)
4907
-		return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
5182
+	if (is_array($string) || $string instanceof Closure) {
5183
+			return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
5184
+	}
4908 5185
 
4909 5186
 	// No full objects, sorry! pass a method or a property instead!
4910
-	if (is_object($string))
4911
-		return false;
5187
+	if (is_object($string)) {
5188
+			return false;
5189
+	}
4912 5190
 
4913 5191
 	// Stay vitaminized my friends...
4914 5192
 	$string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string));
@@ -4917,8 +5195,9 @@  discard block
 block discarded – undo
4917 5195
 	$string = load_file($string);
4918 5196
 
4919 5197
 	// Loaded file failed
4920
-	if (empty($string))
4921
-		return false;
5198
+	if (empty($string)) {
5199
+			return false;
5200
+	}
4922 5201
 
4923 5202
 	// Found a method.
4924 5203
 	if (strpos($string, '::') !== false)
@@ -4939,8 +5218,9 @@  discard block
 block discarded – undo
4939 5218
 				// Add another one to the list.
4940 5219
 				if ($db_show_debug === true)
4941 5220
 				{
4942
-					if (!isset($context['debug']['instances']))
4943
-						$context['debug']['instances'] = array();
5221
+					if (!isset($context['debug']['instances'])) {
5222
+											$context['debug']['instances'] = array();
5223
+					}
4944 5224
 
4945 5225
 					$context['debug']['instances'][$class] = $class;
4946 5226
 				}
@@ -4950,13 +5230,15 @@  discard block
 block discarded – undo
4950 5230
 		}
4951 5231
 
4952 5232
 		// Right then. This is a call to a static method.
4953
-		else
4954
-			$func = array($class, $method);
5233
+		else {
5234
+					$func = array($class, $method);
5235
+		}
4955 5236
 	}
4956 5237
 
4957 5238
 	// Nope! just a plain regular function.
4958
-	else
4959
-		$func = $string;
5239
+	else {
5240
+			$func = $string;
5241
+	}
4960 5242
 
4961 5243
 	// Right, we got what we need, time to do some checks.
4962 5244
 	if (!is_callable($func, false, $callable_name))
@@ -4972,17 +5254,18 @@  discard block
 block discarded – undo
4972 5254
 	else
4973 5255
 	{
4974 5256
 		// What are we gonna do about it?
4975
-		if ($return)
4976
-			return $func;
5257
+		if ($return) {
5258
+					return $func;
5259
+		}
4977 5260
 
4978 5261
 		// If this is a plain function, avoid the heat of calling call_user_func().
4979 5262
 		else
4980 5263
 		{
4981
-			if (is_array($func))
4982
-				call_user_func($func);
4983
-
4984
-			else
4985
-				$func();
5264
+			if (is_array($func)) {
5265
+							call_user_func($func);
5266
+			} else {
5267
+							$func();
5268
+			}
4986 5269
 		}
4987 5270
 	}
4988 5271
 }
@@ -4999,31 +5282,34 @@  discard block
 block discarded – undo
4999 5282
 {
5000 5283
 	global $sourcedir, $txt, $boarddir, $settings;
5001 5284
 
5002
-	if (empty($string))
5003
-		return false;
5285
+	if (empty($string)) {
5286
+			return false;
5287
+	}
5004 5288
 
5005 5289
 	if (strpos($string, '|') !== false)
5006 5290
 	{
5007 5291
 		list ($file, $string) = explode('|', $string);
5008 5292
 
5009 5293
 		// Match the wildcards to their regular vars.
5010
-		if (empty($settings['theme_dir']))
5011
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
5012
-
5013
-		else
5014
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
5294
+		if (empty($settings['theme_dir'])) {
5295
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
5296
+		} else {
5297
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
5298
+		}
5015 5299
 
5016 5300
 		// Load the file if it can be loaded.
5017
-		if (file_exists($absPath))
5018
-			require_once($absPath);
5301
+		if (file_exists($absPath)) {
5302
+					require_once($absPath);
5303
+		}
5019 5304
 
5020 5305
 		// No? try a fallback to $sourcedir
5021 5306
 		else
5022 5307
 		{
5023 5308
 			$absPath = $sourcedir .'/'. $file;
5024 5309
 
5025
-			if (file_exists($absPath))
5026
-				require_once($absPath);
5310
+			if (file_exists($absPath)) {
5311
+							require_once($absPath);
5312
+			}
5027 5313
 
5028 5314
 			// Sorry, can't do much for you at this point.
5029 5315
 			else
@@ -5062,8 +5348,9 @@  discard block
 block discarded – undo
5062 5348
 	preg_match('~^(http|ftp)(s)?://([^/:]+)(:(\d+))?(.+)$~', $url, $match);
5063 5349
 
5064 5350
 	// No scheme? No data for you!
5065
-	if (empty($match[1]))
5066
-		return false;
5351
+	if (empty($match[1])) {
5352
+			return false;
5353
+	}
5067 5354
 
5068 5355
 	// An FTP url. We should try connecting and RETRieving it...
5069 5356
 	elseif ($match[1] == 'ftp')
@@ -5073,23 +5360,26 @@  discard block
 block discarded – undo
5073 5360
 
5074 5361
 		// Establish a connection and attempt to enable passive mode.
5075 5362
 		$ftp = new ftp_connection(($match[2] ? 'ssl://' : '') . $match[3], empty($match[5]) ? 21 : $match[5], 'anonymous', $webmaster_email);
5076
-		if ($ftp->error !== false || !$ftp->passive())
5077
-			return false;
5363
+		if ($ftp->error !== false || !$ftp->passive()) {
5364
+					return false;
5365
+		}
5078 5366
 
5079 5367
 		// I want that one *points*!
5080 5368
 		fwrite($ftp->connection, 'RETR ' . $match[6] . "\r\n");
5081 5369
 
5082 5370
 		// Since passive mode worked (or we would have returned already!) open the connection.
5083 5371
 		$fp = @fsockopen($ftp->pasv['ip'], $ftp->pasv['port'], $err, $err, 5);
5084
-		if (!$fp)
5085
-			return false;
5372
+		if (!$fp) {
5373
+					return false;
5374
+		}
5086 5375
 
5087 5376
 		// The server should now say something in acknowledgement.
5088 5377
 		$ftp->check_response(150);
5089 5378
 
5090 5379
 		$data = '';
5091
-		while (!feof($fp))
5092
-			$data .= fread($fp, 4096);
5380
+		while (!feof($fp)) {
5381
+					$data .= fread($fp, 4096);
5382
+		}
5093 5383
 		fclose($fp);
5094 5384
 
5095 5385
 		// All done, right?  Good.
@@ -5101,8 +5391,9 @@  discard block
 block discarded – undo
5101 5391
 	elseif (isset($match[1]) && $match[1] == 'http')
5102 5392
 	{
5103 5393
 		// First try to use fsockopen, because it is fastest.
5104
-		if ($keep_alive && $match[3] == $keep_alive_dom)
5105
-			$fp = $keep_alive_fp;
5394
+		if ($keep_alive && $match[3] == $keep_alive_dom) {
5395
+					$fp = $keep_alive_fp;
5396
+		}
5106 5397
 		if (empty($fp))
5107 5398
 		{
5108 5399
 			// Open the socket on the port we want...
@@ -5122,20 +5413,21 @@  discard block
 block discarded – undo
5122 5413
 				fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n");
5123 5414
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
5124 5415
 				fwrite($fp, 'user-agent: PHP/SMF' . "\r\n");
5125
-				if ($keep_alive)
5126
-					fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
5127
-				else
5128
-					fwrite($fp, 'connection: close' . "\r\n\r\n");
5129
-			}
5130
-			else
5416
+				if ($keep_alive) {
5417
+									fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
5418
+				} else {
5419
+									fwrite($fp, 'connection: close' . "\r\n\r\n");
5420
+				}
5421
+			} else
5131 5422
 			{
5132 5423
 				fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n");
5133 5424
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
5134 5425
 				fwrite($fp, 'user-agent: PHP/SMF' . "\r\n");
5135
-				if ($keep_alive)
5136
-					fwrite($fp, 'connection: Keep-Alive' . "\r\n");
5137
-				else
5138
-					fwrite($fp, 'connection: close' . "\r\n");
5426
+				if ($keep_alive) {
5427
+									fwrite($fp, 'connection: Keep-Alive' . "\r\n");
5428
+				} else {
5429
+									fwrite($fp, 'connection: close' . "\r\n");
5430
+				}
5139 5431
 				fwrite($fp, 'content-type: application/x-www-form-urlencoded' . "\r\n");
5140 5432
 				fwrite($fp, 'content-length: ' . strlen($post_data) . "\r\n\r\n");
5141 5433
 				fwrite($fp, $post_data);
@@ -5148,30 +5440,33 @@  discard block
 block discarded – undo
5148 5440
 			{
5149 5441
 				$header = '';
5150 5442
 				$location = '';
5151
-				while (!feof($fp) && trim($header = fgets($fp, 4096)) != '')
5152
-					if (strpos($header, 'location:') !== false)
5443
+				while (!feof($fp) && trim($header = fgets($fp, 4096)) != '') {
5444
+									if (strpos($header, 'location:') !== false)
5153 5445
 						$location = trim(substr($header, strpos($header, ':') + 1));
5446
+				}
5154 5447
 
5155
-				if (empty($location))
5156
-					return false;
5157
-				else
5448
+				if (empty($location)) {
5449
+									return false;
5450
+				} else
5158 5451
 				{
5159
-					if (!$keep_alive)
5160
-						fclose($fp);
5452
+					if (!$keep_alive) {
5453
+											fclose($fp);
5454
+					}
5161 5455
 					return fetch_web_data($location, $post_data, $keep_alive, $redirection_level + 1);
5162 5456
 				}
5163 5457
 			}
5164 5458
 
5165 5459
 			// Make sure we get a 200 OK.
5166
-			elseif (preg_match('~^HTTP/\S+\s+20[01]~i', $response) === 0)
5167
-				return false;
5460
+			elseif (preg_match('~^HTTP/\S+\s+20[01]~i', $response) === 0) {
5461
+							return false;
5462
+			}
5168 5463
 
5169 5464
 			// Skip the headers...
5170 5465
 			while (!feof($fp) && trim($header = fgets($fp, 4096)) != '')
5171 5466
 			{
5172
-				if (preg_match('~content-length:\s*(\d+)~i', $header, $match) != 0)
5173
-					$content_length = $match[1];
5174
-				elseif (preg_match('~connection:\s*close~i', $header) != 0)
5467
+				if (preg_match('~content-length:\s*(\d+)~i', $header, $match) != 0) {
5468
+									$content_length = $match[1];
5469
+				} elseif (preg_match('~connection:\s*close~i', $header) != 0)
5175 5470
 				{
5176 5471
 					$keep_alive_dom = null;
5177 5472
 					$keep_alive = false;
@@ -5183,17 +5478,19 @@  discard block
 block discarded – undo
5183 5478
 			$data = '';
5184 5479
 			if (isset($content_length))
5185 5480
 			{
5186
-				while (!feof($fp) && strlen($data) < $content_length)
5187
-					$data .= fread($fp, $content_length - strlen($data));
5188
-			}
5189
-			else
5481
+				while (!feof($fp) && strlen($data) < $content_length) {
5482
+									$data .= fread($fp, $content_length - strlen($data));
5483
+				}
5484
+			} else
5190 5485
 			{
5191
-				while (!feof($fp))
5192
-					$data .= fread($fp, 4096);
5486
+				while (!feof($fp)) {
5487
+									$data .= fread($fp, 4096);
5488
+				}
5193 5489
 			}
5194 5490
 
5195
-			if (!$keep_alive)
5196
-				fclose($fp);
5491
+			if (!$keep_alive) {
5492
+							fclose($fp);
5493
+			}
5197 5494
 		}
5198 5495
 
5199 5496
 		// If using fsockopen didn't work, try to use cURL if available.
@@ -5206,17 +5503,18 @@  discard block
 block discarded – undo
5206 5503
 			$fetch_data->get_url_data($url, $post_data);
5207 5504
 
5208 5505
 			// no errors and a 200 result, then we have a good dataset, well we at least have data. ;)
5209
-			if ($fetch_data->result('code') == 200 && !$fetch_data->result('error'))
5210
-				$data = $fetch_data->result('body');
5211
-			else
5212
-				return false;
5506
+			if ($fetch_data->result('code') == 200 && !$fetch_data->result('error')) {
5507
+							$data = $fetch_data->result('body');
5508
+			} else {
5509
+							return false;
5510
+			}
5213 5511
 		}
5214 5512
 
5215 5513
 		// Neither fsockopen nor curl are available. Well, phooey.
5216
-		else
5217
-			return false;
5218
-	}
5219
-	else
5514
+		else {
5515
+					return false;
5516
+		}
5517
+	} else
5220 5518
 	{
5221 5519
 		// Umm, this shouldn't happen?
5222 5520
 		trigger_error('fetch_web_data(): Bad URL', E_USER_NOTICE);
@@ -5236,8 +5534,9 @@  discard block
 block discarded – undo
5236 5534
 	global $user_info, $smcFunc;
5237 5535
 
5238 5536
 	// Make sure we have something to work with.
5239
-	if (empty($topic))
5240
-		return array();
5537
+	if (empty($topic)) {
5538
+			return array();
5539
+	}
5241 5540
 
5242 5541
 
5243 5542
 	// We already know the number of likes per message, we just want to know whether the current user liked it or not.
@@ -5260,8 +5559,9 @@  discard block
 block discarded – undo
5260 5559
 				'topic' => $topic,
5261 5560
 			)
5262 5561
 		);
5263
-		while ($row = $smcFunc['db_fetch_assoc']($request))
5264
-			$temp[] = (int) $row['content_id'];
5562
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
5563
+					$temp[] = (int) $row['content_id'];
5564
+		}
5265 5565
 
5266 5566
 		cache_put_data($cache_key, $temp, $ttl);
5267 5567
 	}
@@ -5282,8 +5582,9 @@  discard block
 block discarded – undo
5282 5582
 {
5283 5583
 	global $context;
5284 5584
 
5285
-	if (empty($string))
5286
-		return $string;
5585
+	if (empty($string)) {
5586
+			return $string;
5587
+	}
5287 5588
 
5288 5589
 	// UTF-8 occurences of MS special characters
5289 5590
 	$findchars_utf8 = array(
@@ -5324,10 +5625,11 @@  discard block
 block discarded – undo
5324 5625
 		'--',	// &mdash;
5325 5626
 	);
5326 5627
 
5327
-	if ($context['utf8'])
5328
-		$string = str_replace($findchars_utf8, $replacechars, $string);
5329
-	else
5330
-		$string = str_replace($findchars_iso, $replacechars, $string);
5628
+	if ($context['utf8']) {
5629
+			$string = str_replace($findchars_utf8, $replacechars, $string);
5630
+	} else {
5631
+			$string = str_replace($findchars_iso, $replacechars, $string);
5632
+	}
5331 5633
 
5332 5634
 	return $string;
5333 5635
 }
@@ -5346,49 +5648,59 @@  discard block
 block discarded – undo
5346 5648
 {
5347 5649
 	global $context;
5348 5650
 
5349
-	if (!isset($matches[2]))
5350
-		return '';
5651
+	if (!isset($matches[2])) {
5652
+			return '';
5653
+	}
5351 5654
 
5352 5655
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
5353 5656
 
5354 5657
 	// remove left to right / right to left overrides
5355
-	if ($num === 0x202D || $num === 0x202E)
5356
-		return '';
5658
+	if ($num === 0x202D || $num === 0x202E) {
5659
+			return '';
5660
+	}
5357 5661
 
5358 5662
 	// Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced
5359
-	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E)))
5360
-		return '&#' . $num . ';';
5663
+	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) {
5664
+			return '&#' . $num . ';';
5665
+	}
5361 5666
 
5362 5667
 	if (empty($context['utf8']))
5363 5668
 	{
5364 5669
 		// no control characters
5365
-		if ($num < 0x20)
5366
-			return '';
5670
+		if ($num < 0x20) {
5671
+					return '';
5672
+		}
5367 5673
 		// text is text
5368
-		elseif ($num < 0x80)
5369
-			return chr($num);
5674
+		elseif ($num < 0x80) {
5675
+					return chr($num);
5676
+		}
5370 5677
 		// all others get html-ised
5371
-		else
5372
-			return '&#' . $matches[2] . ';';
5373
-	}
5374
-	else
5678
+		else {
5679
+					return '&#' . $matches[2] . ';';
5680
+		}
5681
+	} else
5375 5682
 	{
5376 5683
 		// <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set
5377 5684
 		// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text)
5378
-		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF))
5379
-			return '';
5685
+		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) {
5686
+					return '';
5687
+		}
5380 5688
 		// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
5381
-		elseif ($num < 0x80)
5382
-			return chr($num);
5689
+		elseif ($num < 0x80) {
5690
+					return chr($num);
5691
+		}
5383 5692
 		// <0x800 (2048)
5384
-		elseif ($num < 0x800)
5385
-			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5693
+		elseif ($num < 0x800) {
5694
+					return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5695
+		}
5386 5696
 		// < 0x10000 (65536)
5387
-		elseif ($num < 0x10000)
5388
-			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5697
+		elseif ($num < 0x10000) {
5698
+					return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5699
+		}
5389 5700
 		// <= 0x10FFFF (1114111)
5390
-		else
5391
-			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5701
+		else {
5702
+					return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5703
+		}
5392 5704
 	}
5393 5705
 }
5394 5706
 
@@ -5404,28 +5716,34 @@  discard block
 block discarded – undo
5404 5716
  */
5405 5717
 function fixchar__callback($matches)
5406 5718
 {
5407
-	if (!isset($matches[1]))
5408
-		return '';
5719
+	if (!isset($matches[1])) {
5720
+			return '';
5721
+	}
5409 5722
 
5410 5723
 	$num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1];
5411 5724
 
5412 5725
 	// <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set
5413 5726
 	// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides
5414
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E)
5415
-		return '';
5727
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) {
5728
+			return '';
5729
+	}
5416 5730
 	// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
5417
-	elseif ($num < 0x80)
5418
-		return chr($num);
5731
+	elseif ($num < 0x80) {
5732
+			return chr($num);
5733
+	}
5419 5734
 	// <0x800 (2048)
5420
-	elseif ($num < 0x800)
5421
-		return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5735
+	elseif ($num < 0x800) {
5736
+			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5737
+	}
5422 5738
 	// < 0x10000 (65536)
5423
-	elseif ($num < 0x10000)
5424
-		return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5739
+	elseif ($num < 0x10000) {
5740
+			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5741
+	}
5425 5742
 	// <= 0x10FFFF (1114111)
5426
-	else
5427
-		return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5428
-}
5743
+	else {
5744
+			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5745
+	}
5746
+	}
5429 5747
 
5430 5748
 /**
5431 5749
  * Strips out invalid html entities, replaces others with html style &#123; codes
@@ -5438,17 +5756,19 @@  discard block
 block discarded – undo
5438 5756
  */
5439 5757
 function entity_fix__callback($matches)
5440 5758
 {
5441
-	if (!isset($matches[2]))
5442
-		return '';
5759
+	if (!isset($matches[2])) {
5760
+			return '';
5761
+	}
5443 5762
 
5444 5763
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
5445 5764
 
5446 5765
 	// we don't allow control characters, characters out of range, byte markers, etc
5447
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E)
5448
-		return '';
5449
-	else
5450
-		return '&#' . $num . ';';
5451
-}
5766
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) {
5767
+			return '';
5768
+	} else {
5769
+			return '&#' . $num . ';';
5770
+	}
5771
+	}
5452 5772
 
5453 5773
 /**
5454 5774
  * Return a Gravatar URL based on
@@ -5472,18 +5792,23 @@  discard block
 block discarded – undo
5472 5792
 		$ratings = array('G', 'PG', 'R', 'X');
5473 5793
 		$defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank');
5474 5794
 		$url_params = array();
5475
-		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings))
5476
-			$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
5477
-		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults))
5478
-			$url_params[] = 'default=' . $modSettings['gravatarDefault'];
5479
-		if (!empty($modSettings['avatar_max_width_external']))
5480
-			$size_string = (int) $modSettings['avatar_max_width_external'];
5481
-		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string))
5482
-			if ((int) $modSettings['avatar_max_height_external'] < $size_string)
5795
+		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) {
5796
+					$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
5797
+		}
5798
+		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) {
5799
+					$url_params[] = 'default=' . $modSettings['gravatarDefault'];
5800
+		}
5801
+		if (!empty($modSettings['avatar_max_width_external'])) {
5802
+					$size_string = (int) $modSettings['avatar_max_width_external'];
5803
+		}
5804
+		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) {
5805
+					if ((int) $modSettings['avatar_max_height_external'] < $size_string)
5483 5806
 				$size_string = $modSettings['avatar_max_height_external'];
5807
+		}
5484 5808
 
5485
-		if (!empty($size_string))
5486
-			$url_params[] = 's=' . $size_string;
5809
+		if (!empty($size_string)) {
5810
+					$url_params[] = 's=' . $size_string;
5811
+		}
5487 5812
 	}
5488 5813
 	$http_method = !empty($modSettings['force_ssl']) ? 'https://secure' : 'http://www';
5489 5814
 
@@ -5502,22 +5827,26 @@  discard block
 block discarded – undo
5502 5827
 	static $timezones = null, $lastwhen = null;
5503 5828
 
5504 5829
 	// No point doing this over if we already did it once
5505
-	if (!empty($timezones) && $when == $lastwhen)
5506
-		return $timezones;
5507
-	else
5508
-		$lastwhen = $when;
5830
+	if (!empty($timezones) && $when == $lastwhen) {
5831
+			return $timezones;
5832
+	} else {
5833
+			$lastwhen = $when;
5834
+	}
5509 5835
 
5510 5836
 	// Parseable datetime string?
5511
-	if (is_int($timestamp = strtotime($when)))
5512
-		$when = $timestamp;
5837
+	if (is_int($timestamp = strtotime($when))) {
5838
+			$when = $timestamp;
5839
+	}
5513 5840
 
5514 5841
 	// A Unix timestamp?
5515
-	elseif (is_numeric($when))
5516
-		$when = intval($when);
5842
+	elseif (is_numeric($when)) {
5843
+			$when = intval($when);
5844
+	}
5517 5845
 
5518 5846
 	// Invalid value? Just get current Unix timestamp.
5519
-	else
5520
-		$when = time();
5847
+	else {
5848
+			$when = time();
5849
+	}
5521 5850
 
5522 5851
 	// We'll need these too
5523 5852
 	$date_when = date_create('@' . $when);
@@ -5532,8 +5861,9 @@  discard block
 block discarded – undo
5532 5861
 	foreach ($priority_countries as $country)
5533 5862
 	{
5534 5863
 		$country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country)));
5535
-		if (!empty($country_tzids))
5536
-			$priority_tzids = array_merge($priority_tzids, $country_tzids);
5864
+		if (!empty($country_tzids)) {
5865
+					$priority_tzids = array_merge($priority_tzids, $country_tzids);
5866
+		}
5537 5867
 	}
5538 5868
 
5539 5869
 	// Antarctic research stations should be listed last, unless you're running a penguin forum
@@ -5547,8 +5877,9 @@  discard block
 block discarded – undo
5547 5877
 	foreach ($tzids as $tzid)
5548 5878
 	{
5549 5879
 		// We don't want UTC right now
5550
-		if ($tzid == 'UTC')
5551
-			continue;
5880
+		if ($tzid == 'UTC') {
5881
+					continue;
5882
+		}
5552 5883
 
5553 5884
 		$tz = timezone_open($tzid);
5554 5885
 
@@ -5569,13 +5900,14 @@  discard block
 block discarded – undo
5569 5900
 		}
5570 5901
 
5571 5902
 		// A time zone from a prioritized country?
5572
-		if (in_array($tzid, $priority_tzids))
5573
-			$priority_zones[$tzkey] = true;
5903
+		if (in_array($tzid, $priority_tzids)) {
5904
+					$priority_zones[$tzkey] = true;
5905
+		}
5574 5906
 
5575 5907
 		// Keep track of the location and offset for this tzid
5576
-		if (!empty($txt[$tzid]))
5577
-			$zones[$tzkey]['locations'][] = $txt[$tzid];
5578
-		else
5908
+		if (!empty($txt[$tzid])) {
5909
+					$zones[$tzkey]['locations'][] = $txt[$tzid];
5910
+		} else
5579 5911
 		{
5580 5912
 			$tzid_parts = explode('/', $tzid);
5581 5913
 			$zones[$tzkey]['locations'][] = str_replace(array('St_', '_'), array('St. ', ' '), array_pop($tzid_parts));
@@ -5595,23 +5927,27 @@  discard block
 block discarded – undo
5595 5927
 		date_timezone_set($date_when, timezone_open($tzvalue['tzid']));
5596 5928
 
5597 5929
 		// Use the custom description, if there is one
5598
-		if (!empty($tztxt[$tzvalue['tzid']]))
5599
-			$desc = $tztxt[$tzvalue['tzid']];
5930
+		if (!empty($tztxt[$tzvalue['tzid']])) {
5931
+					$desc = $tztxt[$tzvalue['tzid']];
5932
+		}
5600 5933
 		// Otherwise, use the list of locations (max 5, so things don't get silly)
5601
-		else
5602
-			$desc = implode(', ', array_slice(array_unique($tzvalue['locations']), 0, 5)) . (count($tzvalue['locations']) > 5 ? ', ' . $txt['etc'] : '');
5934
+		else {
5935
+					$desc = implode(', ', array_slice(array_unique($tzvalue['locations']), 0, 5)) . (count($tzvalue['locations']) > 5 ? ', ' . $txt['etc'] : '');
5936
+		}
5603 5937
 
5604 5938
 		// Show the UTC offset and the abbreviation, if it's something like 'MST' and not '-06'
5605 5939
 		$desc = '[UTC' . date_format($date_when, 'P') . '] - ' . (!strspn($tzvalue['abbr'], '+-') ? $tzvalue['abbr'] . ' - ' : '') . $desc;
5606 5940
 
5607
-		if (isset($priority_zones[$tzkey]))
5608
-			$priority_timezones[$tzvalue['tzid']] = $desc;
5609
-		else
5610
-			$timezones[$tzvalue['tzid']] = $desc;
5941
+		if (isset($priority_zones[$tzkey])) {
5942
+					$priority_timezones[$tzvalue['tzid']] = $desc;
5943
+		} else {
5944
+					$timezones[$tzvalue['tzid']] = $desc;
5945
+		}
5611 5946
 	}
5612 5947
 
5613
-	if (!empty($priority_timezones))
5614
-		$priority_timezones[] = '-----';
5948
+	if (!empty($priority_timezones)) {
5949
+			$priority_timezones[] = '-----';
5950
+	}
5615 5951
 
5616 5952
 	$timezones = array_merge(
5617 5953
 		$priority_timezones,
@@ -5628,8 +5964,9 @@  discard block
 block discarded – undo
5628 5964
  */
5629 5965
 function inet_ptod($ip_address)
5630 5966
 {
5631
-	if (!isValidIP($ip_address))
5632
-		return $ip_address;
5967
+	if (!isValidIP($ip_address)) {
5968
+			return $ip_address;
5969
+	}
5633 5970
 
5634 5971
 	$bin = inet_pton($ip_address);
5635 5972
 	return $bin;
@@ -5641,13 +5978,15 @@  discard block
 block discarded – undo
5641 5978
  */
5642 5979
 function inet_dtop($bin)
5643 5980
 {
5644
-	if(empty($bin))
5645
-		return '';
5981
+	if(empty($bin)) {
5982
+			return '';
5983
+	}
5646 5984
 
5647 5985
 	global $db_type;
5648 5986
 
5649
-	if ($db_type == 'postgresql')
5650
-		return $bin;
5987
+	if ($db_type == 'postgresql') {
5988
+			return $bin;
5989
+	}
5651 5990
 
5652 5991
 	$ip_address = inet_ntop($bin);
5653 5992
 
@@ -5672,26 +6011,32 @@  discard block
 block discarded – undo
5672 6011
  */
5673 6012
 function _safe_serialize($value)
5674 6013
 {
5675
-	if(is_null($value))
5676
-		return 'N;';
6014
+	if(is_null($value)) {
6015
+			return 'N;';
6016
+	}
5677 6017
 
5678
-	if(is_bool($value))
5679
-		return 'b:'. (int) $value .';';
6018
+	if(is_bool($value)) {
6019
+			return 'b:'. (int) $value .';';
6020
+	}
5680 6021
 
5681
-	if(is_int($value))
5682
-		return 'i:'. $value .';';
6022
+	if(is_int($value)) {
6023
+			return 'i:'. $value .';';
6024
+	}
5683 6025
 
5684
-	if(is_float($value))
5685
-		return 'd:'. str_replace(',', '.', $value) .';';
6026
+	if(is_float($value)) {
6027
+			return 'd:'. str_replace(',', '.', $value) .';';
6028
+	}
5686 6029
 
5687
-	if(is_string($value))
5688
-		return 's:'. strlen($value) .':"'. $value .'";';
6030
+	if(is_string($value)) {
6031
+			return 's:'. strlen($value) .':"'. $value .'";';
6032
+	}
5689 6033
 
5690 6034
 	if(is_array($value))
5691 6035
 	{
5692 6036
 		$out = '';
5693
-		foreach($value as $k => $v)
5694
-			$out .= _safe_serialize($k) . _safe_serialize($v);
6037
+		foreach($value as $k => $v) {
6038
+					$out .= _safe_serialize($k) . _safe_serialize($v);
6039
+		}
5695 6040
 
5696 6041
 		return 'a:'. count($value) .':{'. $out .'}';
5697 6042
 	}
@@ -5717,8 +6062,9 @@  discard block
 block discarded – undo
5717 6062
 
5718 6063
 	$out = _safe_serialize($value);
5719 6064
 
5720
-	if (isset($mbIntEnc))
5721
-		mb_internal_encoding($mbIntEnc);
6065
+	if (isset($mbIntEnc)) {
6066
+			mb_internal_encoding($mbIntEnc);
6067
+	}
5722 6068
 
5723 6069
 	return $out;
5724 6070
 }
@@ -5735,8 +6081,9 @@  discard block
 block discarded – undo
5735 6081
 function _safe_unserialize($str)
5736 6082
 {
5737 6083
 	// Input  is not a string.
5738
-	if(empty($str) || !is_string($str))
5739
-		return false;
6084
+	if(empty($str) || !is_string($str)) {
6085
+			return false;
6086
+	}
5740 6087
 
5741 6088
 	$stack = array();
5742 6089
 	$expected = array();
@@ -5752,43 +6099,38 @@  discard block
 block discarded – undo
5752 6099
 	while($state != 1)
5753 6100
 	{
5754 6101
 		$type = isset($str[0]) ? $str[0] : '';
5755
-		if($type == '}')
5756
-			$str = substr($str, 1);
5757
-
5758
-		else if($type == 'N' && $str[1] == ';')
6102
+		if($type == '}') {
6103
+					$str = substr($str, 1);
6104
+		} else if($type == 'N' && $str[1] == ';')
5759 6105
 		{
5760 6106
 			$value = null;
5761 6107
 			$str = substr($str, 2);
5762
-		}
5763
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
6108
+		} else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5764 6109
 		{
5765 6110
 			$value = $matches[1] == '1' ? true : false;
5766 6111
 			$str = substr($str, 4);
5767
-		}
5768
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
6112
+		} else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5769 6113
 		{
5770 6114
 			$value = (int)$matches[1];
5771 6115
 			$str = $matches[2];
5772
-		}
5773
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
6116
+		} else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5774 6117
 		{
5775 6118
 			$value = (float)$matches[1];
5776 6119
 			$str = $matches[3];
5777
-		}
5778
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
6120
+		} else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5779 6121
 		{
5780 6122
 			$value = substr($matches[2], 0, (int)$matches[1]);
5781 6123
 			$str = substr($matches[2], (int)$matches[1] + 2);
5782
-		}
5783
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
6124
+		} else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5784 6125
 		{
5785 6126
 			$expectedLength = (int)$matches[1];
5786 6127
 			$str = $matches[2];
5787 6128
 		}
5788 6129
 
5789 6130
 		// Object or unknown/malformed type.
5790
-		else
5791
-			return false;
6131
+		else {
6132
+					return false;
6133
+		}
5792 6134
 
5793 6135
 		switch($state)
5794 6136
 		{
@@ -5816,8 +6158,9 @@  discard block
 block discarded – undo
5816 6158
 				if($type == '}')
5817 6159
 				{
5818 6160
 					// Array size is less than expected.
5819
-					if(count($list) < end($expected))
5820
-						return false;
6161
+					if(count($list) < end($expected)) {
6162
+											return false;
6163
+					}
5821 6164
 
5822 6165
 					unset($list);
5823 6166
 					$list = &$stack[count($stack)-1];
@@ -5826,8 +6169,9 @@  discard block
 block discarded – undo
5826 6169
 					// Go to terminal state if we're at the end of the root array.
5827 6170
 					array_pop($expected);
5828 6171
 
5829
-					if(count($expected) == 0)
5830
-						$state = 1;
6172
+					if(count($expected) == 0) {
6173
+											$state = 1;
6174
+					}
5831 6175
 
5832 6176
 					break;
5833 6177
 				}
@@ -5835,8 +6179,9 @@  discard block
 block discarded – undo
5835 6179
 				if($type == 'i' || $type == 's')
5836 6180
 				{
5837 6181
 					// Array size exceeds expected length.
5838
-					if(count($list) >= end($expected))
5839
-						return false;
6182
+					if(count($list) >= end($expected)) {
6183
+											return false;
6184
+					}
5840 6185
 
5841 6186
 					$key = $value;
5842 6187
 					$state = 3;
@@ -5870,8 +6215,9 @@  discard block
 block discarded – undo
5870 6215
 	}
5871 6216
 
5872 6217
 	// Trailing data in input.
5873
-	if(!empty($str))
5874
-		return false;
6218
+	if(!empty($str)) {
6219
+			return false;
6220
+	}
5875 6221
 
5876 6222
 	return $data;
5877 6223
 }
@@ -5894,8 +6240,9 @@  discard block
 block discarded – undo
5894 6240
 
5895 6241
 	$out = _safe_unserialize($str);
5896 6242
 
5897
-	if (isset($mbIntEnc))
5898
-		mb_internal_encoding($mbIntEnc);
6243
+	if (isset($mbIntEnc)) {
6244
+			mb_internal_encoding($mbIntEnc);
6245
+	}
5899 6246
 
5900 6247
 	return $out;
5901 6248
 }
@@ -5910,12 +6257,14 @@  discard block
 block discarded – undo
5910 6257
 function smf_chmod($file, $value = 0)
5911 6258
 {
5912 6259
 	// No file? no checks!
5913
-	if (empty($file))
5914
-		return false;
6260
+	if (empty($file)) {
6261
+			return false;
6262
+	}
5915 6263
 
5916 6264
 	// Already writable?
5917
-	if (is_writable($file))
5918
-		return true;
6265
+	if (is_writable($file)) {
6266
+			return true;
6267
+	}
5919 6268
 
5920 6269
 	// Do we have a file or a dir?
5921 6270
 	$isDir = is_dir($file);
@@ -5931,10 +6280,9 @@  discard block
 block discarded – undo
5931 6280
 		{
5932 6281
 			$isWritable = true;
5933 6282
 			break;
6283
+		} else {
6284
+					@chmod($file, $val);
5934 6285
 		}
5935
-
5936
-		else
5937
-			@chmod($file, $val);
5938 6286
 	}
5939 6287
 
5940 6288
 	return $isWritable;
@@ -5953,8 +6301,9 @@  discard block
 block discarded – undo
5953 6301
 	global $txt;
5954 6302
 
5955 6303
 	// Come on...
5956
-	if (empty($json) || !is_string($json))
5957
-		return array();
6304
+	if (empty($json) || !is_string($json)) {
6305
+			return array();
6306
+	}
5958 6307
 
5959 6308
 	$returnArray = @json_decode($json, $returnAsArray);
5960 6309
 
@@ -5992,11 +6341,11 @@  discard block
 block discarded – undo
5992 6341
 		$jsonDebug = $jsonDebug[0];
5993 6342
 		loadLanguage('Errors');
5994 6343
 
5995
-		if (!empty($jsonDebug))
5996
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5997
-
5998
-		else
5999
-			log_error($txt['json_'. $jsonError], 'critical');
6344
+		if (!empty($jsonDebug)) {
6345
+					log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
6346
+		} else {
6347
+					log_error($txt['json_'. $jsonError], 'critical');
6348
+		}
6000 6349
 
6001 6350
 		// Everyone expects an array.
6002 6351
 		return array();
@@ -6030,8 +6379,9 @@  discard block
 block discarded – undo
6030 6379
 	global $db_show_debug, $modSettings;
6031 6380
 
6032 6381
 	// Defensive programming anyone?
6033
-	if (empty($data))
6034
-		return false;
6382
+	if (empty($data)) {
6383
+			return false;
6384
+	}
6035 6385
 
6036 6386
 	// Don't need extra stuff...
6037 6387
 	$db_show_debug = false;
@@ -6039,11 +6389,11 @@  discard block
 block discarded – undo
6039 6389
 	// Kill anything else.
6040 6390
 	ob_end_clean();
6041 6391
 
6042
-	if (!empty($modSettings['CompressedOutput']))
6043
-		@ob_start('ob_gzhandler');
6044
-
6045
-	else
6046
-		ob_start();
6392
+	if (!empty($modSettings['CompressedOutput'])) {
6393
+			@ob_start('ob_gzhandler');
6394
+	} else {
6395
+			ob_start();
6396
+	}
6047 6397
 
6048 6398
 	// Set the header.
6049 6399
 	header($type);
@@ -6075,8 +6425,9 @@  discard block
 block discarded – undo
6075 6425
 	static $done = false;
6076 6426
 
6077 6427
 	// If we don't need to do anything, don't
6078
-	if (!$update && $done)
6079
-		return;
6428
+	if (!$update && $done) {
6429
+			return;
6430
+	}
6080 6431
 
6081 6432
 	// Should we get a new copy of the official list of TLDs?
6082 6433
 	if ($update)
@@ -6088,8 +6439,9 @@  discard block
 block discarded – undo
6088 6439
 		// marauding bandits roaming on the surface. We don't want to waste precious electricity on
6089 6440
 		// pointlessly repeating background tasks, so we'll wait until the next regularly scheduled
6090 6441
 		// update to see if civilization has been restored.
6091
-		if ($tlds === false)
6092
-			$postapocalypticNightmare = true;
6442
+		if ($tlds === false) {
6443
+					$postapocalypticNightmare = true;
6444
+		}
6093 6445
 	}
6094 6446
 	// If we aren't updating and the regex is valid, we're done
6095 6447
 	elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false)
@@ -6104,10 +6456,11 @@  discard block
 block discarded – undo
6104 6456
 		// Clean $tlds and convert it to an array
6105 6457
 		$tlds = array_filter(explode("\n", strtolower($tlds)), function($line) {
6106 6458
 			$line = trim($line);
6107
-			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false)
6108
-				return false;
6109
-			else
6110
-				return true;
6459
+			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) {
6460
+							return false;
6461
+			} else {
6462
+							return true;
6463
+			}
6111 6464
 		});
6112 6465
 
6113 6466
 		// Convert Punycode to Unicode
@@ -6199,8 +6552,7 @@  discard block
 block discarded – undo
6199 6552
 
6200 6553
 		$strlen = 'mb_strlen';
6201 6554
 		$substr = 'mb_substr';
6202
-	}
6203
-	else
6555
+	} else
6204 6556
 	{
6205 6557
 		$strlen = $smcFunc['strlen'];
6206 6558
 		$substr = $smcFunc['substr'];
@@ -6214,20 +6566,21 @@  discard block
 block discarded – undo
6214 6566
 
6215 6567
 		$first = $substr($string, 0, 1);
6216 6568
 
6217
-		if (empty($index[$first]))
6218
-			$index[$first] = array();
6569
+		if (empty($index[$first])) {
6570
+					$index[$first] = array();
6571
+		}
6219 6572
 
6220 6573
 		if ($strlen($string) > 1)
6221 6574
 		{
6222 6575
 			// Sanity check on recursion
6223
-			if ($depth > 99)
6224
-				$index[$first][$substr($string, 1)] = '';
6225
-
6226
-			else
6227
-				$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6576
+			if ($depth > 99) {
6577
+							$index[$first][$substr($string, 1)] = '';
6578
+			} else {
6579
+							$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6580
+			}
6581
+		} else {
6582
+					$index[$first][''] = '';
6228 6583
 		}
6229
-		else
6230
-			$index[$first][''] = '';
6231 6584
 
6232 6585
 		$depth--;
6233 6586
 		return $index;
@@ -6250,9 +6603,9 @@  discard block
 block discarded – undo
6250 6603
 			$key_regex = preg_quote($key, $delim);
6251 6604
 			$new_key = $key;
6252 6605
 
6253
-			if (empty($value))
6254
-				$sub_regex = '';
6255
-			else
6606
+			if (empty($value)) {
6607
+							$sub_regex = '';
6608
+			} else
6256 6609
 			{
6257 6610
 				$sub_regex = $index_to_regex($value, $delim);
6258 6611
 
@@ -6260,22 +6613,22 @@  discard block
 block discarded – undo
6260 6613
 				{
6261 6614
 					$new_key_array = explode('(?'.'>', $sub_regex);
6262 6615
 					$new_key .= $new_key_array[0];
6616
+				} else {
6617
+									$sub_regex = '(?'.'>' . $sub_regex . ')';
6263 6618
 				}
6264
-				else
6265
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
6266 6619
 			}
6267 6620
 
6268
-			if ($depth > 1)
6269
-				$regex[$new_key] = $key_regex . $sub_regex;
6270
-			else
6621
+			if ($depth > 1) {
6622
+							$regex[$new_key] = $key_regex . $sub_regex;
6623
+			} else
6271 6624
 			{
6272 6625
 				if (($length += strlen($key_regex) + 1) < $max_length || empty($regex))
6273 6626
 				{
6274 6627
 					$regex[$new_key] = $key_regex . $sub_regex;
6275 6628
 					unset($index[$key]);
6629
+				} else {
6630
+									break;
6276 6631
 				}
6277
-				else
6278
-					break;
6279 6632
 			}
6280 6633
 		}
6281 6634
 
@@ -6284,10 +6637,11 @@  discard block
 block discarded – undo
6284 6637
 			$l1 = $strlen($k1);
6285 6638
 			$l2 = $strlen($k2);
6286 6639
 
6287
-			if ($l1 == $l2)
6288
-				return strcmp($k1, $k2) > 0 ? 1 : -1;
6289
-			else
6290
-				return $l1 > $l2 ? -1 : 1;
6640
+			if ($l1 == $l2) {
6641
+							return strcmp($k1, $k2) > 0 ? 1 : -1;
6642
+			} else {
6643
+							return $l1 > $l2 ? -1 : 1;
6644
+			}
6291 6645
 		});
6292 6646
 
6293 6647
 		$depth--;
@@ -6298,21 +6652,24 @@  discard block
 block discarded – undo
6298 6652
 	$index = array();
6299 6653
 	$regex = '';
6300 6654
 
6301
-	foreach ($strings as $string)
6302
-		$index = $add_string_to_index($string, $index);
6655
+	foreach ($strings as $string) {
6656
+			$index = $add_string_to_index($string, $index);
6657
+	}
6303 6658
 
6304 6659
 	if ($returnArray === true)
6305 6660
 	{
6306 6661
 		$regex = array();
6307
-		while (!empty($index))
6308
-			$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6662
+		while (!empty($index)) {
6663
+					$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6664
+		}
6665
+	} else {
6666
+			$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6309 6667
 	}
6310
-	else
6311
-		$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6312 6668
 
6313 6669
 	// Restore PHP's internal character encoding to whatever it was originally
6314
-	if (!empty($current_encoding))
6315
-		mb_internal_encoding($current_encoding);
6670
+	if (!empty($current_encoding)) {
6671
+			mb_internal_encoding($current_encoding);
6672
+	}
6316 6673
 
6317 6674
 	return $regex;
6318 6675
 }
@@ -6355,13 +6712,15 @@  discard block
 block discarded – undo
6355 6712
 	// Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't...
6356 6713
 	$url = str_ireplace('https://', 'http://', $url) . '/';
6357 6714
 	$headers = @get_headers($url);
6358
-	if ($headers === false)
6359
-		return false;
6715
+	if ($headers === false) {
6716
+			return false;
6717
+	}
6360 6718
 
6361 6719
 	// Now to see if it came back https...
6362 6720
 	// First check for a redirect status code in first row (301, 302, 307)
6363
-	if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false)
6364
-		return false;
6721
+	if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) {
6722
+			return false;
6723
+	}
6365 6724
 
6366 6725
 	// Search for the location entry to confirm https
6367 6726
 	$result = false;
@@ -6399,8 +6758,7 @@  discard block
 block discarded – undo
6399 6758
 		$is_admin = $user_info['is_admin'];
6400 6759
 		$mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null;
6401 6760
 		$ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null;
6402
-	}
6403
-	else
6761
+	} else
6404 6762
 	{
6405 6763
 		$request = $smcFunc['db_query']('', '
6406 6764
 				SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group
@@ -6414,17 +6772,19 @@  discard block
 block discarded – undo
6414 6772
 
6415 6773
 		$row = $smcFunc['db_fetch_assoc']($request);
6416 6774
 
6417
-		if (empty($row['additional_groups']))
6418
-			$groups = array($row['id_group'], $row['id_post_group']);
6419
-		else
6420
-			$groups = array_merge(
6775
+		if (empty($row['additional_groups'])) {
6776
+					$groups = array($row['id_group'], $row['id_post_group']);
6777
+		} else {
6778
+					$groups = array_merge(
6421 6779
 					array($row['id_group'], $row['id_post_group']),
6422 6780
 					explode(',', $row['additional_groups'])
6423 6781
 			);
6782
+		}
6424 6783
 
6425 6784
 		// Because history has proven that it is possible for groups to go bad - clean up in case.
6426
-		foreach ($groups as $k => $v)
6427
-			$groups[$k] = (int) $v;
6785
+		foreach ($groups as $k => $v) {
6786
+					$groups[$k] = (int) $v;
6787
+		}
6428 6788
 
6429 6789
 		$is_admin = in_array(1, $groups);
6430 6790
 
@@ -6441,8 +6801,9 @@  discard block
 block discarded – undo
6441 6801
 				'current_member' => $userid,
6442 6802
 			)
6443 6803
 		);
6444
-		while ($row = $smcFunc['db_fetch_assoc']($request))
6445
-			$boards_mod[] = $row['id_board'];
6804
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
6805
+					$boards_mod[] = $row['id_board'];
6806
+		}
6446 6807
 		$smcFunc['db_free_result']($request);
6447 6808
 
6448 6809
 		// Can any of the groups they're in moderate any of the boards?
@@ -6454,8 +6815,9 @@  discard block
 block discarded – undo
6454 6815
 				'groups' => $groups,
6455 6816
 			)
6456 6817
 		);
6457
-		while ($row = $smcFunc['db_fetch_assoc']($request))
6458
-			$boards_mod[] = $row['id_board'];
6818
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
6819
+					$boards_mod[] = $row['id_board'];
6820
+		}
6459 6821
 		$smcFunc['db_free_result']($request);
6460 6822
 
6461 6823
 		// Just in case we've got duplicates here...
@@ -6465,21 +6827,25 @@  discard block
 block discarded – undo
6465 6827
 	}
6466 6828
 
6467 6829
 	// Just build this here, it makes it easier to change/use - administrators can see all boards.
6468
-	if ($is_admin)
6469
-		$query_part['query_see_board'] = '1=1';
6830
+	if ($is_admin) {
6831
+			$query_part['query_see_board'] = '1=1';
6832
+	}
6470 6833
 	// Otherwise just the groups in $user_info['groups'].
6471
-	else
6472
-		$query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')';
6834
+	else {
6835
+			$query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')';
6836
+	}
6473 6837
 
6474 6838
 	// Build the list of boards they WANT to see.
6475 6839
 	// This will take the place of query_see_boards in certain spots, so it better include the boards they can see also
6476 6840
 
6477 6841
 	// If they aren't ignoring any boards then they want to see all the boards they can see
6478
-	if (empty($ignoreboards))
6479
-		$query_part['query_wanna_see_board'] = $query_part['query_see_board'];
6842
+	if (empty($ignoreboards)) {
6843
+			$query_part['query_wanna_see_board'] = $query_part['query_see_board'];
6844
+	}
6480 6845
 	// Ok I guess they don't want to see all the boards
6481
-	else
6482
-		$query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))';
6846
+	else {
6847
+			$query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))';
6848
+	}
6483 6849
 
6484 6850
 	return $query_part;
6485 6851
 }
@@ -6493,10 +6859,11 @@  discard block
 block discarded – undo
6493 6859
 {
6494 6860
 	$secure = false;
6495 6861
 
6496
-	if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on')
6497
-		$secure = true;
6498
-	elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on')
6499
-		$secure = true;
6862
+	if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') {
6863
+			$secure = true;
6864
+	} elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') {
6865
+			$secure = true;
6866
+	}
6500 6867
 
6501 6868
 	return $secure;
6502 6869
 }
@@ -6513,11 +6880,12 @@  discard block
 block discarded – undo
6513 6880
 {
6514 6881
 	$url = iri_to_url($iri);
6515 6882
 
6516
-	if (filter_var($url, FILTER_VALIDATE_URL, $flags) !== false)
6517
-		return $iri;
6518
-	else
6519
-		return false;
6520
-}
6883
+	if (filter_var($url, FILTER_VALIDATE_URL, $flags) !== false) {
6884
+			return $iri;
6885
+	} else {
6886
+			return false;
6887
+	}
6888
+	}
6521 6889
 
6522 6890
 /**
6523 6891
  * A wrapper for `filter_var($url, FILTER_SANITIZE_URL)` that can handle URLs
@@ -6560,8 +6928,9 @@  discard block
 block discarded – undo
6560 6928
 
6561 6929
 	$host = parse_url((strpos($iri, '://') === false ? 'http://' : '') . ltrim($iri, ':/'), PHP_URL_HOST);
6562 6930
 
6563
-	if (empty($host))
6564
-		return $iri;
6931
+	if (empty($host)) {
6932
+			return $iri;
6933
+	}
6565 6934
 
6566 6935
 	// Convert the domain using the Punycode algorithm
6567 6936
 	require_once($sourcedir . '/Class-Punycode.php');
@@ -6597,8 +6966,9 @@  discard block
 block discarded – undo
6597 6966
 
6598 6967
 	$host = parse_url((strpos($url, '://') === false ? 'http://' : '') . ltrim($url, ':/'), PHP_URL_HOST);
6599 6968
 
6600
-	if (empty($host))
6601
-		return $url;
6969
+	if (empty($host)) {
6970
+			return $url;
6971
+	}
6602 6972
 
6603 6973
 	// Decode the domain from Punycode
6604 6974
 	require_once($sourcedir . '/Class-Punycode.php');
@@ -6624,8 +6994,9 @@  discard block
 block discarded – undo
6624 6994
 {
6625 6995
 	global $user_info, $modSettings, $smcFunc, $txt;
6626 6996
 
6627
-	if (empty($modSettings['cron_last_checked']))
6628
-		$modSettings['cron_last_checked'] = 0;
6997
+	if (empty($modSettings['cron_last_checked'])) {
6998
+			$modSettings['cron_last_checked'] = 0;
6999
+	}
6629 7000
 
6630 7001
 	if (!empty($modSettings['cron_is_real_cron']) && time() - $modSettings['cron_last_checked'] > 84600)
6631 7002
 	{
@@ -6645,9 +7016,9 @@  discard block
 block discarded – undo
6645 7016
 			loadLanguage('ManageScheduledTasks');
6646 7017
 			log_error($txt['cron_not_working']);
6647 7018
 			updateSettings(array('cron_is_real_cron' => 0));
7019
+		} else {
7020
+					updateSettings(array('cron_last_checked' => time()));
6648 7021
 		}
6649
-		else
6650
-			updateSettings(array('cron_last_checked' => time()));
6651 7022
 	}
6652 7023
 }
6653 7024
 
@@ -6671,10 +7042,11 @@  discard block
 block discarded – undo
6671 7042
 	
6672 7043
 	$protocol = preg_match('~^\s*(HTTP/[12]\.\d)\s*$~i', $_SERVER['SERVER_PROTOCOL'], $matches) ? $matches[1] : 'HTTP/1.0';
6673 7044
 
6674
-	if (!isset($statuses[$code]) && empty($status))
6675
-		header($protocol . ' 500 Internal Server Error');
6676
-	else
6677
-		header($protocol . ' ' . $code . ' ' . !empty($status) ? $status : $statuses[$code]);
6678
-}
7045
+	if (!isset($statuses[$code]) && empty($status)) {
7046
+			header($protocol . ' 500 Internal Server Error');
7047
+	} else {
7048
+			header($protocol . ' ' . $code . ' ' . !empty($status) ? $status : $statuses[$code]);
7049
+	}
7050
+	}
6679 7051
 
6680 7052
 ?>
6681 7053
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/CacheAPI-postgres.php 2 patches
Braces   +28 added lines, -19 removed lines patch added patch discarded remove patch
@@ -11,8 +11,9 @@  discard block
 block discarded – undo
11 11
  * @version 2.1 Beta 4
12 12
  */
13 13
 
14
-if (!defined('SMF'))
14
+if (!defined('SMF')) {
15 15
 	die('Hacking attempt...');
16
+}
16 17
 
17 18
 /**
18 19
  * PostgreSQL Cache API class
@@ -49,8 +50,9 @@  discard block
 block discarded – undo
49 50
 
50 51
 		$result = pg_execute($db_connection, '', array('public', $db_prefix . 'cache'));
51 52
 
52
-		if (pg_affected_rows($result) === 0)
53
-			pg_query($db_connection, 'CREATE UNLOGGED TABLE ' . $db_prefix . 'cache (key text, value text, ttl bigint, PRIMARY KEY (key))');			
53
+		if (pg_affected_rows($result) === 0) {
54
+					pg_query($db_connection, 'CREATE UNLOGGED TABLE ' . $db_prefix . 'cache (key text, value text, ttl bigint, PRIMARY KEY (key))');
55
+		}
54 56
 	}
55 57
 
56 58
 	/**
@@ -60,14 +62,16 @@  discard block
 block discarded – undo
60 62
 	{
61 63
 		global $smcFunc, $db_connection;
62 64
 
63
-		if ($smcFunc['db_title'] !== 'PostgreSQL')
64
-			return false;
65
+		if ($smcFunc['db_title'] !== 'PostgreSQL') {
66
+					return false;
67
+		}
65 68
 
66 69
 		$result = pg_query($db_connection, 'SHOW server_version_num');
67 70
 		$res = pg_fetch_assoc($result);
68 71
 		
69
-		if ($res['server_version_num'] < 90500)
70
-			return false;
72
+		if ($res['server_version_num'] < 90500) {
73
+					return false;
74
+		}
71 75
 		
72 76
 		return $test ? true : parent::isSupported();
73 77
 	}
@@ -81,13 +85,15 @@  discard block
 block discarded – undo
81 85
 
82 86
 		$ttl = time() - $ttl;
83 87
 		
84
-		if (empty($this->pg_get_data_prep))
85
-			$this->pg_get_data_prep = pg_prepare($db_connection, 'smf_cache_get_data', 'SELECT value FROM ' . $db_prefix . 'cache WHERE key = $1 AND ttl >= $2 LIMIT 1');
88
+		if (empty($this->pg_get_data_prep)) {
89
+					$this->pg_get_data_prep = pg_prepare($db_connection, 'smf_cache_get_data', 'SELECT value FROM ' . $db_prefix . 'cache WHERE key = $1 AND ttl >= $2 LIMIT 1');
90
+		}
86 91
 			
87 92
 		$result = pg_execute($db_connection, 'smf_cache_get_data', array($key, $ttl));
88 93
 		
89
-		if (pg_affected_rows($result) === 0)
90
-			return null;
94
+		if (pg_affected_rows($result) === 0) {
95
+					return null;
96
+		}
91 97
 
92 98
 		$res = pg_fetch_assoc($result);
93 99
 
@@ -101,23 +107,26 @@  discard block
 block discarded – undo
101 107
 	{
102 108
 		global  $db_prefix, $db_connection;
103 109
 
104
-		if (!isset($value))
105
-			$value = '';
110
+		if (!isset($value)) {
111
+					$value = '';
112
+		}
106 113
 
107 114
 		$ttl = time() + $ttl;
108 115
 
109
-		if (empty($this->pg_put_data_prep))
110
-			$this->pg_put_data_prep = pg_prepare($db_connection, 'smf_cache_put_data',
116
+		if (empty($this->pg_put_data_prep)) {
117
+					$this->pg_put_data_prep = pg_prepare($db_connection, 'smf_cache_put_data',
111 118
 				'INSERT INTO ' . $db_prefix . 'cache(key,value,ttl) VALUES($1,$2,$3)
112 119
 				ON CONFLICT(key) DO UPDATE SET value = excluded.value, ttl = excluded.ttl'
113 120
 			);
121
+		}
114 122
 
115 123
 		$result = pg_execute($db_connection, 'smf_cache_put_data', array($key, $value, $ttl));
116 124
 
117
-		if (pg_affected_rows($result) > 0)
118
-			return true;
119
-		else
120
-			return false;
125
+		if (pg_affected_rows($result) > 0) {
126
+					return true;
127
+		} else {
128
+					return false;
129
+		}
121 130
 	}
122 131
 
123 132
 	/**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 	{
166 166
 		global $db_connection, $db_prefix;
167 167
 		
168
-		pg_query($db_connection, 'CREATE LOCAL TEMP TABLE IF NOT EXISTS ' . $db_prefix . 'cache_tmp AS SELECT * FROM ' . $db_prefix . 'cache WHERE ttl >= ' . time() );
168
+		pg_query($db_connection, 'CREATE LOCAL TEMP TABLE IF NOT EXISTS ' . $db_prefix . 'cache_tmp AS SELECT * FROM ' . $db_prefix . 'cache WHERE ttl >= ' . time());
169 169
 	}
170 170
 	
171 171
 	/**
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	{
190 190
 		global $db_connection, $db_prefix;
191 191
 		
192
-		pg_query($db_connection, 'INSERT INTO ' . $db_prefix . 'cache SELECT * FROM '. $db_prefix . 'cache_tmp ON CONFLICT DO NOTHING');
192
+		pg_query($db_connection, 'INSERT INTO ' . $db_prefix . 'cache SELECT * FROM ' . $db_prefix . 'cache_tmp ON CONFLICT DO NOTHING');
193 193
 	}
194 194
 }
195 195
 
Please login to merge, or discard this patch.