@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -583,8 +583,7 @@ discard block |
||
583 | 583 | { |
584 | 584 | $header = '<?php require("' . ($user_info['is_admin'] ? addslashes(realpath($boarddir . '/SSI.php')) : 'SSI.php') . '"); ?>' . "\n" . $header; |
585 | 585 | return $header . template_homepage_sample1_html() . $footer; |
586 | - } |
|
587 | - else |
|
586 | + } else |
|
588 | 587 | { |
589 | 588 | echo $header; |
590 | 589 | template_homepage_sample1_php(); |
@@ -599,9 +598,10 @@ discard block |
||
599 | 598 | |
600 | 599 | $topics = ssi_recentTopics(8, null, null, 'array'); |
601 | 600 | |
602 | - foreach ($topics as $topic) |
|
603 | - echo ' |
|
601 | + foreach ($topics as $topic) { |
|
602 | + echo ' |
|
604 | 603 | <li><a href="', $topic['href'], '">', $topic['subject'], '</a> ', $txt['by'], ' ', $topic['poster']['link'], '</li>'; |
604 | + } |
|
605 | 605 | |
606 | 606 | unset($topics); |
607 | 607 |
@@ -186,8 +186,9 @@ discard block |
||
186 | 186 | |
187 | 187 | ########## Error-Catching ########## |
188 | 188 | # Note: You shouldn't touch these settings. |
189 | -if (file_exists(dirname(__FILE__) . '/db_last_error.php')) |
|
189 | +if (file_exists(dirname(__FILE__) . '/db_last_error.php')) { |
|
190 | 190 | include(dirname(__FILE__) . '/db_last_error.php'); |
191 | +} |
|
191 | 192 | |
192 | 193 | if (!isset($db_last_error)) |
193 | 194 | { |
@@ -202,11 +203,14 @@ discard block |
||
202 | 203 | } |
203 | 204 | |
204 | 205 | # Make sure the paths are correct... at least try to fix them. |
205 | -if (!file_exists($boarddir) && file_exists(dirname(__FILE__) . '/agreement.txt')) |
|
206 | +if (!file_exists($boarddir) && file_exists(dirname(__FILE__) . '/agreement.txt')) { |
|
206 | 207 | $boarddir = dirname(__FILE__); |
207 | -if (!file_exists($sourcedir) && file_exists($boarddir . '/Sources')) |
|
208 | +} |
|
209 | +if (!file_exists($sourcedir) && file_exists($boarddir . '/Sources')) { |
|
208 | 210 | $sourcedir = $boarddir . '/Sources'; |
209 | -if (!file_exists($cachedir) && file_exists($boarddir . '/cache')) |
|
211 | +} |
|
212 | +if (!file_exists($cachedir) && file_exists($boarddir . '/cache')) { |
|
210 | 213 | $cachedir = $boarddir . '/cache'; |
214 | +} |
|
211 | 215 | |
212 | 216 | ?> |
213 | 217 | \ No newline at end of file |
@@ -220,7 +220,7 @@ |
||
220 | 220 | ), |
221 | 221 | ), |
222 | 222 | ); |
223 | - */ |
|
223 | + */ |
|
224 | 224 | |
225 | 225 | // Are we using right-to-left orientation? |
226 | 226 | $first = $context['right_to_left'] ? 'last' : 'first'; |
@@ -22,27 +22,31 @@ discard block |
||
22 | 22 | // Get a shortcut to the current list. |
23 | 23 | $list_id = $list_id === null ? (!empty($context['default_list']) ? $context['default_list'] : '') : $list_id; |
24 | 24 | |
25 | - if (empty($list_id) || empty($context[$list_id])) |
|
26 | - return; |
|
25 | + if (empty($list_id) || empty($context[$list_id])) { |
|
26 | + return; |
|
27 | + } |
|
27 | 28 | |
28 | 29 | $cur_list = &$context[$list_id]; |
29 | 30 | |
30 | 31 | // These are the main tabs that is used all around the template. |
31 | - if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'top')) |
|
32 | - template_create_list_menu($cur_list['list_menu'], 'top'); |
|
32 | + if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'top')) { |
|
33 | + template_create_list_menu($cur_list['list_menu'], 'top'); |
|
34 | + } |
|
33 | 35 | |
34 | - if (isset($cur_list['form'])) |
|
35 | - echo ' |
|
36 | + if (isset($cur_list['form'])) { |
|
37 | + echo ' |
|
36 | 38 | <form action="', $cur_list['form']['href'], '" method="post"', empty($cur_list['form']['name']) ? '' : ' name="' . $cur_list['form']['name'] . '" id="' . $cur_list['form']['name'] . '"', ' accept-charset="', $context['character_set'], '">'; |
39 | + } |
|
37 | 40 | |
38 | 41 | // Show the title of the table (if any). |
39 | - if (!empty($cur_list['title'])) |
|
40 | - echo ' |
|
42 | + if (!empty($cur_list['title'])) { |
|
43 | + echo ' |
|
41 | 44 | <div class="cat_bar"> |
42 | 45 | <h3 class="catbg"> |
43 | 46 | ', $cur_list['title'], ' |
44 | 47 | </h3> |
45 | 48 | </div>'; |
49 | + } |
|
46 | 50 | |
47 | 51 | if (isset($cur_list['additional_rows']['after_title'])) |
48 | 52 | { |
@@ -55,20 +59,23 @@ discard block |
||
55 | 59 | </div>'; |
56 | 60 | } |
57 | 61 | |
58 | - if (isset($cur_list['additional_rows']['top_of_list'])) |
|
59 | - template_additional_rows('top_of_list', $cur_list); |
|
62 | + if (isset($cur_list['additional_rows']['top_of_list'])) { |
|
63 | + template_additional_rows('top_of_list', $cur_list); |
|
64 | + } |
|
60 | 65 | |
61 | 66 | if ((!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) || isset($cur_list['additional_rows']['above_column_headers'])) |
62 | 67 | { |
63 | 68 | // Show the page index (if this list doesn't intend to show all items). |
64 | - if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) |
|
65 | - echo ' |
|
69 | + if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) { |
|
70 | + echo ' |
|
66 | 71 | <div class="floatleft"> |
67 | 72 | <div class="pagesection">', $cur_list['page_index'], '</div> |
68 | 73 | </div>'; |
74 | + } |
|
69 | 75 | |
70 | - if (isset($cur_list['additional_rows']['above_column_headers'])) |
|
71 | - template_additional_rows('above_column_headers', $cur_list); |
|
76 | + if (isset($cur_list['additional_rows']['above_column_headers'])) { |
|
77 | + template_additional_rows('above_column_headers', $cur_list); |
|
78 | + } |
|
72 | 79 | } |
73 | 80 | |
74 | 81 | echo ' |
@@ -83,11 +90,12 @@ discard block |
||
83 | 90 | <tr class="title_bar">'; |
84 | 91 | |
85 | 92 | // Loop through each column and add a table header. |
86 | - foreach ($cur_list['headers'] as $col_header) |
|
87 | - echo ' |
|
93 | + foreach ($cur_list['headers'] as $col_header) { |
|
94 | + echo ' |
|
88 | 95 | <th scope="col" id="header_', $list_id, '_', $col_header['id'], '"', empty($col_header['class']) ? '' : ' class="' . $col_header['class'] . '"', empty($col_header['style']) ? '' : ' style="' . $col_header['style'] . '"', empty($col_header['colspan']) ? '' : ' colspan="' . $col_header['colspan'] . '"', '> |
89 | 96 | ', empty($col_header['href']) ? '' : '<a href="' . $col_header['href'] . '" rel="nofollow">', empty($col_header['label']) ? '' : $col_header['label'], empty($col_header['href']) ? '' : (empty($col_header['sort_image']) ? '</a>' : ' <span class="generic_icons sort_' . $col_header['sort_image'] . '"></span></a>'), ' |
90 | 97 | </th>'; |
98 | + } |
|
91 | 99 | |
92 | 100 | echo ' |
93 | 101 | </tr> |
@@ -98,13 +106,14 @@ discard block |
||
98 | 106 | <tbody>'; |
99 | 107 | |
100 | 108 | // Show a nice message informing there are no items in this list. |
101 | - if (empty($cur_list['rows']) && !empty($cur_list['no_items_label'])) |
|
102 | - echo ' |
|
109 | + if (empty($cur_list['rows']) && !empty($cur_list['no_items_label'])) { |
|
110 | + echo ' |
|
103 | 111 | <tr class="windowbg"> |
104 | 112 | <td colspan="', $cur_list['num_columns'], '" class="', !empty($cur_list['no_items_align']) ? $cur_list['no_items_align'] : 'centertext', '"> |
105 | 113 | ', $cur_list['no_items_label'], ' |
106 | 114 | </td> |
107 | 115 | </tr>'; |
116 | + } |
|
108 | 117 | |
109 | 118 | // Show the list rows. |
110 | 119 | elseif (!empty($cur_list['rows'])) |
@@ -114,12 +123,13 @@ discard block |
||
114 | 123 | echo ' |
115 | 124 | <tr class="windowbg', empty($row['class']) ? '' : ' ' . $row['class'], '"', empty($row['style']) ? '' : ' style="' . $row['style'] . '"', ' id="list_', $list_id, '_', $id, '">'; |
116 | 125 | |
117 | - if (!empty($row['data'])) |
|
118 | - foreach ($row['data'] as $row_data) |
|
126 | + if (!empty($row['data'])) { |
|
127 | + foreach ($row['data'] as $row_data) |
|
119 | 128 | echo ' |
120 | 129 | <td', empty($row_data['class']) ? '' : ' class="' . $row_data['class'] . '"', empty($row_data['style']) ? '' : ' style="' . $row_data['style'] . '"', '> |
121 | 130 | ', $row_data['value'], ' |
122 | 131 | </td>'; |
132 | + } |
|
123 | 133 | |
124 | 134 | echo ' |
125 | 135 | </tr>'; |
@@ -136,46 +146,53 @@ discard block |
||
136 | 146 | <div class="flow_auto">'; |
137 | 147 | |
138 | 148 | // Show the page index (if this list doesn't intend to show all items). |
139 | - if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) |
|
140 | - echo ' |
|
149 | + if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) { |
|
150 | + echo ' |
|
141 | 151 | <div class="floatleft"> |
142 | 152 | <div class="pagesection">', $cur_list['page_index'], '</div> |
143 | 153 | </div>'; |
154 | + } |
|
144 | 155 | |
145 | - if (isset($cur_list['additional_rows']['below_table_data'])) |
|
146 | - template_additional_rows('below_table_data', $cur_list); |
|
156 | + if (isset($cur_list['additional_rows']['below_table_data'])) { |
|
157 | + template_additional_rows('below_table_data', $cur_list); |
|
158 | + } |
|
147 | 159 | |
148 | 160 | echo ' |
149 | 161 | </div>'; |
150 | 162 | } |
151 | 163 | |
152 | - if (isset($cur_list['additional_rows']['bottom_of_list'])) |
|
153 | - template_additional_rows('bottom_of_list', $cur_list); |
|
164 | + if (isset($cur_list['additional_rows']['bottom_of_list'])) { |
|
165 | + template_additional_rows('bottom_of_list', $cur_list); |
|
166 | + } |
|
154 | 167 | |
155 | 168 | if (isset($cur_list['form'])) |
156 | 169 | { |
157 | - foreach ($cur_list['form']['hidden_fields'] as $name => $value) |
|
158 | - echo ' |
|
170 | + foreach ($cur_list['form']['hidden_fields'] as $name => $value) { |
|
171 | + echo ' |
|
159 | 172 | <input type="hidden" name="', $name, '" value="', $value, '">'; |
173 | + } |
|
160 | 174 | |
161 | - if (isset($cur_list['form']['token'])) |
|
162 | - echo ' |
|
175 | + if (isset($cur_list['form']['token'])) { |
|
176 | + echo ' |
|
163 | 177 | <input type="hidden" name="', $context[$cur_list['form']['token'] . '_token_var'], '" value="', $context[$cur_list['form']['token'] . '_token'], '">'; |
178 | + } |
|
164 | 179 | |
165 | 180 | echo ' |
166 | 181 | </form>'; |
167 | 182 | } |
168 | 183 | |
169 | 184 | // Tabs at the bottom. Usually bottom aligned. |
170 | - if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'bottom')) |
|
171 | - template_create_list_menu($cur_list['list_menu'], 'bottom'); |
|
185 | + if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'bottom')) { |
|
186 | + template_create_list_menu($cur_list['list_menu'], 'bottom'); |
|
187 | + } |
|
172 | 188 | |
173 | - if (isset($cur_list['javascript'])) |
|
174 | - echo ' |
|
189 | + if (isset($cur_list['javascript'])) { |
|
190 | + echo ' |
|
175 | 191 | <script> |
176 | 192 | ', $cur_list['javascript'], ' |
177 | 193 | </script>'; |
178 | -} |
|
194 | + } |
|
195 | + } |
|
179 | 196 | |
180 | 197 | /** |
181 | 198 | * This template displays additional rows above or below the list. |
@@ -185,12 +202,13 @@ discard block |
||
185 | 202 | */ |
186 | 203 | function template_additional_rows($row_position, $cur_list) |
187 | 204 | { |
188 | - foreach ($cur_list['additional_rows'][$row_position] as $row) |
|
189 | - echo ' |
|
205 | + foreach ($cur_list['additional_rows'][$row_position] as $row) { |
|
206 | + echo ' |
|
190 | 207 | <div class="additional_row', empty($row['class']) ? '' : ' ' . $row['class'], '"', empty($row['style']) ? '' : ' style="' . $row['style'] . '"', '> |
191 | 208 | ', $row['value'], ' |
192 | 209 | </div>'; |
193 | -} |
|
210 | + } |
|
211 | + } |
|
194 | 212 | |
195 | 213 | /** |
196 | 214 | * This function creates a menu |
@@ -249,18 +267,19 @@ discard block |
||
249 | 267 | |
250 | 268 | foreach ($list_menu['links'] as $link) |
251 | 269 | { |
252 | - if ($link['is_selected']) |
|
253 | - echo ' |
|
270 | + if ($link['is_selected']) { |
|
271 | + echo ' |
|
254 | 272 | <td class="', $direction == 'top' ? 'mirror' : 'main', 'tab_active_', $first, '"></td> |
255 | 273 | <td class="', $direction == 'top' ? 'mirrortab' : 'maintab', '_active_back"> |
256 | 274 | <a href="', $link['href'], '">', $link['label'], '</a> |
257 | 275 | </td> |
258 | 276 | <td class="', $direction == 'top' ? 'mirror' : 'main', 'tab_active_', $last, '"></td>'; |
259 | - else |
|
260 | - echo ' |
|
277 | + } else { |
|
278 | + echo ' |
|
261 | 279 | <td class="', $direction == 'top' ? 'mirror' : 'main', 'tab_back"> |
262 | 280 | <a href="', $link['href'], '">', $link['label'], '</a> |
263 | 281 | </td>'; |
282 | + } |
|
264 | 283 | } |
265 | 284 | |
266 | 285 | echo ' |
@@ -271,12 +290,12 @@ discard block |
||
271 | 290 | <td></td>' : '', ' |
272 | 291 | </tr> |
273 | 292 | </table>'; |
274 | - } |
|
275 | - elseif (isset($list_menu['style']) && $list_menu['style'] == 'buttons') |
|
293 | + } elseif (isset($list_menu['style']) && $list_menu['style'] == 'buttons') |
|
276 | 294 | { |
277 | 295 | $links = array(); |
278 | - foreach ($list_menu['links'] as $link) |
|
279 | - $links[] = '<a href="' . $link['href'] . '">' . $link['label'] . '</a>'; |
|
296 | + foreach ($list_menu['links'] as $link) { |
|
297 | + $links[] = '<a href="' . $link['href'] . '">' . $link['label'] . '</a>'; |
|
298 | + } |
|
280 | 299 | |
281 | 300 | echo ' |
282 | 301 | <table style="margin-', $list_menu['position'], ': 10px; width: 100%;"> |
@@ -101,8 +101,8 @@ discard block |
||
101 | 101 | </div> |
102 | 102 | <ul id="messages_not_selected" class="split_messages smalltext">'; |
103 | 103 | |
104 | - foreach ($context['not_selected']['messages'] as $message) |
|
105 | - echo ' |
|
104 | + foreach ($context['not_selected']['messages'] as $message) { |
|
105 | + echo ' |
|
106 | 106 | <li class="windowbg" id="not_selected_', $message['id'], '"> |
107 | 107 | <div class="message_header"> |
108 | 108 | <a class="split_icon floatright" href="', $scripturl, '?action=splittopics;sa=selectTopics;subname=', $context['topic']['subject'], ';topic=', $context['topic']['id'], '.', $context['not_selected']['start'], ';start2=', $context['selected']['start'], ';move=down;msg=', $message['id'], '" onclick="return select(\'down\', ', $message['id'], ');"><span class="generic_icons split_sel" title="->"></span></a> |
@@ -111,6 +111,7 @@ discard block |
||
111 | 111 | </div> |
112 | 112 | <div class="post">', $message['body'], '</div> |
113 | 113 | </li>'; |
114 | + } |
|
114 | 115 | |
115 | 116 | echo ' |
116 | 117 | <li class="dummy"> |
@@ -130,8 +131,8 @@ discard block |
||
130 | 131 | </div> |
131 | 132 | <ul id="messages_selected" class="split_messages smalltext">'; |
132 | 133 | |
133 | - if (!empty($context['selected']['messages'])) |
|
134 | - foreach ($context['selected']['messages'] as $message) |
|
134 | + if (!empty($context['selected']['messages'])) { |
|
135 | + foreach ($context['selected']['messages'] as $message) |
|
135 | 136 | echo ' |
136 | 137 | <li class="windowbg" id="selected_', $message['id'], '"> |
137 | 138 | <div class="message_header"> |
@@ -141,6 +142,7 @@ discard block |
||
141 | 142 | </div> |
142 | 143 | <div class="post">', $message['body'], '</div> |
143 | 144 | </li>'; |
145 | + } |
|
144 | 146 | |
145 | 147 | echo ' |
146 | 148 | <li class="dummy"> |
@@ -793,7 +793,7 @@ discard block |
||
793 | 793 | if (!$this->connection) |
794 | 794 | { |
795 | 795 | $this->error = 'bad_server'; |
796 | - $this->last_message = 'Invalid Server'; |
|
796 | + $this->last_message = 'Invalid Server'; |
|
797 | 797 | return; |
798 | 798 | } |
799 | 799 | |
@@ -801,7 +801,7 @@ discard block |
||
801 | 801 | if (!$this->check_response(220)) |
802 | 802 | { |
803 | 803 | $this->error = 'bad_response'; |
804 | - $this->last_message = 'Bad Response'; |
|
804 | + $this->last_message = 'Bad Response'; |
|
805 | 805 | return; |
806 | 806 | } |
807 | 807 |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Class xmlArray |
@@ -65,8 +66,9 @@ discard block |
||
65 | 66 | } |
66 | 67 | |
67 | 68 | // Is the input an array? (ie. passed from file()?) |
68 | - if (is_array($data)) |
|
69 | - $data = implode('', $data); |
|
69 | + if (is_array($data)) { |
|
70 | + $data = implode('', $data); |
|
71 | + } |
|
70 | 72 | |
71 | 73 | // Remove any xml declaration or doctype, and parse out comments and CDATA. |
72 | 74 | $data = preg_replace('/<!--.*?-->/s', '', $this->_to_cdata(preg_replace(array('/^<\?xml.+?\?' . '>/is', '/<!DOCTYPE[^>]+?' . '>/s'), '', $data))); |
@@ -101,8 +103,9 @@ discard block |
||
101 | 103 | // Get the element, in array form. |
102 | 104 | $array = $this->path($path); |
103 | 105 | |
104 | - if ($array === false) |
|
105 | - return false; |
|
106 | + if ($array === false) { |
|
107 | + return false; |
|
108 | + } |
|
106 | 109 | |
107 | 110 | // Getting elements into this is a bit complicated... |
108 | 111 | if ($get_elements && !is_string($array)) |
@@ -113,8 +116,9 @@ discard block |
||
113 | 116 | foreach ($array->array as $val) |
114 | 117 | { |
115 | 118 | // Skip the name and any attributes. |
116 | - if (is_array($val)) |
|
117 | - $temp .= $this->_xml($val, null); |
|
119 | + if (is_array($val)) { |
|
120 | + $temp .= $this->_xml($val, null); |
|
121 | + } |
|
118 | 122 | } |
119 | 123 | |
120 | 124 | // Just get the XML data and then take out the CDATAs. |
@@ -156,32 +160,35 @@ discard block |
||
156 | 160 | elseif (substr($el, 0, 1) == '@') |
157 | 161 | { |
158 | 162 | // It simplifies things if the attribute is already there ;). |
159 | - if (isset($array[$el])) |
|
160 | - return $array[$el]; |
|
161 | - else |
|
163 | + if (isset($array[$el])) { |
|
164 | + return $array[$el]; |
|
165 | + } else |
|
162 | 166 | { |
163 | 167 | $trace = debug_backtrace(); |
164 | 168 | $i = 0; |
165 | - while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) |
|
166 | - $i++; |
|
169 | + while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) { |
|
170 | + $i++; |
|
171 | + } |
|
167 | 172 | $debug = ' (from ' . $trace[$i - 1]['file'] . ' on line ' . $trace[$i - 1]['line'] . ')'; |
168 | 173 | |
169 | 174 | // Cause an error. |
170 | - if ($this->debug_level & E_NOTICE) |
|
171 | - trigger_error('Undefined XML attribute: ' . substr($el, 1) . $debug, E_USER_NOTICE); |
|
175 | + if ($this->debug_level & E_NOTICE) { |
|
176 | + trigger_error('Undefined XML attribute: ' . substr($el, 1) . $debug, E_USER_NOTICE); |
|
177 | + } |
|
172 | 178 | return false; |
173 | 179 | } |
180 | + } else { |
|
181 | + $lvl = null; |
|
174 | 182 | } |
175 | - else |
|
176 | - $lvl = null; |
|
177 | 183 | |
178 | 184 | // Find this element. |
179 | 185 | $array = $this->_path($array, $el, $lvl); |
180 | 186 | } |
181 | 187 | |
182 | 188 | // Clean up after $lvl, for $return_full. |
183 | - if ($return_full && (!isset($array['name']) || substr($array['name'], -1) != ']')) |
|
184 | - $array = array('name' => $el . '[]', $array); |
|
189 | + if ($return_full && (!isset($array['name']) || substr($array['name'], -1) != ']')) { |
|
190 | + $array = array('name' => $el . '[]', $array); |
|
191 | + } |
|
185 | 192 | |
186 | 193 | // Create the right type of class... |
187 | 194 | $newClass = get_class($this); |
@@ -216,10 +223,11 @@ discard block |
||
216 | 223 | $el = substr($el, 0, strpos($el, '[')); |
217 | 224 | } |
218 | 225 | // Find an attribute. |
219 | - elseif (substr($el, 0, 1) == '@') |
|
220 | - return isset($array[$el]); |
|
221 | - else |
|
222 | - $lvl = null; |
|
226 | + elseif (substr($el, 0, 1) == '@') { |
|
227 | + return isset($array[$el]); |
|
228 | + } else { |
|
229 | + $lvl = null; |
|
230 | + } |
|
223 | 231 | |
224 | 232 | // Find this element. |
225 | 233 | $array = $this->_path($array, $el, $lvl, true); |
@@ -244,8 +252,9 @@ discard block |
||
244 | 252 | $i = 0; |
245 | 253 | foreach ($temp->array as $item) |
246 | 254 | { |
247 | - if (is_array($item)) |
|
248 | - $i++; |
|
255 | + if (is_array($item)) { |
|
256 | + $i++; |
|
257 | + } |
|
249 | 258 | } |
250 | 259 | |
251 | 260 | return $i; |
@@ -269,8 +278,9 @@ discard block |
||
269 | 278 | foreach ($xml->array as $val) |
270 | 279 | { |
271 | 280 | // Skip these, they aren't elements. |
272 | - if (!is_array($val) || $val['name'] == '!') |
|
273 | - continue; |
|
281 | + if (!is_array($val) || $val['name'] == '!') { |
|
282 | + continue; |
|
283 | + } |
|
274 | 284 | |
275 | 285 | // Create the right type of class... |
276 | 286 | $newClass = get_class($this); |
@@ -297,14 +307,16 @@ discard block |
||
297 | 307 | $path = $this->path($path); |
298 | 308 | |
299 | 309 | // The path was not found |
300 | - if ($path === false) |
|
301 | - return false; |
|
310 | + if ($path === false) { |
|
311 | + return false; |
|
312 | + } |
|
302 | 313 | |
303 | 314 | $path = $path->array; |
304 | 315 | } |
305 | 316 | // Just use the current array. |
306 | - else |
|
307 | - $path = $this->array; |
|
317 | + else { |
|
318 | + $path = $this->array; |
|
319 | + } |
|
308 | 320 | |
309 | 321 | // Add the xml declaration to the front. |
310 | 322 | return '<?xml version="1.0"?' . '>' . $this->_xml($path, 0); |
@@ -326,14 +338,16 @@ discard block |
||
326 | 338 | $path = $this->path($path); |
327 | 339 | |
328 | 340 | // The path was not found |
329 | - if ($path === false) |
|
330 | - return false; |
|
341 | + if ($path === false) { |
|
342 | + return false; |
|
343 | + } |
|
331 | 344 | |
332 | 345 | $path = $path->array; |
333 | 346 | } |
334 | 347 | // No, so just use the current array. |
335 | - else |
|
336 | - $path = $this->array; |
|
348 | + else { |
|
349 | + $path = $this->array; |
|
350 | + } |
|
337 | 351 | |
338 | 352 | return $this->_array($path); |
339 | 353 | } |
@@ -355,8 +369,9 @@ discard block |
||
355 | 369 | { |
356 | 370 | // Find and remove the next tag. |
357 | 371 | preg_match('/\A<([\w\-:]+)((?:\s+.+?)?)([\s]?\/)?' . '>/', $data, $match); |
358 | - if (isset($match[0])) |
|
359 | - $data = preg_replace('/' . preg_quote($match[0], '/') . '/s', '', $data, 1); |
|
372 | + if (isset($match[0])) { |
|
373 | + $data = preg_replace('/' . preg_quote($match[0], '/') . '/s', '', $data, 1); |
|
374 | + } |
|
360 | 375 | |
361 | 376 | // Didn't find a tag? Keep looping.... |
362 | 377 | if (!isset($match[1]) || $match[1] == '') |
@@ -367,11 +382,12 @@ discard block |
||
367 | 382 | $text_value = $this->_from_cdata($data); |
368 | 383 | $data = ''; |
369 | 384 | |
370 | - if ($text_value != '') |
|
371 | - $current[] = array( |
|
385 | + if ($text_value != '') { |
|
386 | + $current[] = array( |
|
372 | 387 | 'name' => '!', |
373 | 388 | 'value' => $text_value |
374 | 389 | ); |
390 | + } |
|
375 | 391 | } |
376 | 392 | // If the < isn't immediately next to the current position... more data. |
377 | 393 | elseif (strpos($data, '<') > 0) |
@@ -379,11 +395,12 @@ discard block |
||
379 | 395 | $text_value = $this->_from_cdata(substr($data, 0, strpos($data, '<'))); |
380 | 396 | $data = substr($data, strpos($data, '<')); |
381 | 397 | |
382 | - if ($text_value != '') |
|
383 | - $current[] = array( |
|
398 | + if ($text_value != '') { |
|
399 | + $current[] = array( |
|
384 | 400 | 'name' => '!', |
385 | 401 | 'value' => $text_value |
386 | 402 | ); |
403 | + } |
|
387 | 404 | } |
388 | 405 | // If we're looking at a </something> with no start, kill it. |
389 | 406 | elseif (strpos($data, '<') !== false && strpos($data, '<') == 0) |
@@ -393,22 +410,23 @@ discard block |
||
393 | 410 | $text_value = $this->_from_cdata(substr($data, 0, strpos($data, '<', 1))); |
394 | 411 | $data = substr($data, strpos($data, '<', 1)); |
395 | 412 | |
396 | - if ($text_value != '') |
|
397 | - $current[] = array( |
|
413 | + if ($text_value != '') { |
|
414 | + $current[] = array( |
|
398 | 415 | 'name' => '!', |
399 | 416 | 'value' => $text_value |
400 | 417 | ); |
401 | - } |
|
402 | - else |
|
418 | + } |
|
419 | + } else |
|
403 | 420 | { |
404 | 421 | $text_value = $this->_from_cdata($data); |
405 | 422 | $data = ''; |
406 | 423 | |
407 | - if ($text_value != '') |
|
408 | - $current[] = array( |
|
424 | + if ($text_value != '') { |
|
425 | + $current[] = array( |
|
409 | 426 | 'name' => '!', |
410 | 427 | 'value' => $text_value |
411 | 428 | ); |
429 | + } |
|
412 | 430 | } |
413 | 431 | } |
414 | 432 | |
@@ -425,8 +443,9 @@ discard block |
||
425 | 443 | { |
426 | 444 | // Because PHP 5.2.0+ seems to croak using regex, we'll have to do this the less fun way. |
427 | 445 | $last_tag_end = strpos($data, '</' . $match[1] . '>'); |
428 | - if ($last_tag_end === false) |
|
429 | - continue; |
|
446 | + if ($last_tag_end === false) { |
|
447 | + continue; |
|
448 | + } |
|
430 | 449 | |
431 | 450 | $offset = 0; |
432 | 451 | while (1 == 1) |
@@ -434,16 +453,17 @@ discard block |
||
434 | 453 | // Where is the next start tag? |
435 | 454 | $next_tag_start = strpos($data, '<' . $match[1], $offset); |
436 | 455 | // If the next start tag is after the last end tag then we've found the right close. |
437 | - if ($next_tag_start === false || $next_tag_start > $last_tag_end) |
|
438 | - break; |
|
456 | + if ($next_tag_start === false || $next_tag_start > $last_tag_end) { |
|
457 | + break; |
|
458 | + } |
|
439 | 459 | |
440 | 460 | // If not then find the next ending tag. |
441 | 461 | $next_tag_end = strpos($data, '</' . $match[1] . '>', $offset); |
442 | 462 | |
443 | 463 | // Didn't find one? Then just use the last and sod it. |
444 | - if ($next_tag_end === false) |
|
445 | - break; |
|
446 | - else |
|
464 | + if ($next_tag_end === false) { |
|
465 | + break; |
|
466 | + } else |
|
447 | 467 | { |
448 | 468 | $last_tag_end = $next_tag_end; |
449 | 469 | $offset = $next_tag_start + 1; |
@@ -457,16 +477,17 @@ discard block |
||
457 | 477 | if (!empty($inner_match)) |
458 | 478 | { |
459 | 479 | // Parse the inner data. |
460 | - if (strpos($inner_match, '<') !== false) |
|
461 | - $el += $this->_parse($inner_match); |
|
462 | - elseif (trim($inner_match) != '') |
|
480 | + if (strpos($inner_match, '<') !== false) { |
|
481 | + $el += $this->_parse($inner_match); |
|
482 | + } elseif (trim($inner_match) != '') |
|
463 | 483 | { |
464 | 484 | $text_value = $this->_from_cdata($inner_match); |
465 | - if ($text_value != '') |
|
466 | - $el[] = array( |
|
485 | + if ($text_value != '') { |
|
486 | + $el[] = array( |
|
467 | 487 | 'name' => '!', |
468 | 488 | 'value' => $text_value |
469 | 489 | ); |
490 | + } |
|
470 | 491 | } |
471 | 492 | } |
472 | 493 | } |
@@ -478,8 +499,9 @@ discard block |
||
478 | 499 | preg_match_all('/([\w:]+)="(.+?)"/', $match[2], $attr, PREG_SET_ORDER); |
479 | 500 | |
480 | 501 | // Set them as @attribute-name. |
481 | - foreach ($attr as $match_attr) |
|
482 | - $el['@' . $match_attr[1]] = $match_attr[2]; |
|
502 | + foreach ($attr as $match_attr) { |
|
503 | + $el['@' . $match_attr[1]] = $match_attr[2]; |
|
504 | + } |
|
483 | 505 | } |
484 | 506 | } |
485 | 507 | |
@@ -503,16 +525,18 @@ discard block |
||
503 | 525 | if (is_array($array) && !isset($array['name'])) |
504 | 526 | { |
505 | 527 | $temp = ''; |
506 | - foreach ($array as $val) |
|
507 | - $temp .= $this->_xml($val, $indent); |
|
528 | + foreach ($array as $val) { |
|
529 | + $temp .= $this->_xml($val, $indent); |
|
530 | + } |
|
508 | 531 | return $temp; |
509 | 532 | } |
510 | 533 | |
511 | 534 | // This is just text! |
512 | - if ($array['name'] == '!') |
|
513 | - return $indentation . '<![CDATA[' . $array['value'] . ']]>'; |
|
514 | - elseif (substr($array['name'], -2) == '[]') |
|
515 | - $array['name'] = substr($array['name'], 0, -2); |
|
535 | + if ($array['name'] == '!') { |
|
536 | + return $indentation . '<![CDATA[' . $array['value'] . ']]>'; |
|
537 | + } elseif (substr($array['name'], -2) == '[]') { |
|
538 | + $array['name'] = substr($array['name'], 0, -2); |
|
539 | + } |
|
516 | 540 | |
517 | 541 | // Start the element. |
518 | 542 | $output = $indentation . '<' . $array['name']; |
@@ -523,9 +547,9 @@ discard block |
||
523 | 547 | // Run through and recursively output all the elements or attrbutes inside this. |
524 | 548 | foreach ($array as $k => $v) |
525 | 549 | { |
526 | - if (substr($k, 0, 1) == '@') |
|
527 | - $output .= ' ' . substr($k, 1) . '="' . $v . '"'; |
|
528 | - elseif (is_array($v)) |
|
550 | + if (substr($k, 0, 1) == '@') { |
|
551 | + $output .= ' ' . substr($k, 1) . '="' . $v . '"'; |
|
552 | + } elseif (is_array($v)) |
|
529 | 553 | { |
530 | 554 | $output_el .= $this->_xml($v, $indent === null ? null : $indent + 1); |
531 | 555 | $inside_elements = true; |
@@ -533,10 +557,11 @@ discard block |
||
533 | 557 | } |
534 | 558 | |
535 | 559 | // Indent, if necessary.... then close the tag. |
536 | - if ($inside_elements) |
|
537 | - $output .= '>' . $output_el . $indentation . '</' . $array['name'] . '>'; |
|
538 | - else |
|
539 | - $output .= ' />'; |
|
560 | + if ($inside_elements) { |
|
561 | + $output .= '>' . $output_el . $indentation . '</' . $array['name'] . '>'; |
|
562 | + } else { |
|
563 | + $output .= ' />'; |
|
564 | + } |
|
540 | 565 | |
541 | 566 | return $output; |
542 | 567 | } |
@@ -553,19 +578,22 @@ discard block |
||
553 | 578 | $text = ''; |
554 | 579 | foreach ($array as $value) |
555 | 580 | { |
556 | - if (!is_array($value) || !isset($value['name'])) |
|
557 | - continue; |
|
581 | + if (!is_array($value) || !isset($value['name'])) { |
|
582 | + continue; |
|
583 | + } |
|
558 | 584 | |
559 | - if ($value['name'] == '!') |
|
560 | - $text .= $value['value']; |
|
561 | - else |
|
562 | - $return[$value['name']] = $this->_array($value); |
|
585 | + if ($value['name'] == '!') { |
|
586 | + $text .= $value['value']; |
|
587 | + } else { |
|
588 | + $return[$value['name']] = $this->_array($value); |
|
589 | + } |
|
563 | 590 | } |
564 | 591 | |
565 | - if (empty($return)) |
|
566 | - return $text; |
|
567 | - else |
|
568 | - return $return; |
|
592 | + if (empty($return)) { |
|
593 | + return $text; |
|
594 | + } else { |
|
595 | + return $return; |
|
596 | + } |
|
569 | 597 | } |
570 | 598 | |
571 | 599 | /** |
@@ -583,24 +611,28 @@ discard block |
||
583 | 611 | foreach ($parts as $part) |
584 | 612 | { |
585 | 613 | // Handle XML comments. |
586 | - if (!$inCdata && $part === '<!--') |
|
587 | - $inComment = true; |
|
588 | - if ($inComment && $part === '-->') |
|
589 | - $inComment = false; |
|
590 | - elseif ($inComment) |
|
591 | - continue; |
|
614 | + if (!$inCdata && $part === '<!--') { |
|
615 | + $inComment = true; |
|
616 | + } |
|
617 | + if ($inComment && $part === '-->') { |
|
618 | + $inComment = false; |
|
619 | + } elseif ($inComment) { |
|
620 | + continue; |
|
621 | + } |
|
592 | 622 | |
593 | 623 | // Handle Cdata blocks. |
594 | - elseif (!$inComment && $part === '<![CDATA[') |
|
595 | - $inCdata = true; |
|
596 | - elseif ($inCdata && $part === ']]>') |
|
597 | - $inCdata = false; |
|
598 | - elseif ($inCdata) |
|
599 | - $output .= htmlentities($part, ENT_QUOTES); |
|
624 | + elseif (!$inComment && $part === '<![CDATA[') { |
|
625 | + $inCdata = true; |
|
626 | + } elseif ($inCdata && $part === ']]>') { |
|
627 | + $inCdata = false; |
|
628 | + } elseif ($inCdata) { |
|
629 | + $output .= htmlentities($part, ENT_QUOTES); |
|
630 | + } |
|
600 | 631 | |
601 | 632 | // Everything else is kept as is. |
602 | - else |
|
603 | - $output .= $part; |
|
633 | + else { |
|
634 | + $output .= $part; |
|
635 | + } |
|
604 | 636 | } |
605 | 637 | |
606 | 638 | return $output; |
@@ -635,22 +667,26 @@ discard block |
||
635 | 667 | protected function _fetch($array) |
636 | 668 | { |
637 | 669 | // Don't return anything if this is just a string. |
638 | - if (is_string($array)) |
|
639 | - return ''; |
|
670 | + if (is_string($array)) { |
|
671 | + return ''; |
|
672 | + } |
|
640 | 673 | |
641 | 674 | $temp = ''; |
642 | 675 | foreach ($array as $text) |
643 | 676 | { |
644 | 677 | // This means it's most likely an attribute or the name itself. |
645 | - if (!isset($text['name'])) |
|
646 | - continue; |
|
678 | + if (!isset($text['name'])) { |
|
679 | + continue; |
|
680 | + } |
|
647 | 681 | |
648 | 682 | // This is text! |
649 | - if ($text['name'] == '!') |
|
650 | - $temp .= $text['value']; |
|
683 | + if ($text['name'] == '!') { |
|
684 | + $temp .= $text['value']; |
|
685 | + } |
|
651 | 686 | // Another element - dive in ;). |
652 | - else |
|
653 | - $temp .= $this->_fetch($text); |
|
687 | + else { |
|
688 | + $temp .= $this->_fetch($text); |
|
689 | + } |
|
654 | 690 | } |
655 | 691 | |
656 | 692 | // Return all the bits and pieces we've put together. |
@@ -669,12 +705,14 @@ discard block |
||
669 | 705 | protected function _path($array, $path, $level, $no_error = false) |
670 | 706 | { |
671 | 707 | // Is $array even an array? It might be false! |
672 | - if (!is_array($array)) |
|
673 | - return false; |
|
708 | + if (!is_array($array)) { |
|
709 | + return false; |
|
710 | + } |
|
674 | 711 | |
675 | 712 | // Asking for *no* path? |
676 | - if ($path == '' || $path == '.') |
|
677 | - return $array; |
|
713 | + if ($path == '' || $path == '.') { |
|
714 | + return $array; |
|
715 | + } |
|
678 | 716 | $paths = explode('|', $path); |
679 | 717 | |
680 | 718 | // A * means all elements of any name. |
@@ -685,16 +723,18 @@ discard block |
||
685 | 723 | // Check each element. |
686 | 724 | foreach ($array as $value) |
687 | 725 | { |
688 | - if (!is_array($value) || $value['name'] === '!') |
|
689 | - continue; |
|
726 | + if (!is_array($value) || $value['name'] === '!') { |
|
727 | + continue; |
|
728 | + } |
|
690 | 729 | |
691 | 730 | if ($show_all || in_array($value['name'], $paths)) |
692 | 731 | { |
693 | 732 | // Skip elements before "the one". |
694 | - if ($level !== null && $level > 0) |
|
695 | - $level--; |
|
696 | - else |
|
697 | - $results[] = $value; |
|
733 | + if ($level !== null && $level > 0) { |
|
734 | + $level--; |
|
735 | + } else { |
|
736 | + $results[] = $value; |
|
737 | + } |
|
698 | 738 | } |
699 | 739 | } |
700 | 740 | |
@@ -703,21 +743,25 @@ discard block |
||
703 | 743 | { |
704 | 744 | $trace = debug_backtrace(); |
705 | 745 | $i = 0; |
706 | - while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) |
|
707 | - $i++; |
|
746 | + while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) { |
|
747 | + $i++; |
|
748 | + } |
|
708 | 749 | $debug = ' from ' . $trace[$i - 1]['file'] . ' on line ' . $trace[$i - 1]['line']; |
709 | 750 | |
710 | 751 | // Cause an error. |
711 | - if ($this->debug_level & E_NOTICE && !$no_error) |
|
712 | - trigger_error('Undefined XML element: ' . $path . $debug, E_USER_NOTICE); |
|
752 | + if ($this->debug_level & E_NOTICE && !$no_error) { |
|
753 | + trigger_error('Undefined XML element: ' . $path . $debug, E_USER_NOTICE); |
|
754 | + } |
|
713 | 755 | return false; |
714 | 756 | } |
715 | 757 | // Only one result. |
716 | - elseif (count($results) == 1 || $level !== null) |
|
717 | - return $results[0]; |
|
758 | + elseif (count($results) == 1 || $level !== null) { |
|
759 | + return $results[0]; |
|
760 | + } |
|
718 | 761 | // Return the result set. |
719 | - else |
|
720 | - return $results + array('name' => $path . '[]'); |
|
762 | + else { |
|
763 | + return $results + array('name' => $path . '[]'); |
|
764 | + } |
|
721 | 765 | } |
722 | 766 | } |
723 | 767 | |
@@ -764,8 +808,9 @@ discard block |
||
764 | 808 | $this->error = false; |
765 | 809 | $this->pasv = array(); |
766 | 810 | |
767 | - if ($ftp_server !== null) |
|
768 | - $this->connect($ftp_server, $ftp_port, $ftp_user, $ftp_pass); |
|
811 | + if ($ftp_server !== null) { |
|
812 | + $this->connect($ftp_server, $ftp_port, $ftp_user, $ftp_pass); |
|
813 | + } |
|
769 | 814 | } |
770 | 815 | |
771 | 816 | /** |
@@ -778,14 +823,16 @@ discard block |
||
778 | 823 | */ |
779 | 824 | public function connect($ftp_server, $ftp_port = 21, $ftp_user = 'anonymous', $ftp_pass = '[email protected]') |
780 | 825 | { |
781 | - if (strpos($ftp_server, 'ftp://') === 0) |
|
782 | - $ftp_server = substr($ftp_server, 6); |
|
783 | - elseif (strpos($ftp_server, 'ftps://') === 0) |
|
784 | - $ftp_server = 'ssl://' . substr($ftp_server, 7); |
|
785 | - if (strpos($ftp_server, 'http://') === 0) |
|
786 | - $ftp_server = substr($ftp_server, 7); |
|
787 | - elseif (strpos($ftp_server, 'https://') === 0) |
|
788 | - $ftp_server = substr($ftp_server, 8); |
|
826 | + if (strpos($ftp_server, 'ftp://') === 0) { |
|
827 | + $ftp_server = substr($ftp_server, 6); |
|
828 | + } elseif (strpos($ftp_server, 'ftps://') === 0) { |
|
829 | + $ftp_server = 'ssl://' . substr($ftp_server, 7); |
|
830 | + } |
|
831 | + if (strpos($ftp_server, 'http://') === 0) { |
|
832 | + $ftp_server = substr($ftp_server, 7); |
|
833 | + } elseif (strpos($ftp_server, 'https://') === 0) { |
|
834 | + $ftp_server = substr($ftp_server, 8); |
|
835 | + } |
|
789 | 836 | $ftp_server = strtr($ftp_server, array('/' => '', ':' => '', '@' => '')); |
790 | 837 | |
791 | 838 | // Connect to the FTP server. |
@@ -834,12 +881,14 @@ discard block |
||
834 | 881 | */ |
835 | 882 | public function chdir($ftp_path) |
836 | 883 | { |
837 | - if (!is_resource($this->connection)) |
|
838 | - return false; |
|
884 | + if (!is_resource($this->connection)) { |
|
885 | + return false; |
|
886 | + } |
|
839 | 887 | |
840 | 888 | // No slash on the end, please... |
841 | - if ($ftp_path !== '/' && substr($ftp_path, -1) === '/') |
|
842 | - $ftp_path = substr($ftp_path, 0, -1); |
|
889 | + if ($ftp_path !== '/' && substr($ftp_path, -1) === '/') { |
|
890 | + $ftp_path = substr($ftp_path, 0, -1); |
|
891 | + } |
|
843 | 892 | |
844 | 893 | fwrite($this->connection, 'CWD ' . $ftp_path . "\r\n"); |
845 | 894 | if (!$this->check_response(250)) |
@@ -860,11 +909,13 @@ discard block |
||
860 | 909 | */ |
861 | 910 | public function chmod($ftp_file, $chmod) |
862 | 911 | { |
863 | - if (!is_resource($this->connection)) |
|
864 | - return false; |
|
912 | + if (!is_resource($this->connection)) { |
|
913 | + return false; |
|
914 | + } |
|
865 | 915 | |
866 | - if ($ftp_file == '') |
|
867 | - $ftp_file = '.'; |
|
916 | + if ($ftp_file == '') { |
|
917 | + $ftp_file = '.'; |
|
918 | + } |
|
868 | 919 | |
869 | 920 | // Do we have a file or a dir? |
870 | 921 | $is_dir = is_dir($ftp_file); |
@@ -880,9 +931,7 @@ discard block |
||
880 | 931 | { |
881 | 932 | $is_writable = true; |
882 | 933 | break; |
883 | - } |
|
884 | - |
|
885 | - else |
|
934 | + } else |
|
886 | 935 | { |
887 | 936 | // Convert the chmod value from octal (0777) to text ("777"). |
888 | 937 | fwrite($this->connection, 'SITE CHMOD ' . decoct($val) . ' ' . $ftp_file . "\r\n"); |
@@ -905,8 +954,9 @@ discard block |
||
905 | 954 | public function unlink($ftp_file) |
906 | 955 | { |
907 | 956 | // We are actually connected, right? |
908 | - if (!is_resource($this->connection)) |
|
909 | - return false; |
|
957 | + if (!is_resource($this->connection)) { |
|
958 | + return false; |
|
959 | + } |
|
910 | 960 | |
911 | 961 | // Delete file X. |
912 | 962 | fwrite($this->connection, 'DELE ' . $ftp_file . "\r\n"); |
@@ -935,9 +985,9 @@ discard block |
||
935 | 985 | { |
936 | 986 | // Wait for a response that isn't continued with -, but don't wait too long. |
937 | 987 | $time = time(); |
938 | - do |
|
939 | - $this->last_message = fgets($this->connection, 1024); |
|
940 | - while ((strlen($this->last_message) < 4 || strpos($this->last_message, ' ') === 0 || strpos($this->last_message, ' ', 3) !== 3) && time() - $time < 5); |
|
988 | + do { |
|
989 | + $this->last_message = fgets($this->connection, 1024); |
|
990 | + } while ((strlen($this->last_message) < 4 || strpos($this->last_message, ' ') === 0 || strpos($this->last_message, ' ', 3) !== 3) && time() - $time < 5); |
|
941 | 991 | |
942 | 992 | // Was the desired response returned? |
943 | 993 | return is_array($desired) ? in_array(substr($this->last_message, 0, 3), $desired) : substr($this->last_message, 0, 3) == $desired; |
@@ -951,15 +1001,16 @@ discard block |
||
951 | 1001 | public function passive() |
952 | 1002 | { |
953 | 1003 | // We can't create a passive data connection without a primary one first being there. |
954 | - if (!is_resource($this->connection)) |
|
955 | - return false; |
|
1004 | + if (!is_resource($this->connection)) { |
|
1005 | + return false; |
|
1006 | + } |
|
956 | 1007 | |
957 | 1008 | // Request a passive connection - this means, we'll talk to you, you don't talk to us. |
958 | 1009 | @fwrite($this->connection, 'PASV' . "\r\n"); |
959 | 1010 | $time = time(); |
960 | - do |
|
961 | - $response = fgets($this->connection, 1024); |
|
962 | - while (strpos($response, ' ', 3) !== 3 && time() - $time < 5); |
|
1011 | + do { |
|
1012 | + $response = fgets($this->connection, 1024); |
|
1013 | + } while (strpos($response, ' ', 3) !== 3 && time() - $time < 5); |
|
963 | 1014 | |
964 | 1015 | // If it's not 227, we weren't given an IP and port, which means it failed. |
965 | 1016 | if (strpos($response, '227 ') !== 0) |
@@ -990,12 +1041,14 @@ discard block |
||
990 | 1041 | public function create_file($ftp_file) |
991 | 1042 | { |
992 | 1043 | // First, we have to be connected... very important. |
993 | - if (!is_resource($this->connection)) |
|
994 | - return false; |
|
1044 | + if (!is_resource($this->connection)) { |
|
1045 | + return false; |
|
1046 | + } |
|
995 | 1047 | |
996 | 1048 | // I'd like one passive mode, please! |
997 | - if (!$this->passive()) |
|
998 | - return false; |
|
1049 | + if (!$this->passive()) { |
|
1050 | + return false; |
|
1051 | + } |
|
999 | 1052 | |
1000 | 1053 | // Seems logical enough, so far... |
1001 | 1054 | fwrite($this->connection, 'STOR ' . $ftp_file . "\r\n"); |
@@ -1030,12 +1083,14 @@ discard block |
||
1030 | 1083 | public function list_dir($ftp_path = '', $search = false) |
1031 | 1084 | { |
1032 | 1085 | // Are we even connected...? |
1033 | - if (!is_resource($this->connection)) |
|
1034 | - return false; |
|
1086 | + if (!is_resource($this->connection)) { |
|
1087 | + return false; |
|
1088 | + } |
|
1035 | 1089 | |
1036 | 1090 | // Passive... non-agressive... |
1037 | - if (!$this->passive()) |
|
1038 | - return false; |
|
1091 | + if (!$this->passive()) { |
|
1092 | + return false; |
|
1093 | + } |
|
1039 | 1094 | |
1040 | 1095 | // Get the listing! |
1041 | 1096 | fwrite($this->connection, 'LIST -1' . ($search ? 'R' : '') . ($ftp_path == '' ? '' : ' ' . $ftp_path) . "\r\n"); |
@@ -1051,8 +1106,9 @@ discard block |
||
1051 | 1106 | |
1052 | 1107 | // Read in the file listing. |
1053 | 1108 | $data = ''; |
1054 | - while (!feof($fp)) |
|
1055 | - $data .= fread($fp, 4096); |
|
1109 | + while (!feof($fp)) { |
|
1110 | + $data .= fread($fp, 4096); |
|
1111 | + } |
|
1056 | 1112 | fclose($fp); |
1057 | 1113 | |
1058 | 1114 | // Everything go okay? |
@@ -1074,21 +1130,23 @@ discard block |
||
1074 | 1130 | */ |
1075 | 1131 | public function locate($file, $listing = null) |
1076 | 1132 | { |
1077 | - if ($listing === null) |
|
1078 | - $listing = $this->list_dir('', true); |
|
1133 | + if ($listing === null) { |
|
1134 | + $listing = $this->list_dir('', true); |
|
1135 | + } |
|
1079 | 1136 | $listing = explode("\n", $listing); |
1080 | 1137 | |
1081 | 1138 | @fwrite($this->connection, 'PWD' . "\r\n"); |
1082 | 1139 | $time = time(); |
1083 | - do |
|
1084 | - $response = fgets($this->connection, 1024); |
|
1085 | - while ($response[3] != ' ' && time() - $time < 5); |
|
1140 | + do { |
|
1141 | + $response = fgets($this->connection, 1024); |
|
1142 | + } while ($response[3] != ' ' && time() - $time < 5); |
|
1086 | 1143 | |
1087 | 1144 | // Check for 257! |
1088 | - if (preg_match('~^257 "(.+?)" ~', $response, $match) != 0) |
|
1089 | - $current_dir = strtr($match[1], array('""' => '"')); |
|
1090 | - else |
|
1091 | - $current_dir = ''; |
|
1145 | + if (preg_match('~^257 "(.+?)" ~', $response, $match) != 0) { |
|
1146 | + $current_dir = strtr($match[1], array('""' => '"')); |
|
1147 | + } else { |
|
1148 | + $current_dir = ''; |
|
1149 | + } |
|
1092 | 1150 | |
1093 | 1151 | for ($i = 0, $n = count($listing); $i < $n; $i++) |
1094 | 1152 | { |
@@ -1101,12 +1159,15 @@ discard block |
||
1101 | 1159 | // Okay, this file's name is: |
1102 | 1160 | $listing[$i] = $current_dir . '/' . trim(strlen($listing[$i]) > 30 ? strrchr($listing[$i], ' ') : $listing[$i]); |
1103 | 1161 | |
1104 | - if ($file[0] == '*' && substr($listing[$i], -(strlen($file) - 1)) == substr($file, 1)) |
|
1105 | - return $listing[$i]; |
|
1106 | - if (substr($file, -1) == '*' && substr($listing[$i], 0, strlen($file) - 1) == substr($file, 0, -1)) |
|
1107 | - return $listing[$i]; |
|
1108 | - if (basename($listing[$i]) == $file || $listing[$i] == $file) |
|
1109 | - return $listing[$i]; |
|
1162 | + if ($file[0] == '*' && substr($listing[$i], -(strlen($file) - 1)) == substr($file, 1)) { |
|
1163 | + return $listing[$i]; |
|
1164 | + } |
|
1165 | + if (substr($file, -1) == '*' && substr($listing[$i], 0, strlen($file) - 1) == substr($file, 0, -1)) { |
|
1166 | + return $listing[$i]; |
|
1167 | + } |
|
1168 | + if (basename($listing[$i]) == $file || $listing[$i] == $file) { |
|
1169 | + return $listing[$i]; |
|
1170 | + } |
|
1110 | 1171 | } |
1111 | 1172 | |
1112 | 1173 | return false; |
@@ -1121,8 +1182,9 @@ discard block |
||
1121 | 1182 | public function create_dir($ftp_dir) |
1122 | 1183 | { |
1123 | 1184 | // We must be connected to the server to do something. |
1124 | - if (!is_resource($this->connection)) |
|
1125 | - return false; |
|
1185 | + if (!is_resource($this->connection)) { |
|
1186 | + return false; |
|
1187 | + } |
|
1126 | 1188 | |
1127 | 1189 | // Make this new beautiful directory! |
1128 | 1190 | fwrite($this->connection, 'MKD ' . $ftp_dir . "\r\n"); |
@@ -1154,35 +1216,40 @@ discard block |
||
1154 | 1216 | |
1155 | 1217 | $path = strtr($_SERVER['DOCUMENT_ROOT'], array('/home/' . $match[1] . '/' => '', '/home2/' . $match[1] . '/' => '')); |
1156 | 1218 | |
1157 | - if (substr($path, -1) == '/') |
|
1158 | - $path = substr($path, 0, -1); |
|
1219 | + if (substr($path, -1) == '/') { |
|
1220 | + $path = substr($path, 0, -1); |
|
1221 | + } |
|
1159 | 1222 | |
1160 | - if (strlen(dirname($_SERVER['PHP_SELF'])) > 1) |
|
1161 | - $path .= dirname($_SERVER['PHP_SELF']); |
|
1223 | + if (strlen(dirname($_SERVER['PHP_SELF'])) > 1) { |
|
1224 | + $path .= dirname($_SERVER['PHP_SELF']); |
|
1225 | + } |
|
1226 | + } elseif (strpos($filesystem_path, '/var/www/') === 0) { |
|
1227 | + $path = substr($filesystem_path, 8); |
|
1228 | + } else { |
|
1229 | + $path = strtr(strtr($filesystem_path, array('\\' => '/')), array($_SERVER['DOCUMENT_ROOT'] => '')); |
|
1162 | 1230 | } |
1163 | - elseif (strpos($filesystem_path, '/var/www/') === 0) |
|
1164 | - $path = substr($filesystem_path, 8); |
|
1165 | - else |
|
1166 | - $path = strtr(strtr($filesystem_path, array('\\' => '/')), array($_SERVER['DOCUMENT_ROOT'] => '')); |
|
1231 | + } else { |
|
1232 | + $path = ''; |
|
1167 | 1233 | } |
1168 | - else |
|
1169 | - $path = ''; |
|
1170 | 1234 | |
1171 | 1235 | if (is_resource($this->connection) && $this->list_dir($path) == '') |
1172 | 1236 | { |
1173 | 1237 | $data = $this->list_dir('', true); |
1174 | 1238 | |
1175 | - if ($lookup_file === null) |
|
1176 | - $lookup_file = $_SERVER['PHP_SELF']; |
|
1239 | + if ($lookup_file === null) { |
|
1240 | + $lookup_file = $_SERVER['PHP_SELF']; |
|
1241 | + } |
|
1177 | 1242 | |
1178 | 1243 | $found_path = dirname($this->locate('*' . basename(dirname($lookup_file)) . '/' . basename($lookup_file), $data)); |
1179 | - if ($found_path == false) |
|
1180 | - $found_path = dirname($this->locate(basename($lookup_file))); |
|
1181 | - if ($found_path != false) |
|
1182 | - $path = $found_path; |
|
1244 | + if ($found_path == false) { |
|
1245 | + $found_path = dirname($this->locate(basename($lookup_file))); |
|
1246 | + } |
|
1247 | + if ($found_path != false) { |
|
1248 | + $path = $found_path; |
|
1249 | + } |
|
1250 | + } elseif (is_resource($this->connection)) { |
|
1251 | + $found_path = true; |
|
1183 | 1252 | } |
1184 | - elseif (is_resource($this->connection)) |
|
1185 | - $found_path = true; |
|
1186 | 1253 | |
1187 | 1254 | return array($username, $path, isset($found_path)); |
1188 | 1255 | } |
@@ -50,8 +50,8 @@ discard block |
||
50 | 50 | ) |
51 | 51 | ); |
52 | 52 | $members = array(); |
53 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
54 | - $members[$row['id_member']] = array( |
|
53 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
54 | + $members[$row['id_member']] = array( |
|
55 | 55 | 'id' => $row['id_member'], |
56 | 56 | 'real_name' => $row['real_name'], |
57 | 57 | 'email_address' => $row['email_address'], |
@@ -62,6 +62,7 @@ discard block |
||
62 | 62 | ), |
63 | 63 | 'lngfile' => $row['lngfile'], |
64 | 64 | ); |
65 | + } |
|
65 | 66 | $smcFunc['db_free_result']($request); |
66 | 67 | |
67 | 68 | return $members; |
@@ -83,13 +84,14 @@ discard block |
||
83 | 84 | |
84 | 85 | call_integration_hook('mention_insert_' . $content_type, array($content_id, &$members)); |
85 | 86 | |
86 | - foreach ($members as $member) |
|
87 | - $smcFunc['db_insert']('ignore', |
|
87 | + foreach ($members as $member) { |
|
88 | + $smcFunc['db_insert']('ignore', |
|
88 | 89 | '{db_prefix}mentions', |
89 | 90 | array('content_id' => 'int', 'content_type' => 'string', 'id_member' => 'int', 'id_mentioned' => 'int', 'time' => 'int'), |
90 | 91 | array((int) $content_id, $content_type, $id_member, $member['id'], time()), |
91 | 92 | array('content_id', 'content_type', 'id_mentioned') |
92 | 93 | ); |
94 | + } |
|
93 | 95 | } |
94 | 96 | |
95 | 97 | /** |
@@ -103,8 +105,9 @@ discard block |
||
103 | 105 | */ |
104 | 106 | public static function getBody($body, array $members) |
105 | 107 | { |
106 | - foreach ($members as $member) |
|
107 | - $body = str_ireplace(static::$char . $member['real_name'], '[member=' . $member['id'] . ']' . $member['real_name'] . '[/member]', $body); |
|
108 | + foreach ($members as $member) { |
|
109 | + $body = str_ireplace(static::$char . $member['real_name'], '[member=' . $member['id'] . ']' . $member['real_name'] . '[/member]', $body); |
|
110 | + } |
|
108 | 111 | |
109 | 112 | return $body; |
110 | 113 | } |
@@ -123,8 +126,9 @@ discard block |
||
123 | 126 | |
124 | 127 | $possible_names = self::getPossibleMentions($body); |
125 | 128 | |
126 | - if (empty($possible_names) || !allowedTo('mention')) |
|
127 | - return array(); |
|
129 | + if (empty($possible_names) || !allowedTo('mention')) { |
|
130 | + return array(); |
|
131 | + } |
|
128 | 132 | |
129 | 133 | $request = $smcFunc['db_query']('', ' |
130 | 134 | SELECT id_member, real_name |
@@ -140,8 +144,9 @@ discard block |
||
140 | 144 | $members = array(); |
141 | 145 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
142 | 146 | { |
143 | - if (stripos($body, static::$char . $row['real_name']) === false) |
|
144 | - continue; |
|
147 | + if (stripos($body, static::$char . $row['real_name']) === false) { |
|
148 | + continue; |
|
149 | + } |
|
145 | 150 | |
146 | 151 | $members[$row['id_member']] = array( |
147 | 152 | 'id' => $row['id_member'], |
@@ -185,8 +190,9 @@ discard block |
||
185 | 190 | $body = htmlspecialchars_decode(preg_replace('~<br\s*/?\>~', "\n", str_replace(' ', ' ', $body)), ENT_QUOTES); |
186 | 191 | |
187 | 192 | // Remove quotes, we don't want to get double mentions. |
188 | - while (preg_match('~\[quote[^\]]*\](.+?)\[\/quote\]~s', $body)) |
|
189 | - $body = preg_replace('~\[quote[^\]]*\](.+?)\[\/quote\]~s', '', $body); |
|
193 | + while (preg_match('~\[quote[^\]]*\](.+?)\[\/quote\]~s', $body)) { |
|
194 | + $body = preg_replace('~\[quote[^\]]*\](.+?)\[\/quote\]~s', '', $body); |
|
195 | + } |
|
190 | 196 | |
191 | 197 | $matches = array(); |
192 | 198 | $string = str_split($body); |
@@ -197,9 +203,9 @@ discard block |
||
197 | 203 | { |
198 | 204 | $depth++; |
199 | 205 | $matches[] = array(); |
206 | + } elseif ($char == "\n") { |
|
207 | + $depth = 0; |
|
200 | 208 | } |
201 | - elseif ($char == "\n") |
|
202 | - $depth = 0; |
|
203 | 209 | |
204 | 210 | for ($i = $depth; $i > 0; $i--) |
205 | 211 | { |
@@ -212,8 +218,9 @@ discard block |
||
212 | 218 | } |
213 | 219 | } |
214 | 220 | |
215 | - foreach ($matches as $k => $match) |
|
216 | - $matches[$k] = substr(implode('', $match), 1); |
|
221 | + foreach ($matches as $k => $match) { |
|
222 | + $matches[$k] = substr(implode('', $match), 1); |
|
223 | + } |
|
217 | 224 | |
218 | 225 | // Names can have spaces, other breaks, or they can't...we try to match every possible |
219 | 226 | // combination. |
@@ -223,8 +230,9 @@ discard block |
||
223 | 230 | $match = preg_split('/([^\w])/', $match, -1, PREG_SPLIT_DELIM_CAPTURE); |
224 | 231 | $count = count($match); |
225 | 232 | |
226 | - for ($i = 1; $i <= $count; $i++) |
|
227 | - $names[] = $smcFunc['htmlspecialchars']($smcFunc['htmltrim'](implode('', array_slice($match, 0, $i)))); |
|
233 | + for ($i = 1; $i <= $count; $i++) { |
|
234 | + $names[] = $smcFunc['htmlspecialchars']($smcFunc['htmltrim'](implode('', array_slice($match, 0, $i)))); |
|
235 | + } |
|
228 | 236 | } |
229 | 237 | |
230 | 238 | $names = array_unique($names); |
@@ -426,8 +426,8 @@ |
||
426 | 426 | */ |
427 | 427 | function matchIPtoCIDR($ip_address, $cidr_address) |
428 | 428 | { |
429 | - list ($cidr_network, $cidr_subnetmask) = preg_split('/', $cidr_address); |
|
430 | - return (ip2long($ip_address) & (~((1 << (32 - $cidr_subnetmask)) - 1))) == ip2long($cidr_network); |
|
429 | + list ($cidr_network, $cidr_subnetmask) = preg_split('/', $cidr_address); |
|
430 | + return (ip2long($ip_address) & (~((1 << (32 - $cidr_subnetmask)) - 1))) == ip2long($cidr_network); |
|
431 | 431 | } |
432 | 432 | |
433 | 433 | /** |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 4 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Clean the request variables - add html entities to GET and slashes if magic_quotes_gpc is Off. |
@@ -44,22 +45,26 @@ discard block |
||
44 | 45 | unset($GLOBALS['HTTP_POST_FILES'], $GLOBALS['HTTP_POST_FILES']); |
45 | 46 | |
46 | 47 | // These keys shouldn't be set...ever. |
47 | - if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) |
|
48 | - die('Invalid request variable.'); |
|
48 | + if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) { |
|
49 | + die('Invalid request variable.'); |
|
50 | + } |
|
49 | 51 | |
50 | 52 | // Same goes for numeric keys. |
51 | - foreach (array_merge(array_keys($_POST), array_keys($_GET), array_keys($_FILES)) as $key) |
|
52 | - if (is_numeric($key)) |
|
53 | + foreach (array_merge(array_keys($_POST), array_keys($_GET), array_keys($_FILES)) as $key) { |
|
54 | + if (is_numeric($key)) |
|
53 | 55 | die('Numeric request keys are invalid.'); |
56 | + } |
|
54 | 57 | |
55 | 58 | // Numeric keys in cookies are less of a problem. Just unset those. |
56 | - foreach ($_COOKIE as $key => $value) |
|
57 | - if (is_numeric($key)) |
|
59 | + foreach ($_COOKIE as $key => $value) { |
|
60 | + if (is_numeric($key)) |
|
58 | 61 | unset($_COOKIE[$key]); |
62 | + } |
|
59 | 63 | |
60 | 64 | // Get the correct query string. It may be in an environment variable... |
61 | - if (!isset($_SERVER['QUERY_STRING'])) |
|
62 | - $_SERVER['QUERY_STRING'] = getenv('QUERY_STRING'); |
|
65 | + if (!isset($_SERVER['QUERY_STRING'])) { |
|
66 | + $_SERVER['QUERY_STRING'] = getenv('QUERY_STRING'); |
|
67 | + } |
|
63 | 68 | |
64 | 69 | // It seems that sticking a URL after the query string is mighty common, well, it's evil - don't. |
65 | 70 | if (strpos($_SERVER['QUERY_STRING'], 'http') === 0) |
@@ -83,13 +88,14 @@ discard block |
||
83 | 88 | parse_str(preg_replace('/&(\w+)(?=&|$)/', '&$1=', strtr($_SERVER['QUERY_STRING'], array(';?' => '&', ';' => '&', '%00' => '', "\0" => ''))), $_GET); |
84 | 89 | |
85 | 90 | // Magic quotes still applies with parse_str - so clean it up. |
86 | - if (function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc() != 0 && empty($modSettings['integrate_magic_quotes'])) |
|
87 | - $_GET = $removeMagicQuoteFunction($_GET); |
|
88 | - } |
|
89 | - elseif (strpos(ini_get('arg_separator.input'), ';') !== false) |
|
91 | + if (function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc() != 0 && empty($modSettings['integrate_magic_quotes'])) { |
|
92 | + $_GET = $removeMagicQuoteFunction($_GET); |
|
93 | + } |
|
94 | + } elseif (strpos(ini_get('arg_separator.input'), ';') !== false) |
|
90 | 95 | { |
91 | - if (function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc() != 0 && empty($modSettings['integrate_magic_quotes'])) |
|
92 | - $_GET = $removeMagicQuoteFunction($_GET); |
|
96 | + if (function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc() != 0 && empty($modSettings['integrate_magic_quotes'])) { |
|
97 | + $_GET = $removeMagicQuoteFunction($_GET); |
|
98 | + } |
|
93 | 99 | |
94 | 100 | // Search engines will send action=profile%3Bu=1, which confuses PHP. |
95 | 101 | foreach ($_GET as $k => $v) |
@@ -102,8 +108,9 @@ discard block |
||
102 | 108 | for ($i = 1, $n = count($temp); $i < $n; $i++) |
103 | 109 | { |
104 | 110 | @list ($key, $val) = @explode('=', $temp[$i], 2); |
105 | - if (!isset($_GET[$key])) |
|
106 | - $_GET[$key] = $val; |
|
111 | + if (!isset($_GET[$key])) { |
|
112 | + $_GET[$key] = $val; |
|
113 | + } |
|
107 | 114 | } |
108 | 115 | } |
109 | 116 | |
@@ -120,18 +127,20 @@ discard block |
||
120 | 127 | if (!empty($_SERVER['REQUEST_URI'])) |
121 | 128 | { |
122 | 129 | // Remove the .html, assuming there is one. |
123 | - if (substr($_SERVER['REQUEST_URI'], strrpos($_SERVER['REQUEST_URI'], '.'), 4) == '.htm') |
|
124 | - $request = substr($_SERVER['REQUEST_URI'], 0, strrpos($_SERVER['REQUEST_URI'], '.')); |
|
125 | - else |
|
126 | - $request = $_SERVER['REQUEST_URI']; |
|
130 | + if (substr($_SERVER['REQUEST_URI'], strrpos($_SERVER['REQUEST_URI'], '.'), 4) == '.htm') { |
|
131 | + $request = substr($_SERVER['REQUEST_URI'], 0, strrpos($_SERVER['REQUEST_URI'], '.')); |
|
132 | + } else { |
|
133 | + $request = $_SERVER['REQUEST_URI']; |
|
134 | + } |
|
127 | 135 | |
128 | 136 | // @todo smflib. |
129 | 137 | // Replace 'index.php/a,b,c/d/e,f' with 'a=b,c&d=&e=f' and parse it into $_GET. |
130 | 138 | if (strpos($request, basename($scripturl) . '/') !== false) |
131 | 139 | { |
132 | 140 | parse_str(substr(preg_replace('/&(\w+)(?=&|$)/', '&$1=', strtr(preg_replace('~/([^,/]+),~', '/$1=', substr($request, strpos($request, basename($scripturl)) + strlen(basename($scripturl)))), '/', '&')), 1), $temp); |
133 | - if (function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc() != 0 && empty($modSettings['integrate_magic_quotes'])) |
|
134 | - $temp = $removeMagicQuoteFunction($temp); |
|
141 | + if (function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc() != 0 && empty($modSettings['integrate_magic_quotes'])) { |
|
142 | + $temp = $removeMagicQuoteFunction($temp); |
|
143 | + } |
|
135 | 144 | $_GET += $temp; |
136 | 145 | } |
137 | 146 | } |
@@ -142,9 +151,10 @@ discard block |
||
142 | 151 | $_ENV = $removeMagicQuoteFunction($_ENV); |
143 | 152 | $_POST = $removeMagicQuoteFunction($_POST); |
144 | 153 | $_COOKIE = $removeMagicQuoteFunction($_COOKIE); |
145 | - foreach ($_FILES as $k => $dummy) |
|
146 | - if (isset($_FILES[$k]['name'])) |
|
154 | + foreach ($_FILES as $k => $dummy) { |
|
155 | + if (isset($_FILES[$k]['name'])) |
|
147 | 156 | $_FILES[$k]['name'] = $removeMagicQuoteFunction($_FILES[$k]['name']); |
157 | + } |
|
148 | 158 | } |
149 | 159 | |
150 | 160 | // Add entities to GET. This is kinda like the slashes on everything else. |
@@ -160,11 +170,13 @@ discard block |
||
160 | 170 | $_REQUEST['board'] = (string) $_REQUEST['board']; |
161 | 171 | |
162 | 172 | // If there's a slash in it, we've got a start value! (old, compatible links.) |
163 | - if (strpos($_REQUEST['board'], '/') !== false) |
|
164 | - list ($_REQUEST['board'], $_REQUEST['start']) = explode('/', $_REQUEST['board']); |
|
173 | + if (strpos($_REQUEST['board'], '/') !== false) { |
|
174 | + list ($_REQUEST['board'], $_REQUEST['start']) = explode('/', $_REQUEST['board']); |
|
175 | + } |
|
165 | 176 | // Same idea, but dots. This is the currently used format - ?board=1.0... |
166 | - elseif (strpos($_REQUEST['board'], '.') !== false) |
|
167 | - list ($_REQUEST['board'], $_REQUEST['start']) = explode('.', $_REQUEST['board']); |
|
177 | + elseif (strpos($_REQUEST['board'], '.') !== false) { |
|
178 | + list ($_REQUEST['board'], $_REQUEST['start']) = explode('.', $_REQUEST['board']); |
|
179 | + } |
|
168 | 180 | // Now make absolutely sure it's a number. |
169 | 181 | $board = (int) $_REQUEST['board']; |
170 | 182 | $_REQUEST['start'] = isset($_REQUEST['start']) ? (int) $_REQUEST['start'] : 0; |
@@ -173,12 +185,14 @@ discard block |
||
173 | 185 | $_GET['board'] = $board; |
174 | 186 | } |
175 | 187 | // Well, $board is going to be a number no matter what. |
176 | - else |
|
177 | - $board = 0; |
|
188 | + else { |
|
189 | + $board = 0; |
|
190 | + } |
|
178 | 191 | |
179 | 192 | // If there's a threadid, it's probably an old YaBB SE link. Flow with it. |
180 | - if (isset($_REQUEST['threadid']) && !isset($_REQUEST['topic'])) |
|
181 | - $_REQUEST['topic'] = $_REQUEST['threadid']; |
|
193 | + if (isset($_REQUEST['threadid']) && !isset($_REQUEST['topic'])) { |
|
194 | + $_REQUEST['topic'] = $_REQUEST['threadid']; |
|
195 | + } |
|
182 | 196 | |
183 | 197 | // We've got topic! |
184 | 198 | if (isset($_REQUEST['topic'])) |
@@ -187,11 +201,13 @@ discard block |
||
187 | 201 | $_REQUEST['topic'] = (string) $_REQUEST['topic']; |
188 | 202 | |
189 | 203 | // Slash means old, beta style, formatting. That's okay though, the link should still work. |
190 | - if (strpos($_REQUEST['topic'], '/') !== false) |
|
191 | - list ($_REQUEST['topic'], $_REQUEST['start']) = explode('/', $_REQUEST['topic']); |
|
204 | + if (strpos($_REQUEST['topic'], '/') !== false) { |
|
205 | + list ($_REQUEST['topic'], $_REQUEST['start']) = explode('/', $_REQUEST['topic']); |
|
206 | + } |
|
192 | 207 | // Dots are useful and fun ;). This is ?topic=1.15. |
193 | - elseif (strpos($_REQUEST['topic'], '.') !== false) |
|
194 | - list ($_REQUEST['topic'], $_REQUEST['start']) = explode('.', $_REQUEST['topic']); |
|
208 | + elseif (strpos($_REQUEST['topic'], '.') !== false) { |
|
209 | + list ($_REQUEST['topic'], $_REQUEST['start']) = explode('.', $_REQUEST['topic']); |
|
210 | + } |
|
195 | 211 | |
196 | 212 | // Topic should always be an integer |
197 | 213 | $topic = $_GET['topic'] = $_REQUEST['topic'] = (int) $_REQUEST['topic']; |
@@ -220,21 +236,25 @@ discard block |
||
220 | 236 | $_REQUEST['start'] = $timestamp === 0 ? 0 : 'from' . $timestamp; |
221 | 237 | } |
222 | 238 | // ... or something invalid, in which case we reset it to 0. |
223 | - else |
|
224 | - $_REQUEST['start'] = 0; |
|
239 | + else { |
|
240 | + $_REQUEST['start'] = 0; |
|
241 | + } |
|
242 | + } else { |
|
243 | + $topic = 0; |
|
225 | 244 | } |
226 | - else |
|
227 | - $topic = 0; |
|
228 | 245 | |
229 | 246 | // There should be a $_REQUEST['start'], some at least. If you need to default to other than 0, use $_GET['start']. |
230 | - if (empty($_REQUEST['start']) || $_REQUEST['start'] < 0 || (int) $_REQUEST['start'] > 2147473647) |
|
231 | - $_REQUEST['start'] = 0; |
|
247 | + if (empty($_REQUEST['start']) || $_REQUEST['start'] < 0 || (int) $_REQUEST['start'] > 2147473647) { |
|
248 | + $_REQUEST['start'] = 0; |
|
249 | + } |
|
232 | 250 | |
233 | 251 | // The action needs to be a string and not an array or anything else |
234 | - if (isset($_REQUEST['action'])) |
|
235 | - $_REQUEST['action'] = (string) $_REQUEST['action']; |
|
236 | - if (isset($_GET['action'])) |
|
237 | - $_GET['action'] = (string) $_GET['action']; |
|
252 | + if (isset($_REQUEST['action'])) { |
|
253 | + $_REQUEST['action'] = (string) $_REQUEST['action']; |
|
254 | + } |
|
255 | + if (isset($_GET['action'])) { |
|
256 | + $_GET['action'] = (string) $_GET['action']; |
|
257 | + } |
|
238 | 258 | |
239 | 259 | // Some mail providers like to encode semicolons in activation URLs... |
240 | 260 | if (!empty($_REQUEST['action']) && substr($_SERVER['QUERY_STRING'], 0, 18) == 'action=activate%3b') |
@@ -260,29 +280,33 @@ discard block |
||
260 | 280 | $_SERVER['BAN_CHECK_IP'] = $_SERVER['REMOTE_ADDR']; |
261 | 281 | |
262 | 282 | // If we haven't specified how to handle Reverse Proxy IP headers, lets do what we always used to do. |
263 | - if (!isset($modSettings['proxy_ip_header'])) |
|
264 | - $modSettings['proxy_ip_header'] = 'autodetect'; |
|
283 | + if (!isset($modSettings['proxy_ip_header'])) { |
|
284 | + $modSettings['proxy_ip_header'] = 'autodetect'; |
|
285 | + } |
|
265 | 286 | |
266 | 287 | // Which headers are we going to check for Reverse Proxy IP headers? |
267 | - if ($modSettings['proxy_ip_header'] == 'disabled') |
|
268 | - $reverseIPheaders = array(); |
|
269 | - elseif ($modSettings['proxy_ip_header'] == 'autodetect') |
|
270 | - $reverseIPheaders = array('HTTP_X_FORWARDED_FOR', 'HTTP_CLIENT_IP'); |
|
271 | - else |
|
272 | - $reverseIPheaders = array($modSettings['proxy_ip_header']); |
|
288 | + if ($modSettings['proxy_ip_header'] == 'disabled') { |
|
289 | + $reverseIPheaders = array(); |
|
290 | + } elseif ($modSettings['proxy_ip_header'] == 'autodetect') { |
|
291 | + $reverseIPheaders = array('HTTP_X_FORWARDED_FOR', 'HTTP_CLIENT_IP'); |
|
292 | + } else { |
|
293 | + $reverseIPheaders = array($modSettings['proxy_ip_header']); |
|
294 | + } |
|
273 | 295 | |
274 | 296 | // Find the user's IP address. (but don't let it give you 'unknown'!) |
275 | 297 | foreach ($reverseIPheaders as $proxyIPheader) |
276 | 298 | { |
277 | 299 | // Ignore if this is not set. |
278 | - if (!isset($_SERVER[$proxyIPheader])) |
|
279 | - continue; |
|
300 | + if (!isset($_SERVER[$proxyIPheader])) { |
|
301 | + continue; |
|
302 | + } |
|
280 | 303 | |
281 | 304 | if (!empty($modSettings['proxy_ip_servers'])) |
282 | 305 | { |
283 | - foreach (explode(',', $modSettings['proxy_ip_servers']) as $proxy) |
|
284 | - if ($proxy == $_SERVER['REMOTE_ADDR'] || matchIPtoCIDR($_SERVER['REMOTE_ADDR'], $proxy)) |
|
306 | + foreach (explode(',', $modSettings['proxy_ip_servers']) as $proxy) { |
|
307 | + if ($proxy == $_SERVER['REMOTE_ADDR'] || matchIPtoCIDR($_SERVER['REMOTE_ADDR'], $proxy)) |
|
285 | 308 | continue; |
309 | + } |
|
286 | 310 | } |
287 | 311 | |
288 | 312 | // If there are commas, get the last one.. probably. |
@@ -302,8 +326,9 @@ discard block |
||
302 | 326 | |
303 | 327 | // Just incase we have a legacy IPv4 address. |
304 | 328 | // @ TODO: Convert to IPv6. |
305 | - if (preg_match('~^((([1]?\d)?\d|2[0-4]\d|25[0-5])\.){3}(([1]?\d)?\d|2[0-4]\d|25[0-5])$~', $_SERVER[$proxyIPheader]) === 0) |
|
306 | - continue; |
|
329 | + if (preg_match('~^((([1]?\d)?\d|2[0-4]\d|25[0-5])\.){3}(([1]?\d)?\d|2[0-4]\d|25[0-5])$~', $_SERVER[$proxyIPheader]) === 0) { |
|
330 | + continue; |
|
331 | + } |
|
307 | 332 | } |
308 | 333 | |
309 | 334 | continue; |
@@ -315,36 +340,40 @@ discard block |
||
315 | 340 | } |
316 | 341 | } |
317 | 342 | // Otherwise just use the only one. |
318 | - elseif (preg_match('~^((0|10|172\.(1[6-9]|2[0-9]|3[01])|192\.168|255|127)\.|unknown|::1|fe80::|fc00::)~', $_SERVER[$proxyIPheader]) == 0 || preg_match('~^((0|10|172\.(1[6-9]|2[0-9]|3[01])|192\.168|255|127)\.|unknown|::1|fe80::|fc00::)~', $_SERVER['REMOTE_ADDR']) != 0) |
|
319 | - $_SERVER['BAN_CHECK_IP'] = $_SERVER[$proxyIPheader]; |
|
320 | - elseif (!isValidIPv6($_SERVER[$proxyIPheader]) || preg_match('~::ffff:\d+\.\d+\.\d+\.\d+~', $_SERVER[$proxyIPheader]) !== 0) |
|
343 | + elseif (preg_match('~^((0|10|172\.(1[6-9]|2[0-9]|3[01])|192\.168|255|127)\.|unknown|::1|fe80::|fc00::)~', $_SERVER[$proxyIPheader]) == 0 || preg_match('~^((0|10|172\.(1[6-9]|2[0-9]|3[01])|192\.168|255|127)\.|unknown|::1|fe80::|fc00::)~', $_SERVER['REMOTE_ADDR']) != 0) { |
|
344 | + $_SERVER['BAN_CHECK_IP'] = $_SERVER[$proxyIPheader]; |
|
345 | + } elseif (!isValidIPv6($_SERVER[$proxyIPheader]) || preg_match('~::ffff:\d+\.\d+\.\d+\.\d+~', $_SERVER[$proxyIPheader]) !== 0) |
|
321 | 346 | { |
322 | 347 | $_SERVER[$proxyIPheader] = preg_replace('~^::ffff:(\d+\.\d+\.\d+\.\d+)~', '\1', $_SERVER[$proxyIPheader]); |
323 | 348 | |
324 | 349 | // Just incase we have a legacy IPv4 address. |
325 | 350 | // @ TODO: Convert to IPv6. |
326 | - if (preg_match('~^((([1]?\d)?\d|2[0-4]\d|25[0-5])\.){3}(([1]?\d)?\d|2[0-4]\d|25[0-5])$~', $_SERVER[$proxyIPheader]) === 0) |
|
327 | - continue; |
|
351 | + if (preg_match('~^((([1]?\d)?\d|2[0-4]\d|25[0-5])\.){3}(([1]?\d)?\d|2[0-4]\d|25[0-5])$~', $_SERVER[$proxyIPheader]) === 0) { |
|
352 | + continue; |
|
353 | + } |
|
328 | 354 | } |
329 | 355 | } |
330 | 356 | |
331 | 357 | // Make sure we know the URL of the current request. |
332 | - if (empty($_SERVER['REQUEST_URI'])) |
|
333 | - $_SERVER['REQUEST_URL'] = $scripturl . (!empty($_SERVER['QUERY_STRING']) ? '?' . $_SERVER['QUERY_STRING'] : ''); |
|
334 | - elseif (preg_match('~^([^/]+//[^/]+)~', $scripturl, $match) == 1) |
|
335 | - $_SERVER['REQUEST_URL'] = $match[1] . $_SERVER['REQUEST_URI']; |
|
336 | - else |
|
337 | - $_SERVER['REQUEST_URL'] = $_SERVER['REQUEST_URI']; |
|
358 | + if (empty($_SERVER['REQUEST_URI'])) { |
|
359 | + $_SERVER['REQUEST_URL'] = $scripturl . (!empty($_SERVER['QUERY_STRING']) ? '?' . $_SERVER['QUERY_STRING'] : ''); |
|
360 | + } elseif (preg_match('~^([^/]+//[^/]+)~', $scripturl, $match) == 1) { |
|
361 | + $_SERVER['REQUEST_URL'] = $match[1] . $_SERVER['REQUEST_URI']; |
|
362 | + } else { |
|
363 | + $_SERVER['REQUEST_URL'] = $_SERVER['REQUEST_URI']; |
|
364 | + } |
|
338 | 365 | |
339 | 366 | // And make sure HTTP_USER_AGENT is set. |
340 | 367 | $_SERVER['HTTP_USER_AGENT'] = isset($_SERVER['HTTP_USER_AGENT']) ? (isset($smcFunc['htmlspecialchars']) ? $smcFunc['htmlspecialchars']($smcFunc['db_unescape_string']($_SERVER['HTTP_USER_AGENT']), ENT_QUOTES) : htmlspecialchars($smcFunc['db_unescape_string']($_SERVER['HTTP_USER_AGENT']), ENT_QUOTES)) : ''; |
341 | 368 | |
342 | 369 | // Some final checking. |
343 | - if (!isValidIP($_SERVER['BAN_CHECK_IP'])) |
|
344 | - $_SERVER['BAN_CHECK_IP'] = ''; |
|
345 | - if ($_SERVER['REMOTE_ADDR'] == 'unknown') |
|
346 | - $_SERVER['REMOTE_ADDR'] = ''; |
|
347 | -} |
|
370 | + if (!isValidIP($_SERVER['BAN_CHECK_IP'])) { |
|
371 | + $_SERVER['BAN_CHECK_IP'] = ''; |
|
372 | + } |
|
373 | + if ($_SERVER['REMOTE_ADDR'] == 'unknown') { |
|
374 | + $_SERVER['REMOTE_ADDR'] = ''; |
|
375 | + } |
|
376 | + } |
|
348 | 377 | |
349 | 378 | /** |
350 | 379 | * Validates a IPv6 address. returns true if it is ipv6. |
@@ -355,8 +384,9 @@ discard block |
||
355 | 384 | function isValidIPv6($ip) |
356 | 385 | { |
357 | 386 | //looking for : |
358 | - if (strpos($ip, ':') === false) |
|
359 | - return false; |
|
387 | + if (strpos($ip, ':') === false) { |
|
388 | + return false; |
|
389 | + } |
|
360 | 390 | |
361 | 391 | //check valid address |
362 | 392 | return inet_pton($ip); |
@@ -373,15 +403,17 @@ discard block |
||
373 | 403 | static $expanded = array(); |
374 | 404 | |
375 | 405 | // Check if we have done this already. |
376 | - if (isset($expanded[$ip])) |
|
377 | - return $expanded[$ip]; |
|
406 | + if (isset($expanded[$ip])) { |
|
407 | + return $expanded[$ip]; |
|
408 | + } |
|
378 | 409 | |
379 | 410 | // Expand the IP out. |
380 | 411 | $expanded_ip = explode(':', expandIPv6($ip)); |
381 | 412 | |
382 | 413 | $new_ip = array(); |
383 | - foreach ($expanded_ip as $int) |
|
384 | - $new_ip[] = hexdec($int); |
|
414 | + foreach ($expanded_ip as $int) { |
|
415 | + $new_ip[] = hexdec($int); |
|
416 | + } |
|
385 | 417 | |
386 | 418 | // Save this incase of repeated use. |
387 | 419 | $expanded[$ip] = $new_ip; |
@@ -401,8 +433,9 @@ discard block |
||
401 | 433 | static $converted = array(); |
402 | 434 | |
403 | 435 | // Check if we have done this already. |
404 | - if (isset($converted[$addr])) |
|
405 | - return $converted[$addr]; |
|
436 | + if (isset($converted[$addr])) { |
|
437 | + return $converted[$addr]; |
|
438 | + } |
|
406 | 439 | |
407 | 440 | // Check if there are segments missing, insert if necessary. |
408 | 441 | if (strpos($addr, '::') !== false) |
@@ -412,18 +445,20 @@ discard block |
||
412 | 445 | $part[1] = explode(':', $part[1]); |
413 | 446 | $missing = array(); |
414 | 447 | |
415 | - for ($i = 0; $i < (8 - (count($part[0]) + count($part[1]))); $i++) |
|
416 | - array_push($missing, '0000'); |
|
448 | + for ($i = 0; $i < (8 - (count($part[0]) + count($part[1]))); $i++) { |
|
449 | + array_push($missing, '0000'); |
|
450 | + } |
|
417 | 451 | |
418 | 452 | $part = array_merge($part[0], $missing, $part[1]); |
453 | + } else { |
|
454 | + $part = explode(':', $addr); |
|
419 | 455 | } |
420 | - else |
|
421 | - $part = explode(':', $addr); |
|
422 | 456 | |
423 | 457 | // Pad each segment until it has 4 digits. |
424 | - foreach ($part as &$p) |
|
425 | - while (strlen($p) < 4) |
|
458 | + foreach ($part as &$p) { |
|
459 | + while (strlen($p) < 4) |
|
426 | 460 | $p = '0' . $p; |
461 | + } |
|
427 | 462 | |
428 | 463 | unset($p); |
429 | 464 | |
@@ -434,11 +469,12 @@ discard block |
||
434 | 469 | $converted[$addr] = $result; |
435 | 470 | |
436 | 471 | // Quick check to make sure the length is as expected. |
437 | - if (!$strict_check || strlen($result) == 39) |
|
438 | - return $result; |
|
439 | - else |
|
440 | - return false; |
|
441 | -} |
|
472 | + if (!$strict_check || strlen($result) == 39) { |
|
473 | + return $result; |
|
474 | + } else { |
|
475 | + return false; |
|
476 | + } |
|
477 | + } |
|
442 | 478 | |
443 | 479 | |
444 | 480 | /** |
@@ -469,15 +505,17 @@ discard block |
||
469 | 505 | { |
470 | 506 | global $smcFunc; |
471 | 507 | |
472 | - if (!is_array($var)) |
|
473 | - return $smcFunc['db_escape_string']($var); |
|
508 | + if (!is_array($var)) { |
|
509 | + return $smcFunc['db_escape_string']($var); |
|
510 | + } |
|
474 | 511 | |
475 | 512 | // Reindex the array with slashes. |
476 | 513 | $new_var = array(); |
477 | 514 | |
478 | 515 | // Add slashes to every element, even the indexes! |
479 | - foreach ($var as $k => $v) |
|
480 | - $new_var[$smcFunc['db_escape_string']($k)] = escapestring__recursive($v); |
|
516 | + foreach ($var as $k => $v) { |
|
517 | + $new_var[$smcFunc['db_escape_string']($k)] = escapestring__recursive($v); |
|
518 | + } |
|
481 | 519 | |
482 | 520 | return $new_var; |
483 | 521 | } |
@@ -497,12 +535,14 @@ discard block |
||
497 | 535 | { |
498 | 536 | global $smcFunc; |
499 | 537 | |
500 | - if (!is_array($var)) |
|
501 | - return isset($smcFunc['htmlspecialchars']) ? $smcFunc['htmlspecialchars']($var, ENT_QUOTES) : htmlspecialchars($var, ENT_QUOTES); |
|
538 | + if (!is_array($var)) { |
|
539 | + return isset($smcFunc['htmlspecialchars']) ? $smcFunc['htmlspecialchars']($var, ENT_QUOTES) : htmlspecialchars($var, ENT_QUOTES); |
|
540 | + } |
|
502 | 541 | |
503 | 542 | // Add the htmlspecialchars to every element. |
504 | - foreach ($var as $k => $v) |
|
505 | - $var[$k] = $level > 25 ? null : htmlspecialchars__recursive($v, $level + 1); |
|
543 | + foreach ($var as $k => $v) { |
|
544 | + $var[$k] = $level > 25 ? null : htmlspecialchars__recursive($v, $level + 1); |
|
545 | + } |
|
506 | 546 | |
507 | 547 | return $var; |
508 | 548 | } |
@@ -520,15 +560,17 @@ discard block |
||
520 | 560 | */ |
521 | 561 | function urldecode__recursive($var, $level = 0) |
522 | 562 | { |
523 | - if (!is_array($var)) |
|
524 | - return urldecode($var); |
|
563 | + if (!is_array($var)) { |
|
564 | + return urldecode($var); |
|
565 | + } |
|
525 | 566 | |
526 | 567 | // Reindex the array... |
527 | 568 | $new_var = array(); |
528 | 569 | |
529 | 570 | // Add the htmlspecialchars to every element. |
530 | - foreach ($var as $k => $v) |
|
531 | - $new_var[urldecode($k)] = $level > 25 ? null : urldecode__recursive($v, $level + 1); |
|
571 | + foreach ($var as $k => $v) { |
|
572 | + $new_var[urldecode($k)] = $level > 25 ? null : urldecode__recursive($v, $level + 1); |
|
573 | + } |
|
532 | 574 | |
533 | 575 | return $new_var; |
534 | 576 | } |
@@ -546,15 +588,17 @@ discard block |
||
546 | 588 | { |
547 | 589 | global $smcFunc; |
548 | 590 | |
549 | - if (!is_array($var)) |
|
550 | - return $smcFunc['db_unescape_string']($var); |
|
591 | + if (!is_array($var)) { |
|
592 | + return $smcFunc['db_unescape_string']($var); |
|
593 | + } |
|
551 | 594 | |
552 | 595 | // Reindex the array without slashes, this time. |
553 | 596 | $new_var = array(); |
554 | 597 | |
555 | 598 | // Strip the slashes from every element. |
556 | - foreach ($var as $k => $v) |
|
557 | - $new_var[$smcFunc['db_unescape_string']($k)] = unescapestring__recursive($v); |
|
599 | + foreach ($var as $k => $v) { |
|
600 | + $new_var[$smcFunc['db_unescape_string']($k)] = unescapestring__recursive($v); |
|
601 | + } |
|
558 | 602 | |
559 | 603 | return $new_var; |
560 | 604 | } |
@@ -572,15 +616,17 @@ discard block |
||
572 | 616 | */ |
573 | 617 | function stripslashes__recursive($var, $level = 0) |
574 | 618 | { |
575 | - if (!is_array($var)) |
|
576 | - return stripslashes($var); |
|
619 | + if (!is_array($var)) { |
|
620 | + return stripslashes($var); |
|
621 | + } |
|
577 | 622 | |
578 | 623 | // Reindex the array without slashes, this time. |
579 | 624 | $new_var = array(); |
580 | 625 | |
581 | 626 | // Strip the slashes from every element. |
582 | - foreach ($var as $k => $v) |
|
583 | - $new_var[stripslashes($k)] = $level > 25 ? null : stripslashes__recursive($v, $level + 1); |
|
627 | + foreach ($var as $k => $v) { |
|
628 | + $new_var[stripslashes($k)] = $level > 25 ? null : stripslashes__recursive($v, $level + 1); |
|
629 | + } |
|
584 | 630 | |
585 | 631 | return $new_var; |
586 | 632 | } |
@@ -601,12 +647,14 @@ discard block |
||
601 | 647 | global $smcFunc; |
602 | 648 | |
603 | 649 | // Remove spaces (32), tabs (9), returns (13, 10, and 11), nulls (0), and hard spaces. (160) |
604 | - if (!is_array($var)) |
|
605 | - return isset($smcFunc) ? $smcFunc['htmltrim']($var) : trim($var, ' ' . "\t\n\r\x0B" . '\0' . "\xA0"); |
|
650 | + if (!is_array($var)) { |
|
651 | + return isset($smcFunc) ? $smcFunc['htmltrim']($var) : trim($var, ' ' . "\t\n\r\x0B" . '\0' . "\xA0"); |
|
652 | + } |
|
606 | 653 | |
607 | 654 | // Go through all the elements and remove the whitespace. |
608 | - foreach ($var as $k => $v) |
|
609 | - $var[$k] = $level > 25 ? null : htmltrim__recursive($v, $level + 1); |
|
655 | + foreach ($var as $k => $v) { |
|
656 | + $var[$k] = $level > 25 ? null : htmltrim__recursive($v, $level + 1); |
|
657 | + } |
|
610 | 658 | |
611 | 659 | return $var; |
612 | 660 | } |
@@ -671,30 +719,37 @@ discard block |
||
671 | 719 | global $scripturl, $modSettings, $context; |
672 | 720 | |
673 | 721 | // If $scripturl is set to nothing, or the SID is not defined (SSI?) just quit. |
674 | - if ($scripturl == '' || !defined('SID')) |
|
675 | - return $buffer; |
|
722 | + if ($scripturl == '' || !defined('SID')) { |
|
723 | + return $buffer; |
|
724 | + } |
|
676 | 725 | |
677 | 726 | // Do nothing if the session is cookied, or they are a crawler - guests are caught by redirectexit(). This doesn't work below PHP 4.3.0, because it makes the output buffer bigger. |
678 | 727 | // @todo smflib |
679 | - if (empty($_COOKIE) && SID != '' && !isBrowser('possibly_robot')) |
|
680 | - $buffer = preg_replace('/(?<!<link rel="canonical" href=)"' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', '"' . $scripturl . '?' . SID . '&', $buffer); |
|
728 | + if (empty($_COOKIE) && SID != '' && !isBrowser('possibly_robot')) { |
|
729 | + $buffer = preg_replace('/(?<!<link rel="canonical" href=)"' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', '"' . $scripturl . '?' . SID . '&', $buffer); |
|
730 | + } |
|
681 | 731 | // Debugging templates, are we? |
682 | - elseif (isset($_GET['debug'])) |
|
683 | - $buffer = preg_replace('/(?<!<link rel="canonical" href=)"' . preg_quote($scripturl, '/') . '\\??/', '"' . $scripturl . '?debug;', $buffer); |
|
732 | + elseif (isset($_GET['debug'])) { |
|
733 | + $buffer = preg_replace('/(?<!<link rel="canonical" href=)"' . preg_quote($scripturl, '/') . '\\??/', '"' . $scripturl . '?debug;', $buffer); |
|
734 | + } |
|
684 | 735 | |
685 | 736 | // This should work even in 4.2.x, just not CGI without cgi.fix_pathinfo. |
686 | 737 | if (!empty($modSettings['queryless_urls']) && (!$context['server']['is_cgi'] || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && ($context['server']['is_apache'] || $context['server']['is_lighttpd'] || $context['server']['is_litespeed'])) |
687 | 738 | { |
688 | 739 | // Let's do something special for session ids! |
689 | - if (defined('SID') && SID != '') |
|
690 | - $buffer = preg_replace_callback('~"' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#"]+?)(#[^"]*?)?"~', function($m) |
|
740 | + if (defined('SID') && SID != '') { |
|
741 | + $buffer = preg_replace_callback('~"' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#"]+?)(#[^"]*?)?"~', function($m) |
|
691 | 742 | { |
692 | - global $scripturl; return '"' . $scripturl . "/" . strtr("$m[1]", '&;=', '//,') . ".html?" . SID . (isset($m[2]) ? $m[2] : "") . '"'; |
|
743 | + global $scripturl; |
|
744 | + } |
|
745 | + return '"' . $scripturl . "/" . strtr("$m[1]", '&;=', '//,') . ".html?" . SID . (isset($m[2]) ? $m[2] : "") . '"'; |
|
693 | 746 | }, $buffer); |
694 | - else |
|
695 | - $buffer = preg_replace_callback('~"' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?"~', function($m) |
|
747 | + else { |
|
748 | + $buffer = preg_replace_callback('~"' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?"~', function($m) |
|
696 | 749 | { |
697 | - global $scripturl; return '"' . $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? $m[2] : "") . '"'; |
|
750 | + global $scripturl; |
|
751 | + } |
|
752 | + return '"' . $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? $m[2] : "") . '"'; |
|
698 | 753 | }, $buffer); |
699 | 754 | } |
700 | 755 |