SimpleMachines /
SMF2.1
@@ -20,8 +20,9 @@ discard block |
||
| 20 | 20 | // ><html dir="ltr"><head><title>Error!</title></head><body>Sorry, this installer requires PHP!<div style="display: none;"> |
| 21 | 21 | |
| 22 | 22 | // Let's pull in useful classes |
| 23 | -if (!defined('SMF')) |
|
| 23 | +if (!defined('SMF')) { |
|
| 24 | 24 | define('SMF', 1); |
| 25 | +} |
|
| 25 | 26 | |
| 26 | 27 | require_once('Sources/Class-Package.php'); |
| 27 | 28 | |
@@ -63,10 +64,11 @@ discard block |
||
| 63 | 64 | |
| 64 | 65 | list ($charcode) = pg_fetch_row($request); |
| 65 | 66 | |
| 66 | - if ($charcode == 'UTF8') |
|
| 67 | - return true; |
|
| 68 | - else |
|
| 69 | - return false; |
|
| 67 | + if ($charcode == 'UTF8') { |
|
| 68 | + return true; |
|
| 69 | + } else { |
|
| 70 | + return false; |
|
| 71 | + } |
|
| 70 | 72 | }, |
| 71 | 73 | 'utf8_version' => '8.0', |
| 72 | 74 | 'utf8_version_check' => '$request = pg_query(\'SELECT version()\'); list ($version) = pg_fetch_row($request); list($pgl, $version) = explode(" ", $version); return $version;', |
@@ -74,12 +76,14 @@ discard block |
||
| 74 | 76 | $value = preg_replace('~[^A-Za-z0-9_\$]~', '', $value); |
| 75 | 77 | |
| 76 | 78 | // Is it reserved? |
| 77 | - if ($value == 'pg_') |
|
| 78 | - return $txt['error_db_prefix_reserved']; |
|
| 79 | + if ($value == 'pg_') { |
|
| 80 | + return $txt['error_db_prefix_reserved']; |
|
| 81 | + } |
|
| 79 | 82 | |
| 80 | 83 | // Is the prefix numeric? |
| 81 | - if (preg_match('~^\d~', $value)) |
|
| 82 | - return $txt['error_db_prefix_numeric']; |
|
| 84 | + if (preg_match('~^\d~', $value)) { |
|
| 85 | + return $txt['error_db_prefix_numeric']; |
|
| 86 | + } |
|
| 83 | 87 | |
| 84 | 88 | return true; |
| 85 | 89 | }, |
@@ -124,10 +128,11 @@ discard block |
||
| 124 | 128 | $incontext['skip'] = false; |
| 125 | 129 | |
| 126 | 130 | // Call the step and if it returns false that means pause! |
| 127 | - if (function_exists($step[2]) && $step[2]() === false) |
|
| 128 | - break; |
|
| 129 | - elseif (function_exists($step[2])) |
|
| 130 | - $incontext['current_step']++; |
|
| 131 | + if (function_exists($step[2]) && $step[2]() === false) { |
|
| 132 | + break; |
|
| 133 | + } elseif (function_exists($step[2])) { |
|
| 134 | + $incontext['current_step']++; |
|
| 135 | + } |
|
| 131 | 136 | |
| 132 | 137 | // No warnings pass on. |
| 133 | 138 | $incontext['warning'] = ''; |
@@ -143,12 +148,14 @@ discard block |
||
| 143 | 148 | global $databases, $incontext; |
| 144 | 149 | |
| 145 | 150 | // Just so people using older versions of PHP aren't left in the cold. |
| 146 | - if (!isset($_SERVER['PHP_SELF'])) |
|
| 147 | - $_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php'; |
|
| 151 | + if (!isset($_SERVER['PHP_SELF'])) { |
|
| 152 | + $_SERVER['PHP_SELF'] = isset($GLOBALS['HTTP_SERVER_VARS']['PHP_SELF']) ? $GLOBALS['HTTP_SERVER_VARS']['PHP_SELF'] : 'install.php'; |
|
| 153 | + } |
|
| 148 | 154 | |
| 149 | 155 | // Turn off magic quotes runtime and enable error reporting. |
| 150 | - if (function_exists('set_magic_quotes_runtime')) |
|
| 151 | - @set_magic_quotes_runtime(0); |
|
| 156 | + if (function_exists('set_magic_quotes_runtime')) { |
|
| 157 | + @set_magic_quotes_runtime(0); |
|
| 158 | + } |
|
| 152 | 159 | error_reporting(E_ALL); |
| 153 | 160 | |
| 154 | 161 | // Fun. Low PHP version... |
@@ -162,21 +169,23 @@ discard block |
||
| 162 | 169 | { |
| 163 | 170 | ob_start(); |
| 164 | 171 | |
| 165 | - if (ini_get('session.save_handler') == 'user') |
|
| 166 | - @ini_set('session.save_handler', 'files'); |
|
| 167 | - if (function_exists('session_start')) |
|
| 168 | - @session_start(); |
|
| 169 | - } |
|
| 170 | - else |
|
| 172 | + if (ini_get('session.save_handler') == 'user') { |
|
| 173 | + @ini_set('session.save_handler', 'files'); |
|
| 174 | + } |
|
| 175 | + if (function_exists('session_start')) { |
|
| 176 | + @session_start(); |
|
| 177 | + } |
|
| 178 | + } else |
|
| 171 | 179 | { |
| 172 | 180 | ob_start('ob_gzhandler'); |
| 173 | 181 | |
| 174 | - if (ini_get('session.save_handler') == 'user') |
|
| 175 | - @ini_set('session.save_handler', 'files'); |
|
| 182 | + if (ini_get('session.save_handler') == 'user') { |
|
| 183 | + @ini_set('session.save_handler', 'files'); |
|
| 184 | + } |
|
| 176 | 185 | session_start(); |
| 177 | 186 | |
| 178 | - if (!headers_sent()) |
|
| 179 | - echo '<!DOCTYPE html> |
|
| 187 | + if (!headers_sent()) { |
|
| 188 | + echo '<!DOCTYPE html> |
|
| 180 | 189 | <html> |
| 181 | 190 | <head> |
| 182 | 191 | <title>', htmlspecialchars($_GET['pass_string']), '</title> |
@@ -185,14 +194,16 @@ discard block |
||
| 185 | 194 | <strong>', htmlspecialchars($_GET['pass_string']), '</strong> |
| 186 | 195 | </body> |
| 187 | 196 | </html>'; |
| 197 | + } |
|
| 188 | 198 | exit; |
| 189 | 199 | } |
| 190 | 200 | |
| 191 | 201 | // Add slashes, as long as they aren't already being added. |
| 192 | - if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) |
|
| 193 | - foreach ($_POST as $k => $v) |
|
| 202 | + if (!function_exists('get_magic_quotes_gpc') || @get_magic_quotes_gpc() == 0) { |
|
| 203 | + foreach ($_POST as $k => $v) |
|
| 194 | 204 | if (strpos($k, 'password') === false && strpos($k, 'db_passwd') === false) |
| 195 | 205 | $_POST[$k] = addslashes($v); |
| 206 | + } |
|
| 196 | 207 | |
| 197 | 208 | // This is really quite simple; if ?delete is on the URL, delete the installer... |
| 198 | 209 | if (isset($_GET['delete'])) |
@@ -213,8 +224,7 @@ discard block |
||
| 213 | 224 | $ftp->close(); |
| 214 | 225 | |
| 215 | 226 | unset($_SESSION['installer_temp_ftp']); |
| 216 | - } |
|
| 217 | - else |
|
| 227 | + } else |
|
| 218 | 228 | { |
| 219 | 229 | @unlink(__FILE__); |
| 220 | 230 | |
@@ -235,10 +245,11 @@ discard block |
||
| 235 | 245 | { |
| 236 | 246 | // Get PHP's default timezone, if set |
| 237 | 247 | $ini_tz = ini_get('date.timezone'); |
| 238 | - if (!empty($ini_tz)) |
|
| 239 | - $timezone_id = $ini_tz; |
|
| 240 | - else |
|
| 241 | - $timezone_id = ''; |
|
| 248 | + if (!empty($ini_tz)) { |
|
| 249 | + $timezone_id = $ini_tz; |
|
| 250 | + } else { |
|
| 251 | + $timezone_id = ''; |
|
| 252 | + } |
|
| 242 | 253 | |
| 243 | 254 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
| 244 | 255 | if (!in_array($timezone_id, timezone_identifiers_list())) |
@@ -268,8 +279,9 @@ discard block |
||
| 268 | 279 | $dir = dir(dirname(__FILE__) . '/Themes/default/languages'); |
| 269 | 280 | while ($entry = $dir->read()) |
| 270 | 281 | { |
| 271 | - if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') |
|
| 272 | - $incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12)); |
|
| 282 | + if (substr($entry, 0, 8) == 'Install.' && substr($entry, -4) == '.php') { |
|
| 283 | + $incontext['detected_languages'][$entry] = ucfirst(substr($entry, 8, strlen($entry) - 12)); |
|
| 284 | + } |
|
| 273 | 285 | } |
| 274 | 286 | $dir->close(); |
| 275 | 287 | } |
@@ -304,10 +316,11 @@ discard block |
||
| 304 | 316 | } |
| 305 | 317 | |
| 306 | 318 | // Override the language file? |
| 307 | - if (isset($_GET['lang_file'])) |
|
| 308 | - $_SESSION['installer_temp_lang'] = $_GET['lang_file']; |
|
| 309 | - elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) |
|
| 310 | - $_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file']; |
|
| 319 | + if (isset($_GET['lang_file'])) { |
|
| 320 | + $_SESSION['installer_temp_lang'] = $_GET['lang_file']; |
|
| 321 | + } elseif (isset($GLOBALS['HTTP_GET_VARS']['lang_file'])) { |
|
| 322 | + $_SESSION['installer_temp_lang'] = $GLOBALS['HTTP_GET_VARS']['lang_file']; |
|
| 323 | + } |
|
| 311 | 324 | |
| 312 | 325 | // Make sure it exists, if it doesn't reset it. |
| 313 | 326 | if (!isset($_SESSION['installer_temp_lang']) || preg_match('~[^\\w_\\-.]~', $_SESSION['installer_temp_lang']) === 1 || !file_exists(dirname(__FILE__) . '/Themes/default/languages/' . $_SESSION['installer_temp_lang'])) |
@@ -316,8 +329,9 @@ discard block |
||
| 316 | 329 | list ($_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
| 317 | 330 | |
| 318 | 331 | // If we have english and some other language, use the other language. We Americans hate english :P. |
| 319 | - if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) |
|
| 320 | - list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
|
| 332 | + if ($_SESSION['installer_temp_lang'] == 'Install.english.php' && count($incontext['detected_languages']) > 1) { |
|
| 333 | + list (, $_SESSION['installer_temp_lang']) = array_keys($incontext['detected_languages']); |
|
| 334 | + } |
|
| 321 | 335 | } |
| 322 | 336 | |
| 323 | 337 | // And now include the actual language file itself. |
@@ -330,15 +344,18 @@ discard block |
||
| 330 | 344 | global $db_prefix, $db_connection, $sourcedir; |
| 331 | 345 | global $smcFunc, $modSettings, $db_type, $db_name, $db_user, $db_persist; |
| 332 | 346 | |
| 333 | - if (empty($sourcedir)) |
|
| 334 | - $sourcedir = dirname(__FILE__) . '/Sources'; |
|
| 347 | + if (empty($sourcedir)) { |
|
| 348 | + $sourcedir = dirname(__FILE__) . '/Sources'; |
|
| 349 | + } |
|
| 335 | 350 | |
| 336 | 351 | // Need this to check whether we need the database password. |
| 337 | 352 | require(dirname(__FILE__) . '/Settings.php'); |
| 338 | - if (!defined('SMF')) |
|
| 339 | - define('SMF', 1); |
|
| 340 | - if (empty($smcFunc)) |
|
| 341 | - $smcFunc = array(); |
|
| 353 | + if (!defined('SMF')) { |
|
| 354 | + define('SMF', 1); |
|
| 355 | + } |
|
| 356 | + if (empty($smcFunc)) { |
|
| 357 | + $smcFunc = array(); |
|
| 358 | + } |
|
| 342 | 359 | |
| 343 | 360 | $modSettings['disableQueryCheck'] = true; |
| 344 | 361 | |
@@ -346,8 +363,9 @@ discard block |
||
| 346 | 363 | if (!$db_connection) |
| 347 | 364 | { |
| 348 | 365 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
| 349 | - if (version_compare(PHP_VERSION, '5', '<')) |
|
| 350 | - require_once($sourcedir . '/Subs-Compat.php'); |
|
| 366 | + if (version_compare(PHP_VERSION, '5', '<')) { |
|
| 367 | + require_once($sourcedir . '/Subs-Compat.php'); |
|
| 368 | + } |
|
| 351 | 369 | |
| 352 | 370 | $db_options = array('persist' => $db_persist); |
| 353 | 371 | $port = ''; |
@@ -358,19 +376,20 @@ discard block |
||
| 358 | 376 | if ($db_type == 'mysql') |
| 359 | 377 | { |
| 360 | 378 | $port = ((int) $_POST['db_port'] == ini_get($db_type . 'default_port')) ? '' : (int) $_POST['db_port']; |
| 361 | - } |
|
| 362 | - elseif ($db_type == 'postgresql') |
|
| 379 | + } elseif ($db_type == 'postgresql') |
|
| 363 | 380 | { |
| 364 | 381 | // PostgreSQL doesn't have a default port setting in php.ini, so just check against the default |
| 365 | 382 | $port = ((int) $_POST['db_port'] == 5432) ? '' : (int) $_POST['db_port']; |
| 366 | 383 | } |
| 367 | 384 | } |
| 368 | 385 | |
| 369 | - if (!empty($port)) |
|
| 370 | - $db_options['port'] = $port; |
|
| 386 | + if (!empty($port)) { |
|
| 387 | + $db_options['port'] = $port; |
|
| 388 | + } |
|
| 371 | 389 | |
| 372 | - if (!$db_connection) |
|
| 373 | - $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options); |
|
| 390 | + if (!$db_connection) { |
|
| 391 | + $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, $db_options); |
|
| 392 | + } |
|
| 374 | 393 | } |
| 375 | 394 | } |
| 376 | 395 | |
@@ -398,8 +417,9 @@ discard block |
||
| 398 | 417 | // @todo REMOVE THIS!! |
| 399 | 418 | else |
| 400 | 419 | { |
| 401 | - if (function_exists('doStep' . $_GET['step'])) |
|
| 402 | - call_user_func('doStep' . $_GET['step']); |
|
| 420 | + if (function_exists('doStep' . $_GET['step'])) { |
|
| 421 | + call_user_func('doStep' . $_GET['step']); |
|
| 422 | + } |
|
| 403 | 423 | } |
| 404 | 424 | // Show the footer. |
| 405 | 425 | template_install_below(); |
@@ -417,8 +437,9 @@ discard block |
||
| 417 | 437 | $incontext['sub_template'] = 'welcome_message'; |
| 418 | 438 | |
| 419 | 439 | // Done the submission? |
| 420 | - if (isset($_POST['contbutt'])) |
|
| 421 | - return true; |
|
| 440 | + if (isset($_POST['contbutt'])) { |
|
| 441 | + return true; |
|
| 442 | + } |
|
| 422 | 443 | |
| 423 | 444 | // See if we think they have already installed it? |
| 424 | 445 | if (is_readable(dirname(__FILE__) . '/Settings.php')) |
@@ -426,14 +447,17 @@ discard block |
||
| 426 | 447 | $probably_installed = 0; |
| 427 | 448 | foreach (file(dirname(__FILE__) . '/Settings.php') as $line) |
| 428 | 449 | { |
| 429 | - if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) |
|
| 430 | - $probably_installed++; |
|
| 431 | - if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) |
|
| 432 | - $probably_installed++; |
|
| 450 | + if (preg_match('~^\$db_passwd\s=\s\'([^\']+)\';$~', $line)) { |
|
| 451 | + $probably_installed++; |
|
| 452 | + } |
|
| 453 | + if (preg_match('~^\$boardurl\s=\s\'([^\']+)\';~', $line) && !preg_match('~^\$boardurl\s=\s\'http://127\.0\.0\.1/smf\';~', $line)) { |
|
| 454 | + $probably_installed++; |
|
| 455 | + } |
|
| 433 | 456 | } |
| 434 | 457 | |
| 435 | - if ($probably_installed == 2) |
|
| 436 | - $incontext['warning'] = $txt['error_already_installed']; |
|
| 458 | + if ($probably_installed == 2) { |
|
| 459 | + $incontext['warning'] = $txt['error_already_installed']; |
|
| 460 | + } |
|
| 437 | 461 | } |
| 438 | 462 | |
| 439 | 463 | // Is some database support even compiled in? |
@@ -448,36 +472,43 @@ discard block |
||
| 448 | 472 | $databases[$key]['supported'] = false; |
| 449 | 473 | $notFoundSQLFile = true; |
| 450 | 474 | $txt['error_db_script_missing'] = sprintf($txt['error_db_script_missing'], 'install_' . $GLOBALS['db_script_version'] . '_' . $type . '.sql'); |
| 475 | + } else { |
|
| 476 | + $incontext['supported_databases'][] = $db; |
|
| 451 | 477 | } |
| 452 | - else |
|
| 453 | - $incontext['supported_databases'][] = $db; |
|
| 454 | 478 | } |
| 455 | 479 | } |
| 456 | 480 | |
| 457 | 481 | // Check the PHP version. |
| 458 | - if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>'))) |
|
| 459 | - $error = 'error_php_too_low'; |
|
| 482 | + if ((!function_exists('version_compare') || version_compare($GLOBALS['required_php_version'], PHP_VERSION, '>'))) { |
|
| 483 | + $error = 'error_php_too_low'; |
|
| 484 | + } |
|
| 460 | 485 | // Make sure we have a supported database |
| 461 | - elseif (empty($incontext['supported_databases'])) |
|
| 462 | - $error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing'; |
|
| 486 | + elseif (empty($incontext['supported_databases'])) { |
|
| 487 | + $error = empty($notFoundSQLFile) ? 'error_db_missing' : 'error_db_script_missing'; |
|
| 488 | + } |
|
| 463 | 489 | // How about session support? Some crazy sysadmin remove it? |
| 464 | - elseif (!function_exists('session_start')) |
|
| 465 | - $error = 'error_session_missing'; |
|
| 490 | + elseif (!function_exists('session_start')) { |
|
| 491 | + $error = 'error_session_missing'; |
|
| 492 | + } |
|
| 466 | 493 | // Make sure they uploaded all the files. |
| 467 | - elseif (!file_exists(dirname(__FILE__) . '/index.php')) |
|
| 468 | - $error = 'error_missing_files'; |
|
| 494 | + elseif (!file_exists(dirname(__FILE__) . '/index.php')) { |
|
| 495 | + $error = 'error_missing_files'; |
|
| 496 | + } |
|
| 469 | 497 | // Very simple check on the session.save_path for Windows. |
| 470 | 498 | // @todo Move this down later if they don't use database-driven sessions? |
| 471 | - elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') |
|
| 472 | - $error = 'error_session_save_path'; |
|
| 499 | + elseif (@ini_get('session.save_path') == '/tmp' && substr(__FILE__, 1, 2) == ':\\') { |
|
| 500 | + $error = 'error_session_save_path'; |
|
| 501 | + } |
|
| 473 | 502 | |
| 474 | 503 | // Since each of the three messages would look the same, anyway... |
| 475 | - if (isset($error)) |
|
| 476 | - $incontext['error'] = $txt[$error]; |
|
| 504 | + if (isset($error)) { |
|
| 505 | + $incontext['error'] = $txt[$error]; |
|
| 506 | + } |
|
| 477 | 507 | |
| 478 | 508 | // Mod_security blocks everything that smells funny. Let SMF handle security. |
| 479 | - if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) |
|
| 480 | - $incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again']; |
|
| 509 | + if (!fixModSecurity() && !isset($_GET['overmodsecurity'])) { |
|
| 510 | + $incontext['error'] = $txt['error_mod_security'] . '<br><br><a href="' . $installurl . '?overmodsecurity=true">' . $txt['error_message_click'] . '</a> ' . $txt['error_message_bad_try_again']; |
|
| 511 | + } |
|
| 481 | 512 | |
| 482 | 513 | return false; |
| 483 | 514 | } |
@@ -503,12 +534,14 @@ discard block |
||
| 503 | 534 | 'db_last_error.php', |
| 504 | 535 | ); |
| 505 | 536 | |
| 506 | - foreach ($incontext['detected_languages'] as $lang => $temp) |
|
| 507 | - $extra_files[] = 'Themes/default/languages/' . $lang; |
|
| 537 | + foreach ($incontext['detected_languages'] as $lang => $temp) { |
|
| 538 | + $extra_files[] = 'Themes/default/languages/' . $lang; |
|
| 539 | + } |
|
| 508 | 540 | |
| 509 | 541 | // With mod_security installed, we could attempt to fix it with .htaccess. |
| 510 | - if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) |
|
| 511 | - $writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.'; |
|
| 542 | + if (function_exists('apache_get_modules') && in_array('mod_security', apache_get_modules())) { |
|
| 543 | + $writable_files[] = file_exists(dirname(__FILE__) . '/.htaccess') ? '.htaccess' : '.'; |
|
| 544 | + } |
|
| 512 | 545 | |
| 513 | 546 | $failed_files = array(); |
| 514 | 547 | |
@@ -524,12 +557,14 @@ discard block |
||
| 524 | 557 | @chmod(dirname(__FILE__) . '/' . $file, 0755); |
| 525 | 558 | |
| 526 | 559 | // Well, 755 hopefully worked... if not, try 777. |
| 527 | - if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) |
|
| 528 | - $failed_files[] = $file; |
|
| 560 | + if (!is_writable(dirname(__FILE__) . '/' . $file) && !@chmod(dirname(__FILE__) . '/' . $file, 0777)) { |
|
| 561 | + $failed_files[] = $file; |
|
| 562 | + } |
|
| 529 | 563 | } |
| 530 | 564 | } |
| 531 | - foreach ($extra_files as $file) |
|
| 532 | - @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
| 565 | + foreach ($extra_files as $file) { |
|
| 566 | + @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
| 567 | + } |
|
| 533 | 568 | } |
| 534 | 569 | // Windows is trickier. Let's try opening for r+... |
| 535 | 570 | else |
@@ -539,30 +574,35 @@ discard block |
||
| 539 | 574 | foreach ($writable_files as $file) |
| 540 | 575 | { |
| 541 | 576 | // Folders can't be opened for write... but the index.php in them can ;) |
| 542 | - if (is_dir(dirname(__FILE__) . '/' . $file)) |
|
| 543 | - $file .= '/index.php'; |
|
| 577 | + if (is_dir(dirname(__FILE__) . '/' . $file)) { |
|
| 578 | + $file .= '/index.php'; |
|
| 579 | + } |
|
| 544 | 580 | |
| 545 | 581 | // Funny enough, chmod actually does do something on windows - it removes the read only attribute. |
| 546 | 582 | @chmod(dirname(__FILE__) . '/' . $file, 0777); |
| 547 | 583 | $fp = @fopen(dirname(__FILE__) . '/' . $file, 'r+'); |
| 548 | 584 | |
| 549 | 585 | // Hmm, okay, try just for write in that case... |
| 550 | - if (!is_resource($fp)) |
|
| 551 | - $fp = @fopen(dirname(__FILE__) . '/' . $file, 'w'); |
|
| 586 | + if (!is_resource($fp)) { |
|
| 587 | + $fp = @fopen(dirname(__FILE__) . '/' . $file, 'w'); |
|
| 588 | + } |
|
| 552 | 589 | |
| 553 | - if (!is_resource($fp)) |
|
| 554 | - $failed_files[] = $file; |
|
| 590 | + if (!is_resource($fp)) { |
|
| 591 | + $failed_files[] = $file; |
|
| 592 | + } |
|
| 555 | 593 | |
| 556 | 594 | @fclose($fp); |
| 557 | 595 | } |
| 558 | - foreach ($extra_files as $file) |
|
| 559 | - @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
| 596 | + foreach ($extra_files as $file) { |
|
| 597 | + @chmod(dirname(__FILE__) . (empty($file) ? '' : '/' . $file), 0777); |
|
| 598 | + } |
|
| 560 | 599 | } |
| 561 | 600 | |
| 562 | 601 | $failure = count($failed_files) >= 1; |
| 563 | 602 | |
| 564 | - if (!isset($_SERVER)) |
|
| 565 | - return !$failure; |
|
| 603 | + if (!isset($_SERVER)) { |
|
| 604 | + return !$failure; |
|
| 605 | + } |
|
| 566 | 606 | |
| 567 | 607 | // Put the list into context. |
| 568 | 608 | $incontext['failed_files'] = $failed_files; |
@@ -610,19 +650,23 @@ discard block |
||
| 610 | 650 | |
| 611 | 651 | if (!isset($ftp) || $ftp->error !== false) |
| 612 | 652 | { |
| 613 | - if (!isset($ftp)) |
|
| 614 | - $ftp = new ftp_connection(null); |
|
| 653 | + if (!isset($ftp)) { |
|
| 654 | + $ftp = new ftp_connection(null); |
|
| 655 | + } |
|
| 615 | 656 | // Save the error so we can mess with listing... |
| 616 | - elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) |
|
| 617 | - $incontext['ftp_errors'][] = $ftp->last_message; |
|
| 657 | + elseif ($ftp->error !== false && empty($incontext['ftp_errors']) && !empty($ftp->last_message)) { |
|
| 658 | + $incontext['ftp_errors'][] = $ftp->last_message; |
|
| 659 | + } |
|
| 618 | 660 | |
| 619 | 661 | list ($username, $detect_path, $found_path) = $ftp->detect_path(dirname(__FILE__)); |
| 620 | 662 | |
| 621 | - if (empty($_POST['ftp_path']) && $found_path) |
|
| 622 | - $_POST['ftp_path'] = $detect_path; |
|
| 663 | + if (empty($_POST['ftp_path']) && $found_path) { |
|
| 664 | + $_POST['ftp_path'] = $detect_path; |
|
| 665 | + } |
|
| 623 | 666 | |
| 624 | - if (!isset($_POST['ftp_username'])) |
|
| 625 | - $_POST['ftp_username'] = $username; |
|
| 667 | + if (!isset($_POST['ftp_username'])) { |
|
| 668 | + $_POST['ftp_username'] = $username; |
|
| 669 | + } |
|
| 626 | 670 | |
| 627 | 671 | // Set the username etc, into context. |
| 628 | 672 | $incontext['ftp'] = array( |
@@ -634,8 +678,7 @@ discard block |
||
| 634 | 678 | ); |
| 635 | 679 | |
| 636 | 680 | return false; |
| 637 | - } |
|
| 638 | - else |
|
| 681 | + } else |
|
| 639 | 682 | { |
| 640 | 683 | $_SESSION['installer_temp_ftp'] = array( |
| 641 | 684 | 'server' => $_POST['ftp_server'], |
@@ -649,10 +692,12 @@ discard block |
||
| 649 | 692 | |
| 650 | 693 | foreach ($failed_files as $file) |
| 651 | 694 | { |
| 652 | - if (!is_writable(dirname(__FILE__) . '/' . $file)) |
|
| 653 | - $ftp->chmod($file, 0755); |
|
| 654 | - if (!is_writable(dirname(__FILE__) . '/' . $file)) |
|
| 655 | - $ftp->chmod($file, 0777); |
|
| 695 | + if (!is_writable(dirname(__FILE__) . '/' . $file)) { |
|
| 696 | + $ftp->chmod($file, 0755); |
|
| 697 | + } |
|
| 698 | + if (!is_writable(dirname(__FILE__) . '/' . $file)) { |
|
| 699 | + $ftp->chmod($file, 0777); |
|
| 700 | + } |
|
| 656 | 701 | if (!is_writable(dirname(__FILE__) . '/' . $file)) |
| 657 | 702 | { |
| 658 | 703 | $failed_files_updated[] = $file; |
@@ -707,15 +752,17 @@ discard block |
||
| 707 | 752 | |
| 708 | 753 | if (!$foundOne) |
| 709 | 754 | { |
| 710 | - if (isset($db['default_host'])) |
|
| 711 | - $incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost'; |
|
| 755 | + if (isset($db['default_host'])) { |
|
| 756 | + $incontext['db']['server'] = ini_get($db['default_host']) or $incontext['db']['server'] = 'localhost'; |
|
| 757 | + } |
|
| 712 | 758 | if (isset($db['default_user'])) |
| 713 | 759 | { |
| 714 | 760 | $incontext['db']['user'] = ini_get($db['default_user']); |
| 715 | 761 | $incontext['db']['name'] = ini_get($db['default_user']); |
| 716 | 762 | } |
| 717 | - if (isset($db['default_password'])) |
|
| 718 | - $incontext['db']['pass'] = ini_get($db['default_password']); |
|
| 763 | + if (isset($db['default_password'])) { |
|
| 764 | + $incontext['db']['pass'] = ini_get($db['default_password']); |
|
| 765 | + } |
|
| 719 | 766 | |
| 720 | 767 | // For simplicity and less confusion, leave the port blank by default |
| 721 | 768 | $incontext['db']['port'] = ''; |
@@ -734,10 +781,10 @@ discard block |
||
| 734 | 781 | $incontext['db']['server'] = $_POST['db_server']; |
| 735 | 782 | $incontext['db']['prefix'] = $_POST['db_prefix']; |
| 736 | 783 | |
| 737 | - if (!empty($_POST['db_port'])) |
|
| 738 | - $incontext['db']['port'] = $_POST['db_port']; |
|
| 739 | - } |
|
| 740 | - else |
|
| 784 | + if (!empty($_POST['db_port'])) { |
|
| 785 | + $incontext['db']['port'] = $_POST['db_port']; |
|
| 786 | + } |
|
| 787 | + } else |
|
| 741 | 788 | { |
| 742 | 789 | $incontext['db']['prefix'] = 'smf_'; |
| 743 | 790 | } |
@@ -773,10 +820,11 @@ discard block |
||
| 773 | 820 | if (!empty($_POST['db_port'])) |
| 774 | 821 | { |
| 775 | 822 | // For MySQL, we can get the "default port" from PHP. PostgreSQL has no such option though. |
| 776 | - if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) |
|
| 777 | - $vars['db_port'] = (int) $_POST['db_port']; |
|
| 778 | - elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) |
|
| 779 | - $vars['db_port'] = (int) $_POST['db_port']; |
|
| 823 | + if (($db_type == 'mysql' || $db_type == 'mysqli') && $_POST['db_port'] != ini_get($db_type . '.default_port')) { |
|
| 824 | + $vars['db_port'] = (int) $_POST['db_port']; |
|
| 825 | + } elseif ($db_type == 'postgresql' && $_POST['db_port'] != 5432) { |
|
| 826 | + $vars['db_port'] = (int) $_POST['db_port']; |
|
| 827 | + } |
|
| 780 | 828 | } |
| 781 | 829 | |
| 782 | 830 | // God I hope it saved! |
@@ -789,8 +837,9 @@ discard block |
||
| 789 | 837 | // Make sure it works. |
| 790 | 838 | require(dirname(__FILE__) . '/Settings.php'); |
| 791 | 839 | |
| 792 | - if (empty($sourcedir)) |
|
| 793 | - $sourcedir = dirname(__FILE__) . '/Sources'; |
|
| 840 | + if (empty($sourcedir)) { |
|
| 841 | + $sourcedir = dirname(__FILE__) . '/Sources'; |
|
| 842 | + } |
|
| 794 | 843 | |
| 795 | 844 | // Better find the database file! |
| 796 | 845 | if (!file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
@@ -800,18 +849,21 @@ discard block |
||
| 800 | 849 | } |
| 801 | 850 | |
| 802 | 851 | // Now include it for database functions! |
| 803 | - if (!defined('SMF')) |
|
| 804 | - define('SMF', 1); |
|
| 852 | + if (!defined('SMF')) { |
|
| 853 | + define('SMF', 1); |
|
| 854 | + } |
|
| 805 | 855 | |
| 806 | 856 | $modSettings['disableQueryCheck'] = true; |
| 807 | - if (empty($smcFunc)) |
|
| 808 | - $smcFunc = array(); |
|
| 857 | + if (empty($smcFunc)) { |
|
| 858 | + $smcFunc = array(); |
|
| 859 | + } |
|
| 809 | 860 | |
| 810 | 861 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
| 811 | 862 | |
| 812 | 863 | // What - running PHP4? The shame! |
| 813 | - if (version_compare(PHP_VERSION, '5', '<')) |
|
| 814 | - require_once($sourcedir . '/Subs-Compat.php'); |
|
| 864 | + if (version_compare(PHP_VERSION, '5', '<')) { |
|
| 865 | + require_once($sourcedir . '/Subs-Compat.php'); |
|
| 866 | + } |
|
| 815 | 867 | |
| 816 | 868 | // Attempt a connection. |
| 817 | 869 | $needsDB = !empty($databases[$db_type]['always_has_db']); |
@@ -899,12 +951,14 @@ discard block |
||
| 899 | 951 | $incontext['page_title'] = $txt['install_settings']; |
| 900 | 952 | |
| 901 | 953 | // Let's see if we got the database type correct. |
| 902 | - if (isset($_POST['db_type'], $databases[$_POST['db_type']])) |
|
| 903 | - $db_type = $_POST['db_type']; |
|
| 954 | + if (isset($_POST['db_type'], $databases[$_POST['db_type']])) { |
|
| 955 | + $db_type = $_POST['db_type']; |
|
| 956 | + } |
|
| 904 | 957 | |
| 905 | 958 | // Else we'd better be able to get the connection. |
| 906 | - else |
|
| 907 | - load_database(); |
|
| 959 | + else { |
|
| 960 | + load_database(); |
|
| 961 | + } |
|
| 908 | 962 | |
| 909 | 963 | $db_type = isset($_POST['db_type']) ? $_POST['db_type'] : $db_type; |
| 910 | 964 | |
@@ -924,12 +978,14 @@ discard block |
||
| 924 | 978 | // Submitting? |
| 925 | 979 | if (isset($_POST['boardurl'])) |
| 926 | 980 | { |
| 927 | - if (substr($_POST['boardurl'], -10) == '/index.php') |
|
| 928 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
| 929 | - elseif (substr($_POST['boardurl'], -1) == '/') |
|
| 930 | - $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
| 931 | - if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') |
|
| 932 | - $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
| 981 | + if (substr($_POST['boardurl'], -10) == '/index.php') { |
|
| 982 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -10); |
|
| 983 | + } elseif (substr($_POST['boardurl'], -1) == '/') { |
|
| 984 | + $_POST['boardurl'] = substr($_POST['boardurl'], 0, -1); |
|
| 985 | + } |
|
| 986 | + if (substr($_POST['boardurl'], 0, 7) != 'http://' && substr($_POST['boardurl'], 0, 7) != 'file://' && substr($_POST['boardurl'], 0, 8) != 'https://') { |
|
| 987 | + $_POST['boardurl'] = 'http://' . $_POST['boardurl']; |
|
| 988 | + } |
|
| 933 | 989 | |
| 934 | 990 | // Save these variables. |
| 935 | 991 | $vars = array( |
@@ -966,10 +1022,10 @@ discard block |
||
| 966 | 1022 | { |
| 967 | 1023 | $incontext['error'] = sprintf($txt['error_utf8_version'], $databases[$db_type]['utf8_version']); |
| 968 | 1024 | return false; |
| 969 | - } |
|
| 970 | - else |
|
| 971 | - // Set the character set here. |
|
| 1025 | + } else { |
|
| 1026 | + // Set the character set here. |
|
| 972 | 1027 | updateSettingsFile(array('db_character_set' => 'utf8')); |
| 1028 | + } |
|
| 973 | 1029 | } |
| 974 | 1030 | |
| 975 | 1031 | // Good, skip on. |
@@ -989,8 +1045,9 @@ discard block |
||
| 989 | 1045 | $incontext['continue'] = 1; |
| 990 | 1046 | |
| 991 | 1047 | // Already done? |
| 992 | - if (isset($_POST['pop_done'])) |
|
| 993 | - return true; |
|
| 1048 | + if (isset($_POST['pop_done'])) { |
|
| 1049 | + return true; |
|
| 1050 | + } |
|
| 994 | 1051 | |
| 995 | 1052 | // Reload settings. |
| 996 | 1053 | require(dirname(__FILE__) . '/Settings.php'); |
@@ -1008,8 +1065,9 @@ discard block |
||
| 1008 | 1065 | $modSettings = array(); |
| 1009 | 1066 | if ($result !== false) |
| 1010 | 1067 | { |
| 1011 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
| 1012 | - $modSettings[$row['variable']] = $row['value']; |
|
| 1068 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
| 1069 | + $modSettings[$row['variable']] = $row['value']; |
|
| 1070 | + } |
|
| 1013 | 1071 | $smcFunc['db_free_result']($result); |
| 1014 | 1072 | |
| 1015 | 1073 | // Do they match? If so, this is just a refresh so charge on! |
@@ -1022,20 +1080,22 @@ discard block |
||
| 1022 | 1080 | $modSettings['disableQueryCheck'] = true; |
| 1023 | 1081 | |
| 1024 | 1082 | // If doing UTF8, select it. PostgreSQL requires passing it as a string... |
| 1025 | - if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) |
|
| 1026 | - $smcFunc['db_query']('', ' |
|
| 1083 | + if (!empty($db_character_set) && $db_character_set == 'utf8' && !empty($databases[$db_type]['utf8_support'])) { |
|
| 1084 | + $smcFunc['db_query']('', ' |
|
| 1027 | 1085 | SET NAMES {string:utf8}', |
| 1028 | 1086 | array( |
| 1029 | 1087 | 'db_error_skip' => true, |
| 1030 | 1088 | 'utf8' => 'utf8', |
| 1031 | 1089 | ) |
| 1032 | 1090 | ); |
| 1091 | + } |
|
| 1033 | 1092 | |
| 1034 | 1093 | // Windows likes to leave the trailing slash, which yields to C:\path\to\SMF\/attachments... |
| 1035 | - if (substr(__DIR__, -1) == '\\') |
|
| 1036 | - $attachdir = __DIR__ . 'attachments'; |
|
| 1037 | - else |
|
| 1038 | - $attachdir = __DIR__ . '/attachments'; |
|
| 1094 | + if (substr(__DIR__, -1) == '\\') { |
|
| 1095 | + $attachdir = __DIR__ . 'attachments'; |
|
| 1096 | + } else { |
|
| 1097 | + $attachdir = __DIR__ . '/attachments'; |
|
| 1098 | + } |
|
| 1039 | 1099 | |
| 1040 | 1100 | $replaces = array( |
| 1041 | 1101 | '{$db_prefix}' => $db_prefix, |
@@ -1052,8 +1112,9 @@ discard block |
||
| 1052 | 1112 | |
| 1053 | 1113 | foreach ($txt as $key => $value) |
| 1054 | 1114 | { |
| 1055 | - if (substr($key, 0, 8) == 'default_') |
|
| 1056 | - $replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value); |
|
| 1115 | + if (substr($key, 0, 8) == 'default_') { |
|
| 1116 | + $replaces['{$' . $key . '}'] = $smcFunc['db_escape_string']($value); |
|
| 1117 | + } |
|
| 1057 | 1118 | } |
| 1058 | 1119 | $replaces['{$default_reserved_names}'] = strtr($replaces['{$default_reserved_names}'], array('\\\\n' => '\\n')); |
| 1059 | 1120 | |
@@ -1068,8 +1129,9 @@ discard block |
||
| 1068 | 1129 | |
| 1069 | 1130 | while ($row = $smcFunc['db_fetch_assoc']($get_engines)) |
| 1070 | 1131 | { |
| 1071 | - if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') |
|
| 1072 | - $engines[] = $row['Engine']; |
|
| 1132 | + if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') { |
|
| 1133 | + $engines[] = $row['Engine']; |
|
| 1134 | + } |
|
| 1073 | 1135 | } |
| 1074 | 1136 | |
| 1075 | 1137 | // Done with this now |
@@ -1093,8 +1155,7 @@ discard block |
||
| 1093 | 1155 | $replaces['START TRANSACTION;'] = ''; |
| 1094 | 1156 | $replaces['COMMIT;'] = ''; |
| 1095 | 1157 | } |
| 1096 | - } |
|
| 1097 | - else |
|
| 1158 | + } else |
|
| 1098 | 1159 | { |
| 1099 | 1160 | $has_innodb = false; |
| 1100 | 1161 | } |
@@ -1116,21 +1177,24 @@ discard block |
||
| 1116 | 1177 | foreach ($sql_lines as $count => $line) |
| 1117 | 1178 | { |
| 1118 | 1179 | // No comments allowed! |
| 1119 | - if (substr(trim($line), 0, 1) != '#') |
|
| 1120 | - $current_statement .= "\n" . rtrim($line); |
|
| 1180 | + if (substr(trim($line), 0, 1) != '#') { |
|
| 1181 | + $current_statement .= "\n" . rtrim($line); |
|
| 1182 | + } |
|
| 1121 | 1183 | |
| 1122 | 1184 | // Is this the end of the query string? |
| 1123 | - if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) |
|
| 1124 | - continue; |
|
| 1185 | + if (empty($current_statement) || (preg_match('~;[\s]*$~s', $line) == 0 && $count != count($sql_lines))) { |
|
| 1186 | + continue; |
|
| 1187 | + } |
|
| 1125 | 1188 | |
| 1126 | 1189 | // Does this table already exist? If so, don't insert more data into it! |
| 1127 | 1190 | if (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) != 0 && in_array($match[1], $exists)) |
| 1128 | 1191 | { |
| 1129 | 1192 | preg_match_all('~\)[,;]~', $current_statement, $matches); |
| 1130 | - if (!empty($matches[0])) |
|
| 1131 | - $incontext['sql_results']['insert_dups'] += count($matches[0]); |
|
| 1132 | - else |
|
| 1133 | - $incontext['sql_results']['insert_dups']++; |
|
| 1193 | + if (!empty($matches[0])) { |
|
| 1194 | + $incontext['sql_results']['insert_dups'] += count($matches[0]); |
|
| 1195 | + } else { |
|
| 1196 | + $incontext['sql_results']['insert_dups']++; |
|
| 1197 | + } |
|
| 1134 | 1198 | |
| 1135 | 1199 | $current_statement = ''; |
| 1136 | 1200 | continue; |
@@ -1139,8 +1203,9 @@ discard block |
||
| 1139 | 1203 | if ($smcFunc['db_query']('', $current_statement, array('security_override' => true, 'db_error_skip' => true), $db_connection) === false) |
| 1140 | 1204 | { |
| 1141 | 1205 | // Use the appropriate function based on the DB type |
| 1142 | - if ($db_type == 'mysql' || $db_type == 'mysqli') |
|
| 1143 | - $db_errorno = $db_type . '_errno'; |
|
| 1206 | + if ($db_type == 'mysql' || $db_type == 'mysqli') { |
|
| 1207 | + $db_errorno = $db_type . '_errno'; |
|
| 1208 | + } |
|
| 1144 | 1209 | |
| 1145 | 1210 | // Error 1050: Table already exists! |
| 1146 | 1211 | // @todo Needs to be made better! |
@@ -1155,18 +1220,18 @@ discard block |
||
| 1155 | 1220 | // MySQLi requires a connection object. It's optional with MySQL and Postgres |
| 1156 | 1221 | $incontext['failures'][$count] = $smcFunc['db_error']($db_connection); |
| 1157 | 1222 | } |
| 1158 | - } |
|
| 1159 | - else |
|
| 1223 | + } else |
|
| 1160 | 1224 | { |
| 1161 | - if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
| 1162 | - $incontext['sql_results']['tables']++; |
|
| 1163 | - elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
| 1225 | + if (preg_match('~^\s*CREATE TABLE ([^\s\n\r]+?)~', $current_statement, $match) == 1) { |
|
| 1226 | + $incontext['sql_results']['tables']++; |
|
| 1227 | + } elseif (preg_match('~^\s*INSERT INTO ([^\s\n\r]+?)~', $current_statement, $match) == 1) |
|
| 1164 | 1228 | { |
| 1165 | 1229 | preg_match_all('~\)[,;]~', $current_statement, $matches); |
| 1166 | - if (!empty($matches[0])) |
|
| 1167 | - $incontext['sql_results']['inserts'] += count($matches[0]); |
|
| 1168 | - else |
|
| 1169 | - $incontext['sql_results']['inserts']++; |
|
| 1230 | + if (!empty($matches[0])) { |
|
| 1231 | + $incontext['sql_results']['inserts'] += count($matches[0]); |
|
| 1232 | + } else { |
|
| 1233 | + $incontext['sql_results']['inserts']++; |
|
| 1234 | + } |
|
| 1170 | 1235 | } |
| 1171 | 1236 | } |
| 1172 | 1237 | |
@@ -1179,15 +1244,17 @@ discard block |
||
| 1179 | 1244 | // Sort out the context for the SQL. |
| 1180 | 1245 | foreach ($incontext['sql_results'] as $key => $number) |
| 1181 | 1246 | { |
| 1182 | - if ($number == 0) |
|
| 1183 | - unset($incontext['sql_results'][$key]); |
|
| 1184 | - else |
|
| 1185 | - $incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number); |
|
| 1247 | + if ($number == 0) { |
|
| 1248 | + unset($incontext['sql_results'][$key]); |
|
| 1249 | + } else { |
|
| 1250 | + $incontext['sql_results'][$key] = sprintf($txt['db_populate_' . $key], $number); |
|
| 1251 | + } |
|
| 1186 | 1252 | } |
| 1187 | 1253 | |
| 1188 | 1254 | // Make sure UTF will be used globally. |
| 1189 | - if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) |
|
| 1190 | - $newSettings[] = array('global_character_set', 'UTF-8'); |
|
| 1255 | + if ((!empty($databases[$db_type]['utf8_support']) && !empty($databases[$db_type]['utf8_required'])) || (empty($databases[$db_type]['utf8_required']) && !empty($databases[$db_type]['utf8_support']) && isset($_POST['utf8']))) { |
|
| 1256 | + $newSettings[] = array('global_character_set', 'UTF-8'); |
|
| 1257 | + } |
|
| 1191 | 1258 | |
| 1192 | 1259 | // Maybe we can auto-detect better cookie settings? |
| 1193 | 1260 | preg_match('~^http[s]?://([^\.]+?)([^/]*?)(/.*)?$~', $boardurl, $matches); |
@@ -1198,16 +1265,20 @@ discard block |
||
| 1198 | 1265 | $globalCookies = false; |
| 1199 | 1266 | |
| 1200 | 1267 | // Okay... let's see. Using a subdomain other than www.? (not a perfect check.) |
| 1201 | - if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www')))) |
|
| 1202 | - $globalCookies = true; |
|
| 1268 | + if ($matches[2] != '' && (strpos(substr($matches[2], 1), '.') === false || in_array($matches[1], array('forum', 'board', 'community', 'forums', 'support', 'chat', 'help', 'talk', 'boards', 'www')))) { |
|
| 1269 | + $globalCookies = true; |
|
| 1270 | + } |
|
| 1203 | 1271 | // If there's a / in the middle of the path, or it starts with ~... we want local. |
| 1204 | - if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false)) |
|
| 1205 | - $localCookies = true; |
|
| 1272 | + if (isset($matches[3]) && strlen($matches[3]) > 3 && (substr($matches[3], 0, 2) == '/~' || strpos(substr($matches[3], 1), '/') !== false)) { |
|
| 1273 | + $localCookies = true; |
|
| 1274 | + } |
|
| 1206 | 1275 | |
| 1207 | - if ($globalCookies) |
|
| 1208 | - $newSettings[] = array('globalCookies', '1'); |
|
| 1209 | - if ($localCookies) |
|
| 1210 | - $newSettings[] = array('localCookies', '1'); |
|
| 1276 | + if ($globalCookies) { |
|
| 1277 | + $newSettings[] = array('globalCookies', '1'); |
|
| 1278 | + } |
|
| 1279 | + if ($localCookies) { |
|
| 1280 | + $newSettings[] = array('localCookies', '1'); |
|
| 1281 | + } |
|
| 1211 | 1282 | } |
| 1212 | 1283 | |
| 1213 | 1284 | // Are we allowing stat collection? |
@@ -1223,32 +1294,36 @@ discard block |
||
| 1223 | 1294 | fwrite($fp, $out); |
| 1224 | 1295 | |
| 1225 | 1296 | $return_data = ''; |
| 1226 | - while (!feof($fp)) |
|
| 1227 | - $return_data .= fgets($fp, 128); |
|
| 1297 | + while (!feof($fp)) { |
|
| 1298 | + $return_data .= fgets($fp, 128); |
|
| 1299 | + } |
|
| 1228 | 1300 | |
| 1229 | 1301 | fclose($fp); |
| 1230 | 1302 | |
| 1231 | 1303 | // Get the unique site ID. |
| 1232 | 1304 | preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID); |
| 1233 | 1305 | |
| 1234 | - if (!empty($ID[1])) |
|
| 1235 | - $newSettings[] = array('allow_sm_stats', $ID[1]); |
|
| 1306 | + if (!empty($ID[1])) { |
|
| 1307 | + $newSettings[] = array('allow_sm_stats', $ID[1]); |
|
| 1308 | + } |
|
| 1236 | 1309 | } |
| 1237 | 1310 | } |
| 1238 | 1311 | |
| 1239 | 1312 | // Are we enabling SSL? |
| 1240 | - if (!empty($_POST['force_ssl'])) |
|
| 1241 | - $newSettings[] = array('force_ssl', 2); |
|
| 1313 | + if (!empty($_POST['force_ssl'])) { |
|
| 1314 | + $newSettings[] = array('force_ssl', 2); |
|
| 1315 | + } |
|
| 1242 | 1316 | |
| 1243 | 1317 | // Setting a timezone is required. |
| 1244 | 1318 | if (!isset($modSettings['default_timezone']) && function_exists('date_default_timezone_set')) |
| 1245 | 1319 | { |
| 1246 | 1320 | // Get PHP's default timezone, if set |
| 1247 | 1321 | $ini_tz = ini_get('date.timezone'); |
| 1248 | - if (!empty($ini_tz)) |
|
| 1249 | - $timezone_id = $ini_tz; |
|
| 1250 | - else |
|
| 1251 | - $timezone_id = ''; |
|
| 1322 | + if (!empty($ini_tz)) { |
|
| 1323 | + $timezone_id = $ini_tz; |
|
| 1324 | + } else { |
|
| 1325 | + $timezone_id = ''; |
|
| 1326 | + } |
|
| 1252 | 1327 | |
| 1253 | 1328 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
| 1254 | 1329 | if (!in_array($timezone_id, timezone_identifiers_list())) |
@@ -1257,8 +1332,9 @@ discard block |
||
| 1257 | 1332 | $timezone_id = timezone_name_from_abbr('', $server_offset, 0); |
| 1258 | 1333 | } |
| 1259 | 1334 | |
| 1260 | - if (date_default_timezone_set($timezone_id)) |
|
| 1261 | - $newSettings[] = array('default_timezone', $timezone_id); |
|
| 1335 | + if (date_default_timezone_set($timezone_id)) { |
|
| 1336 | + $newSettings[] = array('default_timezone', $timezone_id); |
|
| 1337 | + } |
|
| 1262 | 1338 | } |
| 1263 | 1339 | |
| 1264 | 1340 | if (!empty($newSettings)) |
@@ -1289,16 +1365,18 @@ discard block |
||
| 1289 | 1365 | } |
| 1290 | 1366 | |
| 1291 | 1367 | // MySQL specific stuff |
| 1292 | - if (substr($db_type, 0, 5) != 'mysql') |
|
| 1293 | - return false; |
|
| 1368 | + if (substr($db_type, 0, 5) != 'mysql') { |
|
| 1369 | + return false; |
|
| 1370 | + } |
|
| 1294 | 1371 | |
| 1295 | 1372 | // Find database user privileges. |
| 1296 | 1373 | $privs = array(); |
| 1297 | 1374 | $get_privs = $smcFunc['db_query']('', 'SHOW PRIVILEGES', array()); |
| 1298 | 1375 | while ($row = $smcFunc['db_fetch_assoc']($get_privs)) |
| 1299 | 1376 | { |
| 1300 | - if ($row['Privilege'] == 'Alter') |
|
| 1301 | - $privs[] = $row['Privilege']; |
|
| 1377 | + if ($row['Privilege'] == 'Alter') { |
|
| 1378 | + $privs[] = $row['Privilege']; |
|
| 1379 | + } |
|
| 1302 | 1380 | } |
| 1303 | 1381 | $smcFunc['db_free_result']($get_privs); |
| 1304 | 1382 | |
@@ -1328,8 +1406,9 @@ discard block |
||
| 1328 | 1406 | $incontext['continue'] = 1; |
| 1329 | 1407 | |
| 1330 | 1408 | // Skipping? |
| 1331 | - if (!empty($_POST['skip'])) |
|
| 1332 | - return true; |
|
| 1409 | + if (!empty($_POST['skip'])) { |
|
| 1410 | + return true; |
|
| 1411 | + } |
|
| 1333 | 1412 | |
| 1334 | 1413 | // Need this to check whether we need the database password. |
| 1335 | 1414 | require(dirname(__FILE__) . '/Settings.php'); |
@@ -1342,18 +1421,22 @@ discard block |
||
| 1342 | 1421 | // We need this to properly hash the password for Admin |
| 1343 | 1422 | $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : function($string) { |
| 1344 | 1423 | global $sourcedir; |
| 1345 | - if (function_exists('mb_strtolower')) |
|
| 1346 | - return mb_strtolower($string, 'UTF-8'); |
|
| 1424 | + if (function_exists('mb_strtolower')) { |
|
| 1425 | + return mb_strtolower($string, 'UTF-8'); |
|
| 1426 | + } |
|
| 1347 | 1427 | require_once($sourcedir . '/Subs-Charset.php'); |
| 1348 | 1428 | return utf8_strtolower($string); |
| 1349 | 1429 | }; |
| 1350 | 1430 | |
| 1351 | - if (!isset($_POST['username'])) |
|
| 1352 | - $_POST['username'] = ''; |
|
| 1353 | - if (!isset($_POST['email'])) |
|
| 1354 | - $_POST['email'] = ''; |
|
| 1355 | - if (!isset($_POST['server_email'])) |
|
| 1356 | - $_POST['server_email'] = ''; |
|
| 1431 | + if (!isset($_POST['username'])) { |
|
| 1432 | + $_POST['username'] = ''; |
|
| 1433 | + } |
|
| 1434 | + if (!isset($_POST['email'])) { |
|
| 1435 | + $_POST['email'] = ''; |
|
| 1436 | + } |
|
| 1437 | + if (!isset($_POST['server_email'])) { |
|
| 1438 | + $_POST['server_email'] = ''; |
|
| 1439 | + } |
|
| 1357 | 1440 | |
| 1358 | 1441 | $incontext['username'] = htmlspecialchars(stripslashes($_POST['username'])); |
| 1359 | 1442 | $incontext['email'] = htmlspecialchars(stripslashes($_POST['email'])); |
@@ -1372,8 +1455,9 @@ discard block |
||
| 1372 | 1455 | 'admin_group' => 1, |
| 1373 | 1456 | ) |
| 1374 | 1457 | ); |
| 1375 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
| 1376 | - $incontext['skip'] = 1; |
|
| 1458 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
| 1459 | + $incontext['skip'] = 1; |
|
| 1460 | + } |
|
| 1377 | 1461 | $smcFunc['db_free_result']($request); |
| 1378 | 1462 | |
| 1379 | 1463 | // Trying to create an account? |
@@ -1404,8 +1488,9 @@ discard block |
||
| 1404 | 1488 | } |
| 1405 | 1489 | |
| 1406 | 1490 | // Update the webmaster's email? |
| 1407 | - if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) |
|
| 1408 | - updateSettingsFile(array('webmaster_email' => $_POST['server_email'])); |
|
| 1491 | + if (!empty($_POST['server_email']) && (empty($webmaster_email) || $webmaster_email == '[email protected]')) { |
|
| 1492 | + updateSettingsFile(array('webmaster_email' => $_POST['server_email'])); |
|
| 1493 | + } |
|
| 1409 | 1494 | |
| 1410 | 1495 | // Work out whether we're going to have dodgy characters and remove them. |
| 1411 | 1496 | $invalid_characters = preg_match('~[<>&"\'=\\\]~', $_POST['username']) != 0; |
@@ -1428,32 +1513,27 @@ discard block |
||
| 1428 | 1513 | $smcFunc['db_free_result']($result); |
| 1429 | 1514 | |
| 1430 | 1515 | $incontext['account_existed'] = $txt['error_user_settings_taken']; |
| 1431 | - } |
|
| 1432 | - elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25) |
|
| 1516 | + } elseif ($_POST['username'] == '' || strlen($_POST['username']) > 25) |
|
| 1433 | 1517 | { |
| 1434 | 1518 | // Try the previous step again. |
| 1435 | 1519 | $incontext['error'] = $_POST['username'] == '' ? $txt['error_username_left_empty'] : $txt['error_username_too_long']; |
| 1436 | 1520 | return false; |
| 1437 | - } |
|
| 1438 | - elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false) |
|
| 1521 | + } elseif ($invalid_characters || $_POST['username'] == '_' || $_POST['username'] == '|' || strpos($_POST['username'], '[code') !== false || strpos($_POST['username'], '[/code') !== false) |
|
| 1439 | 1522 | { |
| 1440 | 1523 | // Try the previous step again. |
| 1441 | 1524 | $incontext['error'] = $txt['error_invalid_characters_username']; |
| 1442 | 1525 | return false; |
| 1443 | - } |
|
| 1444 | - elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255) |
|
| 1526 | + } elseif (empty($_POST['email']) || !filter_var(stripslashes($_POST['email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['email'])) > 255) |
|
| 1445 | 1527 | { |
| 1446 | 1528 | // One step back, this time fill out a proper admin email address. |
| 1447 | 1529 | $incontext['error'] = sprintf($txt['error_valid_admin_email_needed'], $_POST['username']); |
| 1448 | 1530 | return false; |
| 1449 | - } |
|
| 1450 | - elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255) |
|
| 1531 | + } elseif (empty($_POST['server_email']) || !filter_var(stripslashes($_POST['server_email']), FILTER_VALIDATE_EMAIL) || strlen(stripslashes($_POST['server_email'])) > 255) |
|
| 1451 | 1532 | { |
| 1452 | 1533 | // One step back, this time fill out a proper admin email address. |
| 1453 | 1534 | $incontext['error'] = $txt['error_valid_server_email_needed']; |
| 1454 | 1535 | return false; |
| 1455 | - } |
|
| 1456 | - elseif ($_POST['username'] != '') |
|
| 1536 | + } elseif ($_POST['username'] != '') |
|
| 1457 | 1537 | { |
| 1458 | 1538 | $incontext['member_salt'] = substr(md5(mt_rand()), 0, 4); |
| 1459 | 1539 | |
@@ -1519,17 +1599,19 @@ discard block |
||
| 1519 | 1599 | require_once($sourcedir . '/Subs-Auth.php'); |
| 1520 | 1600 | |
| 1521 | 1601 | // Bring a warning over. |
| 1522 | - if (!empty($incontext['account_existed'])) |
|
| 1523 | - $incontext['warning'] = $incontext['account_existed']; |
|
| 1602 | + if (!empty($incontext['account_existed'])) { |
|
| 1603 | + $incontext['warning'] = $incontext['account_existed']; |
|
| 1604 | + } |
|
| 1524 | 1605 | |
| 1525 | - if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) |
|
| 1526 | - $smcFunc['db_query']('', ' |
|
| 1606 | + if (!empty($db_character_set) && !empty($databases[$db_type]['utf8_support'])) { |
|
| 1607 | + $smcFunc['db_query']('', ' |
|
| 1527 | 1608 | SET NAMES {string:db_character_set}', |
| 1528 | 1609 | array( |
| 1529 | 1610 | 'db_character_set' => $db_character_set, |
| 1530 | 1611 | 'db_error_skip' => true, |
| 1531 | 1612 | ) |
| 1532 | 1613 | ); |
| 1614 | + } |
|
| 1533 | 1615 | |
| 1534 | 1616 | // As track stats is by default enabled let's add some activity. |
| 1535 | 1617 | $smcFunc['db_insert']('ignore', |
@@ -1550,14 +1632,16 @@ discard block |
||
| 1550 | 1632 | // Only proceed if we can load the data. |
| 1551 | 1633 | if ($request) |
| 1552 | 1634 | { |
| 1553 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
| 1554 | - $modSettings[$row[0]] = $row[1]; |
|
| 1635 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
| 1636 | + $modSettings[$row[0]] = $row[1]; |
|
| 1637 | + } |
|
| 1555 | 1638 | $smcFunc['db_free_result']($request); |
| 1556 | 1639 | } |
| 1557 | 1640 | |
| 1558 | 1641 | // Automatically log them in ;) |
| 1559 | - if (isset($incontext['member_id']) && isset($incontext['member_salt'])) |
|
| 1560 | - setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt'])); |
|
| 1642 | + if (isset($incontext['member_id']) && isset($incontext['member_salt'])) { |
|
| 1643 | + setLoginCookie(3153600 * 60, $incontext['member_id'], hash_salt($_POST['password1'], $incontext['member_salt'])); |
|
| 1644 | + } |
|
| 1561 | 1645 | |
| 1562 | 1646 | $result = $smcFunc['db_query']('', ' |
| 1563 | 1647 | SELECT value |
@@ -1568,13 +1652,14 @@ discard block |
||
| 1568 | 1652 | 'db_error_skip' => true, |
| 1569 | 1653 | ) |
| 1570 | 1654 | ); |
| 1571 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
| 1572 | - list ($db_sessions) = $smcFunc['db_fetch_row']($result); |
|
| 1655 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
| 1656 | + list ($db_sessions) = $smcFunc['db_fetch_row']($result); |
|
| 1657 | + } |
|
| 1573 | 1658 | $smcFunc['db_free_result']($result); |
| 1574 | 1659 | |
| 1575 | - if (empty($db_sessions)) |
|
| 1576 | - $_SESSION['admin_time'] = time(); |
|
| 1577 | - else |
|
| 1660 | + if (empty($db_sessions)) { |
|
| 1661 | + $_SESSION['admin_time'] = time(); |
|
| 1662 | + } else |
|
| 1578 | 1663 | { |
| 1579 | 1664 | $_SERVER['HTTP_USER_AGENT'] = substr($_SERVER['HTTP_USER_AGENT'], 0, 211); |
| 1580 | 1665 | |
@@ -1598,8 +1683,9 @@ discard block |
||
| 1598 | 1683 | $smcFunc['strtolower'] = $db_character_set != 'utf8' && $txt['lang_character_set'] != 'UTF-8' ? 'strtolower' : |
| 1599 | 1684 | function($string){ |
| 1600 | 1685 | global $sourcedir; |
| 1601 | - if (function_exists('mb_strtolower')) |
|
| 1602 | - return mb_strtolower($string, 'UTF-8'); |
|
| 1686 | + if (function_exists('mb_strtolower')) { |
|
| 1687 | + return mb_strtolower($string, 'UTF-8'); |
|
| 1688 | + } |
|
| 1603 | 1689 | require_once($sourcedir . '/Subs-Charset.php'); |
| 1604 | 1690 | return utf8_strtolower($string); |
| 1605 | 1691 | }; |
@@ -1615,8 +1701,9 @@ discard block |
||
| 1615 | 1701 | ) |
| 1616 | 1702 | ); |
| 1617 | 1703 | $context['utf8'] = $db_character_set === 'utf8' || $txt['lang_character_set'] === 'UTF-8'; |
| 1618 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
| 1619 | - updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject'])); |
|
| 1704 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
| 1705 | + updateStats('subject', 1, htmlspecialchars($txt['default_topic_subject'])); |
|
| 1706 | + } |
|
| 1620 | 1707 | $smcFunc['db_free_result']($request); |
| 1621 | 1708 | |
| 1622 | 1709 | // Now is the perfect time to fetch the SM files. |
@@ -1635,8 +1722,9 @@ discard block |
||
| 1635 | 1722 | |
| 1636 | 1723 | // Check if we need some stupid MySQL fix. |
| 1637 | 1724 | $server_version = $smcFunc['db_server_info'](); |
| 1638 | - if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) |
|
| 1639 | - updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
| 1725 | + if (($db_type == 'mysql' || $db_type == 'mysqli') && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) { |
|
| 1726 | + updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
| 1727 | + } |
|
| 1640 | 1728 | |
| 1641 | 1729 | // Some final context for the template. |
| 1642 | 1730 | $incontext['dir_still_writable'] = is_writable(dirname(__FILE__)) && substr(__FILE__, 1, 2) != ':\\'; |
@@ -1656,8 +1744,9 @@ discard block |
||
| 1656 | 1744 | $settingsArray = file(dirname(__FILE__) . '/Settings.php'); |
| 1657 | 1745 | |
| 1658 | 1746 | // @todo Do we just want to read the file in clean, and split it this way always? |
| 1659 | - if (count($settingsArray) == 1) |
|
| 1660 | - $settingsArray = preg_split('~[\r\n]~', $settingsArray[0]); |
|
| 1747 | + if (count($settingsArray) == 1) { |
|
| 1748 | + $settingsArray = preg_split('~[\r\n]~', $settingsArray[0]); |
|
| 1749 | + } |
|
| 1661 | 1750 | |
| 1662 | 1751 | for ($i = 0, $n = count($settingsArray); $i < $n; $i++) |
| 1663 | 1752 | { |
@@ -1672,19 +1761,22 @@ discard block |
||
| 1672 | 1761 | continue; |
| 1673 | 1762 | } |
| 1674 | 1763 | |
| 1675 | - if (trim($settingsArray[$i]) == '?' . '>') |
|
| 1676 | - $settingsArray[$i] = ''; |
|
| 1764 | + if (trim($settingsArray[$i]) == '?' . '>') { |
|
| 1765 | + $settingsArray[$i] = ''; |
|
| 1766 | + } |
|
| 1677 | 1767 | |
| 1678 | 1768 | // Don't trim or bother with it if it's not a variable. |
| 1679 | - if (substr($settingsArray[$i], 0, 1) != '$') |
|
| 1680 | - continue; |
|
| 1769 | + if (substr($settingsArray[$i], 0, 1) != '$') { |
|
| 1770 | + continue; |
|
| 1771 | + } |
|
| 1681 | 1772 | |
| 1682 | 1773 | $settingsArray[$i] = rtrim($settingsArray[$i]) . "\n"; |
| 1683 | 1774 | |
| 1684 | - foreach ($vars as $var => $val) |
|
| 1685 | - if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0) |
|
| 1775 | + foreach ($vars as $var => $val) { |
|
| 1776 | + if (strncasecmp($settingsArray[$i], '$' . $var, 1 + strlen($var)) == 0) |
|
| 1686 | 1777 | { |
| 1687 | 1778 | $comment = strstr($settingsArray[$i], '#'); |
| 1779 | + } |
|
| 1688 | 1780 | $settingsArray[$i] = '$' . $var . ' = \'' . $val . '\';' . ($comment != '' ? "\t\t" . $comment : "\n"); |
| 1689 | 1781 | unset($vars[$var]); |
| 1690 | 1782 | } |
@@ -1694,36 +1786,41 @@ discard block |
||
| 1694 | 1786 | if (!empty($vars)) |
| 1695 | 1787 | { |
| 1696 | 1788 | $settingsArray[$i++] = ''; |
| 1697 | - foreach ($vars as $var => $val) |
|
| 1698 | - $settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n"; |
|
| 1789 | + foreach ($vars as $var => $val) { |
|
| 1790 | + $settingsArray[$i++] = '$' . $var . ' = \'' . $val . '\';' . "\n"; |
|
| 1791 | + } |
|
| 1699 | 1792 | } |
| 1700 | 1793 | |
| 1701 | 1794 | // Blank out the file - done to fix a oddity with some servers. |
| 1702 | 1795 | $fp = @fopen(dirname(__FILE__) . '/Settings.php', 'w'); |
| 1703 | - if (!$fp) |
|
| 1704 | - return false; |
|
| 1796 | + if (!$fp) { |
|
| 1797 | + return false; |
|
| 1798 | + } |
|
| 1705 | 1799 | fclose($fp); |
| 1706 | 1800 | |
| 1707 | 1801 | $fp = fopen(dirname(__FILE__) . '/Settings.php', 'r+'); |
| 1708 | 1802 | |
| 1709 | 1803 | // Gotta have one of these ;) |
| 1710 | - if (trim($settingsArray[0]) != '<?php') |
|
| 1711 | - fwrite($fp, "<?php\n"); |
|
| 1804 | + if (trim($settingsArray[0]) != '<?php') { |
|
| 1805 | + fwrite($fp, "<?php\n"); |
|
| 1806 | + } |
|
| 1712 | 1807 | |
| 1713 | 1808 | $lines = count($settingsArray); |
| 1714 | 1809 | for ($i = 0; $i < $lines - 1; $i++) |
| 1715 | 1810 | { |
| 1716 | 1811 | // Don't just write a bunch of blank lines. |
| 1717 | - if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') |
|
| 1718 | - fwrite($fp, strtr($settingsArray[$i], "\r", '')); |
|
| 1812 | + if ($settingsArray[$i] != '' || @$settingsArray[$i - 1] != '') { |
|
| 1813 | + fwrite($fp, strtr($settingsArray[$i], "\r", '')); |
|
| 1814 | + } |
|
| 1719 | 1815 | } |
| 1720 | 1816 | fwrite($fp, $settingsArray[$i] . '?' . '>'); |
| 1721 | 1817 | fclose($fp); |
| 1722 | 1818 | |
| 1723 | 1819 | // Even though on normal installations the filemtime should prevent this being used by the installer incorrectly |
| 1724 | 1820 | // it seems that there are times it might not. So let's MAKE it dump the cache. |
| 1725 | - if (function_exists('opcache_invalidate')) |
|
| 1726 | - opcache_invalidate(dirname(__FILE__) . '/Settings.php', true); |
|
| 1821 | + if (function_exists('opcache_invalidate')) { |
|
| 1822 | + opcache_invalidate(dirname(__FILE__) . '/Settings.php', true); |
|
| 1823 | + } |
|
| 1727 | 1824 | |
| 1728 | 1825 | return true; |
| 1729 | 1826 | } |
@@ -1748,9 +1845,9 @@ discard block |
||
| 1748 | 1845 | SecFilterScanPOST Off |
| 1749 | 1846 | </IfModule>'; |
| 1750 | 1847 | |
| 1751 | - if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) |
|
| 1752 | - return true; |
|
| 1753 | - elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess')) |
|
| 1848 | + if (!function_exists('apache_get_modules') || !in_array('mod_security', apache_get_modules())) { |
|
| 1849 | + return true; |
|
| 1850 | + } elseif (file_exists(dirname(__FILE__) . '/.htaccess') && is_writable(dirname(__FILE__) . '/.htaccess')) |
|
| 1754 | 1851 | { |
| 1755 | 1852 | $current_htaccess = implode('', file(dirname(__FILE__) . '/.htaccess')); |
| 1756 | 1853 | |
@@ -1762,29 +1859,28 @@ discard block |
||
| 1762 | 1859 | fwrite($ht_handle, $htaccess_addition); |
| 1763 | 1860 | fclose($ht_handle); |
| 1764 | 1861 | return true; |
| 1862 | + } else { |
|
| 1863 | + return false; |
|
| 1765 | 1864 | } |
| 1766 | - else |
|
| 1767 | - return false; |
|
| 1865 | + } else { |
|
| 1866 | + return true; |
|
| 1768 | 1867 | } |
| 1769 | - else |
|
| 1770 | - return true; |
|
| 1771 | - } |
|
| 1772 | - elseif (file_exists(dirname(__FILE__) . '/.htaccess')) |
|
| 1773 | - return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false; |
|
| 1774 | - elseif (is_writable(dirname(__FILE__))) |
|
| 1868 | + } elseif (file_exists(dirname(__FILE__) . '/.htaccess')) { |
|
| 1869 | + return strpos(implode('', file(dirname(__FILE__) . '/.htaccess')), '<IfModule mod_security.c>') !== false; |
|
| 1870 | + } elseif (is_writable(dirname(__FILE__))) |
|
| 1775 | 1871 | { |
| 1776 | 1872 | if ($ht_handle = fopen(dirname(__FILE__) . '/.htaccess', 'w')) |
| 1777 | 1873 | { |
| 1778 | 1874 | fwrite($ht_handle, $htaccess_addition); |
| 1779 | 1875 | fclose($ht_handle); |
| 1780 | 1876 | return true; |
| 1877 | + } else { |
|
| 1878 | + return false; |
|
| 1781 | 1879 | } |
| 1782 | - else |
|
| 1880 | + } else { |
|
| 1783 | 1881 | return false; |
| 1784 | 1882 | } |
| 1785 | - else |
|
| 1786 | - return false; |
|
| 1787 | -} |
|
| 1883 | + } |
|
| 1788 | 1884 | |
| 1789 | 1885 | function template_install_above() |
| 1790 | 1886 | { |
@@ -1822,9 +1918,10 @@ discard block |
||
| 1822 | 1918 | <label for="installer_language">', $txt['installer_language'], ':</label> |
| 1823 | 1919 | <select id="installer_language" name="lang_file" onchange="location.href = \'', $installurl, '?lang_file=\' + this.options[this.selectedIndex].value;">'; |
| 1824 | 1920 | |
| 1825 | - foreach ($incontext['detected_languages'] as $lang => $name) |
|
| 1826 | - echo ' |
|
| 1921 | + foreach ($incontext['detected_languages'] as $lang => $name) { |
|
| 1922 | + echo ' |
|
| 1827 | 1923 | <option', isset($_SESSION['installer_temp_lang']) && $_SESSION['installer_temp_lang'] == $lang ? ' selected' : '', ' value="', $lang, '">', $name, '</option>'; |
| 1924 | + } |
|
| 1828 | 1925 | |
| 1829 | 1926 | echo ' |
| 1830 | 1927 | </select> |
@@ -1844,9 +1941,10 @@ discard block |
||
| 1844 | 1941 | <h2>', $txt['upgrade_progress'], '</h2> |
| 1845 | 1942 | <ul>'; |
| 1846 | 1943 | |
| 1847 | - foreach ($incontext['steps'] as $num => $step) |
|
| 1848 | - echo ' |
|
| 1944 | + foreach ($incontext['steps'] as $num => $step) { |
|
| 1945 | + echo ' |
|
| 1849 | 1946 | <li class="', $num < $incontext['current_step'] ? 'stepdone' : ($num == $incontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>'; |
| 1947 | + } |
|
| 1850 | 1948 | |
| 1851 | 1949 | echo ' |
| 1852 | 1950 | </ul> |
@@ -1871,20 +1969,23 @@ discard block |
||
| 1871 | 1969 | echo ' |
| 1872 | 1970 | <div>'; |
| 1873 | 1971 | |
| 1874 | - if (!empty($incontext['continue'])) |
|
| 1875 | - echo ' |
|
| 1972 | + if (!empty($incontext['continue'])) { |
|
| 1973 | + echo ' |
|
| 1876 | 1974 | <input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '" onclick="return submitThisOnce(this);" class="button_submit" />'; |
| 1877 | - if (!empty($incontext['skip'])) |
|
| 1878 | - echo ' |
|
| 1975 | + } |
|
| 1976 | + if (!empty($incontext['skip'])) { |
|
| 1977 | + echo ' |
|
| 1879 | 1978 | <input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="return submitThisOnce(this);" class="button_submit" />'; |
| 1979 | + } |
|
| 1880 | 1980 | echo ' |
| 1881 | 1981 | </div>'; |
| 1882 | 1982 | } |
| 1883 | 1983 | |
| 1884 | 1984 | // Show the closing form tag and other data only if not in the last step |
| 1885 | - if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) |
|
| 1886 | - echo ' |
|
| 1985 | + if (count($incontext['steps']) - 1 !== (int) $incontext['current_step']) { |
|
| 1986 | + echo ' |
|
| 1887 | 1987 | </form>'; |
| 1988 | + } |
|
| 1888 | 1989 | |
| 1889 | 1990 | echo ' |
| 1890 | 1991 | </div> |
@@ -1919,13 +2020,15 @@ discard block |
||
| 1919 | 2020 | </div>'; |
| 1920 | 2021 | |
| 1921 | 2022 | // Show the warnings, or not. |
| 1922 | - if (template_warning_divs()) |
|
| 1923 | - echo ' |
|
| 2023 | + if (template_warning_divs()) { |
|
| 2024 | + echo ' |
|
| 1924 | 2025 | <h3>', $txt['install_all_lovely'], '</h3>'; |
| 2026 | + } |
|
| 1925 | 2027 | |
| 1926 | 2028 | // Say we want the continue button! |
| 1927 | - if (empty($incontext['error'])) |
|
| 1928 | - $incontext['continue'] = 1; |
|
| 2029 | + if (empty($incontext['error'])) { |
|
| 2030 | + $incontext['continue'] = 1; |
|
| 2031 | + } |
|
| 1929 | 2032 | |
| 1930 | 2033 | // For the latest version stuff. |
| 1931 | 2034 | echo ' |
@@ -1959,8 +2062,8 @@ discard block |
||
| 1959 | 2062 | global $txt, $incontext; |
| 1960 | 2063 | |
| 1961 | 2064 | // Errors are very serious.. |
| 1962 | - if (!empty($incontext['error'])) |
|
| 1963 | - echo ' |
|
| 2065 | + if (!empty($incontext['error'])) { |
|
| 2066 | + echo ' |
|
| 1964 | 2067 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
| 1965 | 2068 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
| 1966 | 2069 | <strong style="text-decoration: underline;">', $txt['upgrade_critical_error'], '</strong><br> |
@@ -1968,9 +2071,10 @@ discard block |
||
| 1968 | 2071 | ', $incontext['error'], ' |
| 1969 | 2072 | </div> |
| 1970 | 2073 | </div>'; |
| 2074 | + } |
|
| 1971 | 2075 | // A warning message? |
| 1972 | - elseif (!empty($incontext['warning'])) |
|
| 1973 | - echo ' |
|
| 2076 | + elseif (!empty($incontext['warning'])) { |
|
| 2077 | + echo ' |
|
| 1974 | 2078 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
| 1975 | 2079 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
| 1976 | 2080 | <strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br> |
@@ -1978,6 +2082,7 @@ discard block |
||
| 1978 | 2082 | ', $incontext['warning'], ' |
| 1979 | 2083 | </div> |
| 1980 | 2084 | </div>'; |
| 2085 | + } |
|
| 1981 | 2086 | |
| 1982 | 2087 | return empty($incontext['error']) && empty($incontext['warning']); |
| 1983 | 2088 | } |
@@ -1993,27 +2098,30 @@ discard block |
||
| 1993 | 2098 | <li>', $incontext['failed_files']), '</li> |
| 1994 | 2099 | </ul>'; |
| 1995 | 2100 | |
| 1996 | - if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') |
|
| 1997 | - echo ' |
|
| 2101 | + if (isset($incontext['systemos'], $incontext['detected_path']) && $incontext['systemos'] == 'linux') { |
|
| 2102 | + echo ' |
|
| 1998 | 2103 | <hr> |
| 1999 | 2104 | <p>', $txt['chmod_linux_info'], '</p> |
| 2000 | 2105 | <tt># chmod a+w ', implode(' ' . $incontext['detected_path'] . '/', $incontext['failed_files']), '</tt>'; |
| 2106 | + } |
|
| 2001 | 2107 | |
| 2002 | 2108 | // This is serious! |
| 2003 | - if (!template_warning_divs()) |
|
| 2004 | - return; |
|
| 2109 | + if (!template_warning_divs()) { |
|
| 2110 | + return; |
|
| 2111 | + } |
|
| 2005 | 2112 | |
| 2006 | 2113 | echo ' |
| 2007 | 2114 | <hr> |
| 2008 | 2115 | <p>', $txt['ftp_setup_info'], '</p>'; |
| 2009 | 2116 | |
| 2010 | - if (!empty($incontext['ftp_errors'])) |
|
| 2011 | - echo ' |
|
| 2117 | + if (!empty($incontext['ftp_errors'])) { |
|
| 2118 | + echo ' |
|
| 2012 | 2119 | <div class="error_message"> |
| 2013 | 2120 | ', $txt['error_ftp_no_connect'], '<br><br> |
| 2014 | 2121 | <code>', implode('<br>', $incontext['ftp_errors']), '</code> |
| 2015 | 2122 | </div> |
| 2016 | 2123 | <br>'; |
| 2124 | + } |
|
| 2017 | 2125 | |
| 2018 | 2126 | echo ' |
| 2019 | 2127 | <form action="', $incontext['form_url'], '" method="post"> |
@@ -2073,17 +2181,17 @@ discard block |
||
| 2073 | 2181 | <td> |
| 2074 | 2182 | <select name="db_type" id="db_type_input" onchange="toggleDBInput();">'; |
| 2075 | 2183 | |
| 2076 | - foreach ($incontext['supported_databases'] as $key => $db) |
|
| 2077 | - echo ' |
|
| 2184 | + foreach ($incontext['supported_databases'] as $key => $db) { |
|
| 2185 | + echo ' |
|
| 2078 | 2186 | <option value="', $key, '"', isset($_POST['db_type']) && $_POST['db_type'] == $key ? ' selected' : '', '>', $db['name'], '</option>'; |
| 2187 | + } |
|
| 2079 | 2188 | |
| 2080 | 2189 | echo ' |
| 2081 | 2190 | </select> |
| 2082 | 2191 | <div class="smalltext block">', $txt['db_settings_type_info'], '</div> |
| 2083 | 2192 | </td> |
| 2084 | 2193 | </tr>'; |
| 2085 | - } |
|
| 2086 | - else |
|
| 2194 | + } else |
|
| 2087 | 2195 | { |
| 2088 | 2196 | echo ' |
| 2089 | 2197 | <tr style="display: none;"> |
@@ -2275,9 +2383,10 @@ discard block |
||
| 2275 | 2383 | <div style="color: red;">', $txt['error_db_queries'], '</div> |
| 2276 | 2384 | <ul>'; |
| 2277 | 2385 | |
| 2278 | - foreach ($incontext['failures'] as $line => $fail) |
|
| 2279 | - echo ' |
|
| 2386 | + foreach ($incontext['failures'] as $line => $fail) { |
|
| 2387 | + echo ' |
|
| 2280 | 2388 | <li><strong>', $txt['error_db_queries_line'], $line + 1, ':</strong> ', nl2br(htmlspecialchars($fail)), '</li>'; |
| 2389 | + } |
|
| 2281 | 2390 | |
| 2282 | 2391 | echo ' |
| 2283 | 2392 | </ul>'; |
@@ -2338,15 +2447,16 @@ discard block |
||
| 2338 | 2447 | </tr> |
| 2339 | 2448 | </table>'; |
| 2340 | 2449 | |
| 2341 | - if ($incontext['require_db_confirm']) |
|
| 2342 | - echo ' |
|
| 2450 | + if ($incontext['require_db_confirm']) { |
|
| 2451 | + echo ' |
|
| 2343 | 2452 | <h2>', $txt['user_settings_database'], '</h2> |
| 2344 | 2453 | <p>', $txt['user_settings_database_info'], '</p> |
| 2345 | 2454 | |
| 2346 | 2455 | <div style="margin-bottom: 2ex; padding-', $txt['lang_rtl'] == false ? 'left' : 'right', ': 50px;"> |
| 2347 | 2456 | <input type="password" name="password3" size="30" class="input_password" /> |
| 2348 | 2457 | </div>'; |
| 2349 | -} |
|
| 2458 | + } |
|
| 2459 | + } |
|
| 2350 | 2460 | |
| 2351 | 2461 | // Tell them it's done, and to delete. |
| 2352 | 2462 | function template_delete_install() |
@@ -2359,14 +2469,15 @@ discard block |
||
| 2359 | 2469 | template_warning_divs(); |
| 2360 | 2470 | |
| 2361 | 2471 | // Install directory still writable? |
| 2362 | - if ($incontext['dir_still_writable']) |
|
| 2363 | - echo ' |
|
| 2472 | + if ($incontext['dir_still_writable']) { |
|
| 2473 | + echo ' |
|
| 2364 | 2474 | <em>', $txt['still_writable'], '</em><br> |
| 2365 | 2475 | <br>'; |
| 2476 | + } |
|
| 2366 | 2477 | |
| 2367 | 2478 | // Don't show the box if it's like 99% sure it won't work :P. |
| 2368 | - if ($incontext['probably_delete_install']) |
|
| 2369 | - echo ' |
|
| 2479 | + if ($incontext['probably_delete_install']) { |
|
| 2480 | + echo ' |
|
| 2370 | 2481 | <div style="margin: 1ex; font-weight: bold;"> |
| 2371 | 2482 | <label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete();" class="input_check" /> ', $txt['delete_installer'], !isset($_SESSION['installer_temp_ftp']) ? ' ' . $txt['delete_installer_maybe'] : '', '</label> |
| 2372 | 2483 | </div> |
@@ -2382,6 +2493,7 @@ discard block |
||
| 2382 | 2493 | } |
| 2383 | 2494 | </script> |
| 2384 | 2495 | <br>'; |
| 2496 | + } |
|
| 2385 | 2497 | |
| 2386 | 2498 | echo ' |
| 2387 | 2499 | ', sprintf($txt['go_to_your_forum'], $boardurl . '/index.php'), '<br> |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 3 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * This is the main function for the languages area. |
@@ -153,11 +154,11 @@ discard block |
||
| 153 | 154 | $language_list = new xmlArray(fetch_web_data($url), true); |
| 154 | 155 | |
| 155 | 156 | // Check that the site responded and that the language exists. |
| 156 | - if (!$language_list->exists('languages')) |
|
| 157 | - $context['smf_error'] = 'no_response'; |
|
| 158 | - elseif (!$language_list->exists('languages/language')) |
|
| 159 | - $context['smf_error'] = 'no_files'; |
|
| 160 | - else |
|
| 157 | + if (!$language_list->exists('languages')) { |
|
| 158 | + $context['smf_error'] = 'no_response'; |
|
| 159 | + } elseif (!$language_list->exists('languages/language')) { |
|
| 160 | + $context['smf_error'] = 'no_files'; |
|
| 161 | + } else |
|
| 161 | 162 | { |
| 162 | 163 | $language_list = $language_list->path('languages[0]'); |
| 163 | 164 | $lang_files = $language_list->set('language'); |
@@ -165,8 +166,9 @@ discard block |
||
| 165 | 166 | foreach ($lang_files as $file) |
| 166 | 167 | { |
| 167 | 168 | // Were we searching? |
| 168 | - if (!empty($context['smf_search_term']) && strpos($file->fetch('name'), $smcFunc['strtolower']($context['smf_search_term'])) === false) |
|
| 169 | - continue; |
|
| 169 | + if (!empty($context['smf_search_term']) && strpos($file->fetch('name'), $smcFunc['strtolower']($context['smf_search_term'])) === false) { |
|
| 170 | + continue; |
|
| 171 | + } |
|
| 170 | 172 | |
| 171 | 173 | $smf_languages[] = array( |
| 172 | 174 | 'id' => $file->fetch('id'), |
@@ -177,10 +179,11 @@ discard block |
||
| 177 | 179 | 'install_link' => '<a href="' . $scripturl . '?action=admin;area=languages;sa=downloadlang;did=' . $file->fetch('id') . ';' . $context['session_var'] . '=' . $context['session_id'] . '">' . $txt['add_language_smf_install'] . '</a>', |
| 178 | 180 | ); |
| 179 | 181 | } |
| 180 | - if (empty($smf_languages)) |
|
| 181 | - $context['smf_error'] = 'no_files'; |
|
| 182 | - else |
|
| 183 | - return $smf_languages; |
|
| 182 | + if (empty($smf_languages)) { |
|
| 183 | + $context['smf_error'] = 'no_files'; |
|
| 184 | + } else { |
|
| 185 | + return $smf_languages; |
|
| 186 | + } |
|
| 184 | 187 | } |
| 185 | 188 | } |
| 186 | 189 | |
@@ -202,8 +205,9 @@ discard block |
||
| 202 | 205 | require_once($sourcedir . '/Subs-Package.php'); |
| 203 | 206 | |
| 204 | 207 | // Clearly we need to know what to request. |
| 205 | - if (!isset($_GET['did'])) |
|
| 206 | - fatal_lang_error('no_access', false); |
|
| 208 | + if (!isset($_GET['did'])) { |
|
| 209 | + fatal_lang_error('no_access', false); |
|
| 210 | + } |
|
| 207 | 211 | |
| 208 | 212 | // Some lovely context. |
| 209 | 213 | $context['download_id'] = $_GET['did']; |
@@ -223,8 +227,9 @@ discard block |
||
| 223 | 227 | foreach ($_POST['copy_file'] as $file) |
| 224 | 228 | { |
| 225 | 229 | // Check it's not very bad. |
| 226 | - if (strpos($file, '..') !== false || (strpos($file, 'Themes') !== 0 && !preg_match('~agreement\.[A-Za-z-_0-9]+\.txt$~', $file))) |
|
| 227 | - fatal_error($txt['languages_download_illegal_paths']); |
|
| 230 | + if (strpos($file, '..') !== false || (strpos($file, 'Themes') !== 0 && !preg_match('~agreement\.[A-Za-z-_0-9]+\.txt$~', $file))) { |
|
| 231 | + fatal_error($txt['languages_download_illegal_paths']); |
|
| 232 | + } |
|
| 228 | 233 | |
| 229 | 234 | $chmod_files[] = $boarddir . '/' . $file; |
| 230 | 235 | $install_files[] = $file; |
@@ -235,8 +240,9 @@ discard block |
||
| 235 | 240 | $files_left = $file_status['files']['notwritable']; |
| 236 | 241 | |
| 237 | 242 | // Something not writable? |
| 238 | - if (!empty($files_left)) |
|
| 239 | - $context['error_message'] = $txt['languages_download_not_chmod']; |
|
| 243 | + if (!empty($files_left)) { |
|
| 244 | + $context['error_message'] = $txt['languages_download_not_chmod']; |
|
| 245 | + } |
|
| 240 | 246 | // Otherwise, go go go! |
| 241 | 247 | elseif (!empty($install_files)) |
| 242 | 248 | { |
@@ -251,11 +257,13 @@ discard block |
||
| 251 | 257 | } |
| 252 | 258 | |
| 253 | 259 | // Open up the old china. |
| 254 | - if (!isset($archive_content)) |
|
| 255 | - $archive_content = read_tgz_file('https://download.simplemachines.org/fetch_language.php?version=' . urlencode(strtr($forum_version, array('SMF ' => ''))) . ';fetch=' . urlencode($_GET['did']), null); |
|
| 260 | + if (!isset($archive_content)) { |
|
| 261 | + $archive_content = read_tgz_file('https://download.simplemachines.org/fetch_language.php?version=' . urlencode(strtr($forum_version, array('SMF ' => ''))) . ';fetch=' . urlencode($_GET['did']), null); |
|
| 262 | + } |
|
| 256 | 263 | |
| 257 | - if (empty($archive_content)) |
|
| 258 | - fatal_error($txt['add_language_error_no_response']); |
|
| 264 | + if (empty($archive_content)) { |
|
| 265 | + fatal_error($txt['add_language_error_no_response']); |
|
| 266 | + } |
|
| 259 | 267 | |
| 260 | 268 | // Now for each of the files, let's do some *stuff* |
| 261 | 269 | $context['files'] = array( |
@@ -270,8 +278,9 @@ discard block |
||
| 270 | 278 | $extension = substr($filename, strrpos($filename, '.') + 1); |
| 271 | 279 | |
| 272 | 280 | // Don't do anything with files we don't understand. |
| 273 | - if (!in_array($extension, array('php', 'jpg', 'gif', 'jpeg', 'png', 'txt'))) |
|
| 274 | - continue; |
|
| 281 | + if (!in_array($extension, array('php', 'jpg', 'gif', 'jpeg', 'png', 'txt'))) { |
|
| 282 | + continue; |
|
| 283 | + } |
|
| 275 | 284 | |
| 276 | 285 | // Basic data. |
| 277 | 286 | $context_data = array( |
@@ -290,8 +299,9 @@ discard block |
||
| 290 | 299 | // Does the file exist, is it different and can we overwrite? |
| 291 | 300 | if (file_exists($boarddir . '/' . $file['filename'])) |
| 292 | 301 | { |
| 293 | - if (is_writable($boarddir . '/' . $file['filename'])) |
|
| 294 | - $context_data['writable'] = true; |
|
| 302 | + if (is_writable($boarddir . '/' . $file['filename'])) { |
|
| 303 | + $context_data['writable'] = true; |
|
| 304 | + } |
|
| 295 | 305 | |
| 296 | 306 | // Finally, do we actually think the content has changed? |
| 297 | 307 | if ($file['size'] == filesize($boarddir . '/' . $file['filename']) && $file['md5'] == md5_file($boarddir . '/' . $file['filename'])) |
@@ -304,16 +314,17 @@ discard block |
||
| 304 | 314 | { |
| 305 | 315 | $context_data['exists'] = 'same'; |
| 306 | 316 | $context_data['default_copy'] = false; |
| 317 | + } else { |
|
| 318 | + $context_data['exists'] = 'different'; |
|
| 307 | 319 | } |
| 308 | - else |
|
| 309 | - $context_data['exists'] = 'different'; |
|
| 310 | 320 | } |
| 311 | 321 | // No overwrite? |
| 312 | 322 | else |
| 313 | 323 | { |
| 314 | 324 | // Can we at least stick it in the directory... |
| 315 | - if (is_writable($boarddir . '/' . $dirname)) |
|
| 316 | - $context_data['writable'] = true; |
|
| 325 | + if (is_writable($boarddir . '/' . $dirname)) { |
|
| 326 | + $context_data['writable'] = true; |
|
| 327 | + } |
|
| 317 | 328 | } |
| 318 | 329 | |
| 319 | 330 | // I love PHP files, that's why I'm a developer and not an artistic type spending my time drinking absinth and living a life of sin... |
@@ -328,8 +339,9 @@ discard block |
||
| 328 | 339 | list ($name, $language) = explode('.', $filename); |
| 329 | 340 | |
| 330 | 341 | // Let's get the new version, I like versions, they tell me that I'm up to date. |
| 331 | - if (preg_match('~\s*Version:\s+(.+?);\s*' . preg_quote($name, '~') . '~i', $file['preview'], $match) == 1) |
|
| 332 | - $context_data['version'] = $match[1]; |
|
| 342 | + if (preg_match('~\s*Version:\s+(.+?);\s*' . preg_quote($name, '~') . '~i', $file['preview'], $match) == 1) { |
|
| 343 | + $context_data['version'] = $match[1]; |
|
| 344 | + } |
|
| 333 | 345 | |
| 334 | 346 | // Now does the old file exist - if so what is it's version? |
| 335 | 347 | if (file_exists($boarddir . '/' . $file['filename'])) |
@@ -345,34 +357,35 @@ discard block |
||
| 345 | 357 | $context_data['cur_version'] = $match[1]; |
| 346 | 358 | |
| 347 | 359 | // How does this compare? |
| 348 | - if ($context_data['cur_version'] == $context_data['version']) |
|
| 349 | - $context_data['version_compare'] = 'same'; |
|
| 350 | - elseif ($context_data['cur_version'] > $context_data['version']) |
|
| 351 | - $context_data['version_compare'] = 'older'; |
|
| 360 | + if ($context_data['cur_version'] == $context_data['version']) { |
|
| 361 | + $context_data['version_compare'] = 'same'; |
|
| 362 | + } elseif ($context_data['cur_version'] > $context_data['version']) { |
|
| 363 | + $context_data['version_compare'] = 'older'; |
|
| 364 | + } |
|
| 352 | 365 | |
| 353 | 366 | // Don't recommend copying if the version is the same. |
| 354 | - if ($context_data['version_compare'] != 'newer') |
|
| 355 | - $context_data['default_copy'] = false; |
|
| 367 | + if ($context_data['version_compare'] != 'newer') { |
|
| 368 | + $context_data['default_copy'] = false; |
|
| 369 | + } |
|
| 356 | 370 | } |
| 357 | 371 | } |
| 358 | 372 | |
| 359 | 373 | // Add the context data to the main set. |
| 360 | 374 | $context['files']['lang'][] = $context_data; |
| 361 | - } |
|
| 362 | - elseif ($extension == '.txt' && stripos($filename, 'agreement') !== false) |
|
| 375 | + } elseif ($extension == '.txt' && stripos($filename, 'agreement') !== false) |
|
| 363 | 376 | { |
| 364 | 377 | // Registration agreement is a primary file |
| 365 | 378 | $context['files']['lang'][] = $context_data; |
| 366 | - } |
|
| 367 | - else |
|
| 379 | + } else |
|
| 368 | 380 | { |
| 369 | 381 | // There shouldn't be anything else, but load this into "other" in case we decide to handle it in the future |
| 370 | 382 | $context['files']['other'][] = $context_data; |
| 371 | 383 | } |
| 372 | 384 | |
| 373 | 385 | // Collect together all non-writable areas. |
| 374 | - if (!$context_data['writable']) |
|
| 375 | - $context['make_writable'][] = $context_data['destination']; |
|
| 386 | + if (!$context_data['writable']) { |
|
| 387 | + $context['make_writable'][] = $context_data['destination']; |
|
| 388 | + } |
|
| 376 | 389 | } |
| 377 | 390 | |
| 378 | 391 | // Before we go to far can we make anything writable, eh, eh? |
@@ -387,22 +400,24 @@ discard block |
||
| 387 | 400 | { |
| 388 | 401 | if ($type == 'lang') |
| 389 | 402 | { |
| 390 | - foreach ($data as $k => $file) |
|
| 391 | - if (!$file['writable'] && !in_array($file['destination'], $context['still_not_writable'])) |
|
| 403 | + foreach ($data as $k => $file) { |
|
| 404 | + if (!$file['writable'] && !in_array($file['destination'], $context['still_not_writable'])) |
|
| 392 | 405 | $context['files'][$type][$k]['writable'] = true; |
| 393 | - } |
|
| 394 | - else |
|
| 406 | + } |
|
| 407 | + } else |
|
| 395 | 408 | { |
| 396 | - foreach ($data as $theme => $files) |
|
| 397 | - foreach ($files as $k => $file) |
|
| 409 | + foreach ($data as $theme => $files) { |
|
| 410 | + foreach ($files as $k => $file) |
|
| 398 | 411 | if (!$file['writable'] && !in_array($file['destination'], $context['still_not_writable'])) |
| 399 | 412 | $context['files'][$type][$theme][$k]['writable'] = true; |
| 413 | + } |
|
| 400 | 414 | } |
| 401 | 415 | } |
| 402 | 416 | |
| 403 | 417 | // Are we going to need more language stuff? |
| 404 | - if (!empty($context['still_not_writable'])) |
|
| 405 | - loadLanguage('Packages'); |
|
| 418 | + if (!empty($context['still_not_writable'])) { |
|
| 419 | + loadLanguage('Packages'); |
|
| 420 | + } |
|
| 406 | 421 | } |
| 407 | 422 | |
| 408 | 423 | // This is the list for the main files. |
@@ -615,12 +630,13 @@ discard block |
||
| 615 | 630 | highlightSelected("list_language_list_' . ($language == '' ? 'english' : $language) . '");', true); |
| 616 | 631 | |
| 617 | 632 | // Display a warning if we cannot edit the default setting. |
| 618 | - if (!is_writable($boarddir . '/Settings.php')) |
|
| 619 | - $listOptions['additional_rows'][] = array( |
|
| 633 | + if (!is_writable($boarddir . '/Settings.php')) { |
|
| 634 | + $listOptions['additional_rows'][] = array( |
|
| 620 | 635 | 'position' => 'after_title', |
| 621 | 636 | 'value' => $txt['language_settings_writable'], |
| 622 | 637 | 'class' => 'smalltext alert', |
| 623 | 638 | ); |
| 639 | + } |
|
| 624 | 640 | |
| 625 | 641 | require_once($sourcedir . '/Subs-List.php'); |
| 626 | 642 | createList($listOptions); |
@@ -662,10 +678,11 @@ discard block |
||
| 662 | 678 | |
| 663 | 679 | // Put them back. |
| 664 | 680 | $settings['actual_theme_dir'] = $backup_actual_theme_dir; |
| 665 | - if (!empty($backup_base_theme_dir)) |
|
| 666 | - $settings['base_theme_dir'] = $backup_base_theme_dir; |
|
| 667 | - else |
|
| 668 | - unset($settings['base_theme_dir']); |
|
| 681 | + if (!empty($backup_base_theme_dir)) { |
|
| 682 | + $settings['base_theme_dir'] = $backup_base_theme_dir; |
|
| 683 | + } else { |
|
| 684 | + unset($settings['base_theme_dir']); |
|
| 685 | + } |
|
| 669 | 686 | |
| 670 | 687 | // Get the language files and data... |
| 671 | 688 | foreach ($context['languages'] as $lang) |
@@ -694,13 +711,15 @@ discard block |
||
| 694 | 711 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 695 | 712 | { |
| 696 | 713 | // Default? |
| 697 | - if (empty($row['lngfile']) || !isset($languages[$row['lngfile']])) |
|
| 698 | - $row['lngfile'] = $language; |
|
| 714 | + if (empty($row['lngfile']) || !isset($languages[$row['lngfile']])) { |
|
| 715 | + $row['lngfile'] = $language; |
|
| 716 | + } |
|
| 699 | 717 | |
| 700 | - if (!isset($languages[$row['lngfile']]) && isset($languages['english'])) |
|
| 701 | - $languages['english']['count'] += $row['num_users']; |
|
| 702 | - elseif (isset($languages[$row['lngfile']])) |
|
| 703 | - $languages[$row['lngfile']]['count'] += $row['num_users']; |
|
| 718 | + if (!isset($languages[$row['lngfile']]) && isset($languages['english'])) { |
|
| 719 | + $languages['english']['count'] += $row['num_users']; |
|
| 720 | + } elseif (isset($languages[$row['lngfile']])) { |
|
| 721 | + $languages[$row['lngfile']]['count'] += $row['num_users']; |
|
| 722 | + } |
|
| 704 | 723 | } |
| 705 | 724 | $smcFunc['db_free_result']($request); |
| 706 | 725 | |
@@ -740,13 +759,15 @@ discard block |
||
| 740 | 759 | |
| 741 | 760 | call_integration_hook('integrate_language_settings', array(&$config_vars)); |
| 742 | 761 | |
| 743 | - if ($return_config) |
|
| 744 | - return $config_vars; |
|
| 762 | + if ($return_config) { |
|
| 763 | + return $config_vars; |
|
| 764 | + } |
|
| 745 | 765 | |
| 746 | 766 | // Get our languages. No cache |
| 747 | 767 | getLanguages(false); |
| 748 | - foreach ($context['languages'] as $lang) |
|
| 749 | - $config_vars['language'][4][$lang['filename']] = array($lang['filename'], $lang['name']); |
|
| 768 | + foreach ($context['languages'] as $lang) { |
|
| 769 | + $config_vars['language'][4][$lang['filename']] = array($lang['filename'], $lang['name']); |
|
| 770 | + } |
|
| 750 | 771 | |
| 751 | 772 | // Saving settings? |
| 752 | 773 | if (isset($_REQUEST['save'])) |
@@ -756,8 +777,9 @@ discard block |
||
| 756 | 777 | call_integration_hook('integrate_save_language_settings', array(&$config_vars)); |
| 757 | 778 | |
| 758 | 779 | saveSettings($config_vars); |
| 759 | - if (!$settings_not_writable && !$settings_backup_fail) |
|
| 760 | - $_SESSION['adm-save'] = true; |
|
| 780 | + if (!$settings_not_writable && !$settings_backup_fail) { |
|
| 781 | + $_SESSION['adm-save'] = true; |
|
| 782 | + } |
|
| 761 | 783 | redirectexit('action=admin;area=languages;sa=settings'); |
| 762 | 784 | } |
| 763 | 785 | |
@@ -766,10 +788,11 @@ discard block |
||
| 766 | 788 | $context['settings_title'] = $txt['language_settings']; |
| 767 | 789 | $context['save_disabled'] = $settings_not_writable; |
| 768 | 790 | |
| 769 | - if ($settings_not_writable) |
|
| 770 | - $context['settings_message'] = '<div class="centertext"><strong>' . $txt['settings_not_writable'] . '</strong></div><br>'; |
|
| 771 | - elseif ($settings_backup_fail) |
|
| 772 | - $context['settings_message'] = '<div class="centertext"><strong>' . $txt['admin_backup_fail'] . '</strong></div><br>'; |
|
| 791 | + if ($settings_not_writable) { |
|
| 792 | + $context['settings_message'] = '<div class="centertext"><strong>' . $txt['settings_not_writable'] . '</strong></div><br>'; |
|
| 793 | + } elseif ($settings_backup_fail) { |
|
| 794 | + $context['settings_message'] = '<div class="centertext"><strong>' . $txt['admin_backup_fail'] . '</strong></div><br>'; |
|
| 795 | + } |
|
| 773 | 796 | |
| 774 | 797 | // Fill the config array. |
| 775 | 798 | prepareServerSettingsContext($config_vars); |
@@ -816,8 +839,9 @@ discard block |
||
| 816 | 839 | 'theme_dir' => $settings['default_theme_dir'], |
| 817 | 840 | ), |
| 818 | 841 | ); |
| 819 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 820 | - $themes[$row['id_theme']][$row['variable']] = $row['value']; |
|
| 842 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 843 | + $themes[$row['id_theme']][$row['variable']] = $row['value']; |
|
| 844 | + } |
|
| 821 | 845 | $smcFunc['db_free_result']($request); |
| 822 | 846 | |
| 823 | 847 | // This will be where we look |
@@ -829,14 +853,16 @@ discard block |
||
| 829 | 853 | // Check we have themes with a path and a name - just in case - and add the path. |
| 830 | 854 | foreach ($themes as $id => $data) |
| 831 | 855 | { |
| 832 | - if (count($data) != 2) |
|
| 833 | - unset($themes[$id]); |
|
| 834 | - elseif (is_dir($data['theme_dir'] . '/languages')) |
|
| 835 | - $lang_dirs[$id] = $data['theme_dir'] . '/languages'; |
|
| 856 | + if (count($data) != 2) { |
|
| 857 | + unset($themes[$id]); |
|
| 858 | + } elseif (is_dir($data['theme_dir'] . '/languages')) { |
|
| 859 | + $lang_dirs[$id] = $data['theme_dir'] . '/languages'; |
|
| 860 | + } |
|
| 836 | 861 | |
| 837 | 862 | // How about image directories? |
| 838 | - if (is_dir($data['theme_dir'] . '/images/' . $context['lang_id'])) |
|
| 839 | - $images_dirs[$id] = $data['theme_dir'] . '/images/' . $context['lang_id']; |
|
| 863 | + if (is_dir($data['theme_dir'] . '/images/' . $context['lang_id'])) { |
|
| 864 | + $images_dirs[$id] = $data['theme_dir'] . '/images/' . $context['lang_id']; |
|
| 865 | + } |
|
| 840 | 866 | } |
| 841 | 867 | |
| 842 | 868 | $current_file = $file_id ? $lang_dirs[$theme_id] . '/' . $file_id . '.' . $context['lang_id'] . '.php' : ''; |
@@ -850,15 +876,17 @@ discard block |
||
| 850 | 876 | while ($entry = $dir->read()) |
| 851 | 877 | { |
| 852 | 878 | // We're only after the files for this language. |
| 853 | - if (preg_match('~^([A-Za-z]+)\.' . $context['lang_id'] . '\.php$~', $entry, $matches) == 0) |
|
| 854 | - continue; |
|
| 879 | + if (preg_match('~^([A-Za-z]+)\.' . $context['lang_id'] . '\.php$~', $entry, $matches) == 0) { |
|
| 880 | + continue; |
|
| 881 | + } |
|
| 855 | 882 | |
| 856 | - if (!isset($context['possible_files'][$theme])) |
|
| 857 | - $context['possible_files'][$theme] = array( |
|
| 883 | + if (!isset($context['possible_files'][$theme])) { |
|
| 884 | + $context['possible_files'][$theme] = array( |
|
| 858 | 885 | 'id' => $theme, |
| 859 | 886 | 'name' => $themes[$theme]['name'], |
| 860 | 887 | 'files' => array(), |
| 861 | 888 | ); |
| 889 | + } |
|
| 862 | 890 | |
| 863 | 891 | $context['possible_files'][$theme]['files'][] = array( |
| 864 | 892 | 'id' => $matches[1], |
@@ -887,31 +915,36 @@ discard block |
||
| 887 | 915 | { |
| 888 | 916 | $_SESSION['last_backup_for'] = $context['lang_id'] . '$$$'; |
| 889 | 917 | $result = package_create_backup('backup_lang_' . $context['lang_id']); |
| 890 | - if (!$result) |
|
| 891 | - fatal_lang_error('could_not_language_backup', false); |
|
| 918 | + if (!$result) { |
|
| 919 | + fatal_lang_error('could_not_language_backup', false); |
|
| 920 | + } |
|
| 892 | 921 | } |
| 893 | 922 | |
| 894 | 923 | // Second, loop through the array to remove the files. |
| 895 | 924 | foreach ($lang_dirs as $curPath) |
| 896 | 925 | { |
| 897 | - foreach ($context['possible_files'][1]['files'] as $lang) |
|
| 898 | - if (file_exists($curPath . '/' . $lang['id'] . '.' . $context['lang_id'] . '.php')) |
|
| 926 | + foreach ($context['possible_files'][1]['files'] as $lang) { |
|
| 927 | + if (file_exists($curPath . '/' . $lang['id'] . '.' . $context['lang_id'] . '.php')) |
|
| 899 | 928 | unlink($curPath . '/' . $lang['id'] . '.' . $context['lang_id'] . '.php'); |
| 929 | + } |
|
| 900 | 930 | |
| 901 | 931 | // Check for the email template. |
| 902 | - if (file_exists($curPath . '/EmailTemplates.' . $context['lang_id'] . '.php')) |
|
| 903 | - unlink($curPath . '/EmailTemplates.' . $context['lang_id'] . '.php'); |
|
| 932 | + if (file_exists($curPath . '/EmailTemplates.' . $context['lang_id'] . '.php')) { |
|
| 933 | + unlink($curPath . '/EmailTemplates.' . $context['lang_id'] . '.php'); |
|
| 934 | + } |
|
| 904 | 935 | } |
| 905 | 936 | |
| 906 | 937 | // Third, the agreement file. |
| 907 | - if (file_exists($boarddir . '/agreement.' . $context['lang_id'] . '.txt')) |
|
| 908 | - unlink($boarddir . '/agreement.' . $context['lang_id'] . '.txt'); |
|
| 938 | + if (file_exists($boarddir . '/agreement.' . $context['lang_id'] . '.txt')) { |
|
| 939 | + unlink($boarddir . '/agreement.' . $context['lang_id'] . '.txt'); |
|
| 940 | + } |
|
| 909 | 941 | |
| 910 | 942 | // Fourth, a related images folder, if it exists... |
| 911 | - if (!empty($images_dirs)) |
|
| 912 | - foreach ($images_dirs as $curPath) |
|
| 943 | + if (!empty($images_dirs)) { |
|
| 944 | + foreach ($images_dirs as $curPath) |
|
| 913 | 945 | if (is_dir($curPath)) |
| 914 | 946 | deltree($curPath); |
| 947 | + } |
|
| 915 | 948 | |
| 916 | 949 | // Members can no longer use this language. |
| 917 | 950 | $smcFunc['db_query']('', ' |
@@ -995,8 +1028,9 @@ discard block |
||
| 995 | 1028 | foreach ($_POST['entry'] as $k => $v) |
| 996 | 1029 | { |
| 997 | 1030 | // Only try to save if it's changed! |
| 998 | - if ($_POST['entry'][$k] != $_POST['comp'][$k]) |
|
| 999 | - $save_strings[$k] = cleanLangString($v, false); |
|
| 1031 | + if ($_POST['entry'][$k] != $_POST['comp'][$k]) { |
|
| 1032 | + $save_strings[$k] = cleanLangString($v, false); |
|
| 1033 | + } |
|
| 1000 | 1034 | } |
| 1001 | 1035 | } |
| 1002 | 1036 | |
@@ -1030,12 +1064,13 @@ discard block |
||
| 1030 | 1064 | if ($multiline_cache) |
| 1031 | 1065 | { |
| 1032 | 1066 | preg_match('~\$(helptxt|txt|editortxt)\[\'(.+)\'\]\s?=\s?(.+);~ms', strtr($multiline_cache, array("\r" => '')), $matches); |
| 1033 | - if (!empty($matches[3])) |
|
| 1034 | - $entries[$matches[2]] = array( |
|
| 1067 | + if (!empty($matches[3])) { |
|
| 1068 | + $entries[$matches[2]] = array( |
|
| 1035 | 1069 | 'type' => $matches[1], |
| 1036 | 1070 | 'full' => $matches[0], |
| 1037 | 1071 | 'entry' => $matches[3], |
| 1038 | 1072 | ); |
| 1073 | + } |
|
| 1039 | 1074 | } |
| 1040 | 1075 | |
| 1041 | 1076 | // These are the entries we can definitely save. |
@@ -1046,8 +1081,9 @@ discard block |
||
| 1046 | 1081 | { |
| 1047 | 1082 | // Ignore some things we set separately. |
| 1048 | 1083 | $ignore_files = array('lang_character_set', 'lang_locale', 'lang_dictionary', 'lang_spelling', 'lang_rtl'); |
| 1049 | - if (in_array($entryKey, $ignore_files)) |
|
| 1050 | - continue; |
|
| 1084 | + if (in_array($entryKey, $ignore_files)) { |
|
| 1085 | + continue; |
|
| 1086 | + } |
|
| 1051 | 1087 | |
| 1052 | 1088 | // These are arrays that need breaking out. |
| 1053 | 1089 | $arrays = array('days', 'days_short', 'months', 'months_titles', 'months_short', 'happy_birthday_author', 'karlbenson1_author', 'nite0859_author', 'zwaldowski_author', 'geezmo_author', 'karlbenson2_author'); |
@@ -1080,9 +1116,9 @@ discard block |
||
| 1080 | 1116 | { |
| 1081 | 1117 | $save_cache['entries'][$cur_index] = strtr($save_strings[$entryKey . '-+- ' . $cur_index], array('\'' => '')); |
| 1082 | 1118 | $save_cache['enabled'] = true; |
| 1119 | + } else { |
|
| 1120 | + $save_cache['entries'][$cur_index] = $subValue; |
|
| 1083 | 1121 | } |
| 1084 | - else |
|
| 1085 | - $save_cache['entries'][$cur_index] = $subValue; |
|
| 1086 | 1122 | |
| 1087 | 1123 | $context['file_entries'][] = array( |
| 1088 | 1124 | 'key' => $entryKey . '-+- ' . $cur_index, |
@@ -1105,9 +1141,9 @@ discard block |
||
| 1105 | 1141 | { |
| 1106 | 1142 | $items[] = $k2 . ' => \'' . $v2 . '\''; |
| 1107 | 1143 | $cur_index = $k2; |
| 1144 | + } else { |
|
| 1145 | + $items[] = '\'' . $v2 . '\''; |
|
| 1108 | 1146 | } |
| 1109 | - else |
|
| 1110 | - $items[] = '\'' . $v2 . '\''; |
|
| 1111 | 1147 | |
| 1112 | 1148 | $cur_index++; |
| 1113 | 1149 | } |
@@ -1117,15 +1153,15 @@ discard block |
||
| 1117 | 1153 | 'replace' => '$' . $entryValue['type'] . '[\'' . $entryKey . '\'] = array(' . implode(', ', $items) . ');', |
| 1118 | 1154 | ); |
| 1119 | 1155 | } |
| 1120 | - } |
|
| 1121 | - else |
|
| 1156 | + } else |
|
| 1122 | 1157 | { |
| 1123 | 1158 | // Saving? |
| 1124 | 1159 | if (isset($save_strings[$entryKey]) && $save_strings[$entryKey] != $entryValue['entry']) |
| 1125 | 1160 | { |
| 1126 | 1161 | // @todo Fix this properly. |
| 1127 | - if ($save_strings[$entryKey] == '') |
|
| 1128 | - $save_strings[$entryKey] = '\'\''; |
|
| 1162 | + if ($save_strings[$entryKey] == '') { |
|
| 1163 | + $save_strings[$entryKey] = '\'\''; |
|
| 1164 | + } |
|
| 1129 | 1165 | |
| 1130 | 1166 | // Set the new value. |
| 1131 | 1167 | $entryValue['entry'] = $save_strings[$entryKey]; |
@@ -1151,8 +1187,9 @@ discard block |
||
| 1151 | 1187 | checkSession(); |
| 1152 | 1188 | |
| 1153 | 1189 | $file_contents = implode('', file($current_file)); |
| 1154 | - foreach ($final_saves as $save) |
|
| 1155 | - $file_contents = strtr($file_contents, array($save['find'] => $save['replace'])); |
|
| 1190 | + foreach ($final_saves as $save) { |
|
| 1191 | + $file_contents = strtr($file_contents, array($save['find'] => $save['replace'])); |
|
| 1192 | + } |
|
| 1156 | 1193 | |
| 1157 | 1194 | // Save the actual changes. |
| 1158 | 1195 | $fp = fopen($current_file, 'w+'); |
@@ -1167,8 +1204,9 @@ discard block |
||
| 1167 | 1204 | } |
| 1168 | 1205 | |
| 1169 | 1206 | // If we saved, redirect. |
| 1170 | - if ($madeSave) |
|
| 1171 | - redirectexit('action=admin;area=languages;sa=editlang;lid=' . $context['lang_id']); |
|
| 1207 | + if ($madeSave) { |
|
| 1208 | + redirectexit('action=admin;area=languages;sa=editlang;lid=' . $context['lang_id']); |
|
| 1209 | + } |
|
| 1172 | 1210 | |
| 1173 | 1211 | createToken('admin-mlang'); |
| 1174 | 1212 | } |
@@ -1200,8 +1238,9 @@ discard block |
||
| 1200 | 1238 | // Toggle the escape. |
| 1201 | 1239 | $is_escape = !$is_escape; |
| 1202 | 1240 | // If we're now escaped don't add this string. |
| 1203 | - if ($is_escape) |
|
| 1204 | - continue; |
|
| 1241 | + if ($is_escape) { |
|
| 1242 | + continue; |
|
| 1243 | + } |
|
| 1205 | 1244 | } |
| 1206 | 1245 | // Special case - parsed string with line break etc? |
| 1207 | 1246 | elseif (($string{$i} == 'n' || $string{$i} == 't') && $in_string == 2 && $is_escape) |
@@ -1218,11 +1257,13 @@ discard block |
||
| 1218 | 1257 | if ($in_string != 2 && ($in_string != 1 || !$is_escape)) |
| 1219 | 1258 | { |
| 1220 | 1259 | // Is it the end of a single quote string? |
| 1221 | - if ($in_string == 1) |
|
| 1222 | - $in_string = 0; |
|
| 1260 | + if ($in_string == 1) { |
|
| 1261 | + $in_string = 0; |
|
| 1262 | + } |
|
| 1223 | 1263 | // Otherwise it's the start! |
| 1224 | - else |
|
| 1225 | - $in_string = 1; |
|
| 1264 | + else { |
|
| 1265 | + $in_string = 1; |
|
| 1266 | + } |
|
| 1226 | 1267 | |
| 1227 | 1268 | // Don't actually include this character! |
| 1228 | 1269 | continue; |
@@ -1235,19 +1276,22 @@ discard block |
||
| 1235 | 1276 | if ($in_string != 1 && ($in_string != 2 || !$is_escape)) |
| 1236 | 1277 | { |
| 1237 | 1278 | // Is it the end of a double quote string? |
| 1238 | - if ($in_string == 2) |
|
| 1239 | - $in_string = 0; |
|
| 1279 | + if ($in_string == 2) { |
|
| 1280 | + $in_string = 0; |
|
| 1281 | + } |
|
| 1240 | 1282 | // Otherwise it's the start! |
| 1241 | - else |
|
| 1242 | - $in_string = 2; |
|
| 1283 | + else { |
|
| 1284 | + $in_string = 2; |
|
| 1285 | + } |
|
| 1243 | 1286 | |
| 1244 | 1287 | // Don't actually include this character! |
| 1245 | 1288 | continue; |
| 1246 | 1289 | } |
| 1247 | 1290 | } |
| 1248 | 1291 | // A join/space outside of a string is simply removed. |
| 1249 | - elseif ($in_string == 0 && (empty($string{$i}) || $string{$i} == '.')) |
|
| 1250 | - continue; |
|
| 1292 | + elseif ($in_string == 0 && (empty($string{$i}) || $string{$i} == '.')) { |
|
| 1293 | + continue; |
|
| 1294 | + } |
|
| 1251 | 1295 | // Start of a variable? |
| 1252 | 1296 | elseif ($in_string == 0 && $string{$i} == '$') |
| 1253 | 1297 | { |
@@ -1281,8 +1325,7 @@ discard block |
||
| 1281 | 1325 | |
| 1282 | 1326 | // Unhtml then rehtml the whole thing! |
| 1283 | 1327 | $new_string = $smcFunc['htmlspecialchars'](un_htmlspecialchars($new_string)); |
| 1284 | - } |
|
| 1285 | - else |
|
| 1328 | + } else |
|
| 1286 | 1329 | { |
| 1287 | 1330 | // Keep track of what we're doing... |
| 1288 | 1331 | $in_string = 0; |
@@ -1311,10 +1354,11 @@ discard block |
||
| 1311 | 1354 | preg_match('~\{%([\$A-Za-z0-9\'\[\]_-]+)%\}~', substr($string, $i), $matches); |
| 1312 | 1355 | if (!empty($matches[1])) |
| 1313 | 1356 | { |
| 1314 | - if ($in_string == 1) |
|
| 1315 | - $new_string .= '\' . '; |
|
| 1316 | - elseif ($new_string) |
|
| 1317 | - $new_string .= ' . '; |
|
| 1357 | + if ($in_string == 1) { |
|
| 1358 | + $new_string .= '\' . '; |
|
| 1359 | + } elseif ($new_string) { |
|
| 1360 | + $new_string .= ' . '; |
|
| 1361 | + } |
|
| 1318 | 1362 | |
| 1319 | 1363 | $new_string .= $matches[1]; |
| 1320 | 1364 | $i += strlen($matches[1]) + 3; |
@@ -1327,8 +1371,9 @@ discard block |
||
| 1327 | 1371 | elseif ($string{$i} == '<') |
| 1328 | 1372 | { |
| 1329 | 1373 | // Probably HTML? |
| 1330 | - if ($string{$i + 1} != ' ') |
|
| 1331 | - $in_html = true; |
|
| 1374 | + if ($string{$i + 1} != ' ') { |
|
| 1375 | + $in_html = true; |
|
| 1376 | + } |
|
| 1332 | 1377 | // Assume we need an entity... |
| 1333 | 1378 | else |
| 1334 | 1379 | { |
@@ -1340,8 +1385,9 @@ discard block |
||
| 1340 | 1385 | elseif ($string{$i} == '>') |
| 1341 | 1386 | { |
| 1342 | 1387 | // Will it be HTML? |
| 1343 | - if ($in_html) |
|
| 1344 | - $in_html = false; |
|
| 1388 | + if ($in_html) { |
|
| 1389 | + $in_html = false; |
|
| 1390 | + } |
|
| 1345 | 1391 | // Otherwise we need an entity... |
| 1346 | 1392 | else |
| 1347 | 1393 | { |
@@ -1350,8 +1396,9 @@ discard block |
||
| 1350 | 1396 | } |
| 1351 | 1397 | } |
| 1352 | 1398 | // Is it a slash? If so escape it... |
| 1353 | - if ($string{$i} == '\\') |
|
| 1354 | - $new_string .= '\\'; |
|
| 1399 | + if ($string{$i} == '\\') { |
|
| 1400 | + $new_string .= '\\'; |
|
| 1401 | + } |
|
| 1355 | 1402 | // The infamous double quote? |
| 1356 | 1403 | elseif ($string{$i} == '"') |
| 1357 | 1404 | { |
@@ -1374,10 +1421,11 @@ discard block |
||
| 1374 | 1421 | } |
| 1375 | 1422 | |
| 1376 | 1423 | // If we ended as a string then close it off. |
| 1377 | - if ($in_string == 1) |
|
| 1378 | - $new_string .= '\''; |
|
| 1379 | - elseif ($in_string == 2) |
|
| 1380 | - $new_string .= '"'; |
|
| 1424 | + if ($in_string == 1) { |
|
| 1425 | + $new_string .= '\''; |
|
| 1426 | + } elseif ($in_string == 2) { |
|
| 1427 | + $new_string .= '"'; |
|
| 1428 | + } |
|
| 1381 | 1429 | } |
| 1382 | 1430 | |
| 1383 | 1431 | return $new_string; |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 3 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * The main admin handling function.<br> |
@@ -444,8 +445,9 @@ discard block |
||
| 444 | 445 | foreach ($admin_includes as $include) |
| 445 | 446 | { |
| 446 | 447 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
| 447 | - if (file_exists($include)) |
|
| 448 | - require_once($include); |
|
| 448 | + if (file_exists($include)) { |
|
| 449 | + require_once($include); |
|
| 450 | + } |
|
| 449 | 451 | } |
| 450 | 452 | } |
| 451 | 453 | |
@@ -457,24 +459,27 @@ discard block |
||
| 457 | 459 | unset($admin_areas); |
| 458 | 460 | |
| 459 | 461 | // Nothing valid? |
| 460 | - if ($admin_include_data == false) |
|
| 461 | - fatal_lang_error('no_access', false); |
|
| 462 | + if ($admin_include_data == false) { |
|
| 463 | + fatal_lang_error('no_access', false); |
|
| 464 | + } |
|
| 462 | 465 | |
| 463 | 466 | // Build the link tree. |
| 464 | 467 | $context['linktree'][] = array( |
| 465 | 468 | 'url' => $scripturl . '?action=admin', |
| 466 | 469 | 'name' => $txt['admin_center'], |
| 467 | 470 | ); |
| 468 | - if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index') |
|
| 469 | - $context['linktree'][] = array( |
|
| 471 | + if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index') { |
|
| 472 | + $context['linktree'][] = array( |
|
| 470 | 473 | 'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';' . $context['session_var'] . '=' . $context['session_id'], |
| 471 | 474 | 'name' => $admin_include_data['label'], |
| 472 | 475 | ); |
| 473 | - if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label']) |
|
| 474 | - $context['linktree'][] = array( |
|
| 476 | + } |
|
| 477 | + if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label']) { |
|
| 478 | + $context['linktree'][] = array( |
|
| 475 | 479 | 'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';sa=' . $admin_include_data['current_subsection'] . ';' . $context['session_var'] . '=' . $context['session_id'], |
| 476 | 480 | 'name' => $admin_include_data['subsections'][$admin_include_data['current_subsection']][0], |
| 477 | 481 | ); |
| 482 | + } |
|
| 478 | 483 | |
| 479 | 484 | // Make a note of the Unique ID for this menu. |
| 480 | 485 | $context['admin_menu_id'] = $context['max_menu_id']; |
@@ -484,16 +489,18 @@ discard block |
||
| 484 | 489 | $context['admin_area'] = $admin_include_data['current_area']; |
| 485 | 490 | |
| 486 | 491 | // Now - finally - call the right place! |
| 487 | - if (isset($admin_include_data['file'])) |
|
| 488 | - require_once($sourcedir . '/' . $admin_include_data['file']); |
|
| 492 | + if (isset($admin_include_data['file'])) { |
|
| 493 | + require_once($sourcedir . '/' . $admin_include_data['file']); |
|
| 494 | + } |
|
| 489 | 495 | |
| 490 | 496 | // Get the right callable. |
| 491 | 497 | $call = call_helper($admin_include_data['function'], true); |
| 492 | 498 | |
| 493 | 499 | // Is it valid? |
| 494 | - if (!empty($call)) |
|
| 495 | - call_user_func($call); |
|
| 496 | -} |
|
| 500 | + if (!empty($call)) { |
|
| 501 | + call_user_func($call); |
|
| 502 | + } |
|
| 503 | + } |
|
| 497 | 504 | |
| 498 | 505 | /** |
| 499 | 506 | * The main administration section. |
@@ -547,13 +554,14 @@ discard block |
||
| 547 | 554 | |
| 548 | 555 | $context['sub_template'] = $context['admin_area'] == 'credits' ? 'credits' : 'admin'; |
| 549 | 556 | $context['page_title'] = $context['admin_area'] == 'credits' ? $txt['support_credits_title'] : $txt['admin_center']; |
| 550 | - if ($context['admin_area'] != 'credits') |
|
| 551 | - $context[$context['admin_menu_name']]['tab_data'] = array( |
|
| 557 | + if ($context['admin_area'] != 'credits') { |
|
| 558 | + $context[$context['admin_menu_name']]['tab_data'] = array( |
|
| 552 | 559 | 'title' => $txt['admin_center'], |
| 553 | 560 | 'help' => '', |
| 554 | 561 | 'description' => '<strong>' . $txt['hello_guest'] . ' ' . $context['user']['name'] . '!</strong> |
| 555 | 562 | ' . sprintf($txt['admin_main_welcome'], $txt['admin_center'], $txt['help'], $txt['help']), |
| 556 | 563 | ); |
| 564 | + } |
|
| 557 | 565 | |
| 558 | 566 | // Lastly, fill in the blanks in the support resources paragraphs. |
| 559 | 567 | $txt['support_resources_p1'] = sprintf($txt['support_resources_p1'], |
@@ -571,9 +579,10 @@ discard block |
||
| 571 | 579 | 'https://www.simplemachines.org/redirect/customize_support' |
| 572 | 580 | ); |
| 573 | 581 | |
| 574 | - if ($context['admin_area'] == 'admin') |
|
| 575 | - loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin'); |
|
| 576 | -} |
|
| 582 | + if ($context['admin_area'] == 'admin') { |
|
| 583 | + loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin'); |
|
| 584 | + } |
|
| 585 | + } |
|
| 577 | 586 | |
| 578 | 587 | /** |
| 579 | 588 | * Get one of the admin information files from Simple Machines. |
@@ -584,8 +593,9 @@ discard block |
||
| 584 | 593 | |
| 585 | 594 | setMemoryLimit('32M'); |
| 586 | 595 | |
| 587 | - if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename'])) |
|
| 588 | - fatal_lang_error('no_access', false); |
|
| 596 | + if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename'])) { |
|
| 597 | + fatal_lang_error('no_access', false); |
|
| 598 | + } |
|
| 589 | 599 | |
| 590 | 600 | // Strip off the forum cache part or we won't find it... |
| 591 | 601 | $_REQUEST['filename'] = str_replace($modSettings['browser_cache'], '', $_REQUEST['filename']); |
@@ -600,27 +610,30 @@ discard block |
||
| 600 | 610 | ) |
| 601 | 611 | ); |
| 602 | 612 | |
| 603 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
| 604 | - fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404); |
|
| 613 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
| 614 | + fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404); |
|
| 615 | + } |
|
| 605 | 616 | |
| 606 | 617 | list ($file_data, $filetype) = $smcFunc['db_fetch_row']($request); |
| 607 | 618 | $smcFunc['db_free_result']($request); |
| 608 | 619 | |
| 609 | 620 | // @todo Temp |
| 610 | 621 | // Figure out if sesc is still being used. |
| 611 | - if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript') |
|
| 612 | - $file_data = ' |
|
| 622 | + if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript') { |
|
| 623 | + $file_data = ' |
|
| 613 | 624 | if (!(\'smfForum_sessionvar\' in window)) |
| 614 | 625 | window.smfForum_sessionvar = \'sesc\'; |
| 615 | 626 | ' . strtr($file_data, array(';sesc=' => ';\' + window.smfForum_sessionvar + \'=')); |
| 627 | + } |
|
| 616 | 628 | |
| 617 | 629 | $context['template_layers'] = array(); |
| 618 | 630 | // Lets make sure we aren't going to output anything nasty. |
| 619 | 631 | @ob_end_clean(); |
| 620 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
| 621 | - @ob_start('ob_gzhandler'); |
|
| 622 | - else |
|
| 623 | - @ob_start(); |
|
| 632 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
| 633 | + @ob_start('ob_gzhandler'); |
|
| 634 | + } else { |
|
| 635 | + @ob_start(); |
|
| 636 | + } |
|
| 624 | 637 | |
| 625 | 638 | // Make sure they know what type of file we are. |
| 626 | 639 | header('Content-Type: ' . $filetype); |
@@ -660,11 +673,12 @@ discard block |
||
| 660 | 673 | updateAdminPreferences(); |
| 661 | 674 | } |
| 662 | 675 | |
| 663 | - if (trim($context['search_term']) == '') |
|
| 664 | - $context['search_results'] = array(); |
|
| 665 | - else |
|
| 666 | - call_helper($subActions[$context['search_type']]); |
|
| 667 | -} |
|
| 676 | + if (trim($context['search_term']) == '') { |
|
| 677 | + $context['search_results'] = array(); |
|
| 678 | + } else { |
|
| 679 | + call_helper($subActions[$context['search_type']]); |
|
| 680 | + } |
|
| 681 | + } |
|
| 668 | 682 | |
| 669 | 683 | /** |
| 670 | 684 | * A complicated but relatively quick internal search. |
@@ -728,8 +742,9 @@ discard block |
||
| 728 | 742 | |
| 729 | 743 | loadLanguage(implode('+', $language_files)); |
| 730 | 744 | |
| 731 | - foreach ($include_files as $file) |
|
| 732 | - require_once($sourcedir . '/' . $file . '.php'); |
|
| 745 | + foreach ($include_files as $file) { |
|
| 746 | + require_once($sourcedir . '/' . $file . '.php'); |
|
| 747 | + } |
|
| 733 | 748 | |
| 734 | 749 | /* This is the huge array that defines everything... it's a huge array of items formatted as follows: |
| 735 | 750 | 0 = Language index (Can be array of indexes) to search through for this setting. |
@@ -753,11 +768,12 @@ discard block |
||
| 753 | 768 | foreach ($section['areas'] as $menu_key => $menu_item) |
| 754 | 769 | { |
| 755 | 770 | $search_data['sections'][] = array($menu_item['label'], 'area=' . $menu_key); |
| 756 | - if (!empty($menu_item['subsections'])) |
|
| 757 | - foreach ($menu_item['subsections'] as $key => $sublabel) |
|
| 771 | + if (!empty($menu_item['subsections'])) { |
|
| 772 | + foreach ($menu_item['subsections'] as $key => $sublabel) |
|
| 758 | 773 | { |
| 759 | 774 | if (isset($sublabel['label'])) |
| 760 | 775 | $search_data['sections'][] = array($sublabel['label'], 'area=' . $menu_key . ';sa=' . $key); |
| 776 | + } |
|
| 761 | 777 | } |
| 762 | 778 | } |
| 763 | 779 | } |
@@ -767,9 +783,10 @@ discard block |
||
| 767 | 783 | // Get a list of their variables. |
| 768 | 784 | $config_vars = $setting_area[0](true); |
| 769 | 785 | |
| 770 | - foreach ($config_vars as $var) |
|
| 771 | - if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc'))) |
|
| 786 | + foreach ($config_vars as $var) { |
|
| 787 | + if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc'))) |
|
| 772 | 788 | $search_data['settings'][] = array($var[(isset($var[2]) && in_array($var[2], array('file', 'db'))) ? 0 : 1], $setting_area[1]); |
| 789 | + } |
|
| 773 | 790 | } |
| 774 | 791 | |
| 775 | 792 | $context['page_title'] = $txt['admin_search_results']; |
@@ -782,8 +799,9 @@ discard block |
||
| 782 | 799 | foreach ($data as $item) |
| 783 | 800 | { |
| 784 | 801 | $found = false; |
| 785 | - if (!is_array($item[0])) |
|
| 786 | - $item[0] = array($item[0]); |
|
| 802 | + if (!is_array($item[0])) { |
|
| 803 | + $item[0] = array($item[0]); |
|
| 804 | + } |
|
| 787 | 805 | foreach ($item[0] as $term) |
| 788 | 806 | { |
| 789 | 807 | if (stripos($term, $search_term) !== false || (isset($txt[$term]) && stripos($txt[$term], $search_term) !== false) || (isset($txt['setting_' . $term]) && stripos($txt['setting_' . $term], $search_term) !== false)) |
@@ -841,8 +859,9 @@ discard block |
||
| 841 | 859 | $postVars = explode(' ', $context['search_term']); |
| 842 | 860 | |
| 843 | 861 | // Encode the search data. |
| 844 | - foreach ($postVars as $k => $v) |
|
| 845 | - $postVars[$k] = urlencode($v); |
|
| 862 | + foreach ($postVars as $k => $v) { |
|
| 863 | + $postVars[$k] = urlencode($v); |
|
| 864 | + } |
|
| 846 | 865 | |
| 847 | 866 | // This is what we will send. |
| 848 | 867 | $postVars = implode('+', $postVars); |
@@ -854,8 +873,9 @@ discard block |
||
| 854 | 873 | $search_results = fetch_web_data($context['doc_apiurl'] . '?action=query&list=search&srprop=timestamp|snippet&format=xml&srwhat=text&srsearch=' . $postVars); |
| 855 | 874 | |
| 856 | 875 | // If we didn't get any xml back we are in trouble - perhaps the doc site is overloaded? |
| 857 | - if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true) |
|
| 858 | - fatal_lang_error('cannot_connect_doc_site'); |
|
| 876 | + if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true) { |
|
| 877 | + fatal_lang_error('cannot_connect_doc_site'); |
|
| 878 | + } |
|
| 859 | 879 | |
| 860 | 880 | $search_results = $matches[1]; |
| 861 | 881 | |
@@ -867,8 +887,9 @@ discard block |
||
| 867 | 887 | $results = new xmlArray($search_results, false); |
| 868 | 888 | |
| 869 | 889 | // Move through the api layer. |
| 870 | - if (!$results->exists('api')) |
|
| 871 | - fatal_lang_error('cannot_connect_doc_site'); |
|
| 890 | + if (!$results->exists('api')) { |
|
| 891 | + fatal_lang_error('cannot_connect_doc_site'); |
|
| 892 | + } |
|
| 872 | 893 | |
| 873 | 894 | // Are there actually some results? |
| 874 | 895 | if ($results->exists('api/query/search/p')) |
@@ -904,8 +925,9 @@ discard block |
||
| 904 | 925 | ); |
| 905 | 926 | |
| 906 | 927 | // If it's not got a sa set it must have come here for first time, pretend error log should be reversed. |
| 907 | - if (!isset($_REQUEST['sa'])) |
|
| 908 | - $_REQUEST['desc'] = true; |
|
| 928 | + if (!isset($_REQUEST['sa'])) { |
|
| 929 | + $_REQUEST['desc'] = true; |
|
| 930 | + } |
|
| 909 | 931 | |
| 910 | 932 | // Setup some tab stuff. |
| 911 | 933 | $context[$context['admin_menu_name']]['tab_data'] = array( |
@@ -955,9 +977,10 @@ discard block |
||
| 955 | 977 | unset($_SESSION['admin_time']); |
| 956 | 978 | |
| 957 | 979 | // Clean any admin tokens as well. |
| 958 | - foreach ($_SESSION['token'] as $key => $token) |
|
| 959 | - if (strpos($key, '-admin') !== false) |
|
| 980 | + foreach ($_SESSION['token'] as $key => $token) { |
|
| 981 | + if (strpos($key, '-admin') !== false) |
|
| 960 | 982 | unset($_SESSION['token'][$key]); |
| 983 | + } |
|
| 961 | 984 | |
| 962 | 985 | redirectexit(); |
| 963 | 986 | } |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 3 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * This is the dispatcher of smileys administration. |
@@ -91,8 +92,9 @@ discard block |
||
| 91 | 92 | ); |
| 92 | 93 | |
| 93 | 94 | // Some settings may not be enabled, disallow these from the tabs as appropriate. |
| 94 | - if (empty($modSettings['messageIcons_enable'])) |
|
| 95 | - $context[$context['admin_menu_name']]['tab_data']['tabs']['editicons']['disabled'] = true; |
|
| 95 | + if (empty($modSettings['messageIcons_enable'])) { |
|
| 96 | + $context[$context['admin_menu_name']]['tab_data']['tabs']['editicons']['disabled'] = true; |
|
| 97 | + } |
|
| 96 | 98 | if (empty($modSettings['smiley_enable'])) |
| 97 | 99 | { |
| 98 | 100 | $context[$context['admin_menu_name']]['tab_data']['tabs']['addsmiley']['disabled'] = true; |
@@ -125,8 +127,9 @@ discard block |
||
| 125 | 127 | $set_names = explode("\n", $modSettings['smiley_sets_names']); |
| 126 | 128 | |
| 127 | 129 | $smiley_context = array(); |
| 128 | - foreach ($smiley_sets as $i => $set) |
|
| 129 | - $smiley_context[$set] = $set_names[$i]; |
|
| 130 | + foreach ($smiley_sets as $i => $set) { |
|
| 131 | + $smiley_context[$set] = $set_names[$i]; |
|
| 132 | + } |
|
| 130 | 133 | |
| 131 | 134 | // All the settings for the page... |
| 132 | 135 | $config_vars = array( |
@@ -147,8 +150,9 @@ discard block |
||
| 147 | 150 | |
| 148 | 151 | call_integration_hook('integrate_modify_smiley_settings', array(&$config_vars)); |
| 149 | 152 | |
| 150 | - if ($return_config) |
|
| 151 | - return $config_vars; |
|
| 153 | + if ($return_config) { |
|
| 154 | + return $config_vars; |
|
| 155 | + } |
|
| 152 | 156 | |
| 153 | 157 | // Setup the basics of the settings template. |
| 154 | 158 | require_once($sourcedir . '/ManageServer.php'); |
@@ -207,8 +211,9 @@ discard block |
||
| 207 | 211 | foreach ($_POST['smiley_set'] as $id => $val) |
| 208 | 212 | { |
| 209 | 213 | // If this is the set you've marked as default, or the only one remaining, you can't delete it |
| 210 | - if ($modSettings['smiley_sets_default'] != $set_paths[$id] && count($set_paths) != 1 && isset($set_paths[$id], $set_names[$id])) |
|
| 211 | - unset($set_paths[$id], $set_names[$id]); |
|
| 214 | + if ($modSettings['smiley_sets_default'] != $set_paths[$id] && count($set_paths) != 1 && isset($set_paths[$id], $set_names[$id])) { |
|
| 215 | + unset($set_paths[$id], $set_names[$id]); |
|
| 216 | + } |
|
| 212 | 217 | } |
| 213 | 218 | |
| 214 | 219 | // Shortcut... array_merge() on a single array resets the numeric keys |
@@ -222,8 +227,9 @@ discard block |
||
| 222 | 227 | )); |
| 223 | 228 | } |
| 224 | 229 | // Add a new smiley set. |
| 225 | - elseif (!empty($_POST['add'])) |
|
| 226 | - $context['sub_action'] = 'modifyset'; |
|
| 230 | + elseif (!empty($_POST['add'])) { |
|
| 231 | + $context['sub_action'] = 'modifyset'; |
|
| 232 | + } |
|
| 227 | 233 | // Create or modify a smiley set. |
| 228 | 234 | elseif (isset($_POST['set'])) |
| 229 | 235 | { |
@@ -233,8 +239,9 @@ discard block |
||
| 233 | 239 | // Create a new smiley set. |
| 234 | 240 | if ($_POST['set'] == -1 && isset($_POST['smiley_sets_path'])) |
| 235 | 241 | { |
| 236 | - if (in_array($_POST['smiley_sets_path'], $set_paths)) |
|
| 237 | - fatal_lang_error('smiley_set_already_exists'); |
|
| 242 | + if (in_array($_POST['smiley_sets_path'], $set_paths)) { |
|
| 243 | + fatal_lang_error('smiley_set_already_exists'); |
|
| 244 | + } |
|
| 238 | 245 | |
| 239 | 246 | updateSettings(array( |
| 240 | 247 | 'smiley_sets_known' => $modSettings['smiley_sets_known'] . ',' . $_POST['smiley_sets_path'], |
@@ -246,12 +253,14 @@ discard block |
||
| 246 | 253 | else |
| 247 | 254 | { |
| 248 | 255 | // Make sure the smiley set exists. |
| 249 | - if (!isset($set_paths[$_POST['set']]) || !isset($set_names[$_POST['set']])) |
|
| 250 | - fatal_lang_error('smiley_set_not_found'); |
|
| 256 | + if (!isset($set_paths[$_POST['set']]) || !isset($set_names[$_POST['set']])) { |
|
| 257 | + fatal_lang_error('smiley_set_not_found'); |
|
| 258 | + } |
|
| 251 | 259 | |
| 252 | 260 | // Make sure the path is not yet used by another smileyset. |
| 253 | - if (in_array($_POST['smiley_sets_path'], $set_paths) && $_POST['smiley_sets_path'] != $set_paths[$_POST['set']]) |
|
| 254 | - fatal_lang_error('smiley_set_path_already_used'); |
|
| 261 | + if (in_array($_POST['smiley_sets_path'], $set_paths) && $_POST['smiley_sets_path'] != $set_paths[$_POST['set']]) { |
|
| 262 | + fatal_lang_error('smiley_set_path_already_used'); |
|
| 263 | + } |
|
| 255 | 264 | |
| 256 | 265 | $set_paths[$_POST['set']] = $_POST['smiley_sets_path']; |
| 257 | 266 | $set_names[$_POST['set']] = $_POST['smiley_sets_name']; |
@@ -263,8 +272,9 @@ discard block |
||
| 263 | 272 | } |
| 264 | 273 | |
| 265 | 274 | // The user might have checked to also import smileys. |
| 266 | - if (!empty($_POST['smiley_sets_import'])) |
|
| 267 | - ImportSmileys($_POST['smiley_sets_path']); |
|
| 275 | + if (!empty($_POST['smiley_sets_import'])) { |
|
| 276 | + ImportSmileys($_POST['smiley_sets_path']); |
|
| 277 | + } |
|
| 268 | 278 | } |
| 269 | 279 | cache_put_data('parsing_smileys', null, 480); |
| 270 | 280 | cache_put_data('posting_smileys', null, 480); |
@@ -273,13 +283,14 @@ discard block |
||
| 273 | 283 | // Load all available smileysets... |
| 274 | 284 | $context['smiley_sets'] = explode(',', $modSettings['smiley_sets_known']); |
| 275 | 285 | $set_names = explode("\n", $modSettings['smiley_sets_names']); |
| 276 | - foreach ($context['smiley_sets'] as $i => $set) |
|
| 277 | - $context['smiley_sets'][$i] = array( |
|
| 286 | + foreach ($context['smiley_sets'] as $i => $set) { |
|
| 287 | + $context['smiley_sets'][$i] = array( |
|
| 278 | 288 | 'id' => $i, |
| 279 | 289 | 'path' => $smcFunc['htmlspecialchars']($set), |
| 280 | 290 | 'name' => $smcFunc['htmlspecialchars']($set_names[$i]), |
| 281 | 291 | 'selected' => $set == $modSettings['smiley_sets_default'] |
| 282 | 292 | ); |
| 293 | + } |
|
| 283 | 294 | |
| 284 | 295 | // Importing any smileys from an existing set? |
| 285 | 296 | if ($context['sub_action'] == 'import') |
@@ -290,8 +301,9 @@ discard block |
||
| 290 | 301 | $_GET['set'] = (int) $_GET['set']; |
| 291 | 302 | |
| 292 | 303 | // Sanity check - then import. |
| 293 | - if (isset($context['smiley_sets'][$_GET['set']])) |
|
| 294 | - ImportSmileys(un_htmlspecialchars($context['smiley_sets'][$_GET['set']]['path'])); |
|
| 304 | + if (isset($context['smiley_sets'][$_GET['set']])) { |
|
| 305 | + ImportSmileys(un_htmlspecialchars($context['smiley_sets'][$_GET['set']]['path'])); |
|
| 306 | + } |
|
| 295 | 307 | |
| 296 | 308 | // Force the process to continue. |
| 297 | 309 | $context['sub_action'] = 'modifyset'; |
@@ -301,15 +313,15 @@ discard block |
||
| 301 | 313 | if ($context['sub_action'] == 'modifyset') |
| 302 | 314 | { |
| 303 | 315 | $_GET['set'] = !isset($_GET['set']) ? -1 : (int) $_GET['set']; |
| 304 | - if ($_GET['set'] == -1 || !isset($context['smiley_sets'][$_GET['set']])) |
|
| 305 | - $context['current_set'] = array( |
|
| 316 | + if ($_GET['set'] == -1 || !isset($context['smiley_sets'][$_GET['set']])) { |
|
| 317 | + $context['current_set'] = array( |
|
| 306 | 318 | 'id' => '-1', |
| 307 | 319 | 'path' => '', |
| 308 | 320 | 'name' => '', |
| 309 | 321 | 'selected' => false, |
| 310 | 322 | 'is_new' => true, |
| 311 | 323 | ); |
| 312 | - else |
|
| 324 | + } else |
|
| 313 | 325 | { |
| 314 | 326 | $context['current_set'] = &$context['smiley_sets'][$_GET['set']]; |
| 315 | 327 | $context['current_set']['is_new'] = false; |
@@ -321,13 +333,15 @@ discard block |
||
| 321 | 333 | $dir = dir($modSettings['smileys_dir'] . '/' . $context['current_set']['path']); |
| 322 | 334 | while ($entry = $dir->read()) |
| 323 | 335 | { |
| 324 | - if (in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) |
|
| 325 | - $smileys[strtolower($entry)] = $entry; |
|
| 336 | + if (in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) { |
|
| 337 | + $smileys[strtolower($entry)] = $entry; |
|
| 338 | + } |
|
| 326 | 339 | } |
| 327 | 340 | $dir->close(); |
| 328 | 341 | |
| 329 | - if (empty($smileys)) |
|
| 330 | - fatal_lang_error('smiley_set_dir_not_found', false, array($context['current_set']['name'])); |
|
| 342 | + if (empty($smileys)) { |
|
| 343 | + fatal_lang_error('smiley_set_dir_not_found', false, array($context['current_set']['name'])); |
|
| 344 | + } |
|
| 331 | 345 | |
| 332 | 346 | // Exclude the smileys that are already in the database. |
| 333 | 347 | $request = $smcFunc['db_query']('', ' |
@@ -338,9 +352,10 @@ discard block |
||
| 338 | 352 | 'smiley_list' => $smileys, |
| 339 | 353 | ) |
| 340 | 354 | ); |
| 341 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 342 | - if (isset($smileys[strtolower($row['filename'])])) |
|
| 355 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 356 | + if (isset($smileys[strtolower($row['filename'])])) |
|
| 343 | 357 | unset($smileys[strtolower($row['filename'])]); |
| 358 | + } |
|
| 344 | 359 | $smcFunc['db_free_result']($request); |
| 345 | 360 | |
| 346 | 361 | $context['current_set']['can_import'] = count($smileys); |
@@ -355,13 +370,14 @@ discard block |
||
| 355 | 370 | $dir = dir($modSettings['smileys_dir']); |
| 356 | 371 | while ($entry = $dir->read()) |
| 357 | 372 | { |
| 358 | - if (!in_array($entry, array('.', '..')) && is_dir($modSettings['smileys_dir'] . '/' . $entry)) |
|
| 359 | - $context['smiley_set_dirs'][] = array( |
|
| 373 | + if (!in_array($entry, array('.', '..')) && is_dir($modSettings['smileys_dir'] . '/' . $entry)) { |
|
| 374 | + $context['smiley_set_dirs'][] = array( |
|
| 360 | 375 | 'id' => $entry, |
| 361 | 376 | 'path' => $modSettings['smileys_dir'] . '/' . $entry, |
| 362 | 377 | 'selectable' => $entry == $context['current_set']['path'] || !in_array($entry, explode(',', $modSettings['smiley_sets_known'])), |
| 363 | 378 | 'current' => $entry == $context['current_set']['path'], |
| 364 | 379 | ); |
| 380 | + } |
|
| 365 | 381 | } |
| 366 | 382 | $dir->close(); |
| 367 | 383 | } |
@@ -371,8 +387,9 @@ discard block |
||
| 371 | 387 | createToken('admin-mss', 'request'); |
| 372 | 388 | |
| 373 | 389 | // In case we need to import smileys, we need to add the token in now. |
| 374 | - if (isset($context['current_set']['import_url'])) |
|
| 375 | - $context['current_set']['import_url'] .= ';' . $context['admin-mss_token_var'] . '=' . $context['admin-mss_token']; |
|
| 390 | + if (isset($context['current_set']['import_url'])) { |
|
| 391 | + $context['current_set']['import_url'] .= ';' . $context['admin-mss_token_var'] . '=' . $context['admin-mss_token']; |
|
| 392 | + } |
|
| 376 | 393 | |
| 377 | 394 | $listOptions = array( |
| 378 | 395 | 'id' => 'smiley_set_list', |
@@ -510,21 +527,23 @@ discard block |
||
| 510 | 527 | $cols['name'][] = $set_names[$i]; |
| 511 | 528 | } |
| 512 | 529 | $sort_flag = strpos($sort, 'DESC') === false ? SORT_ASC : SORT_DESC; |
| 513 | - if (substr($sort, 0, 4) === 'name') |
|
| 514 | - array_multisort($cols['name'], $sort_flag, SORT_REGULAR, $cols['path'], $cols['selected'], $cols['id']); |
|
| 515 | - elseif (substr($sort, 0, 4) === 'path') |
|
| 516 | - array_multisort($cols['path'], $sort_flag, SORT_REGULAR, $cols['name'], $cols['selected'], $cols['id']); |
|
| 517 | - else |
|
| 518 | - array_multisort($cols['selected'], $sort_flag, SORT_REGULAR, $cols['path'], $cols['name'], $cols['id']); |
|
| 530 | + if (substr($sort, 0, 4) === 'name') { |
|
| 531 | + array_multisort($cols['name'], $sort_flag, SORT_REGULAR, $cols['path'], $cols['selected'], $cols['id']); |
|
| 532 | + } elseif (substr($sort, 0, 4) === 'path') { |
|
| 533 | + array_multisort($cols['path'], $sort_flag, SORT_REGULAR, $cols['name'], $cols['selected'], $cols['id']); |
|
| 534 | + } else { |
|
| 535 | + array_multisort($cols['selected'], $sort_flag, SORT_REGULAR, $cols['path'], $cols['name'], $cols['id']); |
|
| 536 | + } |
|
| 519 | 537 | |
| 520 | 538 | $smiley_sets = array(); |
| 521 | - foreach ($cols['id'] as $i => $id) |
|
| 522 | - $smiley_sets[] = array( |
|
| 539 | + foreach ($cols['id'] as $i => $id) { |
|
| 540 | + $smiley_sets[] = array( |
|
| 523 | 541 | 'id' => $id, |
| 524 | 542 | 'path' => $cols['path'][$i], |
| 525 | 543 | 'name' => $cols['name'][$i], |
| 526 | 544 | 'selected' => $cols['path'][$i] == $modSettings['smiley_sets_default'] |
| 527 | 545 | ); |
| 546 | + } |
|
| 528 | 547 | |
| 529 | 548 | return $smiley_sets; |
| 530 | 549 | } |
@@ -553,13 +572,14 @@ discard block |
||
| 553 | 572 | $context['smileys_dir_found'] = is_dir($context['smileys_dir']); |
| 554 | 573 | $context['smiley_sets'] = explode(',', $modSettings['smiley_sets_known']); |
| 555 | 574 | $set_names = explode("\n", $modSettings['smiley_sets_names']); |
| 556 | - foreach ($context['smiley_sets'] as $i => $set) |
|
| 557 | - $context['smiley_sets'][$i] = array( |
|
| 575 | + foreach ($context['smiley_sets'] as $i => $set) { |
|
| 576 | + $context['smiley_sets'][$i] = array( |
|
| 558 | 577 | 'id' => $i, |
| 559 | 578 | 'path' => $smcFunc['htmlspecialchars']($set), |
| 560 | 579 | 'name' => $smcFunc['htmlspecialchars']($set_names[$i]), |
| 561 | 580 | 'selected' => $set == $modSettings['smiley_sets_default'] |
| 562 | 581 | ); |
| 582 | + } |
|
| 563 | 583 | |
| 564 | 584 | // Submitting a form? |
| 565 | 585 | if (isset($_POST[$context['session_var']], $_POST['smiley_code'])) |
@@ -575,8 +595,9 @@ discard block |
||
| 575 | 595 | $_POST['smiley_filename'] = htmltrim__recursive($_POST['smiley_filename']); |
| 576 | 596 | |
| 577 | 597 | // Make sure some code was entered. |
| 578 | - if (empty($_POST['smiley_code'])) |
|
| 579 | - fatal_lang_error('smiley_has_no_code'); |
|
| 598 | + if (empty($_POST['smiley_code'])) { |
|
| 599 | + fatal_lang_error('smiley_has_no_code'); |
|
| 600 | + } |
|
| 580 | 601 | |
| 581 | 602 | // Check whether the new code has duplicates. It should be unique. |
| 582 | 603 | $request = $smcFunc['db_query']('', ' |
@@ -588,8 +609,9 @@ discard block |
||
| 588 | 609 | 'smiley_code' => $_POST['smiley_code'], |
| 589 | 610 | ) |
| 590 | 611 | ); |
| 591 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
| 592 | - fatal_lang_error('smiley_not_unique'); |
|
| 612 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
| 613 | + fatal_lang_error('smiley_not_unique'); |
|
| 614 | + } |
|
| 593 | 615 | $smcFunc['db_free_result']($request); |
| 594 | 616 | |
| 595 | 617 | // If we are uploading - check all the smiley sets are writable! |
@@ -598,38 +620,44 @@ discard block |
||
| 598 | 620 | $writeErrors = array(); |
| 599 | 621 | foreach ($context['smiley_sets'] as $set) |
| 600 | 622 | { |
| 601 | - if (!is_writable($context['smileys_dir'] . '/' . un_htmlspecialchars($set['path']))) |
|
| 602 | - $writeErrors[] = $set['path']; |
|
| 623 | + if (!is_writable($context['smileys_dir'] . '/' . un_htmlspecialchars($set['path']))) { |
|
| 624 | + $writeErrors[] = $set['path']; |
|
| 625 | + } |
|
| 626 | + } |
|
| 627 | + if (!empty($writeErrors)) { |
|
| 628 | + fatal_lang_error('smileys_upload_error_notwritable', true, array(implode(', ', $writeErrors))); |
|
| 603 | 629 | } |
| 604 | - if (!empty($writeErrors)) |
|
| 605 | - fatal_lang_error('smileys_upload_error_notwritable', true, array(implode(', ', $writeErrors))); |
|
| 606 | 630 | } |
| 607 | 631 | |
| 608 | 632 | // Uploading just one smiley for all of them? |
| 609 | 633 | if (isset($_POST['sameall']) && isset($_FILES['uploadSmiley']['name']) && $_FILES['uploadSmiley']['name'] != '') |
| 610 | 634 | { |
| 611 | - if (!is_uploaded_file($_FILES['uploadSmiley']['tmp_name']) || (ini_get('open_basedir') == '' && !file_exists($_FILES['uploadSmiley']['tmp_name']))) |
|
| 612 | - fatal_lang_error('smileys_upload_error'); |
|
| 635 | + if (!is_uploaded_file($_FILES['uploadSmiley']['tmp_name']) || (ini_get('open_basedir') == '' && !file_exists($_FILES['uploadSmiley']['tmp_name']))) { |
|
| 636 | + fatal_lang_error('smileys_upload_error'); |
|
| 637 | + } |
|
| 613 | 638 | |
| 614 | 639 | // Sorry, no spaces, dots, or anything else but letters allowed. |
| 615 | 640 | $_FILES['uploadSmiley']['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['uploadSmiley']['name']); |
| 616 | 641 | |
| 617 | 642 | // We only allow image files - it's THAT simple - no messing around here... |
| 618 | - if (!in_array(strtolower(substr(strrchr($_FILES['uploadSmiley']['name'], '.'), 1)), $allowedTypes)) |
|
| 619 | - fatal_lang_error('smileys_upload_error_types', false, array(implode(', ', $allowedTypes))); |
|
| 643 | + if (!in_array(strtolower(substr(strrchr($_FILES['uploadSmiley']['name'], '.'), 1)), $allowedTypes)) { |
|
| 644 | + fatal_lang_error('smileys_upload_error_types', false, array(implode(', ', $allowedTypes))); |
|
| 645 | + } |
|
| 620 | 646 | |
| 621 | 647 | // We only need the filename... |
| 622 | 648 | $destName = basename($_FILES['uploadSmiley']['name']); |
| 623 | 649 | |
| 624 | 650 | // Make sure they aren't trying to upload a nasty file - for their own good here! |
| 625 | - if (in_array(strtolower($destName), $disabledFiles)) |
|
| 626 | - fatal_lang_error('smileys_upload_error_illegal'); |
|
| 651 | + if (in_array(strtolower($destName), $disabledFiles)) { |
|
| 652 | + fatal_lang_error('smileys_upload_error_illegal'); |
|
| 653 | + } |
|
| 627 | 654 | |
| 628 | 655 | // Check if the file already exists... and if not move it to EVERY smiley set directory. |
| 629 | 656 | $i = 0; |
| 630 | 657 | // Keep going until we find a set the file doesn't exist in. (or maybe it exists in all of them?) |
| 631 | - while (isset($context['smiley_sets'][$i]) && file_exists($context['smileys_dir'] . '/' . un_htmlspecialchars($context['smiley_sets'][$i]['path']) . '/' . $destName)) |
|
| 632 | - $i++; |
|
| 658 | + while (isset($context['smiley_sets'][$i]) && file_exists($context['smileys_dir'] . '/' . un_htmlspecialchars($context['smiley_sets'][$i]['path']) . '/' . $destName)) { |
|
| 659 | + $i++; |
|
| 660 | + } |
|
| 633 | 661 | |
| 634 | 662 | // Okay, we're going to put the smiley right here, since it's not there yet! |
| 635 | 663 | if (isset($context['smiley_sets'][$i]['path'])) |
@@ -644,8 +672,9 @@ discard block |
||
| 644 | 672 | $currentPath = $context['smileys_dir'] . '/' . un_htmlspecialchars($context['smiley_sets'][$i]['path']) . '/' . $destName; |
| 645 | 673 | |
| 646 | 674 | // The file is already there! Don't overwrite it! |
| 647 | - if (file_exists($currentPath)) |
|
| 648 | - continue; |
|
| 675 | + if (file_exists($currentPath)) { |
|
| 676 | + continue; |
|
| 677 | + } |
|
| 649 | 678 | |
| 650 | 679 | // Okay, so copy the first one we made to here. |
| 651 | 680 | copy($smileyLocation, $currentPath); |
@@ -662,13 +691,15 @@ discard block |
||
| 662 | 691 | $newName = ''; |
| 663 | 692 | foreach ($_FILES as $name => $data) |
| 664 | 693 | { |
| 665 | - if ($_FILES[$name]['name'] == '') |
|
| 666 | - fatal_lang_error('smileys_upload_error_blank'); |
|
| 694 | + if ($_FILES[$name]['name'] == '') { |
|
| 695 | + fatal_lang_error('smileys_upload_error_blank'); |
|
| 696 | + } |
|
| 667 | 697 | |
| 668 | - if (empty($newName)) |
|
| 669 | - $newName = basename($_FILES[$name]['name']); |
|
| 670 | - elseif (basename($_FILES[$name]['name']) != $newName) |
|
| 671 | - fatal_lang_error('smileys_upload_error_name'); |
|
| 698 | + if (empty($newName)) { |
|
| 699 | + $newName = basename($_FILES[$name]['name']); |
|
| 700 | + } elseif (basename($_FILES[$name]['name']) != $newName) { |
|
| 701 | + fatal_lang_error('smileys_upload_error_name'); |
|
| 702 | + } |
|
| 672 | 703 | } |
| 673 | 704 | |
| 674 | 705 | foreach ($context['smiley_sets'] as $i => $set) |
@@ -676,31 +707,36 @@ discard block |
||
| 676 | 707 | $set['name'] = un_htmlspecialchars($set['name']); |
| 677 | 708 | $set['path'] = un_htmlspecialchars($set['path']); |
| 678 | 709 | |
| 679 | - if (!isset($_FILES['individual_' . $set['name']]['name']) || $_FILES['individual_' . $set['name']]['name'] == '') |
|
| 680 | - continue; |
|
| 710 | + if (!isset($_FILES['individual_' . $set['name']]['name']) || $_FILES['individual_' . $set['name']]['name'] == '') { |
|
| 711 | + continue; |
|
| 712 | + } |
|
| 681 | 713 | |
| 682 | 714 | // Got one... |
| 683 | - if (!is_uploaded_file($_FILES['individual_' . $set['name']]['tmp_name']) || (ini_get('open_basedir') == '' && !file_exists($_FILES['individual_' . $set['name']]['tmp_name']))) |
|
| 684 | - fatal_lang_error('smileys_upload_error'); |
|
| 715 | + if (!is_uploaded_file($_FILES['individual_' . $set['name']]['tmp_name']) || (ini_get('open_basedir') == '' && !file_exists($_FILES['individual_' . $set['name']]['tmp_name']))) { |
|
| 716 | + fatal_lang_error('smileys_upload_error'); |
|
| 717 | + } |
|
| 685 | 718 | |
| 686 | 719 | // Sorry, no spaces, dots, or anything else but letters allowed. |
| 687 | 720 | $_FILES['individual_' . $set['name']]['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['individual_' . $set['name']]['name']); |
| 688 | 721 | |
| 689 | 722 | // We only allow image files - it's THAT simple - no messing around here... |
| 690 | - if (!in_array(strtolower(substr(strrchr($_FILES['individual_' . $set['name']]['name'], '.'), 1)), $allowedTypes)) |
|
| 691 | - fatal_lang_error('smileys_upload_error_types', false, array(implode(', ', $allowedTypes))); |
|
| 723 | + if (!in_array(strtolower(substr(strrchr($_FILES['individual_' . $set['name']]['name'], '.'), 1)), $allowedTypes)) { |
|
| 724 | + fatal_lang_error('smileys_upload_error_types', false, array(implode(', ', $allowedTypes))); |
|
| 725 | + } |
|
| 692 | 726 | |
| 693 | 727 | // We only need the filename... |
| 694 | 728 | $destName = basename($_FILES['individual_' . $set['name']]['name']); |
| 695 | 729 | |
| 696 | 730 | // Make sure they aren't trying to upload a nasty file - for their own good here! |
| 697 | - if (in_array(strtolower($destName), $disabledFiles)) |
|
| 698 | - fatal_lang_error('smileys_upload_error_illegal'); |
|
| 731 | + if (in_array(strtolower($destName), $disabledFiles)) { |
|
| 732 | + fatal_lang_error('smileys_upload_error_illegal'); |
|
| 733 | + } |
|
| 699 | 734 | |
| 700 | 735 | // If the file exists - ignore it. |
| 701 | 736 | $smileyLocation = $context['smileys_dir'] . '/' . $set['path'] . '/' . $destName; |
| 702 | - if (file_exists($smileyLocation)) |
|
| 703 | - continue; |
|
| 737 | + if (file_exists($smileyLocation)) { |
|
| 738 | + continue; |
|
| 739 | + } |
|
| 704 | 740 | |
| 705 | 741 | // Finally - move the image! |
| 706 | 742 | move_uploaded_file($_FILES['individual_' . $set['name']]['tmp_name'], $smileyLocation); |
@@ -712,8 +748,9 @@ discard block |
||
| 712 | 748 | } |
| 713 | 749 | |
| 714 | 750 | // Also make sure a filename was given. |
| 715 | - if (empty($_POST['smiley_filename'])) |
|
| 716 | - fatal_lang_error('smiley_has_no_filename'); |
|
| 751 | + if (empty($_POST['smiley_filename'])) { |
|
| 752 | + fatal_lang_error('smiley_has_no_filename'); |
|
| 753 | + } |
|
| 717 | 754 | |
| 718 | 755 | // Find the position on the right. |
| 719 | 756 | $smiley_order = '0'; |
@@ -732,8 +769,9 @@ discard block |
||
| 732 | 769 | list ($smiley_order) = $smcFunc['db_fetch_row']($request); |
| 733 | 770 | $smcFunc['db_free_result']($request); |
| 734 | 771 | |
| 735 | - if (empty($smiley_order)) |
|
| 736 | - $smiley_order = '0'; |
|
| 772 | + if (empty($smiley_order)) { |
|
| 773 | + $smiley_order = '0'; |
|
| 774 | + } |
|
| 737 | 775 | } |
| 738 | 776 | $smcFunc['db_insert']('', |
| 739 | 777 | '{db_prefix}smileys', |
@@ -761,17 +799,19 @@ discard block |
||
| 761 | 799 | { |
| 762 | 800 | foreach ($context['smiley_sets'] as $smiley_set) |
| 763 | 801 | { |
| 764 | - if (!file_exists($context['smileys_dir'] . '/' . un_htmlspecialchars($smiley_set['path']))) |
|
| 765 | - continue; |
|
| 802 | + if (!file_exists($context['smileys_dir'] . '/' . un_htmlspecialchars($smiley_set['path']))) { |
|
| 803 | + continue; |
|
| 804 | + } |
|
| 766 | 805 | |
| 767 | 806 | $dir = dir($context['smileys_dir'] . '/' . un_htmlspecialchars($smiley_set['path'])); |
| 768 | 807 | while ($entry = $dir->read()) |
| 769 | 808 | { |
| 770 | - if (!in_array($entry, $context['filenames']) && in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) |
|
| 771 | - $context['filenames'][strtolower($entry)] = array( |
|
| 809 | + if (!in_array($entry, $context['filenames']) && in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) { |
|
| 810 | + $context['filenames'][strtolower($entry)] = array( |
|
| 772 | 811 | 'id' => $smcFunc['htmlspecialchars']($entry), |
| 773 | 812 | 'selected' => false, |
| 774 | 813 | ); |
| 814 | + } |
|
| 775 | 815 | } |
| 776 | 816 | $dir->close(); |
| 777 | 817 | } |
@@ -809,17 +849,19 @@ discard block |
||
| 809 | 849 | // Changing the selected smileys? |
| 810 | 850 | if (isset($_POST['smiley_action']) && !empty($_POST['checked_smileys'])) |
| 811 | 851 | { |
| 812 | - foreach ($_POST['checked_smileys'] as $id => $smiley_id) |
|
| 813 | - $_POST['checked_smileys'][$id] = (int) $smiley_id; |
|
| 852 | + foreach ($_POST['checked_smileys'] as $id => $smiley_id) { |
|
| 853 | + $_POST['checked_smileys'][$id] = (int) $smiley_id; |
|
| 854 | + } |
|
| 814 | 855 | |
| 815 | - if ($_POST['smiley_action'] == 'delete') |
|
| 816 | - $smcFunc['db_query']('', ' |
|
| 856 | + if ($_POST['smiley_action'] == 'delete') { |
|
| 857 | + $smcFunc['db_query']('', ' |
|
| 817 | 858 | DELETE FROM {db_prefix}smileys |
| 818 | 859 | WHERE id_smiley IN ({array_int:checked_smileys})', |
| 819 | 860 | array( |
| 820 | 861 | 'checked_smileys' => $_POST['checked_smileys'], |
| 821 | 862 | ) |
| 822 | 863 | ); |
| 864 | + } |
|
| 823 | 865 | // Changing the status of the smiley? |
| 824 | 866 | else |
| 825 | 867 | { |
@@ -829,8 +871,8 @@ discard block |
||
| 829 | 871 | 'hidden' => 1, |
| 830 | 872 | 'popup' => 2 |
| 831 | 873 | ); |
| 832 | - if (isset($displayTypes[$_POST['smiley_action']])) |
|
| 833 | - $smcFunc['db_query']('', ' |
|
| 874 | + if (isset($displayTypes[$_POST['smiley_action']])) { |
|
| 875 | + $smcFunc['db_query']('', ' |
|
| 834 | 876 | UPDATE {db_prefix}smileys |
| 835 | 877 | SET hidden = {int:display_type} |
| 836 | 878 | WHERE id_smiley IN ({array_int:checked_smileys})', |
@@ -839,6 +881,7 @@ discard block |
||
| 839 | 881 | 'display_type' => $displayTypes[$_POST['smiley_action']], |
| 840 | 882 | ) |
| 841 | 883 | ); |
| 884 | + } |
|
| 842 | 885 | } |
| 843 | 886 | } |
| 844 | 887 | // Create/modify a smiley. |
@@ -864,12 +907,14 @@ discard block |
||
| 864 | 907 | $_POST['smiley_location'] = empty($_POST['smiley_location']) || $_POST['smiley_location'] > 2 || $_POST['smiley_location'] < 0 ? 0 : (int) $_POST['smiley_location']; |
| 865 | 908 | |
| 866 | 909 | // Make sure some code was entered. |
| 867 | - if (empty($_POST['smiley_code'])) |
|
| 868 | - fatal_lang_error('smiley_has_no_code'); |
|
| 910 | + if (empty($_POST['smiley_code'])) { |
|
| 911 | + fatal_lang_error('smiley_has_no_code'); |
|
| 912 | + } |
|
| 869 | 913 | |
| 870 | 914 | // Also make sure a filename was given. |
| 871 | - if (empty($_POST['smiley_filename'])) |
|
| 872 | - fatal_lang_error('smiley_has_no_filename'); |
|
| 915 | + if (empty($_POST['smiley_filename'])) { |
|
| 916 | + fatal_lang_error('smiley_has_no_filename'); |
|
| 917 | + } |
|
| 873 | 918 | |
| 874 | 919 | // Check whether the new code has duplicates. It should be unique. |
| 875 | 920 | $request = $smcFunc['db_query']('', ' |
@@ -883,8 +928,9 @@ discard block |
||
| 883 | 928 | 'smiley_code' => $_POST['smiley_code'], |
| 884 | 929 | ) |
| 885 | 930 | ); |
| 886 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
| 887 | - fatal_lang_error('smiley_not_unique'); |
|
| 931 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
| 932 | + fatal_lang_error('smiley_not_unique'); |
|
| 933 | + } |
|
| 888 | 934 | $smcFunc['db_free_result']($request); |
| 889 | 935 | |
| 890 | 936 | $smcFunc['db_query']('', ' |
@@ -913,13 +959,14 @@ discard block |
||
| 913 | 959 | // Load all known smiley sets. |
| 914 | 960 | $context['smiley_sets'] = explode(',', $modSettings['smiley_sets_known']); |
| 915 | 961 | $set_names = explode("\n", $modSettings['smiley_sets_names']); |
| 916 | - foreach ($context['smiley_sets'] as $i => $set) |
|
| 917 | - $context['smiley_sets'][$i] = array( |
|
| 962 | + foreach ($context['smiley_sets'] as $i => $set) { |
|
| 963 | + $context['smiley_sets'][$i] = array( |
|
| 918 | 964 | 'id' => $i, |
| 919 | 965 | 'path' => $smcFunc['htmlspecialchars']($set), |
| 920 | 966 | 'name' => $smcFunc['htmlspecialchars']($set_names[$i]), |
| 921 | 967 | 'selected' => $set == $modSettings['smiley_sets_default'] |
| 922 | 968 | ); |
| 969 | + } |
|
| 923 | 970 | |
| 924 | 971 | // Prepare overview of all (custom) smileys. |
| 925 | 972 | if ($context['sub_action'] == 'editsmileys') |
@@ -935,9 +982,10 @@ discard block |
||
| 935 | 982 | // Create a list of options for selecting smiley sets. |
| 936 | 983 | $smileyset_option_list = ' |
| 937 | 984 | <select name="set" onchange="changeSet(this.options[this.selectedIndex].value);">'; |
| 938 | - foreach ($context['smiley_sets'] as $smiley_set) |
|
| 939 | - $smileyset_option_list .= ' |
|
| 985 | + foreach ($context['smiley_sets'] as $smiley_set) { |
|
| 986 | + $smileyset_option_list .= ' |
|
| 940 | 987 | <option value="' . $smiley_set['path'] . '"' . ($modSettings['smiley_sets_default'] == $smiley_set['path'] ? ' selected' : '') . '>' . $smiley_set['name'] . '</option>'; |
| 988 | + } |
|
| 941 | 989 | $smileyset_option_list .= ' |
| 942 | 990 | </select>'; |
| 943 | 991 | |
@@ -999,12 +1047,13 @@ discard block |
||
| 999 | 1047 | 'data' => array( |
| 1000 | 1048 | 'function' => function ($rowData) use ($txt) |
| 1001 | 1049 | { |
| 1002 | - if (empty($rowData['hidden'])) |
|
| 1003 | - return $txt['smileys_location_form']; |
|
| 1004 | - elseif ($rowData['hidden'] == 1) |
|
| 1005 | - return $txt['smileys_location_hidden']; |
|
| 1006 | - else |
|
| 1007 | - return $txt['smileys_location_popup']; |
|
| 1050 | + if (empty($rowData['hidden'])) { |
|
| 1051 | + return $txt['smileys_location_form']; |
|
| 1052 | + } elseif ($rowData['hidden'] == 1) { |
|
| 1053 | + return $txt['smileys_location_hidden']; |
|
| 1054 | + } else { |
|
| 1055 | + return $txt['smileys_location_popup']; |
|
| 1056 | + } |
|
| 1008 | 1057 | }, |
| 1009 | 1058 | ), |
| 1010 | 1059 | 'sort' => array( |
@@ -1019,19 +1068,22 @@ discard block |
||
| 1019 | 1068 | 'data' => array( |
| 1020 | 1069 | 'function' => function ($rowData) use ($context, $txt, $modSettings, $smcFunc) |
| 1021 | 1070 | { |
| 1022 | - if (empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir'])) |
|
| 1023 | - return $smcFunc['htmlspecialchars']($rowData['description']); |
|
| 1071 | + if (empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir'])) { |
|
| 1072 | + return $smcFunc['htmlspecialchars']($rowData['description']); |
|
| 1073 | + } |
|
| 1024 | 1074 | |
| 1025 | 1075 | // Check if there are smileys missing in some sets. |
| 1026 | 1076 | $missing_sets = array(); |
| 1027 | - foreach ($context['smiley_sets'] as $smiley_set) |
|
| 1028 | - if (!file_exists(sprintf('%1$s/%2$s/%3$s', $modSettings['smileys_dir'], $smiley_set['path'], $rowData['filename']))) |
|
| 1077 | + foreach ($context['smiley_sets'] as $smiley_set) { |
|
| 1078 | + if (!file_exists(sprintf('%1$s/%2$s/%3$s', $modSettings['smileys_dir'], $smiley_set['path'], $rowData['filename']))) |
|
| 1029 | 1079 | $missing_sets[] = $smiley_set['path']; |
| 1080 | + } |
|
| 1030 | 1081 | |
| 1031 | 1082 | $description = $smcFunc['htmlspecialchars']($rowData['description']); |
| 1032 | 1083 | |
| 1033 | - if (!empty($missing_sets)) |
|
| 1034 | - $description .= sprintf('<br><span class="smalltext"><strong>%1$s:</strong> %2$s</span>', $txt['smileys_not_found_in_set'], implode(', ', $missing_sets)); |
|
| 1084 | + if (!empty($missing_sets)) { |
|
| 1085 | + $description .= sprintf('<br><span class="smalltext"><strong>%1$s:</strong> %2$s</span>', $txt['smileys_not_found_in_set'], implode(', ', $missing_sets)); |
|
| 1086 | + } |
|
| 1035 | 1087 | |
| 1036 | 1088 | return $description; |
| 1037 | 1089 | }, |
@@ -1147,13 +1199,14 @@ discard block |
||
| 1147 | 1199 | $context['smileys_dir_found'] = is_dir($context['smileys_dir']); |
| 1148 | 1200 | $context['smiley_sets'] = explode(',', $modSettings['smiley_sets_known']); |
| 1149 | 1201 | $set_names = explode("\n", $modSettings['smiley_sets_names']); |
| 1150 | - foreach ($context['smiley_sets'] as $i => $set) |
|
| 1151 | - $context['smiley_sets'][$i] = array( |
|
| 1202 | + foreach ($context['smiley_sets'] as $i => $set) { |
|
| 1203 | + $context['smiley_sets'][$i] = array( |
|
| 1152 | 1204 | 'id' => $i, |
| 1153 | 1205 | 'path' => $smcFunc['htmlspecialchars']($set), |
| 1154 | 1206 | 'name' => $smcFunc['htmlspecialchars']($set_names[$i]), |
| 1155 | 1207 | 'selected' => $set == $modSettings['smiley_sets_default'] |
| 1156 | 1208 | ); |
| 1209 | + } |
|
| 1157 | 1210 | |
| 1158 | 1211 | $context['selected_set'] = $modSettings['smiley_sets_default']; |
| 1159 | 1212 | |
@@ -1163,17 +1216,19 @@ discard block |
||
| 1163 | 1216 | { |
| 1164 | 1217 | foreach ($context['smiley_sets'] as $smiley_set) |
| 1165 | 1218 | { |
| 1166 | - if (!file_exists($context['smileys_dir'] . '/' . un_htmlspecialchars($smiley_set['path']))) |
|
| 1167 | - continue; |
|
| 1219 | + if (!file_exists($context['smileys_dir'] . '/' . un_htmlspecialchars($smiley_set['path']))) { |
|
| 1220 | + continue; |
|
| 1221 | + } |
|
| 1168 | 1222 | |
| 1169 | 1223 | $dir = dir($context['smileys_dir'] . '/' . un_htmlspecialchars($smiley_set['path'])); |
| 1170 | 1224 | while ($entry = $dir->read()) |
| 1171 | 1225 | { |
| 1172 | - if (!in_array($entry, $context['filenames']) && in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) |
|
| 1173 | - $context['filenames'][strtolower($entry)] = array( |
|
| 1226 | + if (!in_array($entry, $context['filenames']) && in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) { |
|
| 1227 | + $context['filenames'][strtolower($entry)] = array( |
|
| 1174 | 1228 | 'id' => $smcFunc['htmlspecialchars']($entry), |
| 1175 | 1229 | 'selected' => false, |
| 1176 | 1230 | ); |
| 1231 | + } |
|
| 1177 | 1232 | } |
| 1178 | 1233 | $dir->close(); |
| 1179 | 1234 | } |
@@ -1188,8 +1243,9 @@ discard block |
||
| 1188 | 1243 | 'current_smiley' => (int) $_REQUEST['smiley'], |
| 1189 | 1244 | ) |
| 1190 | 1245 | ); |
| 1191 | - if ($smcFunc['db_num_rows']($request) != 1) |
|
| 1192 | - fatal_lang_error('smiley_not_found'); |
|
| 1246 | + if ($smcFunc['db_num_rows']($request) != 1) { |
|
| 1247 | + fatal_lang_error('smiley_not_found'); |
|
| 1248 | + } |
|
| 1193 | 1249 | $context['current_smiley'] = $smcFunc['db_fetch_assoc']($request); |
| 1194 | 1250 | $smcFunc['db_free_result']($request); |
| 1195 | 1251 | |
@@ -1197,8 +1253,9 @@ discard block |
||
| 1197 | 1253 | $context['current_smiley']['filename'] = $smcFunc['htmlspecialchars']($context['current_smiley']['filename']); |
| 1198 | 1254 | $context['current_smiley']['description'] = $smcFunc['htmlspecialchars']($context['current_smiley']['description']); |
| 1199 | 1255 | |
| 1200 | - if (isset($context['filenames'][strtolower($context['current_smiley']['filename'])])) |
|
| 1201 | - $context['filenames'][strtolower($context['current_smiley']['filename'])]['selected'] = true; |
|
| 1256 | + if (isset($context['filenames'][strtolower($context['current_smiley']['filename'])])) { |
|
| 1257 | + $context['filenames'][strtolower($context['current_smiley']['filename'])]['selected'] = true; |
|
| 1258 | + } |
|
| 1202 | 1259 | } |
| 1203 | 1260 | } |
| 1204 | 1261 | |
@@ -1223,8 +1280,9 @@ discard block |
||
| 1223 | 1280 | ) |
| 1224 | 1281 | ); |
| 1225 | 1282 | $smileys = array(); |
| 1226 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1227 | - $smileys[] = $row; |
|
| 1283 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1284 | + $smileys[] = $row; |
|
| 1285 | + } |
|
| 1228 | 1286 | $smcFunc['db_free_result']($request); |
| 1229 | 1287 | |
| 1230 | 1288 | return $smileys; |
@@ -1264,8 +1322,9 @@ discard block |
||
| 1264 | 1322 | $_GET['location'] = empty($_GET['location']) || $_GET['location'] != 'popup' ? 0 : 2; |
| 1265 | 1323 | $_GET['source'] = empty($_GET['source']) ? 0 : (int) $_GET['source']; |
| 1266 | 1324 | |
| 1267 | - if (empty($_GET['source'])) |
|
| 1268 | - fatal_lang_error('smiley_not_found'); |
|
| 1325 | + if (empty($_GET['source'])) { |
|
| 1326 | + fatal_lang_error('smiley_not_found'); |
|
| 1327 | + } |
|
| 1269 | 1328 | |
| 1270 | 1329 | if (!empty($_GET['after'])) |
| 1271 | 1330 | { |
@@ -1281,12 +1340,12 @@ discard block |
||
| 1281 | 1340 | 'after_smiley' => $_GET['after'], |
| 1282 | 1341 | ) |
| 1283 | 1342 | ); |
| 1284 | - if ($smcFunc['db_num_rows']($request) != 1) |
|
| 1285 | - fatal_lang_error('smiley_not_found'); |
|
| 1343 | + if ($smcFunc['db_num_rows']($request) != 1) { |
|
| 1344 | + fatal_lang_error('smiley_not_found'); |
|
| 1345 | + } |
|
| 1286 | 1346 | list ($smiley_row, $smiley_order, $smileyLocation) = $smcFunc['db_fetch_row']($request); |
| 1287 | 1347 | $smcFunc['db_free_result']($request); |
| 1288 | - } |
|
| 1289 | - else |
|
| 1348 | + } else |
|
| 1290 | 1349 | { |
| 1291 | 1350 | $smiley_row = (int) $_GET['row']; |
| 1292 | 1351 | $smiley_order = -1; |
@@ -1360,14 +1419,15 @@ discard block |
||
| 1360 | 1419 | $context['move_smiley'] = empty($_REQUEST['move']) ? 0 : (int) $_REQUEST['move']; |
| 1361 | 1420 | |
| 1362 | 1421 | // Make sure all rows are sequential. |
| 1363 | - foreach (array_keys($context['smileys']) as $location) |
|
| 1364 | - $context['smileys'][$location] = array( |
|
| 1422 | + foreach (array_keys($context['smileys']) as $location) { |
|
| 1423 | + $context['smileys'][$location] = array( |
|
| 1365 | 1424 | 'id' => $location, |
| 1366 | 1425 | 'title' => $location == 'postform' ? $txt['smileys_location_form'] : $txt['smileys_location_popup'], |
| 1367 | 1426 | 'description' => $location == 'postform' ? $txt['smileys_location_form_description'] : $txt['smileys_location_popup_description'], |
| 1368 | 1427 | 'last_row' => count($context['smileys'][$location]['rows']), |
| 1369 | 1428 | 'rows' => array_values($context['smileys'][$location]['rows']), |
| 1370 | 1429 | ); |
| 1430 | + } |
|
| 1371 | 1431 | |
| 1372 | 1432 | // Check & fix smileys that are not ordered properly in the database. |
| 1373 | 1433 | foreach (array_keys($context['smileys']) as $location) |
@@ -1392,8 +1452,8 @@ discard block |
||
| 1392 | 1452 | $context['smileys'][$location]['rows'][$id][0]['row'] = $id; |
| 1393 | 1453 | } |
| 1394 | 1454 | // Make sure the smiley order is always sequential. |
| 1395 | - foreach ($smiley_row as $order_id => $smiley) |
|
| 1396 | - if ($order_id != $smiley['order']) |
|
| 1455 | + foreach ($smiley_row as $order_id => $smiley) { |
|
| 1456 | + if ($order_id != $smiley['order']) |
|
| 1397 | 1457 | $smcFunc['db_query']('', ' |
| 1398 | 1458 | UPDATE {db_prefix}smileys |
| 1399 | 1459 | SET smiley_order = {int:new_order} |
@@ -1403,6 +1463,7 @@ discard block |
||
| 1403 | 1463 | 'current_smiley' => $smiley['id'], |
| 1404 | 1464 | ) |
| 1405 | 1465 | ); |
| 1466 | + } |
|
| 1406 | 1467 | } |
| 1407 | 1468 | } |
| 1408 | 1469 | |
@@ -1436,19 +1497,20 @@ discard block |
||
| 1436 | 1497 | |
| 1437 | 1498 | // Check that the smiley is from simplemachines.org, for now... maybe add mirroring later. |
| 1438 | 1499 | // @ TODO: Our current xml files serve http links. Allowing both for now until we serve https. |
| 1439 | - if (preg_match('~^https?://[\w_\-]+\.simplemachines\.org/~', $_REQUEST['set_gz']) == 0 || strpos($_REQUEST['set_gz'], 'dlattach') !== false) |
|
| 1440 | - fatal_lang_error('not_on_simplemachines'); |
|
| 1500 | + if (preg_match('~^https?://[\w_\-]+\.simplemachines\.org/~', $_REQUEST['set_gz']) == 0 || strpos($_REQUEST['set_gz'], 'dlattach') !== false) { |
|
| 1501 | + fatal_lang_error('not_on_simplemachines'); |
|
| 1502 | + } |
|
| 1441 | 1503 | |
| 1442 | 1504 | $destination = $packagesdir . '/' . $base_name; |
| 1443 | 1505 | |
| 1444 | - if (file_exists($destination)) |
|
| 1445 | - fatal_lang_error('package_upload_error_exists'); |
|
| 1506 | + if (file_exists($destination)) { |
|
| 1507 | + fatal_lang_error('package_upload_error_exists'); |
|
| 1508 | + } |
|
| 1446 | 1509 | |
| 1447 | 1510 | // Let's copy it to the Packages directory |
| 1448 | 1511 | file_put_contents($destination, fetch_web_data($_REQUEST['set_gz'])); |
| 1449 | 1512 | $testing = true; |
| 1450 | - } |
|
| 1451 | - elseif (isset($_REQUEST['package'])) |
|
| 1513 | + } elseif (isset($_REQUEST['package'])) |
|
| 1452 | 1514 | { |
| 1453 | 1515 | $base_name = basename($_REQUEST['package']); |
| 1454 | 1516 | $name = $smcFunc['htmlspecialchars'](strtok(basename($_REQUEST['package']), '.')); |
@@ -1457,12 +1519,14 @@ discard block |
||
| 1457 | 1519 | $destination = $packagesdir . '/' . basename($_REQUEST['package']); |
| 1458 | 1520 | } |
| 1459 | 1521 | |
| 1460 | - if (empty($destination) || !file_exists($destination)) |
|
| 1461 | - fatal_lang_error('package_no_file', false); |
|
| 1522 | + if (empty($destination) || !file_exists($destination)) { |
|
| 1523 | + fatal_lang_error('package_no_file', false); |
|
| 1524 | + } |
|
| 1462 | 1525 | |
| 1463 | 1526 | // Make sure temp directory exists and is empty. |
| 1464 | - if (file_exists($packagesdir . '/temp')) |
|
| 1465 | - deltree($packagesdir . '/temp', false); |
|
| 1527 | + if (file_exists($packagesdir . '/temp')) { |
|
| 1528 | + deltree($packagesdir . '/temp', false); |
|
| 1529 | + } |
|
| 1466 | 1530 | |
| 1467 | 1531 | if (!mktree($packagesdir . '/temp', 0755)) |
| 1468 | 1532 | { |
@@ -1474,31 +1538,37 @@ discard block |
||
| 1474 | 1538 | create_chmod_control(array($packagesdir . '/temp/delme.tmp'), array('destination_url' => $scripturl . '?action=admin;area=smileys;sa=install;set_gz=' . $_REQUEST['set_gz'], 'crash_on_error' => true)); |
| 1475 | 1539 | |
| 1476 | 1540 | deltree($packagesdir . '/temp', false); |
| 1477 | - if (!mktree($packagesdir . '/temp', 0777)) |
|
| 1478 | - fatal_lang_error('package_cant_download', false); |
|
| 1541 | + if (!mktree($packagesdir . '/temp', 0777)) { |
|
| 1542 | + fatal_lang_error('package_cant_download', false); |
|
| 1543 | + } |
|
| 1479 | 1544 | } |
| 1480 | 1545 | } |
| 1481 | 1546 | |
| 1482 | 1547 | $extracted = read_tgz_file($destination, $packagesdir . '/temp'); |
| 1483 | - if (!$extracted) |
|
| 1484 | - fatal_lang_error('packageget_unable', false, array('https://custom.simplemachines.org/mods/index.php?action=search;type=12;basic_search=' . $name)); |
|
| 1485 | - if ($extracted && !file_exists($packagesdir . '/temp/package-info.xml')) |
|
| 1486 | - foreach ($extracted as $file) |
|
| 1548 | + if (!$extracted) { |
|
| 1549 | + fatal_lang_error('packageget_unable', false, array('https://custom.simplemachines.org/mods/index.php?action=search;type=12;basic_search=' . $name)); |
|
| 1550 | + } |
|
| 1551 | + if ($extracted && !file_exists($packagesdir . '/temp/package-info.xml')) { |
|
| 1552 | + foreach ($extracted as $file) |
|
| 1487 | 1553 | if (basename($file['filename']) == 'package-info.xml') |
| 1488 | 1554 | { |
| 1489 | 1555 | $base_path = dirname($file['filename']) . '/'; |
| 1556 | + } |
|
| 1490 | 1557 | break; |
| 1491 | 1558 | } |
| 1492 | 1559 | |
| 1493 | - if (!isset($base_path)) |
|
| 1494 | - $base_path = ''; |
|
| 1560 | + if (!isset($base_path)) { |
|
| 1561 | + $base_path = ''; |
|
| 1562 | + } |
|
| 1495 | 1563 | |
| 1496 | - if (!file_exists($packagesdir . '/temp/' . $base_path . 'package-info.xml')) |
|
| 1497 | - fatal_lang_error('package_get_error_missing_xml', false); |
|
| 1564 | + if (!file_exists($packagesdir . '/temp/' . $base_path . 'package-info.xml')) { |
|
| 1565 | + fatal_lang_error('package_get_error_missing_xml', false); |
|
| 1566 | + } |
|
| 1498 | 1567 | |
| 1499 | 1568 | $smileyInfo = getPackageInfo($context['filename']); |
| 1500 | - if (!is_array($smileyInfo)) |
|
| 1501 | - fatal_lang_error($smileyInfo); |
|
| 1569 | + if (!is_array($smileyInfo)) { |
|
| 1570 | + fatal_lang_error($smileyInfo); |
|
| 1571 | + } |
|
| 1502 | 1572 | |
| 1503 | 1573 | // See if it is installed? |
| 1504 | 1574 | $request = $smcFunc['db_query']('', ' |
@@ -1514,8 +1584,9 @@ discard block |
||
| 1514 | 1584 | ) |
| 1515 | 1585 | ); |
| 1516 | 1586 | |
| 1517 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
| 1518 | - fata_lang_error('package_installed_warning1'); |
|
| 1587 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
| 1588 | + fata_lang_error('package_installed_warning1'); |
|
| 1589 | + } |
|
| 1519 | 1590 | |
| 1520 | 1591 | // Everything is fine, now it's time to do something |
| 1521 | 1592 | $actions = parsePackageInfo($smileyInfo['xml'], true, 'install'); |
@@ -1532,23 +1603,23 @@ discard block |
||
| 1532 | 1603 | { |
| 1533 | 1604 | $has_readme = true; |
| 1534 | 1605 | $type = 'package_' . $action['type']; |
| 1535 | - if (file_exists($packagesdir . '/temp/' . $base_path . $action['filename'])) |
|
| 1536 | - $context[$type] = $smcFunc['htmlspecialchars'](trim(file_get_contents($packagesdir . '/temp/' . $base_path . $action['filename']), "\n\r")); |
|
| 1537 | - elseif (file_exists($action['filename'])) |
|
| 1538 | - $context[$type] = $smcFunc['htmlspecialchars'](trim(file_get_contents($action['filename']), "\n\r")); |
|
| 1606 | + if (file_exists($packagesdir . '/temp/' . $base_path . $action['filename'])) { |
|
| 1607 | + $context[$type] = $smcFunc['htmlspecialchars'](trim(file_get_contents($packagesdir . '/temp/' . $base_path . $action['filename']), "\n\r")); |
|
| 1608 | + } elseif (file_exists($action['filename'])) { |
|
| 1609 | + $context[$type] = $smcFunc['htmlspecialchars'](trim(file_get_contents($action['filename']), "\n\r")); |
|
| 1610 | + } |
|
| 1539 | 1611 | |
| 1540 | 1612 | if (!empty($action['parse_bbc'])) |
| 1541 | 1613 | { |
| 1542 | 1614 | require_once($sourcedir . '/Subs-Post.php'); |
| 1543 | 1615 | preparsecode($context[$type]); |
| 1544 | 1616 | $context[$type] = parse_bbc($context[$type]); |
| 1617 | + } else { |
|
| 1618 | + $context[$type] = nl2br($context[$type]); |
|
| 1545 | 1619 | } |
| 1546 | - else |
|
| 1547 | - $context[$type] = nl2br($context[$type]); |
|
| 1548 | 1620 | |
| 1549 | 1621 | continue; |
| 1550 | - } |
|
| 1551 | - elseif ($action['type'] == 'require-dir') |
|
| 1622 | + } elseif ($action['type'] == 'require-dir') |
|
| 1552 | 1623 | { |
| 1553 | 1624 | // Do this one... |
| 1554 | 1625 | $thisAction = array( |
@@ -1567,12 +1638,12 @@ discard block |
||
| 1567 | 1638 | ); |
| 1568 | 1639 | } |
| 1569 | 1640 | // @todo None given? |
| 1570 | - if (empty($thisAction['description'])) |
|
| 1571 | - $thisAction['description'] = isset($action['description']) ? $action['description'] : ''; |
|
| 1641 | + if (empty($thisAction['description'])) { |
|
| 1642 | + $thisAction['description'] = isset($action['description']) ? $action['description'] : ''; |
|
| 1643 | + } |
|
| 1572 | 1644 | |
| 1573 | 1645 | $context['actions'][] = $thisAction; |
| 1574 | - } |
|
| 1575 | - elseif ($action['type'] == 'credits') |
|
| 1646 | + } elseif ($action['type'] == 'credits') |
|
| 1576 | 1647 | { |
| 1577 | 1648 | // Time to build the billboard |
| 1578 | 1649 | $credits_tag = array( |
@@ -1631,12 +1702,14 @@ discard block |
||
| 1631 | 1702 | cache_put_data('posting_smileys', null, 480); |
| 1632 | 1703 | } |
| 1633 | 1704 | |
| 1634 | - if (file_exists($packagesdir . '/temp')) |
|
| 1635 | - deltree($packagesdir . '/temp'); |
|
| 1705 | + if (file_exists($packagesdir . '/temp')) { |
|
| 1706 | + deltree($packagesdir . '/temp'); |
|
| 1707 | + } |
|
| 1636 | 1708 | |
| 1637 | - if (!$testing) |
|
| 1638 | - redirectexit('action=admin;area=smileys'); |
|
| 1639 | -} |
|
| 1709 | + if (!$testing) { |
|
| 1710 | + redirectexit('action=admin;area=smileys'); |
|
| 1711 | + } |
|
| 1712 | + } |
|
| 1640 | 1713 | |
| 1641 | 1714 | /** |
| 1642 | 1715 | * A function to import new smileys from an existing directory into the database. |
@@ -1647,15 +1720,17 @@ discard block |
||
| 1647 | 1720 | { |
| 1648 | 1721 | global $modSettings, $smcFunc; |
| 1649 | 1722 | |
| 1650 | - if (empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir'] . '/' . $smileyPath)) |
|
| 1651 | - fatal_lang_error('smiley_set_unable_to_import'); |
|
| 1723 | + if (empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir'] . '/' . $smileyPath)) { |
|
| 1724 | + fatal_lang_error('smiley_set_unable_to_import'); |
|
| 1725 | + } |
|
| 1652 | 1726 | |
| 1653 | 1727 | $smileys = array(); |
| 1654 | 1728 | $dir = dir($modSettings['smileys_dir'] . '/' . $smileyPath); |
| 1655 | 1729 | while ($entry = $dir->read()) |
| 1656 | 1730 | { |
| 1657 | - if (in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) |
|
| 1658 | - $smileys[strtolower($entry)] = $entry; |
|
| 1731 | + if (in_array(strrchr($entry, '.'), array('.jpg', '.gif', '.jpeg', '.png'))) { |
|
| 1732 | + $smileys[strtolower($entry)] = $entry; |
|
| 1733 | + } |
|
| 1659 | 1734 | } |
| 1660 | 1735 | $dir->close(); |
| 1661 | 1736 | |
@@ -1668,9 +1743,10 @@ discard block |
||
| 1668 | 1743 | 'smiley_list' => $smileys, |
| 1669 | 1744 | ) |
| 1670 | 1745 | ); |
| 1671 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1672 | - if (isset($smileys[strtolower($row['filename'])])) |
|
| 1746 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1747 | + if (isset($smileys[strtolower($row['filename'])])) |
|
| 1673 | 1748 | unset($smileys[strtolower($row['filename'])]); |
| 1749 | + } |
|
| 1674 | 1750 | $smcFunc['db_free_result']($request); |
| 1675 | 1751 | |
| 1676 | 1752 | $request = $smcFunc['db_query']('', ' |
@@ -1687,9 +1763,10 @@ discard block |
||
| 1687 | 1763 | $smcFunc['db_free_result']($request); |
| 1688 | 1764 | |
| 1689 | 1765 | $new_smileys = array(); |
| 1690 | - foreach ($smileys as $smiley) |
|
| 1691 | - if (strlen($smiley) <= 48) |
|
| 1766 | + foreach ($smileys as $smiley) { |
|
| 1767 | + if (strlen($smiley) <= 48) |
|
| 1692 | 1768 | $new_smileys[] = array(':' . strtok($smiley, '.') . ':', $smiley, strtok($smiley, '.'), 0, ++$smiley_order); |
| 1769 | + } |
|
| 1693 | 1770 | |
| 1694 | 1771 | if (!empty($new_smileys)) |
| 1695 | 1772 | { |
@@ -1754,8 +1831,9 @@ discard block |
||
| 1754 | 1831 | if (isset($_POST['delete']) && !empty($_POST['checked_icons'])) |
| 1755 | 1832 | { |
| 1756 | 1833 | $deleteIcons = array(); |
| 1757 | - foreach ($_POST['checked_icons'] as $icon) |
|
| 1758 | - $deleteIcons[] = (int) $icon; |
|
| 1834 | + foreach ($_POST['checked_icons'] as $icon) { |
|
| 1835 | + $deleteIcons[] = (int) $icon; |
|
| 1836 | + } |
|
| 1759 | 1837 | |
| 1760 | 1838 | // Do the actual delete! |
| 1761 | 1839 | $smcFunc['db_query']('', ' |
@@ -1772,35 +1850,41 @@ discard block |
||
| 1772 | 1850 | $_GET['icon'] = (int) $_GET['icon']; |
| 1773 | 1851 | |
| 1774 | 1852 | // Do some preperation with the data... like check the icon exists *somewhere* |
| 1775 | - if (strpos($_POST['icon_filename'], '.png') !== false) |
|
| 1776 | - $_POST['icon_filename'] = substr($_POST['icon_filename'], 0, -4); |
|
| 1777 | - if (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon_filename'] . '.png')) |
|
| 1778 | - fatal_lang_error('icon_not_found'); |
|
| 1853 | + if (strpos($_POST['icon_filename'], '.png') !== false) { |
|
| 1854 | + $_POST['icon_filename'] = substr($_POST['icon_filename'], 0, -4); |
|
| 1855 | + } |
|
| 1856 | + if (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon_filename'] . '.png')) { |
|
| 1857 | + fatal_lang_error('icon_not_found'); |
|
| 1858 | + } |
|
| 1779 | 1859 | // There is a 16 character limit on message icons... |
| 1780 | - elseif (strlen($_POST['icon_filename']) > 16) |
|
| 1781 | - fatal_lang_error('icon_name_too_long'); |
|
| 1782 | - elseif ($_POST['icon_location'] == $_GET['icon'] && !empty($_GET['icon'])) |
|
| 1783 | - fatal_lang_error('icon_after_itself'); |
|
| 1860 | + elseif (strlen($_POST['icon_filename']) > 16) { |
|
| 1861 | + fatal_lang_error('icon_name_too_long'); |
|
| 1862 | + } elseif ($_POST['icon_location'] == $_GET['icon'] && !empty($_GET['icon'])) { |
|
| 1863 | + fatal_lang_error('icon_after_itself'); |
|
| 1864 | + } |
|
| 1784 | 1865 | |
| 1785 | 1866 | // First do the sorting... if this is an edit reduce the order of everything after it by one ;) |
| 1786 | 1867 | if ($_GET['icon'] != 0) |
| 1787 | 1868 | { |
| 1788 | 1869 | $oldOrder = $context['icons'][$_GET['icon']]['true_order']; |
| 1789 | - foreach ($context['icons'] as $id => $data) |
|
| 1790 | - if ($data['true_order'] > $oldOrder) |
|
| 1870 | + foreach ($context['icons'] as $id => $data) { |
|
| 1871 | + if ($data['true_order'] > $oldOrder) |
|
| 1791 | 1872 | $context['icons'][$id]['true_order']--; |
| 1873 | + } |
|
| 1792 | 1874 | } |
| 1793 | 1875 | |
| 1794 | 1876 | // If there are no existing icons and this is a new one, set the id to 1 (mainly for non-mysql) |
| 1795 | - if (empty($_GET['icon']) && empty($context['icons'])) |
|
| 1796 | - $_GET['icon'] = 1; |
|
| 1877 | + if (empty($_GET['icon']) && empty($context['icons'])) { |
|
| 1878 | + $_GET['icon'] = 1; |
|
| 1879 | + } |
|
| 1797 | 1880 | |
| 1798 | 1881 | // Get the new order. |
| 1799 | 1882 | $newOrder = $_POST['icon_location'] == 0 ? 0 : $context['icons'][$_POST['icon_location']]['true_order'] + 1; |
| 1800 | 1883 | // Do the same, but with the one that used to be after this icon, done to avoid conflict. |
| 1801 | - foreach ($context['icons'] as $id => $data) |
|
| 1802 | - if ($data['true_order'] >= $newOrder) |
|
| 1884 | + foreach ($context['icons'] as $id => $data) { |
|
| 1885 | + if ($data['true_order'] >= $newOrder) |
|
| 1803 | 1886 | $context['icons'][$id]['true_order']++; |
| 1887 | + } |
|
| 1804 | 1888 | |
| 1805 | 1889 | // Finally set the current icon's position! |
| 1806 | 1890 | $context['icons'][$_GET['icon']]['true_order'] = $newOrder; |
@@ -1818,8 +1902,7 @@ discard block |
||
| 1818 | 1902 | if ($id != 0) |
| 1819 | 1903 | { |
| 1820 | 1904 | $iconInsert[] = array($id, $icon['board_id'], $icon['title'], $icon['filename'], $icon['true_order']); |
| 1821 | - } |
|
| 1822 | - else |
|
| 1905 | + } else |
|
| 1823 | 1906 | { |
| 1824 | 1907 | $iconInsert_new[] = array($icon['board_id'], $icon['title'], $icon['filename'], $icon['true_order']); |
| 1825 | 1908 | } |
@@ -1844,8 +1927,9 @@ discard block |
||
| 1844 | 1927 | } |
| 1845 | 1928 | |
| 1846 | 1929 | // Unless we're adding a new thing, we'll escape |
| 1847 | - if (!isset($_POST['add'])) |
|
| 1848 | - redirectexit('action=admin;area=smileys;sa=editicons'); |
|
| 1930 | + if (!isset($_POST['add'])) { |
|
| 1931 | + redirectexit('action=admin;area=smileys;sa=editicons'); |
|
| 1932 | + } |
|
| 1849 | 1933 | } |
| 1850 | 1934 | |
| 1851 | 1935 | $context[$context['admin_menu_name']]['current_subsection'] = 'editicons'; |
@@ -1955,8 +2039,9 @@ discard block |
||
| 1955 | 2039 | $context['new_icon'] = !isset($_GET['icon']); |
| 1956 | 2040 | |
| 1957 | 2041 | // Get the properties of the current icon from the icon list. |
| 1958 | - if (!$context['new_icon']) |
|
| 1959 | - $context['icon'] = $context['icons'][$_GET['icon']]; |
|
| 2042 | + if (!$context['new_icon']) { |
|
| 2043 | + $context['icon'] = $context['icons'][$_GET['icon']]; |
|
| 2044 | + } |
|
| 1960 | 2045 | |
| 1961 | 2046 | // Get a list of boards needed for assigning this icon to a specific board. |
| 1962 | 2047 | $boardListOptions = array( |
@@ -1990,8 +2075,9 @@ discard block |
||
| 1990 | 2075 | ); |
| 1991 | 2076 | |
| 1992 | 2077 | $message_icons = array(); |
| 1993 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1994 | - $message_icons[] = $row; |
|
| 2078 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2079 | + $message_icons[] = $row; |
|
| 2080 | + } |
|
| 1995 | 2081 | $smcFunc['db_free_result']($request); |
| 1996 | 2082 | |
| 1997 | 2083 | return $message_icons; |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 3 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Browse the list of package servers, add servers... |
@@ -43,13 +44,15 @@ discard block |
||
| 43 | 44 | ); |
| 44 | 45 | |
| 45 | 46 | // Now let's decide where we are taking this... |
| 46 | - if (isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']])) |
|
| 47 | - $context['sub_action'] = $_REQUEST['sa']; |
|
| 47 | + if (isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']])) { |
|
| 48 | + $context['sub_action'] = $_REQUEST['sa']; |
|
| 49 | + } |
|
| 48 | 50 | // We need to support possible old javascript links... |
| 49 | - elseif (isset($_GET['pgdownload'])) |
|
| 50 | - $context['sub_action'] = 'download'; |
|
| 51 | - else |
|
| 52 | - $context['sub_action'] = 'servers'; |
|
| 51 | + elseif (isset($_GET['pgdownload'])) { |
|
| 52 | + $context['sub_action'] = 'download'; |
|
| 53 | + } else { |
|
| 54 | + $context['sub_action'] = 'servers'; |
|
| 55 | + } |
|
| 53 | 56 | |
| 54 | 57 | // We need to force the "Download" tab as selected. |
| 55 | 58 | $context['menu_data_' . $context['admin_menu_id']]['current_subsection'] = 'packageget'; |
@@ -141,17 +144,19 @@ discard block |
||
| 141 | 144 | { |
| 142 | 145 | require_once($sourcedir . '/Class-Package.php'); |
| 143 | 146 | $ftp = new ftp_connection(null); |
| 147 | + } elseif ($ftp->error !== false && !isset($ftp_error)) { |
|
| 148 | + $ftp_error = $ftp->last_message === null ? '' : $ftp->last_message; |
|
| 144 | 149 | } |
| 145 | - elseif ($ftp->error !== false && !isset($ftp_error)) |
|
| 146 | - $ftp_error = $ftp->last_message === null ? '' : $ftp->last_message; |
|
| 147 | 150 | |
| 148 | 151 | list ($username, $detect_path, $found_path) = $ftp->detect_path($packagesdir); |
| 149 | 152 | |
| 150 | - if ($found_path || !isset($_POST['ftp_path'])) |
|
| 151 | - $_POST['ftp_path'] = $detect_path; |
|
| 153 | + if ($found_path || !isset($_POST['ftp_path'])) { |
|
| 154 | + $_POST['ftp_path'] = $detect_path; |
|
| 155 | + } |
|
| 152 | 156 | |
| 153 | - if (!isset($_POST['ftp_username'])) |
|
| 154 | - $_POST['ftp_username'] = $username; |
|
| 157 | + if (!isset($_POST['ftp_username'])) { |
|
| 158 | + $_POST['ftp_username'] = $username; |
|
| 159 | + } |
|
| 155 | 160 | |
| 156 | 161 | $context['package_ftp'] = array( |
| 157 | 162 | 'server' => isset($_POST['ftp_server']) ? $_POST['ftp_server'] : (isset($modSettings['package_server']) ? $modSettings['package_server'] : 'localhost'), |
@@ -160,8 +165,7 @@ discard block |
||
| 160 | 165 | 'path' => $_POST['ftp_path'], |
| 161 | 166 | 'error' => empty($ftp_error) ? null : $ftp_error, |
| 162 | 167 | ); |
| 163 | - } |
|
| 164 | - else |
|
| 168 | + } else |
|
| 165 | 169 | { |
| 166 | 170 | $context['package_download_broken'] = false; |
| 167 | 171 | |
@@ -203,8 +207,9 @@ discard block |
||
| 203 | 207 | |
| 204 | 208 | if (isset($_GET['server'])) |
| 205 | 209 | { |
| 206 | - if ($_GET['server'] == '') |
|
| 207 | - redirectexit('action=admin;area=packages;get'); |
|
| 210 | + if ($_GET['server'] == '') { |
|
| 211 | + redirectexit('action=admin;area=packages;get'); |
|
| 212 | + } |
|
| 208 | 213 | |
| 209 | 214 | $server = (int) $_GET['server']; |
| 210 | 215 | |
@@ -222,17 +227,18 @@ discard block |
||
| 222 | 227 | $smcFunc['db_free_result']($request); |
| 223 | 228 | |
| 224 | 229 | // If the server does not exist, dump out. |
| 225 | - if (empty($url)) |
|
| 226 | - fatal_lang_error('couldnt_connect', false); |
|
| 230 | + if (empty($url)) { |
|
| 231 | + fatal_lang_error('couldnt_connect', false); |
|
| 232 | + } |
|
| 227 | 233 | |
| 228 | 234 | // If there is a relative link, append to the stored server url. |
| 229 | - if (isset($_GET['relative'])) |
|
| 230 | - $url = $url . (substr($url, -1) == '/' ? '' : '/') . $_GET['relative']; |
|
| 235 | + if (isset($_GET['relative'])) { |
|
| 236 | + $url = $url . (substr($url, -1) == '/' ? '' : '/') . $_GET['relative']; |
|
| 237 | + } |
|
| 231 | 238 | |
| 232 | 239 | // Clear any "absolute" URL. Since "server" is present, "absolute" is garbage. |
| 233 | 240 | unset($_GET['absolute']); |
| 234 | - } |
|
| 235 | - elseif (isset($_GET['absolute']) && $_GET['absolute'] != '') |
|
| 241 | + } elseif (isset($_GET['absolute']) && $_GET['absolute'] != '') |
|
| 236 | 242 | { |
| 237 | 243 | // Initialize the requried variables. |
| 238 | 244 | $server = ''; |
@@ -256,16 +262,19 @@ discard block |
||
| 256 | 262 | } |
| 257 | 263 | } |
| 258 | 264 | // Minimum required parameter did not exist so dump out. |
| 259 | - else |
|
| 260 | - fatal_lang_error('couldnt_connect', false); |
|
| 265 | + else { |
|
| 266 | + fatal_lang_error('couldnt_connect', false); |
|
| 267 | + } |
|
| 261 | 268 | |
| 262 | 269 | // Attempt to connect. If unsuccessful... try the URL. |
| 263 | - if (!isset($_GET['package']) || file_exists($_GET['package'])) |
|
| 264 | - $_GET['package'] = $url . '/packages.xml?language=' . $context['user']['language']; |
|
| 270 | + if (!isset($_GET['package']) || file_exists($_GET['package'])) { |
|
| 271 | + $_GET['package'] = $url . '/packages.xml?language=' . $context['user']['language']; |
|
| 272 | + } |
|
| 265 | 273 | |
| 266 | 274 | // Check to be sure the packages.xml file actually exists where it is should be... or dump out. |
| 267 | - if ((isset($_GET['absolute']) || isset($_GET['relative'])) && !url_exists($_GET['package'])) |
|
| 268 | - fatal_lang_error('packageget_unable', false, array($url . '/index.php')); |
|
| 275 | + if ((isset($_GET['absolute']) || isset($_GET['relative'])) && !url_exists($_GET['package'])) { |
|
| 276 | + fatal_lang_error('packageget_unable', false, array($url . '/index.php')); |
|
| 277 | + } |
|
| 269 | 278 | |
| 270 | 279 | // Might take some time. |
| 271 | 280 | @set_time_limit(600); |
@@ -275,8 +284,9 @@ discard block |
||
| 275 | 284 | $listing = new xmlArray(fetch_web_data($_GET['package']), true); |
| 276 | 285 | |
| 277 | 286 | // Errm.... empty file? Try the URL.... |
| 278 | - if (!$listing->exists('package-list')) |
|
| 279 | - fatal_lang_error('packageget_unable', false, array($url . '/index.php')); |
|
| 287 | + if (!$listing->exists('package-list')) { |
|
| 288 | + fatal_lang_error('packageget_unable', false, array($url . '/index.php')); |
|
| 289 | + } |
|
| 280 | 290 | |
| 281 | 291 | // List out the packages... |
| 282 | 292 | $context['package_list'] = array(); |
@@ -284,8 +294,9 @@ discard block |
||
| 284 | 294 | $listing = $listing->path('package-list[0]'); |
| 285 | 295 | |
| 286 | 296 | // Use the package list's name if it exists. |
| 287 | - if ($listing->exists('list-title')) |
|
| 288 | - $name = $smcFunc['htmlspecialchars']($listing->fetch('list-title')); |
|
| 297 | + if ($listing->exists('list-title')) { |
|
| 298 | + $name = $smcFunc['htmlspecialchars']($listing->fetch('list-title')); |
|
| 299 | + } |
|
| 289 | 300 | |
| 290 | 301 | // Pick the correct template. |
| 291 | 302 | $context['sub_template'] = 'package_list'; |
@@ -300,28 +311,32 @@ discard block |
||
| 300 | 311 | |
| 301 | 312 | $installed_mods = array(); |
| 302 | 313 | // Look through the list of installed mods... |
| 303 | - foreach ($instmods as $installed_mod) |
|
| 304 | - $installed_mods[$installed_mod['package_id']] = $installed_mod['version']; |
|
| 314 | + foreach ($instmods as $installed_mod) { |
|
| 315 | + $installed_mods[$installed_mod['package_id']] = $installed_mod['version']; |
|
| 316 | + } |
|
| 305 | 317 | |
| 306 | 318 | // Get default author and email if they exist. |
| 307 | 319 | if ($listing->exists('default-author')) |
| 308 | 320 | { |
| 309 | 321 | $default_author = $smcFunc['htmlspecialchars']($listing->fetch('default-author')); |
| 310 | - if ($listing->exists('default-author/@email') && filter_var($listing->fetch('default-author/@email'), FILTER_VALIDATE_EMAIL)) |
|
| 311 | - $default_email = $smcFunc['htmlspecialchars']($listing->fetch('default-author/@email')); |
|
| 322 | + if ($listing->exists('default-author/@email') && filter_var($listing->fetch('default-author/@email'), FILTER_VALIDATE_EMAIL)) { |
|
| 323 | + $default_email = $smcFunc['htmlspecialchars']($listing->fetch('default-author/@email')); |
|
| 324 | + } |
|
| 312 | 325 | } |
| 313 | 326 | |
| 314 | 327 | // Get default web site if it exists. |
| 315 | 328 | if ($listing->exists('default-website')) |
| 316 | 329 | { |
| 317 | 330 | $default_website = $smcFunc['htmlspecialchars']($listing->fetch('default-website')); |
| 318 | - if ($listing->exists('default-website/@title')) |
|
| 319 | - $default_title = $smcFunc['htmlspecialchars']($listing->fetch('default-website/@title')); |
|
| 331 | + if ($listing->exists('default-website/@title')) { |
|
| 332 | + $default_title = $smcFunc['htmlspecialchars']($listing->fetch('default-website/@title')); |
|
| 333 | + } |
|
| 320 | 334 | } |
| 321 | 335 | |
| 322 | 336 | $the_version = strtr($forum_version, array('SMF ' => '')); |
| 323 | - if (!empty($_SESSION['version_emulate'])) |
|
| 324 | - $the_version = $_SESSION['version_emulate']; |
|
| 337 | + if (!empty($_SESSION['version_emulate'])) { |
|
| 338 | + $the_version = $_SESSION['version_emulate']; |
|
| 339 | + } |
|
| 325 | 340 | |
| 326 | 341 | $packageNum = 0; |
| 327 | 342 | $packageSection = 0; |
@@ -342,11 +357,13 @@ discard block |
||
| 342 | 357 | 'type' => $thisPackage->name(), |
| 343 | 358 | ); |
| 344 | 359 | |
| 345 | - if (in_array($package['type'], array('title', 'text'))) |
|
| 346 | - $context['package_list'][$packageSection][$package['type']] = $smcFunc['htmlspecialchars']($thisPackage->fetch('.')); |
|
| 360 | + if (in_array($package['type'], array('title', 'text'))) { |
|
| 361 | + $context['package_list'][$packageSection][$package['type']] = $smcFunc['htmlspecialchars']($thisPackage->fetch('.')); |
|
| 362 | + } |
|
| 347 | 363 | // It's a Title, Heading, Rule or Text. |
| 348 | - elseif (in_array($package['type'], array('heading', 'rule'))) |
|
| 349 | - $package['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('.')); |
|
| 364 | + elseif (in_array($package['type'], array('heading', 'rule'))) { |
|
| 365 | + $package['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('.')); |
|
| 366 | + } |
|
| 350 | 367 | // It's a Remote link. |
| 351 | 368 | elseif ($package['type'] == 'remote') |
| 352 | 369 | { |
@@ -354,20 +371,21 @@ discard block |
||
| 354 | 371 | |
| 355 | 372 | if ($remote_type == 'relative' && substr($thisPackage->fetch('@href'), 0, 7) != 'http://' && substr($thisPackage->fetch('@href'), 0, 8) != 'https://') |
| 356 | 373 | { |
| 357 | - if (isset($_GET['absolute'])) |
|
| 358 | - $current_url = $_GET['absolute'] . '/'; |
|
| 359 | - elseif (isset($_GET['relative'])) |
|
| 360 | - $current_url = $_GET['relative'] . '/'; |
|
| 361 | - else |
|
| 362 | - $current_url = ''; |
|
| 374 | + if (isset($_GET['absolute'])) { |
|
| 375 | + $current_url = $_GET['absolute'] . '/'; |
|
| 376 | + } elseif (isset($_GET['relative'])) { |
|
| 377 | + $current_url = $_GET['relative'] . '/'; |
|
| 378 | + } else { |
|
| 379 | + $current_url = ''; |
|
| 380 | + } |
|
| 363 | 381 | |
| 364 | 382 | $current_url .= $thisPackage->fetch('@href'); |
| 365 | - if (isset($_GET['absolute'])) |
|
| 366 | - $package['href'] = $scripturl . '?action=admin;area=packages;get;sa=browse;absolute=' . $current_url; |
|
| 367 | - else |
|
| 368 | - $package['href'] = $scripturl . '?action=admin;area=packages;get;sa=browse;server=' . $context['package_server'] . ';relative=' . $current_url; |
|
| 369 | - } |
|
| 370 | - else |
|
| 383 | + if (isset($_GET['absolute'])) { |
|
| 384 | + $package['href'] = $scripturl . '?action=admin;area=packages;get;sa=browse;absolute=' . $current_url; |
|
| 385 | + } else { |
|
| 386 | + $package['href'] = $scripturl . '?action=admin;area=packages;get;sa=browse;server=' . $context['package_server'] . ';relative=' . $current_url; |
|
| 387 | + } |
|
| 388 | + } else |
|
| 371 | 389 | { |
| 372 | 390 | $current_url = $thisPackage->fetch('@href'); |
| 373 | 391 | $package['href'] = $scripturl . '?action=admin;area=packages;get;sa=browse;absolute=' . $current_url; |
@@ -379,25 +397,28 @@ discard block |
||
| 379 | 397 | // It's a package... |
| 380 | 398 | else |
| 381 | 399 | { |
| 382 | - if (isset($_GET['absolute'])) |
|
| 383 | - $current_url = $_GET['absolute'] . '/'; |
|
| 384 | - elseif (isset($_GET['relative'])) |
|
| 385 | - $current_url = $_GET['relative'] . '/'; |
|
| 386 | - else |
|
| 387 | - $current_url = ''; |
|
| 400 | + if (isset($_GET['absolute'])) { |
|
| 401 | + $current_url = $_GET['absolute'] . '/'; |
|
| 402 | + } elseif (isset($_GET['relative'])) { |
|
| 403 | + $current_url = $_GET['relative'] . '/'; |
|
| 404 | + } else { |
|
| 405 | + $current_url = ''; |
|
| 406 | + } |
|
| 388 | 407 | |
| 389 | 408 | $server_att = $server != '' ? ';server=' . $server : ''; |
| 390 | 409 | |
| 391 | 410 | $package += $thisPackage->to_array(); |
| 392 | 411 | |
| 393 | - if (isset($package['website'])) |
|
| 394 | - unset($package['website']); |
|
| 412 | + if (isset($package['website'])) { |
|
| 413 | + unset($package['website']); |
|
| 414 | + } |
|
| 395 | 415 | $package['author'] = array(); |
| 396 | 416 | |
| 397 | - if ($package['description'] == '') |
|
| 398 | - $package['description'] = $txt['package_no_description']; |
|
| 399 | - else |
|
| 400 | - $package['description'] = parse_bbc(preg_replace('~\[[/]?html\]~i', '', $smcFunc['htmlspecialchars']($package['description']))); |
|
| 417 | + if ($package['description'] == '') { |
|
| 418 | + $package['description'] = $txt['package_no_description']; |
|
| 419 | + } else { |
|
| 420 | + $package['description'] = parse_bbc(preg_replace('~\[[/]?html\]~i', '', $smcFunc['htmlspecialchars']($package['description']))); |
|
| 421 | + } |
|
| 401 | 422 | |
| 402 | 423 | $package['is_installed'] = isset($installed_mods[$package['id']]); |
| 403 | 424 | $package['is_current'] = $package['is_installed'] && ($installed_mods[$package['id']] == $package['version']); |
@@ -406,12 +427,14 @@ discard block |
||
| 406 | 427 | // This package is either not installed, or installed but old. Is it supported on this version of SMF? |
| 407 | 428 | if (!$package['is_installed'] || (!$package['is_current'] && !$package['is_newer'])) |
| 408 | 429 | { |
| 409 | - if ($thisPackage->exists('version/@for')) |
|
| 410 | - $package['can_install'] = matchPackageVersion($the_version, $thisPackage->fetch('version/@for')); |
|
| 430 | + if ($thisPackage->exists('version/@for')) { |
|
| 431 | + $package['can_install'] = matchPackageVersion($the_version, $thisPackage->fetch('version/@for')); |
|
| 432 | + } |
|
| 411 | 433 | } |
| 412 | 434 | // Okay, it's already installed AND up to date. |
| 413 | - else |
|
| 414 | - $package['can_install'] = false; |
|
| 435 | + else { |
|
| 436 | + $package['can_install'] = false; |
|
| 437 | + } |
|
| 415 | 438 | |
| 416 | 439 | $already_exists = getPackageInfo(basename($package['filename'])); |
| 417 | 440 | $package['download_conflict'] = is_array($already_exists) && $already_exists['id'] == $package['id'] && $already_exists['version'] != $package['version']; |
@@ -423,40 +446,44 @@ discard block |
||
| 423 | 446 | |
| 424 | 447 | if ($thisPackage->exists('author') || isset($default_author)) |
| 425 | 448 | { |
| 426 | - if ($thisPackage->exists('author/@email') && filter_var($thisPackage->fetch('author/@email'), FILTER_VALIDATE_EMAIL)) |
|
| 427 | - $package['author']['email'] = $thisPackage->fetch('author/@email'); |
|
| 428 | - elseif (isset($default_email)) |
|
| 429 | - $package['author']['email'] = $default_email; |
|
| 430 | - |
|
| 431 | - if ($thisPackage->exists('author') && $thisPackage->fetch('author') != '') |
|
| 432 | - $package['author']['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('author')); |
|
| 433 | - else |
|
| 434 | - $package['author']['name'] = $default_author; |
|
| 435 | - |
|
| 436 | - if (!empty($package['author']['email'])) |
|
| 437 | - $package['author']['link'] = '<a href="mailto:' . $package['author']['email'] . '">' . $package['author']['name'] . '</a>'; |
|
| 449 | + if ($thisPackage->exists('author/@email') && filter_var($thisPackage->fetch('author/@email'), FILTER_VALIDATE_EMAIL)) { |
|
| 450 | + $package['author']['email'] = $thisPackage->fetch('author/@email'); |
|
| 451 | + } elseif (isset($default_email)) { |
|
| 452 | + $package['author']['email'] = $default_email; |
|
| 453 | + } |
|
| 454 | + |
|
| 455 | + if ($thisPackage->exists('author') && $thisPackage->fetch('author') != '') { |
|
| 456 | + $package['author']['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('author')); |
|
| 457 | + } else { |
|
| 458 | + $package['author']['name'] = $default_author; |
|
| 459 | + } |
|
| 460 | + |
|
| 461 | + if (!empty($package['author']['email'])) { |
|
| 462 | + $package['author']['link'] = '<a href="mailto:' . $package['author']['email'] . '">' . $package['author']['name'] . '</a>'; |
|
| 463 | + } |
|
| 438 | 464 | } |
| 439 | 465 | |
| 440 | 466 | if ($thisPackage->exists('website') || isset($default_website)) |
| 441 | 467 | { |
| 442 | - if ($thisPackage->exists('website') && $thisPackage->exists('website/@title')) |
|
| 443 | - $package['author']['website']['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('website/@title')); |
|
| 444 | - elseif (isset($default_title)) |
|
| 445 | - $package['author']['website']['name'] = $default_title; |
|
| 446 | - elseif ($thisPackage->exists('website')) |
|
| 447 | - $package['author']['website']['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('website')); |
|
| 448 | - else |
|
| 449 | - $package['author']['website']['name'] = $default_website; |
|
| 450 | - |
|
| 451 | - if ($thisPackage->exists('website') && $thisPackage->fetch('website') != '') |
|
| 452 | - $authorhompage = $smcFunc['htmlspecialchars']($thisPackage->fetch('website')); |
|
| 453 | - else |
|
| 454 | - $authorhompage = $default_website; |
|
| 468 | + if ($thisPackage->exists('website') && $thisPackage->exists('website/@title')) { |
|
| 469 | + $package['author']['website']['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('website/@title')); |
|
| 470 | + } elseif (isset($default_title)) { |
|
| 471 | + $package['author']['website']['name'] = $default_title; |
|
| 472 | + } elseif ($thisPackage->exists('website')) { |
|
| 473 | + $package['author']['website']['name'] = $smcFunc['htmlspecialchars']($thisPackage->fetch('website')); |
|
| 474 | + } else { |
|
| 475 | + $package['author']['website']['name'] = $default_website; |
|
| 476 | + } |
|
| 477 | + |
|
| 478 | + if ($thisPackage->exists('website') && $thisPackage->fetch('website') != '') { |
|
| 479 | + $authorhompage = $smcFunc['htmlspecialchars']($thisPackage->fetch('website')); |
|
| 480 | + } else { |
|
| 481 | + $authorhompage = $default_website; |
|
| 482 | + } |
|
| 455 | 483 | |
| 456 | 484 | $package['author']['website']['href'] = $authorhompage; |
| 457 | 485 | $package['author']['website']['link'] = '<a href="' . $authorhompage . '">' . $package['author']['website']['name'] . '</a>'; |
| 458 | - } |
|
| 459 | - else |
|
| 486 | + } else |
|
| 460 | 487 | { |
| 461 | 488 | $package['author']['website']['href'] = ''; |
| 462 | 489 | $package['author']['website']['link'] = ''; |
@@ -472,11 +499,13 @@ discard block |
||
| 472 | 499 | $packageNum = in_array($package['type'], array('title', 'heading', 'text', 'remote', 'rule')) ? 0 : $packageNum + 1; |
| 473 | 500 | $package['count'] = $packageNum; |
| 474 | 501 | |
| 475 | - if (!in_array($package['type'], array('title', 'text'))) |
|
| 476 | - $context['package_list'][$packageSection]['items'][] = $package; |
|
| 502 | + if (!in_array($package['type'], array('title', 'text'))) { |
|
| 503 | + $context['package_list'][$packageSection]['items'][] = $package; |
|
| 504 | + } |
|
| 477 | 505 | |
| 478 | - if ($package['count'] > 1) |
|
| 479 | - $context['list_type'] = 'ol'; |
|
| 506 | + if ($package['count'] > 1) { |
|
| 507 | + $context['list_type'] = 'ol'; |
|
| 508 | + } |
|
| 480 | 509 | } |
| 481 | 510 | |
| 482 | 511 | $packageSection++; |
@@ -489,8 +518,9 @@ discard block |
||
| 489 | 518 | { |
| 490 | 519 | foreach ($packageSection['items'] as $i => $package) |
| 491 | 520 | { |
| 492 | - if ($package['count'] == 0 || isset($package['can_install'])) |
|
| 493 | - continue; |
|
| 521 | + if ($package['count'] == 0 || isset($package['can_install'])) { |
|
| 522 | + continue; |
|
| 523 | + } |
|
| 494 | 524 | |
| 495 | 525 | $context['package_list'][$ps_id]['items'][$i]['can_install'] = false; |
| 496 | 526 | |
@@ -539,8 +569,9 @@ discard block |
||
| 539 | 569 | checkSession('get'); |
| 540 | 570 | |
| 541 | 571 | // To download something, we need a valid server or url. |
| 542 | - if (empty($_GET['server']) && (!empty($_GET['get']) && !empty($_REQUEST['package']))) |
|
| 543 | - fatal_lang_error('package_get_error_is_zero', false); |
|
| 572 | + if (empty($_GET['server']) && (!empty($_GET['get']) && !empty($_REQUEST['package']))) { |
|
| 573 | + fatal_lang_error('package_get_error_is_zero', false); |
|
| 574 | + } |
|
| 544 | 575 | |
| 545 | 576 | if (isset($_GET['server'])) |
| 546 | 577 | { |
@@ -560,22 +591,23 @@ discard block |
||
| 560 | 591 | $smcFunc['db_free_result']($request); |
| 561 | 592 | |
| 562 | 593 | // If server does not exist then dump out. |
| 563 | - if (empty($url)) |
|
| 564 | - fatal_lang_error('couldnt_connect', false); |
|
| 594 | + if (empty($url)) { |
|
| 595 | + fatal_lang_error('couldnt_connect', false); |
|
| 596 | + } |
|
| 565 | 597 | |
| 566 | 598 | $url = $url . '/'; |
| 567 | - } |
|
| 568 | - else |
|
| 599 | + } else |
|
| 569 | 600 | { |
| 570 | 601 | // Initialize the requried variables. |
| 571 | 602 | $server = ''; |
| 572 | 603 | $url = ''; |
| 573 | 604 | } |
| 574 | 605 | |
| 575 | - if (isset($_REQUEST['byurl']) && !empty($_POST['filename'])) |
|
| 576 | - $package_name = basename($_REQUEST['filename']); |
|
| 577 | - else |
|
| 578 | - $package_name = basename($_REQUEST['package']); |
|
| 606 | + if (isset($_REQUEST['byurl']) && !empty($_POST['filename'])) { |
|
| 607 | + $package_name = basename($_REQUEST['filename']); |
|
| 608 | + } else { |
|
| 609 | + $package_name = basename($_REQUEST['package']); |
|
| 610 | + } |
|
| 579 | 611 | |
| 580 | 612 | if (isset($_REQUEST['conflict']) || (isset($_REQUEST['auto']) && file_exists($packagesdir . '/' . $package_name))) |
| 581 | 613 | { |
@@ -584,14 +616,15 @@ discard block |
||
| 584 | 616 | { |
| 585 | 617 | $ext = substr($package_name, strrpos(substr($package_name, 0, -3), '.')); |
| 586 | 618 | $package_name = substr($package_name, 0, strrpos(substr($package_name, 0, -3), '.')) . '_'; |
| 619 | + } else { |
|
| 620 | + $ext = ''; |
|
| 587 | 621 | } |
| 588 | - else |
|
| 589 | - $ext = ''; |
|
| 590 | 622 | |
| 591 | 623 | // Find the first available. |
| 592 | 624 | $i = 1; |
| 593 | - while (file_exists($packagesdir . '/' . $package_name . $i . $ext)) |
|
| 594 | - $i++; |
|
| 625 | + while (file_exists($packagesdir . '/' . $package_name . $i . $ext)) { |
|
| 626 | + $i++; |
|
| 627 | + } |
|
| 595 | 628 | |
| 596 | 629 | $package_name = $package_name . $i . $ext; |
| 597 | 630 | } |
@@ -602,25 +635,28 @@ discard block |
||
| 602 | 635 | |
| 603 | 636 | // Done! Did we get this package automatically? |
| 604 | 637 | // @ TODO: These are usually update packages. Allowing both for now until more testing has been done. |
| 605 | - if (preg_match('~^https?://[\w_\-]+\.simplemachines\.org/~', $_REQUEST['package']) == 1 && strpos($_REQUEST['package'], 'dlattach') === false && isset($_REQUEST['auto'])) |
|
| 606 | - redirectexit('action=admin;area=packages;sa=install;package=' . $package_name); |
|
| 638 | + if (preg_match('~^https?://[\w_\-]+\.simplemachines\.org/~', $_REQUEST['package']) == 1 && strpos($_REQUEST['package'], 'dlattach') === false && isset($_REQUEST['auto'])) { |
|
| 639 | + redirectexit('action=admin;area=packages;sa=install;package=' . $package_name); |
|
| 640 | + } |
|
| 607 | 641 | |
| 608 | 642 | // You just downloaded a mod from SERVER_NAME_GOES_HERE. |
| 609 | 643 | $context['package_server'] = $server; |
| 610 | 644 | |
| 611 | 645 | $context['package'] = getPackageInfo($package_name); |
| 612 | 646 | |
| 613 | - if (!is_array($context['package'])) |
|
| 614 | - fatal_lang_error('package_cant_download', false); |
|
| 647 | + if (!is_array($context['package'])) { |
|
| 648 | + fatal_lang_error('package_cant_download', false); |
|
| 649 | + } |
|
| 615 | 650 | |
| 616 | - if ($context['package']['type'] == 'modification') |
|
| 617 | - $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['install_mod'] . ' ]</a>'; |
|
| 618 | - elseif ($context['package']['type'] == 'avatar') |
|
| 619 | - $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['use_avatars'] . ' ]</a>'; |
|
| 620 | - elseif ($context['package']['type'] == 'language') |
|
| 621 | - $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['add_languages'] . ' ]</a>'; |
|
| 622 | - else |
|
| 623 | - $context['package']['install']['link'] = ''; |
|
| 651 | + if ($context['package']['type'] == 'modification') { |
|
| 652 | + $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['install_mod'] . ' ]</a>'; |
|
| 653 | + } elseif ($context['package']['type'] == 'avatar') { |
|
| 654 | + $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['use_avatars'] . ' ]</a>'; |
|
| 655 | + } elseif ($context['package']['type'] == 'language') { |
|
| 656 | + $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['add_languages'] . ' ]</a>'; |
|
| 657 | + } else { |
|
| 658 | + $context['package']['install']['link'] = ''; |
|
| 659 | + } |
|
| 624 | 660 | |
| 625 | 661 | // Does a 3rd party hook want to do some additional changes? |
| 626 | 662 | call_integration_hook('integrate_package_download'); |
@@ -646,10 +682,11 @@ discard block |
||
| 646 | 682 | // @todo Use FTP if the Packages directory is not writable. |
| 647 | 683 | |
| 648 | 684 | // Check the file was even sent! |
| 649 | - if (!isset($_FILES['package']['name']) || $_FILES['package']['name'] == '') |
|
| 650 | - fatal_lang_error('package_upload_error_nofile'); |
|
| 651 | - elseif (!is_uploaded_file($_FILES['package']['tmp_name']) || (ini_get('open_basedir') == '' && !file_exists($_FILES['package']['tmp_name']))) |
|
| 652 | - fatal_lang_error('package_upload_error_failed'); |
|
| 685 | + if (!isset($_FILES['package']['name']) || $_FILES['package']['name'] == '') { |
|
| 686 | + fatal_lang_error('package_upload_error_nofile'); |
|
| 687 | + } elseif (!is_uploaded_file($_FILES['package']['tmp_name']) || (ini_get('open_basedir') == '' && !file_exists($_FILES['package']['tmp_name']))) { |
|
| 688 | + fatal_lang_error('package_upload_error_failed'); |
|
| 689 | + } |
|
| 653 | 690 | |
| 654 | 691 | // Make sure it has a sane filename. |
| 655 | 692 | $_FILES['package']['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['package']['name']); |
@@ -666,8 +703,9 @@ discard block |
||
| 666 | 703 | // Setup the destination and throw an error if the file is already there! |
| 667 | 704 | $destination = $packagesdir . '/' . $packageName; |
| 668 | 705 | // @todo Maybe just roll it like we do for downloads? |
| 669 | - if (file_exists($destination)) |
|
| 670 | - fatal_lang_error('package_upload_error_exists'); |
|
| 706 | + if (file_exists($destination)) { |
|
| 707 | + fatal_lang_error('package_upload_error_exists'); |
|
| 708 | + } |
|
| 671 | 709 | |
| 672 | 710 | // Now move the file. |
| 673 | 711 | move_uploaded_file($_FILES['package']['tmp_name'], $destination); |
@@ -690,12 +728,14 @@ discard block |
||
| 690 | 728 | { |
| 691 | 729 | while ($package = readdir($dir)) |
| 692 | 730 | { |
| 693 | - if ($package == '.' || $package == '..' || $package == 'temp' || $package == $packageName || (!(is_dir($packagesdir . '/' . $package) && file_exists($packagesdir . '/' . $package . '/package-info.xml')) && substr(strtolower($package), -7) != '.tar.gz' && substr(strtolower($package), -4) != '.tgz' && substr(strtolower($package), -4) != '.zip')) |
|
| 694 | - continue; |
|
| 731 | + if ($package == '.' || $package == '..' || $package == 'temp' || $package == $packageName || (!(is_dir($packagesdir . '/' . $package) && file_exists($packagesdir . '/' . $package . '/package-info.xml')) && substr(strtolower($package), -7) != '.tar.gz' && substr(strtolower($package), -4) != '.tgz' && substr(strtolower($package), -4) != '.zip')) { |
|
| 732 | + continue; |
|
| 733 | + } |
|
| 695 | 734 | |
| 696 | 735 | $packageInfo = getPackageInfo($package); |
| 697 | - if (!is_array($packageInfo)) |
|
| 698 | - continue; |
|
| 736 | + if (!is_array($packageInfo)) { |
|
| 737 | + continue; |
|
| 738 | + } |
|
| 699 | 739 | |
| 700 | 740 | if ($packageInfo['id'] == $context['package']['id'] && $packageInfo['version'] == $context['package']['version']) |
| 701 | 741 | { |
@@ -707,14 +747,15 @@ discard block |
||
| 707 | 747 | closedir($dir); |
| 708 | 748 | } |
| 709 | 749 | |
| 710 | - if ($context['package']['type'] == 'modification') |
|
| 711 | - $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['install_mod'] . ' ]</a>'; |
|
| 712 | - elseif ($context['package']['type'] == 'avatar') |
|
| 713 | - $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['use_avatars'] . ' ]</a>'; |
|
| 714 | - elseif ($context['package']['type'] == 'language') |
|
| 715 | - $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['add_languages'] . ' ]</a>'; |
|
| 716 | - else |
|
| 717 | - $context['package']['install']['link'] = ''; |
|
| 750 | + if ($context['package']['type'] == 'modification') { |
|
| 751 | + $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['install_mod'] . ' ]</a>'; |
|
| 752 | + } elseif ($context['package']['type'] == 'avatar') { |
|
| 753 | + $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['use_avatars'] . ' ]</a>'; |
|
| 754 | + } elseif ($context['package']['type'] == 'language') { |
|
| 755 | + $context['package']['install']['link'] = '<a href="' . $scripturl . '?action=admin;area=packages;sa=install;package=' . $context['package']['filename'] . '">[ ' . $txt['add_languages'] . ' ]</a>'; |
|
| 756 | + } else { |
|
| 757 | + $context['package']['install']['link'] = ''; |
|
| 758 | + } |
|
| 718 | 759 | |
| 719 | 760 | // Does a 3rd party hook want to do some additional changes? |
| 720 | 761 | call_integration_hook('integrate_package_upload'); |
@@ -737,16 +778,18 @@ discard block |
||
| 737 | 778 | checkSession(); |
| 738 | 779 | |
| 739 | 780 | // If they put a slash on the end, get rid of it. |
| 740 | - if (substr($_POST['serverurl'], -1) == '/') |
|
| 741 | - $_POST['serverurl'] = substr($_POST['serverurl'], 0, -1); |
|
| 781 | + if (substr($_POST['serverurl'], -1) == '/') { |
|
| 782 | + $_POST['serverurl'] = substr($_POST['serverurl'], 0, -1); |
|
| 783 | + } |
|
| 742 | 784 | |
| 743 | 785 | // Are they both nice and clean? |
| 744 | 786 | $servername = trim($smcFunc['htmlspecialchars']($_POST['servername'])); |
| 745 | 787 | $serverurl = trim($smcFunc['htmlspecialchars']($_POST['serverurl'])); |
| 746 | 788 | |
| 747 | 789 | // Make sure the URL has the correct prefix. |
| 748 | - if (strpos($serverurl, 'http://') !== 0 && strpos($serverurl, 'https://') !== 0) |
|
| 749 | - $serverurl = 'http://' . $serverurl; |
|
| 790 | + if (strpos($serverurl, 'http://') !== 0 && strpos($serverurl, 'https://') !== 0) { |
|
| 791 | + $serverurl = 'http://' . $serverurl; |
|
| 792 | + } |
|
| 750 | 793 | |
| 751 | 794 | $smcFunc['db_insert']('', |
| 752 | 795 | '{db_prefix}package_servers', |
@@ -14,8 +14,9 @@ discard block |
||
| 14 | 14 | // This won't be dedicated without this - this must exist in each gateway! |
| 15 | 15 | // SMF Payment Gateway: paypal |
| 16 | 16 | |
| 17 | -if (!defined('SMF')) |
|
| 17 | +if (!defined('SMF')) { |
|
| 18 | 18 | die('No direct access...'); |
| 19 | +} |
|
| 19 | 20 | |
| 20 | 21 | /** |
| 21 | 22 | * Class for returning available form data for this gateway |
@@ -118,8 +119,7 @@ discard block |
||
| 118 | 119 | { |
| 119 | 120 | $return_data['hidden']['p3'] = 1; |
| 120 | 121 | $return_data['hidden']['t3'] = strtoupper(substr($period, 0, 1)); |
| 121 | - } |
|
| 122 | - else |
|
| 122 | + } else |
|
| 123 | 123 | { |
| 124 | 124 | preg_match('~(\d*)(\w)~', $sub_data['real_length'], $match); |
| 125 | 125 | $unit = $match[1]; |
@@ -130,14 +130,15 @@ discard block |
||
| 130 | 130 | } |
| 131 | 131 | |
| 132 | 132 | // If it's repeatable do some javascript to respect this idea. |
| 133 | - if (!empty($sub_data['repeatable'])) |
|
| 134 | - $return_data['javascript'] = ' |
|
| 133 | + if (!empty($sub_data['repeatable'])) { |
|
| 134 | + $return_data['javascript'] = ' |
|
| 135 | 135 | document.write(\'<label for="do_paypal_recur"><input type="checkbox" name="do_paypal_recur" id="do_paypal_recur" checked onclick="switchPaypalRecur();" class="input_check">' . $txt['paid_make_recurring'] . '</label><br>\'); |
| 136 | 136 | |
| 137 | 137 | function switchPaypalRecur() |
| 138 | 138 | { |
| 139 | 139 | document.getElementById("paypal_cmd").value = document.getElementById("do_paypal_recur").checked ? "_xclick-subscriptions" : "_xclick"; |
| 140 | 140 | }'; |
| 141 | + } |
|
| 141 | 142 | |
| 142 | 143 | return $return_data; |
| 143 | 144 | } |
@@ -160,20 +161,24 @@ discard block |
||
| 160 | 161 | global $modSettings; |
| 161 | 162 | |
| 162 | 163 | // Has the user set up an email address? |
| 163 | - if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) |
|
| 164 | - return false; |
|
| 164 | + if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) { |
|
| 165 | + return false; |
|
| 166 | + } |
|
| 165 | 167 | // Check the correct transaction types are even here. |
| 166 | - if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) |
|
| 167 | - return false; |
|
| 168 | + if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) { |
|
| 169 | + return false; |
|
| 170 | + } |
|
| 168 | 171 | // Correct email address? |
| 169 | - if (!isset($_POST['business'])) |
|
| 170 | - $_POST['business'] = $_POST['receiver_email']; |
|
| 172 | + if (!isset($_POST['business'])) { |
|
| 173 | + $_POST['business'] = $_POST['receiver_email']; |
|
| 174 | + } |
|
| 171 | 175 | |
| 172 | 176 | // Are we testing? |
| 173 | - if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) |
|
| 174 | - return false; |
|
| 175 | - elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) |
|
| 176 | - return false; |
|
| 177 | + if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) { |
|
| 178 | + return false; |
|
| 179 | + } elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) { |
|
| 180 | + return false; |
|
| 181 | + } |
|
| 177 | 182 | return true; |
| 178 | 183 | } |
| 179 | 184 | |
@@ -192,15 +197,17 @@ discard block |
||
| 192 | 197 | global $modSettings, $txt; |
| 193 | 198 | |
| 194 | 199 | // Put this to some default value. |
| 195 | - if (!isset($_POST['txn_type'])) |
|
| 196 | - $_POST['txn_type'] = ''; |
|
| 200 | + if (!isset($_POST['txn_type'])) { |
|
| 201 | + $_POST['txn_type'] = ''; |
|
| 202 | + } |
|
| 197 | 203 | |
| 198 | 204 | // Build the request string - starting with the minimum requirement. |
| 199 | 205 | $requestString = 'cmd=_notify-validate'; |
| 200 | 206 | |
| 201 | 207 | // Now my dear, add all the posted bits in the order we got them |
| 202 | - foreach ($_POST as $k => $v) |
|
| 203 | - $requestString .= '&' . $k . '=' . urlencode($v); |
|
| 208 | + foreach ($_POST as $k => $v) { |
|
| 209 | + $requestString .= '&' . $k . '=' . urlencode($v); |
|
| 210 | + } |
|
| 204 | 211 | |
| 205 | 212 | // Can we use curl? |
| 206 | 213 | if (function_exists('curl_init') && $curl = curl_init((!empty($modSettings['paidsubs_test']) ? 'https://www.sandbox.' : 'https://www.') . 'paypal.com/cgi-bin/webscr')) |
@@ -240,14 +247,16 @@ discard block |
||
| 240 | 247 | $header .= 'Connection: close' . "\r\n\r\n"; |
| 241 | 248 | |
| 242 | 249 | // Open the connection. |
| 243 | - if (!empty($modSettings['paidsubs_test'])) |
|
| 244 | - $fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30); |
|
| 245 | - else |
|
| 246 | - $fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30); |
|
| 250 | + if (!empty($modSettings['paidsubs_test'])) { |
|
| 251 | + $fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30); |
|
| 252 | + } else { |
|
| 253 | + $fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30); |
|
| 254 | + } |
|
| 247 | 255 | |
| 248 | 256 | // Did it work? |
| 249 | - if (!$fp) |
|
| 250 | - generateSubscriptionError($txt['paypal_could_not_connect']); |
|
| 257 | + if (!$fp) { |
|
| 258 | + generateSubscriptionError($txt['paypal_could_not_connect']); |
|
| 259 | + } |
|
| 251 | 260 | |
| 252 | 261 | // Put the data to the port. |
| 253 | 262 | fputs($fp, $header . $requestString); |
@@ -256,8 +265,9 @@ discard block |
||
| 256 | 265 | while (!feof($fp)) |
| 257 | 266 | { |
| 258 | 267 | $this->return_data = fgets($fp, 1024); |
| 259 | - if (strcmp(trim($this->return_data), 'VERIFIED') === 0) |
|
| 260 | - break; |
|
| 268 | + if (strcmp(trim($this->return_data), 'VERIFIED') === 0) { |
|
| 269 | + break; |
|
| 270 | + } |
|
| 261 | 271 | } |
| 262 | 272 | |
| 263 | 273 | // Clean up. |
@@ -265,28 +275,34 @@ discard block |
||
| 265 | 275 | } |
| 266 | 276 | |
| 267 | 277 | // If this isn't verified then give up... |
| 268 | - if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) |
|
| 269 | - exit; |
|
| 278 | + if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) { |
|
| 279 | + exit; |
|
| 280 | + } |
|
| 270 | 281 | |
| 271 | 282 | // Check that this is intended for us. |
| 272 | - if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) |
|
| 273 | - exit; |
|
| 283 | + if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) { |
|
| 284 | + exit; |
|
| 285 | + } |
|
| 274 | 286 | |
| 275 | 287 | // Is this a subscription - and if so is it a secondary payment that we need to process? |
| 276 | 288 | // If so, make sure we get it in the expected format. Seems PayPal sometimes sends it without urlencoding. |
| 277 | - if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) |
|
| 278 | - $_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']); |
|
| 279 | - if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) |
|
| 280 | - // Calculate the subscription it relates to! |
|
| 289 | + if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) { |
|
| 290 | + $_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']); |
|
| 291 | + } |
|
| 292 | + if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) { |
|
| 293 | + // Calculate the subscription it relates to! |
|
| 281 | 294 | $this->_findSubscription(); |
| 295 | + } |
|
| 282 | 296 | |
| 283 | 297 | // Verify the currency! |
| 284 | - if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) |
|
| 285 | - exit; |
|
| 298 | + if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) { |
|
| 299 | + exit; |
|
| 300 | + } |
|
| 286 | 301 | |
| 287 | 302 | // Can't exist if it doesn't contain anything. |
| 288 | - if (empty($_POST['item_number'])) |
|
| 289 | - exit; |
|
| 303 | + if (empty($_POST['item_number'])) { |
|
| 304 | + exit; |
|
| 305 | + } |
|
| 290 | 306 | |
| 291 | 307 | // Return the id_sub and id_member |
| 292 | 308 | return explode('+', $_POST['item_number']); |
@@ -299,10 +315,11 @@ discard block |
||
| 299 | 315 | */ |
| 300 | 316 | public function isRefund() |
| 301 | 317 | { |
| 302 | - if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) |
|
| 303 | - return true; |
|
| 304 | - else |
|
| 305 | - return false; |
|
| 318 | + if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) { |
|
| 319 | + return true; |
|
| 320 | + } else { |
|
| 321 | + return false; |
|
| 322 | + } |
|
| 306 | 323 | } |
| 307 | 324 | |
| 308 | 325 | /** |
@@ -312,10 +329,11 @@ discard block |
||
| 312 | 329 | */ |
| 313 | 330 | public function isSubscription() |
| 314 | 331 | { |
| 315 | - if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') |
|
| 316 | - return true; |
|
| 317 | - else |
|
| 318 | - return false; |
|
| 332 | + if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') { |
|
| 333 | + return true; |
|
| 334 | + } else { |
|
| 335 | + return false; |
|
| 336 | + } |
|
| 319 | 337 | } |
| 320 | 338 | |
| 321 | 339 | /** |
@@ -325,10 +343,11 @@ discard block |
||
| 325 | 343 | */ |
| 326 | 344 | public function isPayment() |
| 327 | 345 | { |
| 328 | - if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') |
|
| 329 | - return true; |
|
| 330 | - else |
|
| 331 | - return false; |
|
| 346 | + if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') { |
|
| 347 | + return true; |
|
| 348 | + } else { |
|
| 349 | + return false; |
|
| 350 | + } |
|
| 332 | 351 | } |
| 333 | 352 | |
| 334 | 353 | /** |
@@ -341,10 +360,11 @@ discard block |
||
| 341 | 360 | // subscr_cancel is sent when the user cancels, subscr_eot is sent when the subscription reaches final payment |
| 342 | 361 | // Neither require us to *do* anything as per performCancel(). |
| 343 | 362 | // subscr_eot, if sent, indicates an end of payments term. |
| 344 | - if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') |
|
| 345 | - return true; |
|
| 346 | - else |
|
| 347 | - return false; |
|
| 363 | + if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') { |
|
| 364 | + return true; |
|
| 365 | + } else { |
|
| 366 | + return false; |
|
| 367 | + } |
|
| 348 | 368 | } |
| 349 | 369 | |
| 350 | 370 | /** |
@@ -409,8 +429,9 @@ discard block |
||
| 409 | 429 | global $smcFunc; |
| 410 | 430 | |
| 411 | 431 | // Assume we have this? |
| 412 | - if (empty($_POST['subscr_id'])) |
|
| 413 | - return false; |
|
| 432 | + if (empty($_POST['subscr_id'])) { |
|
| 433 | + return false; |
|
| 434 | + } |
|
| 414 | 435 | |
| 415 | 436 | // Do we have this in the database? |
| 416 | 437 | $request = $smcFunc['db_query']('', ' |
@@ -439,11 +460,12 @@ discard block |
||
| 439 | 460 | 'payer_email' => $_POST['payer_email'], |
| 440 | 461 | ) |
| 441 | 462 | ); |
| 442 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
| 443 | - return false; |
|
| 463 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
| 464 | + return false; |
|
| 465 | + } |
|
| 466 | + } else { |
|
| 467 | + return false; |
|
| 444 | 468 | } |
| 445 | - else |
|
| 446 | - return false; |
|
| 447 | 469 | } |
| 448 | 470 | list ($member_id, $subscription_id) = $smcFunc['db_fetch_row']($request); |
| 449 | 471 | $_POST['item_number'] = $member_id . '+' . $subscription_id; |
@@ -28,7 +28,7 @@ discard block |
||
| 28 | 28 | * @param bool $single_file If true returns the contents of the file specified by destination if it exists |
| 29 | 29 | * @param bool $overwrite Whether to overwrite existing files |
| 30 | 30 | * @param null|array $files_to_extract Specific files to extract |
| 31 | - * @return array|false An array of information about extracted files or false on failure |
|
| 31 | + * @return string An array of information about extracted files or false on failure |
|
| 32 | 32 | */ |
| 33 | 33 | function read_tgz_file($gzfilename, $destination, $single_file = false, $overwrite = false, $files_to_extract = null) |
| 34 | 34 | { |
@@ -59,7 +59,7 @@ discard block |
||
| 59 | 59 | * @param bool $single_file Whether to only extract a single file |
| 60 | 60 | * @param bool $overwrite Whether to overwrite existing data |
| 61 | 61 | * @param null|array $files_to_extract If set, only extracts the specified files |
| 62 | - * @return array|false An array of information about the extracted files or false on failure |
|
| 62 | + * @return string An array of information about the extracted files or false on failure |
|
| 63 | 63 | */ |
| 64 | 64 | function read_tgz_data($gzfilename, $destination, $single_file = false, $overwrite = false, $files_to_extract = null) |
| 65 | 65 | { |
@@ -3255,7 +3255,7 @@ discard block |
||
| 3255 | 3255 | * https://php.net/crc32#79567 |
| 3256 | 3256 | * |
| 3257 | 3257 | * @param string $number |
| 3258 | - * @return string The crc32 |
|
| 3258 | + * @return integer The crc32 |
|
| 3259 | 3259 | */ |
| 3260 | 3260 | function smf_crc32($number) |
| 3261 | 3261 | { |
@@ -75,8 +75,9 @@ discard block |
||
| 75 | 75 | $upcontext['inactive_timeout'] = 10; |
| 76 | 76 | |
| 77 | 77 | // The helper is crucial. Include it first thing. |
| 78 | -if (!file_exists($upgrade_path . '/upgrade-helper.php')) |
|
| 78 | +if (!file_exists($upgrade_path . '/upgrade-helper.php')) { |
|
| 79 | 79 | die('upgrade-helper.php not found where it was expected: ' . $upgrade_path . '/upgrade-helper.php! Make sure you have uploaded ALL files from the upgrade package. The upgrader cannot continue.'); |
| 80 | +} |
|
| 80 | 81 | |
| 81 | 82 | require_once($upgrade_path . '/upgrade-helper.php'); |
| 82 | 83 | |
@@ -100,11 +101,14 @@ discard block |
||
| 100 | 101 | ini_set('default_socket_timeout', 900); |
| 101 | 102 | } |
| 102 | 103 | // Clean the upgrade path if this is from the client. |
| 103 | -if (!empty($_SERVER['argv']) && php_sapi_name() == 'cli' && empty($_SERVER['REMOTE_ADDR'])) |
|
| 104 | - for ($i = 1; $i < $_SERVER['argc']; $i++) |
|
| 104 | +if (!empty($_SERVER['argv']) && php_sapi_name() == 'cli' && empty($_SERVER['REMOTE_ADDR'])) { |
|
| 105 | + for ($i = 1; |
|
| 106 | +} |
|
| 107 | +$i < $_SERVER['argc']; $i++) |
|
| 105 | 108 | { |
| 106 | - if (preg_match('~^--path=(.+)$~', $_SERVER['argv'][$i], $match) != 0) |
|
| 107 | - $upgrade_path = substr($match[1], -1) == '/' ? substr($match[1], 0, -1) : $match[1]; |
|
| 109 | + if (preg_match('~^--path=(.+)$~', $_SERVER['argv'][$i], $match) != 0) { |
|
| 110 | + $upgrade_path = substr($match[1], -1) == '/' ? substr($match[1], 0, -1) : $match[1]; |
|
| 111 | + } |
|
| 108 | 112 | } |
| 109 | 113 | |
| 110 | 114 | // Are we from the client? |
@@ -112,16 +116,17 @@ discard block |
||
| 112 | 116 | { |
| 113 | 117 | $command_line = true; |
| 114 | 118 | $disable_security = true; |
| 115 | -} |
|
| 116 | -else |
|
| 119 | +} else { |
|
| 117 | 120 | $command_line = false; |
| 121 | +} |
|
| 118 | 122 | |
| 119 | 123 | // Load this now just because we can. |
| 120 | 124 | require_once($upgrade_path . '/Settings.php'); |
| 121 | 125 | |
| 122 | 126 | // We don't use "-utf8" anymore... Tweak the entry that may have been loaded by Settings.php |
| 123 | -if (isset($language)) |
|
| 127 | +if (isset($language)) { |
|
| 124 | 128 | $language = str_ireplace('-utf8', '', $language); |
| 129 | +} |
|
| 125 | 130 | |
| 126 | 131 | // Are we logged in? |
| 127 | 132 | if (isset($upgradeData)) |
@@ -129,10 +134,12 @@ discard block |
||
| 129 | 134 | $upcontext['user'] = json_decode(base64_decode($upgradeData), true); |
| 130 | 135 | |
| 131 | 136 | // Check for sensible values. |
| 132 | - if (empty($upcontext['user']['started']) || $upcontext['user']['started'] < time() - 86400) |
|
| 133 | - $upcontext['user']['started'] = time(); |
|
| 134 | - if (empty($upcontext['user']['updated']) || $upcontext['user']['updated'] < time() - 86400) |
|
| 135 | - $upcontext['user']['updated'] = 0; |
|
| 137 | + if (empty($upcontext['user']['started']) || $upcontext['user']['started'] < time() - 86400) { |
|
| 138 | + $upcontext['user']['started'] = time(); |
|
| 139 | + } |
|
| 140 | + if (empty($upcontext['user']['updated']) || $upcontext['user']['updated'] < time() - 86400) { |
|
| 141 | + $upcontext['user']['updated'] = 0; |
|
| 142 | + } |
|
| 136 | 143 | |
| 137 | 144 | $upcontext['started'] = $upcontext['user']['started']; |
| 138 | 145 | $upcontext['updated'] = $upcontext['user']['updated']; |
@@ -190,8 +197,9 @@ discard block |
||
| 190 | 197 | 'db_error_skip' => true, |
| 191 | 198 | ) |
| 192 | 199 | ); |
| 193 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 194 | - $modSettings[$row['variable']] = $row['value']; |
|
| 200 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 201 | + $modSettings[$row['variable']] = $row['value']; |
|
| 202 | + } |
|
| 195 | 203 | $smcFunc['db_free_result']($request); |
| 196 | 204 | } |
| 197 | 205 | |
@@ -201,10 +209,12 @@ discard block |
||
| 201 | 209 | $modSettings['theme_url'] = 'Themes/default'; |
| 202 | 210 | $modSettings['images_url'] = 'Themes/default/images'; |
| 203 | 211 | } |
| 204 | -if (!isset($settings['default_theme_url'])) |
|
| 212 | +if (!isset($settings['default_theme_url'])) { |
|
| 205 | 213 | $settings['default_theme_url'] = $modSettings['theme_url']; |
| 206 | -if (!isset($settings['default_theme_dir'])) |
|
| 214 | +} |
|
| 215 | +if (!isset($settings['default_theme_dir'])) { |
|
| 207 | 216 | $settings['default_theme_dir'] = $modSettings['theme_dir']; |
| 217 | +} |
|
| 208 | 218 | |
| 209 | 219 | $upcontext['is_large_forum'] = (empty($modSettings['smfVersion']) || $modSettings['smfVersion'] <= '1.1 RC1') && !empty($modSettings['totalMessages']) && $modSettings['totalMessages'] > 75000; |
| 210 | 220 | // Default title... |
@@ -222,13 +232,15 @@ discard block |
||
| 222 | 232 | $support_js = $upcontext['upgrade_status']['js']; |
| 223 | 233 | |
| 224 | 234 | // Only set this if the upgrader status says so. |
| 225 | - if (empty($is_debug)) |
|
| 226 | - $is_debug = $upcontext['upgrade_status']['debug']; |
|
| 235 | + if (empty($is_debug)) { |
|
| 236 | + $is_debug = $upcontext['upgrade_status']['debug']; |
|
| 237 | + } |
|
| 227 | 238 | |
| 228 | 239 | // Load the language. |
| 229 | - if (file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) |
|
| 230 | - require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'); |
|
| 231 | -} |
|
| 240 | + if (file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) { |
|
| 241 | + require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'); |
|
| 242 | + } |
|
| 243 | + } |
|
| 232 | 244 | // Set the defaults. |
| 233 | 245 | else |
| 234 | 246 | { |
@@ -246,15 +258,18 @@ discard block |
||
| 246 | 258 | } |
| 247 | 259 | |
| 248 | 260 | // If this isn't the first stage see whether they are logging in and resuming. |
| 249 | -if ($upcontext['current_step'] != 0 || !empty($upcontext['user']['step'])) |
|
| 261 | +if ($upcontext['current_step'] != 0 || !empty($upcontext['user']['step'])) { |
|
| 250 | 262 | checkLogin(); |
| 263 | +} |
|
| 251 | 264 | |
| 252 | -if ($command_line) |
|
| 265 | +if ($command_line) { |
|
| 253 | 266 | cmdStep0(); |
| 267 | +} |
|
| 254 | 268 | |
| 255 | 269 | // Don't error if we're using xml. |
| 256 | -if (isset($_GET['xml'])) |
|
| 270 | +if (isset($_GET['xml'])) { |
|
| 257 | 271 | $upcontext['return_error'] = true; |
| 272 | +} |
|
| 258 | 273 | |
| 259 | 274 | // Loop through all the steps doing each one as required. |
| 260 | 275 | $upcontext['overall_percent'] = 0; |
@@ -275,9 +290,9 @@ discard block |
||
| 275 | 290 | } |
| 276 | 291 | |
| 277 | 292 | // Call the step and if it returns false that means pause! |
| 278 | - if (function_exists($step[2]) && $step[2]() === false) |
|
| 279 | - break; |
|
| 280 | - elseif (function_exists($step[2])) { |
|
| 293 | + if (function_exists($step[2]) && $step[2]() === false) { |
|
| 294 | + break; |
|
| 295 | + } elseif (function_exists($step[2])) { |
|
| 281 | 296 | //Start each new step with this unset, so the 'normal' template is called first |
| 282 | 297 | unset($_GET['xml']); |
| 283 | 298 | $_GET['substep'] = 0; |
@@ -321,17 +336,18 @@ discard block |
||
| 321 | 336 | // This should not happen my dear... HELP ME DEVELOPERS!! |
| 322 | 337 | if (!empty($command_line)) |
| 323 | 338 | { |
| 324 | - if (function_exists('debug_print_backtrace')) |
|
| 325 | - debug_print_backtrace(); |
|
| 339 | + if (function_exists('debug_print_backtrace')) { |
|
| 340 | + debug_print_backtrace(); |
|
| 341 | + } |
|
| 326 | 342 | |
| 327 | 343 | echo "\n" . 'Error: Unexpected call to use the ' . (isset($upcontext['sub_template']) ? $upcontext['sub_template'] : '') . ' template. Please copy and paste all the text above and visit the SMF support forum to tell the Developers that they\'ve made a boo boo; they\'ll get you up and running again.'; |
| 328 | 344 | flush(); |
| 329 | 345 | die(); |
| 330 | 346 | } |
| 331 | 347 | |
| 332 | - if (!isset($_GET['xml'])) |
|
| 333 | - template_upgrade_above(); |
|
| 334 | - else |
|
| 348 | + if (!isset($_GET['xml'])) { |
|
| 349 | + template_upgrade_above(); |
|
| 350 | + } else |
|
| 335 | 351 | { |
| 336 | 352 | header('Content-Type: text/xml; charset=UTF-8'); |
| 337 | 353 | // Sadly we need to retain the $_GET data thanks to the old upgrade scripts. |
@@ -353,25 +369,29 @@ discard block |
||
| 353 | 369 | $upcontext['form_url'] = $upgradeurl . '?step=' . $upcontext['current_step'] . '&substep=' . $_GET['substep'] . '&data=' . base64_encode(json_encode($upcontext['upgrade_status'])); |
| 354 | 370 | |
| 355 | 371 | // Custom stuff to pass back? |
| 356 | - if (!empty($upcontext['query_string'])) |
|
| 357 | - $upcontext['form_url'] .= $upcontext['query_string']; |
|
| 372 | + if (!empty($upcontext['query_string'])) { |
|
| 373 | + $upcontext['form_url'] .= $upcontext['query_string']; |
|
| 374 | + } |
|
| 358 | 375 | |
| 359 | 376 | // Call the appropriate subtemplate |
| 360 | - if (is_callable('template_' . $upcontext['sub_template'])) |
|
| 361 | - call_user_func('template_' . $upcontext['sub_template']); |
|
| 362 | - else |
|
| 363 | - die('Upgrade aborted! Invalid template: template_' . $upcontext['sub_template']); |
|
| 377 | + if (is_callable('template_' . $upcontext['sub_template'])) { |
|
| 378 | + call_user_func('template_' . $upcontext['sub_template']); |
|
| 379 | + } else { |
|
| 380 | + die('Upgrade aborted! Invalid template: template_' . $upcontext['sub_template']); |
|
| 381 | + } |
|
| 364 | 382 | } |
| 365 | 383 | |
| 366 | 384 | // Was there an error? |
| 367 | - if (!empty($upcontext['forced_error_message'])) |
|
| 368 | - echo $upcontext['forced_error_message']; |
|
| 385 | + if (!empty($upcontext['forced_error_message'])) { |
|
| 386 | + echo $upcontext['forced_error_message']; |
|
| 387 | + } |
|
| 369 | 388 | |
| 370 | 389 | // Show the footer. |
| 371 | - if (!isset($_GET['xml'])) |
|
| 372 | - template_upgrade_below(); |
|
| 373 | - else |
|
| 374 | - template_xml_below(); |
|
| 390 | + if (!isset($_GET['xml'])) { |
|
| 391 | + template_upgrade_below(); |
|
| 392 | + } else { |
|
| 393 | + template_xml_below(); |
|
| 394 | + } |
|
| 375 | 395 | } |
| 376 | 396 | |
| 377 | 397 | |
@@ -383,15 +403,19 @@ discard block |
||
| 383 | 403 | $seconds = intval($active % 60); |
| 384 | 404 | |
| 385 | 405 | $totalTime = ''; |
| 386 | - if ($hours > 0) |
|
| 387 | - $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 388 | - if ($minutes > 0) |
|
| 389 | - $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 390 | - if ($seconds > 0) |
|
| 391 | - $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 406 | + if ($hours > 0) { |
|
| 407 | + $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 408 | + } |
|
| 409 | + if ($minutes > 0) { |
|
| 410 | + $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 411 | + } |
|
| 412 | + if ($seconds > 0) { |
|
| 413 | + $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 414 | + } |
|
| 392 | 415 | |
| 393 | - if (!empty($totalTime)) |
|
| 394 | - echo "\n" . 'Upgrade completed in ' . $totalTime . "\n"; |
|
| 416 | + if (!empty($totalTime)) { |
|
| 417 | + echo "\n" . 'Upgrade completed in ' . $totalTime . "\n"; |
|
| 418 | + } |
|
| 395 | 419 | } |
| 396 | 420 | |
| 397 | 421 | // Bang - gone! |
@@ -404,8 +428,9 @@ discard block |
||
| 404 | 428 | global $upgradeurl, $upcontext, $command_line; |
| 405 | 429 | |
| 406 | 430 | // Command line users can't be redirected. |
| 407 | - if ($command_line) |
|
| 408 | - upgradeExit(true); |
|
| 431 | + if ($command_line) { |
|
| 432 | + upgradeExit(true); |
|
| 433 | + } |
|
| 409 | 434 | |
| 410 | 435 | // Are we providing the core info? |
| 411 | 436 | if ($addForm) |
@@ -428,19 +453,22 @@ discard block |
||
| 428 | 453 | global $modSettings, $sourcedir, $smcFunc; |
| 429 | 454 | |
| 430 | 455 | // Do the non-SSI stuff... |
| 431 | - if (function_exists('set_magic_quotes_runtime')) |
|
| 432 | - @set_magic_quotes_runtime(0); |
|
| 456 | + if (function_exists('set_magic_quotes_runtime')) { |
|
| 457 | + @set_magic_quotes_runtime(0); |
|
| 458 | + } |
|
| 433 | 459 | |
| 434 | 460 | error_reporting(E_ALL); |
| 435 | 461 | define('SMF', 1); |
| 436 | 462 | |
| 437 | 463 | // Start the session. |
| 438 | - if (@ini_get('session.save_handler') == 'user') |
|
| 439 | - @ini_set('session.save_handler', 'files'); |
|
| 464 | + if (@ini_get('session.save_handler') == 'user') { |
|
| 465 | + @ini_set('session.save_handler', 'files'); |
|
| 466 | + } |
|
| 440 | 467 | @session_start(); |
| 441 | 468 | |
| 442 | - if (empty($smcFunc)) |
|
| 443 | - $smcFunc = array(); |
|
| 469 | + if (empty($smcFunc)) { |
|
| 470 | + $smcFunc = array(); |
|
| 471 | + } |
|
| 444 | 472 | |
| 445 | 473 | // We need this for authentication and some upgrade code |
| 446 | 474 | require_once($sourcedir . '/Subs-Auth.php'); |
@@ -452,32 +480,36 @@ discard block |
||
| 452 | 480 | initialize_inputs(); |
| 453 | 481 | |
| 454 | 482 | // Get the database going! |
| 455 | - if (empty($db_type) || $db_type == 'mysqli') |
|
| 456 | - $db_type = 'mysql'; |
|
| 483 | + if (empty($db_type) || $db_type == 'mysqli') { |
|
| 484 | + $db_type = 'mysql'; |
|
| 485 | + } |
|
| 457 | 486 | |
| 458 | 487 | if (file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
| 459 | 488 | { |
| 460 | 489 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
| 461 | 490 | |
| 462 | 491 | // Make the connection... |
| 463 | - if (empty($db_connection)) |
|
| 464 | - $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, array('non_fatal' => true)); |
|
| 465 | - else |
|
| 466 | - // If we've returned here, ping/reconnect to be safe |
|
| 492 | + if (empty($db_connection)) { |
|
| 493 | + $db_connection = smf_db_initiate($db_server, $db_name, $db_user, $db_passwd, $db_prefix, array('non_fatal' => true)); |
|
| 494 | + } else { |
|
| 495 | + // If we've returned here, ping/reconnect to be safe |
|
| 467 | 496 | $smcFunc['db_ping']($db_connection); |
| 497 | + } |
|
| 468 | 498 | |
| 469 | 499 | // Oh dear god!! |
| 470 | - if ($db_connection === null) |
|
| 471 | - die('Unable to connect to database - please check username and password are correct in Settings.php'); |
|
| 500 | + if ($db_connection === null) { |
|
| 501 | + die('Unable to connect to database - please check username and password are correct in Settings.php'); |
|
| 502 | + } |
|
| 472 | 503 | |
| 473 | - if ($db_type == 'mysql' && isset($db_character_set) && preg_match('~^\w+$~', $db_character_set) === 1) |
|
| 474 | - $smcFunc['db_query']('', ' |
|
| 504 | + if ($db_type == 'mysql' && isset($db_character_set) && preg_match('~^\w+$~', $db_character_set) === 1) { |
|
| 505 | + $smcFunc['db_query']('', ' |
|
| 475 | 506 | SET NAMES {string:db_character_set}', |
| 476 | 507 | array( |
| 477 | 508 | 'db_error_skip' => true, |
| 478 | 509 | 'db_character_set' => $db_character_set, |
| 479 | 510 | ) |
| 480 | 511 | ); |
| 512 | + } |
|
| 481 | 513 | |
| 482 | 514 | // Load the modSettings data... |
| 483 | 515 | $request = $smcFunc['db_query']('', ' |
@@ -488,11 +520,11 @@ discard block |
||
| 488 | 520 | ) |
| 489 | 521 | ); |
| 490 | 522 | $modSettings = array(); |
| 491 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 492 | - $modSettings[$row['variable']] = $row['value']; |
|
| 523 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 524 | + $modSettings[$row['variable']] = $row['value']; |
|
| 525 | + } |
|
| 493 | 526 | $smcFunc['db_free_result']($request); |
| 494 | - } |
|
| 495 | - else |
|
| 527 | + } else |
|
| 496 | 528 | { |
| 497 | 529 | return throw_error('Cannot find ' . $sourcedir . '/Subs-Db-' . $db_type . '.php' . '. Please check you have uploaded all source files and have the correct paths set.'); |
| 498 | 530 | } |
@@ -506,9 +538,10 @@ discard block |
||
| 506 | 538 | cleanRequest(); |
| 507 | 539 | } |
| 508 | 540 | |
| 509 | - if (!isset($_GET['substep'])) |
|
| 510 | - $_GET['substep'] = 0; |
|
| 511 | -} |
|
| 541 | + if (!isset($_GET['substep'])) { |
|
| 542 | + $_GET['substep'] = 0; |
|
| 543 | + } |
|
| 544 | + } |
|
| 512 | 545 | |
| 513 | 546 | function initialize_inputs() |
| 514 | 547 | { |
@@ -538,8 +571,9 @@ discard block |
||
| 538 | 571 | $dh = opendir(dirname(__FILE__)); |
| 539 | 572 | while ($file = readdir($dh)) |
| 540 | 573 | { |
| 541 | - if (preg_match('~upgrade_\d-\d_([A-Za-z])+\.sql~i', $file, $matches) && isset($matches[1])) |
|
| 542 | - @unlink(dirname(__FILE__) . '/' . $file); |
|
| 574 | + if (preg_match('~upgrade_\d-\d_([A-Za-z])+\.sql~i', $file, $matches) && isset($matches[1])) { |
|
| 575 | + @unlink(dirname(__FILE__) . '/' . $file); |
|
| 576 | + } |
|
| 543 | 577 | } |
| 544 | 578 | closedir($dh); |
| 545 | 579 | |
@@ -568,8 +602,9 @@ discard block |
||
| 568 | 602 | $temp = 'upgrade_php?step'; |
| 569 | 603 | while (strlen($temp) > 4) |
| 570 | 604 | { |
| 571 | - if (isset($_GET[$temp])) |
|
| 572 | - unset($_GET[$temp]); |
|
| 605 | + if (isset($_GET[$temp])) { |
|
| 606 | + unset($_GET[$temp]); |
|
| 607 | + } |
|
| 573 | 608 | $temp = substr($temp, 1); |
| 574 | 609 | } |
| 575 | 610 | |
@@ -596,32 +631,39 @@ discard block |
||
| 596 | 631 | && @file_exists(dirname(__FILE__) . '/upgrade_2-1_' . $db_type . '.sql'); |
| 597 | 632 | |
| 598 | 633 | // Need legacy scripts? |
| 599 | - if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.1) |
|
| 600 | - $check &= @file_exists(dirname(__FILE__) . '/upgrade_2-0_' . $db_type . '.sql'); |
|
| 601 | - if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.0) |
|
| 602 | - $check &= @file_exists(dirname(__FILE__) . '/upgrade_1-1.sql'); |
|
| 603 | - if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 1.1) |
|
| 604 | - $check &= @file_exists(dirname(__FILE__) . '/upgrade_1-0.sql'); |
|
| 634 | + if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.1) { |
|
| 635 | + $check &= @file_exists(dirname(__FILE__) . '/upgrade_2-0_' . $db_type . '.sql'); |
|
| 636 | + } |
|
| 637 | + if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 2.0) { |
|
| 638 | + $check &= @file_exists(dirname(__FILE__) . '/upgrade_1-1.sql'); |
|
| 639 | + } |
|
| 640 | + if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < 1.1) { |
|
| 641 | + $check &= @file_exists(dirname(__FILE__) . '/upgrade_1-0.sql'); |
|
| 642 | + } |
|
| 605 | 643 | |
| 606 | 644 | // We don't need "-utf8" files anymore... |
| 607 | 645 | $upcontext['language'] = str_ireplace('-utf8', '', $upcontext['language']); |
| 608 | 646 | |
| 609 | 647 | // This needs to exist! |
| 610 | - if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) |
|
| 611 | - return throw_error('The upgrader could not find the "Install" language file for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded all the files included in the package, even the theme and language files for the default theme.<br> [<a href="' . $upgradeurl . '?lang=english">Try English</a>]'); |
|
| 612 | - else |
|
| 613 | - require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'); |
|
| 648 | + if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) { |
|
| 649 | + return throw_error('The upgrader could not find the "Install" language file for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded all the files included in the package, even the theme and language files for the default theme.<br> [<a href="' . $upgradeurl . '?lang=english">Try English</a>]'); |
|
| 650 | + } else { |
|
| 651 | + require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'); |
|
| 652 | + } |
|
| 614 | 653 | |
| 615 | - if (!$check) |
|
| 616 | - // Don't tell them what files exactly because it's a spot check - just like teachers don't tell which problems they are spot checking, that's dumb. |
|
| 654 | + if (!$check) { |
|
| 655 | + // Don't tell them what files exactly because it's a spot check - just like teachers don't tell which problems they are spot checking, that's dumb. |
|
| 617 | 656 | return throw_error('The upgrader was unable to find some crucial files.<br><br>Please make sure you uploaded all of the files included in the package, including the Themes, Sources, and other directories.'); |
| 657 | + } |
|
| 618 | 658 | |
| 619 | 659 | // Do they meet the install requirements? |
| 620 | - if (!php_version_check()) |
|
| 621 | - return throw_error('Warning! You do not appear to have a version of PHP installed on your webserver that meets SMF\'s minimum installations requirements.<br><br>Please ask your host to upgrade.'); |
|
| 660 | + if (!php_version_check()) { |
|
| 661 | + return throw_error('Warning! You do not appear to have a version of PHP installed on your webserver that meets SMF\'s minimum installations requirements.<br><br>Please ask your host to upgrade.'); |
|
| 662 | + } |
|
| 622 | 663 | |
| 623 | - if (!db_version_check()) |
|
| 624 | - return throw_error('Your ' . $databases[$db_type]['name'] . ' version does not meet the minimum requirements of SMF.<br><br>Please ask your host to upgrade.'); |
|
| 664 | + if (!db_version_check()) { |
|
| 665 | + return throw_error('Your ' . $databases[$db_type]['name'] . ' version does not meet the minimum requirements of SMF.<br><br>Please ask your host to upgrade.'); |
|
| 666 | + } |
|
| 625 | 667 | |
| 626 | 668 | // Do some checks to make sure they have proper privileges |
| 627 | 669 | db_extend('packages'); |
@@ -636,14 +678,16 @@ discard block |
||
| 636 | 678 | $drop = $smcFunc['db_drop_table']('{db_prefix}priv_check'); |
| 637 | 679 | |
| 638 | 680 | // Sorry... we need CREATE, ALTER and DROP |
| 639 | - if (!$create || !$alter || !$drop) |
|
| 640 | - return throw_error('The ' . $databases[$db_type]['name'] . ' user you have set in Settings.php does not have proper privileges.<br><br>Please ask your host to give this user the ALTER, CREATE, and DROP privileges.'); |
|
| 681 | + if (!$create || !$alter || !$drop) { |
|
| 682 | + return throw_error('The ' . $databases[$db_type]['name'] . ' user you have set in Settings.php does not have proper privileges.<br><br>Please ask your host to give this user the ALTER, CREATE, and DROP privileges.'); |
|
| 683 | + } |
|
| 641 | 684 | |
| 642 | 685 | // Do a quick version spot check. |
| 643 | 686 | $temp = substr(@implode('', @file($boarddir . '/index.php')), 0, 4096); |
| 644 | 687 | preg_match('~\*\s@version\s+(.+)[\s]{2}~i', $temp, $match); |
| 645 | - if (empty($match[1]) || (trim($match[1]) != SMF_VERSION)) |
|
| 646 | - return throw_error('The upgrader found some old or outdated files.<br><br>Please make certain you uploaded the new versions of all the files included in the package.'); |
|
| 688 | + if (empty($match[1]) || (trim($match[1]) != SMF_VERSION)) { |
|
| 689 | + return throw_error('The upgrader found some old or outdated files.<br><br>Please make certain you uploaded the new versions of all the files included in the package.'); |
|
| 690 | + } |
|
| 647 | 691 | |
| 648 | 692 | // What absolutely needs to be writable? |
| 649 | 693 | $writable_files = array( |
@@ -665,12 +709,13 @@ discard block |
||
| 665 | 709 | quickFileWritable($custom_av_dir); |
| 666 | 710 | |
| 667 | 711 | // Are we good now? |
| 668 | - if (!is_writable($custom_av_dir)) |
|
| 669 | - return throw_error(sprintf('The directory: %1$s has to be writable to continue the upgrade. Please make sure permissions are correctly set to allow this.', $custom_av_dir)); |
|
| 670 | - elseif ($need_settings_update) |
|
| 712 | + if (!is_writable($custom_av_dir)) { |
|
| 713 | + return throw_error(sprintf('The directory: %1$s has to be writable to continue the upgrade. Please make sure permissions are correctly set to allow this.', $custom_av_dir)); |
|
| 714 | + } elseif ($need_settings_update) |
|
| 671 | 715 | { |
| 672 | - if (!function_exists('cache_put_data')) |
|
| 673 | - require_once($sourcedir . '/Load.php'); |
|
| 716 | + if (!function_exists('cache_put_data')) { |
|
| 717 | + require_once($sourcedir . '/Load.php'); |
|
| 718 | + } |
|
| 674 | 719 | updateSettings(array('custom_avatar_dir' => $custom_av_dir)); |
| 675 | 720 | updateSettings(array('custom_avatar_url' => $custom_av_url)); |
| 676 | 721 | } |
@@ -679,28 +724,33 @@ discard block |
||
| 679 | 724 | |
| 680 | 725 | // Check the cache directory. |
| 681 | 726 | $cachedir_temp = empty($cachedir) ? $boarddir . '/cache' : $cachedir; |
| 682 | - if (!file_exists($cachedir_temp)) |
|
| 683 | - @mkdir($cachedir_temp); |
|
| 684 | - if (!file_exists($cachedir_temp)) |
|
| 685 | - return throw_error('The cache directory could not be found.<br><br>Please make sure you have a directory called "cache" in your forum directory before continuing.'); |
|
| 686 | - |
|
| 687 | - if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang'])) |
|
| 688 | - return throw_error('The upgrader was unable to find language files for the language specified in Settings.php.<br>SMF will not work without the primary language files installed.<br><br>Please either install them, or <a href="' . $upgradeurl . '?step=0;lang=english">use english instead</a>.'); |
|
| 689 | - elseif (!isset($_GET['skiplang'])) |
|
| 727 | + if (!file_exists($cachedir_temp)) { |
|
| 728 | + @mkdir($cachedir_temp); |
|
| 729 | + } |
|
| 730 | + if (!file_exists($cachedir_temp)) { |
|
| 731 | + return throw_error('The cache directory could not be found.<br><br>Please make sure you have a directory called "cache" in your forum directory before continuing.'); |
|
| 732 | + } |
|
| 733 | + |
|
| 734 | + if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang'])) { |
|
| 735 | + return throw_error('The upgrader was unable to find language files for the language specified in Settings.php.<br>SMF will not work without the primary language files installed.<br><br>Please either install them, or <a href="' . $upgradeurl . '?step=0;lang=english">use english instead</a>.'); |
|
| 736 | + } elseif (!isset($_GET['skiplang'])) |
|
| 690 | 737 | { |
| 691 | 738 | $temp = substr(@implode('', @file($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php')), 0, 4096); |
| 692 | 739 | preg_match('~(?://|/\*)\s*Version:\s+(.+?);\s*index(?:[\s]{2}|\*/)~i', $temp, $match); |
| 693 | 740 | |
| 694 | - if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) |
|
| 695 | - return throw_error('The upgrader found some old or outdated language files, for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded the new versions of all the files included in the package, even the theme and language files for the default theme.<br> [<a href="' . $upgradeurl . '?skiplang">SKIP</a>] [<a href="' . $upgradeurl . '?lang=english">Try English</a>]'); |
|
| 741 | + if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) { |
|
| 742 | + return throw_error('The upgrader found some old or outdated language files, for the forum default language, ' . $upcontext['language'] . '.<br><br>Please make certain you uploaded the new versions of all the files included in the package, even the theme and language files for the default theme.<br> [<a href="' . $upgradeurl . '?skiplang">SKIP</a>] [<a href="' . $upgradeurl . '?lang=english">Try English</a>]'); |
|
| 743 | + } |
|
| 696 | 744 | } |
| 697 | 745 | |
| 698 | - if (!makeFilesWritable($writable_files)) |
|
| 699 | - return false; |
|
| 746 | + if (!makeFilesWritable($writable_files)) { |
|
| 747 | + return false; |
|
| 748 | + } |
|
| 700 | 749 | |
| 701 | 750 | // Check agreement.txt. (it may not exist, in which case $boarddir must be writable.) |
| 702 | - if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt')) |
|
| 703 | - return throw_error('The upgrader was unable to obtain write access to agreement.txt.<br><br>If you are using a linux or unix based server, please ensure that the file is chmod\'d to 777, or if it does not exist that the directory this upgrader is in is 777.<br>If your server is running Windows, please ensure that the internet guest account has the proper permissions on it or its folder.'); |
|
| 751 | + if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt')) { |
|
| 752 | + return throw_error('The upgrader was unable to obtain write access to agreement.txt.<br><br>If you are using a linux or unix based server, please ensure that the file is chmod\'d to 777, or if it does not exist that the directory this upgrader is in is 777.<br>If your server is running Windows, please ensure that the internet guest account has the proper permissions on it or its folder.'); |
|
| 753 | + } |
|
| 704 | 754 | |
| 705 | 755 | // Upgrade the agreement. |
| 706 | 756 | elseif (isset($modSettings['agreement'])) |
@@ -711,8 +761,8 @@ discard block |
||
| 711 | 761 | } |
| 712 | 762 | |
| 713 | 763 | // We're going to check that their board dir setting is right in case they've been moving stuff around. |
| 714 | - if (strtr($boarddir, array('/' => '', '\\' => '')) != strtr(dirname(__FILE__), array('/' => '', '\\' => ''))) |
|
| 715 | - $upcontext['warning'] = ' |
|
| 764 | + if (strtr($boarddir, array('/' => '', '\\' => '')) != strtr(dirname(__FILE__), array('/' => '', '\\' => ''))) { |
|
| 765 | + $upcontext['warning'] = ' |
|
| 716 | 766 | It looks as if your board directory settings <em>might</em> be incorrect. Your board directory is currently set to "' . $boarddir . '" but should probably be "' . dirname(__FILE__) . '". Settings.php currently lists your paths as:<br> |
| 717 | 767 | <ul> |
| 718 | 768 | <li>Board Directory: ' . $boarddir . '</li> |
@@ -720,10 +770,12 @@ discard block |
||
| 720 | 770 | <li>Cache Directory: ' . $cachedir_temp . '</li> |
| 721 | 771 | </ul> |
| 722 | 772 | If these seem incorrect please open Settings.php in a text editor before proceeding with this upgrade. If they are incorrect due to you moving your forum to a new location please download and execute the <a href="https://download.simplemachines.org/?tools">Repair Settings</a> tool from the Simple Machines website before continuing.'; |
| 773 | + } |
|
| 723 | 774 | |
| 724 | 775 | // Either we're logged in or we're going to present the login. |
| 725 | - if (checkLogin()) |
|
| 726 | - return true; |
|
| 776 | + if (checkLogin()) { |
|
| 777 | + return true; |
|
| 778 | + } |
|
| 727 | 779 | |
| 728 | 780 | $upcontext += createToken('login'); |
| 729 | 781 | |
@@ -737,15 +789,17 @@ discard block |
||
| 737 | 789 | global $smcFunc, $db_type, $support_js; |
| 738 | 790 | |
| 739 | 791 | // Don't bother if the security is disabled. |
| 740 | - if ($disable_security) |
|
| 741 | - return true; |
|
| 792 | + if ($disable_security) { |
|
| 793 | + return true; |
|
| 794 | + } |
|
| 742 | 795 | |
| 743 | 796 | // Are we trying to login? |
| 744 | 797 | if (isset($_POST['contbutt']) && (!empty($_POST['user']))) |
| 745 | 798 | { |
| 746 | 799 | // If we've disabled security pick a suitable name! |
| 747 | - if (empty($_POST['user'])) |
|
| 748 | - $_POST['user'] = 'Administrator'; |
|
| 800 | + if (empty($_POST['user'])) { |
|
| 801 | + $_POST['user'] = 'Administrator'; |
|
| 802 | + } |
|
| 749 | 803 | |
| 750 | 804 | // Before 2.0 these column names were different! |
| 751 | 805 | $oldDB = false; |
@@ -760,16 +814,17 @@ discard block |
||
| 760 | 814 | 'db_error_skip' => true, |
| 761 | 815 | ) |
| 762 | 816 | ); |
| 763 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
| 764 | - $oldDB = true; |
|
| 817 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
| 818 | + $oldDB = true; |
|
| 819 | + } |
|
| 765 | 820 | $smcFunc['db_free_result']($request); |
| 766 | 821 | } |
| 767 | 822 | |
| 768 | 823 | // Get what we believe to be their details. |
| 769 | 824 | if (!$disable_security) |
| 770 | 825 | { |
| 771 | - if ($oldDB) |
|
| 772 | - $request = $smcFunc['db_query']('', ' |
|
| 826 | + if ($oldDB) { |
|
| 827 | + $request = $smcFunc['db_query']('', ' |
|
| 773 | 828 | SELECT id_member, memberName AS member_name, passwd, id_group, |
| 774 | 829 | additionalGroups AS additional_groups, lngfile |
| 775 | 830 | FROM {db_prefix}members |
@@ -779,8 +834,8 @@ discard block |
||
| 779 | 834 | 'db_error_skip' => true, |
| 780 | 835 | ) |
| 781 | 836 | ); |
| 782 | - else |
|
| 783 | - $request = $smcFunc['db_query']('', ' |
|
| 837 | + } else { |
|
| 838 | + $request = $smcFunc['db_query']('', ' |
|
| 784 | 839 | SELECT id_member, member_name, passwd, id_group, additional_groups, lngfile |
| 785 | 840 | FROM {db_prefix}members |
| 786 | 841 | WHERE member_name = {string:member_name}', |
@@ -789,6 +844,7 @@ discard block |
||
| 789 | 844 | 'db_error_skip' => true, |
| 790 | 845 | ) |
| 791 | 846 | ); |
| 847 | + } |
|
| 792 | 848 | if ($smcFunc['db_num_rows']($request) != 0) |
| 793 | 849 | { |
| 794 | 850 | list ($id_member, $name, $password, $id_group, $addGroups, $user_language) = $smcFunc['db_fetch_row']($request); |
@@ -796,16 +852,17 @@ discard block |
||
| 796 | 852 | $groups = explode(',', $addGroups); |
| 797 | 853 | $groups[] = $id_group; |
| 798 | 854 | |
| 799 | - foreach ($groups as $k => $v) |
|
| 800 | - $groups[$k] = (int) $v; |
|
| 855 | + foreach ($groups as $k => $v) { |
|
| 856 | + $groups[$k] = (int) $v; |
|
| 857 | + } |
|
| 801 | 858 | |
| 802 | 859 | $sha_passwd = sha1(strtolower($name) . un_htmlspecialchars($_REQUEST['passwrd'])); |
| 803 | 860 | |
| 804 | 861 | // We don't use "-utf8" anymore... |
| 805 | 862 | $user_language = str_ireplace('-utf8', '', $user_language); |
| 863 | + } else { |
|
| 864 | + $upcontext['username_incorrect'] = true; |
|
| 806 | 865 | } |
| 807 | - else |
|
| 808 | - $upcontext['username_incorrect'] = true; |
|
| 809 | 866 | $smcFunc['db_free_result']($request); |
| 810 | 867 | } |
| 811 | 868 | $upcontext['username'] = $_POST['user']; |
@@ -815,13 +872,14 @@ discard block |
||
| 815 | 872 | { |
| 816 | 873 | $upcontext['upgrade_status']['js'] = 1; |
| 817 | 874 | $support_js = 1; |
| 875 | + } else { |
|
| 876 | + $support_js = 0; |
|
| 818 | 877 | } |
| 819 | - else |
|
| 820 | - $support_js = 0; |
|
| 821 | 878 | |
| 822 | 879 | // Note down the version we are coming from. |
| 823 | - if (!empty($modSettings['smfVersion']) && empty($upcontext['user']['version'])) |
|
| 824 | - $upcontext['user']['version'] = $modSettings['smfVersion']; |
|
| 880 | + if (!empty($modSettings['smfVersion']) && empty($upcontext['user']['version'])) { |
|
| 881 | + $upcontext['user']['version'] = $modSettings['smfVersion']; |
|
| 882 | + } |
|
| 825 | 883 | |
| 826 | 884 | // Didn't get anywhere? |
| 827 | 885 | if (!$disable_security && (empty($sha_passwd) || (!empty($password) ? $password : '') != $sha_passwd) && !hash_verify_password((!empty($name) ? $name : ''), $_REQUEST['passwrd'], (!empty($password) ? $password : '')) && empty($upcontext['username_incorrect'])) |
@@ -855,15 +913,15 @@ discard block |
||
| 855 | 913 | 'db_error_skip' => true, |
| 856 | 914 | ) |
| 857 | 915 | ); |
| 858 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
| 859 | - return throw_error('You need to be an admin to perform an upgrade!'); |
|
| 916 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
| 917 | + return throw_error('You need to be an admin to perform an upgrade!'); |
|
| 918 | + } |
|
| 860 | 919 | $smcFunc['db_free_result']($request); |
| 861 | 920 | } |
| 862 | 921 | |
| 863 | 922 | $upcontext['user']['id'] = $id_member; |
| 864 | 923 | $upcontext['user']['name'] = $name; |
| 865 | - } |
|
| 866 | - else |
|
| 924 | + } else |
|
| 867 | 925 | { |
| 868 | 926 | $upcontext['user']['id'] = 1; |
| 869 | 927 | $upcontext['user']['name'] = 'Administrator'; |
@@ -879,11 +937,11 @@ discard block |
||
| 879 | 937 | $temp = substr(@implode('', @file($modSettings['theme_dir'] . '/languages/index.' . $user_language . '.php')), 0, 4096); |
| 880 | 938 | preg_match('~(?://|/\*)\s*Version:\s+(.+?);\s*index(?:[\s]{2}|\*/)~i', $temp, $match); |
| 881 | 939 | |
| 882 | - if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) |
|
| 883 | - $upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been updated to the latest version. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.'; |
|
| 884 | - elseif (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . basename($user_language, '.lng') . '.php')) |
|
| 885 | - $upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been uploaded/updated as the "Install" language file is missing. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.'; |
|
| 886 | - else |
|
| 940 | + if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) { |
|
| 941 | + $upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been updated to the latest version. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.'; |
|
| 942 | + } elseif (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . basename($user_language, '.lng') . '.php')) { |
|
| 943 | + $upcontext['upgrade_options_warning'] = 'The language files for your selected language, ' . $user_language . ', have not been uploaded/updated as the "Install" language file is missing. Upgrade will continue with the forum default, ' . $upcontext['language'] . '.'; |
|
| 944 | + } else |
|
| 887 | 945 | { |
| 888 | 946 | // Set this as the new language. |
| 889 | 947 | $upcontext['language'] = $user_language; |
@@ -927,8 +985,9 @@ discard block |
||
| 927 | 985 | unset($member_columns); |
| 928 | 986 | |
| 929 | 987 | // If we've not submitted then we're done. |
| 930 | - if (empty($_POST['upcont'])) |
|
| 931 | - return false; |
|
| 988 | + if (empty($_POST['upcont'])) { |
|
| 989 | + return false; |
|
| 990 | + } |
|
| 932 | 991 | |
| 933 | 992 | // Firstly, if they're enabling SM stat collection just do it. |
| 934 | 993 | if (!empty($_POST['stats']) && (substr($boardurl, 0, 16) != 'http://localhost' || substr($boardurl, 0, 16) != 'https://localhost') && empty($modSettings['allow_sm_stats'])) |
@@ -943,25 +1002,26 @@ discard block |
||
| 943 | 1002 | fwrite($fp, $out); |
| 944 | 1003 | |
| 945 | 1004 | $return_data = ''; |
| 946 | - while (!feof($fp)) |
|
| 947 | - $return_data .= fgets($fp, 128); |
|
| 1005 | + while (!feof($fp)) { |
|
| 1006 | + $return_data .= fgets($fp, 128); |
|
| 1007 | + } |
|
| 948 | 1008 | |
| 949 | 1009 | fclose($fp); |
| 950 | 1010 | |
| 951 | 1011 | // Get the unique site ID. |
| 952 | 1012 | preg_match('~SITE-ID:\s(\w{10})~', $return_data, $ID); |
| 953 | 1013 | |
| 954 | - if (!empty($ID[1])) |
|
| 955 | - $smcFunc['db_insert']('replace', |
|
| 1014 | + if (!empty($ID[1])) { |
|
| 1015 | + $smcFunc['db_insert']('replace', |
|
| 956 | 1016 | $db_prefix . 'settings', |
| 957 | 1017 | array('variable' => 'string', 'value' => 'string'), |
| 958 | 1018 | array('allow_sm_stats', $ID[1]), |
| 959 | 1019 | array('variable') |
| 960 | 1020 | ); |
| 1021 | + } |
|
| 961 | 1022 | } |
| 962 | - } |
|
| 963 | - else |
|
| 964 | - $smcFunc['db_query']('', ' |
|
| 1023 | + } else { |
|
| 1024 | + $smcFunc['db_query']('', ' |
|
| 965 | 1025 | DELETE FROM {db_prefix}settings |
| 966 | 1026 | WHERE variable = {string:allow_sm_stats}', |
| 967 | 1027 | array( |
@@ -969,6 +1029,7 @@ discard block |
||
| 969 | 1029 | 'db_error_skip' => true, |
| 970 | 1030 | ) |
| 971 | 1031 | ); |
| 1032 | + } |
|
| 972 | 1033 | |
| 973 | 1034 | // Deleting old karma stuff? |
| 974 | 1035 | if (!empty($_POST['delete_karma'])) |
@@ -983,20 +1044,22 @@ discard block |
||
| 983 | 1044 | ); |
| 984 | 1045 | |
| 985 | 1046 | // Cleaning up old karma member settings. |
| 986 | - if ($upcontext['karma_installed']['good']) |
|
| 987 | - $smcFunc['db_query']('', ' |
|
| 1047 | + if ($upcontext['karma_installed']['good']) { |
|
| 1048 | + $smcFunc['db_query']('', ' |
|
| 988 | 1049 | ALTER TABLE {db_prefix}members |
| 989 | 1050 | DROP karma_good', |
| 990 | 1051 | array() |
| 991 | 1052 | ); |
| 1053 | + } |
|
| 992 | 1054 | |
| 993 | 1055 | // Does karma bad was enable? |
| 994 | - if ($upcontext['karma_installed']['bad']) |
|
| 995 | - $smcFunc['db_query']('', ' |
|
| 1056 | + if ($upcontext['karma_installed']['bad']) { |
|
| 1057 | + $smcFunc['db_query']('', ' |
|
| 996 | 1058 | ALTER TABLE {db_prefix}members |
| 997 | 1059 | DROP karma_bad', |
| 998 | 1060 | array() |
| 999 | 1061 | ); |
| 1062 | + } |
|
| 1000 | 1063 | |
| 1001 | 1064 | // Cleaning up old karma permissions. |
| 1002 | 1065 | $smcFunc['db_query']('', ' |
@@ -1009,26 +1072,29 @@ discard block |
||
| 1009 | 1072 | } |
| 1010 | 1073 | |
| 1011 | 1074 | // Emptying the error log? |
| 1012 | - if (!empty($_POST['empty_error'])) |
|
| 1013 | - $smcFunc['db_query']('truncate_table', ' |
|
| 1075 | + if (!empty($_POST['empty_error'])) { |
|
| 1076 | + $smcFunc['db_query']('truncate_table', ' |
|
| 1014 | 1077 | TRUNCATE {db_prefix}log_errors', |
| 1015 | 1078 | array( |
| 1016 | 1079 | ) |
| 1017 | 1080 | ); |
| 1081 | + } |
|
| 1018 | 1082 | |
| 1019 | 1083 | $changes = array(); |
| 1020 | 1084 | |
| 1021 | 1085 | // Add proxy settings. |
| 1022 | - if (!isset($GLOBALS['image_proxy_maxsize'])) |
|
| 1023 | - $changes += array( |
|
| 1086 | + if (!isset($GLOBALS['image_proxy_maxsize'])) { |
|
| 1087 | + $changes += array( |
|
| 1024 | 1088 | 'image_proxy_secret' => '\'' . substr(sha1(mt_rand()), 0, 20) . '\'', |
| 1025 | 1089 | 'image_proxy_maxsize' => 5190, |
| 1026 | 1090 | 'image_proxy_enabled' => 0, |
| 1027 | 1091 | ); |
| 1092 | + } |
|
| 1028 | 1093 | |
| 1029 | 1094 | // If we're overriding the language follow it through. |
| 1030 | - if (isset($_GET['lang']) && file_exists($modSettings['theme_dir'] . '/languages/index.' . $_GET['lang'] . '.php')) |
|
| 1031 | - $changes['language'] = '\'' . $_GET['lang'] . '\''; |
|
| 1095 | + if (isset($_GET['lang']) && file_exists($modSettings['theme_dir'] . '/languages/index.' . $_GET['lang'] . '.php')) { |
|
| 1096 | + $changes['language'] = '\'' . $_GET['lang'] . '\''; |
|
| 1097 | + } |
|
| 1032 | 1098 | |
| 1033 | 1099 | if (!empty($_POST['maint'])) |
| 1034 | 1100 | { |
@@ -1040,30 +1106,34 @@ discard block |
||
| 1040 | 1106 | { |
| 1041 | 1107 | $changes['mtitle'] = '\'' . addslashes($_POST['maintitle']) . '\''; |
| 1042 | 1108 | $changes['mmessage'] = '\'' . addslashes($_POST['mainmessage']) . '\''; |
| 1043 | - } |
|
| 1044 | - else |
|
| 1109 | + } else |
|
| 1045 | 1110 | { |
| 1046 | 1111 | $changes['mtitle'] = '\'Upgrading the forum...\''; |
| 1047 | 1112 | $changes['mmessage'] = '\'Don\\\'t worry, we will be back shortly with an updated forum. It will only be a minute ;).\''; |
| 1048 | 1113 | } |
| 1049 | 1114 | } |
| 1050 | 1115 | |
| 1051 | - if ($command_line) |
|
| 1052 | - echo ' * Updating Settings.php...'; |
|
| 1116 | + if ($command_line) { |
|
| 1117 | + echo ' * Updating Settings.php...'; |
|
| 1118 | + } |
|
| 1053 | 1119 | |
| 1054 | 1120 | // Fix some old paths. |
| 1055 | - if (substr($boarddir, 0, 1) == '.') |
|
| 1056 | - $changes['boarddir'] = '\'' . fixRelativePath($boarddir) . '\''; |
|
| 1121 | + if (substr($boarddir, 0, 1) == '.') { |
|
| 1122 | + $changes['boarddir'] = '\'' . fixRelativePath($boarddir) . '\''; |
|
| 1123 | + } |
|
| 1057 | 1124 | |
| 1058 | - if (substr($sourcedir, 0, 1) == '.') |
|
| 1059 | - $changes['sourcedir'] = '\'' . fixRelativePath($sourcedir) . '\''; |
|
| 1125 | + if (substr($sourcedir, 0, 1) == '.') { |
|
| 1126 | + $changes['sourcedir'] = '\'' . fixRelativePath($sourcedir) . '\''; |
|
| 1127 | + } |
|
| 1060 | 1128 | |
| 1061 | - if (empty($cachedir) || substr($cachedir, 0, 1) == '.') |
|
| 1062 | - $changes['cachedir'] = '\'' . fixRelativePath($boarddir) . '/cache\''; |
|
| 1129 | + if (empty($cachedir) || substr($cachedir, 0, 1) == '.') { |
|
| 1130 | + $changes['cachedir'] = '\'' . fixRelativePath($boarddir) . '/cache\''; |
|
| 1131 | + } |
|
| 1063 | 1132 | |
| 1064 | 1133 | // Not had the database type added before? |
| 1065 | - if (empty($db_type)) |
|
| 1066 | - $changes['db_type'] = 'mysql'; |
|
| 1134 | + if (empty($db_type)) { |
|
| 1135 | + $changes['db_type'] = 'mysql'; |
|
| 1136 | + } |
|
| 1067 | 1137 | |
| 1068 | 1138 | // If they have a "host:port" setup for the host, split that into separate values |
| 1069 | 1139 | // You should never have a : in the hostname if you're not on MySQL, but better safe than sorry |
@@ -1074,32 +1144,36 @@ discard block |
||
| 1074 | 1144 | $changes['db_server'] = '\'' . $db_server . '\''; |
| 1075 | 1145 | |
| 1076 | 1146 | // Only set this if we're not using the default port |
| 1077 | - if ($db_port != ini_get('mysqli.default_port')) |
|
| 1078 | - $changes['db_port'] = (int) $db_port; |
|
| 1079 | - } |
|
| 1080 | - elseif (!empty($db_port)) |
|
| 1147 | + if ($db_port != ini_get('mysqli.default_port')) { |
|
| 1148 | + $changes['db_port'] = (int) $db_port; |
|
| 1149 | + } |
|
| 1150 | + } elseif (!empty($db_port)) |
|
| 1081 | 1151 | { |
| 1082 | 1152 | // If db_port is set and is the same as the default, set it to '' |
| 1083 | 1153 | if ($db_type == 'mysql') |
| 1084 | 1154 | { |
| 1085 | - if ($db_port == ini_get('mysqli.default_port')) |
|
| 1086 | - $changes['db_port'] = '\'\''; |
|
| 1087 | - elseif ($db_type == 'postgresql' && $db_port == 5432) |
|
| 1088 | - $changes['db_port'] = '\'\''; |
|
| 1155 | + if ($db_port == ini_get('mysqli.default_port')) { |
|
| 1156 | + $changes['db_port'] = '\'\''; |
|
| 1157 | + } elseif ($db_type == 'postgresql' && $db_port == 5432) { |
|
| 1158 | + $changes['db_port'] = '\'\''; |
|
| 1159 | + } |
|
| 1089 | 1160 | } |
| 1090 | 1161 | } |
| 1091 | 1162 | |
| 1092 | 1163 | // Maybe we haven't had this option yet? |
| 1093 | - if (empty($packagesdir)) |
|
| 1094 | - $changes['packagesdir'] = '\'' . fixRelativePath($boarddir) . '/Packages\''; |
|
| 1164 | + if (empty($packagesdir)) { |
|
| 1165 | + $changes['packagesdir'] = '\'' . fixRelativePath($boarddir) . '/Packages\''; |
|
| 1166 | + } |
|
| 1095 | 1167 | |
| 1096 | 1168 | // Add support for $tasksdir var. |
| 1097 | - if (empty($tasksdir)) |
|
| 1098 | - $changes['tasksdir'] = '\'' . fixRelativePath($sourcedir) . '/tasks\''; |
|
| 1169 | + if (empty($tasksdir)) { |
|
| 1170 | + $changes['tasksdir'] = '\'' . fixRelativePath($sourcedir) . '/tasks\''; |
|
| 1171 | + } |
|
| 1099 | 1172 | |
| 1100 | 1173 | // Make sure we fix the language as well. |
| 1101 | - if (stristr($language, '-utf8')) |
|
| 1102 | - $changes['language'] = '\'' . str_ireplace('-utf8', '', $language) . '\''; |
|
| 1174 | + if (stristr($language, '-utf8')) { |
|
| 1175 | + $changes['language'] = '\'' . str_ireplace('-utf8', '', $language) . '\''; |
|
| 1176 | + } |
|
| 1103 | 1177 | |
| 1104 | 1178 | // @todo Maybe change the cookie name if going to 1.1, too? |
| 1105 | 1179 | |
@@ -1107,8 +1181,9 @@ discard block |
||
| 1107 | 1181 | require_once($sourcedir . '/Subs-Admin.php'); |
| 1108 | 1182 | updateSettingsFile($changes); |
| 1109 | 1183 | |
| 1110 | - if ($command_line) |
|
| 1111 | - echo ' Successful.' . "\n"; |
|
| 1184 | + if ($command_line) { |
|
| 1185 | + echo ' Successful.' . "\n"; |
|
| 1186 | + } |
|
| 1112 | 1187 | |
| 1113 | 1188 | // Are we doing debug? |
| 1114 | 1189 | if (isset($_POST['debug'])) |
@@ -1118,8 +1193,9 @@ discard block |
||
| 1118 | 1193 | } |
| 1119 | 1194 | |
| 1120 | 1195 | // If we're not backing up then jump one. |
| 1121 | - if (empty($_POST['backup'])) |
|
| 1122 | - $upcontext['current_step']++; |
|
| 1196 | + if (empty($_POST['backup'])) { |
|
| 1197 | + $upcontext['current_step']++; |
|
| 1198 | + } |
|
| 1123 | 1199 | |
| 1124 | 1200 | // If we've got here then let's proceed to the next step! |
| 1125 | 1201 | return true; |
@@ -1134,8 +1210,9 @@ discard block |
||
| 1134 | 1210 | $upcontext['page_title'] = 'Backup Database'; |
| 1135 | 1211 | |
| 1136 | 1212 | // Done it already - js wise? |
| 1137 | - if (!empty($_POST['backup_done'])) |
|
| 1138 | - return true; |
|
| 1213 | + if (!empty($_POST['backup_done'])) { |
|
| 1214 | + return true; |
|
| 1215 | + } |
|
| 1139 | 1216 | |
| 1140 | 1217 | // Some useful stuff here. |
| 1141 | 1218 | db_extend(); |
@@ -1149,9 +1226,10 @@ discard block |
||
| 1149 | 1226 | $tables = $smcFunc['db_list_tables']($db, $filter); |
| 1150 | 1227 | |
| 1151 | 1228 | $table_names = array(); |
| 1152 | - foreach ($tables as $table) |
|
| 1153 | - if (substr($table, 0, 7) !== 'backup_') |
|
| 1229 | + foreach ($tables as $table) { |
|
| 1230 | + if (substr($table, 0, 7) !== 'backup_') |
|
| 1154 | 1231 | $table_names[] = $table; |
| 1232 | + } |
|
| 1155 | 1233 | |
| 1156 | 1234 | $upcontext['table_count'] = count($table_names); |
| 1157 | 1235 | $upcontext['cur_table_num'] = $_GET['substep']; |
@@ -1161,12 +1239,14 @@ discard block |
||
| 1161 | 1239 | $file_steps = $upcontext['table_count']; |
| 1162 | 1240 | |
| 1163 | 1241 | // What ones have we already done? |
| 1164 | - foreach ($table_names as $id => $table) |
|
| 1165 | - if ($id < $_GET['substep']) |
|
| 1242 | + foreach ($table_names as $id => $table) { |
|
| 1243 | + if ($id < $_GET['substep']) |
|
| 1166 | 1244 | $upcontext['previous_tables'][] = $table; |
| 1245 | + } |
|
| 1167 | 1246 | |
| 1168 | - if ($command_line) |
|
| 1169 | - echo 'Backing Up Tables.'; |
|
| 1247 | + if ($command_line) { |
|
| 1248 | + echo 'Backing Up Tables.'; |
|
| 1249 | + } |
|
| 1170 | 1250 | |
| 1171 | 1251 | // If we don't support javascript we backup here. |
| 1172 | 1252 | if (!$support_js || isset($_GET['xml'])) |
@@ -1185,8 +1265,9 @@ discard block |
||
| 1185 | 1265 | backupTable($table_names[$substep]); |
| 1186 | 1266 | |
| 1187 | 1267 | // If this is XML to keep it nice for the user do one table at a time anyway! |
| 1188 | - if (isset($_GET['xml'])) |
|
| 1189 | - return upgradeExit(); |
|
| 1268 | + if (isset($_GET['xml'])) { |
|
| 1269 | + return upgradeExit(); |
|
| 1270 | + } |
|
| 1190 | 1271 | } |
| 1191 | 1272 | |
| 1192 | 1273 | if ($command_line) |
@@ -1219,9 +1300,10 @@ discard block |
||
| 1219 | 1300 | |
| 1220 | 1301 | $smcFunc['db_backup_table']($table, 'backup_' . $table); |
| 1221 | 1302 | |
| 1222 | - if ($command_line) |
|
| 1223 | - echo ' done.'; |
|
| 1224 | -} |
|
| 1303 | + if ($command_line) { |
|
| 1304 | + echo ' done.'; |
|
| 1305 | + } |
|
| 1306 | + } |
|
| 1225 | 1307 | |
| 1226 | 1308 | // Step 2: Everything. |
| 1227 | 1309 | function DatabaseChanges() |
@@ -1230,8 +1312,9 @@ discard block |
||
| 1230 | 1312 | global $upcontext, $support_js, $db_type; |
| 1231 | 1313 | |
| 1232 | 1314 | // Have we just completed this? |
| 1233 | - if (!empty($_POST['database_done'])) |
|
| 1234 | - return true; |
|
| 1315 | + if (!empty($_POST['database_done'])) { |
|
| 1316 | + return true; |
|
| 1317 | + } |
|
| 1235 | 1318 | |
| 1236 | 1319 | $upcontext['sub_template'] = isset($_GET['xml']) ? 'database_xml' : 'database_changes'; |
| 1237 | 1320 | $upcontext['page_title'] = 'Database Changes'; |
@@ -1246,15 +1329,16 @@ discard block |
||
| 1246 | 1329 | ); |
| 1247 | 1330 | |
| 1248 | 1331 | // How many files are there in total? |
| 1249 | - if (isset($_GET['filecount'])) |
|
| 1250 | - $upcontext['file_count'] = (int) $_GET['filecount']; |
|
| 1251 | - else |
|
| 1332 | + if (isset($_GET['filecount'])) { |
|
| 1333 | + $upcontext['file_count'] = (int) $_GET['filecount']; |
|
| 1334 | + } else |
|
| 1252 | 1335 | { |
| 1253 | 1336 | $upcontext['file_count'] = 0; |
| 1254 | 1337 | foreach ($files as $file) |
| 1255 | 1338 | { |
| 1256 | - if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < $file[1]) |
|
| 1257 | - $upcontext['file_count']++; |
|
| 1339 | + if (!isset($modSettings['smfVersion']) || $modSettings['smfVersion'] < $file[1]) { |
|
| 1340 | + $upcontext['file_count']++; |
|
| 1341 | + } |
|
| 1258 | 1342 | } |
| 1259 | 1343 | } |
| 1260 | 1344 | |
@@ -1264,9 +1348,9 @@ discard block |
||
| 1264 | 1348 | $upcontext['cur_file_num'] = 0; |
| 1265 | 1349 | foreach ($files as $file) |
| 1266 | 1350 | { |
| 1267 | - if ($did_not_do) |
|
| 1268 | - $did_not_do--; |
|
| 1269 | - else |
|
| 1351 | + if ($did_not_do) { |
|
| 1352 | + $did_not_do--; |
|
| 1353 | + } else |
|
| 1270 | 1354 | { |
| 1271 | 1355 | $upcontext['cur_file_num']++; |
| 1272 | 1356 | $upcontext['cur_file_name'] = $file[0]; |
@@ -1293,12 +1377,13 @@ discard block |
||
| 1293 | 1377 | // Flag to move on to the next. |
| 1294 | 1378 | $upcontext['completed_step'] = true; |
| 1295 | 1379 | // Did we complete the whole file? |
| 1296 | - if ($nextFile) |
|
| 1297 | - $upcontext['current_debug_item_num'] = -1; |
|
| 1380 | + if ($nextFile) { |
|
| 1381 | + $upcontext['current_debug_item_num'] = -1; |
|
| 1382 | + } |
|
| 1298 | 1383 | return upgradeExit(); |
| 1384 | + } elseif ($support_js) { |
|
| 1385 | + break; |
|
| 1299 | 1386 | } |
| 1300 | - elseif ($support_js) |
|
| 1301 | - break; |
|
| 1302 | 1387 | } |
| 1303 | 1388 | // Set the progress bar to be right as if we had - even if we hadn't... |
| 1304 | 1389 | $upcontext['step_progress'] = ($upcontext['cur_file_num'] / $upcontext['file_count']) * 100; |
@@ -1323,8 +1408,9 @@ discard block |
||
| 1323 | 1408 | global $command_line, $language, $upcontext, $boarddir, $sourcedir, $forum_version, $user_info, $maintenance, $smcFunc, $db_type; |
| 1324 | 1409 | |
| 1325 | 1410 | // Now it's nice to have some of the basic SMF source files. |
| 1326 | - if (!isset($_GET['ssi']) && !$command_line) |
|
| 1327 | - redirectLocation('&ssi=1'); |
|
| 1411 | + if (!isset($_GET['ssi']) && !$command_line) { |
|
| 1412 | + redirectLocation('&ssi=1'); |
|
| 1413 | + } |
|
| 1328 | 1414 | |
| 1329 | 1415 | $upcontext['sub_template'] = 'upgrade_complete'; |
| 1330 | 1416 | $upcontext['page_title'] = 'Upgrade Complete'; |
@@ -1340,14 +1426,16 @@ discard block |
||
| 1340 | 1426 | // Are we in maintenance mode? |
| 1341 | 1427 | if (isset($upcontext['user']['main'])) |
| 1342 | 1428 | { |
| 1343 | - if ($command_line) |
|
| 1344 | - echo ' * '; |
|
| 1429 | + if ($command_line) { |
|
| 1430 | + echo ' * '; |
|
| 1431 | + } |
|
| 1345 | 1432 | $upcontext['removed_maintenance'] = true; |
| 1346 | 1433 | $changes['maintenance'] = $upcontext['user']['main']; |
| 1347 | 1434 | } |
| 1348 | 1435 | // Otherwise if somehow we are in 2 let's go to 1. |
| 1349 | - elseif (!empty($maintenance) && $maintenance == 2) |
|
| 1350 | - $changes['maintenance'] = 1; |
|
| 1436 | + elseif (!empty($maintenance) && $maintenance == 2) { |
|
| 1437 | + $changes['maintenance'] = 1; |
|
| 1438 | + } |
|
| 1351 | 1439 | |
| 1352 | 1440 | // Wipe this out... |
| 1353 | 1441 | $upcontext['user'] = array(); |
@@ -1362,9 +1450,9 @@ discard block |
||
| 1362 | 1450 | $upcontext['can_delete_script'] = is_writable(dirname(__FILE__)) || is_writable(__FILE__); |
| 1363 | 1451 | |
| 1364 | 1452 | // Now is the perfect time to fetch the SM files. |
| 1365 | - if ($command_line) |
|
| 1366 | - cli_scheduled_fetchSMfiles(); |
|
| 1367 | - else |
|
| 1453 | + if ($command_line) { |
|
| 1454 | + cli_scheduled_fetchSMfiles(); |
|
| 1455 | + } else |
|
| 1368 | 1456 | { |
| 1369 | 1457 | require_once($sourcedir . '/ScheduledTasks.php'); |
| 1370 | 1458 | $forum_version = SMF_VERSION; // The variable is usually defined in index.php so lets just use the constant to do it for us. |
@@ -1372,8 +1460,9 @@ discard block |
||
| 1372 | 1460 | } |
| 1373 | 1461 | |
| 1374 | 1462 | // Log what we've done. |
| 1375 | - if (empty($user_info['id'])) |
|
| 1376 | - $user_info['id'] = !empty($upcontext['user']['id']) ? $upcontext['user']['id'] : 0; |
|
| 1463 | + if (empty($user_info['id'])) { |
|
| 1464 | + $user_info['id'] = !empty($upcontext['user']['id']) ? $upcontext['user']['id'] : 0; |
|
| 1465 | + } |
|
| 1377 | 1466 | |
| 1378 | 1467 | // Log the action manually, so CLI still works. |
| 1379 | 1468 | $smcFunc['db_insert']('', |
@@ -1392,8 +1481,9 @@ discard block |
||
| 1392 | 1481 | |
| 1393 | 1482 | // Save the current database version. |
| 1394 | 1483 | $server_version = $smcFunc['db_server_info'](); |
| 1395 | - if ($db_type == 'mysql' && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) |
|
| 1396 | - updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
| 1484 | + if ($db_type == 'mysql' && in_array(substr($server_version, 0, 6), array('5.0.50', '5.0.51'))) { |
|
| 1485 | + updateSettings(array('db_mysql_group_by_fix' => '1')); |
|
| 1486 | + } |
|
| 1397 | 1487 | |
| 1398 | 1488 | if ($command_line) |
| 1399 | 1489 | { |
@@ -1405,8 +1495,9 @@ discard block |
||
| 1405 | 1495 | |
| 1406 | 1496 | // Make sure it says we're done. |
| 1407 | 1497 | $upcontext['overall_percent'] = 100; |
| 1408 | - if (isset($upcontext['step_progress'])) |
|
| 1409 | - unset($upcontext['step_progress']); |
|
| 1498 | + if (isset($upcontext['step_progress'])) { |
|
| 1499 | + unset($upcontext['step_progress']); |
|
| 1500 | + } |
|
| 1410 | 1501 | |
| 1411 | 1502 | $_GET['substep'] = 0; |
| 1412 | 1503 | return false; |
@@ -1417,8 +1508,9 @@ discard block |
||
| 1417 | 1508 | { |
| 1418 | 1509 | global $sourcedir, $language, $forum_version, $modSettings, $smcFunc; |
| 1419 | 1510 | |
| 1420 | - if (empty($modSettings['time_format'])) |
|
| 1421 | - $modSettings['time_format'] = '%B %d, %Y, %I:%M:%S %p'; |
|
| 1511 | + if (empty($modSettings['time_format'])) { |
|
| 1512 | + $modSettings['time_format'] = '%B %d, %Y, %I:%M:%S %p'; |
|
| 1513 | + } |
|
| 1422 | 1514 | |
| 1423 | 1515 | // What files do we want to get |
| 1424 | 1516 | $request = $smcFunc['db_query']('', ' |
@@ -1452,8 +1544,9 @@ discard block |
||
| 1452 | 1544 | $file_data = fetch_web_data($url); |
| 1453 | 1545 | |
| 1454 | 1546 | // If we got an error - give up - the site might be down. |
| 1455 | - if ($file_data === false) |
|
| 1456 | - return throw_error(sprintf('Could not retrieve the file %1$s.', $url)); |
|
| 1547 | + if ($file_data === false) { |
|
| 1548 | + return throw_error(sprintf('Could not retrieve the file %1$s.', $url)); |
|
| 1549 | + } |
|
| 1457 | 1550 | |
| 1458 | 1551 | // Save the file to the database. |
| 1459 | 1552 | $smcFunc['db_query']('substring', ' |
@@ -1495,8 +1588,9 @@ discard block |
||
| 1495 | 1588 | $themeData = array(); |
| 1496 | 1589 | foreach ($values as $variable => $value) |
| 1497 | 1590 | { |
| 1498 | - if (!isset($value) || $value === null) |
|
| 1499 | - $value = 0; |
|
| 1591 | + if (!isset($value) || $value === null) { |
|
| 1592 | + $value = 0; |
|
| 1593 | + } |
|
| 1500 | 1594 | |
| 1501 | 1595 | $themeData[] = array(0, 1, $variable, $value); |
| 1502 | 1596 | } |
@@ -1525,8 +1619,9 @@ discard block |
||
| 1525 | 1619 | |
| 1526 | 1620 | foreach ($values as $variable => $value) |
| 1527 | 1621 | { |
| 1528 | - if (empty($modSettings[$value[0]])) |
|
| 1529 | - continue; |
|
| 1622 | + if (empty($modSettings[$value[0]])) { |
|
| 1623 | + continue; |
|
| 1624 | + } |
|
| 1530 | 1625 | |
| 1531 | 1626 | $smcFunc['db_query']('', ' |
| 1532 | 1627 | INSERT IGNORE INTO {db_prefix}themes |
@@ -1612,10 +1707,11 @@ discard block |
||
| 1612 | 1707 | set_error_handler( |
| 1613 | 1708 | function ($errno, $errstr, $errfile, $errline) use ($support_js) |
| 1614 | 1709 | { |
| 1615 | - if ($support_js) |
|
| 1616 | - return true; |
|
| 1617 | - else |
|
| 1618 | - echo 'Error: ' . $errstr . ' File: ' . $errfile . ' Line: ' . $errline; |
|
| 1710 | + if ($support_js) { |
|
| 1711 | + return true; |
|
| 1712 | + } else { |
|
| 1713 | + echo 'Error: ' . $errstr . ' File: ' . $errfile . ' Line: ' . $errline; |
|
| 1714 | + } |
|
| 1619 | 1715 | } |
| 1620 | 1716 | ); |
| 1621 | 1717 | |
@@ -1630,8 +1726,9 @@ discard block |
||
| 1630 | 1726 | 'db_error_skip' => true, |
| 1631 | 1727 | ) |
| 1632 | 1728 | ); |
| 1633 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
| 1634 | - die('Unable to find members table!'); |
|
| 1729 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
| 1730 | + die('Unable to find members table!'); |
|
| 1731 | + } |
|
| 1635 | 1732 | $table_status = $smcFunc['db_fetch_assoc']($request); |
| 1636 | 1733 | $smcFunc['db_free_result']($request); |
| 1637 | 1734 | |
@@ -1646,17 +1743,20 @@ discard block |
||
| 1646 | 1743 | ) |
| 1647 | 1744 | ); |
| 1648 | 1745 | // Got something? |
| 1649 | - if ($smcFunc['db_num_rows']($request) !== 0) |
|
| 1650 | - $collation_info = $smcFunc['db_fetch_assoc']($request); |
|
| 1746 | + if ($smcFunc['db_num_rows']($request) !== 0) { |
|
| 1747 | + $collation_info = $smcFunc['db_fetch_assoc']($request); |
|
| 1748 | + } |
|
| 1651 | 1749 | $smcFunc['db_free_result']($request); |
| 1652 | 1750 | |
| 1653 | 1751 | // Excellent! |
| 1654 | - if (!empty($collation_info['Collation']) && !empty($collation_info['Charset'])) |
|
| 1655 | - $db_collation = ' CHARACTER SET ' . $collation_info['Charset'] . ' COLLATE ' . $collation_info['Collation']; |
|
| 1752 | + if (!empty($collation_info['Collation']) && !empty($collation_info['Charset'])) { |
|
| 1753 | + $db_collation = ' CHARACTER SET ' . $collation_info['Charset'] . ' COLLATE ' . $collation_info['Collation']; |
|
| 1754 | + } |
|
| 1656 | 1755 | } |
| 1657 | 1756 | } |
| 1658 | - if (empty($db_collation)) |
|
| 1659 | - $db_collation = ''; |
|
| 1757 | + if (empty($db_collation)) { |
|
| 1758 | + $db_collation = ''; |
|
| 1759 | + } |
|
| 1660 | 1760 | |
| 1661 | 1761 | $endl = $command_line ? "\n" : '<br>' . "\n"; |
| 1662 | 1762 | |
@@ -1668,8 +1768,9 @@ discard block |
||
| 1668 | 1768 | $last_step = ''; |
| 1669 | 1769 | |
| 1670 | 1770 | // Make sure all newly created tables will have the proper characters set. |
| 1671 | - if (isset($db_character_set) && $db_character_set === 'utf8') |
|
| 1672 | - $lines = str_replace(') ENGINE=MyISAM;', ') ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci;', $lines); |
|
| 1771 | + if (isset($db_character_set) && $db_character_set === 'utf8') { |
|
| 1772 | + $lines = str_replace(') ENGINE=MyISAM;', ') ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci;', $lines); |
|
| 1773 | + } |
|
| 1673 | 1774 | |
| 1674 | 1775 | // Count the total number of steps within this file - for progress. |
| 1675 | 1776 | $file_steps = substr_count(implode('', $lines), '---#'); |
@@ -1689,15 +1790,18 @@ discard block |
||
| 1689 | 1790 | $do_current = $substep >= $_GET['substep']; |
| 1690 | 1791 | |
| 1691 | 1792 | // Get rid of any comments in the beginning of the line... |
| 1692 | - if (substr(trim($line), 0, 2) === '/*') |
|
| 1693 | - $line = preg_replace('~/\*.+?\*/~', '', $line); |
|
| 1793 | + if (substr(trim($line), 0, 2) === '/*') { |
|
| 1794 | + $line = preg_replace('~/\*.+?\*/~', '', $line); |
|
| 1795 | + } |
|
| 1694 | 1796 | |
| 1695 | 1797 | // Always flush. Flush, flush, flush. Flush, flush, flush, flush! FLUSH! |
| 1696 | - if ($is_debug && !$support_js && $command_line) |
|
| 1697 | - flush(); |
|
| 1798 | + if ($is_debug && !$support_js && $command_line) { |
|
| 1799 | + flush(); |
|
| 1800 | + } |
|
| 1698 | 1801 | |
| 1699 | - if (trim($line) === '') |
|
| 1700 | - continue; |
|
| 1802 | + if (trim($line) === '') { |
|
| 1803 | + continue; |
|
| 1804 | + } |
|
| 1701 | 1805 | |
| 1702 | 1806 | if (trim(substr($line, 0, 3)) === '---') |
| 1703 | 1807 | { |
@@ -1707,8 +1811,9 @@ discard block |
||
| 1707 | 1811 | if (trim($current_data) != '' && $type !== '}') |
| 1708 | 1812 | { |
| 1709 | 1813 | $upcontext['error_message'] = 'Error in upgrade script - line ' . $line_number . '!' . $endl; |
| 1710 | - if ($command_line) |
|
| 1711 | - echo $upcontext['error_message']; |
|
| 1814 | + if ($command_line) { |
|
| 1815 | + echo $upcontext['error_message']; |
|
| 1816 | + } |
|
| 1712 | 1817 | } |
| 1713 | 1818 | |
| 1714 | 1819 | if ($type == ' ') |
@@ -1726,17 +1831,18 @@ discard block |
||
| 1726 | 1831 | if ($do_current) |
| 1727 | 1832 | { |
| 1728 | 1833 | $upcontext['actioned_items'][] = $last_step; |
| 1729 | - if ($command_line) |
|
| 1730 | - echo ' * '; |
|
| 1834 | + if ($command_line) { |
|
| 1835 | + echo ' * '; |
|
| 1836 | + } |
|
| 1731 | 1837 | } |
| 1732 | - } |
|
| 1733 | - elseif ($type == '#') |
|
| 1838 | + } elseif ($type == '#') |
|
| 1734 | 1839 | { |
| 1735 | 1840 | $upcontext['step_progress'] += (100 / $upcontext['file_count']) / $file_steps; |
| 1736 | 1841 | |
| 1737 | 1842 | $upcontext['current_debug_item_num']++; |
| 1738 | - if (trim($line) != '---#') |
|
| 1739 | - $upcontext['current_debug_item_name'] = htmlspecialchars(rtrim(substr($line, 4))); |
|
| 1843 | + if (trim($line) != '---#') { |
|
| 1844 | + $upcontext['current_debug_item_name'] = htmlspecialchars(rtrim(substr($line, 4))); |
|
| 1845 | + } |
|
| 1740 | 1846 | |
| 1741 | 1847 | // Have we already done something? |
| 1742 | 1848 | if (isset($_GET['xml']) && $done_something) |
@@ -1747,34 +1853,36 @@ discard block |
||
| 1747 | 1853 | |
| 1748 | 1854 | if ($do_current) |
| 1749 | 1855 | { |
| 1750 | - if (trim($line) == '---#' && $command_line) |
|
| 1751 | - echo ' done.', $endl; |
|
| 1752 | - elseif ($command_line) |
|
| 1753 | - echo ' +++ ', rtrim(substr($line, 4)); |
|
| 1754 | - elseif (trim($line) != '---#') |
|
| 1856 | + if (trim($line) == '---#' && $command_line) { |
|
| 1857 | + echo ' done.', $endl; |
|
| 1858 | + } elseif ($command_line) { |
|
| 1859 | + echo ' +++ ', rtrim(substr($line, 4)); |
|
| 1860 | + } elseif (trim($line) != '---#') |
|
| 1755 | 1861 | { |
| 1756 | - if ($is_debug) |
|
| 1757 | - $upcontext['actioned_items'][] = htmlspecialchars(rtrim(substr($line, 4))); |
|
| 1862 | + if ($is_debug) { |
|
| 1863 | + $upcontext['actioned_items'][] = htmlspecialchars(rtrim(substr($line, 4))); |
|
| 1864 | + } |
|
| 1758 | 1865 | } |
| 1759 | 1866 | } |
| 1760 | 1867 | |
| 1761 | 1868 | if ($substep < $_GET['substep'] && $substep + 1 >= $_GET['substep']) |
| 1762 | 1869 | { |
| 1763 | - if ($command_line) |
|
| 1764 | - echo ' * '; |
|
| 1765 | - else |
|
| 1766 | - $upcontext['actioned_items'][] = $last_step; |
|
| 1870 | + if ($command_line) { |
|
| 1871 | + echo ' * '; |
|
| 1872 | + } else { |
|
| 1873 | + $upcontext['actioned_items'][] = $last_step; |
|
| 1874 | + } |
|
| 1767 | 1875 | } |
| 1768 | 1876 | |
| 1769 | 1877 | // Small step - only if we're actually doing stuff. |
| 1770 | - if ($do_current) |
|
| 1771 | - nextSubstep(++$substep); |
|
| 1772 | - else |
|
| 1773 | - $substep++; |
|
| 1774 | - } |
|
| 1775 | - elseif ($type == '{') |
|
| 1776 | - $current_type = 'code'; |
|
| 1777 | - elseif ($type == '}') |
|
| 1878 | + if ($do_current) { |
|
| 1879 | + nextSubstep(++$substep); |
|
| 1880 | + } else { |
|
| 1881 | + $substep++; |
|
| 1882 | + } |
|
| 1883 | + } elseif ($type == '{') { |
|
| 1884 | + $current_type = 'code'; |
|
| 1885 | + } elseif ($type == '}') |
|
| 1778 | 1886 | { |
| 1779 | 1887 | $current_type = 'sql'; |
| 1780 | 1888 | |
@@ -1787,8 +1895,9 @@ discard block |
||
| 1787 | 1895 | if (eval('global $db_prefix, $modSettings, $smcFunc; ' . $current_data) === false) |
| 1788 | 1896 | { |
| 1789 | 1897 | $upcontext['error_message'] = 'Error in upgrade script ' . basename($filename) . ' on line ' . $line_number . '!' . $endl; |
| 1790 | - if ($command_line) |
|
| 1791 | - echo $upcontext['error_message']; |
|
| 1898 | + if ($command_line) { |
|
| 1899 | + echo $upcontext['error_message']; |
|
| 1900 | + } |
|
| 1792 | 1901 | } |
| 1793 | 1902 | |
| 1794 | 1903 | // Done with code! |
@@ -1868,8 +1977,9 @@ discard block |
||
| 1868 | 1977 | $db_unbuffered = false; |
| 1869 | 1978 | |
| 1870 | 1979 | // Failure?! |
| 1871 | - if ($result !== false) |
|
| 1872 | - return $result; |
|
| 1980 | + if ($result !== false) { |
|
| 1981 | + return $result; |
|
| 1982 | + } |
|
| 1873 | 1983 | |
| 1874 | 1984 | $db_error_message = $smcFunc['db_error']($db_connection); |
| 1875 | 1985 | // If MySQL we do something more clever. |
@@ -1897,54 +2007,61 @@ discard block |
||
| 1897 | 2007 | { |
| 1898 | 2008 | mysqli_query($db_connection, 'REPAIR TABLE `' . $match[1] . '`'); |
| 1899 | 2009 | $result = mysqli_query($db_connection, $string); |
| 1900 | - if ($result !== false) |
|
| 1901 | - return $result; |
|
| 2010 | + if ($result !== false) { |
|
| 2011 | + return $result; |
|
| 2012 | + } |
|
| 1902 | 2013 | } |
| 1903 | - } |
|
| 1904 | - elseif ($mysqli_errno == 2013) |
|
| 2014 | + } elseif ($mysqli_errno == 2013) |
|
| 1905 | 2015 | { |
| 1906 | 2016 | $db_connection = mysqli_connect($db_server, $db_user, $db_passwd); |
| 1907 | 2017 | mysqli_select_db($db_connection, $db_name); |
| 1908 | 2018 | if ($db_connection) |
| 1909 | 2019 | { |
| 1910 | 2020 | $result = mysqli_query($db_connection, $string); |
| 1911 | - if ($result !== false) |
|
| 1912 | - return $result; |
|
| 2021 | + if ($result !== false) { |
|
| 2022 | + return $result; |
|
| 2023 | + } |
|
| 1913 | 2024 | } |
| 1914 | 2025 | } |
| 1915 | 2026 | // Duplicate column name... should be okay ;). |
| 1916 | - elseif (in_array($mysqli_errno, array(1060, 1061, 1068, 1091))) |
|
| 1917 | - return false; |
|
| 2027 | + elseif (in_array($mysqli_errno, array(1060, 1061, 1068, 1091))) { |
|
| 2028 | + return false; |
|
| 2029 | + } |
|
| 1918 | 2030 | // Duplicate insert... make sure it's the proper type of query ;). |
| 1919 | - elseif (in_array($mysqli_errno, array(1054, 1062, 1146)) && $error_query) |
|
| 1920 | - return false; |
|
| 2031 | + elseif (in_array($mysqli_errno, array(1054, 1062, 1146)) && $error_query) { |
|
| 2032 | + return false; |
|
| 2033 | + } |
|
| 1921 | 2034 | // Creating an index on a non-existent column. |
| 1922 | - elseif ($mysqli_errno == 1072) |
|
| 1923 | - return false; |
|
| 1924 | - elseif ($mysqli_errno == 1050 && substr(trim($string), 0, 12) == 'RENAME TABLE') |
|
| 1925 | - return false; |
|
| 2035 | + elseif ($mysqli_errno == 1072) { |
|
| 2036 | + return false; |
|
| 2037 | + } elseif ($mysqli_errno == 1050 && substr(trim($string), 0, 12) == 'RENAME TABLE') { |
|
| 2038 | + return false; |
|
| 2039 | + } |
|
| 1926 | 2040 | } |
| 1927 | 2041 | // If a table already exists don't go potty. |
| 1928 | 2042 | else |
| 1929 | 2043 | { |
| 1930 | 2044 | if (in_array(substr(trim($string), 0, 8), array('CREATE T', 'CREATE S', 'DROP TABL', 'ALTER TA', 'CREATE I', 'CREATE U'))) |
| 1931 | 2045 | { |
| 1932 | - if (strpos($db_error_message, 'exist') !== false) |
|
| 1933 | - return true; |
|
| 1934 | - } |
|
| 1935 | - elseif (strpos(trim($string), 'INSERT ') !== false) |
|
| 2046 | + if (strpos($db_error_message, 'exist') !== false) { |
|
| 2047 | + return true; |
|
| 2048 | + } |
|
| 2049 | + } elseif (strpos(trim($string), 'INSERT ') !== false) |
|
| 1936 | 2050 | { |
| 1937 | - if (strpos($db_error_message, 'duplicate') !== false) |
|
| 1938 | - return true; |
|
| 2051 | + if (strpos($db_error_message, 'duplicate') !== false) { |
|
| 2052 | + return true; |
|
| 2053 | + } |
|
| 1939 | 2054 | } |
| 1940 | 2055 | } |
| 1941 | 2056 | |
| 1942 | 2057 | // Get the query string so we pass everything. |
| 1943 | 2058 | $query_string = ''; |
| 1944 | - foreach ($_GET as $k => $v) |
|
| 1945 | - $query_string .= ';' . $k . '=' . $v; |
|
| 1946 | - if (strlen($query_string) != 0) |
|
| 1947 | - $query_string = '?' . substr($query_string, 1); |
|
| 2059 | + foreach ($_GET as $k => $v) { |
|
| 2060 | + $query_string .= ';' . $k . '=' . $v; |
|
| 2061 | + } |
|
| 2062 | + if (strlen($query_string) != 0) { |
|
| 2063 | + $query_string = '?' . substr($query_string, 1); |
|
| 2064 | + } |
|
| 1948 | 2065 | |
| 1949 | 2066 | if ($command_line) |
| 1950 | 2067 | { |
@@ -1999,16 +2116,18 @@ discard block |
||
| 1999 | 2116 | { |
| 2000 | 2117 | $found |= 1; |
| 2001 | 2118 | // Do some checks on the data if we have it set. |
| 2002 | - if (isset($change['col_type'])) |
|
| 2003 | - $found &= $change['col_type'] === $column['type']; |
|
| 2004 | - if (isset($change['null_allowed'])) |
|
| 2005 | - $found &= $column['null'] == $change['null_allowed']; |
|
| 2006 | - if (isset($change['default'])) |
|
| 2007 | - $found &= $change['default'] === $column['default']; |
|
| 2119 | + if (isset($change['col_type'])) { |
|
| 2120 | + $found &= $change['col_type'] === $column['type']; |
|
| 2121 | + } |
|
| 2122 | + if (isset($change['null_allowed'])) { |
|
| 2123 | + $found &= $column['null'] == $change['null_allowed']; |
|
| 2124 | + } |
|
| 2125 | + if (isset($change['default'])) { |
|
| 2126 | + $found &= $change['default'] === $column['default']; |
|
| 2127 | + } |
|
| 2008 | 2128 | } |
| 2009 | 2129 | } |
| 2010 | - } |
|
| 2011 | - elseif ($change['type'] === 'index') |
|
| 2130 | + } elseif ($change['type'] === 'index') |
|
| 2012 | 2131 | { |
| 2013 | 2132 | $request = upgrade_query(' |
| 2014 | 2133 | SHOW INDEX |
@@ -2017,9 +2136,10 @@ discard block |
||
| 2017 | 2136 | { |
| 2018 | 2137 | $cur_index = array(); |
| 2019 | 2138 | |
| 2020 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 2021 | - if ($row['Key_name'] === $change['name']) |
|
| 2139 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2140 | + if ($row['Key_name'] === $change['name']) |
|
| 2022 | 2141 | $cur_index[(int) $row['Seq_in_index']] = $row['Column_name']; |
| 2142 | + } |
|
| 2023 | 2143 | |
| 2024 | 2144 | ksort($cur_index, SORT_NUMERIC); |
| 2025 | 2145 | $found = array_values($cur_index) === $change['target_columns']; |
@@ -2029,14 +2149,17 @@ discard block |
||
| 2029 | 2149 | } |
| 2030 | 2150 | |
| 2031 | 2151 | // If we're trying to add and it's added, we're done. |
| 2032 | - if ($found && in_array($change['method'], array('add', 'change'))) |
|
| 2033 | - return true; |
|
| 2152 | + if ($found && in_array($change['method'], array('add', 'change'))) { |
|
| 2153 | + return true; |
|
| 2154 | + } |
|
| 2034 | 2155 | // Otherwise if we're removing and it wasn't found we're also done. |
| 2035 | - elseif (!$found && in_array($change['method'], array('remove', 'change_remove'))) |
|
| 2036 | - return true; |
|
| 2156 | + elseif (!$found && in_array($change['method'], array('remove', 'change_remove'))) { |
|
| 2157 | + return true; |
|
| 2158 | + } |
|
| 2037 | 2159 | // Otherwise is it just a test? |
| 2038 | - elseif ($is_test) |
|
| 2039 | - return false; |
|
| 2160 | + elseif ($is_test) { |
|
| 2161 | + return false; |
|
| 2162 | + } |
|
| 2040 | 2163 | |
| 2041 | 2164 | // Not found it yet? Bummer! How about we see if we're currently doing it? |
| 2042 | 2165 | $running = false; |
@@ -2047,8 +2170,9 @@ discard block |
||
| 2047 | 2170 | SHOW FULL PROCESSLIST'); |
| 2048 | 2171 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 2049 | 2172 | { |
| 2050 | - if (strpos($row['Info'], 'ALTER TABLE ' . $db_prefix . $change['table']) !== false && strpos($row['Info'], $change['text']) !== false) |
|
| 2051 | - $found = true; |
|
| 2173 | + if (strpos($row['Info'], 'ALTER TABLE ' . $db_prefix . $change['table']) !== false && strpos($row['Info'], $change['text']) !== false) { |
|
| 2174 | + $found = true; |
|
| 2175 | + } |
|
| 2052 | 2176 | } |
| 2053 | 2177 | |
| 2054 | 2178 | // Can't find it? Then we need to run it fools! |
@@ -2060,8 +2184,9 @@ discard block |
||
| 2060 | 2184 | ALTER TABLE ' . $db_prefix . $change['table'] . ' |
| 2061 | 2185 | ' . $change['text'], true) !== false; |
| 2062 | 2186 | |
| 2063 | - if (!$success) |
|
| 2064 | - return false; |
|
| 2187 | + if (!$success) { |
|
| 2188 | + return false; |
|
| 2189 | + } |
|
| 2065 | 2190 | |
| 2066 | 2191 | // Return |
| 2067 | 2192 | $running = true; |
@@ -2103,8 +2228,9 @@ discard block |
||
| 2103 | 2228 | 'db_error_skip' => true, |
| 2104 | 2229 | ) |
| 2105 | 2230 | ); |
| 2106 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
| 2107 | - die('Unable to find column ' . $change['column'] . ' inside table ' . $db_prefix . $change['table']); |
|
| 2231 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
| 2232 | + die('Unable to find column ' . $change['column'] . ' inside table ' . $db_prefix . $change['table']); |
|
| 2233 | + } |
|
| 2108 | 2234 | $table_row = $smcFunc['db_fetch_assoc']($request); |
| 2109 | 2235 | $smcFunc['db_free_result']($request); |
| 2110 | 2236 | |
@@ -2126,18 +2252,19 @@ discard block |
||
| 2126 | 2252 | ) |
| 2127 | 2253 | ); |
| 2128 | 2254 | // No results? Just forget it all together. |
| 2129 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
| 2130 | - unset($table_row['Collation']); |
|
| 2131 | - else |
|
| 2132 | - $collation_info = $smcFunc['db_fetch_assoc']($request); |
|
| 2255 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
| 2256 | + unset($table_row['Collation']); |
|
| 2257 | + } else { |
|
| 2258 | + $collation_info = $smcFunc['db_fetch_assoc']($request); |
|
| 2259 | + } |
|
| 2133 | 2260 | $smcFunc['db_free_result']($request); |
| 2134 | 2261 | } |
| 2135 | 2262 | |
| 2136 | 2263 | if ($column_fix) |
| 2137 | 2264 | { |
| 2138 | 2265 | // Make sure there are no NULL's left. |
| 2139 | - if ($null_fix) |
|
| 2140 | - $smcFunc['db_query']('', ' |
|
| 2266 | + if ($null_fix) { |
|
| 2267 | + $smcFunc['db_query']('', ' |
|
| 2141 | 2268 | UPDATE {db_prefix}' . $change['table'] . ' |
| 2142 | 2269 | SET ' . $change['column'] . ' = {string:default} |
| 2143 | 2270 | WHERE ' . $change['column'] . ' IS NULL', |
@@ -2146,6 +2273,7 @@ discard block |
||
| 2146 | 2273 | 'db_error_skip' => true, |
| 2147 | 2274 | ) |
| 2148 | 2275 | ); |
| 2276 | + } |
|
| 2149 | 2277 | |
| 2150 | 2278 | // Do the actual alteration. |
| 2151 | 2279 | $smcFunc['db_query']('', ' |
@@ -2174,8 +2302,9 @@ discard block |
||
| 2174 | 2302 | } |
| 2175 | 2303 | |
| 2176 | 2304 | // Not a column we need to check on? |
| 2177 | - if (!in_array($change['name'], array('memberGroups', 'passwordSalt'))) |
|
| 2178 | - return; |
|
| 2305 | + if (!in_array($change['name'], array('memberGroups', 'passwordSalt'))) { |
|
| 2306 | + return; |
|
| 2307 | + } |
|
| 2179 | 2308 | |
| 2180 | 2309 | // Break it up you (six|seven). |
| 2181 | 2310 | $temp = explode(' ', str_replace('NOT NULL', 'NOT_NULL', $change['text'])); |
@@ -2194,13 +2323,13 @@ discard block |
||
| 2194 | 2323 | 'new_name' => $temp[2], |
| 2195 | 2324 | )); |
| 2196 | 2325 | // !!! This doesn't technically work because we don't pass request into it, but it hasn't broke anything yet. |
| 2197 | - if ($smcFunc['db_num_rows'] != 1) |
|
| 2198 | - return; |
|
| 2326 | + if ($smcFunc['db_num_rows'] != 1) { |
|
| 2327 | + return; |
|
| 2328 | + } |
|
| 2199 | 2329 | |
| 2200 | 2330 | list (, $current_type) = $smcFunc['db_fetch_assoc']($request); |
| 2201 | 2331 | $smcFunc['db_free_result']($request); |
| 2202 | - } |
|
| 2203 | - else |
|
| 2332 | + } else |
|
| 2204 | 2333 | { |
| 2205 | 2334 | // Do this the old fashion, sure method way. |
| 2206 | 2335 | $request = $smcFunc['db_query']('', ' |
@@ -2211,21 +2340,24 @@ discard block |
||
| 2211 | 2340 | )); |
| 2212 | 2341 | // Mayday! |
| 2213 | 2342 | // !!! This doesn't technically work because we don't pass request into it, but it hasn't broke anything yet. |
| 2214 | - if ($smcFunc['db_num_rows'] == 0) |
|
| 2215 | - return; |
|
| 2343 | + if ($smcFunc['db_num_rows'] == 0) { |
|
| 2344 | + return; |
|
| 2345 | + } |
|
| 2216 | 2346 | |
| 2217 | 2347 | // Oh where, oh where has my little field gone. Oh where can it be... |
| 2218 | - while ($row = $smcFunc['db_query']($request)) |
|
| 2219 | - if ($row['Field'] == $temp[1] || $row['Field'] == $temp[2]) |
|
| 2348 | + while ($row = $smcFunc['db_query']($request)) { |
|
| 2349 | + if ($row['Field'] == $temp[1] || $row['Field'] == $temp[2]) |
|
| 2220 | 2350 | { |
| 2221 | 2351 | $current_type = $row['Type']; |
| 2352 | + } |
|
| 2222 | 2353 | break; |
| 2223 | 2354 | } |
| 2224 | 2355 | } |
| 2225 | 2356 | |
| 2226 | 2357 | // If this doesn't match, the column may of been altered for a reason. |
| 2227 | - if (trim($current_type) != trim($temp[3])) |
|
| 2228 | - $temp[3] = $current_type; |
|
| 2358 | + if (trim($current_type) != trim($temp[3])) { |
|
| 2359 | + $temp[3] = $current_type; |
|
| 2360 | + } |
|
| 2229 | 2361 | |
| 2230 | 2362 | // Piece this back together. |
| 2231 | 2363 | $change['text'] = str_replace('NOT_NULL', 'NOT NULL', implode(' ', $temp)); |
@@ -2237,8 +2369,9 @@ discard block |
||
| 2237 | 2369 | global $start_time, $timeLimitThreshold, $command_line, $custom_warning; |
| 2238 | 2370 | global $step_progress, $is_debug, $upcontext; |
| 2239 | 2371 | |
| 2240 | - if ($_GET['substep'] < $substep) |
|
| 2241 | - $_GET['substep'] = $substep; |
|
| 2372 | + if ($_GET['substep'] < $substep) { |
|
| 2373 | + $_GET['substep'] = $substep; |
|
| 2374 | + } |
|
| 2242 | 2375 | |
| 2243 | 2376 | if ($command_line) |
| 2244 | 2377 | { |
@@ -2251,29 +2384,33 @@ discard block |
||
| 2251 | 2384 | } |
| 2252 | 2385 | |
| 2253 | 2386 | @set_time_limit(300); |
| 2254 | - if (function_exists('apache_reset_timeout')) |
|
| 2255 | - @apache_reset_timeout(); |
|
| 2387 | + if (function_exists('apache_reset_timeout')) { |
|
| 2388 | + @apache_reset_timeout(); |
|
| 2389 | + } |
|
| 2256 | 2390 | |
| 2257 | - if (time() - $start_time <= $timeLimitThreshold) |
|
| 2258 | - return; |
|
| 2391 | + if (time() - $start_time <= $timeLimitThreshold) { |
|
| 2392 | + return; |
|
| 2393 | + } |
|
| 2259 | 2394 | |
| 2260 | 2395 | // Do we have some custom step progress stuff? |
| 2261 | 2396 | if (!empty($step_progress)) |
| 2262 | 2397 | { |
| 2263 | 2398 | $upcontext['substep_progress'] = 0; |
| 2264 | 2399 | $upcontext['substep_progress_name'] = $step_progress['name']; |
| 2265 | - if ($step_progress['current'] > $step_progress['total']) |
|
| 2266 | - $upcontext['substep_progress'] = 99.9; |
|
| 2267 | - else |
|
| 2268 | - $upcontext['substep_progress'] = ($step_progress['current'] / $step_progress['total']) * 100; |
|
| 2400 | + if ($step_progress['current'] > $step_progress['total']) { |
|
| 2401 | + $upcontext['substep_progress'] = 99.9; |
|
| 2402 | + } else { |
|
| 2403 | + $upcontext['substep_progress'] = ($step_progress['current'] / $step_progress['total']) * 100; |
|
| 2404 | + } |
|
| 2269 | 2405 | |
| 2270 | 2406 | // Make it nicely rounded. |
| 2271 | 2407 | $upcontext['substep_progress'] = round($upcontext['substep_progress'], 1); |
| 2272 | 2408 | } |
| 2273 | 2409 | |
| 2274 | 2410 | // If this is XML we just exit right away! |
| 2275 | - if (isset($_GET['xml'])) |
|
| 2276 | - return upgradeExit(); |
|
| 2411 | + if (isset($_GET['xml'])) { |
|
| 2412 | + return upgradeExit(); |
|
| 2413 | + } |
|
| 2277 | 2414 | |
| 2278 | 2415 | // We're going to pause after this! |
| 2279 | 2416 | $upcontext['pause'] = true; |
@@ -2281,13 +2418,15 @@ discard block |
||
| 2281 | 2418 | $upcontext['query_string'] = ''; |
| 2282 | 2419 | foreach ($_GET as $k => $v) |
| 2283 | 2420 | { |
| 2284 | - if ($k != 'data' && $k != 'substep' && $k != 'step') |
|
| 2285 | - $upcontext['query_string'] .= ';' . $k . '=' . $v; |
|
| 2421 | + if ($k != 'data' && $k != 'substep' && $k != 'step') { |
|
| 2422 | + $upcontext['query_string'] .= ';' . $k . '=' . $v; |
|
| 2423 | + } |
|
| 2286 | 2424 | } |
| 2287 | 2425 | |
| 2288 | 2426 | // Custom warning? |
| 2289 | - if (!empty($custom_warning)) |
|
| 2290 | - $upcontext['custom_warning'] = $custom_warning; |
|
| 2427 | + if (!empty($custom_warning)) { |
|
| 2428 | + $upcontext['custom_warning'] = $custom_warning; |
|
| 2429 | + } |
|
| 2291 | 2430 | |
| 2292 | 2431 | upgradeExit(); |
| 2293 | 2432 | } |
@@ -2302,25 +2441,26 @@ discard block |
||
| 2302 | 2441 | ob_implicit_flush(true); |
| 2303 | 2442 | @set_time_limit(600); |
| 2304 | 2443 | |
| 2305 | - if (!isset($_SERVER['argv'])) |
|
| 2306 | - $_SERVER['argv'] = array(); |
|
| 2444 | + if (!isset($_SERVER['argv'])) { |
|
| 2445 | + $_SERVER['argv'] = array(); |
|
| 2446 | + } |
|
| 2307 | 2447 | $_GET['maint'] = 1; |
| 2308 | 2448 | |
| 2309 | 2449 | foreach ($_SERVER['argv'] as $i => $arg) |
| 2310 | 2450 | { |
| 2311 | - if (preg_match('~^--language=(.+)$~', $arg, $match) != 0) |
|
| 2312 | - $_GET['lang'] = $match[1]; |
|
| 2313 | - elseif (preg_match('~^--path=(.+)$~', $arg) != 0) |
|
| 2314 | - continue; |
|
| 2315 | - elseif ($arg == '--no-maintenance') |
|
| 2316 | - $_GET['maint'] = 0; |
|
| 2317 | - elseif ($arg == '--debug') |
|
| 2318 | - $is_debug = true; |
|
| 2319 | - elseif ($arg == '--backup') |
|
| 2320 | - $_POST['backup'] = 1; |
|
| 2321 | - elseif ($arg == '--template' && (file_exists($boarddir . '/template.php') || file_exists($boarddir . '/template.html') && !file_exists($modSettings['theme_dir'] . '/converted'))) |
|
| 2322 | - $_GET['conv'] = 1; |
|
| 2323 | - elseif ($i != 0) |
|
| 2451 | + if (preg_match('~^--language=(.+)$~', $arg, $match) != 0) { |
|
| 2452 | + $_GET['lang'] = $match[1]; |
|
| 2453 | + } elseif (preg_match('~^--path=(.+)$~', $arg) != 0) { |
|
| 2454 | + continue; |
|
| 2455 | + } elseif ($arg == '--no-maintenance') { |
|
| 2456 | + $_GET['maint'] = 0; |
|
| 2457 | + } elseif ($arg == '--debug') { |
|
| 2458 | + $is_debug = true; |
|
| 2459 | + } elseif ($arg == '--backup') { |
|
| 2460 | + $_POST['backup'] = 1; |
|
| 2461 | + } elseif ($arg == '--template' && (file_exists($boarddir . '/template.php') || file_exists($boarddir . '/template.html') && !file_exists($modSettings['theme_dir'] . '/converted'))) { |
|
| 2462 | + $_GET['conv'] = 1; |
|
| 2463 | + } elseif ($i != 0) |
|
| 2324 | 2464 | { |
| 2325 | 2465 | echo 'SMF Command-line Upgrader |
| 2326 | 2466 | Usage: /path/to/php -f ' . basename(__FILE__) . ' -- [OPTION]... |
@@ -2334,10 +2474,12 @@ discard block |
||
| 2334 | 2474 | } |
| 2335 | 2475 | } |
| 2336 | 2476 | |
| 2337 | - if (!php_version_check()) |
|
| 2338 | - print_error('Error: PHP ' . PHP_VERSION . ' does not match version requirements.', true); |
|
| 2339 | - if (!db_version_check()) |
|
| 2340 | - print_error('Error: ' . $databases[$db_type]['name'] . ' ' . $databases[$db_type]['version'] . ' does not match minimum requirements.', true); |
|
| 2477 | + if (!php_version_check()) { |
|
| 2478 | + print_error('Error: PHP ' . PHP_VERSION . ' does not match version requirements.', true); |
|
| 2479 | + } |
|
| 2480 | + if (!db_version_check()) { |
|
| 2481 | + print_error('Error: ' . $databases[$db_type]['name'] . ' ' . $databases[$db_type]['version'] . ' does not match minimum requirements.', true); |
|
| 2482 | + } |
|
| 2341 | 2483 | |
| 2342 | 2484 | // Do some checks to make sure they have proper privileges |
| 2343 | 2485 | db_extend('packages'); |
@@ -2352,34 +2494,39 @@ discard block |
||
| 2352 | 2494 | $drop = $smcFunc['db_drop_table']('{db_prefix}priv_check'); |
| 2353 | 2495 | |
| 2354 | 2496 | // Sorry... we need CREATE, ALTER and DROP |
| 2355 | - if (!$create || !$alter || !$drop) |
|
| 2356 | - print_error("The " . $databases[$db_type]['name'] . " user you have set in Settings.php does not have proper privileges.\n\nPlease ask your host to give this user the ALTER, CREATE, and DROP privileges.", true); |
|
| 2497 | + if (!$create || !$alter || !$drop) { |
|
| 2498 | + print_error("The " . $databases[$db_type]['name'] . " user you have set in Settings.php does not have proper privileges.\n\nPlease ask your host to give this user the ALTER, CREATE, and DROP privileges.", true); |
|
| 2499 | + } |
|
| 2357 | 2500 | |
| 2358 | 2501 | $check = @file_exists($modSettings['theme_dir'] . '/index.template.php') |
| 2359 | 2502 | && @file_exists($sourcedir . '/QueryString.php') |
| 2360 | 2503 | && @file_exists($sourcedir . '/ManageBoards.php'); |
| 2361 | - if (!$check && !isset($modSettings['smfVersion'])) |
|
| 2362 | - print_error('Error: Some files are missing or out-of-date.', true); |
|
| 2504 | + if (!$check && !isset($modSettings['smfVersion'])) { |
|
| 2505 | + print_error('Error: Some files are missing or out-of-date.', true); |
|
| 2506 | + } |
|
| 2363 | 2507 | |
| 2364 | 2508 | // Do a quick version spot check. |
| 2365 | 2509 | $temp = substr(@implode('', @file($boarddir . '/index.php')), 0, 4096); |
| 2366 | 2510 | preg_match('~\*\s@version\s+(.+)[\s]{2}~i', $temp, $match); |
| 2367 | - if (empty($match[1]) || (trim($match[1]) != SMF_VERSION)) |
|
| 2368 | - print_error('Error: Some files have not yet been updated properly.'); |
|
| 2511 | + if (empty($match[1]) || (trim($match[1]) != SMF_VERSION)) { |
|
| 2512 | + print_error('Error: Some files have not yet been updated properly.'); |
|
| 2513 | + } |
|
| 2369 | 2514 | |
| 2370 | 2515 | // Make sure Settings.php is writable. |
| 2371 | 2516 | quickFileWritable($boarddir . '/Settings.php'); |
| 2372 | - if (!is_writable($boarddir . '/Settings.php')) |
|
| 2373 | - print_error('Error: Unable to obtain write access to "Settings.php".', true); |
|
| 2517 | + if (!is_writable($boarddir . '/Settings.php')) { |
|
| 2518 | + print_error('Error: Unable to obtain write access to "Settings.php".', true); |
|
| 2519 | + } |
|
| 2374 | 2520 | |
| 2375 | 2521 | // Make sure Settings_bak.php is writable. |
| 2376 | 2522 | quickFileWritable($boarddir . '/Settings_bak.php'); |
| 2377 | - if (!is_writable($boarddir . '/Settings_bak.php')) |
|
| 2378 | - print_error('Error: Unable to obtain write access to "Settings_bak.php".'); |
|
| 2523 | + if (!is_writable($boarddir . '/Settings_bak.php')) { |
|
| 2524 | + print_error('Error: Unable to obtain write access to "Settings_bak.php".'); |
|
| 2525 | + } |
|
| 2379 | 2526 | |
| 2380 | - if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt')) |
|
| 2381 | - print_error('Error: Unable to obtain write access to "agreement.txt".'); |
|
| 2382 | - elseif (isset($modSettings['agreement'])) |
|
| 2527 | + if (isset($modSettings['agreement']) && (!is_writable($boarddir) || file_exists($boarddir . '/agreement.txt')) && !is_writable($boarddir . '/agreement.txt')) { |
|
| 2528 | + print_error('Error: Unable to obtain write access to "agreement.txt".'); |
|
| 2529 | + } elseif (isset($modSettings['agreement'])) |
|
| 2383 | 2530 | { |
| 2384 | 2531 | $fp = fopen($boarddir . '/agreement.txt', 'w'); |
| 2385 | 2532 | fwrite($fp, $modSettings['agreement']); |
@@ -2389,31 +2536,36 @@ discard block |
||
| 2389 | 2536 | // Make sure Themes is writable. |
| 2390 | 2537 | quickFileWritable($modSettings['theme_dir']); |
| 2391 | 2538 | |
| 2392 | - if (!is_writable($modSettings['theme_dir']) && !isset($modSettings['smfVersion'])) |
|
| 2393 | - print_error('Error: Unable to obtain write access to "Themes".'); |
|
| 2539 | + if (!is_writable($modSettings['theme_dir']) && !isset($modSettings['smfVersion'])) { |
|
| 2540 | + print_error('Error: Unable to obtain write access to "Themes".'); |
|
| 2541 | + } |
|
| 2394 | 2542 | |
| 2395 | 2543 | // Make sure cache directory exists and is writable! |
| 2396 | 2544 | $cachedir_temp = empty($cachedir) ? $boarddir . '/cache' : $cachedir; |
| 2397 | - if (!file_exists($cachedir_temp)) |
|
| 2398 | - @mkdir($cachedir_temp); |
|
| 2545 | + if (!file_exists($cachedir_temp)) { |
|
| 2546 | + @mkdir($cachedir_temp); |
|
| 2547 | + } |
|
| 2399 | 2548 | |
| 2400 | 2549 | // Make sure the cache temp dir is writable. |
| 2401 | 2550 | quickFileWritable($cachedir_temp); |
| 2402 | 2551 | |
| 2403 | - if (!is_writable($cachedir_temp)) |
|
| 2404 | - print_error('Error: Unable to obtain write access to "cache".', true); |
|
| 2552 | + if (!is_writable($cachedir_temp)) { |
|
| 2553 | + print_error('Error: Unable to obtain write access to "cache".', true); |
|
| 2554 | + } |
|
| 2405 | 2555 | |
| 2406 | - if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang'])) |
|
| 2407 | - print_error('Error: Unable to find language files!', true); |
|
| 2408 | - else |
|
| 2556 | + if (!file_exists($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php') && !isset($modSettings['smfVersion']) && !isset($_GET['lang'])) { |
|
| 2557 | + print_error('Error: Unable to find language files!', true); |
|
| 2558 | + } else |
|
| 2409 | 2559 | { |
| 2410 | 2560 | $temp = substr(@implode('', @file($modSettings['theme_dir'] . '/languages/index.' . $upcontext['language'] . '.php')), 0, 4096); |
| 2411 | 2561 | preg_match('~(?://|/\*)\s*Version:\s+(.+?);\s*index(?:[\s]{2}|\*/)~i', $temp, $match); |
| 2412 | 2562 | |
| 2413 | - if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) |
|
| 2414 | - print_error('Error: Language files out of date.', true); |
|
| 2415 | - if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) |
|
| 2416 | - print_error('Error: Install language is missing for selected language.', true); |
|
| 2563 | + if (empty($match[1]) || $match[1] != SMF_LANG_VERSION) { |
|
| 2564 | + print_error('Error: Language files out of date.', true); |
|
| 2565 | + } |
|
| 2566 | + if (!file_exists($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php')) { |
|
| 2567 | + print_error('Error: Install language is missing for selected language.', true); |
|
| 2568 | + } |
|
| 2417 | 2569 | |
| 2418 | 2570 | // Otherwise include it! |
| 2419 | 2571 | require_once($modSettings['theme_dir'] . '/languages/Install.' . $upcontext['language'] . '.php'); |
@@ -2432,8 +2584,9 @@ discard block |
||
| 2432 | 2584 | global $upcontext, $db_character_set, $sourcedir, $smcFunc, $modSettings, $language, $db_prefix, $db_type, $command_line, $support_js; |
| 2433 | 2585 | |
| 2434 | 2586 | // Done it already? |
| 2435 | - if (!empty($_POST['utf8_done'])) |
|
| 2436 | - return true; |
|
| 2587 | + if (!empty($_POST['utf8_done'])) { |
|
| 2588 | + return true; |
|
| 2589 | + } |
|
| 2437 | 2590 | |
| 2438 | 2591 | // First make sure they aren't already on UTF-8 before we go anywhere... |
| 2439 | 2592 | if ($db_type == 'postgresql' || ($db_character_set === 'utf8' && !empty($modSettings['global_character_set']) && $modSettings['global_character_set'] === 'UTF-8')) |
@@ -2446,8 +2599,7 @@ discard block |
||
| 2446 | 2599 | ); |
| 2447 | 2600 | |
| 2448 | 2601 | return true; |
| 2449 | - } |
|
| 2450 | - else |
|
| 2602 | + } else |
|
| 2451 | 2603 | { |
| 2452 | 2604 | $upcontext['page_title'] = 'Converting to UTF8'; |
| 2453 | 2605 | $upcontext['sub_template'] = isset($_GET['xml']) ? 'convert_xml' : 'convert_utf8'; |
@@ -2491,8 +2643,9 @@ discard block |
||
| 2491 | 2643 | ) |
| 2492 | 2644 | ); |
| 2493 | 2645 | $db_charsets = array(); |
| 2494 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 2495 | - $db_charsets[] = $row['Charset']; |
|
| 2646 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2647 | + $db_charsets[] = $row['Charset']; |
|
| 2648 | + } |
|
| 2496 | 2649 | |
| 2497 | 2650 | $smcFunc['db_free_result']($request); |
| 2498 | 2651 | |
@@ -2528,13 +2681,15 @@ discard block |
||
| 2528 | 2681 | // If there's a fulltext index, we need to drop it first... |
| 2529 | 2682 | if ($request !== false || $smcFunc['db_num_rows']($request) != 0) |
| 2530 | 2683 | { |
| 2531 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 2532 | - if ($row['Column_name'] == 'body' && (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT' || isset($row['Comment']) && $row['Comment'] == 'FULLTEXT')) |
|
| 2684 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2685 | + if ($row['Column_name'] == 'body' && (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT' || isset($row['Comment']) && $row['Comment'] == 'FULLTEXT')) |
|
| 2533 | 2686 | $upcontext['fulltext_index'][] = $row['Key_name']; |
| 2687 | + } |
|
| 2534 | 2688 | $smcFunc['db_free_result']($request); |
| 2535 | 2689 | |
| 2536 | - if (isset($upcontext['fulltext_index'])) |
|
| 2537 | - $upcontext['fulltext_index'] = array_unique($upcontext['fulltext_index']); |
|
| 2690 | + if (isset($upcontext['fulltext_index'])) { |
|
| 2691 | + $upcontext['fulltext_index'] = array_unique($upcontext['fulltext_index']); |
|
| 2692 | + } |
|
| 2538 | 2693 | } |
| 2539 | 2694 | |
| 2540 | 2695 | // Drop it and make a note... |
@@ -2724,8 +2879,9 @@ discard block |
||
| 2724 | 2879 | $replace = '%field%'; |
| 2725 | 2880 | |
| 2726 | 2881 | // Build a huge REPLACE statement... |
| 2727 | - foreach ($translation_tables[$upcontext['charset_detected']] as $from => $to) |
|
| 2728 | - $replace = 'REPLACE(' . $replace . ', ' . $from . ', ' . $to . ')'; |
|
| 2882 | + foreach ($translation_tables[$upcontext['charset_detected']] as $from => $to) { |
|
| 2883 | + $replace = 'REPLACE(' . $replace . ', ' . $from . ', ' . $to . ')'; |
|
| 2884 | + } |
|
| 2729 | 2885 | } |
| 2730 | 2886 | |
| 2731 | 2887 | // Get a list of table names ahead of time... This makes it easier to set our substep and such |
@@ -2735,9 +2891,10 @@ discard block |
||
| 2735 | 2891 | $upcontext['table_count'] = count($queryTables); |
| 2736 | 2892 | |
| 2737 | 2893 | // What ones have we already done? |
| 2738 | - foreach ($queryTables as $id => $table) |
|
| 2739 | - if ($id < $_GET['substep']) |
|
| 2894 | + foreach ($queryTables as $id => $table) { |
|
| 2895 | + if ($id < $_GET['substep']) |
|
| 2740 | 2896 | $upcontext['previous_tables'][] = $table; |
| 2897 | + } |
|
| 2741 | 2898 | |
| 2742 | 2899 | $upcontext['cur_table_num'] = $_GET['substep']; |
| 2743 | 2900 | $upcontext['cur_table_name'] = str_replace($db_prefix, '', $queryTables[$_GET['substep']]); |
@@ -2774,8 +2931,9 @@ discard block |
||
| 2774 | 2931 | nextSubstep($substep); |
| 2775 | 2932 | |
| 2776 | 2933 | // Just to make sure it doesn't time out. |
| 2777 | - if (function_exists('apache_reset_timeout')) |
|
| 2778 | - @apache_reset_timeout(); |
|
| 2934 | + if (function_exists('apache_reset_timeout')) { |
|
| 2935 | + @apache_reset_timeout(); |
|
| 2936 | + } |
|
| 2779 | 2937 | |
| 2780 | 2938 | $table_charsets = array(); |
| 2781 | 2939 | |
@@ -2796,8 +2954,9 @@ discard block |
||
| 2796 | 2954 | { |
| 2797 | 2955 | list($charset) = explode('_', $collation); |
| 2798 | 2956 | |
| 2799 | - if (!isset($table_charsets[$charset])) |
|
| 2800 | - $table_charsets[$charset] = array(); |
|
| 2957 | + if (!isset($table_charsets[$charset])) { |
|
| 2958 | + $table_charsets[$charset] = array(); |
|
| 2959 | + } |
|
| 2801 | 2960 | |
| 2802 | 2961 | $table_charsets[$charset][] = $column_info; |
| 2803 | 2962 | } |
@@ -2837,10 +2996,11 @@ discard block |
||
| 2837 | 2996 | if (isset($translation_tables[$upcontext['charset_detected']])) |
| 2838 | 2997 | { |
| 2839 | 2998 | $update = ''; |
| 2840 | - foreach ($table_charsets as $charset => $columns) |
|
| 2841 | - foreach ($columns as $column) |
|
| 2999 | + foreach ($table_charsets as $charset => $columns) { |
|
| 3000 | + foreach ($columns as $column) |
|
| 2842 | 3001 | $update .= ' |
| 2843 | 3002 | ' . $column['Field'] . ' = ' . strtr($replace, array('%field%' => $column['Field'])) . ','; |
| 3003 | + } |
|
| 2844 | 3004 | |
| 2845 | 3005 | $smcFunc['db_query']('', ' |
| 2846 | 3006 | UPDATE {raw:table_name} |
@@ -2865,8 +3025,9 @@ discard block |
||
| 2865 | 3025 | // Now do the actual conversion (if still needed). |
| 2866 | 3026 | if ($charsets[$upcontext['charset_detected']] !== 'utf8') |
| 2867 | 3027 | { |
| 2868 | - if ($command_line) |
|
| 2869 | - echo 'Converting table ' . $table_info['Name'] . ' to UTF-8...'; |
|
| 3028 | + if ($command_line) { |
|
| 3029 | + echo 'Converting table ' . $table_info['Name'] . ' to UTF-8...'; |
|
| 3030 | + } |
|
| 2870 | 3031 | |
| 2871 | 3032 | $smcFunc['db_query']('', ' |
| 2872 | 3033 | ALTER TABLE {raw:table_name} |
@@ -2876,12 +3037,14 @@ discard block |
||
| 2876 | 3037 | ) |
| 2877 | 3038 | ); |
| 2878 | 3039 | |
| 2879 | - if ($command_line) |
|
| 2880 | - echo " done.\n"; |
|
| 3040 | + if ($command_line) { |
|
| 3041 | + echo " done.\n"; |
|
| 3042 | + } |
|
| 2881 | 3043 | } |
| 2882 | 3044 | // If this is XML to keep it nice for the user do one table at a time anyway! |
| 2883 | - if (isset($_GET['xml'])) |
|
| 2884 | - return upgradeExit(); |
|
| 3045 | + if (isset($_GET['xml'])) { |
|
| 3046 | + return upgradeExit(); |
|
| 3047 | + } |
|
| 2885 | 3048 | } |
| 2886 | 3049 | |
| 2887 | 3050 | $prev_charset = empty($translation_tables[$upcontext['charset_detected']]) ? $charsets[$upcontext['charset_detected']] : $translation_tables[$upcontext['charset_detected']]; |
@@ -2910,8 +3073,8 @@ discard block |
||
| 2910 | 3073 | ); |
| 2911 | 3074 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 2912 | 3075 | { |
| 2913 | - if (@safe_unserialize($row['extra']) === false && preg_match('~^(a:3:{s:5:"topic";i:\d+;s:7:"subject";s:)(\d+):"(.+)"(;s:6:"member";s:5:"\d+";})$~', $row['extra'], $matches) === 1) |
|
| 2914 | - $smcFunc['db_query']('', ' |
|
| 3076 | + if (@safe_unserialize($row['extra']) === false && preg_match('~^(a:3:{s:5:"topic";i:\d+;s:7:"subject";s:)(\d+):"(.+)"(;s:6:"member";s:5:"\d+";})$~', $row['extra'], $matches) === 1) { |
|
| 3077 | + $smcFunc['db_query']('', ' |
|
| 2915 | 3078 | UPDATE {db_prefix}log_actions |
| 2916 | 3079 | SET extra = {string:extra} |
| 2917 | 3080 | WHERE id_action = {int:current_action}', |
@@ -2920,6 +3083,7 @@ discard block |
||
| 2920 | 3083 | 'extra' => $matches[1] . strlen($matches[3]) . ':"' . $matches[3] . '"' . $matches[4], |
| 2921 | 3084 | ) |
| 2922 | 3085 | ); |
| 3086 | + } |
|
| 2923 | 3087 | } |
| 2924 | 3088 | $smcFunc['db_free_result']($request); |
| 2925 | 3089 | |
@@ -2941,15 +3105,17 @@ discard block |
||
| 2941 | 3105 | // First thing's first - did we already do this? |
| 2942 | 3106 | if (!empty($modSettings['json_done'])) |
| 2943 | 3107 | { |
| 2944 | - if ($command_line) |
|
| 2945 | - return DeleteUpgrade(); |
|
| 2946 | - else |
|
| 2947 | - return true; |
|
| 3108 | + if ($command_line) { |
|
| 3109 | + return DeleteUpgrade(); |
|
| 3110 | + } else { |
|
| 3111 | + return true; |
|
| 3112 | + } |
|
| 2948 | 3113 | } |
| 2949 | 3114 | |
| 2950 | 3115 | // Done it already - js wise? |
| 2951 | - if (!empty($_POST['json_done'])) |
|
| 2952 | - return true; |
|
| 3116 | + if (!empty($_POST['json_done'])) { |
|
| 3117 | + return true; |
|
| 3118 | + } |
|
| 2953 | 3119 | |
| 2954 | 3120 | // List of tables affected by this function |
| 2955 | 3121 | // name => array('key', col1[,col2|true[,col3]]) |
@@ -2981,12 +3147,14 @@ discard block |
||
| 2981 | 3147 | $upcontext['cur_table_name'] = isset($keys[$_GET['substep']]) ? $keys[$_GET['substep']] : $keys[0]; |
| 2982 | 3148 | $upcontext['step_progress'] = (int) (($upcontext['cur_table_num'] / $upcontext['table_count']) * 100); |
| 2983 | 3149 | |
| 2984 | - foreach ($keys as $id => $table) |
|
| 2985 | - if ($id < $_GET['substep']) |
|
| 3150 | + foreach ($keys as $id => $table) { |
|
| 3151 | + if ($id < $_GET['substep']) |
|
| 2986 | 3152 | $upcontext['previous_tables'][] = $table; |
| 3153 | + } |
|
| 2987 | 3154 | |
| 2988 | - if ($command_line) |
|
| 2989 | - echo 'Converting data from serialize() to json_encode().'; |
|
| 3155 | + if ($command_line) { |
|
| 3156 | + echo 'Converting data from serialize() to json_encode().'; |
|
| 3157 | + } |
|
| 2990 | 3158 | |
| 2991 | 3159 | if (!$support_js || isset($_GET['xml'])) |
| 2992 | 3160 | { |
@@ -3026,8 +3194,9 @@ discard block |
||
| 3026 | 3194 | |
| 3027 | 3195 | // Loop through and fix these... |
| 3028 | 3196 | $new_settings = array(); |
| 3029 | - if ($command_line) |
|
| 3030 | - echo "\n" . 'Fixing some settings...'; |
|
| 3197 | + if ($command_line) { |
|
| 3198 | + echo "\n" . 'Fixing some settings...'; |
|
| 3199 | + } |
|
| 3031 | 3200 | |
| 3032 | 3201 | foreach ($serialized_settings as $var) |
| 3033 | 3202 | { |
@@ -3035,22 +3204,24 @@ discard block |
||
| 3035 | 3204 | { |
| 3036 | 3205 | // Attempt to unserialize the setting |
| 3037 | 3206 | $temp = @safe_unserialize($modSettings[$var]); |
| 3038 | - if (!$temp && $command_line) |
|
| 3039 | - echo "\n - Failed to unserialize the '" . $var . "' setting. Skipping."; |
|
| 3040 | - elseif ($temp !== false) |
|
| 3041 | - $new_settings[$var] = json_encode($temp); |
|
| 3207 | + if (!$temp && $command_line) { |
|
| 3208 | + echo "\n - Failed to unserialize the '" . $var . "' setting. Skipping."; |
|
| 3209 | + } elseif ($temp !== false) { |
|
| 3210 | + $new_settings[$var] = json_encode($temp); |
|
| 3211 | + } |
|
| 3042 | 3212 | } |
| 3043 | 3213 | } |
| 3044 | 3214 | |
| 3045 | 3215 | // Update everything at once |
| 3046 | - if (!function_exists('cache_put_data')) |
|
| 3047 | - require_once($sourcedir . '/Load.php'); |
|
| 3216 | + if (!function_exists('cache_put_data')) { |
|
| 3217 | + require_once($sourcedir . '/Load.php'); |
|
| 3218 | + } |
|
| 3048 | 3219 | updateSettings($new_settings, true); |
| 3049 | 3220 | |
| 3050 | - if ($command_line) |
|
| 3051 | - echo ' done.'; |
|
| 3052 | - } |
|
| 3053 | - elseif ($table == 'themes') |
|
| 3221 | + if ($command_line) { |
|
| 3222 | + echo ' done.'; |
|
| 3223 | + } |
|
| 3224 | + } elseif ($table == 'themes') |
|
| 3054 | 3225 | { |
| 3055 | 3226 | // Finally, fix the admin prefs. Unfortunately this is stored per theme, but hopefully they only have one theme installed at this point... |
| 3056 | 3227 | $query = $smcFunc['db_query']('', ' |
@@ -3069,10 +3240,11 @@ discard block |
||
| 3069 | 3240 | |
| 3070 | 3241 | if ($command_line) |
| 3071 | 3242 | { |
| 3072 | - if ($temp === false) |
|
| 3073 | - echo "\n" . 'Unserialize of admin_preferences for user ' . $row['id_member'] . ' failed. Skipping.'; |
|
| 3074 | - else |
|
| 3075 | - echo "\n" . 'Fixing admin preferences...'; |
|
| 3243 | + if ($temp === false) { |
|
| 3244 | + echo "\n" . 'Unserialize of admin_preferences for user ' . $row['id_member'] . ' failed. Skipping.'; |
|
| 3245 | + } else { |
|
| 3246 | + echo "\n" . 'Fixing admin preferences...'; |
|
| 3247 | + } |
|
| 3076 | 3248 | } |
| 3077 | 3249 | |
| 3078 | 3250 | if ($temp !== false) |
@@ -3094,15 +3266,15 @@ discard block |
||
| 3094 | 3266 | ) |
| 3095 | 3267 | ); |
| 3096 | 3268 | |
| 3097 | - if ($command_line) |
|
| 3098 | - echo ' done.'; |
|
| 3269 | + if ($command_line) { |
|
| 3270 | + echo ' done.'; |
|
| 3271 | + } |
|
| 3099 | 3272 | } |
| 3100 | 3273 | } |
| 3101 | 3274 | |
| 3102 | 3275 | $smcFunc['db_free_result']($query); |
| 3103 | 3276 | } |
| 3104 | - } |
|
| 3105 | - else |
|
| 3277 | + } else |
|
| 3106 | 3278 | { |
| 3107 | 3279 | // First item is always the key... |
| 3108 | 3280 | $key = $info[0]; |
@@ -3113,8 +3285,7 @@ discard block |
||
| 3113 | 3285 | { |
| 3114 | 3286 | $col_select = $info[1]; |
| 3115 | 3287 | $where = ' WHERE ' . $info[1] . ' != {empty}'; |
| 3116 | - } |
|
| 3117 | - else |
|
| 3288 | + } else |
|
| 3118 | 3289 | { |
| 3119 | 3290 | $col_select = implode(', ', $info); |
| 3120 | 3291 | } |
@@ -3147,8 +3318,7 @@ discard block |
||
| 3147 | 3318 | if ($temp === false && $command_line) |
| 3148 | 3319 | { |
| 3149 | 3320 | echo "\nFailed to unserialize " . $row[$col] . "... Skipping\n"; |
| 3150 | - } |
|
| 3151 | - else |
|
| 3321 | + } else |
|
| 3152 | 3322 | { |
| 3153 | 3323 | $row[$col] = json_encode($temp); |
| 3154 | 3324 | |
@@ -3173,16 +3343,18 @@ discard block |
||
| 3173 | 3343 | } |
| 3174 | 3344 | } |
| 3175 | 3345 | |
| 3176 | - if ($command_line) |
|
| 3177 | - echo ' done.'; |
|
| 3346 | + if ($command_line) { |
|
| 3347 | + echo ' done.'; |
|
| 3348 | + } |
|
| 3178 | 3349 | |
| 3179 | 3350 | // Free up some memory... |
| 3180 | 3351 | $smcFunc['db_free_result']($query); |
| 3181 | 3352 | } |
| 3182 | 3353 | } |
| 3183 | 3354 | // If this is XML to keep it nice for the user do one table at a time anyway! |
| 3184 | - if (isset($_GET['xml'])) |
|
| 3185 | - return upgradeExit(); |
|
| 3355 | + if (isset($_GET['xml'])) { |
|
| 3356 | + return upgradeExit(); |
|
| 3357 | + } |
|
| 3186 | 3358 | } |
| 3187 | 3359 | |
| 3188 | 3360 | if ($command_line) |
@@ -3197,8 +3369,9 @@ discard block |
||
| 3197 | 3369 | |
| 3198 | 3370 | $_GET['substep'] = 0; |
| 3199 | 3371 | // Make sure we move on! |
| 3200 | - if ($command_line) |
|
| 3201 | - return DeleteUpgrade(); |
|
| 3372 | + if ($command_line) { |
|
| 3373 | + return DeleteUpgrade(); |
|
| 3374 | + } |
|
| 3202 | 3375 | |
| 3203 | 3376 | return true; |
| 3204 | 3377 | } |
@@ -3218,14 +3391,16 @@ discard block |
||
| 3218 | 3391 | global $upcontext, $txt, $settings; |
| 3219 | 3392 | |
| 3220 | 3393 | // Don't call me twice! |
| 3221 | - if (!empty($upcontext['chmod_called'])) |
|
| 3222 | - return; |
|
| 3394 | + if (!empty($upcontext['chmod_called'])) { |
|
| 3395 | + return; |
|
| 3396 | + } |
|
| 3223 | 3397 | |
| 3224 | 3398 | $upcontext['chmod_called'] = true; |
| 3225 | 3399 | |
| 3226 | 3400 | // Nothing? |
| 3227 | - if (empty($upcontext['chmod']['files']) && empty($upcontext['chmod']['ftp_error'])) |
|
| 3228 | - return; |
|
| 3401 | + if (empty($upcontext['chmod']['files']) && empty($upcontext['chmod']['ftp_error'])) { |
|
| 3402 | + return; |
|
| 3403 | + } |
|
| 3229 | 3404 | |
| 3230 | 3405 | // Was it a problem with Windows? |
| 3231 | 3406 | if (!empty($upcontext['chmod']['ftp_error']) && $upcontext['chmod']['ftp_error'] == 'total_mess') |
@@ -3257,11 +3432,12 @@ discard block |
||
| 3257 | 3432 | content.write(\'<div class="windowbg description">\n\t\t\t<h4>The following files needs to be made writable to continue:</h4>\n\t\t\t\'); |
| 3258 | 3433 | content.write(\'<p>', implode('<br>\n\t\t\t', $upcontext['chmod']['files']), '</p>\n\t\t\t\');'; |
| 3259 | 3434 | |
| 3260 | - if (isset($upcontext['systemos']) && $upcontext['systemos'] == 'linux') |
|
| 3261 | - echo ' |
|
| 3435 | + if (isset($upcontext['systemos']) && $upcontext['systemos'] == 'linux') { |
|
| 3436 | + echo ' |
|
| 3262 | 3437 | content.write(\'<hr>\n\t\t\t\'); |
| 3263 | 3438 | content.write(\'<p>If you have a shell account, the convenient below command can automatically correct permissions on these files</p>\n\t\t\t\'); |
| 3264 | 3439 | content.write(\'<tt># chmod a+w ', implode(' ', $upcontext['chmod']['files']), '</tt>\n\t\t\t\');'; |
| 3440 | + } |
|
| 3265 | 3441 | |
| 3266 | 3442 | echo ' |
| 3267 | 3443 | content.write(\'<a href="javascript:self.close();">close</a>\n\t\t</div>\n\t</body>\n</html>\'); |
@@ -3269,17 +3445,19 @@ discard block |
||
| 3269 | 3445 | } |
| 3270 | 3446 | </script>'; |
| 3271 | 3447 | |
| 3272 | - if (!empty($upcontext['chmod']['ftp_error'])) |
|
| 3273 | - echo ' |
|
| 3448 | + if (!empty($upcontext['chmod']['ftp_error'])) { |
|
| 3449 | + echo ' |
|
| 3274 | 3450 | <div class="error_message red"> |
| 3275 | 3451 | The following error was encountered when trying to connect:<br><br> |
| 3276 | 3452 | <code>', $upcontext['chmod']['ftp_error'], '</code> |
| 3277 | 3453 | </div> |
| 3278 | 3454 | <br>'; |
| 3455 | + } |
|
| 3279 | 3456 | |
| 3280 | - if (empty($upcontext['chmod_in_form'])) |
|
| 3281 | - echo ' |
|
| 3457 | + if (empty($upcontext['chmod_in_form'])) { |
|
| 3458 | + echo ' |
|
| 3282 | 3459 | <form action="', $upcontext['form_url'], '" method="post">'; |
| 3460 | + } |
|
| 3283 | 3461 | |
| 3284 | 3462 | echo ' |
| 3285 | 3463 | <table width="520" border="0" align="center" style="margin-bottom: 1ex;"> |
@@ -3314,10 +3492,11 @@ discard block |
||
| 3314 | 3492 | <div class="righttext" style="margin: 1ex;"><input type="submit" value="', $txt['ftp_connect'], '" class="button_submit"></div> |
| 3315 | 3493 | </div>'; |
| 3316 | 3494 | |
| 3317 | - if (empty($upcontext['chmod_in_form'])) |
|
| 3318 | - echo ' |
|
| 3495 | + if (empty($upcontext['chmod_in_form'])) { |
|
| 3496 | + echo ' |
|
| 3319 | 3497 | </form>'; |
| 3320 | -} |
|
| 3498 | + } |
|
| 3499 | + } |
|
| 3321 | 3500 | |
| 3322 | 3501 | function template_upgrade_above() |
| 3323 | 3502 | { |
@@ -3377,9 +3556,10 @@ discard block |
||
| 3377 | 3556 | <h2>', $txt['upgrade_progress'], '</h2> |
| 3378 | 3557 | <ul>'; |
| 3379 | 3558 | |
| 3380 | - foreach ($upcontext['steps'] as $num => $step) |
|
| 3381 | - echo ' |
|
| 3559 | + foreach ($upcontext['steps'] as $num => $step) { |
|
| 3560 | + echo ' |
|
| 3382 | 3561 | <li class="', $num < $upcontext['current_step'] ? 'stepdone' : ($num == $upcontext['current_step'] ? 'stepcurrent' : 'stepwaiting'), '">', $txt['upgrade_step'], ' ', $step[0], ': ', $step[1], '</li>'; |
| 3562 | + } |
|
| 3383 | 3563 | |
| 3384 | 3564 | echo ' |
| 3385 | 3565 | </ul> |
@@ -3392,8 +3572,8 @@ discard block |
||
| 3392 | 3572 | </div> |
| 3393 | 3573 | </div>'; |
| 3394 | 3574 | |
| 3395 | - if (isset($upcontext['step_progress'])) |
|
| 3396 | - echo ' |
|
| 3575 | + if (isset($upcontext['step_progress'])) { |
|
| 3576 | + echo ' |
|
| 3397 | 3577 | <br> |
| 3398 | 3578 | <br> |
| 3399 | 3579 | <div id="progress_bar_step"> |
@@ -3402,6 +3582,7 @@ discard block |
||
| 3402 | 3582 | <span>', $txt['upgrade_step_progress'], '</span> |
| 3403 | 3583 | </div> |
| 3404 | 3584 | </div>'; |
| 3585 | + } |
|
| 3405 | 3586 | |
| 3406 | 3587 | echo ' |
| 3407 | 3588 | <div id="substep_bar_div" class="smalltext" style="float: left;width: 50%;margin-top: 0.6em;display: ', isset($upcontext['substep_progress']) ? '' : 'none', ';">', isset($upcontext['substep_progress_name']) ? trim(strtr($upcontext['substep_progress_name'], array('.' => ''))) : '', ':</div> |
@@ -3432,32 +3613,36 @@ discard block |
||
| 3432 | 3613 | { |
| 3433 | 3614 | global $upcontext, $txt; |
| 3434 | 3615 | |
| 3435 | - if (!empty($upcontext['pause'])) |
|
| 3436 | - echo ' |
|
| 3616 | + if (!empty($upcontext['pause'])) { |
|
| 3617 | + echo ' |
|
| 3437 | 3618 | <em>', $txt['upgrade_incomplete'], '.</em><br> |
| 3438 | 3619 | |
| 3439 | 3620 | <h2 style="margin-top: 2ex;">', $txt['upgrade_not_quite_done'], '</h2> |
| 3440 | 3621 | <h3> |
| 3441 | 3622 | ', $txt['upgrade_paused_overload'], ' |
| 3442 | 3623 | </h3>'; |
| 3624 | + } |
|
| 3443 | 3625 | |
| 3444 | - if (!empty($upcontext['custom_warning'])) |
|
| 3445 | - echo ' |
|
| 3626 | + if (!empty($upcontext['custom_warning'])) { |
|
| 3627 | + echo ' |
|
| 3446 | 3628 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
| 3447 | 3629 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
| 3448 | 3630 | <strong style="text-decoration: underline;">', $txt['upgrade_note'], '</strong><br> |
| 3449 | 3631 | <div style="padding-left: 6ex;">', $upcontext['custom_warning'], '</div> |
| 3450 | 3632 | </div>'; |
| 3633 | + } |
|
| 3451 | 3634 | |
| 3452 | 3635 | echo ' |
| 3453 | 3636 | <div class="righttext" style="margin: 1ex;">'; |
| 3454 | 3637 | |
| 3455 | - if (!empty($upcontext['continue'])) |
|
| 3456 | - echo ' |
|
| 3638 | + if (!empty($upcontext['continue'])) { |
|
| 3639 | + echo ' |
|
| 3457 | 3640 | <input type="submit" id="contbutt" name="contbutt" value="', $txt['upgrade_continue'], '"', $upcontext['continue'] == 2 ? ' disabled' : '', ' class="button_submit">'; |
| 3458 | - if (!empty($upcontext['skip'])) |
|
| 3459 | - echo ' |
|
| 3641 | + } |
|
| 3642 | + if (!empty($upcontext['skip'])) { |
|
| 3643 | + echo ' |
|
| 3460 | 3644 | <input type="submit" id="skip" name="skip" value="', $txt['upgrade_skip'], '" onclick="dontSubmit = true; document.getElementById(\'contbutt\').disabled = \'disabled\'; return true;" class="button_submit">'; |
| 3645 | + } |
|
| 3461 | 3646 | |
| 3462 | 3647 | echo ' |
| 3463 | 3648 | </div> |
@@ -3507,11 +3692,12 @@ discard block |
||
| 3507 | 3692 | echo '<', '?xml version="1.0" encoding="UTF-8"?', '> |
| 3508 | 3693 | <smf>'; |
| 3509 | 3694 | |
| 3510 | - if (!empty($upcontext['get_data'])) |
|
| 3511 | - foreach ($upcontext['get_data'] as $k => $v) |
|
| 3695 | + if (!empty($upcontext['get_data'])) { |
|
| 3696 | + foreach ($upcontext['get_data'] as $k => $v) |
|
| 3512 | 3697 | echo ' |
| 3513 | 3698 | <get key="', $k, '">', $v, '</get>'; |
| 3514 | -} |
|
| 3699 | + } |
|
| 3700 | + } |
|
| 3515 | 3701 | |
| 3516 | 3702 | function template_xml_below() |
| 3517 | 3703 | { |
@@ -3552,8 +3738,8 @@ discard block |
||
| 3552 | 3738 | template_chmod(); |
| 3553 | 3739 | |
| 3554 | 3740 | // For large, pre 1.1 RC2 forums give them a warning about the possible impact of this upgrade! |
| 3555 | - if ($upcontext['is_large_forum']) |
|
| 3556 | - echo ' |
|
| 3741 | + if ($upcontext['is_large_forum']) { |
|
| 3742 | + echo ' |
|
| 3557 | 3743 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
| 3558 | 3744 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
| 3559 | 3745 | <strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br> |
@@ -3561,10 +3747,11 @@ discard block |
||
| 3561 | 3747 | ', $txt['upgrade_warning_lots_data'], ' |
| 3562 | 3748 | </div> |
| 3563 | 3749 | </div>'; |
| 3750 | + } |
|
| 3564 | 3751 | |
| 3565 | 3752 | // A warning message? |
| 3566 | - if (!empty($upcontext['warning'])) |
|
| 3567 | - echo ' |
|
| 3753 | + if (!empty($upcontext['warning'])) { |
|
| 3754 | + echo ' |
|
| 3568 | 3755 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
| 3569 | 3756 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
| 3570 | 3757 | <strong style="text-decoration: underline;">', $txt['upgrade_warning'], '</strong><br> |
@@ -3572,6 +3759,7 @@ discard block |
||
| 3572 | 3759 | ', $upcontext['warning'], ' |
| 3573 | 3760 | </div> |
| 3574 | 3761 | </div>'; |
| 3762 | + } |
|
| 3575 | 3763 | |
| 3576 | 3764 | // Paths are incorrect? |
| 3577 | 3765 | echo ' |
@@ -3587,20 +3775,22 @@ discard block |
||
| 3587 | 3775 | if (!empty($upcontext['user']['id']) && (time() - $upcontext['started'] < 72600 || time() - $upcontext['updated'] < 3600)) |
| 3588 | 3776 | { |
| 3589 | 3777 | $ago = time() - $upcontext['started']; |
| 3590 | - if ($ago < 60) |
|
| 3591 | - $ago = $ago . ' seconds'; |
|
| 3592 | - elseif ($ago < 3600) |
|
| 3593 | - $ago = (int) ($ago / 60) . ' minutes'; |
|
| 3594 | - else |
|
| 3595 | - $ago = (int) ($ago / 3600) . ' hours'; |
|
| 3778 | + if ($ago < 60) { |
|
| 3779 | + $ago = $ago . ' seconds'; |
|
| 3780 | + } elseif ($ago < 3600) { |
|
| 3781 | + $ago = (int) ($ago / 60) . ' minutes'; |
|
| 3782 | + } else { |
|
| 3783 | + $ago = (int) ($ago / 3600) . ' hours'; |
|
| 3784 | + } |
|
| 3596 | 3785 | |
| 3597 | 3786 | $active = time() - $upcontext['updated']; |
| 3598 | - if ($active < 60) |
|
| 3599 | - $updated = $active . ' seconds'; |
|
| 3600 | - elseif ($active < 3600) |
|
| 3601 | - $updated = (int) ($active / 60) . ' minutes'; |
|
| 3602 | - else |
|
| 3603 | - $updated = (int) ($active / 3600) . ' hours'; |
|
| 3787 | + if ($active < 60) { |
|
| 3788 | + $updated = $active . ' seconds'; |
|
| 3789 | + } elseif ($active < 3600) { |
|
| 3790 | + $updated = (int) ($active / 60) . ' minutes'; |
|
| 3791 | + } else { |
|
| 3792 | + $updated = (int) ($active / 3600) . ' hours'; |
|
| 3793 | + } |
|
| 3604 | 3794 | |
| 3605 | 3795 | echo ' |
| 3606 | 3796 | <div style="margin: 2ex; padding: 2ex; border: 2px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
@@ -3609,16 +3799,18 @@ discard block |
||
| 3609 | 3799 | <div style="padding-left: 6ex;"> |
| 3610 | 3800 | "', $upcontext['user']['name'], '" has been running the upgrade script for the last ', $ago, ' - and was last active ', $updated, ' ago.'; |
| 3611 | 3801 | |
| 3612 | - if ($active < 600) |
|
| 3613 | - echo ' |
|
| 3802 | + if ($active < 600) { |
|
| 3803 | + echo ' |
|
| 3614 | 3804 | We recommend that you do not run this script unless you are sure that ', $upcontext['user']['name'], ' has completed their upgrade.'; |
| 3805 | + } |
|
| 3615 | 3806 | |
| 3616 | - if ($active > $upcontext['inactive_timeout']) |
|
| 3617 | - echo ' |
|
| 3807 | + if ($active > $upcontext['inactive_timeout']) { |
|
| 3808 | + echo ' |
|
| 3618 | 3809 | <br><br>You can choose to either run the upgrade again from the beginning - or alternatively continue from the last step reached during the last upgrade.'; |
| 3619 | - else |
|
| 3620 | - echo ' |
|
| 3810 | + } else { |
|
| 3811 | + echo ' |
|
| 3621 | 3812 | <br><br>This upgrade script cannot be run until ', $upcontext['user']['name'], ' has been inactive for at least ', ($upcontext['inactive_timeout'] > 120 ? round($upcontext['inactive_timeout'] / 60, 1) . ' minutes!' : $upcontext['inactive_timeout'] . ' seconds!'); |
| 3813 | + } |
|
| 3622 | 3814 | |
| 3623 | 3815 | echo ' |
| 3624 | 3816 | </div> |
@@ -3634,9 +3826,10 @@ discard block |
||
| 3634 | 3826 | <td> |
| 3635 | 3827 | <input type="text" name="user" value="', !empty($upcontext['username']) ? $upcontext['username'] : '', '"', $disable_security ? ' disabled' : '', ' class="input_text">'; |
| 3636 | 3828 | |
| 3637 | - if (!empty($upcontext['username_incorrect'])) |
|
| 3638 | - echo ' |
|
| 3829 | + if (!empty($upcontext['username_incorrect'])) { |
|
| 3830 | + echo ' |
|
| 3639 | 3831 | <div class="smalltext" style="color: red;">Username Incorrect</div>'; |
| 3832 | + } |
|
| 3640 | 3833 | |
| 3641 | 3834 | echo ' |
| 3642 | 3835 | </td> |
@@ -3647,9 +3840,10 @@ discard block |
||
| 3647 | 3840 | <input type="password" name="passwrd" value=""', $disable_security ? ' disabled' : '', ' class="input_password"> |
| 3648 | 3841 | <input type="hidden" name="hash_passwrd" value="">'; |
| 3649 | 3842 | |
| 3650 | - if (!empty($upcontext['password_failed'])) |
|
| 3651 | - echo ' |
|
| 3843 | + if (!empty($upcontext['password_failed'])) { |
|
| 3844 | + echo ' |
|
| 3652 | 3845 | <div class="smalltext" style="color: red;">Password Incorrect</div>'; |
| 3846 | + } |
|
| 3653 | 3847 | |
| 3654 | 3848 | echo ' |
| 3655 | 3849 | </td> |
@@ -3720,8 +3914,8 @@ discard block |
||
| 3720 | 3914 | <form action="', $upcontext['form_url'], '" method="post" name="upform" id="upform">'; |
| 3721 | 3915 | |
| 3722 | 3916 | // Warning message? |
| 3723 | - if (!empty($upcontext['upgrade_options_warning'])) |
|
| 3724 | - echo ' |
|
| 3917 | + if (!empty($upcontext['upgrade_options_warning'])) { |
|
| 3918 | + echo ' |
|
| 3725 | 3919 | <div style="margin: 1ex; padding: 1ex; border: 1px dashed #cc3344; color: black; background-color: #ffe4e9;"> |
| 3726 | 3920 | <div style="float: left; width: 2ex; font-size: 2em; color: red;">!!</div> |
| 3727 | 3921 | <strong style="text-decoration: underline;">Warning!</strong><br> |
@@ -3729,6 +3923,7 @@ discard block |
||
| 3729 | 3923 | ', $upcontext['upgrade_options_warning'], ' |
| 3730 | 3924 | </div> |
| 3731 | 3925 | </div>'; |
| 3926 | + } |
|
| 3732 | 3927 | |
| 3733 | 3928 | echo ' |
| 3734 | 3929 | <table> |
@@ -3771,8 +3966,8 @@ discard block |
||
| 3771 | 3966 | </td> |
| 3772 | 3967 | </tr>'; |
| 3773 | 3968 | |
| 3774 | - if (!empty($upcontext['karma_installed']['good']) || !empty($upcontext['karma_installed']['bad'])) |
|
| 3775 | - echo ' |
|
| 3969 | + if (!empty($upcontext['karma_installed']['good']) || !empty($upcontext['karma_installed']['bad'])) { |
|
| 3970 | + echo ' |
|
| 3776 | 3971 | <tr valign="top"> |
| 3777 | 3972 | <td width="2%"> |
| 3778 | 3973 | <input type="checkbox" name="delete_karma" id="delete_karma" value="1" class="input_check"> |
@@ -3781,6 +3976,7 @@ discard block |
||
| 3781 | 3976 | <label for="delete_karma">Delete all karma settings and info from the DB</label> |
| 3782 | 3977 | </td> |
| 3783 | 3978 | </tr>'; |
| 3979 | + } |
|
| 3784 | 3980 | |
| 3785 | 3981 | echo ' |
| 3786 | 3982 | <tr valign="top"> |
@@ -3818,10 +4014,11 @@ discard block |
||
| 3818 | 4014 | </div>'; |
| 3819 | 4015 | |
| 3820 | 4016 | // Dont any tables so far? |
| 3821 | - if (!empty($upcontext['previous_tables'])) |
|
| 3822 | - foreach ($upcontext['previous_tables'] as $table) |
|
| 4017 | + if (!empty($upcontext['previous_tables'])) { |
|
| 4018 | + foreach ($upcontext['previous_tables'] as $table) |
|
| 3823 | 4019 | echo ' |
| 3824 | 4020 | <br>Completed Table: "', $table, '".'; |
| 4021 | + } |
|
| 3825 | 4022 | |
| 3826 | 4023 | echo ' |
| 3827 | 4024 | <h3 id="current_tab_div">Current Table: "<span id="current_table">', $upcontext['cur_table_name'], '</span>"</h3> |
@@ -3858,12 +4055,13 @@ discard block |
||
| 3858 | 4055 | updateStepProgress(iTableNum, ', $upcontext['table_count'], ', ', $upcontext['step_weight'] * ((100 - $upcontext['step_progress']) / 100), ');'; |
| 3859 | 4056 | |
| 3860 | 4057 | // If debug flood the screen. |
| 3861 | - if ($is_debug) |
|
| 3862 | - echo ' |
|
| 4058 | + if ($is_debug) { |
|
| 4059 | + echo ' |
|
| 3863 | 4060 | setOuterHTML(document.getElementById(\'debuginfo\'), \'<br>Completed Table: "\' + sCompletedTableName + \'".<span id="debuginfo"><\' + \'/span>\'); |
| 3864 | 4061 | |
| 3865 | 4062 | if (document.getElementById(\'debug_section\').scrollHeight) |
| 3866 | 4063 | document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight'; |
| 4064 | + } |
|
| 3867 | 4065 | |
| 3868 | 4066 | echo ' |
| 3869 | 4067 | // Get the next update... |
@@ -3896,8 +4094,9 @@ discard block |
||
| 3896 | 4094 | { |
| 3897 | 4095 | global $upcontext, $support_js, $is_debug, $timeLimitThreshold; |
| 3898 | 4096 | |
| 3899 | - if (empty($is_debug) && !empty($upcontext['upgrade_status']['debug'])) |
|
| 3900 | - $is_debug = true; |
|
| 4097 | + if (empty($is_debug) && !empty($upcontext['upgrade_status']['debug'])) { |
|
| 4098 | + $is_debug = true; |
|
| 4099 | + } |
|
| 3901 | 4100 | |
| 3902 | 4101 | echo ' |
| 3903 | 4102 | <h3>Executing database changes</h3> |
@@ -3912,8 +4111,9 @@ discard block |
||
| 3912 | 4111 | { |
| 3913 | 4112 | foreach ($upcontext['actioned_items'] as $num => $item) |
| 3914 | 4113 | { |
| 3915 | - if ($num != 0) |
|
| 3916 | - echo ' Successful!'; |
|
| 4114 | + if ($num != 0) { |
|
| 4115 | + echo ' Successful!'; |
|
| 4116 | + } |
|
| 3917 | 4117 | echo '<br>' . $item; |
| 3918 | 4118 | } |
| 3919 | 4119 | if (!empty($upcontext['changes_complete'])) |
@@ -3926,28 +4126,32 @@ discard block |
||
| 3926 | 4126 | $seconds = intval($active % 60); |
| 3927 | 4127 | |
| 3928 | 4128 | $totalTime = ''; |
| 3929 | - if ($hours > 0) |
|
| 3930 | - $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 3931 | - if ($minutes > 0) |
|
| 3932 | - $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 3933 | - if ($seconds > 0) |
|
| 3934 | - $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 4129 | + if ($hours > 0) { |
|
| 4130 | + $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 4131 | + } |
|
| 4132 | + if ($minutes > 0) { |
|
| 4133 | + $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 4134 | + } |
|
| 4135 | + if ($seconds > 0) { |
|
| 4136 | + $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 4137 | + } |
|
| 3935 | 4138 | } |
| 3936 | 4139 | |
| 3937 | - if ($is_debug && !empty($totalTime)) |
|
| 3938 | - echo ' Successful! Completed in ', $totalTime, '<br><br>'; |
|
| 3939 | - else |
|
| 3940 | - echo ' Successful!<br><br>'; |
|
| 4140 | + if ($is_debug && !empty($totalTime)) { |
|
| 4141 | + echo ' Successful! Completed in ', $totalTime, '<br><br>'; |
|
| 4142 | + } else { |
|
| 4143 | + echo ' Successful!<br><br>'; |
|
| 4144 | + } |
|
| 3941 | 4145 | |
| 3942 | 4146 | echo '<span id="commess" style="font-weight: bold;">1 Database Updates Complete! Click Continue to Proceed.</span><br>'; |
| 3943 | 4147 | } |
| 3944 | - } |
|
| 3945 | - else |
|
| 4148 | + } else |
|
| 3946 | 4149 | { |
| 3947 | 4150 | // Tell them how many files we have in total. |
| 3948 | - if ($upcontext['file_count'] > 1) |
|
| 3949 | - echo ' |
|
| 4151 | + if ($upcontext['file_count'] > 1) { |
|
| 4152 | + echo ' |
|
| 3950 | 4153 | <strong id="info1">Executing upgrade script <span id="file_done">', $upcontext['cur_file_num'], '</span> of ', $upcontext['file_count'], '.</strong>'; |
| 4154 | + } |
|
| 3951 | 4155 | |
| 3952 | 4156 | echo ' |
| 3953 | 4157 | <h3 id="info2"><strong>Executing:</strong> "<span id="cur_item_name">', $upcontext['current_item_name'], '</span>" (<span id="item_num">', $upcontext['current_item_num'], '</span> of <span id="total_items"><span id="item_count">', $upcontext['total_items'], '</span>', $upcontext['file_count'] > 1 ? ' - of this script' : '', ')</span></h3> |
@@ -3963,19 +4167,23 @@ discard block |
||
| 3963 | 4167 | $seconds = intval($active % 60); |
| 3964 | 4168 | |
| 3965 | 4169 | $totalTime = ''; |
| 3966 | - if ($hours > 0) |
|
| 3967 | - $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 3968 | - if ($minutes > 0) |
|
| 3969 | - $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 3970 | - if ($seconds > 0) |
|
| 3971 | - $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 4170 | + if ($hours > 0) { |
|
| 4171 | + $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 4172 | + } |
|
| 4173 | + if ($minutes > 0) { |
|
| 4174 | + $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 4175 | + } |
|
| 4176 | + if ($seconds > 0) { |
|
| 4177 | + $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 4178 | + } |
|
| 3972 | 4179 | } |
| 3973 | 4180 | |
| 3974 | 4181 | echo ' |
| 3975 | 4182 | <br><span id="upgradeCompleted">'; |
| 3976 | 4183 | |
| 3977 | - if (!empty($totalTime)) |
|
| 3978 | - echo 'Completed in ', $totalTime, '<br>'; |
|
| 4184 | + if (!empty($totalTime)) { |
|
| 4185 | + echo 'Completed in ', $totalTime, '<br>'; |
|
| 4186 | + } |
|
| 3979 | 4187 | |
| 3980 | 4188 | echo '</span> |
| 3981 | 4189 | <div id="debug_section" style="height: 117px; overflow: auto;"> |
@@ -4012,9 +4220,10 @@ discard block |
||
| 4012 | 4220 | var getData = ""; |
| 4013 | 4221 | var debugItems = ', $upcontext['debug_items'], ';'; |
| 4014 | 4222 | |
| 4015 | - if ($is_debug) |
|
| 4016 | - echo ' |
|
| 4223 | + if ($is_debug) { |
|
| 4224 | + echo ' |
|
| 4017 | 4225 | var upgradeStartTime = ' . $upcontext['started'] . ';'; |
| 4226 | + } |
|
| 4018 | 4227 | |
| 4019 | 4228 | echo ' |
| 4020 | 4229 | function getNextItem() |
@@ -4054,9 +4263,10 @@ discard block |
||
| 4054 | 4263 | document.getElementById("error_block").style.display = ""; |
| 4055 | 4264 | setInnerHTML(document.getElementById("error_message"), "Error retrieving information on step: " + (sDebugName == "" ? sLastString : sDebugName));'; |
| 4056 | 4265 | |
| 4057 | - if ($is_debug) |
|
| 4058 | - echo ' |
|
| 4266 | + if ($is_debug) { |
|
| 4267 | + echo ' |
|
| 4059 | 4268 | setOuterHTML(document.getElementById(\'debuginfo\'), \'<span style="color: red;">failed<\' + \'/span><span id="debuginfo"><\' + \'/span>\');'; |
| 4269 | + } |
|
| 4060 | 4270 | |
| 4061 | 4271 | echo ' |
| 4062 | 4272 | } |
@@ -4077,9 +4287,10 @@ discard block |
||
| 4077 | 4287 | document.getElementById("error_block").style.display = ""; |
| 4078 | 4288 | setInnerHTML(document.getElementById("error_message"), "Upgrade script appears to be going into a loop - step: " + sDebugName);'; |
| 4079 | 4289 | |
| 4080 | - if ($is_debug) |
|
| 4081 | - echo ' |
|
| 4290 | + if ($is_debug) { |
|
| 4291 | + echo ' |
|
| 4082 | 4292 | setOuterHTML(document.getElementById(\'debuginfo\'), \'<span style="color: red;">failed<\' + \'/span><span id="debuginfo"><\' + \'/span>\');'; |
| 4293 | + } |
|
| 4083 | 4294 | |
| 4084 | 4295 | echo ' |
| 4085 | 4296 | } |
@@ -4138,8 +4349,8 @@ discard block |
||
| 4138 | 4349 | if (bIsComplete && iDebugNum == -1 && curFile >= ', $upcontext['file_count'], ') |
| 4139 | 4350 | {'; |
| 4140 | 4351 | |
| 4141 | - if ($is_debug) |
|
| 4142 | - echo ' |
|
| 4352 | + if ($is_debug) { |
|
| 4353 | + echo ' |
|
| 4143 | 4354 | document.getElementById(\'debug_section\').style.display = "none"; |
| 4144 | 4355 | |
| 4145 | 4356 | var upgradeFinishedTime = parseInt(oXMLDoc.getElementsByTagName("curtime")[0].childNodes[0].nodeValue); |
@@ -4157,6 +4368,7 @@ discard block |
||
| 4157 | 4368 | totalTime = totalTime + diffSeconds + " second" + (diffSeconds > 1 ? "s" : ""); |
| 4158 | 4369 | |
| 4159 | 4370 | setInnerHTML(document.getElementById("upgradeCompleted"), "Completed in " + totalTime);'; |
| 4371 | + } |
|
| 4160 | 4372 | |
| 4161 | 4373 | echo ' |
| 4162 | 4374 | |
@@ -4164,9 +4376,10 @@ discard block |
||
| 4164 | 4376 | document.getElementById(\'contbutt\').disabled = 0; |
| 4165 | 4377 | document.getElementById(\'database_done\').value = 1;'; |
| 4166 | 4378 | |
| 4167 | - if ($upcontext['file_count'] > 1) |
|
| 4168 | - echo ' |
|
| 4379 | + if ($upcontext['file_count'] > 1) { |
|
| 4380 | + echo ' |
|
| 4169 | 4381 | document.getElementById(\'info1\').style.display = "none";'; |
| 4382 | + } |
|
| 4170 | 4383 | |
| 4171 | 4384 | echo ' |
| 4172 | 4385 | document.getElementById(\'info2\').style.display = "none"; |
@@ -4179,9 +4392,10 @@ discard block |
||
| 4179 | 4392 | lastItem = 0; |
| 4180 | 4393 | prevFile = curFile;'; |
| 4181 | 4394 | |
| 4182 | - if ($is_debug) |
|
| 4183 | - echo ' |
|
| 4395 | + if ($is_debug) { |
|
| 4396 | + echo ' |
|
| 4184 | 4397 | setOuterHTML(document.getElementById(\'debuginfo\'), \'Moving to next script file...done<br><span id="debuginfo"><\' + \'/span>\');'; |
| 4398 | + } |
|
| 4185 | 4399 | |
| 4186 | 4400 | echo ' |
| 4187 | 4401 | getNextItem(); |
@@ -4189,8 +4403,8 @@ discard block |
||
| 4189 | 4403 | }'; |
| 4190 | 4404 | |
| 4191 | 4405 | // If debug scroll the screen. |
| 4192 | - if ($is_debug) |
|
| 4193 | - echo ' |
|
| 4406 | + if ($is_debug) { |
|
| 4407 | + echo ' |
|
| 4194 | 4408 | if (iLastSubStepProgress == -1) |
| 4195 | 4409 | { |
| 4196 | 4410 | // Give it consistent dots. |
@@ -4209,6 +4423,7 @@ discard block |
||
| 4209 | 4423 | |
| 4210 | 4424 | if (document.getElementById(\'debug_section\').scrollHeight) |
| 4211 | 4425 | document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight'; |
| 4426 | + } |
|
| 4212 | 4427 | |
| 4213 | 4428 | echo ' |
| 4214 | 4429 | // Update the page. |
@@ -4269,9 +4484,10 @@ discard block |
||
| 4269 | 4484 | }'; |
| 4270 | 4485 | |
| 4271 | 4486 | // Start things off assuming we've not errored. |
| 4272 | - if (empty($upcontext['error_message'])) |
|
| 4273 | - echo ' |
|
| 4487 | + if (empty($upcontext['error_message'])) { |
|
| 4488 | + echo ' |
|
| 4274 | 4489 | getNextItem();'; |
| 4490 | + } |
|
| 4275 | 4491 | |
| 4276 | 4492 | echo ' |
| 4277 | 4493 | //# sourceURL=dynamicScript-dbch.js |
@@ -4289,18 +4505,21 @@ discard block |
||
| 4289 | 4505 | <item num="', $upcontext['current_item_num'], '">', $upcontext['current_item_name'], '</item> |
| 4290 | 4506 | <debug num="', $upcontext['current_debug_item_num'], '" percent="', isset($upcontext['substep_progress']) ? $upcontext['substep_progress'] : '-1', '" complete="', empty($upcontext['completed_step']) ? 0 : 1, '">', $upcontext['current_debug_item_name'], '</debug>'; |
| 4291 | 4507 | |
| 4292 | - if (!empty($upcontext['error_message'])) |
|
| 4293 | - echo ' |
|
| 4508 | + if (!empty($upcontext['error_message'])) { |
|
| 4509 | + echo ' |
|
| 4294 | 4510 | <error>', $upcontext['error_message'], '</error>'; |
| 4511 | + } |
|
| 4295 | 4512 | |
| 4296 | - if (!empty($upcontext['error_string'])) |
|
| 4297 | - echo ' |
|
| 4513 | + if (!empty($upcontext['error_string'])) { |
|
| 4514 | + echo ' |
|
| 4298 | 4515 | <sql>', $upcontext['error_string'], '</sql>'; |
| 4516 | + } |
|
| 4299 | 4517 | |
| 4300 | - if ($is_debug) |
|
| 4301 | - echo ' |
|
| 4518 | + if ($is_debug) { |
|
| 4519 | + echo ' |
|
| 4302 | 4520 | <curtime>', time(), '</curtime>'; |
| 4303 | -} |
|
| 4521 | + } |
|
| 4522 | + } |
|
| 4304 | 4523 | |
| 4305 | 4524 | // Template for the UTF-8 conversion step. Basically a copy of the backup stuff with slight modifications.... |
| 4306 | 4525 | function template_convert_utf8() |
@@ -4319,18 +4538,20 @@ discard block |
||
| 4319 | 4538 | </div>'; |
| 4320 | 4539 | |
| 4321 | 4540 | // Done any tables so far? |
| 4322 | - if (!empty($upcontext['previous_tables'])) |
|
| 4323 | - foreach ($upcontext['previous_tables'] as $table) |
|
| 4541 | + if (!empty($upcontext['previous_tables'])) { |
|
| 4542 | + foreach ($upcontext['previous_tables'] as $table) |
|
| 4324 | 4543 | echo ' |
| 4325 | 4544 | <br>Completed Table: "', $table, '".'; |
| 4545 | + } |
|
| 4326 | 4546 | |
| 4327 | 4547 | echo ' |
| 4328 | 4548 | <h3 id="current_tab_div">Current Table: "<span id="current_table">', $upcontext['cur_table_name'], '</span>"</h3>'; |
| 4329 | 4549 | |
| 4330 | 4550 | // If we dropped their index, let's let them know |
| 4331 | - if ($upcontext['cur_table_num'] == $upcontext['table_count'] && $upcontext['dropping_index']) |
|
| 4332 | - echo ' |
|
| 4551 | + if ($upcontext['cur_table_num'] == $upcontext['table_count'] && $upcontext['dropping_index']) { |
|
| 4552 | + echo ' |
|
| 4333 | 4553 | <br><span style="display:inline;">Please note that your fulltext index was dropped to facilitate the conversion and will need to be recreated.</span>'; |
| 4554 | + } |
|
| 4334 | 4555 | |
| 4335 | 4556 | echo ' |
| 4336 | 4557 | <br><span id="commess" style="font-weight: bold; display: ', $upcontext['cur_table_num'] == $upcontext['table_count'] ? 'inline' : 'none', ';">Conversion Complete! Click Continue to Proceed.</span>'; |
@@ -4366,12 +4587,13 @@ discard block |
||
| 4366 | 4587 | updateStepProgress(iTableNum, ', $upcontext['table_count'], ', ', $upcontext['step_weight'] * ((100 - $upcontext['step_progress']) / 100), ');'; |
| 4367 | 4588 | |
| 4368 | 4589 | // If debug flood the screen. |
| 4369 | - if ($is_debug) |
|
| 4370 | - echo ' |
|
| 4590 | + if ($is_debug) { |
|
| 4591 | + echo ' |
|
| 4371 | 4592 | setOuterHTML(document.getElementById(\'debuginfo\'), \'<br>Completed Table: "\' + sCompletedTableName + \'".<span id="debuginfo"><\' + \'/span>\'); |
| 4372 | 4593 | |
| 4373 | 4594 | if (document.getElementById(\'debug_section\').scrollHeight) |
| 4374 | 4595 | document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight'; |
| 4596 | + } |
|
| 4375 | 4597 | |
| 4376 | 4598 | echo ' |
| 4377 | 4599 | // Get the next update... |
@@ -4416,19 +4638,21 @@ discard block |
||
| 4416 | 4638 | </div>'; |
| 4417 | 4639 | |
| 4418 | 4640 | // Dont any tables so far? |
| 4419 | - if (!empty($upcontext['previous_tables'])) |
|
| 4420 | - foreach ($upcontext['previous_tables'] as $table) |
|
| 4641 | + if (!empty($upcontext['previous_tables'])) { |
|
| 4642 | + foreach ($upcontext['previous_tables'] as $table) |
|
| 4421 | 4643 | echo ' |
| 4422 | 4644 | <br>Completed Table: "', $table, '".'; |
| 4645 | + } |
|
| 4423 | 4646 | |
| 4424 | 4647 | echo ' |
| 4425 | 4648 | <h3 id="current_tab_div">Current Table: "<span id="current_table">', $upcontext['cur_table_name'], '</span>"</h3> |
| 4426 | 4649 | <br><span id="commess" style="font-weight: bold; display: ', $upcontext['cur_table_num'] == $upcontext['table_count'] ? 'inline' : 'none', ';">Convert to JSON Complete! Click Continue to Proceed.</span>'; |
| 4427 | 4650 | |
| 4428 | 4651 | // Try to make sure substep was reset. |
| 4429 | - if ($upcontext['cur_table_num'] == $upcontext['table_count']) |
|
| 4430 | - echo ' |
|
| 4652 | + if ($upcontext['cur_table_num'] == $upcontext['table_count']) { |
|
| 4653 | + echo ' |
|
| 4431 | 4654 | <input type="hidden" name="substep" id="substep" value="0">'; |
| 4655 | + } |
|
| 4432 | 4656 | |
| 4433 | 4657 | // Continue please! |
| 4434 | 4658 | $upcontext['continue'] = $support_js ? 2 : 1; |
@@ -4461,12 +4685,13 @@ discard block |
||
| 4461 | 4685 | updateStepProgress(iTableNum, ', $upcontext['table_count'], ', ', $upcontext['step_weight'] * ((100 - $upcontext['step_progress']) / 100), ');'; |
| 4462 | 4686 | |
| 4463 | 4687 | // If debug flood the screen. |
| 4464 | - if ($is_debug) |
|
| 4465 | - echo ' |
|
| 4688 | + if ($is_debug) { |
|
| 4689 | + echo ' |
|
| 4466 | 4690 | setOuterHTML(document.getElementById(\'debuginfo\'), \'<br>Completed Table: "\' + sCompletedTableName + \'".<span id="debuginfo"><\' + \'/span>\'); |
| 4467 | 4691 | |
| 4468 | 4692 | if (document.getElementById(\'debug_section\').scrollHeight) |
| 4469 | 4693 | document.getElementById(\'debug_section\').scrollTop = document.getElementById(\'debug_section\').scrollHeight'; |
| 4694 | + } |
|
| 4470 | 4695 | |
| 4471 | 4696 | echo ' |
| 4472 | 4697 | // Get the next update... |
@@ -4502,8 +4727,8 @@ discard block |
||
| 4502 | 4727 | <h3>That wasn\'t so hard, was it? Now you are ready to use <a href="', $boardurl, '/index.php">your installation of SMF</a>. Hope you like it!</h3> |
| 4503 | 4728 | <form action="', $boardurl, '/index.php">'; |
| 4504 | 4729 | |
| 4505 | - if (!empty($upcontext['can_delete_script'])) |
|
| 4506 | - echo ' |
|
| 4730 | + if (!empty($upcontext['can_delete_script'])) { |
|
| 4731 | + echo ' |
|
| 4507 | 4732 | <label for="delete_self"><input type="checkbox" id="delete_self" onclick="doTheDelete(this);" class="input_check"> Delete upgrade.php and its data files now</label> <em>(doesn\'t work on all servers).</em> |
| 4508 | 4733 | <script> |
| 4509 | 4734 | function doTheDelete(theCheck) |
@@ -4515,6 +4740,7 @@ discard block |
||
| 4515 | 4740 | } |
| 4516 | 4741 | </script> |
| 4517 | 4742 | <img src="', $settings['default_theme_url'], '/images/blank.png" alt="" id="delete_upgrader"><br>'; |
| 4743 | + } |
|
| 4518 | 4744 | |
| 4519 | 4745 | $active = time() - $upcontext['started']; |
| 4520 | 4746 | $hours = floor($active / 3600); |
@@ -4524,16 +4750,20 @@ discard block |
||
| 4524 | 4750 | if ($is_debug) |
| 4525 | 4751 | { |
| 4526 | 4752 | $totalTime = ''; |
| 4527 | - if ($hours > 0) |
|
| 4528 | - $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 4529 | - if ($minutes > 0) |
|
| 4530 | - $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 4531 | - if ($seconds > 0) |
|
| 4532 | - $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 4753 | + if ($hours > 0) { |
|
| 4754 | + $totalTime .= $hours . ' hour' . ($hours > 1 ? 's' : '') . ' '; |
|
| 4755 | + } |
|
| 4756 | + if ($minutes > 0) { |
|
| 4757 | + $totalTime .= $minutes . ' minute' . ($minutes > 1 ? 's' : '') . ' '; |
|
| 4758 | + } |
|
| 4759 | + if ($seconds > 0) { |
|
| 4760 | + $totalTime .= $seconds . ' second' . ($seconds > 1 ? 's' : '') . ' '; |
|
| 4761 | + } |
|
| 4533 | 4762 | } |
| 4534 | 4763 | |
| 4535 | - if ($is_debug && !empty($totalTime)) |
|
| 4536 | - echo '<br> Upgrade completed in ', $totalTime, '<br><br>'; |
|
| 4764 | + if ($is_debug && !empty($totalTime)) { |
|
| 4765 | + echo '<br> Upgrade completed in ', $totalTime, '<br><br>'; |
|
| 4766 | + } |
|
| 4537 | 4767 | |
| 4538 | 4768 | echo '<br> |
| 4539 | 4769 | If you had any problems with this upgrade, or have any problems using SMF, please don\'t hesitate to <a href="https://www.simplemachines.org/community/index.php">look to us for assistance</a>.<br> |
@@ -4560,8 +4790,9 @@ discard block |
||
| 4560 | 4790 | |
| 4561 | 4791 | $current_substep = $_GET['substep']; |
| 4562 | 4792 | |
| 4563 | - if (empty($_GET['a'])) |
|
| 4564 | - $_GET['a'] = 0; |
|
| 4793 | + if (empty($_GET['a'])) { |
|
| 4794 | + $_GET['a'] = 0; |
|
| 4795 | + } |
|
| 4565 | 4796 | $step_progress['name'] = 'Converting ips'; |
| 4566 | 4797 | $step_progress['current'] = $_GET['a']; |
| 4567 | 4798 | |
@@ -4604,16 +4835,19 @@ discard block |
||
| 4604 | 4835 | 'empty' => '', |
| 4605 | 4836 | 'limit' => $limit, |
| 4606 | 4837 | )); |
| 4607 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 4608 | - $arIp[] = $row[$oldCol]; |
|
| 4838 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 4839 | + $arIp[] = $row[$oldCol]; |
|
| 4840 | + } |
|
| 4609 | 4841 | $smcFunc['db_free_result']($request); |
| 4610 | 4842 | |
| 4611 | 4843 | // Special case, null ip could keep us in a loop. |
| 4612 | - if (is_null($arIp[0])) |
|
| 4613 | - unset($arIp[0]); |
|
| 4844 | + if (is_null($arIp[0])) { |
|
| 4845 | + unset($arIp[0]); |
|
| 4846 | + } |
|
| 4614 | 4847 | |
| 4615 | - if (empty($arIp)) |
|
| 4616 | - $is_done = true; |
|
| 4848 | + if (empty($arIp)) { |
|
| 4849 | + $is_done = true; |
|
| 4850 | + } |
|
| 4617 | 4851 | |
| 4618 | 4852 | $updates = array(); |
| 4619 | 4853 | $cases = array(); |
@@ -4622,16 +4856,18 @@ discard block |
||
| 4622 | 4856 | { |
| 4623 | 4857 | $arIp[$i] = trim($arIp[$i]); |
| 4624 | 4858 | |
| 4625 | - if (empty($arIp[$i])) |
|
| 4626 | - continue; |
|
| 4859 | + if (empty($arIp[$i])) { |
|
| 4860 | + continue; |
|
| 4861 | + } |
|
| 4627 | 4862 | |
| 4628 | 4863 | $updates['ip' . $i] = $arIp[$i]; |
| 4629 | 4864 | $cases[$arIp[$i]] = 'WHEN ' . $oldCol . ' = {string:ip' . $i . '} THEN {inet:ip' . $i . '}'; |
| 4630 | 4865 | |
| 4631 | 4866 | if ($setSize > 0 && $i % $setSize === 0) |
| 4632 | 4867 | { |
| 4633 | - if (count($updates) == 1) |
|
| 4634 | - continue; |
|
| 4868 | + if (count($updates) == 1) { |
|
| 4869 | + continue; |
|
| 4870 | + } |
|
| 4635 | 4871 | |
| 4636 | 4872 | $updates['whereSet'] = array_values($updates); |
| 4637 | 4873 | $smcFunc['db_query']('', ' |
@@ -4665,8 +4901,7 @@ discard block |
||
| 4665 | 4901 | 'ip' => $ip |
| 4666 | 4902 | )); |
| 4667 | 4903 | } |
| 4668 | - } |
|
| 4669 | - else |
|
| 4904 | + } else |
|
| 4670 | 4905 | { |
| 4671 | 4906 | $updates['whereSet'] = array_values($updates); |
| 4672 | 4907 | $smcFunc['db_query']('', ' |
@@ -4680,9 +4915,9 @@ discard block |
||
| 4680 | 4915 | $updates |
| 4681 | 4916 | ); |
| 4682 | 4917 | } |
| 4918 | + } else { |
|
| 4919 | + $is_done = true; |
|
| 4683 | 4920 | } |
| 4684 | - else |
|
| 4685 | - $is_done = true; |
|
| 4686 | 4921 | |
| 4687 | 4922 | $_GET['a'] += $limit; |
| 4688 | 4923 | $step_progress['current'] = $_GET['a']; |
@@ -4708,10 +4943,11 @@ discard block |
||
| 4708 | 4943 | |
| 4709 | 4944 | $columns = $smcFunc['db_list_columns']($targetTable, true); |
| 4710 | 4945 | |
| 4711 | - if (isset($columns[$column])) |
|
| 4712 | - return $columns[$column]; |
|
| 4713 | - else |
|
| 4714 | - return null; |
|
| 4715 | -} |
|
| 4946 | + if (isset($columns[$column])) { |
|
| 4947 | + return $columns[$column]; |
|
| 4948 | + } else { |
|
| 4949 | + return null; |
|
| 4950 | + } |
|
| 4951 | + } |
|
| 4716 | 4952 | |
| 4717 | 4953 | ?> |
| 4718 | 4954 | \ No newline at end of file |
