obExit_cron() - Code Metrics - Inspection of "Changes 'Project Manager' credits string to 'Proje..." - SimpleMachines/SMF2.1 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — release-2.1 ( 6a0187...ca9e9e )

by Jon

created 2022-02-05 20:16 UTC

obExit_cron() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
c	0
b	0
f	0
nop	0
dl	0
loc	8
rs	10
nc	2

<?php

/**
 * This is a slightly strange file. It is not designed to ever be run directly from within SMF's
 * conventional running, but called externally to facilitate background tasks. It can be called
 * either directly or via cron, and in either case will completely ignore anything supplied
 * via command line, or $_GET, $_POST, $_COOKIE etc. because those things should never affect the
 * running of this script.
 *
 * Because of the way this runs, etc. we do need some of SMF but not everything to try to keep this
 * running a little bit faster.
 *
 * Simple Machines Forum (SMF)
 *
 * @package SMF
 * @author Simple Machines https://www.simplemachines.org
 * @copyright 2022 Simple Machines and individual contributors
 * @license https://www.simplemachines.org/about/smf/license.php BSD
 *
 * @version 2.1 RC4
 */

define('SMF', 'BACKGROUND');
define('SMF_VERSION', '2.1 RC4');
define('SMF_FULL_VERSION', 'SMF ' . SMF_VERSION);
define('SMF_SOFTWARE_YEAR', '2022');
define('FROM_CLI', empty($_SERVER['REQUEST_METHOD']));

define('JQUERY_VERSION', '3.6.0');
define('POSTGRE_TITLE', 'PostgreSQL');
define('MYSQL_TITLE', 'MySQL');
define('SMF_USER_AGENT', 'Mozilla/5.0 (' . php_uname('s') . ' ' . php_uname('m') . ') AppleWebKit/605.1.15 (KHTML, like Gecko)  SMF/' . strtr(SMF_VERSION, ' ', '.'));

// This one setting is worth bearing in mind. If you are running this from proper cron, make sure you
// don't run this file any more frequently than indicated here. It might turn ugly if you do.
// But on proper cron you can always increase this value provided you don't go beyond max_limit.
define('MAX_CRON_TIME', 10);
// If a task fails for whatever reason it will still be marked as claimed. This is the threshold
// by which if a task has not completed in this time, the task should become available again.
define('MAX_CLAIM_THRESHOLD', 300);

// We're going to want a few globals... these are all set later.
global $maintenance, $msubject, $mmessage, $mbname, $language;
global $boardurl, $boarddir, $sourcedir, $webmaster_email;
global $db_server, $db_name, $db_user, $db_prefix, $db_persist, $db_error_send, $db_last_error;
global $db_connection, $modSettings, $context, $sc, $user_info, $txt;
global $smcFunc, $ssi_db_user, $scripturl, $db_passwd, $cachedir;

if (!defined('TIME_START'))
	define('TIME_START', microtime(true));

// Just being safe...
foreach (array('db_character_set', 'cachedir') as $variable)
	if (isset($GLOBALS[$variable]))
		unset($GLOBALS[$variable]);

// Get the forum's settings for database and file paths.
require_once(dirname(__FILE__) . '/Settings.php');

// Make absolutely sure the cache directory is defined and writable.
if (empty($cachedir) || !is_dir($cachedir) || !is_writable($cachedir))
{
	if (is_dir($boarddir . '/cache') && is_writable($boarddir . '/cache'))
		$cachedir = $boarddir . '/cache';
	else
	{
		$cachedir = sys_get_temp_dir() . '/smf_cache_' . md5($boarddir);
		@mkdir($cachedir, 0750);
	}
}

// Don't do john didley if the forum's been shut down completely.
if ($maintenance == 2)
	die($mmessage);

// Fix for using the current directory as a path.
if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.')
	$sourcedir = dirname(__FILE__) . substr($sourcedir, 1);

// Have we already turned this off? If so, exist gracefully.
if (file_exists($cachedir . '/cron.lock'))
	obExit_cron();

// Before we go any further, if this is not a CLI request, we need to do some checking.
if (!FROM_CLI)
{
	// When using sub-domains with SSI and ssi_themes set, browsers will receive a "Access-Control-Allow-Origin" error.
	// * is not ideal but the best method to preventing this from occurring.
	header('Access-Control-Allow-Origin: *');

	// We will clean up $_GET shortly. But we want to this ASAP.
	$ts = isset($_GET['ts']) ? (int) $_GET['ts'] : 0;
	if ($ts <= 0 || $ts % 15 != 0 || time() - $ts < 0 || time() - $ts > 20)
		obExit_cron();
}

else
	$_SERVER['SERVER_PROTOCOL'] = 'HTTP/1.0';

// Load the most important includes. In general, a background should be loading its own dependencies.
require_once($sourcedir . '/Errors.php');
require_once($sourcedir . '/Load.php');
require_once($sourcedir . '/Security.php');
require_once($sourcedir . '/Subs.php');

// Create a variable to store some SMF specific functions in.
$smcFunc = array();

// This is our general bootstrap, a la SSI.php but with a few differences.
unset ($db_show_debug);
loadDatabase();
reloadSettings();

// Just in case there's a problem...
set_error_handler('smf_error_handler_cron');
$sc = '';
$_SERVER['QUERY_STRING'] = '';
$_SERVER['REQUEST_URL'] = FROM_CLI ? 'CLI cron.php' : $boardurl . '/cron.php';

// Now 'clean the request' (or more accurately, ignore everything we're not going to use)
cleanRequest_cron();

// At this point we could reseed the RNG but I don't think we need to risk it being seeded *even more*.
// Meanwhile, time we got on with the real business here.
while ($task_details = fetch_task())
{
	$result = perform_task($task_details);
	if ($result)
	{
		$smcFunc['db_query']('', '
			DELETE FROM {db_prefix}background_tasks
			WHERE id_task = {int:task}',
			array(
				'task' => $task_details['id_task'],
			)
		);
	}
}
obExit_cron();
exit;

/**
 * The heart of this cron handler...
 *
 * @return bool|array False if there's nothing to do or an array of info about the task
 */
function fetch_task()
{
	global $smcFunc;

	// Check we haven't run over our time limit.
	if (microtime(true) - TIME_START > MAX_CRON_TIME)
		return false;

	// Try to find a task. Specifically, try to find one that hasn't been claimed previously, or failing that,
	// a task that was claimed but failed for whatever reason and failed long enough ago. We should not care
	// what task it is, merely that it is one in the queue, the order is irrelevant.
	$request = $smcFunc['db_query']('', '
		SELECT id_task, task_file, task_class, task_data, claimed_time
		FROM {db_prefix}background_tasks
		WHERE claimed_time < {int:claim_limit}
		LIMIT 1',
		array(
			'claim_limit' => time() - MAX_CLAIM_THRESHOLD,
		)
	);
	if ($row = $smcFunc['db_fetch_assoc']($request))
	{
		// We found one. Let's try and claim it immediately.
		$smcFunc['db_free_result']($request);
		$smcFunc['db_query']('', '
			UPDATE {db_prefix}background_tasks
			SET claimed_time = {int:new_claimed}
			WHERE id_task = {int:task}
				AND claimed_time = {int:old_claimed}',
			array(
				'new_claimed' => time(),
				'task' => $row['id_task'],
				'old_claimed' => $row['claimed_time'],
			)
		);
		// Could we claim it? If so, return it back.
		if ($smcFunc['db_affected_rows']() != 0)
		{
			// Update the time and go back.
			$row['claimed_time'] = time();
			return $row;
		}
		else
		{
			// Uh oh, we just missed it. Try to claim another one, and let it fall through if there aren't any.
			return fetch_task();
		}
	}
	else
	{
		// No dice. Clean up and go home.
		$smcFunc['db_free_result']($request);
		return false;
	}
}

/**
 * This actually handles the task
 *
 * @param array $task_details An array of info about the task
 * @return bool|void True if the task is invalid; otherwise calls the function to execute the task
 */
function perform_task($task_details)
{
	global $smcFunc, $sourcedir, $boarddir;

	// This indicates the file to load.
	if (!empty($task_details['task_file']))
	{
		$include = strtr(trim($task_details['task_file']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
		if (file_exists($include))
			require_once($include);
	}

	if (empty($task_details['task_class']))
	{
		// This would be nice to translate but the language files aren't loaded for any specific language.
		log_error('Invalid background task specified (no class, ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
		return true; // So we clear it from the queue.
	}

	// All background tasks need to be classes.
	elseif (class_exists($task_details['task_class']) && is_subclass_of($task_details['task_class'], 'SMF_BackgroundTask'))
	{
		$details = empty($task_details['task_data']) ? array() : $smcFunc['json_decode']($task_details['task_data'], true);
		$bgtask = new $task_details['task_class']($details);
		return $bgtask->execute();
	}
	else
	{
		log_error('Invalid background task specified: (class: ' . $task_details['task_class'] . ', ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
		return true; // So we clear it from the queue.
	}
}

// These are all our helper functions that resemble their big brother counterparts. These are not so important.
/**
 * Cleans up the request variables
 *
 * @return void
 */
function cleanRequest_cron()
{
	global $scripturl, $boardurl;

	$scripturl = $boardurl . '/index.php';

	// These keys shouldn't be set...ever.
	if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS']))
		die('Invalid request variable.');


	// Save some memory.. (since we don't use these anyway.)
	unset($GLOBALS['HTTP_POST_VARS'], $GLOBALS['HTTP_POST_VARS']);
	unset($GLOBALS['HTTP_POST_FILES'], $GLOBALS['HTTP_POST_FILES']);
	unset($GLOBALS['_GET'], $GLOBALS['_POST'], $GLOBALS['_REQUEST'], $GLOBALS['_COOKIE'], $GLOBALS['_FILES']);
}

/**
 * The error handling function
 *
 * @param int $error_level One of the PHP error level constants (see )
 * @param string $error_string The error message
 * @param string $file The file where the error occurred
 * @param int $line What line of the specified file the error occurred on
 * @return void
 */
function smf_error_handler_cron($error_level, $error_string, $file, $line)
{
	global $modSettings;

	// Ignore errors that should not be logged.
	if (error_reporting() == 0)
		return;

	$error_type = 'cron';

	log_error($error_level . ': ' . $error_string, $error_type, $file, $line);

	// If this is an E_ERROR or E_USER_ERROR.... die.  Violently so.
	if ($error_level % 255 == E_ERROR)
		die('No direct access...');

}

/**
 * The exit function
 */
function obExit_cron()
{
	if (FROM_CLI)
		die(0);

	else
	{
		header('content-type: image/gif');
		die("\x47\x49\x46\x38\x39\x61\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\x00\x00\x00\x21\xF9\x04\x01\x00\x00\x00\x00\x2C\x00\x00\x00\x00\x01\x00\x01\x00\x00\x02\x02\x44\x01\x00\x3B");
	}
}

// We would like this to be defined, but we don't want to have to load more stuff than necessary.
// Thus we declare it here, and any legitimate background task must implement this.
/**
 * Class SMF_BackgroundTask
 */
abstract class SMF_BackgroundTask
{
	/**
	 * Constants for notification types.
	*/
	const RECEIVE_NOTIFY_EMAIL = 0x02;
	const RECEIVE_NOTIFY_ALERT = 0x01;

	/**
	 * @var array Holds the details for the task
	 */
	protected $_details;

	/**
	 * @var array Temp property to hold the current user info while tasks make use of $user_info
	 */
	private $current_user_info = array();

	/**
	 * The constructor.
	 *
	 * @param array $details The details for the task
	 */
	public function __construct($details)
	{
		global $user_info;

		$this->_details = $details;

		$this->current_user_info = $user_info;
	}

	/**
	 * The function to actually execute a task
	 *
	 * @return mixed
	 */
	abstract public function execute();

	/**
	 * Loads minimal info for the previously loaded user ids
	 *
	 * @param array $user_ids
	 * @return array
	 * @throws Exception
	 */
	public function getMinUserInfo($user_ids = array())
	{
		return loadMinUserInfo($user_ids);
	}

	public function __destruct()
	{
		global $user_info;

		$user_info = $this->current_user_info;
	}
}

?>

1			<?php
2
3			/**
4			* This is a slightly strange file. It is not designed to ever be run directly from within SMF's
5			* conventional running, but called externally to facilitate background tasks. It can be called
6			* either directly or via cron, and in either case will completely ignore anything supplied
7			* via command line, or $_GET, $_POST, $_COOKIE etc. because those things should never affect the
8			* running of this script.
9			*
10			* Because of the way this runs, etc. we do need some of SMF but not everything to try to keep this
11			* running a little bit faster.
12			*
13			* Simple Machines Forum (SMF)
14			*
15			* @package SMF
16			* @author Simple Machines https://www.simplemachines.org
17			* @copyright 2022 Simple Machines and individual contributors
18			* @license https://www.simplemachines.org/about/smf/license.php BSD
19			*
20			* @version 2.1 RC4
21			*/
22
23			define('SMF', 'BACKGROUND');
24			define('SMF_VERSION', '2.1 RC4');
25			define('SMF_FULL_VERSION', 'SMF ' . SMF_VERSION);
26			define('SMF_SOFTWARE_YEAR', '2022');
27			define('FROM_CLI', empty($_SERVER['REQUEST_METHOD']));
28
29			define('JQUERY_VERSION', '3.6.0');
30			define('POSTGRE_TITLE', 'PostgreSQL');
31			define('MYSQL_TITLE', 'MySQL');
32			define('SMF_USER_AGENT', 'Mozilla/5.0 (' . php_uname('s') . ' ' . php_uname('m') . ') AppleWebKit/605.1.15 (KHTML, like Gecko) SMF/' . strtr(SMF_VERSION, ' ', '.'));
33
34			// This one setting is worth bearing in mind. If you are running this from proper cron, make sure you
35			// don't run this file any more frequently than indicated here. It might turn ugly if you do.
36			// But on proper cron you can always increase this value provided you don't go beyond max_limit.
37			define('MAX_CRON_TIME', 10);
38			// If a task fails for whatever reason it will still be marked as claimed. This is the threshold
39			// by which if a task has not completed in this time, the task should become available again.
40			define('MAX_CLAIM_THRESHOLD', 300);
41
42			// We're going to want a few globals... these are all set later.
43			global $maintenance, $msubject, $mmessage, $mbname, $language;
44			global $boardurl, $boarddir, $sourcedir, $webmaster_email;
45			global $db_server, $db_name, $db_user, $db_prefix, $db_persist, $db_error_send, $db_last_error;
46			global $db_connection, $modSettings, $context, $sc, $user_info, $txt;
47			global $smcFunc, $ssi_db_user, $scripturl, $db_passwd, $cachedir;
48
49			if (!defined('TIME_START'))
50			define('TIME_START', microtime(true));
51
52			// Just being safe...
53			foreach (array('db_character_set', 'cachedir') as $variable)
54			if (isset($GLOBALS[$variable]))
55			unset($GLOBALS[$variable]);
56
57			// Get the forum's settings for database and file paths.
58			require_once(dirname(__FILE__) . '/Settings.php');
59
60			// Make absolutely sure the cache directory is defined and writable.
61			if (empty($cachedir) \|\| !is_dir($cachedir) \|\| !is_writable($cachedir))
62			{
63			if (is_dir($boarddir . '/cache') && is_writable($boarddir . '/cache'))
64			$cachedir = $boarddir . '/cache';
65			else
66			{
67			$cachedir = sys_get_temp_dir() . '/smf_cache_' . md5($boarddir);
68			@mkdir($cachedir, 0750);
69			}
70			}
71
72			// Don't do john didley if the forum's been shut down completely.
73			if ($maintenance == 2)
74			die($mmessage);
75
76			// Fix for using the current directory as a path.
77			if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.')
78			$sourcedir = dirname(__FILE__) . substr($sourcedir, 1);
79
80			// Have we already turned this off? If so, exist gracefully.
81			if (file_exists($cachedir . '/cron.lock'))
82			obExit_cron();
83
84			// Before we go any further, if this is not a CLI request, we need to do some checking.
85			if (!FROM_CLI)
86			{
87			// When using sub-domains with SSI and ssi_themes set, browsers will receive a "Access-Control-Allow-Origin" error.
88			// * is not ideal but the best method to preventing this from occurring.
89			header('Access-Control-Allow-Origin: *');
90
91			// We will clean up $_GET shortly. But we want to this ASAP.
92			$ts = isset($_GET['ts']) ? (int) $_GET['ts'] : 0;
93			if ($ts <= 0 \|\| $ts % 15 != 0 \|\| time() - $ts < 0 \|\| time() - $ts > 20)
94			obExit_cron();
95			}
96
97			else
98			$_SERVER['SERVER_PROTOCOL'] = 'HTTP/1.0';
99
100			// Load the most important includes. In general, a background should be loading its own dependencies.
101			require_once($sourcedir . '/Errors.php');
102			require_once($sourcedir . '/Load.php');
103			require_once($sourcedir . '/Security.php');
104			require_once($sourcedir . '/Subs.php');
105
106			// Create a variable to store some SMF specific functions in.
107			$smcFunc = array();
108
109			// This is our general bootstrap, a la SSI.php but with a few differences.
110			unset ($db_show_debug);
111			loadDatabase();
112			reloadSettings();
113
114			// Just in case there's a problem...
115			set_error_handler('smf_error_handler_cron');
116			$sc = '';
117			$_SERVER['QUERY_STRING'] = '';
118			$_SERVER['REQUEST_URL'] = FROM_CLI ? 'CLI cron.php' : $boardurl . '/cron.php';
119
120			// Now 'clean the request' (or more accurately, ignore everything we're not going to use)
121			cleanRequest_cron();
122
123			// At this point we could reseed the RNG but I don't think we need to risk it being seeded even more.
124			// Meanwhile, time we got on with the real business here.
125			while ($task_details = fetch_task())
126			{
127			$result = perform_task($task_details);
128			if ($result)
129			{
130			$smcFunc['db_query']('', '
131			DELETE FROM {db_prefix}background_tasks
132			WHERE id_task = {int:task}',
133			array(
134			'task' => $task_details['id_task'],
135			)
136			);
137			}
138			}
139			obExit_cron();
140			exit;
141
142			/**
143			* The heart of this cron handler...
144			*
145			* @return bool\|array False if there's nothing to do or an array of info about the task
146			*/
147			function fetch_task()
148			{
149			global $smcFunc;
150
151			// Check we haven't run over our time limit.
152			if (microtime(true) - TIME_START > MAX_CRON_TIME)
153			return false;
154
155			// Try to find a task. Specifically, try to find one that hasn't been claimed previously, or failing that,
156			// a task that was claimed but failed for whatever reason and failed long enough ago. We should not care
157			// what task it is, merely that it is one in the queue, the order is irrelevant.
158			$request = $smcFunc['db_query']('', '
159			SELECT id_task, task_file, task_class, task_data, claimed_time
160			FROM {db_prefix}background_tasks
161			WHERE claimed_time < {int:claim_limit}
162			LIMIT 1',
163			array(
164			'claim_limit' => time() - MAX_CLAIM_THRESHOLD,
165			)
166			);
167			if ($row = $smcFunc['db_fetch_assoc']($request))
168			{
169			// We found one. Let's try and claim it immediately.
170			$smcFunc['db_free_result']($request);
171			$smcFunc['db_query']('', '
172			UPDATE {db_prefix}background_tasks
173			SET claimed_time = {int:new_claimed}
174			WHERE id_task = {int:task}
175			AND claimed_time = {int:old_claimed}',
176			array(
177			'new_claimed' => time(),
178			'task' => $row['id_task'],
179			'old_claimed' => $row['claimed_time'],
180			)
181			);
182			// Could we claim it? If so, return it back.
183			if ($smcFunc['db_affected_rows']() != 0)
184			{
185			// Update the time and go back.
186			$row['claimed_time'] = time();
187			return $row;
188			}
189			else
190			{
191			// Uh oh, we just missed it. Try to claim another one, and let it fall through if there aren't any.
192			return fetch_task();
193			}
194			}
195			else
196			{
197			// No dice. Clean up and go home.
198			$smcFunc['db_free_result']($request);
199			return false;
200			}
201			}
202
203			/**
204			* This actually handles the task
205			*
206			* @param array $task_details An array of info about the task
207			* @return bool\|void True if the task is invalid; otherwise calls the function to execute the task
208			*/
209			function perform_task($task_details)
210			{
211			global $smcFunc, $sourcedir, $boarddir;
212
213			// This indicates the file to load.
214			if (!empty($task_details['task_file']))
215			{
216			$include = strtr(trim($task_details['task_file']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
217			if (file_exists($include))
218			require_once($include);
219			}
220
221			if (empty($task_details['task_class']))
222			{
223			// This would be nice to translate but the language files aren't loaded for any specific language.
224			log_error('Invalid background task specified (no class, ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
225			return true; // So we clear it from the queue.
226			}
227
228			// All background tasks need to be classes.
229			elseif (class_exists($task_details['task_class']) && is_subclass_of($task_details['task_class'], 'SMF_BackgroundTask'))
230			{
231			$details = empty($task_details['task_data']) ? array() : $smcFunc['json_decode']($task_details['task_data'], true);
232			$bgtask = new $task_details['task_class']($details);
233			return $bgtask->execute();
234			}
235			else
236			{
237			log_error('Invalid background task specified: (class: ' . $task_details['task_class'] . ', ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
238			return true; // So we clear it from the queue.
239			}
240			}
241
242			// These are all our helper functions that resemble their big brother counterparts. These are not so important.
243			/**
244			* Cleans up the request variables
245			*
246			* @return void
247			*/
248			function cleanRequest_cron()
249			{
250			global $scripturl, $boardurl;
251
252			$scripturl = $boardurl . '/index.php';
253
254			// These keys shouldn't be set...ever.
255			if (isset($_REQUEST['GLOBALS']) \|\| isset($_COOKIE['GLOBALS']))
256			die('Invalid request variable.');
			0 ignored issues – show Best Practice introduced 2018-10-21 22:13 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
257
258			// Save some memory.. (since we don't use these anyway.)
259			unset($GLOBALS['HTTP_POST_VARS'], $GLOBALS['HTTP_POST_VARS']);
260			unset($GLOBALS['HTTP_POST_FILES'], $GLOBALS['HTTP_POST_FILES']);
261			unset($GLOBALS['_GET'], $GLOBALS['_POST'], $GLOBALS['_REQUEST'], $GLOBALS['_COOKIE'], $GLOBALS['_FILES']);
262			}
263
264			/**
265			* The error handling function
266			*
267			* @param int $error_level One of the PHP error level constants (see )
268			* @param string $error_string The error message
269			* @param string $file The file where the error occurred
270			* @param int $line What line of the specified file the error occurred on
271			* @return void
272			*/
273			function smf_error_handler_cron($error_level, $error_string, $file, $line)
274			{
275			global $modSettings;
276
277			// Ignore errors that should not be logged.
278			if (error_reporting() == 0)
279			return;
280
281			$error_type = 'cron';
282
283			log_error($error_level . ': ' . $error_string, $error_type, $file, $line);
284
285			// If this is an E_ERROR or E_USER_ERROR.... die. Violently so.
286			if ($error_level % 255 == E_ERROR)
287			die('No direct access...');
			0 ignored issues – show Best Practice introduced 2018-10-21 22:13 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
288			}
289
290			/**
291			* The exit function
292			*/
293			function obExit_cron()
294			{
295			if (FROM_CLI)
296			die(0);
			0 ignored issues – show Best Practice introduced 2018-10-21 22:13 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
297			else
298			{
299			header('content-type: image/gif');
300			die("\x47\x49\x46\x38\x39\x61\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\x00\x00\x00\x21\xF9\x04\x01\x00\x00\x00\x00\x2C\x00\x00\x00\x00\x01\x00\x01\x00\x00\x02\x02\x44\x01\x00\x3B");
301			}
302			}
303
304			// We would like this to be defined, but we don't want to have to load more stuff than necessary.
305			// Thus we declare it here, and any legitimate background task must implement this.
306			/**
307			* Class SMF_BackgroundTask
308			*/
309			abstract class SMF_BackgroundTask
310			{
311			/**
312			* Constants for notification types.
313			*/
314			const RECEIVE_NOTIFY_EMAIL = 0x02;
315			const RECEIVE_NOTIFY_ALERT = 0x01;
316
317			/**
318			* @var array Holds the details for the task
319			*/
320			protected $_details;
321
322			/**
323			* @var array Temp property to hold the current user info while tasks make use of $user_info
324			*/
325			private $current_user_info = array();
326
327			/**
328			* The constructor.
329			*
330			* @param array $details The details for the task
331			*/
332			public function __construct($details)
333			{
334			global $user_info;
335
336			$this->_details = $details;
337
338			$this->current_user_info = $user_info;
339			}
340
341			/**
342			* The function to actually execute a task
343			*
344			* @return mixed
345			*/
346			abstract public function execute();
347
348			/**
349			* Loads minimal info for the previously loaded user ids
350			*
351			* @param array $user_ids
352			* @return array
353			* @throws Exception
354			*/
355			public function getMinUserInfo($user_ids = array())
356			{
357			return loadMinUserInfo($user_ids);
358			}
359
360			public function __destruct()
361			{
362			global $user_info;
363
364			$user_info = $this->current_user_info;
365			}
366			}
367
368			?>

SimpleMachines / SMF2.1

Push — release-2.1 ( 6a0187...ca9e9e )

obExit_cron() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like