@@ -229,7 +229,7 @@ |
||
| 229 | 229 | //In maintenance mode, only login is allowed and don't show OverlayDiv |
| 230 | 230 | echo ' |
| 231 | 231 | <ul class="floatleft welcome"> |
| 232 | - <li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl. '?action=login', 'return true;'), '</li> |
|
| 232 | + <li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl . '?action=login', 'return true;'), '</li> |
|
| 233 | 233 | </ul>'; |
| 234 | 234 | |
| 235 | 235 | if (!empty($modSettings['userLanguage']) && !empty($context['languages']) && count($context['languages']) > 1) |
@@ -72,9 +72,10 @@ discard block |
||
| 72 | 72 | |
| 73 | 73 | // Allow css/js files to be disable for this specific theme. |
| 74 | 74 | // Add the identifier as an array key. IE array('smf_script'); Some external files might not add identifiers, on those cases SMF uses its filename as reference. |
| 75 | - if (!isset($settings['disable_files'])) |
|
| 76 | - $settings['disable_files'] = array(); |
|
| 77 | -} |
|
| 75 | + if (!isset($settings['disable_files'])) { |
|
| 76 | + $settings['disable_files'] = array(); |
|
| 77 | + } |
|
| 78 | + } |
|
| 78 | 79 | |
| 79 | 80 | /** |
| 80 | 81 | * The main sub template above the content. |
@@ -111,8 +112,9 @@ discard block |
||
| 111 | 112 | echo ' |
| 112 | 113 | <meta'; |
| 113 | 114 | |
| 114 | - foreach ($meta_tag as $meta_key => $meta_value) |
|
| 115 | - echo ' ', $meta_key, '="', $meta_value, '"'; |
|
| 115 | + foreach ($meta_tag as $meta_key => $meta_value) { |
|
| 116 | + echo ' ', $meta_key, '="', $meta_value, '"'; |
|
| 117 | + } |
|
| 116 | 118 | |
| 117 | 119 | echo '>'; |
| 118 | 120 | } |
@@ -123,14 +125,16 @@ discard block |
||
| 123 | 125 | <meta name="theme-color" content="#557EA0">'; |
| 124 | 126 | |
| 125 | 127 | // Please don't index these Mr Robot. |
| 126 | - if (!empty($context['robot_no_index'])) |
|
| 127 | - echo ' |
|
| 128 | + if (!empty($context['robot_no_index'])) { |
|
| 129 | + echo ' |
|
| 128 | 130 | <meta name="robots" content="noindex">'; |
| 131 | + } |
|
| 129 | 132 | |
| 130 | 133 | // Present a canonical url for search engines to prevent duplicate content in their indices. |
| 131 | - if (!empty($context['canonical_url'])) |
|
| 132 | - echo ' |
|
| 134 | + if (!empty($context['canonical_url'])) { |
|
| 135 | + echo ' |
|
| 133 | 136 | <link rel="canonical" href="', $context['canonical_url'], '">'; |
| 137 | + } |
|
| 134 | 138 | |
| 135 | 139 | // Show all the relative links, such as help, search, contents, and the like. |
| 136 | 140 | echo ' |
@@ -139,10 +143,11 @@ discard block |
||
| 139 | 143 | <link rel="search" href="' . $scripturl . '?action=search">' : ''); |
| 140 | 144 | |
| 141 | 145 | // If RSS feeds are enabled, advertise the presence of one. |
| 142 | - if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged'])) |
|
| 143 | - echo ' |
|
| 146 | + if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged'])) { |
|
| 147 | + echo ' |
|
| 144 | 148 | <link rel="alternate feed" type="application/rss+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['rss'], '" href="', $scripturl, '?action=.xml;type=rss2', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '"> |
| 145 | 149 | <link rel="alternate feed" type="application/atom+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['atom'], '" href="', $scripturl, '?action=.xml;type=atom', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '">'; |
| 150 | + } |
|
| 146 | 151 | |
| 147 | 152 | // If we're viewing a topic, these should be the previous and next topics, respectively. |
| 148 | 153 | if (!empty($context['links']['next'])) |
@@ -158,9 +163,10 @@ discard block |
||
| 158 | 163 | } |
| 159 | 164 | |
| 160 | 165 | // If we're in a board, or a topic for that matter, the index will be the board's index. |
| 161 | - if (!empty($context['current_board'])) |
|
| 162 | - echo ' |
|
| 166 | + if (!empty($context['current_board'])) { |
|
| 167 | + echo ' |
|
| 163 | 168 | <link rel="index" href="', $scripturl, '?board=', $context['current_board'], '.0">'; |
| 169 | + } |
|
| 164 | 170 | |
| 165 | 171 | // Output any remaining HTML headers. (from mods, maybe?) |
| 166 | 172 | echo $context['html_headers']; |
@@ -191,8 +197,9 @@ discard block |
||
| 191 | 197 | <ul class="floatleft" id="top_info"> |
| 192 | 198 | <li> |
| 193 | 199 | <a href="', $scripturl, '?action=profile"', !empty($context['self_profile']) ? ' class="active"' : '', ' id="profile_menu_top" onclick="return false;">'; |
| 194 | - if (!empty($context['user']['avatar'])) |
|
| 195 | - echo $context['user']['avatar']['image']; |
|
| 200 | + if (!empty($context['user']['avatar'])) { |
|
| 201 | + echo $context['user']['avatar']['image']; |
|
| 202 | + } |
|
| 196 | 203 | echo $context['user']['name'], '</a> |
| 197 | 204 | <div id="profile_menu" class="top_menu"></div> |
| 198 | 205 | </li>'; |
@@ -220,17 +227,18 @@ discard block |
||
| 220 | 227 | } |
| 221 | 228 | // Otherwise they're a guest. Ask them to either register or login. |
| 222 | 229 | else |
| 223 | - if (empty($maintenance)) |
|
| 224 | - echo ' |
|
| 230 | + if (empty($maintenance)) { |
|
| 231 | + echo ' |
|
| 225 | 232 | <ul class="floatleft welcome"> |
| 226 | 233 | <li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'), '</li> |
| 227 | 234 | </ul>'; |
| 228 | - else |
|
| 229 | - //In maintenance mode, only login is allowed and don't show OverlayDiv |
|
| 235 | + } else { |
|
| 236 | + //In maintenance mode, only login is allowed and don't show OverlayDiv |
|
| 230 | 237 | echo ' |
| 231 | 238 | <ul class="floatleft welcome"> |
| 232 | 239 | <li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl. '?action=login', 'return true;'), '</li> |
| 233 | 240 | </ul>'; |
| 241 | + } |
|
| 234 | 242 | |
| 235 | 243 | if (!empty($modSettings['userLanguage']) && !empty($context['languages']) && count($context['languages']) > 1) |
| 236 | 244 | { |
@@ -238,9 +246,10 @@ discard block |
||
| 238 | 246 | <form id="languages_form" method="get" class="floatright"> |
| 239 | 247 | <select id="language_select" name="language" onchange="this.form.submit()">'; |
| 240 | 248 | |
| 241 | - foreach ($context['languages'] as $language) |
|
| 242 | - echo ' |
|
| 249 | + foreach ($context['languages'] as $language) { |
|
| 250 | + echo ' |
|
| 243 | 251 | <option value="', $language['filename'], '"', isset($context['user']['language']) && $context['user']['language'] == $language['filename'] ? ' selected="selected"' : '', '>', str_replace('-utf8', '', $language['name']), '</option>'; |
| 252 | + } |
|
| 244 | 253 | |
| 245 | 254 | echo ' |
| 246 | 255 | </select> |
@@ -264,31 +273,36 @@ discard block |
||
| 264 | 273 | <option value="all"', ($selected == 'all' ? ' selected' : ''), '>', $txt['search_entireforum'], ' </option>'; |
| 265 | 274 | |
| 266 | 275 | // Can't limit it to a specific topic if we are not in one |
| 267 | - if (!empty($context['current_topic'])) |
|
| 268 | - echo ' |
|
| 276 | + if (!empty($context['current_topic'])) { |
|
| 277 | + echo ' |
|
| 269 | 278 | <option value="topic"', ($selected == 'current_topic' ? ' selected' : ''), '>', $txt['search_thistopic'], '</option>'; |
| 279 | + } |
|
| 270 | 280 | |
| 271 | 281 | // Can't limit it to a specific board if we are not in one |
| 272 | - if (!empty($context['current_board'])) |
|
| 273 | - echo ' |
|
| 282 | + if (!empty($context['current_board'])) { |
|
| 283 | + echo ' |
|
| 274 | 284 | <option value="board"', ($selected == 'current_board' ? ' selected' : ''), '>', $txt['search_thisbrd'], '</option>'; |
| 285 | + } |
|
| 275 | 286 | |
| 276 | 287 | // Can't search for members if we can't see the memberlist |
| 277 | - if (!empty($context['allow_memberlist'])) |
|
| 278 | - echo ' |
|
| 288 | + if (!empty($context['allow_memberlist'])) { |
|
| 289 | + echo ' |
|
| 279 | 290 | <option value="members"', ($selected == 'members' ? ' selected' : ''), '>', $txt['search_members'], ' </option>'; |
| 291 | + } |
|
| 280 | 292 | |
| 281 | 293 | echo ' |
| 282 | 294 | </select>'; |
| 283 | 295 | |
| 284 | 296 | // Search within current topic? |
| 285 | - if (!empty($context['current_topic'])) |
|
| 286 | - echo ' |
|
| 297 | + if (!empty($context['current_topic'])) { |
|
| 298 | + echo ' |
|
| 287 | 299 | <input type="hidden" name="sd_topic" value="', $context['current_topic'], '">'; |
| 300 | + } |
|
| 288 | 301 | // If we're on a certain board, limit it to this board ;). |
| 289 | - elseif (!empty($context['current_board'])) |
|
| 290 | - echo ' |
|
| 302 | + elseif (!empty($context['current_board'])) { |
|
| 303 | + echo ' |
|
| 291 | 304 | <input type="hidden" name="sd_brd" value="', $context['current_board'], '">'; |
| 305 | + } |
|
| 292 | 306 | |
| 293 | 307 | echo ' |
| 294 | 308 | <input type="submit" name="search2" value="', $txt['search'], '" class="button_submit"> |
@@ -318,12 +332,13 @@ discard block |
||
| 318 | 332 | ', $context['current_time'], ' |
| 319 | 333 | </div>'; |
| 320 | 334 | // Show a random news item? (or you could pick one from news_lines...) |
| 321 | - if (!empty($settings['enable_news']) && !empty($context['random_news_line'])) |
|
| 322 | - echo ' |
|
| 335 | + if (!empty($settings['enable_news']) && !empty($context['random_news_line'])) { |
|
| 336 | + echo ' |
|
| 323 | 337 | <div class="news"> |
| 324 | 338 | <h2>', $txt['news'], ': </h2> |
| 325 | 339 | <p>', $context['random_news_line'], '</p> |
| 326 | 340 | </div>'; |
| 341 | + } |
|
| 327 | 342 | |
| 328 | 343 | echo ' |
| 329 | 344 | <hr class="clear"> |
@@ -386,9 +401,10 @@ discard block |
||
| 386 | 401 | </ul>'; |
| 387 | 402 | |
| 388 | 403 | // Show the load time? |
| 389 | - if ($context['show_load_time']) |
|
| 390 | - echo ' |
|
| 404 | + if ($context['show_load_time']) { |
|
| 405 | + echo ' |
|
| 391 | 406 | <p>', sprintf($txt['page_created_full'], $context['load_time'], $context['load_queries']), '</p>'; |
| 407 | + } |
|
| 392 | 408 | |
| 393 | 409 | echo ' |
| 394 | 410 | </div>'; |
@@ -418,19 +434,21 @@ discard block |
||
| 418 | 434 | global $context, $shown_linktree, $scripturl, $txt; |
| 419 | 435 | |
| 420 | 436 | // If linktree is empty, just return - also allow an override. |
| 421 | - if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show)) |
|
| 422 | - return; |
|
| 437 | + if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show)) { |
|
| 438 | + return; |
|
| 439 | + } |
|
| 423 | 440 | |
| 424 | 441 | echo ' |
| 425 | 442 | <div class="navigate_section"> |
| 426 | 443 | <ul>'; |
| 427 | 444 | |
| 428 | - if ($context['user']['is_logged']) |
|
| 429 | - echo ' |
|
| 445 | + if ($context['user']['is_logged']) { |
|
| 446 | + echo ' |
|
| 430 | 447 | <li class="unread_links"> |
| 431 | 448 | <a href="', $scripturl, '?action=unread" title="', $txt['unread_since_visit'], '">', $txt['view_unread_category'], '</a> |
| 432 | 449 | <a href="', $scripturl, '?action=unreadreplies" title="', $txt['show_unread_replies'], '">', $txt['unread_replies'], '</a> |
| 433 | 450 | </li>'; |
| 451 | + } |
|
| 434 | 452 | |
| 435 | 453 | // Each tree item has a URL and name. Some may have extra_before and extra_after. |
| 436 | 454 | foreach ($context['linktree'] as $link_num => $tree) |
@@ -441,25 +459,29 @@ discard block |
||
| 441 | 459 | // Don't show a separator for the first one. |
| 442 | 460 | // Better here. Always points to the next level when the linktree breaks to a second line. |
| 443 | 461 | // Picked a better looking HTML entity, and added support for RTL plus a span for styling. |
| 444 | - if ($link_num != 0) |
|
| 445 | - echo ' |
|
| 462 | + if ($link_num != 0) { |
|
| 463 | + echo ' |
|
| 446 | 464 | <span class="dividers">', $context['right_to_left'] ? ' ◄ ' : ' ► ', '</span>'; |
| 465 | + } |
|
| 447 | 466 | |
| 448 | 467 | // Show something before the link? |
| 449 | - if (isset($tree['extra_before'])) |
|
| 450 | - echo $tree['extra_before'], ' '; |
|
| 468 | + if (isset($tree['extra_before'])) { |
|
| 469 | + echo $tree['extra_before'], ' '; |
|
| 470 | + } |
|
| 451 | 471 | |
| 452 | 472 | // Show the link, including a URL if it should have one. |
| 453 | - if (isset($tree['url'])) |
|
| 454 | - echo ' |
|
| 473 | + if (isset($tree['url'])) { |
|
| 474 | + echo ' |
|
| 455 | 475 | <a href="' . $tree['url'] . '"><span>' . $tree['name'] . '</span></a>'; |
| 456 | - else |
|
| 457 | - echo ' |
|
| 476 | + } else { |
|
| 477 | + echo ' |
|
| 458 | 478 | <span>' . $tree['name'] . '</span>'; |
| 479 | + } |
|
| 459 | 480 | |
| 460 | 481 | // Show something after the link...? |
| 461 | - if (isset($tree['extra_after'])) |
|
| 462 | - echo ' ', $tree['extra_after']; |
|
| 482 | + if (isset($tree['extra_after'])) { |
|
| 483 | + echo ' ', $tree['extra_after']; |
|
| 484 | + } |
|
| 463 | 485 | |
| 464 | 486 | echo ' |
| 465 | 487 | </li>'; |
@@ -509,13 +531,14 @@ discard block |
||
| 509 | 531 | echo ' |
| 510 | 532 | <ul>'; |
| 511 | 533 | |
| 512 | - foreach ($childbutton['sub_buttons'] as $grandchildbutton) |
|
| 513 | - echo ' |
|
| 534 | + foreach ($childbutton['sub_buttons'] as $grandchildbutton) { |
|
| 535 | + echo ' |
|
| 514 | 536 | <li> |
| 515 | 537 | <a href="', $grandchildbutton['href'], '"', isset($grandchildbutton['target']) ? ' target="' . $grandchildbutton['target'] . '"' : '', '> |
| 516 | 538 | ', $grandchildbutton['title'], ' |
| 517 | 539 | </a> |
| 518 | 540 | </li>'; |
| 541 | + } |
|
| 519 | 542 | |
| 520 | 543 | echo ' |
| 521 | 544 | </ul>'; |
@@ -546,8 +569,9 @@ discard block |
||
| 546 | 569 | { |
| 547 | 570 | global $context, $txt; |
| 548 | 571 | |
| 549 | - if (!is_array($strip_options)) |
|
| 550 | - $strip_options = array(); |
|
| 572 | + if (!is_array($strip_options)) { |
|
| 573 | + $strip_options = array(); |
|
| 574 | + } |
|
| 551 | 575 | |
| 552 | 576 | // Create the buttons... |
| 553 | 577 | $buttons = array(); |
@@ -556,8 +580,9 @@ discard block |
||
| 556 | 580 | // As of 2.1, the 'test' for each button happens while the array is being generated. The extra 'test' check here is deprecated but kept for backward compatibility (update your mods, folks!) |
| 557 | 581 | if (!isset($value['test']) || !empty($context[$value['test']])) |
| 558 | 582 | { |
| 559 | - if (!isset($value['id'])) |
|
| 560 | - $value['id'] = $key; |
|
| 583 | + if (!isset($value['id'])) { |
|
| 584 | + $value['id'] = $key; |
|
| 585 | + } |
|
| 561 | 586 | |
| 562 | 587 | $button = ' |
| 563 | 588 | <a class="button button_strip_' . $key . (!empty($value['active']) ? ' active' : '') . (isset($value['class']) ? ' ' . $value['class'] : '') . '" ' . (!empty($value['url']) ? 'href="' . $value['url'] . '"' : '') . ' ' . (isset($value['custom']) ? ' ' . $value['custom'] : '') . '>' . $txt[$value['text']] . '</a>'; |
@@ -570,13 +595,15 @@ discard block |
||
| 570 | 595 | <div class="overview">'; |
| 571 | 596 | foreach ($value['sub_buttons'] as $element) |
| 572 | 597 | { |
| 573 | - if (isset($element['test']) && empty($context[$element['test']])) |
|
| 574 | - continue; |
|
| 598 | + if (isset($element['test']) && empty($context[$element['test']])) { |
|
| 599 | + continue; |
|
| 600 | + } |
|
| 575 | 601 | |
| 576 | 602 | $button .= ' |
| 577 | 603 | <a href="' . $element['url'] . '"><strong>' . $txt[$element['text']] . '</strong>'; |
| 578 | - if (isset($txt[$element['text'] . '_desc'])) |
|
| 579 | - $button .= '<br /><span>' . $txt[$element['text'] . '_desc'] . '</span>'; |
|
| 604 | + if (isset($txt[$element['text'] . '_desc'])) { |
|
| 605 | + $button .= '<br /><span>' . $txt[$element['text'] . '_desc'] . '</span>'; |
|
| 606 | + } |
|
| 580 | 607 | $button .= '</a>'; |
| 581 | 608 | } |
| 582 | 609 | $button .= ' |
@@ -590,8 +617,9 @@ discard block |
||
| 590 | 617 | } |
| 591 | 618 | |
| 592 | 619 | // No buttons? No button strip either. |
| 593 | - if (empty($buttons)) |
|
| 594 | - return; |
|
| 620 | + if (empty($buttons)) { |
|
| 621 | + return; |
|
| 622 | + } |
|
| 595 | 623 | |
| 596 | 624 | echo ' |
| 597 | 625 | <div class="buttonlist', !empty($direction) ? ' float' . $direction : '', '"', (empty($buttons) ? ' style="display: none;"' : ''), (!empty($strip_options['id']) ? ' id="' . $strip_options['id'] . '"' : ''), '> |
@@ -1542,7 +1542,7 @@ discard block |
||
| 1542 | 1542 | 'no_msg' => 0, |
| 1543 | 1543 | 'substep' => $_GET['substep'], |
| 1544 | 1544 | 'ignore_ids' => $ignore_ids, |
| 1545 | - 'attach_thumb' => array(0,3), |
|
| 1545 | + 'attach_thumb' => array(0, 3), |
|
| 1546 | 1546 | ) |
| 1547 | 1547 | ); |
| 1548 | 1548 | |
@@ -1572,7 +1572,7 @@ discard block |
||
| 1572 | 1572 | array( |
| 1573 | 1573 | 'to_remove' => $to_remove, |
| 1574 | 1574 | 'no_member' => 0, |
| 1575 | - 'attach_thumb' => array(0,3), |
|
| 1575 | + 'attach_thumb' => array(0, 3), |
|
| 1576 | 1576 | ) |
| 1577 | 1577 | ); |
| 1578 | 1578 | |
@@ -14,8 +14,9 @@ discard block |
||
| 14 | 14 | * @version 2.1 Beta 3 |
| 15 | 15 | */ |
| 16 | 16 | |
| 17 | -if (!defined('SMF')) |
|
| 17 | +if (!defined('SMF')) { |
|
| 18 | 18 | die('No direct access...'); |
| 19 | +} |
|
| 19 | 20 | |
| 20 | 21 | /** |
| 21 | 22 | * The main 'Attachments and Avatars' management function. |
@@ -63,10 +64,11 @@ discard block |
||
| 63 | 64 | call_integration_hook('integrate_manage_attachments', array(&$subActions)); |
| 64 | 65 | |
| 65 | 66 | // Pick the correct sub-action. |
| 66 | - if (isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']])) |
|
| 67 | - $context['sub_action'] = $_REQUEST['sa']; |
|
| 68 | - else |
|
| 69 | - $context['sub_action'] = 'browse'; |
|
| 67 | + if (isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']])) { |
|
| 68 | + $context['sub_action'] = $_REQUEST['sa']; |
|
| 69 | + } else { |
|
| 70 | + $context['sub_action'] = 'browse'; |
|
| 71 | + } |
|
| 70 | 72 | |
| 71 | 73 | // Default page title is good. |
| 72 | 74 | $context['page_title'] = $txt['attachments_avatars']; |
@@ -94,20 +96,20 @@ discard block |
||
| 94 | 96 | $context['attachmentUploadDir'] = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
| 95 | 97 | |
| 96 | 98 | // If not set, show a default path for the base directory |
| 97 | - if (!isset($_GET['save']) && empty($modSettings['basedirectory_for_attachments'])) |
|
| 98 | - if (is_dir($modSettings['attachmentUploadDir'][1])) |
|
| 99 | + if (!isset($_GET['save']) && empty($modSettings['basedirectory_for_attachments'])) { |
|
| 100 | + if (is_dir($modSettings['attachmentUploadDir'][1])) |
|
| 99 | 101 | $modSettings['basedirectory_for_attachments'] = $modSettings['attachmentUploadDir'][1]; |
| 100 | - |
|
| 101 | - else |
|
| 102 | - $modSettings['basedirectory_for_attachments'] = $context['attachmentUploadDir']; |
|
| 102 | + } else { |
|
| 103 | + $modSettings['basedirectory_for_attachments'] = $context['attachmentUploadDir']; |
|
| 104 | + } |
|
| 103 | 105 | |
| 104 | 106 | $context['valid_upload_dir'] = is_dir($context['attachmentUploadDir']) && is_writable($context['attachmentUploadDir']); |
| 105 | 107 | |
| 106 | - if (!empty($modSettings['automanage_attachments'])) |
|
| 107 | - $context['valid_basedirectory'] = !empty($modSettings['basedirectory_for_attachments']) && is_writable($modSettings['basedirectory_for_attachments']); |
|
| 108 | - |
|
| 109 | - else |
|
| 110 | - $context['valid_basedirectory'] = true; |
|
| 108 | + if (!empty($modSettings['automanage_attachments'])) { |
|
| 109 | + $context['valid_basedirectory'] = !empty($modSettings['basedirectory_for_attachments']) && is_writable($modSettings['basedirectory_for_attachments']); |
|
| 110 | + } else { |
|
| 111 | + $context['valid_basedirectory'] = true; |
|
| 112 | + } |
|
| 111 | 113 | |
| 112 | 114 | // A bit of razzle dazzle with the $txt strings. :) |
| 113 | 115 | $txt['attachment_path'] = $context['attachmentUploadDir']; |
@@ -185,8 +187,9 @@ discard block |
||
| 185 | 187 | |
| 186 | 188 | call_integration_hook('integrate_modify_attachment_settings', array(&$config_vars)); |
| 187 | 189 | |
| 188 | - if ($return_config) |
|
| 189 | - return $config_vars; |
|
| 190 | + if ($return_config) { |
|
| 191 | + return $config_vars; |
|
| 192 | + } |
|
| 190 | 193 | |
| 191 | 194 | // These are very likely to come in handy! (i.e. without them we're doomed!) |
| 192 | 195 | require_once($sourcedir . '/ManagePermissions.php'); |
@@ -197,21 +200,24 @@ discard block |
||
| 197 | 200 | { |
| 198 | 201 | checkSession(); |
| 199 | 202 | |
| 200 | - if (isset($_POST['attachmentUploadDir'])) |
|
| 201 | - unset($_POST['attachmentUploadDir']); |
|
| 203 | + if (isset($_POST['attachmentUploadDir'])) { |
|
| 204 | + unset($_POST['attachmentUploadDir']); |
|
| 205 | + } |
|
| 202 | 206 | |
| 203 | 207 | if (!empty($_POST['use_subdirectories_for_attachments'])) |
| 204 | 208 | { |
| 205 | - if (isset($_POST['use_subdirectories_for_attachments']) && empty($_POST['basedirectory_for_attachments'])) |
|
| 206 | - $_POST['basedirectory_for_attachments'] = (!empty($modSettings['basedirectory_for_attachments']) ? ($modSettings['basedirectory_for_attachments']) : $boarddir); |
|
| 209 | + if (isset($_POST['use_subdirectories_for_attachments']) && empty($_POST['basedirectory_for_attachments'])) { |
|
| 210 | + $_POST['basedirectory_for_attachments'] = (!empty($modSettings['basedirectory_for_attachments']) ? ($modSettings['basedirectory_for_attachments']) : $boarddir); |
|
| 211 | + } |
|
| 207 | 212 | |
| 208 | 213 | if (!empty($_POST['use_subdirectories_for_attachments']) && !empty($modSettings['attachment_basedirectories'])) |
| 209 | 214 | { |
| 210 | - if (!is_array($modSettings['attachment_basedirectories'])) |
|
| 211 | - $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
|
| 215 | + if (!is_array($modSettings['attachment_basedirectories'])) { |
|
| 216 | + $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
|
| 217 | + } |
|
| 218 | + } else { |
|
| 219 | + $modSettings['attachment_basedirectories'] = array(); |
|
| 212 | 220 | } |
| 213 | - else |
|
| 214 | - $modSettings['attachment_basedirectories'] = array(); |
|
| 215 | 221 | |
| 216 | 222 | if (!empty($_POST['use_subdirectories_for_attachments']) && !empty($_POST['basedirectory_for_attachments']) && !in_array($_POST['basedirectory_for_attachments'], $modSettings['attachment_basedirectories'])) |
| 217 | 223 | { |
@@ -219,8 +225,9 @@ discard block |
||
| 219 | 225 | |
| 220 | 226 | if (!in_array($_POST['basedirectory_for_attachments'], $modSettings['attachmentUploadDir'])) |
| 221 | 227 | { |
| 222 | - if (!automanage_attachments_create_directory($_POST['basedirectory_for_attachments'])) |
|
| 223 | - $_POST['basedirectory_for_attachments'] = $modSettings['basedirectory_for_attachments']; |
|
| 228 | + if (!automanage_attachments_create_directory($_POST['basedirectory_for_attachments'])) { |
|
| 229 | + $_POST['basedirectory_for_attachments'] = $modSettings['basedirectory_for_attachments']; |
|
| 230 | + } |
|
| 224 | 231 | } |
| 225 | 232 | |
| 226 | 233 | if (!in_array($_POST['basedirectory_for_attachments'], $modSettings['attachment_basedirectories'])) |
@@ -336,8 +343,9 @@ discard block |
||
| 336 | 343 | |
| 337 | 344 | call_integration_hook('integrate_modify_avatar_settings', array(&$config_vars)); |
| 338 | 345 | |
| 339 | - if ($return_config) |
|
| 340 | - return $config_vars; |
|
| 346 | + if ($return_config) { |
|
| 347 | + return $config_vars; |
|
| 348 | + } |
|
| 341 | 349 | |
| 342 | 350 | // We need this file for the settings template. |
| 343 | 351 | require_once($sourcedir . '/ManageServer.php'); |
@@ -348,17 +356,21 @@ discard block |
||
| 348 | 356 | checkSession(); |
| 349 | 357 | |
| 350 | 358 | // These settings cannot be left empty! |
| 351 | - if (empty($_POST['custom_avatar_dir'])) |
|
| 352 | - $_POST['custom_avatar_dir'] = $boarddir . '/custom_avatar'; |
|
| 359 | + if (empty($_POST['custom_avatar_dir'])) { |
|
| 360 | + $_POST['custom_avatar_dir'] = $boarddir . '/custom_avatar'; |
|
| 361 | + } |
|
| 353 | 362 | |
| 354 | - if (empty($_POST['custom_avatar_url'])) |
|
| 355 | - $_POST['custom_avatar_url'] = $boardurl . '/custom_avatar'; |
|
| 363 | + if (empty($_POST['custom_avatar_url'])) { |
|
| 364 | + $_POST['custom_avatar_url'] = $boardurl . '/custom_avatar'; |
|
| 365 | + } |
|
| 356 | 366 | |
| 357 | - if (empty($_POST['avatar_directory'])) |
|
| 358 | - $_POST['avatar_directory'] = $boarddir . '/avatars'; |
|
| 367 | + if (empty($_POST['avatar_directory'])) { |
|
| 368 | + $_POST['avatar_directory'] = $boarddir . '/avatars'; |
|
| 369 | + } |
|
| 359 | 370 | |
| 360 | - if (empty($_POST['avatar_url'])) |
|
| 361 | - $_POST['avatar_url'] = $boardurl . '/avatars'; |
|
| 371 | + if (empty($_POST['avatar_url'])) { |
|
| 372 | + $_POST['avatar_url'] = $boardurl . '/avatars'; |
|
| 373 | + } |
|
| 362 | 374 | |
| 363 | 375 | call_integration_hook('integrate_save_avatar_settings'); |
| 364 | 376 | |
@@ -406,11 +418,13 @@ discard block |
||
| 406 | 418 | $list_title = $txt['attachment_manager_browse_files'] . ': '; |
| 407 | 419 | foreach ($titles as $browse_type => $details) |
| 408 | 420 | { |
| 409 | - if ($browse_type != 'attachments') |
|
| 410 | - $list_title .= ' | '; |
|
| 421 | + if ($browse_type != 'attachments') { |
|
| 422 | + $list_title .= ' | '; |
|
| 423 | + } |
|
| 411 | 424 | |
| 412 | - if ($context['browse_type'] == $browse_type) |
|
| 413 | - $list_title .= '<img src="' . $settings['images_url'] . '/selected.png" alt=">"> '; |
|
| 425 | + if ($context['browse_type'] == $browse_type) { |
|
| 426 | + $list_title .= '<img src="' . $settings['images_url'] . '/selected.png" alt=">"> '; |
|
| 427 | + } |
|
| 414 | 428 | |
| 415 | 429 | $list_title .= '<a href="' . $scripturl . $details[0] . '">' . $details[1] . '</a>'; |
| 416 | 430 | } |
@@ -446,28 +460,33 @@ discard block |
||
| 446 | 460 | $link = '<a href="'; |
| 447 | 461 | |
| 448 | 462 | // In case of a custom avatar URL attachments have a fixed directory. |
| 449 | - if ($rowData['attachment_type'] == 1) |
|
| 450 | - $link .= sprintf('%1$s/%2$s', $modSettings['custom_avatar_url'], $rowData['filename']); |
|
| 463 | + if ($rowData['attachment_type'] == 1) { |
|
| 464 | + $link .= sprintf('%1$s/%2$s', $modSettings['custom_avatar_url'], $rowData['filename']); |
|
| 465 | + } |
|
| 451 | 466 | |
| 452 | 467 | // By default avatars are downloaded almost as attachments. |
| 453 | - elseif ($context['browse_type'] == 'avatars') |
|
| 454 | - $link .= sprintf('%1$s?action=dlattach;type=avatar;attach=%2$d', $scripturl, $rowData['id_attach']); |
|
| 468 | + elseif ($context['browse_type'] == 'avatars') { |
|
| 469 | + $link .= sprintf('%1$s?action=dlattach;type=avatar;attach=%2$d', $scripturl, $rowData['id_attach']); |
|
| 470 | + } |
|
| 455 | 471 | |
| 456 | 472 | // Normal attachments are always linked to a topic ID. |
| 457 | - else |
|
| 458 | - $link .= sprintf('%1$s?action=dlattach;topic=%2$d.0;attach=%3$d', $scripturl, $rowData['id_topic'], $rowData['id_attach']); |
|
| 473 | + else { |
|
| 474 | + $link .= sprintf('%1$s?action=dlattach;topic=%2$d.0;attach=%3$d', $scripturl, $rowData['id_topic'], $rowData['id_attach']); |
|
| 475 | + } |
|
| 459 | 476 | |
| 460 | 477 | $link .= '"'; |
| 461 | 478 | |
| 462 | 479 | // Show a popup on click if it's a picture and we know its dimensions. |
| 463 | - if (!empty($rowData['width']) && !empty($rowData['height'])) |
|
| 464 | - $link .= sprintf(' onclick="return reqWin(this.href' . ($rowData['attachment_type'] == 1 ? '' : ' + \';image\'') . ', %1$d, %2$d, true);"', $rowData['width'] + 20, $rowData['height'] + 20); |
|
| 480 | + if (!empty($rowData['width']) && !empty($rowData['height'])) { |
|
| 481 | + $link .= sprintf(' onclick="return reqWin(this.href' . ($rowData['attachment_type'] == 1 ? '' : ' + \';image\'') . ', %1$d, %2$d, true);"', $rowData['width'] + 20, $rowData['height'] + 20); |
|
| 482 | + } |
|
| 465 | 483 | |
| 466 | 484 | $link .= sprintf('>%1$s</a>', preg_replace('~&#(\\\\d{1,7}|x[0-9a-fA-F]{1,6});~', '&#\\\\1;', $smcFunc['htmlspecialchars']($rowData['filename']))); |
| 467 | 485 | |
| 468 | 486 | // Show the dimensions. |
| 469 | - if (!empty($rowData['width']) && !empty($rowData['height'])) |
|
| 470 | - $link .= sprintf(' <span class="smalltext">%1$dx%2$d</span>', $rowData['width'], $rowData['height']); |
|
| 487 | + if (!empty($rowData['width']) && !empty($rowData['height'])) { |
|
| 488 | + $link .= sprintf(' <span class="smalltext">%1$dx%2$d</span>', $rowData['width'], $rowData['height']); |
|
| 489 | + } |
|
| 471 | 490 | |
| 472 | 491 | return $link; |
| 473 | 492 | }, |
@@ -500,12 +519,14 @@ discard block |
||
| 500 | 519 | 'function' => function($rowData) use ($scripturl, $smcFunc) |
| 501 | 520 | { |
| 502 | 521 | // In case of an attachment, return the poster of the attachment. |
| 503 | - if (empty($rowData['id_member'])) |
|
| 504 | - return $smcFunc['htmlspecialchars']($rowData['poster_name']); |
|
| 522 | + if (empty($rowData['id_member'])) { |
|
| 523 | + return $smcFunc['htmlspecialchars']($rowData['poster_name']); |
|
| 524 | + } |
|
| 505 | 525 | |
| 506 | 526 | // Otherwise it must be an avatar, return the link to the owner of it. |
| 507 | - else |
|
| 508 | - return sprintf('<a href="%1$s?action=profile;u=%2$d">%3$s</a>', $scripturl, $rowData['id_member'], $rowData['poster_name']); |
|
| 527 | + else { |
|
| 528 | + return sprintf('<a href="%1$s?action=profile;u=%2$d">%3$s</a>', $scripturl, $rowData['id_member'], $rowData['poster_name']); |
|
| 529 | + } |
|
| 509 | 530 | }, |
| 510 | 531 | ), |
| 511 | 532 | 'sort' => array( |
@@ -524,8 +545,9 @@ discard block |
||
| 524 | 545 | $date = empty($rowData['poster_time']) ? $txt['never'] : timeformat($rowData['poster_time']); |
| 525 | 546 | |
| 526 | 547 | // Add a link to the topic in case of an attachment. |
| 527 | - if ($context['browse_type'] !== 'avatars') |
|
| 528 | - $date .= sprintf('<br>%1$s <a href="%2$s?topic=%3$d.msg%4$d#msg%4$d">%5$s</a>', $txt['in'], $scripturl, $rowData['id_topic'], $rowData['id_msg'], $rowData['subject']); |
|
| 548 | + if ($context['browse_type'] !== 'avatars') { |
|
| 549 | + $date .= sprintf('<br>%1$s <a href="%2$s?topic=%3$d.msg%4$d#msg%4$d">%5$s</a>', $txt['in'], $scripturl, $rowData['id_topic'], $rowData['id_msg'], $rowData['subject']); |
|
| 550 | + } |
|
| 529 | 551 | |
| 530 | 552 | return $date; |
| 531 | 553 | }, |
@@ -610,8 +632,8 @@ discard block |
||
| 610 | 632 | global $smcFunc, $txt; |
| 611 | 633 | |
| 612 | 634 | // Choose a query depending on what we are viewing. |
| 613 | - if ($browse_type === 'avatars') |
|
| 614 | - $request = $smcFunc['db_query']('', ' |
|
| 635 | + if ($browse_type === 'avatars') { |
|
| 636 | + $request = $smcFunc['db_query']('', ' |
|
| 615 | 637 | SELECT |
| 616 | 638 | {string:blank_text} AS id_msg, COALESCE(mem.real_name, {string:not_applicable_text}) AS poster_name, |
| 617 | 639 | mem.last_login AS poster_time, 0 AS id_topic, a.id_member, a.id_attach, a.filename, a.file_hash, a.attachment_type, |
@@ -630,8 +652,8 @@ discard block |
||
| 630 | 652 | 'per_page' => $items_per_page, |
| 631 | 653 | ) |
| 632 | 654 | ); |
| 633 | - else |
|
| 634 | - $request = $smcFunc['db_query']('', ' |
|
| 655 | + } else { |
|
| 656 | + $request = $smcFunc['db_query']('', ' |
|
| 635 | 657 | SELECT |
| 636 | 658 | m.id_msg, COALESCE(mem.real_name, m.poster_name) AS poster_name, m.poster_time, m.id_topic, m.id_member, |
| 637 | 659 | a.id_attach, a.filename, a.file_hash, a.attachment_type, a.size, a.width, a.height, a.downloads, mf.subject, t.id_board |
@@ -650,9 +672,11 @@ discard block |
||
| 650 | 672 | 'per_page' => $items_per_page, |
| 651 | 673 | ) |
| 652 | 674 | ); |
| 675 | + } |
|
| 653 | 676 | $files = array(); |
| 654 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 655 | - $files[] = $row; |
|
| 677 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 678 | + $files[] = $row; |
|
| 679 | + } |
|
| 656 | 680 | $smcFunc['db_free_result']($request); |
| 657 | 681 | |
| 658 | 682 | return $files; |
@@ -670,8 +694,8 @@ discard block |
||
| 670 | 694 | global $smcFunc; |
| 671 | 695 | |
| 672 | 696 | // Depending on the type of file, different queries are used. |
| 673 | - if ($browse_type === 'avatars') |
|
| 674 | - $request = $smcFunc['db_query']('', ' |
|
| 697 | + if ($browse_type === 'avatars') { |
|
| 698 | + $request = $smcFunc['db_query']('', ' |
|
| 675 | 699 | SELECT COUNT(*) |
| 676 | 700 | FROM {db_prefix}attachments |
| 677 | 701 | WHERE id_member != {int:guest_id_member}', |
@@ -679,8 +703,8 @@ discard block |
||
| 679 | 703 | 'guest_id_member' => 0, |
| 680 | 704 | ) |
| 681 | 705 | ); |
| 682 | - else |
|
| 683 | - $request = $smcFunc['db_query']('', ' |
|
| 706 | + } else { |
|
| 707 | + $request = $smcFunc['db_query']('', ' |
|
| 684 | 708 | SELECT COUNT(*) AS num_attach |
| 685 | 709 | FROM {db_prefix}attachments AS a |
| 686 | 710 | INNER JOIN {db_prefix}messages AS m ON (m.id_msg = a.id_msg) |
@@ -693,6 +717,7 @@ discard block |
||
| 693 | 717 | 'guest_id_member' => 0, |
| 694 | 718 | ) |
| 695 | 719 | ); |
| 720 | + } |
|
| 696 | 721 | |
| 697 | 722 | list ($num_files) = $smcFunc['db_fetch_row']($request); |
| 698 | 723 | $smcFunc['db_free_result']($request); |
@@ -775,12 +800,14 @@ discard block |
||
| 775 | 800 | $current_dir_size /= 1024; |
| 776 | 801 | |
| 777 | 802 | // If they specified a limit only.... |
| 778 | - if (!empty($modSettings['attachmentDirSizeLimit'])) |
|
| 779 | - $context['attachment_space'] = comma_format(max($modSettings['attachmentDirSizeLimit'] - $current_dir_size, 0), 2); |
|
| 803 | + if (!empty($modSettings['attachmentDirSizeLimit'])) { |
|
| 804 | + $context['attachment_space'] = comma_format(max($modSettings['attachmentDirSizeLimit'] - $current_dir_size, 0), 2); |
|
| 805 | + } |
|
| 780 | 806 | $context['attachment_current_size'] = comma_format($current_dir_size, 2); |
| 781 | 807 | |
| 782 | - if (!empty($modSettings['attachmentDirFileLimit'])) |
|
| 783 | - $context['attachment_files'] = comma_format(max($modSettings['attachmentDirFileLimit'] - $current_dir_files, 0), 0); |
|
| 808 | + if (!empty($modSettings['attachmentDirFileLimit'])) { |
|
| 809 | + $context['attachment_files'] = comma_format(max($modSettings['attachmentDirFileLimit'] - $current_dir_files, 0), 0); |
|
| 810 | + } |
|
| 784 | 811 | $context['attachment_current_files'] = comma_format($current_dir_files, 0); |
| 785 | 812 | |
| 786 | 813 | $context['attach_multiple_dirs'] = count($attach_dirs) > 1 ? true : false; |
@@ -817,8 +844,8 @@ discard block |
||
| 817 | 844 | $messages = removeAttachments(array('attachment_type' => 0, 'poster_time' => (time() - 24 * 60 * 60 * $_POST['age'])), 'messages', true); |
| 818 | 845 | |
| 819 | 846 | // Update the messages to reflect the change. |
| 820 | - if (!empty($messages) && !empty($_POST['notice'])) |
|
| 821 | - $smcFunc['db_query']('', ' |
|
| 847 | + if (!empty($messages) && !empty($_POST['notice'])) { |
|
| 848 | + $smcFunc['db_query']('', ' |
|
| 822 | 849 | UPDATE {db_prefix}messages |
| 823 | 850 | SET body = CONCAT(body, {string:notice}) |
| 824 | 851 | WHERE id_msg IN ({array_int:messages})', |
@@ -827,8 +854,8 @@ discard block |
||
| 827 | 854 | 'notice' => '<br><br>' . $_POST['notice'], |
| 828 | 855 | ) |
| 829 | 856 | ); |
| 830 | - } |
|
| 831 | - else |
|
| 857 | + } |
|
| 858 | + } else |
|
| 832 | 859 | { |
| 833 | 860 | // Remove all the old avatars. |
| 834 | 861 | removeAttachments(array('not_id_member' => 0, 'last_login' => (time() - 24 * 60 * 60 * $_POST['age'])), 'members'); |
@@ -853,8 +880,8 @@ discard block |
||
| 853 | 880 | $messages = removeAttachments(array('attachment_type' => 0, 'size' => 1024 * $_POST['size']), 'messages', true); |
| 854 | 881 | |
| 855 | 882 | // And make a note on the post. |
| 856 | - if (!empty($messages) && !empty($_POST['notice'])) |
|
| 857 | - $smcFunc['db_query']('', ' |
|
| 883 | + if (!empty($messages) && !empty($_POST['notice'])) { |
|
| 884 | + $smcFunc['db_query']('', ' |
|
| 858 | 885 | UPDATE {db_prefix}messages |
| 859 | 886 | SET body = CONCAT(body, {string:notice}) |
| 860 | 887 | WHERE id_msg IN ({array_int:messages})', |
@@ -863,6 +890,7 @@ discard block |
||
| 863 | 890 | 'notice' => '<br><br>' . $_POST['notice'], |
| 864 | 891 | ) |
| 865 | 892 | ); |
| 893 | + } |
|
| 866 | 894 | |
| 867 | 895 | redirectexit('action=admin;area=manageattachments;sa=maintenance'); |
| 868 | 896 | } |
@@ -882,16 +910,17 @@ discard block |
||
| 882 | 910 | { |
| 883 | 911 | $attachments = array(); |
| 884 | 912 | // There must be a quicker way to pass this safety test?? |
| 885 | - foreach ($_POST['remove'] as $removeID => $dummy) |
|
| 886 | - $attachments[] = (int) $removeID; |
|
| 913 | + foreach ($_POST['remove'] as $removeID => $dummy) { |
|
| 914 | + $attachments[] = (int) $removeID; |
|
| 915 | + } |
|
| 887 | 916 | |
| 888 | 917 | // If the attachments are from a 3rd party, let them remove it. Hooks should remove their ids from the array. |
| 889 | 918 | $filesRemoved = false; |
| 890 | 919 | call_integration_hook('integrate_attachment_remove', array(&$filesRemoved, $attachments)); |
| 891 | 920 | |
| 892 | - if ($_REQUEST['type'] == 'avatars' && !empty($attachments)) |
|
| 893 | - removeAttachments(array('id_attach' => $attachments)); |
|
| 894 | - else if (!empty($attachments)) |
|
| 921 | + if ($_REQUEST['type'] == 'avatars' && !empty($attachments)) { |
|
| 922 | + removeAttachments(array('id_attach' => $attachments)); |
|
| 923 | + } else if (!empty($attachments)) |
|
| 895 | 924 | { |
| 896 | 925 | $messages = removeAttachments(array('id_attach' => $attachments), 'messages', true); |
| 897 | 926 | |
@@ -930,12 +959,13 @@ discard block |
||
| 930 | 959 | |
| 931 | 960 | $messages = removeAttachments(array('attachment_type' => 0), '', true); |
| 932 | 961 | |
| 933 | - if (!isset($_POST['notice'])) |
|
| 934 | - $_POST['notice'] = $txt['attachment_delete_admin']; |
|
| 962 | + if (!isset($_POST['notice'])) { |
|
| 963 | + $_POST['notice'] = $txt['attachment_delete_admin']; |
|
| 964 | + } |
|
| 935 | 965 | |
| 936 | 966 | // Add the notice on the end of the changed messages. |
| 937 | - if (!empty($messages)) |
|
| 938 | - $smcFunc['db_query']('', ' |
|
| 967 | + if (!empty($messages)) { |
|
| 968 | + $smcFunc['db_query']('', ' |
|
| 939 | 969 | UPDATE {db_prefix}messages |
| 940 | 970 | SET body = CONCAT(body, {string:deleted_message}) |
| 941 | 971 | WHERE id_msg IN ({array_int:messages})', |
@@ -944,6 +974,7 @@ discard block |
||
| 944 | 974 | 'deleted_message' => '<br><br>' . $_POST['notice'], |
| 945 | 975 | ) |
| 946 | 976 | ); |
| 977 | + } |
|
| 947 | 978 | |
| 948 | 979 | redirectexit('action=admin;area=manageattachments;sa=maintenance'); |
| 949 | 980 | } |
@@ -982,24 +1013,26 @@ discard block |
||
| 982 | 1013 | $is_not = substr($real_type, 0, 4) == 'not_'; |
| 983 | 1014 | $type = $is_not ? substr($real_type, 4) : $real_type; |
| 984 | 1015 | |
| 985 | - if (in_array($type, array('id_member', 'id_attach', 'id_msg'))) |
|
| 986 | - $new_condition[] = 'a.' . $type . ($is_not ? ' NOT' : '') . ' IN (' . (is_array($restriction) ? '{array_int:' . $real_type . '}' : '{int:' . $real_type . '}') . ')'; |
|
| 987 | - elseif ($type == 'attachment_type') |
|
| 988 | - $new_condition[] = 'a.attachment_type = {int:' . $real_type . '}'; |
|
| 989 | - elseif ($type == 'poster_time') |
|
| 990 | - $new_condition[] = 'm.poster_time < {int:' . $real_type . '}'; |
|
| 991 | - elseif ($type == 'last_login') |
|
| 992 | - $new_condition[] = 'mem.last_login < {int:' . $real_type . '}'; |
|
| 993 | - elseif ($type == 'size') |
|
| 994 | - $new_condition[] = 'a.size > {int:' . $real_type . '}'; |
|
| 995 | - elseif ($type == 'id_topic') |
|
| 996 | - $new_condition[] = 'm.id_topic IN (' . (is_array($restriction) ? '{array_int:' . $real_type . '}' : '{int:' . $real_type . '}') . ')'; |
|
| 1016 | + if (in_array($type, array('id_member', 'id_attach', 'id_msg'))) { |
|
| 1017 | + $new_condition[] = 'a.' . $type . ($is_not ? ' NOT' : '') . ' IN (' . (is_array($restriction) ? '{array_int:' . $real_type . '}' : '{int:' . $real_type . '}') . ')'; |
|
| 1018 | + } elseif ($type == 'attachment_type') { |
|
| 1019 | + $new_condition[] = 'a.attachment_type = {int:' . $real_type . '}'; |
|
| 1020 | + } elseif ($type == 'poster_time') { |
|
| 1021 | + $new_condition[] = 'm.poster_time < {int:' . $real_type . '}'; |
|
| 1022 | + } elseif ($type == 'last_login') { |
|
| 1023 | + $new_condition[] = 'mem.last_login < {int:' . $real_type . '}'; |
|
| 1024 | + } elseif ($type == 'size') { |
|
| 1025 | + $new_condition[] = 'a.size > {int:' . $real_type . '}'; |
|
| 1026 | + } elseif ($type == 'id_topic') { |
|
| 1027 | + $new_condition[] = 'm.id_topic IN (' . (is_array($restriction) ? '{array_int:' . $real_type . '}' : '{int:' . $real_type . '}') . ')'; |
|
| 1028 | + } |
|
| 997 | 1029 | |
| 998 | 1030 | // Add the parameter! |
| 999 | 1031 | $query_parameter[$real_type] = $restriction; |
| 1000 | 1032 | |
| 1001 | - if ($type == 'do_logging') |
|
| 1002 | - $do_logging = $condition['id_attach']; |
|
| 1033 | + if ($type == 'do_logging') { |
|
| 1034 | + $do_logging = $condition['id_attach']; |
|
| 1035 | + } |
|
| 1003 | 1036 | } |
| 1004 | 1037 | $condition = implode(' AND ', $new_condition); |
| 1005 | 1038 | } |
@@ -1031,15 +1064,15 @@ discard block |
||
| 1031 | 1064 | // wasn't it obvious? :P |
| 1032 | 1065 | // @todo look again at this. |
| 1033 | 1066 | @unlink($modSettings['custom_avatar_dir'] . '/' . $row['filename']); |
| 1034 | - } |
|
| 1035 | - else |
|
| 1067 | + } else |
|
| 1036 | 1068 | { |
| 1037 | 1069 | $filename = getAttachmentFilename($row['filename'], $row['id_attach'], $row['id_folder'], false, $row['file_hash']); |
| 1038 | 1070 | @unlink($filename); |
| 1039 | 1071 | |
| 1040 | 1072 | // If this was a thumb, the parent attachment should know about it. |
| 1041 | - if (!empty($row['id_parent'])) |
|
| 1042 | - $parents[] = $row['id_parent']; |
|
| 1073 | + if (!empty($row['id_parent'])) { |
|
| 1074 | + $parents[] = $row['id_parent']; |
|
| 1075 | + } |
|
| 1043 | 1076 | |
| 1044 | 1077 | // If this attachments has a thumb, remove it as well. |
| 1045 | 1078 | if (!empty($row['id_thumb']) && $autoThumbRemoval) |
@@ -1051,8 +1084,9 @@ discard block |
||
| 1051 | 1084 | } |
| 1052 | 1085 | |
| 1053 | 1086 | // Make a list. |
| 1054 | - if ($return_affected_messages && empty($row['attachment_type'])) |
|
| 1055 | - $msgs[] = $row['id_msg']; |
|
| 1087 | + if ($return_affected_messages && empty($row['attachment_type'])) { |
|
| 1088 | + $msgs[] = $row['id_msg']; |
|
| 1089 | + } |
|
| 1056 | 1090 | |
| 1057 | 1091 | $attach[] = $row['id_attach']; |
| 1058 | 1092 | } |
@@ -1060,8 +1094,8 @@ discard block |
||
| 1060 | 1094 | |
| 1061 | 1095 | // Removed attachments don't have to be updated anymore. |
| 1062 | 1096 | $parents = array_diff($parents, $attach); |
| 1063 | - if (!empty($parents)) |
|
| 1064 | - $smcFunc['db_query']('', ' |
|
| 1097 | + if (!empty($parents)) { |
|
| 1098 | + $smcFunc['db_query']('', ' |
|
| 1065 | 1099 | UPDATE {db_prefix}attachments |
| 1066 | 1100 | SET id_thumb = {int:no_thumb} |
| 1067 | 1101 | WHERE id_attach IN ({array_int:parent_attachments})', |
@@ -1070,6 +1104,7 @@ discard block |
||
| 1070 | 1104 | 'no_thumb' => 0, |
| 1071 | 1105 | ) |
| 1072 | 1106 | ); |
| 1107 | + } |
|
| 1073 | 1108 | |
| 1074 | 1109 | if (!empty($do_logging)) |
| 1075 | 1110 | { |
@@ -1086,31 +1121,34 @@ discard block |
||
| 1086 | 1121 | ) |
| 1087 | 1122 | ); |
| 1088 | 1123 | |
| 1089 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1090 | - logAction( |
|
| 1124 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1125 | + logAction( |
|
| 1091 | 1126 | 'remove_attach', |
| 1092 | 1127 | array( |
| 1093 | 1128 | 'message' => $row['id_msg'], |
| 1094 | 1129 | 'filename' => preg_replace('~&#(\\d{1,7}|x[0-9a-fA-F]{1,6});~', '&#\\1;', $smcFunc['htmlspecialchars']($row['filename'])), |
| 1095 | 1130 | ) |
| 1096 | 1131 | ); |
| 1132 | + } |
|
| 1097 | 1133 | $smcFunc['db_free_result']($request); |
| 1098 | 1134 | } |
| 1099 | 1135 | |
| 1100 | - if (!empty($attach)) |
|
| 1101 | - $smcFunc['db_query']('', ' |
|
| 1136 | + if (!empty($attach)) { |
|
| 1137 | + $smcFunc['db_query']('', ' |
|
| 1102 | 1138 | DELETE FROM {db_prefix}attachments |
| 1103 | 1139 | WHERE id_attach IN ({array_int:attachment_list})', |
| 1104 | 1140 | array( |
| 1105 | 1141 | 'attachment_list' => $attach, |
| 1106 | 1142 | ) |
| 1107 | 1143 | ); |
| 1144 | + } |
|
| 1108 | 1145 | |
| 1109 | 1146 | call_integration_hook('integrate_remove_attachments', array($attach)); |
| 1110 | 1147 | |
| 1111 | - if ($return_affected_messages) |
|
| 1112 | - return array_unique($msgs); |
|
| 1113 | -} |
|
| 1148 | + if ($return_affected_messages) { |
|
| 1149 | + return array_unique($msgs); |
|
| 1150 | + } |
|
| 1151 | + } |
|
| 1114 | 1152 | |
| 1115 | 1153 | /** |
| 1116 | 1154 | * This function should find attachments in the database that no longer exist and clear them, and fix filesize issues. |
@@ -1122,8 +1160,9 @@ discard block |
||
| 1122 | 1160 | checkSession('get'); |
| 1123 | 1161 | |
| 1124 | 1162 | // If we choose cancel, redirect right back. |
| 1125 | - if (isset($_POST['cancel'])) |
|
| 1126 | - redirectexit('action=admin;area=manageattachments;sa=maintenance'); |
|
| 1163 | + if (isset($_POST['cancel'])) { |
|
| 1164 | + redirectexit('action=admin;area=manageattachments;sa=maintenance'); |
|
| 1165 | + } |
|
| 1127 | 1166 | |
| 1128 | 1167 | // Try give us a while to sort this out... |
| 1129 | 1168 | @set_time_limit(600); |
@@ -1140,13 +1179,15 @@ discard block |
||
| 1140 | 1179 | if (isset($_GET['fixErrors'])) |
| 1141 | 1180 | { |
| 1142 | 1181 | // Nothing? |
| 1143 | - if (empty($_POST['to_fix'])) |
|
| 1144 | - redirectexit('action=admin;area=manageattachments;sa=maintenance'); |
|
| 1182 | + if (empty($_POST['to_fix'])) { |
|
| 1183 | + redirectexit('action=admin;area=manageattachments;sa=maintenance'); |
|
| 1184 | + } |
|
| 1145 | 1185 | |
| 1146 | 1186 | $_SESSION['attachments_to_fix'] = array(); |
| 1147 | 1187 | // @todo No need to do this I think. |
| 1148 | - foreach ($_POST['to_fix'] as $value) |
|
| 1149 | - $_SESSION['attachments_to_fix'][] = $value; |
|
| 1188 | + foreach ($_POST['to_fix'] as $value) { |
|
| 1189 | + $_SESSION['attachments_to_fix'][] = $value; |
|
| 1190 | + } |
|
| 1150 | 1191 | } |
| 1151 | 1192 | } |
| 1152 | 1193 | |
@@ -1213,13 +1254,14 @@ discard block |
||
| 1213 | 1254 | } |
| 1214 | 1255 | } |
| 1215 | 1256 | } |
| 1216 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
| 1217 | - $to_fix[] = 'missing_thumbnail_parent'; |
|
| 1257 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
| 1258 | + $to_fix[] = 'missing_thumbnail_parent'; |
|
| 1259 | + } |
|
| 1218 | 1260 | $smcFunc['db_free_result']($result); |
| 1219 | 1261 | |
| 1220 | 1262 | // Do we need to delete what we have? |
| 1221 | - if ($fix_errors && !empty($to_remove) && in_array('missing_thumbnail_parent', $to_fix)) |
|
| 1222 | - $smcFunc['db_query']('', ' |
|
| 1263 | + if ($fix_errors && !empty($to_remove) && in_array('missing_thumbnail_parent', $to_fix)) { |
|
| 1264 | + $smcFunc['db_query']('', ' |
|
| 1223 | 1265 | DELETE FROM {db_prefix}attachments |
| 1224 | 1266 | WHERE id_attach IN ({array_int:to_remove}) |
| 1225 | 1267 | AND attachment_type = {int:attachment_type}', |
@@ -1228,6 +1270,7 @@ discard block |
||
| 1228 | 1270 | 'attachment_type' => 3, |
| 1229 | 1271 | ) |
| 1230 | 1272 | ); |
| 1273 | + } |
|
| 1231 | 1274 | |
| 1232 | 1275 | pauseAttachmentMaintenance($to_fix, $thumbnails); |
| 1233 | 1276 | } |
@@ -1272,13 +1315,14 @@ discard block |
||
| 1272 | 1315 | $to_update[] = $row['id_attach']; |
| 1273 | 1316 | $context['repair_errors']['parent_missing_thumbnail']++; |
| 1274 | 1317 | } |
| 1275 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
| 1276 | - $to_fix[] = 'parent_missing_thumbnail'; |
|
| 1318 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
| 1319 | + $to_fix[] = 'parent_missing_thumbnail'; |
|
| 1320 | + } |
|
| 1277 | 1321 | $smcFunc['db_free_result']($result); |
| 1278 | 1322 | |
| 1279 | 1323 | // Do we need to delete what we have? |
| 1280 | - if ($fix_errors && !empty($to_update) && in_array('parent_missing_thumbnail', $to_fix)) |
|
| 1281 | - $smcFunc['db_query']('', ' |
|
| 1324 | + if ($fix_errors && !empty($to_update) && in_array('parent_missing_thumbnail', $to_fix)) { |
|
| 1325 | + $smcFunc['db_query']('', ' |
|
| 1282 | 1326 | UPDATE {db_prefix}attachments |
| 1283 | 1327 | SET id_thumb = {int:no_thumb} |
| 1284 | 1328 | WHERE id_attach IN ({array_int:to_update})', |
@@ -1287,6 +1331,7 @@ discard block |
||
| 1287 | 1331 | 'no_thumb' => 0, |
| 1288 | 1332 | ) |
| 1289 | 1333 | ); |
| 1334 | + } |
|
| 1290 | 1335 | |
| 1291 | 1336 | pauseAttachmentMaintenance($to_fix, $thumbnails); |
| 1292 | 1337 | } |
@@ -1324,10 +1369,11 @@ discard block |
||
| 1324 | 1369 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
| 1325 | 1370 | { |
| 1326 | 1371 | // Get the filename. |
| 1327 | - if ($row['attachment_type'] == 1) |
|
| 1328 | - $filename = $modSettings['custom_avatar_dir'] . '/' . $row['filename']; |
|
| 1329 | - else |
|
| 1330 | - $filename = getAttachmentFilename($row['filename'], $row['id_attach'], $row['id_folder'], false, $row['file_hash']); |
|
| 1372 | + if ($row['attachment_type'] == 1) { |
|
| 1373 | + $filename = $modSettings['custom_avatar_dir'] . '/' . $row['filename']; |
|
| 1374 | + } else { |
|
| 1375 | + $filename = getAttachmentFilename($row['filename'], $row['id_attach'], $row['id_folder'], false, $row['file_hash']); |
|
| 1376 | + } |
|
| 1331 | 1377 | |
| 1332 | 1378 | // File doesn't exist? |
| 1333 | 1379 | if (!file_exists($filename)) |
@@ -1339,15 +1385,16 @@ discard block |
||
| 1339 | 1385 | $attachment_name = $row['id_attach'] . '_' . $row['file_hash'] . '.dat'; |
| 1340 | 1386 | |
| 1341 | 1387 | // Loop through the other folders. |
| 1342 | - foreach ($modSettings['attachmentUploadDir'] as $id => $dir) |
|
| 1343 | - if (file_exists($dir . '/' . $attachment_name)) |
|
| 1388 | + foreach ($modSettings['attachmentUploadDir'] as $id => $dir) { |
|
| 1389 | + if (file_exists($dir . '/' . $attachment_name)) |
|
| 1344 | 1390 | { |
| 1345 | 1391 | $context['repair_errors']['wrong_folder']++; |
| 1392 | + } |
|
| 1346 | 1393 | $errors_found[] = 'wrong_folder'; |
| 1347 | 1394 | |
| 1348 | 1395 | // Are we going to fix this now? |
| 1349 | - if ($fix_errors && in_array('wrong_folder', $to_fix)) |
|
| 1350 | - $smcFunc['db_query']('', ' |
|
| 1396 | + if ($fix_errors && in_array('wrong_folder', $to_fix)) { |
|
| 1397 | + $smcFunc['db_query']('', ' |
|
| 1351 | 1398 | UPDATE {db_prefix}attachments |
| 1352 | 1399 | SET id_folder = {int:new_folder} |
| 1353 | 1400 | WHERE id_attach = {int:id_attach}', |
@@ -1356,6 +1403,7 @@ discard block |
||
| 1356 | 1403 | 'id_attach' => $row['id_attach'], |
| 1357 | 1404 | ) |
| 1358 | 1405 | ); |
| 1406 | + } |
|
| 1359 | 1407 | |
| 1360 | 1408 | continue 2; |
| 1361 | 1409 | } |
@@ -1364,8 +1412,7 @@ discard block |
||
| 1364 | 1412 | $to_remove[] = $row['id_attach']; |
| 1365 | 1413 | $context['repair_errors']['file_missing_on_disk']++; |
| 1366 | 1414 | $errors_found[] = 'file_missing_on_disk'; |
| 1367 | - } |
|
| 1368 | - elseif (filesize($filename) == 0) |
|
| 1415 | + } elseif (filesize($filename) == 0) |
|
| 1369 | 1416 | { |
| 1370 | 1417 | $context['repair_errors']['file_size_of_zero']++; |
| 1371 | 1418 | $errors_found[] = 'file_size_of_zero'; |
@@ -1376,8 +1423,7 @@ discard block |
||
| 1376 | 1423 | $to_remove[] = $row['id_attach']; |
| 1377 | 1424 | @unlink($filename); |
| 1378 | 1425 | } |
| 1379 | - } |
|
| 1380 | - elseif (filesize($filename) != $row['size']) |
|
| 1426 | + } elseif (filesize($filename) != $row['size']) |
|
| 1381 | 1427 | { |
| 1382 | 1428 | $context['repair_errors']['file_wrong_size']++; |
| 1383 | 1429 | $errors_found[] = 'file_wrong_size'; |
@@ -1398,14 +1444,18 @@ discard block |
||
| 1398 | 1444 | } |
| 1399 | 1445 | } |
| 1400 | 1446 | |
| 1401 | - if (in_array('file_missing_on_disk', $errors_found)) |
|
| 1402 | - $to_fix[] = 'file_missing_on_disk'; |
|
| 1403 | - if (in_array('file_size_of_zero', $errors_found)) |
|
| 1404 | - $to_fix[] = 'file_size_of_zero'; |
|
| 1405 | - if (in_array('file_wrong_size', $errors_found)) |
|
| 1406 | - $to_fix[] = 'file_wrong_size'; |
|
| 1407 | - if (in_array('wrong_folder', $errors_found)) |
|
| 1408 | - $to_fix[] = 'wrong_folder'; |
|
| 1447 | + if (in_array('file_missing_on_disk', $errors_found)) { |
|
| 1448 | + $to_fix[] = 'file_missing_on_disk'; |
|
| 1449 | + } |
|
| 1450 | + if (in_array('file_size_of_zero', $errors_found)) { |
|
| 1451 | + $to_fix[] = 'file_size_of_zero'; |
|
| 1452 | + } |
|
| 1453 | + if (in_array('file_wrong_size', $errors_found)) { |
|
| 1454 | + $to_fix[] = 'file_wrong_size'; |
|
| 1455 | + } |
|
| 1456 | + if (in_array('wrong_folder', $errors_found)) { |
|
| 1457 | + $to_fix[] = 'wrong_folder'; |
|
| 1458 | + } |
|
| 1409 | 1459 | $smcFunc['db_free_result']($result); |
| 1410 | 1460 | |
| 1411 | 1461 | // Do we need to delete what we have? |
@@ -1475,20 +1525,22 @@ discard block |
||
| 1475 | 1525 | // If we are repairing remove the file from disk now. |
| 1476 | 1526 | if ($fix_errors && in_array('avatar_no_member', $to_fix)) |
| 1477 | 1527 | { |
| 1478 | - if ($row['attachment_type'] == 1) |
|
| 1479 | - $filename = $modSettings['custom_avatar_dir'] . '/' . $row['filename']; |
|
| 1480 | - else |
|
| 1481 | - $filename = getAttachmentFilename($row['filename'], $row['id_attach'], $row['id_folder'], false, $row['file_hash']); |
|
| 1528 | + if ($row['attachment_type'] == 1) { |
|
| 1529 | + $filename = $modSettings['custom_avatar_dir'] . '/' . $row['filename']; |
|
| 1530 | + } else { |
|
| 1531 | + $filename = getAttachmentFilename($row['filename'], $row['id_attach'], $row['id_folder'], false, $row['file_hash']); |
|
| 1532 | + } |
|
| 1482 | 1533 | @unlink($filename); |
| 1483 | 1534 | } |
| 1484 | 1535 | } |
| 1485 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
| 1486 | - $to_fix[] = 'avatar_no_member'; |
|
| 1536 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
| 1537 | + $to_fix[] = 'avatar_no_member'; |
|
| 1538 | + } |
|
| 1487 | 1539 | $smcFunc['db_free_result']($result); |
| 1488 | 1540 | |
| 1489 | 1541 | // Do we need to delete what we have? |
| 1490 | - if ($fix_errors && !empty($to_remove) && in_array('avatar_no_member', $to_fix)) |
|
| 1491 | - $smcFunc['db_query']('', ' |
|
| 1542 | + if ($fix_errors && !empty($to_remove) && in_array('avatar_no_member', $to_fix)) { |
|
| 1543 | + $smcFunc['db_query']('', ' |
|
| 1492 | 1544 | DELETE FROM {db_prefix}attachments |
| 1493 | 1545 | WHERE id_attach IN ({array_int:to_remove}) |
| 1494 | 1546 | AND id_member != {int:no_member} |
@@ -1499,6 +1551,7 @@ discard block |
||
| 1499 | 1551 | 'no_msg' => 0, |
| 1500 | 1552 | ) |
| 1501 | 1553 | ); |
| 1554 | + } |
|
| 1502 | 1555 | |
| 1503 | 1556 | pauseAttachmentMaintenance($to_fix, $thumbnails); |
| 1504 | 1557 | } |
@@ -1558,13 +1611,14 @@ discard block |
||
| 1558 | 1611 | @unlink($filename); |
| 1559 | 1612 | } |
| 1560 | 1613 | } |
| 1561 | - if ($smcFunc['db_num_rows']($result) != 0) |
|
| 1562 | - $to_fix[] = 'attachment_no_msg'; |
|
| 1614 | + if ($smcFunc['db_num_rows']($result) != 0) { |
|
| 1615 | + $to_fix[] = 'attachment_no_msg'; |
|
| 1616 | + } |
|
| 1563 | 1617 | $smcFunc['db_free_result']($result); |
| 1564 | 1618 | |
| 1565 | 1619 | // Do we need to delete what we have? |
| 1566 | - if ($fix_errors && !empty($to_remove) && in_array('attachment_no_msg', $to_fix)) |
|
| 1567 | - $smcFunc['db_query']('', ' |
|
| 1620 | + if ($fix_errors && !empty($to_remove) && in_array('attachment_no_msg', $to_fix)) { |
|
| 1621 | + $smcFunc['db_query']('', ' |
|
| 1568 | 1622 | DELETE FROM {db_prefix}attachments |
| 1569 | 1623 | WHERE id_attach IN ({array_int:to_remove}) |
| 1570 | 1624 | AND id_member = {int:no_member} |
@@ -1575,6 +1629,7 @@ discard block |
||
| 1575 | 1629 | 'attach_thumb' => array(0,3), |
| 1576 | 1630 | ) |
| 1577 | 1631 | ); |
| 1632 | + } |
|
| 1578 | 1633 | |
| 1579 | 1634 | pauseAttachmentMaintenance($to_fix, $thumbnails); |
| 1580 | 1635 | } |
@@ -1598,8 +1653,9 @@ discard block |
||
| 1598 | 1653 | { |
| 1599 | 1654 | while ($file = readdir($dir)) |
| 1600 | 1655 | { |
| 1601 | - if (in_array($file, array('.', '..', '.htaccess', 'index.php'))) |
|
| 1602 | - continue; |
|
| 1656 | + if (in_array($file, array('.', '..', '.htaccess', 'index.php'))) { |
|
| 1657 | + continue; |
|
| 1658 | + } |
|
| 1603 | 1659 | |
| 1604 | 1660 | if ($files_checked <= $current_check) |
| 1605 | 1661 | { |
@@ -1607,8 +1663,9 @@ discard block |
||
| 1607 | 1663 | if (strpos($file, 'post_tmp_') !== false) |
| 1608 | 1664 | { |
| 1609 | 1665 | // Temp file is more than 5 hours old! |
| 1610 | - if (filemtime($attach_dir . '/' . $file) < time() - 18000) |
|
| 1611 | - @unlink($attach_dir . '/' . $file); |
|
| 1666 | + if (filemtime($attach_dir . '/' . $file) < time() - 18000) { |
|
| 1667 | + @unlink($attach_dir . '/' . $file); |
|
| 1668 | + } |
|
| 1612 | 1669 | } |
| 1613 | 1670 | // That should be an attachment, let's check if we have it in the database |
| 1614 | 1671 | elseif (strpos($file, '_') !== false) |
@@ -1630,8 +1687,7 @@ discard block |
||
| 1630 | 1687 | if ($fix_errors && in_array('files_without_attachment', $to_fix)) |
| 1631 | 1688 | { |
| 1632 | 1689 | @unlink($attach_dir . '/' . $file); |
| 1633 | - } |
|
| 1634 | - else |
|
| 1690 | + } else |
|
| 1635 | 1691 | { |
| 1636 | 1692 | $context['repair_errors']['files_without_attachment']++; |
| 1637 | 1693 | $to_fix[] = 'files_without_attachment'; |
@@ -1639,14 +1695,12 @@ discard block |
||
| 1639 | 1695 | } |
| 1640 | 1696 | $smcFunc['db_free_result']($request); |
| 1641 | 1697 | } |
| 1642 | - } |
|
| 1643 | - else |
|
| 1698 | + } else |
|
| 1644 | 1699 | { |
| 1645 | 1700 | if ($fix_errors && in_array('files_without_attachment', $to_fix)) |
| 1646 | 1701 | { |
| 1647 | 1702 | @unlink($attach_dir . '/' . $file); |
| 1648 | - } |
|
| 1649 | - else |
|
| 1703 | + } else |
|
| 1650 | 1704 | { |
| 1651 | 1705 | $context['repair_errors']['files_without_attachment']++; |
| 1652 | 1706 | $to_fix[] = 'files_without_attachment'; |
@@ -1655,8 +1709,9 @@ discard block |
||
| 1655 | 1709 | } |
| 1656 | 1710 | $current_check++; |
| 1657 | 1711 | $_GET['substep'] = $current_check; |
| 1658 | - if ($current_check - $files_checked >= $max_checks) |
|
| 1659 | - pauseAttachmentMaintenance($to_fix); |
|
| 1712 | + if ($current_check - $files_checked >= $max_checks) { |
|
| 1713 | + pauseAttachmentMaintenance($to_fix); |
|
| 1714 | + } |
|
| 1660 | 1715 | } |
| 1661 | 1716 | closedir($dir); |
| 1662 | 1717 | } |
@@ -1692,12 +1747,14 @@ discard block |
||
| 1692 | 1747 | |
| 1693 | 1748 | // Try get more time... |
| 1694 | 1749 | @set_time_limit(600); |
| 1695 | - if (function_exists('apache_reset_timeout')) |
|
| 1696 | - @apache_reset_timeout(); |
|
| 1750 | + if (function_exists('apache_reset_timeout')) { |
|
| 1751 | + @apache_reset_timeout(); |
|
| 1752 | + } |
|
| 1697 | 1753 | |
| 1698 | 1754 | // Have we already used our maximum time? |
| 1699 | - if (time() - array_sum(explode(' ', $time_start)) < 3 || $context['starting_substep'] == $_GET['substep']) |
|
| 1700 | - return; |
|
| 1755 | + if (time() - array_sum(explode(' ', $time_start)) < 3 || $context['starting_substep'] == $_GET['substep']) { |
|
| 1756 | + return; |
|
| 1757 | + } |
|
| 1701 | 1758 | |
| 1702 | 1759 | $context['continue_get_data'] = '?action=admin;area=manageattachments;sa=repair' . (isset($_GET['fixErrors']) ? ';fixErrors' : '') . ';step=' . $_GET['step'] . ';substep=' . $_GET['substep'] . ';' . $context['session_var'] . '=' . $context['session_id']; |
| 1703 | 1760 | $context['page_title'] = $txt['not_done_title']; |
@@ -1709,10 +1766,11 @@ discard block |
||
| 1709 | 1766 | $context[$context['admin_menu_name']]['current_subsection'] = 'maintenance'; |
| 1710 | 1767 | |
| 1711 | 1768 | // Change these two if more steps are added! |
| 1712 | - if (empty($max_substep)) |
|
| 1713 | - $context['continue_percent'] = round(($_GET['step'] * 100) / 25); |
|
| 1714 | - else |
|
| 1715 | - $context['continue_percent'] = round(($_GET['step'] * 100 + ($_GET['substep'] * 100) / $max_substep) / 25); |
|
| 1769 | + if (empty($max_substep)) { |
|
| 1770 | + $context['continue_percent'] = round(($_GET['step'] * 100) / 25); |
|
| 1771 | + } else { |
|
| 1772 | + $context['continue_percent'] = round(($_GET['step'] * 100 + ($_GET['substep'] * 100) / $max_substep) / 25); |
|
| 1773 | + } |
|
| 1716 | 1774 | |
| 1717 | 1775 | // Never more than 100%! |
| 1718 | 1776 | $context['continue_percent'] = min($context['continue_percent'], 100); |
@@ -1754,15 +1812,17 @@ discard block |
||
| 1754 | 1812 | 'attachment_type' => 0, |
| 1755 | 1813 | ) |
| 1756 | 1814 | ); |
| 1757 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1758 | - $attachments[] = $row['id_attach']; |
|
| 1815 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1816 | + $attachments[] = $row['id_attach']; |
|
| 1817 | + } |
|
| 1759 | 1818 | $smcFunc['db_free_result']($request); |
| 1819 | + } elseif (!empty($_GET['aid'])) { |
|
| 1820 | + $attachments[] = (int) $_GET['aid']; |
|
| 1760 | 1821 | } |
| 1761 | - elseif (!empty($_GET['aid'])) |
|
| 1762 | - $attachments[] = (int) $_GET['aid']; |
|
| 1763 | 1822 | |
| 1764 | - if (empty($attachments)) |
|
| 1765 | - fatal_lang_error('no_access', false); |
|
| 1823 | + if (empty($attachments)) { |
|
| 1824 | + fatal_lang_error('no_access', false); |
|
| 1825 | + } |
|
| 1766 | 1826 | |
| 1767 | 1827 | // Now we have some ID's cleaned and ready to approve, but first - let's check we have permission! |
| 1768 | 1828 | $allowed_boards = boardsAllowedTo('approve_posts'); |
@@ -1795,17 +1855,18 @@ discard block |
||
| 1795 | 1855 | } |
| 1796 | 1856 | $smcFunc['db_free_result']($request); |
| 1797 | 1857 | |
| 1798 | - if (empty($attachments)) |
|
| 1799 | - fatal_lang_error('no_access', false); |
|
| 1858 | + if (empty($attachments)) { |
|
| 1859 | + fatal_lang_error('no_access', false); |
|
| 1860 | + } |
|
| 1800 | 1861 | |
| 1801 | 1862 | // Finally, we are there. Follow through! |
| 1802 | 1863 | if ($is_approve) |
| 1803 | 1864 | { |
| 1804 | 1865 | // Checked and deemed worthy. |
| 1805 | 1866 | ApproveAttachments($attachments); |
| 1867 | + } else { |
|
| 1868 | + removeAttachments(array('id_attach' => $attachments, 'do_logging' => true)); |
|
| 1806 | 1869 | } |
| 1807 | - else |
|
| 1808 | - removeAttachments(array('id_attach' => $attachments, 'do_logging' => true)); |
|
| 1809 | 1870 | |
| 1810 | 1871 | // Return to the topic.... |
| 1811 | 1872 | redirectexit($redirect); |
@@ -1821,8 +1882,9 @@ discard block |
||
| 1821 | 1882 | { |
| 1822 | 1883 | global $smcFunc; |
| 1823 | 1884 | |
| 1824 | - if (empty($attachments)) |
|
| 1825 | - return 0; |
|
| 1885 | + if (empty($attachments)) { |
|
| 1886 | + return 0; |
|
| 1887 | + } |
|
| 1826 | 1888 | |
| 1827 | 1889 | // For safety, check for thumbnails... |
| 1828 | 1890 | $request = $smcFunc['db_query']('', ' |
@@ -1841,15 +1903,17 @@ discard block |
||
| 1841 | 1903 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1842 | 1904 | { |
| 1843 | 1905 | // Update the thumbnail too... |
| 1844 | - if (!empty($row['id_thumb'])) |
|
| 1845 | - $attachments[] = $row['id_thumb']; |
|
| 1906 | + if (!empty($row['id_thumb'])) { |
|
| 1907 | + $attachments[] = $row['id_thumb']; |
|
| 1908 | + } |
|
| 1846 | 1909 | |
| 1847 | 1910 | $attachments[] = $row['id_attach']; |
| 1848 | 1911 | } |
| 1849 | 1912 | $smcFunc['db_free_result']($request); |
| 1850 | 1913 | |
| 1851 | - if (empty($attachments)) |
|
| 1852 | - return 0; |
|
| 1914 | + if (empty($attachments)) { |
|
| 1915 | + return 0; |
|
| 1916 | + } |
|
| 1853 | 1917 | |
| 1854 | 1918 | // Approving an attachment is not hard - it's easy. |
| 1855 | 1919 | $smcFunc['db_query']('', ' |
@@ -1875,14 +1939,15 @@ discard block |
||
| 1875 | 1939 | ) |
| 1876 | 1940 | ); |
| 1877 | 1941 | |
| 1878 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1879 | - logAction( |
|
| 1942 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1943 | + logAction( |
|
| 1880 | 1944 | 'approve_attach', |
| 1881 | 1945 | array( |
| 1882 | 1946 | 'message' => $row['id_msg'], |
| 1883 | 1947 | 'filename' => preg_replace('~&#(\\d{1,7}|x[0-9a-fA-F]{1,6});~', '&#\\1;', $smcFunc['htmlspecialchars']($row['filename'])), |
| 1884 | 1948 | ) |
| 1885 | 1949 | ); |
| 1950 | + } |
|
| 1886 | 1951 | $smcFunc['db_free_result']($request); |
| 1887 | 1952 | |
| 1888 | 1953 | // Remove from the approval queue. |
@@ -1905,11 +1970,11 @@ discard block |
||
| 1905 | 1970 | global $modSettings, $scripturl, $context, $txt, $sourcedir, $boarddir, $smcFunc, $settings; |
| 1906 | 1971 | |
| 1907 | 1972 | // Since this needs to be done eventually. |
| 1908 | - if (!isset($modSettings['attachment_basedirectories'])) |
|
| 1909 | - $modSettings['attachment_basedirectories'] = array(); |
|
| 1910 | - |
|
| 1911 | - elseif (!is_array($modSettings['attachment_basedirectories'])) |
|
| 1912 | - $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
|
| 1973 | + if (!isset($modSettings['attachment_basedirectories'])) { |
|
| 1974 | + $modSettings['attachment_basedirectories'] = array(); |
|
| 1975 | + } elseif (!is_array($modSettings['attachment_basedirectories'])) { |
|
| 1976 | + $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
|
| 1977 | + } |
|
| 1913 | 1978 | |
| 1914 | 1979 | $errors = array(); |
| 1915 | 1980 | |
@@ -1924,8 +1989,9 @@ discard block |
||
| 1924 | 1989 | { |
| 1925 | 1990 | $error = ''; |
| 1926 | 1991 | $id = (int) $id; |
| 1927 | - if ($id < 1) |
|
| 1928 | - continue; |
|
| 1992 | + if ($id < 1) { |
|
| 1993 | + continue; |
|
| 1994 | + } |
|
| 1929 | 1995 | |
| 1930 | 1996 | // Sorry, these dirs are NOT valid |
| 1931 | 1997 | $invalid_dirs = array($boarddir, $settings['default_theme_dir'], $sourcedir); |
@@ -1944,8 +2010,7 @@ discard block |
||
| 1944 | 2010 | { |
| 1945 | 2011 | $errors[] = $path . ': ' . $txt['attach_dir_duplicate_msg']; |
| 1946 | 2012 | continue; |
| 1947 | - } |
|
| 1948 | - elseif (empty($path)) |
|
| 2013 | + } elseif (empty($path)) |
|
| 1949 | 2014 | { |
| 1950 | 2015 | // Ignore this and set $id to one less |
| 1951 | 2016 | continue; |
@@ -1953,10 +2018,11 @@ discard block |
||
| 1953 | 2018 | |
| 1954 | 2019 | // OK, so let's try to create it then. |
| 1955 | 2020 | require_once($sourcedir . '/Subs-Attachments.php'); |
| 1956 | - if (automanage_attachments_create_directory($path)) |
|
| 1957 | - $_POST['current_dir'] = $modSettings['currentAttachmentUploadDir']; |
|
| 1958 | - else |
|
| 1959 | - $errors[] = $path . ': ' . $txt[$context['dir_creation_error']]; |
|
| 2021 | + if (automanage_attachments_create_directory($path)) { |
|
| 2022 | + $_POST['current_dir'] = $modSettings['currentAttachmentUploadDir']; |
|
| 2023 | + } else { |
|
| 2024 | + $errors[] = $path . ': ' . $txt[$context['dir_creation_error']]; |
|
| 2025 | + } |
|
| 1960 | 2026 | } |
| 1961 | 2027 | |
| 1962 | 2028 | // Changing a directory name? |
@@ -1969,8 +2035,7 @@ discard block |
||
| 1969 | 2035 | $errors[] = $path . ': ' . $txt['attach_dir_no_rename']; |
| 1970 | 2036 | $path = $modSettings['attachmentUploadDir'][$id]; |
| 1971 | 2037 | } |
| 1972 | - } |
|
| 1973 | - else |
|
| 2038 | + } else |
|
| 1974 | 2039 | { |
| 1975 | 2040 | $errors[] = $path . ': ' . $txt['attach_dir_exists_msg']; |
| 1976 | 2041 | $path = $modSettings['attachmentUploadDir'][$id]; |
@@ -1995,12 +2060,13 @@ discard block |
||
| 1995 | 2060 | $path = $modSettings['attachmentUploadDir'][$id]; |
| 1996 | 2061 | |
| 1997 | 2062 | // It's not a good idea to delete the current directory. |
| 1998 | - if ($id == (!empty($_POST['current_dir']) ? $_POST['current_dir'] : $modSettings['currentAttachmentUploadDir'])) |
|
| 1999 | - $errors[] = $path . ': ' . $txt['attach_dir_is_current']; |
|
| 2063 | + if ($id == (!empty($_POST['current_dir']) ? $_POST['current_dir'] : $modSettings['currentAttachmentUploadDir'])) { |
|
| 2064 | + $errors[] = $path . ': ' . $txt['attach_dir_is_current']; |
|
| 2065 | + } |
|
| 2000 | 2066 | // Or the current base directory |
| 2001 | - elseif (!empty($modSettings['basedirectory_for_attachments']) && $modSettings['basedirectory_for_attachments'] == $modSettings['attachmentUploadDir'][$id]) |
|
| 2002 | - $errors[] = $path . ': ' . $txt['attach_dir_is_current_bd']; |
|
| 2003 | - else |
|
| 2067 | + elseif (!empty($modSettings['basedirectory_for_attachments']) && $modSettings['basedirectory_for_attachments'] == $modSettings['attachmentUploadDir'][$id]) { |
|
| 2068 | + $errors[] = $path . ': ' . $txt['attach_dir_is_current_bd']; |
|
| 2069 | + } else |
|
| 2004 | 2070 | { |
| 2005 | 2071 | // Let's not try to delete a path with files in it. |
| 2006 | 2072 | $request = $smcFunc['db_query']('', ' |
@@ -2019,17 +2085,18 @@ discard block |
||
| 2019 | 2085 | if (!empty($modSettings['attachment_basedirectories'])) |
| 2020 | 2086 | { |
| 2021 | 2087 | // Count any sub-folders. |
| 2022 | - foreach ($modSettings['attachmentUploadDir'] as $sub) |
|
| 2023 | - if (strpos($sub, $path . DIRECTORY_SEPARATOR) !== false) |
|
| 2088 | + foreach ($modSettings['attachmentUploadDir'] as $sub) { |
|
| 2089 | + if (strpos($sub, $path . DIRECTORY_SEPARATOR) !== false) |
|
| 2024 | 2090 | $num_attach++; |
| 2091 | + } |
|
| 2025 | 2092 | } |
| 2026 | 2093 | |
| 2027 | 2094 | // It's safe to delete. So try to delete the folder also |
| 2028 | 2095 | if ($num_attach == 0) |
| 2029 | 2096 | { |
| 2030 | - if (is_dir($path)) |
|
| 2031 | - $doit = true; |
|
| 2032 | - elseif (is_dir($boarddir . DIRECTORY_SEPARATOR . $path)) |
|
| 2097 | + if (is_dir($path)) { |
|
| 2098 | + $doit = true; |
|
| 2099 | + } elseif (is_dir($boarddir . DIRECTORY_SEPARATOR . $path)) |
|
| 2033 | 2100 | { |
| 2034 | 2101 | $doit = true; |
| 2035 | 2102 | $path = $boarddir . DIRECTORY_SEPARATOR . $path; |
@@ -2039,8 +2106,9 @@ discard block |
||
| 2039 | 2106 | { |
| 2040 | 2107 | unlink($path . '/.htaccess'); |
| 2041 | 2108 | unlink($path . '/index.php'); |
| 2042 | - if (!@rmdir($path)) |
|
| 2043 | - $error = $path . ': ' . $txt['attach_dir_no_delete']; |
|
| 2109 | + if (!@rmdir($path)) { |
|
| 2110 | + $error = $path . ': ' . $txt['attach_dir_no_delete']; |
|
| 2111 | + } |
|
| 2044 | 2112 | } |
| 2045 | 2113 | |
| 2046 | 2114 | // Remove it from the base directory list. |
@@ -2050,14 +2118,15 @@ discard block |
||
| 2050 | 2118 | updateSettings(array('attachment_basedirectories' => json_encode($modSettings['attachment_basedirectories']))); |
| 2051 | 2119 | $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
| 2052 | 2120 | } |
| 2121 | + } else { |
|
| 2122 | + $error = $path . ': ' . $txt['attach_dir_no_remove']; |
|
| 2053 | 2123 | } |
| 2054 | - else |
|
| 2055 | - $error = $path . ': ' . $txt['attach_dir_no_remove']; |
|
| 2056 | 2124 | |
| 2057 | - if (empty($error)) |
|
| 2058 | - continue; |
|
| 2059 | - else |
|
| 2060 | - $errors[] = $error; |
|
| 2125 | + if (empty($error)) { |
|
| 2126 | + continue; |
|
| 2127 | + } else { |
|
| 2128 | + $errors[] = $error; |
|
| 2129 | + } |
|
| 2061 | 2130 | } |
| 2062 | 2131 | } |
| 2063 | 2132 | |
@@ -2065,23 +2134,26 @@ discard block |
||
| 2065 | 2134 | } |
| 2066 | 2135 | |
| 2067 | 2136 | // We need to make sure the current directory is right. |
| 2068 | - if (empty($_POST['current_dir']) && !empty($modSettings['currentAttachmentUploadDir'])) |
|
| 2069 | - $_POST['current_dir'] = $modSettings['currentAttachmentUploadDir']; |
|
| 2137 | + if (empty($_POST['current_dir']) && !empty($modSettings['currentAttachmentUploadDir'])) { |
|
| 2138 | + $_POST['current_dir'] = $modSettings['currentAttachmentUploadDir']; |
|
| 2139 | + } |
|
| 2070 | 2140 | |
| 2071 | 2141 | // Find the current directory if there's no value carried, |
| 2072 | 2142 | if (empty($_POST['current_dir']) || empty($new_dirs[$_POST['current_dir']])) |
| 2073 | 2143 | { |
| 2074 | - if (array_key_exists($modSettings['currentAttachmentUploadDir'], $modSettings['attachmentUploadDir'])) |
|
| 2075 | - $_POST['current_dir'] = $modSettings['currentAttachmentUploadDir']; |
|
| 2076 | - else |
|
| 2077 | - $_POST['current_dir'] = max(array_keys($modSettings['attachmentUploadDir'])); |
|
| 2144 | + if (array_key_exists($modSettings['currentAttachmentUploadDir'], $modSettings['attachmentUploadDir'])) { |
|
| 2145 | + $_POST['current_dir'] = $modSettings['currentAttachmentUploadDir']; |
|
| 2146 | + } else { |
|
| 2147 | + $_POST['current_dir'] = max(array_keys($modSettings['attachmentUploadDir'])); |
|
| 2148 | + } |
|
| 2078 | 2149 | } |
| 2079 | 2150 | |
| 2080 | 2151 | // If the user wishes to go back, update the last_dir array |
| 2081 | 2152 | if ($_POST['current_dir'] != $modSettings['currentAttachmentUploadDir'] && !empty($modSettings['last_attachments_directory']) && (isset($modSettings['last_attachments_directory'][$_POST['current_dir']]) || isset($modSettings['last_attachments_directory'][0]))) |
| 2082 | 2153 | { |
| 2083 | - if (!is_array($modSettings['last_attachments_directory'])) |
|
| 2084 | - $modSettings['last_attachments_directory'] = smf_json_decode($modSettings['last_attachments_directory'], true); |
|
| 2154 | + if (!is_array($modSettings['last_attachments_directory'])) { |
|
| 2155 | + $modSettings['last_attachments_directory'] = smf_json_decode($modSettings['last_attachments_directory'], true); |
|
| 2156 | + } |
|
| 2085 | 2157 | $num = substr(strrchr($modSettings['attachmentUploadDir'][$_POST['current_dir']], '_'), 1); |
| 2086 | 2158 | |
| 2087 | 2159 | if (is_numeric($num)) |
@@ -2089,16 +2161,18 @@ discard block |
||
| 2089 | 2161 | // Need to find the base folder. |
| 2090 | 2162 | $bid = -1; |
| 2091 | 2163 | $use_subdirectories_for_attachments = 0; |
| 2092 | - if (!empty($modSettings['attachment_basedirectories'])) |
|
| 2093 | - foreach ($modSettings['attachment_basedirectories'] as $bid => $base) |
|
| 2164 | + if (!empty($modSettings['attachment_basedirectories'])) { |
|
| 2165 | + foreach ($modSettings['attachment_basedirectories'] as $bid => $base) |
|
| 2094 | 2166 | if (strpos($modSettings['attachmentUploadDir'][$_POST['current_dir']], $base . DIRECTORY_SEPARATOR) !== false) |
| 2095 | 2167 | { |
| 2096 | 2168 | $use_subdirectories_for_attachments = 1; |
| 2169 | + } |
|
| 2097 | 2170 | break; |
| 2098 | 2171 | } |
| 2099 | 2172 | |
| 2100 | - if ($use_subdirectories_for_attachments == 0 && strpos($modSettings['attachmentUploadDir'][$_POST['current_dir']], $boarddir . DIRECTORY_SEPARATOR) !== false) |
|
| 2101 | - $bid = 0; |
|
| 2173 | + if ($use_subdirectories_for_attachments == 0 && strpos($modSettings['attachmentUploadDir'][$_POST['current_dir']], $boarddir . DIRECTORY_SEPARATOR) !== false) { |
|
| 2174 | + $bid = 0; |
|
| 2175 | + } |
|
| 2102 | 2176 | |
| 2103 | 2177 | $modSettings['last_attachments_directory'][$bid] = (int) $num; |
| 2104 | 2178 | $modSettings['basedirectory_for_attachments'] = !empty($modSettings['basedirectory_for_attachments']) ? $modSettings['basedirectory_for_attachments'] : ''; |
@@ -2117,8 +2191,8 @@ discard block |
||
| 2117 | 2191 | // We might need to reset the paths. This loop will just loop through once. |
| 2118 | 2192 | foreach ($new_dirs as $id => $dir) |
| 2119 | 2193 | { |
| 2120 | - if ($id != 1) |
|
| 2121 | - $smcFunc['db_query']('', ' |
|
| 2194 | + if ($id != 1) { |
|
| 2195 | + $smcFunc['db_query']('', ' |
|
| 2122 | 2196 | UPDATE {db_prefix}attachments |
| 2123 | 2197 | SET id_folder = {int:default_folder} |
| 2124 | 2198 | WHERE id_folder = {int:current_folder}', |
@@ -2127,14 +2201,14 @@ discard block |
||
| 2127 | 2201 | 'current_folder' => $id, |
| 2128 | 2202 | ) |
| 2129 | 2203 | ); |
| 2204 | + } |
|
| 2130 | 2205 | |
| 2131 | 2206 | $update = array( |
| 2132 | 2207 | 'currentAttachmentUploadDir' => 1, |
| 2133 | 2208 | 'attachmentUploadDir' => json_encode(array(1 => $dir)), |
| 2134 | 2209 | ); |
| 2135 | 2210 | } |
| 2136 | - } |
|
| 2137 | - else |
|
| 2211 | + } else |
|
| 2138 | 2212 | { |
| 2139 | 2213 | // Save it to the database. |
| 2140 | 2214 | $update = array( |
@@ -2143,11 +2217,13 @@ discard block |
||
| 2143 | 2217 | ); |
| 2144 | 2218 | } |
| 2145 | 2219 | |
| 2146 | - if (!empty($update)) |
|
| 2147 | - updateSettings($update); |
|
| 2220 | + if (!empty($update)) { |
|
| 2221 | + updateSettings($update); |
|
| 2222 | + } |
|
| 2148 | 2223 | |
| 2149 | - if (!empty($errors)) |
|
| 2150 | - $_SESSION['errors']['dir'] = $errors; |
|
| 2224 | + if (!empty($errors)) { |
|
| 2225 | + $_SESSION['errors']['dir'] = $errors; |
|
| 2226 | + } |
|
| 2151 | 2227 | |
| 2152 | 2228 | redirectexit('action=admin;area=manageattachments;sa=attachpaths;' . $context['session_var'] . '=' . $context['session_id']); |
| 2153 | 2229 | } |
@@ -2161,10 +2237,11 @@ discard block |
||
| 2161 | 2237 | $_POST['current_base_dir'] = isset($_POST['current_base_dir']) ? (int) $_POST['current_base_dir'] : 1; |
| 2162 | 2238 | if (empty($_POST['new_base_dir']) && !empty($_POST['current_base_dir'])) |
| 2163 | 2239 | { |
| 2164 | - if ($modSettings['basedirectory_for_attachments'] != $modSettings['attachmentUploadDir'][$_POST['current_base_dir']]) |
|
| 2165 | - $update = (array( |
|
| 2240 | + if ($modSettings['basedirectory_for_attachments'] != $modSettings['attachmentUploadDir'][$_POST['current_base_dir']]) { |
|
| 2241 | + $update = (array( |
|
| 2166 | 2242 | 'basedirectory_for_attachments' => $modSettings['attachmentUploadDir'][$_POST['current_base_dir']], |
| 2167 | 2243 | )); |
| 2244 | + } |
|
| 2168 | 2245 | } |
| 2169 | 2246 | |
| 2170 | 2247 | if (isset($_POST['base_dir'])) |
@@ -2212,13 +2289,15 @@ discard block |
||
| 2212 | 2289 | |
| 2213 | 2290 | if (!in_array($_POST['new_base_dir'], $modSettings['attachmentUploadDir'])) |
| 2214 | 2291 | { |
| 2215 | - if (!automanage_attachments_create_directory($_POST['new_base_dir'])) |
|
| 2216 | - $errors[] = $_POST['new_base_dir'] . ': ' . $txt['attach_dir_base_no_create']; |
|
| 2292 | + if (!automanage_attachments_create_directory($_POST['new_base_dir'])) { |
|
| 2293 | + $errors[] = $_POST['new_base_dir'] . ': ' . $txt['attach_dir_base_no_create']; |
|
| 2294 | + } |
|
| 2217 | 2295 | } |
| 2218 | 2296 | |
| 2219 | 2297 | $modSettings['currentAttachmentUploadDir'] = array_search($_POST['new_base_dir'], $modSettings['attachmentUploadDir']); |
| 2220 | - if (!in_array($_POST['new_base_dir'], $modSettings['attachment_basedirectories'])) |
|
| 2221 | - $modSettings['attachment_basedirectories'][$modSettings['currentAttachmentUploadDir']] = $_POST['new_base_dir']; |
|
| 2298 | + if (!in_array($_POST['new_base_dir'], $modSettings['attachment_basedirectories'])) { |
|
| 2299 | + $modSettings['attachment_basedirectories'][$modSettings['currentAttachmentUploadDir']] = $_POST['new_base_dir']; |
|
| 2300 | + } |
|
| 2222 | 2301 | ksort($modSettings['attachment_basedirectories']); |
| 2223 | 2302 | |
| 2224 | 2303 | $update = (array( |
@@ -2228,11 +2307,13 @@ discard block |
||
| 2228 | 2307 | )); |
| 2229 | 2308 | } |
| 2230 | 2309 | |
| 2231 | - if (!empty($errors)) |
|
| 2232 | - $_SESSION['errors']['base'] = $errors; |
|
| 2310 | + if (!empty($errors)) { |
|
| 2311 | + $_SESSION['errors']['base'] = $errors; |
|
| 2312 | + } |
|
| 2233 | 2313 | |
| 2234 | - if (!empty($update)) |
|
| 2235 | - updateSettings($update); |
|
| 2314 | + if (!empty($update)) { |
|
| 2315 | + updateSettings($update); |
|
| 2316 | + } |
|
| 2236 | 2317 | |
| 2237 | 2318 | redirectexit('action=admin;area=manageattachments;sa=attachpaths;' . $context['session_var'] . '=' . $context['session_id']); |
| 2238 | 2319 | } |
@@ -2242,13 +2323,15 @@ discard block |
||
| 2242 | 2323 | if (is_array($_SESSION['errors'])) |
| 2243 | 2324 | { |
| 2244 | 2325 | $errors = array(); |
| 2245 | - if (!empty($_SESSION['errors']['dir'])) |
|
| 2246 | - foreach ($_SESSION['errors']['dir'] as $error) |
|
| 2326 | + if (!empty($_SESSION['errors']['dir'])) { |
|
| 2327 | + foreach ($_SESSION['errors']['dir'] as $error) |
|
| 2247 | 2328 | $errors['dir'][] = $smcFunc['htmlspecialchars']($error, ENT_QUOTES); |
| 2329 | + } |
|
| 2248 | 2330 | |
| 2249 | - if (!empty($_SESSION['errors']['base'])) |
|
| 2250 | - foreach ($_SESSION['errors']['base'] as $error) |
|
| 2331 | + if (!empty($_SESSION['errors']['base'])) { |
|
| 2332 | + foreach ($_SESSION['errors']['base'] as $error) |
|
| 2251 | 2333 | $errors['base'][] = $smcFunc['htmlspecialchars']($error, ENT_QUOTES); |
| 2334 | + } |
|
| 2252 | 2335 | } |
| 2253 | 2336 | unset($_SESSION['errors']); |
| 2254 | 2337 | } |
@@ -2458,8 +2541,9 @@ discard block |
||
| 2458 | 2541 | foreach ($modSettings['attachmentUploadDir'] as $id => $dir) |
| 2459 | 2542 | { |
| 2460 | 2543 | // If there aren't any attachments in this directory this won't exist. |
| 2461 | - if (!isset($expected_files[$id])) |
|
| 2462 | - $expected_files[$id] = 0; |
|
| 2544 | + if (!isset($expected_files[$id])) { |
|
| 2545 | + $expected_files[$id] = 0; |
|
| 2546 | + } |
|
| 2463 | 2547 | |
| 2464 | 2548 | // Check if the directory is doing okay. |
| 2465 | 2549 | list ($status, $error, $files) = attachDirStatus($dir, $expected_files[$id]); |
@@ -2472,10 +2556,11 @@ discard block |
||
| 2472 | 2556 | $is_base_dir = in_array($dir, $modSettings['attachment_basedirectories']); |
| 2473 | 2557 | |
| 2474 | 2558 | // Count any sub-folders. |
| 2475 | - foreach ($modSettings['attachmentUploadDir'] as $sid => $sub) |
|
| 2476 | - if (strpos($sub, $dir . DIRECTORY_SEPARATOR) !== false) |
|
| 2559 | + foreach ($modSettings['attachmentUploadDir'] as $sid => $sub) { |
|
| 2560 | + if (strpos($sub, $dir . DIRECTORY_SEPARATOR) !== false) |
|
| 2477 | 2561 | { |
| 2478 | 2562 | $expected_files[$id]++; |
| 2563 | + } |
|
| 2479 | 2564 | $sub_dirs++; |
| 2480 | 2565 | } |
| 2481 | 2566 | } |
@@ -2493,8 +2578,8 @@ discard block |
||
| 2493 | 2578 | } |
| 2494 | 2579 | |
| 2495 | 2580 | // Just stick a new directory on at the bottom. |
| 2496 | - if (isset($_REQUEST['new_path'])) |
|
| 2497 | - $attachdirs[] = array( |
|
| 2581 | + if (isset($_REQUEST['new_path'])) { |
|
| 2582 | + $attachdirs[] = array( |
|
| 2498 | 2583 | 'id' => max(array_merge(array_keys($expected_files), array_keys($modSettings['attachmentUploadDir']))) + 1, |
| 2499 | 2584 | 'current' => false, |
| 2500 | 2585 | 'path' => '', |
@@ -2502,6 +2587,7 @@ discard block |
||
| 2502 | 2587 | 'num_files' => '', |
| 2503 | 2588 | 'status' => '', |
| 2504 | 2589 | ); |
| 2590 | + } |
|
| 2505 | 2591 | |
| 2506 | 2592 | return $attachdirs; |
| 2507 | 2593 | } |
@@ -2514,8 +2600,9 @@ discard block |
||
| 2514 | 2600 | { |
| 2515 | 2601 | global $modSettings, $txt; |
| 2516 | 2602 | |
| 2517 | - if (empty($modSettings['attachment_basedirectories'])) |
|
| 2518 | - return; |
|
| 2603 | + if (empty($modSettings['attachment_basedirectories'])) { |
|
| 2604 | + return; |
|
| 2605 | + } |
|
| 2519 | 2606 | |
| 2520 | 2607 | $basedirs = array(); |
| 2521 | 2608 | // Get a list of the base directories. |
@@ -2523,16 +2610,18 @@ discard block |
||
| 2523 | 2610 | { |
| 2524 | 2611 | // Loop through the attach directory array to count any sub-directories |
| 2525 | 2612 | $expected_dirs = 0; |
| 2526 | - foreach ($modSettings['attachmentUploadDir'] as $sid => $sub) |
|
| 2527 | - if (strpos($sub, $dir . DIRECTORY_SEPARATOR) !== false) |
|
| 2613 | + foreach ($modSettings['attachmentUploadDir'] as $sid => $sub) { |
|
| 2614 | + if (strpos($sub, $dir . DIRECTORY_SEPARATOR) !== false) |
|
| 2528 | 2615 | $expected_dirs++; |
| 2616 | + } |
|
| 2529 | 2617 | |
| 2530 | - if (!is_dir($dir)) |
|
| 2531 | - $status = 'does_not_exist'; |
|
| 2532 | - elseif (!is_writeable($dir)) |
|
| 2533 | - $status = 'not_writable'; |
|
| 2534 | - else |
|
| 2535 | - $status = 'ok'; |
|
| 2618 | + if (!is_dir($dir)) { |
|
| 2619 | + $status = 'does_not_exist'; |
|
| 2620 | + } elseif (!is_writeable($dir)) { |
|
| 2621 | + $status = 'not_writable'; |
|
| 2622 | + } else { |
|
| 2623 | + $status = 'ok'; |
|
| 2624 | + } |
|
| 2536 | 2625 | |
| 2537 | 2626 | $basedirs[] = array( |
| 2538 | 2627 | 'id' => $id, |
@@ -2543,14 +2632,15 @@ discard block |
||
| 2543 | 2632 | ); |
| 2544 | 2633 | } |
| 2545 | 2634 | |
| 2546 | - if (isset($_REQUEST['new_base_path'])) |
|
| 2547 | - $basedirs[] = array( |
|
| 2635 | + if (isset($_REQUEST['new_base_path'])) { |
|
| 2636 | + $basedirs[] = array( |
|
| 2548 | 2637 | 'id' => '', |
| 2549 | 2638 | 'current' => false, |
| 2550 | 2639 | 'path' => '<input type="text" name="new_base_dir" value="" size="40">', |
| 2551 | 2640 | 'num_dirs' => '', |
| 2552 | 2641 | 'status' => '', |
| 2553 | 2642 | ); |
| 2643 | + } |
|
| 2554 | 2644 | |
| 2555 | 2645 | return $basedirs; |
| 2556 | 2646 | } |
@@ -2566,10 +2656,11 @@ discard block |
||
| 2566 | 2656 | */ |
| 2567 | 2657 | function attachDirStatus($dir, $expected_files) |
| 2568 | 2658 | { |
| 2569 | - if (!is_dir($dir)) |
|
| 2570 | - return array('does_not_exist', true, ''); |
|
| 2571 | - elseif (!is_writable($dir)) |
|
| 2572 | - return array('not_writable', true, ''); |
|
| 2659 | + if (!is_dir($dir)) { |
|
| 2660 | + return array('does_not_exist', true, ''); |
|
| 2661 | + } elseif (!is_writable($dir)) { |
|
| 2662 | + return array('not_writable', true, ''); |
|
| 2663 | + } |
|
| 2573 | 2664 | |
| 2574 | 2665 | // Everything is okay so far, start to scan through the directory. |
| 2575 | 2666 | $num_files = 0; |
@@ -2577,22 +2668,26 @@ discard block |
||
| 2577 | 2668 | while ($file = $dir_handle->read()) |
| 2578 | 2669 | { |
| 2579 | 2670 | // Now do we have a real file here? |
| 2580 | - if (in_array($file, array('.', '..', '.htaccess', 'index.php'))) |
|
| 2581 | - continue; |
|
| 2671 | + if (in_array($file, array('.', '..', '.htaccess', 'index.php'))) { |
|
| 2672 | + continue; |
|
| 2673 | + } |
|
| 2582 | 2674 | |
| 2583 | 2675 | $num_files++; |
| 2584 | 2676 | } |
| 2585 | 2677 | $dir_handle->close(); |
| 2586 | 2678 | |
| 2587 | - if ($num_files < $expected_files) |
|
| 2588 | - return array('files_missing', true, $num_files); |
|
| 2679 | + if ($num_files < $expected_files) { |
|
| 2680 | + return array('files_missing', true, $num_files); |
|
| 2681 | + } |
|
| 2589 | 2682 | // Empty? |
| 2590 | - elseif ($expected_files == 0) |
|
| 2591 | - return array('unused', false, $num_files); |
|
| 2683 | + elseif ($expected_files == 0) { |
|
| 2684 | + return array('unused', false, $num_files); |
|
| 2685 | + } |
|
| 2592 | 2686 | // All good! |
| 2593 | - else |
|
| 2594 | - return array('ok', false, $num_files); |
|
| 2595 | -} |
|
| 2687 | + else { |
|
| 2688 | + return array('ok', false, $num_files); |
|
| 2689 | + } |
|
| 2690 | + } |
|
| 2596 | 2691 | |
| 2597 | 2692 | /** |
| 2598 | 2693 | * Maintance function to move attachments from one directory to another |
@@ -2604,10 +2699,11 @@ discard block |
||
| 2604 | 2699 | checkSession(); |
| 2605 | 2700 | |
| 2606 | 2701 | $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
| 2607 | - if (!empty($modSettings['attachment_basedirectories'])) |
|
| 2608 | - $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
|
| 2609 | - else |
|
| 2610 | - $modSettings['basedirectory_for_attachments'] = array(); |
|
| 2702 | + if (!empty($modSettings['attachment_basedirectories'])) { |
|
| 2703 | + $modSettings['attachment_basedirectories'] = smf_json_decode($modSettings['attachment_basedirectories'], true); |
|
| 2704 | + } else { |
|
| 2705 | + $modSettings['basedirectory_for_attachments'] = array(); |
|
| 2706 | + } |
|
| 2611 | 2707 | |
| 2612 | 2708 | $_POST['from'] = (int) $_POST['from']; |
| 2613 | 2709 | $_POST['auto'] = !empty($_POST['auto']) ? (int) $_POST['auto'] : 0; |
@@ -2621,11 +2717,13 @@ discard block |
||
| 2621 | 2717 | $total_moved = 0; |
| 2622 | 2718 | $total_not_moved = 0; |
| 2623 | 2719 | |
| 2624 | - if (empty($_POST['from']) || (empty($_POST['auto']) && empty($_POST['to']))) |
|
| 2625 | - $results[] = $txt['attachment_transfer_no_dir']; |
|
| 2720 | + if (empty($_POST['from']) || (empty($_POST['auto']) && empty($_POST['to']))) { |
|
| 2721 | + $results[] = $txt['attachment_transfer_no_dir']; |
|
| 2722 | + } |
|
| 2626 | 2723 | |
| 2627 | - if ($_POST['from'] == $_POST['to']) |
|
| 2628 | - $results[] = $txt['attachment_transfer_same_dir']; |
|
| 2724 | + if ($_POST['from'] == $_POST['to']) { |
|
| 2725 | + $results[] = $txt['attachment_transfer_same_dir']; |
|
| 2726 | + } |
|
| 2629 | 2727 | |
| 2630 | 2728 | if (empty($results)) |
| 2631 | 2729 | { |
@@ -2644,8 +2742,9 @@ discard block |
||
| 2644 | 2742 | $smcFunc['db_free_result']($request); |
| 2645 | 2743 | $total_progress -= $start; |
| 2646 | 2744 | |
| 2647 | - if ($total_progress < 1) |
|
| 2648 | - $results[] = $txt['attachment_transfer_no_find']; |
|
| 2745 | + if ($total_progress < 1) { |
|
| 2746 | + $results[] = $txt['attachment_transfer_no_find']; |
|
| 2747 | + } |
|
| 2649 | 2748 | } |
| 2650 | 2749 | |
| 2651 | 2750 | if (empty($results)) |
@@ -2661,9 +2760,9 @@ discard block |
||
| 2661 | 2760 | |
| 2662 | 2761 | automanage_attachments_check_directory(); |
| 2663 | 2762 | $new_dir = $modSettings['currentAttachmentUploadDir']; |
| 2763 | + } else { |
|
| 2764 | + $new_dir = $_POST['to']; |
|
| 2664 | 2765 | } |
| 2665 | - else |
|
| 2666 | - $new_dir = $_POST['to']; |
|
| 2667 | 2766 | |
| 2668 | 2767 | $modSettings['currentAttachmentUploadDir'] = $new_dir; |
| 2669 | 2768 | |
@@ -2671,8 +2770,9 @@ discard block |
||
| 2671 | 2770 | while ($break == false) |
| 2672 | 2771 | { |
| 2673 | 2772 | @set_time_limit(300); |
| 2674 | - if (function_exists('apache_reset_timeout')) |
|
| 2675 | - @apache_reset_timeout(); |
|
| 2773 | + if (function_exists('apache_reset_timeout')) { |
|
| 2774 | + @apache_reset_timeout(); |
|
| 2775 | + } |
|
| 2676 | 2776 | |
| 2677 | 2777 | // If limits are set, get the file count and size for the destination folder |
| 2678 | 2778 | if ($dir_files <= 0 && (!empty($modSettings['attachmentDirSizeLimit']) || !empty($modSettings['attachmentDirFileLimit']))) |
@@ -2708,13 +2808,15 @@ discard block |
||
| 2708 | 2808 | |
| 2709 | 2809 | if ($smcFunc['db_num_rows']($request) === 0) |
| 2710 | 2810 | { |
| 2711 | - if (empty($current_progress)) |
|
| 2712 | - $results[] = $txt['attachment_transfer_no_find']; |
|
| 2811 | + if (empty($current_progress)) { |
|
| 2812 | + $results[] = $txt['attachment_transfer_no_find']; |
|
| 2813 | + } |
|
| 2713 | 2814 | break; |
| 2714 | 2815 | } |
| 2715 | 2816 | |
| 2716 | - if ($smcFunc['db_num_rows']($request) < $limit) |
|
| 2717 | - $break = true; |
|
| 2817 | + if ($smcFunc['db_num_rows']($request) < $limit) { |
|
| 2818 | + $break = true; |
|
| 2819 | + } |
|
| 2718 | 2820 | |
| 2719 | 2821 | // Move them |
| 2720 | 2822 | $moved = array(); |
@@ -2738,8 +2840,9 @@ discard block |
||
| 2738 | 2840 | automanage_attachments_by_space(); |
| 2739 | 2841 | |
| 2740 | 2842 | $results[] = sprintf($txt['attachments_transferred'], $total_moved, $modSettings['attachmentUploadDir'][$new_dir]); |
| 2741 | - if (!empty($total_not_moved)) |
|
| 2742 | - $results[] = sprintf($txt['attachments_not_transferred'], $total_not_moved); |
|
| 2843 | + if (!empty($total_not_moved)) { |
|
| 2844 | + $results[] = sprintf($txt['attachments_not_transferred'], $total_not_moved); |
|
| 2845 | + } |
|
| 2743 | 2846 | |
| 2744 | 2847 | $dir_files = 0; |
| 2745 | 2848 | $total_moved = 0; |
@@ -2747,8 +2850,7 @@ discard block |
||
| 2747 | 2850 | |
| 2748 | 2851 | $break = false; |
| 2749 | 2852 | break; |
| 2750 | - } |
|
| 2751 | - else |
|
| 2853 | + } else |
|
| 2752 | 2854 | { |
| 2753 | 2855 | // Hmm, not in auto. Time to bail out then... |
| 2754 | 2856 | $results[] = $txt['attachment_transfer_no_room']; |
@@ -2763,9 +2865,9 @@ discard block |
||
| 2763 | 2865 | $total_moved++; |
| 2764 | 2866 | $current_progress++; |
| 2765 | 2867 | $moved[] = $row['id_attach']; |
| 2868 | + } else { |
|
| 2869 | + $total_not_moved++; |
|
| 2766 | 2870 | } |
| 2767 | - else |
|
| 2768 | - $total_not_moved++; |
|
| 2769 | 2871 | } |
| 2770 | 2872 | $smcFunc['db_free_result']($request); |
| 2771 | 2873 | |
@@ -2803,13 +2905,15 @@ discard block |
||
| 2803 | 2905 | } |
| 2804 | 2906 | |
| 2805 | 2907 | $results[] = sprintf($txt['attachments_transferred'], $total_moved, $modSettings['attachmentUploadDir'][$new_dir]); |
| 2806 | - if (!empty($total_not_moved)) |
|
| 2807 | - $results[] = sprintf($txt['attachments_not_transferred'], $total_not_moved); |
|
| 2908 | + if (!empty($total_not_moved)) { |
|
| 2909 | + $results[] = sprintf($txt['attachments_not_transferred'], $total_not_moved); |
|
| 2910 | + } |
|
| 2808 | 2911 | } |
| 2809 | 2912 | |
| 2810 | 2913 | $_SESSION['results'] = $results; |
| 2811 | - if (file_exists($boarddir . '/progress.php')) |
|
| 2812 | - unlink($boarddir . '/progress.php'); |
|
| 2914 | + if (file_exists($boarddir . '/progress.php')) { |
|
| 2915 | + unlink($boarddir . '/progress.php'); |
|
| 2916 | + } |
|
| 2813 | 2917 | |
| 2814 | 2918 | redirectexit('action=admin;area=manageattachments;sa=maintenance#transfer'); |
| 2815 | 2919 | } |
@@ -15,8 +15,9 @@ discard block |
||
| 15 | 15 | * @version 2.1 Beta 3 |
| 16 | 16 | */ |
| 17 | 17 | |
| 18 | -if (!defined('SMF')) |
|
| 18 | +if (!defined('SMF')) { |
|
| 19 | 19 | die('No direct access...'); |
| 20 | +} |
|
| 20 | 21 | |
| 21 | 22 | /** |
| 22 | 23 | * Main dispatcher. This function checks permissions and passes control through to the relevant section. |
@@ -245,8 +246,9 @@ discard block |
||
| 245 | 246 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 246 | 247 | { |
| 247 | 248 | // Private PM/email subjects and similar shouldn't be shown in the mailbox area. |
| 248 | - if (!empty($row['private'])) |
|
| 249 | - $row['subject'] = $txt['personal_message']; |
|
| 249 | + if (!empty($row['private'])) { |
|
| 250 | + $row['subject'] = $txt['personal_message']; |
|
| 251 | + } |
|
| 250 | 252 | |
| 251 | 253 | $mails[] = $row; |
| 252 | 254 | } |
@@ -300,8 +302,9 @@ discard block |
||
| 300 | 302 | $element = substr($key, strrpos($key, '_') + 1); |
| 301 | 303 | $processedBirthdayEmails[$index][$element] = $value; |
| 302 | 304 | } |
| 303 | - foreach ($processedBirthdayEmails as $index => $dummy) |
|
| 304 | - $emails[$index] = $index; |
|
| 305 | + foreach ($processedBirthdayEmails as $index => $dummy) { |
|
| 306 | + $emails[$index] = $index; |
|
| 307 | + } |
|
| 305 | 308 | |
| 306 | 309 | $config_vars = array( |
| 307 | 310 | // Mail queue stuff, this rocks ;) |
@@ -322,8 +325,9 @@ discard block |
||
| 322 | 325 | |
| 323 | 326 | call_integration_hook('integrate_modify_mail_settings', array(&$config_vars)); |
| 324 | 327 | |
| 325 | - if ($return_config) |
|
| 326 | - return $config_vars; |
|
| 328 | + if ($return_config) { |
|
| 329 | + return $config_vars; |
|
| 330 | + } |
|
| 327 | 331 | |
| 328 | 332 | // Saving? |
| 329 | 333 | if (isset($_GET['save'])) |
@@ -398,9 +402,9 @@ discard block |
||
| 398 | 402 | ); |
| 399 | 403 | list ($_GET['te']) = $smcFunc['db_fetch_row']($request); |
| 400 | 404 | $smcFunc['db_free_result']($request); |
| 405 | + } else { |
|
| 406 | + $_GET['te'] = (int) $_GET['te']; |
|
| 401 | 407 | } |
| 402 | - else |
|
| 403 | - $_GET['te'] = (int) $_GET['te']; |
|
| 404 | 408 | |
| 405 | 409 | $_GET['sent'] = isset($_GET['sent']) ? (int) $_GET['sent'] : 0; |
| 406 | 410 | |
@@ -424,12 +428,14 @@ discard block |
||
| 424 | 428 | |
| 425 | 429 | // Try get more time... |
| 426 | 430 | @set_time_limit(600); |
| 427 | - if (function_exists('apache_reset_timeout')) |
|
| 428 | - @apache_reset_timeout(); |
|
| 431 | + if (function_exists('apache_reset_timeout')) { |
|
| 432 | + @apache_reset_timeout(); |
|
| 433 | + } |
|
| 429 | 434 | |
| 430 | 435 | // Have we already used our maximum time? |
| 431 | - if (time() - array_sum(explode(' ', $time_start)) < 5) |
|
| 432 | - return; |
|
| 436 | + if (time() - array_sum(explode(' ', $time_start)) < 5) { |
|
| 437 | + return; |
|
| 438 | + } |
|
| 433 | 439 | |
| 434 | 440 | $context['continue_get_data'] = '?action=admin;area=mailqueue;sa=clear;te=' . $_GET['te'] . ';sent=' . $_GET['sent'] . ';' . $context['session_var'] . '=' . $context['session_id']; |
| 435 | 441 | $context['page_title'] = $txt['not_done_title']; |
@@ -459,8 +465,9 @@ discard block |
||
| 459 | 465 | { |
| 460 | 466 | global $txt; |
| 461 | 467 | |
| 462 | - if ($time_diff < 0) |
|
| 463 | - $time_diff = 0; |
|
| 468 | + if ($time_diff < 0) { |
|
| 469 | + $time_diff = 0; |
|
| 470 | + } |
|
| 464 | 471 | |
| 465 | 472 | // Just do a bit of an if fest... |
| 466 | 473 | if ($time_diff > 86400) |
@@ -481,8 +488,9 @@ discard block |
||
| 481 | 488 | return sprintf($minutes == 1 ? $txt['mq_minute'] : $txt['mq_minutes'], $minutes); |
| 482 | 489 | } |
| 483 | 490 | // Otherwise must be second |
| 484 | - else |
|
| 485 | - return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff); |
|
| 486 | -} |
|
| 491 | + else { |
|
| 492 | + return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff); |
|
| 493 | + } |
|
| 494 | + } |
|
| 487 | 495 | |
| 488 | 496 | ?> |
| 489 | 497 | \ No newline at end of file |
@@ -2262,9 +2262,9 @@ discard block |
||
| 2262 | 2262 | * |
| 2263 | 2263 | * @uses the template_include() function to include the file. |
| 2264 | 2264 | * @param string $template_name The name of the template to load |
| 2265 | - * @param array|string $style_sheets The name of a single stylesheet or an array of names of stylesheets to load |
|
| 2265 | + * @param string $style_sheets The name of a single stylesheet or an array of names of stylesheets to load |
|
| 2266 | 2266 | * @param bool $fatal If true, dies with an error message if the template cannot be found |
| 2267 | - * @return boolean Whether or not the template was loaded |
|
| 2267 | + * @return boolean|null Whether or not the template was loaded |
|
| 2268 | 2268 | */ |
| 2269 | 2269 | function loadTemplate($template_name, $style_sheets = array(), $fatal = true) |
| 2270 | 2270 | { |
@@ -2447,7 +2447,7 @@ discard block |
||
| 2447 | 2447 | * - all code added with this function is added to the same <style> tag so do make sure your css is valid! |
| 2448 | 2448 | * |
| 2449 | 2449 | * @param string $css Some css code |
| 2450 | - * @return void|bool Adds the CSS to the $context['css_header'] array or returns if no CSS is specified |
|
| 2450 | + * @return false|null Adds the CSS to the $context['css_header'] array or returns if no CSS is specified |
|
| 2451 | 2451 | */ |
| 2452 | 2452 | function addInlineCss($css) |
| 2453 | 2453 | { |
@@ -2463,7 +2463,7 @@ discard block |
||
| 2463 | 2463 | /** |
| 2464 | 2464 | * Add a Javascript file for output later |
| 2465 | 2465 | * |
| 2466 | - * @param string $filename The name of the file to load |
|
| 2466 | + * @param string $fileName The name of the file to load |
|
| 2467 | 2467 | * @param array $params An array of parameter info |
| 2468 | 2468 | * Keys are the following: |
| 2469 | 2469 | * - ['external'] (true/false): define if the file is a externally located file. Needs to be set to true if you are loading an external file |
@@ -2561,7 +2561,7 @@ discard block |
||
| 2561 | 2561 | * |
| 2562 | 2562 | * @param string $javascript Some JS code |
| 2563 | 2563 | * @param bool $defer Whether the script should load in <head> or before the closing <html> tag |
| 2564 | - * @return void|bool Adds the code to one of the $context['javascript_inline'] arrays or returns if no JS was specified |
|
| 2564 | + * @return false|null Adds the code to one of the $context['javascript_inline'] arrays or returns if no JS was specified |
|
| 2565 | 2565 | */ |
| 2566 | 2566 | function addInlineJavaScript($javascript, $defer = false) |
| 2567 | 2567 | { |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 3 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Load the $modSettings array. |
@@ -25,13 +26,14 @@ discard block |
||
| 25 | 26 | global $cache_enable, $sourcedir, $context; |
| 26 | 27 | |
| 27 | 28 | // Most database systems have not set UTF-8 as their default input charset. |
| 28 | - if (!empty($db_character_set)) |
|
| 29 | - $smcFunc['db_query']('', ' |
|
| 29 | + if (!empty($db_character_set)) { |
|
| 30 | + $smcFunc['db_query']('', ' |
|
| 30 | 31 | SET NAMES {string:db_character_set}', |
| 31 | 32 | array( |
| 32 | 33 | 'db_character_set' => $db_character_set, |
| 33 | 34 | ) |
| 34 | 35 | ); |
| 36 | + } |
|
| 35 | 37 | |
| 36 | 38 | // We need some caching support, maybe. |
| 37 | 39 | loadCacheAccelerator(); |
@@ -46,27 +48,35 @@ discard block |
||
| 46 | 48 | ) |
| 47 | 49 | ); |
| 48 | 50 | $modSettings = array(); |
| 49 | - if (!$request) |
|
| 50 | - display_db_error(); |
|
| 51 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
| 52 | - $modSettings[$row[0]] = $row[1]; |
|
| 51 | + if (!$request) { |
|
| 52 | + display_db_error(); |
|
| 53 | + } |
|
| 54 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
| 55 | + $modSettings[$row[0]] = $row[1]; |
|
| 56 | + } |
|
| 53 | 57 | $smcFunc['db_free_result']($request); |
| 54 | 58 | |
| 55 | 59 | // Do a few things to protect against missing settings or settings with invalid values... |
| 56 | - if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) |
|
| 57 | - $modSettings['defaultMaxTopics'] = 20; |
|
| 58 | - if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) |
|
| 59 | - $modSettings['defaultMaxMessages'] = 15; |
|
| 60 | - if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) |
|
| 61 | - $modSettings['defaultMaxMembers'] = 30; |
|
| 62 | - if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) |
|
| 63 | - $modSettings['defaultMaxListItems'] = 15; |
|
| 60 | + if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) { |
|
| 61 | + $modSettings['defaultMaxTopics'] = 20; |
|
| 62 | + } |
|
| 63 | + if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) { |
|
| 64 | + $modSettings['defaultMaxMessages'] = 15; |
|
| 65 | + } |
|
| 66 | + if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) { |
|
| 67 | + $modSettings['defaultMaxMembers'] = 30; |
|
| 68 | + } |
|
| 69 | + if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) { |
|
| 70 | + $modSettings['defaultMaxListItems'] = 15; |
|
| 71 | + } |
|
| 64 | 72 | |
| 65 | - if (!is_array($modSettings['attachmentUploadDir'])) |
|
| 66 | - $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
|
| 73 | + if (!is_array($modSettings['attachmentUploadDir'])) { |
|
| 74 | + $modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true); |
|
| 75 | + } |
|
| 67 | 76 | |
| 68 | - if (!empty($cache_enable)) |
|
| 69 | - cache_put_data('modSettings', $modSettings, 90); |
|
| 77 | + if (!empty($cache_enable)) { |
|
| 78 | + cache_put_data('modSettings', $modSettings, 90); |
|
| 79 | + } |
|
| 70 | 80 | } |
| 71 | 81 | |
| 72 | 82 | $modSettings['cache_enable'] = $cache_enable; |
@@ -86,8 +96,9 @@ discard block |
||
| 86 | 96 | }; |
| 87 | 97 | $fix_utf8mb4 = function($string) use ($utf8, $smcFunc) |
| 88 | 98 | { |
| 89 | - if (!$utf8 || $smcFunc['db_mb4']) |
|
| 90 | - return $string; |
|
| 99 | + if (!$utf8 || $smcFunc['db_mb4']) { |
|
| 100 | + return $string; |
|
| 101 | + } |
|
| 91 | 102 | |
| 92 | 103 | $i = 0; |
| 93 | 104 | $len = strlen($string); |
@@ -99,18 +110,15 @@ discard block |
||
| 99 | 110 | { |
| 100 | 111 | $new_string .= $string[$i]; |
| 101 | 112 | $i++; |
| 102 | - } |
|
| 103 | - elseif ($ord < 224) |
|
| 113 | + } elseif ($ord < 224) |
|
| 104 | 114 | { |
| 105 | 115 | $new_string .= $string[$i] . $string[$i + 1]; |
| 106 | 116 | $i += 2; |
| 107 | - } |
|
| 108 | - elseif ($ord < 240) |
|
| 117 | + } elseif ($ord < 240) |
|
| 109 | 118 | { |
| 110 | 119 | $new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2]; |
| 111 | 120 | $i += 3; |
| 112 | - } |
|
| 113 | - elseif ($ord < 248) |
|
| 121 | + } elseif ($ord < 248) |
|
| 114 | 122 | { |
| 115 | 123 | // Magic happens. |
| 116 | 124 | $val = (ord($string[$i]) & 0x07) << 18; |
@@ -154,8 +162,7 @@ discard block |
||
| 154 | 162 | { |
| 155 | 163 | $result = array_search($needle, array_slice($haystack_arr, $offset)); |
| 156 | 164 | return is_int($result) ? $result + $offset : false; |
| 157 | - } |
|
| 158 | - else |
|
| 165 | + } else |
|
| 159 | 166 | { |
| 160 | 167 | $needle_arr = preg_split('~(&#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . ';|"|&|<|>| |.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY); |
| 161 | 168 | $needle_size = count($needle_arr); |
@@ -164,8 +171,9 @@ discard block |
||
| 164 | 171 | while ((int) $result === $result) |
| 165 | 172 | { |
| 166 | 173 | $offset += $result; |
| 167 | - if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) |
|
| 168 | - return $offset; |
|
| 174 | + if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) { |
|
| 175 | + return $offset; |
|
| 176 | + } |
|
| 169 | 177 | $result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset)); |
| 170 | 178 | } |
| 171 | 179 | return false; |
@@ -203,8 +211,9 @@ discard block |
||
| 203 | 211 | $string = $ent_check($string); |
| 204 | 212 | preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches); |
| 205 | 213 | $string = $matches[0]; |
| 206 | - while (strlen($string) > $length) |
|
| 207 | - $string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string); |
|
| 214 | + while (strlen($string) > $length) { |
|
| 215 | + $string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string); |
|
| 216 | + } |
|
| 208 | 217 | return $string; |
| 209 | 218 | }, |
| 210 | 219 | 'ucfirst' => $utf8 ? function($string) use (&$smcFunc) |
@@ -214,23 +223,25 @@ discard block |
||
| 214 | 223 | 'ucwords' => $utf8 ? function($string) use (&$smcFunc) |
| 215 | 224 | { |
| 216 | 225 | $words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE); |
| 217 | - for ($i = 0, $n = count($words); $i < $n; $i += 2) |
|
| 218 | - $words[$i] = $smcFunc['ucfirst']($words[$i]); |
|
| 226 | + for ($i = 0, $n = count($words); $i < $n; $i += 2) { |
|
| 227 | + $words[$i] = $smcFunc['ucfirst']($words[$i]); |
|
| 228 | + } |
|
| 219 | 229 | return implode('', $words); |
| 220 | 230 | } : 'ucwords', |
| 221 | 231 | ); |
| 222 | 232 | |
| 223 | 233 | // Setting the timezone is a requirement for some functions. |
| 224 | - if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) |
|
| 225 | - date_default_timezone_set($modSettings['default_timezone']); |
|
| 226 | - else |
|
| 234 | + if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) { |
|
| 235 | + date_default_timezone_set($modSettings['default_timezone']); |
|
| 236 | + } else |
|
| 227 | 237 | { |
| 228 | 238 | // Get PHP's default timezone, if set |
| 229 | 239 | $ini_tz = ini_get('date.timezone'); |
| 230 | - if (!empty($ini_tz)) |
|
| 231 | - $modSettings['default_timezone'] = $ini_tz; |
|
| 232 | - else |
|
| 233 | - $modSettings['default_timezone'] = ''; |
|
| 240 | + if (!empty($ini_tz)) { |
|
| 241 | + $modSettings['default_timezone'] = $ini_tz; |
|
| 242 | + } else { |
|
| 243 | + $modSettings['default_timezone'] = ''; |
|
| 244 | + } |
|
| 234 | 245 | |
| 235 | 246 | // If date.timezone is unset, invalid, or just plain weird, make a best guess |
| 236 | 247 | if (!in_array($modSettings['default_timezone'], timezone_identifiers_list())) |
@@ -248,22 +259,26 @@ discard block |
||
| 248 | 259 | if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null) |
| 249 | 260 | { |
| 250 | 261 | $modSettings['load_average'] = @file_get_contents('/proc/loadavg'); |
| 251 | - if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) |
|
| 252 | - $modSettings['load_average'] = (float) $matches[1]; |
|
| 253 | - elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) |
|
| 254 | - $modSettings['load_average'] = (float) $matches[1]; |
|
| 255 | - else |
|
| 256 | - unset($modSettings['load_average']); |
|
| 262 | + if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) { |
|
| 263 | + $modSettings['load_average'] = (float) $matches[1]; |
|
| 264 | + } elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) { |
|
| 265 | + $modSettings['load_average'] = (float) $matches[1]; |
|
| 266 | + } else { |
|
| 267 | + unset($modSettings['load_average']); |
|
| 268 | + } |
|
| 257 | 269 | |
| 258 | - if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
|
| 259 | - cache_put_data('loadavg', $modSettings['load_average'], 90); |
|
| 270 | + if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) { |
|
| 271 | + cache_put_data('loadavg', $modSettings['load_average'], 90); |
|
| 272 | + } |
|
| 260 | 273 | } |
| 261 | 274 | |
| 262 | - if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) |
|
| 263 | - call_integration_hook('integrate_load_average', array($modSettings['load_average'])); |
|
| 275 | + if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) { |
|
| 276 | + call_integration_hook('integrate_load_average', array($modSettings['load_average'])); |
|
| 277 | + } |
|
| 264 | 278 | |
| 265 | - if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) |
|
| 266 | - display_loadavg_error(); |
|
| 279 | + if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) { |
|
| 280 | + display_loadavg_error(); |
|
| 281 | + } |
|
| 267 | 282 | } |
| 268 | 283 | |
| 269 | 284 | // Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is. |
@@ -284,8 +299,9 @@ discard block |
||
| 284 | 299 | if (defined('SMF_INTEGRATION_SETTINGS')) |
| 285 | 300 | { |
| 286 | 301 | $integration_settings = smf_json_decode(SMF_INTEGRATION_SETTINGS, true); |
| 287 | - foreach ($integration_settings as $hook => $function) |
|
| 288 | - add_integration_function($hook, $function, '', false); |
|
| 302 | + foreach ($integration_settings as $hook => $function) { |
|
| 303 | + add_integration_function($hook, $function, '', false); |
|
| 304 | + } |
|
| 289 | 305 | } |
| 290 | 306 | |
| 291 | 307 | // Any files to pre include? |
@@ -295,8 +311,9 @@ discard block |
||
| 295 | 311 | foreach ($pre_includes as $include) |
| 296 | 312 | { |
| 297 | 313 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
| 298 | - if (file_exists($include)) |
|
| 299 | - require_once($include); |
|
| 314 | + if (file_exists($include)) { |
|
| 315 | + require_once($include); |
|
| 316 | + } |
|
| 300 | 317 | } |
| 301 | 318 | } |
| 302 | 319 | |
@@ -400,27 +417,28 @@ discard block |
||
| 400 | 417 | break; |
| 401 | 418 | } |
| 402 | 419 | } |
| 420 | + } else { |
|
| 421 | + $id_member = 0; |
|
| 403 | 422 | } |
| 404 | - else |
|
| 405 | - $id_member = 0; |
|
| 406 | 423 | |
| 407 | 424 | if (empty($id_member) && isset($_COOKIE[$cookiename])) |
| 408 | 425 | { |
| 409 | 426 | $cookie_data = smf_json_decode($_COOKIE[$cookiename], true, false); |
| 410 | 427 | |
| 411 | - if (empty($cookie_data)) |
|
| 412 | - $cookie_data = safe_unserialize($_COOKIE[$cookiename]); |
|
| 428 | + if (empty($cookie_data)) { |
|
| 429 | + $cookie_data = safe_unserialize($_COOKIE[$cookiename]); |
|
| 430 | + } |
|
| 413 | 431 | |
| 414 | 432 | list ($id_member, $password) = $cookie_data; |
| 415 | 433 | $id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0; |
| 416 | - } |
|
| 417 | - elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA']))) |
|
| 434 | + } elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA']))) |
|
| 418 | 435 | { |
| 419 | 436 | // @todo Perhaps we can do some more checking on this, such as on the first octet of the IP? |
| 420 | 437 | $cookie_data = smf_json_decode($_SESSION['login_' . $cookiename]); |
| 421 | 438 | |
| 422 | - if (empty($cookie_data)) |
|
| 423 | - $cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
| 439 | + if (empty($cookie_data)) { |
|
| 440 | + $cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]); |
|
| 441 | + } |
|
| 424 | 442 | |
| 425 | 443 | list ($id_member, $password, $login_span) = $cookie_data; |
| 426 | 444 | $id_member = !empty($id_member) && strlen($password) == 128 && $login_span > time() ? (int) $id_member : 0; |
@@ -445,30 +463,34 @@ discard block |
||
| 445 | 463 | $user_settings = $smcFunc['db_fetch_assoc']($request); |
| 446 | 464 | $smcFunc['db_free_result']($request); |
| 447 | 465 | |
| 448 | - if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) |
|
| 449 | - $user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret); |
|
| 466 | + if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) { |
|
| 467 | + $user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret); |
|
| 468 | + } |
|
| 450 | 469 | |
| 451 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
| 452 | - cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
| 470 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
| 471 | + cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
| 472 | + } |
|
| 453 | 473 | } |
| 454 | 474 | |
| 455 | 475 | // Did we find 'im? If not, junk it. |
| 456 | 476 | if (!empty($user_settings)) |
| 457 | 477 | { |
| 458 | 478 | // As much as the password should be right, we can assume the integration set things up. |
| 459 | - if (!empty($already_verified) && $already_verified === true) |
|
| 460 | - $check = true; |
|
| 479 | + if (!empty($already_verified) && $already_verified === true) { |
|
| 480 | + $check = true; |
|
| 481 | + } |
|
| 461 | 482 | // SHA-512 hash should be 128 characters long. |
| 462 | - elseif (strlen($password) == 128) |
|
| 463 | - $check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password; |
|
| 464 | - else |
|
| 465 | - $check = false; |
|
| 483 | + elseif (strlen($password) == 128) { |
|
| 484 | + $check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password; |
|
| 485 | + } else { |
|
| 486 | + $check = false; |
|
| 487 | + } |
|
| 466 | 488 | |
| 467 | 489 | // Wrong password or not activated - either way, you're going nowhere. |
| 468 | 490 | $id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0; |
| 491 | + } else { |
|
| 492 | + $id_member = 0; |
|
| 469 | 493 | } |
| 470 | - else |
|
| 471 | - $id_member = 0; |
|
| 472 | 494 | |
| 473 | 495 | // If we no longer have the member maybe they're being all hackey, stop brute force! |
| 474 | 496 | if (!$id_member) |
@@ -490,13 +512,15 @@ discard block |
||
| 490 | 512 | { |
| 491 | 513 | $tfa_data = smf_json_decode($_COOKIE[$tfacookie]); |
| 492 | 514 | |
| 493 | - if (is_null($tfa_data)) |
|
| 494 | - $tfa_data = safe_unserialize($_COOKIE[$tfacookie]); |
|
| 515 | + if (is_null($tfa_data)) { |
|
| 516 | + $tfa_data = safe_unserialize($_COOKIE[$tfacookie]); |
|
| 517 | + } |
|
| 495 | 518 | |
| 496 | 519 | list ($tfamember, $tfasecret) = $tfa_data; |
| 497 | 520 | |
| 498 | - if ((int) $tfamember != $id_member) |
|
| 499 | - $tfasecret = null; |
|
| 521 | + if ((int) $tfamember != $id_member) { |
|
| 522 | + $tfasecret = null; |
|
| 523 | + } |
|
| 500 | 524 | } |
| 501 | 525 | |
| 502 | 526 | if (empty($tfasecret) || hash_salt($user_settings['tfa_backup'], $user_settings['password_salt']) != $tfasecret) |
@@ -516,10 +540,12 @@ discard block |
||
| 516 | 540 | // Are we forcing 2FA? Need to check if the user groups actually require 2FA |
| 517 | 541 | elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret'])) |
| 518 | 542 | { |
| 519 | - if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups |
|
| 543 | + if ($modSettings['tfa_mode'] == 2) { |
|
| 544 | + //only do this if we are just forcing SOME membergroups |
|
| 520 | 545 | { |
| 521 | 546 | //Build an array of ALL user membergroups. |
| 522 | 547 | $full_groups = array($user_settings['id_group']); |
| 548 | + } |
|
| 523 | 549 | if (!empty($user_settings['additional_groups'])) |
| 524 | 550 | { |
| 525 | 551 | $full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups'])); |
@@ -539,15 +565,17 @@ discard block |
||
| 539 | 565 | ); |
| 540 | 566 | $row = $smcFunc['db_fetch_assoc']($request); |
| 541 | 567 | $smcFunc['db_free_result']($request); |
| 568 | + } else { |
|
| 569 | + $row['total'] = 1; |
|
| 542 | 570 | } |
| 543 | - else |
|
| 544 | - $row['total'] = 1; //simplifies logics in the next "if" |
|
| 571 | + //simplifies logics in the next "if" |
|
| 545 | 572 | |
| 546 | 573 | $area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : ''; |
| 547 | 574 | $action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : ''; |
| 548 | 575 | |
| 549 | - if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) |
|
| 550 | - redirectexit('action=profile;area=tfasetup;forced'); |
|
| 576 | + if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) { |
|
| 577 | + redirectexit('action=profile;area=tfasetup;forced'); |
|
| 578 | + } |
|
| 551 | 579 | } |
| 552 | 580 | } |
| 553 | 581 | |
@@ -584,33 +612,37 @@ discard block |
||
| 584 | 612 | updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP'])); |
| 585 | 613 | $user_settings['last_login'] = time(); |
| 586 | 614 | |
| 587 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
| 588 | - cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
| 615 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
| 616 | + cache_put_data('user_settings-' . $id_member, $user_settings, 60); |
|
| 617 | + } |
|
| 589 | 618 | |
| 590 | - if (!empty($modSettings['cache_enable'])) |
|
| 591 | - cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600); |
|
| 619 | + if (!empty($modSettings['cache_enable'])) { |
|
| 620 | + cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600); |
|
| 621 | + } |
|
| 592 | 622 | } |
| 623 | + } elseif (empty($_SESSION['id_msg_last_visit'])) { |
|
| 624 | + $_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit']; |
|
| 593 | 625 | } |
| 594 | - elseif (empty($_SESSION['id_msg_last_visit'])) |
|
| 595 | - $_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit']; |
|
| 596 | 626 | |
| 597 | 627 | $username = $user_settings['member_name']; |
| 598 | 628 | |
| 599 | - if (empty($user_settings['additional_groups'])) |
|
| 600 | - $user_info = array( |
|
| 629 | + if (empty($user_settings['additional_groups'])) { |
|
| 630 | + $user_info = array( |
|
| 601 | 631 | 'groups' => array($user_settings['id_group'], $user_settings['id_post_group']) |
| 602 | 632 | ); |
| 603 | - else |
|
| 604 | - $user_info = array( |
|
| 633 | + } else { |
|
| 634 | + $user_info = array( |
|
| 605 | 635 | 'groups' => array_merge( |
| 606 | 636 | array($user_settings['id_group'], $user_settings['id_post_group']), |
| 607 | 637 | explode(',', $user_settings['additional_groups']) |
| 608 | 638 | ) |
| 609 | 639 | ); |
| 640 | + } |
|
| 610 | 641 | |
| 611 | 642 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
| 612 | - foreach ($user_info['groups'] as $k => $v) |
|
| 613 | - $user_info['groups'][$k] = (int) $v; |
|
| 643 | + foreach ($user_info['groups'] as $k => $v) { |
|
| 644 | + $user_info['groups'][$k] = (int) $v; |
|
| 645 | + } |
|
| 614 | 646 | |
| 615 | 647 | // This is a logged in user, so definitely not a spider. |
| 616 | 648 | $user_info['possibly_robot'] = false; |
@@ -624,8 +656,7 @@ discard block |
||
| 624 | 656 | $time_system = new DateTime('now', $tz_system); |
| 625 | 657 | $time_user = new DateTime('now', $tz_user); |
| 626 | 658 | $user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600; |
| 627 | - } |
|
| 628 | - else |
|
| 659 | + } else |
|
| 629 | 660 | { |
| 630 | 661 | // !!! Compatibility. |
| 631 | 662 | $user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset']; |
@@ -639,16 +670,18 @@ discard block |
||
| 639 | 670 | $user_info = array('groups' => array(-1)); |
| 640 | 671 | $user_settings = array(); |
| 641 | 672 | |
| 642 | - if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) |
|
| 643 | - $_COOKIE[$cookiename] = ''; |
|
| 673 | + if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) { |
|
| 674 | + $_COOKIE[$cookiename] = ''; |
|
| 675 | + } |
|
| 644 | 676 | |
| 645 | 677 | // Expire the 2FA cookie |
| 646 | 678 | if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member'])) |
| 647 | 679 | { |
| 648 | 680 | $tfa_data = smf_json_decode($_COOKIE[$cookiename . '_tfa'], true); |
| 649 | 681 | |
| 650 | - if (is_null($tfa_data)) |
|
| 651 | - $tfa_data = safe_unserialize($_COOKIE[$cookiename . '_tfa']); |
|
| 682 | + if (is_null($tfa_data)) { |
|
| 683 | + $tfa_data = safe_unserialize($_COOKIE[$cookiename . '_tfa']); |
|
| 684 | + } |
|
| 652 | 685 | |
| 653 | 686 | list ($id, $user, $exp, $state, $preserve) = $tfa_data; |
| 654 | 687 | |
@@ -660,19 +693,20 @@ discard block |
||
| 660 | 693 | } |
| 661 | 694 | |
| 662 | 695 | // Create a login token if it doesn't exist yet. |
| 663 | - if (!isset($_SESSION['token']['post-login'])) |
|
| 664 | - createToken('login'); |
|
| 665 | - else |
|
| 666 | - list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login']; |
|
| 696 | + if (!isset($_SESSION['token']['post-login'])) { |
|
| 697 | + createToken('login'); |
|
| 698 | + } else { |
|
| 699 | + list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login']; |
|
| 700 | + } |
|
| 667 | 701 | |
| 668 | 702 | // Do we perhaps think this is a search robot? Check every five minutes just in case... |
| 669 | 703 | if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300)) |
| 670 | 704 | { |
| 671 | 705 | require_once($sourcedir . '/ManageSearchEngines.php'); |
| 672 | 706 | $user_info['possibly_robot'] = SpiderCheck(); |
| 707 | + } elseif (!empty($modSettings['spider_mode'])) { |
|
| 708 | + $user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0; |
|
| 673 | 709 | } |
| 674 | - elseif (!empty($modSettings['spider_mode'])) |
|
| 675 | - $user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0; |
|
| 676 | 710 | // If we haven't turned on proper spider hunts then have a guess! |
| 677 | 711 | else |
| 678 | 712 | { |
@@ -720,8 +754,9 @@ discard block |
||
| 720 | 754 | $user_info['groups'] = array_unique($user_info['groups']); |
| 721 | 755 | |
| 722 | 756 | // Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems. |
| 723 | - if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) |
|
| 724 | - unset($user_info['ignoreboards'][$tmp]); |
|
| 757 | + if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) { |
|
| 758 | + unset($user_info['ignoreboards'][$tmp]); |
|
| 759 | + } |
|
| 725 | 760 | |
| 726 | 761 | // Allow the user to change their language. |
| 727 | 762 | if (!empty($modSettings['userLanguage'])) |
@@ -734,31 +769,36 @@ discard block |
||
| 734 | 769 | $user_info['language'] = strtr($_GET['language'], './\\:', '____'); |
| 735 | 770 | |
| 736 | 771 | // Make it permanent for members. |
| 737 | - if (!empty($user_info['id'])) |
|
| 738 | - updateMemberData($user_info['id'], array('lngfile' => $user_info['language'])); |
|
| 739 | - else |
|
| 740 | - $_SESSION['language'] = $user_info['language']; |
|
| 772 | + if (!empty($user_info['id'])) { |
|
| 773 | + updateMemberData($user_info['id'], array('lngfile' => $user_info['language'])); |
|
| 774 | + } else { |
|
| 775 | + $_SESSION['language'] = $user_info['language']; |
|
| 776 | + } |
|
| 777 | + } elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) { |
|
| 778 | + $user_info['language'] = strtr($_SESSION['language'], './\\:', '____'); |
|
| 741 | 779 | } |
| 742 | - elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) |
|
| 743 | - $user_info['language'] = strtr($_SESSION['language'], './\\:', '____'); |
|
| 744 | 780 | } |
| 745 | 781 | |
| 746 | 782 | // Just build this here, it makes it easier to change/use - administrators can see all boards. |
| 747 | - if ($user_info['is_admin']) |
|
| 748 | - $user_info['query_see_board'] = '1=1'; |
|
| 783 | + if ($user_info['is_admin']) { |
|
| 784 | + $user_info['query_see_board'] = '1=1'; |
|
| 785 | + } |
|
| 749 | 786 | // Otherwise just the groups in $user_info['groups']. |
| 750 | - else |
|
| 751 | - $user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')'; |
|
| 787 | + else { |
|
| 788 | + $user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')'; |
|
| 789 | + } |
|
| 752 | 790 | |
| 753 | 791 | // Build the list of boards they WANT to see. |
| 754 | 792 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
| 755 | 793 | |
| 756 | 794 | // If they aren't ignoring any boards then they want to see all the boards they can see |
| 757 | - if (empty($user_info['ignoreboards'])) |
|
| 758 | - $user_info['query_wanna_see_board'] = $user_info['query_see_board']; |
|
| 795 | + if (empty($user_info['ignoreboards'])) { |
|
| 796 | + $user_info['query_wanna_see_board'] = $user_info['query_see_board']; |
|
| 797 | + } |
|
| 759 | 798 | // Ok I guess they don't want to see all the boards |
| 760 | - else |
|
| 761 | - $user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))'; |
|
| 799 | + else { |
|
| 800 | + $user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))'; |
|
| 801 | + } |
|
| 762 | 802 | |
| 763 | 803 | call_integration_hook('integrate_user_info'); |
| 764 | 804 | } |
@@ -816,9 +856,9 @@ discard block |
||
| 816 | 856 | } |
| 817 | 857 | |
| 818 | 858 | // Remember redirection is the key to avoiding fallout from your bosses. |
| 819 | - if (!empty($topic)) |
|
| 820 | - redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']); |
|
| 821 | - else |
|
| 859 | + if (!empty($topic)) { |
|
| 860 | + redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']); |
|
| 861 | + } else |
|
| 822 | 862 | { |
| 823 | 863 | loadPermissions(); |
| 824 | 864 | loadTheme(); |
@@ -836,10 +876,11 @@ discard block |
||
| 836 | 876 | if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3)) |
| 837 | 877 | { |
| 838 | 878 | // @todo SLOW? |
| 839 | - if (!empty($topic)) |
|
| 840 | - $temp = cache_get_data('topic_board-' . $topic, 120); |
|
| 841 | - else |
|
| 842 | - $temp = cache_get_data('board-' . $board, 120); |
|
| 879 | + if (!empty($topic)) { |
|
| 880 | + $temp = cache_get_data('topic_board-' . $topic, 120); |
|
| 881 | + } else { |
|
| 882 | + $temp = cache_get_data('board-' . $board, 120); |
|
| 883 | + } |
|
| 843 | 884 | |
| 844 | 885 | if (!empty($temp)) |
| 845 | 886 | { |
@@ -877,8 +918,9 @@ discard block |
||
| 877 | 918 | $row = $smcFunc['db_fetch_assoc']($request); |
| 878 | 919 | |
| 879 | 920 | // Set the current board. |
| 880 | - if (!empty($row['id_board'])) |
|
| 881 | - $board = $row['id_board']; |
|
| 921 | + if (!empty($row['id_board'])) { |
|
| 922 | + $board = $row['id_board']; |
|
| 923 | + } |
|
| 882 | 924 | |
| 883 | 925 | // Basic operating information. (globals... :/) |
| 884 | 926 | $board_info = array( |
@@ -914,21 +956,23 @@ discard block |
||
| 914 | 956 | |
| 915 | 957 | do |
| 916 | 958 | { |
| 917 | - if (!empty($row['id_moderator'])) |
|
| 918 | - $board_info['moderators'][$row['id_moderator']] = array( |
|
| 959 | + if (!empty($row['id_moderator'])) { |
|
| 960 | + $board_info['moderators'][$row['id_moderator']] = array( |
|
| 919 | 961 | 'id' => $row['id_moderator'], |
| 920 | 962 | 'name' => $row['real_name'], |
| 921 | 963 | 'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'], |
| 922 | 964 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>' |
| 923 | 965 | ); |
| 966 | + } |
|
| 924 | 967 | |
| 925 | - if (!empty($row['id_moderator_group'])) |
|
| 926 | - $board_info['moderator_groups'][$row['id_moderator_group']] = array( |
|
| 968 | + if (!empty($row['id_moderator_group'])) { |
|
| 969 | + $board_info['moderator_groups'][$row['id_moderator_group']] = array( |
|
| 927 | 970 | 'id' => $row['id_moderator_group'], |
| 928 | 971 | 'name' => $row['group_name'], |
| 929 | 972 | 'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'], |
| 930 | 973 | 'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>' |
| 931 | 974 | ); |
| 975 | + } |
|
| 932 | 976 | } |
| 933 | 977 | while ($row = $smcFunc['db_fetch_assoc']($request)); |
| 934 | 978 | |
@@ -960,12 +1004,12 @@ discard block |
||
| 960 | 1004 | if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3)) |
| 961 | 1005 | { |
| 962 | 1006 | // @todo SLOW? |
| 963 | - if (!empty($topic)) |
|
| 964 | - cache_put_data('topic_board-' . $topic, $board_info, 120); |
|
| 1007 | + if (!empty($topic)) { |
|
| 1008 | + cache_put_data('topic_board-' . $topic, $board_info, 120); |
|
| 1009 | + } |
|
| 965 | 1010 | cache_put_data('board-' . $board, $board_info, 120); |
| 966 | 1011 | } |
| 967 | - } |
|
| 968 | - else |
|
| 1012 | + } else |
|
| 969 | 1013 | { |
| 970 | 1014 | // Otherwise the topic is invalid, there are no moderators, etc. |
| 971 | 1015 | $board_info = array( |
@@ -979,8 +1023,9 @@ discard block |
||
| 979 | 1023 | $smcFunc['db_free_result']($request); |
| 980 | 1024 | } |
| 981 | 1025 | |
| 982 | - if (!empty($topic)) |
|
| 983 | - $_GET['board'] = (int) $board; |
|
| 1026 | + if (!empty($topic)) { |
|
| 1027 | + $_GET['board'] = (int) $board; |
|
| 1028 | + } |
|
| 984 | 1029 | |
| 985 | 1030 | if (!empty($board)) |
| 986 | 1031 | { |
@@ -990,10 +1035,12 @@ discard block |
||
| 990 | 1035 | // Now check if the user is a moderator. |
| 991 | 1036 | $user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0; |
| 992 | 1037 | |
| 993 | - if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) |
|
| 994 | - $board_info['error'] = 'access'; |
|
| 995 | - if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) |
|
| 996 | - $board_info['error'] = 'access'; |
|
| 1038 | + if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) { |
|
| 1039 | + $board_info['error'] = 'access'; |
|
| 1040 | + } |
|
| 1041 | + if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) { |
|
| 1042 | + $board_info['error'] = 'access'; |
|
| 1043 | + } |
|
| 997 | 1044 | |
| 998 | 1045 | // Build up the linktree. |
| 999 | 1046 | $context['linktree'] = array_merge( |
@@ -1016,8 +1063,9 @@ discard block |
||
| 1016 | 1063 | $context['current_board'] = $board; |
| 1017 | 1064 | |
| 1018 | 1065 | // No posting in redirection boards! |
| 1019 | - if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) |
|
| 1020 | - $board_info['error'] == 'post_in_redirect'; |
|
| 1066 | + if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) { |
|
| 1067 | + $board_info['error'] == 'post_in_redirect'; |
|
| 1068 | + } |
|
| 1021 | 1069 | |
| 1022 | 1070 | // Hacker... you can't see this topic, I'll tell you that. (but moderators can!) |
| 1023 | 1071 | if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod'])) |
@@ -1043,24 +1091,23 @@ discard block |
||
| 1043 | 1091 | ob_end_clean(); |
| 1044 | 1092 | header('HTTP/1.1 403 Forbidden'); |
| 1045 | 1093 | die; |
| 1046 | - } |
|
| 1047 | - elseif ($board_info['error'] == 'post_in_redirect') |
|
| 1094 | + } elseif ($board_info['error'] == 'post_in_redirect') |
|
| 1048 | 1095 | { |
| 1049 | 1096 | // Slightly different error message here... |
| 1050 | 1097 | fatal_lang_error('cannot_post_redirect', false); |
| 1051 | - } |
|
| 1052 | - elseif ($user_info['is_guest']) |
|
| 1098 | + } elseif ($user_info['is_guest']) |
|
| 1053 | 1099 | { |
| 1054 | 1100 | loadLanguage('Errors'); |
| 1055 | 1101 | is_not_guest($txt['topic_gone']); |
| 1102 | + } else { |
|
| 1103 | + fatal_lang_error('topic_gone', false); |
|
| 1056 | 1104 | } |
| 1057 | - else |
|
| 1058 | - fatal_lang_error('topic_gone', false); |
|
| 1059 | 1105 | } |
| 1060 | 1106 | |
| 1061 | - if ($user_info['is_mod']) |
|
| 1062 | - $user_info['groups'][] = 3; |
|
| 1063 | -} |
|
| 1107 | + if ($user_info['is_mod']) { |
|
| 1108 | + $user_info['groups'][] = 3; |
|
| 1109 | + } |
|
| 1110 | + } |
|
| 1064 | 1111 | |
| 1065 | 1112 | /** |
| 1066 | 1113 | * Load this user's permissions. |
@@ -1081,8 +1128,9 @@ discard block |
||
| 1081 | 1128 | asort($cache_groups); |
| 1082 | 1129 | $cache_groups = implode(',', $cache_groups); |
| 1083 | 1130 | // If it's a spider then cache it different. |
| 1084 | - if ($user_info['possibly_robot']) |
|
| 1085 | - $cache_groups .= '-spider'; |
|
| 1131 | + if ($user_info['possibly_robot']) { |
|
| 1132 | + $cache_groups .= '-spider'; |
|
| 1133 | + } |
|
| 1086 | 1134 | |
| 1087 | 1135 | if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated']) |
| 1088 | 1136 | { |
@@ -1090,9 +1138,9 @@ discard block |
||
| 1090 | 1138 | banPermissions(); |
| 1091 | 1139 | |
| 1092 | 1140 | return; |
| 1141 | + } elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) { |
|
| 1142 | + list ($user_info['permissions'], $removals) = $temp; |
|
| 1093 | 1143 | } |
| 1094 | - elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) |
|
| 1095 | - list ($user_info['permissions'], $removals) = $temp; |
|
| 1096 | 1144 | } |
| 1097 | 1145 | |
| 1098 | 1146 | // If it is detected as a robot, and we are restricting permissions as a special group - then implement this. |
@@ -1114,23 +1162,26 @@ discard block |
||
| 1114 | 1162 | $removals = array(); |
| 1115 | 1163 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1116 | 1164 | { |
| 1117 | - if (empty($row['add_deny'])) |
|
| 1118 | - $removals[] = $row['permission']; |
|
| 1119 | - else |
|
| 1120 | - $user_info['permissions'][] = $row['permission']; |
|
| 1165 | + if (empty($row['add_deny'])) { |
|
| 1166 | + $removals[] = $row['permission']; |
|
| 1167 | + } else { |
|
| 1168 | + $user_info['permissions'][] = $row['permission']; |
|
| 1169 | + } |
|
| 1121 | 1170 | } |
| 1122 | 1171 | $smcFunc['db_free_result']($request); |
| 1123 | 1172 | |
| 1124 | - if (isset($cache_groups)) |
|
| 1125 | - cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240); |
|
| 1173 | + if (isset($cache_groups)) { |
|
| 1174 | + cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240); |
|
| 1175 | + } |
|
| 1126 | 1176 | } |
| 1127 | 1177 | |
| 1128 | 1178 | // Get the board permissions. |
| 1129 | 1179 | if (!empty($board)) |
| 1130 | 1180 | { |
| 1131 | 1181 | // Make sure the board (if any) has been loaded by loadBoard(). |
| 1132 | - if (!isset($board_info['profile'])) |
|
| 1133 | - fatal_lang_error('no_board'); |
|
| 1182 | + if (!isset($board_info['profile'])) { |
|
| 1183 | + fatal_lang_error('no_board'); |
|
| 1184 | + } |
|
| 1134 | 1185 | |
| 1135 | 1186 | $request = $smcFunc['db_query']('', ' |
| 1136 | 1187 | SELECT permission, add_deny |
@@ -1146,20 +1197,23 @@ discard block |
||
| 1146 | 1197 | ); |
| 1147 | 1198 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1148 | 1199 | { |
| 1149 | - if (empty($row['add_deny'])) |
|
| 1150 | - $removals[] = $row['permission']; |
|
| 1151 | - else |
|
| 1152 | - $user_info['permissions'][] = $row['permission']; |
|
| 1200 | + if (empty($row['add_deny'])) { |
|
| 1201 | + $removals[] = $row['permission']; |
|
| 1202 | + } else { |
|
| 1203 | + $user_info['permissions'][] = $row['permission']; |
|
| 1204 | + } |
|
| 1153 | 1205 | } |
| 1154 | 1206 | $smcFunc['db_free_result']($request); |
| 1155 | 1207 | } |
| 1156 | 1208 | |
| 1157 | 1209 | // Remove all the permissions they shouldn't have ;). |
| 1158 | - if (!empty($modSettings['permission_enable_deny'])) |
|
| 1159 | - $user_info['permissions'] = array_diff($user_info['permissions'], $removals); |
|
| 1210 | + if (!empty($modSettings['permission_enable_deny'])) { |
|
| 1211 | + $user_info['permissions'] = array_diff($user_info['permissions'], $removals); |
|
| 1212 | + } |
|
| 1160 | 1213 | |
| 1161 | - if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) |
|
| 1162 | - cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240); |
|
| 1214 | + if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) { |
|
| 1215 | + cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240); |
|
| 1216 | + } |
|
| 1163 | 1217 | |
| 1164 | 1218 | // Banned? Watch, don't touch.. |
| 1165 | 1219 | banPermissions(); |
@@ -1171,17 +1225,18 @@ discard block |
||
| 1171 | 1225 | { |
| 1172 | 1226 | require_once($sourcedir . '/Subs-Auth.php'); |
| 1173 | 1227 | rebuildModCache(); |
| 1228 | + } else { |
|
| 1229 | + $user_info['mod_cache'] = $_SESSION['mc']; |
|
| 1174 | 1230 | } |
| 1175 | - else |
|
| 1176 | - $user_info['mod_cache'] = $_SESSION['mc']; |
|
| 1177 | 1231 | |
| 1178 | 1232 | // This is a useful phantom permission added to the current user, and only the current user while they are logged in. |
| 1179 | 1233 | // For example this drastically simplifies certain changes to the profile area. |
| 1180 | 1234 | $user_info['permissions'][] = 'is_not_guest'; |
| 1181 | 1235 | // And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions. |
| 1182 | 1236 | $user_info['permissions'][] = 'profile_view_own'; |
| 1183 | - if (in_array('profile_view', $user_info['permissions'])) |
|
| 1184 | - $user_info['permissions'][] = 'profile_view_any'; |
|
| 1237 | + if (in_array('profile_view', $user_info['permissions'])) { |
|
| 1238 | + $user_info['permissions'][] = 'profile_view_any'; |
|
| 1239 | + } |
|
| 1185 | 1240 | } |
| 1186 | 1241 | } |
| 1187 | 1242 | |
@@ -1199,8 +1254,9 @@ discard block |
||
| 1199 | 1254 | global $image_proxy_enabled, $image_proxy_secret, $boardurl; |
| 1200 | 1255 | |
| 1201 | 1256 | // Can't just look for no users :P. |
| 1202 | - if (empty($users)) |
|
| 1203 | - return array(); |
|
| 1257 | + if (empty($users)) { |
|
| 1258 | + return array(); |
|
| 1259 | + } |
|
| 1204 | 1260 | |
| 1205 | 1261 | // Pass the set value |
| 1206 | 1262 | $context['loadMemberContext_set'] = $set; |
@@ -1215,8 +1271,9 @@ discard block |
||
| 1215 | 1271 | for ($i = 0, $n = count($users); $i < $n; $i++) |
| 1216 | 1272 | { |
| 1217 | 1273 | $data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240); |
| 1218 | - if ($data == null) |
|
| 1219 | - continue; |
|
| 1274 | + if ($data == null) { |
|
| 1275 | + continue; |
|
| 1276 | + } |
|
| 1220 | 1277 | |
| 1221 | 1278 | $loaded_ids[] = $data['id_member']; |
| 1222 | 1279 | $user_profile[$data['id_member']] = $data; |
@@ -1283,13 +1340,16 @@ discard block |
||
| 1283 | 1340 | $row['avatar_original'] = $row['avatar']; |
| 1284 | 1341 | |
| 1285 | 1342 | // Take care of proxying avatar if required, do this here for maximum reach |
| 1286 | - if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) |
|
| 1287 | - $row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret); |
|
| 1343 | + if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) { |
|
| 1344 | + $row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret); |
|
| 1345 | + } |
|
| 1288 | 1346 | |
| 1289 | - if (isset($row['member_ip'])) |
|
| 1290 | - $row['member_ip'] = inet_dtop($row['member_ip']); |
|
| 1291 | - if (isset($row['member_ip2'])) |
|
| 1292 | - $row['member_ip2'] = inet_dtop($row['member_ip2']); |
|
| 1347 | + if (isset($row['member_ip'])) { |
|
| 1348 | + $row['member_ip'] = inet_dtop($row['member_ip']); |
|
| 1349 | + } |
|
| 1350 | + if (isset($row['member_ip2'])) { |
|
| 1351 | + $row['member_ip2'] = inet_dtop($row['member_ip2']); |
|
| 1352 | + } |
|
| 1293 | 1353 | $new_loaded_ids[] = $row['id_member']; |
| 1294 | 1354 | $loaded_ids[] = $row['id_member']; |
| 1295 | 1355 | $row['options'] = array(); |
@@ -1308,8 +1368,9 @@ discard block |
||
| 1308 | 1368 | 'loaded_ids' => $new_loaded_ids, |
| 1309 | 1369 | ) |
| 1310 | 1370 | ); |
| 1311 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1312 | - $user_profile[$row['id_member']]['options'][$row['variable']] = $row['value']; |
|
| 1371 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1372 | + $user_profile[$row['id_member']]['options'][$row['variable']] = $row['value']; |
|
| 1373 | + } |
|
| 1313 | 1374 | $smcFunc['db_free_result']($request); |
| 1314 | 1375 | } |
| 1315 | 1376 | |
@@ -1320,10 +1381,11 @@ discard block |
||
| 1320 | 1381 | { |
| 1321 | 1382 | foreach ($loaded_ids as $a_member) |
| 1322 | 1383 | { |
| 1323 | - if (!empty($user_profile[$a_member]['additional_groups'])) |
|
| 1324 | - $groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups'])); |
|
| 1325 | - else |
|
| 1326 | - $groups = array($user_profile[$a_member]['id_group']); |
|
| 1384 | + if (!empty($user_profile[$a_member]['additional_groups'])) { |
|
| 1385 | + $groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups'])); |
|
| 1386 | + } else { |
|
| 1387 | + $groups = array($user_profile[$a_member]['id_group']); |
|
| 1388 | + } |
|
| 1327 | 1389 | |
| 1328 | 1390 | $temp = array_intersect($groups, array_keys($board_info['moderator_groups'])); |
| 1329 | 1391 | |
@@ -1336,8 +1398,9 @@ discard block |
||
| 1336 | 1398 | |
| 1337 | 1399 | if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3) |
| 1338 | 1400 | { |
| 1339 | - for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) |
|
| 1340 | - cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240); |
|
| 1401 | + for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) { |
|
| 1402 | + cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240); |
|
| 1403 | + } |
|
| 1341 | 1404 | } |
| 1342 | 1405 | |
| 1343 | 1406 | // Are we loading any moderators? If so, fix their group data... |
@@ -1363,14 +1426,17 @@ discard block |
||
| 1363 | 1426 | foreach ($temp_mods as $id) |
| 1364 | 1427 | { |
| 1365 | 1428 | // By popular demand, don't show admins or global moderators as moderators. |
| 1366 | - if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) |
|
| 1367 | - $user_profile[$id]['member_group'] = $row['member_group']; |
|
| 1429 | + if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) { |
|
| 1430 | + $user_profile[$id]['member_group'] = $row['member_group']; |
|
| 1431 | + } |
|
| 1368 | 1432 | |
| 1369 | 1433 | // If the Moderator group has no color or icons, but their group does... don't overwrite. |
| 1370 | - if (!empty($row['icons'])) |
|
| 1371 | - $user_profile[$id]['icons'] = $row['icons']; |
|
| 1372 | - if (!empty($row['member_group_color'])) |
|
| 1373 | - $user_profile[$id]['member_group_color'] = $row['member_group_color']; |
|
| 1434 | + if (!empty($row['icons'])) { |
|
| 1435 | + $user_profile[$id]['icons'] = $row['icons']; |
|
| 1436 | + } |
|
| 1437 | + if (!empty($row['member_group_color'])) { |
|
| 1438 | + $user_profile[$id]['member_group_color'] = $row['member_group_color']; |
|
| 1439 | + } |
|
| 1374 | 1440 | } |
| 1375 | 1441 | } |
| 1376 | 1442 | |
@@ -1392,12 +1458,14 @@ discard block |
||
| 1392 | 1458 | static $loadedLanguages = array(); |
| 1393 | 1459 | |
| 1394 | 1460 | // If this person's data is already loaded, skip it. |
| 1395 | - if (isset($dataLoaded[$user])) |
|
| 1396 | - return true; |
|
| 1461 | + if (isset($dataLoaded[$user])) { |
|
| 1462 | + return true; |
|
| 1463 | + } |
|
| 1397 | 1464 | |
| 1398 | 1465 | // We can't load guests or members not loaded by loadMemberData()! |
| 1399 | - if ($user == 0) |
|
| 1400 | - return false; |
|
| 1466 | + if ($user == 0) { |
|
| 1467 | + return false; |
|
| 1468 | + } |
|
| 1401 | 1469 | if (!isset($user_profile[$user])) |
| 1402 | 1470 | { |
| 1403 | 1471 | trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING); |
@@ -1423,12 +1491,16 @@ discard block |
||
| 1423 | 1491 | $buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array(); |
| 1424 | 1492 | |
| 1425 | 1493 | //We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme |
| 1426 | - if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists |
|
| 1494 | + if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) { |
|
| 1495 | + //icon is set and exists |
|
| 1427 | 1496 | $group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1]; |
| 1428 | - elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default |
|
| 1497 | + } elseif (isset($profile['icons'][1])) { |
|
| 1498 | + //icon is set and doesn't exist, fallback to default |
|
| 1429 | 1499 | $group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1]; |
| 1430 | - else //not set, bye bye |
|
| 1500 | + } else { |
|
| 1501 | + //not set, bye bye |
|
| 1431 | 1502 | $group_icon_url = ''; |
| 1503 | + } |
|
| 1432 | 1504 | |
| 1433 | 1505 | // These minimal values are always loaded |
| 1434 | 1506 | $memberContext[$user] = array( |
@@ -1447,8 +1519,9 @@ discard block |
||
| 1447 | 1519 | if ($context['loadMemberContext_set'] != 'minimal') |
| 1448 | 1520 | { |
| 1449 | 1521 | // Go the extra mile and load the user's native language name. |
| 1450 | - if (empty($loadedLanguages)) |
|
| 1451 | - $loadedLanguages = getLanguages(); |
|
| 1522 | + if (empty($loadedLanguages)) { |
|
| 1523 | + $loadedLanguages = getLanguages(); |
|
| 1524 | + } |
|
| 1452 | 1525 | |
| 1453 | 1526 | $memberContext[$user] += array( |
| 1454 | 1527 | 'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>', |
@@ -1502,31 +1575,33 @@ discard block |
||
| 1502 | 1575 | { |
| 1503 | 1576 | if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://'))) |
| 1504 | 1577 | { |
| 1505 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) |
|
| 1506 | - $image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11)); |
|
| 1507 | - else |
|
| 1508 | - $image = get_gravatar_url($profile['email_address']); |
|
| 1509 | - } |
|
| 1510 | - else |
|
| 1578 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) { |
|
| 1579 | + $image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11)); |
|
| 1580 | + } else { |
|
| 1581 | + $image = get_gravatar_url($profile['email_address']); |
|
| 1582 | + } |
|
| 1583 | + } else |
|
| 1511 | 1584 | { |
| 1512 | 1585 | // So it's stored in the member table? |
| 1513 | 1586 | if (!empty($profile['avatar'])) |
| 1514 | 1587 | { |
| 1515 | 1588 | $image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar']; |
| 1589 | + } elseif (!empty($profile['filename'])) { |
|
| 1590 | + $image = $modSettings['custom_avatar_url'] . '/' . $profile['filename']; |
|
| 1516 | 1591 | } |
| 1517 | - elseif (!empty($profile['filename'])) |
|
| 1518 | - $image = $modSettings['custom_avatar_url'] . '/' . $profile['filename']; |
|
| 1519 | 1592 | // Right... no avatar...use the default one |
| 1520 | - else |
|
| 1521 | - $image = $modSettings['avatar_url'] . '/default.png'; |
|
| 1593 | + else { |
|
| 1594 | + $image = $modSettings['avatar_url'] . '/default.png'; |
|
| 1595 | + } |
|
| 1522 | 1596 | } |
| 1523 | - if (!empty($image)) |
|
| 1524 | - $memberContext[$user]['avatar'] = array( |
|
| 1597 | + if (!empty($image)) { |
|
| 1598 | + $memberContext[$user]['avatar'] = array( |
|
| 1525 | 1599 | 'name' => $profile['avatar'], |
| 1526 | 1600 | 'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">', |
| 1527 | 1601 | 'href' => $image, |
| 1528 | 1602 | 'url' => $image, |
| 1529 | 1603 | ); |
| 1604 | + } |
|
| 1530 | 1605 | } |
| 1531 | 1606 | |
| 1532 | 1607 | // Are we also loading the members custom fields into context? |
@@ -1534,35 +1609,41 @@ discard block |
||
| 1534 | 1609 | { |
| 1535 | 1610 | $memberContext[$user]['custom_fields'] = array(); |
| 1536 | 1611 | |
| 1537 | - if (!isset($context['display_fields'])) |
|
| 1538 | - $context['display_fields'] = smf_json_decode($modSettings['displayFields'], true); |
|
| 1612 | + if (!isset($context['display_fields'])) { |
|
| 1613 | + $context['display_fields'] = smf_json_decode($modSettings['displayFields'], true); |
|
| 1614 | + } |
|
| 1539 | 1615 | |
| 1540 | 1616 | foreach ($context['display_fields'] as $custom) |
| 1541 | 1617 | { |
| 1542 | - if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) |
|
| 1543 | - continue; |
|
| 1618 | + if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) { |
|
| 1619 | + continue; |
|
| 1620 | + } |
|
| 1544 | 1621 | |
| 1545 | 1622 | $value = $profile['options'][$custom['col_name']]; |
| 1546 | 1623 | |
| 1547 | 1624 | // Don't show the "disabled" option for the "gender" field. |
| 1548 | - if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') |
|
| 1549 | - continue; |
|
| 1625 | + if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') { |
|
| 1626 | + continue; |
|
| 1627 | + } |
|
| 1550 | 1628 | |
| 1551 | 1629 | // BBC? |
| 1552 | - if ($custom['bbc']) |
|
| 1553 | - $value = parse_bbc($value); |
|
| 1630 | + if ($custom['bbc']) { |
|
| 1631 | + $value = parse_bbc($value); |
|
| 1632 | + } |
|
| 1554 | 1633 | // ... or checkbox? |
| 1555 | - elseif (isset($custom['type']) && $custom['type'] == 'check') |
|
| 1556 | - $value = $value ? $txt['yes'] : $txt['no']; |
|
| 1634 | + elseif (isset($custom['type']) && $custom['type'] == 'check') { |
|
| 1635 | + $value = $value ? $txt['yes'] : $txt['no']; |
|
| 1636 | + } |
|
| 1557 | 1637 | |
| 1558 | 1638 | // Enclosing the user input within some other text? |
| 1559 | - if (!empty($custom['enclose'])) |
|
| 1560 | - $value = strtr($custom['enclose'], array( |
|
| 1639 | + if (!empty($custom['enclose'])) { |
|
| 1640 | + $value = strtr($custom['enclose'], array( |
|
| 1561 | 1641 | '{SCRIPTURL}' => $scripturl, |
| 1562 | 1642 | '{IMAGES_URL}' => $settings['images_url'], |
| 1563 | 1643 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
| 1564 | 1644 | '{INPUT}' => $value, |
| 1565 | 1645 | )); |
| 1646 | + } |
|
| 1566 | 1647 | |
| 1567 | 1648 | $memberContext[$user]['custom_fields'][] = array( |
| 1568 | 1649 | 'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'], |
@@ -1589,8 +1670,9 @@ discard block |
||
| 1589 | 1670 | global $smcFunc, $txt, $scripturl, $settings; |
| 1590 | 1671 | |
| 1591 | 1672 | // Do not waste my time... |
| 1592 | - if (empty($users) || empty($params)) |
|
| 1593 | - return false; |
|
| 1673 | + if (empty($users) || empty($params)) { |
|
| 1674 | + return false; |
|
| 1675 | + } |
|
| 1594 | 1676 | |
| 1595 | 1677 | // Make sure it's an array. |
| 1596 | 1678 | $users = !is_array($users) ? array($users) : array_unique($users); |
@@ -1614,31 +1696,36 @@ discard block |
||
| 1614 | 1696 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1615 | 1697 | { |
| 1616 | 1698 | // BBC? |
| 1617 | - if (!empty($row['bbc'])) |
|
| 1618 | - $row['value'] = parse_bbc($row['value']); |
|
| 1699 | + if (!empty($row['bbc'])) { |
|
| 1700 | + $row['value'] = parse_bbc($row['value']); |
|
| 1701 | + } |
|
| 1619 | 1702 | |
| 1620 | 1703 | // ... or checkbox? |
| 1621 | - elseif (isset($row['type']) && $row['type'] == 'check') |
|
| 1622 | - $row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no']; |
|
| 1704 | + elseif (isset($row['type']) && $row['type'] == 'check') { |
|
| 1705 | + $row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no']; |
|
| 1706 | + } |
|
| 1623 | 1707 | |
| 1624 | 1708 | // Enclosing the user input within some other text? |
| 1625 | - if (!empty($row['enclose'])) |
|
| 1626 | - $row['value'] = strtr($row['enclose'], array( |
|
| 1709 | + if (!empty($row['enclose'])) { |
|
| 1710 | + $row['value'] = strtr($row['enclose'], array( |
|
| 1627 | 1711 | '{SCRIPTURL}' => $scripturl, |
| 1628 | 1712 | '{IMAGES_URL}' => $settings['images_url'], |
| 1629 | 1713 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
| 1630 | 1714 | '{INPUT}' => un_htmlspecialchars($row['value']), |
| 1631 | 1715 | )); |
| 1716 | + } |
|
| 1632 | 1717 | |
| 1633 | 1718 | // Send a simple array if there is just 1 param |
| 1634 | - if (count($params) == 1) |
|
| 1635 | - $return[$row['id_member']] = $row; |
|
| 1719 | + if (count($params) == 1) { |
|
| 1720 | + $return[$row['id_member']] = $row; |
|
| 1721 | + } |
|
| 1636 | 1722 | |
| 1637 | 1723 | // More than 1? knock yourself out... |
| 1638 | 1724 | else |
| 1639 | 1725 | { |
| 1640 | - if (!isset($return[$row['id_member']])) |
|
| 1641 | - $return[$row['id_member']] = array(); |
|
| 1726 | + if (!isset($return[$row['id_member']])) { |
|
| 1727 | + $return[$row['id_member']] = array(); |
|
| 1728 | + } |
|
| 1642 | 1729 | |
| 1643 | 1730 | $return[$row['id_member']][$row['variable']] = $row; |
| 1644 | 1731 | } |
@@ -1672,8 +1759,9 @@ discard block |
||
| 1672 | 1759 | global $context; |
| 1673 | 1760 | |
| 1674 | 1761 | // Don't know any browser! |
| 1675 | - if (empty($context['browser'])) |
|
| 1676 | - detectBrowser(); |
|
| 1762 | + if (empty($context['browser'])) { |
|
| 1763 | + detectBrowser(); |
|
| 1764 | + } |
|
| 1677 | 1765 | |
| 1678 | 1766 | return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false; |
| 1679 | 1767 | } |
@@ -1691,8 +1779,9 @@ discard block |
||
| 1691 | 1779 | global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled; |
| 1692 | 1780 | |
| 1693 | 1781 | // The theme was specified by parameter. |
| 1694 | - if (!empty($id_theme)) |
|
| 1695 | - $id_theme = (int) $id_theme; |
|
| 1782 | + if (!empty($id_theme)) { |
|
| 1783 | + $id_theme = (int) $id_theme; |
|
| 1784 | + } |
|
| 1696 | 1785 | // The theme was specified by REQUEST. |
| 1697 | 1786 | elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) |
| 1698 | 1787 | { |
@@ -1700,51 +1789,58 @@ discard block |
||
| 1700 | 1789 | $_SESSION['id_theme'] = $id_theme; |
| 1701 | 1790 | } |
| 1702 | 1791 | // The theme was specified by REQUEST... previously. |
| 1703 | - elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) |
|
| 1704 | - $id_theme = (int) $_SESSION['id_theme']; |
|
| 1792 | + elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) { |
|
| 1793 | + $id_theme = (int) $_SESSION['id_theme']; |
|
| 1794 | + } |
|
| 1705 | 1795 | // The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.) |
| 1706 | - elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) |
|
| 1707 | - $id_theme = $user_info['theme']; |
|
| 1796 | + elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) { |
|
| 1797 | + $id_theme = $user_info['theme']; |
|
| 1798 | + } |
|
| 1708 | 1799 | // The theme was specified by the board. |
| 1709 | - elseif (!empty($board_info['theme'])) |
|
| 1710 | - $id_theme = $board_info['theme']; |
|
| 1800 | + elseif (!empty($board_info['theme'])) { |
|
| 1801 | + $id_theme = $board_info['theme']; |
|
| 1802 | + } |
|
| 1711 | 1803 | // The theme is the forum's default. |
| 1712 | - else |
|
| 1713 | - $id_theme = $modSettings['theme_guests']; |
|
| 1804 | + else { |
|
| 1805 | + $id_theme = $modSettings['theme_guests']; |
|
| 1806 | + } |
|
| 1714 | 1807 | |
| 1715 | 1808 | // Verify the id_theme... no foul play. |
| 1716 | 1809 | // Always allow the board specific theme, if they are overriding. |
| 1717 | - if (!empty($board_info['theme']) && $board_info['override_theme']) |
|
| 1718 | - $id_theme = $board_info['theme']; |
|
| 1810 | + if (!empty($board_info['theme']) && $board_info['override_theme']) { |
|
| 1811 | + $id_theme = $board_info['theme']; |
|
| 1812 | + } |
|
| 1719 | 1813 | // If they have specified a particular theme to use with SSI allow it to be used. |
| 1720 | - elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) |
|
| 1721 | - $id_theme = (int) $id_theme; |
|
| 1722 | - elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum')) |
|
| 1814 | + elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) { |
|
| 1815 | + $id_theme = (int) $id_theme; |
|
| 1816 | + } elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum')) |
|
| 1723 | 1817 | { |
| 1724 | 1818 | $themes = explode(',', $modSettings['enableThemes']); |
| 1725 | - if (!in_array($id_theme, $themes)) |
|
| 1726 | - $id_theme = $modSettings['theme_guests']; |
|
| 1727 | - else |
|
| 1819 | + if (!in_array($id_theme, $themes)) { |
|
| 1820 | + $id_theme = $modSettings['theme_guests']; |
|
| 1821 | + } else { |
|
| 1822 | + $id_theme = (int) $id_theme; |
|
| 1823 | + } |
|
| 1824 | + } else { |
|
| 1728 | 1825 | $id_theme = (int) $id_theme; |
| 1729 | 1826 | } |
| 1730 | - else |
|
| 1731 | - $id_theme = (int) $id_theme; |
|
| 1732 | 1827 | |
| 1733 | 1828 | $member = empty($user_info['id']) ? -1 : $user_info['id']; |
| 1734 | 1829 | |
| 1735 | 1830 | // Disable image proxy if we don't have SSL enabled |
| 1736 | - if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) |
|
| 1737 | - $image_proxy_enabled = false; |
|
| 1831 | + if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) { |
|
| 1832 | + $image_proxy_enabled = false; |
|
| 1833 | + } |
|
| 1738 | 1834 | |
| 1739 | 1835 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated']) |
| 1740 | 1836 | { |
| 1741 | 1837 | $themeData = $temp; |
| 1742 | 1838 | $flag = true; |
| 1839 | + } elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) { |
|
| 1840 | + $themeData = $temp + array($member => array()); |
|
| 1841 | + } else { |
|
| 1842 | + $themeData = array(-1 => array(), 0 => array(), $member => array()); |
|
| 1743 | 1843 | } |
| 1744 | - elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) |
|
| 1745 | - $themeData = $temp + array($member => array()); |
|
| 1746 | - else |
|
| 1747 | - $themeData = array(-1 => array(), 0 => array(), $member => array()); |
|
| 1748 | 1844 | |
| 1749 | 1845 | if (empty($flag)) |
| 1750 | 1846 | { |
@@ -1763,31 +1859,37 @@ discard block |
||
| 1763 | 1859 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
| 1764 | 1860 | { |
| 1765 | 1861 | // There are just things we shouldn't be able to change as members. |
| 1766 | - if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) |
|
| 1767 | - continue; |
|
| 1862 | + if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) { |
|
| 1863 | + continue; |
|
| 1864 | + } |
|
| 1768 | 1865 | |
| 1769 | 1866 | // If this is the theme_dir of the default theme, store it. |
| 1770 | - if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) |
|
| 1771 | - $themeData[0]['default_' . $row['variable']] = $row['value']; |
|
| 1867 | + if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) { |
|
| 1868 | + $themeData[0]['default_' . $row['variable']] = $row['value']; |
|
| 1869 | + } |
|
| 1772 | 1870 | |
| 1773 | 1871 | // If this isn't set yet, is a theme option, or is not the default theme.. |
| 1774 | - if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') |
|
| 1775 | - $themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value']; |
|
| 1872 | + if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') { |
|
| 1873 | + $themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value']; |
|
| 1874 | + } |
|
| 1776 | 1875 | } |
| 1777 | 1876 | $smcFunc['db_free_result']($result); |
| 1778 | 1877 | |
| 1779 | - if (!empty($themeData[-1])) |
|
| 1780 | - foreach ($themeData[-1] as $k => $v) |
|
| 1878 | + if (!empty($themeData[-1])) { |
|
| 1879 | + foreach ($themeData[-1] as $k => $v) |
|
| 1781 | 1880 | { |
| 1782 | 1881 | if (!isset($themeData[$member][$k])) |
| 1783 | 1882 | $themeData[$member][$k] = $v; |
| 1883 | + } |
|
| 1784 | 1884 | } |
| 1785 | 1885 | |
| 1786 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
| 1787 | - cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60); |
|
| 1886 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
| 1887 | + cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60); |
|
| 1888 | + } |
|
| 1788 | 1889 | // Only if we didn't already load that part of the cache... |
| 1789 | - elseif (!isset($temp)) |
|
| 1790 | - cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90); |
|
| 1890 | + elseif (!isset($temp)) { |
|
| 1891 | + cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90); |
|
| 1892 | + } |
|
| 1791 | 1893 | } |
| 1792 | 1894 | |
| 1793 | 1895 | $settings = $themeData[0]; |
@@ -1804,20 +1906,24 @@ discard block |
||
| 1804 | 1906 | $settings['template_dirs'][] = $settings['theme_dir']; |
| 1805 | 1907 | |
| 1806 | 1908 | // Based on theme (if there is one). |
| 1807 | - if (!empty($settings['base_theme_dir'])) |
|
| 1808 | - $settings['template_dirs'][] = $settings['base_theme_dir']; |
|
| 1909 | + if (!empty($settings['base_theme_dir'])) { |
|
| 1910 | + $settings['template_dirs'][] = $settings['base_theme_dir']; |
|
| 1911 | + } |
|
| 1809 | 1912 | |
| 1810 | 1913 | // Lastly the default theme. |
| 1811 | - if ($settings['theme_dir'] != $settings['default_theme_dir']) |
|
| 1812 | - $settings['template_dirs'][] = $settings['default_theme_dir']; |
|
| 1914 | + if ($settings['theme_dir'] != $settings['default_theme_dir']) { |
|
| 1915 | + $settings['template_dirs'][] = $settings['default_theme_dir']; |
|
| 1916 | + } |
|
| 1813 | 1917 | |
| 1814 | - if (!$initialize) |
|
| 1815 | - return; |
|
| 1918 | + if (!$initialize) { |
|
| 1919 | + return; |
|
| 1920 | + } |
|
| 1816 | 1921 | |
| 1817 | 1922 | // Check to see if we're forcing SSL |
| 1818 | 1923 | if (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 && empty($maintenance) && |
| 1819 | - (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') |
|
| 1820 | - redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://'))); |
|
| 1924 | + (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') { |
|
| 1925 | + redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://'))); |
|
| 1926 | + } |
|
| 1821 | 1927 | |
| 1822 | 1928 | // Check to see if they're accessing it from the wrong place. |
| 1823 | 1929 | if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME'])) |
@@ -1825,8 +1931,9 @@ discard block |
||
| 1825 | 1931 | $detected_url = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on' ? 'https://' : 'http://'; |
| 1826 | 1932 | $detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST']; |
| 1827 | 1933 | $temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/')); |
| 1828 | - if ($temp != '/') |
|
| 1829 | - $detected_url .= $temp; |
|
| 1934 | + if ($temp != '/') { |
|
| 1935 | + $detected_url .= $temp; |
|
| 1936 | + } |
|
| 1830 | 1937 | } |
| 1831 | 1938 | if (isset($detected_url) && $detected_url != $boardurl) |
| 1832 | 1939 | { |
@@ -1838,8 +1945,9 @@ discard block |
||
| 1838 | 1945 | foreach ($aliases as $alias) |
| 1839 | 1946 | { |
| 1840 | 1947 | // Rip off all the boring parts, spaces, etc. |
| 1841 | - if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) |
|
| 1842 | - $do_fix = true; |
|
| 1948 | + if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) { |
|
| 1949 | + $do_fix = true; |
|
| 1950 | + } |
|
| 1843 | 1951 | } |
| 1844 | 1952 | } |
| 1845 | 1953 | |
@@ -1847,20 +1955,22 @@ discard block |
||
| 1847 | 1955 | if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI') |
| 1848 | 1956 | { |
| 1849 | 1957 | // Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;). |
| 1850 | - if (empty($_GET)) |
|
| 1851 | - redirectexit('wwwRedirect'); |
|
| 1852 | - else |
|
| 1958 | + if (empty($_GET)) { |
|
| 1959 | + redirectexit('wwwRedirect'); |
|
| 1960 | + } else |
|
| 1853 | 1961 | { |
| 1854 | 1962 | list ($k, $v) = each($_GET); |
| 1855 | 1963 | |
| 1856 | - if ($k != 'wwwRedirect') |
|
| 1857 | - redirectexit('wwwRedirect;' . $k . '=' . $v); |
|
| 1964 | + if ($k != 'wwwRedirect') { |
|
| 1965 | + redirectexit('wwwRedirect;' . $k . '=' . $v); |
|
| 1966 | + } |
|
| 1858 | 1967 | } |
| 1859 | 1968 | } |
| 1860 | 1969 | |
| 1861 | 1970 | // #3 is just a check for SSL... |
| 1862 | - if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) |
|
| 1863 | - $do_fix = true; |
|
| 1971 | + if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) { |
|
| 1972 | + $do_fix = true; |
|
| 1973 | + } |
|
| 1864 | 1974 | |
| 1865 | 1975 | // Okay, #4 - perhaps it's an IP address? We're gonna want to use that one, then. (assuming it's the IP or something...) |
| 1866 | 1976 | if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1) |
@@ -1894,8 +2004,9 @@ discard block |
||
| 1894 | 2004 | $board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl)); |
| 1895 | 2005 | } |
| 1896 | 2006 | } |
| 1897 | - foreach ($context['linktree'] as $k => $dummy) |
|
| 1898 | - $context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl)); |
|
| 2007 | + foreach ($context['linktree'] as $k => $dummy) { |
|
| 2008 | + $context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl)); |
|
| 2009 | + } |
|
| 1899 | 2010 | } |
| 1900 | 2011 | } |
| 1901 | 2012 | // Set up the contextual user array. |
@@ -1914,16 +2025,16 @@ discard block |
||
| 1914 | 2025 | 'email' => $user_info['email'], |
| 1915 | 2026 | 'ignoreusers' => $user_info['ignoreusers'], |
| 1916 | 2027 | ); |
| 1917 | - if (!$context['user']['is_guest']) |
|
| 1918 | - $context['user']['name'] = $user_info['name']; |
|
| 1919 | - elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) |
|
| 1920 | - $context['user']['name'] = $txt['guest_title']; |
|
| 2028 | + if (!$context['user']['is_guest']) { |
|
| 2029 | + $context['user']['name'] = $user_info['name']; |
|
| 2030 | + } elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) { |
|
| 2031 | + $context['user']['name'] = $txt['guest_title']; |
|
| 2032 | + } |
|
| 1921 | 2033 | |
| 1922 | 2034 | // Determine the current smiley set. |
| 1923 | 2035 | $user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set']; |
| 1924 | 2036 | $context['user']['smiley_set'] = $user_info['smiley_set']; |
| 1925 | - } |
|
| 1926 | - else |
|
| 2037 | + } else |
|
| 1927 | 2038 | { |
| 1928 | 2039 | $context['user'] = array( |
| 1929 | 2040 | 'id' => -1, |
@@ -1939,18 +2050,24 @@ discard block |
||
| 1939 | 2050 | } |
| 1940 | 2051 | |
| 1941 | 2052 | // Some basic information... |
| 1942 | - if (!isset($context['html_headers'])) |
|
| 1943 | - $context['html_headers'] = ''; |
|
| 1944 | - if (!isset($context['javascript_files'])) |
|
| 1945 | - $context['javascript_files'] = array(); |
|
| 1946 | - if (!isset($context['css_files'])) |
|
| 1947 | - $context['css_files'] = array(); |
|
| 1948 | - if (!isset($context['css_header'])) |
|
| 1949 | - $context['css_header'] = array(); |
|
| 1950 | - if (!isset($context['javascript_inline'])) |
|
| 1951 | - $context['javascript_inline'] = array('standard' => array(), 'defer' => array()); |
|
| 1952 | - if (!isset($context['javascript_vars'])) |
|
| 1953 | - $context['javascript_vars'] = array(); |
|
| 2053 | + if (!isset($context['html_headers'])) { |
|
| 2054 | + $context['html_headers'] = ''; |
|
| 2055 | + } |
|
| 2056 | + if (!isset($context['javascript_files'])) { |
|
| 2057 | + $context['javascript_files'] = array(); |
|
| 2058 | + } |
|
| 2059 | + if (!isset($context['css_files'])) { |
|
| 2060 | + $context['css_files'] = array(); |
|
| 2061 | + } |
|
| 2062 | + if (!isset($context['css_header'])) { |
|
| 2063 | + $context['css_header'] = array(); |
|
| 2064 | + } |
|
| 2065 | + if (!isset($context['javascript_inline'])) { |
|
| 2066 | + $context['javascript_inline'] = array('standard' => array(), 'defer' => array()); |
|
| 2067 | + } |
|
| 2068 | + if (!isset($context['javascript_vars'])) { |
|
| 2069 | + $context['javascript_vars'] = array(); |
|
| 2070 | + } |
|
| 1954 | 2071 | |
| 1955 | 2072 | $context['login_url'] = (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl) . '?action=login2'; |
| 1956 | 2073 | $context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | '; |
@@ -1962,8 +2079,9 @@ discard block |
||
| 1962 | 2079 | $context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null; |
| 1963 | 2080 | $context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null; |
| 1964 | 2081 | $context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3; |
| 1965 | - if (isset($modSettings['load_average'])) |
|
| 1966 | - $context['load_average'] = $modSettings['load_average']; |
|
| 2082 | + if (isset($modSettings['load_average'])) { |
|
| 2083 | + $context['load_average'] = $modSettings['load_average']; |
|
| 2084 | + } |
|
| 1967 | 2085 | |
| 1968 | 2086 | // Detect the browser. This is separated out because it's also used in attachment downloads |
| 1969 | 2087 | detectBrowser(); |
@@ -1977,8 +2095,9 @@ discard block |
||
| 1977 | 2095 | // This allows sticking some HTML on the page output - useful for controls. |
| 1978 | 2096 | $context['insert_after_template'] = ''; |
| 1979 | 2097 | |
| 1980 | - if (!isset($txt)) |
|
| 1981 | - $txt = array(); |
|
| 2098 | + if (!isset($txt)) { |
|
| 2099 | + $txt = array(); |
|
| 2100 | + } |
|
| 1982 | 2101 | |
| 1983 | 2102 | $simpleActions = array( |
| 1984 | 2103 | 'findmember', |
@@ -2024,9 +2143,10 @@ discard block |
||
| 2024 | 2143 | |
| 2025 | 2144 | // See if theres any extra param to check. |
| 2026 | 2145 | $requiresXML = false; |
| 2027 | - foreach ($extraParams as $key => $extra) |
|
| 2028 | - if (isset($_REQUEST[$extra])) |
|
| 2146 | + foreach ($extraParams as $key => $extra) { |
|
| 2147 | + if (isset($_REQUEST[$extra])) |
|
| 2029 | 2148 | $requiresXML = true; |
| 2149 | + } |
|
| 2030 | 2150 | |
| 2031 | 2151 | // Output is fully XML, so no need for the index template. |
| 2032 | 2152 | if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML)) |
@@ -2041,37 +2161,39 @@ discard block |
||
| 2041 | 2161 | { |
| 2042 | 2162 | loadLanguage('index+Modifications'); |
| 2043 | 2163 | $context['template_layers'] = array(); |
| 2044 | - } |
|
| 2045 | - |
|
| 2046 | - else |
|
| 2164 | + } else |
|
| 2047 | 2165 | { |
| 2048 | 2166 | // Custom templates to load, or just default? |
| 2049 | - if (isset($settings['theme_templates'])) |
|
| 2050 | - $templates = explode(',', $settings['theme_templates']); |
|
| 2051 | - else |
|
| 2052 | - $templates = array('index'); |
|
| 2167 | + if (isset($settings['theme_templates'])) { |
|
| 2168 | + $templates = explode(',', $settings['theme_templates']); |
|
| 2169 | + } else { |
|
| 2170 | + $templates = array('index'); |
|
| 2171 | + } |
|
| 2053 | 2172 | |
| 2054 | 2173 | // Load each template... |
| 2055 | - foreach ($templates as $template) |
|
| 2056 | - loadTemplate($template); |
|
| 2174 | + foreach ($templates as $template) { |
|
| 2175 | + loadTemplate($template); |
|
| 2176 | + } |
|
| 2057 | 2177 | |
| 2058 | 2178 | // ...and attempt to load their associated language files. |
| 2059 | 2179 | $required_files = implode('+', array_merge($templates, array('Modifications'))); |
| 2060 | 2180 | loadLanguage($required_files, '', false); |
| 2061 | 2181 | |
| 2062 | 2182 | // Custom template layers? |
| 2063 | - if (isset($settings['theme_layers'])) |
|
| 2064 | - $context['template_layers'] = explode(',', $settings['theme_layers']); |
|
| 2065 | - else |
|
| 2066 | - $context['template_layers'] = array('html', 'body'); |
|
| 2183 | + if (isset($settings['theme_layers'])) { |
|
| 2184 | + $context['template_layers'] = explode(',', $settings['theme_layers']); |
|
| 2185 | + } else { |
|
| 2186 | + $context['template_layers'] = array('html', 'body'); |
|
| 2187 | + } |
|
| 2067 | 2188 | } |
| 2068 | 2189 | |
| 2069 | 2190 | // Initialize the theme. |
| 2070 | 2191 | loadSubTemplate('init', 'ignore'); |
| 2071 | 2192 | |
| 2072 | 2193 | // Allow overriding the board wide time/number formats. |
| 2073 | - if (empty($user_settings['time_format']) && !empty($txt['time_format'])) |
|
| 2074 | - $user_info['time_format'] = $txt['time_format']; |
|
| 2194 | + if (empty($user_settings['time_format']) && !empty($txt['time_format'])) { |
|
| 2195 | + $user_info['time_format'] = $txt['time_format']; |
|
| 2196 | + } |
|
| 2075 | 2197 | |
| 2076 | 2198 | // Set the character set from the template. |
| 2077 | 2199 | $context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']; |
@@ -2079,12 +2201,14 @@ discard block |
||
| 2079 | 2201 | $context['right_to_left'] = !empty($txt['lang_rtl']); |
| 2080 | 2202 | |
| 2081 | 2203 | // Guests may still need a name. |
| 2082 | - if ($context['user']['is_guest'] && empty($context['user']['name'])) |
|
| 2083 | - $context['user']['name'] = $txt['guest_title']; |
|
| 2204 | + if ($context['user']['is_guest'] && empty($context['user']['name'])) { |
|
| 2205 | + $context['user']['name'] = $txt['guest_title']; |
|
| 2206 | + } |
|
| 2084 | 2207 | |
| 2085 | 2208 | // Any theme-related strings that need to be loaded? |
| 2086 | - if (!empty($settings['require_theme_strings'])) |
|
| 2087 | - loadLanguage('ThemeStrings', '', false); |
|
| 2209 | + if (!empty($settings['require_theme_strings'])) { |
|
| 2210 | + loadLanguage('ThemeStrings', '', false); |
|
| 2211 | + } |
|
| 2088 | 2212 | |
| 2089 | 2213 | // Make a special URL for the language. |
| 2090 | 2214 | $settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']); |
@@ -2095,8 +2219,9 @@ discard block |
||
| 2095 | 2219 | // Here is my luvly Responsive CSS |
| 2096 | 2220 | loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true), 'smf_responsive'); |
| 2097 | 2221 | |
| 2098 | - if ($context['right_to_left']) |
|
| 2099 | - loadCSSFile('rtl.css', array(), 'smf_rtl'); |
|
| 2222 | + if ($context['right_to_left']) { |
|
| 2223 | + loadCSSFile('rtl.css', array(), 'smf_rtl'); |
|
| 2224 | + } |
|
| 2100 | 2225 | |
| 2101 | 2226 | // We allow theme variants, because we're cool. |
| 2102 | 2227 | $context['theme_variant'] = ''; |
@@ -2104,14 +2229,17 @@ discard block |
||
| 2104 | 2229 | if (!empty($settings['theme_variants'])) |
| 2105 | 2230 | { |
| 2106 | 2231 | // Overriding - for previews and that ilk. |
| 2107 | - if (!empty($_REQUEST['variant'])) |
|
| 2108 | - $_SESSION['id_variant'] = $_REQUEST['variant']; |
|
| 2232 | + if (!empty($_REQUEST['variant'])) { |
|
| 2233 | + $_SESSION['id_variant'] = $_REQUEST['variant']; |
|
| 2234 | + } |
|
| 2109 | 2235 | // User selection? |
| 2110 | - if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) |
|
| 2111 | - $context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : ''); |
|
| 2236 | + if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) { |
|
| 2237 | + $context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : ''); |
|
| 2238 | + } |
|
| 2112 | 2239 | // If not a user variant, select the default. |
| 2113 | - if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) |
|
| 2114 | - $context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0]; |
|
| 2240 | + if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) { |
|
| 2241 | + $context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0]; |
|
| 2242 | + } |
|
| 2115 | 2243 | |
| 2116 | 2244 | // Do this to keep things easier in the templates. |
| 2117 | 2245 | $context['theme_variant'] = '_' . $context['theme_variant']; |
@@ -2120,20 +2248,23 @@ discard block |
||
| 2120 | 2248 | if (!empty($context['theme_variant'])) |
| 2121 | 2249 | { |
| 2122 | 2250 | loadCSSFile('index' . $context['theme_variant'] . '.css', array(), 'smf_index' . $context['theme_variant']); |
| 2123 | - if ($context['right_to_left']) |
|
| 2124 | - loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']); |
|
| 2251 | + if ($context['right_to_left']) { |
|
| 2252 | + loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']); |
|
| 2253 | + } |
|
| 2125 | 2254 | } |
| 2126 | 2255 | } |
| 2127 | 2256 | |
| 2128 | 2257 | // Let's be compatible with old themes! |
| 2129 | - if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) |
|
| 2130 | - $context['template_layers'] = array('main'); |
|
| 2258 | + if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) { |
|
| 2259 | + $context['template_layers'] = array('main'); |
|
| 2260 | + } |
|
| 2131 | 2261 | |
| 2132 | 2262 | $context['tabindex'] = 1; |
| 2133 | 2263 | |
| 2134 | 2264 | // Compatibility. |
| 2135 | - if (!isset($settings['theme_version'])) |
|
| 2136 | - $modSettings['memberCount'] = $modSettings['totalMembers']; |
|
| 2265 | + if (!isset($settings['theme_version'])) { |
|
| 2266 | + $modSettings['memberCount'] = $modSettings['totalMembers']; |
|
| 2267 | + } |
|
| 2137 | 2268 | |
| 2138 | 2269 | // Default JS variables for use in every theme |
| 2139 | 2270 | $context['javascript_vars'] = array( |
@@ -2152,18 +2283,18 @@ discard block |
||
| 2152 | 2283 | ); |
| 2153 | 2284 | |
| 2154 | 2285 | // Add the JQuery library to the list of files to load. |
| 2155 | - if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') |
|
| 2156 | - loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
| 2157 | - |
|
| 2158 | - elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') |
|
| 2159 | - loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery'); |
|
| 2160 | - |
|
| 2161 | - elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') |
|
| 2162 | - loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery'); |
|
| 2286 | + if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') { |
|
| 2287 | + loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
| 2288 | + } elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') { |
|
| 2289 | + loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery'); |
|
| 2290 | + } elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') { |
|
| 2291 | + loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery'); |
|
| 2292 | + } |
|
| 2163 | 2293 | |
| 2164 | 2294 | // Auto loading? template_javascript() will take care of the local half of this. |
| 2165 | - else |
|
| 2166 | - loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
| 2295 | + else { |
|
| 2296 | + loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery'); |
|
| 2297 | + } |
|
| 2167 | 2298 | |
| 2168 | 2299 | // Queue our JQuery plugins! |
| 2169 | 2300 | loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins'); |
@@ -2186,12 +2317,12 @@ discard block |
||
| 2186 | 2317 | require_once($sourcedir . '/ScheduledTasks.php'); |
| 2187 | 2318 | |
| 2188 | 2319 | // What to do, what to do?! |
| 2189 | - if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) |
|
| 2190 | - AutoTask(); |
|
| 2191 | - else |
|
| 2192 | - ReduceMailQueue(); |
|
| 2193 | - } |
|
| 2194 | - else |
|
| 2320 | + if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) { |
|
| 2321 | + AutoTask(); |
|
| 2322 | + } else { |
|
| 2323 | + ReduceMailQueue(); |
|
| 2324 | + } |
|
| 2325 | + } else |
|
| 2195 | 2326 | { |
| 2196 | 2327 | $type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq'; |
| 2197 | 2328 | $ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time']; |
@@ -2242,8 +2373,9 @@ discard block |
||
| 2242 | 2373 | foreach ($theme_includes as $include) |
| 2243 | 2374 | { |
| 2244 | 2375 | $include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
| 2245 | - if (file_exists($include)) |
|
| 2246 | - require_once($include); |
|
| 2376 | + if (file_exists($include)) { |
|
| 2377 | + require_once($include); |
|
| 2378 | + } |
|
| 2247 | 2379 | } |
| 2248 | 2380 | } |
| 2249 | 2381 | |
@@ -2273,16 +2405,19 @@ discard block |
||
| 2273 | 2405 | // Do any style sheets first, cause we're easy with those. |
| 2274 | 2406 | if (!empty($style_sheets)) |
| 2275 | 2407 | { |
| 2276 | - if (!is_array($style_sheets)) |
|
| 2277 | - $style_sheets = array($style_sheets); |
|
| 2408 | + if (!is_array($style_sheets)) { |
|
| 2409 | + $style_sheets = array($style_sheets); |
|
| 2410 | + } |
|
| 2278 | 2411 | |
| 2279 | - foreach ($style_sheets as $sheet) |
|
| 2280 | - loadCSSFile($sheet . '.css', array(), $sheet); |
|
| 2412 | + foreach ($style_sheets as $sheet) { |
|
| 2413 | + loadCSSFile($sheet . '.css', array(), $sheet); |
|
| 2414 | + } |
|
| 2281 | 2415 | } |
| 2282 | 2416 | |
| 2283 | 2417 | // No template to load? |
| 2284 | - if ($template_name === false) |
|
| 2285 | - return true; |
|
| 2418 | + if ($template_name === false) { |
|
| 2419 | + return true; |
|
| 2420 | + } |
|
| 2286 | 2421 | |
| 2287 | 2422 | $loaded = false; |
| 2288 | 2423 | foreach ($settings['template_dirs'] as $template_dir) |
@@ -2297,12 +2432,14 @@ discard block |
||
| 2297 | 2432 | |
| 2298 | 2433 | if ($loaded) |
| 2299 | 2434 | { |
| 2300 | - if ($db_show_debug === true) |
|
| 2301 | - $context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')'; |
|
| 2435 | + if ($db_show_debug === true) { |
|
| 2436 | + $context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')'; |
|
| 2437 | + } |
|
| 2302 | 2438 | |
| 2303 | 2439 | // If they have specified an initialization function for this template, go ahead and call it now. |
| 2304 | - if (function_exists('template_' . $template_name . '_init')) |
|
| 2305 | - call_user_func('template_' . $template_name . '_init'); |
|
| 2440 | + if (function_exists('template_' . $template_name . '_init')) { |
|
| 2441 | + call_user_func('template_' . $template_name . '_init'); |
|
| 2442 | + } |
|
| 2306 | 2443 | } |
| 2307 | 2444 | // Hmmm... doesn't exist?! I don't suppose the directory is wrong, is it? |
| 2308 | 2445 | elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default')) |
@@ -2322,13 +2459,14 @@ discard block |
||
| 2322 | 2459 | loadTemplate($template_name); |
| 2323 | 2460 | } |
| 2324 | 2461 | // Cause an error otherwise. |
| 2325 | - elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) |
|
| 2326 | - fatal_lang_error('theme_template_error', 'template', array((string) $template_name)); |
|
| 2327 | - elseif ($fatal) |
|
| 2328 | - die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template')); |
|
| 2329 | - else |
|
| 2330 | - return false; |
|
| 2331 | -} |
|
| 2462 | + elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) { |
|
| 2463 | + fatal_lang_error('theme_template_error', 'template', array((string) $template_name)); |
|
| 2464 | + } elseif ($fatal) { |
|
| 2465 | + die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template')); |
|
| 2466 | + } else { |
|
| 2467 | + return false; |
|
| 2468 | + } |
|
| 2469 | + } |
|
| 2332 | 2470 | |
| 2333 | 2471 | /** |
| 2334 | 2472 | * Load a sub-template. |
@@ -2346,17 +2484,19 @@ discard block |
||
| 2346 | 2484 | { |
| 2347 | 2485 | global $context, $txt, $db_show_debug; |
| 2348 | 2486 | |
| 2349 | - if ($db_show_debug === true) |
|
| 2350 | - $context['debug']['sub_templates'][] = $sub_template_name; |
|
| 2487 | + if ($db_show_debug === true) { |
|
| 2488 | + $context['debug']['sub_templates'][] = $sub_template_name; |
|
| 2489 | + } |
|
| 2351 | 2490 | |
| 2352 | 2491 | // Figure out what the template function is named. |
| 2353 | 2492 | $theme_function = 'template_' . $sub_template_name; |
| 2354 | - if (function_exists($theme_function)) |
|
| 2355 | - $theme_function(); |
|
| 2356 | - elseif ($fatal === false) |
|
| 2357 | - fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name)); |
|
| 2358 | - elseif ($fatal !== 'ignore') |
|
| 2359 | - die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template')); |
|
| 2493 | + if (function_exists($theme_function)) { |
|
| 2494 | + $theme_function(); |
|
| 2495 | + } elseif ($fatal === false) { |
|
| 2496 | + fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name)); |
|
| 2497 | + } elseif ($fatal !== 'ignore') { |
|
| 2498 | + die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template')); |
|
| 2499 | + } |
|
| 2360 | 2500 | |
| 2361 | 2501 | // Are we showing debugging for templates? Just make sure not to do it before the doctype... |
| 2362 | 2502 | if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml'])) |
@@ -2393,8 +2533,9 @@ discard block |
||
| 2393 | 2533 | $params['validate'] = isset($params['validate']) ? $params['validate'] : true; |
| 2394 | 2534 | |
| 2395 | 2535 | // If this is an external file, automatically set this to false. |
| 2396 | - if (!empty($params['external'])) |
|
| 2397 | - $params['minimize'] = false; |
|
| 2536 | + if (!empty($params['external'])) { |
|
| 2537 | + $params['minimize'] = false; |
|
| 2538 | + } |
|
| 2398 | 2539 | |
| 2399 | 2540 | // Account for shorthand like admin.css?alp21 filenames |
| 2400 | 2541 | $has_seed = strpos($fileName, '.css?'); |
@@ -2411,13 +2552,10 @@ discard block |
||
| 2411 | 2552 | { |
| 2412 | 2553 | $fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
| 2413 | 2554 | $filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
| 2555 | + } else { |
|
| 2556 | + $fileUrl = false; |
|
| 2414 | 2557 | } |
| 2415 | - |
|
| 2416 | - else |
|
| 2417 | - $fileUrl = false; |
|
| 2418 | - } |
|
| 2419 | - |
|
| 2420 | - else |
|
| 2558 | + } else |
|
| 2421 | 2559 | { |
| 2422 | 2560 | $fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
| 2423 | 2561 | $filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']); |
@@ -2432,12 +2570,14 @@ discard block |
||
| 2432 | 2570 | } |
| 2433 | 2571 | |
| 2434 | 2572 | // Add it to the array for use in the template |
| 2435 | - if (!empty($fileName)) |
|
| 2436 | - $context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
| 2573 | + if (!empty($fileName)) { |
|
| 2574 | + $context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
| 2575 | + } |
|
| 2437 | 2576 | |
| 2438 | - if (!empty($context['right_to_left']) && !empty($params['rtl'])) |
|
| 2439 | - loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0))); |
|
| 2440 | -} |
|
| 2577 | + if (!empty($context['right_to_left']) && !empty($params['rtl'])) { |
|
| 2578 | + loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0))); |
|
| 2579 | + } |
|
| 2580 | + } |
|
| 2441 | 2581 | |
| 2442 | 2582 | /** |
| 2443 | 2583 | * Add a block of inline css code to be executed later |
@@ -2454,8 +2594,9 @@ discard block |
||
| 2454 | 2594 | global $context; |
| 2455 | 2595 | |
| 2456 | 2596 | // Gotta add something... |
| 2457 | - if (empty($css)) |
|
| 2458 | - return false; |
|
| 2597 | + if (empty($css)) { |
|
| 2598 | + return false; |
|
| 2599 | + } |
|
| 2459 | 2600 | |
| 2460 | 2601 | $context['css_header'][] = $css; |
| 2461 | 2602 | } |
@@ -2490,8 +2631,9 @@ discard block |
||
| 2490 | 2631 | $params['validate'] = isset($params['validate']) ? $params['validate'] : true; |
| 2491 | 2632 | |
| 2492 | 2633 | // If this is an external file, automatically set this to false. |
| 2493 | - if (!empty($params['external'])) |
|
| 2494 | - $params['minimize'] = false; |
|
| 2634 | + if (!empty($params['external'])) { |
|
| 2635 | + $params['minimize'] = false; |
|
| 2636 | + } |
|
| 2495 | 2637 | |
| 2496 | 2638 | // Account for shorthand like admin.js?alp21 filenames |
| 2497 | 2639 | $has_seed = strpos($fileName, '.js?'); |
@@ -2508,16 +2650,12 @@ discard block |
||
| 2508 | 2650 | { |
| 2509 | 2651 | $fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
| 2510 | 2652 | $filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
| 2511 | - } |
|
| 2512 | - |
|
| 2513 | - else |
|
| 2653 | + } else |
|
| 2514 | 2654 | { |
| 2515 | 2655 | $fileUrl = false; |
| 2516 | 2656 | $filePath = false; |
| 2517 | 2657 | } |
| 2518 | - } |
|
| 2519 | - |
|
| 2520 | - else |
|
| 2658 | + } else |
|
| 2521 | 2659 | { |
| 2522 | 2660 | $fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
| 2523 | 2661 | $filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']); |
@@ -2532,9 +2670,10 @@ discard block |
||
| 2532 | 2670 | } |
| 2533 | 2671 | |
| 2534 | 2672 | // Add it to the array for use in the template |
| 2535 | - if (!empty($fileName)) |
|
| 2536 | - $context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
| 2537 | -} |
|
| 2673 | + if (!empty($fileName)) { |
|
| 2674 | + $context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params); |
|
| 2675 | + } |
|
| 2676 | + } |
|
| 2538 | 2677 | |
| 2539 | 2678 | /** |
| 2540 | 2679 | * Add a Javascript variable for output later (for feeding text strings and similar to JS) |
@@ -2548,9 +2687,10 @@ discard block |
||
| 2548 | 2687 | { |
| 2549 | 2688 | global $context; |
| 2550 | 2689 | |
| 2551 | - if (!empty($key) && (!empty($value) || $value === '0')) |
|
| 2552 | - $context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value; |
|
| 2553 | -} |
|
| 2690 | + if (!empty($key) && (!empty($value) || $value === '0')) { |
|
| 2691 | + $context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value; |
|
| 2692 | + } |
|
| 2693 | + } |
|
| 2554 | 2694 | |
| 2555 | 2695 | /** |
| 2556 | 2696 | * Add a block of inline Javascript code to be executed later |
@@ -2567,8 +2707,9 @@ discard block |
||
| 2567 | 2707 | { |
| 2568 | 2708 | global $context; |
| 2569 | 2709 | |
| 2570 | - if (empty($javascript)) |
|
| 2571 | - return false; |
|
| 2710 | + if (empty($javascript)) { |
|
| 2711 | + return false; |
|
| 2712 | + } |
|
| 2572 | 2713 | |
| 2573 | 2714 | $context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript; |
| 2574 | 2715 | } |
@@ -2589,15 +2730,18 @@ discard block |
||
| 2589 | 2730 | static $already_loaded = array(); |
| 2590 | 2731 | |
| 2591 | 2732 | // Default to the user's language. |
| 2592 | - if ($lang == '') |
|
| 2593 | - $lang = isset($user_info['language']) ? $user_info['language'] : $language; |
|
| 2733 | + if ($lang == '') { |
|
| 2734 | + $lang = isset($user_info['language']) ? $user_info['language'] : $language; |
|
| 2735 | + } |
|
| 2594 | 2736 | |
| 2595 | 2737 | // Do we want the English version of language file as fallback? |
| 2596 | - if (empty($modSettings['disable_language_fallback']) && $lang != 'english') |
|
| 2597 | - loadLanguage($template_name, 'english', false); |
|
| 2738 | + if (empty($modSettings['disable_language_fallback']) && $lang != 'english') { |
|
| 2739 | + loadLanguage($template_name, 'english', false); |
|
| 2740 | + } |
|
| 2598 | 2741 | |
| 2599 | - if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) |
|
| 2600 | - return $lang; |
|
| 2742 | + if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) { |
|
| 2743 | + return $lang; |
|
| 2744 | + } |
|
| 2601 | 2745 | |
| 2602 | 2746 | // Make sure we have $settings - if not we're in trouble and need to find it! |
| 2603 | 2747 | if (empty($settings['default_theme_dir'])) |
@@ -2608,8 +2752,9 @@ discard block |
||
| 2608 | 2752 | |
| 2609 | 2753 | // What theme are we in? |
| 2610 | 2754 | $theme_name = basename($settings['theme_url']); |
| 2611 | - if (empty($theme_name)) |
|
| 2612 | - $theme_name = 'unknown'; |
|
| 2755 | + if (empty($theme_name)) { |
|
| 2756 | + $theme_name = 'unknown'; |
|
| 2757 | + } |
|
| 2613 | 2758 | |
| 2614 | 2759 | // For each file open it up and write it out! |
| 2615 | 2760 | foreach (explode('+', $template_name) as $template) |
@@ -2651,8 +2796,9 @@ discard block |
||
| 2651 | 2796 | $found = true; |
| 2652 | 2797 | |
| 2653 | 2798 | // setlocale is required for basename() & pathinfo() to work properly on the selected language |
| 2654 | - if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) |
|
| 2655 | - setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']); |
|
| 2799 | + if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) { |
|
| 2800 | + setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']); |
|
| 2801 | + } |
|
| 2656 | 2802 | |
| 2657 | 2803 | break; |
| 2658 | 2804 | } |
@@ -2692,8 +2838,9 @@ discard block |
||
| 2692 | 2838 | } |
| 2693 | 2839 | |
| 2694 | 2840 | // Keep track of what we're up to soldier. |
| 2695 | - if ($db_show_debug === true) |
|
| 2696 | - $context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')'; |
|
| 2841 | + if ($db_show_debug === true) { |
|
| 2842 | + $context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')'; |
|
| 2843 | + } |
|
| 2697 | 2844 | |
| 2698 | 2845 | // Remember what we have loaded, and in which language. |
| 2699 | 2846 | $already_loaded[$template_name] = $lang; |
@@ -2739,8 +2886,9 @@ discard block |
||
| 2739 | 2886 | ) |
| 2740 | 2887 | ); |
| 2741 | 2888 | // In the EXTREMELY unlikely event this happens, give an error message. |
| 2742 | - if ($smcFunc['db_num_rows']($result) == 0) |
|
| 2743 | - fatal_lang_error('parent_not_found', 'critical'); |
|
| 2889 | + if ($smcFunc['db_num_rows']($result) == 0) { |
|
| 2890 | + fatal_lang_error('parent_not_found', 'critical'); |
|
| 2891 | + } |
|
| 2744 | 2892 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
| 2745 | 2893 | { |
| 2746 | 2894 | if (!isset($boards[$row['id_board']])) |
@@ -2757,8 +2905,8 @@ discard block |
||
| 2757 | 2905 | ); |
| 2758 | 2906 | } |
| 2759 | 2907 | // If a moderator exists for this board, add that moderator for all children too. |
| 2760 | - if (!empty($row['id_moderator'])) |
|
| 2761 | - foreach ($boards as $id => $dummy) |
|
| 2908 | + if (!empty($row['id_moderator'])) { |
|
| 2909 | + foreach ($boards as $id => $dummy) |
|
| 2762 | 2910 | { |
| 2763 | 2911 | $boards[$id]['moderators'][$row['id_moderator']] = array( |
| 2764 | 2912 | 'id' => $row['id_moderator'], |
@@ -2766,11 +2914,12 @@ discard block |
||
| 2766 | 2914 | 'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'], |
| 2767 | 2915 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>' |
| 2768 | 2916 | ); |
| 2917 | + } |
|
| 2769 | 2918 | } |
| 2770 | 2919 | |
| 2771 | 2920 | // If a moderator group exists for this board, add that moderator group for all children too |
| 2772 | - if (!empty($row['id_moderator_group'])) |
|
| 2773 | - foreach ($boards as $id => $dummy) |
|
| 2921 | + if (!empty($row['id_moderator_group'])) { |
|
| 2922 | + foreach ($boards as $id => $dummy) |
|
| 2774 | 2923 | { |
| 2775 | 2924 | $boards[$id]['moderator_groups'][$row['id_moderator_group']] = array( |
| 2776 | 2925 | 'id' => $row['id_moderator_group'], |
@@ -2778,6 +2927,7 @@ discard block |
||
| 2778 | 2927 | 'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'], |
| 2779 | 2928 | 'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>' |
| 2780 | 2929 | ); |
| 2930 | + } |
|
| 2781 | 2931 | } |
| 2782 | 2932 | } |
| 2783 | 2933 | $smcFunc['db_free_result']($result); |
@@ -2804,23 +2954,27 @@ discard block |
||
| 2804 | 2954 | if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null) |
| 2805 | 2955 | { |
| 2806 | 2956 | // If we don't have our ucwords function defined yet, let's load the settings data. |
| 2807 | - if (empty($smcFunc['ucwords'])) |
|
| 2808 | - reloadSettings(); |
|
| 2957 | + if (empty($smcFunc['ucwords'])) { |
|
| 2958 | + reloadSettings(); |
|
| 2959 | + } |
|
| 2809 | 2960 | |
| 2810 | 2961 | // If we don't have our theme information yet, let's get it. |
| 2811 | - if (empty($settings['default_theme_dir'])) |
|
| 2812 | - loadTheme(0, false); |
|
| 2962 | + if (empty($settings['default_theme_dir'])) { |
|
| 2963 | + loadTheme(0, false); |
|
| 2964 | + } |
|
| 2813 | 2965 | |
| 2814 | 2966 | // Default language directories to try. |
| 2815 | 2967 | $language_directories = array( |
| 2816 | 2968 | $settings['default_theme_dir'] . '/languages', |
| 2817 | 2969 | ); |
| 2818 | - if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) |
|
| 2819 | - $language_directories[] = $settings['actual_theme_dir'] . '/languages'; |
|
| 2970 | + if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) { |
|
| 2971 | + $language_directories[] = $settings['actual_theme_dir'] . '/languages'; |
|
| 2972 | + } |
|
| 2820 | 2973 | |
| 2821 | 2974 | // We possibly have a base theme directory. |
| 2822 | - if (!empty($settings['base_theme_dir'])) |
|
| 2823 | - $language_directories[] = $settings['base_theme_dir'] . '/languages'; |
|
| 2975 | + if (!empty($settings['base_theme_dir'])) { |
|
| 2976 | + $language_directories[] = $settings['base_theme_dir'] . '/languages'; |
|
| 2977 | + } |
|
| 2824 | 2978 | |
| 2825 | 2979 | // Remove any duplicates. |
| 2826 | 2980 | $language_directories = array_unique($language_directories); |
@@ -2834,20 +2988,21 @@ discard block |
||
| 2834 | 2988 | foreach ($language_directories as $language_dir) |
| 2835 | 2989 | { |
| 2836 | 2990 | // Can't look in here... doesn't exist! |
| 2837 | - if (!file_exists($language_dir)) |
|
| 2838 | - continue; |
|
| 2991 | + if (!file_exists($language_dir)) { |
|
| 2992 | + continue; |
|
| 2993 | + } |
|
| 2839 | 2994 | |
| 2840 | 2995 | $dir = dir($language_dir); |
| 2841 | 2996 | while ($entry = $dir->read()) |
| 2842 | 2997 | { |
| 2843 | 2998 | // Look for the index language file... For good measure skip any "index.language-utf8.php" files |
| 2844 | - if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) |
|
| 2845 | - continue; |
|
| 2846 | - |
|
| 2847 | - if (!empty($langList) && !empty($langList[$matches[1]])) |
|
| 2848 | - $langName = $langList[$matches[1]]; |
|
| 2999 | + if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) { |
|
| 3000 | + continue; |
|
| 3001 | + } |
|
| 2849 | 3002 | |
| 2850 | - else |
|
| 3003 | + if (!empty($langList) && !empty($langList[$matches[1]])) { |
|
| 3004 | + $langName = $langList[$matches[1]]; |
|
| 3005 | + } else |
|
| 2851 | 3006 | { |
| 2852 | 3007 | $langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' '))); |
| 2853 | 3008 | |
@@ -2888,12 +3043,14 @@ discard block |
||
| 2888 | 3043 | } |
| 2889 | 3044 | |
| 2890 | 3045 | // Do we need to store the lang list? |
| 2891 | - if (empty($langList)) |
|
| 2892 | - updateSettings(array('langList' => json_encode($catchLang))); |
|
| 3046 | + if (empty($langList)) { |
|
| 3047 | + updateSettings(array('langList' => json_encode($catchLang))); |
|
| 3048 | + } |
|
| 2893 | 3049 | |
| 2894 | 3050 | // Let's cash in on this deal. |
| 2895 | - if (!empty($modSettings['cache_enable'])) |
|
| 2896 | - cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600); |
|
| 3051 | + if (!empty($modSettings['cache_enable'])) { |
|
| 3052 | + cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600); |
|
| 3053 | + } |
|
| 2897 | 3054 | } |
| 2898 | 3055 | |
| 2899 | 3056 | return $context['languages']; |
@@ -2916,8 +3073,9 @@ discard block |
||
| 2916 | 3073 | global $modSettings, $options, $txt; |
| 2917 | 3074 | static $censor_vulgar = null, $censor_proper; |
| 2918 | 3075 | |
| 2919 | - if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') |
|
| 2920 | - return $text; |
|
| 3076 | + if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') { |
|
| 3077 | + return $text; |
|
| 3078 | + } |
|
| 2921 | 3079 | |
| 2922 | 3080 | // If they haven't yet been loaded, load them. |
| 2923 | 3081 | if ($censor_vulgar == null) |
@@ -2945,9 +3103,9 @@ discard block |
||
| 2945 | 3103 | { |
| 2946 | 3104 | $func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace'; |
| 2947 | 3105 | $text = $func($censor_vulgar, $censor_proper, $text); |
| 3106 | + } else { |
|
| 3107 | + $text = preg_replace($censor_vulgar, $censor_proper, $text); |
|
| 2948 | 3108 | } |
| 2949 | - else |
|
| 2950 | - $text = preg_replace($censor_vulgar, $censor_proper, $text); |
|
| 2951 | 3109 | |
| 2952 | 3110 | return $text; |
| 2953 | 3111 | } |
@@ -2973,38 +3131,42 @@ discard block |
||
| 2973 | 3131 | @ini_set('track_errors', '1'); |
| 2974 | 3132 | |
| 2975 | 3133 | // Don't include the file more than once, if $once is true. |
| 2976 | - if ($once && in_array($filename, $templates)) |
|
| 2977 | - return; |
|
| 3134 | + if ($once && in_array($filename, $templates)) { |
|
| 3135 | + return; |
|
| 3136 | + } |
|
| 2978 | 3137 | // Add this file to the include list, whether $once is true or not. |
| 2979 | - else |
|
| 2980 | - $templates[] = $filename; |
|
| 3138 | + else { |
|
| 3139 | + $templates[] = $filename; |
|
| 3140 | + } |
|
| 2981 | 3141 | |
| 2982 | 3142 | // Are we going to use eval? |
| 2983 | 3143 | if (empty($modSettings['disableTemplateEval'])) |
| 2984 | 3144 | { |
| 2985 | 3145 | $file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false; |
| 2986 | 3146 | $settings['current_include_filename'] = $filename; |
| 2987 | - } |
|
| 2988 | - else |
|
| 3147 | + } else |
|
| 2989 | 3148 | { |
| 2990 | 3149 | $file_found = file_exists($filename); |
| 2991 | 3150 | |
| 2992 | - if ($once && $file_found) |
|
| 2993 | - require_once($filename); |
|
| 2994 | - elseif ($file_found) |
|
| 2995 | - require($filename); |
|
| 3151 | + if ($once && $file_found) { |
|
| 3152 | + require_once($filename); |
|
| 3153 | + } elseif ($file_found) { |
|
| 3154 | + require($filename); |
|
| 3155 | + } |
|
| 2996 | 3156 | } |
| 2997 | 3157 | |
| 2998 | 3158 | if ($file_found !== true) |
| 2999 | 3159 | { |
| 3000 | 3160 | ob_end_clean(); |
| 3001 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
| 3002 | - @ob_start('ob_gzhandler'); |
|
| 3003 | - else |
|
| 3004 | - ob_start(); |
|
| 3161 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
| 3162 | + @ob_start('ob_gzhandler'); |
|
| 3163 | + } else { |
|
| 3164 | + ob_start(); |
|
| 3165 | + } |
|
| 3005 | 3166 | |
| 3006 | - if (isset($_GET['debug'])) |
|
| 3007 | - header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
| 3167 | + if (isset($_GET['debug'])) { |
|
| 3168 | + header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
| 3169 | + } |
|
| 3008 | 3170 | |
| 3009 | 3171 | // Don't cache error pages!! |
| 3010 | 3172 | header('Expires: Mon, 26 Jul 1997 05:00:00 GMT'); |
@@ -3023,12 +3185,13 @@ discard block |
||
| 3023 | 3185 | echo '<!DOCTYPE html> |
| 3024 | 3186 | <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '> |
| 3025 | 3187 | <head>'; |
| 3026 | - if (isset($context['character_set'])) |
|
| 3027 | - echo ' |
|
| 3188 | + if (isset($context['character_set'])) { |
|
| 3189 | + echo ' |
|
| 3028 | 3190 | <meta charset="', $context['character_set'], '">'; |
| 3191 | + } |
|
| 3029 | 3192 | |
| 3030 | - if (!empty($maintenance) && !allowedTo('admin_forum')) |
|
| 3031 | - echo ' |
|
| 3193 | + if (!empty($maintenance) && !allowedTo('admin_forum')) { |
|
| 3194 | + echo ' |
|
| 3032 | 3195 | <title>', $mtitle, '</title> |
| 3033 | 3196 | </head> |
| 3034 | 3197 | <body> |
@@ -3036,8 +3199,8 @@ discard block |
||
| 3036 | 3199 | ', $mmessage, ' |
| 3037 | 3200 | </body> |
| 3038 | 3201 | </html>'; |
| 3039 | - elseif (!allowedTo('admin_forum')) |
|
| 3040 | - echo ' |
|
| 3202 | + } elseif (!allowedTo('admin_forum')) { |
|
| 3203 | + echo ' |
|
| 3041 | 3204 | <title>', $txt['template_parse_error'], '</title> |
| 3042 | 3205 | </head> |
| 3043 | 3206 | <body> |
@@ -3045,15 +3208,17 @@ discard block |
||
| 3045 | 3208 | ', $txt['template_parse_error_message'], ' |
| 3046 | 3209 | </body> |
| 3047 | 3210 | </html>'; |
| 3048 | - else |
|
| 3211 | + } else |
|
| 3049 | 3212 | { |
| 3050 | 3213 | require_once($sourcedir . '/Subs-Package.php'); |
| 3051 | 3214 | |
| 3052 | 3215 | $error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => ''))); |
| 3053 | - if (empty($error) && ini_get('track_errors') && !empty($php_errormsg)) |
|
| 3054 | - $error = $php_errormsg; |
|
| 3055 | - if (empty($error)) |
|
| 3056 | - $error = $txt['template_parse_errmsg']; |
|
| 3216 | + if (empty($error) && ini_get('track_errors') && !empty($php_errormsg)) { |
|
| 3217 | + $error = $php_errormsg; |
|
| 3218 | + } |
|
| 3219 | + if (empty($error)) { |
|
| 3220 | + $error = $txt['template_parse_errmsg']; |
|
| 3221 | + } |
|
| 3057 | 3222 | |
| 3058 | 3223 | $error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>')); |
| 3059 | 3224 | |
@@ -3064,11 +3229,12 @@ discard block |
||
| 3064 | 3229 | <h3>', $txt['template_parse_error'], '</h3> |
| 3065 | 3230 | ', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => ''))); |
| 3066 | 3231 | |
| 3067 | - if (!empty($error)) |
|
| 3068 | - echo ' |
|
| 3232 | + if (!empty($error)) { |
|
| 3233 | + echo ' |
|
| 3069 | 3234 | <hr> |
| 3070 | 3235 | |
| 3071 | 3236 | <div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>'; |
| 3237 | + } |
|
| 3072 | 3238 | |
| 3073 | 3239 | // I know, I know... this is VERY COMPLICATED. Still, it's good. |
| 3074 | 3240 | if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0) |
@@ -3078,10 +3244,11 @@ discard block |
||
| 3078 | 3244 | $data2 = preg_split('~\<br( /)?\>~', $data2); |
| 3079 | 3245 | |
| 3080 | 3246 | // Fix the PHP code stuff... |
| 3081 | - if (!isBrowser('gecko')) |
|
| 3082 | - $data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2); |
|
| 3083 | - else |
|
| 3084 | - $data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2); |
|
| 3247 | + if (!isBrowser('gecko')) { |
|
| 3248 | + $data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2); |
|
| 3249 | + } else { |
|
| 3250 | + $data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2); |
|
| 3251 | + } |
|
| 3085 | 3252 | |
| 3086 | 3253 | // Now we get to work around a bug in PHP where it doesn't escape <br>s! |
| 3087 | 3254 | $j = -1; |
@@ -3089,8 +3256,9 @@ discard block |
||
| 3089 | 3256 | { |
| 3090 | 3257 | $j++; |
| 3091 | 3258 | |
| 3092 | - if (substr_count($line, '<br>') == 0) |
|
| 3093 | - continue; |
|
| 3259 | + if (substr_count($line, '<br>') == 0) { |
|
| 3260 | + continue; |
|
| 3261 | + } |
|
| 3094 | 3262 | |
| 3095 | 3263 | $n = substr_count($line, '<br>'); |
| 3096 | 3264 | for ($i = 0; $i < $n; $i++) |
@@ -3109,38 +3277,42 @@ discard block |
||
| 3109 | 3277 | // Figure out what the color coding was before... |
| 3110 | 3278 | $line = max($match[1] - 9, 1); |
| 3111 | 3279 | $last_line = ''; |
| 3112 | - for ($line2 = $line - 1; $line2 > 1; $line2--) |
|
| 3113 | - if (strpos($data2[$line2], '<') !== false) |
|
| 3280 | + for ($line2 = $line - 1; $line2 > 1; $line2--) { |
|
| 3281 | + if (strpos($data2[$line2], '<') !== false) |
|
| 3114 | 3282 | { |
| 3115 | 3283 | if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0) |
| 3116 | 3284 | $last_line = $color_match[1]; |
| 3285 | + } |
|
| 3117 | 3286 | break; |
| 3118 | 3287 | } |
| 3119 | 3288 | |
| 3120 | 3289 | // Show the relevant lines... |
| 3121 | 3290 | for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++) |
| 3122 | 3291 | { |
| 3123 | - if ($line == $match[1]) |
|
| 3124 | - echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">'; |
|
| 3292 | + if ($line == $match[1]) { |
|
| 3293 | + echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">'; |
|
| 3294 | + } |
|
| 3125 | 3295 | |
| 3126 | 3296 | echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> '; |
| 3127 | - if (isset($data2[$line]) && $data2[$line] != '') |
|
| 3128 | - echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line]; |
|
| 3297 | + if (isset($data2[$line]) && $data2[$line] != '') { |
|
| 3298 | + echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line]; |
|
| 3299 | + } |
|
| 3129 | 3300 | |
| 3130 | 3301 | if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0) |
| 3131 | 3302 | { |
| 3132 | 3303 | $last_line = $color_match[1]; |
| 3133 | 3304 | echo '</', substr($last_line, 1, 4), '>'; |
| 3305 | + } elseif ($last_line != '' && strpos($data2[$line], '<') !== false) { |
|
| 3306 | + $last_line = ''; |
|
| 3307 | + } elseif ($last_line != '' && $data2[$line] != '') { |
|
| 3308 | + echo '</', substr($last_line, 1, 4), '>'; |
|
| 3134 | 3309 | } |
| 3135 | - elseif ($last_line != '' && strpos($data2[$line], '<') !== false) |
|
| 3136 | - $last_line = ''; |
|
| 3137 | - elseif ($last_line != '' && $data2[$line] != '') |
|
| 3138 | - echo '</', substr($last_line, 1, 4), '>'; |
|
| 3139 | 3310 | |
| 3140 | - if ($line == $match[1]) |
|
| 3141 | - echo '</pre></div><pre style="margin: 0;">'; |
|
| 3142 | - else |
|
| 3143 | - echo "\n"; |
|
| 3311 | + if ($line == $match[1]) { |
|
| 3312 | + echo '</pre></div><pre style="margin: 0;">'; |
|
| 3313 | + } else { |
|
| 3314 | + echo "\n"; |
|
| 3315 | + } |
|
| 3144 | 3316 | } |
| 3145 | 3317 | |
| 3146 | 3318 | echo '</pre></div>'; |
@@ -3164,8 +3336,9 @@ discard block |
||
| 3164 | 3336 | global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port; |
| 3165 | 3337 | |
| 3166 | 3338 | // Figure out what type of database we are using. |
| 3167 | - if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) |
|
| 3168 | - $db_type = 'mysql'; |
|
| 3339 | + if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) { |
|
| 3340 | + $db_type = 'mysql'; |
|
| 3341 | + } |
|
| 3169 | 3342 | |
| 3170 | 3343 | // Load the file for the database. |
| 3171 | 3344 | require_once($sourcedir . '/Subs-Db-' . $db_type . '.php'); |
@@ -3173,8 +3346,9 @@ discard block |
||
| 3173 | 3346 | $db_options = array(); |
| 3174 | 3347 | |
| 3175 | 3348 | // Add in the port if needed |
| 3176 | - if (!empty($db_port)) |
|
| 3177 | - $db_options['port'] = $db_port; |
|
| 3349 | + if (!empty($db_port)) { |
|
| 3350 | + $db_options['port'] = $db_port; |
|
| 3351 | + } |
|
| 3178 | 3352 | |
| 3179 | 3353 | // If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use. |
| 3180 | 3354 | if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd)) |
@@ -3193,13 +3367,15 @@ discard block |
||
| 3193 | 3367 | } |
| 3194 | 3368 | |
| 3195 | 3369 | // Safe guard here, if there isn't a valid connection lets put a stop to it. |
| 3196 | - if (!$db_connection) |
|
| 3197 | - display_db_error(); |
|
| 3370 | + if (!$db_connection) { |
|
| 3371 | + display_db_error(); |
|
| 3372 | + } |
|
| 3198 | 3373 | |
| 3199 | 3374 | // If in SSI mode fix up the prefix. |
| 3200 | - if (SMF == 'SSI') |
|
| 3201 | - db_fix_prefix($db_prefix, $db_name); |
|
| 3202 | -} |
|
| 3375 | + if (SMF == 'SSI') { |
|
| 3376 | + db_fix_prefix($db_prefix, $db_name); |
|
| 3377 | + } |
|
| 3378 | + } |
|
| 3203 | 3379 | |
| 3204 | 3380 | /** |
| 3205 | 3381 | * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it. |
@@ -3213,10 +3389,11 @@ discard block |
||
| 3213 | 3389 | global $sourcedir, $cacheAPI, $cache_accelerator; |
| 3214 | 3390 | |
| 3215 | 3391 | // Not overriding this and we have a cacheAPI, send it back. |
| 3216 | - if (empty($overrideCache) && is_object($cacheAPI)) |
|
| 3217 | - return $cacheAPI; |
|
| 3218 | - elseif (is_null($cacheAPI)) |
|
| 3219 | - $cacheAPI = false; |
|
| 3392 | + if (empty($overrideCache) && is_object($cacheAPI)) { |
|
| 3393 | + return $cacheAPI; |
|
| 3394 | + } elseif (is_null($cacheAPI)) { |
|
| 3395 | + $cacheAPI = false; |
|
| 3396 | + } |
|
| 3220 | 3397 | |
| 3221 | 3398 | // Make sure our class is in session. |
| 3222 | 3399 | require_once($sourcedir . '/Class-CacheAPI.php'); |
@@ -3237,8 +3414,9 @@ discard block |
||
| 3237 | 3414 | if (!$testAPI->isSupported()) |
| 3238 | 3415 | { |
| 3239 | 3416 | // Can we save ourselves? |
| 3240 | - if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') |
|
| 3241 | - return loadCacheAccelerator(null, false); |
|
| 3417 | + if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') { |
|
| 3418 | + return loadCacheAccelerator(null, false); |
|
| 3419 | + } |
|
| 3242 | 3420 | return false; |
| 3243 | 3421 | } |
| 3244 | 3422 | |
@@ -3250,9 +3428,9 @@ discard block |
||
| 3250 | 3428 | { |
| 3251 | 3429 | $cacheAPI = $testAPI; |
| 3252 | 3430 | return $cacheAPI; |
| 3431 | + } else { |
|
| 3432 | + return $testAPI; |
|
| 3253 | 3433 | } |
| 3254 | - else |
|
| 3255 | - return $testAPI; |
|
| 3256 | 3434 | } |
| 3257 | 3435 | } |
| 3258 | 3436 | |
@@ -3272,8 +3450,9 @@ discard block |
||
| 3272 | 3450 | |
| 3273 | 3451 | // @todo Why are we doing this if caching is disabled? |
| 3274 | 3452 | |
| 3275 | - if (function_exists('call_integration_hook')) |
|
| 3276 | - call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level)); |
|
| 3453 | + if (function_exists('call_integration_hook')) { |
|
| 3454 | + call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level)); |
|
| 3455 | + } |
|
| 3277 | 3456 | |
| 3278 | 3457 | /* Refresh the cache if either: |
| 3279 | 3458 | 1. Caching is disabled. |
@@ -3287,16 +3466,19 @@ discard block |
||
| 3287 | 3466 | require_once($sourcedir . '/' . $file); |
| 3288 | 3467 | $cache_block = call_user_func_array($function, $params); |
| 3289 | 3468 | |
| 3290 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) |
|
| 3291 | - cache_put_data($key, $cache_block, $cache_block['expires'] - time()); |
|
| 3469 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) { |
|
| 3470 | + cache_put_data($key, $cache_block, $cache_block['expires'] - time()); |
|
| 3471 | + } |
|
| 3292 | 3472 | } |
| 3293 | 3473 | |
| 3294 | 3474 | // Some cached data may need a freshening up after retrieval. |
| 3295 | - if (!empty($cache_block['post_retri_eval'])) |
|
| 3296 | - eval($cache_block['post_retri_eval']); |
|
| 3475 | + if (!empty($cache_block['post_retri_eval'])) { |
|
| 3476 | + eval($cache_block['post_retri_eval']); |
|
| 3477 | + } |
|
| 3297 | 3478 | |
| 3298 | - if (function_exists('call_integration_hook')) |
|
| 3299 | - call_integration_hook('post_cache_quick_get', array(&$cache_block)); |
|
| 3479 | + if (function_exists('call_integration_hook')) { |
|
| 3480 | + call_integration_hook('post_cache_quick_get', array(&$cache_block)); |
|
| 3481 | + } |
|
| 3300 | 3482 | |
| 3301 | 3483 | return $cache_block['data']; |
| 3302 | 3484 | } |
@@ -3323,8 +3505,9 @@ discard block |
||
| 3323 | 3505 | global $boardurl, $modSettings, $cache_enable, $cacheAPI; |
| 3324 | 3506 | global $cache_hits, $cache_count, $db_show_debug; |
| 3325 | 3507 | |
| 3326 | - if (empty($cache_enable) || empty($cacheAPI)) |
|
| 3327 | - return; |
|
| 3508 | + if (empty($cache_enable) || empty($cacheAPI)) { |
|
| 3509 | + return; |
|
| 3510 | + } |
|
| 3328 | 3511 | |
| 3329 | 3512 | $cache_count = isset($cache_count) ? $cache_count + 1 : 1; |
| 3330 | 3513 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -3337,12 +3520,14 @@ discard block |
||
| 3337 | 3520 | $value = $value === null ? null : json_encode($value); |
| 3338 | 3521 | $cacheAPI->putData($key, $value, $ttl); |
| 3339 | 3522 | |
| 3340 | - if (function_exists('call_integration_hook')) |
|
| 3341 | - call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl)); |
|
| 3523 | + if (function_exists('call_integration_hook')) { |
|
| 3524 | + call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl)); |
|
| 3525 | + } |
|
| 3342 | 3526 | |
| 3343 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
| 3344 | - $cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st)); |
|
| 3345 | -} |
|
| 3527 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
| 3528 | + $cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st)); |
|
| 3529 | + } |
|
| 3530 | + } |
|
| 3346 | 3531 | |
| 3347 | 3532 | /** |
| 3348 | 3533 | * Gets the value from the cache specified by key, so long as it is not older than ttl seconds. |
@@ -3358,8 +3543,9 @@ discard block |
||
| 3358 | 3543 | global $boardurl, $modSettings, $cache_enable, $cacheAPI; |
| 3359 | 3544 | global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug; |
| 3360 | 3545 | |
| 3361 | - if (empty($cache_enable) || empty($cacheAPI)) |
|
| 3362 | - return; |
|
| 3546 | + if (empty($cache_enable) || empty($cacheAPI)) { |
|
| 3547 | + return; |
|
| 3548 | + } |
|
| 3363 | 3549 | |
| 3364 | 3550 | $cache_count = isset($cache_count) ? $cache_count + 1 : 1; |
| 3365 | 3551 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -3379,16 +3565,18 @@ discard block |
||
| 3379 | 3565 | |
| 3380 | 3566 | if (empty($value)) |
| 3381 | 3567 | { |
| 3382 | - if (!is_array($cache_misses)) |
|
| 3383 | - $cache_misses = array(); |
|
| 3568 | + if (!is_array($cache_misses)) { |
|
| 3569 | + $cache_misses = array(); |
|
| 3570 | + } |
|
| 3384 | 3571 | |
| 3385 | 3572 | $cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1; |
| 3386 | 3573 | $cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get'); |
| 3387 | 3574 | } |
| 3388 | 3575 | } |
| 3389 | 3576 | |
| 3390 | - if (function_exists('call_integration_hook') && isset($value)) |
|
| 3391 | - call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value)); |
|
| 3577 | + if (function_exists('call_integration_hook') && isset($value)) { |
|
| 3578 | + call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value)); |
|
| 3579 | + } |
|
| 3392 | 3580 | |
| 3393 | 3581 | return empty($value) ? null : smf_json_decode($value, true); |
| 3394 | 3582 | } |
@@ -3410,8 +3598,9 @@ discard block |
||
| 3410 | 3598 | global $cacheAPI; |
| 3411 | 3599 | |
| 3412 | 3600 | // If we can't get to the API, can't do this. |
| 3413 | - if (empty($cacheAPI)) |
|
| 3414 | - return; |
|
| 3601 | + if (empty($cacheAPI)) { |
|
| 3602 | + return; |
|
| 3603 | + } |
|
| 3415 | 3604 | |
| 3416 | 3605 | // Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure. |
| 3417 | 3606 | $cacheAPI->cleanCache($type); |
@@ -3436,8 +3625,9 @@ discard block |
||
| 3436 | 3625 | global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $image_proxy_secret; |
| 3437 | 3626 | |
| 3438 | 3627 | // Come on! |
| 3439 | - if (empty($data)) |
|
| 3440 | - return array(); |
|
| 3628 | + if (empty($data)) { |
|
| 3629 | + return array(); |
|
| 3630 | + } |
|
| 3441 | 3631 | |
| 3442 | 3632 | // Set a nice default var. |
| 3443 | 3633 | $image = ''; |
@@ -3445,11 +3635,11 @@ discard block |
||
| 3445 | 3635 | // Gravatar has been set as mandatory! |
| 3446 | 3636 | if (!empty($modSettings['gravatarOverride'])) |
| 3447 | 3637 | { |
| 3448 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) |
|
| 3449 | - $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
| 3450 | - |
|
| 3451 | - else if (!empty($data['email'])) |
|
| 3452 | - $image = get_gravatar_url($data['email']); |
|
| 3638 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) { |
|
| 3639 | + $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
| 3640 | + } else if (!empty($data['email'])) { |
|
| 3641 | + $image = get_gravatar_url($data['email']); |
|
| 3642 | + } |
|
| 3453 | 3643 | } |
| 3454 | 3644 | |
| 3455 | 3645 | // Look if the user has a gravatar field or has set an external url as avatar. |
@@ -3461,54 +3651,60 @@ discard block |
||
| 3461 | 3651 | // Gravatar. |
| 3462 | 3652 | if (stristr($data['avatar'], 'gravatar://')) |
| 3463 | 3653 | { |
| 3464 | - if ($data['avatar'] == 'gravatar://') |
|
| 3465 | - $image = get_gravatar_url($data['email']); |
|
| 3466 | - |
|
| 3467 | - elseif (!empty($modSettings['gravatarAllowExtraEmail'])) |
|
| 3468 | - $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
| 3654 | + if ($data['avatar'] == 'gravatar://') { |
|
| 3655 | + $image = get_gravatar_url($data['email']); |
|
| 3656 | + } elseif (!empty($modSettings['gravatarAllowExtraEmail'])) { |
|
| 3657 | + $image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11)); |
|
| 3658 | + } |
|
| 3469 | 3659 | } |
| 3470 | 3660 | |
| 3471 | 3661 | // External url. |
| 3472 | 3662 | else |
| 3473 | 3663 | { |
| 3474 | 3664 | // Using ssl? |
| 3475 | - if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) |
|
| 3476 | - $image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret); |
|
| 3665 | + if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) { |
|
| 3666 | + $image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret); |
|
| 3667 | + } |
|
| 3477 | 3668 | |
| 3478 | 3669 | // Just a plain external url. |
| 3479 | - else |
|
| 3480 | - $image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar']; |
|
| 3670 | + else { |
|
| 3671 | + $image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar']; |
|
| 3672 | + } |
|
| 3481 | 3673 | } |
| 3482 | 3674 | } |
| 3483 | 3675 | |
| 3484 | 3676 | // Perhaps this user has an attachment as avatar... |
| 3485 | - else if (!empty($data['filename'])) |
|
| 3486 | - $image = $modSettings['custom_avatar_url'] . '/' . $data['filename']; |
|
| 3677 | + else if (!empty($data['filename'])) { |
|
| 3678 | + $image = $modSettings['custom_avatar_url'] . '/' . $data['filename']; |
|
| 3679 | + } |
|
| 3487 | 3680 | |
| 3488 | 3681 | // Right... no avatar... use our default image. |
| 3489 | - else |
|
| 3490 | - $image = $modSettings['avatar_url'] . '/default.png'; |
|
| 3682 | + else { |
|
| 3683 | + $image = $modSettings['avatar_url'] . '/default.png'; |
|
| 3684 | + } |
|
| 3491 | 3685 | } |
| 3492 | 3686 | |
| 3493 | 3687 | call_integration_hook('integrate_set_avatar_data', array(&$image, &$data)); |
| 3494 | 3688 | |
| 3495 | 3689 | // At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed. |
| 3496 | - if (!empty($image)) |
|
| 3497 | - return array( |
|
| 3690 | + if (!empty($image)) { |
|
| 3691 | + return array( |
|
| 3498 | 3692 | 'name' => !empty($data['avatar']) ? $data['avatar'] : '', |
| 3499 | 3693 | 'image' => '<img class="avatar" src="' . $image . '" />', |
| 3500 | 3694 | 'href' => $image, |
| 3501 | 3695 | 'url' => $image, |
| 3502 | 3696 | ); |
| 3697 | + } |
|
| 3503 | 3698 | |
| 3504 | 3699 | // Fallback to make life easier for everyone... |
| 3505 | - else |
|
| 3506 | - return array( |
|
| 3700 | + else { |
|
| 3701 | + return array( |
|
| 3507 | 3702 | 'name' => '', |
| 3508 | 3703 | 'image' => '', |
| 3509 | 3704 | 'href' => '', |
| 3510 | 3705 | 'url' => '', |
| 3511 | 3706 | ); |
| 3512 | -} |
|
| 3707 | + } |
|
| 3708 | + } |
|
| 3513 | 3709 | |
| 3514 | 3710 | ?> |
| 3515 | 3711 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
| 12 | 12 | header('Location: ' . $boardurl); |
| 13 | 13 | } |
| 14 | 14 | // Can't find it... just forget it. |
| 15 | -else |
|
| 15 | +else { |
|
| 16 | 16 | exit; |
| 17 | +} |
|
| 17 | 18 | |
| 18 | 19 | ?> |
| 19 | 20 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
| 12 | 12 | header('Location: ' . $boardurl); |
| 13 | 13 | } |
| 14 | 14 | // Can't find it... just forget it. |
| 15 | -else |
|
| 15 | +else { |
|
| 16 | 16 | exit; |
| 17 | +} |
|
| 17 | 18 | |
| 18 | 19 | ?> |
| 19 | 20 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |