SimonBlanke /
Hyperactive
| Conditions | 3 |
| Total Lines | 66 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | """Base class for optimizer.""" |
||
| 52 | def add_search( |
||
| 53 | self, |
||
| 54 | experiment: callable, |
||
| 55 | search_space: Dict[str, list], |
||
| 56 | n_iter: int, |
||
| 57 | search_id=None, |
||
| 58 | n_jobs: int = 1, |
||
| 59 | initialize: Dict[str, int] = {"grid": 4, "random": 2, "vertices": 4}, |
||
| 60 | constraints: List[callable] = None, |
||
| 61 | pass_through: Dict = None, |
||
| 62 | max_score: float = None, |
||
| 63 | early_stopping: Dict = None, |
||
| 64 | random_state: int = None, |
||
| 65 | memory: Union[str, bool] = "share", |
||
| 66 | memory_warm_start: pd.DataFrame = None, |
||
| 67 | ): |
||
| 68 | """ |
||
| 69 | Add a new optimization search process with specified parameters. |
||
| 70 | |||
| 71 | Parameters: |
||
| 72 | - experiment: Experiment class containing the objective-function to optimize. |
||
| 73 | - search_space: Dictionary defining the search space for optimization. |
||
| 74 | - n_iter: Number of iterations for the optimization process. |
||
| 75 | - search_id: Identifier for the search process (default: None). |
||
| 76 | - n_jobs: Number of parallel jobs to run (default: 1). |
||
| 77 | - initialize: Dictionary specifying initialization parameters (default: {"grid": 4, "random": 2, "vertices": 4}). |
||
| 78 | - constraints: List of constraint functions (default: None). |
||
| 79 | - pass_through: Dictionary of additional parameters to pass through (default: None). |
||
| 80 | - callbacks: Dictionary of callback functions (default: None). |
||
| 81 | - catch: Dictionary of exceptions to catch during optimization (default: None). |
||
| 82 | - max_score: Maximum score to achieve (default: None). |
||
| 83 | - early_stopping: Dictionary specifying early stopping criteria (default: None). |
||
| 84 | - random_state: Seed for random number generation (default: None). |
||
| 85 | - memory: Option to share memory between processes (default: "share"). |
||
| 86 | - memory_warm_start: DataFrame containing warm start memory (default: None). |
||
| 87 | """ |
||
| 88 | |||
| 89 | self.n_search += 1 |
||
| 90 | |||
| 91 | self.check_list(search_space) |
||
| 92 | |||
| 93 | constraints = constraints or [] |
||
| 94 | pass_through = pass_through or {} |
||
| 95 | early_stopping = early_stopping or {} |
||
| 96 | |||
| 97 | search_id = self._default_search_id(search_id, experiment.objective_function) |
||
| 98 | s_space = SearchSpace(search_space) |
||
| 99 | |||
| 100 | n_jobs = mp.cpu_count() if n_jobs == -1 else n_jobs |
||
| 101 | |||
| 102 | for _ in range(n_jobs): |
||
| 103 | search = Search(self.optimizer_class, self.opt_params) |
||
| 104 | search.setup( |
||
| 105 | experiment=experiment, |
||
| 106 | s_space=s_space, |
||
| 107 | n_iter=n_iter, |
||
| 108 | initialize=initialize, |
||
| 109 | constraints=constraints, |
||
| 110 | pass_through=pass_through, |
||
| 111 | max_score=max_score, |
||
| 112 | early_stopping=early_stopping, |
||
| 113 | random_state=random_state, |
||
| 114 | memory=memory, |
||
| 115 | memory_warm_start=memory_warm_start, |
||
| 116 | ) |
||
| 117 | self.searches.append(search) |
||
| 118 | |||
| 184 |
Loading history...