Sil\RouteSecurityBundle\Listener\AccessControlListener::onKernelRequest()

Complexity

Conditions	7
Paths	6

Size

Total Lines	29
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	7

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function onKernelRequest(RequestEvent $event)
    {
        $route = $event->getRequest()->attributes->get('_route');

        if (false === $this->accessControl->isEnable() || false === $this->accessControl->isRouteSecure($route)) {
            return;
        }

        if (null === $this->tokenStorage->getToken()) {
            throw new LogicException('Unable to retrive the current user. The token storage does not contain security token.');
        }

        if (false === $this->tokenStorage->getToken()->getUser() instanceof UserInterface) {
            throw new LogicException(sprintf('The security token must containt an User object that implements %s', UserInterface::class));
        }

        $user = $this->tokenStorage->getToken()->getUser();

        if (false === $this->accessControl->hasUserAccessToRoute($user, $route)) {
            $access_denied_event = new AccessDeniedToRouteEvent($user, $event->getRequest());
            $this->eventDispatcher->dispatch($access_denied_event, AccessDeniedToRouteEvent::ON_ACCESS_DENIED_TO_ROUTE);

            if (true === $access_denied_event->hasResponse()) {
                $event->setResponse($access_denied_event->getResponse());

It seems like $access_denied_event->getResponse() can also be of type null; however, parameter $response of Symfony\Component\HttpKernel\Event\RequestEvent::setResponse() does only seem to accept Symfony\Component\HttpFoundation\Response, maybe add an additional type check?

                return $event;
            }

            throw new AccessDeniedException();
        }