Issues in single-comic.php (master) - Issues in master - SilentComics/Strip - Measure and Improve Code Quality continuously with Scrutinizer

Issues (631)

single-comic.php (2 issues)

Labels

Bug 2

Severity

<?php
/**
 *  The Template for displaying all single comics
 *
 * @package WordPress
 * @subpackage Strip
 */

if ( post_type_exists( 'comic' ) ) {
	get_header( 'lite' );
} else {
	get_header();
}
?>

	<section id="primary">
		<main id="content" role="main">

	<?php
	// Start the loop.
	while ( have_posts() ) : the_post(); ?>

			<div class="entry-comic">

				<?php get_template_part( 'content-comic' ); ?>

					<div class="wrap clear">

						<h1 class="screen-reader-text"><?php esc_html_e( 'Post navigation', 'strip' ); ?></h1>

								<div class="navigation-comic">
								<nav class="nav-first"><a href="<?php echo esc_url( first_comic_link() ); ?>"><?php esc_html_e( 'Start', 'strip' ); ?></a></nav>
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
								<nav class="nav-previous"><?php previous_post_link( '%link', __( 'Previous', 'strip' ), true, '', 'story' ); ?></nav>
								<nav class="nav-title"><?php the_title( '<h4 class="series-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h4>' ); ?></nav>
								<nav class="nav-next"><?php next_post_link( '%link', __( 'Next', 'strip' ), true, '', 'story' ); ?></nav>
								<nav class="nav-last"><a href="<?php echo esc_url( last_comic_link() ); ?>"><?php esc_html_e( 'Last', 'strip' ); ?></a></nav>
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
							</div><!-- .wrap -->

						<?php set_transient( 'story', $comic );?>

			</div><!-- #entry-comic -->

			<?php wp_reset_postdata(); ?>

		<?php
			// If comments are open or we have at least one comment, load up the comment template.
		if ( comments_open() || '0' !== get_comments_number() ) :
			comments_template();
		endif;

	  endwhile; // end of the loop. ?>

		</main><!-- #content -->
	</section><!-- #primary -->
<?php get_footer( 'lite' ); ?>


1			<?php
2			/**
3			* The Template for displaying all single comics
4			*
5			* @package WordPress
6			* @subpackage Strip
7			*/
8
9			if ( post_type_exists( 'comic' ) ) {
10			get_header( 'lite' );
11			} else {
12			get_header();
13			}
14			?>
15
16			<section id="primary">
17			<main id="content" role="main">
18
19			<?php
20			// Start the loop.
21			while ( have_posts() ) : the_post(); ?>
22
23			<div class="entry-comic">
24
25			<?php get_template_part( 'content-comic' ); ?>
26
27			<div class="wrap clear">
28
29			<h1 class="screen-reader-text"><?php esc_html_e( 'Post navigation', 'strip' ); ?></h1>
30
31			<div class="navigation-comic">
32			<nav class="nav-first"><a href="<?php echo esc_url( first_comic_link() ); ?>"><?php esc_html_e( 'Start', 'strip' ); ?></a></nav>
			0 ignored issues – show Bug introduced 2018-03-12 10:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `first_comic_link()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
33			<nav class="nav-previous"><?php previous_post_link( '%link', __( 'Previous', 'strip' ), true, '', 'story' ); ?></nav>
34			<nav class="nav-title"><?php the_title( '<h4 class="series-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h4>' ); ?></nav>
35			<nav class="nav-next"><?php next_post_link( '%link', __( 'Next', 'strip' ), true, '', 'story' ); ?></nav>
36			<nav class="nav-last"><a href="<?php echo esc_url( last_comic_link() ); ?>"><?php esc_html_e( 'Last', 'strip' ); ?></a></nav>
			0 ignored issues – show Bug introduced 2018-03-12 10:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `last_comic_link()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
37			</div><!-- .wrap -->
38
39			<?php set_transient( 'story', $comic );?>
40
41			</div><!-- #entry-comic -->
42
43			<?php wp_reset_postdata(); ?>
44
45			<?php
46			// If comments are open or we have at least one comment, load up the comment template.
47			if ( comments_open() \|\| '0' !== get_comments_number() ) :
48			comments_template();
49			endif;
50
51			endwhile; // end of the loop. ?>
52
53			</main><!-- #content -->
54			</section><!-- #primary -->
55			<?php get_footer( 'lite' ); ?>
56

SilentComics / Strip

Issues (631)

single-comic.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like