Issues in single-comic.php - Fixed Issues - Inspection of "rewind" - SilentComics/Strip - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d9c94...5b5429 )

by SILENT

created 2017-04-03 20:20 UTC

single-comic.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *  The Template for displaying all single comics
 *
 * @package WordPress
 * @subpackage Strip
 */

if ( post_type_exists( $post_type )  && is_single() ) {
	get_header( 'lite' );
} else {
	get_header();
}
	?>

	<section id="primary">
		<main id="content" role="main">

	<?php
	// Start the loop.
	while ( have_posts() ) :
		the_post();
		if ( 'comic' === get_post_type() ) : ?>

			<div class="entry-comic">

				<?php get_template_part( 'content-comic' ); ?>

				<?php strip_content_nav( 'nav-below' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				set_transient( 'story', $post_type );?>

			</div><!-- #entry-comic -->

			<?php                                                                                                                                                                                                                      endif;
		wp_reset_postdata(); ?>

				<?php
					// If comments are open or we have at least one comment, load up the comment template.
				if ( comments_open() || '0' !== get_comments_number() ) {
					comments_template();
				}
				?>

		<?php  endwhile; // end of the loop. ?>

		</main><!-- #content -->
	</section><!-- #primary -->

<?php get_footer( 'lite' ); ?>


1			<?php
2			/**
3			* The Template for displaying all single comics
4			*
5			* @package WordPress
6			* @subpackage Strip
7			*/
8
9			if ( post_type_exists( $post_type ) && is_single() ) {
10			get_header( 'lite' );
11			} else {
12			get_header();
13			}
14			?>
15
16			<section id="primary">
17			<main id="content" role="main">
18
19			<?php
20			// Start the loop.
21			while ( have_posts() ) :
22			the_post();
23			if ( 'comic' === get_post_type() ) : ?>
24
25			<div class="entry-comic">
26
27			<?php get_template_part( 'content-comic' ); ?>
28
29			<?php strip_content_nav( 'nav-below' );
			0 ignored issues – show Documentation introduced 2017-04-03 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'nav-below'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			set_transient( 'story', $post_type );?>
31
32			</div><!-- #entry-comic -->
33
34			<?php endif;
35			wp_reset_postdata(); ?>
36
37			<?php
38			// If comments are open or we have at least one comment, load up the comment template.
39			if ( comments_open() \|\| '0' !== get_comments_number() ) {
40			comments_template();
41			}
42			?>
43
44			<?php endwhile; // end of the loop. ?>
45
46			</main><!-- #content -->
47			</section><!-- #primary -->
48
49			<?php get_footer( 'lite' ); ?>
50

SilentComics / Strip

Push — master ( 1d9c94...5b5429 )

single-comic.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like