DaftJsonExceptionTest::dataProviderPropertyNotThingableException() - Code Metrics - Inspection of "updating testing" - SignpostMarv/daft-object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53bcfa...6873de )

by SignpostMarv

created 2018-05-17 21:58 UTC

dataProviderPropertyNotThingableException() A

↳ Parent: DaftJsonExceptionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	60
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	37
nc	1
nop	0
dl	0
loc	60
rs	9.5555
c	0
b	0
f	0

How to fix Long Method

<?php
/**
* @author SignpostMarv
*/
declare(strict_types=1);

namespace SignpostMarv\DaftObject\Tests;

use SignpostMarv\DaftObject\ClassDoesNotImplementClassException;
use SignpostMarv\DaftObject\DaftJson;
use SignpostMarv\DaftObject\PropertyNotJsonDecodableException;
use SignpostMarv\DaftObject\PropertyNotJsonDecodableShouldBeArrayException;
use SignpostMarv\DaftObject\PropertyNotNullableException;
use SignpostMarv\DaftObject\ReadWriteJson;
use SignpostMarv\DaftObject\ReadWriteJsonJson;
use SignpostMarv\DaftObject\ReadWriteJsonJsonArray;
use SignpostMarv\DaftObject\ReadWriteJsonJsonArrayBad;

class DaftJsonExceptionTest extends TestCase
{
    public function dataProviderClassDoesNotImplementClassException() : array
    {
        return [
            [
                ReadWriteJsonJsonArrayBad::class,
                'stdClass',
                [
                    'json' => [
                        [
                            'Foo' => 'Foo',
                            'Bar' => 1.0,
                            'Baz' => 2,
                            'Bat' => true,
                        ],
                    ],
                ],
                true,
            ],
        ];
    }

    public function dataProviderPropertyNotThingableException() : array
    {
        return [
            [
                ReadWriteJsonJsonArrayBad::class,
                ReadWriteJsonJsonArrayBad::class,
                'json',
                PropertyNotNullableException::class,
                'nullable',
                [
                    'json' => null,
                ],
                true,
            ],
            [
                ReadWriteJsonJsonArray::class,
                ReadWriteJsonJsonArray::class,
                'notthere',
                PropertyNotJsonDecodableException::class,
                'json-decodable',
                [
                    'json' => [],
                    'notthere' => 1,
                ],
                true,
            ],
            [
                ReadWriteJsonJsonArray::class,
                ReadWriteJsonJsonArray::class,
                'json',
                PropertyNotJsonDecodableShouldBeArrayException::class,
                'json-decodable (should be an array)',
                [
                    'json' => 1,
                ],
                true,
            ],
            [
                ReadWriteJsonJson::class,
                ReadWriteJson::class,
                'json',
                PropertyNotJsonDecodableShouldBeArrayException::class,
                'json-decodable (should be an array)',
                [
                    'json' => 1,
                ],
                true,
            ],
            [
                ReadWriteJsonJsonArray::class,
                ReadWriteJson::class,
                'json',
                PropertyNotJsonDecodableShouldBeArrayException::class,
                'json-decodable (should be an array)',
                [
                    'json' => [
                        1,
                    ],
                ],
                true,
            ],
        ];
    }

    /**
    * @dataProvider dataProviderClassDoesNotImplementClassException
    */
    public function testClassDoesNotImplementClassException(
        string $implementation,
        string $expectingFailureWith,
        array $args,
        bool $writeAll
    ) : void {
        $this->expectException(ClassDoesNotImplementClassException::class);
        $this->expectExceptionMessage(
            sprintf(
                '%s does not implement %s',
                $expectingFailureWith,
                DaftJson::class
            )
        );

        $implementation::DaftObjectFromJsonArray($args, $writeAll);
    }

    /**
    * @dataProvider dataProviderPropertyNotThingableException
    */
    public function testPropertyNotThingableException(
        string $implementation,
        string $expectingFailureWithClass,
        string $expectingFailureWithProperty,
        string $expectingException,
        string $expectingThing,
        array $args,
        bool $writeAll
    ) : void {
        $this->expectException($expectingException);
        $this->expectExceptionMessage(
            sprintf(
                'Property not %s: %s::$%s',
                $expectingThing,
                $expectingFailureWithClass,
                $expectingFailureWithProperty
            )
        );

        $obj = $implementation::DaftObjectFromJsonArray($args, $writeAll);

        foreach ($implementation::DaftObjectPublicGetters() as $arg) {
            $obj->$arg;
        }
    }
}


1			<?php
2			/**
3			* @author SignpostMarv
4			*/
5			declare(strict_types=1);
6
7			namespace SignpostMarv\DaftObject\Tests;
8
9			use SignpostMarv\DaftObject\ClassDoesNotImplementClassException;
10			use SignpostMarv\DaftObject\DaftJson;
11			use SignpostMarv\DaftObject\PropertyNotJsonDecodableException;
12			use SignpostMarv\DaftObject\PropertyNotJsonDecodableShouldBeArrayException;
13			use SignpostMarv\DaftObject\PropertyNotNullableException;
14			use SignpostMarv\DaftObject\ReadWriteJson;
15			use SignpostMarv\DaftObject\ReadWriteJsonJson;
16			use SignpostMarv\DaftObject\ReadWriteJsonJsonArray;
17			use SignpostMarv\DaftObject\ReadWriteJsonJsonArrayBad;
18
19			class DaftJsonExceptionTest extends TestCase
20			{
21			public function dataProviderClassDoesNotImplementClassException() : array
22			{
23			return [
24			[
25			ReadWriteJsonJsonArrayBad::class,
26			'stdClass',
27			[
28			'json' => [
29			[
30			'Foo' => 'Foo',
31			'Bar' => 1.0,
32			'Baz' => 2,
33			'Bat' => true,
34			],
35			],
36			],
37			true,
38			],
39			];
40			}
41
42			public function dataProviderPropertyNotThingableException() : array
43			{
44			return [
45			[
46			ReadWriteJsonJsonArrayBad::class,
47			ReadWriteJsonJsonArrayBad::class,
48			'json',
49			PropertyNotNullableException::class,
50			'nullable',
51			[
52			'json' => null,
53			],
54			true,
55			],
56			[
57			ReadWriteJsonJsonArray::class,
58			ReadWriteJsonJsonArray::class,
59			'notthere',
60			PropertyNotJsonDecodableException::class,
61			'json-decodable',
62			[
63			'json' => [],
64			'notthere' => 1,
65			],
66			true,
67			],
68			[
69			ReadWriteJsonJsonArray::class,
70			ReadWriteJsonJsonArray::class,
71			'json',
72			PropertyNotJsonDecodableShouldBeArrayException::class,
73			'json-decodable (should be an array)',
74			[
75			'json' => 1,
76			],
77			true,
78			],
79			[
80			ReadWriteJsonJson::class,
81			ReadWriteJson::class,
82			'json',
83			PropertyNotJsonDecodableShouldBeArrayException::class,
84			'json-decodable (should be an array)',
85			[
86			'json' => 1,
87			],
88			true,
89			],
90			[
91			ReadWriteJsonJsonArray::class,
92			ReadWriteJson::class,
93			'json',
94			PropertyNotJsonDecodableShouldBeArrayException::class,
95			'json-decodable (should be an array)',
96			[
97			'json' => [
98			1,
99			],
100			],
101			true,
102			],
103			];
104			}
105
106			/**
107			* @dataProvider dataProviderClassDoesNotImplementClassException
108			*/
109			public function testClassDoesNotImplementClassException(
110			string $implementation,
111			string $expectingFailureWith,
112			array $args,
113			bool $writeAll
114			) : void {
115			$this->expectException(ClassDoesNotImplementClassException::class);
116			$this->expectExceptionMessage(
117			sprintf(
118			'%s does not implement %s',
119			$expectingFailureWith,
120			DaftJson::class
121			)
122			);
123
124			$implementation::DaftObjectFromJsonArray($args, $writeAll);
125			}
126
127			/**
128			* @dataProvider dataProviderPropertyNotThingableException
129			*/
130			public function testPropertyNotThingableException(
131			string $implementation,
132			string $expectingFailureWithClass,
133			string $expectingFailureWithProperty,
134			string $expectingException,
135			string $expectingThing,
136			array $args,
137			bool $writeAll
138			) : void {
139			$this->expectException($expectingException);
140			$this->expectExceptionMessage(
141			sprintf(
142			'Property not %s: %s::$%s',
143			$expectingThing,
144			$expectingFailureWithClass,
145			$expectingFailureWithProperty
146			)
147			);
148
149			$obj = $implementation::DaftObjectFromJsonArray($args, $writeAll);
150
151			foreach ($implementation::DaftObjectPublicGetters() as $arg) {
152			$obj->$arg;
153			}
154			}
155			}
156

SignpostMarv / daft-object

GitHub Access Token became invalid

Push — master ( 53bcfa...6873de )

dataProviderPropertyNotThingableException() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like