SignpostMarv\DaftObject\TraitSortableDaftObject

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	CompareToDaftSortableObject()	0	18	4
A	DaftSortableObjectProperties()	0	15	2

<?php
/**
* Exceptions.
*
* @author SignpostMarv
*/
declare(strict_types=1);

namespace SignpostMarv\DaftObject;

/**
* @template T as DaftSortableObject
*/
trait TraitSortableDaftObject
{
    /**
    * @psalm-param T as $otherObject
    */
    public function CompareToDaftSortableObject(DaftSortableObject $otherObject) : int
    {
        if ( ! is_a(static::class, DaftSortableObject::class, true)) {
            throw new ClassDoesNotImplementClassException(
                static::class,
                DaftSortableObject::class
            );
        }

        foreach (static::DaftSortableObjectProperties() as $property) {
            $sort = $this->__get($property) <=> $otherObject->__get($property);

It seems like __get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if (0 !== $sort) {
                return $sort;
            }
        }

        return 0;
    }

    /**
    * @return array<int, string>
    */
    public static function DaftSortableObjectProperties() : array
    {
        if ( ! is_a(static::class, DaftSortableObject::class, true)) {
            throw new ClassDoesNotImplementClassException(
                static::class,
                DaftSortableObject::class
            );
        }

        /**
        * @var array<int, string>
        */
        $out = static::SORTABLE_PROPERTIES;

The constant SignpostMarv\DaftObject\TraitSortableDaftObject::SORTABLE_PROPERTIES was not found. Maybe you did not declare it correctly or list all dependencies?

        return $out;
    }
}