SignpostMarv\DaftObject\EasyDB\WriteableTreeTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	RecallDaftObjectOrThrow()	0	4	1
A	ObtainLastLeafInTree()	0	34	3

<?php
/**
* Base daft objects.
*
* @author SignpostMarv
*/
declare(strict_types=1);

namespace SignpostMarv\DaftObject\EasyDB;

use PDO;
use SignpostMarv\DaftObject\DaftNestedWriteableObject;
use SignpostMarv\DaftObject\DefinesOwnArrayIdInterface;
use SignpostMarv\DaftObject\SuitableForRepositoryType;

/**
* @template T as DaftNestedWriteableObject
*/
trait WriteableTreeTrait
{
    abstract protected function DaftObjectDatabaseTable() : string;

    /**
    * @param scalar|(scalar|array|object|null)[] $id
    *
    * @psalm-param class-string<T> $type
    *
    * @psalm-return T
    */
    public function RecallDaftObjectOrThrow(
        $id,

The parameter $id is not used and could be removed.

        string $type = SuitableForRepositoryType::class

The parameter $type is not used and could be removed.

    ) : SuitableForRepositoryType;

In this branch, the function will implicitly return null which is incompatible with the type-hinted return SignpostMarv\DaftObject\SuitableForRepositoryType. Consider adding a return statement or allowing null as return value.

    protected function ObtainLastLeafInTree() : DaftNestedWriteableObject
    {
        /**
        * @var \ParagonIE\EasyDB\EasyDB
        */
        $db = $this->db;

        /**
        * @psalm-var class-string<T>
        */
        $type = $this->type;

        $sth = $db->prepare(
            'SELECT ' .
            implode(',', array_map(
                [$db, 'escapeIdentifier'],
                $type::DaftObjectIdProperties()
            )) .
            ' FROM ' .
            $this->DaftObjectDatabaseTable() .
            ' ORDER BY ' .
            $db->escapeIdentifier('intNestedLeft') .
            ' DESC LIMIT 1'
        );

        $sth->execute();

        $res = $sth->fetch(PDO::FETCH_ASSOC);

        if (1 === count($res) && ! is_a($type, DefinesOwnArrayIdInterface::class, true)) {
            $res = current($res);
        }

        return $this->RecallDaftObjectOrThrow($res);

The expression return $this->RecallDaftObjectOrThrow($res) returns the type SignpostMarv\DaftObject\SuitableForRepositoryType which includes types incompatible with the type-hinted return SignpostMarv\DaftObject\DaftNestedWriteableObject.

    }
}