CookieMiddlewareTest::DataProvderCookeMiddlewareTest() - Code Metrics - Inspection of "dropping scrutinizer in favour of travis + coveral..." - SignpostMarv/daft-framework - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed
Push — master ( 31710d...a28762 )

by SignpostMarv
created 2019-07-13 14:45 UTC
DataProvderCookeMiddlewareTest() B

↳ Parent: CookieMiddlewareTest
Complexity

Conditions	6
Paths	6
Size

Total Lines	63
Code Lines	44
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	6
eloc	44
nc	6
nop	0
dl	0
loc	63
rs	8.5937
c	1
b	0
f	0
How to fix Long Method

<?php
/**
* @author SignpostMarv
*/
declare(strict_types=1);

namespace SignpostMarv\DaftFramework\Tests;

use Generator;
use PHPUnit\Framework\TestCase as Base;
use SignpostMarv\DaftFramework\Http\CookieMiddleware;
use SignpostMarv\DaftFramework\HttpHandler;
use SignpostMarv\DaftRouter\DaftSource;
use Symfony\Component\HttpFoundation\Cookie;
use Symfony\Component\HttpFoundation\Request;

class CookieMiddlewareTest extends Base
{
	/**
	* @dataProvider DataProvderCookeMiddlewareTest
	*/
	public function testCookieMiddleware(
		string $implementation,
		string $baseUrl,
		string $basePath,
		array $config,
		string $cookieName,
		string $cookieValue,
		? string $secure,
		? string $http,
		? string $sameSite
	) : void {
		$url = sprintf(
			'cookie-test/%s/%s/%s/%s/%s',
			rawurlencode($cookieName),
			rawurlencode($cookieValue),
			rawurlencode($secure ?? '1'),
			rawurlencode($http ?? '1'),
			rawurlencode($sameSite ?? 'lax')
		);

		/**
		* @var array<string, bool|string>
		*/
		$cookieConfig = [];

		if (is_string($secure) && is_string($http) && is_string($sameSite)) {
			$cookieConfig = [
				'secure' => '1' !== $secure,
				'httpOnly' => '1' !== $http,
				'sameSite' => (('lax' === $sameSite) ? 'strict' : 'lax'),
			];
		}

		$config[CookieMiddleware::class] = $cookieConfig;

		/**
		* @var array<string, string|array<int, string>>
		*/
		$sourceConfig = (array) $config[DaftSource::class];

		$sourceConfig['sources'] = [
			fixtures\Routes\CookieTest::class,
		];
		$sourceConfig['cacheFile'] = (
			__DIR__ .
			'/fixtures/cookie-test.fast-route.cache'
		);

		$config[DaftSource::class] = $sourceConfig;

		$instance = Utilities::ObtainHttpHandlerInstanceMixedArgs(
			$this,
			$implementation,
			$baseUrl,
			$basePath,
			$config
		);

		$request = Request::create($baseUrl . $url);

		$response = $instance->handle($request);

		$cookie = current(array_filter(
			$response->headers->getCookies(),
			function (Cookie $cookie) use ($cookieName) : bool {
				return $cookieName === $cookie->getName();
			}
		));

		static::assertInstanceOf(Cookie::class, $cookie);

		if (is_string($secure) && is_string($http) && is_string($sameSite)) {
			static::assertSame(
           assertSame(
				'1' === $secure,
				/** @scrutinizer ignore-type */ '1' === $secure,
				$cookie->isSecure(),
				'Secure must match without middleware'
			);
			static::assertSame(
				'1' === $http,
				$cookie->isHttpOnly(),
				'HttpOnly must match without middleware'
			);
			static::assertSame(
				$sameSite,
				/** @scrutinizer ignore-type */ $sameSite,
				$cookie->getSameSite(),
				'SameSite must match without middleware'
			);
		}

		/**
		* @var array<string, string|array<int, string>>
		*/
		$sourceConfig = (array) $config[DaftSource::class];

		$sourceConfig['sources'] = [fixtures\Routes\CookieTest::class, CookieMiddleware::class];
		$sourceConfig['cacheFile'] = (__DIR__ . '/fixtures/cookie-middleware.fast-route.cache');

		$config[DaftSource::class] = $sourceConfig;

		$instance = Utilities::ObtainHttpHandlerInstanceMixedArgs(
			$this,
			$implementation,
			$baseUrl,
			$basePath,
			$config
		);

		$request = Request::create($baseUrl . $url);

		$response = $instance->handle($request);

		$cookie = current(array_filter(
			$response->headers->getCookies(),
			function (Cookie $cookie) use ($cookieName) : bool {
				return $cookieName === $cookie->getName();
			}
		));

		static::assertInstanceOf(Cookie::class, $cookie);

		if (is_string($secure) && is_string($http) && is_string($sameSite)) {
			/**
			* @var array<string, string|bool>
			*/
			$cookieConfig = $config[CookieMiddleware::class];

			static::assertSame(
				$cookieConfig['secure'],
				$cookie->isSecure(),
				sprintf(
					'Secure must match flipped value with middleware %s vs %s',
					var_export($cookieConfig['secure'], true),
					var_export($cookie->isSecure(), true)
				)
			);
			static::assertSame(
				$cookieConfig['httpOnly'],
				$cookie->isHttpOnly(),
				sprintf(
					'HttpOnly must match flipped value with middleware %s vs %s',
					var_export($cookieConfig['httpOnly'], true),
					var_export($cookie->isHttpOnly(), true)
				)
			);
			static::assertSame(
				$cookieConfig['sameSite'],
				$cookie->getSameSite(),
				sprintf(
					'SameSite must match flipped value with middleware %s vs %s',
					var_export($cookieConfig['sameSite'], true),
					var_export($cookie->getSameSite(), true)
				)
			);
		}
	}

	/**
	* @return Generator<int, array{0:class-string<HttpHandler>, 1:string, 2:string, 3:array, 4:string, 5:string, 6:string|null, 7:string|null, 8:string|null}, mixed, void>
	*/
	public function DataProvderCookeMiddlewareTest() : Generator
	{
		foreach ($this->DataProviderCookieNameValue() as $cookie) {
			foreach ($this->DataProviderHttpHandlerInstances() as $handlerArgs) {
				[
					$implementation,
					,
					$baseUrl,
					$basePath,
					$config,
					$cookieName,
					$cookieValue,
					$secure,
					$http,
					$sameSite,
				] = array_merge($handlerArgs, $cookie, [null, null, null]);

				/**
				* @var array{0:class-string<HttpHandler>, 1:string, 2:string, 3:array, 4:string, 5:string, 6:string|null, 7:string|null, 8:string|null}
				*/
				$yielding = [
					$implementation,
					$baseUrl,
					$basePath,
					$config,
					$cookieName,
					$cookieValue,
					$secure,
					$http,
					$sameSite,
				];

				yield $yielding;

				foreach ($this->DataProviderCookieSecure() as $secure) {
					foreach ($this->DataProviderCookieHttp() as $http) {
						foreach ($this->DataProviderCookieSameSite() as $sameSite) {
							[
								$implementation,
								,
								$baseUrl,
								$basePath,
								$config,
								$cookieName,
								$cookieValue,
							] = array_merge($handlerArgs, $cookie);

							/**
							* @var array{0:class-string<HttpHandler>, 1:string, 2:string, 3:array, 4:string, 5:string, 6:string|null, 7:string|null, 8:string|null}
							*/
							$yielding = [
								$implementation,
								$baseUrl,
								$basePath,
								$config,
								$cookieName,
								$cookieValue,
								$secure,
								$http,
								$sameSite,
							];

							yield $yielding;
						}
					}
				}
			}
		}
	}

	/**
	* @psalm-return Generator<int, array{0:class-string<HttpHandler>, 1:array, 2:string, 3:string, 4:array}, mixed, void>
	*/
	public function DataProviderHttpHandlerInstances() : Generator
	{
		yield from [
			[
				HttpHandler::class,
				[],
				'https://example.com/',
				realpath(__DIR__ . '/fixtures'),
				[
					DaftSource::class => [],
				],
			],
		];
	}

	/**
	* @psalm-return Generator<int, array{0:string, 1:string}, mixed, void>
	*/
	public function DataProviderCookieNameValue() : Generator
	{
		yield from [
			['a', 'b'],
		];
	}

	/**
	* @psalm-return Generator<int, string, mixed, void>
	*/
	public function DataProviderCookieSecure() : Generator
	{
		yield from ['0', '1'];
	}

	/**
	* @psalm-return Generator<int, string, mixed, void>
	*/
	public function DataProviderCookieHttp() : Generator
	{
		yield from ['0', '1'];
	}

	/**
	* @psalm-return Generator<int, string, mixed, void>
	*/
	public function DataProviderCookieSameSite() : Generator
	{
		yield from ['lax', 'strict'];
	}
}

SignpostMarv / daft-framework

Push — master ( 31710d...a28762 )

DataProvderCookeMiddlewareTest() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
