TestObjectRepository::__construct() - Code Metrics - Inspection of "shifting nullables check back" - SignpostMarv/daft-db-object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 06e1ac...896e66 )

by SignpostMarv

created 2017-10-12 22:39 UTC

TestObjectRepository::__construct() B

↳ Parent: TestObjectRepository

Complexity

Conditions	8
Paths	20

Size

Total Lines	58
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	35
nc	20
nop	2
dl	0
loc	58
rs	7.1977
c	0
b	0
f	0

How to fix Long Method

<?php
/**
* Base daft objects.
*
* @author SignpostMarv
*/
declare(strict_types=1);

namespace SignpostMarv\DaftObject\EasyDB;

use ParagonIE\EasyDB\EasyDB;
use ReflectionClass;
use ReflectionType;
use RuntimeException;
use SignpostMarv\DaftObject\AbstractDaftObjectEasyDBRepository;
use SignpostMarv\DaftObject\DefinesOwnIdPropertiesInterface;

class TestObjectRepository extends AbstractDaftObjectEasyDBRepository
{
    protected function __construct(string $type, EasyDB $db)
    {
        parent::__construct($type, $db);

        /**
        * @var DefinesOwnIdPropertiesInterface $type
        */
        $type = $type;

        $query =
            'CREATE TABLE ' .
            $db->escapeIdentifier($this->DaftObjectDatabaseTable()) .
            ' (';

        $queryParts = [];

        $ref = new ReflectionClass($type);
        $nullables = $type::DaftObjectNullableProperties();

        foreach ($type::DaftObjectProperties() as $i => $prop) {
            $methodName = 'Get' . ucfirst($prop);
            if (true === $ref->hasMethod($methodName)) {
                $refReturn = $ref->getMethod($methodName)->getReturnType();
                if (
                    ($refReturn instanceof ReflectionType) &&
                    true
                ) {
                    $queryPart = static::QueryPartFromRefReturn(
                        $db,
                        $refReturn,
                        $prop
                    );
                    if (false === in_array($prop, $nullables, true)) {
                        $queryPart .= ' NOT NULL';
                    }

                    $queryParts[] = $queryPart;
                }
            }
        }

        $primaryKeyCols = [];
        foreach ($type::DaftObjectIdProperties() as $col) {
            $primaryKeyCols[] = $db->escapeIdentifier($col);
        }

        if (count($primaryKeyCols) > 0) {
            $queryParts[] =
                'PRIMARY KEY (' .
                implode(',', $primaryKeyCols) .
                ')';
        }

        $query .=
            implode(',', $queryParts) .
            ');';

        $db->safeQuery($query);
    }

    protected function DaftObjectDatabaseTable() : string
    {
        return preg_replace('/[^a-z]+/', '_', mb_strtolower($this->type));
    }

    protected static function QueryPartFromRefReturn(
        EasyDB $db,
        ReflectionType $refReturn,
        string $prop
    ) : string {
        if (
            $refReturn->isBuiltin()
        ) {
            $queryPart = $db->escapeIdentifier($prop);
            switch ($refReturn->__toString()) {
                case 'string':
                    $queryPart .= ' VARCHAR(255)';
                break;
                case 'float':
                    $queryPart .= ' REAL';
                break;
                case 'int':
                case 'bool':
                    $queryPart .= ' INTEGER';
                break;
                default:
                    throw new RuntimeException(
                        sprintf(
                            'Unsupported data type! (%s)',
                            $refReturn->__toString()
                        )
                    );
            }

            return $queryPart;
        }

        throw new RuntimeException('Only supports builtins');
    }
}


1			<?php
2			/**
3			* Base daft objects.
4			*
5			* @author SignpostMarv
6			*/
7			declare(strict_types=1);
8
9			namespace SignpostMarv\DaftObject\EasyDB;
10
11			use ParagonIE\EasyDB\EasyDB;
12			use ReflectionClass;
13			use ReflectionType;
14			use RuntimeException;
15			use SignpostMarv\DaftObject\AbstractDaftObjectEasyDBRepository;
16			use SignpostMarv\DaftObject\DefinesOwnIdPropertiesInterface;
17
18			class TestObjectRepository extends AbstractDaftObjectEasyDBRepository
19			{
20			protected function __construct(string $type, EasyDB $db)
21			{
22			parent::__construct($type, $db);
23
24			/**
25			* @var DefinesOwnIdPropertiesInterface $type
26			*/
27			$type = $type;
28
29			$query =
30			'CREATE TABLE ' .
31			$db->escapeIdentifier($this->DaftObjectDatabaseTable()) .
32			' (';
33
34			$queryParts = [];
35
36			$ref = new ReflectionClass($type);
37			$nullables = $type::DaftObjectNullableProperties();
38
39			foreach ($type::DaftObjectProperties() as $i => $prop) {
40			$methodName = 'Get' . ucfirst($prop);
41			if (true === $ref->hasMethod($methodName)) {
42			$refReturn = $ref->getMethod($methodName)->getReturnType();
43			if (
44			($refReturn instanceof ReflectionType) &&
45			true
46			) {
47			$queryPart = static::QueryPartFromRefReturn(
48			$db,
49			$refReturn,
50			$prop
51			);
52			if (false === in_array($prop, $nullables, true)) {
53			$queryPart .= ' NOT NULL';
54			}
55
56			$queryParts[] = $queryPart;
57			}
58			}
59			}
60
61			$primaryKeyCols = [];
62			foreach ($type::DaftObjectIdProperties() as $col) {
63			$primaryKeyCols[] = $db->escapeIdentifier($col);
64			}
65
66			if (count($primaryKeyCols) > 0) {
67			$queryParts[] =
68			'PRIMARY KEY (' .
69			implode(',', $primaryKeyCols) .
70			')';
71			}
72
73			$query .=
74			implode(',', $queryParts) .
75			');';
76
77			$db->safeQuery($query);
78			}
79
80			protected function DaftObjectDatabaseTable() : string
81			{
82			return preg_replace('/[^a-z]+/', '_', mb_strtolower($this->type));
83			}
84
85			protected static function QueryPartFromRefReturn(
86			EasyDB $db,
87			ReflectionType $refReturn,
88			string $prop
89			) : string {
90			if (
91			$refReturn->isBuiltin()
92			) {
93			$queryPart = $db->escapeIdentifier($prop);
94			switch ($refReturn->__toString()) {
95			case 'string':
96			$queryPart .= ' VARCHAR(255)';
97			break;
98			case 'float':
99			$queryPart .= ' REAL';
100			break;
101			case 'int':
102			case 'bool':
103			$queryPart .= ' INTEGER';
104			break;
105			default:
106			throw new RuntimeException(
107			sprintf(
108			'Unsupported data type! (%s)',
109			$refReturn->__toString()
110			)
111			);
112			}
113
114			return $queryPart;
115			}
116
117			throw new RuntimeException('Only supports builtins');
118			}
119			}
120

SignpostMarv / daft-db-object

Push — master ( 06e1ac...896e66 )

TestObjectRepository::__construct() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like