SignpostMarv\DaftObject\SchemaOrg\DataTypes\DateTimeInterface::ObtainFromString()

Complexity

Conditions	3
Paths	4

Size

Total Lines	21
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

0

<?php
    public static function ObtainFromString(
        string $value,
        DateTimeZone $tz = null
    ) : DateTimeInterface {
        $out = new static($value);
        $format = static::ObtainFormat();

        if ( ! is_null($tz)) {
            $out = $out->setTimezone($tz);
        }

        $out = new static($out->format($format));

        if ( ! is_null($tz)) {
            /**
            * @var DateTimeInterface
            */
            $out = $out->setTimezone($tz);
        }

        return $out;

The expression return $out could return the type false which is incompatible with the type-hinted return SignpostMarv\DaftObject\SchemaOrg\DataTypes\DateTimeInterface. Consider adding an additional type-check to rule them out.

    }