Integrations\Traits\Access

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	20 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	allowAccess()	0	8	2
A	denyAccess()	0	8	2
A	hasAccess()	0	4	1
A	hasAccessToAny()	10	10	3
A	hasAccessToAll()	10	10	3
A	hasAccessOrFail()	0	8	2

<?php

namespace Integrations\Traits;

use Integrations\Exceptions\AccessDeniedException;

trait Access
{
    /**
     * Set an operation as having access using the Settings API.
     *
     * @param string $operation
     *
     * @return bool
     */
    public function allowAccess($operation)
    {
        foreach ((array) $operation as $op) {
            $this->set($op.'.access', true);

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this->hasAccessToAll($operation);

$operation is of type string, but the function expects a array.

    }

    /**
     * Disable the access to a certain operation, or the current one.
     *
     * @param bool $operation [description]
     *
     * @return [type] [description]

The doc-type [type] could not be parsed: Unknown type name "" at position 0. [(view supported doc-types)

     */
    public function denyAccess($operation)
    {
        foreach ((array) $operation as $op) {
            $this->set($op.'.access', false);

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return ! $this->hasAccessToAny($operation);

$operation is of type boolean, but the function expects a array.

    }

    /**
     * Check if a operation is allowed for a Crud Panel. Return false if not.
     *
     * @param string $operation
     *
     * @return bool
     */
    public function hasAccess($operation)
    {
        return $this->get($operation.'.access') ?? false;

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Check if any operations are allowed for a Crud Panel. Return false if not.
     *
     * @param array $operation_array
     *
     * @return bool
     */
    public function hasAccessToAny($operation_array)

This method seems to be duplicated in your project.

    {
        foreach ((array) $operation_array as $key => $operation) {
            if ($this->get($operation.'.access') == true) {

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return true;
            }
        }

        return false;
    }

    /**
     * Check if all operations are allowed for a Crud Panel. Return false if not.
     *
     * @param array $operation_array Permissions.
     *
     * @return bool
     */
    public function hasAccessToAll($operation_array)

This method seems to be duplicated in your project.

    {
        foreach ((array) $operation_array as $key => $operation) {
            if (! $this->get($operation.'.access')) {

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return false;
            }
        }

        return true;
    }

    /**
     * Check if a operation is allowed for a Crud Panel. Fail if not.
     *
     * @param string $operation
     *
     * @throws \Backpack\CRUD\Exception\AccessDeniedException in case the operation is not enabled
     *
     * @return bool
     */
    public function hasAccessOrFail($operation)
    {
        if (! $this->get($operation.'.access')) {

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]));
        }

        return true;
    }
}