Issues in FileController.php (master) - Issues in master - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1490)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Api/FileController.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Fabrica\Http\Api;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Event;

use Fabrica\Http\Api\Controller;
use Fabrica\Project\Eloquent\File;
use Fabrica\Events\FileUploadEvent;
use Fabrica\Events\FileDelEvent;
use Fabrica\Utils\File as FileUtil;
use DB;

class FileController extends Controller
{
    /**
     * Upload file.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  String                   $project_key
     * @return \Illuminate\Http\Response
     */
    public function upload(Request $request, $project_key)
    {
        set_time_limit(0);

        if (!is_writable(config('filesystems.disks.local.root', '/tmp'))) {
            throw new \UnexpectedValueException('the user has not the writable permission to the directory.', -15103);
        }

        $thumbnail_size = 190;

        $fields = array_keys($_FILES); 
        $field = array_pop($fields);
        if (empty($_FILES) || $_FILES[$field]['error'] > 0) {

            throw new \UnexpectedValueException('upload file errors.', -15101);
        }

        $basename = md5(microtime() . $_FILES[$field]['name']);
        $sub_save_path = config('filesystems.disks.local.root', '/tmp') . '/' . substr($basename, 0, 2) . '/';
        if (!is_dir($sub_save_path)) {
            @mkdir($sub_save_path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        $filename = '/tmp/' . $basename;
        move_uploaded_file($_FILES[$field]['tmp_name'], $filename);
        $data = [];
        $data['name']    = $_FILES[$field]['name'];
        $data['size']    = $_FILES[$field]['size'];
        $data['type']    = $_FILES[$field]['type'];
        $data['index']   = $basename; 
        if (in_array($_FILES[$field]['type'], [ 'image/jpeg', 'image/jpg', 'image/png', 'image/gif' ])) {

            $size = getimagesize($filename);
            $width = $size[0]; $height = $size[1];
            $scale = $width < $height ? $height : $width;
            $thumbnails_width = floor($thumbnail_size * $width / $scale);
            $thumbnails_height = floor($thumbnail_size * $height / $scale);
            $thumbnails_filename = $filename . '_thumbnails';
            if ($scale <= $thumbnail_size) {
                @copy($filename, $thumbnails_filename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            else if ($_FILES[$field]['type'] == 'image/jpeg' || $_FILES[$field]['type'] == 'image/jpg') {
                $src_image = imagecreatefromjpeg($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagejpeg($dst_image, $thumbnails_filename);
            }
            else if ($_FILES[$field]['type'] == 'image/png') {
                $src_image = imagecreatefrompng($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagepng($dst_image, $thumbnails_filename);
            }
            else if ($_FILES[$field]['type'] == 'image/gif') {
                $src_image = imagecreatefromgif($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagegif($dst_image, $thumbnails_filename);
            }
            else 
            {
                @copy($filename, $thumbnails_filename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            $data['thumbnails_index'] = $basename . '_thumbnails';
            // move the thumbnails
            @rename($thumbnails_filename, $sub_save_path . $data['thumbnails_index']);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        // move original file
        @rename($filename, $sub_save_path . $basename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $data['uploader'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        $file = File::create($data);

        $issue_id = $request->input('issue_id');
        if (isset($issue_id) && $issue_id) {
            Event::fire(new FileUploadEvent($project_key, $issue_id, $field, $file->id, $data['uploader']));
        }

        return response()->json([ 'ecode' => 0, 'data' => [ 'field' => $field, 'file' => File::find($file->id), 'filename' => '/actionview/api/project/' . $project_key . '/file/' . $file->id ] ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Download small image file.
     *
     * @param \Illuminate\Http\Request $request
     * @param String                   $id
     */
    public function downloadThumbnail(Request $request, $project_key, $id)
    {
        $file = File::find($id);
        $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($file->index, 0, 2);
        $filename = $filepath . '/' . $file->thumbnails_index;

        if (!file_exists($filename)) {
            throw new \UnexpectedValueException('file does not exist.', -15100);
        }

        FileUtil::download($filename, $file->name);
    }

    /**
     * Download file.
     *
     * @param \Illuminate\Http\Request $request
     * @param String                   $id
     */
    public function download(Request $request, $project_key, $id)
    {
        set_time_limit(0);

        $file = File::find($id); 
        if (!$file || $file->del_flg == 1) {
            throw new \UnexpectedValueException('file does not exist.', -15100);
        }

        $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($file->index, 0, 2);
        $filename = $filepath . '/' . $file->index;
        if (!file_exists($filename)) {
            throw new \UnexpectedValueException('file does not exist.', -15100);
        }

        FileUtil::download($filename, $file->name);
    }

    /**
     * get avatar file.
     *
     * @param \Illuminate\Http\Request $request
     */
    public function getAvatar(Request $request)
    {
        $fid = $request->input('fid');
        if (!isset($fid) || !$fid) {
            throw new \UnexpectedValueException('the avatar file id cannot empty.', -15100);
        }

        $filename = config('filesystems.disks.local.root', '/tmp') . '/avatar/' . $fid;
        if (!file_exists($filename)) {
            throw new \UnexpectedValueException('the avatar file does not exist.', -15100);
        }

        FileUtil::download($filename, $filename);
    }

    /**
     * Delete file.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  String                   $project_key
     * @param  String                   $id
     * @return \Illuminate\Http\Response
     */
    public function delete(Request $request, $project_key, $id)
    {
        $file = File::find($id);
        //if (!file || $file->del_flg == 1)
        //{
        //    throw new \UnexpectedValueException('file does not exist.', -15100);
        //}

        if ($file && !$this->isPermissionAllowed($project_key, 'remove_file') && !($this->isPermissionAllowed($project_key, 'remove_self_file') && $file->uploader['id'] == $this->user->id)) {

            return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        $issue_id = $request->input('issue_id');
        $field_key = $request->input('field_key');
        if (isset($issue_id) && $issue_id && isset($field_key) && $field_key) {
            $user = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
            Event::fire(new FileDelEvent($project_key, $issue_id, $field_key, $id, $user));
        }

        // logically deleted
        if ($file) {
            $file->fill([ 'del_flg' => 1 ])->save();
        }

        $issue = DB::collection('issue_' . $project_key)->where('_id', $issue_id)->first();
        if (array_search($id, $issue[$field_key]) === false) {
            return response()->json(['ecode' => 0, 'data' => ['id' => $id]]);
        }
        else
        {
            throw new \UnexpectedValueException('file deletion failed.', -15102);
        }
    }

    /**
     * Upload temporary file.
     *
     * @param  \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response
     */
    public function uploadTmpFile(Request $request)
    {
        set_time_limit(0);

        if (empty($_FILES) || $_FILES['file']['error'] > 0) {

            throw new \UnexpectedValueException('upload file errors.', -15101);
        }

        $basename = md5(microtime() . $_FILES['file']['name']);
        $sub_save_path = config('filesystems.disks.local.root', '/tmp') . '/' . substr($basename, 0, 2) . '/';
        if (!is_dir($sub_save_path)) {
            @mkdir($sub_save_path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        $filename = '/tmp/' . $basename;
        move_uploaded_file($_FILES['file']['tmp_name'], $filename);

        // move original file
        @rename($filename, $sub_save_path . $basename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $data['uploader'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $file = File::create($data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return response()->json([ 'ecode' => 0, 'data' => [ 'fid' => $basename, 'fname' => $_FILES['file']['name'] ] ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


Issues (1490)

Security Analysis not enabled

src/Http/Api/FileController.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		namespace Fabrica\Http\Api;
3
4		use Illuminate\Http\Request;
5		use Illuminate\Support\Facades\Event;
6
7		use Fabrica\Http\Api\Controller;
8		use Fabrica\Project\Eloquent\File;
9		use Fabrica\Events\FileUploadEvent;
10		use Fabrica\Events\FileDelEvent;
11		use Fabrica\Utils\File as FileUtil;
12		use DB;
13
14		class FileController extends Controller
15		{
16		/**
17		* Upload file.
18		*
19		* @param \Illuminate\Http\Request $request
20		* @param String $project_key
21		* @return \Illuminate\Http\Response
22		*/
23		public function upload(Request $request, $project_key)
24		{
25		set_time_limit(0);
26
27		if (!is_writable(config('filesystems.disks.local.root', '/tmp'))) {
28		throw new \UnexpectedValueException('the user has not the writable permission to the directory.', -15103);
29		}
30
31		$thumbnail_size = 190;
32
33		$fields = array_keys($_FILES);
34		$field = array_pop($fields);
35	View Code Duplication	if (empty($_FILES) \|\| $_FILES[$field]['error'] > 0) {
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		throw new \UnexpectedValueException('upload file errors.', -15101);
37		}
38
39		$basename = md5(microtime() . $_FILES[$field]['name']);
40		$sub_save_path = config('filesystems.disks.local.root', '/tmp') . '/' . substr($basename, 0, 2) . '/';
41		if (!is_dir($sub_save_path)) {
42		@mkdir($sub_save_path);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
43		}
44		$filename = '/tmp/' . $basename;
45		move_uploaded_file($_FILES[$field]['tmp_name'], $filename);
46		$data = [];
47		$data['name'] = $_FILES[$field]['name'];
48		$data['size'] = $_FILES[$field]['size'];
49		$data['type'] = $_FILES[$field]['type'];
50		$data['index'] = $basename;
51	View Code Duplication	if (in_array($_FILES[$field]['type'], [ 'image/jpeg', 'image/jpg', 'image/png', 'image/gif' ])) {
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		$size = getimagesize($filename);
53		$width = $size[0]; $height = $size[1];
54		$scale = $width < $height ? $height : $width;
55		$thumbnails_width = floor($thumbnail_size * $width / $scale);
56		$thumbnails_height = floor($thumbnail_size * $height / $scale);
57		$thumbnails_filename = $filename . '_thumbnails';
58		if ($scale <= $thumbnail_size) {
59		@copy($filename, $thumbnails_filename);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
60		}
61		else if ($_FILES[$field]['type'] == 'image/jpeg' \|\| $_FILES[$field]['type'] == 'image/jpg') {
62		$src_image = imagecreatefromjpeg($filename);
63		$dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
64		imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
65		imagejpeg($dst_image, $thumbnails_filename);
66		}
67		else if ($_FILES[$field]['type'] == 'image/png') {
68		$src_image = imagecreatefrompng($filename);
69		$dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
70		imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
71		imagepng($dst_image, $thumbnails_filename);
72		}
73		else if ($_FILES[$field]['type'] == 'image/gif') {
74		$src_image = imagecreatefromgif($filename);
75		$dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
76		imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
77		imagegif($dst_image, $thumbnails_filename);
78		}
79		else
80		{
81		@copy($filename, $thumbnails_filename);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
82		}
83		$data['thumbnails_index'] = $basename . '_thumbnails';
84		// move the thumbnails
85		@rename($thumbnails_filename, $sub_save_path . $data['thumbnails_index']);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
86		}
87		// move original file
88		@rename($filename, $sub_save_path . $basename);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
89		$data['uploader'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
90		$file = File::create($data);
91
92		$issue_id = $request->input('issue_id');
93		if (isset($issue_id) && $issue_id) {
94		Event::fire(new FileUploadEvent($project_key, $issue_id, $field, $file->id, $data['uploader']));
95		}
96
97		return response()->json([ 'ecode' => 0, 'data' => [ 'field' => $field, 'file' => File::find($file->id), 'filename' => '/actionview/api/project/' . $project_key . '/file/' . $file->id ] ]);
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
98		}
99
100		/**
101		* Download small image file.
102		*
103		* @param \Illuminate\Http\Request $request
104		* @param String $id
105		*/
106		public function downloadThumbnail(Request $request, $project_key, $id)
107		{
108		$file = File::find($id);
109		$filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($file->index, 0, 2);
110		$filename = $filepath . '/' . $file->thumbnails_index;
111
112		if (!file_exists($filename)) {
113		throw new \UnexpectedValueException('file does not exist.', -15100);
114		}
115
116		FileUtil::download($filename, $file->name);
117		}
118
119		/**
120		* Download file.
121		*
122		* @param \Illuminate\Http\Request $request
123		* @param String $id
124		*/
125		public function download(Request $request, $project_key, $id)
126		{
127		set_time_limit(0);
128
129		$file = File::find($id);
130		if (!$file \|\| $file->del_flg == 1) {
131		throw new \UnexpectedValueException('file does not exist.', -15100);
132		}
133
134		$filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($file->index, 0, 2);
135		$filename = $filepath . '/' . $file->index;
136		if (!file_exists($filename)) {
137		throw new \UnexpectedValueException('file does not exist.', -15100);
138		}
139
140		FileUtil::download($filename, $file->name);
141		}
142
143		/**
144		* get avatar file.
145		*
146		* @param \Illuminate\Http\Request $request
147		*/
148		public function getAvatar(Request $request)
149		{
150		$fid = $request->input('fid');
151		if (!isset($fid) \|\| !$fid) {
152		throw new \UnexpectedValueException('the avatar file id cannot empty.', -15100);
153		}
154
155		$filename = config('filesystems.disks.local.root', '/tmp') . '/avatar/' . $fid;
156		if (!file_exists($filename)) {
157		throw new \UnexpectedValueException('the avatar file does not exist.', -15100);
158		}
159
160		FileUtil::download($filename, $filename);
161		}
162
163		/**
164		* Delete file.
165		*
166		* @param \Illuminate\Http\Request $request
167		* @param String $project_key
168		* @param String $id
169		* @return \Illuminate\Http\Response
170		*/
171		public function delete(Request $request, $project_key, $id)
172		{
173		$file = File::find($id);
174		//if (!file \|\| $file->del_flg == 1)
175		//{
176		// throw new \UnexpectedValueException('file does not exist.', -15100);
177		//}
178
179	View Code Duplication	if ($file && !$this->isPermissionAllowed($project_key, 'remove_file') && !($this->isPermissionAllowed($project_key, 'remove_self_file') && $file->uploader['id'] == $this->user->id)) {
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
180		return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
181		}
182
183		$issue_id = $request->input('issue_id');
184		$field_key = $request->input('field_key');
185		if (isset($issue_id) && $issue_id && isset($field_key) && $field_key) {
186		$user = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
187		Event::fire(new FileDelEvent($project_key, $issue_id, $field_key, $id, $user));
188		}
189
190		// logically deleted
191		if ($file) {
192		$file->fill([ 'del_flg' => 1 ])->save();
193		}
194
195		$issue = DB::collection('issue_' . $project_key)->where('_id', $issue_id)->first();
196		if (array_search($id, $issue[$field_key]) === false) {
197		return response()->json(['ecode' => 0, 'data' => ['id' => $id]]);
198		}
199		else
200		{
201		throw new \UnexpectedValueException('file deletion failed.', -15102);
202		}
203		}
204
205		/**
206		* Upload temporary file.
207		*
208		* @param \Illuminate\Http\Request $request
209		* @return \Illuminate\Http\Response
210		*/
211		public function uploadTmpFile(Request $request)
212		{
213		set_time_limit(0);
214
215	View Code Duplication	if (empty($_FILES) \|\| $_FILES['file']['error'] > 0) {
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
216		throw new \UnexpectedValueException('upload file errors.', -15101);
217		}
218
219		$basename = md5(microtime() . $_FILES['file']['name']);
220		$sub_save_path = config('filesystems.disks.local.root', '/tmp') . '/' . substr($basename, 0, 2) . '/';
221		if (!is_dir($sub_save_path)) {
222		@mkdir($sub_save_path);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
223		}
224		$filename = '/tmp/' . $basename;
225		move_uploaded_file($_FILES['file']['tmp_name'], $filename);
226
227		// move original file
228		@rename($filename, $sub_save_path . $basename);
		0 ignored issues – show Security Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
229		$data['uploader'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
		0 ignored issues – show Coding Style Comprehensibility introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
230		$file = File::create($data);
		0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$file` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
231
232		return response()->json([ 'ecode' => 0, 'data' => [ 'fid' => $basename, 'fname' => $_FILES['file']['name'] ] ]);
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
233		}
234		}
235

SierraTecnologia / fabrica

Issues (1490)

Security Analysis not enabled

src/Http/Api/FileController.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like