Issues in DocumentController.php (master) - Issues in master - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1490)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Api/DocumentController.php (46 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Fabrica\Http\Api;

use Illuminate\Http\Request;

use Fabrica\Http\Requests;
use Fabrica\Http\Api\Controller;
use Fabrica\Events\DocumentEvent;
use Fabrica\Project\Eloquent\DocumentFavorites;
use Fabrica\Acl\Acl;
use DB;
use Fabrica\Utils\File;

use MongoDB\BSON\ObjectID;
use Zipper;

class DocumentController extends Controller
{
    /**
     * search path.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  string                   $project_key
     * @return \Illuminate\Http\Response
     */
    public function searchPath(Request $request, $project_key)

    {
        $s =  $request->input('s');
        if (!$s) {
            return response()->json(['ecode' => 0, 'data' => []]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        if ($s === '/') {
            return response()->json(['ecode' => 0, 'data' => [ [ 'id' => '0', 'name' => '/' ] ] ]);
        }

        $query = DB::collection('document_' . $project_key)
            ->where('d', 1)
            ->where('del_flag', '<>', 1)
            ->where('name', 'like', '%' . $s . '%');

        $moved_path = $request->input('moved_path');
        if (isset($moved_path) && $moved_path) {
            $query->where('pt', '<>', $moved_path);
            $query->where('_id', '<>', $moved_path);
        }

        $directories = $query->take(20)->get(['name', 'pt']);

        $ret = [];
        foreach ($directories as $d)
        {
            $parents = [];
            $path = '';
            $ps = DB::collection('document_' . $project_key)
                ->whereIn('_id', $d['pt'])
                ->get([ 'name' ]);
            foreach ($ps as $val)
            {
                $parents[$val['_id']->__toString()] = $val['name'];
            }

            foreach ($d['pt'] as $pid)
            {
                if (isset($parents[$pid])) {
                    $path .= '/' . $parents[$pid];
                }
            }
            $path .= '/' . $d['name'];
            $ret[] = [ 'id' => $d['_id']->__toString(), 'name' => $path ];
        }
        return response()->json(['ecode' => 0, 'data' => parent::arrange($ret)]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * get the directory children.
     *
     * @param  string $project_key
     * @param  string $directory
     * @return \Illuminate\Http\Response
     */
    public function getDirChildren(Request $request, $project_key, $directory)
    {
        $sub_dirs = DB::collection('document_' . $project_key)
            ->where('parent', $directory)
            ->where('d', 1)
            ->where('del_flag', '<>', 1)
            ->get();

        $res = [];
        foreach ($sub_dirs as $val) 
        {
            $res[] = [ 'id' => $val['_id']->__toString(), 'name' => $val['name'] ];
        }

        return response()->json([ 'ecode' => 0, 'data' => $res ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * get the directory tree.
     *
     * @param  string $project_key
     * @return \Illuminate\Http\Response
     */
    public function getDirTree(Request $request, $project_key)
    {
        $dt = [ 'id' => '0', 'name' => '根目录' ];

        $curdir = $request->input('currentdir');
        if (!$curdir) {
            $curdir = '0';
        }

        $pt = [ '0' ];
        if ($curdir !== '0') {
            $node = DB::collection('document_' . $project_key)
                ->where('_id', $curdir)
                ->first();

            if ($node) {
                $pt = $node['pt'];
                array_push($pt, $curdir);
            }
        }

        foreach($pt as $val)

        {
            $sub_dirs = DB::collection('document_' . $project_key)
                ->where('parent', $val)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->get();

            $this->addChildren2Tree($dt, $val, $sub_dirs);
        }

        return response()->json([ 'ecode' => 0, 'data' => $dt ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * add children to tree.
     *
     * @param  array  $dt
     * @param  string $parent_id
     * @param  array  $sub_dirs
     * @return void
     */
    public function addChildren2Tree(&$dt, $parent_id, $sub_dirs)
    {
        $new_dirs = [];
        foreach($sub_dirs as $val)
        {
            $new_dirs[] = [ 'id' => $val['_id']->__toString(), 'name' => $val['name'] ];
        }

        if ($dt['id'] == $parent_id) {

            $dt['children'] = $new_dirs;
            return true;
        }
        else
        {
            if (isset($dt['children']) && $dt['children']) {
                $children_num = count($dt['children']);
                for ($i = 0; $i < $children_num; $i++)
                {
                    $res = $this->addChildren2Tree($dt['children'][$i], $parent_id, $sub_dirs);
                    if ($res === true) {
                        return true;
                    }
                }
            }
            return false;
        }
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function getOptions(Request $request, $project_key)
    {
        $uploaders = DB::collection('document_' . $project_key)
            ->where('del_flag', '<>', 1)
            ->distinct('uploader')
            ->get([ 'uploader' ]);

        return response()->json(['ecode' => 0, 'data' => [ 'uploader' => $uploaders ]]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request, $project_key, $directory)
    {
        $documents = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $mode = 'list';
        $query = DB::collection('document_' . $project_key);

        $uploader_id = $request->input('uploader_id');
        if (isset($uploader_id) && $uploader_id) {
            $mode = 'search';
            $query->where('uploader.id', $uploader_id == 'me' ? $this->user->id : $uploader_id);
        }

        $name = $request->input('name');
        if (isset($name) && $name) {

            $mode = 'search';
            $query = $query->where('name', 'like', '%' . $name . '%');
        }

        $uploaded_at = $request->input('uploaded_at');
        if (isset($uploaded_at) && $uploaded_at) {
            $mode = 'search';
            $unitMap = [ 'w' => 'week', 'm' => 'month', 'y' => 'year' ];
            $unit = substr($uploaded_at, -1);
            $val = abs(substr($uploaded_at, 0, -1));
            $query->where('uploaded_at', '>=', strtotime(date('Ymd', strtotime('-' . $val . ' ' . $unitMap[$unit]))));
        }

        $favorite_documents = DocumentFavorites::where('project_key', $project_key)
            ->where('user.id', $this->user->id)
            ->get()
            ->toArray();
        $favorite_dids = array_column($favorite_documents, 'did');

        $myfavorite = $request->input('myfavorite');
        if (isset($myfavorite) && $myfavorite == '1') {

            $mode = 'search';
            $favoritedIds = [];
            foreach ($favorite_dids as $did)
            {
                $favoritedIds[] = new ObjectID($did);
            }

            $query->whereIn('_id', $favoritedIds);
        }

        if ($directory !== '0') {

            $query = $query->where($mode === 'search' ? 'pt' : 'parent', $directory);
        }
        else
        {
            if ($mode === 'list') {
                $query = $query->where('parent', $directory);
            }
        }

        $query->where('del_flag', '<>', 1);
        $query->orderBy('d', 'desc')->orderBy('_id', 'desc');

        $limit = 1000; // fix me
        $query->take($limit);
        $documents = $query->get();

        foreach ($documents as $k => $d)

        {
            if (in_array($d['_id']->__toString(), $favorite_dids)) {
                $documents[$k]['favorited'] = true;
            }
        }

        $path = [];
        if ($directory === '0') {
            $path[] = [ 'id' => '0', 'name' => 'root' ];
        }
        else
        {
            $path[] = [ 'id' => '0', 'name' => 'root' ];
            $d = DB::collection('document_' . $project_key)
                ->where('_id', $directory)
                ->first();
            if ($d && isset($d['pt'])) {
                $parents = [];
                $ps = DB::collection('document_' . $project_key)
                    ->whereIn('_id', $d['pt'])
                    ->get([ 'name' ]);
                foreach ($ps as $val)
                {
                    $parents[$val['_id']->__toString()] = $val['name'];
                }

                foreach ($d['pt'] as $pid)
                {
                    if (isset($parents[$pid])) {

                        $path[] = [ 'id' => $pid, 'name' => $parents[$pid] ];
                    }
                }
            }
            $path[] = [ 'id' => $directory, 'name' => $d['name'] ];
        }

        return response()->json([ 'ecode' => 0, 'data' => parent::arrange($documents), 'options' => [ 'path' => $path ] ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  string                   $project_key
     * @return \Illuminate\Http\Response
     */
    public function createFolder(Request $request, $project_key)

    {
        $insValues = [];

        $parent = $request->input('parent');
        if (!isset($parent)) {
            throw new \UnexpectedValueException('the parent directory can not be empty.', -11905);
        }
        $insValues['parent'] = $parent;

        if ($parent !== '0') {
            $isExists = DB::collection('document_' . $project_key)
                ->where('_id', $parent)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->exists();
            if (!$isExists) {
                throw new \UnexpectedValueException('the parent directory does not exist.', -11906);
            }
        }

        $name =  $request->input('name');
        if (!isset($name) || !$name) {
            throw new \UnexpectedValueException('the name can not be empty.', -11900);
        }
        $insValues['name'] = $name;

        $isExists = DB::collection('document_' . $project_key)
            ->where('parent', $parent)
            ->where('name', $name)
            ->where('d', 1)
            ->where('del_flag', '<>', 1)
            ->exists();
        if ($isExists) {
            throw new \UnexpectedValueException('the name cannot be repeated.', -11901);
        }

        $insValues['pt'] = $this->getParentTree($project_key, $parent);
        $insValues['d'] = 1;
        $insValues['creator'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        $insValues['created_at'] = time();

        $id = DB::collection('document_' . $project_key)->insertGetId($insValues);

        $document = DB::collection('document_' . $project_key)->where('_id', $id)->first();
        return response()->json(['ecode' => 0, 'data' => parent::arrange($document)]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * get parent treee.
     *
     * @param  string $project_key
     * @param  string $directory
     * @return array
     */
    public function getParentTree($project_key, $directory)

    {
        $pt = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($directory === '0') {
            $pt = [ '0' ];
        }
        else
        {
            $d = DB::collection('document_' . $project_key)
                ->where('_id', $directory)
                ->first();
            $pt = array_merge($d['pt'], [ $directory ]);
        }
        return $pt;
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  string                   $project_key
     * @param  string                   $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $project_key, $id)
    {
        $name = $request->input('name');
        if (!isset($name) || !$name) {
            throw new \UnexpectedValueException('the name can not be empty.', -11900);
        }

        $old_document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$old_document) {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        if (isset($old_document['d']) && $old_document['d'] === 1) {

            if (!$this->isPermissionAllowed($project_key, 'manage_project')) {
                return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }
        }
        else
        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project') && $old_document['uploader']['id'] !== $this->user->id) {
                return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
            }
        }

        if ($old_document['name'] !== $name) {

            $query = DB::collection('document_' . $project_key)
                ->where('parent', $old_document['parent'])
                ->where('name', $name)
                ->where('del_flag', '<>', 1);

            if (isset($old_document['d']) && $old_document['d'] === 1) {
                $query->where('d', 1);
            }
            else
            {
                $query->where('d', '<>', 1);
            }

            $isExists = $query->exists();

            if ($isExists) {
                throw new \UnexpectedValueException('the name cannot be repeated.', -11901);
            }
        }

        DB::collection('document_' . $project_key)->where('_id', $id)->update([ 'name' => $name ]);
        $new_document = DB::collection('document_' . $project_key)->where('_id', $id)->first();

        return response()->json(['ecode' => 0, 'data' => parent::arrange($new_document)]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * move the document.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  string                   $project_key
     * @return \Illuminate\Http\Response
     */
    public function move(Request $request, $project_key)
    {
        $id =  $request->input('id');
        if (!isset($id) || !$id) {
            throw new \UnexpectedValueException('the move object can not be empty.', -11911);
        }

        $dest_path =  $request->input('dest_path');
        if (!isset($dest_path)) {
            throw new \UnexpectedValueException('the dest directory can not be empty.', -11912);
        }

        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$document) {
            throw new \UnexpectedValueException('the move object does not exist.', -11913);
        }

        if (isset($document['d']) && $document['d'] === 1) {

            if (!$this->isPermissionAllowed($project_key, 'manage_project')) {
                return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }
        }
        else
        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project') && $document['uploader']['id'] !== $this->user->id) {
                return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
            }
        }

        $dest_directory = [];
        if ($dest_path !== '0') {
            $dest_directory = DB::collection('document_' . $project_key)
                ->where('_id', $dest_path)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->first();
            if (!$dest_directory) {
                throw new \UnexpectedValueException('the dest directory does not exist.', -11914);
            }
        }

        $isExists = DB::collection('document_' . $project_key)
            ->where('parent', $dest_path)
            ->where('name', $document['name'])
            ->where('d', isset($document['d']) && $document['d'] === 1 ? '=' : '<>', 1)
            ->where('del_flag', '<>', 1)
            ->exists();
        if ($isExists) {
            throw new \UnexpectedValueException('the name cannot be repeated.', -11901);
        }

        $updValues = [];
        $updValues['parent'] = $dest_path;
        $updValues['pt'] = array_merge(isset($dest_directory['pt']) ? $dest_directory['pt'] : [], [$dest_path]);
        DB::collection('document_' . $project_key)->where('_id', $id)->update($updValues);

        if (isset($document['d']) && $document['d'] === 1) {

            $subs = DB::collection('document_' . $project_key)
                ->where('pt', $id)
                ->where('del_flag', '<>', 1)
                ->get();
            foreach ($subs as $sub)
             {
                $pt = isset($sub['pt']) ? $sub['pt'] : [];
                $pind = array_search($id, $pt);
                if ($pind !== false) {
                    $tail = array_slice($pt, $pind);
                    $pt = array_merge($updValues['pt'], $tail);
                    DB::collection('document_' . $project_key)->where('_id', $sub['_id']->__toString())->update(['pt' => $pt]);
                }
            }
        }

        $document = DB::collection('document_' . $project_key)->where('_id', $id)->first();
        return response()->json(['ecode' => 0, 'data' => parent::arrange($document)]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  string $project_key
     * @param  string $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($project_key, $id)
    {
        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$document) {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        if (isset($document['d']) && $document['d'] === 1) {

            if (!$this->isPermissionAllowed($project_key, 'manage_project')) {
                return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }
        }
        else
        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project') && $document['uploader']['id'] !== $this->user->id) {
                return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
            }
        }

        DB::collection('document_' . $project_key)->where('_id', $id)->update([ 'del_flag' => 1 ]);

        if (isset($document['d']) && $document['d'] === 1) {

            DB::collection('document_' . $project_key)->whereRaw([ 'pt' => $id ])->update([ 'del_flag' => 1 ]);
        }

        return response()->json(['ecode' => 0, 'data' => [ 'id' => $id ]]);
    }

    /**
     * Upload file.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  String                   $project_key
     * @param  String                   $directory
     * @return \Illuminate\Http\Response
     */
    public function upload(Request $request, $project_key, $directory)
    {
        set_time_limit(0);

        if (!is_writable(config('filesystems.disks.local.root', '/tmp'))) {
            throw new \UnexpectedValueException('the user has not the writable permission to the directory.', -15103);
        }

        if ($directory !== '0') {
            $isExists = DB::collection('document_' . $project_key)
                ->where('_id', $directory)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->exists();
            if (!$isExists) {
                throw new \UnexpectedValueException('the parent directory does not exist.', -11905);
            }
        }

        $fields = array_keys($_FILES);
        $field = array_pop($fields);
        if (empty($_FILES) || $_FILES[$field]['error'] > 0) {

            throw new \UnexpectedValueException('upload file errors.', -11903);
        }

        $basename = md5(microtime() . $_FILES[$field]['name']);
        $sub_save_path = config('filesystems.disks.local.root', '/tmp') . '/' . substr($basename, 0, 2) . '/';
        if (!is_dir($sub_save_path)) {
            @mkdir($sub_save_path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }

        $filename = $sub_save_path . $basename;
        move_uploaded_file($_FILES[$field]['tmp_name'], $filename);

        $data = [];

        $thumbnail_size = 190;
        if (in_array($_FILES[$field]['type'], [ 'image/jpeg', 'image/jpg', 'image/png', 'image/gif' ])) {

            $size = getimagesize($filename);
            $width = $size[0]; $height = $size[1];
            $scale = $width < $height ? $height : $width;
            $thumbnails_width = floor($thumbnail_size * $width / $scale);
            $thumbnails_height = floor($thumbnail_size * $height / $scale);
            $thumbnails_filename = $filename . '_thumbnails';
            if ($scale <= $thumbnail_size) {
                @copy($filename, $thumbnails_filename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            else if ($_FILES[$field]['type'] == 'image/jpeg' || $_FILES[$field]['type'] == 'image/jpg') {
                $src_image = imagecreatefromjpeg($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagejpeg($dst_image, $thumbnails_filename);
            }
            else if ($_FILES[$field]['type'] == 'image/png') {
                $src_image = imagecreatefrompng($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagepng($dst_image, $thumbnails_filename);
            }
            else if ($_FILES[$field]['type'] == 'image/gif') {
                $src_image = imagecreatefromgif($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagegif($dst_image, $thumbnails_filename);
            }
            else
            {
                @copy($filename, $thumbnails_filename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            $data['thumbnails_index'] = $basename . '_thumbnails';
            // move the thumbnails
            @rename($thumbnails_filename, $sub_save_path . $data['thumbnails_index']);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }

        $fname = $_FILES[$field]['name'];
        $extname = '';
        $segments = explode('.', $fname);
        if (count($segments) > 1) {
            $extname = '.' . array_pop($segments);
            $fname = implode('.', $segments);
        }
        $i = 1;
        while(true)
        {
            $isExists = DB::collection('document_' . $project_key)
                ->where('parent', $directory)
                ->where('name', $fname . ($i < 2 ? '' : ('(' . $i . ')')) . $extname)
                ->where('d', '<>', 1)
                ->where('del_flag', '<>', 1)
                ->exists();
            if (!$isExists) {
                break;
            }
            $i++;
        }
        $data['name'] = $fname . ($i < 2 ? '' : ('(' . $i . ')')) . $extname;

        $data['pt']      = $this->getParentTree($project_key, $directory);
        $data['parent']  = $directory;
        $data['size']    = $_FILES[$field]['size'];
        $data['type']    = $_FILES[$field]['type'];
        $data['index']   = $basename;

        $data['uploader'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        $data['uploaded_at'] = time();

        $id = DB::collection('document_' . $project_key)->insertGetId($data);
        $document = DB::collection('document_' . $project_key)->where('_id', $id)->first();

        return response()->json(['ecode' => 0, 'data' => parent::arrange($document)]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Download Thumbnails file.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  String                   $project_key
     * @param  String                   $id
     * @return \Illuminate\Http\Response
     */
    public function downloadThumbnails(Request $request, $project_key, $id)
    {
        set_time_limit(0);

        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->first();
        if (!$document) {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($document['index'], 0, 2);
        $filename = $filepath . '/' . $document['thumbnails_index'];
        if (!file_exists($filename)) {
            throw new \UnexpectedValueException('file does not exist.', -11904);
        }

        File::download($filename, $document['name']);
    }

    /**
     * Download file or directory.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  String                   $project_key
     * @param  String                   $id
     * @return \Illuminate\Http\Response
     */
    public function download(Request $request, $project_key, $id)
    {
        set_time_limit(0);

        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->first();
        if (!$document) {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        if (isset($document['d']) && $document['d'] === 1) {
            $this->downloadFolder($project_key, $document['name'], $id);
        }
        else
        {
            $this->downloadFile($document['name'], $document['index']);
        }
    }

    /**
     * Download file.
     *
     * @param  String $name
     * @param  String $directory
     * @return \Illuminate\Http\Response
     */
    public function downloadFolder($project_key, $name, $directory)
    {
        setlocale(LC_ALL, 'zh_CN.UTF-8'); 

        $basepath = '/tmp/' . md5($this->user->id . microtime());
        @mkdir($basepath);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $this->contructFolder($project_key, $basepath . '/' . $name, $directory);

        $filename = $basepath . '/' . $name . '.zip';

        Zipper::make($filename)->folder($name)->add($basepath . '/' . $name);
        Zipper::close();

        File::download($filename, $name . '.zip');

        exec('rm -rf ' . $basepath);
    }

    /**
     * contruct file folder.
     *
     * @param  String $fullpath
     * @param  String $id
     * @return void
     */
    public function contructFolder($project_key, $fullpath, $id)
    {
        @mkdir($fullpath);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $documents = DB::collection('document_' . $project_key)
            ->where('parent', $id)
            ->where('del_flag', '<>', 1)
            ->get();
        foreach ($documents as $doc)
        {
            if (isset($doc['d']) && $doc['d'] === 1) {
                $this->contructFolder($project_key, $fullpath . '/' . $doc['name'], $doc['_id']->__toString());
            }
            else
            {
                $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($doc['index'], 0, 2);
                $filename = $filepath . '/' . $doc['index'];
                if (file_exists($filename)) {
                    @copy($filename, $fullpath . '/' . $doc['name']);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                }
            }
        }
    }

    /**
     * Download file.
     *
     * @param  String $name
     * @param  String $index
     * @return \Illuminate\Http\Response
     */
    public function downloadFile($name, $index)

    {
        $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($index, 0, 2);
        $filename = $filepath . '/' . $index;
        if (!file_exists($filename)) {
            throw new \UnexpectedValueException('file does not exist.', -11904);
        }

        File::download($filename, $name);
    }

    /**
     * favorite action.
     *
     * @param  string $project_key
     * @param  string $id
     * @return \Illuminate\Http\Response
     */
    public function favorite(Request $request, $project_key, $id)

    {
        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$document) {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        DocumentFavorites::where('did', $id)->where('user.id', $this->user->id)->delete();

        $cur_user = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];

        $flag = $request->input('flag');
        if (isset($flag) && $flag) {
            DocumentFavorites::create([ 'project_key' => $project_key, 'did' => $id, 'user' => $cur_user ]);
        }

        return response()->json(['ecode' => 0, 'data' => ['id' => $id, 'user' => $cur_user, 'favorited' => $flag]]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


Issues (1490)

Security Analysis not enabled

src/Http/Api/DocumentController.php (46 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

SierraTecnologia / fabrica

Issues (1490)

Security Analysis not enabled

src/Http/Api/DocumentController.php (46 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like