Issues in LDAP.php (master) - Issues in master - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1490)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ActiveDirectory/LDAP.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Fabrica\ActiveDirectory;

use Adldap\Adldap;

use Cartalyst\Sentinel\Users\EloquentUser;
use Fabrica\Acl\Eloquent\Group;

use Sentinel;
use DB;
use Exception;

class LDAP
{

    /**
     * connect ldap server.
     *
     * @var    array $config
     * @return array 
     */
    public static function test($configs)
    {
        $ad = new Adldap(self::filterConnectConfigs($configs));

        $ret = [];
        foreach ($configs as $key => $config)
        {
            $tmp = [];
            try {
                $provider = $ad->connect($key);
            } catch (Exception $e) {
                $ret[$key] =  [ 
                    'server_connect'   => false, 
                    'user_count'       => 0, 
                    'group_count'      => 0, 
                    'group_membership' => false ];
                continue;
            }

            $tmp['server_connect'] = true;

            if (!isset($config['user_object_class'])) {

                $tmp['user_count'] = 0;
            }
            else
            {
                $users = $provider
                    ->search()
                    ->setDn(self::getUserDn($config))
                    ->rawFilter(isset($config['user_object_filter']) ? $config['user_object_filter'] : ('(objectClass=' . $config['user_object_class'] . ')'))
                    ->where('objectClass', $config['user_object_class'])
                    ->get();
                $tmp['user_count'] = count($users);
            }

            if (!isset($config['group_object_class'])) {

                $tmp['group_count'] = 0;
            }
            else
            {
                $groups = $provider
                    ->search()
                    ->setDn(self::getGroupDn($config))
                    ->rawFilter(isset($config['group_object_filter']) ? $config['group_object_filter'] : ('(objectClass=' . $config['group_object_class'] . ')'))
                    ->where('objectClass', $configs['default']['group_object_class'])
                    ->get();
                $tmp['group_count'] = count($groups);
            }

            if (!isset($config['group_object_class']) || !isset($config['group_membership_attr'])) {
                $tmp['group_memebership'] = false;
            }
            else
            {
                $group = $provider
                    ->search()
                    ->setDn(self::getGroupDn($config))
                    ->where('objectClass', $config['group_object_class'])
                    ->first();
                $tmp['group_membership'] = $group ? $group->hasAttribute(strtolower($config['group_membership_attr'])) : false;
            }

            $ret[$key] = $tmp;
        }

        return $ret;
    }

    /**
     * connect ldap server.
     *
     * @var    array $config
     * @return array 
     */
    public static function sync($configs)
    {
        $ret = [];
        $ad = new Adldap(self::filterConnectConfigs($configs));

        foreach ($configs as $key => $config)
        {
            $tmp = [];
            try {
                $provider = $ad->connect($key);
            } catch (Exception $e) {
                $tmp['connect'] = $tmp['user'] = $tmp['group'] = false;
                $ret[$key] = $tmp;
                continue;
            }
            $tmp['connect'] = true;
            // sync the users
            $tmp['user'] = self::syncUsers($provider, $key, $config);
            // sync the groups
            $tmp['group'] = self::syncGroups($provider, $key, $config);

            $ret[$key] = $tmp;
        }

        return $ret;
    }

    /**
     * arrange configs.
     *
     * @return array
     */
    public static function filterConnectConfigs($configs)
    {
        $connect_configs = [];
        foreach ($configs as $key => $config)
        {
            $connect = [];
            $connect['domain_controllers'] = [ $config['host'] ];
            $connect['port'] = $config['port'];
            $connect['admin_username'] = $config['admin_username'];
            $connect['admin_password'] = $config['admin_password'];
            if (isset($config['encryption']) && $config['encryption']) {
                if ($config['encryption'] == 'ssl') {
                    $connect['use_ssl'] = true;
                }
                else if ($config['encryption'] == 'tls') {
                    $connect['use_tls'] = true;
                }
                else
                {
                    $connect['use_ssl'] = false;
                    $connect['use_tls'] = false; 
                }
            }
            else
            {
                $connect['use_ssl'] = false;
                $connect['use_tls'] = false;   
            }
            $connect_configs[$key] = $connect;
        }

        return $connect_configs;
    }

    /**
     * get user dn.
     *
     * @return string 
     */
    public static function getUserDN($config)

    {
        $user_dn = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($config['additional_user_dn']) && $config['additional_user_dn']) {
            if (strpos($config['additional_user_dn'], $config['base_dn']) !== false) {
                $user_dn = $config['additional_user_dn'];
            }
            else
            {
                $user_dn = $config['additional_user_dn'] . ',' . $config['base_dn'];
            }
        }
        else
        {
            $user_dn = $config['base_dn'];
        }
        return $user_dn;
    }

    /**
     * get group dn.
     *
     * @return string 
     */
    public static function getGroupDN($config)

    {
        $group_dn = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($config['additional_group_dn']) && $config['additional_group_dn']) {
            if (strpos($config['additional_group_dn'], $config['base_dn']) !== false) {
                $group_dn = $config['additional_group_dn'];
            }
            else
            {
                $group_dn = $config['additional_group_dn'] . ',' . $config['base_dn'];
            }
        }
        else
        {
            $group_dn = $config['base_dn'];
        }
        return $group_dn;
    }

    /**
     * sync the users.
     *
     * @return bool 
     */
    public static function syncUsers($provider, $directory, $config)
    {
        if (!isset($config['user_object_class'])) {
            return false;
        }

        // the user sync
        DB::table('users')->where('directory', $directory)->update([ 'sync_flag' => 1 ]);

        $users = $provider
            ->search()
            ->setDn(self::getUserDN($config))
            ->rawFilter(isset($config['user_object_filter']) ? $config['user_object_filter'] : ('(objectClass=' . $config['user_object_class'] . ')'))
            ->where('objectClass', $config['user_object_class'])
            ->get();
        foreach ($users as $user)
        {
            $dn = $user->getDn();
            $cn = $user->getFirstAttribute(strtolower($config['user_name_attr']));
            $email = $user->getFirstAttribute(strtolower($config['user_email_attr']));

            $eloquent_user = EloquentUser::where('directory', $directory)
                ->where('ldap_dn', $dn)
                ->first();
            if ($eloquent_user) {
                Sentinel::update(
                    $eloquent_user, [
                    'first_name' => $cn,
                    'email' => $email,
                    'invalid_flag' => 0,
                    'sync_flag' => 0 ]
                );
            }
            else
            {
                Sentinel::register(
                    [
                    'directory' => $directory,
                    'ldap_dn' => $dn,
                    'first_name' => $cn,
                    'email' => $email,
                    'password' => md5(rand(10000, 99999)) ],
                    true
                );
            }
        }
        // disable the users
        DB::table('users')
            ->where('directory', $directory)
            ->where('sync_flag', 1)
            ->update([ 'sync_flag' => 0, 'invalid_flag' => 1 ]);

        return true;
    }

    /**
     * sync the groups.
     *
     * @return bool 
     */
    public static function syncGroups($provider, $directory, $config)
    {
        if (!isset($config['group_object_class'])) {
            return false;
        }

        $groups = $provider
            ->search()
            ->setDn(self::getGroupDN($config))
            ->rawFilter(isset($config['group_object_filter']) ? $config['group_object_filter'] : ('(objectClass=' . $config['group_object_class'] . ')'))
            ->where('objectClass', $config['group_object_class'])
            ->get();

        foreach ($groups as $group)
        {
            $dn = $group->getDn();
            $cn = $group->getFirstAttribute(strtolower($config['group_name_attr']));
            $members = $group->getAttribute(strtolower($config['group_membership_attr']));

            $users = EloquentUser::where('directory', $directory)
                ->whereIn('ldap_dn', $members)
                ->get([ 'name' ])
                ->toArray();

            $user_ids = [];
            if ($users) {
                $user_ids = array_column($users, '_id');
            }

            $eloquent_group = Group::where('directory', $directory)
                ->where('ldap_dn', $dn)
                ->first();
            if ($eloquent_group) {
                $eloquent_group
                    ->fill([ 'name' => $cn, 'users' => $user_ids ])
                    ->save();
            }
            else
            {
                Group::create(
                    [ 
                    'name' => $cn, 
                    'users' => $user_ids, 
                    'ldap_dn' => $dn, 
                    'directory' => $directory ]
                );
            }
        }

        return true;
    }

    /**
     * ldap user authenticate.
     *
     * @var    array $configs
     * @var    string $username
     * @var    string $password
     * @return object 
     */
    public static function attempt($configs, $username, $password)
    {
        $pass = false;
        $user = null;

        $ad = new Adldap(self::filterConnectConfigs($configs));

        foreach ($configs as $key => $config)
        {
            try {
                $provider = $ad->connect($key);

                $user = EloquentUser::where('directory', $key)
                    ->where('email', $username)
                    ->first(); 

                if (!$user || !$user->ldap_dn) {
                    continue;
                }

                if ($provider->auth()->attempt($user->ldap_dn, $password)) {
                    $pass = true;
                    break;
                }
            } catch (Exception $e) {
                continue;
            }
        }

        return $pass ? $user : null;
    }
}


1		<?php
2		namespace Fabrica\ActiveDirectory;
3
4		use Adldap\Adldap;
5
6		use Cartalyst\Sentinel\Users\EloquentUser;
7		use Fabrica\Acl\Eloquent\Group;
8
9		use Sentinel;
10		use DB;
11		use Exception;
12
13		class LDAP
14		{
15
16		/**
17		* connect ldap server.
18		*
19		* @var array $config
20		* @return array
21		*/
22		public static function test($configs)
23		{
24		$ad = new Adldap(self::filterConnectConfigs($configs));
25
26		$ret = [];
27		foreach ($configs as $key => $config)
28		{
29		$tmp = [];
30		try {
31		$provider = $ad->connect($key);
32		} catch (Exception $e) {
33		$ret[$key] = [
34		'server_connect' => false,
35		'user_count' => 0,
36		'group_count' => 0,
37		'group_membership' => false ];
38		continue;
39		}
40
41		$tmp['server_connect'] = true;
42
43	View Code Duplication	if (!isset($config['user_object_class'])) {
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		$tmp['user_count'] = 0;
45		}
46		else
47		{
48		$users = $provider
49		->search()
50		->setDn(self::getUserDn($config))
51		->rawFilter(isset($config['user_object_filter']) ? $config['user_object_filter'] : ('(objectClass=' . $config['user_object_class'] . ')'))
52		->where('objectClass', $config['user_object_class'])
53		->get();
54		$tmp['user_count'] = count($users);
55		}
56
57	View Code Duplication	if (!isset($config['group_object_class'])) {
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		$tmp['group_count'] = 0;
59		}
60		else
61		{
62		$groups = $provider
63		->search()
64		->setDn(self::getGroupDn($config))
65		->rawFilter(isset($config['group_object_filter']) ? $config['group_object_filter'] : ('(objectClass=' . $config['group_object_class'] . ')'))
66		->where('objectClass', $configs['default']['group_object_class'])
67		->get();
68		$tmp['group_count'] = count($groups);
69		}
70
71		if (!isset($config['group_object_class']) \|\| !isset($config['group_membership_attr'])) {
72		$tmp['group_memebership'] = false;
73		}
74		else
75		{
76		$group = $provider
77		->search()
78		->setDn(self::getGroupDn($config))
79		->where('objectClass', $config['group_object_class'])
80		->first();
81		$tmp['group_membership'] = $group ? $group->hasAttribute(strtolower($config['group_membership_attr'])) : false;
82		}
83
84		$ret[$key] = $tmp;
85		}
86
87		return $ret;
88		}
89
90		/**
91		* connect ldap server.
92		*
93		* @var array $config
94		* @return array
95		*/
96		public static function sync($configs)
97		{
98		$ret = [];
99		$ad = new Adldap(self::filterConnectConfigs($configs));
100
101		foreach ($configs as $key => $config)
102		{
103		$tmp = [];
104		try {
105		$provider = $ad->connect($key);
106		} catch (Exception $e) {
107		$tmp['connect'] = $tmp['user'] = $tmp['group'] = false;
108		$ret[$key] = $tmp;
109		continue;
110		}
111		$tmp['connect'] = true;
112		// sync the users
113		$tmp['user'] = self::syncUsers($provider, $key, $config);
114		// sync the groups
115		$tmp['group'] = self::syncGroups($provider, $key, $config);
116
117		$ret[$key] = $tmp;
118		}
119
120		return $ret;
121		}
122
123		/**
124		* arrange configs.
125		*
126		* @return array
127		*/
128		public static function filterConnectConfigs($configs)
129		{
130		$connect_configs = [];
131		foreach ($configs as $key => $config)
132		{
133		$connect = [];
134		$connect['domain_controllers'] = [ $config['host'] ];
135		$connect['port'] = $config['port'];
136		$connect['admin_username'] = $config['admin_username'];
137		$connect['admin_password'] = $config['admin_password'];
138		if (isset($config['encryption']) && $config['encryption']) {
139		if ($config['encryption'] == 'ssl') {
140		$connect['use_ssl'] = true;
141		}
142		else if ($config['encryption'] == 'tls') {
143		$connect['use_tls'] = true;
144		}
145		else
146		{
147		$connect['use_ssl'] = false;
148		$connect['use_tls'] = false;
149		}
150		}
151		else
152		{
153		$connect['use_ssl'] = false;
154		$connect['use_tls'] = false;
155		}
156		$connect_configs[$key] = $connect;
157		}
158
159		return $connect_configs;
160		}
161
162		/**
163		* get user dn.
164		*
165		* @return string
166		*/
167	View Code Duplication	public static function getUserDN($config)
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		$user_dn = '';
		0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$user_dn` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
170		if (isset($config['additional_user_dn']) && $config['additional_user_dn']) {
171		if (strpos($config['additional_user_dn'], $config['base_dn']) !== false) {
172		$user_dn = $config['additional_user_dn'];
173		}
174		else
175		{
176		$user_dn = $config['additional_user_dn'] . ',' . $config['base_dn'];
177		}
178		}
179		else
180		{
181		$user_dn = $config['base_dn'];
182		}
183		return $user_dn;
184		}
185
186		/**
187		* get group dn.
188		*
189		* @return string
190		*/
191	View Code Duplication	public static function getGroupDN($config)
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
192		{
193		$group_dn = '';
		0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$group_dn` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
194		if (isset($config['additional_group_dn']) && $config['additional_group_dn']) {
195		if (strpos($config['additional_group_dn'], $config['base_dn']) !== false) {
196		$group_dn = $config['additional_group_dn'];
197		}
198		else
199		{
200		$group_dn = $config['additional_group_dn'] . ',' . $config['base_dn'];
201		}
202		}
203		else
204		{
205		$group_dn = $config['base_dn'];
206		}
207		return $group_dn;
208		}
209
210		/**
211		* sync the users.
212		*
213		* @return bool
214		*/
215		public static function syncUsers($provider, $directory, $config)
216		{
217		if (!isset($config['user_object_class'])) {
218		return false;
219		}
220
221		// the user sync
222		DB::table('users')->where('directory', $directory)->update([ 'sync_flag' => 1 ]);
223
224		$users = $provider
225		->search()
226		->setDn(self::getUserDN($config))
227		->rawFilter(isset($config['user_object_filter']) ? $config['user_object_filter'] : ('(objectClass=' . $config['user_object_class'] . ')'))
228		->where('objectClass', $config['user_object_class'])
229		->get();
230		foreach ($users as $user)
231		{
232		$dn = $user->getDn();
233		$cn = $user->getFirstAttribute(strtolower($config['user_name_attr']));
234		$email = $user->getFirstAttribute(strtolower($config['user_email_attr']));
235
236		$eloquent_user = EloquentUser::where('directory', $directory)
237		->where('ldap_dn', $dn)
238		->first();
239		if ($eloquent_user) {
240		Sentinel::update(
241		$eloquent_user, [
242		'first_name' => $cn,
243		'email' => $email,
244		'invalid_flag' => 0,
245		'sync_flag' => 0 ]
246		);
247		}
248		else
249		{
250		Sentinel::register(
251		[
252		'directory' => $directory,
253		'ldap_dn' => $dn,
254		'first_name' => $cn,
255		'email' => $email,
256		'password' => md5(rand(10000, 99999)) ],
257		true
258		);
259		}
260		}
261		// disable the users
262		DB::table('users')
263		->where('directory', $directory)
264		->where('sync_flag', 1)
265		->update([ 'sync_flag' => 0, 'invalid_flag' => 1 ]);
266
267		return true;
268		}
269
270		/**
271		* sync the groups.
272		*
273		* @return bool
274		*/
275		public static function syncGroups($provider, $directory, $config)
276		{
277		if (!isset($config['group_object_class'])) {
278		return false;
279		}
280
281		$groups = $provider
282		->search()
283		->setDn(self::getGroupDN($config))
284		->rawFilter(isset($config['group_object_filter']) ? $config['group_object_filter'] : ('(objectClass=' . $config['group_object_class'] . ')'))
285		->where('objectClass', $config['group_object_class'])
286		->get();
287
288		foreach ($groups as $group)
289		{
290		$dn = $group->getDn();
291		$cn = $group->getFirstAttribute(strtolower($config['group_name_attr']));
292		$members = $group->getAttribute(strtolower($config['group_membership_attr']));
293
294		$users = EloquentUser::where('directory', $directory)
295		->whereIn('ldap_dn', $members)
296		->get([ 'name' ])
297		->toArray();
298
299		$user_ids = [];
300		if ($users) {
301		$user_ids = array_column($users, '_id');
302		}
303
304		$eloquent_group = Group::where('directory', $directory)
305		->where('ldap_dn', $dn)
306		->first();
307		if ($eloquent_group) {
308		$eloquent_group
309		->fill([ 'name' => $cn, 'users' => $user_ids ])
310		->save();
311		}
312		else
313		{
314		Group::create(
315		[
316		'name' => $cn,
317		'users' => $user_ids,
318		'ldap_dn' => $dn,
319		'directory' => $directory ]
320		);
321		}
322		}
323
324		return true;
325		}
326
327		/**
328		* ldap user authenticate.
329		*
330		* @var array $configs
331		* @var string $username
332		* @var string $password
333		* @return object
334		*/
335		public static function attempt($configs, $username, $password)
336		{
337		$pass = false;
338		$user = null;
339
340		$ad = new Adldap(self::filterConnectConfigs($configs));
341
342		foreach ($configs as $key => $config)
343		{
344		try {
345		$provider = $ad->connect($key);
346
347		$user = EloquentUser::where('directory', $key)
348		->where('email', $username)
349		->first();
350
351		if (!$user \|\| !$user->ldap_dn) {
352		continue;
353		}
354
355		if ($provider->auth()->attempt($user->ldap_dn, $password)) {
356		$pass = true;
357		break;
358		}
359		} catch (Exception $e) {
360		continue;
361		}
362		}
363
364		return $pass ? $user : null;
365		}
366		}
367

SierraTecnologia / fabrica

Issues (1490)

Security Analysis not enabled

src/ActiveDirectory/LDAP.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like