SierraTecnologia / fabrica

src/Http/Api/BoardController.php

Unused Use Statements +2 added lines, -4 removed lines

@@ -3,16 +3,14 @@
 namespace Fabrica\Http\Api;
 
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Event;
 
-use Fabrica\Http\Requests;
 use Fabrica\Http\Api\Controller;
 
+use Fabrica\Project\Eloquent\AccessBoardLog;
 use Fabrica\Project\Eloquent\Board;
 use Fabrica\Project\Eloquent\BoardRankMap;
-use Fabrica\Project\Eloquent\AccessBoardLog;
-use Fabrica\Project\Eloquent\Sprint;
 use Fabrica\Project\Eloquent\Epic;
+use Fabrica\Project\Eloquent\Sprint;
 use Fabrica\Project\Eloquent\Version;
 use Fabrica\Project\Provider;
 

src/Http/Api/CalendarController.php

Doc Comments +4 added lines, -5 removed lines

@@ -55,7 +55,7 @@ 
     /**
      * fetch the year dates .
      *
-     * @param number $year
+     * @param integer $year
      * @return array
      */
     public function getYearDates($year)
@@ -92,9 +92,9 @@ 
     /**
      * convert the solar to lunar.
      *
-     * @param number $year
-     * @param number $month
-     * @param number $day
+     * @param string $year
+     * @param integer $month
+     * @param integer $day
      * @return array
      */
     private function convert2lunar($year, $month, $day)
@@ -210,7 +210,6 @@ 
     /**
      * sync the year singular calendars.
      *
-     * @param string $year
      * @@return array
      */
     public function sync(Request $request)

Unused Use Statements +1 added lines, -2 removed lines

@@ -4,12 +4,11 @@
 
 use Illuminate\Http\Request;
 
-use Fabrica\Http\Requests;
 use Fabrica\Http\Api\Controller;
 use Fabrica\System\Eloquent\CalendarSingular;
 
-use Fabrica\Utils\Lunar;
 use Fabrica\Utils\CurlRequest;
+use Fabrica\Utils\Lunar;
 
 class CalendarController extends Controller
 {

src/Http/Api/CommentsController.php

Unused Use Statements -4 removed lines

@@ -6,12 +6,8 @@
 use Fabrica\Events\IssueEvent;
 use Fabrica\Http\Api\Controller;
 
-use Fabrica\Http\Requests;
-use Fabrica\Project\Provider;
-
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Event;
-use Sentinel;
 
 class CommentsController extends Controller
 {

src/Http/Api/Controller.php

Doc Comments +2 added lines

@@ -51,6 +51,7 @@ 
      *
      * string $project_key
      * string $permission
+     * @param string $permission
      * @return bool
      */
     public function isPermissionAllowed($project_key, $permission, $user_id='')
@@ -77,6 +78,7 @@ 
     /**
      * check if the field is used by issue.
      *
+     * @param string $field_key
      * @return true 
      */
     public function isFieldUsedByIssue($project_key, $field_key, $field, $ext_info='')

Unused Use Statements +5 added lines, -5 removed lines

@@ -2,18 +2,18 @@
 
 namespace Fabrica\Http\Api;
 
-use Illuminate\Foundation\Bus\DispatchesJobs;
-use Illuminate\Routing\Controller as BaseController;
-use Illuminate\Foundation\Validation\ValidatesRequests;
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Auth\Access\AuthorizesResources;
+use Illuminate\Foundation\Bus\DispatchesJobs;
+use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Routing\Controller as BaseController;
 
+use DB;
+use Fabrica\Acl\Acl;
 use Fabrica\Project\Eloquent\Project;
 use Fabrica\Project\Eloquent\Watch;
 use Fabrica\Project\Provider;
-use Fabrica\Acl\Acl;
 use Sentinel;
-use DB;
 
 use MongoDB\BSON\ObjectID; 
 

src/Http/Api/DirectoryController.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -5,11 +5,10 @@
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Event;
 
-use Fabrica\Http\Requests;
 use Fabrica\Http\Api\Controller;
 
-use Fabrica\Acl\Eloquent\Group;
 use Cartalyst\Sentinel\Users\EloquentUser;
+use Fabrica\Acl\Eloquent\Group;
 use Fabrica\ActiveDirectory\Eloquent\Directory;
 use Fabrica\ActiveDirectory\LDAP;
 

src/Http/Api/DocumentController.php

Doc Comments +3 added lines, -2 removed lines

@@ -148,7 +148,7 @@ 
      * @param  array  $dt
      * @param  string $parent_id
      * @param  array  $sub_dirs
-     * @return void
+     * @return boolean
      */
     public function addChildren2Tree(&$dt, $parent_id, $sub_dirs)
     {
@@ -377,7 +377,7 @@ 
      * get parent treee.
      * @param  string  $project_key
      * @param  string  $directory
-     * @return array
+     * @return string[]
      */
     public function getParentTree($project_key, $directory)
     {
@@ -804,6 +804,7 @@ 
      *
      * @param  String  $name
      * @param  String  $directory
+     * @param string $project_key
      * @return \Illuminate\Http\Response
      */
     public function downloadFolder($project_key, $name, $directory)

Unused Use Statements +1 added lines, -4 removed lines

@@ -4,12 +4,9 @@
 
 use Illuminate\Http\Request;
 
-use Fabrica\Http\Requests;
+use DB;
 use Fabrica\Http\Api\Controller;
-use Fabrica\Events\DocumentEvent;
 use Fabrica\Project\Eloquent\DocumentFavorites;
-use Fabrica\Acl\Acl;
-use DB;
 use Fabrica\Utils\File;
 
 use MongoDB\BSON\ObjectID;

src/Http/Api/EpicController.php

Doc Comments -1 removed lines

@@ -256,7 +256,6 @@
     /**
      * update the issues epic
      *
-     * @param  array $issues
      * @param  string $source
      * @param  string $dest
      * @return \Illuminate\Http\Response

Unused Use Statements +2 added lines, -4 removed lines

@@ -5,14 +5,12 @@
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Event;
 
+use DB;
 use Fabrica\Events\IssueEvent;
-use Fabrica\Http\Requests;
 use Fabrica\Http\Api\Controller;
-use Fabrica\Customization\Eloquent\State;
-use Fabrica\Project\Eloquent\Epic;
 use Fabrica\Project\Eloquent\Board;
+use Fabrica\Project\Eloquent\Epic;
 use Fabrica\Project\Provider;
-use DB;
 
 class EpicController extends Controller
 {

src/Http/Api/EventsController.php

Doc Comments -1 removed lines

@@ -141,7 +141,6 @@
      * set notifications
      *
      * @param  string $project_key
-     * @param  string $event_id
      * @return array
      */
     public function setNotify(Request $request, $project_key, $id)

Unused Use Statements +2 added lines, -3 removed lines

@@ -4,10 +4,9 @@
 
 use Illuminate\Http\Request;
 
-use Fabrica\Http\Requests;
-use Fabrica\Http\Api\Controller;
-use Fabrica\Customization\Eloquent\Events;
 use Fabrica\Customization\Eloquent\EventNotifications;
+use Fabrica\Customization\Eloquent\Events;
+use Fabrica\Http\Api\Controller;
 use Fabrica\Project\Provider;
 
 class EventsController extends Controller

src/Http/Api/ExternalUsersController.php

Doc Comments -1 removed lines

@@ -26,7 +26,6 @@
     /**
      * handle the external user.
      *
-     * @param  int  $id
      * @return \Illuminate\Http\Response
      */
     public function handle(Request $request, $project_key)

Unused Use Statements -4 removed lines

@@ -3,12 +3,8 @@
 
 use Illuminate\Http\Request;
 
-use Fabrica\Http\Requests;
 use Fabrica\Http\Api\Controller;
 use Fabrica\Project\Eloquent\ExternalUsers;
-use Fabrica\Project\Eloquent\Project;
-use Fabrica\Project\Provider;
-use DB;
 
 class ExternalUsersController extends Controller
 {