SprintController - Code Metrics - Inspection of "fix bug" - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( ab60f2...c901a1 )

by Ricardo
created 2020-09-09 10:57 UTC
SprintController F

↳ Parent: Project
Complexity

Total Complexity
140
Size/Duplication

Total Lines	726
Duplicated Lines	15.84 %
Coupling/Cohesion

Components	1
Dependencies	3
Importance

Changes
Metric	Value
wmc	140
lcom	1
cbo	3
dl	115
loc	726
rs	1.874
c	0
b	0
f	0
19 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	3	1
A	store()	0	12	1
C	moveIssue()	36	62	16
A	show()	0	10	2
D	publish()	16	91	19
B	update()	0	32	8
C	complete()	10	60	14
B	destroy()	10	36	11
A	getValidSprintList()	0	17	3
A	pushSprint()	17	17	4
A	popSprint()	17	17	4
B	getLastColumnStates()	9	16	7
A	filterIssues()	0	24	4
A	getOriginIssues()	0	13	4
F	getLog()	0	90	16
B	getWorkingDay()	0	23	6
B	t2m()	0	31	10
B	getRemainingTime()	0	40	9
How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class
Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.
Complex classes like SprintController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SprintController, and based on these observations, apply Extract Interface, too.
<?php
namespace Fabrica\Http\Api;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Event;

use Fabrica\Http\Requests;
use Fabrica\Http\Api\Controller;
use Fabrica\Project\Eloquent\Sprint;
use Fabrica\Project\Eloquent\SprintDayLog;
use Fabrica\Project\Eloquent\Board;
use Fabrica\Project\Provider;
use Fabrica\Events\SprintEvent;
use Fabrica\System\Eloquent\CalendarSingular;
use DB;

class SprintController extends Controller
{
    public function __construct()
    {
        $this->middleware('privilege:manage_project', [ 'except' => [ 'show', 'getLog' ] ]);
        parent::__construct();
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index($project_key)
    {
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request, $project_key)
    {
        $sprint_count = Sprint::where('project_key', $project_key)->count();
        $sprint = Sprint::create([ 
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            'project_key' => $project_key, 
            'no' => $sprint_count + 1, 
            'name' => 'Sprint ' . ($sprint_count + 1),
            'status' => 'waiting', 
            'issues' => [] 
        ]);
        return Response()->json(['ecode' => 0, 'data' => $this->getValidSprintList($project_key)]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function moveIssue(Request $request, $project_key)
    {
        $issue_no = $request->input('issue_no');
        if (!$issue_no)
        {
            throw new \UnexpectedValueException('the moved issue cannot be empty', -11700);
        }

        $src_sprint_no = $request->input('src_sprint_no');
        if (!isset($src_sprint_no))
        {
            throw new \UnexpectedValueException('the src sprint of moved issue cannot be empty', -11701);
        }
        $src_sprint_no = intval($src_sprint_no);

        $dest_sprint_no = $request->input('dest_sprint_no');
        if (!isset($dest_sprint_no))
        {
            throw new \UnexpectedValueException('the dest sprint of moved issue cannot be empty', -11702);
        }
        $dest_sprint_no = intval($dest_sprint_no);

        if ($src_sprint_no > 0)

        {
            $src_sprint = Sprint::where('project_key', $project_key)->where('no', $src_sprint_no)->first(); 
            if (!in_array($issue_no, $src_sprint->issues ?: []))
            {
                throw new \UnexpectedValueException('the moved issue cannot be found in the src sprint', -11703);
            }
            if ($src_sprint->status == 'completed')
            {
                throw new \UnexpectedValueException('the moved issue cannot be moved into or moved out of the completed sprint', -11706);
            }
            $src_sprint->fill([ 'issues' => array_values(array_diff($src_sprint->issues, [ $issue_no ]) ?: []) ])->save();

            if ($src_sprint->status == 'active')
            {
                $this->popSprint($project_key, $issue_no, $src_sprint_no);
            }
        }

        if ($dest_sprint_no > 0)

        {
            $dest_sprint = Sprint::where('project_key', $project_key)->where('no', $dest_sprint_no)->first();
            if (in_array($issue_no, $dest_sprint->issues ?: []))
            {
                throw new \UnexpectedValueException('the moved issue has been in the dest sprint', -11704);
            }
            if ($dest_sprint->status == 'completed')
            {
                throw new \UnexpectedValueException('the moved issue cannot be moved into or moved out of the completed sprint', -11706);
            }
            $dest_sprint->fill([ 'issues' => array_values(array_merge($dest_sprint->issues ?: [], [ $issue_no ])) ])->save();

            if ($dest_sprint->status == 'active')
            {
                $this->pushSprint($project_key, $issue_no, $dest_sprint_no);
            }
        }

        return Response()->json([ 'ecode' => 0, 'data' => $this->getValidSprintList($project_key) ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($project_key, $no)
    {
        $sprint = Sprint::where('project_key', $project_key)->where('no', intval($no))->first();
        if (!$sprint->name)
        {
            $sprint->name = 'Sprint ' . $sprint->no;
        }

        return Response()->json(['ecode' => 0, 'data' => $sprint]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * publish the sprint.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function publish(Request $request, $project_key, $no)
    {
        if (!$no)
        {
            throw new \UnexpectedValueException('the published sprint cannot be empty', -11705);
        }
        $no = intval($no);

        $active_sprint_exists = Sprint::where('project_key', $project_key)
            ->where('status', 'active')
            ->exists();
        if ($active_sprint_exists)
        {
            throw new \UnexpectedValueException('the active sprint has been exists.', -11706);
        }

        $before_waiting_sprint_exists = Sprint::where('project_key', $project_key)
            ->where('status', 'waiting')
            ->where('no', '<', $no)
            ->exists();
        if ($before_waiting_sprint_exists)
        {
            throw new \UnexpectedValueException('the more first sprint has been exists.', -11707);
        }

        $sprint = Sprint::where('project_key', $project_key)
            ->where('no', $no)
            ->first();
        if (!$sprint || $project_key != $sprint->project_key)
        {
            throw new \UnexpectedValueException('the sprint does not exist or is not in the project.', -11708);
        }

        $updValues = [ 'status' => 'active' ];

        $start_time = $request->input('start_time');
        if (isset($start_time) && $start_time)

        {
            $updValues['start_time'] = $start_time;
        }
        else
        {
            throw new \UnexpectedValueException('the sprint start time cannot be empty.', -11709);
        }

        $complete_time = $request->input('complete_time');
        if (isset($complete_time) && $complete_time)

        {
            $updValues['complete_time'] = $complete_time;
        }
        else
        {
            throw new \UnexpectedValueException('the sprint complete time cannot be empty.', -11710);
        }

        $name = $request->input('name');
        if (isset($name) && $name)
        {
            $updValues['name'] = $name;
        }

        $description = $request->input('description');
        if (isset($description) && $description)
        {
            $updValues['description'] = $description;
        }

        $kanban_id = $request->input('kanban_id');
        if (!isset($kanban_id) || !$kanban_id)
        {
            throw new \UnexpectedValueException('the kanban id cannot be empty', -11717);
        }

        $new_issues = $this->filterIssues($project_key, isset($sprint->issues) ? $sprint->issues : [], $kanban_id);

        $updValues['issues'] = $new_issues['issues'];
        $updValues['origin_issues'] = $new_issues['origin_issues'];

        $sprint->fill($updValues)->save();

        foreach ($new_issues['issues'] as $issue_no)
        {
            $this->pushSprint($project_key, $issue_no, $no);
        }

        $isSendMsg = $request->input('isSendMsg') && true;
        $user = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        Event::fire(new SprintEvent($project_key, $user, [ 'event_key' => 'start_sprint', 'isSendMsg' => $isSendMsg, 'data' => [ 'sprint_no' => $no ] ]));

        return Response()->json([ 'ecode' => 0, 'data' => $this->getValidSprintList($project_key) ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * edit the sprint.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $project_key, $no)
    {
        if (!$no)
        {
            throw new \UnexpectedValueException('the updated sprint cannot be empty', -11718);
        }
        $no = intval($no);

        $sprint = Sprint::where('project_key', $project_key)->where('no', $no)->first();
        if (!$sprint || $project_key != $sprint->project_key)
        {
            throw new \UnexpectedValueException('the sprint does not exist or is not in the project.', -11708);
        }

        $updValues = [];

        $name = $request->input('name');
        if (isset($name) && $name)
        {
            $updValues['name'] = $name;
        }

        $description = $request->input('description');
        if (isset($description) && $description)
        {
            $updValues['description'] = $description;
        }

        $sprint->fill($updValues)->save();

        return Response()->json([ 'ecode' => 0, 'data' => $this->getValidSprintList($project_key) ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * publish the sprint.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function complete(Request $request, $project_key, $no)
    {
        if (!$no)
        {
            throw new \UnexpectedValueException('the completed sprint cannot be empty', -11711);
        }
        $no = intval($no);

        $sprint = Sprint::where('project_key', $project_key)->where('no', $no)->first();
        if (!$sprint || $project_key != $sprint->project_key)
        {
            throw new \UnexpectedValueException('the sprint does not exist or is not in the project.', -11708);
        }

        if (!isset($sprint->status) || $sprint->status != 'active')

        {
            throw new \UnexpectedValueException('the completed sprint must be active.', -11712);
        }

        $completed_issues = $request->input('completed_issues') ?: [];
        if (array_diff($completed_issues, $sprint->issues))
        {
            throw new \UnexpectedValueException('the completed sprint issues have errors.', -11713);
        }

        $incompleted_issues = array_values(array_diff($sprint->issues, $completed_issues));

        $valid_incompleted_issues = DB::collection('issue_' . $project_key)->whereIn('no', $incompleted_issues)->where('del_flg', '<>', 1)->get([ 'no' ]);
        if ($valid_incompleted_issues)
        {
    	    $valid_incompleted_issues = array_column($valid_incompleted_issues, 'no');
    	    $incompleted_issues = array_values(array_intersect($incompleted_issues, $valid_incompleted_issues));
        }

        $updValues = [ 
            'status' => 'completed', 
            'real_complete_time' => time(), 
            'completed_issues' => $completed_issues,
            'incompleted_issues' => $incompleted_issues 
        ];

        $sprint->fill($updValues)->save();

        if ($incompleted_issues)

        {
            $next_sprint = Sprint::where('project_key', $project_key)->where('status', 'waiting')->orderBy('no', 'asc')->first();
            if ($next_sprint)

            {
                $issues = !isset($next_sprint->issues) || !$next_sprint->issues ? [] : $next_sprint->issues;
                $issues = array_merge($incompleted_issues, $issues);
                $next_sprint->fill([ 'issues' => $issues ])->save();
            }
        }

        $isSendMsg = $request->input('isSendMsg') && true;
        $user = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        Event::fire(new SprintEvent($project_key, $user, [ 'event_key' => 'complete_sprint', 'isSendMsg' => $isSendMsg, 'data' => [ 'sprint_no' => $no ] ]));

        return Response()->json([ 'ecode' => 0, 'data' => $this->getValidSprintList($project_key) ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($project_key, $no)
    {
        if (!$no)
        {
            throw new \UnexpectedValueException('the deleted sprint cannot be empty', -11714);
        }
        $no = intval($no);

        $sprint = Sprint::where('project_key', $project_key)->where('no', $no)->first();
        if (!$sprint || $project_key != $sprint->project_key)
        {
            throw new \UnexpectedValueException('the sprint does not exist or is not in the project.', -11708);
        }

        if ($sprint->status == 'completed' || $sprint->status == 'active')

	{
            throw new \UnexpectedValueException('the active or completed sprint cannot be removed.', -11715);
        }

        if (isset($sprint->issues) && $sprint->issues)
        {
            $next_sprint = Sprint::where('project_key', $project_key)->where('no', '>', $no)->first();
            if ($next_sprint)

            {
                $issues = !isset($next_sprint->issues) || !$next_sprint->issues ? [] : $next_sprint->issues;
                $issues = array_merge($sprint->issues, $issues);
                $next_sprint->fill([ 'issues' => $issues ])->save();
            }
        }

        $sprint->delete();

        Sprint::where('project_key', $project_key)->where('no', '>', $no)->decrement('no');

        return Response()->json([ 'ecode' => 0, 'data' => $this->getValidSprintList($project_key) ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * get waiting or active sprint list.
     *
     * @param  string  $project_key
     * @return array 
     */
    public function getValidSprintList($project_key)
    {
        $sprints = Sprint::where('project_key', $project_key)
            ->whereIn('status', [ 'active', 'waiting' ])
            ->orderBy('no', 'asc')
            ->get();

        foreach ($sprints as $sprint)
        {
            if (!$sprint->name)
            {
                $sprint->name = 'Sprint ' . $sprint->no;
            }
        }

        return $sprints;
    }

    /**
     * push sprint to issue detail.
     *
     * @param  string  $project_key
     * @param  string  $issue_no
     * @param  string  $sprint_no
     * @return void 
     */
    public function pushSprint($project_key, $issue_no, $sprint_no)

    {
        $issue = DB::collection('issue_' . $project_key)->where('no', $issue_no)->first();
        if (!$issue)
        {
            return;
        }

        $sprints = [];
        if (isset($issue['sprints']) && $issue['sprints'])
        {
            $sprints = $issue['sprints'];
        }
        array_push($sprints, $sprint_no);

        DB::collection('issue_' . $project_key)->where('no', $issue_no)->update(['sprints' => $sprints]);
    }

    /**
     * pop sprint from issue detail.
     *
     * @param  string  $project_key
     * @param  string  $issue_no
     * @param  string  $sprint_no
     * @return void 
     */
    public function popSprint($project_key, $issue_no, $sprint_no)

    {
        $issue = DB::collection('issue_' . $project_key)->where('no', $issue_no)->first();
        if (!$issue)
        {
            return;
        }

        $sprints = [];
        if (isset($issue['sprints']) && $issue['sprints'])
        {
            $sprints = $issue['sprints'];
        }
        $new_sprints = array_diff($sprints, [ $sprint_no ]);

        DB::collection('issue_' . $project_key)->where('no', $issue_no)->update(['sprints' => $new_sprints]);
    }

   /**
     * get the last column state of the kanban.
     *
     * @param  string $kanban_id
     * @return array 
     */
    public function getLastColumnStates($kanban_id)
    {
        // remaining start
        $last_column_states = [];
        $board = Board::find($kanban_id);
        if ($board && isset($board->columns))

        {
            $board_columns = $board->columns;
            $last_column = array_pop($board_columns) ?: [];
            if ($last_column && isset($last_column['states']) && $last_column['states'])
            {
                $last_column_states = $last_column['states'];
            }
        }
        return $last_column_states; 
    }

   /**
     * get sprint original state.
     *
     * @param  string $project_key
     * @param  array  $issue_nos
     * @param  string $kanban_id
     * @return array
     */
    public function filterIssues($project_key, $issue_nos, $kanban_id)
    {
        // get the kanban last column states
        $last_column_states = $this->getLastColumnStates($kanban_id);

        $new_issue_nos = [];
        $origin_issues = [];

        $issues = DB::collection('issue_' . $project_key)
            ->where([ 'no' => [ '$in' => $issue_nos ] ])
            ->where([ 'state' => [ '$nin' => $last_column_states ] ])
            ->get();
        foreach ($issues as $issue)
        {
            $new_issue_nos[] = $issue['no'];

            $origin_issues[] = [
                'no' => $issue['no'],
                'state' => isset($issue['state']) ? $issue['state'] : '',
                'story_points' => isset($issue['story_points']) ? $issue['story_points'] : 0 ];
        }

        return [ 'issues' => $new_issue_nos, 'origin_issues' => $origin_issues ];
    }

   /**
     * get sprint original state.
     *
     * @param  string $project_key 
     * @param  array  $issue_nos
     * @return array 
     */
    public function getOriginIssues($project_key, $issue_nos)
    {
        $origin_issues = [];
        $issues = DB::collection('issue_' . $project_key)->where([ 'no' => [ '$in' => $issue_nos ] ])->get();
        foreach ($issues as $issue)
        {
            $origin_issues[] = [ 
                'no' => $issue['no'], 
                'state' => isset($issue['state']) ? $issue['state'] : '', 
                'story_points' => isset($issue['story_points']) ? $issue['story_points'] : 0 ];
        }
        return $origin_issues;
    }

    /**
     * get sprint log.
     *
     * @param  string  $project_key
     * @param  string  $sprint_no
     * @return \Illuminate\Http\Response
     */
    public function getLog(Request $request, $project_key, $sprint_no)
    {
        $sprint_no = intval($sprint_no);

        $kanban_id = $request->input('kanban_id');
        if (!$kanban_id)
        {
            throw new \UnexpectedValueException('the kanban id cannot be empty', -11717);
        }

        $sprint = Sprint::where('project_key', $project_key)
            ->where('no', $sprint_no)
            ->first();
        if (!$sprint)
        {
            throw new \UnexpectedValueException('the sprint does not exist or is not in the project.', -11708);
        }

        $origin_issue_count = 0;
        if (isset($sprint->origin_issues))
        {
            $origin_issue_count = count($sprint->origin_issues); 
        }
        $origin_story_points = 0;
        if (isset($sprint->origin_issues))
        {
            foreach ($sprint->origin_issues as $val)
            {
                $origin_story_points += $val['story_points']; 
            }
        }

        $workingDays = $this->getWorkingDay($sprint->start_time, $sprint->complete_time); 
        $workingDayNum = 0;
        foreach ($workingDays as $val)
        {
            $workingDayNum += $val;
        }

        // guideline start
        $issue_count_guideline = [];
        $story_points_guideline = [];
        $issue_count_guideline[] = [ 'day' => '', 'value' => $origin_issue_count ];
        $story_points_guideline[] = [ 'day' => '', 'value' => $origin_story_points ];
        $tmp_issue_count = $origin_issue_count;
        $tmp_story_points = $origin_story_points;
        foreach ($workingDays as $day => $flag)
        {
            if ($flag === 1)
            {
                $tmp_issue_count = max([ round($tmp_issue_count - $origin_issue_count / $workingDayNum, 2), 0 ]);
                $tmp_story_points = max([ round($tmp_story_points - $origin_story_points / $workingDayNum, 2), 0 ]);
            }
            $issue_count_guideline[] = [ 'day' => substr($day, 5), 'value' => $tmp_issue_count, 'notWorking' => ($flag + 1) % 2 ];
            $story_points_guideline[] = [ 'day' => substr($day, 5), 'value' => $tmp_story_points, 'notWorking' => ($flag + 1) % 2 ];
        }
        // guideline end 

        // remaining start
        $last_column_states = $this->getLastColumnStates($kanban_id);

        $sprint_day_log = SprintDayLog::where('project_key', $project_key)
            ->where('no', $sprint_no)
            ->orderBy('day', 'asc')
            ->get();

        $issue_count_remaining = [];
        $story_points_remaining = [];
	$issue_count_remaining[] = [ 'day' => '', 'value' => $origin_issue_count ];
	$story_points_remaining[] = [ 'day' => '', 'value' => $origin_story_points ];
        foreach($sprint_day_log as $daylog)
        {
            $incompleted_issue_num = 0;
            $incompleted_story_points = 0;
            $issues = isset($daylog->issues) ? $daylog->issues : []; 
            foreach ($issues as $issue)
            {
                if (!in_array($issue['state'], $last_column_states))
                {
                    $incompleted_issue_num++;
                    $incompleted_story_points += isset($issue['story_points']) ? $issue['story_points'] : 0;
                } 
            }
            $issue_count_remaining[] = [ 'day' => substr($daylog->day, 5), 'value' => $incompleted_issue_num, 'notWorking' => isset($workingDays[$daylog->day]) ? ($workingDays[$daylog->day] + 1) % 2 : 0 ]; 
            $story_points_remaining[] = [ 'day' => substr($daylog->day, 5), 'value' => $incompleted_story_points, 'notWorking' => isset($workingDays[$daylog->day]) ? ($workingDays[$daylog->day] + 1) % 2 : 0 ]; 
        }
        // remaining start

        return Response()->json([ 'ecode' => 0, 'data' => [ 'issue_count' => [ 'guideline' => $issue_count_guideline, 'remaining' => $issue_count_remaining ], 'story_points' => [ 'guideline' => $story_points_guideline, 'remaining' => $story_points_remaining ] ] ]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * get working day flag.
     *
     * @param  int  $start_time
     * @param  int  $complete_time
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function getWorkingDay($start_time, $end_time)
    {
        $days = [];
        $tmp_time = $start_time;
        while ($tmp_time < $end_time)
        {
            $day = date('Y/m/d', $tmp_time);
            $days[] = $day;

            $week_flg = intval(date('w', $tmp_time));
            $workingDays[$day] = ($week_flg === 0 || $week_flg === 6) ? 0 : 1;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

            $tmp_time += 24 * 60 * 60;
        }

        $singulars = CalendarSingular::where([ 'date' => [ '$in' => $days ] ])->get();
        foreach ($singulars as $singular)
        {
            $tmp = $singular->date;
            $workingDays[$tmp] = $singular->type == 'holiday' ? 0 : 1;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
        return $workingDays;
    }

    public function t2m($val, $options) 
    {
        $w2d = isset($options['w2d']) ? $options['w2d'] : 5;
        $d2h = isset($options['d2h']) ? $options['d2h'] : 8;

        $total = 0;
        $tmp = explode(' ', $val);
        foreach ($tmp as $v)
        {
            $t = substr($v, 0, strlen($v) - 1);
            $u = substr($v, -1);

            if ($u == 'w' || $u == 'W')
            {
                $total += $total + $t * $w2d * $d2h;
            }
            else if ($u == 'd' || $u == 'D')
            {
                $total += $t * $d2h * 60;
            }
            else if ($u == 'h' || $u == 'H')
            {
                $total += $t * 60;
            }
            else 
            {
                $total += $t;
            }
        }
        return $total;
    }

    public function getRemainingTime($issue_no)
    {
        $origin_estimate_time = 0;
        $issue = DB::where('no', $issue_no)->first();
        if (isset($issue['original_estimate']))
        {
            $origin_estimate_time = $issue['original_estimate'];
        }

        $leave_estimate_m = $this->t2m($origin_estimate_time);
        if ($leave_estimate_m <= 0)
        {
            return 0;
        }

        $worklogs = Worklog::Where('project_key', $project_key)

            ->where('issue_id', $issue_id)

            ->orderBy('recorded_at', 'asc')
            ->get();

        foreach ($worklogs as $worklog)
        {
            if (!isset($worklog['spend']))
            {
                continue;
            }
            if (isset($worklog['adjust_type']))
            {
                if ($worklog['adjust_type'] == 1)
                {
                    $spend_m = $this->t2m($worklog['spend']);
                    $leave_estimate_m = $leave_estimate_m - $spend_m;
                }
                else if ($worklog['adjust_type'] == 3)
                {
                    $leave_estimate_m = $this->t2m(isset($worklog['cut']) ? $worklog['cut'] : 0);
                }
            }
        }
    }
}

Push — master ( ab60f2...c901a1 )

SprintController F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

SierraTecnologia / fabrica

Push — master ( ab60f2...c901a1 )

SprintController F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
