Fabrica\Http\Api\DocumentController

Complexity

Total Complexity

136

Size/Duplication

Total Lines	893
Duplicated Lines	39.75 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

18 Methods

Rating	Name	Duplication	Size	Complexity
B	searchPath()	52	52	9
A	getDirChildren()	0	16	2
A	getDirTree()	10	37	5
B	addChildren2Tree()	21	30	7
A	getOptions()	0	9	1
F	index()	38	111	22
B	createFolder()	52	52	7
A	getParentTree()	16	16	2
C	update()	37	61	13
D	move()	32	90	21
B	destroy()	18	35	9
F	upload()	45	123	19
A	downloadThumbnails()	0	21	3
A	download()	0	21	4
A	downloadFolder()	0	18	1
A	contructFolder()	0	25	5
A	downloadFile()	11	11	2
A	favorite()	23	23	4

<?php

namespace Fabrica\Http\Api;

use Illuminate\Http\Request;

use Fabrica\Http\Requests;
use Fabrica\Http\Api\Controller;
use Fabrica\Events\DocumentEvent;
use Fabrica\Project\Eloquent\DocumentFavorites;
use Fabrica\Acl\Acl;
use DB;
use Fabrica\Utils\File;

use MongoDB\BSON\ObjectID;
use Zipper;

class DocumentController extends Controller
{
    /**
     * search path.
     * @param  \Illuminate\Http\Request  $request
     * @param  string  $project_key
     * @return \Illuminate\Http\Response
     */
    public function searchPath(Request $request, $project_key)

This method seems to be duplicated in your project.

    {
        $s =  $request->input('s');
        if (!$s)
        {
            return Response()->json(['ecode' => 0, 'data' => []]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

        }

        if ($s === '/')
        {
            return Response()->json(['ecode' => 0, 'data' => [ [ 'id' => '0', 'name' => '/' ] ] ]);
        }

        $query = DB::collection('document_' . $project_key)
            ->where('d', 1)
            ->where('del_flag', '<>', 1)
            ->where('name', 'like', '%' . $s . '%');

        $moved_path = $request->input('moved_path');
        if (isset($moved_path) && $moved_path)
        {
            $query->where('pt', '<>', $moved_path);
            $query->where('_id', '<>', $moved_path);
        }

        $directories = $query->take(20)->get(['name', 'pt']);

        $ret = [];
        foreach ($directories as $d)
        {
            $parents = [];
            $path = '';
            $ps = DB::collection('document_' . $project_key)
                ->whereIn('_id', $d['pt'])
                ->get([ 'name' ]);
            foreach ($ps as $val)
            {
                $parents[$val['_id']->__toString()] = $val['name'];
            }

            foreach ($d['pt'] as $pid)
            {
                if (isset($parents[$pid]))
                {
                    $path .= '/' . $parents[$pid];
                }
            }
            $path .= '/' . $d['name'];
            $ret[] = [ 'id' => $d['_id']->__toString(), 'name' => $path ];
        }
        return Response()->json(['ecode' => 0, 'data' => parent::arrange($ret)]);

It seems like you call parent on a different method (arrange() instead of searchPath()). Are you sure this is correct? If so, you might want to change this to $this->arrange().

    }

    /**
     * get the directory children.
     * @param  string  $project_key
     * @param  string  $directory
     * @return \Illuminate\Http\Response
     */
    public function getDirChildren(Request $request, $project_key, $directory)
    {
        $sub_dirs = DB::collection('document_' . $project_key)
    	    ->where('parent', $directory)
            ->where('d', 1)
            ->where('del_flag', '<>', 1)
            ->get();

    	$res = [];
    	foreach ($sub_dirs as $val) 
        {
    	    $res[] = [ 'id' => $val['_id']->__toString(), 'name' => $val['name'] ];
        }

    	return Response()->json([ 'ecode' => 0, 'data' => $res ]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }

    /**
     * get the directory tree.
     * @param  string  $project_key
     * @return \Illuminate\Http\Response
     */
    public function getDirTree(Request $request, $project_key)
    {
        $dt = [ 'id' => '0', 'name' => '根目录' ];

        $curdir = $request->input('currentdir');
        if (!$curdir)
        {
            $curdir = '0';
        }

        $pt = [ '0' ];
        if ($curdir !== '0')
        {
            $node = DB::collection('document_' . $project_key)
                ->where('_id', $curdir)
    	        ->first();

    	    if ($node)
    	    {
    	        $pt = $node['pt'];
    	        array_push($pt, $curdir);
            }
        }

    	foreach($pt as $val)

This code seems to be duplicated across your project.

    	{
            $sub_dirs = DB::collection('document_' . $project_key)
                ->where('parent', $val)
    	        ->where('d', 1)
    	        ->where('del_flag', '<>', 1)
    	        ->get();

    	    $this->addChildren2Tree($dt, $val, $sub_dirs);
        }

    	return Response()->json([ 'ecode' => 0, 'data' => $dt ]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }

    /**
     * add children to tree.
     *
     * @param  array  $dt
     * @param  string $parent_id
     * @param  array  $sub_dirs
     * @return void
     */
    public function addChildren2Tree(&$dt, $parent_id, $sub_dirs)
    {
        $new_dirs = [];
        foreach($sub_dirs as $val)
        {
            $new_dirs[] = [ 'id' => $val['_id']->__toString(), 'name' => $val['name'] ];
        }

        if ($dt['id'] == $parent_id)

This code seems to be duplicated across your project.

        {
            $dt['children'] = $new_dirs;
            return true;
        }
        else
        {
            if (isset($dt['children']) && $dt['children'])
            {
                $children_num = count($dt['children']);
                for ($i = 0; $i < $children_num; $i++)
                {
                    $res = $this->addChildren2Tree($dt['children'][$i], $parent_id, $sub_dirs);
                    if ($res === true)
                    {
                        return true;
                    }
                }
            }
            return false;
        }
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function getOptions(Request $request, $project_key)
    {
        $uploaders = DB::collection('document_' . $project_key)
            ->where('del_flag', '<>' , 1)
            ->distinct('uploader')
            ->get([ 'uploader' ]);

        return Response()->json(['ecode' => 0, 'data' => [ 'uploader' => $uploaders ]]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request, $project_key, $directory)
    {
        $documents = [];

$documents is not used, you could remove the assignment.

        $mode = 'list';
        $query = DB::collection('document_' . $project_key);

        $uploader_id = $request->input('uploader_id');
        if (isset($uploader_id) && $uploader_id)
        {
            $mode = 'search';
            $query->where('uploader.id', $uploader_id == 'me' ? $this->user->id : $uploader_id);
        }

        $name = $request->input('name');
        if (isset($name) && $name)

This code seems to be duplicated across your project.

        {
            $mode = 'search';
            $query = $query->where('name', 'like', '%' . $name . '%');
        }

        $uploaded_at = $request->input('uploaded_at');
        if (isset($uploaded_at) && $uploaded_at)
        {
            $mode = 'search';
            $unitMap = [ 'w' => 'week', 'm' => 'month', 'y' => 'year' ];
            $unit = substr($uploaded_at, -1);
            $val = abs(substr($uploaded_at, 0, -1));
            $query->where('uploaded_at', '>=', strtotime(date('Ymd', strtotime('-' . $val . ' ' . $unitMap[$unit]))));
        }

        $favorite_documents = DocumentFavorites::where('project_key', $project_key)
            ->where('user.id', $this->user->id)
            ->get()
            ->toArray();
        $favorite_dids = array_column($favorite_documents, 'did');

        $myfavorite = $request->input('myfavorite');
        if (isset($myfavorite) && $myfavorite == '1') 

This code seems to be duplicated across your project.

        {
            $mode = 'search';
            $favoritedIds = [];
            foreach ($favorite_dids as $did)
            {
                $favoritedIds[] = new ObjectID($did);
            }

            $query->whereIn('_id', $favoritedIds);
        }

        if ($directory !== '0')

This code seems to be duplicated across your project.

        {
            $query = $query->where($mode === 'search' ? 'pt' : 'parent', $directory);
        }
        else
        {
            if ($mode === 'list')
            {
                $query = $query->where('parent', $directory);
            }
        }

        $query->where('del_flag', '<>', 1);
        $query->orderBy('d', 'desc')->orderBy('_id', 'desc');

        $limit = 1000; // fix me
        $query->take($limit);
        $documents = $query->get();

        foreach ($documents as $k => $d)

This code seems to be duplicated across your project.

        {
            if (in_array($d['_id']->__toString(), $favorite_dids))
            {
                $documents[$k]['favorited'] = true;
            }
        }

        $path = [];
        if ($directory === '0')
        {
            $path[] = [ 'id' => '0', 'name' => 'root' ];
        }
        else
        {
            $path[] = [ 'id' => '0', 'name' => 'root' ];
            $d = DB::collection('document_' . $project_key)
                ->where('_id', $directory)
                ->first();
            if ($d && isset($d['pt']))
            {
                $parents = [];
                $ps = DB::collection('document_' . $project_key)
                    ->whereIn('_id', $d['pt'])
                    ->get([ 'name' ]);
                foreach ($ps as $val)
                {
                    $parents[$val['_id']->__toString()] = $val['name'];
                }

                foreach ($d['pt'] as $pid)
                {
                    if (isset($parents[$pid]))

This code seems to be duplicated across your project.

                    {
                        $path[] = [ 'id' => $pid, 'name' => $parents[$pid] ];
                    }
                }
            }
            $path[] = [ 'id' => $directory, 'name' => $d['name'] ];
        }

        return Response()->json([ 'ecode' => 0, 'data' => parent::arrange($documents), 'options' => [ 'path' => $path ] ]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

It seems like you call parent on a different method (arrange() instead of index()). Are you sure this is correct? If so, you might want to change this to $this->arrange().

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string  $project_key
     * @return \Illuminate\Http\Response
     */
    public function createFolder(Request $request, $project_key)

This method seems to be duplicated in your project.

    {
        $insValues = [];

        $parent = $request->input('parent');
        if (!isset($parent))
        {
            throw new \UnexpectedValueException('the parent directory can not be empty.', -11905);
        }
        $insValues['parent'] = $parent;

        if ($parent !== '0')
        {
            $isExists = DB::collection('document_' . $project_key)
                ->where('_id', $parent)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->exists();
            if (!$isExists)
            {
                throw new \UnexpectedValueException('the parent directory does not exist.', -11906);
            }
        }

        $name =  $request->input('name');
        if (!isset($name) || !$name)
        {
            throw new \UnexpectedValueException('the name can not be empty.', -11900);
        }
        $insValues['name'] = $name;

        $isExists = DB::collection('document_' . $project_key)
            ->where('parent', $parent)
            ->where('name', $name)
            ->where('d', 1)
            ->where('del_flag', '<>', 1)
            ->exists();
        if ($isExists)
        {
            throw new \UnexpectedValueException('the name cannot be repeated.', -11901);
        }

        $insValues['pt'] = $this->getParentTree($project_key, $parent);
        $insValues['d'] = 1;
        $insValues['creator'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        $insValues['created_at'] = time();

        $id = DB::collection('document_' . $project_key)->insertGetId($insValues);

        $document = DB::collection('document_' . $project_key)->where('_id', $id)->first();
        return Response()->json(['ecode' => 0, 'data' => parent::arrange($document)]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

It seems like you call parent on a different method (arrange() instead of createFolder()). Are you sure this is correct? If so, you might want to change this to $this->arrange().

    }

    /**
     * get parent treee.
     * @param  string  $project_key
     * @param  string  $directory
     * @return array
     */
    public function getParentTree($project_key, $directory)

This method seems to be duplicated in your project.

    {
        $pt = [];

$pt is not used, you could remove the assignment.

        if ($directory === '0')
        {
            $pt = [ '0' ];
        }
        else
        {
            $d = DB::collection('document_' . $project_key)
                ->where('_id', $directory)
                ->first();
            $pt = array_merge($d['pt'], [ $directory ]);
        }
        return $pt;
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string  $project_key
     * @param  string  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $project_key, $id)
    {
        $name = $request->input('name');
        if (!isset($name) || !$name)
        {
            throw new \UnexpectedValueException('the name can not be empty.', -11900);
        }

        $old_document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$old_document)
        {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        if (isset($old_document['d']) && $old_document['d'] === 1)

This code seems to be duplicated across your project.

        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project')) 
            {
                return Response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

            }
        }
        else
        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project') && $old_document['uploader']['id'] !== $this->user->id) 
            {
                return Response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
            }
        }

        if ($old_document['name'] !== $name)

This code seems to be duplicated across your project.

        {
            $query = DB::collection('document_' . $project_key)
                ->where('parent', $old_document['parent'])
                ->where('name', $name)
                ->where('del_flag', '<>', 1);

            if (isset($old_document['d']) && $old_document['d'] === 1)
            {
                $query->where('d', 1);
            }
            else
            {
                $query->where('d', '<>', 1);
            }

            $isExists = $query->exists();

            if ($isExists)
            {
                throw new \UnexpectedValueException('the name cannot be repeated.', -11901);
            }
        }

        DB::collection('document_' . $project_key)->where('_id', $id)->update([ 'name' => $name ]);
        $new_document = DB::collection('document_' . $project_key)->where('_id', $id)->first();

        return Response()->json(['ecode' => 0, 'data' => parent::arrange($new_document)]);

It seems like you call parent on a different method (arrange() instead of update()). Are you sure this is correct? If so, you might want to change this to $this->arrange().

    }

    /**
     * move the document.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string  $project_key
     * @return \Illuminate\Http\Response
     */
    public function move(Request $request, $project_key)
    {
        $id =  $request->input('id');
        if (!isset($id) || !$id)
        {
            throw new \UnexpectedValueException('the move object can not be empty.', -11911);
        }

        $dest_path =  $request->input('dest_path');
        if (!isset($dest_path))
        {
            throw new \UnexpectedValueException('the dest directory can not be empty.', -11912);
        }

        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$document)
        {
            throw new \UnexpectedValueException('the move object does not exist.', -11913);
        }

        if (isset($document['d']) && $document['d'] === 1)

This code seems to be duplicated across your project.

        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project'))
            {
                return Response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

            }
        }
        else
        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project') && $document['uploader']['id'] !== $this->user->id)
            {
                return Response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
            }
        }

        $dest_directory = [];
        if ($dest_path !== '0')
        {
            $dest_directory = DB::collection('document_' . $project_key)
                ->where('_id', $dest_path)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->first();
            if (!$dest_directory)
            {
                throw new \UnexpectedValueException('the dest directory does not exist.', -11914);
            }
        }

        $isExists = DB::collection('document_' . $project_key)
            ->where('parent', $dest_path)
            ->where('name', $document['name'])
            ->where('d', isset($document['d']) && $document['d'] === 1 ? '=' : '<>', 1)
            ->where('del_flag', '<>', 1)
            ->exists();
        if ($isExists)
        {
            throw new \UnexpectedValueException('the name cannot be repeated.', -11901);
        }

        $updValues = [];
        $updValues['parent'] = $dest_path;
        $updValues['pt'] = array_merge(isset($dest_directory['pt']) ? $dest_directory['pt'] : [], [$dest_path]);
        DB::collection('document_' . $project_key)->where('_id', $id)->update($updValues);

        if (isset($document['d']) && $document['d'] === 1) 

This code seems to be duplicated across your project.

        {
            $subs = DB::collection('document_' . $project_key)
                ->where('pt', $id)
                ->where('del_flag', '<>', 1)
                ->get();
             foreach ($subs as $sub)
             {
                 $pt = isset($sub['pt']) ? $sub['pt'] : [];
                 $pind = array_search($id, $pt);
                 if ($pind !== false)
                 {
                     $tail = array_slice($pt, $pind);
                     $pt = array_merge($updValues['pt'], $tail);
                     DB::collection('document_' . $project_key)->where('_id', $sub['_id']->__toString())->update(['pt' => $pt]);
                 }
             }
        }

        $document = DB::collection('document_' . $project_key)->where('_id', $id)->first();
        return Response()->json(['ecode' => 0, 'data' => parent::arrange($document)]);

It seems like you call parent on a different method (arrange() instead of move()). Are you sure this is correct? If so, you might want to change this to $this->arrange().

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  string  $project_key
     * @param  string  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($project_key, $id)
    {
        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$document)
        {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        if (isset($document['d']) && $document['d'] === 1)

This code seems to be duplicated across your project.

        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project'))
            {
                return Response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

            }
        }
        else
        {
            if (!$this->isPermissionAllowed($project_key, 'manage_project') && $document['uploader']['id'] !== $this->user->id)
            {
                return Response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);
            }
        }

        DB::collection('document_' . $project_key)->where('_id', $id)->update([ 'del_flag' => 1 ]);

        if (isset($document['d']) && $document['d'] === 1)

This code seems to be duplicated across your project.

        {
            DB::collection('document_' . $project_key)->whereRaw([ 'pt' => $id ])->update([ 'del_flag' => 1 ]);
        }

        return Response()->json(['ecode' => 0, 'data' => [ 'id' => $id ]]);
    }

    /**
     * Upload file.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  String  $project_key
     * @param  String  $directory
     * @return \Illuminate\Http\Response
     */
    public function upload(Request $request, $project_key, $directory)
    {
        set_time_limit(0);

        if (!is_writable(config('filesystems.disks.local.root', '/tmp')))
        {
            throw new \UnexpectedValueException('the user has not the writable permission to the directory.', -15103);
        }

        if ($directory !== '0')
        {
            $isExists = DB::collection('document_' . $project_key)
                ->where('_id', $directory)
                ->where('d', 1)
                ->where('del_flag', '<>', 1)
                ->exists();
            if (!$isExists)
            {
                throw new \UnexpectedValueException('the parent directory does not exist.', -11905);
            }
        }

        $fields = array_keys($_FILES);
        $field = array_pop($fields);
        if (empty($_FILES) || $_FILES[$field]['error'] > 0)

This code seems to be duplicated across your project.

        {
            throw new \UnexpectedValueException('upload file errors.', -11903);
        }

        $basename = md5(microtime() . $_FILES[$field]['name']);
        $sub_save_path = config('filesystems.disks.local.root', '/tmp') . '/' . substr($basename, 0, 2) . '/';
        if (!is_dir($sub_save_path))
        {
            @mkdir($sub_save_path);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        $filename = $sub_save_path . $basename;
        move_uploaded_file($_FILES[$field]['tmp_name'], $filename);

        $data = [];

        $thumbnail_size = 190;
        if (in_array($_FILES[$field]['type'], [ 'image/jpeg', 'image/jpg', 'image/png', 'image/gif' ]))

This code seems to be duplicated across your project.

        {
            $size = getimagesize($filename);
            $width = $size[0]; $height = $size[1];
            $scale = $width < $height ? $height : $width;
            $thumbnails_width = floor($thumbnail_size * $width / $scale);
            $thumbnails_height = floor($thumbnail_size * $height / $scale);
            $thumbnails_filename = $filename . '_thumbnails';
            if ($scale <= $thumbnail_size)
            {
                @copy($filename, $thumbnails_filename);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            }
            else if ($_FILES[$field]['type'] == 'image/jpeg' || $_FILES[$field]['type'] == 'image/jpg')
            {
                $src_image = imagecreatefromjpeg($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagejpeg($dst_image, $thumbnails_filename);
            }
            else if ($_FILES[$field]['type'] == 'image/png')
            {
                $src_image = imagecreatefrompng($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagepng($dst_image, $thumbnails_filename);
            }
            else if ($_FILES[$field]['type'] == 'image/gif')
            {
                $src_image = imagecreatefromgif($filename);
                $dst_image = imagecreatetruecolor($thumbnails_width, $thumbnails_height);
                imagecopyresized($dst_image, $src_image, 0, 0, 0, 0, $thumbnails_width, $thumbnails_height, $width, $height);
                imagegif($dst_image, $thumbnails_filename);
            }
            else
            {
                @copy($filename, $thumbnails_filename);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            }
            $data['thumbnails_index'] = $basename . '_thumbnails';
            // move the thumbnails
            @rename($thumbnails_filename, $sub_save_path . $data['thumbnails_index']);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        $fname = $_FILES[$field]['name'];
        $extname = '';
        $segments = explode('.', $fname);
        if (count($segments) > 1)
        {
            $extname = '.' . array_pop($segments);
            $fname = implode('.', $segments);
        }
        $i = 1;
        while(true)
        {
            $isExists = DB::collection('document_' . $project_key)
                ->where('parent', $directory)
                ->where('name', $fname . ($i < 2 ? '' : ('(' . $i . ')')) . $extname)
                ->where('d', '<>', 1)
                ->where('del_flag', '<>', 1)
                ->exists();
            if (!$isExists)
            {
                break;
            }
            $i++;
        }
        $data['name'] = $fname . ($i < 2 ? '' : ('(' . $i . ')')) . $extname;

        $data['pt']      = $this->getParentTree($project_key, $directory);
        $data['parent']  = $directory;
        $data['size']    = $_FILES[$field]['size'];
        $data['type']    = $_FILES[$field]['type'];
        $data['index']   = $basename;

        $data['uploader'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        $data['uploaded_at'] = time();

        $id = DB::collection('document_' . $project_key)->insertGetId($data);
        $document = DB::collection('document_' . $project_key)->where('_id', $id)->first();

        return Response()->json(['ecode' => 0, 'data' => parent::arrange($document)]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

It seems like you call parent on a different method (arrange() instead of upload()). Are you sure this is correct? If so, you might want to change this to $this->arrange().

    }

    /**
     * Download Thumbnails file.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  String  $project_key
     * @param  String  $id
     * @return \Illuminate\Http\Response
     */
    public function downloadThumbnails(Request $request, $project_key, $id)
    {
        set_time_limit(0);

        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->first();
        if (!$document)
        {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($document['index'], 0, 2);
        $filename = $filepath . '/' . $document['thumbnails_index'];
        if (!file_exists($filename))
        {
            throw new \UnexpectedValueException('file does not exist.', -11904);
        }

        File::download($filename, $document['name']);
    }

    /**
     * Download file or directory.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  String  $project_key
     * @param  String  $id
     * @return \Illuminate\Http\Response
     */
    public function download(Request $request, $project_key, $id)
    {
        set_time_limit(0);

        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->first();
        if (!$document)
        {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        if (isset($document['d']) && $document['d'] === 1)
        {
            $this->downloadFolder($project_key, $document['name'], $id);
        }
        else
        {
            $this->downloadFile($document['name'], $document['index']);
        }
    }

    /**
     * Download file.
     *
     * @param  String  $name
     * @param  String  $directory
     * @return \Illuminate\Http\Response
     */
    public function downloadFolder($project_key, $name, $directory)
    {
        setlocale(LC_ALL, 'zh_CN.UTF-8'); 

        $basepath = '/tmp/' . md5($this->user->id . microtime());
        @mkdir($basepath);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $this->contructFolder($project_key, $basepath . '/' . $name, $directory);

        $filename = $basepath . '/' . $name . '.zip';

        Zipper::make($filename)->folder($name)->add($basepath . '/' . $name);
        Zipper::close();

        File::download($filename, $name . '.zip');

        exec('rm -rf ' . $basepath);
    }

    /**
     * contruct file folder.
     *
     * @param  String  $fullpath
     * @param  String  $id
     * @return void
     */
    public function contructFolder($project_key, $fullpath, $id)
    {
        @mkdir($fullpath);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $documents = DB::collection('document_' . $project_key)
            ->where('parent', $id)
            ->where('del_flag', '<>', 1)
            ->get();
        foreach ($documents as $doc)
        {
            if (isset($doc['d']) && $doc['d'] === 1)
            {
                $this->contructFolder($project_key, $fullpath . '/' . $doc['name'], $doc['_id']->__toString());
            }
            else
            {
                $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($doc['index'], 0, 2);
                $filename = $filepath . '/' . $doc['index'];
                if (file_exists($filename))
                {
                    @copy($filename, $fullpath . '/' . $doc['name']);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                }
            }
        }
    }

    /**
     * Download file.
     *
     * @param  String  $name
     * @param  String  $index
     * @return \Illuminate\Http\Response
     */
    public function downloadFile($name, $index)

This method seems to be duplicated in your project.

    {
        $filepath = config('filesystems.disks.local.root', '/tmp') . '/' . substr($index, 0, 2);
        $filename = $filepath . '/' . $index;
        if (!file_exists($filename))
        {
            throw new \UnexpectedValueException('file does not exist.', -11904);
        }

        File::download($filename, $name);
    }

    /**
     * favorite action.
     *
     * @param  string  $project_key
     * @param  string  $id
     * @return \Illuminate\Http\Response
     */
    public function favorite(Request $request, $project_key, $id)

This method seems to be duplicated in your project.

    {
        $document = DB::collection('document_' . $project_key)
            ->where('_id', $id)
            ->where('del_flag', '<>', 1)
            ->first();
        if (!$document)
        {
            throw new \UnexpectedValueException('the object does not exist.', -11902);
        }

        DocumentFavorites::where('did', $id)->where('user.id', $this->user->id)->delete();

        $cur_user = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];

        $flag = $request->input('flag');
        if (isset($flag) && $flag)
        {
            DocumentFavorites::create([ 'project_key' => $project_key, 'did' => $id, 'user' => $cur_user ]);
        }

        return Response()->json(['ecode' => 0, 'data' => ['id' => $id, 'user' => $cur_user, 'favorited' => $flag]]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }
}