UserSshKeyCreateCommandTest::testSimpleCase() - Code Metrics - Inspection of "CAMN-10" - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a5a038...08ae9a )

by Ricardo

created 2021-02-26 20:52 UTC

UserSshKeyCreateCommandTest::testSimpleCase() A

↳ Parent: UserSshKeyCreateCommandTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	18
Ratio	90 %

Importance

Changes

Metric	Value
dl	18
loc	20
rs	9.6
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * This file is part of Fabrica.
 *
 * (c) Alexandre Salomé <[email protected]>
 * (c) Julien DIDIER <[email protected]>
 *
 * This source file is subject to the GPL license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Fabrica\Bundle\CoreBundle\Tests\Command;

use Fabrica\Bundle\CoreBundle\Test\CommandTestCase;

class UserSshKeyCreateCommandTest extends CommandTestCase
{
    protected $client;

    protected function setUp(): void
    {
        $this->client = self::createClient();
        $this->client->startIsolation();
    }

    public function tearDown(): void
    {
        $this->client->stopIsolation();
    }

    public function testSimpleCase()

    {
        list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-ssh-key-create "alice" foo bar');
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        $this->assertEquals("The key named foo was successfully added to user alice!\n", $output);

        $em = $this->client->getKernel()->getContainer()->get('doctrine')->getManager();

        $userSshKey = $em->getRepository('FabricaCoreBundle:UserSshKey')->findOneBy(
            array(
            'title' => 'foo'
            )
        );

        $this->assertInstanceOf('Fabrica\Models\Code\UserSshKey', $userSshKey);

        $this->assertEquals('alice', $userSshKey->getUser()->getUsername());
        $this->assertEquals('foo', $userSshKey->getTitle());
        $this->assertEquals('bar', $userSshKey->getContent());
    }

    public function testNonExistingUser()
    {
        list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-ssh-key-create "foo" bar baz');
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        $this->assertContains('User with username "foo" not found', $output);
    }
}


1		<?php
2
3		/**
4		* This file is part of Fabrica.
5		*
6		* (c) Alexandre Salomé <[email protected]>
7		* (c) Julien DIDIER <[email protected]>
8		*
9		* This source file is subject to the GPL license that is bundled
10		* with this source code in the file LICENSE.
11		*/
12
13		namespace Fabrica\Bundle\CoreBundle\Tests\Command;
14
15		use Fabrica\Bundle\CoreBundle\Test\CommandTestCase;
16
17		class UserSshKeyCreateCommandTest extends CommandTestCase
18		{
19		protected $client;
20
21		protected function setUp(): void
22		{
23		$this->client = self::createClient();
24		$this->client->startIsolation();
25		}
26
27		public function tearDown(): void
28		{
29		$this->client->stopIsolation();
30		}
31
32	View Code Duplication	public function testSimpleCase()
		0 ignored issues – show Duplication introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-ssh-key-create "alice" foo bar');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report The assignment to `$statusCode` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
35
36		$this->assertEquals("The key named foo was successfully added to user alice!\n", $output);
37
38		$em = $this->client->getKernel()->getContainer()->get('doctrine')->getManager();
39
40		$userSshKey = $em->getRepository('FabricaCoreBundle:UserSshKey')->findOneBy(
41		array(
42		'title' => 'foo'
43		)
44		);
45
46		$this->assertInstanceOf('Fabrica\Models\Code\UserSshKey', $userSshKey);
47
48		$this->assertEquals('alice', $userSshKey->getUser()->getUsername());
49		$this->assertEquals('foo', $userSshKey->getTitle());
50		$this->assertEquals('bar', $userSshKey->getContent());
51		}
52
53		public function testNonExistingUser()
54		{
55		list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-ssh-key-create "foo" bar baz');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report The assignment to `$statusCode` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
56
57		$this->assertContains('User with username "foo" not found', $output);
58		}
59		}
60

SierraTecnologia / fabrica

Push — master ( a5a038...08ae9a )

UserSshKeyCreateCommandTest::testSimpleCase() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like