UserRoleCreateCommandTest - Code Metrics - Inspection of "CAMN-10" - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a5a038...08ae9a )

by Ricardo

created 2021-02-26 20:52 UTC

UserRoleCreateCommandTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	28.13 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	1
dl	18
loc	64
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	tearDown()	0	4	1
A	testProjectRole()	18	20	1
A	testGlobalRole()	0	13	1
A	testProjectRoleIncorrect()	0	6	1
A	testGlobalRoleIncorrect()	0	6	1

How to fix Duplicated Code

<?php

/**
 * This file is part of Fabrica.
 *
 * (c) Alexandre Salomé <[email protected]>
 * (c) Julien DIDIER <[email protected]>
 *
 * This source file is subject to the GPL license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Fabrica\Bundle\CoreBundle\Tests\Command;

use Fabrica\Bundle\CoreBundle\Test\CommandTestCase;

class UserRoleCreateCommandTest extends CommandTestCase
{
    protected $client;

    protected function setUp(): void
    {
        $this->client = self::createClient();
        $this->client->startIsolation();
    }

    public function tearDown(): void
    {
        $this->client->stopIsolation();
    }

    public function testProjectRole()

    {
        list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Developer barbaz');
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        $this->assertEquals("Added successfully Bob as Developer to Barbaz\n", $output);

        $em = $this->client->getKernel()->getContainer()->get('doctrine')->getManager();

        $user    = $em->getRepository('FabricaCoreBundle:User')->findOneByUsername('bob');
        $role    = $em->getRepository('FabricaCoreBundle:Role')->findOneByName('Developer');
        $project = $em->getRepository('FabricaCoreBundle:Project')->findOneBySlug('barbaz');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $userRole = $em->getRepository('FabricaCoreBundle:UserRoleProject')->findOneBy(
            array(
            'user' => $user,
            'role' => $role,
            )
        );

        $this->assertInstanceOf('Fabrica\Models\Code\UserRoleProject', $userRole);
    }

    public function testGlobalRole()
    {
        list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Administrator');
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        $this->assertEquals("Added successfully Bob as Administrator\n", $output);

        $em = $this->client->getKernel()->getContainer()->get('doctrine')->getManager();

        $user    = $em->getRepository('FabricaCoreBundle:User')->findOneByUsername('bob');
        $role    = $em->getRepository('FabricaCoreBundle:Role')->findOneByName('Administrator');

        $this->assertTrue($user->getGlobalRoles()->contains($role));
    }

    public function testProjectRoleIncorrect()
    {
        list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Administrator barbaz');
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        $this->assertContains("Cannot add a global role to a project", $output);
    }

    public function testGlobalRoleIncorrect()
    {
        list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Developer');
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        $this->assertContains("Cannot add a project role without project slug", $output);
    }
}


1		<?php
2
3		/**
4		* This file is part of Fabrica.
5		*
6		* (c) Alexandre Salomé <[email protected]>
7		* (c) Julien DIDIER <[email protected]>
8		*
9		* This source file is subject to the GPL license that is bundled
10		* with this source code in the file LICENSE.
11		*/
12
13		namespace Fabrica\Bundle\CoreBundle\Tests\Command;
14
15		use Fabrica\Bundle\CoreBundle\Test\CommandTestCase;
16
17		class UserRoleCreateCommandTest extends CommandTestCase
18		{
19		protected $client;
20
21		protected function setUp(): void
22		{
23		$this->client = self::createClient();
24		$this->client->startIsolation();
25		}
26
27		public function tearDown(): void
28		{
29		$this->client->stopIsolation();
30		}
31
32	View Code Duplication	public function testProjectRole()
		0 ignored issues – show Duplication introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Developer barbaz');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report The assignment to `$statusCode` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
35
36		$this->assertEquals("Added successfully Bob as Developer to Barbaz\n", $output);
37
38		$em = $this->client->getKernel()->getContainer()->get('doctrine')->getManager();
39
40		$user = $em->getRepository('FabricaCoreBundle:User')->findOneByUsername('bob');
41		$role = $em->getRepository('FabricaCoreBundle:Role')->findOneByName('Developer');
42		$project = $em->getRepository('FabricaCoreBundle:Project')->findOneBySlug('barbaz');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report `$project` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
43		$userRole = $em->getRepository('FabricaCoreBundle:UserRoleProject')->findOneBy(
44		array(
45		'user' => $user,
46		'role' => $role,
47		)
48		);
49
50		$this->assertInstanceOf('Fabrica\Models\Code\UserRoleProject', $userRole);
51		}
52
53		public function testGlobalRole()
54		{
55		list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Administrator');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report The assignment to `$statusCode` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
56
57		$this->assertEquals("Added successfully Bob as Administrator\n", $output);
58
59		$em = $this->client->getKernel()->getContainer()->get('doctrine')->getManager();
60
61		$user = $em->getRepository('FabricaCoreBundle:User')->findOneByUsername('bob');
62		$role = $em->getRepository('FabricaCoreBundle:Role')->findOneByName('Administrator');
63
64		$this->assertTrue($user->getGlobalRoles()->contains($role));
65		}
66
67		public function testProjectRoleIncorrect()
68		{
69		list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Administrator barbaz');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report The assignment to `$statusCode` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
70
71		$this->assertContains("Cannot add a global role to a project", $output);
72		}
73
74		public function testGlobalRoleIncorrect()
75		{
76		list($statusCode ,$output) = $this->runCommand($this->client, 'fabrica:user-role-create bob Developer');
		0 ignored issues – show Unused Code introduced 2020-07-25 16:42 UTC by Report Bug Copy Issue Report The assignment to `$statusCode` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
77
78		$this->assertContains("Cannot add a project role without project slug", $output);
79		}
80		}
81

SierraTecnologia / fabrica

Push — master ( a5a038...08ae9a )

UserRoleCreateCommandTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like