Fabrica\Http\Api\IssueController::update()

Complexity

Conditions	30
Paths	107

Size

Total Lines

104

Duplication

Lines	54
Ratio	51.92 %

Importance

Changes

0

<?php
    public function update(Request $request, $project_key, $id)
    {
        if (!$this->isPermissionAllowed($project_key, 'edit_issue') && !$this->isPermissionAllowed($project_key, 'exec_workflow')) {

This code seems to be duplicated across your project.

            return response()->json(['ecode' => -10002, 'emsg' => 'permission denied.']);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

        }

        if (!$request->all()) {
            return $this->show($project_key, $id); 
        }

        $table = 'issue_' . $project_key;
        $issue = DB::collection($table)->find($id);
        if (!$issue) {
            throw new \UnexpectedValueException('the issue does not exist or is not in the project.', -11103);
        }

        $schema = Provider::getSchemaByType($request->input('type') ?: $issue['type']);
        if (!$schema) {

The expression $schema of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new \UnexpectedValueException('the schema of the type is not existed.', -11101);
        }

        if (!$this->requiredCheck($schema, $request->all(), 'update')) {
            throw new \UnexpectedValueException('the required field is empty.', -11121);
        }

        // handle timetracking
        $updValues = [];
        foreach ($schema as $field)

This code seems to be duplicated across your project.

        {
            $fieldValue = $request->input($field['key']);
            if (!isset($fieldValue) || !$fieldValue) {
                continue;
            }

            if ($field['type'] == 'TimeTracking') {
                if (!$this->ttCheck($fieldValue)) {
                    throw new \UnexpectedValueException('the format of timetracking field is incorrect.', -11102);
                }

                $updValues[$field['key']] = $this->ttHandle($fieldValue);
                $updValues[$field['key'] . '_m'] = $this->ttHandleInM($updValues[$field['key']]);
            }
            else if ($field['type'] == 'DatePicker' || $field['type'] == 'DateTimePicker') {
                if ($this->isTimestamp($fieldValue) === false) {
                    throw new \UnexpectedValueException('the format of datepicker field is incorrect.', -11122);
                }
            }
            else if ($field['type'] == 'SingleUser') {
                $user_info = Sentinel::findById($fieldValue);
                if ($user_info) {
                    $updValues[$field['key']] = [ 'id' => $fieldValue, 'name' => $user_info->first_name, 'email' => $user_info->email ];
                }
            }
            else if ($field['type'] == 'MultiUser') {
                $user_ids = $fieldValue;
                $updValues[$field['key']] = [];
                $new_user_ids = [];
                foreach ($user_ids as $uid)
                {
                    $user_info = Sentinel::findById($uid);
                    if ($user_info) {
                        array_push($updValues[$field['key']], [ 'id' => $uid, 'name' => $user_info->first_name, 'email' => $user_info->email ]);
                    }
                    $new_user_ids[] = $uid;
                }
                $updValues[$field['key'] . '_ids'] = $new_user_ids;
            }
        }

        $assignee_id = $request->input('assignee');
        if ($assignee_id) {
            if ((!isset($issue['assignee']) || (isset($issue['assignee']) && $assignee_id != $issue['assignee']['id'])) && !$this->isPermissionAllowed($project_key, 'assigned_issue', $assignee_id)) {
                return response()->json(['ecode' => -11118, 'emsg' => 'the assigned user has not assigned-issue permission.']);
            }

            $user_info = Sentinel::findById($assignee_id);
            if ($user_info) {
                $assignee = [ 'id' => $assignee_id, 'name' => $user_info->first_name, 'email' => $user_info->email ];
                $updValues['assignee'] = $assignee;
            }
        }

        $valid_keys = $this->getValidKeysBySchema($schema);
        $updValues = $updValues + array_only($request->all(), $valid_keys);
        if (!$updValues) {

The expression $updValues of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->show($project_key, $id);
        }

        $updValues['modifier'] = [ 'id' => $this->user->id, 'name' => $this->user->first_name, 'email' => $this->user->email ];
        $updValues['updated_at'] = time();

        DB::collection($table)->where('_id', $id)->update($updValues);

        // add to histroy table
        $snap_id = Provider::snap2His($project_key, $id, $schema, array_keys(array_only($request->all(), $valid_keys)));
        // trigger event of issue edited
        Event::fire(new IssueEvent($project_key, $id, $updValues['modifier'], [ 'event_key' => 'edit_issue', 'snap_id' => $snap_id ]));
        // create the Labels for project
        if (isset($updValues['labels']) && $updValues['labels']) {
            $this->createLabels($project_key, $updValues['labels']);
        }

        return $this->show($project_key, $id); 
    }