ExcelTrait::arrangeExcel() - Code Metrics - SierraTecnologia/fabrica - Measure and Improve Code Quality continuously with Scrutinizer

ExcelTrait::arrangeExcel() C
last analyzed 2021-05-27 22:56 UTC

↳ Parent: ExcelTrait

Complexity

Conditions	12
Paths	38

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	54
rs	6.9666
c	0
b	0
f	0
cc	12
nc	38
nop	2

How to fix Long Method Complexity

<?php

namespace Fabrica\Http\Api;

trait ExcelTrait
{
    /**
     * remove the empty row and trim the cell value
     *
     * @param  array $data
     * @return array
     */
    public function trimExcel($data)
    {
        if (!is_array($data)) {
            return [];
        }

        // trim the cell value
        foreach($data as $k1 => $val)
        {
            foreach($val as $k2 => $val2)
            {
                $data[$k1][$k2] = trim($val2);
            }
        }

        // delete the empty row
        $data = array_filter(
            $data, function ($v) {
                return array_filter($v); 
            }
        );
        // delete the empty column
        $data = array_filter(
            $this->rotate($data), function ($v) {
                return array_filter($v); 
            }
        );
        // rotate the array
        $data = $this->rotate($data);

        return $data;
    }

    /**
     * arrange the data 
     *
     * @param  array $data
     * @param  array $fields
     * @return array
     */
    public function arrangeExcel($data, $fields)
    {
        $data = $this->trimExcel($data);

        $header_index = 0;
        while(true)
        {
            $header = array_shift($data);
            if (!$header) {
                throw new \UnexpectedValueException('表头定位错误。', -11142);
            }

            if (is_array($header)) {
                if (in_array($header[0], $fields)) {
                    break;
                }
                if (++$header_index > 5) {
                    throw new \UnexpectedValueException('表头定位错误。', -11142);
                }
            }
        }

        // the first row is used for the issue keys
        if (array_search('', $header) !== false) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            throw new \UnexpectedValueException('表头不能有空值。', -11143);
        }
        // check the header title
        if (count($header) !== count(array_unique($header))) {
            throw new \UnexpectedValueException('表头不能有重复列。', -11144);
        }

        $field_keys = [];
        foreach($header as $field)
        {
            $tmp = array_search($field, $fields);
            if ($tmp === false) {
                throw new \UnexpectedValueException('表头有不明确列。', -11145);
            }
            $field_keys[] = $tmp;
        }

        $new_data = [];
        foreach ($data as $item)
        {
            $tmp = [];
            foreach ($item as $key => $val)
            {
                $tmp[$field_keys[$key]] = $val;
            }
            $new_data[] = $tmp;
        }

        return $new_data;
    }

    /**
     * rotate the matrix 
     *
     * @param  array $matrix
     * @return array
     */
    public function rotate(array $matrix)
    {
        $ret = [];
        foreach($matrix as $val)
        {
            foreach($val as $k => $val2)
            {
                $ret[$k][] = $val2;
            }
        }
        return $ret;
    }
}


1			<?php
2
3			namespace Fabrica\Http\Api;
4
5			trait ExcelTrait
6			{
7			/**
8			* remove the empty row and trim the cell value
9			*
10			* @param array $data
11			* @return array
12			*/
13			public function trimExcel($data)
14			{
15			if (!is_array($data)) {
16			return [];
17			}
18
19			// trim the cell value
20			foreach($data as $k1 => $val)
21			{
22			foreach($val as $k2 => $val2)
23			{
24			$data[$k1][$k2] = trim($val2);
25			}
26			}
27
28			// delete the empty row
29			$data = array_filter(
30			$data, function ($v) {
31			return array_filter($v);
32			}
33			);
34			// delete the empty column
35			$data = array_filter(
36			$this->rotate($data), function ($v) {
37			return array_filter($v);
38			}
39			);
40			// rotate the array
41			$data = $this->rotate($data);
42
43			return $data;
44			}
45
46			/**
47			* arrange the data
48			*
49			* @param array $data
50			* @param array $fields
51			* @return array
52			*/
53			public function arrangeExcel($data, $fields)
54			{
55			$data = $this->trimExcel($data);
56
57			$header_index = 0;
58			while(true)
59			{
60			$header = array_shift($data);
61			if (!$header) {
62			throw new \UnexpectedValueException('表头定位错误。', -11142);
63			}
64
65			if (is_array($header)) {
66			if (in_array($header[0], $fields)) {
67			break;
68			}
69			if (++$header_index > 5) {
70			throw new \UnexpectedValueException('表头定位错误。', -11142);
71			}
72			}
73			}
74
75			// the first row is used for the issue keys
76			if (array_search('', $header) !== false) {
			0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The variable `$header` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
77			throw new \UnexpectedValueException('表头不能有空值。', -11143);
78			}
79			// check the header title
80			if (count($header) !== count(array_unique($header))) {
81			throw new \UnexpectedValueException('表头不能有重复列。', -11144);
82			}
83
84			$field_keys = [];
85			foreach($header as $field)
86			{
87			$tmp = array_search($field, $fields);
88			if ($tmp === false) {
89			throw new \UnexpectedValueException('表头有不明确列。', -11145);
90			}
91			$field_keys[] = $tmp;
92			}
93
94			$new_data = [];
95			foreach ($data as $item)
96			{
97			$tmp = [];
98			foreach ($item as $key => $val)
99			{
100			$tmp[$field_keys[$key]] = $val;
101			}
102			$new_data[] = $tmp;
103			}
104
105			return $new_data;
106			}
107
108			/**
109			* rotate the matrix
110			*
111			* @param array $matrix
112			* @return array
113			*/
114			public function rotate(array $matrix)
115			{
116			$ret = [];
117			foreach($matrix as $val)
118			{
119			foreach($val as $k => $val2)
120			{
121			$ret[$k][] = $val2;
122			}
123			}
124			return $ret;
125			}
126			}
127

SierraTecnologia / fabrica

ExcelTrait::arrangeExcel() C last analyzed 2021-05-27 22:56 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like

ExcelTrait::arrangeExcel() C
last analyzed 2021-05-27 22:56 UTC