Fabrica\Http\Api\ConfigController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	47
Duplicated Lines	19.15 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	23	5
A	getPermissions()	8	8	5

<?php

namespace Fabrica\Http\Api;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Event;

use Fabrica\Http\Requests;
use Fabrica\Http\Api\Controller;

use DB;
use Fabrica\Project\Provider;
use Fabrica\Acl\Eloquent\RolePermissions;

class ConfigController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index($project_key)
    {
        $new_types = [];
        $types = Provider::getTypeList($project_key); 
        foreach ($types as $type)
        {
            if (isset($type->disabled) && $type->disabled) {
                continue;
            }
            $type->screen = $type->screen;
            $type->workflow = $type->workflow;
            $new_types[] = $type;
        }

        $priorities = Provider::getPriorityList($project_key);
        $roles = Provider::getRoleList($project_key);
        foreach($roles as $role)
        {
            $role->permissions = $this->getPermissions($project_key, $role->id);
        }

        return response()->json([ 'ecode' => 0, 'data' => [ 'types' => $new_types, 'roles' => $roles, 'priorities' => $priorities ] ]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }

    /**
     * get permissions by project_key and roleid.
     *
     * @param  string $project_key
     * @param  string $role_id
     * @return array
     */
    public function getPermissions($project_key, $role_id)

This method seems to be duplicated in your project.

    {
        $rp = RolePermissions::where([ 'project_key' => $project_key, 'role_id' => $role_id ])->first();
        if (!$rp && $project_key !== '$_sys_$') {
            $rp = RolePermissions::where([ 'project_key' => '$_sys_$', 'role_id' => $role_id ])->first();
        }
        return $rp && isset($rp->permissions) ? $rp->permissions : [];
    }
}