ActivityService::log() - Code Metrics - SierraTecnologia/Transmissor - Measure and Improve Code Quality continuously with Scrutinizer

ActivityService::log() A
last analyzed 2020-10-20 08:55 UTC

↳ Parent: ActivityService

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0

<?php

namespace Transmissor\Services;

use Porteiro\Models\Activity;

class ActivityService
{
    public function __construct(Activity $model)
    {
        $this->model = $model;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * All activities
     *
     * @return Collection
     */
    public function getByUser($userId, $paginate = null)
    {
        $query = $this->model->where('user_id', $userId);

        if (!is_null($paginate)) {
            return $query->paginate($paginate);
        }

        return $query->get();
    }

    /**
     * Create an activity record
     *
     * @param  string $description
     * @return Activity
     */
    public function log($description = '')
    {
        $payload = [
            'user_id' => auth()->id(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'description' => $description,
            'request' => json_encode(
                [
                'url' => request()->url(),
                'method' => request()->method(),
                'query' => request()->fullUrl(),
                'secure' => request()->secure(),
                'client_ip' => request()->ip(),
                'payload' => request()->all(),
                ]
            ),
        ];

        return $this->model->create($payload);
    }
}


1			<?php
2
3			namespace Transmissor\Services;
4
5			use Porteiro\Models\Activity;
6
7			class ActivityService
8			{
9			public function __construct(Activity $model)
10			{
11			$this->model = $model;
			0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
12			}
13
14			/**
15			* All activities
16			*
17			* @return Collection
18			*/
19			public function getByUser($userId, $paginate = null)
20			{
21			$query = $this->model->where('user_id', $userId);
22
23			if (!is_null($paginate)) {
24			return $query->paginate($paginate);
25			}
26
27			return $query->get();
28			}
29
30			/**
31			* Create an activity record
32			*
33			* @param string $description
34			* @return Activity
35			*/
36			public function log($description = '')
37			{
38			$payload = [
39			'user_id' => auth()->id(),
			0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The method `id` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
40			'description' => $description,
41			'request' => json_encode(
42			[
43			'url' => request()->url(),
44			'method' => request()->method(),
45			'query' => request()->fullUrl(),
46			'secure' => request()->secure(),
47			'client_ip' => request()->ip(),
48			'payload' => request()->all(),
49			]
50			),
51			];
52
53			return $this->model->create($payload);
54			}
55			}
56

SierraTecnologia / Transmissor

ActivityService::log() A last analyzed 2020-10-20 08:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ActivityService::log() A
last analyzed 2020-10-20 08:55 UTC