ChatController::index() - Code Metrics - SierraTecnologia/Transmissor - Measure and Improve Code Quality continuously with Scrutinizer

ChatController::index() A
last analyzed 2020-10-20 08:55 UTC

↳ Parent: ChatController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0

<?php

namespace Transmissor\Http\Api;

use Illuminate\Http\Request;

class ChatController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->middleware('auth');
    }
    
    /**
     * Show the application dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $conversations = Chat::conversation(Chat::conversations()->conversation)
          ->for(auth()->user())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
          ->get()
          ->toArray()['data'];
        $conversations = array_pluck($conversations, 'id');
        return view('home', compact('conversations'));
    }

    public function history($toId)
    {
        $user = Auth::getToken();
        $conversation = Chat::conversations()->between($user, User::find($toId));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function send($toId)
    {
        $user = Auth::getToken();
        $message = Chat::message('Hello')
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            ->from($user)
            ->to($conversation)

            ->send();
    }
}


1			<?php
2
3			namespace Transmissor\Http\Api;
4
5			use Illuminate\Http\Request;
6
7			class ChatController extends Controller
8			{
9			/**
10			* Create a new controller instance.
11			*
12			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
13			*/
14			public function __construct()
15			{
16			$this->middleware('auth');
17			}
18
19			/**
20			* Show the application dashboard.
21			*
22			* @return \Illuminate\Http\Response
23			*/
24			public function index(Request $request)
25			{
26			$conversations = Chat::conversation(Chat::conversations()->conversation)
27			->for(auth()->user())
			0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28			->get()
29			->toArray()['data'];
30			$conversations = array_pluck($conversations, 'id');
31			return view('home', compact('conversations'));
32			}
33
34			public function history($toId)
35			{
36			$user = Auth::getToken();
37			$conversation = Chat::conversations()->between($user, User::find($toId));
			0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report `$conversation` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
38			}
39
40			public function send($toId)
41			{
42			$user = Auth::getToken();
43			$message = Chat::message('Hello')
			0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
44			->from($user)
45			->to($conversation)
			0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The variable `$conversation` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
46			->send();
47			}
48			}
49

SierraTecnologia / Transmissor

ChatController::index() A last analyzed 2020-10-20 08:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ChatController::index() A
last analyzed 2020-10-20 08:55 UTC