NotificationController - Code Metrics - SierraTecnologia/Transmissor - Measure and Improve Code Quality continuously with Scrutinizer

NotificationController A
last analyzed 2020-10-20 08:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	16.13 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	10
loc	62
rs	10
c	0
b	0
f	0
wmc	6
lcom	1
cbo	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	7	1
A	search()	0	5	1
A	read()	0	7	1
A	delete()	10	10	2

How to fix Duplicated Code

<?php

namespace Transmissor\Http\Controllers\User;

use Auth;
use Illuminate\Http\Request;
use Transmissor\Http\Controllers\User\Controller;
use Transmissor\Services\NotificationService;

class NotificationController extends Controller
{
    public function __construct(NotificationService $notificationService)
    {
        $this->service = $notificationService;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

    {
        $notifications = $this->service->userBasedPaginated(Auth::id());
        $currentActor = Auth::user();
        return view('transmissor::users.notifications.index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('notifications', $notifications)->with('currentActor', $currentActor);
    }

    /**
     * Display a listing of the resource searched.
     *
     * @return \Illuminate\Http\Response
     */
    public function search(Request $request)
    {
        $notifications = $this->service->search($request->search, Auth::id());
        return view('transmissor::users.notifications.index')->with('notifications', $notifications);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function read($uuid)
    {
        $notification = $this->service->findByUuid($uuid);
        $this->service->markAsRead($notification->id);

        return view('transmissor::users.notifications.show')->with('notification', $notification);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function delete($id)

    {
        $result = $this->service->destroy($id);

        if ($result) {
            return redirect('user/notifications')->with('message', 'Successfully deleted');
        }

        return redirect('user/notifications')->with('errors', ['Failed to delete']);
    }
}


1		<?php
2
3		namespace Transmissor\Http\Controllers\User;
4
5		use Auth;
6		use Illuminate\Http\Request;
7		use Transmissor\Http\Controllers\User\Controller;
8		use Transmissor\Services\NotificationService;
9
10		class NotificationController extends Controller
11		{
12		public function __construct(NotificationService $notificationService)
13		{
14		$this->service = $notificationService;
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The property `service` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15		}
16
17		/**
18		* Display a listing of the resource.
19		*
20		* @return \Illuminate\Http\Response
21		*/
22		public function index(Request $request)
		0 ignored issues – show Unused Code introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
23		{
24		$notifications = $this->service->userBasedPaginated(Auth::id());
25		$currentActor = Auth::user();
26		return view('transmissor::users.notifications.index')
		0 ignored issues – show Bug introduced 2020-09-25 18:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		->with('notifications', $notifications)->with('currentActor', $currentActor);
28		}
29
30		/**
31		* Display a listing of the resource searched.
32		*
33		* @return \Illuminate\Http\Response
34		*/
35		public function search(Request $request)
36		{
37		$notifications = $this->service->search($request->search, Auth::id());
38		return view('transmissor::users.notifications.index')->with('notifications', $notifications);
		0 ignored issues – show Bug introduced 2020-09-25 18:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
39		}
40
41		/**
42		* Display the specified resource.
43		*
44		* @param int $id
		0 ignored issues – show Bug introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
45		* @return \Illuminate\Http\Response
46		*/
47		public function read($uuid)
48		{
49		$notification = $this->service->findByUuid($uuid);
50		$this->service->markAsRead($notification->id);
51
52		return view('transmissor::users.notifications.show')->with('notification', $notification);
		0 ignored issues – show Bug introduced 2020-09-25 18:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53		}
54
55		/**
56		* Remove the specified resource from storage.
57		*
58		* @param int $id
59		* @return \Illuminate\Http\Response
60		*/
61	View Code Duplication	public function delete($id)
		0 ignored issues – show Duplication introduced 2020-09-09 11:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$result = $this->service->destroy($id);
64
65		if ($result) {
66		return redirect('user/notifications')->with('message', 'Successfully deleted');
67		}
68
69		return redirect('user/notifications')->with('errors', ['Failed to delete']);
70		}
71		}
72

SierraTecnologia / Transmissor

NotificationController A last analyzed 2020-10-20 08:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

NotificationController A
last analyzed 2020-10-20 08:55 UTC