Transmissor\Http\Controllers\MessagesController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	113
Duplicated Lines	85.84 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	18	18	2
A	index()	0	9	2
A	create()	15	15	3
A	store()	49	49	2
A	createSecureMessage()	15	15	2

<?php

namespace Transmissor\Http\Controllers;

use App\Http\Requests\MessageRequest;
use App\Jobs\SendNotifyMail;
use App\Models\Message;
use App\Models\Participant;
use App\Models\Thread;
use App\Models\User;
use App\Phphub\Markdown\Markdown;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Input;
use Illuminate\Support\Facades\Session;

class MessagesController extends Controller
{
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $threads = Thread::participateBy(Auth::id());
        if (Auth::user()->newThreadsCount() == 0) {

The method newThreadsCount() does not seem to exist on object<Illuminate\Contracts\Auth\Authenticatable>.

            Auth::user()->message_count = 0;

Accessing message_count on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            Auth::user()->save();

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method save() does only exist in the following implementations of said interface: Illuminate\Foundation\Auth\User.

        }
        return view('transmissor::users.messages.index', compact('threads', 'currentUserId'));
    }

    public function show($id)

This method seems to be duplicated in your project.

    {
        $thread = Thread::findOrFail($id);
        $participant = $thread->participant();
        $messages = $thread->messages()->recent()->get();

        $this->authorize('show', $thread);

        // counters
        $unread_message_count = $thread->userUnreadMessagesCount(Auth::id());
        if ($unread_message_count > 0) {
            Auth::user()->message_count -= $unread_message_count;

Accessing message_count on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            Auth::user()->save();

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method save() does only exist in the following implementations of said interface: Illuminate\Foundation\Auth\User.

        }
        $thread->markAsRead(Auth::id());

        return view('transmissor::users.messages.show', compact('thread', 'participant', 'messages', 'unread_message_count'));
    }

    public function create($id = null)

This method seems to be duplicated in your project.

    {
        if ($id) {
            $recipient = User::findOrFail($id);
            $thread = Thread::between([$recipient->id, Auth::id()])->first();
            if ($thread) {
                return redirect()->route('profile.transmissor.messages.show', $thread->id);
            }
            return view('transmissor::users.messages.create', compact('recipient'));
        }

        $recipient = User::pluck('name');

        return view('transmissor::users.messages.create', compact('recipient'));
    }

    public function createSecureMessage($id)

This method seems to be duplicated in your project.

    {
        // @todo Fazer com as seguintes opcoes
        // timePraAutoDestruicao
        // Grava em disco ou só memoria
        // Criptografia ponta a ponta com limite de data
        $recipient = User::findOrFail($id);

        $thread = Thread::between([$recipient->id, Auth::id()])->first();
        if ($thread) {
            return redirect()->route('profile.transmissor.messages.show', $thread->id);
        }

        return view('transmissor::users.messages.create', compact('recipient'));
    }

    public function store(MessageRequest $request, Markdown $markdown)

This method seems to be duplicated in your project.

    {
        $recipient = User::findOrFail($request->recipient_id);

        if ($request->thread_id) {
            $thread = Thread::findOrFail($request->thread_id);
        } else {
            $subject = Auth::user()->name . ' 给 ' . $recipient->name . ' 的私信。';

Accessing name on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $thread = Thread::create(['subject' => $subject]);
        }

        // Message
        $message = $markdown->convertMarkdownToHtml($request->message);
        Message::create(
            [
                'messageable_type' => Thread::class,
                'messageable_id' => $thread->id,
                'actorable_type' => User::class,
                'actorable_id' => Auth::id(),
                'body' => $message
            ]
        );

        // Sender
        $participant = Participant::firstOrCreate(
            [
                'messageable_type' => Thread::class,
                'messageable_id' => $thread->id,
                'actorable_type' => User::class,
                'actorable_id' => Auth::id()
            ]
        );
        $participant->last_read = new Carbon;
        $participant->save();

        // Recipient
        $thread->addParticipant($recipient->id);

        // Notify user by Email
        $job = (new SendNotifyMail('new_message', Auth::user(), $recipient, null, null, $message))
                                ->delay(config('phphub.notify_delay'));
        dispatch($job);

        // notifications count
        $recipient->message_count++;
        $recipient->save();

        return redirect()->route('profile.transmissor.messages.show', $thread->id);
    }
}