Siravel\Notifications\Metrics\RouteRequested

Complexity

Total Complexity

18

Size/Duplication

Total Lines	130
Duplicated Lines	20 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	via()	14	14	4
B	toMail()	6	27	6
B	toSlack()	6	35	6
A	toArray()	0	6	1

<?php

namespace Siravel\Notifications\Metrics;

use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Messages\SlackMessage;
use Tracking\Models\Metrics\LarametricsRequest;

class RouteRequested extends Notification implements ShouldQueue
{
    use Queueable;

    private $larametricsRequest;

    private $requestInfo;

    /**
     * Create a new notification instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(LarametricsRequest $larametricsRequest)
    {
        $this->larametricsRequest = $larametricsRequest;

        $this->requestInfo = array(
            'id' => $larametricsRequest->id,
            'method' => $larametricsRequest->method,
            'uri' => $larametricsRequest->uri,
            'ip' => $larametricsRequest->ip,
            'execution_time' => floor(($larametricsRequest->end_time - $larametricsRequest->start_time) * 1000)
        );
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed $notifiable
     * @return array
     */
    public function via($notifiable)

This method seems to be duplicated in your project.

    {
        switch($notifiable->notify_by) {
        case 'email':
            return ['mail'];
            break;

break is not strictly necessary here and could be removed.

        case 'slack':
            return ['slack'];
            break;

break is not strictly necessary here and could be removed.

        case 'email_slack':
            return ['mail', 'slack'];
            break;

break is not strictly necessary here and could be removed.

        }
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)
    {
        $content = 'A route on ' . url('/') . ' was requested.';
        if($notifiable->filter !== '*' && !is_numeric($notifiable->filter)) {

This code seems to be duplicated across your project.

            $content .= " You're being notified because the route contains `" . $notifiable->filter . "`";
        }

        if(is_numeric($notifiable->filter)) {
            $content .= " You're being notified because the execution time exceeded your limit of " . $notifiable->filter . "ms.";
        }

        $alertColor = '#00B945';
        if(is_numeric($notifiable->filter) && $this->requestInfo['execution_time'] > intval($notifiable->filter)) {

This code seems to be duplicated across your project.

            $alertColor = '#BC001A';
        }

        return (new MailMessage)
            ->subject(env('LARAMETRICS_ROUTE_SUBJECT', '[Larametrics Alert] A route has been requested'))
            ->from(env('LARAMETRICS_FROM_EMAIL', 'alerts@larametrics.com'), env('LARAMETRICS_FROM_NAME', 'Larametrics Alerts'))
            ->view(
                'rica.larametrics::emails.route-requested', [
                'requestInfo' => $this->requestInfo,
                'content' => $content,
                'alertColor' => $alertColor
                ]
            );
    }

    public function toSlack($notifiable)
    {
        $content = 'A route on ' . url('/') . ' was requested.';
        if($notifiable->filter !== '*' && !is_numeric($notifiable->filter)) {

This code seems to be duplicated across your project.

            $content .= " You're being notified because the route contains `" . $notifiable->filter . "`";
        }

        if(is_numeric($notifiable->filter)) {
            $content .= " You're being notified because the execution time exceeded your limit of " . $notifiable->filter . "ms.";
        }

        $status = 'success';
        if(is_numeric($notifiable->filter) && $this->requestInfo['execution_time'] > intval($notifiable->filter)) {

This code seems to be duplicated across your project.

            $status = 'error';
        }

        $requestInfo = $this->requestInfo;

        return (new SlackMessage)
            ->{ $status }()
            ->attachment(
                function ($attachment) use ($requestInfo, $content) {
                    $attachment->title('Request #' . $requestInfo['id'], route('rica.larametrics::requests.show', $requestInfo['id']))
                        ->content($content)
                        ->fields(
                            [
                            'Method' => $requestInfo['method'],
                            'From IP' => $requestInfo['ip'],
                            'Requested URI' => $requestInfo['uri'],
                            'Execution Time' => $requestInfo['execution_time'] . 'ms'
                            ]
                        );
                }
            );
    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed $notifiable
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            //
        ];
    }
}